commit d9c9da536f0df0efa4dfd95e1797c0edc1950589
author Jason Molenda <jmolenda@apple.com> Wed Jul 20 03:49:02 2016 +0000
committer Jason Molenda <jmolenda@apple.com> Wed Jul 20 03:49:02 2016 +0000
tree f69ee6d0cd9556d8d94f65d3f5b222a594e84923
parent 074f8d7777c9eb13489982ecbfff198248f5ad57

Add a default-value bool flag pretty_print to the StructuredData Dump methods.
They will dump pretty-print (indentation, extra whitepsace) by default.  
I'll make a change to ProcessGDBRemote soon so it stops sending JSON strings
to debugserver pretty-printed; it's unnecessary extra bytes being sent between
the two.

llvm-svn: 276079

lldb/source/Core/StructuredData.cpp

diff --git a/lldb/source/Core/StructuredData.cpp b/lldb/source/Core/StructuredData.cpp
index efc104f..000dacb 100644
--- a/lldb/source/Core/StructuredData.cpp
+++ b/lldb/source/Core/StructuredData.cpp
@@ -203,50 +203,64 @@
 }
 
 void
-StructuredData::Object::DumpToStdout() const
+StructuredData::Object::DumpToStdout(bool pretty_print) const
 {
     StreamString stream;
-    Dump(stream);
+    Dump(stream, pretty_print);
     printf("%s\n", stream.GetString().c_str());
 }
 
 void
-StructuredData::Array::Dump(Stream &s) const
+StructuredData::Array::Dump(Stream &s, bool pretty_print) const
 {
     bool first = true;
-    s << "[\n";
-    s.IndentMore();
+    s << "[";
+    if (pretty_print)
+    {
+        s << "\n";
+        s.IndentMore();
+    }
     for (const auto &item_sp : m_items)
     {
         if (first)
+        {
             first = false;
+        }
         else
-            s << ",\n";
+        {
+            s << ",";
+            if (pretty_print)
+                s << "\n";
+        }
 
-        s.Indent();
-        item_sp->Dump(s);
+        if (pretty_print)
+            s.Indent();
+        item_sp->Dump(s, pretty_print);
     }
-    s.IndentLess();
-    s.EOL();
-    s.Indent();
+    if (pretty_print)
+    {
+        s.IndentLess();
+        s.EOL();
+        s.Indent();
+    }
     s << "]";
 }
 
 void
-StructuredData::Integer::Dump (Stream &s) const
+StructuredData::Integer::Dump (Stream &s, bool pretty_print) const
 {
     s.Printf ("%" PRIu64, m_value);
 }
 
 
 void
-StructuredData::Float::Dump (Stream &s) const
+StructuredData::Float::Dump (Stream &s, bool pretty_print) const
 {
     s.Printf ("%lg", m_value);
 }
 
 void
-StructuredData::Boolean::Dump (Stream &s) const
+StructuredData::Boolean::Dump (Stream &s, bool pretty_print) const
 {
     if (m_value == true)
         s.PutCString ("true");
@@ -256,7 +270,7 @@
 
 
 void
-StructuredData::String::Dump (Stream &s) const
+StructuredData::String::Dump (Stream &s, bool pretty_print) const
 {
     std::string quoted;
     const size_t strsize = m_value.size();
@@ -271,35 +285,47 @@
 }
 
 void
-StructuredData::Dictionary::Dump (Stream &s) const
+StructuredData::Dictionary::Dump (Stream &s, bool pretty_print) const
 {
     bool first = true;
-    s << "{\n";
-    s.IndentMore();
+    s << "{";
+    if (pretty_print)
+    {
+        s << "{\n";
+        s.IndentMore();
+    }
     for (const auto &pair : m_dict)
     {
         if (first)
             first = false;
         else
-            s << ",\n";
-        s.Indent();
+        {
+            s << ",";
+            if (pretty_print)
+                s << "\n";
+        }
+        if (pretty_print)
+            s.Indent();
         s << "\"" << pair.first.AsCString() << "\" : ";
-        pair.second->Dump(s);
+        pair.second->Dump(s, pretty_print);
     }
-    s.IndentLess();
-    s.EOL();
-    s.Indent();
+    if (pretty_print)
+    {
+        s.IndentLess();
+        s.EOL();
+        s.Indent();
+    }
     s << "}";
 }
 
 void
-StructuredData::Null::Dump (Stream &s) const
+StructuredData::Null::Dump (Stream &s, bool pretty_print) const
 {
     s << "null";
 }
 
 void
-StructuredData::Generic::Dump(Stream &s) const
+StructuredData::Generic::Dump(Stream &s, bool pretty_print) const
 {
     s << "0x" << m_object;
 }