commit dbe077a89da99afcb551ee0722e78f3dfcacf0b0
author Argyrios Kyrtzidis <akyrtzi@gmail.com> Tue Nov 08 05:56:11 2011 +0000
committer Argyrios Kyrtzidis <akyrtzi@gmail.com> Tue Nov 08 05:56:11 2011 +0000
tree 96d5236dae24fe7f36d67e8784ce09f68986c853
parent 3befb8cd8af2031657fb4f3bea495588b6f9cb4e

[arcmt] Now that properties are strong by default, avoid adding redundant '(strong)'
property attribute.

llvm-svn: 144078

clang/lib/ARCMigrate/TransProperties.cpp

diff --git a/clang/lib/ARCMigrate/TransProperties.cpp b/clang/lib/ARCMigrate/TransProperties.cpp
index 050512f..7e890ef 100644
--- a/clang/lib/ARCMigrate/TransProperties.cpp
+++ b/clang/lib/ARCMigrate/TransProperties.cpp
@@ -287,8 +287,10 @@
   void maybeAddStrongAttr(PropsTy &props, SourceLocation atLoc) const {
     ObjCPropertyDecl::PropertyAttributeKind propAttrs = getPropertyAttrs(props);
 
-    if (!(propAttrs & ObjCPropertyDecl::OBJC_PR_readonly) ||
-        !hasAllIvarsBacked(props)) {
+    if (!(propAttrs & ObjCPropertyDecl::OBJC_PR_readonly))
+      return; // 'strong' by default.
+
+    if (!hasAllIvarsBacked(props)) {
       addAttribute("strong", atLoc);
     }