commit dccd9883c4ad145b03784a69d5897e41d1001957
author Ted Kremenek <kremenek@apple.com> Wed Aug 13 03:28:04 2008 +0000
committer Ted Kremenek <kremenek@apple.com> Wed Aug 13 03:28:04 2008 +0000
tree 7751459a2db3cebac6a76d675b4d6e8c55f7cfd9
parent b036db8e66a80f3a14186010bc72703ed865b95a

Initialize tracked local variables to undefined.

llvm-svn: 54716

clang/lib/Analysis/GRExprEngine.cpp

diff --git a/clang/lib/Analysis/GRExprEngine.cpp b/clang/lib/Analysis/GRExprEngine.cpp
index f0c0d8d..a31c435 100644
--- a/clang/lib/Analysis/GRExprEngine.cpp
+++ b/clang/lib/Analysis/GRExprEngine.cpp
@@ -202,10 +202,15 @@
     
     ScopedDecl *SD = const_cast<ScopedDecl*>(I->first);
     if (VarDecl* VD = dyn_cast<VarDecl>(SD)) {
-      if (VD->hasGlobalStorage() || isa<ParmVarDecl>(VD)) {
-        RVal X = RVal::GetSymbolValue(SymMgr, VD);
-        StateMgr.SetRVal(StateImpl, lval::DeclVal(VD), X);
-      }
+      // Initialize globals and parameters to symbolic values.
+      // Initialize local variables to undefined.
+      RVal X = (VD->hasGlobalStorage() || isa<ParmVarDecl>(VD) ||
+                isa<ImplicitParamDecl>(VD))
+             ? RVal::GetSymbolValue(SymMgr, VD)
+             : UndefinedVal();
+      
+      StateMgr.SetRVal(StateImpl, lval::DeclVal(VD), X);
+      
     } else if (ImplicitParamDecl *IPD = dyn_cast<ImplicitParamDecl>(SD)) {
         RVal X = RVal::GetSymbolValue(SymMgr, IPD);
       StateMgr.SetRVal(StateImpl, lval::DeclVal(IPD), X);

clang/lib/Analysis/SymbolManager.cpp

diff --git a/clang/lib/Analysis/SymbolManager.cpp b/clang/lib/Analysis/SymbolManager.cpp
index f243fa66..beb4379 100644
--- a/clang/lib/Analysis/SymbolManager.cpp
+++ b/clang/lib/Analysis/SymbolManager.cpp
@@ -18,7 +18,8 @@
 
 SymbolID SymbolManager::getSymbol(VarDecl* D) {
 
-  assert (isa<ParmVarDecl>(D) || D->hasGlobalStorage());
+  assert (isa<ParmVarDecl>(D) || isa<ImplicitParamDecl>(D) || 
+          D->hasGlobalStorage());
   
   llvm::FoldingSetNodeID profile;