commit ddf42c8d80084bdd04d593c3d63584b12c069b59
author Anders Carlsson <andersca@mac.com> Fri Dec 04 02:56:03 2009 +0000
committer Anders Carlsson <andersca@mac.com> Fri Dec 04 02:56:03 2009 +0000
tree 655ab2b5f80aadf444dae6b99f5c18931207ec4e
parent 5b3ea9bf1cc0d39443f63475783cc94033ce04aa

Move handling of pure virtual methods to AppendMethods (and rename it to AppendMethodsToVtable).

llvm-svn: 90529

clang/lib/CodeGen/CGVtable.cpp

diff --git a/clang/lib/CodeGen/CGVtable.cpp b/clang/lib/CodeGen/CGVtable.cpp
index 2f5d3f7..f122622 100644
--- a/clang/lib/CodeGen/CGVtable.cpp
+++ b/clang/lib/CodeGen/CGVtable.cpp
@@ -289,17 +289,8 @@
                       Index_t Offset, int64_t CurrentVBaseOffset);
 
   /// AppendMethods - Append the current methods to the vtable.
-  void AppendMethods();
+  void AppendMethodsToVtable();
   
-  void InstallThunks() {
-    for (PureVirtualMethodsSetTy::iterator i = PureVirtualMethods.begin(),
-         e = PureVirtualMethods.end(); i != e; ++i) {
-      GlobalDecl GD = *i;
-      submethods[Index[GD]] = getPureVirtualFn();
-    }
-    PureVirtualMethods.clear();
-  }
-
   llvm::Constant *WrapAddrOf(GlobalDecl GD) {
     const CXXMethodDecl *MD = cast<CXXMethodDecl>(GD.getDecl());
 
@@ -486,7 +477,7 @@
 
     assert(submethods.size() == Methods.size() && "Method size mismatch!");
 
-    AppendMethods();
+    AppendMethodsToVtable();
 
     // and then the non-virtual bases.
     NonVirtualBases(RD, Layout, PrimaryBase, PrimaryBaseWasVirtual,
@@ -851,9 +842,7 @@
   return false;
 }
 
-void VtableBuilder::AppendMethods() {
-  InstallThunks();
-
+void VtableBuilder::AppendMethodsToVtable() {
   for (unsigned i = 0, e = Methods.size(); i != e; ++i) {
     GlobalDecl GD = Methods[i];
     const CXXMethodDecl *MD = cast<CXXMethodDecl>(GD.getDecl());
@@ -886,6 +875,9 @@
     } else if (!ThisAdjustment.isEmpty()) {
       // Build a "regular" thunk.
       submethods[i] = CGM.BuildThunk(GD, Extern, ThisAdjustment);
+    } else if (MD->isPure()) {
+      // We have a pure virtual method.
+      submethods[i] = getPureVirtualFn();
     }
   }