Change DeclContextFindDeclByName to return a vector of CompilerDecl objects. Opaque pointers should only be used for the decl context object. Also made a default implementation so that GoASTContext doesn't need to override DeclContextFindDeclByName.

llvm-svn: 255038
diff --git a/lldb/source/Symbol/CompilerDeclContext.cpp b/lldb/source/Symbol/CompilerDeclContext.cpp
index a28ea8d..e44cee6 100644
--- a/lldb/source/Symbol/CompilerDeclContext.cpp
+++ b/lldb/source/Symbol/CompilerDeclContext.cpp
@@ -17,14 +17,10 @@
 std::vector<CompilerDecl>
 CompilerDeclContext::FindDeclByName (ConstString name)
 {
-    std::vector<CompilerDecl> found_decls;
     if (IsValid())
-    {
-        std::vector<void *> found_opaque_decls = m_type_system->DeclContextFindDeclByName(m_opaque_decl_ctx, name);
-        for (void *opaque_decl : found_opaque_decls)
-            found_decls.push_back(CompilerDecl(m_type_system, opaque_decl));
-    }
-    return found_decls;
+        return m_type_system->DeclContextFindDeclByName(m_opaque_decl_ctx, name);
+    else
+        return std::vector<CompilerDecl>();
 }
 
 bool