commit e2125d82787d20ccbfdd1e24e1835c9101e6ad77
author Benjamin Kramer <benny.kra@googlemail.com> Mon Sep 26 02:14:13 2011 +0000
committer Benjamin Kramer <benny.kra@googlemail.com> Mon Sep 26 02:14:13 2011 +0000
tree 2062df2bb2717352c753d4eb42e89213500c4814
parent cfd2356180e46ef4135c3679dcfce9fd95efb56c

Don't print a stray ] at the end of diagnostics.

Also remove an obsolete utostr call.

llvm-svn: 140511

clang/lib/Frontend/TextDiagnosticPrinter.cpp

diff --git a/clang/lib/Frontend/TextDiagnosticPrinter.cpp b/clang/lib/Frontend/TextDiagnosticPrinter.cpp
index 3fd91b2..3c2b84f 100644
--- a/clang/lib/Frontend/TextDiagnosticPrinter.cpp
+++ b/clang/lib/Frontend/TextDiagnosticPrinter.cpp
@@ -20,7 +20,6 @@
 #include "llvm/Support/raw_ostream.h"
 #include "llvm/Support/ErrorHandling.h"
 #include "llvm/ADT/SmallString.h"
-#include "llvm/ADT/StringExtras.h"
 #include <algorithm>
 using namespace clang;
 
@@ -1070,15 +1069,17 @@
       DiagnosticIDs::getCategoryNumberForDiag(Info.getID());
     if (DiagCategory) {
       OS << (Started ? "," : " [");
+      Started = true;
       if (DiagOpts.ShowCategories == 1)
-        OS << llvm::utostr(DiagCategory);
+        OS << DiagCategory;
       else {
         assert(DiagOpts.ShowCategories == 2 && "Invalid ShowCategories value");
         OS << DiagnosticIDs::getCategoryNameFromID(DiagCategory);
       }
     }
   }
-  OS << "]";
+  if (Started)
+    OS << ']';
 }
 
 /// \brief Print the given string to a stream, word-wrapping it to