Consistent use of <internal> when displaying internal symbol names
Differential Revision: https://reviews.llvm.org/D40510
llvm-svn: 319108
diff --git a/lld/wasm/SymbolTable.cpp b/lld/wasm/SymbolTable.cpp
index 492a809..97670cf 100644
--- a/lld/wasm/SymbolTable.cpp
+++ b/lld/wasm/SymbolTable.cpp
@@ -73,7 +73,7 @@
void SymbolTable::reportDuplicate(Symbol *Existing, InputFile *NewFile) {
error("duplicate symbol: " + toString(*Existing) + "\n>>> defined in " +
toString(Existing->getFile()) + "\n>>> defined in " +
- (NewFile ? toString(NewFile) : "<internal>"));
+ toString(NewFile));
}
static void checkSymbolTypes(Symbol *Existing, InputFile *F,
@@ -86,13 +86,10 @@
if (Existing->isFunction() == NewIsFunction)
return;
- std::string Filename = "<builtin>";
- if (Existing->getFile())
- Filename = toString(Existing->getFile());
error("symbol type mismatch: " + New->Name + "\n>>> defined as " +
- (Existing->isFunction() ? "Function" : "Global") + " in " + Filename +
- "\n>>> defined as " + (NewIsFunction ? "Function" : "Global") + " in " +
- F->getName());
+ (Existing->isFunction() ? "Function" : "Global") + " in " +
+ toString(Existing->getFile()) + "\n>>> defined as " +
+ (NewIsFunction ? "Function" : "Global") + " in " + F->getName());
}
Symbol *SymbolTable::addDefinedGlobal(StringRef Name) {