commit e4cfcd4e4134b76c5880880f3984bb4d86655814
author Anna Zaks <ganna@apple.com> Tue Apr 16 00:22:55 2013 +0000
committer Anna Zaks <ganna@apple.com> Tue Apr 16 00:22:55 2013 +0000
tree 22b19c73b9e792a08d884e07fc2ab8921dc75310
parent d63d3c7d971081b64552f73654705ca7f240f10f

[analyzer] Improve the malloc checker stack hint message

llvm-svn: 179580

clang/lib/StaticAnalyzer/Checkers/MallocChecker.cpp

diff --git a/clang/lib/StaticAnalyzer/Checkers/MallocChecker.cpp b/clang/lib/StaticAnalyzer/Checkers/MallocChecker.cpp
index b7fe9b6..5d3eb65 100644
--- a/clang/lib/StaticAnalyzer/Checkers/MallocChecker.cpp
+++ b/clang/lib/StaticAnalyzer/Checkers/MallocChecker.cpp
@@ -2092,7 +2092,7 @@
     } else if (isReleased(RS, RSPrev, S)) {
       Msg = "Memory is released";
       StackHint = new StackHintGeneratorForSymbol(Sym,
-                                                  "Returned released memory");
+                                             "Returning; memory was released");
     } else if (isRelinquished(RS, RSPrev, S)) {
       Msg = "Memory ownership is transfered";
       StackHint = new StackHintGeneratorForSymbol(Sym, "");
@@ -2152,13 +2152,13 @@
   }
 }
 
-void ento::registerNewDeleteLeaksChecker(CheckerManager &mgr) {

-  registerCStringCheckerBasic(mgr);

-  mgr.registerChecker<MallocChecker>()->Filter.CNewDeleteLeaksChecker = true;

-  // We currently treat NewDeleteLeaks checker as a subchecker of NewDelete 

-  // checker.

-  mgr.registerChecker<MallocChecker>()->Filter.CNewDeleteChecker = true;

-}

+void ento::registerNewDeleteLeaksChecker(CheckerManager &mgr) {
+  registerCStringCheckerBasic(mgr);
+  mgr.registerChecker<MallocChecker>()->Filter.CNewDeleteLeaksChecker = true;
+  // We currently treat NewDeleteLeaks checker as a subchecker of NewDelete 
+  // checker.
+  mgr.registerChecker<MallocChecker>()->Filter.CNewDeleteChecker = true;
+}
 
 #define REGISTER_CHECKER(name) \
 void ento::register##name(CheckerManager &mgr) {\