commit e62d682a27ce9addf40223430fe8228a793e889f
author Argyrios Kyrtzidis <akyrtzi@gmail.com> Sat Oct 18 06:19:36 2014 +0000
committer Argyrios Kyrtzidis <akyrtzi@gmail.com> Sat Oct 18 06:19:36 2014 +0000
tree 7b0f577907bfc9432e84159ec5b49bbce7c56bbb
parent 2b67fca0337b46ea650f890df6e8508d1a821ae7

[libclang] Allow code-completion when pointing at the end-of-file.

llvm-svn: 220135

clang/lib/Lex/Preprocessor.cpp

diff --git a/clang/lib/Lex/Preprocessor.cpp b/clang/lib/Lex/Preprocessor.cpp
index 400cdb4..c15a6ab 100644
--- a/clang/lib/Lex/Preprocessor.cpp
+++ b/clang/lib/Lex/Preprocessor.cpp
@@ -384,21 +384,20 @@
   }
 
   Position += CompleteColumn - 1;
+  if (Position > Buffer->getBufferEnd())
+    Position = Buffer->getBufferEnd();
 
-  // Insert '\0' at the code-completion point.
-  if (Position < Buffer->getBufferEnd()) {
-    CodeCompletionFile = File;
-    CodeCompletionOffset = Position - Buffer->getBufferStart();
+  CodeCompletionFile = File;
+  CodeCompletionOffset = Position - Buffer->getBufferStart();
 
-    std::unique_ptr<MemoryBuffer> NewBuffer =
-        MemoryBuffer::getNewUninitMemBuffer(Buffer->getBufferSize() + 1,
-                                            Buffer->getBufferIdentifier());
-    char *NewBuf = const_cast<char*>(NewBuffer->getBufferStart());
-    char *NewPos = std::copy(Buffer->getBufferStart(), Position, NewBuf);
-    *NewPos = '\0';
-    std::copy(Position, Buffer->getBufferEnd(), NewPos+1);
-    SourceMgr.overrideFileContents(File, std::move(NewBuffer));
-  }
+  std::unique_ptr<MemoryBuffer> NewBuffer =
+      MemoryBuffer::getNewUninitMemBuffer(Buffer->getBufferSize() + 1,
+                                          Buffer->getBufferIdentifier());
+  char *NewBuf = const_cast<char*>(NewBuffer->getBufferStart());
+  char *NewPos = std::copy(Buffer->getBufferStart(), Position, NewBuf);
+  *NewPos = '\0';
+  std::copy(Position, Buffer->getBufferEnd(), NewPos+1);
+  SourceMgr.overrideFileContents(File, std::move(NewBuffer));
 
   return false;
 }

clang/test/Index/Inputs/complete-at-EOF.c

diff --git a/clang/test/Index/Inputs/complete-at-EOF.c b/clang/test/Index/Inputs/complete-at-EOF.c
new file mode 100644
index 0000000..8207f72
--- /dev/null
+++ b/clang/test/Index/Inputs/complete-at-EOF.c
@@ -0,0 +1,3 @@
+#define CAKE 1
+
+typedef int foo;

clang/test/Index/complete-at-EOF.c

diff --git a/clang/test/Index/complete-at-EOF.c b/clang/test/Index/complete-at-EOF.c
new file mode 100644
index 0000000..ff39233
--- /dev/null
+++ b/clang/test/Index/complete-at-EOF.c
@@ -0,0 +1,5 @@
+
+// RUN: env CINDEXTEST_EDITING=1 CINDEXTEST_COMPLETION_CACHING=1 c-index-test \
+// RUN:	    -code-completion-at=%S/Inputs/complete-at-EOF.c:4:1 %S/Inputs/complete-at-EOF.c | FileCheck -check-prefix=CHECK-EOF %s
+// CHECK-EOF: macro definition:{TypedText CAKE}
+// CHECK-EOF: TypedefDecl:{TypedText foo}