Fix a false positive warning when initializing members with gsl::Owners.
llvm-svn: 368501
diff --git a/clang/lib/Sema/SemaInit.cpp b/clang/lib/Sema/SemaInit.cpp
index a54f5db..9411c81 100644
--- a/clang/lib/Sema/SemaInit.cpp
+++ b/clang/lib/Sema/SemaInit.cpp
@@ -7217,6 +7217,11 @@
if (pathContainsInit(Path))
return false;
+ // Suppress false positives for code like the below:
+ // Ctor(unique_ptr<T> up) : member(*up), member2(move(up)) {}
+ if (IsLocalGslOwner && pathOnlyInitializesGslPointer(Path))
+ return false;
+
auto *DRE = dyn_cast<DeclRefExpr>(L);
auto *VD = DRE ? dyn_cast<VarDecl>(DRE->getDecl()) : nullptr;
if (!VD) {
diff --git a/clang/test/Sema/warn-lifetime-analysis-nocfg.cpp b/clang/test/Sema/warn-lifetime-analysis-nocfg.cpp
index efa54fe..c558901 100644
--- a/clang/test/Sema/warn-lifetime-analysis-nocfg.cpp
+++ b/clang/test/Sema/warn-lifetime-analysis-nocfg.cpp
@@ -120,6 +120,13 @@
}
namespace std {
+template<class T> struct remove_reference { typedef T type; };
+template<class T> struct remove_reference<T &> { typedef T type; };
+template<class T> struct remove_reference<T &&> { typedef T type; };
+
+template<class T>
+typename remove_reference<T>::type &&move(T &&t) noexcept;
+
template <typename T>
struct basic_iterator {
basic_iterator operator++();
@@ -153,6 +160,7 @@
template<typename T>
struct unique_ptr {
+ T &operator*();
T *get() const;
};
@@ -217,3 +225,10 @@
const char *trackThroughMultiplePointer() {
return std::basic_string_view<char>(std::basic_string<char>()).begin(); // expected-warning {{returning address of local temporary object}}
}
+
+struct X {
+ X(std::unique_ptr<int> up) : pointee(*up), pointer(std::move(up)) {}
+
+ int &pointee;
+ std::unique_ptr<int> pointer;
+};