commit eb563af70b54c9ef758393f863bdca00116be421
author Gabor Horvath <xazax.hun@gmail.com> Sat Aug 10 00:32:29 2019 +0000
committer Gabor Horvath <xazax.hun@gmail.com> Sat Aug 10 00:32:29 2019 +0000
tree 6b7b6e0ae8fa3fed32182864041900ac61d2e58e
parent 1aaef90c2aab94407b047ee82b8ed9d3aecd532f

Fix a false positive warning when initializing members with gsl::Owners.

llvm-svn: 368501

clang/lib/Sema/SemaInit.cpp

diff --git a/clang/lib/Sema/SemaInit.cpp b/clang/lib/Sema/SemaInit.cpp
index a54f5db..9411c81 100644
--- a/clang/lib/Sema/SemaInit.cpp
+++ b/clang/lib/Sema/SemaInit.cpp
@@ -7217,6 +7217,11 @@
         if (pathContainsInit(Path))
           return false;
 
+        // Suppress false positives for code like the below:
+        //   Ctor(unique_ptr<T> up) : member(*up), member2(move(up)) {}
+        if (IsLocalGslOwner && pathOnlyInitializesGslPointer(Path))
+          return false;
+
         auto *DRE = dyn_cast<DeclRefExpr>(L);
         auto *VD = DRE ? dyn_cast<VarDecl>(DRE->getDecl()) : nullptr;
         if (!VD) {