commit edc44140947e4e3721e2a44e527b8b538451271d
author Enrico Granata <egranata@apple.com> Sat Sep 06 01:30:04 2014 +0000
committer Enrico Granata <egranata@apple.com> Sat Sep 06 01:30:04 2014 +0000
tree 394993f8fa69d4253ab7df24d586f9a139a63939
parent 728894340f2a95eef5330b60410fb2abb158137b

Expose the ability to retrieve the result of a type validator via the SB API. To keep it simple, do not expose the pair, but just return a NULL string for success, and a non-NULL string for error; If we were to decide to expose the pair, we would need an SBTypeValidatorResult, which is fine, but it should come as part of exposing type validators through the SB API rather than as a one-off thing. So, KISS for now

llvm-svn: 217299

lldb/include/lldb/API/SBValue.h

diff --git a/lldb/include/lldb/API/SBValue.h b/lldb/include/lldb/API/SBValue.h
index 93b869ba..2d415c1 100644
--- a/lldb/include/lldb/API/SBValue.h
+++ b/lldb/include/lldb/API/SBValue.h
@@ -93,6 +93,9 @@
     const char *
     GetObjectDescription ();
     
+    const char *
+    GetTypeValidatorResult ();
+    
     lldb::SBValue
     GetDynamicValue (lldb::DynamicValueType use_dynamic);
     

lldb/scripts/Python/interface/SBValue.i

diff --git a/lldb/scripts/Python/interface/SBValue.i b/lldb/scripts/Python/interface/SBValue.i
index 281782b..15b39fd 100644
--- a/lldb/scripts/Python/interface/SBValue.i
+++ b/lldb/scripts/Python/interface/SBValue.i
@@ -123,6 +123,9 @@
     
     const char *
     GetObjectDescription ();
+    
+    const char *
+    GetTypeValidatorResult ();
 
     lldb::SBValue
     GetDynamicValue (lldb::DynamicValueType use_dynamic);

lldb/source/API/SBValue.cpp

diff --git a/lldb/source/API/SBValue.cpp b/lldb/source/API/SBValue.cpp
index 3a9621b..d22f611 100644
--- a/lldb/source/API/SBValue.cpp
+++ b/lldb/source/API/SBValue.cpp
@@ -543,6 +543,36 @@
     return cstr;
 }
 
+const char *
+SBValue::GetTypeValidatorResult ()
+{
+    Log *log(lldb_private::GetLogIfAllCategoriesSet (LIBLLDB_LOG_API));
+    const char *cstr = NULL;
+    ValueLocker locker;
+    lldb::ValueObjectSP value_sp(GetSP(locker));
+    if (value_sp)
+    {
+        const auto& validation(value_sp->GetValidationStatus());
+        if (TypeValidatorResult::Failure == validation.first)
+        {
+            if (validation.second.empty())
+                cstr = "unknown error";
+            else
+                cstr = validation.second.c_str();
+        }
+    }
+    if (log)
+    {
+        if (cstr)
+            log->Printf ("SBValue(%p)::GetTypeValidatorResult() => \"%s\"",
+                         static_cast<void*>(value_sp.get()), cstr);
+        else
+            log->Printf ("SBValue(%p)::GetTypeValidatorResult() => NULL",
+                         static_cast<void*>(value_sp.get()));
+    }
+    return cstr;
+}
+
 SBType
 SBValue::GetType()
 {