Heh, funny thing, 'void' isn't a POD type. Nice of us to suggest it to
silence this warning. ;]
Fixed that obvious bug and added a bit more testing as well.
llvm-svn: 130318
diff --git a/clang/lib/Sema/SemaChecking.cpp b/clang/lib/Sema/SemaChecking.cpp
index 6b21961..7ee0eac 100644
--- a/clang/lib/Sema/SemaChecking.cpp
+++ b/clang/lib/Sema/SemaChecking.cpp
@@ -1810,7 +1810,7 @@
QualType DestTy = Dest->getType();
if (const PointerType *DestPtrTy = DestTy->getAs<PointerType>()) {
QualType PointeeTy = DestPtrTy->getPointeeType();
- if (!PointeeTy->isPODType()) {
+ if (!PointeeTy->isPODType() && !PointeeTy->isVoidType()) {
DiagRuntimeBehavior(
Dest->getExprLoc(), Dest,
PDiag(diag::warn_non_pod_memset)
diff --git a/clang/test/SemaCXX/warn-non-pod-memset.cpp b/clang/test/SemaCXX/warn-non-pod-memset.cpp
index 03e626e..97bbdc2 100644
--- a/clang/test/SemaCXX/warn-non-pod-memset.cpp
+++ b/clang/test/SemaCXX/warn-non-pod-memset.cpp
@@ -32,7 +32,16 @@
// expected-note {{explicitly cast the pointer to silence this warning}}
}
-void test_nowarn() {
+void test_nowarn(void *void_ptr) {
+ int i, *iptr;
+ float y;
+ char c;
+
+ memset(&i, 0, sizeof i);
+ memset(&iptr, 0, sizeof iptr);
+ memset(&y, 0, sizeof y);
+ memset(&c, 0, sizeof c);
+ memset(void_ptr, 0, 42);
memset(&s1, 0, sizeof s1);
memset(&s2, 0, sizeof s2);
memset(&s3, 0, sizeof s3);