commit ef1ac01c2ebac3dec3d4288b323576cc0d4139ae
author Rafael Espindola <rafael.espindola@gmail.com> Thu Aug 13 15:31:17 2015 +0000
committer Rafael Espindola <rafael.espindola@gmail.com> Thu Aug 13 15:31:17 2015 +0000
tree 553423bd33a30347462a239c69bd20b12b7c7167
parent 221104bec6e14e41f24adfeb6c662341ae11e145

Don't give an address to sections that are not allocated.

llvm-svn: 244900

lld/ELF/Writer.cpp

diff --git a/lld/ELF/Writer.cpp b/lld/ELF/Writer.cpp
index b754ba3..79ab880 100644
--- a/lld/ELF/Writer.cpp
+++ b/lld/ELF/Writer.cpp
@@ -174,9 +174,11 @@
   std::stable_sort(OutputSections.begin(), OutputSections.end(), compSec<ELFT>);
 
   for (OutputSection<ELFT> *Sec : OutputSections) {
-    Sec->setVA(VA);
+    if (Sec->getFlags() & SHF_ALLOC) {
+      Sec->setVA(VA);
+      VA += RoundUpToAlignment(Sec->getSize(), PageSize);
+    }
     Sec->setFileOffset(FileOff);
-    VA += RoundUpToAlignment(Sec->getSize(), PageSize);
     FileOff += RoundUpToAlignment(Sec->getSize(), 8);
     StrTabBuilder.add(Sec->getName());
   }

lld/test/elf2/string-table.s

diff --git a/lld/test/elf2/string-table.s b/lld/test/elf2/string-table.s
index 80bfe7b..81b740d 100644
--- a/lld/test/elf2/string-table.s
+++ b/lld/test/elf2/string-table.s
@@ -15,11 +15,13 @@
 // CHECK-NEXT:   Flags [
 // CHECK-NEXT:     SHF_ALLOC
 // CHECK-NEXT:   ]
+// CHECK-NEXT:   Address: 0x1000
 
 // CHECK:      Name: foobar
 // CHECK-NEXT:   Type: SHT_PROGBITS
 // CHECK-NEXT:   Flags [
 // CHECK-NEXT:   ]
+// CHECK-NEXT:   Address: 0x0
 
 // Test that the sting "bar" is merged into "foobar"