commit f1f20e6802b286e44631c814181e27cf8a5bc947
author Richard Smith <richard-llvm@metafoo.co.uk> Wed Feb 14 02:07:53 2018 +0000
committer Richard Smith <richard-llvm@metafoo.co.uk> Wed Feb 14 02:07:53 2018 +0000
tree feab1a4664d4b580da909a737e8c8d923a249af3
parent 1d76120d9ad078c13453433621fa55f8983acd68

Fix a couple of places where we assumed that non-type template parameters are always rvalues.

llvm-svn: 325095

clang/lib/Sema/SemaTemplateInstantiate.cpp

diff --git a/clang/lib/Sema/SemaTemplateInstantiate.cpp b/clang/lib/Sema/SemaTemplateInstantiate.cpp
index 489d026..2c4f649 100644
--- a/clang/lib/Sema/SemaTemplateInstantiate.cpp
+++ b/clang/lib/Sema/SemaTemplateInstantiate.cpp
@@ -1212,11 +1212,11 @@
                                               NTTP->getDeclName());
       if (TargetType.isNull())
         return ExprError();
-      
-      return new (SemaRef.Context) SubstNonTypeTemplateParmPackExpr(TargetType,
-                                                                    NTTP, 
-                                                              E->getLocation(),
-                                                                    Arg);
+
+      return new (SemaRef.Context) SubstNonTypeTemplateParmPackExpr(
+          TargetType.getNonLValueExprType(SemaRef.Context),
+          TargetType->isReferenceType() ? VK_LValue : VK_RValue, NTTP,
+          E->getLocation(), Arg);
     }
     
     Arg = getPackSubstitutedTemplateArgument(getSema(), Arg);