Added a better diagnostic when using the delete operator with lambdas
Summary:
This adds a new error for missing parentheses around lambdas in delete operators.
```
int main() {
delete []() { return new int(); }();
}
```
This will result in:
```
test.cpp:2:3: error: '[]' after delete interpreted as 'delete[]'
delete []() { return new int(); }();
^~~~~~~~~
test.cpp:2:9: note: add parentheses around the lambda
delete []() { return new int(); }();
^
( )
```
Reviewers: rsmith
Reviewed By: rsmith
Subscribers: riccibruno, cfe-commits
Tags: #clang
Differential Revision: https://reviews.llvm.org/D36357
llvm-svn: 361119
diff --git a/clang/test/Parser/cxx0x-lambda-expressions.cpp b/clang/test/Parser/cxx0x-lambda-expressions.cpp
index 7deeb21..b297d73 100644
--- a/clang/test/Parser/cxx0x-lambda-expressions.cpp
+++ b/clang/test/Parser/cxx0x-lambda-expressions.cpp
@@ -1,4 +1,5 @@
// RUN: %clang_cc1 -fsyntax-only -Wno-unused-value -verify -std=c++11 %s
+// RUN: %clang_cc1 -fsyntax-only -Wno-unused-value -verify -std=c++2a %s
enum E { e };
@@ -43,31 +44,57 @@
int a4[1] = {[&b] = 1 }; // expected-error{{integral constant expression must have integral or unscoped enumeration type, not 'const int *'}}
int a5[3] = { []{return 0;}() };
int a6[1] = {[this] = 1 }; // expected-error{{integral constant expression must have integral or unscoped enumeration type, not 'C *'}}
- int a7[1] = {[d(0)] { return d; } ()}; // expected-warning{{extension}}
- int a8[1] = {[d = 0] { return d; } ()}; // expected-warning{{extension}}
+ int a7[1] = {[d(0)] { return d; } ()};
+ int a8[1] = {[d = 0] { return d; } ()};
+ int a10[1] = {[id(0)] { return id; } ()};
+#if __cplusplus <= 201103L
+ // expected-warning@-4{{extension}}
+ // expected-warning@-4{{extension}}
+ // expected-warning@-4{{extension}}
+#endif
int a9[1] = {[d = 0] = 1}; // expected-error{{is not an integral constant expression}}
- int a10[1] = {[id(0)] { return id; } ()}; // expected-warning{{extension}}
+#if __cplusplus >= 201402L
+ // expected-note@-2{{constant expression cannot modify an object that is visible outside that expression}}
+#endif
int a11[1] = {[id(0)] = 1};
}
void delete_lambda(int *p) {
delete [] p;
delete [] (int*) { new int }; // ok, compound-literal, not lambda
- delete [] { return new int; } (); // expected-error{{expected expression}}
+ delete [] { return new int; } (); // expected-error {{'[]' after delete interpreted as 'delete[]'}}
delete [&] { return new int; } (); // ok, lambda
+
+ delete []() { return new int; }(); // expected-error{{'[]' after delete interpreted as 'delete[]'}}
+ delete [](E Enum) { return new int((int)Enum); }(e); // expected-error{{'[]' after delete interpreted as 'delete[]'}}
+#if __cplusplus > 201703L
+ delete []<int = 0>() { return new int; }(); // expected-error{{'[]' after delete interpreted as 'delete[]'}}
+#endif
}
// We support init-captures in C++11 as an extension.
int z;
void init_capture() {
- [n(0)] () mutable -> int { return ++n; }; // expected-warning{{extension}}
- [n{0}] { return; }; // expected-warning{{extension}}
- [n = 0] { return ++n; }; // expected-error {{captured by copy in a non-mutable}} expected-warning{{extension}}
- [n = {0}] { return; }; // expected-error {{<initializer_list>}} expected-warning{{extension}}
- [a([&b = z]{})](){}; // expected-warning 2{{extension}}
+ [n(0)] () mutable -> int { return ++n; };
+ [n{0}] { return; };
+ [a([&b = z]{})](){};
+ [n = 0] { return ++n; }; // expected-error {{captured by copy in a non-mutable}}
+ [n = {0}] { return; }; // expected-error {{<initializer_list>}}
+#if __cplusplus <= 201103L
+ // expected-warning@-6{{extension}}
+ // expected-warning@-6{{extension}}
+ // expected-warning@-6{{extension}}
+ // expected-warning@-7{{extension}}
+ // expected-warning@-7{{extension}}
+ // expected-warning@-7{{extension}}
+#endif
int x = 4;
- auto y = [&r = x, x = x + 1]() -> int { // expected-warning 2{{extension}}
+ auto y = [&r = x, x = x + 1]() -> int {
+#if __cplusplus <= 201103L
+ // expected-warning@-2{{extension}}
+ // expected-warning@-3{{extension}}
+#endif
r += 2;
return x + 2;
} ();