commit f847117ac800e46780f85de2f04c594c86b358c8
author Anders Carlsson <andersca@mac.com> Fri Oct 16 02:06:06 2009 +0000
committer Anders Carlsson <andersca@mac.com> Fri Oct 16 02:06:06 2009 +0000
tree 3108bb97b70c389ce042fe605ff0646d0e948d98
parent 5d9134747b012b706bab56f6e2c7cf53e7c0622a

Builtin types are subsitutable if they are qualified. Fixes PR5196.

llvm-svn: 84237

clang/lib/CodeGen/Mangle.cpp

diff --git a/clang/lib/CodeGen/Mangle.cpp b/clang/lib/CodeGen/Mangle.cpp
index fd77274..344ef06 100644
--- a/clang/lib/CodeGen/Mangle.cpp
+++ b/clang/lib/CodeGen/Mangle.cpp
@@ -705,7 +705,7 @@
   // Only operate on the canonical type!
   T = Context.getASTContext().getCanonicalType(T);
 
-  bool IsSubstitutable = !isa<BuiltinType>(T);
+  bool IsSubstitutable = T.hasQualifiers() || !isa<BuiltinType>(T);
   if (IsSubstitutable && mangleSubstitution(T))
     return;
 

clang/test/CodeGenCXX/mangle-subst.cpp

diff --git a/clang/test/CodeGenCXX/mangle-subst.cpp b/clang/test/CodeGenCXX/mangle-subst.cpp
index c53a630..46a21b6 100644
--- a/clang/test/CodeGenCXX/mangle-subst.cpp
+++ b/clang/test/CodeGenCXX/mangle-subst.cpp
@@ -54,3 +54,8 @@
 // CHECK: @_ZN2NS3ft3IiEEvNS_2S1IT_EENS1_IcEE
 template void ft3<int>(S1<int>, S1<char>);
 }
+
+// PR5196
+// CHECK: @_Z1fPKcS0_
+void f(const char*, const char*) {}
+