commit fd8355373333dc3055143f292e7f82967c5239f7
author Anders Carlsson <andersca@mac.com> Thu Jan 20 05:57:14 2011 +0000
committer Anders Carlsson <andersca@mac.com> Thu Jan 20 05:57:14 2011 +0000
tree c20465701e7708abf1799ecfd18069e76be68797
parent b4801436d162dd3cfa523d2d16d77c7f59a3b650

Diagnose virtual member functions marked override but not overriding any virtual member functions.

llvm-svn: 123888

clang/lib/Sema/SemaDecl.cpp

diff --git a/clang/lib/Sema/SemaDecl.cpp b/clang/lib/Sema/SemaDecl.cpp
index d28548d..2905076 100644
--- a/clang/lib/Sema/SemaDecl.cpp
+++ b/clang/lib/Sema/SemaDecl.cpp
@@ -3388,7 +3388,8 @@
   ///   If a virtual member function f is marked override and does not override
   ///   a member function of a base class the program is ill-formed.
   if (HasOverrideAttr && !HasOverriddenMethods) {
-    SemaRef.Diag(MD->getLocation(), diag::err_override_function_not_overriding)
+    SemaRef.Diag(MD->getLocation(), 
+                 diag::err_function_marked_override_not_overriding)
       << MD->getDeclName();
     return;
   }

clang/lib/Sema/SemaDeclCXX.cpp

diff --git a/clang/lib/Sema/SemaDeclCXX.cpp b/clang/lib/Sema/SemaDeclCXX.cpp
index c58fbce..8fe4852 100644
--- a/clang/lib/Sema/SemaDeclCXX.cpp
+++ b/clang/lib/Sema/SemaDeclCXX.cpp
@@ -852,6 +852,27 @@
   return ASDecl;
 }
 
+/// CheckOverrideControl - Check C++0x override control semantics.
+static void 
+CheckOverrideControl(Sema& SemaRef, const Decl *D) {
+  const CXXMethodDecl *MD = llvm::dyn_cast<CXXMethodDecl>(D);
+  if (!MD || !MD->isVirtual())
+    return;
+
+  // C++0x [class.virtual]p3:
+  //   If a virtual function is marked with the virt-specifier override and does
+  //   not override a member function of a base class, 
+  //   the program is ill-formed.
+  bool HasOverriddenMethods = 
+    MD->begin_overridden_methods() != MD->end_overridden_methods();
+  if (MD->isMarkedOverride() && !HasOverriddenMethods) {
+    SemaRef.Diag(MD->getLocation(), 
+                 diag::err_function_marked_override_not_overriding)
+      << MD->getDeclName();
+    return;
+  }
+}
+
 /// ActOnCXXMemberDeclarator - This is invoked when a C++ class member
 /// declarator is parsed. 'AS' is the access specifier, 'BW' specifies the
 /// bitfield width if there is one and 'InitExpr' specifies the initializer if
@@ -995,7 +1016,8 @@
       Diag(Member->getLocStart(), 
            diag::override_keyword_only_allowed_on_virtual_member_functions)
         << "override" << FixItHint::CreateRemoval(VS.getOverrideLoc());
-    }
+    } else
+      MD->setIsMarkedOverride(true);
   }
   if (VS.isFinalSpecified()) {
     CXXMethodDecl *MD = dyn_cast<CXXMethodDecl>(Member);
@@ -1003,8 +1025,12 @@
       Diag(Member->getLocStart(), 
            diag::override_keyword_only_allowed_on_virtual_member_functions)
       << "final" << FixItHint::CreateRemoval(VS.getFinalLoc());
-    }    
+    } else
+      MD->setIsMarkedFinal(true);
   }
+
+  CheckOverrideControl(*this, Member);
+
   assert((Name || isInstField) && "No identifier for non-field ?");
 
   if (Init)