Hans Wennborg | c9bd88e | 2014-01-14 19:35:09 +0000 | [diff] [blame] | 1 | // RUN: %clang_cc1 -std=c++11 -triple %itanium_abi_triple -fsyntax-only -Wnon-virtual-dtor -Wdelete-non-virtual-dtor -verify %s |
| 2 | // RUN: %clang_cc1 -std=c++11 -triple %ms_abi_triple -DMSABI -fsyntax-only -Wnon-virtual-dtor -Wdelete-non-virtual-dtor -verify %s |
Douglas Gregor | 831c93f | 2008-11-05 20:51:48 +0000 | [diff] [blame] | 3 | class A { |
| 4 | public: |
| 5 | ~A(); |
| 6 | }; |
| 7 | |
| 8 | class B { |
| 9 | public: |
| 10 | ~B() { } |
| 11 | }; |
| 12 | |
| 13 | class C { |
| 14 | public: |
| 15 | (~C)() { } |
| 16 | }; |
| 17 | |
| 18 | struct D { |
| 19 | static void ~D(int, ...) const { } // \ |
Richard Smith | 63168c7 | 2012-02-10 11:05:11 +0000 | [diff] [blame] | 20 | // expected-error{{static member function cannot have 'const' qualifier}} \ |
Douglas Gregor | 831c93f | 2008-11-05 20:51:48 +0000 | [diff] [blame] | 21 | // expected-error{{destructor cannot be declared 'static'}} \ |
Douglas Gregor | 831c93f | 2008-11-05 20:51:48 +0000 | [diff] [blame] | 22 | // expected-error{{destructor cannot have any parameters}} \ |
Douglas Gregor | 9575516 | 2010-07-01 05:10:53 +0000 | [diff] [blame] | 23 | // expected-error{{destructor cannot be variadic}} \ |
| 24 | // expected-error{{destructor cannot have a return type}} \ |
| 25 | // expected-error{{'const' qualifier is not allowed on a destructor}} |
Douglas Gregor | 831c93f | 2008-11-05 20:51:48 +0000 | [diff] [blame] | 26 | }; |
| 27 | |
Chris Lattner | 38378bf | 2009-04-25 08:28:21 +0000 | [diff] [blame] | 28 | struct D2 { |
| 29 | void ~D2() { } // \ |
| 30 | // expected-error{{destructor cannot have a return type}} |
| 31 | }; |
| 32 | |
Chris Lattner | f6d1c9c | 2009-04-25 08:06:05 +0000 | [diff] [blame] | 33 | |
Douglas Gregor | 831c93f | 2008-11-05 20:51:48 +0000 | [diff] [blame] | 34 | struct E; |
| 35 | |
| 36 | typedef E E_typedef; |
| 37 | struct E { |
John McCall | 85f9055 | 2010-03-10 11:27:22 +0000 | [diff] [blame] | 38 | ~E_typedef(); // expected-error{{destructor cannot be declared using a typedef 'E_typedef' (aka 'E') of the class name}} |
Douglas Gregor | 831c93f | 2008-11-05 20:51:48 +0000 | [diff] [blame] | 39 | }; |
| 40 | |
| 41 | struct F { |
Chris Lattner | 0369c57 | 2008-11-23 23:12:31 +0000 | [diff] [blame] | 42 | (~F)(); // expected-note {{previous declaration is here}} |
| 43 | ~F(); // expected-error {{destructor cannot be redeclared}} |
Douglas Gregor | 831c93f | 2008-11-05 20:51:48 +0000 | [diff] [blame] | 44 | }; |
| 45 | |
Douglas Gregor | fe17d25 | 2010-02-16 19:09:40 +0000 | [diff] [blame] | 46 | ~; // expected-error {{expected a class name after '~' to name a destructor}} |
Fariborz Jahanian | c0656de | 2009-07-20 22:41:12 +0000 | [diff] [blame] | 47 | ~undef(); // expected-error {{expected the class name after '~' to name a destructor}} |
Douglas Gregor | fe17d25 | 2010-02-16 19:09:40 +0000 | [diff] [blame] | 48 | ~operator+(int, int); // expected-error {{expected a class name after '~' to name a destructor}} |
Argyrios Kyrtzidis | e442635 | 2008-11-07 22:02:30 +0000 | [diff] [blame] | 49 | ~F(){} // expected-error {{destructor must be a non-static member function}} |
Douglas Gregor | 4287b37 | 2008-12-12 08:25:50 +0000 | [diff] [blame] | 50 | |
| 51 | struct G { |
| 52 | ~G(); |
| 53 | }; |
| 54 | |
| 55 | G::~G() { } |
| 56 | |
Anders Carlsson | 5e96547 | 2009-04-30 23:18:11 +0000 | [diff] [blame] | 57 | // <rdar://problem/6841210> |
| 58 | struct H { |
| 59 | ~H(void) { } |
| 60 | }; |
Fariborz Jahanian | b154eca | 2009-07-21 15:28:50 +0000 | [diff] [blame] | 61 | |
| 62 | struct X {}; |
| 63 | |
| 64 | struct Y { |
| 65 | ~X(); // expected-error {{expected the class name after '~' to name the enclosing class}} |
| 66 | }; |
Douglas Gregor | 422f155 | 2010-02-25 18:11:54 +0000 | [diff] [blame] | 67 | |
| 68 | namespace PR6421 { |
| 69 | class T; // expected-note{{forward declaration}} |
| 70 | |
Douglas Gregor | 29d907d | 2010-09-17 22:25:06 +0000 | [diff] [blame] | 71 | class QGenericArgument // expected-note{{declared here}} |
Douglas Gregor | 422f155 | 2010-02-25 18:11:54 +0000 | [diff] [blame] | 72 | { |
| 73 | template<typename U> |
| 74 | void foo(T t) // expected-error{{variable has incomplete type}} |
| 75 | { } |
| 76 | |
| 77 | void disconnect() |
| 78 | { |
| 79 | T* t; |
Douglas Gregor | 29d907d | 2010-09-17 22:25:06 +0000 | [diff] [blame] | 80 | bob<QGenericArgument>(t); // expected-error{{undeclared identifier 'bob'}} \ |
| 81 | // expected-error{{does not refer to a value}} |
Douglas Gregor | 422f155 | 2010-02-25 18:11:54 +0000 | [diff] [blame] | 82 | } |
| 83 | }; |
| 84 | } |
Douglas Gregor | f956b35 | 2010-03-26 06:57:13 +0000 | [diff] [blame] | 85 | |
| 86 | namespace PR6709 { |
Hans Wennborg | 9125b08 | 2014-01-13 19:48:13 +0000 | [diff] [blame] | 87 | #ifdef MSABI |
| 88 | // This bug, "Clang instantiates destructor for function argument" is intended |
| 89 | // behaviour in the Microsoft ABI because the callee needs to destruct the arguments. |
| 90 | // expected-error@+3 {{indirection requires pointer operand ('int' invalid)}} |
| 91 | // expected-note@+3 {{in instantiation of member function 'PR6709::X<int>::~X' requested here}} |
| 92 | #endif |
Douglas Gregor | f956b35 | 2010-03-26 06:57:13 +0000 | [diff] [blame] | 93 | template<class T> class X { T v; ~X() { ++*v; } }; |
| 94 | void a(X<int> x) {} |
| 95 | } |
Douglas Gregor | 9575516 | 2010-07-01 05:10:53 +0000 | [diff] [blame] | 96 | |
| 97 | struct X0 { virtual ~X0() throw(); }; |
| 98 | struct X1 : public X0 { }; |
John McCall | 1e5d75d | 2010-07-03 18:33:00 +0000 | [diff] [blame] | 99 | |
| 100 | // Make sure we instantiate operator deletes when building a virtual |
| 101 | // destructor. |
| 102 | namespace test6 { |
| 103 | template <class T> class A { |
| 104 | public: |
Benjamin Kramer | ba62bda | 2010-07-03 20:33:13 +0000 | [diff] [blame] | 105 | void *operator new(__SIZE_TYPE__); |
John McCall | 1e5d75d | 2010-07-03 18:33:00 +0000 | [diff] [blame] | 106 | void operator delete(void *p) { |
| 107 | T::deleteIt(p); // expected-error {{type 'int' cannot be used prior to '::'}} |
| 108 | } |
| 109 | |
Hans Wennborg | 9125b08 | 2014-01-13 19:48:13 +0000 | [diff] [blame] | 110 | #ifdef MSABI |
| 111 | // expected-note@+2 {{in instantiation of member function 'test6::A<int>::operator delete' requested here}} |
| 112 | #endif |
Nick Lewycky | ef4f456 | 2010-11-25 00:35:20 +0000 | [diff] [blame] | 113 | virtual ~A() {} |
John McCall | 1e5d75d | 2010-07-03 18:33:00 +0000 | [diff] [blame] | 114 | }; |
| 115 | |
Hans Wennborg | 9125b08 | 2014-01-13 19:48:13 +0000 | [diff] [blame] | 116 | #ifndef MSABI |
| 117 | // expected-note@+2 {{in instantiation of member function 'test6::A<int>::operator delete' requested here}} |
| 118 | #endif |
| 119 | class B : A<int> { B(); }; |
Nick Lewycky | ef4f456 | 2010-11-25 00:35:20 +0000 | [diff] [blame] | 120 | B::B() {} |
John McCall | 1e5d75d | 2010-07-03 18:33:00 +0000 | [diff] [blame] | 121 | } |
John McCall | 12d53da | 2010-08-12 00:57:17 +0000 | [diff] [blame] | 122 | |
| 123 | // Make sure classes are marked invalid when they have invalid |
| 124 | // members. This avoids a crash-on-invalid. |
| 125 | namespace test7 { |
| 126 | struct A { |
| 127 | ~A() const; // expected-error {{'const' qualifier is not allowed on a destructor}} |
| 128 | }; |
| 129 | struct B : A {}; |
| 130 | |
| 131 | void test() { |
| 132 | B *b; |
| 133 | b->~B(); |
| 134 | } |
| 135 | } |
Argyrios Kyrtzidis | 7f3986d | 2011-01-31 07:05:00 +0000 | [diff] [blame] | 136 | |
| 137 | namespace nonvirtualdtor { |
| 138 | struct S1 { // expected-warning {{has virtual functions but non-virtual destructor}} |
| 139 | virtual void m(); |
| 140 | }; |
| 141 | |
| 142 | struct S2 { |
| 143 | ~S2(); // expected-warning {{has virtual functions but non-virtual destructor}} |
| 144 | virtual void m(); |
| 145 | }; |
| 146 | |
| 147 | struct S3 : public S1 { // expected-warning {{has virtual functions but non-virtual destructor}} |
| 148 | virtual void m(); |
| 149 | }; |
| 150 | |
| 151 | struct S4 : public S2 { // expected-warning {{has virtual functions but non-virtual destructor}} |
| 152 | virtual void m(); |
| 153 | }; |
| 154 | |
| 155 | struct B { |
| 156 | virtual ~B(); |
| 157 | virtual void m(); |
| 158 | }; |
| 159 | |
| 160 | struct S5 : public B { |
| 161 | virtual void m(); |
| 162 | }; |
Argyrios Kyrtzidis | 33799ca | 2011-01-31 17:10:25 +0000 | [diff] [blame] | 163 | |
| 164 | struct S6 { |
| 165 | virtual void m(); |
| 166 | private: |
| 167 | ~S6(); |
| 168 | }; |
| 169 | |
| 170 | struct S7 { |
| 171 | virtual void m(); |
| 172 | protected: |
| 173 | ~S7(); |
| 174 | }; |
Argyrios Kyrtzidis | 83b797f | 2011-02-02 18:47:41 +0000 | [diff] [blame] | 175 | |
| 176 | template<class T> class TS : public B { |
| 177 | virtual void m(); |
| 178 | }; |
| 179 | |
| 180 | TS<int> baz; |
| 181 | |
| 182 | template<class T> class TS2 { // expected-warning {{'nonvirtualdtor::TS2<int>' has virtual functions but non-virtual destructor}} |
| 183 | virtual void m(); |
| 184 | }; |
| 185 | |
| 186 | TS2<int> foo; // expected-note {{instantiation}} |
Argyrios Kyrtzidis | 7f3986d | 2011-01-31 07:05:00 +0000 | [diff] [blame] | 187 | } |
Douglas Gregor | 0cf82f6 | 2011-02-19 19:14:36 +0000 | [diff] [blame] | 188 | |
Argyrios Kyrtzidis | 8bd4285 | 2011-05-24 19:53:26 +0000 | [diff] [blame] | 189 | namespace dnvd { // delete-non-virtual-dtor warning |
| 190 | struct NP {}; |
| 191 | |
| 192 | struct B { // expected-warning {{has virtual functions but non-virtual destructor}} |
| 193 | virtual void foo(); |
| 194 | }; |
| 195 | |
| 196 | struct D: B {}; // expected-warning {{has virtual functions but non-virtual destructor}} |
| 197 | |
David Blaikie | 04e2e66 | 2014-05-09 22:02:28 +0000 | [diff] [blame] | 198 | struct F final : B {}; |
Argyrios Kyrtzidis | 8bd4285 | 2011-05-24 19:53:26 +0000 | [diff] [blame] | 199 | |
| 200 | struct VB { |
| 201 | virtual void foo(); |
| 202 | virtual ~VB(); |
| 203 | }; |
| 204 | |
| 205 | struct VD: VB {}; |
| 206 | |
| 207 | struct VF final: VB {}; |
| 208 | |
| 209 | template <typename T> |
| 210 | class simple_ptr { |
| 211 | public: |
| 212 | simple_ptr(T* t): _ptr(t) {} |
| 213 | ~simple_ptr() { delete _ptr; } // \ |
| 214 | // expected-warning {{delete called on 'dnvd::B' that has virtual functions but non-virtual destructor}} \ |
| 215 | // expected-warning {{delete called on 'dnvd::D' that has virtual functions but non-virtual destructor}} |
| 216 | T& operator*() const { return *_ptr; } |
| 217 | private: |
| 218 | T* _ptr; |
| 219 | }; |
| 220 | |
| 221 | template <typename T> |
| 222 | class simple_ptr2 { |
| 223 | public: |
| 224 | simple_ptr2(T* t): _ptr(t) {} |
| 225 | ~simple_ptr2() { delete _ptr; } // expected-warning {{delete called on 'dnvd::B' that has virtual functions but non-virtual destructor}} |
| 226 | T& operator*() const { return *_ptr; } |
| 227 | private: |
| 228 | T* _ptr; |
| 229 | }; |
| 230 | |
| 231 | void use(B&); |
| 232 | void use(VB&); |
| 233 | |
| 234 | void nowarnstack() { |
| 235 | B b; use(b); |
| 236 | D d; use(d); |
| 237 | F f; use(f); |
| 238 | VB vb; use(vb); |
| 239 | VD vd; use(vd); |
| 240 | VF vf; use(vf); |
| 241 | } |
| 242 | |
| 243 | void nowarnnonpoly() { |
| 244 | { |
| 245 | NP* np = new NP(); |
| 246 | delete np; |
| 247 | } |
| 248 | { |
| 249 | NP* np = new NP[4]; |
| 250 | delete[] np; |
| 251 | } |
| 252 | } |
| 253 | |
| 254 | void nowarnarray() { |
| 255 | { |
| 256 | B* b = new B[4]; |
| 257 | delete[] b; |
| 258 | } |
| 259 | { |
| 260 | D* d = new D[4]; |
| 261 | delete[] d; |
| 262 | } |
| 263 | { |
| 264 | VB* vb = new VB[4]; |
| 265 | delete[] vb; |
| 266 | } |
| 267 | { |
| 268 | VD* vd = new VD[4]; |
| 269 | delete[] vd; |
| 270 | } |
| 271 | } |
| 272 | |
| 273 | template <typename T> |
| 274 | void nowarntemplate() { |
| 275 | { |
| 276 | T* t = new T(); |
| 277 | delete t; |
| 278 | } |
| 279 | { |
| 280 | T* t = new T[4]; |
| 281 | delete[] t; |
| 282 | } |
| 283 | } |
| 284 | |
| 285 | void nowarn0() { |
| 286 | { |
| 287 | F* f = new F(); |
| 288 | delete f; |
| 289 | } |
| 290 | { |
| 291 | VB* vb = new VB(); |
| 292 | delete vb; |
| 293 | } |
| 294 | { |
| 295 | VB* vb = new VD(); |
| 296 | delete vb; |
| 297 | } |
| 298 | { |
| 299 | VD* vd = new VD(); |
| 300 | delete vd; |
| 301 | } |
| 302 | { |
| 303 | VF* vf = new VF(); |
| 304 | delete vf; |
| 305 | } |
| 306 | } |
| 307 | |
| 308 | void warn0() { |
| 309 | { |
| 310 | B* b = new B(); |
| 311 | delete b; // expected-warning {{delete called on 'dnvd::B' that has virtual functions but non-virtual destructor}} |
| 312 | } |
| 313 | { |
| 314 | B* b = new D(); |
| 315 | delete b; // expected-warning {{delete called on 'dnvd::B' that has virtual functions but non-virtual destructor}} |
| 316 | } |
| 317 | { |
| 318 | D* d = new D(); |
| 319 | delete d; // expected-warning {{delete called on 'dnvd::D' that has virtual functions but non-virtual destructor}} |
| 320 | } |
| 321 | } |
| 322 | |
| 323 | void nowarn1() { |
| 324 | { |
| 325 | simple_ptr<F> f(new F()); |
| 326 | use(*f); |
| 327 | } |
| 328 | { |
| 329 | simple_ptr<VB> vb(new VB()); |
| 330 | use(*vb); |
| 331 | } |
| 332 | { |
| 333 | simple_ptr<VB> vb(new VD()); |
| 334 | use(*vb); |
| 335 | } |
| 336 | { |
| 337 | simple_ptr<VD> vd(new VD()); |
| 338 | use(*vd); |
| 339 | } |
| 340 | { |
| 341 | simple_ptr<VF> vf(new VF()); |
| 342 | use(*vf); |
| 343 | } |
| 344 | } |
| 345 | |
| 346 | void warn1() { |
| 347 | { |
| 348 | simple_ptr<B> b(new B()); // expected-note {{in instantiation of member function 'dnvd::simple_ptr<dnvd::B>::~simple_ptr' requested here}} |
| 349 | use(*b); |
| 350 | } |
| 351 | { |
| 352 | simple_ptr2<B> b(new D()); // expected-note {{in instantiation of member function 'dnvd::simple_ptr2<dnvd::B>::~simple_ptr2' requested here}} |
| 353 | use(*b); |
| 354 | } |
| 355 | { |
| 356 | simple_ptr<D> d(new D()); // expected-note {{in instantiation of member function 'dnvd::simple_ptr<dnvd::D>::~simple_ptr' requested here}} |
| 357 | use(*d); |
| 358 | } |
| 359 | } |
| 360 | } |
| 361 | |
Douglas Gregor | 0cf82f6 | 2011-02-19 19:14:36 +0000 | [diff] [blame] | 362 | namespace PR9238 { |
| 363 | class B { public: ~B(); }; |
| 364 | class C : virtual B { public: ~C() { } }; |
| 365 | } |
Douglas Gregor | 4cf85a7 | 2011-03-04 22:32:08 +0000 | [diff] [blame] | 366 | |
| 367 | namespace PR7900 { |
| 368 | struct A { // expected-note 2{{type 'PR7900::A' is declared here}} |
| 369 | }; |
| 370 | struct B : public A { |
| 371 | }; |
| 372 | void foo() { |
| 373 | B b; |
| 374 | b.~B(); |
| 375 | b.~A(); // expected-error{{destructor type 'PR7900::A' in object destruction expression does not match the type 'PR7900::B' of the object being destroyed}} |
| 376 | (&b)->~A(); // expected-error{{destructor type 'PR7900::A' in object destruction expression does not match the type 'PR7900::B' of the object being destroyed}} |
| 377 | } |
| 378 | } |
Benjamin Kramer | 915d169 | 2013-10-10 09:44:41 +0000 | [diff] [blame] | 379 | |
| 380 | namespace PR16892 { |
| 381 | auto p = &A::~A; // expected-error{{taking the address of a destructor}} |
| 382 | } |