Chris Lattner | 5aa9e3e | 2002-05-24 20:42:13 +0000 | [diff] [blame] | 1 | //===- FunctionResolution.cpp - Resolve declarations to implementations ---===// |
John Criswell | 482202a | 2003-10-20 19:43:21 +0000 | [diff] [blame] | 2 | // |
| 3 | // The LLVM Compiler Infrastructure |
| 4 | // |
| 5 | // This file was developed by the LLVM research group and is distributed under |
| 6 | // the University of Illinois Open Source License. See LICENSE.TXT for details. |
| 7 | // |
| 8 | //===----------------------------------------------------------------------===// |
Chris Lattner | 5aa9e3e | 2002-05-24 20:42:13 +0000 | [diff] [blame] | 9 | // |
| 10 | // Loop over the functions that are in the module and look for functions that |
| 11 | // have the same name. More often than not, there will be things like: |
| 12 | // |
| 13 | // declare void %foo(...) |
| 14 | // void %foo(int, int) { ... } |
| 15 | // |
| 16 | // because of the way things are declared in C. If this is the case, patch |
| 17 | // things up. |
| 18 | // |
| 19 | //===----------------------------------------------------------------------===// |
| 20 | |
Chris Lattner | 5afe2f2 | 2002-07-23 22:04:02 +0000 | [diff] [blame] | 21 | #include "llvm/Transforms/IPO.h" |
Chris Lattner | 5aa9e3e | 2002-05-24 20:42:13 +0000 | [diff] [blame] | 22 | #include "llvm/Module.h" |
Chris Lattner | 5aa9e3e | 2002-05-24 20:42:13 +0000 | [diff] [blame] | 23 | #include "llvm/DerivedTypes.h" |
| 24 | #include "llvm/Pass.h" |
| 25 | #include "llvm/iOther.h" |
Chris Lattner | 013eca00 | 2002-10-09 21:10:06 +0000 | [diff] [blame] | 26 | #include "llvm/Constants.h" |
Chris Lattner | 4cd99ff | 2003-10-22 03:35:34 +0000 | [diff] [blame] | 27 | #include "llvm/Target/TargetData.h" |
Chris Lattner | cbf0839 | 2003-08-13 22:15:04 +0000 | [diff] [blame] | 28 | #include "llvm/Assembly/Writer.h" |
Chris Lattner | bf3a099 | 2002-10-01 22:38:41 +0000 | [diff] [blame] | 29 | #include "Support/Statistic.h" |
Chris Lattner | 5aa9e3e | 2002-05-24 20:42:13 +0000 | [diff] [blame] | 30 | #include <algorithm> |
| 31 | |
Chris Lattner | 5aa9e3e | 2002-05-24 20:42:13 +0000 | [diff] [blame] | 32 | namespace { |
Chris Lattner | bf3a099 | 2002-10-01 22:38:41 +0000 | [diff] [blame] | 33 | Statistic<>NumResolved("funcresolve", "Number of varargs functions resolved"); |
Chris Lattner | 013eca00 | 2002-10-09 21:10:06 +0000 | [diff] [blame] | 34 | Statistic<> NumGlobals("funcresolve", "Number of global variables resolved"); |
Chris Lattner | 5aa9e3e | 2002-05-24 20:42:13 +0000 | [diff] [blame] | 35 | |
| 36 | struct FunctionResolvingPass : public Pass { |
Chris Lattner | 4cd99ff | 2003-10-22 03:35:34 +0000 | [diff] [blame] | 37 | virtual void getAnalysisUsage(AnalysisUsage &AU) const { |
| 38 | AU.addRequired<TargetData>(); |
| 39 | } |
| 40 | |
Chris Lattner | 113f4f4 | 2002-06-25 16:13:24 +0000 | [diff] [blame] | 41 | bool run(Module &M); |
Chris Lattner | 5aa9e3e | 2002-05-24 20:42:13 +0000 | [diff] [blame] | 42 | }; |
Chris Lattner | a2c0985 | 2002-07-26 21:12:44 +0000 | [diff] [blame] | 43 | RegisterOpt<FunctionResolvingPass> X("funcresolve", "Resolve Functions"); |
Chris Lattner | 5aa9e3e | 2002-05-24 20:42:13 +0000 | [diff] [blame] | 44 | } |
| 45 | |
| 46 | Pass *createFunctionResolvingPass() { |
| 47 | return new FunctionResolvingPass(); |
| 48 | } |
| 49 | |
Chris Lattner | b2d9f7d | 2003-01-30 18:22:32 +0000 | [diff] [blame] | 50 | static bool ResolveFunctions(Module &M, std::vector<GlobalValue*> &Globals, |
Chris Lattner | 013eca00 | 2002-10-09 21:10:06 +0000 | [diff] [blame] | 51 | Function *Concrete) { |
| 52 | bool Changed = false; |
| 53 | for (unsigned i = 0; i != Globals.size(); ++i) |
| 54 | if (Globals[i] != Concrete) { |
| 55 | Function *Old = cast<Function>(Globals[i]); |
| 56 | const FunctionType *OldMT = Old->getFunctionType(); |
| 57 | const FunctionType *ConcreteMT = Concrete->getFunctionType(); |
| 58 | |
Chris Lattner | 9810b94 | 2003-04-28 01:23:29 +0000 | [diff] [blame] | 59 | if (OldMT->getParamTypes().size() > ConcreteMT->getParamTypes().size() && |
Chris Lattner | 50cbb90 | 2003-03-03 19:57:46 +0000 | [diff] [blame] | 60 | !ConcreteMT->isVarArg()) |
Chris Lattner | dbb05b0 | 2003-02-27 20:55:48 +0000 | [diff] [blame] | 61 | if (!Old->use_empty()) { |
| 62 | std::cerr << "WARNING: Linking function '" << Old->getName() |
| 63 | << "' is causing arguments to be dropped.\n"; |
| 64 | std::cerr << "WARNING: Prototype: "; |
| 65 | WriteAsOperand(std::cerr, Old); |
| 66 | std::cerr << " resolved to "; |
| 67 | WriteAsOperand(std::cerr, Concrete); |
| 68 | std::cerr << "\n"; |
| 69 | } |
Chris Lattner | 013eca00 | 2002-10-09 21:10:06 +0000 | [diff] [blame] | 70 | |
| 71 | // Check to make sure that if there are specified types, that they |
| 72 | // match... |
| 73 | // |
Chris Lattner | dbb05b0 | 2003-02-27 20:55:48 +0000 | [diff] [blame] | 74 | unsigned NumArguments = std::min(OldMT->getParamTypes().size(), |
| 75 | ConcreteMT->getParamTypes().size()); |
| 76 | |
Chris Lattner | 50cbb90 | 2003-03-03 19:57:46 +0000 | [diff] [blame] | 77 | if (!Old->use_empty() && !Concrete->use_empty()) |
| 78 | for (unsigned i = 0; i < NumArguments; ++i) |
Chris Lattner | 6fc0ee9 | 2003-08-23 20:03:05 +0000 | [diff] [blame] | 79 | if (OldMT->getParamTypes()[i] != ConcreteMT->getParamTypes()[i]) |
Chris Lattner | 015d98e | 2003-08-20 23:50:38 +0000 | [diff] [blame] | 80 | if (OldMT->getParamTypes()[i]->getPrimitiveID() != |
Chris Lattner | 6fc0ee9 | 2003-08-23 20:03:05 +0000 | [diff] [blame] | 81 | ConcreteMT->getParamTypes()[i]->getPrimitiveID()) { |
| 82 | std::cerr << "WARNING: Function [" << Old->getName() |
| 83 | << "]: Parameter types conflict for: '" << OldMT |
| 84 | << "' and '" << ConcreteMT << "'\n"; |
Chris Lattner | 015d98e | 2003-08-20 23:50:38 +0000 | [diff] [blame] | 85 | return Changed; |
Chris Lattner | 6fc0ee9 | 2003-08-23 20:03:05 +0000 | [diff] [blame] | 86 | } |
Chris Lattner | 013eca00 | 2002-10-09 21:10:06 +0000 | [diff] [blame] | 87 | |
Chris Lattner | 9810b94 | 2003-04-28 01:23:29 +0000 | [diff] [blame] | 88 | // Attempt to convert all of the uses of the old function to the concrete |
| 89 | // form of the function. If there is a use of the fn that we don't |
| 90 | // understand here we punt to avoid making a bad transformation. |
Chris Lattner | 013eca00 | 2002-10-09 21:10:06 +0000 | [diff] [blame] | 91 | // |
Chris Lattner | 9810b94 | 2003-04-28 01:23:29 +0000 | [diff] [blame] | 92 | // At this point, we know that the return values are the same for our two |
| 93 | // functions and that the Old function has no varargs fns specified. In |
| 94 | // otherwords it's just <retty> (...) |
Chris Lattner | 013eca00 | 2002-10-09 21:10:06 +0000 | [diff] [blame] | 95 | // |
Chris Lattner | e934022 | 2003-07-23 22:03:18 +0000 | [diff] [blame] | 96 | if (!Old->use_empty()) { // Avoid making the CPR unless we really need it |
| 97 | Value *Replacement = Concrete; |
| 98 | if (Concrete->getType() != Old->getType()) |
| 99 | Replacement = ConstantExpr::getCast(ConstantPointerRef::get(Concrete), |
| 100 | Old->getType()); |
| 101 | NumResolved += Old->use_size(); |
| 102 | Old->replaceAllUsesWith(Replacement); |
| 103 | } |
Chris Lattner | 0804368 | 2003-05-31 21:08:45 +0000 | [diff] [blame] | 104 | |
| 105 | // Since there are no uses of Old anymore, remove it from the module. |
| 106 | M.getFunctionList().erase(Old); |
Chris Lattner | 013eca00 | 2002-10-09 21:10:06 +0000 | [diff] [blame] | 107 | } |
| 108 | return Changed; |
| 109 | } |
| 110 | |
| 111 | |
Chris Lattner | b2d9f7d | 2003-01-30 18:22:32 +0000 | [diff] [blame] | 112 | static bool ResolveGlobalVariables(Module &M, |
| 113 | std::vector<GlobalValue*> &Globals, |
Chris Lattner | 013eca00 | 2002-10-09 21:10:06 +0000 | [diff] [blame] | 114 | GlobalVariable *Concrete) { |
| 115 | bool Changed = false; |
Chris Lattner | defe5c7 | 2003-04-19 00:15:27 +0000 | [diff] [blame] | 116 | Constant *CCPR = ConstantPointerRef::get(Concrete); |
| 117 | |
Chris Lattner | 013eca00 | 2002-10-09 21:10:06 +0000 | [diff] [blame] | 118 | for (unsigned i = 0; i != Globals.size(); ++i) |
| 119 | if (Globals[i] != Concrete) { |
Chris Lattner | af2c00b | 2003-10-21 23:17:56 +0000 | [diff] [blame] | 120 | Constant *Cast = ConstantExpr::getCast(CCPR, Globals[i]->getType()); |
| 121 | Globals[i]->replaceAllUsesWith(Cast); |
Chris Lattner | defe5c7 | 2003-04-19 00:15:27 +0000 | [diff] [blame] | 122 | |
Chris Lattner | 013eca00 | 2002-10-09 21:10:06 +0000 | [diff] [blame] | 123 | // Since there are no uses of Old anymore, remove it from the module. |
Chris Lattner | af2c00b | 2003-10-21 23:17:56 +0000 | [diff] [blame] | 124 | M.getGlobalList().erase(cast<GlobalVariable>(Globals[i])); |
Chris Lattner | 013eca00 | 2002-10-09 21:10:06 +0000 | [diff] [blame] | 125 | |
| 126 | ++NumGlobals; |
| 127 | Changed = true; |
| 128 | } |
| 129 | return Changed; |
| 130 | } |
| 131 | |
Chris Lattner | 4cd99ff | 2003-10-22 03:35:34 +0000 | [diff] [blame] | 132 | static bool ProcessGlobalsWithSameName(Module &M, TargetData &TD, |
Chris Lattner | b2d9f7d | 2003-01-30 18:22:32 +0000 | [diff] [blame] | 133 | std::vector<GlobalValue*> &Globals) { |
Chris Lattner | 013eca00 | 2002-10-09 21:10:06 +0000 | [diff] [blame] | 134 | assert(!Globals.empty() && "Globals list shouldn't be empty here!"); |
| 135 | |
| 136 | bool isFunction = isa<Function>(Globals[0]); // Is this group all functions? |
Chris Lattner | 013eca00 | 2002-10-09 21:10:06 +0000 | [diff] [blame] | 137 | GlobalValue *Concrete = 0; // The most concrete implementation to resolve to |
| 138 | |
Chris Lattner | 013eca00 | 2002-10-09 21:10:06 +0000 | [diff] [blame] | 139 | for (unsigned i = 0; i != Globals.size(); ) { |
| 140 | if (isa<Function>(Globals[i]) != isFunction) { |
| 141 | std::cerr << "WARNING: Found function and global variable with the " |
| 142 | << "same name: '" << Globals[i]->getName() << "'.\n"; |
| 143 | return false; // Don't know how to handle this, bail out! |
| 144 | } |
| 145 | |
Chris Lattner | 52b8fc0 | 2002-11-10 03:36:55 +0000 | [diff] [blame] | 146 | if (isFunction) { |
Chris Lattner | 013eca00 | 2002-10-09 21:10:06 +0000 | [diff] [blame] | 147 | // For functions, we look to merge functions definitions of "int (...)" |
| 148 | // to 'int (int)' or 'int ()' or whatever else is not completely generic. |
| 149 | // |
| 150 | Function *F = cast<Function>(Globals[i]); |
Chris Lattner | 5997c3d | 2002-11-08 00:38:20 +0000 | [diff] [blame] | 151 | if (!F->isExternal()) { |
Chris Lattner | 52b8fc0 | 2002-11-10 03:36:55 +0000 | [diff] [blame] | 152 | if (Concrete && !Concrete->isExternal()) |
Chris Lattner | 013eca00 | 2002-10-09 21:10:06 +0000 | [diff] [blame] | 153 | return false; // Found two different functions types. Can't choose! |
| 154 | |
| 155 | Concrete = Globals[i]; |
Chris Lattner | 52b8fc0 | 2002-11-10 03:36:55 +0000 | [diff] [blame] | 156 | } else if (Concrete) { |
| 157 | if (Concrete->isExternal()) // If we have multiple external symbols...x |
| 158 | if (F->getFunctionType()->getNumParams() > |
| 159 | cast<Function>(Concrete)->getFunctionType()->getNumParams()) |
| 160 | Concrete = F; // We are more concrete than "Concrete"! |
| 161 | |
| 162 | } else { |
| 163 | Concrete = F; |
Chris Lattner | 013eca00 | 2002-10-09 21:10:06 +0000 | [diff] [blame] | 164 | } |
Chris Lattner | 013eca00 | 2002-10-09 21:10:06 +0000 | [diff] [blame] | 165 | } else { |
Chris Lattner | 013eca00 | 2002-10-09 21:10:06 +0000 | [diff] [blame] | 166 | GlobalVariable *GV = cast<GlobalVariable>(Globals[i]); |
Chris Lattner | af2c00b | 2003-10-21 23:17:56 +0000 | [diff] [blame] | 167 | if (!GV->isExternal()) { |
| 168 | if (Concrete) { |
| 169 | std::cerr << "WARNING: Two global variables with external linkage" |
| 170 | << " exist with the same name: '" << GV->getName() |
| 171 | << "'!\n"; |
| 172 | return false; |
Chris Lattner | 013eca00 | 2002-10-09 21:10:06 +0000 | [diff] [blame] | 173 | } |
Chris Lattner | af2c00b | 2003-10-21 23:17:56 +0000 | [diff] [blame] | 174 | Concrete = GV; |
Chris Lattner | 013eca00 | 2002-10-09 21:10:06 +0000 | [diff] [blame] | 175 | } |
Chris Lattner | 013eca00 | 2002-10-09 21:10:06 +0000 | [diff] [blame] | 176 | } |
Chris Lattner | defe5c7 | 2003-04-19 00:15:27 +0000 | [diff] [blame] | 177 | ++i; |
Chris Lattner | 013eca00 | 2002-10-09 21:10:06 +0000 | [diff] [blame] | 178 | } |
| 179 | |
| 180 | if (Globals.size() > 1) { // Found a multiply defined global... |
Chris Lattner | 2b13296 | 2003-05-31 21:57:06 +0000 | [diff] [blame] | 181 | // If there are no external declarations, and there is at most one |
| 182 | // externally visible instance of the global, then there is nothing to do. |
| 183 | // |
| 184 | bool HasExternal = false; |
| 185 | unsigned NumInstancesWithExternalLinkage = 0; |
| 186 | |
| 187 | for (unsigned i = 0, e = Globals.size(); i != e; ++i) { |
| 188 | if (Globals[i]->isExternal()) |
| 189 | HasExternal = true; |
| 190 | else if (!Globals[i]->hasInternalLinkage()) |
| 191 | NumInstancesWithExternalLinkage++; |
| 192 | } |
| 193 | |
| 194 | if (!HasExternal && NumInstancesWithExternalLinkage <= 1) |
| 195 | return false; // Nothing to do? Must have multiple internal definitions. |
| 196 | |
| 197 | |
Chris Lattner | af2c00b | 2003-10-21 23:17:56 +0000 | [diff] [blame] | 198 | std::cerr << "WARNING: Found global types that are not compatible:\n"; |
| 199 | for (unsigned i = 0; i < Globals.size(); ++i) { |
| 200 | std::cerr << "\t" << *Globals[i]->getType() << " %" |
| 201 | << Globals[i]->getName() << "\n"; |
Chris Lattner | 013eca00 | 2002-10-09 21:10:06 +0000 | [diff] [blame] | 202 | } |
| 203 | |
Chris Lattner | af2c00b | 2003-10-21 23:17:56 +0000 | [diff] [blame] | 204 | if (!Concrete) |
| 205 | Concrete = Globals[0]; |
Chris Lattner | 4cd99ff | 2003-10-22 03:35:34 +0000 | [diff] [blame] | 206 | else if (GlobalVariable *GV = dyn_cast<GlobalVariable>(Concrete)) { |
| 207 | // Handle special case hack to change globals if it will make their types |
| 208 | // happier in the long run. The situation we do this is intentionally |
| 209 | // extremely limited. |
| 210 | if (GV->use_empty() && GV->hasInitializer() && |
| 211 | GV->getInitializer()->isNullValue()) { |
| 212 | // Check to see if there is another (external) global with the same size |
| 213 | // and a non-empty use-list. If so, we will make IT be the real |
| 214 | // implementation. |
| 215 | unsigned TS = TD.getTypeSize(Concrete->getType()->getElementType()); |
| 216 | for (unsigned i = 0, e = Globals.size(); i != e; ++i) |
| 217 | if (Globals[i] != Concrete && !Globals[i]->use_empty() && |
| 218 | isa<GlobalVariable>(Globals[i]) && |
| 219 | TD.getTypeSize(Globals[i]->getType()->getElementType()) == TS) { |
| 220 | // At this point we want to replace Concrete with Globals[i]. Make |
| 221 | // concrete external, and Globals[i] have an initializer. |
| 222 | GlobalVariable *NGV = cast<GlobalVariable>(Globals[i]); |
| 223 | const Type *ElTy = NGV->getType()->getElementType(); |
| 224 | NGV->setInitializer(Constant::getNullValue(ElTy)); |
| 225 | cast<GlobalVariable>(Concrete)->setInitializer(0); |
| 226 | Concrete = NGV; |
| 227 | break; |
| 228 | } |
| 229 | } |
| 230 | } |
Chris Lattner | af2c00b | 2003-10-21 23:17:56 +0000 | [diff] [blame] | 231 | |
Chris Lattner | 013eca00 | 2002-10-09 21:10:06 +0000 | [diff] [blame] | 232 | if (isFunction) |
Chris Lattner | defe5c7 | 2003-04-19 00:15:27 +0000 | [diff] [blame] | 233 | return ResolveFunctions(M, Globals, cast<Function>(Concrete)); |
Chris Lattner | 013eca00 | 2002-10-09 21:10:06 +0000 | [diff] [blame] | 234 | else |
Chris Lattner | defe5c7 | 2003-04-19 00:15:27 +0000 | [diff] [blame] | 235 | return ResolveGlobalVariables(M, Globals, |
| 236 | cast<GlobalVariable>(Concrete)); |
Chris Lattner | 013eca00 | 2002-10-09 21:10:06 +0000 | [diff] [blame] | 237 | } |
Chris Lattner | defe5c7 | 2003-04-19 00:15:27 +0000 | [diff] [blame] | 238 | return false; |
Chris Lattner | 013eca00 | 2002-10-09 21:10:06 +0000 | [diff] [blame] | 239 | } |
| 240 | |
Chris Lattner | 113f4f4 | 2002-06-25 16:13:24 +0000 | [diff] [blame] | 241 | bool FunctionResolvingPass::run(Module &M) { |
Chris Lattner | b2d9f7d | 2003-01-30 18:22:32 +0000 | [diff] [blame] | 242 | std::map<std::string, std::vector<GlobalValue*> > Globals; |
Chris Lattner | 5aa9e3e | 2002-05-24 20:42:13 +0000 | [diff] [blame] | 243 | |
Chris Lattner | 12b3593 | 2003-10-22 04:42:20 +0000 | [diff] [blame^] | 244 | // Loop over the globals, adding them to the Globals map. We use a two pass |
| 245 | // algorithm here to avoid problems with iterators getting invalidated if we |
| 246 | // did a one pass scheme. |
Chris Lattner | 5aa9e3e | 2002-05-24 20:42:13 +0000 | [diff] [blame] | 247 | // |
Chris Lattner | 12b3593 | 2003-10-22 04:42:20 +0000 | [diff] [blame^] | 248 | for (Module::iterator I = M.begin(), E = M.end(); I != E; ) { |
| 249 | Function *F = I++; |
| 250 | if (F->use_empty() && F->isExternal()) |
| 251 | M.getFunctionList().erase(F); |
| 252 | else if (!F->hasInternalLinkage() && !F->getName().empty()) |
| 253 | Globals[F->getName()].push_back(F); |
| 254 | } |
| 255 | |
| 256 | for (Module::giterator I = M.gbegin(), E = M.gend(); I != E; ) { |
| 257 | GlobalVariable *GV = I++; |
| 258 | if (GV->use_empty() && GV->isExternal()) |
| 259 | M.getGlobalList().erase(GV); |
| 260 | else if (!GV->hasInternalLinkage() && !GV->getName().empty()) |
| 261 | Globals[GV->getName()].push_back(GV); |
| 262 | } |
Chris Lattner | 5aa9e3e | 2002-05-24 20:42:13 +0000 | [diff] [blame] | 263 | |
| 264 | bool Changed = false; |
| 265 | |
Chris Lattner | 4cd99ff | 2003-10-22 03:35:34 +0000 | [diff] [blame] | 266 | TargetData &TD = getAnalysis<TargetData>(); |
| 267 | |
Chris Lattner | 5aa9e3e | 2002-05-24 20:42:13 +0000 | [diff] [blame] | 268 | // Now we have a list of all functions with a particular name. If there is |
| 269 | // more than one entry in a list, merge the functions together. |
| 270 | // |
Chris Lattner | b2d9f7d | 2003-01-30 18:22:32 +0000 | [diff] [blame] | 271 | for (std::map<std::string, std::vector<GlobalValue*> >::iterator |
| 272 | I = Globals.begin(), E = Globals.end(); I != E; ++I) |
Chris Lattner | 4cd99ff | 2003-10-22 03:35:34 +0000 | [diff] [blame] | 273 | Changed |= ProcessGlobalsWithSameName(M, TD, I->second); |
Chris Lattner | 5aa9e3e | 2002-05-24 20:42:13 +0000 | [diff] [blame] | 274 | |
Chris Lattner | 52b8fc0 | 2002-11-10 03:36:55 +0000 | [diff] [blame] | 275 | // Now loop over all of the globals, checking to see if any are trivially |
| 276 | // dead. If so, remove them now. |
| 277 | |
| 278 | for (Module::iterator I = M.begin(), E = M.end(); I != E; ) |
| 279 | if (I->isExternal() && I->use_empty()) { |
| 280 | Function *F = I; |
| 281 | ++I; |
| 282 | M.getFunctionList().erase(F); |
| 283 | ++NumResolved; |
| 284 | Changed = true; |
| 285 | } else { |
| 286 | ++I; |
| 287 | } |
| 288 | |
| 289 | for (Module::giterator I = M.gbegin(), E = M.gend(); I != E; ) |
| 290 | if (I->isExternal() && I->use_empty()) { |
| 291 | GlobalVariable *GV = I; |
| 292 | ++I; |
| 293 | M.getGlobalList().erase(GV); |
| 294 | ++NumGlobals; |
| 295 | Changed = true; |
| 296 | } else { |
| 297 | ++I; |
| 298 | } |
| 299 | |
Chris Lattner | 5aa9e3e | 2002-05-24 20:42:13 +0000 | [diff] [blame] | 300 | return Changed; |
| 301 | } |