Adam Nemet | 9d9cb27 | 2016-02-18 21:38:19 +0000 | [diff] [blame] | 1 | //===-------- LoopDataPrefetch.cpp - Loop Data Prefetching Pass -----------===// |
Hal Finkel | e5aaf3f | 2015-02-20 05:08:21 +0000 | [diff] [blame] | 2 | // |
| 3 | // The LLVM Compiler Infrastructure |
| 4 | // |
| 5 | // This file is distributed under the University of Illinois Open Source |
| 6 | // License. See LICENSE.TXT for details. |
| 7 | // |
| 8 | //===----------------------------------------------------------------------===// |
| 9 | // |
| 10 | // This file implements a Loop Data Prefetching Pass. |
| 11 | // |
| 12 | //===----------------------------------------------------------------------===// |
| 13 | |
Adam Nemet | 7cf9b1b | 2016-02-18 21:37:12 +0000 | [diff] [blame] | 14 | #define DEBUG_TYPE "loop-data-prefetch" |
Hal Finkel | e5aaf3f | 2015-02-20 05:08:21 +0000 | [diff] [blame] | 15 | #include "llvm/Transforms/Scalar.h" |
Hal Finkel | a9fceb8 | 2015-04-10 15:05:02 +0000 | [diff] [blame] | 16 | #include "llvm/ADT/DepthFirstIterator.h" |
Hal Finkel | e5aaf3f | 2015-02-20 05:08:21 +0000 | [diff] [blame] | 17 | #include "llvm/ADT/Statistic.h" |
| 18 | #include "llvm/Analysis/AssumptionCache.h" |
| 19 | #include "llvm/Analysis/CodeMetrics.h" |
| 20 | #include "llvm/Analysis/InstructionSimplify.h" |
| 21 | #include "llvm/Analysis/LoopInfo.h" |
| 22 | #include "llvm/Analysis/ScalarEvolution.h" |
Chandler Carruth | 7b560d4 | 2015-09-09 17:55:00 +0000 | [diff] [blame] | 23 | #include "llvm/Analysis/ScalarEvolutionAliasAnalysis.h" |
Hal Finkel | e5aaf3f | 2015-02-20 05:08:21 +0000 | [diff] [blame] | 24 | #include "llvm/Analysis/ScalarEvolutionExpander.h" |
| 25 | #include "llvm/Analysis/ScalarEvolutionExpressions.h" |
| 26 | #include "llvm/Analysis/TargetTransformInfo.h" |
| 27 | #include "llvm/Analysis/ValueTracking.h" |
| 28 | #include "llvm/IR/CFG.h" |
Adam Nemet | 3c5eabf | 2016-05-05 00:08:15 +0000 | [diff] [blame] | 29 | #include "llvm/IR/DiagnosticInfo.h" |
Hal Finkel | e5aaf3f | 2015-02-20 05:08:21 +0000 | [diff] [blame] | 30 | #include "llvm/IR/Dominators.h" |
| 31 | #include "llvm/IR/Function.h" |
| 32 | #include "llvm/IR/IntrinsicInst.h" |
| 33 | #include "llvm/IR/Module.h" |
| 34 | #include "llvm/Support/CommandLine.h" |
| 35 | #include "llvm/Support/Debug.h" |
| 36 | #include "llvm/Transforms/Utils/BasicBlockUtils.h" |
| 37 | #include "llvm/Transforms/Utils/Local.h" |
| 38 | #include "llvm/Transforms/Utils/ValueMapper.h" |
| 39 | using namespace llvm; |
| 40 | |
| 41 | // By default, we limit this to creating 16 PHIs (which is a little over half |
| 42 | // of the allocatable register set). |
| 43 | static cl::opt<bool> |
Adam Nemet | 7cf9b1b | 2016-02-18 21:37:12 +0000 | [diff] [blame] | 44 | PrefetchWrites("loop-prefetch-writes", cl::Hidden, cl::init(false), |
Hal Finkel | e5aaf3f | 2015-02-20 05:08:21 +0000 | [diff] [blame] | 45 | cl::desc("Prefetch write addresses")); |
| 46 | |
Adam Nemet | 1428d41 | 2016-03-29 23:45:52 +0000 | [diff] [blame] | 47 | static cl::opt<unsigned> |
| 48 | PrefetchDistance("prefetch-distance", |
| 49 | cl::desc("Number of instructions to prefetch ahead"), |
| 50 | cl::Hidden); |
| 51 | |
| 52 | static cl::opt<unsigned> |
| 53 | MinPrefetchStride("min-prefetch-stride", |
| 54 | cl::desc("Min stride to add prefetches"), cl::Hidden); |
| 55 | |
| 56 | static cl::opt<unsigned> MaxPrefetchIterationsAhead( |
| 57 | "max-prefetch-iters-ahead", |
| 58 | cl::desc("Max number of iterations to prefetch ahead"), cl::Hidden); |
| 59 | |
Adam Nemet | 34785ec | 2016-03-09 05:33:21 +0000 | [diff] [blame] | 60 | STATISTIC(NumPrefetches, "Number of prefetches inserted"); |
| 61 | |
Hal Finkel | e5aaf3f | 2015-02-20 05:08:21 +0000 | [diff] [blame] | 62 | namespace llvm { |
Adam Nemet | 7cf9b1b | 2016-02-18 21:37:12 +0000 | [diff] [blame] | 63 | void initializeLoopDataPrefetchPass(PassRegistry&); |
Hal Finkel | e5aaf3f | 2015-02-20 05:08:21 +0000 | [diff] [blame] | 64 | } |
| 65 | |
| 66 | namespace { |
| 67 | |
Adam Nemet | 7cf9b1b | 2016-02-18 21:37:12 +0000 | [diff] [blame] | 68 | class LoopDataPrefetch : public FunctionPass { |
Hal Finkel | e5aaf3f | 2015-02-20 05:08:21 +0000 | [diff] [blame] | 69 | public: |
| 70 | static char ID; // Pass ID, replacement for typeid |
Adam Nemet | 7cf9b1b | 2016-02-18 21:37:12 +0000 | [diff] [blame] | 71 | LoopDataPrefetch() : FunctionPass(ID) { |
| 72 | initializeLoopDataPrefetchPass(*PassRegistry::getPassRegistry()); |
Hal Finkel | e5aaf3f | 2015-02-20 05:08:21 +0000 | [diff] [blame] | 73 | } |
| 74 | |
| 75 | void getAnalysisUsage(AnalysisUsage &AU) const override { |
| 76 | AU.addRequired<AssumptionCacheTracker>(); |
| 77 | AU.addPreserved<DominatorTreeWrapperPass>(); |
| 78 | AU.addRequired<LoopInfoWrapperPass>(); |
| 79 | AU.addPreserved<LoopInfoWrapperPass>(); |
Chandler Carruth | 2f1fd16 | 2015-08-17 02:08:17 +0000 | [diff] [blame] | 80 | AU.addRequired<ScalarEvolutionWrapperPass>(); |
Hal Finkel | e5aaf3f | 2015-02-20 05:08:21 +0000 | [diff] [blame] | 81 | // FIXME: For some reason, preserving SE here breaks LSR (even if |
| 82 | // this pass changes nothing). |
Chandler Carruth | 2f1fd16 | 2015-08-17 02:08:17 +0000 | [diff] [blame] | 83 | // AU.addPreserved<ScalarEvolutionWrapperPass>(); |
Hal Finkel | e5aaf3f | 2015-02-20 05:08:21 +0000 | [diff] [blame] | 84 | AU.addRequired<TargetTransformInfoWrapperPass>(); |
| 85 | } |
| 86 | |
| 87 | bool runOnFunction(Function &F) override; |
Adam Nemet | 85fba39 | 2016-03-29 22:40:02 +0000 | [diff] [blame] | 88 | |
| 89 | private: |
Hal Finkel | e5aaf3f | 2015-02-20 05:08:21 +0000 | [diff] [blame] | 90 | bool runOnLoop(Loop *L); |
| 91 | |
Adam Nemet | 6d8beec | 2016-03-18 00:27:38 +0000 | [diff] [blame] | 92 | /// \brief Check if the the stride of the accesses is large enough to |
| 93 | /// warrant a prefetch. |
| 94 | bool isStrideLargeEnough(const SCEVAddRecExpr *AR); |
| 95 | |
Adam Nemet | 1428d41 | 2016-03-29 23:45:52 +0000 | [diff] [blame] | 96 | unsigned getMinPrefetchStride() { |
| 97 | if (MinPrefetchStride.getNumOccurrences() > 0) |
| 98 | return MinPrefetchStride; |
| 99 | return TTI->getMinPrefetchStride(); |
| 100 | } |
| 101 | |
| 102 | unsigned getPrefetchDistance() { |
| 103 | if (PrefetchDistance.getNumOccurrences() > 0) |
| 104 | return PrefetchDistance; |
| 105 | return TTI->getPrefetchDistance(); |
| 106 | } |
| 107 | |
| 108 | unsigned getMaxPrefetchIterationsAhead() { |
| 109 | if (MaxPrefetchIterationsAhead.getNumOccurrences() > 0) |
| 110 | return MaxPrefetchIterationsAhead; |
| 111 | return TTI->getMaxPrefetchIterationsAhead(); |
| 112 | } |
| 113 | |
Hal Finkel | e5aaf3f | 2015-02-20 05:08:21 +0000 | [diff] [blame] | 114 | AssumptionCache *AC; |
| 115 | LoopInfo *LI; |
| 116 | ScalarEvolution *SE; |
| 117 | const TargetTransformInfo *TTI; |
| 118 | const DataLayout *DL; |
| 119 | }; |
Alexander Kornienko | f00654e | 2015-06-23 09:49:53 +0000 | [diff] [blame] | 120 | } |
Hal Finkel | e5aaf3f | 2015-02-20 05:08:21 +0000 | [diff] [blame] | 121 | |
Adam Nemet | 7cf9b1b | 2016-02-18 21:37:12 +0000 | [diff] [blame] | 122 | char LoopDataPrefetch::ID = 0; |
| 123 | INITIALIZE_PASS_BEGIN(LoopDataPrefetch, "loop-data-prefetch", |
| 124 | "Loop Data Prefetch", false, false) |
Hal Finkel | e5aaf3f | 2015-02-20 05:08:21 +0000 | [diff] [blame] | 125 | INITIALIZE_PASS_DEPENDENCY(AssumptionCacheTracker) |
| 126 | INITIALIZE_PASS_DEPENDENCY(TargetTransformInfoWrapperPass) |
| 127 | INITIALIZE_PASS_DEPENDENCY(LoopInfoWrapperPass) |
Chandler Carruth | 2f1fd16 | 2015-08-17 02:08:17 +0000 | [diff] [blame] | 128 | INITIALIZE_PASS_DEPENDENCY(ScalarEvolutionWrapperPass) |
Adam Nemet | 7cf9b1b | 2016-02-18 21:37:12 +0000 | [diff] [blame] | 129 | INITIALIZE_PASS_END(LoopDataPrefetch, "loop-data-prefetch", |
| 130 | "Loop Data Prefetch", false, false) |
Hal Finkel | e5aaf3f | 2015-02-20 05:08:21 +0000 | [diff] [blame] | 131 | |
Adam Nemet | 9d9cb27 | 2016-02-18 21:38:19 +0000 | [diff] [blame] | 132 | FunctionPass *llvm::createLoopDataPrefetchPass() { return new LoopDataPrefetch(); } |
Hal Finkel | e5aaf3f | 2015-02-20 05:08:21 +0000 | [diff] [blame] | 133 | |
Adam Nemet | 6d8beec | 2016-03-18 00:27:38 +0000 | [diff] [blame] | 134 | bool LoopDataPrefetch::isStrideLargeEnough(const SCEVAddRecExpr *AR) { |
Adam Nemet | 1428d41 | 2016-03-29 23:45:52 +0000 | [diff] [blame] | 135 | unsigned TargetMinStride = getMinPrefetchStride(); |
Adam Nemet | 6d8beec | 2016-03-18 00:27:38 +0000 | [diff] [blame] | 136 | // No need to check if any stride goes. |
| 137 | if (TargetMinStride <= 1) |
| 138 | return true; |
| 139 | |
| 140 | const auto *ConstStride = dyn_cast<SCEVConstant>(AR->getStepRecurrence(*SE)); |
| 141 | // If MinStride is set, don't prefetch unless we can ensure that stride is |
| 142 | // larger. |
| 143 | if (!ConstStride) |
| 144 | return false; |
| 145 | |
| 146 | unsigned AbsStride = std::abs(ConstStride->getAPInt().getSExtValue()); |
| 147 | return TargetMinStride <= AbsStride; |
| 148 | } |
| 149 | |
Adam Nemet | 7cf9b1b | 2016-02-18 21:37:12 +0000 | [diff] [blame] | 150 | bool LoopDataPrefetch::runOnFunction(Function &F) { |
Andrew Kaylor | 50271f7 | 2016-05-03 22:32:30 +0000 | [diff] [blame] | 151 | if (skipFunction(F)) |
| 152 | return false; |
| 153 | |
Hal Finkel | e5aaf3f | 2015-02-20 05:08:21 +0000 | [diff] [blame] | 154 | LI = &getAnalysis<LoopInfoWrapperPass>().getLoopInfo(); |
Chandler Carruth | 2f1fd16 | 2015-08-17 02:08:17 +0000 | [diff] [blame] | 155 | SE = &getAnalysis<ScalarEvolutionWrapperPass>().getSE(); |
Mehdi Amini | 46a4355 | 2015-03-04 18:43:29 +0000 | [diff] [blame] | 156 | DL = &F.getParent()->getDataLayout(); |
Hal Finkel | e5aaf3f | 2015-02-20 05:08:21 +0000 | [diff] [blame] | 157 | AC = &getAnalysis<AssumptionCacheTracker>().getAssumptionCache(F); |
| 158 | TTI = &getAnalysis<TargetTransformInfoWrapperPass>().getTTI(F); |
| 159 | |
Adam Nemet | bb3680b | 2016-03-07 18:35:42 +0000 | [diff] [blame] | 160 | // If PrefetchDistance is not set, don't run the pass. This gives an |
| 161 | // opportunity for targets to run this pass for selected subtargets only |
| 162 | // (whose TTI sets PrefetchDistance). |
Adam Nemet | 1428d41 | 2016-03-29 23:45:52 +0000 | [diff] [blame] | 163 | if (getPrefetchDistance() == 0) |
Adam Nemet | bb3680b | 2016-03-07 18:35:42 +0000 | [diff] [blame] | 164 | return false; |
Adam Nemet | af76110 | 2016-01-21 18:28:36 +0000 | [diff] [blame] | 165 | assert(TTI->getCacheLineSize() && "Cache line size is not set for target"); |
| 166 | |
Hal Finkel | e5aaf3f | 2015-02-20 05:08:21 +0000 | [diff] [blame] | 167 | bool MadeChange = false; |
| 168 | |
Benjamin Kramer | 135f735 | 2016-06-26 12:28:59 +0000 | [diff] [blame^] | 169 | for (Loop *I : *LI) |
| 170 | for (auto L = df_begin(I), LE = df_end(I); L != LE; ++L) |
Hal Finkel | 5551f25 | 2015-04-12 17:18:56 +0000 | [diff] [blame] | 171 | MadeChange |= runOnLoop(*L); |
Hal Finkel | e5aaf3f | 2015-02-20 05:08:21 +0000 | [diff] [blame] | 172 | |
| 173 | return MadeChange; |
| 174 | } |
| 175 | |
Adam Nemet | 7cf9b1b | 2016-02-18 21:37:12 +0000 | [diff] [blame] | 176 | bool LoopDataPrefetch::runOnLoop(Loop *L) { |
Hal Finkel | e5aaf3f | 2015-02-20 05:08:21 +0000 | [diff] [blame] | 177 | bool MadeChange = false; |
| 178 | |
| 179 | // Only prefetch in the inner-most loop |
| 180 | if (!L->empty()) |
| 181 | return MadeChange; |
| 182 | |
| 183 | SmallPtrSet<const Value *, 32> EphValues; |
| 184 | CodeMetrics::collectEphemeralValues(L, AC, EphValues); |
| 185 | |
| 186 | // Calculate the number of iterations ahead to prefetch |
| 187 | CodeMetrics Metrics; |
| 188 | for (Loop::block_iterator I = L->block_begin(), IE = L->block_end(); |
| 189 | I != IE; ++I) { |
| 190 | |
| 191 | // If the loop already has prefetches, then assume that the user knows |
Nico Weber | 2cf5e89 | 2016-06-10 20:06:03 +0000 | [diff] [blame] | 192 | // what they are doing and don't add any more. |
Hal Finkel | e5aaf3f | 2015-02-20 05:08:21 +0000 | [diff] [blame] | 193 | for (BasicBlock::iterator J = (*I)->begin(), JE = (*I)->end(); |
| 194 | J != JE; ++J) |
| 195 | if (CallInst *CI = dyn_cast<CallInst>(J)) |
| 196 | if (Function *F = CI->getCalledFunction()) |
| 197 | if (F->getIntrinsicID() == Intrinsic::prefetch) |
| 198 | return MadeChange; |
| 199 | |
| 200 | Metrics.analyzeBasicBlock(*I, *TTI, EphValues); |
| 201 | } |
| 202 | unsigned LoopSize = Metrics.NumInsts; |
| 203 | if (!LoopSize) |
| 204 | LoopSize = 1; |
| 205 | |
Adam Nemet | 1428d41 | 2016-03-29 23:45:52 +0000 | [diff] [blame] | 206 | unsigned ItersAhead = getPrefetchDistance() / LoopSize; |
Hal Finkel | e5aaf3f | 2015-02-20 05:08:21 +0000 | [diff] [blame] | 207 | if (!ItersAhead) |
| 208 | ItersAhead = 1; |
| 209 | |
Adam Nemet | 1428d41 | 2016-03-29 23:45:52 +0000 | [diff] [blame] | 210 | if (ItersAhead > getMaxPrefetchIterationsAhead()) |
Adam Nemet | 709e304 | 2016-03-18 00:27:43 +0000 | [diff] [blame] | 211 | return MadeChange; |
| 212 | |
Adam Nemet | 3c5eabf | 2016-05-05 00:08:15 +0000 | [diff] [blame] | 213 | Function *F = L->getHeader()->getParent(); |
Adam Nemet | 34785ec | 2016-03-09 05:33:21 +0000 | [diff] [blame] | 214 | DEBUG(dbgs() << "Prefetching " << ItersAhead |
| 215 | << " iterations ahead (loop size: " << LoopSize << ") in " |
Adam Nemet | 3c5eabf | 2016-05-05 00:08:15 +0000 | [diff] [blame] | 216 | << F->getName() << ": " << *L); |
Adam Nemet | 34785ec | 2016-03-09 05:33:21 +0000 | [diff] [blame] | 217 | |
Hal Finkel | e5aaf3f | 2015-02-20 05:08:21 +0000 | [diff] [blame] | 218 | SmallVector<std::pair<Instruction *, const SCEVAddRecExpr *>, 16> PrefLoads; |
| 219 | for (Loop::block_iterator I = L->block_begin(), IE = L->block_end(); |
| 220 | I != IE; ++I) { |
| 221 | for (BasicBlock::iterator J = (*I)->begin(), JE = (*I)->end(); |
| 222 | J != JE; ++J) { |
| 223 | Value *PtrValue; |
| 224 | Instruction *MemI; |
| 225 | |
| 226 | if (LoadInst *LMemI = dyn_cast<LoadInst>(J)) { |
| 227 | MemI = LMemI; |
| 228 | PtrValue = LMemI->getPointerOperand(); |
| 229 | } else if (StoreInst *SMemI = dyn_cast<StoreInst>(J)) { |
| 230 | if (!PrefetchWrites) continue; |
| 231 | MemI = SMemI; |
| 232 | PtrValue = SMemI->getPointerOperand(); |
| 233 | } else continue; |
| 234 | |
| 235 | unsigned PtrAddrSpace = PtrValue->getType()->getPointerAddressSpace(); |
| 236 | if (PtrAddrSpace) |
| 237 | continue; |
| 238 | |
| 239 | if (L->isLoopInvariant(PtrValue)) |
| 240 | continue; |
| 241 | |
| 242 | const SCEV *LSCEV = SE->getSCEV(PtrValue); |
| 243 | const SCEVAddRecExpr *LSCEVAddRec = dyn_cast<SCEVAddRecExpr>(LSCEV); |
| 244 | if (!LSCEVAddRec) |
| 245 | continue; |
| 246 | |
Adam Nemet | 6d8beec | 2016-03-18 00:27:38 +0000 | [diff] [blame] | 247 | // Check if the the stride of the accesses is large enough to warrant a |
| 248 | // prefetch. |
| 249 | if (!isStrideLargeEnough(LSCEVAddRec)) |
| 250 | continue; |
| 251 | |
Hal Finkel | e5aaf3f | 2015-02-20 05:08:21 +0000 | [diff] [blame] | 252 | // We don't want to double prefetch individual cache lines. If this load |
| 253 | // is known to be within one cache line of some other load that has |
| 254 | // already been prefetched, then don't prefetch this one as well. |
| 255 | bool DupPref = false; |
Benjamin Kramer | 135f735 | 2016-06-26 12:28:59 +0000 | [diff] [blame^] | 256 | for (const auto &PrefLoad : PrefLoads) { |
| 257 | const SCEV *PtrDiff = SE->getMinusSCEV(LSCEVAddRec, PrefLoad.second); |
Hal Finkel | e5aaf3f | 2015-02-20 05:08:21 +0000 | [diff] [blame] | 258 | if (const SCEVConstant *ConstPtrDiff = |
| 259 | dyn_cast<SCEVConstant>(PtrDiff)) { |
Benjamin Kramer | 7bd1f7c | 2015-03-09 20:20:16 +0000 | [diff] [blame] | 260 | int64_t PD = std::abs(ConstPtrDiff->getValue()->getSExtValue()); |
Adam Nemet | af76110 | 2016-01-21 18:28:36 +0000 | [diff] [blame] | 261 | if (PD < (int64_t) TTI->getCacheLineSize()) { |
Hal Finkel | e5aaf3f | 2015-02-20 05:08:21 +0000 | [diff] [blame] | 262 | DupPref = true; |
| 263 | break; |
| 264 | } |
| 265 | } |
| 266 | } |
| 267 | if (DupPref) |
| 268 | continue; |
| 269 | |
| 270 | const SCEV *NextLSCEV = SE->getAddExpr(LSCEVAddRec, SE->getMulExpr( |
| 271 | SE->getConstant(LSCEVAddRec->getType(), ItersAhead), |
| 272 | LSCEVAddRec->getStepRecurrence(*SE))); |
| 273 | if (!isSafeToExpand(NextLSCEV, *SE)) |
| 274 | continue; |
| 275 | |
| 276 | PrefLoads.push_back(std::make_pair(MemI, LSCEVAddRec)); |
| 277 | |
| 278 | Type *I8Ptr = Type::getInt8PtrTy((*I)->getContext(), PtrAddrSpace); |
Mehdi Amini | a28d91d | 2015-03-10 02:37:25 +0000 | [diff] [blame] | 279 | SCEVExpander SCEVE(*SE, J->getModule()->getDataLayout(), "prefaddr"); |
Hal Finkel | e5aaf3f | 2015-02-20 05:08:21 +0000 | [diff] [blame] | 280 | Value *PrefPtrValue = SCEVE.expandCodeFor(NextLSCEV, I8Ptr, MemI); |
| 281 | |
| 282 | IRBuilder<> Builder(MemI); |
| 283 | Module *M = (*I)->getParent()->getParent(); |
| 284 | Type *I32 = Type::getInt32Ty((*I)->getContext()); |
| 285 | Value *PrefetchFunc = Intrinsic::getDeclaration(M, Intrinsic::prefetch); |
David Blaikie | ff6409d | 2015-05-18 22:13:54 +0000 | [diff] [blame] | 286 | Builder.CreateCall( |
| 287 | PrefetchFunc, |
| 288 | {PrefPtrValue, |
| 289 | ConstantInt::get(I32, MemI->mayReadFromMemory() ? 0 : 1), |
| 290 | ConstantInt::get(I32, 3), ConstantInt::get(I32, 1)}); |
Adam Nemet | 34785ec | 2016-03-09 05:33:21 +0000 | [diff] [blame] | 291 | ++NumPrefetches; |
| 292 | DEBUG(dbgs() << " Access: " << *PtrValue << ", SCEV: " << *LSCEV |
| 293 | << "\n"); |
Adam Nemet | 3c5eabf | 2016-05-05 00:08:15 +0000 | [diff] [blame] | 294 | emitOptimizationRemark(F->getContext(), DEBUG_TYPE, *F, |
| 295 | MemI->getDebugLoc(), "prefetched memory access"); |
| 296 | |
Hal Finkel | e5aaf3f | 2015-02-20 05:08:21 +0000 | [diff] [blame] | 297 | |
| 298 | MadeChange = true; |
| 299 | } |
| 300 | } |
| 301 | |
| 302 | return MadeChange; |
| 303 | } |
| 304 | |