blob: 88e56e0d8f45822273741125ad2c783aca69c2ee [file] [log] [blame]
Chris Lattner2188e402010-01-04 07:37:31 +00001//===- InstCombineCompares.cpp --------------------------------------------===//
2//
Chandler Carruth2946cd72019-01-19 08:50:56 +00003// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
4// See https://llvm.org/LICENSE.txt for license information.
5// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
Chris Lattner2188e402010-01-04 07:37:31 +00006//
7//===----------------------------------------------------------------------===//
8//
9// This file implements the visitICmp and visitFCmp functions.
10//
11//===----------------------------------------------------------------------===//
12
Chandler Carrutha9174582015-01-22 05:25:13 +000013#include "InstCombineInternal.h"
Matt Arsenault55e73122015-01-06 15:50:59 +000014#include "llvm/ADT/APSInt.h"
Silviu Barangaf29dfd32016-01-15 15:52:05 +000015#include "llvm/ADT/SetVector.h"
Gerolf Hoflehnerec6217c2014-11-21 23:36:44 +000016#include "llvm/ADT/Statistic.h"
Eli Friedman911e12f2011-07-20 21:57:23 +000017#include "llvm/Analysis/ConstantFolding.h"
Chris Lattner2188e402010-01-04 07:37:31 +000018#include "llvm/Analysis/InstructionSimplify.h"
Mehdi Aminib550cb12016-04-18 09:17:29 +000019#include "llvm/Analysis/TargetLibraryInfo.h"
Chandler Carruth8cd041e2014-03-04 12:24:34 +000020#include "llvm/IR/ConstantRange.h"
Chandler Carruth9fb823b2013-01-02 11:36:10 +000021#include "llvm/IR/DataLayout.h"
Chandler Carruth03eb0de2014-03-04 10:40:04 +000022#include "llvm/IR/GetElementPtrTypeIterator.h"
Chandler Carruth9fb823b2013-01-02 11:36:10 +000023#include "llvm/IR/IntrinsicInst.h"
Chandler Carruth820a9082014-03-04 11:08:18 +000024#include "llvm/IR/PatternMatch.h"
Gerolf Hoflehnerec6217c2014-11-21 23:36:44 +000025#include "llvm/Support/Debug.h"
Craig Topperb45eabc2017-04-26 16:39:58 +000026#include "llvm/Support/KnownBits.h"
Gerolf Hoflehnerec6217c2014-11-21 23:36:44 +000027
Chris Lattner2188e402010-01-04 07:37:31 +000028using namespace llvm;
29using namespace PatternMatch;
30
Chandler Carruth964daaa2014-04-22 02:55:47 +000031#define DEBUG_TYPE "instcombine"
32
Gerolf Hoflehnerec6217c2014-11-21 23:36:44 +000033// How many times is a select replaced by one of its operands?
34STATISTIC(NumSel, "Number of select opts");
35
Chris Lattner98457102011-02-10 05:23:05 +000036
Sanjay Patel5f0217f2016-06-05 16:46:18 +000037/// Compute Result = In1+In2, returning true if the result overflowed for this
38/// type.
Craig Topper6e025a32017-10-01 23:53:54 +000039static bool addWithOverflow(APInt &Result, const APInt &In1,
40 const APInt &In2, bool IsSigned = false) {
41 bool Overflow;
42 if (IsSigned)
43 Result = In1.sadd_ov(In2, Overflow);
44 else
45 Result = In1.uadd_ov(In2, Overflow);
Chris Lattner2188e402010-01-04 07:37:31 +000046
Craig Topper6e025a32017-10-01 23:53:54 +000047 return Overflow;
Chris Lattner2188e402010-01-04 07:37:31 +000048}
49
Sanjay Patel5f0217f2016-06-05 16:46:18 +000050/// Compute Result = In1-In2, returning true if the result overflowed for this
51/// type.
Craig Topper6e025a32017-10-01 23:53:54 +000052static bool subWithOverflow(APInt &Result, const APInt &In1,
53 const APInt &In2, bool IsSigned = false) {
54 bool Overflow;
55 if (IsSigned)
56 Result = In1.ssub_ov(In2, Overflow);
57 else
58 Result = In1.usub_ov(In2, Overflow);
Chris Lattner2188e402010-01-04 07:37:31 +000059
Craig Topper6e025a32017-10-01 23:53:54 +000060 return Overflow;
Chris Lattner2188e402010-01-04 07:37:31 +000061}
62
Balaram Makam569eaec2016-05-04 21:32:14 +000063/// Given an icmp instruction, return true if any use of this comparison is a
64/// branch on sign bit comparison.
Eric Christopher710c1c82017-06-30 01:35:31 +000065static bool hasBranchUse(ICmpInst &I) {
Balaram Makam569eaec2016-05-04 21:32:14 +000066 for (auto *U : I.users())
67 if (isa<BranchInst>(U))
Eric Christopher710c1c82017-06-30 01:35:31 +000068 return true;
Balaram Makam569eaec2016-05-04 21:32:14 +000069 return false;
70}
71
Sanjay Patel5f0217f2016-06-05 16:46:18 +000072/// Given an exploded icmp instruction, return true if the comparison only
73/// checks the sign bit. If it only checks the sign bit, set TrueIfSigned if the
74/// result of the comparison is true when the input value is signed.
Sanjay Patel79263662016-08-21 15:07:45 +000075static bool isSignBitCheck(ICmpInst::Predicate Pred, const APInt &RHS,
Chris Lattner2188e402010-01-04 07:37:31 +000076 bool &TrueIfSigned) {
Sanjay Patel5f0217f2016-06-05 16:46:18 +000077 switch (Pred) {
Chris Lattner2188e402010-01-04 07:37:31 +000078 case ICmpInst::ICMP_SLT: // True if LHS s< 0
79 TrueIfSigned = true;
Craig Topper73ba1c82017-06-07 07:40:37 +000080 return RHS.isNullValue();
Chris Lattner2188e402010-01-04 07:37:31 +000081 case ICmpInst::ICMP_SLE: // True if LHS s<= RHS and RHS == -1
82 TrueIfSigned = true;
Sanjay Patel79263662016-08-21 15:07:45 +000083 return RHS.isAllOnesValue();
Chris Lattner2188e402010-01-04 07:37:31 +000084 case ICmpInst::ICMP_SGT: // True if LHS s> -1
85 TrueIfSigned = false;
Sanjay Patel79263662016-08-21 15:07:45 +000086 return RHS.isAllOnesValue();
Chris Lattner2188e402010-01-04 07:37:31 +000087 case ICmpInst::ICMP_UGT:
88 // True if LHS u> RHS and RHS == high-bit-mask - 1
89 TrueIfSigned = true;
Sanjay Patel79263662016-08-21 15:07:45 +000090 return RHS.isMaxSignedValue();
Jim Grosbach129c52a2011-09-30 18:09:53 +000091 case ICmpInst::ICMP_UGE:
Chris Lattner2188e402010-01-04 07:37:31 +000092 // True if LHS u>= RHS and RHS == high-bit-mask (2^7, 2^15, 2^31, etc)
93 TrueIfSigned = true;
Craig Topperbcfd2d12017-04-20 16:56:25 +000094 return RHS.isSignMask();
Chris Lattner2188e402010-01-04 07:37:31 +000095 default:
96 return false;
97 }
98}
99
Arnaud A. de Grandmaison3ee88e82013-03-25 11:47:38 +0000100/// Returns true if the exploded icmp can be expressed as a signed comparison
101/// to zero and updates the predicate accordingly.
102/// The signedness of the comparison is preserved.
Sanjay Patel5b112842016-08-18 14:59:14 +0000103/// TODO: Refactor with decomposeBitTestICmp()?
104static bool isSignTest(ICmpInst::Predicate &Pred, const APInt &C) {
Sanjay Patel5f0217f2016-06-05 16:46:18 +0000105 if (!ICmpInst::isSigned(Pred))
Arnaud A. de Grandmaison9c383d62013-03-25 09:48:49 +0000106 return false;
107
Craig Topper73ba1c82017-06-07 07:40:37 +0000108 if (C.isNullValue())
Sanjay Patel5f0217f2016-06-05 16:46:18 +0000109 return ICmpInst::isRelational(Pred);
Arnaud A. de Grandmaison9c383d62013-03-25 09:48:49 +0000110
Craig Topper73ba1c82017-06-07 07:40:37 +0000111 if (C.isOneValue()) {
Sanjay Patel5f0217f2016-06-05 16:46:18 +0000112 if (Pred == ICmpInst::ICMP_SLT) {
113 Pred = ICmpInst::ICMP_SLE;
Arnaud A. de Grandmaison9c383d62013-03-25 09:48:49 +0000114 return true;
Arnaud A. de Grandmaison9c383d62013-03-25 09:48:49 +0000115 }
Sanjay Patel5b112842016-08-18 14:59:14 +0000116 } else if (C.isAllOnesValue()) {
Sanjay Patel5f0217f2016-06-05 16:46:18 +0000117 if (Pred == ICmpInst::ICMP_SGT) {
118 Pred = ICmpInst::ICMP_SGE;
Arnaud A. de Grandmaison9c383d62013-03-25 09:48:49 +0000119 return true;
Arnaud A. de Grandmaison9c383d62013-03-25 09:48:49 +0000120 }
Arnaud A. de Grandmaison3ee88e82013-03-25 11:47:38 +0000121 }
Arnaud A. de Grandmaison9c383d62013-03-25 09:48:49 +0000122
123 return false;
124}
125
Sanjay Patel5f0217f2016-06-05 16:46:18 +0000126/// Given a signed integer type and a set of known zero and one bits, compute
127/// the maximum and minimum values that could have the specified known zero and
128/// known one bits, returning them in Min/Max.
Craig Topperb45eabc2017-04-26 16:39:58 +0000129/// TODO: Move to method on KnownBits struct?
130static void computeSignedMinMaxValuesFromKnownBits(const KnownBits &Known,
Sanjay Patel5f0217f2016-06-05 16:46:18 +0000131 APInt &Min, APInt &Max) {
Craig Topperb45eabc2017-04-26 16:39:58 +0000132 assert(Known.getBitWidth() == Min.getBitWidth() &&
133 Known.getBitWidth() == Max.getBitWidth() &&
Chris Lattner2188e402010-01-04 07:37:31 +0000134 "KnownZero, KnownOne and Min, Max must have equal bitwidth.");
Craig Topperb45eabc2017-04-26 16:39:58 +0000135 APInt UnknownBits = ~(Known.Zero|Known.One);
Chris Lattner2188e402010-01-04 07:37:31 +0000136
137 // The minimum value is when all unknown bits are zeros, EXCEPT for the sign
138 // bit if it is unknown.
Craig Topperb45eabc2017-04-26 16:39:58 +0000139 Min = Known.One;
140 Max = Known.One|UnknownBits;
Jim Grosbach129c52a2011-09-30 18:09:53 +0000141
Chris Lattner2188e402010-01-04 07:37:31 +0000142 if (UnknownBits.isNegative()) { // Sign bit is unknown
Craig Topper24db6b82017-04-28 16:58:05 +0000143 Min.setSignBit();
144 Max.clearSignBit();
Chris Lattner2188e402010-01-04 07:37:31 +0000145 }
146}
147
Sanjay Patel5f0217f2016-06-05 16:46:18 +0000148/// Given an unsigned integer type and a set of known zero and one bits, compute
149/// the maximum and minimum values that could have the specified known zero and
150/// known one bits, returning them in Min/Max.
Craig Topperb45eabc2017-04-26 16:39:58 +0000151/// TODO: Move to method on KnownBits struct?
152static void computeUnsignedMinMaxValuesFromKnownBits(const KnownBits &Known,
Chris Lattner2188e402010-01-04 07:37:31 +0000153 APInt &Min, APInt &Max) {
Craig Topperb45eabc2017-04-26 16:39:58 +0000154 assert(Known.getBitWidth() == Min.getBitWidth() &&
155 Known.getBitWidth() == Max.getBitWidth() &&
Chris Lattner2188e402010-01-04 07:37:31 +0000156 "Ty, KnownZero, KnownOne and Min, Max must have equal bitwidth.");
Craig Topperb45eabc2017-04-26 16:39:58 +0000157 APInt UnknownBits = ~(Known.Zero|Known.One);
Jim Grosbach129c52a2011-09-30 18:09:53 +0000158
Chris Lattner2188e402010-01-04 07:37:31 +0000159 // The minimum value is when the unknown bits are all zeros.
Craig Topperb45eabc2017-04-26 16:39:58 +0000160 Min = Known.One;
Chris Lattner2188e402010-01-04 07:37:31 +0000161 // The maximum value is when the unknown bits are all ones.
Craig Topperb45eabc2017-04-26 16:39:58 +0000162 Max = Known.One|UnknownBits;
Chris Lattner2188e402010-01-04 07:37:31 +0000163}
164
Sanjay Patel5f0217f2016-06-05 16:46:18 +0000165/// This is called when we see this pattern:
Chris Lattner2188e402010-01-04 07:37:31 +0000166/// cmp pred (load (gep GV, ...)), cmpcst
Sanjay Patel5f0217f2016-06-05 16:46:18 +0000167/// where GV is a global variable with a constant initializer. Try to simplify
168/// this into some simple computation that does not need the load. For example
Chris Lattner2188e402010-01-04 07:37:31 +0000169/// we can optimize "icmp eq (load (gep "foo", 0, i)), 0" into "icmp eq i, 3".
170///
171/// If AndCst is non-null, then the loaded value is masked with that constant
Sanjay Patel5f0217f2016-06-05 16:46:18 +0000172/// before doing the comparison. This handles cases like "A[i]&4 == 0".
Sanjay Patel43395062016-07-21 18:07:40 +0000173Instruction *InstCombiner::foldCmpLoadFromIndexedGlobal(GetElementPtrInst *GEP,
174 GlobalVariable *GV,
175 CmpInst &ICI,
176 ConstantInt *AndCst) {
Chris Lattnerfe741762012-01-31 02:55:06 +0000177 Constant *Init = GV->getInitializer();
178 if (!isa<ConstantArray>(Init) && !isa<ConstantDataArray>(Init))
Craig Topperf40110f2014-04-25 05:29:35 +0000179 return nullptr;
Jim Grosbachbdbd7342013-04-05 21:20:12 +0000180
Chris Lattnerfe741762012-01-31 02:55:06 +0000181 uint64_t ArrayElementCount = Init->getType()->getArrayNumElements();
Davide Italiano2133bf52017-02-07 17:56:50 +0000182 // Don't blow up on huge arrays.
183 if (ArrayElementCount > MaxArraySizeForCombine)
184 return nullptr;
Jim Grosbach129c52a2011-09-30 18:09:53 +0000185
Chris Lattner2188e402010-01-04 07:37:31 +0000186 // There are many forms of this optimization we can handle, for now, just do
187 // the simple index into a single-dimensional array.
188 //
189 // Require: GEP GV, 0, i {{, constant indices}}
190 if (GEP->getNumOperands() < 3 ||
191 !isa<ConstantInt>(GEP->getOperand(1)) ||
192 !cast<ConstantInt>(GEP->getOperand(1))->isZero() ||
193 isa<Constant>(GEP->getOperand(2)))
Craig Topperf40110f2014-04-25 05:29:35 +0000194 return nullptr;
Chris Lattner2188e402010-01-04 07:37:31 +0000195
196 // Check that indices after the variable are constants and in-range for the
197 // type they index. Collect the indices. This is typically for arrays of
198 // structs.
199 SmallVector<unsigned, 4> LaterIndices;
Jim Grosbach129c52a2011-09-30 18:09:53 +0000200
Chris Lattnerfe741762012-01-31 02:55:06 +0000201 Type *EltTy = Init->getType()->getArrayElementType();
Chris Lattner2188e402010-01-04 07:37:31 +0000202 for (unsigned i = 3, e = GEP->getNumOperands(); i != e; ++i) {
203 ConstantInt *Idx = dyn_cast<ConstantInt>(GEP->getOperand(i));
Craig Topperf40110f2014-04-25 05:29:35 +0000204 if (!Idx) return nullptr; // Variable index.
Jim Grosbach129c52a2011-09-30 18:09:53 +0000205
Chris Lattner2188e402010-01-04 07:37:31 +0000206 uint64_t IdxVal = Idx->getZExtValue();
Craig Topperf40110f2014-04-25 05:29:35 +0000207 if ((unsigned)IdxVal != IdxVal) return nullptr; // Too large array index.
Jim Grosbach129c52a2011-09-30 18:09:53 +0000208
Chris Lattner229907c2011-07-18 04:54:35 +0000209 if (StructType *STy = dyn_cast<StructType>(EltTy))
Chris Lattner2188e402010-01-04 07:37:31 +0000210 EltTy = STy->getElementType(IdxVal);
Chris Lattner229907c2011-07-18 04:54:35 +0000211 else if (ArrayType *ATy = dyn_cast<ArrayType>(EltTy)) {
Craig Topperf40110f2014-04-25 05:29:35 +0000212 if (IdxVal >= ATy->getNumElements()) return nullptr;
Chris Lattner2188e402010-01-04 07:37:31 +0000213 EltTy = ATy->getElementType();
214 } else {
Craig Topperf40110f2014-04-25 05:29:35 +0000215 return nullptr; // Unknown type.
Chris Lattner2188e402010-01-04 07:37:31 +0000216 }
Jim Grosbach129c52a2011-09-30 18:09:53 +0000217
Chris Lattner2188e402010-01-04 07:37:31 +0000218 LaterIndices.push_back(IdxVal);
219 }
Jim Grosbach129c52a2011-09-30 18:09:53 +0000220
Chris Lattner2188e402010-01-04 07:37:31 +0000221 enum { Overdefined = -3, Undefined = -2 };
222
223 // Variables for our state machines.
Jim Grosbach129c52a2011-09-30 18:09:53 +0000224
Chris Lattner2188e402010-01-04 07:37:31 +0000225 // FirstTrueElement/SecondTrueElement - Used to emit a comparison of the form
226 // "i == 47 | i == 87", where 47 is the first index the condition is true for,
227 // and 87 is the second (and last) index. FirstTrueElement is -2 when
228 // undefined, otherwise set to the first true element. SecondTrueElement is
229 // -2 when undefined, -3 when overdefined and >= 0 when that index is true.
230 int FirstTrueElement = Undefined, SecondTrueElement = Undefined;
231
232 // FirstFalseElement/SecondFalseElement - Used to emit a comparison of the
233 // form "i != 47 & i != 87". Same state transitions as for true elements.
234 int FirstFalseElement = Undefined, SecondFalseElement = Undefined;
Jim Grosbach129c52a2011-09-30 18:09:53 +0000235
Chris Lattner2188e402010-01-04 07:37:31 +0000236 /// TrueRangeEnd/FalseRangeEnd - In conjunction with First*Element, these
237 /// define a state machine that triggers for ranges of values that the index
238 /// is true or false for. This triggers on things like "abbbbc"[i] == 'b'.
239 /// This is -2 when undefined, -3 when overdefined, and otherwise the last
240 /// index in the range (inclusive). We use -2 for undefined here because we
241 /// use relative comparisons and don't want 0-1 to match -1.
242 int TrueRangeEnd = Undefined, FalseRangeEnd = Undefined;
Jim Grosbach129c52a2011-09-30 18:09:53 +0000243
Chris Lattner2188e402010-01-04 07:37:31 +0000244 // MagicBitvector - This is a magic bitvector where we set a bit if the
245 // comparison is true for element 'i'. If there are 64 elements or less in
246 // the array, this will fully represent all the comparison results.
247 uint64_t MagicBitvector = 0;
Jim Grosbach129c52a2011-09-30 18:09:53 +0000248
Chris Lattner2188e402010-01-04 07:37:31 +0000249 // Scan the array and see if one of our patterns matches.
250 Constant *CompareRHS = cast<Constant>(ICI.getOperand(1));
Chris Lattnerfe741762012-01-31 02:55:06 +0000251 for (unsigned i = 0, e = ArrayElementCount; i != e; ++i) {
252 Constant *Elt = Init->getAggregateElement(i);
Craig Topperf40110f2014-04-25 05:29:35 +0000253 if (!Elt) return nullptr;
Jim Grosbach129c52a2011-09-30 18:09:53 +0000254
Chris Lattner2188e402010-01-04 07:37:31 +0000255 // If this is indexing an array of structures, get the structure element.
256 if (!LaterIndices.empty())
Jay Foad57aa6362011-07-13 10:26:04 +0000257 Elt = ConstantExpr::getExtractValue(Elt, LaterIndices);
Jim Grosbach129c52a2011-09-30 18:09:53 +0000258
Chris Lattner2188e402010-01-04 07:37:31 +0000259 // If the element is masked, handle it.
260 if (AndCst) Elt = ConstantExpr::getAnd(Elt, AndCst);
Jim Grosbach129c52a2011-09-30 18:09:53 +0000261
Chris Lattner2188e402010-01-04 07:37:31 +0000262 // Find out if the comparison would be true or false for the i'th element.
263 Constant *C = ConstantFoldCompareInstOperands(ICI.getPredicate(), Elt,
Justin Bogner99798402016-08-05 01:06:44 +0000264 CompareRHS, DL, &TLI);
Chris Lattner2188e402010-01-04 07:37:31 +0000265 // If the result is undef for this element, ignore it.
266 if (isa<UndefValue>(C)) {
267 // Extend range state machines to cover this element in case there is an
268 // undef in the middle of the range.
269 if (TrueRangeEnd == (int)i-1)
270 TrueRangeEnd = i;
271 if (FalseRangeEnd == (int)i-1)
272 FalseRangeEnd = i;
273 continue;
274 }
Jim Grosbach129c52a2011-09-30 18:09:53 +0000275
Chris Lattner2188e402010-01-04 07:37:31 +0000276 // If we can't compute the result for any of the elements, we have to give
277 // up evaluating the entire conditional.
Craig Topperf40110f2014-04-25 05:29:35 +0000278 if (!isa<ConstantInt>(C)) return nullptr;
Jim Grosbach129c52a2011-09-30 18:09:53 +0000279
Chris Lattner2188e402010-01-04 07:37:31 +0000280 // Otherwise, we know if the comparison is true or false for this element,
281 // update our state machines.
282 bool IsTrueForElt = !cast<ConstantInt>(C)->isZero();
Jim Grosbach129c52a2011-09-30 18:09:53 +0000283
Chris Lattner2188e402010-01-04 07:37:31 +0000284 // State machine for single/double/range index comparison.
285 if (IsTrueForElt) {
286 // Update the TrueElement state machine.
287 if (FirstTrueElement == Undefined)
288 FirstTrueElement = TrueRangeEnd = i; // First true element.
289 else {
290 // Update double-compare state machine.
291 if (SecondTrueElement == Undefined)
292 SecondTrueElement = i;
293 else
294 SecondTrueElement = Overdefined;
Jim Grosbach129c52a2011-09-30 18:09:53 +0000295
Chris Lattner2188e402010-01-04 07:37:31 +0000296 // Update range state machine.
297 if (TrueRangeEnd == (int)i-1)
298 TrueRangeEnd = i;
299 else
300 TrueRangeEnd = Overdefined;
301 }
302 } else {
303 // Update the FalseElement state machine.
304 if (FirstFalseElement == Undefined)
305 FirstFalseElement = FalseRangeEnd = i; // First false element.
306 else {
307 // Update double-compare state machine.
308 if (SecondFalseElement == Undefined)
309 SecondFalseElement = i;
310 else
311 SecondFalseElement = Overdefined;
Jim Grosbach129c52a2011-09-30 18:09:53 +0000312
Chris Lattner2188e402010-01-04 07:37:31 +0000313 // Update range state machine.
314 if (FalseRangeEnd == (int)i-1)
315 FalseRangeEnd = i;
316 else
317 FalseRangeEnd = Overdefined;
318 }
319 }
Jim Grosbach129c52a2011-09-30 18:09:53 +0000320
Chris Lattner2188e402010-01-04 07:37:31 +0000321 // If this element is in range, update our magic bitvector.
322 if (i < 64 && IsTrueForElt)
323 MagicBitvector |= 1ULL << i;
Jim Grosbach129c52a2011-09-30 18:09:53 +0000324
Chris Lattner2188e402010-01-04 07:37:31 +0000325 // If all of our states become overdefined, bail out early. Since the
326 // predicate is expensive, only check it every 8 elements. This is only
327 // really useful for really huge arrays.
328 if ((i & 8) == 0 && i >= 64 && SecondTrueElement == Overdefined &&
329 SecondFalseElement == Overdefined && TrueRangeEnd == Overdefined &&
330 FalseRangeEnd == Overdefined)
Craig Topperf40110f2014-04-25 05:29:35 +0000331 return nullptr;
Chris Lattner2188e402010-01-04 07:37:31 +0000332 }
333
334 // Now that we've scanned the entire array, emit our new comparison(s). We
335 // order the state machines in complexity of the generated code.
336 Value *Idx = GEP->getOperand(2);
337
Matt Arsenault5aeae182013-08-19 21:40:31 +0000338 // If the index is larger than the pointer size of the target, truncate the
339 // index down like the GEP would do implicitly. We don't have to do this for
340 // an inbounds GEP because the index can't be out of range.
Matt Arsenault84680622013-09-30 21:11:01 +0000341 if (!GEP->isInBounds()) {
Mehdi Aminia28d91d2015-03-10 02:37:25 +0000342 Type *IntPtrTy = DL.getIntPtrType(GEP->getType());
Matt Arsenault84680622013-09-30 21:11:01 +0000343 unsigned PtrSize = IntPtrTy->getIntegerBitWidth();
344 if (Idx->getType()->getPrimitiveSizeInBits() > PtrSize)
Craig Topperbb4069e2017-07-07 23:16:26 +0000345 Idx = Builder.CreateTrunc(Idx, IntPtrTy);
Matt Arsenault84680622013-09-30 21:11:01 +0000346 }
Matt Arsenault5aeae182013-08-19 21:40:31 +0000347
Chris Lattner2188e402010-01-04 07:37:31 +0000348 // If the comparison is only true for one or two elements, emit direct
349 // comparisons.
350 if (SecondTrueElement != Overdefined) {
351 // None true -> false.
352 if (FirstTrueElement == Undefined)
Craig Topperbb4069e2017-07-07 23:16:26 +0000353 return replaceInstUsesWith(ICI, Builder.getFalse());
Jim Grosbach129c52a2011-09-30 18:09:53 +0000354
Chris Lattner2188e402010-01-04 07:37:31 +0000355 Value *FirstTrueIdx = ConstantInt::get(Idx->getType(), FirstTrueElement);
Jim Grosbach129c52a2011-09-30 18:09:53 +0000356
Chris Lattner2188e402010-01-04 07:37:31 +0000357 // True for one element -> 'i == 47'.
358 if (SecondTrueElement == Undefined)
359 return new ICmpInst(ICmpInst::ICMP_EQ, Idx, FirstTrueIdx);
Jim Grosbach129c52a2011-09-30 18:09:53 +0000360
Chris Lattner2188e402010-01-04 07:37:31 +0000361 // True for two elements -> 'i == 47 | i == 72'.
Craig Topperbb4069e2017-07-07 23:16:26 +0000362 Value *C1 = Builder.CreateICmpEQ(Idx, FirstTrueIdx);
Chris Lattner2188e402010-01-04 07:37:31 +0000363 Value *SecondTrueIdx = ConstantInt::get(Idx->getType(), SecondTrueElement);
Craig Topperbb4069e2017-07-07 23:16:26 +0000364 Value *C2 = Builder.CreateICmpEQ(Idx, SecondTrueIdx);
Chris Lattner2188e402010-01-04 07:37:31 +0000365 return BinaryOperator::CreateOr(C1, C2);
366 }
367
368 // If the comparison is only false for one or two elements, emit direct
369 // comparisons.
370 if (SecondFalseElement != Overdefined) {
371 // None false -> true.
372 if (FirstFalseElement == Undefined)
Craig Topperbb4069e2017-07-07 23:16:26 +0000373 return replaceInstUsesWith(ICI, Builder.getTrue());
Jim Grosbach129c52a2011-09-30 18:09:53 +0000374
Chris Lattner2188e402010-01-04 07:37:31 +0000375 Value *FirstFalseIdx = ConstantInt::get(Idx->getType(), FirstFalseElement);
376
377 // False for one element -> 'i != 47'.
378 if (SecondFalseElement == Undefined)
379 return new ICmpInst(ICmpInst::ICMP_NE, Idx, FirstFalseIdx);
Jim Grosbach129c52a2011-09-30 18:09:53 +0000380
Chris Lattner2188e402010-01-04 07:37:31 +0000381 // False for two elements -> 'i != 47 & i != 72'.
Craig Topperbb4069e2017-07-07 23:16:26 +0000382 Value *C1 = Builder.CreateICmpNE(Idx, FirstFalseIdx);
Chris Lattner2188e402010-01-04 07:37:31 +0000383 Value *SecondFalseIdx = ConstantInt::get(Idx->getType(),SecondFalseElement);
Craig Topperbb4069e2017-07-07 23:16:26 +0000384 Value *C2 = Builder.CreateICmpNE(Idx, SecondFalseIdx);
Chris Lattner2188e402010-01-04 07:37:31 +0000385 return BinaryOperator::CreateAnd(C1, C2);
386 }
Jim Grosbach129c52a2011-09-30 18:09:53 +0000387
Chris Lattner2188e402010-01-04 07:37:31 +0000388 // If the comparison can be replaced with a range comparison for the elements
389 // where it is true, emit the range check.
390 if (TrueRangeEnd != Overdefined) {
391 assert(TrueRangeEnd != FirstTrueElement && "Should emit single compare");
Jim Grosbach129c52a2011-09-30 18:09:53 +0000392
Chris Lattner2188e402010-01-04 07:37:31 +0000393 // Generate (i-FirstTrue) <u (TrueRangeEnd-FirstTrue+1).
394 if (FirstTrueElement) {
395 Value *Offs = ConstantInt::get(Idx->getType(), -FirstTrueElement);
Craig Topperbb4069e2017-07-07 23:16:26 +0000396 Idx = Builder.CreateAdd(Idx, Offs);
Chris Lattner2188e402010-01-04 07:37:31 +0000397 }
Jim Grosbach129c52a2011-09-30 18:09:53 +0000398
Chris Lattner2188e402010-01-04 07:37:31 +0000399 Value *End = ConstantInt::get(Idx->getType(),
400 TrueRangeEnd-FirstTrueElement+1);
401 return new ICmpInst(ICmpInst::ICMP_ULT, Idx, End);
402 }
Jim Grosbach129c52a2011-09-30 18:09:53 +0000403
Chris Lattner2188e402010-01-04 07:37:31 +0000404 // False range check.
405 if (FalseRangeEnd != Overdefined) {
406 assert(FalseRangeEnd != FirstFalseElement && "Should emit single compare");
407 // Generate (i-FirstFalse) >u (FalseRangeEnd-FirstFalse).
408 if (FirstFalseElement) {
409 Value *Offs = ConstantInt::get(Idx->getType(), -FirstFalseElement);
Craig Topperbb4069e2017-07-07 23:16:26 +0000410 Idx = Builder.CreateAdd(Idx, Offs);
Chris Lattner2188e402010-01-04 07:37:31 +0000411 }
Jim Grosbach129c52a2011-09-30 18:09:53 +0000412
Chris Lattner2188e402010-01-04 07:37:31 +0000413 Value *End = ConstantInt::get(Idx->getType(),
414 FalseRangeEnd-FirstFalseElement);
415 return new ICmpInst(ICmpInst::ICMP_UGT, Idx, End);
416 }
Jim Grosbach129c52a2011-09-30 18:09:53 +0000417
Arnaud A. de Grandmaisonf364bc62013-03-22 08:25:01 +0000418 // If a magic bitvector captures the entire comparison state
Chris Lattner2188e402010-01-04 07:37:31 +0000419 // of this load, replace it with computation that does:
420 // ((magic_cst >> i) & 1) != 0
Arnaud A. de Grandmaisonf364bc62013-03-22 08:25:01 +0000421 {
Craig Topperf40110f2014-04-25 05:29:35 +0000422 Type *Ty = nullptr;
Arnaud A. de Grandmaisonf364bc62013-03-22 08:25:01 +0000423
424 // Look for an appropriate type:
425 // - The type of Idx if the magic fits
Craig Topper386fc252017-11-07 17:37:32 +0000426 // - The smallest fitting legal type
Arnaud A. de Grandmaisonf364bc62013-03-22 08:25:01 +0000427 if (ArrayElementCount <= Idx->getType()->getIntegerBitWidth())
428 Ty = Idx->getType();
Mehdi Aminia28d91d2015-03-10 02:37:25 +0000429 else
430 Ty = DL.getSmallestLegalIntType(Init->getContext(), ArrayElementCount);
Arnaud A. de Grandmaisonf364bc62013-03-22 08:25:01 +0000431
Craig Topperf40110f2014-04-25 05:29:35 +0000432 if (Ty) {
Craig Topperbb4069e2017-07-07 23:16:26 +0000433 Value *V = Builder.CreateIntCast(Idx, Ty, false);
434 V = Builder.CreateLShr(ConstantInt::get(Ty, MagicBitvector), V);
435 V = Builder.CreateAnd(ConstantInt::get(Ty, 1), V);
Arnaud A. de Grandmaisonf364bc62013-03-22 08:25:01 +0000436 return new ICmpInst(ICmpInst::ICMP_NE, V, ConstantInt::get(Ty, 0));
437 }
Chris Lattner2188e402010-01-04 07:37:31 +0000438 }
Jim Grosbach129c52a2011-09-30 18:09:53 +0000439
Craig Topperf40110f2014-04-25 05:29:35 +0000440 return nullptr;
Chris Lattner2188e402010-01-04 07:37:31 +0000441}
442
Sanjay Patel5f0217f2016-06-05 16:46:18 +0000443/// Return a value that can be used to compare the *offset* implied by a GEP to
444/// zero. For example, if we have &A[i], we want to return 'i' for
445/// "icmp ne i, 0". Note that, in general, indices can be complex, and scales
446/// are involved. The above expression would also be legal to codegen as
447/// "icmp ne (i*4), 0" (assuming A is a pointer to i32).
448/// This latter form is less amenable to optimization though, and we are allowed
Chris Lattner2188e402010-01-04 07:37:31 +0000449/// to generate the first by knowing that pointer arithmetic doesn't overflow.
450///
451/// If we can't emit an optimized form for this expression, this returns null.
Jim Grosbach129c52a2011-09-30 18:09:53 +0000452///
Sanjay Pateld93c4c02016-09-15 18:22:25 +0000453static Value *evaluateGEPOffsetExpression(User *GEP, InstCombiner &IC,
Mehdi Aminia28d91d2015-03-10 02:37:25 +0000454 const DataLayout &DL) {
Chris Lattner2188e402010-01-04 07:37:31 +0000455 gep_type_iterator GTI = gep_type_begin(GEP);
Jim Grosbach129c52a2011-09-30 18:09:53 +0000456
Chris Lattner2188e402010-01-04 07:37:31 +0000457 // Check to see if this gep only has a single variable index. If so, and if
458 // any constant indices are a multiple of its scale, then we can compute this
459 // in terms of the scale of the variable index. For example, if the GEP
460 // implies an offset of "12 + i*4", then we can codegen this as "3 + i",
461 // because the expression will cross zero at the same point.
462 unsigned i, e = GEP->getNumOperands();
463 int64_t Offset = 0;
464 for (i = 1; i != e; ++i, ++GTI) {
465 if (ConstantInt *CI = dyn_cast<ConstantInt>(GEP->getOperand(i))) {
466 // Compute the aggregate offset of constant indices.
467 if (CI->isZero()) continue;
Jim Grosbach129c52a2011-09-30 18:09:53 +0000468
Chris Lattner2188e402010-01-04 07:37:31 +0000469 // Handle a struct index, which adds its field offset to the pointer.
Peter Collingbourneab85225b2016-12-02 02:24:42 +0000470 if (StructType *STy = GTI.getStructTypeOrNull()) {
Rafael Espindola37dc9e12014-02-21 00:06:31 +0000471 Offset += DL.getStructLayout(STy)->getElementOffset(CI->getZExtValue());
Chris Lattner2188e402010-01-04 07:37:31 +0000472 } else {
Rafael Espindola37dc9e12014-02-21 00:06:31 +0000473 uint64_t Size = DL.getTypeAllocSize(GTI.getIndexedType());
Chris Lattner2188e402010-01-04 07:37:31 +0000474 Offset += Size*CI->getSExtValue();
475 }
476 } else {
477 // Found our variable index.
478 break;
479 }
480 }
Jim Grosbach129c52a2011-09-30 18:09:53 +0000481
Chris Lattner2188e402010-01-04 07:37:31 +0000482 // If there are no variable indices, we must have a constant offset, just
483 // evaluate it the general way.
Craig Topperf40110f2014-04-25 05:29:35 +0000484 if (i == e) return nullptr;
Jim Grosbach129c52a2011-09-30 18:09:53 +0000485
Chris Lattner2188e402010-01-04 07:37:31 +0000486 Value *VariableIdx = GEP->getOperand(i);
487 // Determine the scale factor of the variable element. For example, this is
488 // 4 if the variable index is into an array of i32.
Rafael Espindola37dc9e12014-02-21 00:06:31 +0000489 uint64_t VariableScale = DL.getTypeAllocSize(GTI.getIndexedType());
Jim Grosbach129c52a2011-09-30 18:09:53 +0000490
Chris Lattner2188e402010-01-04 07:37:31 +0000491 // Verify that there are no other variable indices. If so, emit the hard way.
492 for (++i, ++GTI; i != e; ++i, ++GTI) {
493 ConstantInt *CI = dyn_cast<ConstantInt>(GEP->getOperand(i));
Craig Topperf40110f2014-04-25 05:29:35 +0000494 if (!CI) return nullptr;
Jim Grosbach129c52a2011-09-30 18:09:53 +0000495
Chris Lattner2188e402010-01-04 07:37:31 +0000496 // Compute the aggregate offset of constant indices.
497 if (CI->isZero()) continue;
Jim Grosbach129c52a2011-09-30 18:09:53 +0000498
Chris Lattner2188e402010-01-04 07:37:31 +0000499 // Handle a struct index, which adds its field offset to the pointer.
Peter Collingbourneab85225b2016-12-02 02:24:42 +0000500 if (StructType *STy = GTI.getStructTypeOrNull()) {
Rafael Espindola37dc9e12014-02-21 00:06:31 +0000501 Offset += DL.getStructLayout(STy)->getElementOffset(CI->getZExtValue());
Chris Lattner2188e402010-01-04 07:37:31 +0000502 } else {
Rafael Espindola37dc9e12014-02-21 00:06:31 +0000503 uint64_t Size = DL.getTypeAllocSize(GTI.getIndexedType());
Chris Lattner2188e402010-01-04 07:37:31 +0000504 Offset += Size*CI->getSExtValue();
505 }
506 }
Jim Grosbach129c52a2011-09-30 18:09:53 +0000507
Chris Lattner2188e402010-01-04 07:37:31 +0000508 // Okay, we know we have a single variable index, which must be a
509 // pointer/array/vector index. If there is no offset, life is simple, return
510 // the index.
Rafael Espindola37dc9e12014-02-21 00:06:31 +0000511 Type *IntPtrTy = DL.getIntPtrType(GEP->getOperand(0)->getType());
Matt Arsenault745101d2013-08-21 19:53:10 +0000512 unsigned IntPtrWidth = IntPtrTy->getIntegerBitWidth();
Chris Lattner2188e402010-01-04 07:37:31 +0000513 if (Offset == 0) {
514 // Cast to intptrty in case a truncation occurs. If an extension is needed,
515 // we don't need to bother extending: the extension won't affect where the
516 // computation crosses zero.
Eli Friedman1754a252011-05-18 23:11:30 +0000517 if (VariableIdx->getType()->getPrimitiveSizeInBits() > IntPtrWidth) {
Craig Topperbb4069e2017-07-07 23:16:26 +0000518 VariableIdx = IC.Builder.CreateTrunc(VariableIdx, IntPtrTy);
Eli Friedman1754a252011-05-18 23:11:30 +0000519 }
Chris Lattner2188e402010-01-04 07:37:31 +0000520 return VariableIdx;
521 }
Jim Grosbach129c52a2011-09-30 18:09:53 +0000522
Chris Lattner2188e402010-01-04 07:37:31 +0000523 // Otherwise, there is an index. The computation we will do will be modulo
Nikita Popov36e03ac2018-12-12 23:19:03 +0000524 // the pointer size.
525 Offset = SignExtend64(Offset, IntPtrWidth);
526 VariableScale = SignExtend64(VariableScale, IntPtrWidth);
Jim Grosbach129c52a2011-09-30 18:09:53 +0000527
Chris Lattner2188e402010-01-04 07:37:31 +0000528 // To do this transformation, any constant index must be a multiple of the
529 // variable scale factor. For example, we can evaluate "12 + 4*i" as "3 + i",
530 // but we can't evaluate "10 + 3*i" in terms of i. Check that the offset is a
531 // multiple of the variable scale.
532 int64_t NewOffs = Offset / (int64_t)VariableScale;
533 if (Offset != NewOffs*(int64_t)VariableScale)
Craig Topperf40110f2014-04-25 05:29:35 +0000534 return nullptr;
Jim Grosbach129c52a2011-09-30 18:09:53 +0000535
Chris Lattner2188e402010-01-04 07:37:31 +0000536 // Okay, we can do this evaluation. Start by converting the index to intptr.
Chris Lattner2188e402010-01-04 07:37:31 +0000537 if (VariableIdx->getType() != IntPtrTy)
Craig Topperbb4069e2017-07-07 23:16:26 +0000538 VariableIdx = IC.Builder.CreateIntCast(VariableIdx, IntPtrTy,
Eli Friedman1754a252011-05-18 23:11:30 +0000539 true /*Signed*/);
Chris Lattner2188e402010-01-04 07:37:31 +0000540 Constant *OffsetVal = ConstantInt::get(IntPtrTy, NewOffs);
Craig Topperbb4069e2017-07-07 23:16:26 +0000541 return IC.Builder.CreateAdd(VariableIdx, OffsetVal, "offset");
Chris Lattner2188e402010-01-04 07:37:31 +0000542}
543
Silviu Barangaf29dfd32016-01-15 15:52:05 +0000544/// Returns true if we can rewrite Start as a GEP with pointer Base
545/// and some integer offset. The nodes that need to be re-written
546/// for this transformation will be added to Explored.
547static bool canRewriteGEPAsOffset(Value *Start, Value *Base,
548 const DataLayout &DL,
549 SetVector<Value *> &Explored) {
550 SmallVector<Value *, 16> WorkList(1, Start);
551 Explored.insert(Base);
552
553 // The following traversal gives us an order which can be used
554 // when doing the final transformation. Since in the final
555 // transformation we create the PHI replacement instructions first,
556 // we don't have to get them in any particular order.
557 //
558 // However, for other instructions we will have to traverse the
559 // operands of an instruction first, which means that we have to
560 // do a post-order traversal.
561 while (!WorkList.empty()) {
562 SetVector<PHINode *> PHIs;
563
564 while (!WorkList.empty()) {
565 if (Explored.size() >= 100)
566 return false;
567
568 Value *V = WorkList.back();
569
570 if (Explored.count(V) != 0) {
571 WorkList.pop_back();
572 continue;
573 }
574
575 if (!isa<IntToPtrInst>(V) && !isa<PtrToIntInst>(V) &&
David Majnemer8b16da82016-09-15 20:10:09 +0000576 !isa<GetElementPtrInst>(V) && !isa<PHINode>(V))
Silviu Barangaf29dfd32016-01-15 15:52:05 +0000577 // We've found some value that we can't explore which is different from
578 // the base. Therefore we can't do this transformation.
579 return false;
580
581 if (isa<IntToPtrInst>(V) || isa<PtrToIntInst>(V)) {
582 auto *CI = dyn_cast<CastInst>(V);
583 if (!CI->isNoopCast(DL))
584 return false;
585
586 if (Explored.count(CI->getOperand(0)) == 0)
587 WorkList.push_back(CI->getOperand(0));
588 }
589
590 if (auto *GEP = dyn_cast<GEPOperator>(V)) {
591 // We're limiting the GEP to having one index. This will preserve
592 // the original pointer type. We could handle more cases in the
593 // future.
594 if (GEP->getNumIndices() != 1 || !GEP->isInBounds() ||
595 GEP->getType() != Start->getType())
596 return false;
597
598 if (Explored.count(GEP->getOperand(0)) == 0)
599 WorkList.push_back(GEP->getOperand(0));
600 }
601
602 if (WorkList.back() == V) {
603 WorkList.pop_back();
604 // We've finished visiting this node, mark it as such.
605 Explored.insert(V);
606 }
607
608 if (auto *PN = dyn_cast<PHINode>(V)) {
David Majnemercdf28732016-03-19 04:39:52 +0000609 // We cannot transform PHIs on unsplittable basic blocks.
610 if (isa<CatchSwitchInst>(PN->getParent()->getTerminator()))
611 return false;
Silviu Barangaf29dfd32016-01-15 15:52:05 +0000612 Explored.insert(PN);
613 PHIs.insert(PN);
614 }
615 }
616
617 // Explore the PHI nodes further.
618 for (auto *PN : PHIs)
619 for (Value *Op : PN->incoming_values())
620 if (Explored.count(Op) == 0)
621 WorkList.push_back(Op);
622 }
623
624 // Make sure that we can do this. Since we can't insert GEPs in a basic
625 // block before a PHI node, we can't easily do this transformation if
626 // we have PHI node users of transformed instructions.
627 for (Value *Val : Explored) {
628 for (Value *Use : Val->uses()) {
629
630 auto *PHI = dyn_cast<PHINode>(Use);
631 auto *Inst = dyn_cast<Instruction>(Val);
632
633 if (Inst == Base || Inst == PHI || !Inst || !PHI ||
634 Explored.count(PHI) == 0)
635 continue;
636
637 if (PHI->getParent() == Inst->getParent())
638 return false;
639 }
640 }
641 return true;
642}
643
644// Sets the appropriate insert point on Builder where we can add
645// a replacement Instruction for V (if that is possible).
646static void setInsertionPoint(IRBuilder<> &Builder, Value *V,
647 bool Before = true) {
648 if (auto *PHI = dyn_cast<PHINode>(V)) {
649 Builder.SetInsertPoint(&*PHI->getParent()->getFirstInsertionPt());
650 return;
651 }
652 if (auto *I = dyn_cast<Instruction>(V)) {
653 if (!Before)
654 I = &*std::next(I->getIterator());
655 Builder.SetInsertPoint(I);
656 return;
657 }
658 if (auto *A = dyn_cast<Argument>(V)) {
659 // Set the insertion point in the entry block.
660 BasicBlock &Entry = A->getParent()->getEntryBlock();
661 Builder.SetInsertPoint(&*Entry.getFirstInsertionPt());
662 return;
663 }
664 // Otherwise, this is a constant and we don't need to set a new
665 // insertion point.
666 assert(isa<Constant>(V) && "Setting insertion point for unknown value!");
667}
668
669/// Returns a re-written value of Start as an indexed GEP using Base as a
670/// pointer.
671static Value *rewriteGEPAsOffset(Value *Start, Value *Base,
672 const DataLayout &DL,
673 SetVector<Value *> &Explored) {
674 // Perform all the substitutions. This is a bit tricky because we can
675 // have cycles in our use-def chains.
676 // 1. Create the PHI nodes without any incoming values.
677 // 2. Create all the other values.
678 // 3. Add the edges for the PHI nodes.
679 // 4. Emit GEPs to get the original pointers.
680 // 5. Remove the original instructions.
681 Type *IndexType = IntegerType::get(
Elena Demikhovsky945b7e52018-02-14 06:58:08 +0000682 Base->getContext(), DL.getIndexTypeSizeInBits(Start->getType()));
Silviu Barangaf29dfd32016-01-15 15:52:05 +0000683
684 DenseMap<Value *, Value *> NewInsts;
685 NewInsts[Base] = ConstantInt::getNullValue(IndexType);
686
687 // Create the new PHI nodes, without adding any incoming values.
688 for (Value *Val : Explored) {
689 if (Val == Base)
690 continue;
691 // Create empty phi nodes. This avoids cyclic dependencies when creating
692 // the remaining instructions.
693 if (auto *PHI = dyn_cast<PHINode>(Val))
694 NewInsts[PHI] = PHINode::Create(IndexType, PHI->getNumIncomingValues(),
695 PHI->getName() + ".idx", PHI);
696 }
697 IRBuilder<> Builder(Base->getContext());
698
699 // Create all the other instructions.
700 for (Value *Val : Explored) {
701
702 if (NewInsts.find(Val) != NewInsts.end())
703 continue;
704
705 if (auto *CI = dyn_cast<CastInst>(Val)) {
Martin Storsjo0fe645c2019-05-30 20:53:21 +0000706 // Don't get rid of the intermediate variable here; the store can grow
707 // the map which will invalidate the reference to the input value.
708 Value *V = NewInsts[CI->getOperand(0)];
709 NewInsts[CI] = V;
Silviu Barangaf29dfd32016-01-15 15:52:05 +0000710 continue;
711 }
712 if (auto *GEP = dyn_cast<GEPOperator>(Val)) {
713 Value *Index = NewInsts[GEP->getOperand(1)] ? NewInsts[GEP->getOperand(1)]
714 : GEP->getOperand(1);
715 setInsertionPoint(Builder, GEP);
716 // Indices might need to be sign extended. GEPs will magically do
717 // this, but we need to do it ourselves here.
718 if (Index->getType()->getScalarSizeInBits() !=
719 NewInsts[GEP->getOperand(0)]->getType()->getScalarSizeInBits()) {
720 Index = Builder.CreateSExtOrTrunc(
721 Index, NewInsts[GEP->getOperand(0)]->getType(),
722 GEP->getOperand(0)->getName() + ".sext");
723 }
724
725 auto *Op = NewInsts[GEP->getOperand(0)];
Craig Topper781aa182018-05-05 01:57:00 +0000726 if (isa<ConstantInt>(Op) && cast<ConstantInt>(Op)->isZero())
Silviu Barangaf29dfd32016-01-15 15:52:05 +0000727 NewInsts[GEP] = Index;
728 else
729 NewInsts[GEP] = Builder.CreateNSWAdd(
730 Op, Index, GEP->getOperand(0)->getName() + ".add");
731 continue;
732 }
733 if (isa<PHINode>(Val))
734 continue;
735
736 llvm_unreachable("Unexpected instruction type");
737 }
738
739 // Add the incoming values to the PHI nodes.
740 for (Value *Val : Explored) {
741 if (Val == Base)
742 continue;
743 // All the instructions have been created, we can now add edges to the
744 // phi nodes.
745 if (auto *PHI = dyn_cast<PHINode>(Val)) {
746 PHINode *NewPhi = static_cast<PHINode *>(NewInsts[PHI]);
747 for (unsigned I = 0, E = PHI->getNumIncomingValues(); I < E; ++I) {
748 Value *NewIncoming = PHI->getIncomingValue(I);
749
750 if (NewInsts.find(NewIncoming) != NewInsts.end())
751 NewIncoming = NewInsts[NewIncoming];
752
753 NewPhi->addIncoming(NewIncoming, PHI->getIncomingBlock(I));
754 }
755 }
756 }
757
758 for (Value *Val : Explored) {
759 if (Val == Base)
760 continue;
761
762 // Depending on the type, for external users we have to emit
763 // a GEP or a GEP + ptrtoint.
764 setInsertionPoint(Builder, Val, false);
765
766 // If required, create an inttoptr instruction for Base.
767 Value *NewBase = Base;
768 if (!Base->getType()->isPointerTy())
769 NewBase = Builder.CreateBitOrPointerCast(Base, Start->getType(),
770 Start->getName() + "to.ptr");
771
772 Value *GEP = Builder.CreateInBoundsGEP(
773 Start->getType()->getPointerElementType(), NewBase,
774 makeArrayRef(NewInsts[Val]), Val->getName() + ".ptr");
775
776 if (!Val->getType()->isPointerTy()) {
777 Value *Cast = Builder.CreatePointerCast(GEP, Val->getType(),
778 Val->getName() + ".conv");
779 GEP = Cast;
780 }
781 Val->replaceAllUsesWith(GEP);
782 }
783
784 return NewInsts[Start];
785}
786
787/// Looks through GEPs, IntToPtrInsts and PtrToIntInsts in order to express
788/// the input Value as a constant indexed GEP. Returns a pair containing
789/// the GEPs Pointer and Index.
790static std::pair<Value *, Value *>
791getAsConstantIndexedAddress(Value *V, const DataLayout &DL) {
792 Type *IndexType = IntegerType::get(V->getContext(),
Elena Demikhovsky945b7e52018-02-14 06:58:08 +0000793 DL.getIndexTypeSizeInBits(V->getType()));
Silviu Barangaf29dfd32016-01-15 15:52:05 +0000794
795 Constant *Index = ConstantInt::getNullValue(IndexType);
796 while (true) {
797 if (GEPOperator *GEP = dyn_cast<GEPOperator>(V)) {
798 // We accept only inbouds GEPs here to exclude the possibility of
799 // overflow.
800 if (!GEP->isInBounds())
801 break;
802 if (GEP->hasAllConstantIndices() && GEP->getNumIndices() == 1 &&
803 GEP->getType() == V->getType()) {
804 V = GEP->getOperand(0);
805 Constant *GEPIndex = static_cast<Constant *>(GEP->getOperand(1));
806 Index = ConstantExpr::getAdd(
807 Index, ConstantExpr::getSExtOrBitCast(GEPIndex, IndexType));
808 continue;
809 }
810 break;
811 }
812 if (auto *CI = dyn_cast<IntToPtrInst>(V)) {
813 if (!CI->isNoopCast(DL))
814 break;
815 V = CI->getOperand(0);
816 continue;
817 }
818 if (auto *CI = dyn_cast<PtrToIntInst>(V)) {
819 if (!CI->isNoopCast(DL))
820 break;
821 V = CI->getOperand(0);
822 continue;
823 }
824 break;
825 }
826 return {V, Index};
827}
828
Sanjay Patel5f0217f2016-06-05 16:46:18 +0000829/// Converts (CMP GEPLHS, RHS) if this change would make RHS a constant.
830/// We can look through PHIs, GEPs and casts in order to determine a common base
831/// between GEPLHS and RHS.
Silviu Barangaf29dfd32016-01-15 15:52:05 +0000832static Instruction *transformToIndexedCompare(GEPOperator *GEPLHS, Value *RHS,
833 ICmpInst::Predicate Cond,
834 const DataLayout &DL) {
835 if (!GEPLHS->hasAllConstantIndices())
836 return nullptr;
837
Silviu Barangac6d21eb2017-01-31 14:04:15 +0000838 // Make sure the pointers have the same type.
839 if (GEPLHS->getType() != RHS->getType())
840 return nullptr;
841
Silviu Barangaf29dfd32016-01-15 15:52:05 +0000842 Value *PtrBase, *Index;
843 std::tie(PtrBase, Index) = getAsConstantIndexedAddress(GEPLHS, DL);
844
845 // The set of nodes that will take part in this transformation.
846 SetVector<Value *> Nodes;
847
848 if (!canRewriteGEPAsOffset(RHS, PtrBase, DL, Nodes))
849 return nullptr;
850
851 // We know we can re-write this as
852 // ((gep Ptr, OFFSET1) cmp (gep Ptr, OFFSET2)
853 // Since we've only looked through inbouds GEPs we know that we
854 // can't have overflow on either side. We can therefore re-write
855 // this as:
856 // OFFSET1 cmp OFFSET2
857 Value *NewRHS = rewriteGEPAsOffset(RHS, PtrBase, DL, Nodes);
858
859 // RewriteGEPAsOffset has replaced RHS and all of its uses with a re-written
860 // GEP having PtrBase as the pointer base, and has returned in NewRHS the
861 // offset. Since Index is the offset of LHS to the base pointer, we will now
862 // compare the offsets instead of comparing the pointers.
863 return new ICmpInst(ICmpInst::getSignedPredicate(Cond), Index, NewRHS);
864}
865
Sanjay Patel5f0217f2016-06-05 16:46:18 +0000866/// Fold comparisons between a GEP instruction and something else. At this point
867/// we know that the GEP is on the LHS of the comparison.
Sanjay Patel43395062016-07-21 18:07:40 +0000868Instruction *InstCombiner::foldGEPICmp(GEPOperator *GEPLHS, Value *RHS,
Chris Lattner2188e402010-01-04 07:37:31 +0000869 ICmpInst::Predicate Cond,
870 Instruction &I) {
Benjamin Kramer6ee86902012-02-21 13:31:09 +0000871 // Don't transform signed compares of GEPs into index compares. Even if the
872 // GEP is inbounds, the final add of the base pointer can have signed overflow
873 // and would change the result of the icmp.
874 // e.g. "&foo[0] <s &foo[1]" can't be folded to "true" because "foo" could be
Benjamin Kramerc7a22fe2012-02-21 13:40:06 +0000875 // the maximum signed value for the pointer type.
Benjamin Kramer6ee86902012-02-21 13:31:09 +0000876 if (ICmpInst::isSigned(Cond))
Craig Topperf40110f2014-04-25 05:29:35 +0000877 return nullptr;
Benjamin Kramer6ee86902012-02-21 13:31:09 +0000878
Matt Arsenault44f60d02014-06-09 19:20:29 +0000879 // Look through bitcasts and addrspacecasts. We do not however want to remove
880 // 0 GEPs.
881 if (!isa<GetElementPtrInst>(RHS))
882 RHS = RHS->stripPointerCasts();
Chris Lattner2188e402010-01-04 07:37:31 +0000883
884 Value *PtrBase = GEPLHS->getOperand(0);
Mehdi Aminia28d91d2015-03-10 02:37:25 +0000885 if (PtrBase == RHS && GEPLHS->isInBounds()) {
Chris Lattner2188e402010-01-04 07:37:31 +0000886 // ((gep Ptr, OFFSET) cmp Ptr) ---> (OFFSET cmp 0).
887 // This transformation (ignoring the base and scales) is valid because we
888 // know pointers can't overflow since the gep is inbounds. See if we can
889 // output an optimized form.
Sanjay Pateld93c4c02016-09-15 18:22:25 +0000890 Value *Offset = evaluateGEPOffsetExpression(GEPLHS, *this, DL);
Jim Grosbach129c52a2011-09-30 18:09:53 +0000891
Chris Lattner2188e402010-01-04 07:37:31 +0000892 // If not, synthesize the offset the hard way.
Craig Topperf40110f2014-04-25 05:29:35 +0000893 if (!Offset)
Chris Lattner2188e402010-01-04 07:37:31 +0000894 Offset = EmitGEPOffset(GEPLHS);
895 return new ICmpInst(ICmpInst::getSignedPredicate(Cond), Offset,
896 Constant::getNullValue(Offset->getType()));
897 } else if (GEPOperator *GEPRHS = dyn_cast<GEPOperator>(RHS)) {
898 // If the base pointers are different, but the indices are the same, just
899 // compare the base pointer.
900 if (PtrBase != GEPRHS->getOperand(0)) {
901 bool IndicesTheSame = GEPLHS->getNumOperands()==GEPRHS->getNumOperands();
902 IndicesTheSame &= GEPLHS->getOperand(0)->getType() ==
903 GEPRHS->getOperand(0)->getType();
904 if (IndicesTheSame)
905 for (unsigned i = 1, e = GEPLHS->getNumOperands(); i != e; ++i)
906 if (GEPLHS->getOperand(i) != GEPRHS->getOperand(i)) {
907 IndicesTheSame = false;
908 break;
909 }
910
911 // If all indices are the same, just compare the base pointers.
Jesper Antonssonc954b862018-10-01 14:59:25 +0000912 Type *BaseType = GEPLHS->getOperand(0)->getType();
913 if (IndicesTheSame && CmpInst::makeCmpResultType(BaseType) == I.getType())
David Majnemer5953d372013-06-29 10:28:04 +0000914 return new ICmpInst(Cond, GEPLHS->getOperand(0), GEPRHS->getOperand(0));
Chris Lattner2188e402010-01-04 07:37:31 +0000915
Benjamin Kramer7adb1892012-02-20 15:07:47 +0000916 // If we're comparing GEPs with two base pointers that only differ in type
917 // and both GEPs have only constant indices or just one use, then fold
918 // the compare with the adjusted indices.
Mehdi Aminia28d91d2015-03-10 02:37:25 +0000919 if (GEPLHS->isInBounds() && GEPRHS->isInBounds() &&
Benjamin Kramer7adb1892012-02-20 15:07:47 +0000920 (GEPLHS->hasAllConstantIndices() || GEPLHS->hasOneUse()) &&
921 (GEPRHS->hasAllConstantIndices() || GEPRHS->hasOneUse()) &&
922 PtrBase->stripPointerCasts() ==
Mehdi Aminia28d91d2015-03-10 02:37:25 +0000923 GEPRHS->getOperand(0)->stripPointerCasts()) {
Matt Arsenault44f60d02014-06-09 19:20:29 +0000924 Value *LOffset = EmitGEPOffset(GEPLHS);
925 Value *ROffset = EmitGEPOffset(GEPRHS);
926
927 // If we looked through an addrspacecast between different sized address
928 // spaces, the LHS and RHS pointers are different sized
929 // integers. Truncate to the smaller one.
930 Type *LHSIndexTy = LOffset->getType();
931 Type *RHSIndexTy = ROffset->getType();
932 if (LHSIndexTy != RHSIndexTy) {
933 if (LHSIndexTy->getPrimitiveSizeInBits() <
934 RHSIndexTy->getPrimitiveSizeInBits()) {
Craig Topperbb4069e2017-07-07 23:16:26 +0000935 ROffset = Builder.CreateTrunc(ROffset, LHSIndexTy);
Matt Arsenault44f60d02014-06-09 19:20:29 +0000936 } else
Craig Topperbb4069e2017-07-07 23:16:26 +0000937 LOffset = Builder.CreateTrunc(LOffset, RHSIndexTy);
Matt Arsenault44f60d02014-06-09 19:20:29 +0000938 }
939
Craig Topperbb4069e2017-07-07 23:16:26 +0000940 Value *Cmp = Builder.CreateICmp(ICmpInst::getSignedPredicate(Cond),
941 LOffset, ROffset);
Sanjay Patel4b198802016-02-01 22:23:39 +0000942 return replaceInstUsesWith(I, Cmp);
Benjamin Kramer7adb1892012-02-20 15:07:47 +0000943 }
944
Chris Lattner2188e402010-01-04 07:37:31 +0000945 // Otherwise, the base pointers are different and the indices are
Silviu Barangaf29dfd32016-01-15 15:52:05 +0000946 // different. Try convert this to an indexed compare by looking through
947 // PHIs/casts.
948 return transformToIndexedCompare(GEPLHS, RHS, Cond, DL);
Chris Lattner2188e402010-01-04 07:37:31 +0000949 }
950
951 // If one of the GEPs has all zero indices, recurse.
Benjamin Kramerd0993e02014-07-07 11:01:16 +0000952 if (GEPLHS->hasAllZeroIndices())
Sanjay Patel43395062016-07-21 18:07:40 +0000953 return foldGEPICmp(GEPRHS, GEPLHS->getOperand(0),
David Majnemer92a8a7d2013-06-29 09:45:35 +0000954 ICmpInst::getSwappedPredicate(Cond), I);
Chris Lattner2188e402010-01-04 07:37:31 +0000955
956 // If the other GEP has all zero indices, recurse.
Benjamin Kramerd0993e02014-07-07 11:01:16 +0000957 if (GEPRHS->hasAllZeroIndices())
Sanjay Patel43395062016-07-21 18:07:40 +0000958 return foldGEPICmp(GEPLHS, GEPRHS->getOperand(0), Cond, I);
Chris Lattner2188e402010-01-04 07:37:31 +0000959
Stuart Hastings66a82b92011-05-14 05:55:10 +0000960 bool GEPsInBounds = GEPLHS->isInBounds() && GEPRHS->isInBounds();
Chris Lattner2188e402010-01-04 07:37:31 +0000961 if (GEPLHS->getNumOperands() == GEPRHS->getNumOperands()) {
962 // If the GEPs only differ by one index, compare it.
963 unsigned NumDifferences = 0; // Keep track of # differences.
964 unsigned DiffOperand = 0; // The operand that differs.
965 for (unsigned i = 1, e = GEPRHS->getNumOperands(); i != e; ++i)
966 if (GEPLHS->getOperand(i) != GEPRHS->getOperand(i)) {
967 if (GEPLHS->getOperand(i)->getType()->getPrimitiveSizeInBits() !=
968 GEPRHS->getOperand(i)->getType()->getPrimitiveSizeInBits()) {
969 // Irreconcilable differences.
970 NumDifferences = 2;
971 break;
972 } else {
973 if (NumDifferences++) break;
974 DiffOperand = i;
975 }
976 }
977
Rafael Espindolaa7bbc0b2013-06-06 17:03:05 +0000978 if (NumDifferences == 0) // SAME GEP?
Sanjay Patel4b198802016-02-01 22:23:39 +0000979 return replaceInstUsesWith(I, // No comparison is needed here.
Jesper Antonsson719fa052018-09-20 13:37:28 +0000980 ConstantInt::get(I.getType(), ICmpInst::isTrueWhenEqual(Cond)));
Chris Lattner2188e402010-01-04 07:37:31 +0000981
Stuart Hastings66a82b92011-05-14 05:55:10 +0000982 else if (NumDifferences == 1 && GEPsInBounds) {
Chris Lattner2188e402010-01-04 07:37:31 +0000983 Value *LHSV = GEPLHS->getOperand(DiffOperand);
984 Value *RHSV = GEPRHS->getOperand(DiffOperand);
985 // Make sure we do a signed comparison here.
986 return new ICmpInst(ICmpInst::getSignedPredicate(Cond), LHSV, RHSV);
987 }
988 }
989
990 // Only lower this if the icmp is the only user of the GEP or if we expect
991 // the result to fold to a constant!
Mehdi Aminia28d91d2015-03-10 02:37:25 +0000992 if (GEPsInBounds && (isa<ConstantExpr>(GEPLHS) || GEPLHS->hasOneUse()) &&
Chris Lattner2188e402010-01-04 07:37:31 +0000993 (isa<ConstantExpr>(GEPRHS) || GEPRHS->hasOneUse())) {
994 // ((gep Ptr, OFFSET1) cmp (gep Ptr, OFFSET2) ---> (OFFSET1 cmp OFFSET2)
995 Value *L = EmitGEPOffset(GEPLHS);
996 Value *R = EmitGEPOffset(GEPRHS);
997 return new ICmpInst(ICmpInst::getSignedPredicate(Cond), L, R);
998 }
999 }
Silviu Barangaf29dfd32016-01-15 15:52:05 +00001000
1001 // Try convert this to an indexed compare by looking through PHIs/casts as a
1002 // last resort.
1003 return transformToIndexedCompare(GEPLHS, RHS, Cond, DL);
Chris Lattner2188e402010-01-04 07:37:31 +00001004}
1005
Pete Cooper980a9352016-08-12 17:13:28 +00001006Instruction *InstCombiner::foldAllocaCmp(ICmpInst &ICI,
1007 const AllocaInst *Alloca,
1008 const Value *Other) {
Hans Wennborgf1f36512015-10-07 00:20:07 +00001009 assert(ICI.isEquality() && "Cannot fold non-equality comparison.");
1010
1011 // It would be tempting to fold away comparisons between allocas and any
1012 // pointer not based on that alloca (e.g. an argument). However, even
1013 // though such pointers cannot alias, they can still compare equal.
1014 //
1015 // But LLVM doesn't specify where allocas get their memory, so if the alloca
1016 // doesn't escape we can argue that it's impossible to guess its value, and we
1017 // can therefore act as if any such guesses are wrong.
1018 //
1019 // The code below checks that the alloca doesn't escape, and that it's only
1020 // used in a comparison once (the current instruction). The
1021 // single-comparison-use condition ensures that we're trivially folding all
1022 // comparisons against the alloca consistently, and avoids the risk of
1023 // erroneously folding a comparison of the pointer with itself.
1024
1025 unsigned MaxIter = 32; // Break cycles and bound to constant-time.
1026
Pete Cooper980a9352016-08-12 17:13:28 +00001027 SmallVector<const Use *, 32> Worklist;
1028 for (const Use &U : Alloca->uses()) {
Hans Wennborgf1f36512015-10-07 00:20:07 +00001029 if (Worklist.size() >= MaxIter)
1030 return nullptr;
1031 Worklist.push_back(&U);
1032 }
1033
1034 unsigned NumCmps = 0;
1035 while (!Worklist.empty()) {
1036 assert(Worklist.size() <= MaxIter);
Pete Cooper980a9352016-08-12 17:13:28 +00001037 const Use *U = Worklist.pop_back_val();
1038 const Value *V = U->getUser();
Hans Wennborgf1f36512015-10-07 00:20:07 +00001039 --MaxIter;
1040
1041 if (isa<BitCastInst>(V) || isa<GetElementPtrInst>(V) || isa<PHINode>(V) ||
1042 isa<SelectInst>(V)) {
1043 // Track the uses.
1044 } else if (isa<LoadInst>(V)) {
1045 // Loading from the pointer doesn't escape it.
1046 continue;
Pete Cooper980a9352016-08-12 17:13:28 +00001047 } else if (const auto *SI = dyn_cast<StoreInst>(V)) {
Hans Wennborgf1f36512015-10-07 00:20:07 +00001048 // Storing *to* the pointer is fine, but storing the pointer escapes it.
1049 if (SI->getValueOperand() == U->get())
1050 return nullptr;
1051 continue;
1052 } else if (isa<ICmpInst>(V)) {
1053 if (NumCmps++)
1054 return nullptr; // Found more than one cmp.
1055 continue;
Pete Cooper980a9352016-08-12 17:13:28 +00001056 } else if (const auto *Intrin = dyn_cast<IntrinsicInst>(V)) {
Hans Wennborgf1f36512015-10-07 00:20:07 +00001057 switch (Intrin->getIntrinsicID()) {
1058 // These intrinsics don't escape or compare the pointer. Memset is safe
1059 // because we don't allow ptrtoint. Memcpy and memmove are safe because
1060 // we don't allow stores, so src cannot point to V.
1061 case Intrinsic::lifetime_start: case Intrinsic::lifetime_end:
Hans Wennborgf1f36512015-10-07 00:20:07 +00001062 case Intrinsic::memcpy: case Intrinsic::memmove: case Intrinsic::memset:
1063 continue;
1064 default:
1065 return nullptr;
1066 }
1067 } else {
1068 return nullptr;
1069 }
Pete Cooper980a9352016-08-12 17:13:28 +00001070 for (const Use &U : V->uses()) {
Hans Wennborgf1f36512015-10-07 00:20:07 +00001071 if (Worklist.size() >= MaxIter)
1072 return nullptr;
1073 Worklist.push_back(&U);
1074 }
1075 }
1076
1077 Type *CmpTy = CmpInst::makeCmpResultType(Other->getType());
Sanjay Patel4b198802016-02-01 22:23:39 +00001078 return replaceInstUsesWith(
Hans Wennborgf1f36512015-10-07 00:20:07 +00001079 ICI,
1080 ConstantInt::get(CmpTy, !CmpInst::isTrueWhenEqual(ICI.getPredicate())));
1081}
1082
Craig Topperbee74792018-08-20 23:04:25 +00001083/// Fold "icmp pred (X+C), X".
1084Instruction *InstCombiner::foldICmpAddOpConst(Value *X, const APInt &C,
Sanjay Patel43395062016-07-21 18:07:40 +00001085 ICmpInst::Predicate Pred) {
Chris Lattner2188e402010-01-04 07:37:31 +00001086 // From this point on, we know that (X+C <= X) --> (X+C < X) because C != 0,
Chris Lattner0ab5e2c2011-04-15 05:18:47 +00001087 // so the values can never be equal. Similarly for all other "or equals"
Chris Lattner2188e402010-01-04 07:37:31 +00001088 // operators.
Craig Topperbee74792018-08-20 23:04:25 +00001089 assert(!!C && "C should not be zero!");
Jim Grosbach129c52a2011-09-30 18:09:53 +00001090
Chris Lattner8c92b572010-01-08 17:48:19 +00001091 // (X+1) <u X --> X >u (MAXUINT-1) --> X == 255
Chris Lattner2188e402010-01-04 07:37:31 +00001092 // (X+2) <u X --> X >u (MAXUINT-2) --> X > 253
1093 // (X+MAXUINT) <u X --> X >u (MAXUINT-MAXUINT) --> X != 0
1094 if (Pred == ICmpInst::ICMP_ULT || Pred == ICmpInst::ICMP_ULE) {
Craig Topperbee74792018-08-20 23:04:25 +00001095 Constant *R = ConstantInt::get(X->getType(),
1096 APInt::getMaxValue(C.getBitWidth()) - C);
Chris Lattner2188e402010-01-04 07:37:31 +00001097 return new ICmpInst(ICmpInst::ICMP_UGT, X, R);
1098 }
Jim Grosbach129c52a2011-09-30 18:09:53 +00001099
Chris Lattner2188e402010-01-04 07:37:31 +00001100 // (X+1) >u X --> X <u (0-1) --> X != 255
1101 // (X+2) >u X --> X <u (0-2) --> X <u 254
1102 // (X+MAXUINT) >u X --> X <u (0-MAXUINT) --> X <u 1 --> X == 0
Duncan Sandse5220012011-02-17 07:46:37 +00001103 if (Pred == ICmpInst::ICMP_UGT || Pred == ICmpInst::ICMP_UGE)
Craig Topperbee74792018-08-20 23:04:25 +00001104 return new ICmpInst(ICmpInst::ICMP_ULT, X,
1105 ConstantInt::get(X->getType(), -C));
Jim Grosbach129c52a2011-09-30 18:09:53 +00001106
Craig Topperbee74792018-08-20 23:04:25 +00001107 APInt SMax = APInt::getSignedMaxValue(C.getBitWidth());
Chris Lattner2188e402010-01-04 07:37:31 +00001108
1109 // (X+ 1) <s X --> X >s (MAXSINT-1) --> X == 127
1110 // (X+ 2) <s X --> X >s (MAXSINT-2) --> X >s 125
1111 // (X+MAXSINT) <s X --> X >s (MAXSINT-MAXSINT) --> X >s 0
1112 // (X+MINSINT) <s X --> X >s (MAXSINT-MINSINT) --> X >s -1
1113 // (X+ -2) <s X --> X >s (MAXSINT- -2) --> X >s 126
1114 // (X+ -1) <s X --> X >s (MAXSINT- -1) --> X != 127
Duncan Sandse5220012011-02-17 07:46:37 +00001115 if (Pred == ICmpInst::ICMP_SLT || Pred == ICmpInst::ICMP_SLE)
Craig Topperbee74792018-08-20 23:04:25 +00001116 return new ICmpInst(ICmpInst::ICMP_SGT, X,
1117 ConstantInt::get(X->getType(), SMax - C));
Jim Grosbach129c52a2011-09-30 18:09:53 +00001118
Chris Lattner2188e402010-01-04 07:37:31 +00001119 // (X+ 1) >s X --> X <s (MAXSINT-(1-1)) --> X != 127
1120 // (X+ 2) >s X --> X <s (MAXSINT-(2-1)) --> X <s 126
1121 // (X+MAXSINT) >s X --> X <s (MAXSINT-(MAXSINT-1)) --> X <s 1
1122 // (X+MINSINT) >s X --> X <s (MAXSINT-(MINSINT-1)) --> X <s -2
1123 // (X+ -2) >s X --> X <s (MAXSINT-(-2-1)) --> X <s -126
1124 // (X+ -1) >s X --> X <s (MAXSINT-(-1-1)) --> X == -128
Jim Grosbach129c52a2011-09-30 18:09:53 +00001125
Chris Lattner2188e402010-01-04 07:37:31 +00001126 assert(Pred == ICmpInst::ICMP_SGT || Pred == ICmpInst::ICMP_SGE);
Craig Topperbee74792018-08-20 23:04:25 +00001127 return new ICmpInst(ICmpInst::ICMP_SLT, X,
1128 ConstantInt::get(X->getType(), SMax - (C - 1)));
Chris Lattner2188e402010-01-04 07:37:31 +00001129}
1130
Sanjay Patel8da42cc2016-09-15 22:26:31 +00001131/// Handle "(icmp eq/ne (ashr/lshr AP2, A), AP1)" ->
1132/// (icmp eq/ne A, Log2(AP2/AP1)) ->
1133/// (icmp eq/ne A, Log2(AP2) - Log2(AP1)).
1134Instruction *InstCombiner::foldICmpShrConstConst(ICmpInst &I, Value *A,
1135 const APInt &AP1,
1136 const APInt &AP2) {
Suyog Sarda3a8c2c12014-07-22 19:19:36 +00001137 assert(I.isEquality() && "Cannot fold icmp gt/lt");
1138
Suyog Sarda3a8c2c12014-07-22 19:19:36 +00001139 auto getICmp = [&I](CmpInst::Predicate Pred, Value *LHS, Value *RHS) {
1140 if (I.getPredicate() == I.ICMP_NE)
1141 Pred = CmpInst::getInversePredicate(Pred);
1142 return new ICmpInst(Pred, LHS, RHS);
1143 };
1144
David Majnemer2abb8182014-10-25 07:13:13 +00001145 // Don't bother doing any work for cases which InstSimplify handles.
Craig Topper73ba1c82017-06-07 07:40:37 +00001146 if (AP2.isNullValue())
David Majnemer2abb8182014-10-25 07:13:13 +00001147 return nullptr;
Sanjay Patel8da42cc2016-09-15 22:26:31 +00001148
1149 bool IsAShr = isa<AShrOperator>(I.getOperand(0));
David Majnemer2abb8182014-10-25 07:13:13 +00001150 if (IsAShr) {
1151 if (AP2.isAllOnesValue())
1152 return nullptr;
1153 if (AP2.isNegative() != AP1.isNegative())
1154 return nullptr;
1155 if (AP2.sgt(AP1))
1156 return nullptr;
1157 }
Suyog Sarda3a8c2c12014-07-22 19:19:36 +00001158
David Majnemerd2056022014-10-21 19:51:55 +00001159 if (!AP1)
Suyog Sarda3a8c2c12014-07-22 19:19:36 +00001160 // 'A' must be large enough to shift out the highest set bit.
1161 return getICmp(I.ICMP_UGT, A,
1162 ConstantInt::get(A->getType(), AP2.logBase2()));
Suyog Sarda3a8c2c12014-07-22 19:19:36 +00001163
David Majnemerd2056022014-10-21 19:51:55 +00001164 if (AP1 == AP2)
1165 return getICmp(I.ICMP_EQ, A, ConstantInt::getNullValue(A->getType()));
Suyog Sarda3a8c2c12014-07-22 19:19:36 +00001166
Andrea Di Biagio5b92b492014-09-17 11:32:31 +00001167 int Shift;
David Majnemerd2056022014-10-21 19:51:55 +00001168 if (IsAShr && AP1.isNegative())
David Majnemere5977eb2015-09-19 00:48:26 +00001169 Shift = AP1.countLeadingOnes() - AP2.countLeadingOnes();
Andrea Di Biagio5b92b492014-09-17 11:32:31 +00001170 else
David Majnemere5977eb2015-09-19 00:48:26 +00001171 Shift = AP1.countLeadingZeros() - AP2.countLeadingZeros();
Suyog Sarda3a8c2c12014-07-22 19:19:36 +00001172
David Majnemerd2056022014-10-21 19:51:55 +00001173 if (Shift > 0) {
David Majnemere5977eb2015-09-19 00:48:26 +00001174 if (IsAShr && AP1 == AP2.ashr(Shift)) {
1175 // There are multiple solutions if we are comparing against -1 and the LHS
David Majnemer47ce0b82015-09-19 00:48:31 +00001176 // of the ashr is not a power of two.
David Majnemere5977eb2015-09-19 00:48:26 +00001177 if (AP1.isAllOnesValue() && !AP2.isPowerOf2())
1178 return getICmp(I.ICMP_UGE, A, ConstantInt::get(A->getType(), Shift));
David Majnemerd2056022014-10-21 19:51:55 +00001179 return getICmp(I.ICMP_EQ, A, ConstantInt::get(A->getType(), Shift));
David Majnemere5977eb2015-09-19 00:48:26 +00001180 } else if (AP1 == AP2.lshr(Shift)) {
1181 return getICmp(I.ICMP_EQ, A, ConstantInt::get(A->getType(), Shift));
1182 }
David Majnemerd2056022014-10-21 19:51:55 +00001183 }
Sanjay Patel524fcdf2016-09-15 19:04:55 +00001184
Suyog Sarda3a8c2c12014-07-22 19:19:36 +00001185 // Shifting const2 will never be equal to const1.
Sanjay Patel524fcdf2016-09-15 19:04:55 +00001186 // FIXME: This should always be handled by InstSimplify?
1187 auto *TorF = ConstantInt::get(I.getType(), I.getPredicate() == I.ICMP_NE);
1188 return replaceInstUsesWith(I, TorF);
Suyog Sarda3a8c2c12014-07-22 19:19:36 +00001189}
Chris Lattner2188e402010-01-04 07:37:31 +00001190
Sanjay Patel8da42cc2016-09-15 22:26:31 +00001191/// Handle "(icmp eq/ne (shl AP2, A), AP1)" ->
1192/// (icmp eq/ne A, TrailingZeros(AP1) - TrailingZeros(AP2)).
1193Instruction *InstCombiner::foldICmpShlConstConst(ICmpInst &I, Value *A,
1194 const APInt &AP1,
1195 const APInt &AP2) {
David Majnemer59939ac2014-10-19 08:23:08 +00001196 assert(I.isEquality() && "Cannot fold icmp gt/lt");
1197
David Majnemer59939ac2014-10-19 08:23:08 +00001198 auto getICmp = [&I](CmpInst::Predicate Pred, Value *LHS, Value *RHS) {
1199 if (I.getPredicate() == I.ICMP_NE)
1200 Pred = CmpInst::getInversePredicate(Pred);
1201 return new ICmpInst(Pred, LHS, RHS);
1202 };
1203
David Majnemer2abb8182014-10-25 07:13:13 +00001204 // Don't bother doing any work for cases which InstSimplify handles.
Craig Topper73ba1c82017-06-07 07:40:37 +00001205 if (AP2.isNullValue())
David Majnemer2abb8182014-10-25 07:13:13 +00001206 return nullptr;
David Majnemer59939ac2014-10-19 08:23:08 +00001207
1208 unsigned AP2TrailingZeros = AP2.countTrailingZeros();
1209
1210 if (!AP1 && AP2TrailingZeros != 0)
Sanjay Patelaf91d1f2016-09-15 21:35:30 +00001211 return getICmp(
1212 I.ICMP_UGE, A,
1213 ConstantInt::get(A->getType(), AP2.getBitWidth() - AP2TrailingZeros));
David Majnemer59939ac2014-10-19 08:23:08 +00001214
1215 if (AP1 == AP2)
1216 return getICmp(I.ICMP_EQ, A, ConstantInt::getNullValue(A->getType()));
1217
1218 // Get the distance between the lowest bits that are set.
1219 int Shift = AP1.countTrailingZeros() - AP2TrailingZeros;
1220
1221 if (Shift > 0 && AP2.shl(Shift) == AP1)
1222 return getICmp(I.ICMP_EQ, A, ConstantInt::get(A->getType(), Shift));
1223
1224 // Shifting const2 will never be equal to const1.
Sanjay Patel524fcdf2016-09-15 19:04:55 +00001225 // FIXME: This should always be handled by InstSimplify?
1226 auto *TorF = ConstantInt::get(I.getType(), I.getPredicate() == I.ICMP_NE);
1227 return replaceInstUsesWith(I, TorF);
David Majnemer59939ac2014-10-19 08:23:08 +00001228}
1229
Sanjay Patel06b127a2016-09-15 14:37:50 +00001230/// The caller has matched a pattern of the form:
1231/// I = icmp ugt (add (add A, B), CI2), CI1
1232/// If this is of the form:
1233/// sum = a + b
1234/// if (sum+128 >u 255)
1235/// Then replace it with llvm.sadd.with.overflow.i8.
1236///
Sanjay Pateld93c4c02016-09-15 18:22:25 +00001237static Instruction *processUGT_ADDCST_ADD(ICmpInst &I, Value *A, Value *B,
Sanjay Patel06b127a2016-09-15 14:37:50 +00001238 ConstantInt *CI2, ConstantInt *CI1,
1239 InstCombiner &IC) {
1240 // The transformation we're trying to do here is to transform this into an
1241 // llvm.sadd.with.overflow. To do this, we have to replace the original add
1242 // with a narrower add, and discard the add-with-constant that is part of the
1243 // range check (if we can't eliminate it, this isn't profitable).
1244
1245 // In order to eliminate the add-with-constant, the compare can be its only
1246 // use.
1247 Instruction *AddWithCst = cast<Instruction>(I.getOperand(0));
1248 if (!AddWithCst->hasOneUse())
1249 return nullptr;
1250
1251 // If CI2 is 2^7, 2^15, 2^31, then it might be an sadd.with.overflow.
1252 if (!CI2->getValue().isPowerOf2())
1253 return nullptr;
1254 unsigned NewWidth = CI2->getValue().countTrailingZeros();
1255 if (NewWidth != 7 && NewWidth != 15 && NewWidth != 31)
1256 return nullptr;
1257
1258 // The width of the new add formed is 1 more than the bias.
1259 ++NewWidth;
1260
1261 // Check to see that CI1 is an all-ones value with NewWidth bits.
1262 if (CI1->getBitWidth() == NewWidth ||
1263 CI1->getValue() != APInt::getLowBitsSet(CI1->getBitWidth(), NewWidth))
1264 return nullptr;
1265
1266 // This is only really a signed overflow check if the inputs have been
1267 // sign-extended; check for that condition. For example, if CI2 is 2^31 and
1268 // the operands of the add are 64 bits wide, we need at least 33 sign bits.
1269 unsigned NeededSignBits = CI1->getBitWidth() - NewWidth + 1;
1270 if (IC.ComputeNumSignBits(A, 0, &I) < NeededSignBits ||
1271 IC.ComputeNumSignBits(B, 0, &I) < NeededSignBits)
1272 return nullptr;
1273
1274 // In order to replace the original add with a narrower
1275 // llvm.sadd.with.overflow, the only uses allowed are the add-with-constant
1276 // and truncates that discard the high bits of the add. Verify that this is
1277 // the case.
1278 Instruction *OrigAdd = cast<Instruction>(AddWithCst->getOperand(0));
1279 for (User *U : OrigAdd->users()) {
1280 if (U == AddWithCst)
1281 continue;
1282
1283 // Only accept truncates for now. We would really like a nice recursive
1284 // predicate like SimplifyDemandedBits, but which goes downwards the use-def
1285 // chain to see which bits of a value are actually demanded. If the
1286 // original add had another add which was then immediately truncated, we
1287 // could still do the transformation.
1288 TruncInst *TI = dyn_cast<TruncInst>(U);
1289 if (!TI || TI->getType()->getPrimitiveSizeInBits() > NewWidth)
1290 return nullptr;
1291 }
1292
1293 // If the pattern matches, truncate the inputs to the narrower type and
1294 // use the sadd_with_overflow intrinsic to efficiently compute both the
1295 // result and the overflow bit.
1296 Type *NewType = IntegerType::get(OrigAdd->getContext(), NewWidth);
James Y Knight7976eb52019-02-01 20:43:25 +00001297 Function *F = Intrinsic::getDeclaration(
1298 I.getModule(), Intrinsic::sadd_with_overflow, NewType);
Sanjay Patel06b127a2016-09-15 14:37:50 +00001299
Craig Topperbb4069e2017-07-07 23:16:26 +00001300 InstCombiner::BuilderTy &Builder = IC.Builder;
Sanjay Patel06b127a2016-09-15 14:37:50 +00001301
1302 // Put the new code above the original add, in case there are any uses of the
1303 // add between the add and the compare.
Craig Topperbb4069e2017-07-07 23:16:26 +00001304 Builder.SetInsertPoint(OrigAdd);
Sanjay Patel06b127a2016-09-15 14:37:50 +00001305
Craig Topperbb4069e2017-07-07 23:16:26 +00001306 Value *TruncA = Builder.CreateTrunc(A, NewType, A->getName() + ".trunc");
1307 Value *TruncB = Builder.CreateTrunc(B, NewType, B->getName() + ".trunc");
1308 CallInst *Call = Builder.CreateCall(F, {TruncA, TruncB}, "sadd");
1309 Value *Add = Builder.CreateExtractValue(Call, 0, "sadd.result");
1310 Value *ZExt = Builder.CreateZExt(Add, OrigAdd->getType());
Sanjay Patel06b127a2016-09-15 14:37:50 +00001311
1312 // The inner add was the result of the narrow add, zero extended to the
1313 // wider type. Replace it with the result computed by the intrinsic.
1314 IC.replaceInstUsesWith(*OrigAdd, ZExt);
1315
1316 // The original icmp gets replaced with the overflow value.
1317 return ExtractValueInst::Create(Call, 1, "sadd.overflow");
1318}
1319
Roman Lebedevbe612ea2019-07-30 15:28:22 +00001320/// If we have:
1321/// icmp eq/ne (urem/srem %x, %y), 0
1322/// iff %y is a power-of-two, we can replace this with a bit test:
1323/// icmp eq/ne (and %x, (add %y, -1)), 0
1324Instruction *InstCombiner::foldIRemByPowerOfTwoToBitTest(ICmpInst &I) {
1325 // This fold is only valid for equality predicates.
1326 if (!I.isEquality())
1327 return nullptr;
1328 ICmpInst::Predicate Pred;
1329 Value *X, *Y, *Zero;
1330 if (!match(&I, m_ICmp(Pred, m_OneUse(m_IRem(m_Value(X), m_Value(Y))),
1331 m_CombineAnd(m_Zero(), m_Value(Zero)))))
1332 return nullptr;
1333 if (!isKnownToBeAPowerOfTwo(Y, /*OrZero*/ true, 0, &I))
1334 return nullptr;
1335 // This may increase instruction count, we don't enforce that Y is a constant.
1336 Value *Mask = Builder.CreateAdd(Y, Constant::getAllOnesValue(Y->getType()));
1337 Value *Masked = Builder.CreateAnd(X, Mask);
1338 return ICmpInst::Create(Instruction::ICmp, Pred, Masked, Zero);
1339}
1340
Roman Lebedevf55818e2019-07-01 09:41:43 +00001341// Handle icmp pred X, 0
Nikolai Bozhenov0e7ebbc2017-10-16 09:19:21 +00001342Instruction *InstCombiner::foldICmpWithZero(ICmpInst &Cmp) {
1343 CmpInst::Predicate Pred = Cmp.getPredicate();
Roman Lebedevf55818e2019-07-01 09:41:43 +00001344 if (!match(Cmp.getOperand(1), m_Zero()))
1345 return nullptr;
Nikolai Bozhenov0e7ebbc2017-10-16 09:19:21 +00001346
Roman Lebedevf55818e2019-07-01 09:41:43 +00001347 // (icmp sgt smin(PosA, B) 0) -> (icmp sgt B 0)
1348 if (Pred == ICmpInst::ICMP_SGT) {
Nikolai Bozhenov0e7ebbc2017-10-16 09:19:21 +00001349 Value *A, *B;
Roman Lebedevf55818e2019-07-01 09:41:43 +00001350 SelectPatternResult SPR = matchSelectPattern(Cmp.getOperand(0), A, B);
Nikolai Bozhenov0e7ebbc2017-10-16 09:19:21 +00001351 if (SPR.Flavor == SPF_SMIN) {
1352 if (isKnownPositive(A, DL, 0, &AC, &Cmp, &DT))
1353 return new ICmpInst(Pred, B, Cmp.getOperand(1));
1354 if (isKnownPositive(B, DL, 0, &AC, &Cmp, &DT))
1355 return new ICmpInst(Pred, A, Cmp.getOperand(1));
1356 }
1357 }
Roman Lebedevf55818e2019-07-01 09:41:43 +00001358
Roman Lebedevbe612ea2019-07-30 15:28:22 +00001359 if (Instruction *New = foldIRemByPowerOfTwoToBitTest(Cmp))
1360 return New;
1361
Roman Lebedevf55818e2019-07-01 09:41:43 +00001362 // Given:
1363 // icmp eq/ne (urem %x, %y), 0
1364 // Iff %x has 0 or 1 bits set, and %y has at least 2 bits set, omit 'urem':
1365 // icmp eq/ne %x, 0
1366 Value *X, *Y;
1367 if (match(Cmp.getOperand(0), m_URem(m_Value(X), m_Value(Y))) &&
1368 ICmpInst::isEquality(Pred)) {
1369 KnownBits XKnown = computeKnownBits(X, 0, &Cmp);
1370 KnownBits YKnown = computeKnownBits(Y, 0, &Cmp);
1371 if (XKnown.countMaxPopulation() == 1 && YKnown.countMinPopulation() >= 2)
1372 return new ICmpInst(Pred, X, Cmp.getOperand(1));
1373 }
1374
Nikolai Bozhenov0e7ebbc2017-10-16 09:19:21 +00001375 return nullptr;
1376}
1377
Sanjay Patela40bf9ff2018-12-04 15:35:17 +00001378/// Fold icmp Pred X, C.
Sanjay Pateld23b5ed2018-12-04 17:44:24 +00001379/// TODO: This code structure does not make sense. The saturating add fold
Sanjay Patela40bf9ff2018-12-04 15:35:17 +00001380/// should be moved to some other helper and extended as noted below (it is also
Sanjay Pateld23b5ed2018-12-04 17:44:24 +00001381/// possible that code has been made unnecessary - do we canonicalize IR to
1382/// overflow/saturating intrinsics or not?).
Sanjay Patel97459832016-09-15 15:11:12 +00001383Instruction *InstCombiner::foldICmpWithConstant(ICmpInst &Cmp) {
Sanjay Patel97459832016-09-15 15:11:12 +00001384 // Match the following pattern, which is a common idiom when writing
1385 // overflow-safe integer arithmetic functions. The source performs an addition
1386 // in wider type and explicitly checks for overflow using comparisons against
1387 // INT_MIN and INT_MAX. Simplify by using the sadd_with_overflow intrinsic.
1388 //
1389 // TODO: This could probably be generalized to handle other overflow-safe
1390 // operations if we worked out the formulas to compute the appropriate magic
1391 // constants.
1392 //
1393 // sum = a + b
1394 // if (sum+128 >u 255) ... -> llvm.sadd.with.overflow.i8
Sanjay Patela40bf9ff2018-12-04 15:35:17 +00001395 CmpInst::Predicate Pred = Cmp.getPredicate();
1396 Value *Op0 = Cmp.getOperand(0), *Op1 = Cmp.getOperand(1);
1397 Value *A, *B;
1398 ConstantInt *CI, *CI2; // I = icmp ugt (add (add A, B), CI2), CI
1399 if (Pred == ICmpInst::ICMP_UGT && match(Op1, m_ConstantInt(CI)) &&
1400 match(Op0, m_Add(m_Add(m_Value(A), m_Value(B)), m_ConstantInt(CI2))))
1401 if (Instruction *Res = processUGT_ADDCST_ADD(Cmp, A, B, CI2, CI, *this))
1402 return Res;
Sanjay Patel06b127a2016-09-15 14:37:50 +00001403
Sanjay Patela40bf9ff2018-12-04 15:35:17 +00001404 return nullptr;
1405}
1406
1407/// Canonicalize icmp instructions based on dominating conditions.
1408Instruction *InstCombiner::foldICmpWithDominatingICmp(ICmpInst &Cmp) {
Sanjay Pateld23b5ed2018-12-04 17:44:24 +00001409 // This is a cheap/incomplete check for dominance - just match a single
1410 // predecessor with a conditional branch.
1411 BasicBlock *CmpBB = Cmp.getParent();
1412 BasicBlock *DomBB = CmpBB->getSinglePredecessor();
1413 if (!DomBB)
Sanjay Patel40c53ea2016-09-15 16:23:20 +00001414 return nullptr;
Sanjay Patel06b127a2016-09-15 14:37:50 +00001415
Sanjay Pateld23b5ed2018-12-04 17:44:24 +00001416 Value *DomCond;
Sanjay Patel97459832016-09-15 15:11:12 +00001417 BasicBlock *TrueBB, *FalseBB;
Sanjay Pateld23b5ed2018-12-04 17:44:24 +00001418 if (!match(DomBB->getTerminator(), m_Br(m_Value(DomCond), TrueBB, FalseBB)))
1419 return nullptr;
1420
1421 assert((TrueBB == CmpBB || FalseBB == CmpBB) &&
1422 "Predecessor block does not point to successor?");
1423
1424 // The branch should get simplified. Don't bother simplifying this condition.
1425 if (TrueBB == FalseBB)
1426 return nullptr;
1427
Sanjay Patelbaffae92018-12-05 15:04:00 +00001428 // Try to simplify this compare to T/F based on the dominating condition.
1429 Optional<bool> Imp = isImpliedCondition(DomCond, &Cmp, DL, TrueBB == CmpBB);
1430 if (Imp)
1431 return replaceInstUsesWith(Cmp, ConstantInt::get(Cmp.getType(), *Imp));
1432
Sanjay Pateld23b5ed2018-12-04 17:44:24 +00001433 CmpInst::Predicate Pred = Cmp.getPredicate();
1434 Value *X = Cmp.getOperand(0), *Y = Cmp.getOperand(1);
1435 ICmpInst::Predicate DomPred;
1436 const APInt *C, *DomC;
1437 if (match(DomCond, m_ICmp(DomPred, m_Specific(X), m_APInt(DomC))) &&
1438 match(Y, m_APInt(C))) {
1439 // We have 2 compares of a variable with constants. Calculate the constant
1440 // ranges of those compares to see if we can transform the 2nd compare:
1441 // DomBB:
1442 // DomCond = icmp DomPred X, DomC
1443 // br DomCond, CmpBB, FalseBB
1444 // CmpBB:
1445 // Cmp = icmp Pred X, C
1446 ConstantRange CR = ConstantRange::makeAllowedICmpRegion(Pred, *C);
Sanjay Patel97459832016-09-15 15:11:12 +00001447 ConstantRange DominatingCR =
Sanjay Pateld23b5ed2018-12-04 17:44:24 +00001448 (CmpBB == TrueBB) ? ConstantRange::makeExactICmpRegion(DomPred, *DomC)
1449 : ConstantRange::makeExactICmpRegion(
1450 CmpInst::getInversePredicate(DomPred), *DomC);
Sanjay Patel97459832016-09-15 15:11:12 +00001451 ConstantRange Intersection = DominatingCR.intersectWith(CR);
1452 ConstantRange Difference = DominatingCR.difference(CR);
1453 if (Intersection.isEmptySet())
Craig Topperbb4069e2017-07-07 23:16:26 +00001454 return replaceInstUsesWith(Cmp, Builder.getFalse());
Sanjay Patel97459832016-09-15 15:11:12 +00001455 if (Difference.isEmptySet())
Craig Topperbb4069e2017-07-07 23:16:26 +00001456 return replaceInstUsesWith(Cmp, Builder.getTrue());
Sanjay Patel06b127a2016-09-15 14:37:50 +00001457
Sanjay Patel97459832016-09-15 15:11:12 +00001458 // Canonicalizing a sign bit comparison that gets used in a branch,
1459 // pessimizes codegen by generating branch on zero instruction instead
1460 // of a test and branch. So we avoid canonicalizing in such situations
1461 // because test and branch instruction has better branch displacement
1462 // than compare and branch instruction.
Sanjay Pateld23b5ed2018-12-04 17:44:24 +00001463 bool UnusedBit;
1464 bool IsSignBit = isSignBitCheck(Pred, *C, UnusedBit);
Eric Christophera95aac32017-06-30 01:57:48 +00001465 if (Cmp.isEquality() || (IsSignBit && hasBranchUse(Cmp)))
1466 return nullptr;
1467
Sanjay Pateld23b5ed2018-12-04 17:44:24 +00001468 if (const APInt *EqC = Intersection.getSingleElement())
1469 return new ICmpInst(ICmpInst::ICMP_EQ, X, Builder.getInt(*EqC));
1470 if (const APInt *NeC = Difference.getSingleElement())
1471 return new ICmpInst(ICmpInst::ICMP_NE, X, Builder.getInt(*NeC));
Sanjay Patel06b127a2016-09-15 14:37:50 +00001472 }
1473
1474 return nullptr;
1475}
1476
Sanjay Patel5f4ce4e2016-08-18 20:25:16 +00001477/// Fold icmp (trunc X, Y), C.
1478Instruction *InstCombiner::foldICmpTruncConstant(ICmpInst &Cmp,
Craig Topper524c44f2017-08-23 05:46:07 +00001479 TruncInst *Trunc,
Craig Topper8ed1aa92017-10-03 05:31:07 +00001480 const APInt &C) {
Sanjay Patel5f4ce4e2016-08-18 20:25:16 +00001481 ICmpInst::Predicate Pred = Cmp.getPredicate();
1482 Value *X = Trunc->getOperand(0);
Craig Topper8ed1aa92017-10-03 05:31:07 +00001483 if (C.isOneValue() && C.getBitWidth() > 1) {
Sanjay Patela3f4f082016-08-16 17:54:36 +00001484 // icmp slt trunc(signum(V)) 1 --> icmp slt V, 1
1485 Value *V = nullptr;
Sanjay Patel5f4ce4e2016-08-18 20:25:16 +00001486 if (Pred == ICmpInst::ICMP_SLT && match(X, m_Signum(m_Value(V))))
Sanjay Patela3f4f082016-08-16 17:54:36 +00001487 return new ICmpInst(ICmpInst::ICMP_SLT, V,
1488 ConstantInt::get(V->getType(), 1));
1489 }
Sanjay Patel5f4ce4e2016-08-18 20:25:16 +00001490
1491 if (Cmp.isEquality() && Trunc->hasOneUse()) {
Sanjay Patela3f4f082016-08-16 17:54:36 +00001492 // Simplify icmp eq (trunc x to i8), 42 -> icmp eq x, 42|highbits if all
1493 // of the high bits truncated out of x are known.
Sanjay Patel40e8ca42016-08-18 20:28:54 +00001494 unsigned DstBits = Trunc->getType()->getScalarSizeInBits(),
1495 SrcBits = X->getType()->getScalarSizeInBits();
Craig Topper8205a1a2017-05-24 16:53:07 +00001496 KnownBits Known = computeKnownBits(X, 0, &Cmp);
Sanjay Patela3f4f082016-08-16 17:54:36 +00001497
1498 // If all the high bits are known, we can do this xform.
Craig Topperb45eabc2017-04-26 16:39:58 +00001499 if ((Known.Zero | Known.One).countLeadingOnes() >= SrcBits - DstBits) {
Sanjay Patela3f4f082016-08-16 17:54:36 +00001500 // Pull in the high bits from known-ones set.
Craig Topper8ed1aa92017-10-03 05:31:07 +00001501 APInt NewRHS = C.zext(SrcBits);
Craig Topperb45eabc2017-04-26 16:39:58 +00001502 NewRHS |= Known.One & APInt::getHighBitsSet(SrcBits, SrcBits - DstBits);
Sanjay Patel40e8ca42016-08-18 20:28:54 +00001503 return new ICmpInst(Pred, X, ConstantInt::get(X->getType(), NewRHS));
Sanjay Patela3f4f082016-08-16 17:54:36 +00001504 }
1505 }
Sanjay Patel5f4ce4e2016-08-18 20:25:16 +00001506
Sanjay Patela3f4f082016-08-16 17:54:36 +00001507 return nullptr;
1508}
1509
Sanjay Patel6d5f4482016-08-17 19:23:42 +00001510/// Fold icmp (xor X, Y), C.
Sanjay Patelc9196c42016-08-22 21:24:29 +00001511Instruction *InstCombiner::foldICmpXorConstant(ICmpInst &Cmp,
1512 BinaryOperator *Xor,
Craig Topper8ed1aa92017-10-03 05:31:07 +00001513 const APInt &C) {
Sanjay Patel4c5e60d2016-08-18 14:10:48 +00001514 Value *X = Xor->getOperand(0);
1515 Value *Y = Xor->getOperand(1);
Sanjay Pateldaffec912016-08-17 19:45:18 +00001516 const APInt *XorC;
Sanjay Patel4c5e60d2016-08-18 14:10:48 +00001517 if (!match(Y, m_APInt(XorC)))
Sanjay Patel6d5f4482016-08-17 19:23:42 +00001518 return nullptr;
Sanjay Patela3f4f082016-08-16 17:54:36 +00001519
Sanjay Patel6d5f4482016-08-17 19:23:42 +00001520 // If this is a comparison that tests the signbit (X < 0) or (x > -1),
1521 // fold the xor.
1522 ICmpInst::Predicate Pred = Cmp.getPredicate();
Craig Topperdf63b962017-10-03 19:14:23 +00001523 bool TrueIfSigned = false;
1524 if (isSignBitCheck(Cmp.getPredicate(), C, TrueIfSigned)) {
Sanjay Patela3f4f082016-08-16 17:54:36 +00001525
Sanjay Patel6d5f4482016-08-17 19:23:42 +00001526 // If the sign bit of the XorCst is not set, there is no change to
1527 // the operation, just stop using the Xor.
Sanjay Pateldaffec912016-08-17 19:45:18 +00001528 if (!XorC->isNegative()) {
1529 Cmp.setOperand(0, X);
Sanjay Patel6d5f4482016-08-17 19:23:42 +00001530 Worklist.Add(Xor);
1531 return &Cmp;
Sanjay Patela3f4f082016-08-16 17:54:36 +00001532 }
1533
Craig Topperdf63b962017-10-03 19:14:23 +00001534 // Emit the opposite comparison.
1535 if (TrueIfSigned)
1536 return new ICmpInst(ICmpInst::ICMP_SGT, X,
1537 ConstantInt::getAllOnesValue(X->getType()));
Sanjay Patel6d5f4482016-08-17 19:23:42 +00001538 else
Craig Topperdf63b962017-10-03 19:14:23 +00001539 return new ICmpInst(ICmpInst::ICMP_SLT, X,
1540 ConstantInt::getNullValue(X->getType()));
Sanjay Patela3f4f082016-08-16 17:54:36 +00001541 }
Sanjay Patel6d5f4482016-08-17 19:23:42 +00001542
1543 if (Xor->hasOneUse()) {
Craig Topperbcfd2d12017-04-20 16:56:25 +00001544 // (icmp u/s (xor X SignMask), C) -> (icmp s/u X, (xor C SignMask))
1545 if (!Cmp.isEquality() && XorC->isSignMask()) {
Sanjay Pateldaffec912016-08-17 19:45:18 +00001546 Pred = Cmp.isSigned() ? Cmp.getUnsignedPredicate()
1547 : Cmp.getSignedPredicate();
Craig Topper8ed1aa92017-10-03 05:31:07 +00001548 return new ICmpInst(Pred, X, ConstantInt::get(X->getType(), C ^ *XorC));
Sanjay Patel6d5f4482016-08-17 19:23:42 +00001549 }
1550
Craig Topperbcfd2d12017-04-20 16:56:25 +00001551 // (icmp u/s (xor X ~SignMask), C) -> (icmp s/u X, (xor C ~SignMask))
Sanjay Pateldaffec912016-08-17 19:45:18 +00001552 if (!Cmp.isEquality() && XorC->isMaxSignedValue()) {
1553 Pred = Cmp.isSigned() ? Cmp.getUnsignedPredicate()
1554 : Cmp.getSignedPredicate();
Sanjay Patel6d5f4482016-08-17 19:23:42 +00001555 Pred = Cmp.getSwappedPredicate(Pred);
Craig Topper8ed1aa92017-10-03 05:31:07 +00001556 return new ICmpInst(Pred, X, ConstantInt::get(X->getType(), C ^ *XorC));
Sanjay Patel6d5f4482016-08-17 19:23:42 +00001557 }
1558 }
1559
Sanjay Patel26725bd2018-09-11 22:00:15 +00001560 // Mask constant magic can eliminate an 'xor' with unsigned compares.
1561 if (Pred == ICmpInst::ICMP_UGT) {
1562 // (xor X, ~C) >u C --> X <u ~C (when C+1 is a power of 2)
1563 if (*XorC == ~C && (C + 1).isPowerOf2())
1564 return new ICmpInst(ICmpInst::ICMP_ULT, X, Y);
1565 // (xor X, C) >u C --> X >u C (when C+1 is a power of 2)
1566 if (*XorC == C && (C + 1).isPowerOf2())
1567 return new ICmpInst(ICmpInst::ICMP_UGT, X, Y);
1568 }
1569 if (Pred == ICmpInst::ICMP_ULT) {
1570 // (xor X, -C) <u C --> X >u ~C (when C is a power of 2)
1571 if (*XorC == -C && C.isPowerOf2())
1572 return new ICmpInst(ICmpInst::ICMP_UGT, X,
1573 ConstantInt::get(X->getType(), ~C));
1574 // (xor X, C) <u C --> X >u ~C (when -C is a power of 2)
1575 if (*XorC == C && (-C).isPowerOf2())
1576 return new ICmpInst(ICmpInst::ICMP_UGT, X,
1577 ConstantInt::get(X->getType(), ~C));
1578 }
Sanjay Patela3f4f082016-08-16 17:54:36 +00001579 return nullptr;
1580}
1581
Sanjay Patel14e0e182016-08-26 18:28:46 +00001582/// Fold icmp (and (sh X, Y), C2), C1.
1583Instruction *InstCombiner::foldICmpAndShift(ICmpInst &Cmp, BinaryOperator *And,
Craig Topper8ed1aa92017-10-03 05:31:07 +00001584 const APInt &C1, const APInt &C2) {
Sanjay Patel9b40f982016-09-07 22:33:03 +00001585 BinaryOperator *Shift = dyn_cast<BinaryOperator>(And->getOperand(0));
1586 if (!Shift || !Shift->isShift())
Sanjay Patelda9c5622016-08-26 17:15:22 +00001587 return nullptr;
Sanjay Patela3f4f082016-08-16 17:54:36 +00001588
Sanjay Patelda9c5622016-08-26 17:15:22 +00001589 // If this is: (X >> C3) & C2 != C1 (where any shift and any compare could
1590 // exist), turn it into (X & (C2 << C3)) != (C1 << C3). This happens a LOT in
1591 // code produced by the clang front-end, for bitfield access.
Sanjay Patelda9c5622016-08-26 17:15:22 +00001592 // This seemingly simple opportunity to fold away a shift turns out to be
1593 // rather complicated. See PR17827 for details.
Sanjay Patel9b40f982016-09-07 22:33:03 +00001594 unsigned ShiftOpcode = Shift->getOpcode();
1595 bool IsShl = ShiftOpcode == Instruction::Shl;
1596 const APInt *C3;
1597 if (match(Shift->getOperand(1), m_APInt(C3))) {
Sanjay Patelda9c5622016-08-26 17:15:22 +00001598 bool CanFold = false;
Craig Topper7a930922017-10-04 23:06:13 +00001599 if (ShiftOpcode == Instruction::Shl) {
Sanjay Patelda9c5622016-08-26 17:15:22 +00001600 // For a left shift, we can fold if the comparison is not signed. We can
1601 // also fold a signed comparison if the mask value and comparison value
1602 // are not negative. These constraints may not be obvious, but we can
1603 // prove that they are correct using an SMT solver.
Craig Topper8ed1aa92017-10-03 05:31:07 +00001604 if (!Cmp.isSigned() || (!C2.isNegative() && !C1.isNegative()))
Sanjay Patelda9c5622016-08-26 17:15:22 +00001605 CanFold = true;
Craig Topper7a930922017-10-04 23:06:13 +00001606 } else {
1607 bool IsAshr = ShiftOpcode == Instruction::AShr;
Sanjay Patelda9c5622016-08-26 17:15:22 +00001608 // For a logical right shift, we can fold if the comparison is not signed.
1609 // We can also fold a signed comparison if the shifted mask value and the
1610 // shifted comparison value are not negative. These constraints may not be
1611 // obvious, but we can prove that they are correct using an SMT solver.
Craig Topper7a930922017-10-04 23:06:13 +00001612 // For an arithmetic shift right we can do the same, if we ensure
1613 // the And doesn't use any bits being shifted in. Normally these would
1614 // be turned into lshr by SimplifyDemandedBits, but not if there is an
1615 // additional user.
1616 if (!IsAshr || (C2.shl(*C3).lshr(*C3) == C2)) {
1617 if (!Cmp.isSigned() ||
1618 (!C2.shl(*C3).isNegative() && !C1.shl(*C3).isNegative()))
1619 CanFold = true;
1620 }
Sanjay Patela3f4f082016-08-16 17:54:36 +00001621 }
1622
Sanjay Patelda9c5622016-08-26 17:15:22 +00001623 if (CanFold) {
Craig Topper8ed1aa92017-10-03 05:31:07 +00001624 APInt NewCst = IsShl ? C1.lshr(*C3) : C1.shl(*C3);
Sanjay Patel9b40f982016-09-07 22:33:03 +00001625 APInt SameAsC1 = IsShl ? NewCst.shl(*C3) : NewCst.lshr(*C3);
Sanjay Patelda9c5622016-08-26 17:15:22 +00001626 // Check to see if we are shifting out any of the bits being compared.
Craig Topper8ed1aa92017-10-03 05:31:07 +00001627 if (SameAsC1 != C1) {
Sanjay Patelda9c5622016-08-26 17:15:22 +00001628 // If we shifted bits out, the fold is not going to work out. As a
1629 // special case, check to see if this means that the result is always
1630 // true or false now.
1631 if (Cmp.getPredicate() == ICmpInst::ICMP_EQ)
Sanjay Patel1c608f42016-09-08 16:54:02 +00001632 return replaceInstUsesWith(Cmp, ConstantInt::getFalse(Cmp.getType()));
Sanjay Patelda9c5622016-08-26 17:15:22 +00001633 if (Cmp.getPredicate() == ICmpInst::ICMP_NE)
Sanjay Patel1c608f42016-09-08 16:54:02 +00001634 return replaceInstUsesWith(Cmp, ConstantInt::getTrue(Cmp.getType()));
Sanjay Patela3f4f082016-08-16 17:54:36 +00001635 } else {
Sanjay Patel9b40f982016-09-07 22:33:03 +00001636 Cmp.setOperand(1, ConstantInt::get(And->getType(), NewCst));
Craig Topper8ed1aa92017-10-03 05:31:07 +00001637 APInt NewAndCst = IsShl ? C2.lshr(*C3) : C2.shl(*C3);
Sanjay Patel9b40f982016-09-07 22:33:03 +00001638 And->setOperand(1, ConstantInt::get(And->getType(), NewAndCst));
Sanjay Patelda9c5622016-08-26 17:15:22 +00001639 And->setOperand(0, Shift->getOperand(0));
1640 Worklist.Add(Shift); // Shift is dead.
1641 return &Cmp;
Sanjay Patela3f4f082016-08-16 17:54:36 +00001642 }
Sanjay Patelda9c5622016-08-26 17:15:22 +00001643 }
1644 }
Sanjay Patela3f4f082016-08-16 17:54:36 +00001645
Sanjay Patelda9c5622016-08-26 17:15:22 +00001646 // Turn ((X >> Y) & C2) == 0 into (X & (C2 << Y)) == 0. The latter is
1647 // preferable because it allows the C2 << Y expression to be hoisted out of a
1648 // loop if Y is invariant and X is not.
Craig Topper8ed1aa92017-10-03 05:31:07 +00001649 if (Shift->hasOneUse() && C1.isNullValue() && Cmp.isEquality() &&
Sanjay Patelda9c5622016-08-26 17:15:22 +00001650 !Shift->isArithmeticShift() && !isa<Constant>(Shift->getOperand(0))) {
1651 // Compute C2 << Y.
Sanjay Patel9b40f982016-09-07 22:33:03 +00001652 Value *NewShift =
Craig Topperbb4069e2017-07-07 23:16:26 +00001653 IsShl ? Builder.CreateLShr(And->getOperand(1), Shift->getOperand(1))
1654 : Builder.CreateShl(And->getOperand(1), Shift->getOperand(1));
Sanjay Patela3f4f082016-08-16 17:54:36 +00001655
Sanjay Patelda9c5622016-08-26 17:15:22 +00001656 // Compute X & (C2 << Y).
Craig Topperbb4069e2017-07-07 23:16:26 +00001657 Value *NewAnd = Builder.CreateAnd(Shift->getOperand(0), NewShift);
Sanjay Patelda9c5622016-08-26 17:15:22 +00001658 Cmp.setOperand(0, NewAnd);
1659 return &Cmp;
1660 }
1661
Sanjay Patel14e0e182016-08-26 18:28:46 +00001662 return nullptr;
1663}
1664
1665/// Fold icmp (and X, C2), C1.
1666Instruction *InstCombiner::foldICmpAndConstConst(ICmpInst &Cmp,
1667 BinaryOperator *And,
Craig Topper8ed1aa92017-10-03 05:31:07 +00001668 const APInt &C1) {
Huihui Zhang670778c2019-06-19 17:31:39 +00001669 bool isICMP_NE = Cmp.getPredicate() == ICmpInst::ICMP_NE;
1670
Sanjay Patel05aadf82018-10-10 20:47:46 +00001671 // For vectors: icmp ne (and X, 1), 0 --> trunc X to N x i1
1672 // TODO: We canonicalize to the longer form for scalars because we have
1673 // better analysis/folds for icmp, and codegen may be better with icmp.
Huihui Zhang670778c2019-06-19 17:31:39 +00001674 if (isICMP_NE && Cmp.getType()->isVectorTy() && C1.isNullValue() &&
1675 match(And->getOperand(1), m_One()))
Sanjay Patel05aadf82018-10-10 20:47:46 +00001676 return new TruncInst(And->getOperand(0), Cmp.getType());
1677
Sanjay Patel6b490972016-09-04 14:32:15 +00001678 const APInt *C2;
Huihui Zhang670778c2019-06-19 17:31:39 +00001679 Value *X;
1680 if (!match(And, m_And(m_Value(X), m_APInt(C2))))
Sanjay Patel14e0e182016-08-26 18:28:46 +00001681 return nullptr;
1682
Huihui Zhang670778c2019-06-19 17:31:39 +00001683 // Don't perform the following transforms if the AND has multiple uses
Craig Topper8bf62212017-09-26 18:47:25 +00001684 if (!And->hasOneUse())
Sanjay Patel14e0e182016-08-26 18:28:46 +00001685 return nullptr;
1686
Huihui Zhang670778c2019-06-19 17:31:39 +00001687 if (Cmp.isEquality() && C1.isNullValue()) {
1688 // Restrict this fold to single-use 'and' (PR10267).
1689 // Replace (and X, (1 << size(X)-1) != 0) with X s< 0
1690 if (C2->isSignMask()) {
1691 Constant *Zero = Constant::getNullValue(X->getType());
1692 auto NewPred = isICMP_NE ? ICmpInst::ICMP_SLT : ICmpInst::ICMP_SGE;
1693 return new ICmpInst(NewPred, X, Zero);
1694 }
Huihui Zhang46266132019-06-25 00:09:10 +00001695
1696 // Restrict this fold only for single-use 'and' (PR10267).
1697 // ((%x & C) == 0) --> %x u< (-C) iff (-C) is power of two.
1698 if ((~(*C2) + 1).isPowerOf2()) {
1699 Constant *NegBOC =
1700 ConstantExpr::getNeg(cast<Constant>(And->getOperand(1)));
1701 auto NewPred = isICMP_NE ? ICmpInst::ICMP_UGE : ICmpInst::ICMP_ULT;
1702 return new ICmpInst(NewPred, X, NegBOC);
1703 }
Huihui Zhang670778c2019-06-19 17:31:39 +00001704 }
1705
Sanjay Patel6b490972016-09-04 14:32:15 +00001706 // If the LHS is an 'and' of a truncate and we can widen the and/compare to
1707 // the input width without changing the value produced, eliminate the cast:
1708 //
1709 // icmp (and (trunc W), C2), C1 -> icmp (and W, C2'), C1'
1710 //
1711 // We can do this transformation if the constants do not have their sign bits
1712 // set or if it is an equality comparison. Extending a relational comparison
1713 // when we're checking the sign bit would not work.
1714 Value *W;
Craig Topper8bf62212017-09-26 18:47:25 +00001715 if (match(And->getOperand(0), m_OneUse(m_Trunc(m_Value(W)))) &&
Craig Topper8ed1aa92017-10-03 05:31:07 +00001716 (Cmp.isEquality() || (!C1.isNegative() && !C2->isNegative()))) {
Sanjay Patel6b490972016-09-04 14:32:15 +00001717 // TODO: Is this a good transform for vectors? Wider types may reduce
1718 // throughput. Should this transform be limited (even for scalars) by using
Sanjay Patel2217f752017-01-31 17:25:42 +00001719 // shouldChangeType()?
Sanjay Patel6b490972016-09-04 14:32:15 +00001720 if (!Cmp.getType()->isVectorTy()) {
1721 Type *WideType = W->getType();
1722 unsigned WideScalarBits = WideType->getScalarSizeInBits();
Craig Topper8ed1aa92017-10-03 05:31:07 +00001723 Constant *ZextC1 = ConstantInt::get(WideType, C1.zext(WideScalarBits));
Sanjay Patel6b490972016-09-04 14:32:15 +00001724 Constant *ZextC2 = ConstantInt::get(WideType, C2->zext(WideScalarBits));
Craig Topperbb4069e2017-07-07 23:16:26 +00001725 Value *NewAnd = Builder.CreateAnd(W, ZextC2, And->getName());
Sanjay Patel6b490972016-09-04 14:32:15 +00001726 return new ICmpInst(Cmp.getPredicate(), NewAnd, ZextC1);
Sanjay Patel14e0e182016-08-26 18:28:46 +00001727 }
1728 }
1729
Craig Topper8ed1aa92017-10-03 05:31:07 +00001730 if (Instruction *I = foldICmpAndShift(Cmp, And, C1, *C2))
Sanjay Patel14e0e182016-08-26 18:28:46 +00001731 return I;
1732
Sanjay Patelda9c5622016-08-26 17:15:22 +00001733 // (icmp pred (and (or (lshr A, B), A), 1), 0) -->
Sanjay Patel6b490972016-09-04 14:32:15 +00001734 // (icmp pred (and A, (or (shl 1, B), 1), 0))
Sanjay Patelda9c5622016-08-26 17:15:22 +00001735 //
1736 // iff pred isn't signed
Craig Topper8ed1aa92017-10-03 05:31:07 +00001737 if (!Cmp.isSigned() && C1.isNullValue() && And->getOperand(0)->hasOneUse() &&
Craig Topper73ba1c82017-06-07 07:40:37 +00001738 match(And->getOperand(1), m_One())) {
Sanjay Pateldef931e2016-09-07 20:50:44 +00001739 Constant *One = cast<Constant>(And->getOperand(1));
1740 Value *Or = And->getOperand(0);
Sanjay Patelda9c5622016-08-26 17:15:22 +00001741 Value *A, *B, *LShr;
Sanjay Pateldef931e2016-09-07 20:50:44 +00001742 if (match(Or, m_Or(m_Value(LShr), m_Value(A))) &&
1743 match(LShr, m_LShr(m_Specific(A), m_Value(B)))) {
1744 unsigned UsesRemoved = 0;
1745 if (And->hasOneUse())
1746 ++UsesRemoved;
1747 if (Or->hasOneUse())
1748 ++UsesRemoved;
1749 if (LShr->hasOneUse())
1750 ++UsesRemoved;
1751
1752 // Compute A & ((1 << B) | 1)
1753 Value *NewOr = nullptr;
1754 if (auto *C = dyn_cast<Constant>(B)) {
1755 if (UsesRemoved >= 1)
1756 NewOr = ConstantExpr::getOr(ConstantExpr::getNUWShl(One, C), One);
1757 } else {
1758 if (UsesRemoved >= 3)
Craig Topperbb4069e2017-07-07 23:16:26 +00001759 NewOr = Builder.CreateOr(Builder.CreateShl(One, B, LShr->getName(),
1760 /*HasNUW=*/true),
1761 One, Or->getName());
Sanjay Pateldef931e2016-09-07 20:50:44 +00001762 }
1763 if (NewOr) {
Craig Topperbb4069e2017-07-07 23:16:26 +00001764 Value *NewAnd = Builder.CreateAnd(A, NewOr, And->getName());
Sanjay Pateldef931e2016-09-07 20:50:44 +00001765 Cmp.setOperand(0, NewAnd);
1766 return &Cmp;
Sanjay Patela3f4f082016-08-16 17:54:36 +00001767 }
1768 }
Sanjay Patela3f4f082016-08-16 17:54:36 +00001769 }
Sanjay Patelda9c5622016-08-26 17:15:22 +00001770
Sanjay Pateld3c7bb282016-08-26 16:42:33 +00001771 return nullptr;
1772}
1773
1774/// Fold icmp (and X, Y), C.
1775Instruction *InstCombiner::foldICmpAndConstant(ICmpInst &Cmp,
1776 BinaryOperator *And,
Craig Topper8ed1aa92017-10-03 05:31:07 +00001777 const APInt &C) {
Sanjay Pateld3c7bb282016-08-26 16:42:33 +00001778 if (Instruction *I = foldICmpAndConstConst(Cmp, And, C))
1779 return I;
1780
Sanjay Patel5c5311f2016-08-28 18:18:00 +00001781 // TODO: These all require that Y is constant too, so refactor with the above.
Sanjay Patela3f4f082016-08-16 17:54:36 +00001782
Sanjay Patel5c5311f2016-08-28 18:18:00 +00001783 // Try to optimize things like "A[i] & 42 == 0" to index computations.
1784 Value *X = And->getOperand(0);
1785 Value *Y = And->getOperand(1);
1786 if (auto *LI = dyn_cast<LoadInst>(X))
1787 if (auto *GEP = dyn_cast<GetElementPtrInst>(LI->getOperand(0)))
1788 if (auto *GV = dyn_cast<GlobalVariable>(GEP->getOperand(0)))
Sanjay Patela3f4f082016-08-16 17:54:36 +00001789 if (GV->isConstant() && GV->hasDefinitiveInitializer() &&
Sanjay Patel5c5311f2016-08-28 18:18:00 +00001790 !LI->isVolatile() && isa<ConstantInt>(Y)) {
1791 ConstantInt *C2 = cast<ConstantInt>(Y);
1792 if (Instruction *Res = foldCmpLoadFromIndexedGlobal(GEP, GV, Cmp, C2))
Sanjay Patela3f4f082016-08-16 17:54:36 +00001793 return Res;
1794 }
Sanjay Patel5c5311f2016-08-28 18:18:00 +00001795
1796 if (!Cmp.isEquality())
1797 return nullptr;
Sanjay Patela3f4f082016-08-16 17:54:36 +00001798
1799 // X & -C == -C -> X > u ~C
1800 // X & -C != -C -> X <= u ~C
1801 // iff C is a power of 2
Craig Topper8ed1aa92017-10-03 05:31:07 +00001802 if (Cmp.getOperand(1) == Y && (-C).isPowerOf2()) {
Sanjay Patel5c5311f2016-08-28 18:18:00 +00001803 auto NewPred = Cmp.getPredicate() == CmpInst::ICMP_EQ ? CmpInst::ICMP_UGT
1804 : CmpInst::ICMP_ULE;
1805 return new ICmpInst(NewPred, X, SubOne(cast<Constant>(Cmp.getOperand(1))));
1806 }
Sanjay Patela3f4f082016-08-16 17:54:36 +00001807
Sanjay Patel5c5311f2016-08-28 18:18:00 +00001808 // (X & C2) == 0 -> (trunc X) >= 0
1809 // (X & C2) != 0 -> (trunc X) < 0
1810 // iff C2 is a power of 2 and it masks the sign bit of a legal integer type.
1811 const APInt *C2;
Craig Topper8ed1aa92017-10-03 05:31:07 +00001812 if (And->hasOneUse() && C.isNullValue() && match(Y, m_APInt(C2))) {
Sanjay Patel5c5311f2016-08-28 18:18:00 +00001813 int32_t ExactLogBase2 = C2->exactLogBase2();
1814 if (ExactLogBase2 != -1 && DL.isLegalInteger(ExactLogBase2 + 1)) {
1815 Type *NTy = IntegerType::get(Cmp.getContext(), ExactLogBase2 + 1);
1816 if (And->getType()->isVectorTy())
1817 NTy = VectorType::get(NTy, And->getType()->getVectorNumElements());
Craig Topperbb4069e2017-07-07 23:16:26 +00001818 Value *Trunc = Builder.CreateTrunc(X, NTy);
Sanjay Patel5c5311f2016-08-28 18:18:00 +00001819 auto NewPred = Cmp.getPredicate() == CmpInst::ICMP_EQ ? CmpInst::ICMP_SGE
1820 : CmpInst::ICMP_SLT;
1821 return new ICmpInst(NewPred, Trunc, Constant::getNullValue(NTy));
Sanjay Patela3f4f082016-08-16 17:54:36 +00001822 }
1823 }
Sanjay Patel5c5311f2016-08-28 18:18:00 +00001824
Sanjay Patela3f4f082016-08-16 17:54:36 +00001825 return nullptr;
1826}
1827
Sanjay Patel943e92e2016-08-17 16:30:43 +00001828/// Fold icmp (or X, Y), C.
Sanjay Patelc9196c42016-08-22 21:24:29 +00001829Instruction *InstCombiner::foldICmpOrConstant(ICmpInst &Cmp, BinaryOperator *Or,
Craig Topper8ed1aa92017-10-03 05:31:07 +00001830 const APInt &C) {
Sanjay Patel943e92e2016-08-17 16:30:43 +00001831 ICmpInst::Predicate Pred = Cmp.getPredicate();
Craig Topper8ed1aa92017-10-03 05:31:07 +00001832 if (C.isOneValue()) {
Sanjay Patela3f4f082016-08-16 17:54:36 +00001833 // icmp slt signum(V) 1 --> icmp slt V, 1
1834 Value *V = nullptr;
Sanjay Patel943e92e2016-08-17 16:30:43 +00001835 if (Pred == ICmpInst::ICMP_SLT && match(Or, m_Signum(m_Value(V))))
Sanjay Patela3f4f082016-08-16 17:54:36 +00001836 return new ICmpInst(ICmpInst::ICMP_SLT, V,
1837 ConstantInt::get(V->getType(), 1));
1838 }
1839
Sanjay Patel68bc5fb2019-02-06 16:43:54 +00001840 Value *OrOp0 = Or->getOperand(0), *OrOp1 = Or->getOperand(1);
1841 if (Cmp.isEquality() && Cmp.getOperand(1) == OrOp1) {
1842 // X | C == C --> X <=u C
1843 // X | C != C --> X >u C
1844 // iff C+1 is a power of 2 (C is a bitmask of the low bits)
1845 if ((C + 1).isPowerOf2()) {
1846 Pred = (Pred == CmpInst::ICMP_EQ) ? CmpInst::ICMP_ULE : CmpInst::ICMP_UGT;
1847 return new ICmpInst(Pred, OrOp0, OrOp1);
1848 }
1849 // More general: are all bits outside of a mask constant set or not set?
1850 // X | C == C --> (X & ~C) == 0
1851 // X | C != C --> (X & ~C) != 0
1852 if (Or->hasOneUse()) {
1853 Value *A = Builder.CreateAnd(OrOp0, ~C);
1854 return new ICmpInst(Pred, A, ConstantInt::getNullValue(OrOp0->getType()));
1855 }
Sanjay Patel50c82c42017-04-05 17:57:05 +00001856 }
1857
Craig Topper8ed1aa92017-10-03 05:31:07 +00001858 if (!Cmp.isEquality() || !C.isNullValue() || !Or->hasOneUse())
Sanjay Patela3f4f082016-08-16 17:54:36 +00001859 return nullptr;
1860
1861 Value *P, *Q;
Sanjay Patel943e92e2016-08-17 16:30:43 +00001862 if (match(Or, m_Or(m_PtrToInt(m_Value(P)), m_PtrToInt(m_Value(Q))))) {
Sanjay Patela3f4f082016-08-16 17:54:36 +00001863 // Simplify icmp eq (or (ptrtoint P), (ptrtoint Q)), 0
1864 // -> and (icmp eq P, null), (icmp eq Q, null).
Reid Klecknera871d382016-08-19 16:53:18 +00001865 Value *CmpP =
Craig Topperbb4069e2017-07-07 23:16:26 +00001866 Builder.CreateICmp(Pred, P, ConstantInt::getNullValue(P->getType()));
Reid Klecknera871d382016-08-19 16:53:18 +00001867 Value *CmpQ =
Craig Topperbb4069e2017-07-07 23:16:26 +00001868 Builder.CreateICmp(Pred, Q, ConstantInt::getNullValue(Q->getType()));
Sanjay Patel3f4db3e2017-07-14 15:09:49 +00001869 auto BOpc = Pred == CmpInst::ICMP_EQ ? Instruction::And : Instruction::Or;
1870 return BinaryOperator::Create(BOpc, CmpP, CmpQ);
1871 }
1872
1873 // Are we using xors to bitwise check for a pair of (in)equalities? Convert to
1874 // a shorter form that has more potential to be folded even further.
1875 Value *X1, *X2, *X3, *X4;
Sanjay Patel68bc5fb2019-02-06 16:43:54 +00001876 if (match(OrOp0, m_OneUse(m_Xor(m_Value(X1), m_Value(X2)))) &&
1877 match(OrOp1, m_OneUse(m_Xor(m_Value(X3), m_Value(X4))))) {
Sanjay Patel3f4db3e2017-07-14 15:09:49 +00001878 // ((X1 ^ X2) || (X3 ^ X4)) == 0 --> (X1 == X2) && (X3 == X4)
1879 // ((X1 ^ X2) || (X3 ^ X4)) != 0 --> (X1 != X2) || (X3 != X4)
1880 Value *Cmp12 = Builder.CreateICmp(Pred, X1, X2);
1881 Value *Cmp34 = Builder.CreateICmp(Pred, X3, X4);
1882 auto BOpc = Pred == CmpInst::ICMP_EQ ? Instruction::And : Instruction::Or;
1883 return BinaryOperator::Create(BOpc, Cmp12, Cmp34);
Sanjay Patela3f4f082016-08-16 17:54:36 +00001884 }
Sanjay Patel943e92e2016-08-17 16:30:43 +00001885
Sanjay Patela3f4f082016-08-16 17:54:36 +00001886 return nullptr;
1887}
1888
Sanjay Patel63478072016-08-18 15:44:44 +00001889/// Fold icmp (mul X, Y), C.
Sanjay Patelc9196c42016-08-22 21:24:29 +00001890Instruction *InstCombiner::foldICmpMulConstant(ICmpInst &Cmp,
1891 BinaryOperator *Mul,
Craig Topper8ed1aa92017-10-03 05:31:07 +00001892 const APInt &C) {
Sanjay Patel63478072016-08-18 15:44:44 +00001893 const APInt *MulC;
1894 if (!match(Mul->getOperand(1), m_APInt(MulC)))
Sanjay Patela3f4f082016-08-16 17:54:36 +00001895 return nullptr;
1896
Sanjay Patel63478072016-08-18 15:44:44 +00001897 // If this is a test of the sign bit and the multiply is sign-preserving with
1898 // a constant operand, use the multiply LHS operand instead.
1899 ICmpInst::Predicate Pred = Cmp.getPredicate();
Craig Topper8ed1aa92017-10-03 05:31:07 +00001900 if (isSignTest(Pred, C) && Mul->hasNoSignedWrap()) {
Sanjay Patel63478072016-08-18 15:44:44 +00001901 if (MulC->isNegative())
1902 Pred = ICmpInst::getSwappedPredicate(Pred);
1903 return new ICmpInst(Pred, Mul->getOperand(0),
1904 Constant::getNullValue(Mul->getType()));
1905 }
Sanjay Patela3f4f082016-08-16 17:54:36 +00001906
1907 return nullptr;
1908}
1909
Sanjay Patel98cd99d2016-08-18 21:28:30 +00001910/// Fold icmp (shl 1, Y), C.
1911static Instruction *foldICmpShlOne(ICmpInst &Cmp, Instruction *Shl,
Craig Topper8ed1aa92017-10-03 05:31:07 +00001912 const APInt &C) {
Sanjay Patel98cd99d2016-08-18 21:28:30 +00001913 Value *Y;
1914 if (!match(Shl, m_Shl(m_One(), m_Value(Y))))
1915 return nullptr;
1916
1917 Type *ShiftType = Shl->getType();
Craig Topper8ed1aa92017-10-03 05:31:07 +00001918 unsigned TypeBits = C.getBitWidth();
1919 bool CIsPowerOf2 = C.isPowerOf2();
Sanjay Patel98cd99d2016-08-18 21:28:30 +00001920 ICmpInst::Predicate Pred = Cmp.getPredicate();
1921 if (Cmp.isUnsigned()) {
1922 // (1 << Y) pred C -> Y pred Log2(C)
1923 if (!CIsPowerOf2) {
1924 // (1 << Y) < 30 -> Y <= 4
1925 // (1 << Y) <= 30 -> Y <= 4
1926 // (1 << Y) >= 30 -> Y > 4
1927 // (1 << Y) > 30 -> Y > 4
1928 if (Pred == ICmpInst::ICMP_ULT)
1929 Pred = ICmpInst::ICMP_ULE;
1930 else if (Pred == ICmpInst::ICMP_UGE)
1931 Pred = ICmpInst::ICMP_UGT;
1932 }
1933
1934 // (1 << Y) >= 2147483648 -> Y >= 31 -> Y == 31
1935 // (1 << Y) < 2147483648 -> Y < 31 -> Y != 31
Craig Topper8ed1aa92017-10-03 05:31:07 +00001936 unsigned CLog2 = C.logBase2();
Sanjay Patel98cd99d2016-08-18 21:28:30 +00001937 if (CLog2 == TypeBits - 1) {
1938 if (Pred == ICmpInst::ICMP_UGE)
1939 Pred = ICmpInst::ICMP_EQ;
1940 else if (Pred == ICmpInst::ICMP_ULT)
1941 Pred = ICmpInst::ICMP_NE;
1942 }
1943 return new ICmpInst(Pred, Y, ConstantInt::get(ShiftType, CLog2));
1944 } else if (Cmp.isSigned()) {
1945 Constant *BitWidthMinusOne = ConstantInt::get(ShiftType, TypeBits - 1);
Craig Topper8ed1aa92017-10-03 05:31:07 +00001946 if (C.isAllOnesValue()) {
Sanjay Patel98cd99d2016-08-18 21:28:30 +00001947 // (1 << Y) <= -1 -> Y == 31
1948 if (Pred == ICmpInst::ICMP_SLE)
1949 return new ICmpInst(ICmpInst::ICMP_EQ, Y, BitWidthMinusOne);
1950
1951 // (1 << Y) > -1 -> Y != 31
1952 if (Pred == ICmpInst::ICMP_SGT)
1953 return new ICmpInst(ICmpInst::ICMP_NE, Y, BitWidthMinusOne);
Craig Topper8ed1aa92017-10-03 05:31:07 +00001954 } else if (!C) {
Sanjay Patel98cd99d2016-08-18 21:28:30 +00001955 // (1 << Y) < 0 -> Y == 31
1956 // (1 << Y) <= 0 -> Y == 31
1957 if (Pred == ICmpInst::ICMP_SLT || Pred == ICmpInst::ICMP_SLE)
1958 return new ICmpInst(ICmpInst::ICMP_EQ, Y, BitWidthMinusOne);
1959
1960 // (1 << Y) >= 0 -> Y != 31
1961 // (1 << Y) > 0 -> Y != 31
1962 if (Pred == ICmpInst::ICMP_SGT || Pred == ICmpInst::ICMP_SGE)
1963 return new ICmpInst(ICmpInst::ICMP_NE, Y, BitWidthMinusOne);
1964 }
1965 } else if (Cmp.isEquality() && CIsPowerOf2) {
Craig Topper8ed1aa92017-10-03 05:31:07 +00001966 return new ICmpInst(Pred, Y, ConstantInt::get(ShiftType, C.logBase2()));
Sanjay Patel98cd99d2016-08-18 21:28:30 +00001967 }
1968
1969 return nullptr;
1970}
1971
Sanjay Patel38b75062016-08-19 17:20:37 +00001972/// Fold icmp (shl X, Y), C.
Sanjay Patelc9196c42016-08-22 21:24:29 +00001973Instruction *InstCombiner::foldICmpShlConstant(ICmpInst &Cmp,
1974 BinaryOperator *Shl,
Craig Topper8ed1aa92017-10-03 05:31:07 +00001975 const APInt &C) {
Sanjay Patel8da42cc2016-09-15 22:26:31 +00001976 const APInt *ShiftVal;
1977 if (Cmp.isEquality() && match(Shl->getOperand(0), m_APInt(ShiftVal)))
Craig Topper8ed1aa92017-10-03 05:31:07 +00001978 return foldICmpShlConstConst(Cmp, Shl->getOperand(1), C, *ShiftVal);
Sanjay Patel8da42cc2016-09-15 22:26:31 +00001979
Sanjay Patelfa7de602016-08-19 22:33:26 +00001980 const APInt *ShiftAmt;
1981 if (!match(Shl->getOperand(1), m_APInt(ShiftAmt)))
Sanjay Patel38b75062016-08-19 17:20:37 +00001982 return foldICmpShlOne(Cmp, Shl, C);
Sanjay Patela867afe2016-08-19 16:12:16 +00001983
Sanjay Patel38b75062016-08-19 17:20:37 +00001984 // Check that the shift amount is in range. If not, don't perform undefined
Sanjay Patel940c0612017-01-09 16:27:56 +00001985 // shifts. When the shift is visited, it will be simplified.
Craig Topper8ed1aa92017-10-03 05:31:07 +00001986 unsigned TypeBits = C.getBitWidth();
Sanjay Patelfa7de602016-08-19 22:33:26 +00001987 if (ShiftAmt->uge(TypeBits))
Sanjay Patela3f4f082016-08-16 17:54:36 +00001988 return nullptr;
1989
Sanjay Patele38e79c2016-08-19 17:34:05 +00001990 ICmpInst::Predicate Pred = Cmp.getPredicate();
1991 Value *X = Shl->getOperand(0);
Sanjay Patel14715b32017-01-17 21:25:16 +00001992 Type *ShType = Shl->getType();
1993
Sanjay Patel291c3d82017-01-19 16:12:10 +00001994 // NSW guarantees that we are only shifting out sign bits from the high bits,
1995 // so we can ASHR the compare constant without needing a mask and eliminate
1996 // the shift.
1997 if (Shl->hasNoSignedWrap()) {
1998 if (Pred == ICmpInst::ICMP_SGT) {
1999 // icmp Pred (shl nsw X, ShiftAmt), C --> icmp Pred X, (C >>s ShiftAmt)
Craig Topper8ed1aa92017-10-03 05:31:07 +00002000 APInt ShiftedC = C.ashr(*ShiftAmt);
Sanjay Patel291c3d82017-01-19 16:12:10 +00002001 return new ICmpInst(Pred, X, ConstantInt::get(ShType, ShiftedC));
2002 }
Sanjay Patel6fb13572018-01-09 18:56:03 +00002003 if ((Pred == ICmpInst::ICMP_EQ || Pred == ICmpInst::ICMP_NE) &&
2004 C.ashr(*ShiftAmt).shl(*ShiftAmt) == C) {
Craig Topper8ed1aa92017-10-03 05:31:07 +00002005 APInt ShiftedC = C.ashr(*ShiftAmt);
Sanjay Patel291c3d82017-01-19 16:12:10 +00002006 return new ICmpInst(Pred, X, ConstantInt::get(ShType, ShiftedC));
2007 }
2008 if (Pred == ICmpInst::ICMP_SLT) {
2009 // SLE is the same as above, but SLE is canonicalized to SLT, so convert:
2010 // (X << S) <=s C is equiv to X <=s (C >> S) for all C
2011 // (X << S) <s (C + 1) is equiv to X <s (C >> S) + 1 if C <s SMAX
2012 // (X << S) <s C is equiv to X <s ((C - 1) >> S) + 1 if C >s SMIN
Craig Topper8ed1aa92017-10-03 05:31:07 +00002013 assert(!C.isMinSignedValue() && "Unexpected icmp slt");
2014 APInt ShiftedC = (C - 1).ashr(*ShiftAmt) + 1;
Sanjay Patel291c3d82017-01-19 16:12:10 +00002015 return new ICmpInst(Pred, X, ConstantInt::get(ShType, ShiftedC));
2016 }
2017 // If this is a signed comparison to 0 and the shift is sign preserving,
2018 // use the shift LHS operand instead; isSignTest may change 'Pred', so only
2019 // do that if we're sure to not continue on in this function.
Craig Topper8ed1aa92017-10-03 05:31:07 +00002020 if (isSignTest(Pred, C))
Sanjay Patel291c3d82017-01-19 16:12:10 +00002021 return new ICmpInst(Pred, X, Constant::getNullValue(ShType));
2022 }
Sanjay Patel14715b32017-01-17 21:25:16 +00002023
Sanjay Patel291c3d82017-01-19 16:12:10 +00002024 // NUW guarantees that we are only shifting out zero bits from the high bits,
2025 // so we can LSHR the compare constant without needing a mask and eliminate
2026 // the shift.
Sanjay Patel14715b32017-01-17 21:25:16 +00002027 if (Shl->hasNoUnsignedWrap()) {
Sanjay Patelae23d652017-01-18 21:16:12 +00002028 if (Pred == ICmpInst::ICMP_UGT) {
Sanjay Patel14715b32017-01-17 21:25:16 +00002029 // icmp Pred (shl nuw X, ShiftAmt), C --> icmp Pred X, (C >>u ShiftAmt)
Craig Topper8ed1aa92017-10-03 05:31:07 +00002030 APInt ShiftedC = C.lshr(*ShiftAmt);
Sanjay Patel14715b32017-01-17 21:25:16 +00002031 return new ICmpInst(Pred, X, ConstantInt::get(ShType, ShiftedC));
2032 }
Sanjay Patel6fb13572018-01-09 18:56:03 +00002033 if ((Pred == ICmpInst::ICMP_EQ || Pred == ICmpInst::ICMP_NE) &&
2034 C.lshr(*ShiftAmt).shl(*ShiftAmt) == C) {
Craig Topper8ed1aa92017-10-03 05:31:07 +00002035 APInt ShiftedC = C.lshr(*ShiftAmt);
Sanjay Patelae23d652017-01-18 21:16:12 +00002036 return new ICmpInst(Pred, X, ConstantInt::get(ShType, ShiftedC));
2037 }
Sanjay Patel14715b32017-01-17 21:25:16 +00002038 if (Pred == ICmpInst::ICMP_ULT) {
2039 // ULE is the same as above, but ULE is canonicalized to ULT, so convert:
2040 // (X << S) <=u C is equiv to X <=u (C >> S) for all C
2041 // (X << S) <u (C + 1) is equiv to X <u (C >> S) + 1 if C <u ~0u
2042 // (X << S) <u C is equiv to X <u ((C - 1) >> S) + 1 if C >u 0
Craig Topper8ed1aa92017-10-03 05:31:07 +00002043 assert(C.ugt(0) && "ult 0 should have been eliminated");
2044 APInt ShiftedC = (C - 1).lshr(*ShiftAmt) + 1;
Sanjay Patel14715b32017-01-17 21:25:16 +00002045 return new ICmpInst(Pred, X, ConstantInt::get(ShType, ShiftedC));
2046 }
2047 }
2048
Sanjay Patel291c3d82017-01-19 16:12:10 +00002049 if (Cmp.isEquality() && Shl->hasOneUse()) {
2050 // Strength-reduce the shift into an 'and'.
2051 Constant *Mask = ConstantInt::get(
2052 ShType,
2053 APInt::getLowBitsSet(TypeBits, TypeBits - ShiftAmt->getZExtValue()));
Craig Topperbb4069e2017-07-07 23:16:26 +00002054 Value *And = Builder.CreateAnd(X, Mask, Shl->getName() + ".mask");
Craig Topper8ed1aa92017-10-03 05:31:07 +00002055 Constant *LShrC = ConstantInt::get(ShType, C.lshr(*ShiftAmt));
Sanjay Patel291c3d82017-01-19 16:12:10 +00002056 return new ICmpInst(Pred, And, LShrC);
Sanjay Patela3f4f082016-08-16 17:54:36 +00002057 }
2058
Sanjay Patela3f4f082016-08-16 17:54:36 +00002059 // Otherwise, if this is a comparison of the sign bit, simplify to and/test.
2060 bool TrueIfSigned = false;
Craig Topper8ed1aa92017-10-03 05:31:07 +00002061 if (Shl->hasOneUse() && isSignBitCheck(Pred, C, TrueIfSigned)) {
Sanjay Patel7ffcde72016-08-21 16:35:34 +00002062 // (X << 31) <s 0 --> (X & 1) != 0
Sanjay Patela3f4f082016-08-16 17:54:36 +00002063 Constant *Mask = ConstantInt::get(
Sanjay Patel14715b32017-01-17 21:25:16 +00002064 ShType,
Sanjay Patelfa7de602016-08-19 22:33:26 +00002065 APInt::getOneBitSet(TypeBits, TypeBits - ShiftAmt->getZExtValue() - 1));
Craig Topperbb4069e2017-07-07 23:16:26 +00002066 Value *And = Builder.CreateAnd(X, Mask, Shl->getName() + ".mask");
Sanjay Patela3f4f082016-08-16 17:54:36 +00002067 return new ICmpInst(TrueIfSigned ? ICmpInst::ICMP_NE : ICmpInst::ICMP_EQ,
Sanjay Patel14715b32017-01-17 21:25:16 +00002068 And, Constant::getNullValue(ShType));
Sanjay Patelc0339c72016-11-01 19:19:29 +00002069 }
2070
Huihui Zhangb90cb572019-06-25 20:44:52 +00002071 // Simplify 'shl' inequality test into 'and' equality test.
2072 if (Cmp.isUnsigned() && Shl->hasOneUse()) {
2073 // (X l<< C2) u<=/u> C1 iff C1+1 is power of two -> X & (~C1 l>> C2) ==/!= 0
2074 if ((C + 1).isPowerOf2() &&
2075 (Pred == ICmpInst::ICMP_ULE || Pred == ICmpInst::ICMP_UGT)) {
2076 Value *And = Builder.CreateAnd(X, (~C).lshr(ShiftAmt->getZExtValue()));
2077 return new ICmpInst(Pred == ICmpInst::ICMP_ULE ? ICmpInst::ICMP_EQ
2078 : ICmpInst::ICMP_NE,
2079 And, Constant::getNullValue(ShType));
2080 }
2081 // (X l<< C2) u</u>= C1 iff C1 is power of two -> X & (-C1 l>> C2) ==/!= 0
2082 if (C.isPowerOf2() &&
2083 (Pred == ICmpInst::ICMP_ULT || Pred == ICmpInst::ICMP_UGE)) {
2084 Value *And =
2085 Builder.CreateAnd(X, (~(C - 1)).lshr(ShiftAmt->getZExtValue()));
2086 return new ICmpInst(Pred == ICmpInst::ICMP_ULT ? ICmpInst::ICMP_EQ
2087 : ICmpInst::ICMP_NE,
2088 And, Constant::getNullValue(ShType));
2089 }
2090 }
2091
Sanjay Patel643d21a2016-08-21 17:10:07 +00002092 // Transform (icmp pred iM (shl iM %v, N), C)
2093 // -> (icmp pred i(M-N) (trunc %v iM to i(M-N)), (trunc (C>>N))
2094 // Transform the shl to a trunc if (trunc (C>>N)) has no loss and M-N.
Sanjay Patel940c0612017-01-09 16:27:56 +00002095 // This enables us to get rid of the shift in favor of a trunc that may be
Sanjay Patela3f4f082016-08-16 17:54:36 +00002096 // free on the target. It has the additional benefit of comparing to a
Sanjay Patel940c0612017-01-09 16:27:56 +00002097 // smaller constant that may be more target-friendly.
Sanjay Patelfa7de602016-08-19 22:33:26 +00002098 unsigned Amt = ShiftAmt->getLimitedValue(TypeBits - 1);
Craig Topper8ed1aa92017-10-03 05:31:07 +00002099 if (Shl->hasOneUse() && Amt != 0 && C.countTrailingZeros() >= Amt &&
Sanjay Patelf3dda132016-10-25 20:11:47 +00002100 DL.isLegalInteger(TypeBits - Amt)) {
Sanjay Patel643d21a2016-08-21 17:10:07 +00002101 Type *TruncTy = IntegerType::get(Cmp.getContext(), TypeBits - Amt);
Sanjay Patel14715b32017-01-17 21:25:16 +00002102 if (ShType->isVectorTy())
2103 TruncTy = VectorType::get(TruncTy, ShType->getVectorNumElements());
Sanjay Patel643d21a2016-08-21 17:10:07 +00002104 Constant *NewC =
Craig Topper8ed1aa92017-10-03 05:31:07 +00002105 ConstantInt::get(TruncTy, C.ashr(*ShiftAmt).trunc(TypeBits - Amt));
Craig Topperbb4069e2017-07-07 23:16:26 +00002106 return new ICmpInst(Pred, Builder.CreateTrunc(X, TruncTy), NewC);
Sanjay Patela3f4f082016-08-16 17:54:36 +00002107 }
2108
2109 return nullptr;
2110}
2111
Sanjay Patela3920492016-08-22 20:45:06 +00002112/// Fold icmp ({al}shr X, Y), C.
Sanjay Patelc9196c42016-08-22 21:24:29 +00002113Instruction *InstCombiner::foldICmpShrConstant(ICmpInst &Cmp,
2114 BinaryOperator *Shr,
Craig Topper8ed1aa92017-10-03 05:31:07 +00002115 const APInt &C) {
Sanjay Patela3920492016-08-22 20:45:06 +00002116 // An exact shr only shifts out zero bits, so:
2117 // icmp eq/ne (shr X, Y), 0 --> icmp eq/ne X, 0
Sanjay Pateld64e9882016-08-23 22:05:55 +00002118 Value *X = Shr->getOperand(0);
Sanjay Patelc9196c42016-08-22 21:24:29 +00002119 CmpInst::Predicate Pred = Cmp.getPredicate();
Craig Topper73ba1c82017-06-07 07:40:37 +00002120 if (Cmp.isEquality() && Shr->isExact() && Shr->hasOneUse() &&
Craig Topper8ed1aa92017-10-03 05:31:07 +00002121 C.isNullValue())
Sanjay Pateld64e9882016-08-23 22:05:55 +00002122 return new ICmpInst(Pred, X, Cmp.getOperand(1));
Sanjay Patela3920492016-08-22 20:45:06 +00002123
Sanjay Patel8da42cc2016-09-15 22:26:31 +00002124 const APInt *ShiftVal;
2125 if (Cmp.isEquality() && match(Shr->getOperand(0), m_APInt(ShiftVal)))
Craig Topper8ed1aa92017-10-03 05:31:07 +00002126 return foldICmpShrConstConst(Cmp, Shr->getOperand(1), C, *ShiftVal);
Sanjay Patel8da42cc2016-09-15 22:26:31 +00002127
Sanjay Pateld398d4a2016-08-24 22:22:06 +00002128 const APInt *ShiftAmt;
2129 if (!match(Shr->getOperand(1), m_APInt(ShiftAmt)))
Sanjay Patela3f4f082016-08-16 17:54:36 +00002130 return nullptr;
2131
Sanjay Pateld398d4a2016-08-24 22:22:06 +00002132 // Check that the shift amount is in range. If not, don't perform undefined
2133 // shifts. When the shift is visited it will be simplified.
Craig Topper8ed1aa92017-10-03 05:31:07 +00002134 unsigned TypeBits = C.getBitWidth();
Sanjay Pateld398d4a2016-08-24 22:22:06 +00002135 unsigned ShAmtVal = ShiftAmt->getLimitedValue(TypeBits);
Sanjay Pateldcac0df2016-08-23 21:25:13 +00002136 if (ShAmtVal >= TypeBits || ShAmtVal == 0)
2137 return nullptr;
2138
Sanjay Pateld64e9882016-08-23 22:05:55 +00002139 bool IsAShr = Shr->getOpcode() == Instruction::AShr;
Sanjay Patel7ac2db62017-10-05 21:11:49 +00002140 bool IsExact = Shr->isExact();
2141 Type *ShrTy = Shr->getType();
2142 // TODO: If we could guarantee that InstSimplify would handle all of the
2143 // constant-value-based preconditions in the folds below, then we could assert
2144 // those conditions rather than checking them. This is difficult because of
2145 // undef/poison (PR34838).
2146 if (IsAShr) {
2147 if (Pred == CmpInst::ICMP_SLT || (Pred == CmpInst::ICMP_SGT && IsExact)) {
2148 // icmp slt (ashr X, ShAmtC), C --> icmp slt X, (C << ShAmtC)
2149 // icmp sgt (ashr exact X, ShAmtC), C --> icmp sgt X, (C << ShAmtC)
2150 APInt ShiftedC = C.shl(ShAmtVal);
2151 if (ShiftedC.ashr(ShAmtVal) == C)
2152 return new ICmpInst(Pred, X, ConstantInt::get(ShrTy, ShiftedC));
2153 }
2154 if (Pred == CmpInst::ICMP_SGT) {
2155 // icmp sgt (ashr X, ShAmtC), C --> icmp sgt X, ((C + 1) << ShAmtC) - 1
2156 APInt ShiftedC = (C + 1).shl(ShAmtVal) - 1;
2157 if (!C.isMaxSignedValue() && !(C + 1).shl(ShAmtVal).isMinSignedValue() &&
2158 (ShiftedC + 1).ashr(ShAmtVal) == (C + 1))
2159 return new ICmpInst(Pred, X, ConstantInt::get(ShrTy, ShiftedC));
2160 }
2161 } else {
2162 if (Pred == CmpInst::ICMP_ULT || (Pred == CmpInst::ICMP_UGT && IsExact)) {
2163 // icmp ult (lshr X, ShAmtC), C --> icmp ult X, (C << ShAmtC)
2164 // icmp ugt (lshr exact X, ShAmtC), C --> icmp ugt X, (C << ShAmtC)
2165 APInt ShiftedC = C.shl(ShAmtVal);
2166 if (ShiftedC.lshr(ShAmtVal) == C)
2167 return new ICmpInst(Pred, X, ConstantInt::get(ShrTy, ShiftedC));
2168 }
2169 if (Pred == CmpInst::ICMP_UGT) {
2170 // icmp ugt (lshr X, ShAmtC), C --> icmp ugt X, ((C + 1) << ShAmtC) - 1
2171 APInt ShiftedC = (C + 1).shl(ShAmtVal) - 1;
2172 if ((ShiftedC + 1).lshr(ShAmtVal) == (C + 1))
2173 return new ICmpInst(Pred, X, ConstantInt::get(ShrTy, ShiftedC));
2174 }
Sanjay Pateldcac0df2016-08-23 21:25:13 +00002175 }
2176
Sanjay Patel7ac2db62017-10-05 21:11:49 +00002177 if (!Cmp.isEquality())
2178 return nullptr;
2179
Sanjay Pateld398d4a2016-08-24 22:22:06 +00002180 // Handle equality comparisons of shift-by-constant.
2181
Sanjay Patel8e297742016-08-24 13:55:55 +00002182 // If the comparison constant changes with the shift, the comparison cannot
2183 // succeed (bits of the comparison constant cannot match the shifted value).
2184 // This should be known by InstSimplify and already be folded to true/false.
Craig Topper8ed1aa92017-10-03 05:31:07 +00002185 assert(((IsAShr && C.shl(ShAmtVal).ashr(ShAmtVal) == C) ||
2186 (!IsAShr && C.shl(ShAmtVal).lshr(ShAmtVal) == C)) &&
Sanjay Patel8e297742016-08-24 13:55:55 +00002187 "Expected icmp+shr simplify did not occur.");
2188
Sanjay Patel934738a2017-10-15 15:39:15 +00002189 // If the bits shifted out are known zero, compare the unshifted value:
Sanjay Pateldcac0df2016-08-23 21:25:13 +00002190 // (X & 4) >> 1 == 2 --> (X & 4) == 4.
Sanjay Patel934738a2017-10-15 15:39:15 +00002191 if (Shr->isExact())
Sanjay Patel42135be2017-10-16 14:47:24 +00002192 return new ICmpInst(Pred, X, ConstantInt::get(ShrTy, C << ShAmtVal));
Sanjay Patelf11b5b42017-10-05 14:26:15 +00002193
Sanjay Patel934738a2017-10-15 15:39:15 +00002194 if (Shr->hasOneUse()) {
2195 // Canonicalize the shift into an 'and':
2196 // icmp eq/ne (shr X, ShAmt), C --> icmp eq/ne (and X, HiMask), (C << ShAmt)
Sanjay Pateld398d4a2016-08-24 22:22:06 +00002197 APInt Val(APInt::getHighBitsSet(TypeBits, TypeBits - ShAmtVal));
Sanjay Patel7ac2db62017-10-05 21:11:49 +00002198 Constant *Mask = ConstantInt::get(ShrTy, Val);
Craig Topperbb4069e2017-07-07 23:16:26 +00002199 Value *And = Builder.CreateAnd(X, Mask, Shr->getName() + ".mask");
Sanjay Patel42135be2017-10-16 14:47:24 +00002200 return new ICmpInst(Pred, And, ConstantInt::get(ShrTy, C << ShAmtVal));
Sanjay Pateldcac0df2016-08-23 21:25:13 +00002201 }
Sanjay Patela3f4f082016-08-16 17:54:36 +00002202
2203 return nullptr;
2204}
2205
Sanjay Patel12a41052016-08-18 17:37:26 +00002206/// Fold icmp (udiv X, Y), C.
2207Instruction *InstCombiner::foldICmpUDivConstant(ICmpInst &Cmp,
Sanjay Patelc9196c42016-08-22 21:24:29 +00002208 BinaryOperator *UDiv,
Craig Topper8ed1aa92017-10-03 05:31:07 +00002209 const APInt &C) {
Sanjay Patelfa5ca2b2016-08-18 17:55:59 +00002210 const APInt *C2;
2211 if (!match(UDiv->getOperand(0), m_APInt(C2)))
2212 return nullptr;
2213
Craig Topper29c282e2017-06-07 07:40:29 +00002214 assert(*C2 != 0 && "udiv 0, X should have been simplified already.");
Sanjay Patelfa5ca2b2016-08-18 17:55:59 +00002215
2216 // (icmp ugt (udiv C2, Y), C) -> (icmp ule Y, C2/(C+1))
2217 Value *Y = UDiv->getOperand(1);
2218 if (Cmp.getPredicate() == ICmpInst::ICMP_UGT) {
Craig Topper8ed1aa92017-10-03 05:31:07 +00002219 assert(!C.isMaxValue() &&
Sanjay Patelfa5ca2b2016-08-18 17:55:59 +00002220 "icmp ugt X, UINT_MAX should have been simplified already.");
2221 return new ICmpInst(ICmpInst::ICMP_ULE, Y,
Craig Topper8ed1aa92017-10-03 05:31:07 +00002222 ConstantInt::get(Y->getType(), C2->udiv(C + 1)));
Sanjay Patelfa5ca2b2016-08-18 17:55:59 +00002223 }
2224
2225 // (icmp ult (udiv C2, Y), C) -> (icmp ugt Y, C2/C)
2226 if (Cmp.getPredicate() == ICmpInst::ICMP_ULT) {
Craig Topper8ed1aa92017-10-03 05:31:07 +00002227 assert(C != 0 && "icmp ult X, 0 should have been simplified already.");
Sanjay Patelfa5ca2b2016-08-18 17:55:59 +00002228 return new ICmpInst(ICmpInst::ICMP_UGT, Y,
Craig Topper8ed1aa92017-10-03 05:31:07 +00002229 ConstantInt::get(Y->getType(), C2->udiv(C)));
Sanjay Patela3f4f082016-08-16 17:54:36 +00002230 }
2231
2232 return nullptr;
2233}
2234
Sanjay Patelf7ba0892016-08-26 15:53:01 +00002235/// Fold icmp ({su}div X, Y), C.
2236Instruction *InstCombiner::foldICmpDivConstant(ICmpInst &Cmp,
2237 BinaryOperator *Div,
Craig Topper8ed1aa92017-10-03 05:31:07 +00002238 const APInt &C) {
Sanjay Patela7cb4772016-08-30 17:10:49 +00002239 // Fold: icmp pred ([us]div X, C2), C -> range test
Sanjay Patela3f4f082016-08-16 17:54:36 +00002240 // Fold this div into the comparison, producing a range check.
2241 // Determine, based on the divide type, what the range is being
2242 // checked. If there is an overflow on the low or high side, remember
2243 // it, otherwise compute the range [low, hi) bounding the new value.
2244 // See: InsertRangeTest above for the kinds of replacements possible.
Sanjay Patela7cb4772016-08-30 17:10:49 +00002245 const APInt *C2;
2246 if (!match(Div->getOperand(1), m_APInt(C2)))
Sanjay Patel16554142016-08-24 23:03:36 +00002247 return nullptr;
2248
Sanjay Patel16554142016-08-24 23:03:36 +00002249 // FIXME: If the operand types don't match the type of the divide
2250 // then don't attempt this transform. The code below doesn't have the
2251 // logic to deal with a signed divide and an unsigned compare (and
Sanjay Patela7cb4772016-08-30 17:10:49 +00002252 // vice versa). This is because (x /s C2) <s C produces different
2253 // results than (x /s C2) <u C or (x /u C2) <s C or even
2254 // (x /u C2) <u C. Simply casting the operands and result won't
Sanjay Patel16554142016-08-24 23:03:36 +00002255 // work. :( The if statement below tests that condition and bails
2256 // if it finds it.
Sanjay Patelf7ba0892016-08-26 15:53:01 +00002257 bool DivIsSigned = Div->getOpcode() == Instruction::SDiv;
2258 if (!Cmp.isEquality() && DivIsSigned != Cmp.isSigned())
Sanjay Patel16554142016-08-24 23:03:36 +00002259 return nullptr;
Sanjay Patela7cb4772016-08-30 17:10:49 +00002260
Sanjay Pateleea2ef72016-09-05 23:38:22 +00002261 // The ProdOV computation fails on divide by 0 and divide by -1. Cases with
2262 // INT_MIN will also fail if the divisor is 1. Although folds of all these
2263 // division-by-constant cases should be present, we can not assert that they
2264 // have happened before we reach this icmp instruction.
Craig Topper73ba1c82017-06-07 07:40:37 +00002265 if (C2->isNullValue() || C2->isOneValue() ||
2266 (DivIsSigned && C2->isAllOnesValue()))
Sanjay Pateleea2ef72016-09-05 23:38:22 +00002267 return nullptr;
Sanjay Patelb3714572016-08-30 17:31:34 +00002268
Craig Topper6e025a32017-10-01 23:53:54 +00002269 // Compute Prod = C * C2. We are essentially solving an equation of
2270 // form X / C2 = C. We solve for X by multiplying C2 and C.
Sanjay Patel541aef42016-08-31 21:57:21 +00002271 // By solving for X, we can turn this into a range check instead of computing
2272 // a divide.
Craig Topper8ed1aa92017-10-03 05:31:07 +00002273 APInt Prod = C * *C2;
Sanjay Patel16554142016-08-24 23:03:36 +00002274
Sanjay Patel541aef42016-08-31 21:57:21 +00002275 // Determine if the product overflows by seeing if the product is not equal to
2276 // the divide. Make sure we do the same kind of divide as in the LHS
2277 // instruction that we're folding.
Craig Topper8ed1aa92017-10-03 05:31:07 +00002278 bool ProdOV = (DivIsSigned ? Prod.sdiv(*C2) : Prod.udiv(*C2)) != C;
Sanjay Patel16554142016-08-24 23:03:36 +00002279
Sanjay Patelf7ba0892016-08-26 15:53:01 +00002280 ICmpInst::Predicate Pred = Cmp.getPredicate();
Sanjay Patel16554142016-08-24 23:03:36 +00002281
2282 // If the division is known to be exact, then there is no remainder from the
2283 // divide, so the covered range size is unit, otherwise it is the divisor.
Craig Topper6e025a32017-10-01 23:53:54 +00002284 APInt RangeSize = Div->isExact() ? APInt(C2->getBitWidth(), 1) : *C2;
Sanjay Patel16554142016-08-24 23:03:36 +00002285
2286 // Figure out the interval that is being checked. For example, a comparison
2287 // like "X /u 5 == 0" is really checking that X is in the interval [0, 5).
2288 // Compute this interval based on the constants involved and the signedness of
2289 // the compare/divide. This computes a half-open interval, keeping track of
2290 // whether either value in the interval overflows. After analysis each
2291 // overflow variable is set to 0 if it's corresponding bound variable is valid
2292 // -1 if overflowed off the bottom end, or +1 if overflowed off the top end.
2293 int LoOverflow = 0, HiOverflow = 0;
Craig Topper6e025a32017-10-01 23:53:54 +00002294 APInt LoBound, HiBound;
Sanjay Patel16554142016-08-24 23:03:36 +00002295
2296 if (!DivIsSigned) { // udiv
2297 // e.g. X/5 op 3 --> [15, 20)
2298 LoBound = Prod;
2299 HiOverflow = LoOverflow = ProdOV;
2300 if (!HiOverflow) {
2301 // If this is not an exact divide, then many values in the range collapse
2302 // to the same result value.
Sanjay Pateld93c4c02016-09-15 18:22:25 +00002303 HiOverflow = addWithOverflow(HiBound, LoBound, RangeSize, false);
Sanjay Patel16554142016-08-24 23:03:36 +00002304 }
Sanjay Patel541aef42016-08-31 21:57:21 +00002305 } else if (C2->isStrictlyPositive()) { // Divisor is > 0.
Craig Topper8ed1aa92017-10-03 05:31:07 +00002306 if (C.isNullValue()) { // (X / pos) op 0
Sanjay Patel16554142016-08-24 23:03:36 +00002307 // Can't overflow. e.g. X/2 op 0 --> [-1, 2)
Craig Topper6e025a32017-10-01 23:53:54 +00002308 LoBound = -(RangeSize - 1);
Sanjay Patel16554142016-08-24 23:03:36 +00002309 HiBound = RangeSize;
Craig Topper8ed1aa92017-10-03 05:31:07 +00002310 } else if (C.isStrictlyPositive()) { // (X / pos) op pos
Sanjay Patel16554142016-08-24 23:03:36 +00002311 LoBound = Prod; // e.g. X/5 op 3 --> [15, 20)
2312 HiOverflow = LoOverflow = ProdOV;
2313 if (!HiOverflow)
Sanjay Pateld93c4c02016-09-15 18:22:25 +00002314 HiOverflow = addWithOverflow(HiBound, Prod, RangeSize, true);
Sanjay Patel16554142016-08-24 23:03:36 +00002315 } else { // (X / pos) op neg
2316 // e.g. X/5 op -3 --> [-15-4, -15+1) --> [-19, -14)
Craig Topper6e025a32017-10-01 23:53:54 +00002317 HiBound = Prod + 1;
Sanjay Patel16554142016-08-24 23:03:36 +00002318 LoOverflow = HiOverflow = ProdOV ? -1 : 0;
2319 if (!LoOverflow) {
Craig Topper6e025a32017-10-01 23:53:54 +00002320 APInt DivNeg = -RangeSize;
Sanjay Pateld93c4c02016-09-15 18:22:25 +00002321 LoOverflow = addWithOverflow(LoBound, HiBound, DivNeg, true) ? -1 : 0;
Sanjay Patel16554142016-08-24 23:03:36 +00002322 }
2323 }
Sanjay Patel541aef42016-08-31 21:57:21 +00002324 } else if (C2->isNegative()) { // Divisor is < 0.
Sanjay Patelf7ba0892016-08-26 15:53:01 +00002325 if (Div->isExact())
Craig Topper6e025a32017-10-01 23:53:54 +00002326 RangeSize.negate();
Craig Topper8ed1aa92017-10-03 05:31:07 +00002327 if (C.isNullValue()) { // (X / neg) op 0
Sanjay Patel16554142016-08-24 23:03:36 +00002328 // e.g. X/-5 op 0 --> [-4, 5)
Craig Topper6e025a32017-10-01 23:53:54 +00002329 LoBound = RangeSize + 1;
2330 HiBound = -RangeSize;
2331 if (HiBound == *C2) { // -INTMIN = INTMIN
Sanjay Patel16554142016-08-24 23:03:36 +00002332 HiOverflow = 1; // [INTMIN+1, overflow)
Craig Topper6e025a32017-10-01 23:53:54 +00002333 HiBound = APInt(); // e.g. X/INTMIN = 0 --> X > INTMIN
Sanjay Patel16554142016-08-24 23:03:36 +00002334 }
Craig Topper8ed1aa92017-10-03 05:31:07 +00002335 } else if (C.isStrictlyPositive()) { // (X / neg) op pos
Sanjay Patel16554142016-08-24 23:03:36 +00002336 // e.g. X/-5 op 3 --> [-19, -14)
Craig Topper6e025a32017-10-01 23:53:54 +00002337 HiBound = Prod + 1;
Sanjay Patel16554142016-08-24 23:03:36 +00002338 HiOverflow = LoOverflow = ProdOV ? -1 : 0;
2339 if (!LoOverflow)
Sanjay Pateld93c4c02016-09-15 18:22:25 +00002340 LoOverflow = addWithOverflow(LoBound, HiBound, RangeSize, true) ? -1:0;
Sanjay Patel16554142016-08-24 23:03:36 +00002341 } else { // (X / neg) op neg
2342 LoBound = Prod; // e.g. X/-5 op -3 --> [15, 20)
2343 LoOverflow = HiOverflow = ProdOV;
2344 if (!HiOverflow)
Sanjay Pateld93c4c02016-09-15 18:22:25 +00002345 HiOverflow = subWithOverflow(HiBound, Prod, RangeSize, true);
Sanjay Patel16554142016-08-24 23:03:36 +00002346 }
2347
2348 // Dividing by a negative swaps the condition. LT <-> GT
2349 Pred = ICmpInst::getSwappedPredicate(Pred);
2350 }
2351
Sanjay Patelf7ba0892016-08-26 15:53:01 +00002352 Value *X = Div->getOperand(0);
Sanjay Patel16554142016-08-24 23:03:36 +00002353 switch (Pred) {
2354 default: llvm_unreachable("Unhandled icmp opcode!");
2355 case ICmpInst::ICMP_EQ:
2356 if (LoOverflow && HiOverflow)
Craig Topperbb4069e2017-07-07 23:16:26 +00002357 return replaceInstUsesWith(Cmp, Builder.getFalse());
Sanjay Patel16554142016-08-24 23:03:36 +00002358 if (HiOverflow)
2359 return new ICmpInst(DivIsSigned ? ICmpInst::ICMP_SGE :
Craig Topper6e025a32017-10-01 23:53:54 +00002360 ICmpInst::ICMP_UGE, X,
2361 ConstantInt::get(Div->getType(), LoBound));
Sanjay Patel16554142016-08-24 23:03:36 +00002362 if (LoOverflow)
2363 return new ICmpInst(DivIsSigned ? ICmpInst::ICMP_SLT :
Craig Topper6e025a32017-10-01 23:53:54 +00002364 ICmpInst::ICMP_ULT, X,
2365 ConstantInt::get(Div->getType(), HiBound));
Sanjay Patel85d79742016-08-31 19:49:56 +00002366 return replaceInstUsesWith(
Craig Topper6e025a32017-10-01 23:53:54 +00002367 Cmp, insertRangeTest(X, LoBound, HiBound, DivIsSigned, true));
Sanjay Patel16554142016-08-24 23:03:36 +00002368 case ICmpInst::ICMP_NE:
2369 if (LoOverflow && HiOverflow)
Craig Topperbb4069e2017-07-07 23:16:26 +00002370 return replaceInstUsesWith(Cmp, Builder.getTrue());
Sanjay Patel16554142016-08-24 23:03:36 +00002371 if (HiOverflow)
2372 return new ICmpInst(DivIsSigned ? ICmpInst::ICMP_SLT :
Craig Topper6e025a32017-10-01 23:53:54 +00002373 ICmpInst::ICMP_ULT, X,
2374 ConstantInt::get(Div->getType(), LoBound));
Sanjay Patel16554142016-08-24 23:03:36 +00002375 if (LoOverflow)
2376 return new ICmpInst(DivIsSigned ? ICmpInst::ICMP_SGE :
Craig Topper6e025a32017-10-01 23:53:54 +00002377 ICmpInst::ICMP_UGE, X,
2378 ConstantInt::get(Div->getType(), HiBound));
Sanjay Patel541aef42016-08-31 21:57:21 +00002379 return replaceInstUsesWith(Cmp,
Craig Topper6e025a32017-10-01 23:53:54 +00002380 insertRangeTest(X, LoBound, HiBound,
Sanjay Patel541aef42016-08-31 21:57:21 +00002381 DivIsSigned, false));
Sanjay Patel16554142016-08-24 23:03:36 +00002382 case ICmpInst::ICMP_ULT:
2383 case ICmpInst::ICMP_SLT:
2384 if (LoOverflow == +1) // Low bound is greater than input range.
Craig Topperbb4069e2017-07-07 23:16:26 +00002385 return replaceInstUsesWith(Cmp, Builder.getTrue());
Sanjay Patel16554142016-08-24 23:03:36 +00002386 if (LoOverflow == -1) // Low bound is less than input range.
Craig Topperbb4069e2017-07-07 23:16:26 +00002387 return replaceInstUsesWith(Cmp, Builder.getFalse());
Craig Topper6e025a32017-10-01 23:53:54 +00002388 return new ICmpInst(Pred, X, ConstantInt::get(Div->getType(), LoBound));
Sanjay Patel16554142016-08-24 23:03:36 +00002389 case ICmpInst::ICMP_UGT:
2390 case ICmpInst::ICMP_SGT:
2391 if (HiOverflow == +1) // High bound greater than input range.
Craig Topperbb4069e2017-07-07 23:16:26 +00002392 return replaceInstUsesWith(Cmp, Builder.getFalse());
Sanjay Patel16554142016-08-24 23:03:36 +00002393 if (HiOverflow == -1) // High bound less than input range.
Craig Topperbb4069e2017-07-07 23:16:26 +00002394 return replaceInstUsesWith(Cmp, Builder.getTrue());
Sanjay Patel16554142016-08-24 23:03:36 +00002395 if (Pred == ICmpInst::ICMP_UGT)
Craig Topper6e025a32017-10-01 23:53:54 +00002396 return new ICmpInst(ICmpInst::ICMP_UGE, X,
2397 ConstantInt::get(Div->getType(), HiBound));
2398 return new ICmpInst(ICmpInst::ICMP_SGE, X,
2399 ConstantInt::get(Div->getType(), HiBound));
Sanjay Patel16554142016-08-24 23:03:36 +00002400 }
Sanjay Patela3f4f082016-08-16 17:54:36 +00002401
2402 return nullptr;
2403}
2404
Sanjay Patelb9aa67b2016-08-16 21:26:10 +00002405/// Fold icmp (sub X, Y), C.
Sanjay Patelc9196c42016-08-22 21:24:29 +00002406Instruction *InstCombiner::foldICmpSubConstant(ICmpInst &Cmp,
2407 BinaryOperator *Sub,
Craig Topper8ed1aa92017-10-03 05:31:07 +00002408 const APInt &C) {
Sanjay Patel886a5422016-09-15 18:05:17 +00002409 Value *X = Sub->getOperand(0), *Y = Sub->getOperand(1);
2410 ICmpInst::Predicate Pred = Cmp.getPredicate();
Luqman Aden8911c5b2019-04-04 07:08:30 +00002411 const APInt *C2;
2412 APInt SubResult;
2413
2414 // (icmp P (sub nuw|nsw C2, Y), C) -> (icmp swap(P) Y, C2-C)
2415 if (match(X, m_APInt(C2)) &&
2416 ((Cmp.isUnsigned() && Sub->hasNoUnsignedWrap()) ||
2417 (Cmp.isSigned() && Sub->hasNoSignedWrap())) &&
2418 !subWithOverflow(SubResult, *C2, C, Cmp.isSigned()))
2419 return new ICmpInst(Cmp.getSwappedPredicate(), Y,
2420 ConstantInt::get(Y->getType(), SubResult));
Sanjay Patel886a5422016-09-15 18:05:17 +00002421
2422 // The following transforms are only worth it if the only user of the subtract
2423 // is the icmp.
2424 if (!Sub->hasOneUse())
Sanjay Patela3f4f082016-08-16 17:54:36 +00002425 return nullptr;
2426
Sanjay Patel886a5422016-09-15 18:05:17 +00002427 if (Sub->hasNoSignedWrap()) {
2428 // (icmp sgt (sub nsw X, Y), -1) -> (icmp sge X, Y)
Craig Topper8ed1aa92017-10-03 05:31:07 +00002429 if (Pred == ICmpInst::ICMP_SGT && C.isAllOnesValue())
Sanjay Patel886a5422016-09-15 18:05:17 +00002430 return new ICmpInst(ICmpInst::ICMP_SGE, X, Y);
Sanjay Patela3f4f082016-08-16 17:54:36 +00002431
Sanjay Patel886a5422016-09-15 18:05:17 +00002432 // (icmp sgt (sub nsw X, Y), 0) -> (icmp sgt X, Y)
Craig Topper8ed1aa92017-10-03 05:31:07 +00002433 if (Pred == ICmpInst::ICMP_SGT && C.isNullValue())
Sanjay Patel886a5422016-09-15 18:05:17 +00002434 return new ICmpInst(ICmpInst::ICMP_SGT, X, Y);
2435
2436 // (icmp slt (sub nsw X, Y), 0) -> (icmp slt X, Y)
Craig Topper8ed1aa92017-10-03 05:31:07 +00002437 if (Pred == ICmpInst::ICMP_SLT && C.isNullValue())
Sanjay Patel886a5422016-09-15 18:05:17 +00002438 return new ICmpInst(ICmpInst::ICMP_SLT, X, Y);
2439
2440 // (icmp slt (sub nsw X, Y), 1) -> (icmp sle X, Y)
Craig Topper8ed1aa92017-10-03 05:31:07 +00002441 if (Pred == ICmpInst::ICMP_SLT && C.isOneValue())
Sanjay Patel886a5422016-09-15 18:05:17 +00002442 return new ICmpInst(ICmpInst::ICMP_SLE, X, Y);
2443 }
2444
Sanjay Patel886a5422016-09-15 18:05:17 +00002445 if (!match(X, m_APInt(C2)))
2446 return nullptr;
2447
2448 // C2 - Y <u C -> (Y | (C - 1)) == C2
2449 // iff (C2 & (C - 1)) == C - 1 and C is a power of 2
Craig Topper8ed1aa92017-10-03 05:31:07 +00002450 if (Pred == ICmpInst::ICMP_ULT && C.isPowerOf2() &&
2451 (*C2 & (C - 1)) == (C - 1))
2452 return new ICmpInst(ICmpInst::ICMP_EQ, Builder.CreateOr(Y, C - 1), X);
Sanjay Patel886a5422016-09-15 18:05:17 +00002453
2454 // C2 - Y >u C -> (Y | C) != C2
2455 // iff C2 & C == C and C + 1 is a power of 2
Craig Topper8ed1aa92017-10-03 05:31:07 +00002456 if (Pred == ICmpInst::ICMP_UGT && (C + 1).isPowerOf2() && (*C2 & C) == C)
2457 return new ICmpInst(ICmpInst::ICMP_NE, Builder.CreateOr(Y, C), X);
Sanjay Patela3f4f082016-08-16 17:54:36 +00002458
2459 return nullptr;
2460}
2461
Sanjay Patel60ea1b42016-08-16 22:34:42 +00002462/// Fold icmp (add X, Y), C.
Sanjay Patelc9196c42016-08-22 21:24:29 +00002463Instruction *InstCombiner::foldICmpAddConstant(ICmpInst &Cmp,
2464 BinaryOperator *Add,
Craig Topper8ed1aa92017-10-03 05:31:07 +00002465 const APInt &C) {
Sanjay Patel4f7eb2a2016-08-17 15:24:30 +00002466 Value *Y = Add->getOperand(1);
2467 const APInt *C2;
2468 if (Cmp.isEquality() || !match(Y, m_APInt(C2)))
Sanjay Patela3f4f082016-08-16 17:54:36 +00002469 return nullptr;
2470
Sanjay Patel4f7eb2a2016-08-17 15:24:30 +00002471 // Fold icmp pred (add X, C2), C.
Sanjay Patel60ea1b42016-08-16 22:34:42 +00002472 Value *X = Add->getOperand(0);
Sanjay Patel4f7eb2a2016-08-17 15:24:30 +00002473 Type *Ty = Add->getType();
Sanjay Patel6dd2eae2017-02-08 16:19:36 +00002474 CmpInst::Predicate Pred = Cmp.getPredicate();
Sanjay Patel45b7e692017-02-12 16:40:30 +00002475
Tim Northover12c1f762018-09-10 14:26:44 +00002476 if (!Add->hasOneUse())
2477 return nullptr;
2478
Sanjay Patel45b7e692017-02-12 16:40:30 +00002479 // If the add does not wrap, we can always adjust the compare by subtracting
Nicola Zaghen9588ad92018-09-04 10:29:48 +00002480 // the constants. Equality comparisons are handled elsewhere. SGE/SLE/UGE/ULE
2481 // are canonicalized to SGT/SLT/UGT/ULT.
2482 if ((Add->hasNoSignedWrap() &&
2483 (Pred == ICmpInst::ICMP_SGT || Pred == ICmpInst::ICMP_SLT)) ||
2484 (Add->hasNoUnsignedWrap() &&
2485 (Pred == ICmpInst::ICMP_UGT || Pred == ICmpInst::ICMP_ULT))) {
Sanjay Patel45b7e692017-02-12 16:40:30 +00002486 bool Overflow;
Nicola Zaghen9588ad92018-09-04 10:29:48 +00002487 APInt NewC =
2488 Cmp.isSigned() ? C.ssub_ov(*C2, Overflow) : C.usub_ov(*C2, Overflow);
Sanjay Patel45b7e692017-02-12 16:40:30 +00002489 // If there is overflow, the result must be true or false.
2490 // TODO: Can we assert there is no overflow because InstSimplify always
2491 // handles those cases?
2492 if (!Overflow)
2493 // icmp Pred (add nsw X, C2), C --> icmp Pred X, (C - C2)
2494 return new ICmpInst(Pred, X, ConstantInt::get(Ty, NewC));
2495 }
2496
Craig Topper8ed1aa92017-10-03 05:31:07 +00002497 auto CR = ConstantRange::makeExactICmpRegion(Pred, C).subtract(*C2);
Sanjay Patel60ea1b42016-08-16 22:34:42 +00002498 const APInt &Upper = CR.getUpper();
2499 const APInt &Lower = CR.getLower();
2500 if (Cmp.isSigned()) {
Craig Topperbcfd2d12017-04-20 16:56:25 +00002501 if (Lower.isSignMask())
Sanjay Patel4f7eb2a2016-08-17 15:24:30 +00002502 return new ICmpInst(ICmpInst::ICMP_SLT, X, ConstantInt::get(Ty, Upper));
Craig Topperbcfd2d12017-04-20 16:56:25 +00002503 if (Upper.isSignMask())
Sanjay Patel4f7eb2a2016-08-17 15:24:30 +00002504 return new ICmpInst(ICmpInst::ICMP_SGE, X, ConstantInt::get(Ty, Lower));
Sanjay Patel60ea1b42016-08-16 22:34:42 +00002505 } else {
2506 if (Lower.isMinValue())
Sanjay Patel4f7eb2a2016-08-17 15:24:30 +00002507 return new ICmpInst(ICmpInst::ICMP_ULT, X, ConstantInt::get(Ty, Upper));
Sanjay Patel60ea1b42016-08-16 22:34:42 +00002508 if (Upper.isMinValue())
Sanjay Patel4f7eb2a2016-08-17 15:24:30 +00002509 return new ICmpInst(ICmpInst::ICMP_UGE, X, ConstantInt::get(Ty, Lower));
Sanjay Patel60ea1b42016-08-16 22:34:42 +00002510 }
Sanjay Patela3f4f082016-08-16 17:54:36 +00002511
Sanjay Patel4f7eb2a2016-08-17 15:24:30 +00002512 // X+C <u C2 -> (X & -C2) == C
2513 // iff C & (C2-1) == 0
2514 // C2 is a power of 2
Craig Topper8ed1aa92017-10-03 05:31:07 +00002515 if (Pred == ICmpInst::ICMP_ULT && C.isPowerOf2() && (*C2 & (C - 1)) == 0)
2516 return new ICmpInst(ICmpInst::ICMP_EQ, Builder.CreateAnd(X, -C),
Sanjay Patel4f7eb2a2016-08-17 15:24:30 +00002517 ConstantExpr::getNeg(cast<Constant>(Y)));
2518
2519 // X+C >u C2 -> (X & ~C2) != C
2520 // iff C & C2 == 0
2521 // C2+1 is a power of 2
Craig Topper8ed1aa92017-10-03 05:31:07 +00002522 if (Pred == ICmpInst::ICMP_UGT && (C + 1).isPowerOf2() && (*C2 & C) == 0)
2523 return new ICmpInst(ICmpInst::ICMP_NE, Builder.CreateAnd(X, ~C),
Sanjay Patel4f7eb2a2016-08-17 15:24:30 +00002524 ConstantExpr::getNeg(cast<Constant>(Y)));
2525
Sanjay Patela3f4f082016-08-16 17:54:36 +00002526 return nullptr;
2527}
2528
Anna Thomasd67165c2017-06-23 13:41:45 +00002529bool InstCombiner::matchThreeWayIntCompare(SelectInst *SI, Value *&LHS,
2530 Value *&RHS, ConstantInt *&Less,
2531 ConstantInt *&Equal,
2532 ConstantInt *&Greater) {
2533 // TODO: Generalize this to work with other comparison idioms or ensure
2534 // they get canonicalized into this form.
2535
2536 // select i1 (a == b), i32 Equal, i32 (select i1 (a < b), i32 Less, i32
2537 // Greater), where Equal, Less and Greater are placeholders for any three
2538 // constants.
2539 ICmpInst::Predicate PredA, PredB;
2540 if (match(SI->getTrueValue(), m_ConstantInt(Equal)) &&
2541 match(SI->getCondition(), m_ICmp(PredA, m_Value(LHS), m_Value(RHS))) &&
2542 PredA == ICmpInst::ICMP_EQ &&
2543 match(SI->getFalseValue(),
2544 m_Select(m_ICmp(PredB, m_Specific(LHS), m_Specific(RHS)),
2545 m_ConstantInt(Less), m_ConstantInt(Greater))) &&
2546 PredB == ICmpInst::ICMP_SLT) {
2547 return true;
2548 }
2549 return false;
2550}
2551
2552Instruction *InstCombiner::foldICmpSelectConstant(ICmpInst &Cmp,
Craig Topper524c44f2017-08-23 05:46:07 +00002553 SelectInst *Select,
Anna Thomasd67165c2017-06-23 13:41:45 +00002554 ConstantInt *C) {
2555
2556 assert(C && "Cmp RHS should be a constant int!");
2557 // If we're testing a constant value against the result of a three way
2558 // comparison, the result can be expressed directly in terms of the
2559 // original values being compared. Note: We could possibly be more
2560 // aggressive here and remove the hasOneUse test. The original select is
2561 // really likely to simplify or sink when we remove a test of the result.
2562 Value *OrigLHS, *OrigRHS;
2563 ConstantInt *C1LessThan, *C2Equal, *C3GreaterThan;
2564 if (Cmp.hasOneUse() &&
Craig Topper524c44f2017-08-23 05:46:07 +00002565 matchThreeWayIntCompare(Select, OrigLHS, OrigRHS, C1LessThan, C2Equal,
2566 C3GreaterThan)) {
Anna Thomasd67165c2017-06-23 13:41:45 +00002567 assert(C1LessThan && C2Equal && C3GreaterThan);
2568
2569 bool TrueWhenLessThan =
2570 ConstantExpr::getCompare(Cmp.getPredicate(), C1LessThan, C)
2571 ->isAllOnesValue();
2572 bool TrueWhenEqual =
2573 ConstantExpr::getCompare(Cmp.getPredicate(), C2Equal, C)
2574 ->isAllOnesValue();
2575 bool TrueWhenGreaterThan =
2576 ConstantExpr::getCompare(Cmp.getPredicate(), C3GreaterThan, C)
2577 ->isAllOnesValue();
2578
2579 // This generates the new instruction that will replace the original Cmp
2580 // Instruction. Instead of enumerating the various combinations when
2581 // TrueWhenLessThan, TrueWhenEqual and TrueWhenGreaterThan are true versus
2582 // false, we rely on chaining of ORs and future passes of InstCombine to
2583 // simplify the OR further (i.e. a s< b || a == b becomes a s<= b).
2584
2585 // When none of the three constants satisfy the predicate for the RHS (C),
2586 // the entire original Cmp can be simplified to a false.
Craig Topperbb4069e2017-07-07 23:16:26 +00002587 Value *Cond = Builder.getFalse();
Anna Thomasd67165c2017-06-23 13:41:45 +00002588 if (TrueWhenLessThan)
Sanjay Patele7f46c32019-02-07 20:54:09 +00002589 Cond = Builder.CreateOr(Cond, Builder.CreateICmp(ICmpInst::ICMP_SLT,
2590 OrigLHS, OrigRHS));
Anna Thomasd67165c2017-06-23 13:41:45 +00002591 if (TrueWhenEqual)
Sanjay Patele7f46c32019-02-07 20:54:09 +00002592 Cond = Builder.CreateOr(Cond, Builder.CreateICmp(ICmpInst::ICMP_EQ,
2593 OrigLHS, OrigRHS));
Anna Thomasd67165c2017-06-23 13:41:45 +00002594 if (TrueWhenGreaterThan)
Sanjay Patele7f46c32019-02-07 20:54:09 +00002595 Cond = Builder.CreateOr(Cond, Builder.CreateICmp(ICmpInst::ICMP_SGT,
2596 OrigLHS, OrigRHS));
Anna Thomasd67165c2017-06-23 13:41:45 +00002597
2598 return replaceInstUsesWith(Cmp, Cond);
2599 }
2600 return nullptr;
2601}
2602
Sanjay Patele7f46c32019-02-07 20:54:09 +00002603static Instruction *foldICmpBitCast(ICmpInst &Cmp,
2604 InstCombiner::BuilderTy &Builder) {
2605 auto *Bitcast = dyn_cast<BitCastInst>(Cmp.getOperand(0));
2606 if (!Bitcast)
2607 return nullptr;
2608
Sanjay Patele7f46c32019-02-07 20:54:09 +00002609 ICmpInst::Predicate Pred = Cmp.getPredicate();
2610 Value *Op1 = Cmp.getOperand(1);
2611 Value *BCSrcOp = Bitcast->getOperand(0);
Sanjay Patele7f46c32019-02-07 20:54:09 +00002612
Sanjay Patel781d8832019-02-07 21:12:01 +00002613 // Make sure the bitcast doesn't change the number of vector elements.
2614 if (Bitcast->getSrcTy()->getScalarSizeInBits() ==
2615 Bitcast->getDestTy()->getScalarSizeInBits()) {
2616 // Zero-equality and sign-bit checks are preserved through sitofp + bitcast.
2617 Value *X;
2618 if (match(BCSrcOp, m_SIToFP(m_Value(X)))) {
2619 // icmp eq (bitcast (sitofp X)), 0 --> icmp eq X, 0
2620 // icmp ne (bitcast (sitofp X)), 0 --> icmp ne X, 0
2621 // icmp slt (bitcast (sitofp X)), 0 --> icmp slt X, 0
2622 // icmp sgt (bitcast (sitofp X)), 0 --> icmp sgt X, 0
2623 if ((Pred == ICmpInst::ICMP_EQ || Pred == ICmpInst::ICMP_SLT ||
2624 Pred == ICmpInst::ICMP_NE || Pred == ICmpInst::ICMP_SGT) &&
2625 match(Op1, m_Zero()))
2626 return new ICmpInst(Pred, X, ConstantInt::getNullValue(X->getType()));
Sanjay Patele7f46c32019-02-07 20:54:09 +00002627
Sanjay Patel781d8832019-02-07 21:12:01 +00002628 // icmp slt (bitcast (sitofp X)), 1 --> icmp slt X, 1
2629 if (Pred == ICmpInst::ICMP_SLT && match(Op1, m_One()))
2630 return new ICmpInst(Pred, X, ConstantInt::get(X->getType(), 1));
2631
2632 // icmp sgt (bitcast (sitofp X)), -1 --> icmp sgt X, -1
2633 if (Pred == ICmpInst::ICMP_SGT && match(Op1, m_AllOnes()))
2634 return new ICmpInst(Pred, X,
2635 ConstantInt::getAllOnesValue(X->getType()));
2636 }
2637
2638 // Zero-equality checks are preserved through unsigned floating-point casts:
2639 // icmp eq (bitcast (uitofp X)), 0 --> icmp eq X, 0
2640 // icmp ne (bitcast (uitofp X)), 0 --> icmp ne X, 0
2641 if (match(BCSrcOp, m_UIToFP(m_Value(X))))
2642 if (Cmp.isEquality() && match(Op1, m_Zero()))
2643 return new ICmpInst(Pred, X, ConstantInt::getNullValue(X->getType()));
Sanjay Patele7f46c32019-02-07 20:54:09 +00002644 }
2645
Sanjay Patele7f46c32019-02-07 20:54:09 +00002646 // Test to see if the operands of the icmp are casted versions of other
2647 // values. If the ptr->ptr cast can be stripped off both arguments, do so.
2648 if (Bitcast->getType()->isPointerTy() &&
2649 (isa<Constant>(Op1) || isa<BitCastInst>(Op1))) {
2650 // If operand #1 is a bitcast instruction, it must also be a ptr->ptr cast
2651 // so eliminate it as well.
2652 if (auto *BC2 = dyn_cast<BitCastInst>(Op1))
2653 Op1 = BC2->getOperand(0);
2654
2655 Op1 = Builder.CreateBitCast(Op1, BCSrcOp->getType());
2656 return new ICmpInst(Pred, BCSrcOp, Op1);
2657 }
2658
Daniel Neilson901acfa2018-04-03 17:26:20 +00002659 // Folding: icmp <pred> iN X, C
2660 // where X = bitcast <M x iK> (shufflevector <M x iK> %vec, undef, SC)) to iN
2661 // and C is a splat of a K-bit pattern
2662 // and SC is a constant vector = <C', C', C', ..., C'>
2663 // Into:
2664 // %E = extractelement <M x iK> %vec, i32 C'
2665 // icmp <pred> iK %E, trunc(C)
Sanjay Patele7f46c32019-02-07 20:54:09 +00002666 const APInt *C;
2667 if (!match(Cmp.getOperand(1), m_APInt(C)) ||
2668 !Bitcast->getType()->isIntegerTy() ||
Daniel Neilson901acfa2018-04-03 17:26:20 +00002669 !Bitcast->getSrcTy()->isIntOrIntVectorTy())
2670 return nullptr;
2671
Sanjay Patele7f46c32019-02-07 20:54:09 +00002672 Value *Vec;
2673 Constant *Mask;
2674 if (match(BCSrcOp,
Daniel Neilson901acfa2018-04-03 17:26:20 +00002675 m_ShuffleVector(m_Value(Vec), m_Undef(), m_Constant(Mask)))) {
2676 // Check whether every element of Mask is the same constant
2677 if (auto *Elem = dyn_cast_or_null<ConstantInt>(Mask->getSplatValue())) {
Sanjay Patele7f46c32019-02-07 20:54:09 +00002678 auto *VecTy = cast<VectorType>(BCSrcOp->getType());
Daniel Neilson901acfa2018-04-03 17:26:20 +00002679 auto *EltTy = cast<IntegerType>(VecTy->getElementType());
Sanjay Patele7f46c32019-02-07 20:54:09 +00002680 if (C->isSplat(EltTy->getBitWidth())) {
Daniel Neilson901acfa2018-04-03 17:26:20 +00002681 // Fold the icmp based on the value of C
2682 // If C is M copies of an iK sized bit pattern,
2683 // then:
2684 // => %E = extractelement <N x iK> %vec, i32 Elem
2685 // icmp <pred> iK %SplatVal, <pattern>
2686 Value *Extract = Builder.CreateExtractElement(Vec, Elem);
Sanjay Patele7f46c32019-02-07 20:54:09 +00002687 Value *NewC = ConstantInt::get(EltTy, C->trunc(EltTy->getBitWidth()));
Daniel Neilson901acfa2018-04-03 17:26:20 +00002688 return new ICmpInst(Pred, Extract, NewC);
2689 }
2690 }
2691 }
2692 return nullptr;
2693}
2694
Sanjay Patelf58f68c2016-09-10 15:03:44 +00002695/// Try to fold integer comparisons with a constant operand: icmp Pred X, C
2696/// where X is some kind of instruction.
2697Instruction *InstCombiner::foldICmpInstWithConstant(ICmpInst &Cmp) {
Sanjay Patelc9196c42016-08-22 21:24:29 +00002698 const APInt *C;
2699 if (!match(Cmp.getOperand(1), m_APInt(C)))
Sanjay Patel1e5b2d12016-08-16 16:08:11 +00002700 return nullptr;
2701
Craig Toppera94069f2017-08-23 05:46:08 +00002702 if (auto *BO = dyn_cast<BinaryOperator>(Cmp.getOperand(0))) {
Sanjay Patelc9196c42016-08-22 21:24:29 +00002703 switch (BO->getOpcode()) {
2704 case Instruction::Xor:
Craig Topper8ed1aa92017-10-03 05:31:07 +00002705 if (Instruction *I = foldICmpXorConstant(Cmp, BO, *C))
Sanjay Patelc9196c42016-08-22 21:24:29 +00002706 return I;
2707 break;
2708 case Instruction::And:
Craig Topper8ed1aa92017-10-03 05:31:07 +00002709 if (Instruction *I = foldICmpAndConstant(Cmp, BO, *C))
Sanjay Patelc9196c42016-08-22 21:24:29 +00002710 return I;
2711 break;
2712 case Instruction::Or:
Craig Topper8ed1aa92017-10-03 05:31:07 +00002713 if (Instruction *I = foldICmpOrConstant(Cmp, BO, *C))
Sanjay Patelc9196c42016-08-22 21:24:29 +00002714 return I;
2715 break;
2716 case Instruction::Mul:
Craig Topper8ed1aa92017-10-03 05:31:07 +00002717 if (Instruction *I = foldICmpMulConstant(Cmp, BO, *C))
Sanjay Patelc9196c42016-08-22 21:24:29 +00002718 return I;
2719 break;
2720 case Instruction::Shl:
Craig Topper8ed1aa92017-10-03 05:31:07 +00002721 if (Instruction *I = foldICmpShlConstant(Cmp, BO, *C))
Sanjay Patelc9196c42016-08-22 21:24:29 +00002722 return I;
2723 break;
2724 case Instruction::LShr:
2725 case Instruction::AShr:
Craig Topper8ed1aa92017-10-03 05:31:07 +00002726 if (Instruction *I = foldICmpShrConstant(Cmp, BO, *C))
Sanjay Patelc9196c42016-08-22 21:24:29 +00002727 return I;
2728 break;
2729 case Instruction::UDiv:
Craig Topper8ed1aa92017-10-03 05:31:07 +00002730 if (Instruction *I = foldICmpUDivConstant(Cmp, BO, *C))
Sanjay Patelc9196c42016-08-22 21:24:29 +00002731 return I;
2732 LLVM_FALLTHROUGH;
2733 case Instruction::SDiv:
Craig Topper8ed1aa92017-10-03 05:31:07 +00002734 if (Instruction *I = foldICmpDivConstant(Cmp, BO, *C))
Sanjay Patelc9196c42016-08-22 21:24:29 +00002735 return I;
2736 break;
2737 case Instruction::Sub:
Craig Topper8ed1aa92017-10-03 05:31:07 +00002738 if (Instruction *I = foldICmpSubConstant(Cmp, BO, *C))
Sanjay Patelc9196c42016-08-22 21:24:29 +00002739 return I;
2740 break;
2741 case Instruction::Add:
Craig Topper8ed1aa92017-10-03 05:31:07 +00002742 if (Instruction *I = foldICmpAddConstant(Cmp, BO, *C))
Sanjay Patelc9196c42016-08-22 21:24:29 +00002743 return I;
2744 break;
2745 default:
2746 break;
2747 }
Sanjay Patelf58f68c2016-09-10 15:03:44 +00002748 // TODO: These folds could be refactored to be part of the above calls.
Craig Topper8ed1aa92017-10-03 05:31:07 +00002749 if (Instruction *I = foldICmpBinOpEqualityWithConstant(Cmp, BO, *C))
Sanjay Patelf58f68c2016-09-10 15:03:44 +00002750 return I;
Chris Lattner2188e402010-01-04 07:37:31 +00002751 }
Jim Grosbach129c52a2011-09-30 18:09:53 +00002752
Anna Thomasd67165c2017-06-23 13:41:45 +00002753 // Match against CmpInst LHS being instructions other than binary operators.
Craig Topper524c44f2017-08-23 05:46:07 +00002754
2755 if (auto *SI = dyn_cast<SelectInst>(Cmp.getOperand(0))) {
2756 // For now, we only support constant integers while folding the
2757 // ICMP(SELECT)) pattern. We can extend this to support vector of integers
2758 // similar to the cases handled by binary ops above.
2759 if (ConstantInt *ConstRHS = dyn_cast<ConstantInt>(Cmp.getOperand(1)))
2760 if (Instruction *I = foldICmpSelectConstant(Cmp, SI, ConstRHS))
Anna Thomasd67165c2017-06-23 13:41:45 +00002761 return I;
Craig Topper524c44f2017-08-23 05:46:07 +00002762 }
2763
2764 if (auto *TI = dyn_cast<TruncInst>(Cmp.getOperand(0))) {
Craig Topper8ed1aa92017-10-03 05:31:07 +00002765 if (Instruction *I = foldICmpTruncConstant(Cmp, TI, *C))
Craig Topper524c44f2017-08-23 05:46:07 +00002766 return I;
Anna Thomasd67165c2017-06-23 13:41:45 +00002767 }
Sanjay Patelc9196c42016-08-22 21:24:29 +00002768
Nikita Popov6515db22019-01-19 09:56:01 +00002769 if (auto *II = dyn_cast<IntrinsicInst>(Cmp.getOperand(0)))
2770 if (Instruction *I = foldICmpIntrinsicWithConstant(Cmp, II, *C))
2771 return I;
Sanjay Patelf58f68c2016-09-10 15:03:44 +00002772
Sanjay Patel1710e7c2016-07-21 17:15:49 +00002773 return nullptr;
2774}
Jim Grosbach129c52a2011-09-30 18:09:53 +00002775
Sanjay Patel0a3d72b2016-09-10 15:33:39 +00002776/// Fold an icmp equality instruction with binary operator LHS and constant RHS:
2777/// icmp eq/ne BO, C.
2778Instruction *InstCombiner::foldICmpBinOpEqualityWithConstant(ICmpInst &Cmp,
2779 BinaryOperator *BO,
Craig Topper8ed1aa92017-10-03 05:31:07 +00002780 const APInt &C) {
Sanjay Patel0a3d72b2016-09-10 15:33:39 +00002781 // TODO: Some of these folds could work with arbitrary constants, but this
2782 // function is limited to scalar and vector splat constants.
2783 if (!Cmp.isEquality())
Sanjay Patel1710e7c2016-07-21 17:15:49 +00002784 return nullptr;
2785
Sanjay Patel0a3d72b2016-09-10 15:33:39 +00002786 ICmpInst::Predicate Pred = Cmp.getPredicate();
2787 bool isICMP_NE = Pred == ICmpInst::ICMP_NE;
2788 Constant *RHS = cast<Constant>(Cmp.getOperand(1));
Sanjay Patel51a767c2016-08-03 17:23:08 +00002789 Value *BOp0 = BO->getOperand(0), *BOp1 = BO->getOperand(1);
Sanjay Patel1710e7c2016-07-21 17:15:49 +00002790
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002791 switch (BO->getOpcode()) {
2792 case Instruction::SRem:
2793 // If we have a signed (X % (2^c)) == 0, turn it into an unsigned one.
Craig Topper8ed1aa92017-10-03 05:31:07 +00002794 if (C.isNullValue() && BO->hasOneUse()) {
Sanjay Patel2e9675f2016-08-03 19:48:40 +00002795 const APInt *BOC;
2796 if (match(BOp1, m_APInt(BOC)) && BOC->sgt(1) && BOC->isPowerOf2()) {
Craig Topperbb4069e2017-07-07 23:16:26 +00002797 Value *NewRem = Builder.CreateURem(BOp0, BOp1, BO->getName());
Sanjay Patel0a3d72b2016-09-10 15:33:39 +00002798 return new ICmpInst(Pred, NewRem,
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002799 Constant::getNullValue(BO->getType()));
Chris Lattner2188e402010-01-04 07:37:31 +00002800 }
Sanjay Patel1710e7c2016-07-21 17:15:49 +00002801 }
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002802 break;
Sanjay Patel00a324e2016-08-03 22:08:44 +00002803 case Instruction::Add: {
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002804 // Replace ((add A, B) != C) with (A != C-B) if B & C are constants.
Sanjay Patel00a324e2016-08-03 22:08:44 +00002805 const APInt *BOC;
2806 if (match(BOp1, m_APInt(BOC))) {
2807 if (BO->hasOneUse()) {
2808 Constant *SubC = ConstantExpr::getSub(RHS, cast<Constant>(BOp1));
Sanjay Patel0a3d72b2016-09-10 15:33:39 +00002809 return new ICmpInst(Pred, BOp0, SubC);
Sanjay Patel00a324e2016-08-03 22:08:44 +00002810 }
Craig Topper8ed1aa92017-10-03 05:31:07 +00002811 } else if (C.isNullValue()) {
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002812 // Replace ((add A, B) != 0) with (A != -B) if A or B is
2813 // efficiently invertible, or if the add has just this one use.
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002814 if (Value *NegVal = dyn_castNegVal(BOp1))
Sanjay Patel0a3d72b2016-09-10 15:33:39 +00002815 return new ICmpInst(Pred, BOp0, NegVal);
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002816 if (Value *NegVal = dyn_castNegVal(BOp0))
Sanjay Patel0a3d72b2016-09-10 15:33:39 +00002817 return new ICmpInst(Pred, NegVal, BOp1);
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002818 if (BO->hasOneUse()) {
Craig Topperbb4069e2017-07-07 23:16:26 +00002819 Value *Neg = Builder.CreateNeg(BOp1);
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002820 Neg->takeName(BO);
Sanjay Patel0a3d72b2016-09-10 15:33:39 +00002821 return new ICmpInst(Pred, BOp0, Neg);
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002822 }
2823 }
2824 break;
Sanjay Patel00a324e2016-08-03 22:08:44 +00002825 }
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002826 case Instruction::Xor:
2827 if (BO->hasOneUse()) {
Sanjay Patel51a767c2016-08-03 17:23:08 +00002828 if (Constant *BOC = dyn_cast<Constant>(BOp1)) {
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002829 // For the xor case, we can xor two constants together, eliminating
2830 // the explicit xor.
Sanjay Patel0a3d72b2016-09-10 15:33:39 +00002831 return new ICmpInst(Pred, BOp0, ConstantExpr::getXor(RHS, BOC));
Craig Topper8ed1aa92017-10-03 05:31:07 +00002832 } else if (C.isNullValue()) {
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002833 // Replace ((xor A, B) != 0) with (A != B)
Sanjay Patel0a3d72b2016-09-10 15:33:39 +00002834 return new ICmpInst(Pred, BOp0, BOp1);
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002835 }
2836 }
2837 break;
2838 case Instruction::Sub:
2839 if (BO->hasOneUse()) {
Sanjay Patel9d591d12016-08-04 15:19:25 +00002840 const APInt *BOC;
2841 if (match(BOp0, m_APInt(BOC))) {
Sanjay Patel362ff5c2016-09-15 17:01:17 +00002842 // Replace ((sub BOC, B) != C) with (B != BOC-C).
Sanjay Patel9d591d12016-08-04 15:19:25 +00002843 Constant *SubC = ConstantExpr::getSub(cast<Constant>(BOp0), RHS);
Sanjay Patel0a3d72b2016-09-10 15:33:39 +00002844 return new ICmpInst(Pred, BOp1, SubC);
Craig Topper8ed1aa92017-10-03 05:31:07 +00002845 } else if (C.isNullValue()) {
Sanjay Patel362ff5c2016-09-15 17:01:17 +00002846 // Replace ((sub A, B) != 0) with (A != B).
Sanjay Patel0a3d72b2016-09-10 15:33:39 +00002847 return new ICmpInst(Pred, BOp0, BOp1);
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002848 }
2849 }
2850 break;
Sanjay Patelb3de75d2016-08-04 19:12:12 +00002851 case Instruction::Or: {
2852 const APInt *BOC;
2853 if (match(BOp1, m_APInt(BOC)) && BO->hasOneUse() && RHS->isAllOnesValue()) {
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002854 // Comparing if all bits outside of a constant mask are set?
2855 // Replace (X | C) == -1 with (X & ~C) == ~C.
2856 // This removes the -1 constant.
Sanjay Patelb3de75d2016-08-04 19:12:12 +00002857 Constant *NotBOC = ConstantExpr::getNot(cast<Constant>(BOp1));
Craig Topperbb4069e2017-07-07 23:16:26 +00002858 Value *And = Builder.CreateAnd(BOp0, NotBOC);
Sanjay Patel0a3d72b2016-09-10 15:33:39 +00002859 return new ICmpInst(Pred, And, NotBOC);
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002860 }
2861 break;
Sanjay Patelb3de75d2016-08-04 19:12:12 +00002862 }
Sanjay Pateld938e882016-08-04 20:05:02 +00002863 case Instruction::And: {
2864 const APInt *BOC;
2865 if (match(BOp1, m_APInt(BOC))) {
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002866 // If we have ((X & C) == C), turn it into ((X & C) != 0).
Craig Topper8ed1aa92017-10-03 05:31:07 +00002867 if (C == *BOC && C.isPowerOf2())
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002868 return new ICmpInst(isICMP_NE ? ICmpInst::ICMP_EQ : ICmpInst::ICMP_NE,
Sanjay Patelab50a932016-08-02 22:38:33 +00002869 BO, Constant::getNullValue(RHS->getType()));
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002870 }
2871 break;
Sanjay Pateld938e882016-08-04 20:05:02 +00002872 }
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002873 case Instruction::Mul:
Craig Topper8ed1aa92017-10-03 05:31:07 +00002874 if (C.isNullValue() && BO->hasNoSignedWrap()) {
Sanjay Patel3bade132016-08-04 22:19:27 +00002875 const APInt *BOC;
Craig Topper73ba1c82017-06-07 07:40:37 +00002876 if (match(BOp1, m_APInt(BOC)) && !BOC->isNullValue()) {
Sanjay Patel3bade132016-08-04 22:19:27 +00002877 // The trivial case (mul X, 0) is handled by InstSimplify.
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002878 // General case : (mul X, C) != 0 iff X != 0
2879 // (mul X, C) == 0 iff X == 0
Sanjay Patel0a3d72b2016-09-10 15:33:39 +00002880 return new ICmpInst(Pred, BOp0, Constant::getNullValue(RHS->getType()));
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002881 }
2882 }
2883 break;
Sanjay Patel6ebd5852016-07-23 00:28:39 +00002884 case Instruction::UDiv:
Craig Topper8ed1aa92017-10-03 05:31:07 +00002885 if (C.isNullValue()) {
Sanjay Patel6ebd5852016-07-23 00:28:39 +00002886 // (icmp eq/ne (udiv A, B), 0) -> (icmp ugt/ule i32 B, A)
Sanjay Patel0a3d72b2016-09-10 15:33:39 +00002887 auto NewPred = isICMP_NE ? ICmpInst::ICMP_ULE : ICmpInst::ICMP_UGT;
2888 return new ICmpInst(NewPred, BOp1, BOp0);
Sanjay Patel6ebd5852016-07-23 00:28:39 +00002889 }
2890 break;
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002891 default:
2892 break;
2893 }
2894 return nullptr;
2895}
2896
Nikita Popov6515db22019-01-19 09:56:01 +00002897/// Fold an equality icmp with LLVM intrinsic and constant operand.
2898Instruction *InstCombiner::foldICmpEqIntrinsicWithConstant(ICmpInst &Cmp,
2899 IntrinsicInst *II,
2900 const APInt &C) {
Sanjay Patelb51e0722017-07-02 16:05:11 +00002901 Type *Ty = II->getType();
Nikita Popov20853a72018-12-18 19:59:50 +00002902 unsigned BitWidth = C.getBitWidth();
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002903 switch (II->getIntrinsicID()) {
2904 case Intrinsic::bswap:
2905 Worklist.Add(II);
Sanjay Patel0a3d72b2016-09-10 15:33:39 +00002906 Cmp.setOperand(0, II->getArgOperand(0));
Craig Topper8ed1aa92017-10-03 05:31:07 +00002907 Cmp.setOperand(1, ConstantInt::get(Ty, C.byteSwap()));
Sanjay Patel0a3d72b2016-09-10 15:33:39 +00002908 return &Cmp;
Sanjay Patelb51e0722017-07-02 16:05:11 +00002909
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002910 case Intrinsic::ctlz:
Nikita Popov20853a72018-12-18 19:59:50 +00002911 case Intrinsic::cttz: {
Amaury Sechet6bea6742016-08-04 05:27:20 +00002912 // ctz(A) == bitwidth(A) -> A == 0 and likewise for !=
Nikita Popov20853a72018-12-18 19:59:50 +00002913 if (C == BitWidth) {
Sanjay Patel1710e7c2016-07-21 17:15:49 +00002914 Worklist.Add(II);
Sanjay Patel0a3d72b2016-09-10 15:33:39 +00002915 Cmp.setOperand(0, II->getArgOperand(0));
Sanjay Patelb51e0722017-07-02 16:05:11 +00002916 Cmp.setOperand(1, ConstantInt::getNullValue(Ty));
Sanjay Patel0a3d72b2016-09-10 15:33:39 +00002917 return &Cmp;
Chris Lattner2188e402010-01-04 07:37:31 +00002918 }
Nikita Popov20853a72018-12-18 19:59:50 +00002919
2920 // ctz(A) == C -> A & Mask1 == Mask2, where Mask2 only has bit C set
2921 // and Mask1 has bits 0..C+1 set. Similar for ctl, but for high bits.
2922 // Limit to one use to ensure we don't increase instruction count.
2923 unsigned Num = C.getLimitedValue(BitWidth);
2924 if (Num != BitWidth && II->hasOneUse()) {
2925 bool IsTrailing = II->getIntrinsicID() == Intrinsic::cttz;
2926 APInt Mask1 = IsTrailing ? APInt::getLowBitsSet(BitWidth, Num + 1)
2927 : APInt::getHighBitsSet(BitWidth, Num + 1);
2928 APInt Mask2 = IsTrailing
2929 ? APInt::getOneBitSet(BitWidth, Num)
2930 : APInt::getOneBitSet(BitWidth, BitWidth - Num - 1);
2931 Cmp.setOperand(0, Builder.CreateAnd(II->getArgOperand(0), Mask1));
2932 Cmp.setOperand(1, ConstantInt::get(Ty, Mask2));
2933 Worklist.Add(II);
2934 return &Cmp;
2935 }
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002936 break;
Nikita Popov20853a72018-12-18 19:59:50 +00002937 }
Sanjay Patelb51e0722017-07-02 16:05:11 +00002938
Amaury Sechet6bea6742016-08-04 05:27:20 +00002939 case Intrinsic::ctpop: {
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002940 // popcount(A) == 0 -> A == 0 and likewise for !=
Amaury Sechet6bea6742016-08-04 05:27:20 +00002941 // popcount(A) == bitwidth(A) -> A == -1 and likewise for !=
Craig Topper8ed1aa92017-10-03 05:31:07 +00002942 bool IsZero = C.isNullValue();
Nikita Popov20853a72018-12-18 19:59:50 +00002943 if (IsZero || C == BitWidth) {
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002944 Worklist.Add(II);
Sanjay Patel0a3d72b2016-09-10 15:33:39 +00002945 Cmp.setOperand(0, II->getArgOperand(0));
Sanjay Patelb51e0722017-07-02 16:05:11 +00002946 auto *NewOp =
2947 IsZero ? Constant::getNullValue(Ty) : Constant::getAllOnesValue(Ty);
Sanjay Patel0a3d72b2016-09-10 15:33:39 +00002948 Cmp.setOperand(1, NewOp);
2949 return &Cmp;
Amaury Sechet6bea6742016-08-04 05:27:20 +00002950 }
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002951 break;
Sanjay Patel0a3d72b2016-09-10 15:33:39 +00002952 }
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002953 default:
2954 break;
Chris Lattner2188e402010-01-04 07:37:31 +00002955 }
Sanjay Patelb51e0722017-07-02 16:05:11 +00002956
Craig Topperf40110f2014-04-25 05:29:35 +00002957 return nullptr;
Chris Lattner2188e402010-01-04 07:37:31 +00002958}
2959
Nikita Popov6515db22019-01-19 09:56:01 +00002960/// Fold an icmp with LLVM intrinsic and constant operand: icmp Pred II, C.
2961Instruction *InstCombiner::foldICmpIntrinsicWithConstant(ICmpInst &Cmp,
2962 IntrinsicInst *II,
2963 const APInt &C) {
2964 if (Cmp.isEquality())
2965 return foldICmpEqIntrinsicWithConstant(Cmp, II, C);
2966
2967 Type *Ty = II->getType();
2968 unsigned BitWidth = C.getBitWidth();
2969 switch (II->getIntrinsicID()) {
2970 case Intrinsic::ctlz: {
2971 // ctlz(0bXXXXXXXX) > 3 -> 0bXXXXXXXX < 0b00010000
2972 if (Cmp.getPredicate() == ICmpInst::ICMP_UGT && C.ult(BitWidth)) {
2973 unsigned Num = C.getLimitedValue();
2974 APInt Limit = APInt::getOneBitSet(BitWidth, BitWidth - Num - 1);
2975 return CmpInst::Create(Instruction::ICmp, ICmpInst::ICMP_ULT,
2976 II->getArgOperand(0), ConstantInt::get(Ty, Limit));
2977 }
2978
2979 // ctlz(0bXXXXXXXX) < 3 -> 0bXXXXXXXX > 0b00011111
2980 if (Cmp.getPredicate() == ICmpInst::ICMP_ULT &&
2981 C.uge(1) && C.ule(BitWidth)) {
2982 unsigned Num = C.getLimitedValue();
2983 APInt Limit = APInt::getLowBitsSet(BitWidth, BitWidth - Num);
2984 return CmpInst::Create(Instruction::ICmp, ICmpInst::ICMP_UGT,
2985 II->getArgOperand(0), ConstantInt::get(Ty, Limit));
2986 }
2987 break;
2988 }
2989 case Intrinsic::cttz: {
2990 // Limit to one use to ensure we don't increase instruction count.
2991 if (!II->hasOneUse())
2992 return nullptr;
2993
2994 // cttz(0bXXXXXXXX) > 3 -> 0bXXXXXXXX & 0b00001111 == 0
2995 if (Cmp.getPredicate() == ICmpInst::ICMP_UGT && C.ult(BitWidth)) {
2996 APInt Mask = APInt::getLowBitsSet(BitWidth, C.getLimitedValue() + 1);
2997 return CmpInst::Create(Instruction::ICmp, ICmpInst::ICMP_EQ,
2998 Builder.CreateAnd(II->getArgOperand(0), Mask),
2999 ConstantInt::getNullValue(Ty));
3000 }
3001
3002 // cttz(0bXXXXXXXX) < 3 -> 0bXXXXXXXX & 0b00000111 != 0
3003 if (Cmp.getPredicate() == ICmpInst::ICMP_ULT &&
3004 C.uge(1) && C.ule(BitWidth)) {
3005 APInt Mask = APInt::getLowBitsSet(BitWidth, C.getLimitedValue());
3006 return CmpInst::Create(Instruction::ICmp, ICmpInst::ICMP_NE,
3007 Builder.CreateAnd(II->getArgOperand(0), Mask),
3008 ConstantInt::getNullValue(Ty));
3009 }
3010 break;
3011 }
3012 default:
3013 break;
3014 }
3015
3016 return nullptr;
3017}
3018
Sanjay Patel10494b22016-09-16 16:10:22 +00003019/// Handle icmp with constant (but not simple integer constant) RHS.
3020Instruction *InstCombiner::foldICmpInstWithConstantNotInt(ICmpInst &I) {
3021 Value *Op0 = I.getOperand(0), *Op1 = I.getOperand(1);
3022 Constant *RHSC = dyn_cast<Constant>(Op1);
3023 Instruction *LHSI = dyn_cast<Instruction>(Op0);
3024 if (!RHSC || !LHSI)
3025 return nullptr;
3026
3027 switch (LHSI->getOpcode()) {
3028 case Instruction::GetElementPtr:
3029 // icmp pred GEP (P, int 0, int 0, int 0), null -> icmp pred P, null
3030 if (RHSC->isNullValue() &&
3031 cast<GetElementPtrInst>(LHSI)->hasAllZeroIndices())
3032 return new ICmpInst(
3033 I.getPredicate(), LHSI->getOperand(0),
3034 Constant::getNullValue(LHSI->getOperand(0)->getType()));
3035 break;
3036 case Instruction::PHI:
3037 // Only fold icmp into the PHI if the phi and icmp are in the same
3038 // block. If in the same block, we're encouraging jump threading. If
3039 // not, we are just pessimizing the code by making an i1 phi.
3040 if (LHSI->getParent() == I.getParent())
Craig Topperfb71b7d2017-04-14 19:20:12 +00003041 if (Instruction *NV = foldOpIntoPhi(I, cast<PHINode>(LHSI)))
Sanjay Patel10494b22016-09-16 16:10:22 +00003042 return NV;
3043 break;
3044 case Instruction::Select: {
3045 // If either operand of the select is a constant, we can fold the
3046 // comparison into the select arms, which will cause one to be
3047 // constant folded and the select turned into a bitwise or.
3048 Value *Op1 = nullptr, *Op2 = nullptr;
3049 ConstantInt *CI = nullptr;
3050 if (Constant *C = dyn_cast<Constant>(LHSI->getOperand(1))) {
3051 Op1 = ConstantExpr::getICmp(I.getPredicate(), C, RHSC);
3052 CI = dyn_cast<ConstantInt>(Op1);
3053 }
3054 if (Constant *C = dyn_cast<Constant>(LHSI->getOperand(2))) {
3055 Op2 = ConstantExpr::getICmp(I.getPredicate(), C, RHSC);
3056 CI = dyn_cast<ConstantInt>(Op2);
3057 }
3058
3059 // We only want to perform this transformation if it will not lead to
3060 // additional code. This is true if either both sides of the select
3061 // fold to a constant (in which case the icmp is replaced with a select
3062 // which will usually simplify) or this is the only user of the
3063 // select (in which case we are trading a select+icmp for a simpler
3064 // select+icmp) or all uses of the select can be replaced based on
3065 // dominance information ("Global cases").
3066 bool Transform = false;
3067 if (Op1 && Op2)
3068 Transform = true;
3069 else if (Op1 || Op2) {
3070 // Local case
3071 if (LHSI->hasOneUse())
3072 Transform = true;
3073 // Global cases
3074 else if (CI && !CI->isZero())
3075 // When Op1 is constant try replacing select with second operand.
3076 // Otherwise Op2 is constant and try replacing select with first
3077 // operand.
3078 Transform =
3079 replacedSelectWithOperand(cast<SelectInst>(LHSI), &I, Op1 ? 2 : 1);
3080 }
3081 if (Transform) {
3082 if (!Op1)
Craig Topperbb4069e2017-07-07 23:16:26 +00003083 Op1 = Builder.CreateICmp(I.getPredicate(), LHSI->getOperand(1), RHSC,
3084 I.getName());
Sanjay Patel10494b22016-09-16 16:10:22 +00003085 if (!Op2)
Craig Topperbb4069e2017-07-07 23:16:26 +00003086 Op2 = Builder.CreateICmp(I.getPredicate(), LHSI->getOperand(2), RHSC,
3087 I.getName());
Sanjay Patel10494b22016-09-16 16:10:22 +00003088 return SelectInst::Create(LHSI->getOperand(0), Op1, Op2);
3089 }
3090 break;
3091 }
3092 case Instruction::IntToPtr:
3093 // icmp pred inttoptr(X), null -> icmp pred X, 0
3094 if (RHSC->isNullValue() &&
3095 DL.getIntPtrType(RHSC->getType()) == LHSI->getOperand(0)->getType())
3096 return new ICmpInst(
3097 I.getPredicate(), LHSI->getOperand(0),
3098 Constant::getNullValue(LHSI->getOperand(0)->getType()));
3099 break;
3100
3101 case Instruction::Load:
3102 // Try to optimize things like "A[i] > 4" to index computations.
3103 if (GetElementPtrInst *GEP =
3104 dyn_cast<GetElementPtrInst>(LHSI->getOperand(0))) {
3105 if (GlobalVariable *GV = dyn_cast<GlobalVariable>(GEP->getOperand(0)))
3106 if (GV->isConstant() && GV->hasDefinitiveInitializer() &&
3107 !cast<LoadInst>(LHSI)->isVolatile())
3108 if (Instruction *Res = foldCmpLoadFromIndexedGlobal(GEP, GV, I))
3109 return Res;
3110 }
3111 break;
3112 }
3113
3114 return nullptr;
3115}
3116
Roman Lebedev68d54cf2018-07-11 19:05:04 +00003117/// Some comparisons can be simplified.
3118/// In this case, we are looking for comparisons that look like
3119/// a check for a lossy truncation.
3120/// Folds:
Roman Lebedev183a4652018-09-19 13:35:27 +00003121/// icmp SrcPred (x & Mask), x to icmp DstPred x, Mask
3122/// Where Mask is some pattern that produces all-ones in low bits:
3123/// (-1 >> y)
Roman Lebedevf50023d2018-09-19 13:35:46 +00003124/// ((-1 << y) >> y) <- non-canonical, has extra uses
Roman Lebedev183a4652018-09-19 13:35:27 +00003125/// ~(-1 << y)
Roman Lebedevca2bdb02018-09-19 13:35:40 +00003126/// ((1 << y) + (-1)) <- non-canonical, has extra uses
Roman Lebedev68d54cf2018-07-11 19:05:04 +00003127/// The Mask can be a constant, too.
Roman Lebedevc7bc4c02018-07-14 20:08:52 +00003128/// For some predicates, the operands are commutative.
3129/// For others, x can only be on a specific side.
Roman Lebedev68d54cf2018-07-11 19:05:04 +00003130static Value *foldICmpWithLowBitMaskedVal(ICmpInst &I,
3131 InstCombiner::BuilderTy &Builder) {
3132 ICmpInst::Predicate SrcPred;
Roman Lebedevf50023d2018-09-19 13:35:46 +00003133 Value *X, *M, *Y;
3134 auto m_VariableMask = m_CombineOr(
3135 m_CombineOr(m_Not(m_Shl(m_AllOnes(), m_Value())),
3136 m_Add(m_Shl(m_One(), m_Value()), m_AllOnes())),
3137 m_CombineOr(m_LShr(m_AllOnes(), m_Value()),
3138 m_LShr(m_Shl(m_AllOnes(), m_Value(Y)), m_Deferred(Y))));
Roman Lebedev183a4652018-09-19 13:35:27 +00003139 auto m_Mask = m_CombineOr(m_VariableMask, m_LowBitMask());
Roman Lebedev68d54cf2018-07-11 19:05:04 +00003140 if (!match(&I, m_c_ICmp(SrcPred,
3141 m_c_And(m_CombineAnd(m_Mask, m_Value(M)), m_Value(X)),
3142 m_Deferred(X))))
3143 return nullptr;
3144
3145 ICmpInst::Predicate DstPred;
3146 switch (SrcPred) {
3147 case ICmpInst::Predicate::ICMP_EQ:
3148 // x & (-1 >> y) == x -> x u<= (-1 >> y)
3149 DstPred = ICmpInst::Predicate::ICMP_ULE;
3150 break;
Roman Lebedev74f899f2018-07-12 14:56:12 +00003151 case ICmpInst::Predicate::ICMP_NE:
3152 // x & (-1 >> y) != x -> x u> (-1 >> y)
3153 DstPred = ICmpInst::Predicate::ICMP_UGT;
3154 break;
Roman Lebedev74f611a2018-07-14 16:44:43 +00003155 case ICmpInst::Predicate::ICMP_UGT:
3156 // x u> x & (-1 >> y) -> x u> (-1 >> y)
3157 assert(X == I.getOperand(0) && "instsimplify took care of commut. variant");
3158 DstPred = ICmpInst::Predicate::ICMP_UGT;
3159 break;
Roman Lebedevfac48472018-07-14 12:20:06 +00003160 case ICmpInst::Predicate::ICMP_UGE:
3161 // x & (-1 >> y) u>= x -> x u<= (-1 >> y)
3162 assert(X == I.getOperand(1) && "instsimplify took care of commut. variant");
3163 DstPred = ICmpInst::Predicate::ICMP_ULE;
3164 break;
Roman Lebedeve3dc5872018-07-14 12:20:16 +00003165 case ICmpInst::Predicate::ICMP_ULT:
3166 // x & (-1 >> y) u< x -> x u> (-1 >> y)
3167 assert(X == I.getOperand(1) && "instsimplify took care of commut. variant");
3168 DstPred = ICmpInst::Predicate::ICMP_UGT;
3169 break;
Roman Lebedev0f5ec892018-07-14 16:44:54 +00003170 case ICmpInst::Predicate::ICMP_ULE:
3171 // x u<= x & (-1 >> y) -> x u<= (-1 >> y)
3172 assert(X == I.getOperand(0) && "instsimplify took care of commut. variant");
3173 DstPred = ICmpInst::Predicate::ICMP_ULE;
3174 break;
Roman Lebedev859e14a2018-07-14 20:08:16 +00003175 case ICmpInst::Predicate::ICMP_SGT:
3176 // x s> x & (-1 >> y) -> x s> (-1 >> y)
3177 if (X != I.getOperand(0)) // X must be on LHS of comparison!
3178 return nullptr; // Ignore the other case.
Roman Lebedevd6697582019-06-09 16:30:42 +00003179 if (!match(M, m_Constant())) // Can not do this fold with non-constant.
3180 return nullptr;
3181 if (!match(M, m_NonNegative())) // Must not have any -1 vector elements.
3182 return nullptr;
Roman Lebedev859e14a2018-07-14 20:08:16 +00003183 DstPred = ICmpInst::Predicate::ICMP_SGT;
3184 break;
Roman Lebedevf1442612018-07-14 20:08:37 +00003185 case ICmpInst::Predicate::ICMP_SGE:
3186 // x & (-1 >> y) s>= x -> x s<= (-1 >> y)
3187 if (X != I.getOperand(1)) // X must be on RHS of comparison!
3188 return nullptr; // Ignore the other case.
Roman Lebedev7bf2fed2018-12-03 20:07:58 +00003189 if (!match(M, m_Constant())) // Can not do this fold with non-constant.
3190 return nullptr;
Roman Lebedev98cb1212018-12-06 08:14:24 +00003191 if (!match(M, m_NonNegative())) // Must not have any -1 vector elements.
3192 return nullptr;
Roman Lebedevf1442612018-07-14 20:08:37 +00003193 DstPred = ICmpInst::Predicate::ICMP_SLE;
3194 break;
Roman Lebedevb972fc32018-07-14 20:08:47 +00003195 case ICmpInst::Predicate::ICMP_SLT:
3196 // x & (-1 >> y) s< x -> x s> (-1 >> y)
3197 if (X != I.getOperand(1)) // X must be on RHS of comparison!
3198 return nullptr; // Ignore the other case.
Roman Lebedev7bf2fed2018-12-03 20:07:58 +00003199 if (!match(M, m_Constant())) // Can not do this fold with non-constant.
3200 return nullptr;
Roman Lebedev98cb1212018-12-06 08:14:24 +00003201 if (!match(M, m_NonNegative())) // Must not have any -1 vector elements.
3202 return nullptr;
Roman Lebedevb972fc32018-07-14 20:08:47 +00003203 DstPred = ICmpInst::Predicate::ICMP_SGT;
3204 break;
Roman Lebedev1e61e352018-07-14 20:08:26 +00003205 case ICmpInst::Predicate::ICMP_SLE:
3206 // x s<= x & (-1 >> y) -> x s<= (-1 >> y)
3207 if (X != I.getOperand(0)) // X must be on LHS of comparison!
3208 return nullptr; // Ignore the other case.
Roman Lebedevd6697582019-06-09 16:30:42 +00003209 if (!match(M, m_Constant())) // Can not do this fold with non-constant.
3210 return nullptr;
3211 if (!match(M, m_NonNegative())) // Must not have any -1 vector elements.
3212 return nullptr;
Roman Lebedev1e61e352018-07-14 20:08:26 +00003213 DstPred = ICmpInst::Predicate::ICMP_SLE;
3214 break;
Roman Lebedev68d54cf2018-07-11 19:05:04 +00003215 default:
Roman Lebedevc7bc4c02018-07-14 20:08:52 +00003216 llvm_unreachable("All possible folds are handled.");
Roman Lebedev68d54cf2018-07-11 19:05:04 +00003217 }
3218
3219 return Builder.CreateICmp(DstPred, X, M);
3220}
3221
Roman Lebedev3cb87e92018-07-18 10:55:17 +00003222/// Some comparisons can be simplified.
3223/// In this case, we are looking for comparisons that look like
3224/// a check for a lossy signed truncation.
3225/// Folds: (MaskedBits is a constant.)
3226/// ((%x << MaskedBits) a>> MaskedBits) SrcPred %x
3227/// Into:
3228/// (add %x, (1 << (KeptBits-1))) DstPred (1 << KeptBits)
3229/// Where KeptBits = bitwidth(%x) - MaskedBits
3230static Value *
3231foldICmpWithTruncSignExtendedVal(ICmpInst &I,
3232 InstCombiner::BuilderTy &Builder) {
3233 ICmpInst::Predicate SrcPred;
3234 Value *X;
3235 const APInt *C0, *C1; // FIXME: non-splats, potentially with undef.
3236 // We are ok with 'shl' having multiple uses, but 'ashr' must be one-use.
3237 if (!match(&I, m_c_ICmp(SrcPred,
3238 m_OneUse(m_AShr(m_Shl(m_Value(X), m_APInt(C0)),
3239 m_APInt(C1))),
3240 m_Deferred(X))))
3241 return nullptr;
3242
3243 // Potential handling of non-splats: for each element:
3244 // * if both are undef, replace with constant 0.
3245 // Because (1<<0) is OK and is 1, and ((1<<0)>>1) is also OK and is 0.
3246 // * if both are not undef, and are different, bailout.
3247 // * else, only one is undef, then pick the non-undef one.
3248
3249 // The shift amount must be equal.
3250 if (*C0 != *C1)
3251 return nullptr;
3252 const APInt &MaskedBits = *C0;
3253 assert(MaskedBits != 0 && "shift by zero should be folded away already.");
3254
3255 ICmpInst::Predicate DstPred;
3256 switch (SrcPred) {
3257 case ICmpInst::Predicate::ICMP_EQ:
3258 // ((%x << MaskedBits) a>> MaskedBits) == %x
3259 // =>
3260 // (add %x, (1 << (KeptBits-1))) u< (1 << KeptBits)
3261 DstPred = ICmpInst::Predicate::ICMP_ULT;
3262 break;
3263 case ICmpInst::Predicate::ICMP_NE:
3264 // ((%x << MaskedBits) a>> MaskedBits) != %x
3265 // =>
3266 // (add %x, (1 << (KeptBits-1))) u>= (1 << KeptBits)
3267 DstPred = ICmpInst::Predicate::ICMP_UGE;
3268 break;
3269 // FIXME: are more folds possible?
3270 default:
3271 return nullptr;
3272 }
3273
3274 auto *XType = X->getType();
3275 const unsigned XBitWidth = XType->getScalarSizeInBits();
3276 const APInt BitWidth = APInt(XBitWidth, XBitWidth);
3277 assert(BitWidth.ugt(MaskedBits) && "shifts should leave some bits untouched");
3278
3279 // KeptBits = bitwidth(%x) - MaskedBits
3280 const APInt KeptBits = BitWidth - MaskedBits;
3281 assert(KeptBits.ugt(0) && KeptBits.ult(BitWidth) && "unreachable");
3282 // ICmpCst = (1 << KeptBits)
3283 const APInt ICmpCst = APInt(XBitWidth, 1).shl(KeptBits);
3284 assert(ICmpCst.isPowerOf2());
3285 // AddCst = (1 << (KeptBits-1))
3286 const APInt AddCst = ICmpCst.lshr(1);
3287 assert(AddCst.ult(ICmpCst) && AddCst.isPowerOf2());
3288
3289 // T0 = add %x, AddCst
3290 Value *T0 = Builder.CreateAdd(X, ConstantInt::get(XType, AddCst));
3291 // T1 = T0 DstPred ICmpCst
3292 Value *T1 = Builder.CreateICmp(DstPred, T0, ConstantInt::get(XType, ICmpCst));
3293
3294 return T1;
3295}
3296
Roman Lebedev72b8d412019-07-01 15:55:15 +00003297// Given pattern:
3298// icmp eq/ne (and ((x shift Q), (y oppositeshift K))), 0
3299// we should move shifts to the same hand of 'and', i.e. rewrite as
3300// icmp eq/ne (and (x shift (Q+K)), y), 0 iff (Q+K) u< bitwidth(x)
3301// We are only interested in opposite logical shifts here.
3302// If we can, we want to end up creating 'lshr' shift.
3303static Value *
3304foldShiftIntoShiftInAnotherHandOfAndInICmp(ICmpInst &I, const SimplifyQuery SQ,
3305 InstCombiner::BuilderTy &Builder) {
3306 if (!I.isEquality() || !match(I.getOperand(1), m_Zero()) ||
3307 !I.getOperand(0)->hasOneUse())
3308 return nullptr;
3309
3310 auto m_AnyLogicalShift = m_LogicalShift(m_Value(), m_Value());
3311 auto m_AnyLShr = m_LShr(m_Value(), m_Value());
3312
3313 // Look for an 'and' of two (opposite) logical shifts.
3314 // Pick the single-use shift as XShift.
Roman Lebedevccdad6e2019-08-12 11:28:02 +00003315 Instruction *XShift, *YShift;
Roman Lebedev72b8d412019-07-01 15:55:15 +00003316 if (!match(I.getOperand(0),
Roman Lebedevccdad6e2019-08-12 11:28:02 +00003317 m_c_And(m_CombineAnd(m_AnyLogicalShift, m_Instruction(XShift)),
3318 m_CombineAnd(m_AnyLogicalShift, m_Instruction(YShift)))))
Roman Lebedev72b8d412019-07-01 15:55:15 +00003319 return nullptr;
3320
Roman Lebedev64fe8062019-08-10 19:28:44 +00003321 // If YShift is a 'lshr', swap the shifts around.
3322 if (match(YShift, m_AnyLShr))
Roman Lebedev72b8d412019-07-01 15:55:15 +00003323 std::swap(XShift, YShift);
3324
3325 // The shifts must be in opposite directions.
Roman Lebedevccdad6e2019-08-12 11:28:02 +00003326 auto XShiftOpcode = XShift->getOpcode();
3327 if (XShiftOpcode == YShift->getOpcode())
Roman Lebedev72b8d412019-07-01 15:55:15 +00003328 return nullptr; // Do not care about same-direction shifts here.
3329
3330 Value *X, *XShAmt, *Y, *YShAmt;
3331 match(XShift, m_BinOp(m_Value(X), m_Value(XShAmt)));
3332 match(YShift, m_BinOp(m_Value(Y), m_Value(YShAmt)));
3333
Roman Lebedeva8d20b42019-08-10 19:28:54 +00003334 // If one of the values being shifted is a constant, then we will end with
3335 // and+icmp, and shift instr will be constant-folded. If they are not,
3336 // however, we will need to ensure that we won't increase instruction count.
3337 if (!isa<Constant>(X) && !isa<Constant>(Y)) {
3338 // At least one of the hands of the 'and' should be one-use shift.
3339 if (!match(I.getOperand(0),
3340 m_c_And(m_OneUse(m_AnyLogicalShift), m_Value())))
3341 return nullptr;
3342 }
3343
Roman Lebedev72b8d412019-07-01 15:55:15 +00003344 // Can we fold (XShAmt+YShAmt) ?
Roman Lebedev96474d12019-08-10 19:29:10 +00003345 Value *NewShAmt = SimplifyAddInst(XShAmt, YShAmt, /*IsNSW=*/false,
3346 /*IsNUW=*/false, SQ.getWithInstruction(&I));
Roman Lebedev72b8d412019-07-01 15:55:15 +00003347 if (!NewShAmt)
3348 return nullptr;
3349 // Is the new shift amount smaller than the bit width?
3350 // FIXME: could also rely on ConstantRange.
3351 unsigned BitWidth = X->getType()->getScalarSizeInBits();
Roman Lebedevc5f92bd2019-07-10 16:07:35 +00003352 if (!match(NewShAmt, m_SpecificInt_ICMP(ICmpInst::Predicate::ICMP_ULT,
3353 APInt(BitWidth, BitWidth))))
Roman Lebedev72b8d412019-07-01 15:55:15 +00003354 return nullptr;
3355 // All good, we can do this fold. The shift is the same that was for X.
3356 Value *T0 = XShiftOpcode == Instruction::BinaryOps::LShr
3357 ? Builder.CreateLShr(X, NewShAmt)
3358 : Builder.CreateShl(X, NewShAmt);
3359 Value *T1 = Builder.CreateAnd(T0, Y);
3360 return Builder.CreateICmp(I.getPredicate(), T1,
3361 Constant::getNullValue(X->getType()));
3362}
3363
Sanjay Patel10494b22016-09-16 16:10:22 +00003364/// Try to fold icmp (binop), X or icmp X, (binop).
Sanjay Patel2df38a82017-05-08 16:21:55 +00003365/// TODO: A large part of this logic is duplicated in InstSimplify's
3366/// simplifyICmpWithBinOp(). We should be able to share that and avoid the code
3367/// duplication.
Sanjay Patel10494b22016-09-16 16:10:22 +00003368Instruction *InstCombiner::foldICmpBinOp(ICmpInst &I) {
3369 Value *Op0 = I.getOperand(0), *Op1 = I.getOperand(1);
3370
3371 // Special logic for binary operators.
3372 BinaryOperator *BO0 = dyn_cast<BinaryOperator>(Op0);
3373 BinaryOperator *BO1 = dyn_cast<BinaryOperator>(Op1);
3374 if (!BO0 && !BO1)
3375 return nullptr;
3376
Sanjay Patel2a062632017-05-08 16:33:42 +00003377 const CmpInst::Predicate Pred = I.getPredicate();
Sanjay Patel1cf07342018-09-11 22:40:20 +00003378 Value *X;
3379
3380 // Convert add-with-unsigned-overflow comparisons into a 'not' with compare.
3381 // (Op1 + X) <u Op1 --> ~Op1 <u X
3382 // Op0 >u (Op0 + X) --> X >u ~Op0
3383 if (match(Op0, m_OneUse(m_c_Add(m_Specific(Op1), m_Value(X)))) &&
3384 Pred == ICmpInst::ICMP_ULT)
3385 return new ICmpInst(Pred, Builder.CreateNot(Op1), X);
3386 if (match(Op1, m_OneUse(m_c_Add(m_Specific(Op0), m_Value(X)))) &&
3387 Pred == ICmpInst::ICMP_UGT)
3388 return new ICmpInst(Pred, X, Builder.CreateNot(Op0));
3389
Sanjay Patel10494b22016-09-16 16:10:22 +00003390 bool NoOp0WrapProblem = false, NoOp1WrapProblem = false;
3391 if (BO0 && isa<OverflowingBinaryOperator>(BO0))
3392 NoOp0WrapProblem =
3393 ICmpInst::isEquality(Pred) ||
3394 (CmpInst::isUnsigned(Pred) && BO0->hasNoUnsignedWrap()) ||
3395 (CmpInst::isSigned(Pred) && BO0->hasNoSignedWrap());
3396 if (BO1 && isa<OverflowingBinaryOperator>(BO1))
3397 NoOp1WrapProblem =
3398 ICmpInst::isEquality(Pred) ||
3399 (CmpInst::isUnsigned(Pred) && BO1->hasNoUnsignedWrap()) ||
3400 (CmpInst::isSigned(Pred) && BO1->hasNoSignedWrap());
3401
3402 // Analyze the case when either Op0 or Op1 is an add instruction.
3403 // Op0 = A + B (or A and B are null); Op1 = C + D (or C and D are null).
3404 Value *A = nullptr, *B = nullptr, *C = nullptr, *D = nullptr;
3405 if (BO0 && BO0->getOpcode() == Instruction::Add) {
3406 A = BO0->getOperand(0);
3407 B = BO0->getOperand(1);
3408 }
3409 if (BO1 && BO1->getOpcode() == Instruction::Add) {
3410 C = BO1->getOperand(0);
3411 D = BO1->getOperand(1);
3412 }
3413
Sanjay Patel10494b22016-09-16 16:10:22 +00003414 // icmp (X+Y), X -> icmp Y, 0 for equalities or if there is no overflow.
3415 if ((A == Op1 || B == Op1) && NoOp0WrapProblem)
3416 return new ICmpInst(Pred, A == Op1 ? B : A,
3417 Constant::getNullValue(Op1->getType()));
3418
3419 // icmp X, (X+Y) -> icmp 0, Y for equalities or if there is no overflow.
3420 if ((C == Op0 || D == Op0) && NoOp1WrapProblem)
3421 return new ICmpInst(Pred, Constant::getNullValue(Op0->getType()),
3422 C == Op0 ? D : C);
3423
3424 // icmp (X+Y), (X+Z) -> icmp Y, Z for equalities or if there is no overflow.
3425 if (A && C && (A == C || A == D || B == C || B == D) && NoOp0WrapProblem &&
3426 NoOp1WrapProblem &&
3427 // Try not to increase register pressure.
3428 BO0->hasOneUse() && BO1->hasOneUse()) {
3429 // Determine Y and Z in the form icmp (X+Y), (X+Z).
3430 Value *Y, *Z;
3431 if (A == C) {
3432 // C + B == C + D -> B == D
3433 Y = B;
3434 Z = D;
3435 } else if (A == D) {
3436 // D + B == C + D -> B == C
3437 Y = B;
3438 Z = C;
3439 } else if (B == C) {
3440 // A + C == C + D -> A == D
3441 Y = A;
3442 Z = D;
3443 } else {
3444 assert(B == D);
3445 // A + D == C + D -> A == C
3446 Y = A;
3447 Z = C;
3448 }
3449 return new ICmpInst(Pred, Y, Z);
3450 }
3451
3452 // icmp slt (X + -1), Y -> icmp sle X, Y
3453 if (A && NoOp0WrapProblem && Pred == CmpInst::ICMP_SLT &&
3454 match(B, m_AllOnes()))
3455 return new ICmpInst(CmpInst::ICMP_SLE, A, Op1);
3456
3457 // icmp sge (X + -1), Y -> icmp sgt X, Y
3458 if (A && NoOp0WrapProblem && Pred == CmpInst::ICMP_SGE &&
3459 match(B, m_AllOnes()))
3460 return new ICmpInst(CmpInst::ICMP_SGT, A, Op1);
3461
3462 // icmp sle (X + 1), Y -> icmp slt X, Y
3463 if (A && NoOp0WrapProblem && Pred == CmpInst::ICMP_SLE && match(B, m_One()))
3464 return new ICmpInst(CmpInst::ICMP_SLT, A, Op1);
3465
3466 // icmp sgt (X + 1), Y -> icmp sge X, Y
3467 if (A && NoOp0WrapProblem && Pred == CmpInst::ICMP_SGT && match(B, m_One()))
3468 return new ICmpInst(CmpInst::ICMP_SGE, A, Op1);
3469
3470 // icmp sgt X, (Y + -1) -> icmp sge X, Y
3471 if (C && NoOp1WrapProblem && Pred == CmpInst::ICMP_SGT &&
3472 match(D, m_AllOnes()))
3473 return new ICmpInst(CmpInst::ICMP_SGE, Op0, C);
3474
3475 // icmp sle X, (Y + -1) -> icmp slt X, Y
3476 if (C && NoOp1WrapProblem && Pred == CmpInst::ICMP_SLE &&
3477 match(D, m_AllOnes()))
3478 return new ICmpInst(CmpInst::ICMP_SLT, Op0, C);
3479
3480 // icmp sge X, (Y + 1) -> icmp sgt X, Y
3481 if (C && NoOp1WrapProblem && Pred == CmpInst::ICMP_SGE && match(D, m_One()))
3482 return new ICmpInst(CmpInst::ICMP_SGT, Op0, C);
3483
3484 // icmp slt X, (Y + 1) -> icmp sle X, Y
3485 if (C && NoOp1WrapProblem && Pred == CmpInst::ICMP_SLT && match(D, m_One()))
3486 return new ICmpInst(CmpInst::ICMP_SLE, Op0, C);
3487
Sanjay Patel40f40172017-01-13 23:25:46 +00003488 // TODO: The subtraction-related identities shown below also hold, but
3489 // canonicalization from (X -nuw 1) to (X + -1) means that the combinations
3490 // wouldn't happen even if they were implemented.
3491 //
3492 // icmp ult (X - 1), Y -> icmp ule X, Y
3493 // icmp uge (X - 1), Y -> icmp ugt X, Y
3494 // icmp ugt X, (Y - 1) -> icmp uge X, Y
3495 // icmp ule X, (Y - 1) -> icmp ult X, Y
3496
3497 // icmp ule (X + 1), Y -> icmp ult X, Y
3498 if (A && NoOp0WrapProblem && Pred == CmpInst::ICMP_ULE && match(B, m_One()))
3499 return new ICmpInst(CmpInst::ICMP_ULT, A, Op1);
3500
3501 // icmp ugt (X + 1), Y -> icmp uge X, Y
3502 if (A && NoOp0WrapProblem && Pred == CmpInst::ICMP_UGT && match(B, m_One()))
3503 return new ICmpInst(CmpInst::ICMP_UGE, A, Op1);
3504
3505 // icmp uge X, (Y + 1) -> icmp ugt X, Y
3506 if (C && NoOp1WrapProblem && Pred == CmpInst::ICMP_UGE && match(D, m_One()))
3507 return new ICmpInst(CmpInst::ICMP_UGT, Op0, C);
3508
3509 // icmp ult X, (Y + 1) -> icmp ule X, Y
3510 if (C && NoOp1WrapProblem && Pred == CmpInst::ICMP_ULT && match(D, m_One()))
3511 return new ICmpInst(CmpInst::ICMP_ULE, Op0, C);
3512
Sanjay Patel10494b22016-09-16 16:10:22 +00003513 // if C1 has greater magnitude than C2:
3514 // icmp (X + C1), (Y + C2) -> icmp (X + C3), Y
3515 // s.t. C3 = C1 - C2
3516 //
3517 // if C2 has greater magnitude than C1:
3518 // icmp (X + C1), (Y + C2) -> icmp X, (Y + C3)
3519 // s.t. C3 = C2 - C1
3520 if (A && C && NoOp0WrapProblem && NoOp1WrapProblem &&
3521 (BO0->hasOneUse() || BO1->hasOneUse()) && !I.isUnsigned())
3522 if (ConstantInt *C1 = dyn_cast<ConstantInt>(B))
3523 if (ConstantInt *C2 = dyn_cast<ConstantInt>(D)) {
3524 const APInt &AP1 = C1->getValue();
3525 const APInt &AP2 = C2->getValue();
3526 if (AP1.isNegative() == AP2.isNegative()) {
3527 APInt AP1Abs = C1->getValue().abs();
3528 APInt AP2Abs = C2->getValue().abs();
3529 if (AP1Abs.uge(AP2Abs)) {
Craig Topperbb4069e2017-07-07 23:16:26 +00003530 ConstantInt *C3 = Builder.getInt(AP1 - AP2);
3531 Value *NewAdd = Builder.CreateNSWAdd(A, C3);
Sanjay Patel10494b22016-09-16 16:10:22 +00003532 return new ICmpInst(Pred, NewAdd, C);
3533 } else {
Craig Topperbb4069e2017-07-07 23:16:26 +00003534 ConstantInt *C3 = Builder.getInt(AP2 - AP1);
3535 Value *NewAdd = Builder.CreateNSWAdd(C, C3);
Sanjay Patel10494b22016-09-16 16:10:22 +00003536 return new ICmpInst(Pred, A, NewAdd);
3537 }
3538 }
3539 }
3540
3541 // Analyze the case when either Op0 or Op1 is a sub instruction.
3542 // Op0 = A - B (or A and B are null); Op1 = C - D (or C and D are null).
3543 A = nullptr;
3544 B = nullptr;
3545 C = nullptr;
3546 D = nullptr;
3547 if (BO0 && BO0->getOpcode() == Instruction::Sub) {
3548 A = BO0->getOperand(0);
3549 B = BO0->getOperand(1);
3550 }
3551 if (BO1 && BO1->getOpcode() == Instruction::Sub) {
3552 C = BO1->getOperand(0);
3553 D = BO1->getOperand(1);
3554 }
3555
3556 // icmp (X-Y), X -> icmp 0, Y for equalities or if there is no overflow.
3557 if (A == Op1 && NoOp0WrapProblem)
3558 return new ICmpInst(Pred, Constant::getNullValue(Op1->getType()), B);
Sanjay Patel10494b22016-09-16 16:10:22 +00003559 // icmp X, (X-Y) -> icmp Y, 0 for equalities or if there is no overflow.
3560 if (C == Op0 && NoOp1WrapProblem)
3561 return new ICmpInst(Pred, D, Constant::getNullValue(Op0->getType()));
3562
Sanjay Patelcbb04502018-04-02 20:37:40 +00003563 // (A - B) >u A --> A <u B
3564 if (A == Op1 && Pred == ICmpInst::ICMP_UGT)
3565 return new ICmpInst(ICmpInst::ICMP_ULT, A, B);
3566 // C <u (C - D) --> C <u D
3567 if (C == Op0 && Pred == ICmpInst::ICMP_ULT)
3568 return new ICmpInst(ICmpInst::ICMP_ULT, C, D);
3569
Sanjay Patel10494b22016-09-16 16:10:22 +00003570 // icmp (Y-X), (Z-X) -> icmp Y, Z for equalities or if there is no overflow.
3571 if (B && D && B == D && NoOp0WrapProblem && NoOp1WrapProblem &&
3572 // Try not to increase register pressure.
3573 BO0->hasOneUse() && BO1->hasOneUse())
3574 return new ICmpInst(Pred, A, C);
Sanjay Patel10494b22016-09-16 16:10:22 +00003575 // icmp (X-Y), (X-Z) -> icmp Z, Y for equalities or if there is no overflow.
3576 if (A && C && A == C && NoOp0WrapProblem && NoOp1WrapProblem &&
3577 // Try not to increase register pressure.
3578 BO0->hasOneUse() && BO1->hasOneUse())
3579 return new ICmpInst(Pred, D, B);
3580
3581 // icmp (0-X) < cst --> x > -cst
3582 if (NoOp0WrapProblem && ICmpInst::isSigned(Pred)) {
3583 Value *X;
3584 if (match(BO0, m_Neg(m_Value(X))))
Chen Zhengb9722732018-07-16 00:51:40 +00003585 if (Constant *RHSC = dyn_cast<Constant>(Op1))
3586 if (RHSC->isNotMinSignedValue())
Sanjay Patel10494b22016-09-16 16:10:22 +00003587 return new ICmpInst(I.getSwappedPredicate(), X,
3588 ConstantExpr::getNeg(RHSC));
3589 }
3590
3591 BinaryOperator *SRem = nullptr;
3592 // icmp (srem X, Y), Y
3593 if (BO0 && BO0->getOpcode() == Instruction::SRem && Op1 == BO0->getOperand(1))
3594 SRem = BO0;
3595 // icmp Y, (srem X, Y)
3596 else if (BO1 && BO1->getOpcode() == Instruction::SRem &&
3597 Op0 == BO1->getOperand(1))
3598 SRem = BO1;
3599 if (SRem) {
3600 // We don't check hasOneUse to avoid increasing register pressure because
3601 // the value we use is the same value this instruction was already using.
3602 switch (SRem == BO0 ? ICmpInst::getSwappedPredicate(Pred) : Pred) {
3603 default:
3604 break;
3605 case ICmpInst::ICMP_EQ:
3606 return replaceInstUsesWith(I, ConstantInt::getFalse(I.getType()));
3607 case ICmpInst::ICMP_NE:
3608 return replaceInstUsesWith(I, ConstantInt::getTrue(I.getType()));
3609 case ICmpInst::ICMP_SGT:
3610 case ICmpInst::ICMP_SGE:
3611 return new ICmpInst(ICmpInst::ICMP_SGT, SRem->getOperand(1),
3612 Constant::getAllOnesValue(SRem->getType()));
3613 case ICmpInst::ICMP_SLT:
3614 case ICmpInst::ICMP_SLE:
3615 return new ICmpInst(ICmpInst::ICMP_SLT, SRem->getOperand(1),
3616 Constant::getNullValue(SRem->getType()));
3617 }
3618 }
3619
3620 if (BO0 && BO1 && BO0->getOpcode() == BO1->getOpcode() && BO0->hasOneUse() &&
3621 BO1->hasOneUse() && BO0->getOperand(1) == BO1->getOperand(1)) {
3622 switch (BO0->getOpcode()) {
3623 default:
3624 break;
3625 case Instruction::Add:
3626 case Instruction::Sub:
Sanjay Pateld3106ad2017-05-23 17:29:58 +00003627 case Instruction::Xor: {
Sanjay Patel10494b22016-09-16 16:10:22 +00003628 if (I.isEquality()) // a+x icmp eq/ne b+x --> a icmp b
Sanjay Patel2a062632017-05-08 16:33:42 +00003629 return new ICmpInst(Pred, BO0->getOperand(0), BO1->getOperand(0));
Sanjay Pateld3106ad2017-05-23 17:29:58 +00003630
3631 const APInt *C;
3632 if (match(BO0->getOperand(1), m_APInt(C))) {
3633 // icmp u/s (a ^ signmask), (b ^ signmask) --> icmp s/u a, b
3634 if (C->isSignMask()) {
Sanjay Patel2a062632017-05-08 16:33:42 +00003635 ICmpInst::Predicate NewPred =
Sanjay Patel10494b22016-09-16 16:10:22 +00003636 I.isSigned() ? I.getUnsignedPredicate() : I.getSignedPredicate();
Sanjay Patel2a062632017-05-08 16:33:42 +00003637 return new ICmpInst(NewPred, BO0->getOperand(0), BO1->getOperand(0));
Sanjay Patel10494b22016-09-16 16:10:22 +00003638 }
3639
Sanjay Pateld3106ad2017-05-23 17:29:58 +00003640 // icmp u/s (a ^ maxsignval), (b ^ maxsignval) --> icmp s/u' a, b
3641 if (BO0->getOpcode() == Instruction::Xor && C->isMaxSignedValue()) {
Sanjay Patel2a062632017-05-08 16:33:42 +00003642 ICmpInst::Predicate NewPred =
Sanjay Patel10494b22016-09-16 16:10:22 +00003643 I.isSigned() ? I.getUnsignedPredicate() : I.getSignedPredicate();
Sanjay Patel2a062632017-05-08 16:33:42 +00003644 NewPred = I.getSwappedPredicate(NewPred);
3645 return new ICmpInst(NewPred, BO0->getOperand(0), BO1->getOperand(0));
Sanjay Patel10494b22016-09-16 16:10:22 +00003646 }
3647 }
3648 break;
Sanjay Pateld3106ad2017-05-23 17:29:58 +00003649 }
Sanjay Patel07b1ba52017-05-24 22:58:17 +00003650 case Instruction::Mul: {
Sanjay Patel10494b22016-09-16 16:10:22 +00003651 if (!I.isEquality())
3652 break;
3653
Sanjay Patel07b1ba52017-05-24 22:58:17 +00003654 const APInt *C;
Craig Topper73ba1c82017-06-07 07:40:37 +00003655 if (match(BO0->getOperand(1), m_APInt(C)) && !C->isNullValue() &&
3656 !C->isOneValue()) {
Sanjay Patel07b1ba52017-05-24 22:58:17 +00003657 // icmp eq/ne (X * C), (Y * C) --> icmp (X & Mask), (Y & Mask)
3658 // Mask = -1 >> count-trailing-zeros(C).
Sanjay Patel51506122017-05-25 14:13:57 +00003659 if (unsigned TZs = C->countTrailingZeros()) {
Sanjay Patel07b1ba52017-05-24 22:58:17 +00003660 Constant *Mask = ConstantInt::get(
3661 BO0->getType(),
Sanjay Patel51506122017-05-25 14:13:57 +00003662 APInt::getLowBitsSet(C->getBitWidth(), C->getBitWidth() - TZs));
Craig Topperbb4069e2017-07-07 23:16:26 +00003663 Value *And1 = Builder.CreateAnd(BO0->getOperand(0), Mask);
3664 Value *And2 = Builder.CreateAnd(BO1->getOperand(0), Mask);
Sanjay Patel2a062632017-05-08 16:33:42 +00003665 return new ICmpInst(Pred, And1, And2);
Sanjay Patel10494b22016-09-16 16:10:22 +00003666 }
Sanjay Patel51506122017-05-25 14:13:57 +00003667 // If there are no trailing zeros in the multiplier, just eliminate
3668 // the multiplies (no masking is needed):
3669 // icmp eq/ne (X * C), (Y * C) --> icmp eq/ne X, Y
3670 return new ICmpInst(Pred, BO0->getOperand(0), BO1->getOperand(0));
Sanjay Patel10494b22016-09-16 16:10:22 +00003671 }
3672 break;
Sanjay Patel07b1ba52017-05-24 22:58:17 +00003673 }
Sanjay Patel10494b22016-09-16 16:10:22 +00003674 case Instruction::UDiv:
3675 case Instruction::LShr:
Sanjay Patel878715f2017-05-15 19:27:53 +00003676 if (I.isSigned() || !BO0->isExact() || !BO1->isExact())
Sanjay Patel10494b22016-09-16 16:10:22 +00003677 break;
Sanjay Patel878715f2017-05-15 19:27:53 +00003678 return new ICmpInst(Pred, BO0->getOperand(0), BO1->getOperand(0));
3679
Sanjay Patel10494b22016-09-16 16:10:22 +00003680 case Instruction::SDiv:
Sanjay Patel878715f2017-05-15 19:27:53 +00003681 if (!I.isEquality() || !BO0->isExact() || !BO1->isExact())
3682 break;
3683 return new ICmpInst(Pred, BO0->getOperand(0), BO1->getOperand(0));
3684
Sanjay Patel10494b22016-09-16 16:10:22 +00003685 case Instruction::AShr:
3686 if (!BO0->isExact() || !BO1->isExact())
3687 break;
Sanjay Patel2a062632017-05-08 16:33:42 +00003688 return new ICmpInst(Pred, BO0->getOperand(0), BO1->getOperand(0));
Sanjay Patel878715f2017-05-15 19:27:53 +00003689
Sanjay Patel10494b22016-09-16 16:10:22 +00003690 case Instruction::Shl: {
3691 bool NUW = BO0->hasNoUnsignedWrap() && BO1->hasNoUnsignedWrap();
3692 bool NSW = BO0->hasNoSignedWrap() && BO1->hasNoSignedWrap();
3693 if (!NUW && !NSW)
3694 break;
3695 if (!NSW && I.isSigned())
3696 break;
Sanjay Patel2a062632017-05-08 16:33:42 +00003697 return new ICmpInst(Pred, BO0->getOperand(0), BO1->getOperand(0));
Sanjay Patel10494b22016-09-16 16:10:22 +00003698 }
3699 }
3700 }
3701
3702 if (BO0) {
3703 // Transform A & (L - 1) `ult` L --> L != 0
3704 auto LSubOne = m_Add(m_Specific(Op1), m_AllOnes());
Craig Topper72ee6942017-06-24 06:24:01 +00003705 auto BitwiseAnd = m_c_And(m_Value(), LSubOne);
Sanjay Patel10494b22016-09-16 16:10:22 +00003706
Sanjay Patel2a062632017-05-08 16:33:42 +00003707 if (match(BO0, BitwiseAnd) && Pred == ICmpInst::ICMP_ULT) {
Sanjay Patel10494b22016-09-16 16:10:22 +00003708 auto *Zero = Constant::getNullValue(BO0->getType());
3709 return new ICmpInst(ICmpInst::ICMP_NE, Op1, Zero);
3710 }
3711 }
3712
Roman Lebedev68d54cf2018-07-11 19:05:04 +00003713 if (Value *V = foldICmpWithLowBitMaskedVal(I, Builder))
3714 return replaceInstUsesWith(I, V);
3715
Roman Lebedev3cb87e92018-07-18 10:55:17 +00003716 if (Value *V = foldICmpWithTruncSignExtendedVal(I, Builder))
3717 return replaceInstUsesWith(I, V);
3718
Roman Lebedev72b8d412019-07-01 15:55:15 +00003719 if (Value *V = foldShiftIntoShiftInAnotherHandOfAndInICmp(I, SQ, Builder))
3720 return replaceInstUsesWith(I, V);
3721
Sanjay Patel10494b22016-09-16 16:10:22 +00003722 return nullptr;
3723}
3724
Sanjay Pateldd46b522016-12-19 17:32:37 +00003725/// Fold icmp Pred min|max(X, Y), X.
3726static Instruction *foldICmpWithMinMax(ICmpInst &Cmp) {
Sanjay Pateld6406412016-12-15 19:13:37 +00003727 ICmpInst::Predicate Pred = Cmp.getPredicate();
3728 Value *Op0 = Cmp.getOperand(0);
3729 Value *X = Cmp.getOperand(1);
3730
Sanjay Pateldd46b522016-12-19 17:32:37 +00003731 // Canonicalize minimum or maximum operand to LHS of the icmp.
Sanjay Patel8296c6c2016-12-19 16:28:53 +00003732 if (match(X, m_c_SMin(m_Specific(Op0), m_Value())) ||
Sanjay Pateldd46b522016-12-19 17:32:37 +00003733 match(X, m_c_SMax(m_Specific(Op0), m_Value())) ||
3734 match(X, m_c_UMin(m_Specific(Op0), m_Value())) ||
3735 match(X, m_c_UMax(m_Specific(Op0), m_Value()))) {
Sanjay Pateld6406412016-12-15 19:13:37 +00003736 std::swap(Op0, X);
3737 Pred = Cmp.getSwappedPredicate();
3738 }
3739
3740 Value *Y;
Sanjay Patel8296c6c2016-12-19 16:28:53 +00003741 if (match(Op0, m_c_SMin(m_Specific(X), m_Value(Y)))) {
Sanjay Pateldd46b522016-12-19 17:32:37 +00003742 // smin(X, Y) == X --> X s<= Y
3743 // smin(X, Y) s>= X --> X s<= Y
Sanjay Patel8296c6c2016-12-19 16:28:53 +00003744 if (Pred == CmpInst::ICMP_EQ || Pred == CmpInst::ICMP_SGE)
3745 return new ICmpInst(ICmpInst::ICMP_SLE, X, Y);
3746
Sanjay Pateldd46b522016-12-19 17:32:37 +00003747 // smin(X, Y) != X --> X s> Y
3748 // smin(X, Y) s< X --> X s> Y
Sanjay Patel8296c6c2016-12-19 16:28:53 +00003749 if (Pred == CmpInst::ICMP_NE || Pred == CmpInst::ICMP_SLT)
3750 return new ICmpInst(ICmpInst::ICMP_SGT, X, Y);
3751
3752 // These cases should be handled in InstSimplify:
Sanjay Pateldd46b522016-12-19 17:32:37 +00003753 // smin(X, Y) s<= X --> true
3754 // smin(X, Y) s> X --> false
Sanjay Pateld6406412016-12-15 19:13:37 +00003755 return nullptr;
Sanjay Patel8296c6c2016-12-19 16:28:53 +00003756 }
Sanjay Pateldd46b522016-12-19 17:32:37 +00003757
Sanjay Patel8296c6c2016-12-19 16:28:53 +00003758 if (match(Op0, m_c_SMax(m_Specific(X), m_Value(Y)))) {
Sanjay Pateldd46b522016-12-19 17:32:37 +00003759 // smax(X, Y) == X --> X s>= Y
3760 // smax(X, Y) s<= X --> X s>= Y
Sanjay Patel8296c6c2016-12-19 16:28:53 +00003761 if (Pred == CmpInst::ICMP_EQ || Pred == CmpInst::ICMP_SLE)
3762 return new ICmpInst(ICmpInst::ICMP_SGE, X, Y);
Sanjay Pateld6406412016-12-15 19:13:37 +00003763
Sanjay Pateldd46b522016-12-19 17:32:37 +00003764 // smax(X, Y) != X --> X s< Y
3765 // smax(X, Y) s> X --> X s< Y
Sanjay Patel8296c6c2016-12-19 16:28:53 +00003766 if (Pred == CmpInst::ICMP_NE || Pred == CmpInst::ICMP_SGT)
3767 return new ICmpInst(ICmpInst::ICMP_SLT, X, Y);
Sanjay Pateld6406412016-12-15 19:13:37 +00003768
Sanjay Patel8296c6c2016-12-19 16:28:53 +00003769 // These cases should be handled in InstSimplify:
Sanjay Pateldd46b522016-12-19 17:32:37 +00003770 // smax(X, Y) s>= X --> true
3771 // smax(X, Y) s< X --> false
3772 return nullptr;
3773 }
3774
3775 if (match(Op0, m_c_UMin(m_Specific(X), m_Value(Y)))) {
3776 // umin(X, Y) == X --> X u<= Y
3777 // umin(X, Y) u>= X --> X u<= Y
3778 if (Pred == CmpInst::ICMP_EQ || Pred == CmpInst::ICMP_UGE)
3779 return new ICmpInst(ICmpInst::ICMP_ULE, X, Y);
3780
3781 // umin(X, Y) != X --> X u> Y
3782 // umin(X, Y) u< X --> X u> Y
3783 if (Pred == CmpInst::ICMP_NE || Pred == CmpInst::ICMP_ULT)
3784 return new ICmpInst(ICmpInst::ICMP_UGT, X, Y);
3785
3786 // These cases should be handled in InstSimplify:
3787 // umin(X, Y) u<= X --> true
3788 // umin(X, Y) u> X --> false
3789 return nullptr;
3790 }
3791
3792 if (match(Op0, m_c_UMax(m_Specific(X), m_Value(Y)))) {
3793 // umax(X, Y) == X --> X u>= Y
3794 // umax(X, Y) u<= X --> X u>= Y
3795 if (Pred == CmpInst::ICMP_EQ || Pred == CmpInst::ICMP_ULE)
3796 return new ICmpInst(ICmpInst::ICMP_UGE, X, Y);
3797
3798 // umax(X, Y) != X --> X u< Y
3799 // umax(X, Y) u> X --> X u< Y
3800 if (Pred == CmpInst::ICMP_NE || Pred == CmpInst::ICMP_UGT)
3801 return new ICmpInst(ICmpInst::ICMP_ULT, X, Y);
3802
3803 // These cases should be handled in InstSimplify:
3804 // umax(X, Y) u>= X --> true
3805 // umax(X, Y) u< X --> false
Sanjay Patel8296c6c2016-12-19 16:28:53 +00003806 return nullptr;
3807 }
Sanjay Pateld6406412016-12-15 19:13:37 +00003808
Sanjay Pateld6406412016-12-15 19:13:37 +00003809 return nullptr;
3810}
3811
Sanjay Patel10494b22016-09-16 16:10:22 +00003812Instruction *InstCombiner::foldICmpEquality(ICmpInst &I) {
3813 if (!I.isEquality())
3814 return nullptr;
3815
3816 Value *Op0 = I.getOperand(0), *Op1 = I.getOperand(1);
Sanjay Patel4e96f192017-06-28 16:39:06 +00003817 const CmpInst::Predicate Pred = I.getPredicate();
Sanjay Patel10494b22016-09-16 16:10:22 +00003818 Value *A, *B, *C, *D;
3819 if (match(Op0, m_Xor(m_Value(A), m_Value(B)))) {
3820 if (A == Op1 || B == Op1) { // (A^B) == A -> B == 0
3821 Value *OtherVal = A == Op1 ? B : A;
Sanjay Patel4e96f192017-06-28 16:39:06 +00003822 return new ICmpInst(Pred, OtherVal, Constant::getNullValue(A->getType()));
Sanjay Patel10494b22016-09-16 16:10:22 +00003823 }
3824
3825 if (match(Op1, m_Xor(m_Value(C), m_Value(D)))) {
3826 // A^c1 == C^c2 --> A == C^(c1^c2)
3827 ConstantInt *C1, *C2;
3828 if (match(B, m_ConstantInt(C1)) && match(D, m_ConstantInt(C2)) &&
3829 Op1->hasOneUse()) {
Craig Topperbb4069e2017-07-07 23:16:26 +00003830 Constant *NC = Builder.getInt(C1->getValue() ^ C2->getValue());
3831 Value *Xor = Builder.CreateXor(C, NC);
Sanjay Patel4e96f192017-06-28 16:39:06 +00003832 return new ICmpInst(Pred, A, Xor);
Sanjay Patel10494b22016-09-16 16:10:22 +00003833 }
3834
3835 // A^B == A^D -> B == D
3836 if (A == C)
Sanjay Patel4e96f192017-06-28 16:39:06 +00003837 return new ICmpInst(Pred, B, D);
Sanjay Patel10494b22016-09-16 16:10:22 +00003838 if (A == D)
Sanjay Patel4e96f192017-06-28 16:39:06 +00003839 return new ICmpInst(Pred, B, C);
Sanjay Patel10494b22016-09-16 16:10:22 +00003840 if (B == C)
Sanjay Patel4e96f192017-06-28 16:39:06 +00003841 return new ICmpInst(Pred, A, D);
Sanjay Patel10494b22016-09-16 16:10:22 +00003842 if (B == D)
Sanjay Patel4e96f192017-06-28 16:39:06 +00003843 return new ICmpInst(Pred, A, C);
Sanjay Patel10494b22016-09-16 16:10:22 +00003844 }
3845 }
3846
3847 if (match(Op1, m_Xor(m_Value(A), m_Value(B))) && (A == Op0 || B == Op0)) {
3848 // A == (A^B) -> B == 0
3849 Value *OtherVal = A == Op0 ? B : A;
Sanjay Patel4e96f192017-06-28 16:39:06 +00003850 return new ICmpInst(Pred, OtherVal, Constant::getNullValue(A->getType()));
Sanjay Patel10494b22016-09-16 16:10:22 +00003851 }
3852
3853 // (X&Z) == (Y&Z) -> (X^Y) & Z == 0
3854 if (match(Op0, m_OneUse(m_And(m_Value(A), m_Value(B)))) &&
3855 match(Op1, m_OneUse(m_And(m_Value(C), m_Value(D))))) {
3856 Value *X = nullptr, *Y = nullptr, *Z = nullptr;
3857
3858 if (A == C) {
3859 X = B;
3860 Y = D;
3861 Z = A;
3862 } else if (A == D) {
3863 X = B;
3864 Y = C;
3865 Z = A;
3866 } else if (B == C) {
3867 X = A;
3868 Y = D;
3869 Z = B;
3870 } else if (B == D) {
3871 X = A;
3872 Y = C;
3873 Z = B;
3874 }
3875
3876 if (X) { // Build (X^Y) & Z
Craig Topperbb4069e2017-07-07 23:16:26 +00003877 Op1 = Builder.CreateXor(X, Y);
3878 Op1 = Builder.CreateAnd(Op1, Z);
Sanjay Patel10494b22016-09-16 16:10:22 +00003879 I.setOperand(0, Op1);
3880 I.setOperand(1, Constant::getNullValue(Op1->getType()));
3881 return &I;
3882 }
3883 }
3884
3885 // Transform (zext A) == (B & (1<<X)-1) --> A == (trunc B)
3886 // and (B & (1<<X)-1) == (zext A) --> A == (trunc B)
3887 ConstantInt *Cst1;
3888 if ((Op0->hasOneUse() && match(Op0, m_ZExt(m_Value(A))) &&
3889 match(Op1, m_And(m_Value(B), m_ConstantInt(Cst1)))) ||
3890 (Op1->hasOneUse() && match(Op0, m_And(m_Value(B), m_ConstantInt(Cst1))) &&
3891 match(Op1, m_ZExt(m_Value(A))))) {
3892 APInt Pow2 = Cst1->getValue() + 1;
3893 if (Pow2.isPowerOf2() && isa<IntegerType>(A->getType()) &&
3894 Pow2.logBase2() == cast<IntegerType>(A->getType())->getBitWidth())
Craig Topperbb4069e2017-07-07 23:16:26 +00003895 return new ICmpInst(Pred, A, Builder.CreateTrunc(B, A->getType()));
Sanjay Patel10494b22016-09-16 16:10:22 +00003896 }
3897
3898 // (A >> C) == (B >> C) --> (A^B) u< (1 << C)
3899 // For lshr and ashr pairs.
3900 if ((match(Op0, m_OneUse(m_LShr(m_Value(A), m_ConstantInt(Cst1)))) &&
3901 match(Op1, m_OneUse(m_LShr(m_Value(B), m_Specific(Cst1))))) ||
3902 (match(Op0, m_OneUse(m_AShr(m_Value(A), m_ConstantInt(Cst1)))) &&
3903 match(Op1, m_OneUse(m_AShr(m_Value(B), m_Specific(Cst1)))))) {
3904 unsigned TypeBits = Cst1->getBitWidth();
3905 unsigned ShAmt = (unsigned)Cst1->getLimitedValue(TypeBits);
3906 if (ShAmt < TypeBits && ShAmt != 0) {
Sanjay Patel4e96f192017-06-28 16:39:06 +00003907 ICmpInst::Predicate NewPred =
3908 Pred == ICmpInst::ICMP_NE ? ICmpInst::ICMP_UGE : ICmpInst::ICMP_ULT;
Craig Topperbb4069e2017-07-07 23:16:26 +00003909 Value *Xor = Builder.CreateXor(A, B, I.getName() + ".unshifted");
Sanjay Patel10494b22016-09-16 16:10:22 +00003910 APInt CmpVal = APInt::getOneBitSet(TypeBits, ShAmt);
Craig Topperbb4069e2017-07-07 23:16:26 +00003911 return new ICmpInst(NewPred, Xor, Builder.getInt(CmpVal));
Sanjay Patel10494b22016-09-16 16:10:22 +00003912 }
3913 }
3914
3915 // (A << C) == (B << C) --> ((A^B) & (~0U >> C)) == 0
3916 if (match(Op0, m_OneUse(m_Shl(m_Value(A), m_ConstantInt(Cst1)))) &&
3917 match(Op1, m_OneUse(m_Shl(m_Value(B), m_Specific(Cst1))))) {
3918 unsigned TypeBits = Cst1->getBitWidth();
3919 unsigned ShAmt = (unsigned)Cst1->getLimitedValue(TypeBits);
3920 if (ShAmt < TypeBits && ShAmt != 0) {
Craig Topperbb4069e2017-07-07 23:16:26 +00003921 Value *Xor = Builder.CreateXor(A, B, I.getName() + ".unshifted");
Sanjay Patel10494b22016-09-16 16:10:22 +00003922 APInt AndVal = APInt::getLowBitsSet(TypeBits, TypeBits - ShAmt);
Craig Topperbb4069e2017-07-07 23:16:26 +00003923 Value *And = Builder.CreateAnd(Xor, Builder.getInt(AndVal),
Sanjay Patel10494b22016-09-16 16:10:22 +00003924 I.getName() + ".mask");
Sanjay Patel4e96f192017-06-28 16:39:06 +00003925 return new ICmpInst(Pred, And, Constant::getNullValue(Cst1->getType()));
Sanjay Patel10494b22016-09-16 16:10:22 +00003926 }
3927 }
3928
3929 // Transform "icmp eq (trunc (lshr(X, cst1)), cst" to
3930 // "icmp (and X, mask), cst"
3931 uint64_t ShAmt = 0;
3932 if (Op0->hasOneUse() &&
3933 match(Op0, m_Trunc(m_OneUse(m_LShr(m_Value(A), m_ConstantInt(ShAmt))))) &&
3934 match(Op1, m_ConstantInt(Cst1)) &&
3935 // Only do this when A has multiple uses. This is most important to do
3936 // when it exposes other optimizations.
3937 !A->hasOneUse()) {
3938 unsigned ASize = cast<IntegerType>(A->getType())->getPrimitiveSizeInBits();
3939
3940 if (ShAmt < ASize) {
3941 APInt MaskV =
3942 APInt::getLowBitsSet(ASize, Op0->getType()->getPrimitiveSizeInBits());
3943 MaskV <<= ShAmt;
3944
3945 APInt CmpV = Cst1->getValue().zext(ASize);
3946 CmpV <<= ShAmt;
3947
Craig Topperbb4069e2017-07-07 23:16:26 +00003948 Value *Mask = Builder.CreateAnd(A, Builder.getInt(MaskV));
3949 return new ICmpInst(Pred, Mask, Builder.getInt(CmpV));
Sanjay Patel10494b22016-09-16 16:10:22 +00003950 }
3951 }
3952
Sanjay Patelc3d5cf02017-07-02 14:34:50 +00003953 // If both operands are byte-swapped or bit-reversed, just compare the
3954 // original values.
3955 // TODO: Move this to a function similar to foldICmpIntrinsicWithConstant()
3956 // and handle more intrinsics.
3957 if ((match(Op0, m_BSwap(m_Value(A))) && match(Op1, m_BSwap(m_Value(B)))) ||
Simon Pilgrimdf2657a2017-07-02 16:31:16 +00003958 (match(Op0, m_BitReverse(m_Value(A))) &&
3959 match(Op1, m_BitReverse(m_Value(B)))))
Sanjay Patelc3d5cf02017-07-02 14:34:50 +00003960 return new ICmpInst(Pred, A, B);
3961
Sanjay Patel63311bf2019-06-20 17:41:15 +00003962 // Canonicalize checking for a power-of-2-or-zero value:
Sanjay Patelddc1b402019-07-01 22:00:00 +00003963 // (A & (A-1)) == 0 --> ctpop(A) < 2 (two commuted variants)
3964 // ((A-1) & A) != 0 --> ctpop(A) > 1 (two commuted variants)
3965 if (!match(Op0, m_OneUse(m_c_And(m_Add(m_Value(A), m_AllOnes()),
3966 m_Deferred(A)))) ||
3967 !match(Op1, m_ZeroInt()))
3968 A = nullptr;
3969
Sanjay Patelfcfa0562019-06-25 18:51:44 +00003970 // (A & -A) == A --> ctpop(A) < 2 (four commuted variants)
3971 // (-A & A) != A --> ctpop(A) > 1 (four commuted variants)
Sanjay Patelfcfa0562019-06-25 18:51:44 +00003972 if (match(Op0, m_OneUse(m_c_And(m_Neg(m_Specific(Op1)), m_Specific(Op1)))))
Sanjay Patel63311bf2019-06-20 17:41:15 +00003973 A = Op1;
Sanjay Patelfcfa0562019-06-25 18:51:44 +00003974 else if (match(Op1,
3975 m_OneUse(m_c_And(m_Neg(m_Specific(Op0)), m_Specific(Op0)))))
Sanjay Patel63311bf2019-06-20 17:41:15 +00003976 A = Op0;
Sanjay Patelfcfa0562019-06-25 18:51:44 +00003977
Sanjay Patel63311bf2019-06-20 17:41:15 +00003978 if (A) {
3979 Type *Ty = A->getType();
Sanjay Patelfcfa0562019-06-25 18:51:44 +00003980 CallInst *CtPop = Builder.CreateUnaryIntrinsic(Intrinsic::ctpop, A);
3981 return Pred == ICmpInst::ICMP_EQ
3982 ? new ICmpInst(ICmpInst::ICMP_ULT, CtPop, ConstantInt::get(Ty, 2))
3983 : new ICmpInst(ICmpInst::ICMP_UGT, CtPop, ConstantInt::get(Ty, 1));
Sanjay Patel63311bf2019-06-20 17:41:15 +00003984 }
3985
Sanjay Patel10494b22016-09-16 16:10:22 +00003986 return nullptr;
3987}
3988
Sanjay Patel6f8f47b2016-06-05 00:12:32 +00003989/// Handle icmp (cast x to y), (cast/cst). We only handle extending casts so
3990/// far.
Sanjay Patel43395062016-07-21 18:07:40 +00003991Instruction *InstCombiner::foldICmpWithCastAndCast(ICmpInst &ICmp) {
Sanjay Patel6f8f47b2016-06-05 00:12:32 +00003992 const CastInst *LHSCI = cast<CastInst>(ICmp.getOperand(0));
Chris Lattner2188e402010-01-04 07:37:31 +00003993 Value *LHSCIOp = LHSCI->getOperand(0);
Chris Lattner229907c2011-07-18 04:54:35 +00003994 Type *SrcTy = LHSCIOp->getType();
3995 Type *DestTy = LHSCI->getType();
Chris Lattner2188e402010-01-04 07:37:31 +00003996
Jim Grosbach129c52a2011-09-30 18:09:53 +00003997 // Turn icmp (ptrtoint x), (ptrtoint/c) into a compare of the input if the
Chris Lattner2188e402010-01-04 07:37:31 +00003998 // integer type is the same size as the pointer type.
Daniel Neilsonbdda1152018-03-05 18:05:51 +00003999 const auto& CompatibleSizes = [&](Type* SrcTy, Type* DestTy) -> bool {
4000 if (isa<VectorType>(SrcTy)) {
4001 SrcTy = cast<VectorType>(SrcTy)->getElementType();
4002 DestTy = cast<VectorType>(DestTy)->getElementType();
4003 }
4004 return DL.getPointerTypeSizeInBits(SrcTy) == DestTy->getIntegerBitWidth();
4005 };
Mehdi Aminia28d91d2015-03-10 02:37:25 +00004006 if (LHSCI->getOpcode() == Instruction::PtrToInt &&
Daniel Neilsonbdda1152018-03-05 18:05:51 +00004007 CompatibleSizes(SrcTy, DestTy)) {
Craig Topperf40110f2014-04-25 05:29:35 +00004008 Value *RHSOp = nullptr;
Sanjay Patel6f8f47b2016-06-05 00:12:32 +00004009 if (auto *RHSC = dyn_cast<PtrToIntOperator>(ICmp.getOperand(1))) {
Michael Liaod266b922015-02-13 04:51:26 +00004010 Value *RHSCIOp = RHSC->getOperand(0);
4011 if (RHSCIOp->getType()->getPointerAddressSpace() ==
4012 LHSCIOp->getType()->getPointerAddressSpace()) {
4013 RHSOp = RHSC->getOperand(0);
4014 // If the pointer types don't match, insert a bitcast.
4015 if (LHSCIOp->getType() != RHSOp->getType())
Craig Topperbb4069e2017-07-07 23:16:26 +00004016 RHSOp = Builder.CreateBitCast(RHSOp, LHSCIOp->getType());
Michael Liaod266b922015-02-13 04:51:26 +00004017 }
Sanjay Patel6f8f47b2016-06-05 00:12:32 +00004018 } else if (auto *RHSC = dyn_cast<Constant>(ICmp.getOperand(1))) {
Chris Lattner2188e402010-01-04 07:37:31 +00004019 RHSOp = ConstantExpr::getIntToPtr(RHSC, SrcTy);
Sanjay Patel6f8f47b2016-06-05 00:12:32 +00004020 }
Chris Lattner2188e402010-01-04 07:37:31 +00004021
4022 if (RHSOp)
Sanjay Patel6f8f47b2016-06-05 00:12:32 +00004023 return new ICmpInst(ICmp.getPredicate(), LHSCIOp, RHSOp);
Chris Lattner2188e402010-01-04 07:37:31 +00004024 }
Jim Grosbach129c52a2011-09-30 18:09:53 +00004025
Chris Lattner2188e402010-01-04 07:37:31 +00004026 // The code below only handles extension cast instructions, so far.
4027 // Enforce this.
4028 if (LHSCI->getOpcode() != Instruction::ZExt &&
4029 LHSCI->getOpcode() != Instruction::SExt)
Craig Topperf40110f2014-04-25 05:29:35 +00004030 return nullptr;
Chris Lattner2188e402010-01-04 07:37:31 +00004031
4032 bool isSignedExt = LHSCI->getOpcode() == Instruction::SExt;
Sanjay Patel6f8f47b2016-06-05 00:12:32 +00004033 bool isSignedCmp = ICmp.isSigned();
Chris Lattner2188e402010-01-04 07:37:31 +00004034
Sanjay Patel6f8f47b2016-06-05 00:12:32 +00004035 if (auto *CI = dyn_cast<CastInst>(ICmp.getOperand(1))) {
Chris Lattner2188e402010-01-04 07:37:31 +00004036 // Not an extension from the same type?
Simon Pilgrim7a2e8552019-05-05 10:27:45 +00004037 Value *RHSCIOp = CI->getOperand(0);
Jim Grosbach129c52a2011-09-30 18:09:53 +00004038 if (RHSCIOp->getType() != LHSCIOp->getType())
Craig Topperf40110f2014-04-25 05:29:35 +00004039 return nullptr;
Jim Grosbach129c52a2011-09-30 18:09:53 +00004040
Chris Lattner2188e402010-01-04 07:37:31 +00004041 // If the signedness of the two casts doesn't agree (i.e. one is a sext
4042 // and the other is a zext), then we can't handle this.
4043 if (CI->getOpcode() != LHSCI->getOpcode())
Craig Topperf40110f2014-04-25 05:29:35 +00004044 return nullptr;
Chris Lattner2188e402010-01-04 07:37:31 +00004045
4046 // Deal with equality cases early.
Sanjay Patel6f8f47b2016-06-05 00:12:32 +00004047 if (ICmp.isEquality())
4048 return new ICmpInst(ICmp.getPredicate(), LHSCIOp, RHSCIOp);
Chris Lattner2188e402010-01-04 07:37:31 +00004049
4050 // A signed comparison of sign extended values simplifies into a
4051 // signed comparison.
4052 if (isSignedCmp && isSignedExt)
Sanjay Patel6f8f47b2016-06-05 00:12:32 +00004053 return new ICmpInst(ICmp.getPredicate(), LHSCIOp, RHSCIOp);
Chris Lattner2188e402010-01-04 07:37:31 +00004054
4055 // The other three cases all fold into an unsigned comparison.
Sanjay Patel6f8f47b2016-06-05 00:12:32 +00004056 return new ICmpInst(ICmp.getUnsignedPredicate(), LHSCIOp, RHSCIOp);
Chris Lattner2188e402010-01-04 07:37:31 +00004057 }
4058
Sanjay Patel4c204232016-06-04 20:39:22 +00004059 // If we aren't dealing with a constant on the RHS, exit early.
Sanjay Patel6f8f47b2016-06-05 00:12:32 +00004060 auto *C = dyn_cast<Constant>(ICmp.getOperand(1));
4061 if (!C)
Craig Topperf40110f2014-04-25 05:29:35 +00004062 return nullptr;
Chris Lattner2188e402010-01-04 07:37:31 +00004063
4064 // Compute the constant that would happen if we truncated to SrcTy then
Sanjay Patelc774f8c2016-06-04 21:20:44 +00004065 // re-extended to DestTy.
Sanjay Patel6f8f47b2016-06-05 00:12:32 +00004066 Constant *Res1 = ConstantExpr::getTrunc(C, SrcTy);
Sanjay Patelc774f8c2016-06-04 21:20:44 +00004067 Constant *Res2 = ConstantExpr::getCast(LHSCI->getOpcode(), Res1, DestTy);
Chris Lattner2188e402010-01-04 07:37:31 +00004068
4069 // If the re-extended constant didn't change...
Sanjay Patel6f8f47b2016-06-05 00:12:32 +00004070 if (Res2 == C) {
Chris Lattner2188e402010-01-04 07:37:31 +00004071 // Deal with equality cases early.
Sanjay Patel6f8f47b2016-06-05 00:12:32 +00004072 if (ICmp.isEquality())
4073 return new ICmpInst(ICmp.getPredicate(), LHSCIOp, Res1);
Chris Lattner2188e402010-01-04 07:37:31 +00004074
4075 // A signed comparison of sign extended values simplifies into a
4076 // signed comparison.
4077 if (isSignedExt && isSignedCmp)
Sanjay Patel6f8f47b2016-06-05 00:12:32 +00004078 return new ICmpInst(ICmp.getPredicate(), LHSCIOp, Res1);
Chris Lattner2188e402010-01-04 07:37:31 +00004079
4080 // The other three cases all fold into an unsigned comparison.
Sanjay Patel6f8f47b2016-06-05 00:12:32 +00004081 return new ICmpInst(ICmp.getUnsignedPredicate(), LHSCIOp, Res1);
Chris Lattner2188e402010-01-04 07:37:31 +00004082 }
4083
Sanjay Patel6a333c32016-06-06 16:56:57 +00004084 // The re-extended constant changed, partly changed (in the case of a vector),
4085 // or could not be determined to be equal (in the case of a constant
4086 // expression), so the constant cannot be represented in the shorter type.
4087 // Consequently, we cannot emit a simple comparison.
Duncan Sands8fb2c382011-01-20 13:21:55 +00004088 // All the cases that fold to true or false will have already been handled
4089 // by SimplifyICmpInst, so only deal with the tricky case.
Chris Lattner2188e402010-01-04 07:37:31 +00004090
Sanjay Patel6a333c32016-06-06 16:56:57 +00004091 if (isSignedCmp || !isSignedExt || !isa<ConstantInt>(C))
Craig Topperf40110f2014-04-25 05:29:35 +00004092 return nullptr;
Chris Lattner2188e402010-01-04 07:37:31 +00004093
4094 // Evaluate the comparison for LT (we invert for GT below). LE and GE cases
4095 // should have been folded away previously and not enter in here.
Duncan Sands8fb2c382011-01-20 13:21:55 +00004096
4097 // We're performing an unsigned comp with a sign extended value.
4098 // This is true if the input is >= 0. [aka >s -1]
4099 Constant *NegOne = Constant::getAllOnesValue(SrcTy);
Craig Topperbb4069e2017-07-07 23:16:26 +00004100 Value *Result = Builder.CreateICmpSGT(LHSCIOp, NegOne, ICmp.getName());
Chris Lattner2188e402010-01-04 07:37:31 +00004101
4102 // Finally, return the value computed.
Sanjay Patel6f8f47b2016-06-05 00:12:32 +00004103 if (ICmp.getPredicate() == ICmpInst::ICMP_ULT)
4104 return replaceInstUsesWith(ICmp, Result);
Chris Lattner2188e402010-01-04 07:37:31 +00004105
Sanjay Patel6f8f47b2016-06-05 00:12:32 +00004106 assert(ICmp.getPredicate() == ICmpInst::ICMP_UGT && "ICmp should be folded!");
Chris Lattner2188e402010-01-04 07:37:31 +00004107 return BinaryOperator::CreateNot(Result);
4108}
4109
Nikita Popov39f2beb2019-05-26 11:43:37 +00004110static bool isNeutralValue(Instruction::BinaryOps BinaryOp, Value *RHS) {
4111 switch (BinaryOp) {
4112 default:
4113 llvm_unreachable("Unsupported binary op");
4114 case Instruction::Add:
4115 case Instruction::Sub:
4116 return match(RHS, m_Zero());
4117 case Instruction::Mul:
4118 return match(RHS, m_One());
4119 }
4120}
4121
4122OverflowResult InstCombiner::computeOverflow(
4123 Instruction::BinaryOps BinaryOp, bool IsSigned,
4124 Value *LHS, Value *RHS, Instruction *CxtI) const {
4125 switch (BinaryOp) {
4126 default:
4127 llvm_unreachable("Unsupported binary op");
4128 case Instruction::Add:
4129 if (IsSigned)
4130 return computeOverflowForSignedAdd(LHS, RHS, CxtI);
4131 else
4132 return computeOverflowForUnsignedAdd(LHS, RHS, CxtI);
4133 case Instruction::Sub:
4134 if (IsSigned)
4135 return computeOverflowForSignedSub(LHS, RHS, CxtI);
4136 else
4137 return computeOverflowForUnsignedSub(LHS, RHS, CxtI);
4138 case Instruction::Mul:
4139 if (IsSigned)
4140 return computeOverflowForSignedMul(LHS, RHS, CxtI);
4141 else
4142 return computeOverflowForUnsignedMul(LHS, RHS, CxtI);
4143 }
4144}
4145
Nikita Popov352f5982019-05-26 11:43:31 +00004146bool InstCombiner::OptimizeOverflowCheck(
4147 Instruction::BinaryOps BinaryOp, bool IsSigned, Value *LHS, Value *RHS,
4148 Instruction &OrigI, Value *&Result, Constant *&Overflow) {
Sanjoy Das827529e2015-08-11 21:33:55 +00004149 if (OrigI.isCommutative() && isa<Constant>(LHS) && !isa<Constant>(RHS))
4150 std::swap(LHS, RHS);
Sanjoy Dasb0984472015-04-08 04:27:22 +00004151
Sanjoy Das6f5dca72015-08-28 19:09:31 +00004152 // If the overflow check was an add followed by a compare, the insertion point
4153 // may be pointing to the compare. We want to insert the new instructions
4154 // before the add in case there are uses of the add between the add and the
4155 // compare.
Craig Topperbb4069e2017-07-07 23:16:26 +00004156 Builder.SetInsertPoint(&OrigI);
Sanjoy Das6f5dca72015-08-28 19:09:31 +00004157
Nikita Popov39f2beb2019-05-26 11:43:37 +00004158 if (isNeutralValue(BinaryOp, RHS)) {
4159 Result = LHS;
4160 Overflow = Builder.getFalse();
4161 return true;
Sanjoy Dasb0984472015-04-08 04:27:22 +00004162 }
4163
Nikita Popov39f2beb2019-05-26 11:43:37 +00004164 switch (computeOverflow(BinaryOp, IsSigned, LHS, RHS, &OrigI)) {
4165 case OverflowResult::MayOverflow:
4166 return false;
Nikita Popov332c1002019-05-28 18:08:31 +00004167 case OverflowResult::AlwaysOverflowsLow:
4168 case OverflowResult::AlwaysOverflowsHigh:
Nikita Popov39f2beb2019-05-26 11:43:37 +00004169 Result = Builder.CreateBinOp(BinaryOp, LHS, RHS);
4170 Result->takeName(&OrigI);
4171 Overflow = Builder.getTrue();
4172 return true;
4173 case OverflowResult::NeverOverflows:
4174 Result = Builder.CreateBinOp(BinaryOp, LHS, RHS);
4175 Result->takeName(&OrigI);
4176 Overflow = Builder.getFalse();
4177 if (auto *Inst = dyn_cast<Instruction>(Result)) {
4178 if (IsSigned)
4179 Inst->setHasNoSignedWrap();
4180 else
4181 Inst->setHasNoUnsignedWrap();
4182 }
4183 return true;
Sanjoy Dasb0984472015-04-08 04:27:22 +00004184 }
4185
Nikita Popov39f2beb2019-05-26 11:43:37 +00004186 llvm_unreachable("Unexpected overflow result");
Sanjoy Dasb0984472015-04-08 04:27:22 +00004187}
4188
Adrian Prantl5f8f34e42018-05-01 15:54:18 +00004189/// Recognize and process idiom involving test for multiplication
Serge Pavlov4bb54d52014-04-13 18:23:41 +00004190/// overflow.
4191///
4192/// The caller has matched a pattern of the form:
4193/// I = cmp u (mul(zext A, zext B), V
4194/// The function checks if this is a test for overflow and if so replaces
4195/// multiplication with call to 'mul.with.overflow' intrinsic.
4196///
4197/// \param I Compare instruction.
4198/// \param MulVal Result of 'mult' instruction. It is one of the arguments of
4199/// the compare instruction. Must be of integer type.
4200/// \param OtherVal The other argument of compare instruction.
4201/// \returns Instruction which must replace the compare instruction, NULL if no
4202/// replacement required.
Sanjay Pateld93c4c02016-09-15 18:22:25 +00004203static Instruction *processUMulZExtIdiom(ICmpInst &I, Value *MulVal,
Serge Pavlov4bb54d52014-04-13 18:23:41 +00004204 Value *OtherVal, InstCombiner &IC) {
Benjamin Kramerc96a7f82014-06-24 10:47:52 +00004205 // Don't bother doing this transformation for pointers, don't do it for
4206 // vectors.
4207 if (!isa<IntegerType>(MulVal->getType()))
4208 return nullptr;
4209
Serge Pavlov4bb54d52014-04-13 18:23:41 +00004210 assert(I.getOperand(0) == MulVal || I.getOperand(1) == MulVal);
4211 assert(I.getOperand(0) == OtherVal || I.getOperand(1) == OtherVal);
David Majnemerdaa24b92015-09-05 20:44:56 +00004212 auto *MulInstr = dyn_cast<Instruction>(MulVal);
4213 if (!MulInstr)
4214 return nullptr;
Serge Pavlov4bb54d52014-04-13 18:23:41 +00004215 assert(MulInstr->getOpcode() == Instruction::Mul);
4216
David Majnemer634ca232014-11-01 23:46:05 +00004217 auto *LHS = cast<ZExtOperator>(MulInstr->getOperand(0)),
4218 *RHS = cast<ZExtOperator>(MulInstr->getOperand(1));
Serge Pavlov4bb54d52014-04-13 18:23:41 +00004219 assert(LHS->getOpcode() == Instruction::ZExt);
4220 assert(RHS->getOpcode() == Instruction::ZExt);
4221 Value *A = LHS->getOperand(0), *B = RHS->getOperand(0);
4222
4223 // Calculate type and width of the result produced by mul.with.overflow.
4224 Type *TyA = A->getType(), *TyB = B->getType();
4225 unsigned WidthA = TyA->getPrimitiveSizeInBits(),
4226 WidthB = TyB->getPrimitiveSizeInBits();
4227 unsigned MulWidth;
4228 Type *MulType;
4229 if (WidthB > WidthA) {
4230 MulWidth = WidthB;
4231 MulType = TyB;
4232 } else {
4233 MulWidth = WidthA;
4234 MulType = TyA;
4235 }
4236
4237 // In order to replace the original mul with a narrower mul.with.overflow,
4238 // all uses must ignore upper bits of the product. The number of used low
4239 // bits must be not greater than the width of mul.with.overflow.
4240 if (MulVal->hasNUsesOrMore(2))
4241 for (User *U : MulVal->users()) {
4242 if (U == &I)
4243 continue;
4244 if (TruncInst *TI = dyn_cast<TruncInst>(U)) {
4245 // Check if truncation ignores bits above MulWidth.
4246 unsigned TruncWidth = TI->getType()->getPrimitiveSizeInBits();
4247 if (TruncWidth > MulWidth)
Craig Topperf40110f2014-04-25 05:29:35 +00004248 return nullptr;
Serge Pavlov4bb54d52014-04-13 18:23:41 +00004249 } else if (BinaryOperator *BO = dyn_cast<BinaryOperator>(U)) {
4250 // Check if AND ignores bits above MulWidth.
4251 if (BO->getOpcode() != Instruction::And)
Craig Topperf40110f2014-04-25 05:29:35 +00004252 return nullptr;
Serge Pavlov4bb54d52014-04-13 18:23:41 +00004253 if (ConstantInt *CI = dyn_cast<ConstantInt>(BO->getOperand(1))) {
4254 const APInt &CVal = CI->getValue();
4255 if (CVal.getBitWidth() - CVal.countLeadingZeros() > MulWidth)
Craig Topperf40110f2014-04-25 05:29:35 +00004256 return nullptr;
Davide Italiano579064e2017-07-16 18:56:30 +00004257 } else {
4258 // In this case we could have the operand of the binary operation
4259 // being defined in another block, and performing the replacement
4260 // could break the dominance relation.
4261 return nullptr;
Serge Pavlov4bb54d52014-04-13 18:23:41 +00004262 }
4263 } else {
4264 // Other uses prohibit this transformation.
Craig Topperf40110f2014-04-25 05:29:35 +00004265 return nullptr;
Serge Pavlov4bb54d52014-04-13 18:23:41 +00004266 }
4267 }
4268
4269 // Recognize patterns
4270 switch (I.getPredicate()) {
4271 case ICmpInst::ICMP_EQ:
4272 case ICmpInst::ICMP_NE:
4273 // Recognize pattern:
4274 // mulval = mul(zext A, zext B)
4275 // cmp eq/neq mulval, zext trunc mulval
4276 if (ZExtInst *Zext = dyn_cast<ZExtInst>(OtherVal))
4277 if (Zext->hasOneUse()) {
4278 Value *ZextArg = Zext->getOperand(0);
4279 if (TruncInst *Trunc = dyn_cast<TruncInst>(ZextArg))
4280 if (Trunc->getType()->getPrimitiveSizeInBits() == MulWidth)
4281 break; //Recognized
4282 }
4283
4284 // Recognize pattern:
4285 // mulval = mul(zext A, zext B)
4286 // cmp eq/neq mulval, and(mulval, mask), mask selects low MulWidth bits.
4287 ConstantInt *CI;
4288 Value *ValToMask;
4289 if (match(OtherVal, m_And(m_Value(ValToMask), m_ConstantInt(CI)))) {
4290 if (ValToMask != MulVal)
Craig Topperf40110f2014-04-25 05:29:35 +00004291 return nullptr;
Serge Pavlov4bb54d52014-04-13 18:23:41 +00004292 const APInt &CVal = CI->getValue() + 1;
4293 if (CVal.isPowerOf2()) {
4294 unsigned MaskWidth = CVal.logBase2();
4295 if (MaskWidth == MulWidth)
4296 break; // Recognized
4297 }
4298 }
Craig Topperf40110f2014-04-25 05:29:35 +00004299 return nullptr;
Serge Pavlov4bb54d52014-04-13 18:23:41 +00004300
4301 case ICmpInst::ICMP_UGT:
4302 // Recognize pattern:
4303 // mulval = mul(zext A, zext B)
4304 // cmp ugt mulval, max
4305 if (ConstantInt *CI = dyn_cast<ConstantInt>(OtherVal)) {
4306 APInt MaxVal = APInt::getMaxValue(MulWidth);
4307 MaxVal = MaxVal.zext(CI->getBitWidth());
4308 if (MaxVal.eq(CI->getValue()))
4309 break; // Recognized
4310 }
Craig Topperf40110f2014-04-25 05:29:35 +00004311 return nullptr;
Serge Pavlov4bb54d52014-04-13 18:23:41 +00004312
4313 case ICmpInst::ICMP_UGE:
4314 // Recognize pattern:
4315 // mulval = mul(zext A, zext B)
4316 // cmp uge mulval, max+1
4317 if (ConstantInt *CI = dyn_cast<ConstantInt>(OtherVal)) {
4318 APInt MaxVal = APInt::getOneBitSet(CI->getBitWidth(), MulWidth);
4319 if (MaxVal.eq(CI->getValue()))
4320 break; // Recognized
4321 }
Craig Topperf40110f2014-04-25 05:29:35 +00004322 return nullptr;
Serge Pavlov4bb54d52014-04-13 18:23:41 +00004323
4324 case ICmpInst::ICMP_ULE:
4325 // Recognize pattern:
4326 // mulval = mul(zext A, zext B)
4327 // cmp ule mulval, max
4328 if (ConstantInt *CI = dyn_cast<ConstantInt>(OtherVal)) {
4329 APInt MaxVal = APInt::getMaxValue(MulWidth);
4330 MaxVal = MaxVal.zext(CI->getBitWidth());
4331 if (MaxVal.eq(CI->getValue()))
4332 break; // Recognized
4333 }
Craig Topperf40110f2014-04-25 05:29:35 +00004334 return nullptr;
Serge Pavlov4bb54d52014-04-13 18:23:41 +00004335
4336 case ICmpInst::ICMP_ULT:
4337 // Recognize pattern:
4338 // mulval = mul(zext A, zext B)
4339 // cmp ule mulval, max + 1
4340 if (ConstantInt *CI = dyn_cast<ConstantInt>(OtherVal)) {
Serge Pavlovb5f3ddc2014-04-14 02:20:19 +00004341 APInt MaxVal = APInt::getOneBitSet(CI->getBitWidth(), MulWidth);
Serge Pavlov4bb54d52014-04-13 18:23:41 +00004342 if (MaxVal.eq(CI->getValue()))
4343 break; // Recognized
4344 }
Craig Topperf40110f2014-04-25 05:29:35 +00004345 return nullptr;
Serge Pavlov4bb54d52014-04-13 18:23:41 +00004346
4347 default:
Craig Topperf40110f2014-04-25 05:29:35 +00004348 return nullptr;
Serge Pavlov4bb54d52014-04-13 18:23:41 +00004349 }
4350
Craig Topperbb4069e2017-07-07 23:16:26 +00004351 InstCombiner::BuilderTy &Builder = IC.Builder;
4352 Builder.SetInsertPoint(MulInstr);
Serge Pavlov4bb54d52014-04-13 18:23:41 +00004353
4354 // Replace: mul(zext A, zext B) --> mul.with.overflow(A, B)
4355 Value *MulA = A, *MulB = B;
4356 if (WidthA < MulWidth)
Craig Topperbb4069e2017-07-07 23:16:26 +00004357 MulA = Builder.CreateZExt(A, MulType);
Serge Pavlov4bb54d52014-04-13 18:23:41 +00004358 if (WidthB < MulWidth)
Craig Topperbb4069e2017-07-07 23:16:26 +00004359 MulB = Builder.CreateZExt(B, MulType);
James Y Knight7976eb52019-02-01 20:43:25 +00004360 Function *F = Intrinsic::getDeclaration(
4361 I.getModule(), Intrinsic::umul_with_overflow, MulType);
Craig Topperbb4069e2017-07-07 23:16:26 +00004362 CallInst *Call = Builder.CreateCall(F, {MulA, MulB}, "umul");
Serge Pavlov4bb54d52014-04-13 18:23:41 +00004363 IC.Worklist.Add(MulInstr);
4364
4365 // If there are uses of mul result other than the comparison, we know that
4366 // they are truncation or binary AND. Change them to use result of
Serge Pavlovb5f3ddc2014-04-14 02:20:19 +00004367 // mul.with.overflow and adjust properly mask/size.
Serge Pavlov4bb54d52014-04-13 18:23:41 +00004368 if (MulVal->hasNUsesOrMore(2)) {
Craig Topperbb4069e2017-07-07 23:16:26 +00004369 Value *Mul = Builder.CreateExtractValue(Call, 0, "umul.value");
Joseph Tremoulet6f406d42018-06-15 16:52:40 +00004370 for (auto UI = MulVal->user_begin(), UE = MulVal->user_end(); UI != UE;) {
4371 User *U = *UI++;
Serge Pavlov4bb54d52014-04-13 18:23:41 +00004372 if (U == &I || U == OtherVal)
4373 continue;
4374 if (TruncInst *TI = dyn_cast<TruncInst>(U)) {
4375 if (TI->getType()->getPrimitiveSizeInBits() == MulWidth)
Sanjay Patel4b198802016-02-01 22:23:39 +00004376 IC.replaceInstUsesWith(*TI, Mul);
Serge Pavlov4bb54d52014-04-13 18:23:41 +00004377 else
4378 TI->setOperand(0, Mul);
4379 } else if (BinaryOperator *BO = dyn_cast<BinaryOperator>(U)) {
4380 assert(BO->getOpcode() == Instruction::And);
4381 // Replace (mul & mask) --> zext (mul.with.overflow & short_mask)
Davide Italiano579064e2017-07-16 18:56:30 +00004382 ConstantInt *CI = cast<ConstantInt>(BO->getOperand(1));
4383 APInt ShortMask = CI->getValue().trunc(MulWidth);
Craig Topperbb4069e2017-07-07 23:16:26 +00004384 Value *ShortAnd = Builder.CreateAnd(Mul, ShortMask);
Davide Italiano579064e2017-07-16 18:56:30 +00004385 Instruction *Zext =
4386 cast<Instruction>(Builder.CreateZExt(ShortAnd, BO->getType()));
4387 IC.Worklist.Add(Zext);
Sanjay Patel4b198802016-02-01 22:23:39 +00004388 IC.replaceInstUsesWith(*BO, Zext);
Serge Pavlov4bb54d52014-04-13 18:23:41 +00004389 } else {
4390 llvm_unreachable("Unexpected Binary operation");
4391 }
Davide Italiano579064e2017-07-16 18:56:30 +00004392 IC.Worklist.Add(cast<Instruction>(U));
Serge Pavlov4bb54d52014-04-13 18:23:41 +00004393 }
4394 }
4395 if (isa<Instruction>(OtherVal))
4396 IC.Worklist.Add(cast<Instruction>(OtherVal));
4397
4398 // The original icmp gets replaced with the overflow value, maybe inverted
4399 // depending on predicate.
4400 bool Inverse = false;
4401 switch (I.getPredicate()) {
4402 case ICmpInst::ICMP_NE:
4403 break;
4404 case ICmpInst::ICMP_EQ:
4405 Inverse = true;
4406 break;
4407 case ICmpInst::ICMP_UGT:
4408 case ICmpInst::ICMP_UGE:
4409 if (I.getOperand(0) == MulVal)
4410 break;
4411 Inverse = true;
4412 break;
4413 case ICmpInst::ICMP_ULT:
4414 case ICmpInst::ICMP_ULE:
4415 if (I.getOperand(1) == MulVal)
4416 break;
4417 Inverse = true;
4418 break;
4419 default:
4420 llvm_unreachable("Unexpected predicate");
4421 }
4422 if (Inverse) {
Craig Topperbb4069e2017-07-07 23:16:26 +00004423 Value *Res = Builder.CreateExtractValue(Call, 1);
Serge Pavlov4bb54d52014-04-13 18:23:41 +00004424 return BinaryOperator::CreateNot(Res);
4425 }
4426
4427 return ExtractValueInst::Create(Call, 1);
4428}
4429
Sanjay Patel5f0217f2016-06-05 16:46:18 +00004430/// When performing a comparison against a constant, it is possible that not all
4431/// the bits in the LHS are demanded. This helper method computes the mask that
4432/// IS demanded.
Craig Topper3edda872017-09-22 18:57:23 +00004433static APInt getDemandedBitsLHSMask(ICmpInst &I, unsigned BitWidth) {
Craig Topper18887bf2017-09-20 23:48:58 +00004434 const APInt *RHS;
4435 if (!match(I.getOperand(1), m_APInt(RHS)))
4436 return APInt::getAllOnesValue(BitWidth);
Jim Grosbach129c52a2011-09-30 18:09:53 +00004437
Craig Topper3edda872017-09-22 18:57:23 +00004438 // If this is a normal comparison, it demands all bits. If it is a sign bit
4439 // comparison, it only demands the sign bit.
4440 bool UnusedBit;
4441 if (isSignBitCheck(I.getPredicate(), *RHS, UnusedBit))
4442 return APInt::getSignMask(BitWidth);
4443
Owen Andersond490c2d2011-01-11 00:36:45 +00004444 switch (I.getPredicate()) {
Jim Grosbach129c52a2011-09-30 18:09:53 +00004445 // For a UGT comparison, we don't care about any bits that
Owen Andersond490c2d2011-01-11 00:36:45 +00004446 // correspond to the trailing ones of the comparand. The value of these
4447 // bits doesn't impact the outcome of the comparison, because any value
4448 // greater than the RHS must differ in a bit higher than these due to carry.
Craig Topper18887bf2017-09-20 23:48:58 +00004449 case ICmpInst::ICMP_UGT:
4450 return APInt::getBitsSetFrom(BitWidth, RHS->countTrailingOnes());
Jim Grosbach129c52a2011-09-30 18:09:53 +00004451
Owen Andersond490c2d2011-01-11 00:36:45 +00004452 // Similarly, for a ULT comparison, we don't care about the trailing zeros.
4453 // Any value less than the RHS must differ in a higher bit because of carries.
Craig Topper18887bf2017-09-20 23:48:58 +00004454 case ICmpInst::ICMP_ULT:
4455 return APInt::getBitsSetFrom(BitWidth, RHS->countTrailingZeros());
Jim Grosbach129c52a2011-09-30 18:09:53 +00004456
Owen Andersond490c2d2011-01-11 00:36:45 +00004457 default:
4458 return APInt::getAllOnesValue(BitWidth);
4459 }
Owen Andersond490c2d2011-01-11 00:36:45 +00004460}
Chris Lattner2188e402010-01-04 07:37:31 +00004461
Sanjay Patel4ccae1c2018-02-02 18:39:05 +00004462/// Check if the order of \p Op0 and \p Op1 as operands in an ICmpInst
Quentin Colombet5ab55552013-09-09 20:56:48 +00004463/// should be swapped.
Alp Tokercb402912014-01-24 17:20:08 +00004464/// The decision is based on how many times these two operands are reused
Quentin Colombet5ab55552013-09-09 20:56:48 +00004465/// as subtract operands and their positions in those instructions.
Sanjay Patel4ccae1c2018-02-02 18:39:05 +00004466/// The rationale is that several architectures use the same instruction for
4467/// both subtract and cmp. Thus, it is better if the order of those operands
Quentin Colombet5ab55552013-09-09 20:56:48 +00004468/// match.
4469/// \return true if Op0 and Op1 should be swapped.
Sanjay Patel4ccae1c2018-02-02 18:39:05 +00004470static bool swapMayExposeCSEOpportunities(const Value *Op0, const Value *Op1) {
4471 // Filter out pointer values as those cannot appear directly in subtract.
Quentin Colombet5ab55552013-09-09 20:56:48 +00004472 // FIXME: we may want to go through inttoptrs or bitcasts.
4473 if (Op0->getType()->isPointerTy())
4474 return false;
Sanjay Patel1ea86972018-02-02 19:08:12 +00004475 // If a subtract already has the same operands as a compare, swapping would be
4476 // bad. If a subtract has the same operands as a compare but in reverse order,
4477 // then swapping is good.
4478 int GoodToSwap = 0;
Chandler Carruthcdf47882014-03-09 03:16:01 +00004479 for (const User *U : Op0->users()) {
Sanjay Patel1ea86972018-02-02 19:08:12 +00004480 if (match(U, m_Sub(m_Specific(Op1), m_Specific(Op0))))
4481 GoodToSwap++;
4482 else if (match(U, m_Sub(m_Specific(Op0), m_Specific(Op1))))
4483 GoodToSwap--;
Quentin Colombet5ab55552013-09-09 20:56:48 +00004484 }
Sanjay Patel1ea86972018-02-02 19:08:12 +00004485 return GoodToSwap > 0;
Quentin Colombet5ab55552013-09-09 20:56:48 +00004486}
4487
Adrian Prantl5f8f34e42018-05-01 15:54:18 +00004488/// Check that one use is in the same block as the definition and all
Sanjay Patel53523312016-09-12 14:25:46 +00004489/// other uses are in blocks dominated by a given block.
Gerolf Hoflehnerec6217c2014-11-21 23:36:44 +00004490///
4491/// \param DI Definition
4492/// \param UI Use
4493/// \param DB Block that must dominate all uses of \p DI outside
4494/// the parent block
4495/// \return true when \p UI is the only use of \p DI in the parent block
4496/// and all other uses of \p DI are in blocks dominated by \p DB.
4497///
4498bool InstCombiner::dominatesAllUses(const Instruction *DI,
4499 const Instruction *UI,
4500 const BasicBlock *DB) const {
4501 assert(DI && UI && "Instruction not defined\n");
Sanjay Patel53523312016-09-12 14:25:46 +00004502 // Ignore incomplete definitions.
Gerolf Hoflehnerec6217c2014-11-21 23:36:44 +00004503 if (!DI->getParent())
4504 return false;
Sanjay Patel53523312016-09-12 14:25:46 +00004505 // DI and UI must be in the same block.
Gerolf Hoflehnerec6217c2014-11-21 23:36:44 +00004506 if (DI->getParent() != UI->getParent())
4507 return false;
Sanjay Patel53523312016-09-12 14:25:46 +00004508 // Protect from self-referencing blocks.
Gerolf Hoflehnerec6217c2014-11-21 23:36:44 +00004509 if (DI->getParent() == DB)
4510 return false;
Gerolf Hoflehnerec6217c2014-11-21 23:36:44 +00004511 for (const User *U : DI->users()) {
4512 auto *Usr = cast<Instruction>(U);
Justin Bogner99798402016-08-05 01:06:44 +00004513 if (Usr != UI && !DT.dominates(DB, Usr->getParent()))
Gerolf Hoflehnerec6217c2014-11-21 23:36:44 +00004514 return false;
4515 }
4516 return true;
4517}
4518
Sanjay Patel5f0217f2016-06-05 16:46:18 +00004519/// Return true when the instruction sequence within a block is select-cmp-br.
Gerolf Hoflehnerec6217c2014-11-21 23:36:44 +00004520static bool isChainSelectCmpBranch(const SelectInst *SI) {
4521 const BasicBlock *BB = SI->getParent();
4522 if (!BB)
4523 return false;
4524 auto *BI = dyn_cast_or_null<BranchInst>(BB->getTerminator());
4525 if (!BI || BI->getNumSuccessors() != 2)
4526 return false;
4527 auto *IC = dyn_cast<ICmpInst>(BI->getCondition());
4528 if (!IC || (IC->getOperand(0) != SI && IC->getOperand(1) != SI))
4529 return false;
4530 return true;
4531}
4532
Adrian Prantl5f8f34e42018-05-01 15:54:18 +00004533/// True when a select result is replaced by one of its operands
Gerolf Hoflehnerec6217c2014-11-21 23:36:44 +00004534/// in select-icmp sequence. This will eventually result in the elimination
4535/// of the select.
4536///
4537/// \param SI Select instruction
4538/// \param Icmp Compare instruction
4539/// \param SIOpd Operand that replaces the select
4540///
4541/// Notes:
4542/// - The replacement is global and requires dominator information
4543/// - The caller is responsible for the actual replacement
4544///
4545/// Example:
4546///
4547/// entry:
4548/// %4 = select i1 %3, %C* %0, %C* null
4549/// %5 = icmp eq %C* %4, null
4550/// br i1 %5, label %9, label %7
4551/// ...
4552/// ; <label>:7 ; preds = %entry
4553/// %8 = getelementptr inbounds %C* %4, i64 0, i32 0
4554/// ...
4555///
4556/// can be transformed to
4557///
4558/// %5 = icmp eq %C* %0, null
4559/// %6 = select i1 %3, i1 %5, i1 true
4560/// br i1 %6, label %9, label %7
4561/// ...
4562/// ; <label>:7 ; preds = %entry
4563/// %8 = getelementptr inbounds %C* %0, i64 0, i32 0 // replace by %0!
4564///
4565/// Similar when the first operand of the select is a constant or/and
4566/// the compare is for not equal rather than equal.
4567///
4568/// NOTE: The function is only called when the select and compare constants
4569/// are equal, the optimization can work only for EQ predicates. This is not a
4570/// major restriction since a NE compare should be 'normalized' to an equal
4571/// compare, which usually happens in the combiner and test case
Sanjay Patel53523312016-09-12 14:25:46 +00004572/// select-cmp-br.ll checks for it.
Gerolf Hoflehnerec6217c2014-11-21 23:36:44 +00004573bool InstCombiner::replacedSelectWithOperand(SelectInst *SI,
4574 const ICmpInst *Icmp,
4575 const unsigned SIOpd) {
David Majnemer83484fd2014-11-22 06:09:28 +00004576 assert((SIOpd == 1 || SIOpd == 2) && "Invalid select operand!");
Gerolf Hoflehnerec6217c2014-11-21 23:36:44 +00004577 if (isChainSelectCmpBranch(SI) && Icmp->getPredicate() == ICmpInst::ICMP_EQ) {
4578 BasicBlock *Succ = SI->getParent()->getTerminator()->getSuccessor(1);
Bjorn Petterssone5027cf2017-03-02 15:18:58 +00004579 // The check for the single predecessor is not the best that can be
Sanjay Patel53523312016-09-12 14:25:46 +00004580 // done. But it protects efficiently against cases like when SI's
Gerolf Hoflehnerec6217c2014-11-21 23:36:44 +00004581 // home block has two successors, Succ and Succ1, and Succ1 predecessor
4582 // of Succ. Then SI can't be replaced by SIOpd because the use that gets
4583 // replaced can be reached on either path. So the uniqueness check
4584 // guarantees that the path all uses of SI (outside SI's parent) are on
4585 // is disjoint from all other paths out of SI. But that information
4586 // is more expensive to compute, and the trade-off here is in favor
Bjorn Petterssone5027cf2017-03-02 15:18:58 +00004587 // of compile-time. It should also be noticed that we check for a single
4588 // predecessor and not only uniqueness. This to handle the situation when
4589 // Succ and Succ1 points to the same basic block.
4590 if (Succ->getSinglePredecessor() && dominatesAllUses(SI, Icmp, Succ)) {
Gerolf Hoflehnerec6217c2014-11-21 23:36:44 +00004591 NumSel++;
4592 SI->replaceUsesOutsideBlock(SI->getOperand(SIOpd), SI->getParent());
4593 return true;
4594 }
4595 }
4596 return false;
4597}
4598
Sanjay Patel3151dec2016-09-12 15:24:31 +00004599/// Try to fold the comparison based on range information we can get by checking
4600/// whether bits are known to be zero or one in the inputs.
4601Instruction *InstCombiner::foldICmpUsingKnownBits(ICmpInst &I) {
4602 Value *Op0 = I.getOperand(0), *Op1 = I.getOperand(1);
4603 Type *Ty = Op0->getType();
Sanjay Patel0531f0a2016-09-12 15:52:28 +00004604 ICmpInst::Predicate Pred = I.getPredicate();
Sanjay Patel3151dec2016-09-12 15:24:31 +00004605
4606 // Get scalar or pointer size.
4607 unsigned BitWidth = Ty->isIntOrIntVectorTy()
4608 ? Ty->getScalarSizeInBits()
Elena Demikhovsky945b7e52018-02-14 06:58:08 +00004609 : DL.getIndexTypeSizeInBits(Ty->getScalarType());
Sanjay Patel3151dec2016-09-12 15:24:31 +00004610
4611 if (!BitWidth)
4612 return nullptr;
4613
Craig Topperb45eabc2017-04-26 16:39:58 +00004614 KnownBits Op0Known(BitWidth);
4615 KnownBits Op1Known(BitWidth);
Sanjay Patel3151dec2016-09-12 15:24:31 +00004616
Craig Topper47596dd2017-03-25 06:52:52 +00004617 if (SimplifyDemandedBits(&I, 0,
Craig Topper3edda872017-09-22 18:57:23 +00004618 getDemandedBitsLHSMask(I, BitWidth),
Craig Topperb45eabc2017-04-26 16:39:58 +00004619 Op0Known, 0))
Sanjay Patel3151dec2016-09-12 15:24:31 +00004620 return &I;
4621
Craig Topper47596dd2017-03-25 06:52:52 +00004622 if (SimplifyDemandedBits(&I, 1, APInt::getAllOnesValue(BitWidth),
Craig Topperb45eabc2017-04-26 16:39:58 +00004623 Op1Known, 0))
Sanjay Patel3151dec2016-09-12 15:24:31 +00004624 return &I;
4625
4626 // Given the known and unknown bits, compute a range that the LHS could be
4627 // in. Compute the Min, Max and RHS values based on the known bits. For the
4628 // EQ and NE we use unsigned values.
4629 APInt Op0Min(BitWidth, 0), Op0Max(BitWidth, 0);
4630 APInt Op1Min(BitWidth, 0), Op1Max(BitWidth, 0);
4631 if (I.isSigned()) {
Craig Topperb45eabc2017-04-26 16:39:58 +00004632 computeSignedMinMaxValuesFromKnownBits(Op0Known, Op0Min, Op0Max);
4633 computeSignedMinMaxValuesFromKnownBits(Op1Known, Op1Min, Op1Max);
Sanjay Patel3151dec2016-09-12 15:24:31 +00004634 } else {
Craig Topperb45eabc2017-04-26 16:39:58 +00004635 computeUnsignedMinMaxValuesFromKnownBits(Op0Known, Op0Min, Op0Max);
4636 computeUnsignedMinMaxValuesFromKnownBits(Op1Known, Op1Min, Op1Max);
Sanjay Patel3151dec2016-09-12 15:24:31 +00004637 }
4638
Sanjay Patelc63f9012018-01-04 14:31:56 +00004639 // If Min and Max are known to be the same, then SimplifyDemandedBits figured
4640 // out that the LHS or RHS is a constant. Constant fold this now, so that
Sanjay Patel0531f0a2016-09-12 15:52:28 +00004641 // code below can assume that Min != Max.
Sanjay Patel3151dec2016-09-12 15:24:31 +00004642 if (!isa<Constant>(Op0) && Op0Min == Op0Max)
Sanjay Patelc63f9012018-01-04 14:31:56 +00004643 return new ICmpInst(Pred, ConstantExpr::getIntegerValue(Ty, Op0Min), Op1);
Sanjay Patel3151dec2016-09-12 15:24:31 +00004644 if (!isa<Constant>(Op1) && Op1Min == Op1Max)
Sanjay Patelc63f9012018-01-04 14:31:56 +00004645 return new ICmpInst(Pred, Op0, ConstantExpr::getIntegerValue(Ty, Op1Min));
Sanjay Patel3151dec2016-09-12 15:24:31 +00004646
4647 // Based on the range information we know about the LHS, see if we can
4648 // simplify this comparison. For example, (x&4) < 8 is always true.
Sanjay Patel0531f0a2016-09-12 15:52:28 +00004649 switch (Pred) {
Sanjay Patel3151dec2016-09-12 15:24:31 +00004650 default:
4651 llvm_unreachable("Unknown icmp opcode!");
Sanjay Patel9efb1bd2016-09-14 23:38:56 +00004652 case ICmpInst::ICMP_EQ:
Sanjay Patel3151dec2016-09-12 15:24:31 +00004653 case ICmpInst::ICMP_NE: {
Sanjay Patel9efb1bd2016-09-14 23:38:56 +00004654 if (Op0Max.ult(Op1Min) || Op0Min.ugt(Op1Max)) {
4655 return Pred == CmpInst::ICMP_EQ
4656 ? replaceInstUsesWith(I, ConstantInt::getFalse(I.getType()))
4657 : replaceInstUsesWith(I, ConstantInt::getTrue(I.getType()));
4658 }
Sanjay Patel3151dec2016-09-12 15:24:31 +00004659
Sanjay Patel0531f0a2016-09-12 15:52:28 +00004660 // If all bits are known zero except for one, then we know at most one bit
4661 // is set. If the comparison is against zero, then this is a check to see if
4662 // *that* bit is set.
Craig Topperb45eabc2017-04-26 16:39:58 +00004663 APInt Op0KnownZeroInverted = ~Op0Known.Zero;
Craig Topperf0aeee02017-05-05 17:36:09 +00004664 if (Op1Known.isZero()) {
Sanjay Patel3151dec2016-09-12 15:24:31 +00004665 // If the LHS is an AND with the same constant, look through it.
4666 Value *LHS = nullptr;
Sanjay Patel7577a3d2016-09-15 14:15:47 +00004667 const APInt *LHSC;
4668 if (!match(Op0, m_And(m_Value(LHS), m_APInt(LHSC))) ||
4669 *LHSC != Op0KnownZeroInverted)
Sanjay Patel3151dec2016-09-12 15:24:31 +00004670 LHS = Op0;
4671
Sanjay Patel9efb1bd2016-09-14 23:38:56 +00004672 Value *X;
Sanjay Patel3151dec2016-09-12 15:24:31 +00004673 if (match(LHS, m_Shl(m_One(), m_Value(X)))) {
4674 APInt ValToCheck = Op0KnownZeroInverted;
Sanjay Patel9efb1bd2016-09-14 23:38:56 +00004675 Type *XTy = X->getType();
Sanjay Patel3151dec2016-09-12 15:24:31 +00004676 if (ValToCheck.isPowerOf2()) {
Sanjay Patel9efb1bd2016-09-14 23:38:56 +00004677 // ((1 << X) & 8) == 0 -> X != 3
4678 // ((1 << X) & 8) != 0 -> X == 3
4679 auto *CmpC = ConstantInt::get(XTy, ValToCheck.countTrailingZeros());
4680 auto NewPred = ICmpInst::getInversePredicate(Pred);
4681 return new ICmpInst(NewPred, X, CmpC);
Sanjay Patel3151dec2016-09-12 15:24:31 +00004682 } else if ((++ValToCheck).isPowerOf2()) {
Sanjay Patel9efb1bd2016-09-14 23:38:56 +00004683 // ((1 << X) & 7) == 0 -> X >= 3
4684 // ((1 << X) & 7) != 0 -> X < 3
4685 auto *CmpC = ConstantInt::get(XTy, ValToCheck.countTrailingZeros());
4686 auto NewPred =
4687 Pred == CmpInst::ICMP_EQ ? CmpInst::ICMP_UGE : CmpInst::ICMP_ULT;
4688 return new ICmpInst(NewPred, X, CmpC);
Sanjay Patel3151dec2016-09-12 15:24:31 +00004689 }
4690 }
4691
Sanjay Patel9efb1bd2016-09-14 23:38:56 +00004692 // Check if the LHS is 8 >>u x and the result is a power of 2 like 1.
Sanjay Patel3151dec2016-09-12 15:24:31 +00004693 const APInt *CI;
Craig Topper73ba1c82017-06-07 07:40:37 +00004694 if (Op0KnownZeroInverted.isOneValue() &&
Sanjay Patel9efb1bd2016-09-14 23:38:56 +00004695 match(LHS, m_LShr(m_Power2(CI), m_Value(X)))) {
4696 // ((8 >>u X) & 1) == 0 -> X != 3
4697 // ((8 >>u X) & 1) != 0 -> X == 3
4698 unsigned CmpVal = CI->countTrailingZeros();
4699 auto NewPred = ICmpInst::getInversePredicate(Pred);
4700 return new ICmpInst(NewPred, X, ConstantInt::get(X->getType(), CmpVal));
4701 }
Sanjay Patel3151dec2016-09-12 15:24:31 +00004702 }
4703 break;
4704 }
4705 case ICmpInst::ICMP_ULT: {
4706 if (Op0Max.ult(Op1Min)) // A <u B -> true if max(A) < min(B)
4707 return replaceInstUsesWith(I, ConstantInt::getTrue(I.getType()));
4708 if (Op0Min.uge(Op1Max)) // A <u B -> false if min(A) >= max(B)
4709 return replaceInstUsesWith(I, ConstantInt::getFalse(I.getType()));
4710 if (Op1Min == Op0Max) // A <u B -> A != B if max(A) == min(B)
4711 return new ICmpInst(ICmpInst::ICMP_NE, Op0, Op1);
4712
Craig Topper0cd25942017-09-27 22:57:18 +00004713 const APInt *CmpC;
4714 if (match(Op1, m_APInt(CmpC))) {
Sanjay Patel3151dec2016-09-12 15:24:31 +00004715 // A <u C -> A == C-1 if min(A)+1 == C
Craig Topper0cd25942017-09-27 22:57:18 +00004716 if (*CmpC == Op0Min + 1)
Craig Topper2c9b7d72017-09-22 18:57:20 +00004717 return new ICmpInst(ICmpInst::ICMP_EQ, Op0,
Craig Topper0cd25942017-09-27 22:57:18 +00004718 ConstantInt::get(Op1->getType(), *CmpC - 1));
Craig Topper30dc9792017-09-25 21:15:00 +00004719 // X <u C --> X == 0, if the number of zero bits in the bottom of X
4720 // exceeds the log2 of C.
Craig Topper0cd25942017-09-27 22:57:18 +00004721 if (Op0Known.countMinTrailingZeros() >= CmpC->ceilLogBase2())
Craig Topper30dc9792017-09-25 21:15:00 +00004722 return new ICmpInst(ICmpInst::ICMP_EQ, Op0,
4723 Constant::getNullValue(Op1->getType()));
Sanjay Patel3151dec2016-09-12 15:24:31 +00004724 }
4725 break;
4726 }
4727 case ICmpInst::ICMP_UGT: {
4728 if (Op0Min.ugt(Op1Max)) // A >u B -> true if min(A) > max(B)
4729 return replaceInstUsesWith(I, ConstantInt::getTrue(I.getType()));
Sanjay Patel3151dec2016-09-12 15:24:31 +00004730 if (Op0Max.ule(Op1Min)) // A >u B -> false if max(A) <= max(B)
4731 return replaceInstUsesWith(I, ConstantInt::getFalse(I.getType()));
Sanjay Patel3151dec2016-09-12 15:24:31 +00004732 if (Op1Max == Op0Min) // A >u B -> A != B if min(A) == max(B)
4733 return new ICmpInst(ICmpInst::ICMP_NE, Op0, Op1);
4734
Craig Topper0cd25942017-09-27 22:57:18 +00004735 const APInt *CmpC;
4736 if (match(Op1, m_APInt(CmpC))) {
Sanjay Patel3151dec2016-09-12 15:24:31 +00004737 // A >u C -> A == C+1 if max(a)-1 == C
Craig Topper0cd25942017-09-27 22:57:18 +00004738 if (*CmpC == Op0Max - 1)
Sanjay Patel3151dec2016-09-12 15:24:31 +00004739 return new ICmpInst(ICmpInst::ICMP_EQ, Op0,
Craig Topper0cd25942017-09-27 22:57:18 +00004740 ConstantInt::get(Op1->getType(), *CmpC + 1));
Craig Topper30dc9792017-09-25 21:15:00 +00004741 // X >u C --> X != 0, if the number of zero bits in the bottom of X
4742 // exceeds the log2 of C.
Craig Topper0cd25942017-09-27 22:57:18 +00004743 if (Op0Known.countMinTrailingZeros() >= CmpC->getActiveBits())
Craig Topper30dc9792017-09-25 21:15:00 +00004744 return new ICmpInst(ICmpInst::ICMP_NE, Op0,
4745 Constant::getNullValue(Op1->getType()));
Sanjay Patel3151dec2016-09-12 15:24:31 +00004746 }
4747 break;
4748 }
Craig Topper0cd25942017-09-27 22:57:18 +00004749 case ICmpInst::ICMP_SLT: {
Sanjay Patel3151dec2016-09-12 15:24:31 +00004750 if (Op0Max.slt(Op1Min)) // A <s B -> true if max(A) < min(C)
4751 return replaceInstUsesWith(I, ConstantInt::getTrue(I.getType()));
4752 if (Op0Min.sge(Op1Max)) // A <s B -> false if min(A) >= max(C)
4753 return replaceInstUsesWith(I, ConstantInt::getFalse(I.getType()));
4754 if (Op1Min == Op0Max) // A <s B -> A != B if max(A) == min(B)
4755 return new ICmpInst(ICmpInst::ICMP_NE, Op0, Op1);
Craig Topper0cd25942017-09-27 22:57:18 +00004756 const APInt *CmpC;
4757 if (match(Op1, m_APInt(CmpC))) {
4758 if (*CmpC == Op0Min + 1) // A <s C -> A == C-1 if min(A)+1 == C
Sanjay Patel3151dec2016-09-12 15:24:31 +00004759 return new ICmpInst(ICmpInst::ICMP_EQ, Op0,
Craig Topper0cd25942017-09-27 22:57:18 +00004760 ConstantInt::get(Op1->getType(), *CmpC - 1));
Sanjay Patel3151dec2016-09-12 15:24:31 +00004761 }
4762 break;
Craig Topper0cd25942017-09-27 22:57:18 +00004763 }
4764 case ICmpInst::ICMP_SGT: {
Sanjay Patel3151dec2016-09-12 15:24:31 +00004765 if (Op0Min.sgt(Op1Max)) // A >s B -> true if min(A) > max(B)
4766 return replaceInstUsesWith(I, ConstantInt::getTrue(I.getType()));
4767 if (Op0Max.sle(Op1Min)) // A >s B -> false if max(A) <= min(B)
4768 return replaceInstUsesWith(I, ConstantInt::getFalse(I.getType()));
Sanjay Patel3151dec2016-09-12 15:24:31 +00004769 if (Op1Max == Op0Min) // A >s B -> A != B if min(A) == max(B)
4770 return new ICmpInst(ICmpInst::ICMP_NE, Op0, Op1);
Craig Topper0cd25942017-09-27 22:57:18 +00004771 const APInt *CmpC;
4772 if (match(Op1, m_APInt(CmpC))) {
4773 if (*CmpC == Op0Max - 1) // A >s C -> A == C+1 if max(A)-1 == C
Sanjay Patel3151dec2016-09-12 15:24:31 +00004774 return new ICmpInst(ICmpInst::ICMP_EQ, Op0,
Craig Topper0cd25942017-09-27 22:57:18 +00004775 ConstantInt::get(Op1->getType(), *CmpC + 1));
Sanjay Patel3151dec2016-09-12 15:24:31 +00004776 }
4777 break;
Craig Topper0cd25942017-09-27 22:57:18 +00004778 }
Sanjay Patel3151dec2016-09-12 15:24:31 +00004779 case ICmpInst::ICMP_SGE:
4780 assert(!isa<ConstantInt>(Op1) && "ICMP_SGE with ConstantInt not folded!");
4781 if (Op0Min.sge(Op1Max)) // A >=s B -> true if min(A) >= max(B)
4782 return replaceInstUsesWith(I, ConstantInt::getTrue(I.getType()));
4783 if (Op0Max.slt(Op1Min)) // A >=s B -> false if max(A) < min(B)
4784 return replaceInstUsesWith(I, ConstantInt::getFalse(I.getType()));
Craig Topperea927ba2017-09-22 21:47:22 +00004785 if (Op1Min == Op0Max) // A >=s B -> A == B if max(A) == min(B)
4786 return new ICmpInst(ICmpInst::ICMP_EQ, Op0, Op1);
Sanjay Patel3151dec2016-09-12 15:24:31 +00004787 break;
4788 case ICmpInst::ICMP_SLE:
4789 assert(!isa<ConstantInt>(Op1) && "ICMP_SLE with ConstantInt not folded!");
4790 if (Op0Max.sle(Op1Min)) // A <=s B -> true if max(A) <= min(B)
4791 return replaceInstUsesWith(I, ConstantInt::getTrue(I.getType()));
4792 if (Op0Min.sgt(Op1Max)) // A <=s B -> false if min(A) > max(B)
4793 return replaceInstUsesWith(I, ConstantInt::getFalse(I.getType()));
Craig Topperea927ba2017-09-22 21:47:22 +00004794 if (Op1Max == Op0Min) // A <=s B -> A == B if min(A) == max(B)
4795 return new ICmpInst(ICmpInst::ICMP_EQ, Op0, Op1);
Sanjay Patel3151dec2016-09-12 15:24:31 +00004796 break;
4797 case ICmpInst::ICMP_UGE:
4798 assert(!isa<ConstantInt>(Op1) && "ICMP_UGE with ConstantInt not folded!");
4799 if (Op0Min.uge(Op1Max)) // A >=u B -> true if min(A) >= max(B)
4800 return replaceInstUsesWith(I, ConstantInt::getTrue(I.getType()));
4801 if (Op0Max.ult(Op1Min)) // A >=u B -> false if max(A) < min(B)
4802 return replaceInstUsesWith(I, ConstantInt::getFalse(I.getType()));
Craig Topperea927ba2017-09-22 21:47:22 +00004803 if (Op1Min == Op0Max) // A >=u B -> A == B if max(A) == min(B)
4804 return new ICmpInst(ICmpInst::ICMP_EQ, Op0, Op1);
Sanjay Patel3151dec2016-09-12 15:24:31 +00004805 break;
4806 case ICmpInst::ICMP_ULE:
4807 assert(!isa<ConstantInt>(Op1) && "ICMP_ULE with ConstantInt not folded!");
4808 if (Op0Max.ule(Op1Min)) // A <=u B -> true if max(A) <= min(B)
4809 return replaceInstUsesWith(I, ConstantInt::getTrue(I.getType()));
4810 if (Op0Min.ugt(Op1Max)) // A <=u B -> false if min(A) > max(B)
4811 return replaceInstUsesWith(I, ConstantInt::getFalse(I.getType()));
Craig Topperea927ba2017-09-22 21:47:22 +00004812 if (Op1Max == Op0Min) // A <=u B -> A == B if min(A) == max(B)
4813 return new ICmpInst(ICmpInst::ICMP_EQ, Op0, Op1);
Sanjay Patel3151dec2016-09-12 15:24:31 +00004814 break;
4815 }
4816
4817 // Turn a signed comparison into an unsigned one if both operands are known to
4818 // have the same sign.
4819 if (I.isSigned() &&
Craig Topperb45eabc2017-04-26 16:39:58 +00004820 ((Op0Known.Zero.isNegative() && Op1Known.Zero.isNegative()) ||
4821 (Op0Known.One.isNegative() && Op1Known.One.isNegative())))
Sanjay Patel3151dec2016-09-12 15:24:31 +00004822 return new ICmpInst(I.getUnsignedPredicate(), Op0, Op1);
4823
4824 return nullptr;
4825}
4826
Roman Lebedev32f1e1a2019-08-14 09:57:20 +00004827llvm::Optional<std::pair<CmpInst::Predicate, Constant *>>
4828llvm::getFlippedStrictnessPredicateAndConstant(CmpInst::Predicate Pred,
4829 Constant *C) {
4830 assert(ICmpInst::isRelational(Pred) && ICmpInst::isIntPredicate(Pred) &&
4831 !isCanonicalPredicate(Pred) &&
4832 "Only for non-canonical relational integer predicates.");
Sanjay Pateld5b0e542016-04-29 16:22:25 +00004833
Sanjay Patele9b2c322016-05-17 00:57:57 +00004834 // Check if the constant operand can be safely incremented/decremented without
Roman Lebedev32f1e1a2019-08-14 09:57:20 +00004835 // overflowing/underflowing. For scalars, SimplifyICmpInst should have already
4836 // handled the edge cases for us, so we just assert on them.
4837 // For vectors, we must handle the edge cases.
4838 Type *Type = C->getType();
4839 bool IsSigned = ICmpInst::isSigned(Pred);
Sanjay Patele9b2c322016-05-17 00:57:57 +00004840 bool IsLE = (Pred == ICmpInst::ICMP_SLE || Pred == ICmpInst::ICMP_ULE);
Roman Lebedev32f1e1a2019-08-14 09:57:20 +00004841 auto *CI = dyn_cast<ConstantInt>(C);
Sanjay Patel18254932016-05-17 01:12:31 +00004842 if (CI) {
Sanjay Patele9b2c322016-05-17 00:57:57 +00004843 // A <= MAX -> TRUE ; A >= MIN -> TRUE
4844 assert(IsLE ? !CI->isMaxValue(IsSigned) : !CI->isMinValue(IsSigned));
Roman Lebedev32f1e1a2019-08-14 09:57:20 +00004845 } else if (Type->isVectorTy()) {
Sanjay Patelb79ab272016-05-13 15:10:46 +00004846 // TODO? If the edge cases for vectors were guaranteed to be handled as they
Sanjay Patele9b2c322016-05-17 00:57:57 +00004847 // are for scalar, we could remove the min/max checks. However, to do that,
4848 // we would have to use insertelement/shufflevector to replace edge values.
Roman Lebedev32f1e1a2019-08-14 09:57:20 +00004849 unsigned NumElts = Type->getVectorNumElements();
Sanjay Patele9b2c322016-05-17 00:57:57 +00004850 for (unsigned i = 0; i != NumElts; ++i) {
Roman Lebedev32f1e1a2019-08-14 09:57:20 +00004851 Constant *Elt = C->getAggregateElement(i);
Benjamin Kramerca9a0fe2016-05-17 12:08:55 +00004852 if (!Elt)
Roman Lebedev32f1e1a2019-08-14 09:57:20 +00004853 return llvm::None;
Benjamin Kramerca9a0fe2016-05-17 12:08:55 +00004854
Sanjay Patele9b2c322016-05-17 00:57:57 +00004855 if (isa<UndefValue>(Elt))
4856 continue;
Sanjay Patel06b127a2016-09-15 14:37:50 +00004857
Sanjay Patele9b2c322016-05-17 00:57:57 +00004858 // Bail out if we can't determine if this constant is min/max or if we
4859 // know that this constant is min/max.
4860 auto *CI = dyn_cast<ConstantInt>(Elt);
4861 if (!CI || (IsLE ? CI->isMaxValue(IsSigned) : CI->isMinValue(IsSigned)))
Roman Lebedev32f1e1a2019-08-14 09:57:20 +00004862 return llvm::None;
Sanjay Patelb79ab272016-05-13 15:10:46 +00004863 }
Sanjay Patele9b2c322016-05-17 00:57:57 +00004864 } else {
4865 // ConstantExpr?
Roman Lebedev32f1e1a2019-08-14 09:57:20 +00004866 return llvm::None;
Sanjay Patelb79ab272016-05-13 15:10:46 +00004867 }
Sanjay Pateld5b0e542016-04-29 16:22:25 +00004868
Roman Lebedev32f1e1a2019-08-14 09:57:20 +00004869 CmpInst::Predicate NewPred = CmpInst::getFlippedStrictnessPredicate(Pred);
4870
4871 // Increment or decrement the constant.
4872 Constant *OneOrNegOne = ConstantInt::get(Type, IsLE ? 1 : -1, true);
4873 Constant *NewC = ConstantExpr::getAdd(C, OneOrNegOne);
4874
4875 return std::make_pair(NewPred, NewC);
4876}
4877
4878/// If we have an icmp le or icmp ge instruction with a constant operand, turn
4879/// it into the appropriate icmp lt or icmp gt instruction. This transform
4880/// allows them to be folded in visitICmpInst.
4881static ICmpInst *canonicalizeCmpWithConstant(ICmpInst &I) {
4882 ICmpInst::Predicate Pred = I.getPredicate();
4883 if (ICmpInst::isEquality(Pred) || !ICmpInst::isIntPredicate(Pred) ||
4884 isCanonicalPredicate(Pred))
4885 return nullptr;
4886
4887 Value *Op0 = I.getOperand(0);
4888 Value *Op1 = I.getOperand(1);
4889 auto *Op1C = dyn_cast<Constant>(Op1);
4890 if (!Op1C)
4891 return nullptr;
4892
4893 auto FlippedStrictness = getFlippedStrictnessPredicateAndConstant(Pred, Op1C);
4894 if (!FlippedStrictness)
4895 return nullptr;
4896
4897 return new ICmpInst(FlippedStrictness->first, Op0, FlippedStrictness->second);
Sanjay Pateld5b0e542016-04-29 16:22:25 +00004898}
4899
Sanjay Patele5747e32017-05-17 22:15:07 +00004900/// Integer compare with boolean values can always be turned into bitwise ops.
4901static Instruction *canonicalizeICmpBool(ICmpInst &I,
4902 InstCombiner::BuilderTy &Builder) {
4903 Value *A = I.getOperand(0), *B = I.getOperand(1);
Craig Topperfde47232017-07-09 07:04:03 +00004904 assert(A->getType()->isIntOrIntVectorTy(1) && "Bools only");
Sanjay Patele5747e32017-05-17 22:15:07 +00004905
Sanjay Patelba212c22017-05-17 22:29:40 +00004906 // A boolean compared to true/false can be simplified to Op0/true/false in
4907 // 14 out of the 20 (10 predicates * 2 constants) possible combinations.
4908 // Cases not handled by InstSimplify are always 'not' of Op0.
4909 if (match(B, m_Zero())) {
4910 switch (I.getPredicate()) {
4911 case CmpInst::ICMP_EQ: // A == 0 -> !A
4912 case CmpInst::ICMP_ULE: // A <=u 0 -> !A
4913 case CmpInst::ICMP_SGE: // A >=s 0 -> !A
4914 return BinaryOperator::CreateNot(A);
4915 default:
4916 llvm_unreachable("ICmp i1 X, C not simplified as expected.");
4917 }
4918 } else if (match(B, m_One())) {
4919 switch (I.getPredicate()) {
4920 case CmpInst::ICMP_NE: // A != 1 -> !A
4921 case CmpInst::ICMP_ULT: // A <u 1 -> !A
4922 case CmpInst::ICMP_SGT: // A >s -1 -> !A
4923 return BinaryOperator::CreateNot(A);
4924 default:
4925 llvm_unreachable("ICmp i1 X, C not simplified as expected.");
4926 }
4927 }
4928
Sanjay Patele5747e32017-05-17 22:15:07 +00004929 switch (I.getPredicate()) {
4930 default:
4931 llvm_unreachable("Invalid icmp instruction!");
4932 case ICmpInst::ICMP_EQ:
4933 // icmp eq i1 A, B -> ~(A ^ B)
4934 return BinaryOperator::CreateNot(Builder.CreateXor(A, B));
4935
4936 case ICmpInst::ICMP_NE:
4937 // icmp ne i1 A, B -> A ^ B
4938 return BinaryOperator::CreateXor(A, B);
4939
4940 case ICmpInst::ICMP_UGT:
4941 // icmp ugt -> icmp ult
4942 std::swap(A, B);
4943 LLVM_FALLTHROUGH;
4944 case ICmpInst::ICMP_ULT:
4945 // icmp ult i1 A, B -> ~A & B
4946 return BinaryOperator::CreateAnd(Builder.CreateNot(A), B);
4947
4948 case ICmpInst::ICMP_SGT:
4949 // icmp sgt -> icmp slt
4950 std::swap(A, B);
4951 LLVM_FALLTHROUGH;
4952 case ICmpInst::ICMP_SLT:
4953 // icmp slt i1 A, B -> A & ~B
4954 return BinaryOperator::CreateAnd(Builder.CreateNot(B), A);
4955
4956 case ICmpInst::ICMP_UGE:
4957 // icmp uge -> icmp ule
4958 std::swap(A, B);
4959 LLVM_FALLTHROUGH;
4960 case ICmpInst::ICMP_ULE:
4961 // icmp ule i1 A, B -> ~A | B
4962 return BinaryOperator::CreateOr(Builder.CreateNot(A), B);
4963
4964 case ICmpInst::ICMP_SGE:
4965 // icmp sge -> icmp sle
4966 std::swap(A, B);
4967 LLVM_FALLTHROUGH;
4968 case ICmpInst::ICMP_SLE:
4969 // icmp sle i1 A, B -> A | ~B
4970 return BinaryOperator::CreateOr(Builder.CreateNot(B), A);
4971 }
4972}
4973
Roman Lebedev75404fb2018-09-12 18:19:43 +00004974// Transform pattern like:
Roman Lebedev1b7fc872018-09-15 12:04:13 +00004975// (1 << Y) u<= X or ~(-1 << Y) u< X or ((1 << Y)+(-1)) u< X
4976// (1 << Y) u> X or ~(-1 << Y) u>= X or ((1 << Y)+(-1)) u>= X
Roman Lebedev75404fb2018-09-12 18:19:43 +00004977// Into:
4978// (X l>> Y) != 0
4979// (X l>> Y) == 0
4980static Instruction *foldICmpWithHighBitMask(ICmpInst &Cmp,
4981 InstCombiner::BuilderTy &Builder) {
Roman Lebedev6dc87002018-09-13 20:33:12 +00004982 ICmpInst::Predicate Pred, NewPred;
Roman Lebedev75404fb2018-09-12 18:19:43 +00004983 Value *X, *Y;
Roman Lebedev6dc87002018-09-13 20:33:12 +00004984 if (match(&Cmp,
4985 m_c_ICmp(Pred, m_OneUse(m_Shl(m_One(), m_Value(Y))), m_Value(X)))) {
4986 // We want X to be the icmp's second operand, so swap predicate if it isn't.
4987 if (Cmp.getOperand(0) == X)
4988 Pred = Cmp.getSwappedPredicate();
Roman Lebedev75404fb2018-09-12 18:19:43 +00004989
Roman Lebedev6dc87002018-09-13 20:33:12 +00004990 switch (Pred) {
4991 case ICmpInst::ICMP_ULE:
4992 NewPred = ICmpInst::ICMP_NE;
4993 break;
4994 case ICmpInst::ICMP_UGT:
4995 NewPred = ICmpInst::ICMP_EQ;
4996 break;
4997 default:
4998 return nullptr;
4999 }
Roman Lebedev1b7fc872018-09-15 12:04:13 +00005000 } else if (match(&Cmp, m_c_ICmp(Pred,
5001 m_OneUse(m_CombineOr(
5002 m_Not(m_Shl(m_AllOnes(), m_Value(Y))),
5003 m_Add(m_Shl(m_One(), m_Value(Y)),
5004 m_AllOnes()))),
5005 m_Value(X)))) {
5006 // The variant with 'add' is not canonical, (the variant with 'not' is)
5007 // we only get it because it has extra uses, and can't be canonicalized,
5008
Roman Lebedev6dc87002018-09-13 20:33:12 +00005009 // We want X to be the icmp's second operand, so swap predicate if it isn't.
5010 if (Cmp.getOperand(0) == X)
5011 Pred = Cmp.getSwappedPredicate();
Roman Lebedev75404fb2018-09-12 18:19:43 +00005012
Roman Lebedev6dc87002018-09-13 20:33:12 +00005013 switch (Pred) {
5014 case ICmpInst::ICMP_ULT:
5015 NewPred = ICmpInst::ICMP_NE;
5016 break;
5017 case ICmpInst::ICMP_UGE:
5018 NewPred = ICmpInst::ICMP_EQ;
5019 break;
5020 default:
5021 return nullptr;
5022 }
5023 } else
Roman Lebedev75404fb2018-09-12 18:19:43 +00005024 return nullptr;
Roman Lebedev75404fb2018-09-12 18:19:43 +00005025
5026 Value *NewX = Builder.CreateLShr(X, Y, X->getName() + ".highbits");
5027 Constant *Zero = Constant::getNullValue(NewX->getType());
5028 return CmpInst::Create(Instruction::ICmp, NewPred, NewX, Zero);
5029}
5030
Sanjay Patel039f5562018-08-16 12:52:17 +00005031static Instruction *foldVectorCmp(CmpInst &Cmp,
5032 InstCombiner::BuilderTy &Builder) {
5033 // If both arguments of the cmp are shuffles that use the same mask and
5034 // shuffle within a single vector, move the shuffle after the cmp.
5035 Value *LHS = Cmp.getOperand(0), *RHS = Cmp.getOperand(1);
5036 Value *V1, *V2;
5037 Constant *M;
5038 if (match(LHS, m_ShuffleVector(m_Value(V1), m_Undef(), m_Constant(M))) &&
5039 match(RHS, m_ShuffleVector(m_Value(V2), m_Undef(), m_Specific(M))) &&
5040 V1->getType() == V2->getType() &&
5041 (LHS->hasOneUse() || RHS->hasOneUse())) {
5042 // cmp (shuffle V1, M), (shuffle V2, M) --> shuffle (cmp V1, V2), M
5043 CmpInst::Predicate P = Cmp.getPredicate();
5044 Value *NewCmp = isa<ICmpInst>(Cmp) ? Builder.CreateICmp(P, V1, V2)
5045 : Builder.CreateFCmp(P, V1, V2);
5046 return new ShuffleVectorInst(NewCmp, UndefValue::get(NewCmp->getType()), M);
5047 }
5048 return nullptr;
5049}
5050
Chris Lattner2188e402010-01-04 07:37:31 +00005051Instruction *InstCombiner::visitICmpInst(ICmpInst &I) {
5052 bool Changed = false;
Chris Lattner9306ffa2010-02-01 19:54:45 +00005053 Value *Op0 = I.getOperand(0), *Op1 = I.getOperand(1);
Quentin Colombet5ab55552013-09-09 20:56:48 +00005054 unsigned Op0Cplxity = getComplexity(Op0);
5055 unsigned Op1Cplxity = getComplexity(Op1);
Jim Grosbach129c52a2011-09-30 18:09:53 +00005056
Chris Lattner2188e402010-01-04 07:37:31 +00005057 /// Orders the operands of the compare so that they are listed from most
5058 /// complex to least complex. This puts constants before unary operators,
5059 /// before binary operators.
Quentin Colombet5ab55552013-09-09 20:56:48 +00005060 if (Op0Cplxity < Op1Cplxity ||
Sanjay Patel4c204232016-06-04 20:39:22 +00005061 (Op0Cplxity == Op1Cplxity && swapMayExposeCSEOpportunities(Op0, Op1))) {
Chris Lattner2188e402010-01-04 07:37:31 +00005062 I.swapOperands();
Chris Lattner9306ffa2010-02-01 19:54:45 +00005063 std::swap(Op0, Op1);
Chris Lattner2188e402010-01-04 07:37:31 +00005064 Changed = true;
5065 }
Jim Grosbach129c52a2011-09-30 18:09:53 +00005066
Daniel Berlin2c75c632017-04-26 20:56:07 +00005067 if (Value *V = SimplifyICmpInst(I.getPredicate(), Op0, Op1,
5068 SQ.getWithInstruction(&I)))
Sanjay Patel4b198802016-02-01 22:23:39 +00005069 return replaceInstUsesWith(I, V);
Jim Grosbach129c52a2011-09-30 18:09:53 +00005070
Uriel Korach18972232017-09-10 08:31:22 +00005071 // Comparing -val or val with non-zero is the same as just comparing val
Pete Cooperfdddc272011-12-01 19:13:26 +00005072 // ie, abs(val) != 0 -> val != 0
Sanjay Patel4c204232016-06-04 20:39:22 +00005073 if (I.getPredicate() == ICmpInst::ICMP_NE && match(Op1, m_Zero())) {
Pete Cooperfdddc272011-12-01 19:13:26 +00005074 Value *Cond, *SelectTrue, *SelectFalse;
5075 if (match(Op0, m_Select(m_Value(Cond), m_Value(SelectTrue),
Pete Cooperbc5c5242011-12-01 03:58:40 +00005076 m_Value(SelectFalse)))) {
Pete Cooperfdddc272011-12-01 19:13:26 +00005077 if (Value *V = dyn_castNegVal(SelectTrue)) {
5078 if (V == SelectFalse)
5079 return CmpInst::Create(Instruction::ICmp, I.getPredicate(), V, Op1);
5080 }
5081 else if (Value *V = dyn_castNegVal(SelectFalse)) {
5082 if (V == SelectTrue)
5083 return CmpInst::Create(Instruction::ICmp, I.getPredicate(), V, Op1);
Pete Cooperbc5c5242011-12-01 03:58:40 +00005084 }
5085 }
5086 }
5087
Craig Topperfde47232017-07-09 07:04:03 +00005088 if (Op0->getType()->isIntOrIntVectorTy(1))
Craig Topperbb4069e2017-07-07 23:16:26 +00005089 if (Instruction *Res = canonicalizeICmpBool(I, Builder))
Sanjay Patele5747e32017-05-17 22:15:07 +00005090 return Res;
Chris Lattner2188e402010-01-04 07:37:31 +00005091
Sanjay Patele9b2c322016-05-17 00:57:57 +00005092 if (ICmpInst *NewICmp = canonicalizeCmpWithConstant(I))
Sanjay Pateld5b0e542016-04-29 16:22:25 +00005093 return NewICmp;
5094
Sanjay Patel06b127a2016-09-15 14:37:50 +00005095 if (Instruction *Res = foldICmpWithConstant(I))
5096 return Res;
Chris Lattner2188e402010-01-04 07:37:31 +00005097
Sanjay Pateld23b5ed2018-12-04 17:44:24 +00005098 if (Instruction *Res = foldICmpWithDominatingICmp(I))
5099 return Res;
5100
Max Kazantsev20da7e42018-07-06 04:04:13 +00005101 if (Instruction *Res = foldICmpUsingKnownBits(I))
5102 return Res;
5103
Chris Lattner2188e402010-01-04 07:37:31 +00005104 // Test if the ICmpInst instruction is used exclusively by a select as
5105 // part of a minimum or maximum operation. If so, refrain from doing
5106 // any other folding. This helps out other analyses which understand
5107 // non-obfuscated minimum and maximum idioms, such as ScalarEvolution
5108 // and CodeGen. And in this case, at least one of the comparison
5109 // operands has at least one user besides the compare (the select),
5110 // which would often largely negate the benefit of folding anyway.
Craig Topperd3e57812017-11-12 02:28:21 +00005111 //
5112 // Do the same for the other patterns recognized by matchSelectPattern.
Chris Lattner2188e402010-01-04 07:37:31 +00005113 if (I.hasOneUse())
Craig Topperd3e57812017-11-12 02:28:21 +00005114 if (SelectInst *SI = dyn_cast<SelectInst>(I.user_back())) {
5115 Value *A, *B;
5116 SelectPatternResult SPR = matchSelectPattern(SI, A, B);
5117 if (SPR.Flavor != SPF_UNKNOWN)
Craig Topperf40110f2014-04-25 05:29:35 +00005118 return nullptr;
Craig Topperd3e57812017-11-12 02:28:21 +00005119 }
Chris Lattner2188e402010-01-04 07:37:31 +00005120
Nikolai Bozhenov0e7ebbc2017-10-16 09:19:21 +00005121 // Do this after checking for min/max to prevent infinite looping.
5122 if (Instruction *Res = foldICmpWithZero(I))
5123 return Res;
5124
Sanjay Patelfebcb9c2017-01-27 23:26:27 +00005125 // FIXME: We only do this after checking for min/max to prevent infinite
5126 // looping caused by a reverse canonicalization of these patterns for min/max.
5127 // FIXME: The organization of folds is a mess. These would naturally go into
5128 // canonicalizeCmpWithConstant(), but we can't move all of the above folds
5129 // down here after the min/max restriction.
5130 ICmpInst::Predicate Pred = I.getPredicate();
5131 const APInt *C;
5132 if (match(Op1, m_APInt(C))) {
5133 // For i32: x >u 2147483647 -> x <s 0 -> true if sign bit set
5134 if (Pred == ICmpInst::ICMP_UGT && C->isMaxSignedValue()) {
5135 Constant *Zero = Constant::getNullValue(Op0->getType());
5136 return new ICmpInst(ICmpInst::ICMP_SLT, Op0, Zero);
5137 }
5138
5139 // For i32: x <u 2147483648 -> x >s -1 -> true if sign bit clear
5140 if (Pred == ICmpInst::ICMP_ULT && C->isMinSignedValue()) {
5141 Constant *AllOnes = Constant::getAllOnesValue(Op0->getType());
5142 return new ICmpInst(ICmpInst::ICMP_SGT, Op0, AllOnes);
5143 }
5144 }
5145
Sanjay Patelf58f68c2016-09-10 15:03:44 +00005146 if (Instruction *Res = foldICmpInstWithConstant(I))
Sanjay Patel1271bf92016-07-23 13:06:49 +00005147 return Res;
5148
Sanjay Patel10494b22016-09-16 16:10:22 +00005149 if (Instruction *Res = foldICmpInstWithConstantNotInt(I))
5150 return Res;
Chris Lattner2188e402010-01-04 07:37:31 +00005151
5152 // If we can optimize a 'icmp GEP, P' or 'icmp P, GEP', do so now.
5153 if (GEPOperator *GEP = dyn_cast<GEPOperator>(Op0))
Sanjay Patel43395062016-07-21 18:07:40 +00005154 if (Instruction *NI = foldGEPICmp(GEP, Op1, I.getPredicate(), I))
Chris Lattner2188e402010-01-04 07:37:31 +00005155 return NI;
5156 if (GEPOperator *GEP = dyn_cast<GEPOperator>(Op1))
Sanjay Patel43395062016-07-21 18:07:40 +00005157 if (Instruction *NI = foldGEPICmp(GEP, Op0,
Chris Lattner2188e402010-01-04 07:37:31 +00005158 ICmpInst::getSwappedPredicate(I.getPredicate()), I))
5159 return NI;
5160
Hans Wennborgf1f36512015-10-07 00:20:07 +00005161 // Try to optimize equality comparisons against alloca-based pointers.
5162 if (Op0->getType()->isPointerTy() && I.isEquality()) {
5163 assert(Op1->getType()->isPointerTy() && "Comparing pointer with non-pointer?");
5164 if (auto *Alloca = dyn_cast<AllocaInst>(GetUnderlyingObject(Op0, DL)))
Sanjay Patel43395062016-07-21 18:07:40 +00005165 if (Instruction *New = foldAllocaCmp(I, Alloca, Op1))
Hans Wennborgf1f36512015-10-07 00:20:07 +00005166 return New;
5167 if (auto *Alloca = dyn_cast<AllocaInst>(GetUnderlyingObject(Op1, DL)))
Sanjay Patel43395062016-07-21 18:07:40 +00005168 if (Instruction *New = foldAllocaCmp(I, Alloca, Op0))
Hans Wennborgf1f36512015-10-07 00:20:07 +00005169 return New;
5170 }
5171
Sanjay Patele7f46c32019-02-07 20:54:09 +00005172 if (Instruction *Res = foldICmpBitCast(I, Builder))
5173 return Res;
Jim Grosbach129c52a2011-09-30 18:09:53 +00005174
Chris Lattner2188e402010-01-04 07:37:31 +00005175 if (isa<CastInst>(Op0)) {
5176 // Handle the special case of: icmp (cast bool to X), <cst>
5177 // This comes up when you have code like
5178 // int X = A < B;
5179 // if (X) ...
5180 // For generality, we handle any zero-extension of any operand comparison
5181 // with a constant or another cast from the same type.
5182 if (isa<Constant>(Op1) || isa<CastInst>(Op1))
Sanjay Patel43395062016-07-21 18:07:40 +00005183 if (Instruction *R = foldICmpWithCastAndCast(I))
Chris Lattner2188e402010-01-04 07:37:31 +00005184 return R;
5185 }
Chris Lattner2188e402010-01-04 07:37:31 +00005186
Sanjay Patel10494b22016-09-16 16:10:22 +00005187 if (Instruction *Res = foldICmpBinOp(I))
5188 return Res;
Duncan Sandse5220012011-02-17 07:46:37 +00005189
Sanjay Pateldd46b522016-12-19 17:32:37 +00005190 if (Instruction *Res = foldICmpWithMinMax(I))
Sanjay Pateld6406412016-12-15 19:13:37 +00005191 return Res;
5192
Sanjay Patel10494b22016-09-16 16:10:22 +00005193 {
5194 Value *A, *B;
David Majnemer1a08acc2013-04-12 17:25:07 +00005195 // Transform (A & ~B) == 0 --> (A & B) != 0
5196 // and (A & ~B) != 0 --> (A & B) == 0
5197 // if A is a power of 2.
5198 if (match(Op0, m_And(m_Value(A), m_Not(m_Value(B)))) &&
Chandler Carruth66b31302015-01-04 12:03:27 +00005199 match(Op1, m_Zero()) &&
Craig Topperd4039f72017-05-25 21:51:12 +00005200 isKnownToBeAPowerOfTwo(A, false, 0, &I) && I.isEquality())
Craig Topperbb4069e2017-07-07 23:16:26 +00005201 return new ICmpInst(I.getInversePredicate(), Builder.CreateAnd(A, B),
David Majnemer1a08acc2013-04-12 17:25:07 +00005202 Op1);
5203
Sanjay Patel4dc85eb2017-06-02 16:11:14 +00005204 // ~X < ~Y --> Y < X
5205 // ~X < C --> X > ~C
Chris Lattnerf3c4eef2011-01-15 05:41:33 +00005206 if (match(Op0, m_Not(m_Value(A)))) {
5207 if (match(Op1, m_Not(m_Value(B))))
5208 return new ICmpInst(I.getPredicate(), B, A);
Sanjay Patel4dc85eb2017-06-02 16:11:14 +00005209
Sanjay Patelce241f42017-06-02 16:29:41 +00005210 const APInt *C;
5211 if (match(Op1, m_APInt(C)))
Sanjay Patel4dc85eb2017-06-02 16:11:14 +00005212 return new ICmpInst(I.getSwappedPredicate(), A,
Sanjay Patelce241f42017-06-02 16:29:41 +00005213 ConstantInt::get(Op1->getType(), ~(*C)));
Chris Lattnerf3c4eef2011-01-15 05:41:33 +00005214 }
Chris Lattner5e0c0c72010-12-19 19:37:52 +00005215
Sanjoy Dasb6c59142015-04-10 21:07:09 +00005216 Instruction *AddI = nullptr;
5217 if (match(&I, m_UAddWithOverflow(m_Value(A), m_Value(B),
5218 m_Instruction(AddI))) &&
5219 isa<IntegerType>(A->getType())) {
5220 Value *Result;
5221 Constant *Overflow;
Nikita Popov352f5982019-05-26 11:43:31 +00005222 if (OptimizeOverflowCheck(Instruction::Add, /*Signed*/false, A, B,
5223 *AddI, Result, Overflow)) {
Sanjay Patel4b198802016-02-01 22:23:39 +00005224 replaceInstUsesWith(*AddI, Result);
5225 return replaceInstUsesWith(I, Overflow);
Sanjoy Dasb6c59142015-04-10 21:07:09 +00005226 }
5227 }
Serge Pavlov4bb54d52014-04-13 18:23:41 +00005228
5229 // (zext a) * (zext b) --> llvm.umul.with.overflow.
5230 if (match(Op0, m_Mul(m_ZExt(m_Value(A)), m_ZExt(m_Value(B))))) {
Sanjay Pateld93c4c02016-09-15 18:22:25 +00005231 if (Instruction *R = processUMulZExtIdiom(I, Op0, Op1, *this))
Serge Pavlov4bb54d52014-04-13 18:23:41 +00005232 return R;
5233 }
5234 if (match(Op1, m_Mul(m_ZExt(m_Value(A)), m_ZExt(m_Value(B))))) {
Sanjay Pateld93c4c02016-09-15 18:22:25 +00005235 if (Instruction *R = processUMulZExtIdiom(I, Op1, Op0, *this))
Serge Pavlov4bb54d52014-04-13 18:23:41 +00005236 return R;
5237 }
Chris Lattner2188e402010-01-04 07:37:31 +00005238 }
Jim Grosbach129c52a2011-09-30 18:09:53 +00005239
Sanjay Patel10494b22016-09-16 16:10:22 +00005240 if (Instruction *Res = foldICmpEquality(I))
5241 return Res;
Jim Grosbach129c52a2011-09-30 18:09:53 +00005242
David Majnemerc1eca5a2014-11-06 23:23:30 +00005243 // The 'cmpxchg' instruction returns an aggregate containing the old value and
5244 // an i1 which indicates whether or not we successfully did the swap.
5245 //
5246 // Replace comparisons between the old value and the expected value with the
5247 // indicator that 'cmpxchg' returns.
5248 //
5249 // N.B. This transform is only valid when the 'cmpxchg' is not permitted to
5250 // spuriously fail. In those cases, the old value may equal the expected
5251 // value but it is possible for the swap to not occur.
5252 if (I.getPredicate() == ICmpInst::ICMP_EQ)
5253 if (auto *EVI = dyn_cast<ExtractValueInst>(Op0))
5254 if (auto *ACXI = dyn_cast<AtomicCmpXchgInst>(EVI->getAggregateOperand()))
5255 if (EVI->getIndices()[0] == 0 && ACXI->getCompareOperand() == Op1 &&
5256 !ACXI->isWeak())
5257 return ExtractValueInst::Create(ACXI, 1);
5258
Chris Lattner2188e402010-01-04 07:37:31 +00005259 {
Craig Topperbee74792018-08-20 23:04:25 +00005260 Value *X;
5261 const APInt *C;
Chris Lattner2188e402010-01-04 07:37:31 +00005262 // icmp X+Cst, X
Craig Topperbee74792018-08-20 23:04:25 +00005263 if (match(Op0, m_Add(m_Value(X), m_APInt(C))) && Op1 == X)
5264 return foldICmpAddOpConst(X, *C, I.getPredicate());
Chris Lattner2188e402010-01-04 07:37:31 +00005265
5266 // icmp X, X+Cst
Craig Topperbee74792018-08-20 23:04:25 +00005267 if (match(Op1, m_Add(m_Value(X), m_APInt(C))) && Op0 == X)
5268 return foldICmpAddOpConst(X, *C, I.getSwappedPredicate());
Chris Lattner2188e402010-01-04 07:37:31 +00005269 }
Roman Lebedev68d54cf2018-07-11 19:05:04 +00005270
Roman Lebedev75404fb2018-09-12 18:19:43 +00005271 if (Instruction *Res = foldICmpWithHighBitMask(I, Builder))
5272 return Res;
5273
Sanjay Patel039f5562018-08-16 12:52:17 +00005274 if (I.getType()->isVectorTy())
5275 if (Instruction *Res = foldVectorCmp(I, Builder))
5276 return Res;
5277
Craig Topperf40110f2014-04-25 05:29:35 +00005278 return Changed ? &I : nullptr;
Chris Lattner2188e402010-01-04 07:37:31 +00005279}
5280
Sanjay Patel5f0217f2016-06-05 16:46:18 +00005281/// Fold fcmp ([us]itofp x, cst) if possible.
Sanjay Patel43395062016-07-21 18:07:40 +00005282Instruction *InstCombiner::foldFCmpIntToFPConst(FCmpInst &I, Instruction *LHSI,
Chris Lattner2188e402010-01-04 07:37:31 +00005283 Constant *RHSC) {
Craig Topperf40110f2014-04-25 05:29:35 +00005284 if (!isa<ConstantFP>(RHSC)) return nullptr;
Chris Lattner2188e402010-01-04 07:37:31 +00005285 const APFloat &RHS = cast<ConstantFP>(RHSC)->getValueAPF();
Jim Grosbach129c52a2011-09-30 18:09:53 +00005286
Chris Lattner2188e402010-01-04 07:37:31 +00005287 // Get the width of the mantissa. We don't want to hack on conversions that
5288 // might lose information from the integer, e.g. "i64 -> float"
5289 int MantissaWidth = LHSI->getType()->getFPMantissaWidth();
Craig Topperf40110f2014-04-25 05:29:35 +00005290 if (MantissaWidth == -1) return nullptr; // Unknown.
Jim Grosbach129c52a2011-09-30 18:09:53 +00005291
Matt Arsenault55e73122015-01-06 15:50:59 +00005292 IntegerType *IntTy = cast<IntegerType>(LHSI->getOperand(0)->getType());
5293
Chris Lattner2188e402010-01-04 07:37:31 +00005294 bool LHSUnsigned = isa<UIToFPInst>(LHSI);
Jim Grosbach129c52a2011-09-30 18:09:53 +00005295
Matt Arsenault55e73122015-01-06 15:50:59 +00005296 if (I.isEquality()) {
5297 FCmpInst::Predicate P = I.getPredicate();
5298 bool IsExact = false;
5299 APSInt RHSCvt(IntTy->getBitWidth(), LHSUnsigned);
5300 RHS.convertToInteger(RHSCvt, APFloat::rmNearestTiesToEven, &IsExact);
5301
5302 // If the floating point constant isn't an integer value, we know if we will
5303 // ever compare equal / not equal to it.
5304 if (!IsExact) {
5305 // TODO: Can never be -0.0 and other non-representable values
5306 APFloat RHSRoundInt(RHS);
5307 RHSRoundInt.roundToIntegral(APFloat::rmNearestTiesToEven);
5308 if (RHS.compare(RHSRoundInt) != APFloat::cmpEqual) {
5309 if (P == FCmpInst::FCMP_OEQ || P == FCmpInst::FCMP_UEQ)
Craig Topperbb4069e2017-07-07 23:16:26 +00005310 return replaceInstUsesWith(I, Builder.getFalse());
Matt Arsenault55e73122015-01-06 15:50:59 +00005311
5312 assert(P == FCmpInst::FCMP_ONE || P == FCmpInst::FCMP_UNE);
Craig Topperbb4069e2017-07-07 23:16:26 +00005313 return replaceInstUsesWith(I, Builder.getTrue());
Matt Arsenault55e73122015-01-06 15:50:59 +00005314 }
5315 }
5316
5317 // TODO: If the constant is exactly representable, is it always OK to do
5318 // equality compares as integer?
5319 }
5320
Arch D. Robison8ed08542015-09-15 17:51:59 +00005321 // Check to see that the input is converted from an integer type that is small
5322 // enough that preserves all bits. TODO: check here for "known" sign bits.
5323 // This would allow us to handle (fptosi (x >>s 62) to float) if x is i64 f.e.
5324 unsigned InputSize = IntTy->getScalarSizeInBits();
Matt Arsenault55e73122015-01-06 15:50:59 +00005325
Justin Bognerc7e4fbe2016-08-05 01:09:48 +00005326 // Following test does NOT adjust InputSize downwards for signed inputs,
5327 // because the most negative value still requires all the mantissa bits
Arch D. Robison8ed08542015-09-15 17:51:59 +00005328 // to distinguish it from one less than that value.
5329 if ((int)InputSize > MantissaWidth) {
5330 // Conversion would lose accuracy. Check if loss can impact comparison.
5331 int Exp = ilogb(RHS);
5332 if (Exp == APFloat::IEK_Inf) {
5333 int MaxExponent = ilogb(APFloat::getLargest(RHS.getSemantics()));
Justin Bognerc7e4fbe2016-08-05 01:09:48 +00005334 if (MaxExponent < (int)InputSize - !LHSUnsigned)
Arch D. Robison8ed08542015-09-15 17:51:59 +00005335 // Conversion could create infinity.
5336 return nullptr;
5337 } else {
Justin Bognerc7e4fbe2016-08-05 01:09:48 +00005338 // Note that if RHS is zero or NaN, then Exp is negative
Arch D. Robison8ed08542015-09-15 17:51:59 +00005339 // and first condition is trivially false.
Justin Bognerc7e4fbe2016-08-05 01:09:48 +00005340 if (MantissaWidth <= Exp && Exp <= (int)InputSize - !LHSUnsigned)
Arch D. Robison8ed08542015-09-15 17:51:59 +00005341 // Conversion could affect comparison.
5342 return nullptr;
5343 }
5344 }
Jim Grosbach129c52a2011-09-30 18:09:53 +00005345
Chris Lattner2188e402010-01-04 07:37:31 +00005346 // Otherwise, we can potentially simplify the comparison. We know that it
5347 // will always come through as an integer value and we know the constant is
5348 // not a NAN (it would have been previously simplified).
5349 assert(!RHS.isNaN() && "NaN comparison not already folded!");
Jim Grosbach129c52a2011-09-30 18:09:53 +00005350
Chris Lattner2188e402010-01-04 07:37:31 +00005351 ICmpInst::Predicate Pred;
5352 switch (I.getPredicate()) {
5353 default: llvm_unreachable("Unexpected predicate!");
5354 case FCmpInst::FCMP_UEQ:
5355 case FCmpInst::FCMP_OEQ:
5356 Pred = ICmpInst::ICMP_EQ;
5357 break;
5358 case FCmpInst::FCMP_UGT:
5359 case FCmpInst::FCMP_OGT:
5360 Pred = LHSUnsigned ? ICmpInst::ICMP_UGT : ICmpInst::ICMP_SGT;
5361 break;
5362 case FCmpInst::FCMP_UGE:
5363 case FCmpInst::FCMP_OGE:
5364 Pred = LHSUnsigned ? ICmpInst::ICMP_UGE : ICmpInst::ICMP_SGE;
5365 break;
5366 case FCmpInst::FCMP_ULT:
5367 case FCmpInst::FCMP_OLT:
5368 Pred = LHSUnsigned ? ICmpInst::ICMP_ULT : ICmpInst::ICMP_SLT;
5369 break;
5370 case FCmpInst::FCMP_ULE:
5371 case FCmpInst::FCMP_OLE:
5372 Pred = LHSUnsigned ? ICmpInst::ICMP_ULE : ICmpInst::ICMP_SLE;
5373 break;
5374 case FCmpInst::FCMP_UNE:
5375 case FCmpInst::FCMP_ONE:
5376 Pred = ICmpInst::ICMP_NE;
5377 break;
5378 case FCmpInst::FCMP_ORD:
Craig Topperbb4069e2017-07-07 23:16:26 +00005379 return replaceInstUsesWith(I, Builder.getTrue());
Chris Lattner2188e402010-01-04 07:37:31 +00005380 case FCmpInst::FCMP_UNO:
Craig Topperbb4069e2017-07-07 23:16:26 +00005381 return replaceInstUsesWith(I, Builder.getFalse());
Chris Lattner2188e402010-01-04 07:37:31 +00005382 }
Jim Grosbach129c52a2011-09-30 18:09:53 +00005383
Chris Lattner2188e402010-01-04 07:37:31 +00005384 // Now we know that the APFloat is a normal number, zero or inf.
Jim Grosbach129c52a2011-09-30 18:09:53 +00005385
Chris Lattner2188e402010-01-04 07:37:31 +00005386 // See if the FP constant is too large for the integer. For example,
5387 // comparing an i8 to 300.0.
5388 unsigned IntWidth = IntTy->getScalarSizeInBits();
Jim Grosbach129c52a2011-09-30 18:09:53 +00005389
Chris Lattner2188e402010-01-04 07:37:31 +00005390 if (!LHSUnsigned) {
5391 // If the RHS value is > SignedMax, fold the comparison. This handles +INF
5392 // and large values.
Michael Gottesman79b09672013-06-27 21:58:19 +00005393 APFloat SMax(RHS.getSemantics());
Chris Lattner2188e402010-01-04 07:37:31 +00005394 SMax.convertFromAPInt(APInt::getSignedMaxValue(IntWidth), true,
5395 APFloat::rmNearestTiesToEven);
5396 if (SMax.compare(RHS) == APFloat::cmpLessThan) { // smax < 13123.0
5397 if (Pred == ICmpInst::ICMP_NE || Pred == ICmpInst::ICMP_SLT ||
5398 Pred == ICmpInst::ICMP_SLE)
Craig Topperbb4069e2017-07-07 23:16:26 +00005399 return replaceInstUsesWith(I, Builder.getTrue());
5400 return replaceInstUsesWith(I, Builder.getFalse());
Chris Lattner2188e402010-01-04 07:37:31 +00005401 }
5402 } else {
5403 // If the RHS value is > UnsignedMax, fold the comparison. This handles
5404 // +INF and large values.
Michael Gottesman79b09672013-06-27 21:58:19 +00005405 APFloat UMax(RHS.getSemantics());
Chris Lattner2188e402010-01-04 07:37:31 +00005406 UMax.convertFromAPInt(APInt::getMaxValue(IntWidth), false,
5407 APFloat::rmNearestTiesToEven);
5408 if (UMax.compare(RHS) == APFloat::cmpLessThan) { // umax < 13123.0
5409 if (Pred == ICmpInst::ICMP_NE || Pred == ICmpInst::ICMP_ULT ||
5410 Pred == ICmpInst::ICMP_ULE)
Craig Topperbb4069e2017-07-07 23:16:26 +00005411 return replaceInstUsesWith(I, Builder.getTrue());
5412 return replaceInstUsesWith(I, Builder.getFalse());
Chris Lattner2188e402010-01-04 07:37:31 +00005413 }
5414 }
Jim Grosbach129c52a2011-09-30 18:09:53 +00005415
Chris Lattner2188e402010-01-04 07:37:31 +00005416 if (!LHSUnsigned) {
5417 // See if the RHS value is < SignedMin.
Michael Gottesman79b09672013-06-27 21:58:19 +00005418 APFloat SMin(RHS.getSemantics());
Chris Lattner2188e402010-01-04 07:37:31 +00005419 SMin.convertFromAPInt(APInt::getSignedMinValue(IntWidth), true,
5420 APFloat::rmNearestTiesToEven);
5421 if (SMin.compare(RHS) == APFloat::cmpGreaterThan) { // smin > 12312.0
5422 if (Pred == ICmpInst::ICMP_NE || Pred == ICmpInst::ICMP_SGT ||
5423 Pred == ICmpInst::ICMP_SGE)
Craig Topperbb4069e2017-07-07 23:16:26 +00005424 return replaceInstUsesWith(I, Builder.getTrue());
5425 return replaceInstUsesWith(I, Builder.getFalse());
Chris Lattner2188e402010-01-04 07:37:31 +00005426 }
Devang Patel698452b2012-02-13 23:05:18 +00005427 } else {
5428 // See if the RHS value is < UnsignedMin.
Michael Gottesman79b09672013-06-27 21:58:19 +00005429 APFloat SMin(RHS.getSemantics());
Devang Patel698452b2012-02-13 23:05:18 +00005430 SMin.convertFromAPInt(APInt::getMinValue(IntWidth), true,
5431 APFloat::rmNearestTiesToEven);
5432 if (SMin.compare(RHS) == APFloat::cmpGreaterThan) { // umin > 12312.0
5433 if (Pred == ICmpInst::ICMP_NE || Pred == ICmpInst::ICMP_UGT ||
5434 Pred == ICmpInst::ICMP_UGE)
Craig Topperbb4069e2017-07-07 23:16:26 +00005435 return replaceInstUsesWith(I, Builder.getTrue());
5436 return replaceInstUsesWith(I, Builder.getFalse());
Devang Patel698452b2012-02-13 23:05:18 +00005437 }
Chris Lattner2188e402010-01-04 07:37:31 +00005438 }
5439
5440 // Okay, now we know that the FP constant fits in the range [SMIN, SMAX] or
5441 // [0, UMAX], but it may still be fractional. See if it is fractional by
5442 // casting the FP value to the integer value and back, checking for equality.
5443 // Don't do this for zero, because -0.0 is not fractional.
5444 Constant *RHSInt = LHSUnsigned
5445 ? ConstantExpr::getFPToUI(RHSC, IntTy)
5446 : ConstantExpr::getFPToSI(RHSC, IntTy);
5447 if (!RHS.isZero()) {
5448 bool Equal = LHSUnsigned
5449 ? ConstantExpr::getUIToFP(RHSInt, RHSC->getType()) == RHSC
5450 : ConstantExpr::getSIToFP(RHSInt, RHSC->getType()) == RHSC;
5451 if (!Equal) {
5452 // If we had a comparison against a fractional value, we have to adjust
5453 // the compare predicate and sometimes the value. RHSC is rounded towards
5454 // zero at this point.
5455 switch (Pred) {
5456 default: llvm_unreachable("Unexpected integer comparison!");
5457 case ICmpInst::ICMP_NE: // (float)int != 4.4 --> true
Craig Topperbb4069e2017-07-07 23:16:26 +00005458 return replaceInstUsesWith(I, Builder.getTrue());
Chris Lattner2188e402010-01-04 07:37:31 +00005459 case ICmpInst::ICMP_EQ: // (float)int == 4.4 --> false
Craig Topperbb4069e2017-07-07 23:16:26 +00005460 return replaceInstUsesWith(I, Builder.getFalse());
Chris Lattner2188e402010-01-04 07:37:31 +00005461 case ICmpInst::ICMP_ULE:
5462 // (float)int <= 4.4 --> int <= 4
5463 // (float)int <= -4.4 --> false
5464 if (RHS.isNegative())
Craig Topperbb4069e2017-07-07 23:16:26 +00005465 return replaceInstUsesWith(I, Builder.getFalse());
Chris Lattner2188e402010-01-04 07:37:31 +00005466 break;
5467 case ICmpInst::ICMP_SLE:
5468 // (float)int <= 4.4 --> int <= 4
5469 // (float)int <= -4.4 --> int < -4
5470 if (RHS.isNegative())
5471 Pred = ICmpInst::ICMP_SLT;
5472 break;
5473 case ICmpInst::ICMP_ULT:
5474 // (float)int < -4.4 --> false
5475 // (float)int < 4.4 --> int <= 4
5476 if (RHS.isNegative())
Craig Topperbb4069e2017-07-07 23:16:26 +00005477 return replaceInstUsesWith(I, Builder.getFalse());
Chris Lattner2188e402010-01-04 07:37:31 +00005478 Pred = ICmpInst::ICMP_ULE;
5479 break;
5480 case ICmpInst::ICMP_SLT:
5481 // (float)int < -4.4 --> int < -4
5482 // (float)int < 4.4 --> int <= 4
5483 if (!RHS.isNegative())
5484 Pred = ICmpInst::ICMP_SLE;
5485 break;
5486 case ICmpInst::ICMP_UGT:
5487 // (float)int > 4.4 --> int > 4
5488 // (float)int > -4.4 --> true
5489 if (RHS.isNegative())
Craig Topperbb4069e2017-07-07 23:16:26 +00005490 return replaceInstUsesWith(I, Builder.getTrue());
Chris Lattner2188e402010-01-04 07:37:31 +00005491 break;
5492 case ICmpInst::ICMP_SGT:
5493 // (float)int > 4.4 --> int > 4
5494 // (float)int > -4.4 --> int >= -4
5495 if (RHS.isNegative())
5496 Pred = ICmpInst::ICMP_SGE;
5497 break;
5498 case ICmpInst::ICMP_UGE:
5499 // (float)int >= -4.4 --> true
5500 // (float)int >= 4.4 --> int > 4
Bob Wilson61f3ad52012-08-07 22:35:16 +00005501 if (RHS.isNegative())
Craig Topperbb4069e2017-07-07 23:16:26 +00005502 return replaceInstUsesWith(I, Builder.getTrue());
Chris Lattner2188e402010-01-04 07:37:31 +00005503 Pred = ICmpInst::ICMP_UGT;
5504 break;
5505 case ICmpInst::ICMP_SGE:
5506 // (float)int >= -4.4 --> int >= -4
5507 // (float)int >= 4.4 --> int > 4
5508 if (!RHS.isNegative())
5509 Pred = ICmpInst::ICMP_SGT;
5510 break;
5511 }
5512 }
5513 }
5514
5515 // Lower this FP comparison into an appropriate integer version of the
5516 // comparison.
5517 return new ICmpInst(Pred, LHSI->getOperand(0), RHSInt);
5518}
5519
Sanjay Patelc3f50ff2018-09-27 15:59:24 +00005520/// Fold (C / X) < 0.0 --> X < 0.0 if possible. Swap predicate if necessary.
5521static Instruction *foldFCmpReciprocalAndZero(FCmpInst &I, Instruction *LHSI,
5522 Constant *RHSC) {
5523 // When C is not 0.0 and infinities are not allowed:
5524 // (C / X) < 0.0 is a sign-bit test of X
5525 // (C / X) < 0.0 --> X < 0.0 (if C is positive)
5526 // (C / X) < 0.0 --> X > 0.0 (if C is negative, swap the predicate)
5527 //
5528 // Proof:
5529 // Multiply (C / X) < 0.0 by X * X / C.
5530 // - X is non zero, if it is the flag 'ninf' is violated.
5531 // - C defines the sign of X * X * C. Thus it also defines whether to swap
5532 // the predicate. C is also non zero by definition.
5533 //
5534 // Thus X * X / C is non zero and the transformation is valid. [qed]
5535
5536 FCmpInst::Predicate Pred = I.getPredicate();
5537
5538 // Check that predicates are valid.
5539 if ((Pred != FCmpInst::FCMP_OGT) && (Pred != FCmpInst::FCMP_OLT) &&
5540 (Pred != FCmpInst::FCMP_OGE) && (Pred != FCmpInst::FCMP_OLE))
5541 return nullptr;
5542
5543 // Check that RHS operand is zero.
5544 if (!match(RHSC, m_AnyZeroFP()))
5545 return nullptr;
5546
5547 // Check fastmath flags ('ninf').
5548 if (!LHSI->hasNoInfs() || !I.hasNoInfs())
5549 return nullptr;
5550
5551 // Check the properties of the dividend. It must not be zero to avoid a
5552 // division by zero (see Proof).
5553 const APFloat *C;
5554 if (!match(LHSI->getOperand(0), m_APFloat(C)))
5555 return nullptr;
5556
5557 if (C->isZero())
5558 return nullptr;
5559
5560 // Get swapped predicate if necessary.
5561 if (C->isNegative())
5562 Pred = I.getSwappedPredicate();
5563
Sanjay Pateld1172a02018-11-07 00:00:42 +00005564 return new FCmpInst(Pred, LHSI->getOperand(1), RHSC, "", &I);
Sanjay Patelc3f50ff2018-09-27 15:59:24 +00005565}
5566
Sanjay Patel1c254c62018-10-31 16:34:43 +00005567/// Optimize fabs(X) compared with zero.
5568static Instruction *foldFabsWithFcmpZero(FCmpInst &I) {
5569 Value *X;
5570 if (!match(I.getOperand(0), m_Intrinsic<Intrinsic::fabs>(m_Value(X))) ||
5571 !match(I.getOperand(1), m_PosZeroFP()))
5572 return nullptr;
5573
Sanjay Patel57a08b32018-11-07 16:15:01 +00005574 auto replacePredAndOp0 = [](FCmpInst *I, FCmpInst::Predicate P, Value *X) {
5575 I->setPredicate(P);
5576 I->setOperand(0, X);
5577 return I;
5578 };
5579
Sanjay Patel1c254c62018-10-31 16:34:43 +00005580 switch (I.getPredicate()) {
5581 case FCmpInst::FCMP_UGE:
5582 case FCmpInst::FCMP_OLT:
5583 // fabs(X) >= 0.0 --> true
5584 // fabs(X) < 0.0 --> false
5585 llvm_unreachable("fcmp should have simplified");
5586
5587 case FCmpInst::FCMP_OGT:
5588 // fabs(X) > 0.0 --> X != 0.0
Sanjay Patel57a08b32018-11-07 16:15:01 +00005589 return replacePredAndOp0(&I, FCmpInst::FCMP_ONE, X);
Sanjay Patel1c254c62018-10-31 16:34:43 +00005590
Sanjay Patelfa5f1462018-11-07 15:33:03 +00005591 case FCmpInst::FCMP_UGT:
5592 // fabs(X) u> 0.0 --> X u!= 0.0
Sanjay Patel57a08b32018-11-07 16:15:01 +00005593 return replacePredAndOp0(&I, FCmpInst::FCMP_UNE, X);
Sanjay Patelfa5f1462018-11-07 15:33:03 +00005594
Sanjay Patel1c254c62018-10-31 16:34:43 +00005595 case FCmpInst::FCMP_OLE:
5596 // fabs(X) <= 0.0 --> X == 0.0
Sanjay Patel57a08b32018-11-07 16:15:01 +00005597 return replacePredAndOp0(&I, FCmpInst::FCMP_OEQ, X);
Sanjay Patel1c254c62018-10-31 16:34:43 +00005598
Sanjay Patelfa5f1462018-11-07 15:33:03 +00005599 case FCmpInst::FCMP_ULE:
5600 // fabs(X) u<= 0.0 --> X u== 0.0
Sanjay Patel57a08b32018-11-07 16:15:01 +00005601 return replacePredAndOp0(&I, FCmpInst::FCMP_UEQ, X);
Sanjay Patelfa5f1462018-11-07 15:33:03 +00005602
Sanjay Patel1c254c62018-10-31 16:34:43 +00005603 case FCmpInst::FCMP_OGE:
5604 // fabs(X) >= 0.0 --> !isnan(X)
5605 assert(!I.hasNoNaNs() && "fcmp should have simplified");
Sanjay Patel57a08b32018-11-07 16:15:01 +00005606 return replacePredAndOp0(&I, FCmpInst::FCMP_ORD, X);
Sanjay Patel1c254c62018-10-31 16:34:43 +00005607
Sanjay Patel76faf512018-11-07 15:11:32 +00005608 case FCmpInst::FCMP_ULT:
5609 // fabs(X) u< 0.0 --> isnan(X)
5610 assert(!I.hasNoNaNs() && "fcmp should have simplified");
Sanjay Patel57a08b32018-11-07 16:15:01 +00005611 return replacePredAndOp0(&I, FCmpInst::FCMP_UNO, X);
Sanjay Patel76faf512018-11-07 15:11:32 +00005612
Sanjay Patel1c254c62018-10-31 16:34:43 +00005613 case FCmpInst::FCMP_OEQ:
5614 case FCmpInst::FCMP_UEQ:
5615 case FCmpInst::FCMP_ONE:
5616 case FCmpInst::FCMP_UNE:
Sanjay Patelbb521e62018-11-07 15:44:26 +00005617 case FCmpInst::FCMP_ORD:
5618 case FCmpInst::FCMP_UNO:
5619 // Look through the fabs() because it doesn't change anything but the sign.
5620 // fabs(X) == 0.0 --> X == 0.0,
Sanjay Patel1c254c62018-10-31 16:34:43 +00005621 // fabs(X) != 0.0 --> X != 0.0
Sanjay Patelbb521e62018-11-07 15:44:26 +00005622 // isnan(fabs(X)) --> isnan(X)
5623 // !isnan(fabs(X) --> !isnan(X)
Sanjay Patel57a08b32018-11-07 16:15:01 +00005624 return replacePredAndOp0(&I, I.getPredicate(), X);
Sanjay Patel1c254c62018-10-31 16:34:43 +00005625
5626 default:
5627 return nullptr;
5628 }
5629}
5630
Chris Lattner2188e402010-01-04 07:37:31 +00005631Instruction *InstCombiner::visitFCmpInst(FCmpInst &I) {
5632 bool Changed = false;
Jim Grosbach129c52a2011-09-30 18:09:53 +00005633
Chris Lattner2188e402010-01-04 07:37:31 +00005634 /// Orders the operands of the compare so that they are listed from most
5635 /// complex to least complex. This puts constants before unary operators,
5636 /// before binary operators.
5637 if (getComplexity(I.getOperand(0)) < getComplexity(I.getOperand(1))) {
5638 I.swapOperands();
5639 Changed = true;
5640 }
5641
Sanjay Patel6b139462017-09-02 15:11:55 +00005642 const CmpInst::Predicate Pred = I.getPredicate();
Chris Lattner2188e402010-01-04 07:37:31 +00005643 Value *Op0 = I.getOperand(0), *Op1 = I.getOperand(1);
Sanjay Patel6b139462017-09-02 15:11:55 +00005644 if (Value *V = SimplifyFCmpInst(Pred, Op0, Op1, I.getFastMathFlags(),
5645 SQ.getWithInstruction(&I)))
Sanjay Patel4b198802016-02-01 22:23:39 +00005646 return replaceInstUsesWith(I, V);
Chris Lattner2188e402010-01-04 07:37:31 +00005647
5648 // Simplify 'fcmp pred X, X'
Sanjay Patela706b9a2019-04-29 19:23:44 +00005649 Type *OpType = Op0->getType();
5650 assert(OpType == Op1->getType() && "fcmp with different-typed operands?");
Chris Lattner2188e402010-01-04 07:37:31 +00005651 if (Op0 == Op1) {
Sanjay Patel6b139462017-09-02 15:11:55 +00005652 switch (Pred) {
5653 default: break;
Chris Lattner2188e402010-01-04 07:37:31 +00005654 case FCmpInst::FCMP_UNO: // True if unordered: isnan(X) | isnan(Y)
5655 case FCmpInst::FCMP_ULT: // True if unordered or less than
5656 case FCmpInst::FCMP_UGT: // True if unordered or greater than
5657 case FCmpInst::FCMP_UNE: // True if unordered or not equal
5658 // Canonicalize these to be 'fcmp uno %X, 0.0'.
5659 I.setPredicate(FCmpInst::FCMP_UNO);
Sanjay Patela706b9a2019-04-29 19:23:44 +00005660 I.setOperand(1, Constant::getNullValue(OpType));
Chris Lattner2188e402010-01-04 07:37:31 +00005661 return &I;
Jim Grosbach129c52a2011-09-30 18:09:53 +00005662
Chris Lattner2188e402010-01-04 07:37:31 +00005663 case FCmpInst::FCMP_ORD: // True if ordered (no nans)
5664 case FCmpInst::FCMP_OEQ: // True if ordered and equal
5665 case FCmpInst::FCMP_OGE: // True if ordered and greater than or equal
5666 case FCmpInst::FCMP_OLE: // True if ordered and less than or equal
5667 // Canonicalize these to be 'fcmp ord %X, 0.0'.
5668 I.setPredicate(FCmpInst::FCMP_ORD);
Sanjay Patela706b9a2019-04-29 19:23:44 +00005669 I.setOperand(1, Constant::getNullValue(OpType));
Chris Lattner2188e402010-01-04 07:37:31 +00005670 return &I;
5671 }
5672 }
Jim Grosbach129c52a2011-09-30 18:09:53 +00005673
Sanjay Patel6840c5f2017-09-05 23:13:13 +00005674 // If we're just checking for a NaN (ORD/UNO) and have a non-NaN operand,
5675 // then canonicalize the operand to 0.0.
5676 if (Pred == CmpInst::FCMP_ORD || Pred == CmpInst::FCMP_UNO) {
Matt Arsenaultd54b7f02018-08-09 22:40:08 +00005677 if (!match(Op0, m_PosZeroFP()) && isKnownNeverNaN(Op0, &TLI)) {
Sanjay Patela706b9a2019-04-29 19:23:44 +00005678 I.setOperand(0, ConstantFP::getNullValue(OpType));
Sanjay Patel6840c5f2017-09-05 23:13:13 +00005679 return &I;
5680 }
Matt Arsenaultd54b7f02018-08-09 22:40:08 +00005681 if (!match(Op1, m_PosZeroFP()) && isKnownNeverNaN(Op1, &TLI)) {
Sanjay Patela706b9a2019-04-29 19:23:44 +00005682 I.setOperand(1, ConstantFP::getNullValue(OpType));
Sanjay Patel6840c5f2017-09-05 23:13:13 +00005683 return &I;
5684 }
5685 }
5686
Sanjay Patel6a281a72019-05-07 18:58:07 +00005687 // fcmp pred (fneg X), (fneg Y) -> fcmp swap(pred) X, Y
5688 Value *X, *Y;
5689 if (match(Op0, m_FNeg(m_Value(X))) && match(Op1, m_FNeg(m_Value(Y))))
5690 return new FCmpInst(I.getSwappedPredicate(), X, Y, "", &I);
5691
James Molloy2b21a7c2015-05-20 18:41:25 +00005692 // Test if the FCmpInst instruction is used exclusively by a select as
5693 // part of a minimum or maximum operation. If so, refrain from doing
5694 // any other folding. This helps out other analyses which understand
5695 // non-obfuscated minimum and maximum idioms, such as ScalarEvolution
5696 // and CodeGen. And in this case, at least one of the comparison
5697 // operands has at least one user besides the compare (the select),
5698 // which would often largely negate the benefit of folding anyway.
5699 if (I.hasOneUse())
Craig Topperd3e57812017-11-12 02:28:21 +00005700 if (SelectInst *SI = dyn_cast<SelectInst>(I.user_back())) {
5701 Value *A, *B;
5702 SelectPatternResult SPR = matchSelectPattern(SI, A, B);
5703 if (SPR.Flavor != SPF_UNKNOWN)
James Molloy2b21a7c2015-05-20 18:41:25 +00005704 return nullptr;
Craig Topperd3e57812017-11-12 02:28:21 +00005705 }
James Molloy2b21a7c2015-05-20 18:41:25 +00005706
Sanjay Patelc26fd1e2018-11-05 17:26:42 +00005707 // The sign of 0.0 is ignored by fcmp, so canonicalize to +0.0:
5708 // fcmp Pred X, -0.0 --> fcmp Pred X, 0.0
5709 if (match(Op1, m_AnyZeroFP()) && !match(Op1, m_PosZeroFP())) {
Sanjay Patela706b9a2019-04-29 19:23:44 +00005710 I.setOperand(1, ConstantFP::getNullValue(OpType));
Sanjay Patelc26fd1e2018-11-05 17:26:42 +00005711 return &I;
5712 }
5713
Sanjay Patel4c39dfc2018-10-30 20:52:25 +00005714 // Handle fcmp with instruction LHS and constant RHS.
5715 Instruction *LHSI;
5716 Constant *RHSC;
5717 if (match(Op0, m_Instruction(LHSI)) && match(Op1, m_Constant(RHSC))) {
5718 switch (LHSI->getOpcode()) {
Sanjay Patel4c39dfc2018-10-30 20:52:25 +00005719 case Instruction::PHI:
5720 // Only fold fcmp into the PHI if the phi and fcmp are in the same
5721 // block. If in the same block, we're encouraging jump threading. If
5722 // not, we are just pessimizing the code by making an i1 phi.
5723 if (LHSI->getParent() == I.getParent())
5724 if (Instruction *NV = foldOpIntoPhi(I, cast<PHINode>(LHSI)))
Chris Lattner2188e402010-01-04 07:37:31 +00005725 return NV;
Sanjay Patel4c39dfc2018-10-30 20:52:25 +00005726 break;
5727 case Instruction::SIToFP:
5728 case Instruction::UIToFP:
5729 if (Instruction *NV = foldFCmpIntToFPConst(I, LHSI, RHSC))
5730 return NV;
5731 break;
Sanjay Patel4c39dfc2018-10-30 20:52:25 +00005732 case Instruction::FDiv:
5733 if (Instruction *NV = foldFCmpReciprocalAndZero(I, LHSI, RHSC))
5734 return NV;
5735 break;
5736 case Instruction::Load:
5737 if (auto *GEP = dyn_cast<GetElementPtrInst>(LHSI->getOperand(0)))
5738 if (auto *GV = dyn_cast<GlobalVariable>(GEP->getOperand(0)))
5739 if (GV->isConstant() && GV->hasDefinitiveInitializer() &&
5740 !cast<LoadInst>(LHSI)->isVolatile())
5741 if (Instruction *Res = foldCmpLoadFromIndexedGlobal(GEP, GV, I))
5742 return Res;
5743 break;
Sanjay Patel1c254c62018-10-31 16:34:43 +00005744 }
Chris Lattner2188e402010-01-04 07:37:31 +00005745 }
5746
Sanjay Pateld1172a02018-11-07 00:00:42 +00005747 if (Instruction *R = foldFabsWithFcmpZero(I))
5748 return R;
5749
Sanjay Patel70282a02018-11-06 15:49:45 +00005750 if (match(Op0, m_FNeg(m_Value(X)))) {
Sanjay Pateld1172a02018-11-07 00:00:42 +00005751 // fcmp pred (fneg X), C --> fcmp swap(pred) X, -C
Sanjay Patel70282a02018-11-06 15:49:45 +00005752 Constant *C;
5753 if (match(Op1, m_Constant(C))) {
Sanjay Patel70282a02018-11-06 15:49:45 +00005754 Constant *NegC = ConstantExpr::getFNeg(C);
Sanjay Pateld1172a02018-11-07 00:00:42 +00005755 return new FCmpInst(I.getSwappedPredicate(), X, NegC, "", &I);
Sanjay Patel70282a02018-11-06 15:49:45 +00005756 }
5757 }
Benjamin Kramerd159d942011-03-31 10:12:22 +00005758
Sanjay Patel7c3ee4d2018-11-06 16:37:35 +00005759 if (match(Op0, m_FPExt(m_Value(X)))) {
Sanjay Pateld1172a02018-11-07 00:00:42 +00005760 // fcmp (fpext X), (fpext Y) -> fcmp X, Y
5761 if (match(Op1, m_FPExt(m_Value(Y))) && X->getType() == Y->getType())
5762 return new FCmpInst(Pred, X, Y, "", &I);
Sanjay Patel7c3ee4d2018-11-06 16:37:35 +00005763
Sanjay Pateld1172a02018-11-07 00:00:42 +00005764 // fcmp (fpext X), C -> fcmp X, (fptrunc C) if fptrunc is lossless
Sanjay Patel724014a2018-11-06 17:20:20 +00005765 const APFloat *C;
5766 if (match(Op1, m_APFloat(C))) {
Sanjay Patel724014a2018-11-06 17:20:20 +00005767 const fltSemantics &FPSem =
5768 X->getType()->getScalarType()->getFltSemantics();
Sanjay Patel7c3ee4d2018-11-06 16:37:35 +00005769 bool Lossy;
Sanjay Patel724014a2018-11-06 17:20:20 +00005770 APFloat TruncC = *C;
5771 TruncC.convert(FPSem, APFloat::rmNearestTiesToEven, &Lossy);
Sanjay Patel7c3ee4d2018-11-06 16:37:35 +00005772
5773 // Avoid lossy conversions and denormals.
5774 // Zero is a special case that's OK to convert.
Sanjay Patel724014a2018-11-06 17:20:20 +00005775 APFloat Fabs = TruncC;
Sanjay Patel7c3ee4d2018-11-06 16:37:35 +00005776 Fabs.clearSign();
5777 if (!Lossy &&
5778 ((Fabs.compare(APFloat::getSmallestNormalized(FPSem)) !=
Sanjay Patel46bf3922018-11-06 16:45:27 +00005779 APFloat::cmpLessThan) || Fabs.isZero())) {
Sanjay Patel724014a2018-11-06 17:20:20 +00005780 Constant *NewC = ConstantFP::get(X->getType(), TruncC);
Sanjay Pateld1172a02018-11-07 00:00:42 +00005781 return new FCmpInst(Pred, X, NewC, "", &I);
Sanjay Patel46bf3922018-11-06 16:45:27 +00005782 }
Sanjay Patel7c3ee4d2018-11-06 16:37:35 +00005783 }
Sanjay Patel1b85f0022018-11-06 16:23:03 +00005784 }
Benjamin Kramer2ccfbc82011-03-31 10:11:58 +00005785
Sanjay Patel039f5562018-08-16 12:52:17 +00005786 if (I.getType()->isVectorTy())
5787 if (Instruction *Res = foldVectorCmp(I, Builder))
5788 return Res;
5789
Craig Topperf40110f2014-04-25 05:29:35 +00005790 return Changed ? &I : nullptr;
Chris Lattner2188e402010-01-04 07:37:31 +00005791}