blob: 88c4937cfe171ec88bb1041a8eac0d2a9a33cc5f [file] [log] [blame]
David Greenb0aa36f2018-03-29 08:48:15 +00001//===----------------- LoopRotationUtils.cpp -----------------------------===//
2//
Chandler Carruth2946cd72019-01-19 08:50:56 +00003// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
4// See https://llvm.org/LICENSE.txt for license information.
5// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
David Greenb0aa36f2018-03-29 08:48:15 +00006//
7//===----------------------------------------------------------------------===//
8//
9// This file provides utilities to convert a loop into a loop with bottom test.
10//
11//===----------------------------------------------------------------------===//
12
13#include "llvm/Transforms/Utils/LoopRotationUtils.h"
14#include "llvm/ADT/Statistic.h"
15#include "llvm/Analysis/AliasAnalysis.h"
16#include "llvm/Analysis/AssumptionCache.h"
17#include "llvm/Analysis/BasicAliasAnalysis.h"
18#include "llvm/Analysis/CodeMetrics.h"
Richard Trieu5f436fc2019-02-06 02:52:52 +000019#include "llvm/Analysis/DomTreeUpdater.h"
David Greenb0aa36f2018-03-29 08:48:15 +000020#include "llvm/Analysis/GlobalsModRef.h"
21#include "llvm/Analysis/InstructionSimplify.h"
22#include "llvm/Analysis/LoopPass.h"
Alina Sbirleaad4d0182018-10-24 22:46:45 +000023#include "llvm/Analysis/MemorySSA.h"
24#include "llvm/Analysis/MemorySSAUpdater.h"
David Greenb0aa36f2018-03-29 08:48:15 +000025#include "llvm/Analysis/ScalarEvolution.h"
26#include "llvm/Analysis/ScalarEvolutionAliasAnalysis.h"
27#include "llvm/Analysis/TargetTransformInfo.h"
David Greenb0aa36f2018-03-29 08:48:15 +000028#include "llvm/Analysis/ValueTracking.h"
29#include "llvm/IR/CFG.h"
30#include "llvm/IR/DebugInfoMetadata.h"
31#include "llvm/IR/Dominators.h"
32#include "llvm/IR/Function.h"
33#include "llvm/IR/IntrinsicInst.h"
34#include "llvm/IR/Module.h"
35#include "llvm/Support/CommandLine.h"
36#include "llvm/Support/Debug.h"
37#include "llvm/Support/raw_ostream.h"
David Greenb0aa36f2018-03-29 08:48:15 +000038#include "llvm/Transforms/Utils/BasicBlockUtils.h"
Chijun Sima21a8b602018-08-03 05:08:17 +000039#include "llvm/Transforms/Utils/Local.h"
David Greenb0aa36f2018-03-29 08:48:15 +000040#include "llvm/Transforms/Utils/LoopUtils.h"
41#include "llvm/Transforms/Utils/SSAUpdater.h"
42#include "llvm/Transforms/Utils/ValueMapper.h"
43using namespace llvm;
44
45#define DEBUG_TYPE "loop-rotate"
46
47STATISTIC(NumRotated, "Number of loops rotated");
48
49namespace {
50/// A simple loop rotation transformation.
51class LoopRotate {
52 const unsigned MaxHeaderSize;
53 LoopInfo *LI;
54 const TargetTransformInfo *TTI;
55 AssumptionCache *AC;
56 DominatorTree *DT;
57 ScalarEvolution *SE;
Alina Sbirleaad4d0182018-10-24 22:46:45 +000058 MemorySSAUpdater *MSSAU;
David Greenb0aa36f2018-03-29 08:48:15 +000059 const SimplifyQuery &SQ;
Jin Lin585f2692018-04-19 20:29:43 +000060 bool RotationOnly;
61 bool IsUtilMode;
David Greenb0aa36f2018-03-29 08:48:15 +000062
63public:
64 LoopRotate(unsigned MaxHeaderSize, LoopInfo *LI,
65 const TargetTransformInfo *TTI, AssumptionCache *AC,
Alina Sbirleaad4d0182018-10-24 22:46:45 +000066 DominatorTree *DT, ScalarEvolution *SE, MemorySSAUpdater *MSSAU,
67 const SimplifyQuery &SQ, bool RotationOnly, bool IsUtilMode)
David Greenb0aa36f2018-03-29 08:48:15 +000068 : MaxHeaderSize(MaxHeaderSize), LI(LI), TTI(TTI), AC(AC), DT(DT), SE(SE),
Alina Sbirleaad4d0182018-10-24 22:46:45 +000069 MSSAU(MSSAU), SQ(SQ), RotationOnly(RotationOnly),
70 IsUtilMode(IsUtilMode) {}
David Greenb0aa36f2018-03-29 08:48:15 +000071 bool processLoop(Loop *L);
72
73private:
74 bool rotateLoop(Loop *L, bool SimplifiedLatch);
75 bool simplifyLoopLatch(Loop *L);
76};
77} // end anonymous namespace
78
79/// RewriteUsesOfClonedInstructions - We just cloned the instructions from the
80/// old header into the preheader. If there were uses of the values produced by
81/// these instruction that were outside of the loop, we have to insert PHI nodes
82/// to merge the two values. Do this now.
83static void RewriteUsesOfClonedInstructions(BasicBlock *OrigHeader,
84 BasicBlock *OrigPreheader,
85 ValueToValueMapTy &ValueMap,
86 SmallVectorImpl<PHINode*> *InsertedPHIs) {
87 // Remove PHI node entries that are no longer live.
88 BasicBlock::iterator I, E = OrigHeader->end();
89 for (I = OrigHeader->begin(); PHINode *PN = dyn_cast<PHINode>(I); ++I)
90 PN->removeIncomingValue(PN->getBasicBlockIndex(OrigPreheader));
91
92 // Now fix up users of the instructions in OrigHeader, inserting PHI nodes
93 // as necessary.
94 SSAUpdater SSA(InsertedPHIs);
95 for (I = OrigHeader->begin(); I != E; ++I) {
96 Value *OrigHeaderVal = &*I;
97
98 // If there are no uses of the value (e.g. because it returns void), there
99 // is nothing to rewrite.
100 if (OrigHeaderVal->use_empty())
101 continue;
102
103 Value *OrigPreHeaderVal = ValueMap.lookup(OrigHeaderVal);
104
105 // The value now exits in two versions: the initial value in the preheader
106 // and the loop "next" value in the original header.
107 SSA.Initialize(OrigHeaderVal->getType(), OrigHeaderVal->getName());
108 SSA.AddAvailableValue(OrigHeader, OrigHeaderVal);
109 SSA.AddAvailableValue(OrigPreheader, OrigPreHeaderVal);
110
111 // Visit each use of the OrigHeader instruction.
112 for (Value::use_iterator UI = OrigHeaderVal->use_begin(),
113 UE = OrigHeaderVal->use_end();
114 UI != UE;) {
115 // Grab the use before incrementing the iterator.
116 Use &U = *UI;
117
118 // Increment the iterator before removing the use from the list.
119 ++UI;
120
121 // SSAUpdater can't handle a non-PHI use in the same block as an
122 // earlier def. We can easily handle those cases manually.
123 Instruction *UserInst = cast<Instruction>(U.getUser());
124 if (!isa<PHINode>(UserInst)) {
125 BasicBlock *UserBB = UserInst->getParent();
126
127 // The original users in the OrigHeader are already using the
128 // original definitions.
129 if (UserBB == OrigHeader)
130 continue;
131
132 // Users in the OrigPreHeader need to use the value to which the
133 // original definitions are mapped.
134 if (UserBB == OrigPreheader) {
135 U = OrigPreHeaderVal;
136 continue;
137 }
138 }
139
140 // Anything else can be handled by SSAUpdater.
141 SSA.RewriteUse(U);
142 }
143
144 // Replace MetadataAsValue(ValueAsMetadata(OrigHeaderVal)) uses in debug
145 // intrinsics.
146 SmallVector<DbgValueInst *, 1> DbgValues;
147 llvm::findDbgValues(DbgValues, OrigHeaderVal);
148 for (auto &DbgValue : DbgValues) {
149 // The original users in the OrigHeader are already using the original
150 // definitions.
151 BasicBlock *UserBB = DbgValue->getParent();
152 if (UserBB == OrigHeader)
153 continue;
154
155 // Users in the OrigPreHeader need to use the value to which the
156 // original definitions are mapped and anything else can be handled by
157 // the SSAUpdater. To avoid adding PHINodes, check if the value is
158 // available in UserBB, if not substitute undef.
159 Value *NewVal;
160 if (UserBB == OrigPreheader)
161 NewVal = OrigPreHeaderVal;
162 else if (SSA.HasValueForBlock(UserBB))
163 NewVal = SSA.GetValueInMiddleOfBlock(UserBB);
164 else
165 NewVal = UndefValue::get(OrigHeaderVal->getType());
166 DbgValue->setOperand(0,
167 MetadataAsValue::get(OrigHeaderVal->getContext(),
168 ValueAsMetadata::get(NewVal)));
169 }
170 }
171}
172
David Greenf80ebc82018-04-01 12:48:24 +0000173// Look for a phi which is only used outside the loop (via a LCSSA phi)
174// in the exit from the header. This means that rotating the loop can
175// remove the phi.
176static bool shouldRotateLoopExitingLatch(Loop *L) {
177 BasicBlock *Header = L->getHeader();
178 BasicBlock *HeaderExit = Header->getTerminator()->getSuccessor(0);
179 if (L->contains(HeaderExit))
180 HeaderExit = Header->getTerminator()->getSuccessor(1);
181
182 for (auto &Phi : Header->phis()) {
183 // Look for uses of this phi in the loop/via exits other than the header.
184 if (llvm::any_of(Phi.users(), [HeaderExit](const User *U) {
185 return cast<Instruction>(U)->getParent() != HeaderExit;
186 }))
187 continue;
188 return true;
189 }
190
191 return false;
192}
193
David Greenb0aa36f2018-03-29 08:48:15 +0000194/// Rotate loop LP. Return true if the loop is rotated.
195///
196/// \param SimplifiedLatch is true if the latch was just folded into the final
197/// loop exit. In this case we may want to rotate even though the new latch is
198/// now an exiting branch. This rotation would have happened had the latch not
199/// been simplified. However, if SimplifiedLatch is false, then we avoid
200/// rotating loops in which the latch exits to avoid excessive or endless
201/// rotation. LoopRotate should be repeatable and converge to a canonical
202/// form. This property is satisfied because simplifying the loop latch can only
203/// happen once across multiple invocations of the LoopRotate pass.
204bool LoopRotate::rotateLoop(Loop *L, bool SimplifiedLatch) {
205 // If the loop has only one block then there is not much to rotate.
206 if (L->getBlocks().size() == 1)
207 return false;
208
209 BasicBlock *OrigHeader = L->getHeader();
210 BasicBlock *OrigLatch = L->getLoopLatch();
211
212 BranchInst *BI = dyn_cast<BranchInst>(OrigHeader->getTerminator());
213 if (!BI || BI->isUnconditional())
214 return false;
215
216 // If the loop header is not one of the loop exiting blocks then
217 // either this loop is already rotated or it is not
218 // suitable for loop rotation transformations.
219 if (!L->isLoopExiting(OrigHeader))
220 return false;
221
222 // If the loop latch already contains a branch that leaves the loop then the
223 // loop is already rotated.
224 if (!OrigLatch)
225 return false;
226
227 // Rotate if either the loop latch does *not* exit the loop, or if the loop
David Greenf80ebc82018-04-01 12:48:24 +0000228 // latch was just simplified. Or if we think it will be profitable.
Jin Lin585f2692018-04-19 20:29:43 +0000229 if (L->isLoopExiting(OrigLatch) && !SimplifiedLatch && IsUtilMode == false &&
David Greenf80ebc82018-04-01 12:48:24 +0000230 !shouldRotateLoopExitingLatch(L))
David Greenb0aa36f2018-03-29 08:48:15 +0000231 return false;
232
233 // Check size of original header and reject loop if it is very big or we can't
234 // duplicate blocks inside it.
235 {
236 SmallPtrSet<const Value *, 32> EphValues;
237 CodeMetrics::collectEphemeralValues(L, AC, EphValues);
238
239 CodeMetrics Metrics;
240 Metrics.analyzeBasicBlock(OrigHeader, *TTI, EphValues);
241 if (Metrics.notDuplicatable) {
Nicola Zaghend34e60c2018-05-14 12:53:11 +0000242 LLVM_DEBUG(
243 dbgs() << "LoopRotation: NOT rotating - contains non-duplicatable"
244 << " instructions: ";
245 L->dump());
David Greenb0aa36f2018-03-29 08:48:15 +0000246 return false;
247 }
248 if (Metrics.convergent) {
Nicola Zaghend34e60c2018-05-14 12:53:11 +0000249 LLVM_DEBUG(dbgs() << "LoopRotation: NOT rotating - contains convergent "
250 "instructions: ";
251 L->dump());
David Greenb0aa36f2018-03-29 08:48:15 +0000252 return false;
253 }
254 if (Metrics.NumInsts > MaxHeaderSize)
255 return false;
256 }
257
258 // Now, this loop is suitable for rotation.
259 BasicBlock *OrigPreheader = L->getLoopPreheader();
260
261 // If the loop could not be converted to canonical form, it must have an
262 // indirectbr in it, just give up.
263 if (!OrigPreheader || !L->hasDedicatedExits())
264 return false;
265
266 // Anything ScalarEvolution may know about this loop or the PHI nodes
Max Kazantsev5a0a40b2018-04-24 02:08:05 +0000267 // in its header will soon be invalidated. We should also invalidate
268 // all outer loops because insertion and deletion of blocks that happens
269 // during the rotation may violate invariants related to backedge taken
270 // infos in them.
David Greenb0aa36f2018-03-29 08:48:15 +0000271 if (SE)
Max Kazantsev91f48162018-04-23 12:33:31 +0000272 SE->forgetTopmostLoop(L);
David Greenb0aa36f2018-03-29 08:48:15 +0000273
Nicola Zaghend34e60c2018-05-14 12:53:11 +0000274 LLVM_DEBUG(dbgs() << "LoopRotation: rotating "; L->dump());
Alina Sbirleaad4d0182018-10-24 22:46:45 +0000275 if (MSSAU && VerifyMemorySSA)
276 MSSAU->getMemorySSA()->verifyMemorySSA();
David Greenb0aa36f2018-03-29 08:48:15 +0000277
278 // Find new Loop header. NewHeader is a Header's one and only successor
279 // that is inside loop. Header's other successor is outside the
280 // loop. Otherwise loop is not suitable for rotation.
281 BasicBlock *Exit = BI->getSuccessor(0);
282 BasicBlock *NewHeader = BI->getSuccessor(1);
283 if (L->contains(Exit))
284 std::swap(Exit, NewHeader);
285 assert(NewHeader && "Unable to determine new loop header");
286 assert(L->contains(NewHeader) && !L->contains(Exit) &&
287 "Unable to determine loop header and exit blocks");
288
289 // This code assumes that the new header has exactly one predecessor.
290 // Remove any single-entry PHI nodes in it.
291 assert(NewHeader->getSinglePredecessor() &&
292 "New header doesn't have one pred!");
293 FoldSingleEntryPHINodes(NewHeader);
294
295 // Begin by walking OrigHeader and populating ValueMap with an entry for
296 // each Instruction.
297 BasicBlock::iterator I = OrigHeader->begin(), E = OrigHeader->end();
298 ValueToValueMapTy ValueMap;
299
300 // For PHI nodes, the value available in OldPreHeader is just the
301 // incoming value from OldPreHeader.
302 for (; PHINode *PN = dyn_cast<PHINode>(I); ++I)
303 ValueMap[PN] = PN->getIncomingValueForBlock(OrigPreheader);
304
305 // For the rest of the instructions, either hoist to the OrigPreheader if
306 // possible or create a clone in the OldPreHeader if not.
Chandler Carruthedb12a82018-10-15 10:04:59 +0000307 Instruction *LoopEntryBranch = OrigPreheader->getTerminator();
David Greenb0aa36f2018-03-29 08:48:15 +0000308
309 // Record all debug intrinsics preceding LoopEntryBranch to avoid duplication.
310 using DbgIntrinsicHash =
311 std::pair<std::pair<Value *, DILocalVariable *>, DIExpression *>;
Hsiangkai Wangef72e482018-08-06 03:59:47 +0000312 auto makeHash = [](DbgVariableIntrinsic *D) -> DbgIntrinsicHash {
David Greenb0aa36f2018-03-29 08:48:15 +0000313 return {{D->getVariableLocation(), D->getVariable()}, D->getExpression()};
314 };
315 SmallDenseSet<DbgIntrinsicHash, 8> DbgIntrinsics;
316 for (auto I = std::next(OrigPreheader->rbegin()), E = OrigPreheader->rend();
317 I != E; ++I) {
Hsiangkai Wangef72e482018-08-06 03:59:47 +0000318 if (auto *DII = dyn_cast<DbgVariableIntrinsic>(&*I))
David Greenb0aa36f2018-03-29 08:48:15 +0000319 DbgIntrinsics.insert(makeHash(DII));
320 else
321 break;
322 }
323
324 while (I != E) {
325 Instruction *Inst = &*I++;
326
327 // If the instruction's operands are invariant and it doesn't read or write
328 // memory, then it is safe to hoist. Doing this doesn't change the order of
329 // execution in the preheader, but does prevent the instruction from
330 // executing in each iteration of the loop. This means it is safe to hoist
331 // something that might trap, but isn't safe to hoist something that reads
332 // memory (without proving that the loop doesn't write).
333 if (L->hasLoopInvariantOperands(Inst) && !Inst->mayReadFromMemory() &&
Chandler Carruth9ae926b2018-08-26 09:51:22 +0000334 !Inst->mayWriteToMemory() && !Inst->isTerminator() &&
David Greenb0aa36f2018-03-29 08:48:15 +0000335 !isa<DbgInfoIntrinsic>(Inst) && !isa<AllocaInst>(Inst)) {
336 Inst->moveBefore(LoopEntryBranch);
337 continue;
338 }
339
340 // Otherwise, create a duplicate of the instruction.
341 Instruction *C = Inst->clone();
342
343 // Eagerly remap the operands of the instruction.
344 RemapInstruction(C, ValueMap,
345 RF_NoModuleLevelChanges | RF_IgnoreMissingLocals);
346
347 // Avoid inserting the same intrinsic twice.
Hsiangkai Wangef72e482018-08-06 03:59:47 +0000348 if (auto *DII = dyn_cast<DbgVariableIntrinsic>(C))
David Greenb0aa36f2018-03-29 08:48:15 +0000349 if (DbgIntrinsics.count(makeHash(DII))) {
350 C->deleteValue();
351 continue;
352 }
353
354 // With the operands remapped, see if the instruction constant folds or is
355 // otherwise simplifyable. This commonly occurs because the entry from PHI
356 // nodes allows icmps and other instructions to fold.
357 Value *V = SimplifyInstruction(C, SQ);
358 if (V && LI->replacementPreservesLCSSAForm(C, V)) {
359 // If so, then delete the temporary instruction and stick the folded value
360 // in the map.
361 ValueMap[Inst] = V;
362 if (!C->mayHaveSideEffects()) {
363 C->deleteValue();
364 C = nullptr;
365 }
366 } else {
367 ValueMap[Inst] = C;
368 }
369 if (C) {
370 // Otherwise, stick the new instruction into the new block!
371 C->setName(Inst->getName());
372 C->insertBefore(LoopEntryBranch);
373
374 if (auto *II = dyn_cast<IntrinsicInst>(C))
375 if (II->getIntrinsicID() == Intrinsic::assume)
376 AC->registerAssumption(II);
377 }
378 }
379
380 // Along with all the other instructions, we just cloned OrigHeader's
381 // terminator into OrigPreHeader. Fix up the PHI nodes in each of OrigHeader's
382 // successors by duplicating their incoming values for OrigHeader.
Chandler Carruth96fc1de2018-08-26 08:41:15 +0000383 for (BasicBlock *SuccBB : successors(OrigHeader))
David Greenb0aa36f2018-03-29 08:48:15 +0000384 for (BasicBlock::iterator BI = SuccBB->begin();
385 PHINode *PN = dyn_cast<PHINode>(BI); ++BI)
386 PN->addIncoming(PN->getIncomingValueForBlock(OrigHeader), OrigPreheader);
387
388 // Now that OrigPreHeader has a clone of OrigHeader's terminator, remove
389 // OrigPreHeader's old terminator (the original branch into the loop), and
390 // remove the corresponding incoming values from the PHI nodes in OrigHeader.
391 LoopEntryBranch->eraseFromParent();
392
Alina Sbirleaad4d0182018-10-24 22:46:45 +0000393 // Update MemorySSA before the rewrite call below changes the 1:1
394 // instruction:cloned_instruction_or_value mapping in ValueMap.
395 if (MSSAU) {
396 ValueMap[OrigHeader] = OrigPreheader;
397 MSSAU->updateForClonedBlockIntoPred(OrigHeader, OrigPreheader, ValueMap);
398 }
David Greenb0aa36f2018-03-29 08:48:15 +0000399
400 SmallVector<PHINode*, 2> InsertedPHIs;
401 // If there were any uses of instructions in the duplicated block outside the
402 // loop, update them, inserting PHI nodes as required
403 RewriteUsesOfClonedInstructions(OrigHeader, OrigPreheader, ValueMap,
404 &InsertedPHIs);
405
406 // Attach dbg.value intrinsics to the new phis if that phi uses a value that
407 // previously had debug metadata attached. This keeps the debug info
408 // up-to-date in the loop body.
409 if (!InsertedPHIs.empty())
410 insertDebugValuesForPHIs(OrigHeader, InsertedPHIs);
411
412 // NewHeader is now the header of the loop.
413 L->moveToHeader(NewHeader);
414 assert(L->getHeader() == NewHeader && "Latch block is our new header");
415
416 // Inform DT about changes to the CFG.
417 if (DT) {
418 // The OrigPreheader branches to the NewHeader and Exit now. Then, inform
419 // the DT about the removed edge to the OrigHeader (that got removed).
420 SmallVector<DominatorTree::UpdateType, 3> Updates;
421 Updates.push_back({DominatorTree::Insert, OrigPreheader, Exit});
422 Updates.push_back({DominatorTree::Insert, OrigPreheader, NewHeader});
423 Updates.push_back({DominatorTree::Delete, OrigPreheader, OrigHeader});
424 DT->applyUpdates(Updates);
Alina Sbirleaad4d0182018-10-24 22:46:45 +0000425
426 if (MSSAU) {
427 MSSAU->applyUpdates(Updates, *DT);
428 if (VerifyMemorySSA)
429 MSSAU->getMemorySSA()->verifyMemorySSA();
430 }
David Greenb0aa36f2018-03-29 08:48:15 +0000431 }
432
433 // At this point, we've finished our major CFG changes. As part of cloning
434 // the loop into the preheader we've simplified instructions and the
435 // duplicated conditional branch may now be branching on a constant. If it is
436 // branching on a constant and if that constant means that we enter the loop,
437 // then we fold away the cond branch to an uncond branch. This simplifies the
438 // loop in cases important for nested loops, and it also means we don't have
439 // to split as many edges.
440 BranchInst *PHBI = cast<BranchInst>(OrigPreheader->getTerminator());
441 assert(PHBI->isConditional() && "Should be clone of BI condbr!");
442 if (!isa<ConstantInt>(PHBI->getCondition()) ||
443 PHBI->getSuccessor(cast<ConstantInt>(PHBI->getCondition())->isZero()) !=
444 NewHeader) {
445 // The conditional branch can't be folded, handle the general case.
446 // Split edges as necessary to preserve LoopSimplify form.
447
448 // Right now OrigPreHeader has two successors, NewHeader and ExitBlock, and
449 // thus is not a preheader anymore.
450 // Split the edge to form a real preheader.
451 BasicBlock *NewPH = SplitCriticalEdge(
452 OrigPreheader, NewHeader,
Alina Sbirleaad4d0182018-10-24 22:46:45 +0000453 CriticalEdgeSplittingOptions(DT, LI, MSSAU).setPreserveLCSSA());
David Greenb0aa36f2018-03-29 08:48:15 +0000454 NewPH->setName(NewHeader->getName() + ".lr.ph");
455
456 // Preserve canonical loop form, which means that 'Exit' should have only
457 // one predecessor. Note that Exit could be an exit block for multiple
458 // nested loops, causing both of the edges to now be critical and need to
459 // be split.
460 SmallVector<BasicBlock *, 4> ExitPreds(pred_begin(Exit), pred_end(Exit));
461 bool SplitLatchEdge = false;
462 for (BasicBlock *ExitPred : ExitPreds) {
463 // We only need to split loop exit edges.
464 Loop *PredLoop = LI->getLoopFor(ExitPred);
Nick Desaulniers212c8ac2019-03-06 23:04:40 +0000465 if (!PredLoop || PredLoop->contains(Exit) ||
466 ExitPred->getTerminator()->isIndirectTerminator())
David Greenb0aa36f2018-03-29 08:48:15 +0000467 continue;
468 SplitLatchEdge |= L->getLoopLatch() == ExitPred;
469 BasicBlock *ExitSplit = SplitCriticalEdge(
470 ExitPred, Exit,
Alina Sbirleaad4d0182018-10-24 22:46:45 +0000471 CriticalEdgeSplittingOptions(DT, LI, MSSAU).setPreserveLCSSA());
David Greenb0aa36f2018-03-29 08:48:15 +0000472 ExitSplit->moveBefore(Exit);
473 }
474 assert(SplitLatchEdge &&
475 "Despite splitting all preds, failed to split latch exit?");
476 } else {
477 // We can fold the conditional branch in the preheader, this makes things
478 // simpler. The first step is to remove the extra edge to the Exit block.
479 Exit->removePredecessor(OrigPreheader, true /*preserve LCSSA*/);
480 BranchInst *NewBI = BranchInst::Create(NewHeader, PHBI);
481 NewBI->setDebugLoc(PHBI->getDebugLoc());
482 PHBI->eraseFromParent();
483
484 // With our CFG finalized, update DomTree if it is available.
485 if (DT) DT->deleteEdge(OrigPreheader, Exit);
Alina Sbirleaad4d0182018-10-24 22:46:45 +0000486
487 // Update MSSA too, if available.
488 if (MSSAU)
489 MSSAU->removeEdge(OrigPreheader, Exit);
David Greenb0aa36f2018-03-29 08:48:15 +0000490 }
491
492 assert(L->getLoopPreheader() && "Invalid loop preheader after loop rotation");
493 assert(L->getLoopLatch() && "Invalid loop latch after loop rotation");
494
Alina Sbirleaad4d0182018-10-24 22:46:45 +0000495 if (MSSAU && VerifyMemorySSA)
496 MSSAU->getMemorySSA()->verifyMemorySSA();
497
David Greenb0aa36f2018-03-29 08:48:15 +0000498 // Now that the CFG and DomTree are in a consistent state again, try to merge
499 // the OrigHeader block into OrigLatch. This will succeed if they are
500 // connected by an unconditional branch. This is just a cleanup so the
501 // emitted code isn't too gross in this common case.
Chijun Sima21a8b602018-08-03 05:08:17 +0000502 DomTreeUpdater DTU(DT, DomTreeUpdater::UpdateStrategy::Eager);
Alina Sbirleaad4d0182018-10-24 22:46:45 +0000503 MergeBlockIntoPredecessor(OrigHeader, &DTU, LI, MSSAU);
504
505 if (MSSAU && VerifyMemorySSA)
506 MSSAU->getMemorySSA()->verifyMemorySSA();
David Greenb0aa36f2018-03-29 08:48:15 +0000507
Nicola Zaghend34e60c2018-05-14 12:53:11 +0000508 LLVM_DEBUG(dbgs() << "LoopRotation: into "; L->dump());
David Greenb0aa36f2018-03-29 08:48:15 +0000509
510 ++NumRotated;
511 return true;
512}
513
514/// Determine whether the instructions in this range may be safely and cheaply
515/// speculated. This is not an important enough situation to develop complex
516/// heuristics. We handle a single arithmetic instruction along with any type
517/// conversions.
518static bool shouldSpeculateInstrs(BasicBlock::iterator Begin,
519 BasicBlock::iterator End, Loop *L) {
520 bool seenIncrement = false;
521 bool MultiExitLoop = false;
522
523 if (!L->getExitingBlock())
524 MultiExitLoop = true;
525
526 for (BasicBlock::iterator I = Begin; I != End; ++I) {
527
528 if (!isSafeToSpeculativelyExecute(&*I))
529 return false;
530
531 if (isa<DbgInfoIntrinsic>(I))
532 continue;
533
534 switch (I->getOpcode()) {
535 default:
536 return false;
537 case Instruction::GetElementPtr:
538 // GEPs are cheap if all indices are constant.
539 if (!cast<GEPOperator>(I)->hasAllConstantIndices())
540 return false;
541 // fall-thru to increment case
542 LLVM_FALLTHROUGH;
543 case Instruction::Add:
544 case Instruction::Sub:
545 case Instruction::And:
546 case Instruction::Or:
547 case Instruction::Xor:
548 case Instruction::Shl:
549 case Instruction::LShr:
550 case Instruction::AShr: {
551 Value *IVOpnd =
552 !isa<Constant>(I->getOperand(0))
553 ? I->getOperand(0)
554 : !isa<Constant>(I->getOperand(1)) ? I->getOperand(1) : nullptr;
555 if (!IVOpnd)
556 return false;
557
558 // If increment operand is used outside of the loop, this speculation
559 // could cause extra live range interference.
560 if (MultiExitLoop) {
561 for (User *UseI : IVOpnd->users()) {
562 auto *UserInst = cast<Instruction>(UseI);
563 if (!L->contains(UserInst))
564 return false;
565 }
566 }
567
568 if (seenIncrement)
569 return false;
570 seenIncrement = true;
571 break;
572 }
573 case Instruction::Trunc:
574 case Instruction::ZExt:
575 case Instruction::SExt:
576 // ignore type conversions
577 break;
578 }
579 }
580 return true;
581}
582
583/// Fold the loop tail into the loop exit by speculating the loop tail
584/// instructions. Typically, this is a single post-increment. In the case of a
585/// simple 2-block loop, hoisting the increment can be much better than
586/// duplicating the entire loop header. In the case of loops with early exits,
587/// rotation will not work anyway, but simplifyLoopLatch will put the loop in
588/// canonical form so downstream passes can handle it.
589///
590/// I don't believe this invalidates SCEV.
591bool LoopRotate::simplifyLoopLatch(Loop *L) {
592 BasicBlock *Latch = L->getLoopLatch();
593 if (!Latch || Latch->hasAddressTaken())
594 return false;
595
596 BranchInst *Jmp = dyn_cast<BranchInst>(Latch->getTerminator());
597 if (!Jmp || !Jmp->isUnconditional())
598 return false;
599
600 BasicBlock *LastExit = Latch->getSinglePredecessor();
601 if (!LastExit || !L->isLoopExiting(LastExit))
602 return false;
603
604 BranchInst *BI = dyn_cast<BranchInst>(LastExit->getTerminator());
605 if (!BI)
606 return false;
607
608 if (!shouldSpeculateInstrs(Latch->begin(), Jmp->getIterator(), L))
609 return false;
610
Nicola Zaghend34e60c2018-05-14 12:53:11 +0000611 LLVM_DEBUG(dbgs() << "Folding loop latch " << Latch->getName() << " into "
612 << LastExit->getName() << "\n");
David Greenb0aa36f2018-03-29 08:48:15 +0000613
614 // Hoist the instructions from Latch into LastExit.
Alina Sbirleaad4d0182018-10-24 22:46:45 +0000615 Instruction *FirstLatchInst = &*(Latch->begin());
David Greenb0aa36f2018-03-29 08:48:15 +0000616 LastExit->getInstList().splice(BI->getIterator(), Latch->getInstList(),
617 Latch->begin(), Jmp->getIterator());
618
Alina Sbirleaad4d0182018-10-24 22:46:45 +0000619 // Update MemorySSA
620 if (MSSAU)
621 MSSAU->moveAllAfterMergeBlocks(Latch, LastExit, FirstLatchInst);
622
David Greenb0aa36f2018-03-29 08:48:15 +0000623 unsigned FallThruPath = BI->getSuccessor(0) == Latch ? 0 : 1;
624 BasicBlock *Header = Jmp->getSuccessor(0);
625 assert(Header == L->getHeader() && "expected a backward branch");
626
627 // Remove Latch from the CFG so that LastExit becomes the new Latch.
628 BI->setSuccessor(FallThruPath, Header);
629 Latch->replaceSuccessorsPhiUsesWith(LastExit);
630 Jmp->eraseFromParent();
631
632 // Nuke the Latch block.
633 assert(Latch->empty() && "unable to evacuate Latch");
634 LI->removeBlock(Latch);
635 if (DT)
636 DT->eraseNode(Latch);
637 Latch->eraseFromParent();
Alina Sbirleaad4d0182018-10-24 22:46:45 +0000638
639 if (MSSAU && VerifyMemorySSA)
640 MSSAU->getMemorySSA()->verifyMemorySSA();
641
David Greenb0aa36f2018-03-29 08:48:15 +0000642 return true;
643}
644
645/// Rotate \c L, and return true if any modification was made.
646bool LoopRotate::processLoop(Loop *L) {
647 // Save the loop metadata.
648 MDNode *LoopMD = L->getLoopID();
649
Jin Lin585f2692018-04-19 20:29:43 +0000650 bool SimplifiedLatch = false;
651
David Greenb0aa36f2018-03-29 08:48:15 +0000652 // Simplify the loop latch before attempting to rotate the header
653 // upward. Rotation may not be needed if the loop tail can be folded into the
654 // loop exit.
Jin Lin585f2692018-04-19 20:29:43 +0000655 if (!RotationOnly)
656 SimplifiedLatch = simplifyLoopLatch(L);
David Greenb0aa36f2018-03-29 08:48:15 +0000657
658 bool MadeChange = rotateLoop(L, SimplifiedLatch);
659 assert((!MadeChange || L->isLoopExiting(L->getLoopLatch())) &&
660 "Loop latch should be exiting after loop-rotate.");
661
662 // Restore the loop metadata.
663 // NB! We presume LoopRotation DOESN'T ADD its own metadata.
664 if ((MadeChange || SimplifiedLatch) && LoopMD)
665 L->setLoopID(LoopMD);
666
667 return MadeChange || SimplifiedLatch;
668}
669
670
671/// The utility to convert a loop into a loop with bottom test.
Jin Lin585f2692018-04-19 20:29:43 +0000672bool llvm::LoopRotation(Loop *L, LoopInfo *LI, const TargetTransformInfo *TTI,
673 AssumptionCache *AC, DominatorTree *DT,
Alina Sbirleaad4d0182018-10-24 22:46:45 +0000674 ScalarEvolution *SE, MemorySSAUpdater *MSSAU,
675 const SimplifyQuery &SQ, bool RotationOnly = true,
Jin Lin585f2692018-04-19 20:29:43 +0000676 unsigned Threshold = unsigned(-1),
677 bool IsUtilMode = true) {
Alina Sbirleaad4d0182018-10-24 22:46:45 +0000678 if (MSSAU && VerifyMemorySSA)
679 MSSAU->getMemorySSA()->verifyMemorySSA();
680 LoopRotate LR(Threshold, LI, TTI, AC, DT, SE, MSSAU, SQ, RotationOnly,
681 IsUtilMode);
682 if (MSSAU && VerifyMemorySSA)
683 MSSAU->getMemorySSA()->verifyMemorySSA();
David Greenb0aa36f2018-03-29 08:48:15 +0000684
685 return LR.processLoop(L);
686}