| Hal Finkel | 05e4648 | 2017-12-16 02:23:22 +0000 | [diff] [blame] | 1 | // RUN: %clang_cc1 -std=c++11 -triple=x86_64-pc-linux-gnu -fsyntax-only \ |
| Roman Lebedev | c5417aa | 2018-01-03 08:45:19 +0000 | [diff] [blame] | 2 | // RUN: -Wtautological-unsigned-enum-zero-compare \ |
| Hal Finkel | 05e4648 | 2017-12-16 02:23:22 +0000 | [diff] [blame] | 3 | // RUN: -verify=unsigned,unsigned-signed %s |
| 4 | // RUN: %clang_cc1 -std=c++11 -triple=x86_64-pc-win32 -fsyntax-only \ |
| Roman Lebedev | c5417aa | 2018-01-03 08:45:19 +0000 | [diff] [blame] | 5 | // RUN: -Wtautological-unsigned-enum-zero-compare \ |
| Hal Finkel | 05e4648 | 2017-12-16 02:23:22 +0000 | [diff] [blame] | 6 | // RUN: -verify=unsigned-signed %s |
| 7 | // RUN: %clang_cc1 -std=c++11 -triple=x86_64-pc-win32 -fsyntax-only \ |
| Hal Finkel | 05e4648 | 2017-12-16 02:23:22 +0000 | [diff] [blame] | 8 | // RUN: -verify=silence %s |
| 9 | |
| 10 | // silence-no-diagnostics |
| Roman Lebedev | 30d2608 | 2017-09-20 13:50:01 +0000 | [diff] [blame] | 11 | |
| Roman Lebedev | 30d2608 | 2017-09-20 13:50:01 +0000 | [diff] [blame] | 12 | int main() { |
| Richard Smith | 371e9e8a | 2017-12-06 03:00:51 +0000 | [diff] [blame] | 13 | // On Windows, all enumerations have a fixed underlying type, which is 'int' |
| 14 | // if not otherwise specified, so A is identical to C on Windows. Otherwise, |
| 15 | // we follow the C++ rules, which say that the only valid values of A are 0 |
| 16 | // and 1. |
| Roman Lebedev | ca1aaac | 2017-10-21 16:44:03 +0000 | [diff] [blame] | 17 | enum A { A_foo = 0, A_bar, }; |
| Roman Lebedev | 30d2608 | 2017-09-20 13:50:01 +0000 | [diff] [blame] | 18 | enum A a; |
| 19 | |
| Roman Lebedev | ca1aaac | 2017-10-21 16:44:03 +0000 | [diff] [blame] | 20 | enum B : unsigned { B_foo = 0, B_bar, }; |
| Roman Lebedev | 30d2608 | 2017-09-20 13:50:01 +0000 | [diff] [blame] | 21 | enum B b; |
| 22 | |
| Roman Lebedev | ca1aaac | 2017-10-21 16:44:03 +0000 | [diff] [blame] | 23 | enum C : signed { C_foo = 0, C_bar, }; |
| Roman Lebedev | 30d2608 | 2017-09-20 13:50:01 +0000 | [diff] [blame] | 24 | enum C c; |
| 25 | |
| Hal Finkel | 05e4648 | 2017-12-16 02:23:22 +0000 | [diff] [blame] | 26 | if (a < 0) // unsigned-warning {{comparison of unsigned enum expression < 0 is always false}} |
| Roman Lebedev | 30d2608 | 2017-09-20 13:50:01 +0000 | [diff] [blame] | 27 | return 0; |
| Roman Lebedev | ca1aaac | 2017-10-21 16:44:03 +0000 | [diff] [blame] | 28 | if (0 >= a) |
| 29 | return 0; |
| 30 | if (a > 0) |
| Roman Lebedev | 30d2608 | 2017-09-20 13:50:01 +0000 | [diff] [blame] | 31 | return 0; |
| Hal Finkel | 05e4648 | 2017-12-16 02:23:22 +0000 | [diff] [blame] | 32 | if (0 <= a) // unsigned-warning {{comparison of 0 <= unsigned enum expression is always true}} |
| Roman Lebedev | 30d2608 | 2017-09-20 13:50:01 +0000 | [diff] [blame] | 33 | return 0; |
| Roman Lebedev | ca1aaac | 2017-10-21 16:44:03 +0000 | [diff] [blame] | 34 | if (a <= 0) |
| 35 | return 0; |
| Hal Finkel | 05e4648 | 2017-12-16 02:23:22 +0000 | [diff] [blame] | 36 | if (0 > a) // unsigned-warning {{comparison of 0 > unsigned enum expression is always false}} |
| Roman Lebedev | 30d2608 | 2017-09-20 13:50:01 +0000 | [diff] [blame] | 37 | return 0; |
| Hal Finkel | 05e4648 | 2017-12-16 02:23:22 +0000 | [diff] [blame] | 38 | if (a >= 0) // unsigned-warning {{comparison of unsigned enum expression >= 0 is always true}} |
| Roman Lebedev | ca1aaac | 2017-10-21 16:44:03 +0000 | [diff] [blame] | 39 | return 0; |
| 40 | if (0 < a) |
| 41 | return 0; |
| 42 | |
| Hal Finkel | 05e4648 | 2017-12-16 02:23:22 +0000 | [diff] [blame] | 43 | // FIXME: As below, the issue here is that the enumeration is promoted to |
| 44 | // unsigned. |
| 45 | if (a < 0U) // unsigned-signed-warning {{comparison of unsigned enum expression < 0 is always false}} |
| Roman Lebedev | 30d2608 | 2017-09-20 13:50:01 +0000 | [diff] [blame] | 46 | return 0; |
| Roman Lebedev | ca1aaac | 2017-10-21 16:44:03 +0000 | [diff] [blame] | 47 | if (0U >= a) |
| 48 | return 0; |
| 49 | if (a > 0U) |
| Roman Lebedev | 30d2608 | 2017-09-20 13:50:01 +0000 | [diff] [blame] | 50 | return 0; |
| Hal Finkel | 05e4648 | 2017-12-16 02:23:22 +0000 | [diff] [blame] | 51 | if (0U <= a) // unsigned-signed-warning {{comparison of 0 <= unsigned enum expression is always true}} |
| Roman Lebedev | 30d2608 | 2017-09-20 13:50:01 +0000 | [diff] [blame] | 52 | return 0; |
| Roman Lebedev | ca1aaac | 2017-10-21 16:44:03 +0000 | [diff] [blame] | 53 | if (a <= 0U) |
| 54 | return 0; |
| Hal Finkel | 05e4648 | 2017-12-16 02:23:22 +0000 | [diff] [blame] | 55 | if (0U > a) // unsigned-signed-warning {{comparison of 0 > unsigned enum expression is always false}} |
| Roman Lebedev | 30d2608 | 2017-09-20 13:50:01 +0000 | [diff] [blame] | 56 | return 0; |
| Hal Finkel | 05e4648 | 2017-12-16 02:23:22 +0000 | [diff] [blame] | 57 | if (a >= 0U) // unsigned-signed-warning {{comparison of unsigned enum expression >= 0 is always true}} |
| Roman Lebedev | ca1aaac | 2017-10-21 16:44:03 +0000 | [diff] [blame] | 58 | return 0; |
| 59 | if (0U < a) |
| 60 | return 0; |
| Roman Lebedev | 30d2608 | 2017-09-20 13:50:01 +0000 | [diff] [blame] | 61 | |
| Hal Finkel | 05e4648 | 2017-12-16 02:23:22 +0000 | [diff] [blame] | 62 | if (b < 0) // unsigned-signed-warning {{comparison of unsigned enum expression < 0 is always false}} |
| Roman Lebedev | 30d2608 | 2017-09-20 13:50:01 +0000 | [diff] [blame] | 63 | return 0; |
| Roman Lebedev | ca1aaac | 2017-10-21 16:44:03 +0000 | [diff] [blame] | 64 | if (0 >= b) |
| 65 | return 0; |
| 66 | if (b > 0) |
| Roman Lebedev | 30d2608 | 2017-09-20 13:50:01 +0000 | [diff] [blame] | 67 | return 0; |
| Hal Finkel | 05e4648 | 2017-12-16 02:23:22 +0000 | [diff] [blame] | 68 | if (0 <= b) // unsigned-signed-warning {{comparison of 0 <= unsigned enum expression is always true}} |
| Roman Lebedev | 30d2608 | 2017-09-20 13:50:01 +0000 | [diff] [blame] | 69 | return 0; |
| Roman Lebedev | ca1aaac | 2017-10-21 16:44:03 +0000 | [diff] [blame] | 70 | if (b <= 0) |
| 71 | return 0; |
| Hal Finkel | 05e4648 | 2017-12-16 02:23:22 +0000 | [diff] [blame] | 72 | if (0 > b) // unsigned-signed-warning {{comparison of 0 > unsigned enum expression is always false}} |
| Roman Lebedev | 30d2608 | 2017-09-20 13:50:01 +0000 | [diff] [blame] | 73 | return 0; |
| Hal Finkel | 05e4648 | 2017-12-16 02:23:22 +0000 | [diff] [blame] | 74 | if (b >= 0) // unsigned-signed-warning {{comparison of unsigned enum expression >= 0 is always true}} |
| Roman Lebedev | 30d2608 | 2017-09-20 13:50:01 +0000 | [diff] [blame] | 75 | return 0; |
| Roman Lebedev | ca1aaac | 2017-10-21 16:44:03 +0000 | [diff] [blame] | 76 | if (0 < b) |
| Roman Lebedev | 30d2608 | 2017-09-20 13:50:01 +0000 | [diff] [blame] | 77 | return 0; |
| Roman Lebedev | ca1aaac | 2017-10-21 16:44:03 +0000 | [diff] [blame] | 78 | |
| Hal Finkel | 05e4648 | 2017-12-16 02:23:22 +0000 | [diff] [blame] | 79 | if (b < 0U) // unsigned-signed-warning {{comparison of unsigned enum expression < 0 is always false}} |
| Roman Lebedev | 30d2608 | 2017-09-20 13:50:01 +0000 | [diff] [blame] | 80 | return 0; |
| Roman Lebedev | ca1aaac | 2017-10-21 16:44:03 +0000 | [diff] [blame] | 81 | if (0U >= b) |
| 82 | return 0; |
| 83 | if (b > 0U) |
| Roman Lebedev | 30d2608 | 2017-09-20 13:50:01 +0000 | [diff] [blame] | 84 | return 0; |
| Hal Finkel | 05e4648 | 2017-12-16 02:23:22 +0000 | [diff] [blame] | 85 | if (0U <= b) // unsigned-signed-warning {{comparison of 0 <= unsigned enum expression is always true}} |
| Roman Lebedev | 30d2608 | 2017-09-20 13:50:01 +0000 | [diff] [blame] | 86 | return 0; |
| Roman Lebedev | ca1aaac | 2017-10-21 16:44:03 +0000 | [diff] [blame] | 87 | if (b <= 0U) |
| 88 | return 0; |
| Hal Finkel | 05e4648 | 2017-12-16 02:23:22 +0000 | [diff] [blame] | 89 | if (0U > b) // unsigned-signed-warning {{comparison of 0 > unsigned enum expression is always false}} |
| Roman Lebedev | 30d2608 | 2017-09-20 13:50:01 +0000 | [diff] [blame] | 90 | return 0; |
| Hal Finkel | 05e4648 | 2017-12-16 02:23:22 +0000 | [diff] [blame] | 91 | if (b >= 0U) // unsigned-signed-warning {{comparison of unsigned enum expression >= 0 is always true}} |
| Roman Lebedev | 30d2608 | 2017-09-20 13:50:01 +0000 | [diff] [blame] | 92 | return 0; |
| Roman Lebedev | ca1aaac | 2017-10-21 16:44:03 +0000 | [diff] [blame] | 93 | if (0U < b) |
| Roman Lebedev | 30d2608 | 2017-09-20 13:50:01 +0000 | [diff] [blame] | 94 | return 0; |
| 95 | |
| 96 | if (c < 0) |
| 97 | return 0; |
| Richard Smith | 371e9e8a | 2017-12-06 03:00:51 +0000 | [diff] [blame] | 98 | if (0 >= c) |
| Roman Lebedev | ca1aaac | 2017-10-21 16:44:03 +0000 | [diff] [blame] | 99 | return 0; |
| Richard Smith | 371e9e8a | 2017-12-06 03:00:51 +0000 | [diff] [blame] | 100 | if (c > 0) |
| Roman Lebedev | 30d2608 | 2017-09-20 13:50:01 +0000 | [diff] [blame] | 101 | return 0; |
| 102 | if (0 <= c) |
| 103 | return 0; |
| Richard Smith | 371e9e8a | 2017-12-06 03:00:51 +0000 | [diff] [blame] | 104 | if (c <= 0) |
| Roman Lebedev | ca1aaac | 2017-10-21 16:44:03 +0000 | [diff] [blame] | 105 | return 0; |
| Roman Lebedev | 30d2608 | 2017-09-20 13:50:01 +0000 | [diff] [blame] | 106 | if (0 > c) |
| 107 | return 0; |
| Roman Lebedev | ca1aaac | 2017-10-21 16:44:03 +0000 | [diff] [blame] | 108 | if (c >= 0) |
| 109 | return 0; |
| Richard Smith | 371e9e8a | 2017-12-06 03:00:51 +0000 | [diff] [blame] | 110 | if (0 < c) |
| Roman Lebedev | ca1aaac | 2017-10-21 16:44:03 +0000 | [diff] [blame] | 111 | return 0; |
| 112 | |
| Richard Smith | 371e9e8a | 2017-12-06 03:00:51 +0000 | [diff] [blame] | 113 | // FIXME: These diagnostics are terrible. The issue here is that the signed |
| 114 | // enumeration value was promoted to an unsigned type. |
| Hal Finkel | 05e4648 | 2017-12-16 02:23:22 +0000 | [diff] [blame] | 115 | if (c < 0U) // unsigned-signed-warning {{comparison of unsigned enum expression < 0 is always false}} |
| Roman Lebedev | ca1aaac | 2017-10-21 16:44:03 +0000 | [diff] [blame] | 116 | return 0; |
| 117 | if (0U >= c) |
| 118 | return 0; |
| 119 | if (c > 0U) |
| 120 | return 0; |
| Hal Finkel | 05e4648 | 2017-12-16 02:23:22 +0000 | [diff] [blame] | 121 | if (0U <= c) // unsigned-signed-warning {{comparison of 0 <= unsigned enum expression is always true}} |
| Roman Lebedev | ca1aaac | 2017-10-21 16:44:03 +0000 | [diff] [blame] | 122 | return 0; |
| 123 | if (c <= 0U) |
| 124 | return 0; |
| Hal Finkel | 05e4648 | 2017-12-16 02:23:22 +0000 | [diff] [blame] | 125 | if (0U > c) // unsigned-signed-warning {{comparison of 0 > unsigned enum expression is always false}} |
| Roman Lebedev | ca1aaac | 2017-10-21 16:44:03 +0000 | [diff] [blame] | 126 | return 0; |
| Hal Finkel | 05e4648 | 2017-12-16 02:23:22 +0000 | [diff] [blame] | 127 | if (c >= 0U) // unsigned-signed-warning {{comparison of unsigned enum expression >= 0 is always true}} |
| Roman Lebedev | ca1aaac | 2017-10-21 16:44:03 +0000 | [diff] [blame] | 128 | return 0; |
| 129 | if (0U < c) |
| 130 | return 0; |
| Roman Lebedev | 30d2608 | 2017-09-20 13:50:01 +0000 | [diff] [blame] | 131 | |
| 132 | return 1; |
| 133 | } |
| Roman Lebedev | ca1aaac | 2017-10-21 16:44:03 +0000 | [diff] [blame] | 134 | |
| 135 | namespace crash_enum_zero_width { |
| 136 | int test() { |
| 137 | enum A : unsigned { |
| 138 | A_foo = 0 |
| 139 | }; |
| 140 | enum A a; |
| 141 | |
| 142 | // used to crash in llvm::APSInt::getMaxValue() |
| Hal Finkel | 05e4648 | 2017-12-16 02:23:22 +0000 | [diff] [blame] | 143 | if (a < 0) // unsigned-signed-warning {{comparison of unsigned enum expression < 0 is always false}} |
| Roman Lebedev | ca1aaac | 2017-10-21 16:44:03 +0000 | [diff] [blame] | 144 | return 0; |
| 145 | |
| 146 | return 1; |
| 147 | } |
| 148 | } // namespace crash_enum_zero_width |