blob: 98ffae9223f887ab2e9956ebe3fb6d9ff810d78e [file] [log] [blame]
Ted Kremenek918fe842010-03-20 21:06:02 +00001//=- AnalysisBasedWarnings.cpp - Sema warnings based on libAnalysis -*- C++ -*-=//
2//
3// The LLVM Compiler Infrastructure
4//
5// This file is distributed under the University of Illinois Open Source
6// License. See LICENSE.TXT for details.
7//
8//===----------------------------------------------------------------------===//
9//
10// This file defines analysis_warnings::[Policy,Executor].
11// Together they are used by Sema to issue warnings based on inexpensive
12// static analysis algorithms in libAnalysis.
13//
14//===----------------------------------------------------------------------===//
15
Douglas Gregorc3a6ade2010-08-12 20:07:10 +000016#include "clang/Sema/AnalysisBasedWarnings.h"
John McCall28a0cf72010-08-25 07:42:41 +000017#include "clang/AST/DeclCXX.h"
Chandler Carruth3a022472012-12-04 09:13:33 +000018#include "clang/AST/DeclObjC.h"
Ted Kremenekb8d8c4e2011-04-04 20:56:00 +000019#include "clang/AST/EvaluatedExprVisitor.h"
Chandler Carruth3a022472012-12-04 09:13:33 +000020#include "clang/AST/ExprCXX.h"
21#include "clang/AST/ExprObjC.h"
Jordan Rose76831c62012-10-11 16:10:19 +000022#include "clang/AST/ParentMap.h"
Richard Smith84837d52012-05-03 18:27:39 +000023#include "clang/AST/RecursiveASTVisitor.h"
Chandler Carruth3a022472012-12-04 09:13:33 +000024#include "clang/AST/StmtCXX.h"
25#include "clang/AST/StmtObjC.h"
26#include "clang/AST/StmtVisitor.h"
27#include "clang/Analysis/Analyses/CFGReachabilityAnalysis.h"
DeLesley Hutchins48a31762013-08-12 21:20:55 +000028#include "clang/Analysis/Analyses/Consumed.h"
Chandler Carruth3a022472012-12-04 09:13:33 +000029#include "clang/Analysis/Analyses/ReachableCode.h"
30#include "clang/Analysis/Analyses/ThreadSafety.h"
31#include "clang/Analysis/Analyses/UninitializedValues.h"
Ted Kremenek918fe842010-03-20 21:06:02 +000032#include "clang/Analysis/AnalysisContext.h"
33#include "clang/Analysis/CFG.h"
Ted Kremenek3427fac2011-02-23 01:52:04 +000034#include "clang/Analysis/CFGStmtMap.h"
Chandler Carruth3a022472012-12-04 09:13:33 +000035#include "clang/Basic/SourceLocation.h"
36#include "clang/Basic/SourceManager.h"
37#include "clang/Lex/Lexer.h"
38#include "clang/Lex/Preprocessor.h"
39#include "clang/Sema/ScopeInfo.h"
40#include "clang/Sema/SemaInternal.h"
Alexander Kornienkoe61e5622012-09-28 22:24:03 +000041#include "llvm/ADT/ArrayRef.h"
Ted Kremenek918fe842010-03-20 21:06:02 +000042#include "llvm/ADT/BitVector.h"
Caitlin Sadowskiafbbd8e2011-08-23 18:46:34 +000043#include "llvm/ADT/FoldingSet.h"
44#include "llvm/ADT/ImmutableMap.h"
Enea Zaffanella2f40be72013-02-15 20:09:55 +000045#include "llvm/ADT/MapVector.h"
Caitlin Sadowskiafbbd8e2011-08-23 18:46:34 +000046#include "llvm/ADT/PostOrderIterator.h"
Dmitri Gribenko6743e042012-09-29 11:40:46 +000047#include "llvm/ADT/SmallString.h"
Caitlin Sadowskiafbbd8e2011-08-23 18:46:34 +000048#include "llvm/ADT/SmallVector.h"
Caitlin Sadowski0b3501c2011-09-09 16:04:02 +000049#include "llvm/ADT/StringRef.h"
Ted Kremenek918fe842010-03-20 21:06:02 +000050#include "llvm/Support/Casting.h"
Caitlin Sadowskiafbbd8e2011-08-23 18:46:34 +000051#include <algorithm>
Chandler Carruth3a022472012-12-04 09:13:33 +000052#include <deque>
Richard Smith84837d52012-05-03 18:27:39 +000053#include <iterator>
Caitlin Sadowskiafbbd8e2011-08-23 18:46:34 +000054#include <vector>
Ted Kremenek918fe842010-03-20 21:06:02 +000055
56using namespace clang;
57
58//===----------------------------------------------------------------------===//
59// Unreachable code analysis.
60//===----------------------------------------------------------------------===//
61
62namespace {
63 class UnreachableCodeHandler : public reachable_code::Callback {
64 Sema &S;
65 public:
66 UnreachableCodeHandler(Sema &s) : S(s) {}
67
Ted Kremenek1a8641c2014-03-15 01:26:32 +000068 void HandleUnreachable(reachable_code::UnreachableKind UK,
Ted Kremenekec3bbf42014-03-29 00:35:20 +000069 SourceLocation L,
70 SourceRange SilenceableCondVal,
71 SourceRange R1,
Craig Toppere14c0f82014-03-12 04:55:44 +000072 SourceRange R2) override {
Ted Kremenek1a8641c2014-03-15 01:26:32 +000073 unsigned diag = diag::warn_unreachable;
74 switch (UK) {
75 case reachable_code::UK_Break:
76 diag = diag::warn_unreachable_break;
77 break;
Ted Kremenekf3c93bb2014-03-20 06:07:30 +000078 case reachable_code::UK_Return:
Ted Kremenekad8753c2014-03-15 05:47:06 +000079 diag = diag::warn_unreachable_return;
Ted Kremenek1a8641c2014-03-15 01:26:32 +000080 break;
Ted Kremenek14210372014-03-21 06:02:36 +000081 case reachable_code::UK_Loop_Increment:
82 diag = diag::warn_unreachable_loop_increment;
83 break;
Ted Kremenek1a8641c2014-03-15 01:26:32 +000084 case reachable_code::UK_Other:
85 break;
86 }
87
88 S.Diag(L, diag) << R1 << R2;
Ted Kremenekec3bbf42014-03-29 00:35:20 +000089
90 SourceLocation Open = SilenceableCondVal.getBegin();
91 if (Open.isValid()) {
Alp Tokerb6cc5922014-05-03 03:45:55 +000092 SourceLocation Close = SilenceableCondVal.getEnd();
93 Close = S.getLocForEndOfToken(Close);
Ted Kremenekec3bbf42014-03-29 00:35:20 +000094 if (Close.isValid()) {
95 S.Diag(Open, diag::note_unreachable_silence)
96 << FixItHint::CreateInsertion(Open, "/* DISABLES CODE */ (")
97 << FixItHint::CreateInsertion(Close, ")");
98 }
99 }
Ted Kremenek918fe842010-03-20 21:06:02 +0000100 }
101 };
102}
103
104/// CheckUnreachable - Check for unreachable code.
Ted Kremenek81ce1c82011-10-24 01:32:45 +0000105static void CheckUnreachable(Sema &S, AnalysisDeclContext &AC) {
Ted Kremenekc1b28752014-02-25 22:35:37 +0000106 // As a heuristic prune all diagnostics not in the main file. Currently
107 // the majority of warnings in headers are false positives. These
108 // are largely caused by configuration state, e.g. preprocessor
109 // defined code, etc.
110 //
111 // Note that this is also a performance optimization. Analyzing
112 // headers many times can be expensive.
113 if (!S.getSourceManager().isInMainFile(AC.getDecl()->getLocStart()))
114 return;
115
Ted Kremenek918fe842010-03-20 21:06:02 +0000116 UnreachableCodeHandler UC(S);
Ted Kremenek2dd810a2014-03-09 08:13:49 +0000117 reachable_code::FindUnreachableCode(AC, S.getPreprocessor(), UC);
Ted Kremenek918fe842010-03-20 21:06:02 +0000118}
119
Benjamin Kramer3a002252015-02-16 16:53:12 +0000120namespace {
Richard Trieuf935b562014-04-05 05:17:01 +0000121/// \brief Warn on logical operator errors in CFGBuilder
122class LogicalErrorHandler : public CFGCallback {
123 Sema &S;
124
125public:
126 LogicalErrorHandler(Sema &S) : CFGCallback(), S(S) {}
127
128 static bool HasMacroID(const Expr *E) {
129 if (E->getExprLoc().isMacroID())
130 return true;
131
132 // Recurse to children.
133 for (ConstStmtRange SubStmts = E->children(); SubStmts; ++SubStmts)
134 if (*SubStmts)
135 if (const Expr *SubExpr = dyn_cast<Expr>(*SubStmts))
136 if (HasMacroID(SubExpr))
137 return true;
138
139 return false;
140 }
141
Alexander Kornienko34eb2072015-04-11 02:00:23 +0000142 void compareAlwaysTrue(const BinaryOperator *B, bool isAlwaysTrue) override {
Richard Trieuf935b562014-04-05 05:17:01 +0000143 if (HasMacroID(B))
144 return;
145
146 SourceRange DiagRange = B->getSourceRange();
147 S.Diag(B->getExprLoc(), diag::warn_tautological_overlap_comparison)
148 << DiagRange << isAlwaysTrue;
149 }
Jordan Rose7afd71e2014-05-20 17:31:11 +0000150
Alexander Kornienko34eb2072015-04-11 02:00:23 +0000151 void compareBitwiseEquality(const BinaryOperator *B,
152 bool isAlwaysTrue) override {
Jordan Rose7afd71e2014-05-20 17:31:11 +0000153 if (HasMacroID(B))
154 return;
155
156 SourceRange DiagRange = B->getSourceRange();
157 S.Diag(B->getExprLoc(), diag::warn_comparison_bitwise_always)
158 << DiagRange << isAlwaysTrue;
159 }
Richard Trieuf935b562014-04-05 05:17:01 +0000160};
Benjamin Kramer3a002252015-02-16 16:53:12 +0000161} // namespace
Richard Trieuf935b562014-04-05 05:17:01 +0000162
Ted Kremenek918fe842010-03-20 21:06:02 +0000163//===----------------------------------------------------------------------===//
Richard Trieu2f024f42013-12-21 02:33:43 +0000164// Check for infinite self-recursion in functions
165//===----------------------------------------------------------------------===//
166
167// All blocks are in one of three states. States are ordered so that blocks
168// can only move to higher states.
169enum RecursiveState {
170 FoundNoPath,
171 FoundPath,
172 FoundPathWithNoRecursiveCall
173};
174
175static void checkForFunctionCall(Sema &S, const FunctionDecl *FD,
176 CFGBlock &Block, unsigned ExitID,
177 llvm::SmallVectorImpl<RecursiveState> &States,
178 RecursiveState State) {
179 unsigned ID = Block.getBlockID();
180
181 // A block's state can only move to a higher state.
182 if (States[ID] >= State)
183 return;
184
185 States[ID] = State;
186
187 // Found a path to the exit node without a recursive call.
188 if (ID == ExitID && State == FoundPathWithNoRecursiveCall)
189 return;
190
191 if (State == FoundPathWithNoRecursiveCall) {
192 // If the current state is FoundPathWithNoRecursiveCall, the successors
193 // will be either FoundPathWithNoRecursiveCall or FoundPath. To determine
194 // which, process all the Stmt's in this block to find any recursive calls.
Aaron Ballmane5195222014-05-15 20:50:47 +0000195 for (const auto &B : Block) {
196 if (B.getKind() != CFGElement::Statement)
Richard Trieu2f024f42013-12-21 02:33:43 +0000197 continue;
198
Aaron Ballmane5195222014-05-15 20:50:47 +0000199 const CallExpr *CE = dyn_cast<CallExpr>(B.getAs<CFGStmt>()->getStmt());
Richard Trieu2f024f42013-12-21 02:33:43 +0000200 if (CE && CE->getCalleeDecl() &&
201 CE->getCalleeDecl()->getCanonicalDecl() == FD) {
Richard Trieu658eb682014-01-04 01:57:42 +0000202
203 // Skip function calls which are qualified with a templated class.
204 if (const DeclRefExpr *DRE = dyn_cast<DeclRefExpr>(
205 CE->getCallee()->IgnoreParenImpCasts())) {
206 if (NestedNameSpecifier *NNS = DRE->getQualifier()) {
207 if (NNS->getKind() == NestedNameSpecifier::TypeSpec &&
208 isa<TemplateSpecializationType>(NNS->getAsType())) {
209 continue;
210 }
211 }
212 }
213
Richard Trieu2f024f42013-12-21 02:33:43 +0000214 if (const CXXMemberCallExpr *MCE = dyn_cast<CXXMemberCallExpr>(CE)) {
215 if (isa<CXXThisExpr>(MCE->getImplicitObjectArgument()) ||
216 !MCE->getMethodDecl()->isVirtual()) {
217 State = FoundPath;
218 break;
219 }
220 } else {
221 State = FoundPath;
222 break;
223 }
224 }
225 }
226 }
227
228 for (CFGBlock::succ_iterator I = Block.succ_begin(), E = Block.succ_end();
229 I != E; ++I)
230 if (*I)
231 checkForFunctionCall(S, FD, **I, ExitID, States, State);
232}
233
234static void checkRecursiveFunction(Sema &S, const FunctionDecl *FD,
235 const Stmt *Body,
236 AnalysisDeclContext &AC) {
237 FD = FD->getCanonicalDecl();
238
239 // Only run on non-templated functions and non-templated members of
240 // templated classes.
241 if (FD->getTemplatedKind() != FunctionDecl::TK_NonTemplate &&
242 FD->getTemplatedKind() != FunctionDecl::TK_MemberSpecialization)
243 return;
244
245 CFG *cfg = AC.getCFG();
Craig Topperc3ec1492014-05-26 06:22:03 +0000246 if (!cfg) return;
Richard Trieu2f024f42013-12-21 02:33:43 +0000247
248 // If the exit block is unreachable, skip processing the function.
249 if (cfg->getExit().pred_empty())
250 return;
251
252 // Mark all nodes as FoundNoPath, then begin processing the entry block.
253 llvm::SmallVector<RecursiveState, 16> states(cfg->getNumBlockIDs(),
254 FoundNoPath);
255 checkForFunctionCall(S, FD, cfg->getEntry(), cfg->getExit().getBlockID(),
256 states, FoundPathWithNoRecursiveCall);
257
258 // Check that the exit block is reachable. This prevents triggering the
259 // warning on functions that do not terminate.
260 if (states[cfg->getExit().getBlockID()] == FoundPath)
261 S.Diag(Body->getLocStart(), diag::warn_infinite_recursive_function);
262}
263
264//===----------------------------------------------------------------------===//
Ted Kremenek918fe842010-03-20 21:06:02 +0000265// Check for missing return value.
266//===----------------------------------------------------------------------===//
267
John McCall5c6ec8c2010-05-16 09:34:11 +0000268enum ControlFlowKind {
269 UnknownFallThrough,
270 NeverFallThrough,
271 MaybeFallThrough,
272 AlwaysFallThrough,
273 NeverFallThroughOrReturn
274};
Ted Kremenek918fe842010-03-20 21:06:02 +0000275
276/// CheckFallThrough - Check that we don't fall off the end of a
277/// Statement that should return a value.
278///
Sylvestre Ledru33b5baf2012-09-27 10:16:10 +0000279/// \returns AlwaysFallThrough iff we always fall off the end of the statement,
280/// MaybeFallThrough iff we might or might not fall off the end,
281/// NeverFallThroughOrReturn iff we never fall off the end of the statement or
282/// return. We assume NeverFallThrough iff we never fall off the end of the
Ted Kremenek918fe842010-03-20 21:06:02 +0000283/// statement but we may return. We assume that functions not marked noreturn
284/// will return.
Ted Kremenek81ce1c82011-10-24 01:32:45 +0000285static ControlFlowKind CheckFallThrough(AnalysisDeclContext &AC) {
Ted Kremenek918fe842010-03-20 21:06:02 +0000286 CFG *cfg = AC.getCFG();
Craig Topperc3ec1492014-05-26 06:22:03 +0000287 if (!cfg) return UnknownFallThrough;
Ted Kremenek918fe842010-03-20 21:06:02 +0000288
289 // The CFG leaves in dead things, and we don't want the dead code paths to
290 // confuse us, so we mark all live things first.
Ted Kremenek918fe842010-03-20 21:06:02 +0000291 llvm::BitVector live(cfg->getNumBlockIDs());
Ted Kremenekbd913712011-08-23 23:05:11 +0000292 unsigned count = reachable_code::ScanReachableFromBlock(&cfg->getEntry(),
Ted Kremenek918fe842010-03-20 21:06:02 +0000293 live);
294
295 bool AddEHEdges = AC.getAddEHEdges();
296 if (!AddEHEdges && count != cfg->getNumBlockIDs())
297 // When there are things remaining dead, and we didn't add EH edges
298 // from CallExprs to the catch clauses, we have to go back and
299 // mark them as live.
Aaron Ballmane5195222014-05-15 20:50:47 +0000300 for (const auto *B : *cfg) {
301 if (!live[B->getBlockID()]) {
302 if (B->pred_begin() == B->pred_end()) {
303 if (B->getTerminator() && isa<CXXTryStmt>(B->getTerminator()))
Ted Kremenek918fe842010-03-20 21:06:02 +0000304 // When not adding EH edges from calls, catch clauses
305 // can otherwise seem dead. Avoid noting them as dead.
Aaron Ballmane5195222014-05-15 20:50:47 +0000306 count += reachable_code::ScanReachableFromBlock(B, live);
Ted Kremenek918fe842010-03-20 21:06:02 +0000307 continue;
308 }
309 }
310 }
311
312 // Now we know what is live, we check the live precessors of the exit block
313 // and look for fall through paths, being careful to ignore normal returns,
314 // and exceptional paths.
315 bool HasLiveReturn = false;
316 bool HasFakeEdge = false;
317 bool HasPlainEdge = false;
318 bool HasAbnormalEdge = false;
Ted Kremenek50205742010-09-09 00:06:07 +0000319
320 // Ignore default cases that aren't likely to be reachable because all
321 // enums in a switch(X) have explicit case statements.
322 CFGBlock::FilterOptions FO;
323 FO.IgnoreDefaultsWithCoveredEnums = 1;
324
325 for (CFGBlock::filtered_pred_iterator
326 I = cfg->getExit().filtered_pred_start_end(FO); I.hasMore(); ++I) {
327 const CFGBlock& B = **I;
Ted Kremenek918fe842010-03-20 21:06:02 +0000328 if (!live[B.getBlockID()])
329 continue;
Ted Kremenek5d068492011-01-26 04:49:52 +0000330
Chandler Carruth03faf782011-09-13 09:53:58 +0000331 // Skip blocks which contain an element marked as no-return. They don't
332 // represent actually viable edges into the exit block, so mark them as
333 // abnormal.
334 if (B.hasNoReturnElement()) {
335 HasAbnormalEdge = true;
336 continue;
337 }
338
Ted Kremenek5d068492011-01-26 04:49:52 +0000339 // Destructors can appear after the 'return' in the CFG. This is
340 // normal. We need to look pass the destructors for the return
341 // statement (if it exists).
342 CFGBlock::const_reverse_iterator ri = B.rbegin(), re = B.rend();
Ted Kremeneke06a55c2011-03-02 20:32:29 +0000343
Chandler Carruth03faf782011-09-13 09:53:58 +0000344 for ( ; ri != re ; ++ri)
David Blaikie2a01f5d2013-02-21 20:58:29 +0000345 if (ri->getAs<CFGStmt>())
Ted Kremenek5d068492011-01-26 04:49:52 +0000346 break;
Chandler Carruth03faf782011-09-13 09:53:58 +0000347
Ted Kremenek5d068492011-01-26 04:49:52 +0000348 // No more CFGElements in the block?
349 if (ri == re) {
Ted Kremenek918fe842010-03-20 21:06:02 +0000350 if (B.getTerminator() && isa<CXXTryStmt>(B.getTerminator())) {
351 HasAbnormalEdge = true;
352 continue;
353 }
Ted Kremenek918fe842010-03-20 21:06:02 +0000354 // A labeled empty statement, or the entry block...
355 HasPlainEdge = true;
356 continue;
357 }
Ted Kremenekebe62602011-01-25 22:50:47 +0000358
David Blaikie2a01f5d2013-02-21 20:58:29 +0000359 CFGStmt CS = ri->castAs<CFGStmt>();
Ted Kremenekadfb4452011-08-23 23:05:04 +0000360 const Stmt *S = CS.getStmt();
Ted Kremenek918fe842010-03-20 21:06:02 +0000361 if (isa<ReturnStmt>(S)) {
362 HasLiveReturn = true;
363 continue;
364 }
365 if (isa<ObjCAtThrowStmt>(S)) {
366 HasFakeEdge = true;
367 continue;
368 }
369 if (isa<CXXThrowExpr>(S)) {
370 HasFakeEdge = true;
371 continue;
372 }
Chad Rosier32503022012-06-11 20:47:18 +0000373 if (isa<MSAsmStmt>(S)) {
374 // TODO: Verify this is correct.
375 HasFakeEdge = true;
376 HasLiveReturn = true;
377 continue;
378 }
Ted Kremenek918fe842010-03-20 21:06:02 +0000379 if (isa<CXXTryStmt>(S)) {
380 HasAbnormalEdge = true;
381 continue;
382 }
Chandler Carruth03faf782011-09-13 09:53:58 +0000383 if (std::find(B.succ_begin(), B.succ_end(), &cfg->getExit())
384 == B.succ_end()) {
385 HasAbnormalEdge = true;
386 continue;
Ted Kremenek918fe842010-03-20 21:06:02 +0000387 }
Chandler Carruth03faf782011-09-13 09:53:58 +0000388
389 HasPlainEdge = true;
Ted Kremenek918fe842010-03-20 21:06:02 +0000390 }
391 if (!HasPlainEdge) {
392 if (HasLiveReturn)
393 return NeverFallThrough;
394 return NeverFallThroughOrReturn;
395 }
396 if (HasAbnormalEdge || HasFakeEdge || HasLiveReturn)
397 return MaybeFallThrough;
398 // This says AlwaysFallThrough for calls to functions that are not marked
399 // noreturn, that don't return. If people would like this warning to be more
400 // accurate, such functions should be marked as noreturn.
401 return AlwaysFallThrough;
402}
403
Dan Gohman28ade552010-07-26 21:25:24 +0000404namespace {
405
Ted Kremenek918fe842010-03-20 21:06:02 +0000406struct CheckFallThroughDiagnostics {
407 unsigned diag_MaybeFallThrough_HasNoReturn;
408 unsigned diag_MaybeFallThrough_ReturnsNonVoid;
409 unsigned diag_AlwaysFallThrough_HasNoReturn;
410 unsigned diag_AlwaysFallThrough_ReturnsNonVoid;
411 unsigned diag_NeverFallThroughOrReturn;
Douglas Gregorcf11eb72012-02-15 16:20:15 +0000412 enum { Function, Block, Lambda } funMode;
Argyrios Kyrtzidis1cb0de12010-12-15 18:44:22 +0000413 SourceLocation FuncLoc;
Ted Kremenek0b405322010-03-23 00:13:23 +0000414
Douglas Gregor24f27692010-04-16 23:28:44 +0000415 static CheckFallThroughDiagnostics MakeForFunction(const Decl *Func) {
Ted Kremenek918fe842010-03-20 21:06:02 +0000416 CheckFallThroughDiagnostics D;
Argyrios Kyrtzidis1cb0de12010-12-15 18:44:22 +0000417 D.FuncLoc = Func->getLocation();
Ted Kremenek918fe842010-03-20 21:06:02 +0000418 D.diag_MaybeFallThrough_HasNoReturn =
419 diag::warn_falloff_noreturn_function;
420 D.diag_MaybeFallThrough_ReturnsNonVoid =
421 diag::warn_maybe_falloff_nonvoid_function;
422 D.diag_AlwaysFallThrough_HasNoReturn =
423 diag::warn_falloff_noreturn_function;
424 D.diag_AlwaysFallThrough_ReturnsNonVoid =
425 diag::warn_falloff_nonvoid_function;
Douglas Gregor24f27692010-04-16 23:28:44 +0000426
427 // Don't suggest that virtual functions be marked "noreturn", since they
428 // might be overridden by non-noreturn functions.
429 bool isVirtualMethod = false;
430 if (const CXXMethodDecl *Method = dyn_cast<CXXMethodDecl>(Func))
431 isVirtualMethod = Method->isVirtual();
432
Douglas Gregor0de57202011-10-10 18:15:57 +0000433 // Don't suggest that template instantiations be marked "noreturn"
434 bool isTemplateInstantiation = false;
Ted Kremenek85825ae2011-12-01 00:59:17 +0000435 if (const FunctionDecl *Function = dyn_cast<FunctionDecl>(Func))
436 isTemplateInstantiation = Function->isTemplateInstantiation();
Douglas Gregor0de57202011-10-10 18:15:57 +0000437
438 if (!isVirtualMethod && !isTemplateInstantiation)
Douglas Gregor24f27692010-04-16 23:28:44 +0000439 D.diag_NeverFallThroughOrReturn =
440 diag::warn_suggest_noreturn_function;
441 else
442 D.diag_NeverFallThroughOrReturn = 0;
443
Douglas Gregorcf11eb72012-02-15 16:20:15 +0000444 D.funMode = Function;
Ted Kremenek918fe842010-03-20 21:06:02 +0000445 return D;
446 }
Ted Kremenek0b405322010-03-23 00:13:23 +0000447
Ted Kremenek918fe842010-03-20 21:06:02 +0000448 static CheckFallThroughDiagnostics MakeForBlock() {
449 CheckFallThroughDiagnostics D;
450 D.diag_MaybeFallThrough_HasNoReturn =
451 diag::err_noreturn_block_has_return_expr;
452 D.diag_MaybeFallThrough_ReturnsNonVoid =
453 diag::err_maybe_falloff_nonvoid_block;
454 D.diag_AlwaysFallThrough_HasNoReturn =
455 diag::err_noreturn_block_has_return_expr;
456 D.diag_AlwaysFallThrough_ReturnsNonVoid =
457 diag::err_falloff_nonvoid_block;
Fariborz Jahanian5ce22792014-04-03 23:06:35 +0000458 D.diag_NeverFallThroughOrReturn = 0;
Douglas Gregorcf11eb72012-02-15 16:20:15 +0000459 D.funMode = Block;
460 return D;
461 }
462
463 static CheckFallThroughDiagnostics MakeForLambda() {
464 CheckFallThroughDiagnostics D;
465 D.diag_MaybeFallThrough_HasNoReturn =
466 diag::err_noreturn_lambda_has_return_expr;
467 D.diag_MaybeFallThrough_ReturnsNonVoid =
468 diag::warn_maybe_falloff_nonvoid_lambda;
469 D.diag_AlwaysFallThrough_HasNoReturn =
470 diag::err_noreturn_lambda_has_return_expr;
471 D.diag_AlwaysFallThrough_ReturnsNonVoid =
472 diag::warn_falloff_nonvoid_lambda;
473 D.diag_NeverFallThroughOrReturn = 0;
474 D.funMode = Lambda;
Ted Kremenek918fe842010-03-20 21:06:02 +0000475 return D;
476 }
Ted Kremenek0b405322010-03-23 00:13:23 +0000477
David Blaikie9c902b52011-09-25 23:23:43 +0000478 bool checkDiagnostics(DiagnosticsEngine &D, bool ReturnsVoid,
Ted Kremenek918fe842010-03-20 21:06:02 +0000479 bool HasNoReturn) const {
Douglas Gregorcf11eb72012-02-15 16:20:15 +0000480 if (funMode == Function) {
Argyrios Kyrtzidis1cb0de12010-12-15 18:44:22 +0000481 return (ReturnsVoid ||
Alp Tokerd4a3f0e2014-06-15 23:30:39 +0000482 D.isIgnored(diag::warn_maybe_falloff_nonvoid_function,
483 FuncLoc)) &&
484 (!HasNoReturn ||
485 D.isIgnored(diag::warn_noreturn_function_has_return_expr,
486 FuncLoc)) &&
487 (!ReturnsVoid ||
488 D.isIgnored(diag::warn_suggest_noreturn_block, FuncLoc));
Ted Kremenek918fe842010-03-20 21:06:02 +0000489 }
Ted Kremenek0b405322010-03-23 00:13:23 +0000490
Douglas Gregorcf11eb72012-02-15 16:20:15 +0000491 // For blocks / lambdas.
Fariborz Jahanian5ce22792014-04-03 23:06:35 +0000492 return ReturnsVoid && !HasNoReturn;
Ted Kremenek918fe842010-03-20 21:06:02 +0000493 }
494};
495
Dan Gohman28ade552010-07-26 21:25:24 +0000496}
497
Ted Kremenek918fe842010-03-20 21:06:02 +0000498/// CheckFallThroughForFunctionDef - Check that we don't fall off the end of a
499/// function that should return a value. Check that we don't fall off the end
500/// of a noreturn function. We assume that functions and blocks not marked
501/// noreturn will return.
502static void CheckFallThroughForBody(Sema &S, const Decl *D, const Stmt *Body,
Ted Kremenek1767a272011-02-23 01:51:48 +0000503 const BlockExpr *blkExpr,
Ted Kremenek918fe842010-03-20 21:06:02 +0000504 const CheckFallThroughDiagnostics& CD,
Ted Kremenek81ce1c82011-10-24 01:32:45 +0000505 AnalysisDeclContext &AC) {
Ted Kremenek918fe842010-03-20 21:06:02 +0000506
507 bool ReturnsVoid = false;
508 bool HasNoReturn = false;
509
510 if (const FunctionDecl *FD = dyn_cast<FunctionDecl>(D)) {
Alp Toker314cc812014-01-25 16:55:45 +0000511 ReturnsVoid = FD->getReturnType()->isVoidType();
Richard Smith10876ef2013-01-17 01:30:42 +0000512 HasNoReturn = FD->isNoReturn();
Ted Kremenek918fe842010-03-20 21:06:02 +0000513 }
514 else if (const ObjCMethodDecl *MD = dyn_cast<ObjCMethodDecl>(D)) {
Alp Toker314cc812014-01-25 16:55:45 +0000515 ReturnsVoid = MD->getReturnType()->isVoidType();
Ted Kremenek918fe842010-03-20 21:06:02 +0000516 HasNoReturn = MD->hasAttr<NoReturnAttr>();
517 }
518 else if (isa<BlockDecl>(D)) {
Ted Kremenek1767a272011-02-23 01:51:48 +0000519 QualType BlockTy = blkExpr->getType();
Ted Kremenek0b405322010-03-23 00:13:23 +0000520 if (const FunctionType *FT =
Ted Kremenek918fe842010-03-20 21:06:02 +0000521 BlockTy->getPointeeType()->getAs<FunctionType>()) {
Alp Toker314cc812014-01-25 16:55:45 +0000522 if (FT->getReturnType()->isVoidType())
Ted Kremenek918fe842010-03-20 21:06:02 +0000523 ReturnsVoid = true;
524 if (FT->getNoReturnAttr())
525 HasNoReturn = true;
526 }
527 }
528
David Blaikie9c902b52011-09-25 23:23:43 +0000529 DiagnosticsEngine &Diags = S.getDiagnostics();
Ted Kremenek918fe842010-03-20 21:06:02 +0000530
531 // Short circuit for compilation speed.
532 if (CD.checkDiagnostics(Diags, ReturnsVoid, HasNoReturn))
533 return;
Ted Kremenek0b405322010-03-23 00:13:23 +0000534
Aaron Ballmanb2e2c1b2014-10-24 13:19:19 +0000535 SourceLocation LBrace = Body->getLocStart(), RBrace = Body->getLocEnd();
536 // Either in a function body compound statement, or a function-try-block.
537 switch (CheckFallThrough(AC)) {
538 case UnknownFallThrough:
539 break;
John McCall5c6ec8c2010-05-16 09:34:11 +0000540
Aaron Ballmanb2e2c1b2014-10-24 13:19:19 +0000541 case MaybeFallThrough:
542 if (HasNoReturn)
543 S.Diag(RBrace, CD.diag_MaybeFallThrough_HasNoReturn);
544 else if (!ReturnsVoid)
545 S.Diag(RBrace, CD.diag_MaybeFallThrough_ReturnsNonVoid);
546 break;
547 case AlwaysFallThrough:
548 if (HasNoReturn)
549 S.Diag(RBrace, CD.diag_AlwaysFallThrough_HasNoReturn);
550 else if (!ReturnsVoid)
551 S.Diag(RBrace, CD.diag_AlwaysFallThrough_ReturnsNonVoid);
552 break;
553 case NeverFallThroughOrReturn:
554 if (ReturnsVoid && !HasNoReturn && CD.diag_NeverFallThroughOrReturn) {
555 if (const FunctionDecl *FD = dyn_cast<FunctionDecl>(D)) {
556 S.Diag(LBrace, CD.diag_NeverFallThroughOrReturn) << 0 << FD;
557 } else if (const ObjCMethodDecl *MD = dyn_cast<ObjCMethodDecl>(D)) {
558 S.Diag(LBrace, CD.diag_NeverFallThroughOrReturn) << 1 << MD;
559 } else {
560 S.Diag(LBrace, CD.diag_NeverFallThroughOrReturn);
Chandler Carruthc841b6e2011-08-31 09:01:53 +0000561 }
Aaron Ballmanb2e2c1b2014-10-24 13:19:19 +0000562 }
563 break;
564 case NeverFallThrough:
565 break;
Ted Kremenek918fe842010-03-20 21:06:02 +0000566 }
567}
568
569//===----------------------------------------------------------------------===//
Ted Kremenekb749a6d2011-01-15 02:58:47 +0000570// -Wuninitialized
571//===----------------------------------------------------------------------===//
572
Ted Kremenekb8d8c4e2011-04-04 20:56:00 +0000573namespace {
Chandler Carruth4e021822011-04-05 06:48:00 +0000574/// ContainsReference - A visitor class to search for references to
575/// a particular declaration (the needle) within any evaluated component of an
576/// expression (recursively).
Ted Kremenekb8d8c4e2011-04-04 20:56:00 +0000577class ContainsReference : public EvaluatedExprVisitor<ContainsReference> {
Chandler Carruth4e021822011-04-05 06:48:00 +0000578 bool FoundReference;
579 const DeclRefExpr *Needle;
580
Ted Kremenekb8d8c4e2011-04-04 20:56:00 +0000581public:
Chandler Carruth4e021822011-04-05 06:48:00 +0000582 ContainsReference(ASTContext &Context, const DeclRefExpr *Needle)
583 : EvaluatedExprVisitor<ContainsReference>(Context),
584 FoundReference(false), Needle(Needle) {}
585
586 void VisitExpr(Expr *E) {
Ted Kremenekb8d8c4e2011-04-04 20:56:00 +0000587 // Stop evaluating if we already have a reference.
Chandler Carruth4e021822011-04-05 06:48:00 +0000588 if (FoundReference)
Ted Kremenekb8d8c4e2011-04-04 20:56:00 +0000589 return;
Chandler Carruth4e021822011-04-05 06:48:00 +0000590
591 EvaluatedExprVisitor<ContainsReference>::VisitExpr(E);
Ted Kremenekb8d8c4e2011-04-04 20:56:00 +0000592 }
Chandler Carruth4e021822011-04-05 06:48:00 +0000593
594 void VisitDeclRefExpr(DeclRefExpr *E) {
595 if (E == Needle)
596 FoundReference = true;
597 else
598 EvaluatedExprVisitor<ContainsReference>::VisitDeclRefExpr(E);
Ted Kremenekb8d8c4e2011-04-04 20:56:00 +0000599 }
Chandler Carruth4e021822011-04-05 06:48:00 +0000600
601 bool doesContainReference() const { return FoundReference; }
Ted Kremenekb8d8c4e2011-04-04 20:56:00 +0000602};
603}
604
David Blaikiee5f9a9e2011-09-10 05:35:08 +0000605static bool SuggestInitializationFixit(Sema &S, const VarDecl *VD) {
Fariborz Jahanian429fadb2012-03-08 00:22:50 +0000606 QualType VariableTy = VD->getType().getCanonicalType();
607 if (VariableTy->isBlockPointerType() &&
608 !VD->hasAttr<BlocksAttr>()) {
Nico Weber3c68ee92014-07-08 23:46:20 +0000609 S.Diag(VD->getLocation(), diag::note_block_var_fixit_add_initialization)
610 << VD->getDeclName()
611 << FixItHint::CreateInsertion(VD->getLocation(), "__block ");
Fariborz Jahanian429fadb2012-03-08 00:22:50 +0000612 return true;
613 }
Richard Smithf7ec86a2013-09-20 00:27:40 +0000614
David Blaikiee5f9a9e2011-09-10 05:35:08 +0000615 // Don't issue a fixit if there is already an initializer.
616 if (VD->getInit())
617 return false;
Richard Trieu2cdcf822012-05-03 01:09:59 +0000618
619 // Don't suggest a fixit inside macros.
620 if (VD->getLocEnd().isMacroID())
621 return false;
622
Alp Tokerb6cc5922014-05-03 03:45:55 +0000623 SourceLocation Loc = S.getLocForEndOfToken(VD->getLocEnd());
Richard Smithf7ec86a2013-09-20 00:27:40 +0000624
625 // Suggest possible initialization (if any).
626 std::string Init = S.getFixItZeroInitializerForType(VariableTy, Loc);
627 if (Init.empty())
628 return false;
629
Richard Smith8d06f422012-01-12 23:53:29 +0000630 S.Diag(Loc, diag::note_var_fixit_add_initialization) << VD->getDeclName()
631 << FixItHint::CreateInsertion(Loc, Init);
632 return true;
David Blaikiee5f9a9e2011-09-10 05:35:08 +0000633}
634
Richard Smith1bb8edb82012-05-26 06:20:46 +0000635/// Create a fixit to remove an if-like statement, on the assumption that its
636/// condition is CondVal.
637static void CreateIfFixit(Sema &S, const Stmt *If, const Stmt *Then,
638 const Stmt *Else, bool CondVal,
639 FixItHint &Fixit1, FixItHint &Fixit2) {
640 if (CondVal) {
641 // If condition is always true, remove all but the 'then'.
642 Fixit1 = FixItHint::CreateRemoval(
643 CharSourceRange::getCharRange(If->getLocStart(),
644 Then->getLocStart()));
645 if (Else) {
646 SourceLocation ElseKwLoc = Lexer::getLocForEndOfToken(
647 Then->getLocEnd(), 0, S.getSourceManager(), S.getLangOpts());
648 Fixit2 = FixItHint::CreateRemoval(
649 SourceRange(ElseKwLoc, Else->getLocEnd()));
650 }
651 } else {
652 // If condition is always false, remove all but the 'else'.
653 if (Else)
654 Fixit1 = FixItHint::CreateRemoval(
655 CharSourceRange::getCharRange(If->getLocStart(),
656 Else->getLocStart()));
657 else
658 Fixit1 = FixItHint::CreateRemoval(If->getSourceRange());
659 }
660}
661
662/// DiagUninitUse -- Helper function to produce a diagnostic for an
663/// uninitialized use of a variable.
664static void DiagUninitUse(Sema &S, const VarDecl *VD, const UninitUse &Use,
665 bool IsCapturedByBlock) {
666 bool Diagnosed = false;
667
Richard Smithba8071e2013-09-12 18:49:10 +0000668 switch (Use.getKind()) {
669 case UninitUse::Always:
670 S.Diag(Use.getUser()->getLocStart(), diag::warn_uninit_var)
671 << VD->getDeclName() << IsCapturedByBlock
672 << Use.getUser()->getSourceRange();
673 return;
674
675 case UninitUse::AfterDecl:
676 case UninitUse::AfterCall:
677 S.Diag(VD->getLocation(), diag::warn_sometimes_uninit_var)
678 << VD->getDeclName() << IsCapturedByBlock
679 << (Use.getKind() == UninitUse::AfterDecl ? 4 : 5)
680 << const_cast<DeclContext*>(VD->getLexicalDeclContext())
681 << VD->getSourceRange();
682 S.Diag(Use.getUser()->getLocStart(), diag::note_uninit_var_use)
683 << IsCapturedByBlock << Use.getUser()->getSourceRange();
684 return;
685
686 case UninitUse::Maybe:
687 case UninitUse::Sometimes:
688 // Carry on to report sometimes-uninitialized branches, if possible,
689 // or a 'may be used uninitialized' diagnostic otherwise.
690 break;
691 }
692
Richard Smith1bb8edb82012-05-26 06:20:46 +0000693 // Diagnose each branch which leads to a sometimes-uninitialized use.
Richard Smith4323bf82012-05-25 02:17:09 +0000694 for (UninitUse::branch_iterator I = Use.branch_begin(), E = Use.branch_end();
695 I != E; ++I) {
Richard Smith1bb8edb82012-05-26 06:20:46 +0000696 assert(Use.getKind() == UninitUse::Sometimes);
697
698 const Expr *User = Use.getUser();
Richard Smith4323bf82012-05-25 02:17:09 +0000699 const Stmt *Term = I->Terminator;
Richard Smith1bb8edb82012-05-26 06:20:46 +0000700
701 // Information used when building the diagnostic.
Richard Smith4323bf82012-05-25 02:17:09 +0000702 unsigned DiagKind;
David Blaikie1d202a62012-10-08 01:11:04 +0000703 StringRef Str;
Richard Smith1bb8edb82012-05-26 06:20:46 +0000704 SourceRange Range;
705
Stefanus Du Toitb3318502013-03-01 21:41:22 +0000706 // FixIts to suppress the diagnostic by removing the dead condition.
Richard Smith1bb8edb82012-05-26 06:20:46 +0000707 // For all binary terminators, branch 0 is taken if the condition is true,
708 // and branch 1 is taken if the condition is false.
709 int RemoveDiagKind = -1;
710 const char *FixitStr =
711 S.getLangOpts().CPlusPlus ? (I->Output ? "true" : "false")
712 : (I->Output ? "1" : "0");
713 FixItHint Fixit1, Fixit2;
714
Richard Smithba8071e2013-09-12 18:49:10 +0000715 switch (Term ? Term->getStmtClass() : Stmt::DeclStmtClass) {
Richard Smith4323bf82012-05-25 02:17:09 +0000716 default:
Richard Smith1bb8edb82012-05-26 06:20:46 +0000717 // Don't know how to report this. Just fall back to 'may be used
Richard Smithba8071e2013-09-12 18:49:10 +0000718 // uninitialized'. FIXME: Can this happen?
Richard Smith4323bf82012-05-25 02:17:09 +0000719 continue;
720
721 // "condition is true / condition is false".
Richard Smith1bb8edb82012-05-26 06:20:46 +0000722 case Stmt::IfStmtClass: {
723 const IfStmt *IS = cast<IfStmt>(Term);
Richard Smith4323bf82012-05-25 02:17:09 +0000724 DiagKind = 0;
725 Str = "if";
Richard Smith1bb8edb82012-05-26 06:20:46 +0000726 Range = IS->getCond()->getSourceRange();
727 RemoveDiagKind = 0;
728 CreateIfFixit(S, IS, IS->getThen(), IS->getElse(),
729 I->Output, Fixit1, Fixit2);
Richard Smith4323bf82012-05-25 02:17:09 +0000730 break;
Richard Smith1bb8edb82012-05-26 06:20:46 +0000731 }
732 case Stmt::ConditionalOperatorClass: {
733 const ConditionalOperator *CO = cast<ConditionalOperator>(Term);
Richard Smith4323bf82012-05-25 02:17:09 +0000734 DiagKind = 0;
735 Str = "?:";
Richard Smith1bb8edb82012-05-26 06:20:46 +0000736 Range = CO->getCond()->getSourceRange();
737 RemoveDiagKind = 0;
738 CreateIfFixit(S, CO, CO->getTrueExpr(), CO->getFalseExpr(),
739 I->Output, Fixit1, Fixit2);
Richard Smith4323bf82012-05-25 02:17:09 +0000740 break;
Richard Smith1bb8edb82012-05-26 06:20:46 +0000741 }
Richard Smith4323bf82012-05-25 02:17:09 +0000742 case Stmt::BinaryOperatorClass: {
743 const BinaryOperator *BO = cast<BinaryOperator>(Term);
744 if (!BO->isLogicalOp())
745 continue;
746 DiagKind = 0;
747 Str = BO->getOpcodeStr();
748 Range = BO->getLHS()->getSourceRange();
Richard Smith1bb8edb82012-05-26 06:20:46 +0000749 RemoveDiagKind = 0;
750 if ((BO->getOpcode() == BO_LAnd && I->Output) ||
751 (BO->getOpcode() == BO_LOr && !I->Output))
752 // true && y -> y, false || y -> y.
753 Fixit1 = FixItHint::CreateRemoval(SourceRange(BO->getLocStart(),
754 BO->getOperatorLoc()));
755 else
756 // false && y -> false, true || y -> true.
757 Fixit1 = FixItHint::CreateReplacement(BO->getSourceRange(), FixitStr);
Richard Smith4323bf82012-05-25 02:17:09 +0000758 break;
759 }
760
761 // "loop is entered / loop is exited".
762 case Stmt::WhileStmtClass:
763 DiagKind = 1;
764 Str = "while";
765 Range = cast<WhileStmt>(Term)->getCond()->getSourceRange();
Richard Smith1bb8edb82012-05-26 06:20:46 +0000766 RemoveDiagKind = 1;
767 Fixit1 = FixItHint::CreateReplacement(Range, FixitStr);
Richard Smith4323bf82012-05-25 02:17:09 +0000768 break;
769 case Stmt::ForStmtClass:
770 DiagKind = 1;
771 Str = "for";
772 Range = cast<ForStmt>(Term)->getCond()->getSourceRange();
Richard Smith1bb8edb82012-05-26 06:20:46 +0000773 RemoveDiagKind = 1;
774 if (I->Output)
775 Fixit1 = FixItHint::CreateRemoval(Range);
776 else
777 Fixit1 = FixItHint::CreateReplacement(Range, FixitStr);
Richard Smith4323bf82012-05-25 02:17:09 +0000778 break;
Richard Smithba8071e2013-09-12 18:49:10 +0000779 case Stmt::CXXForRangeStmtClass:
780 if (I->Output == 1) {
781 // The use occurs if a range-based for loop's body never executes.
782 // That may be impossible, and there's no syntactic fix for this,
783 // so treat it as a 'may be uninitialized' case.
784 continue;
785 }
786 DiagKind = 1;
787 Str = "for";
788 Range = cast<CXXForRangeStmt>(Term)->getRangeInit()->getSourceRange();
789 break;
Richard Smith4323bf82012-05-25 02:17:09 +0000790
791 // "condition is true / loop is exited".
792 case Stmt::DoStmtClass:
793 DiagKind = 2;
794 Str = "do";
795 Range = cast<DoStmt>(Term)->getCond()->getSourceRange();
Richard Smith1bb8edb82012-05-26 06:20:46 +0000796 RemoveDiagKind = 1;
797 Fixit1 = FixItHint::CreateReplacement(Range, FixitStr);
Richard Smith4323bf82012-05-25 02:17:09 +0000798 break;
799
800 // "switch case is taken".
801 case Stmt::CaseStmtClass:
802 DiagKind = 3;
803 Str = "case";
804 Range = cast<CaseStmt>(Term)->getLHS()->getSourceRange();
805 break;
806 case Stmt::DefaultStmtClass:
807 DiagKind = 3;
808 Str = "default";
809 Range = cast<DefaultStmt>(Term)->getDefaultLoc();
810 break;
811 }
812
Richard Smith1bb8edb82012-05-26 06:20:46 +0000813 S.Diag(Range.getBegin(), diag::warn_sometimes_uninit_var)
814 << VD->getDeclName() << IsCapturedByBlock << DiagKind
815 << Str << I->Output << Range;
816 S.Diag(User->getLocStart(), diag::note_uninit_var_use)
817 << IsCapturedByBlock << User->getSourceRange();
818 if (RemoveDiagKind != -1)
819 S.Diag(Fixit1.RemoveRange.getBegin(), diag::note_uninit_fixit_remove_cond)
820 << RemoveDiagKind << Str << I->Output << Fixit1 << Fixit2;
821
822 Diagnosed = true;
Richard Smith4323bf82012-05-25 02:17:09 +0000823 }
Richard Smith1bb8edb82012-05-26 06:20:46 +0000824
825 if (!Diagnosed)
Richard Smithba8071e2013-09-12 18:49:10 +0000826 S.Diag(Use.getUser()->getLocStart(), diag::warn_maybe_uninit_var)
Richard Smith1bb8edb82012-05-26 06:20:46 +0000827 << VD->getDeclName() << IsCapturedByBlock
828 << Use.getUser()->getSourceRange();
Richard Smith4323bf82012-05-25 02:17:09 +0000829}
830
Chandler Carruthdd8f0d02011-04-05 18:27:05 +0000831/// DiagnoseUninitializedUse -- Helper function for diagnosing uses of an
832/// uninitialized variable. This manages the different forms of diagnostic
833/// emitted for particular types of uses. Returns true if the use was diagnosed
Richard Smith4323bf82012-05-25 02:17:09 +0000834/// as a warning. If a particular use is one we omit warnings for, returns
Chandler Carruthdd8f0d02011-04-05 18:27:05 +0000835/// false.
836static bool DiagnoseUninitializedUse(Sema &S, const VarDecl *VD,
Richard Smith4323bf82012-05-25 02:17:09 +0000837 const UninitUse &Use,
Ted Kremenek596fa162011-10-13 18:50:06 +0000838 bool alwaysReportSelfInit = false) {
Chandler Carruth895904da2011-04-05 18:18:05 +0000839
Richard Smith4323bf82012-05-25 02:17:09 +0000840 if (const DeclRefExpr *DRE = dyn_cast<DeclRefExpr>(Use.getUser())) {
Richard Trieu43a2fc72012-05-09 21:08:22 +0000841 // Inspect the initializer of the variable declaration which is
842 // being referenced prior to its initialization. We emit
843 // specialized diagnostics for self-initialization, and we
844 // specifically avoid warning about self references which take the
845 // form of:
846 //
847 // int x = x;
848 //
849 // This is used to indicate to GCC that 'x' is intentionally left
850 // uninitialized. Proven code paths which access 'x' in
851 // an uninitialized state after this will still warn.
852 if (const Expr *Initializer = VD->getInit()) {
853 if (!alwaysReportSelfInit && DRE == Initializer->IgnoreParenImpCasts())
854 return false;
Chandler Carruth895904da2011-04-05 18:18:05 +0000855
Richard Trieu43a2fc72012-05-09 21:08:22 +0000856 ContainsReference CR(S.Context, DRE);
857 CR.Visit(const_cast<Expr*>(Initializer));
858 if (CR.doesContainReference()) {
Chandler Carruth895904da2011-04-05 18:18:05 +0000859 S.Diag(DRE->getLocStart(),
860 diag::warn_uninit_self_reference_in_init)
Richard Trieu43a2fc72012-05-09 21:08:22 +0000861 << VD->getDeclName() << VD->getLocation() << DRE->getSourceRange();
862 return true;
Chandler Carruth895904da2011-04-05 18:18:05 +0000863 }
Chandler Carruth895904da2011-04-05 18:18:05 +0000864 }
Richard Trieu43a2fc72012-05-09 21:08:22 +0000865
Richard Smith1bb8edb82012-05-26 06:20:46 +0000866 DiagUninitUse(S, VD, Use, false);
Chandler Carruth895904da2011-04-05 18:18:05 +0000867 } else {
Richard Smith4323bf82012-05-25 02:17:09 +0000868 const BlockExpr *BE = cast<BlockExpr>(Use.getUser());
Richard Smith1bb8edb82012-05-26 06:20:46 +0000869 if (VD->getType()->isBlockPointerType() && !VD->hasAttr<BlocksAttr>())
870 S.Diag(BE->getLocStart(),
871 diag::warn_uninit_byref_blockvar_captured_by_block)
Fariborz Jahanian429fadb2012-03-08 00:22:50 +0000872 << VD->getDeclName();
Richard Smith1bb8edb82012-05-26 06:20:46 +0000873 else
874 DiagUninitUse(S, VD, Use, true);
Chandler Carruth895904da2011-04-05 18:18:05 +0000875 }
876
877 // Report where the variable was declared when the use wasn't within
David Blaikiee5f9a9e2011-09-10 05:35:08 +0000878 // the initializer of that declaration & we didn't already suggest
879 // an initialization fixit.
Richard Trieu43a2fc72012-05-09 21:08:22 +0000880 if (!SuggestInitializationFixit(S, VD))
Chandler Carruth895904da2011-04-05 18:18:05 +0000881 S.Diag(VD->getLocStart(), diag::note_uninit_var_def)
882 << VD->getDeclName();
883
Chandler Carruthdd8f0d02011-04-05 18:27:05 +0000884 return true;
Chandler Carruth7a037202011-04-05 18:18:08 +0000885}
886
Richard Smith84837d52012-05-03 18:27:39 +0000887namespace {
888 class FallthroughMapper : public RecursiveASTVisitor<FallthroughMapper> {
889 public:
890 FallthroughMapper(Sema &S)
891 : FoundSwitchStatements(false),
892 S(S) {
893 }
894
895 bool foundSwitchStatements() const { return FoundSwitchStatements; }
896
897 void markFallthroughVisited(const AttributedStmt *Stmt) {
898 bool Found = FallthroughStmts.erase(Stmt);
899 assert(Found);
Kaelyn Uhrain29a8eeb2012-05-03 19:46:38 +0000900 (void)Found;
Richard Smith84837d52012-05-03 18:27:39 +0000901 }
902
903 typedef llvm::SmallPtrSet<const AttributedStmt*, 8> AttrStmts;
904
905 const AttrStmts &getFallthroughStmts() const {
906 return FallthroughStmts;
907 }
908
Alexander Kornienkoafed1dd2013-01-30 03:49:44 +0000909 void fillReachableBlocks(CFG *Cfg) {
910 assert(ReachableBlocks.empty() && "ReachableBlocks already filled");
911 std::deque<const CFGBlock *> BlockQueue;
912
913 ReachableBlocks.insert(&Cfg->getEntry());
914 BlockQueue.push_back(&Cfg->getEntry());
Alexander Kornienkoc121b9b2013-02-07 02:17:19 +0000915 // Mark all case blocks reachable to avoid problems with switching on
916 // constants, covered enums, etc.
917 // These blocks can contain fall-through annotations, and we don't want to
918 // issue a warn_fallthrough_attr_unreachable for them.
Aaron Ballmane5195222014-05-15 20:50:47 +0000919 for (const auto *B : *Cfg) {
Alexander Kornienkoc121b9b2013-02-07 02:17:19 +0000920 const Stmt *L = B->getLabel();
David Blaikie82e95a32014-11-19 07:49:47 +0000921 if (L && isa<SwitchCase>(L) && ReachableBlocks.insert(B).second)
Alexander Kornienkoc121b9b2013-02-07 02:17:19 +0000922 BlockQueue.push_back(B);
923 }
924
Alexander Kornienkoafed1dd2013-01-30 03:49:44 +0000925 while (!BlockQueue.empty()) {
926 const CFGBlock *P = BlockQueue.front();
927 BlockQueue.pop_front();
928 for (CFGBlock::const_succ_iterator I = P->succ_begin(),
929 E = P->succ_end();
930 I != E; ++I) {
David Blaikie82e95a32014-11-19 07:49:47 +0000931 if (*I && ReachableBlocks.insert(*I).second)
Alexander Kornienkoafed1dd2013-01-30 03:49:44 +0000932 BlockQueue.push_back(*I);
933 }
934 }
935 }
936
Richard Smith84837d52012-05-03 18:27:39 +0000937 bool checkFallThroughIntoBlock(const CFGBlock &B, int &AnnotatedCnt) {
Alexander Kornienkoafed1dd2013-01-30 03:49:44 +0000938 assert(!ReachableBlocks.empty() && "ReachableBlocks empty");
939
Richard Smith84837d52012-05-03 18:27:39 +0000940 int UnannotatedCnt = 0;
941 AnnotatedCnt = 0;
942
Aaron Ballmane5195222014-05-15 20:50:47 +0000943 std::deque<const CFGBlock*> BlockQueue(B.pred_begin(), B.pred_end());
Richard Smith84837d52012-05-03 18:27:39 +0000944 while (!BlockQueue.empty()) {
945 const CFGBlock *P = BlockQueue.front();
946 BlockQueue.pop_front();
Nick Lewyckycdf11082014-02-27 02:43:25 +0000947 if (!P) continue;
Richard Smith84837d52012-05-03 18:27:39 +0000948
949 const Stmt *Term = P->getTerminator();
950 if (Term && isa<SwitchStmt>(Term))
951 continue; // Switch statement, good.
952
953 const SwitchCase *SW = dyn_cast_or_null<SwitchCase>(P->getLabel());
954 if (SW && SW->getSubStmt() == B.getLabel() && P->begin() == P->end())
955 continue; // Previous case label has no statements, good.
956
Alexander Kornienko09f15f32013-01-25 20:44:56 +0000957 const LabelStmt *L = dyn_cast_or_null<LabelStmt>(P->getLabel());
958 if (L && L->getSubStmt() == B.getLabel() && P->begin() == P->end())
959 continue; // Case label is preceded with a normal label, good.
960
Alexander Kornienkoafed1dd2013-01-30 03:49:44 +0000961 if (!ReachableBlocks.count(P)) {
Alexander Kornienkoc121b9b2013-02-07 02:17:19 +0000962 for (CFGBlock::const_reverse_iterator ElemIt = P->rbegin(),
963 ElemEnd = P->rend();
964 ElemIt != ElemEnd; ++ElemIt) {
David Blaikie00be69a2013-02-23 00:29:34 +0000965 if (Optional<CFGStmt> CS = ElemIt->getAs<CFGStmt>()) {
966 if (const AttributedStmt *AS = asFallThroughAttr(CS->getStmt())) {
Richard Smith84837d52012-05-03 18:27:39 +0000967 S.Diag(AS->getLocStart(),
968 diag::warn_fallthrough_attr_unreachable);
969 markFallthroughVisited(AS);
970 ++AnnotatedCnt;
Alexander Kornienkoc121b9b2013-02-07 02:17:19 +0000971 break;
Richard Smith84837d52012-05-03 18:27:39 +0000972 }
973 // Don't care about other unreachable statements.
974 }
975 }
976 // If there are no unreachable statements, this may be a special
977 // case in CFG:
978 // case X: {
979 // A a; // A has a destructor.
980 // break;
981 // }
982 // // <<<< This place is represented by a 'hanging' CFG block.
983 // case Y:
984 continue;
985 }
986
987 const Stmt *LastStmt = getLastStmt(*P);
988 if (const AttributedStmt *AS = asFallThroughAttr(LastStmt)) {
989 markFallthroughVisited(AS);
990 ++AnnotatedCnt;
991 continue; // Fallthrough annotation, good.
992 }
993
994 if (!LastStmt) { // This block contains no executable statements.
995 // Traverse its predecessors.
996 std::copy(P->pred_begin(), P->pred_end(),
997 std::back_inserter(BlockQueue));
998 continue;
999 }
1000
1001 ++UnannotatedCnt;
1002 }
1003 return !!UnannotatedCnt;
1004 }
1005
1006 // RecursiveASTVisitor setup.
1007 bool shouldWalkTypesOfTypeLocs() const { return false; }
1008
1009 bool VisitAttributedStmt(AttributedStmt *S) {
1010 if (asFallThroughAttr(S))
1011 FallthroughStmts.insert(S);
1012 return true;
1013 }
1014
1015 bool VisitSwitchStmt(SwitchStmt *S) {
1016 FoundSwitchStatements = true;
1017 return true;
1018 }
1019
Alexander Kornienkoa9c809f2013-04-02 15:20:32 +00001020 // We don't want to traverse local type declarations. We analyze their
1021 // methods separately.
1022 bool TraverseDecl(Decl *D) { return true; }
1023
Alexander Kornienkobf911642014-06-24 15:28:21 +00001024 // We analyze lambda bodies separately. Skip them here.
1025 bool TraverseLambdaBody(LambdaExpr *LE) { return true; }
1026
Richard Smith84837d52012-05-03 18:27:39 +00001027 private:
1028
1029 static const AttributedStmt *asFallThroughAttr(const Stmt *S) {
1030 if (const AttributedStmt *AS = dyn_cast_or_null<AttributedStmt>(S)) {
1031 if (hasSpecificAttr<FallThroughAttr>(AS->getAttrs()))
1032 return AS;
1033 }
Craig Topperc3ec1492014-05-26 06:22:03 +00001034 return nullptr;
Richard Smith84837d52012-05-03 18:27:39 +00001035 }
1036
1037 static const Stmt *getLastStmt(const CFGBlock &B) {
1038 if (const Stmt *Term = B.getTerminator())
1039 return Term;
1040 for (CFGBlock::const_reverse_iterator ElemIt = B.rbegin(),
1041 ElemEnd = B.rend();
1042 ElemIt != ElemEnd; ++ElemIt) {
David Blaikie00be69a2013-02-23 00:29:34 +00001043 if (Optional<CFGStmt> CS = ElemIt->getAs<CFGStmt>())
1044 return CS->getStmt();
Richard Smith84837d52012-05-03 18:27:39 +00001045 }
1046 // Workaround to detect a statement thrown out by CFGBuilder:
1047 // case X: {} case Y:
1048 // case X: ; case Y:
1049 if (const SwitchCase *SW = dyn_cast_or_null<SwitchCase>(B.getLabel()))
1050 if (!isa<SwitchCase>(SW->getSubStmt()))
1051 return SW->getSubStmt();
1052
Craig Topperc3ec1492014-05-26 06:22:03 +00001053 return nullptr;
Richard Smith84837d52012-05-03 18:27:39 +00001054 }
1055
1056 bool FoundSwitchStatements;
1057 AttrStmts FallthroughStmts;
1058 Sema &S;
Alexander Kornienkoafed1dd2013-01-30 03:49:44 +00001059 llvm::SmallPtrSet<const CFGBlock *, 16> ReachableBlocks;
Richard Smith84837d52012-05-03 18:27:39 +00001060 };
1061}
1062
Alexander Kornienko06caf7d2012-06-02 01:01:07 +00001063static void DiagnoseSwitchLabelsFallthrough(Sema &S, AnalysisDeclContext &AC,
Alexis Hunt2178f142012-06-15 21:22:05 +00001064 bool PerFunction) {
Ted Kremenekda5919f2012-11-12 21:20:48 +00001065 // Only perform this analysis when using C++11. There is no good workflow
1066 // for this warning when not using C++11. There is no good way to silence
1067 // the warning (no attribute is available) unless we are using C++11's support
1068 // for generalized attributes. Once could use pragmas to silence the warning,
1069 // but as a general solution that is gross and not in the spirit of this
1070 // warning.
1071 //
1072 // NOTE: This an intermediate solution. There are on-going discussions on
1073 // how to properly support this warning outside of C++11 with an annotation.
Richard Smith2bf7fdb2013-01-02 11:42:31 +00001074 if (!AC.getASTContext().getLangOpts().CPlusPlus11)
Ted Kremenekda5919f2012-11-12 21:20:48 +00001075 return;
1076
Richard Smith84837d52012-05-03 18:27:39 +00001077 FallthroughMapper FM(S);
1078 FM.TraverseStmt(AC.getBody());
1079
1080 if (!FM.foundSwitchStatements())
1081 return;
1082
Alexis Hunt2178f142012-06-15 21:22:05 +00001083 if (PerFunction && FM.getFallthroughStmts().empty())
Alexander Kornienko06caf7d2012-06-02 01:01:07 +00001084 return;
1085
Richard Smith84837d52012-05-03 18:27:39 +00001086 CFG *Cfg = AC.getCFG();
1087
1088 if (!Cfg)
1089 return;
1090
Alexander Kornienkoafed1dd2013-01-30 03:49:44 +00001091 FM.fillReachableBlocks(Cfg);
Richard Smith84837d52012-05-03 18:27:39 +00001092
1093 for (CFG::reverse_iterator I = Cfg->rbegin(), E = Cfg->rend(); I != E; ++I) {
Alexander Kornienko55488792013-01-25 15:49:34 +00001094 const CFGBlock *B = *I;
1095 const Stmt *Label = B->getLabel();
Richard Smith84837d52012-05-03 18:27:39 +00001096
1097 if (!Label || !isa<SwitchCase>(Label))
1098 continue;
1099
Alexander Kornienkoafed1dd2013-01-30 03:49:44 +00001100 int AnnotatedCnt;
1101
Alexander Kornienko55488792013-01-25 15:49:34 +00001102 if (!FM.checkFallThroughIntoBlock(*B, AnnotatedCnt))
Richard Smith84837d52012-05-03 18:27:39 +00001103 continue;
1104
Alexander Kornienko06caf7d2012-06-02 01:01:07 +00001105 S.Diag(Label->getLocStart(),
Alexis Hunt2178f142012-06-15 21:22:05 +00001106 PerFunction ? diag::warn_unannotated_fallthrough_per_function
1107 : diag::warn_unannotated_fallthrough);
Richard Smith84837d52012-05-03 18:27:39 +00001108
1109 if (!AnnotatedCnt) {
1110 SourceLocation L = Label->getLocStart();
1111 if (L.isMacroID())
1112 continue;
Richard Smith2bf7fdb2013-01-02 11:42:31 +00001113 if (S.getLangOpts().CPlusPlus11) {
Alexander Kornienko55488792013-01-25 15:49:34 +00001114 const Stmt *Term = B->getTerminator();
1115 // Skip empty cases.
1116 while (B->empty() && !Term && B->succ_size() == 1) {
1117 B = *B->succ_begin();
1118 Term = B->getTerminator();
1119 }
1120 if (!(B->empty() && Term && isa<BreakStmt>(Term))) {
Alexander Kornienkoe61e5622012-09-28 22:24:03 +00001121 Preprocessor &PP = S.getPreprocessor();
1122 TokenValue Tokens[] = {
1123 tok::l_square, tok::l_square, PP.getIdentifierInfo("clang"),
1124 tok::coloncolon, PP.getIdentifierInfo("fallthrough"),
1125 tok::r_square, tok::r_square
1126 };
Dmitri Gribenko6743e042012-09-29 11:40:46 +00001127 StringRef AnnotationSpelling = "[[clang::fallthrough]]";
1128 StringRef MacroName = PP.getLastMacroWithSpelling(L, Tokens);
1129 if (!MacroName.empty())
1130 AnnotationSpelling = MacroName;
1131 SmallString<64> TextToInsert(AnnotationSpelling);
1132 TextToInsert += "; ";
Alexander Kornienko246e85d2012-05-26 00:49:15 +00001133 S.Diag(L, diag::note_insert_fallthrough_fixit) <<
Alexander Kornienkoe61e5622012-09-28 22:24:03 +00001134 AnnotationSpelling <<
Dmitri Gribenko6743e042012-09-29 11:40:46 +00001135 FixItHint::CreateInsertion(L, TextToInsert);
Alexander Kornienko246e85d2012-05-26 00:49:15 +00001136 }
Richard Smith84837d52012-05-03 18:27:39 +00001137 }
1138 S.Diag(L, diag::note_insert_break_fixit) <<
1139 FixItHint::CreateInsertion(L, "break; ");
1140 }
1141 }
1142
Aaron Ballmane5195222014-05-15 20:50:47 +00001143 for (const auto *F : FM.getFallthroughStmts())
1144 S.Diag(F->getLocStart(), diag::warn_fallthrough_attr_invalid_placement);
Richard Smith84837d52012-05-03 18:27:39 +00001145}
1146
Jordan Rose25c0ea82012-10-29 17:46:47 +00001147static bool isInLoop(const ASTContext &Ctx, const ParentMap &PM,
1148 const Stmt *S) {
Jordan Rose76831c62012-10-11 16:10:19 +00001149 assert(S);
1150
1151 do {
1152 switch (S->getStmtClass()) {
Jordan Rose76831c62012-10-11 16:10:19 +00001153 case Stmt::ForStmtClass:
1154 case Stmt::WhileStmtClass:
1155 case Stmt::CXXForRangeStmtClass:
1156 case Stmt::ObjCForCollectionStmtClass:
1157 return true;
Jordan Rose25c0ea82012-10-29 17:46:47 +00001158 case Stmt::DoStmtClass: {
1159 const Expr *Cond = cast<DoStmt>(S)->getCond();
1160 llvm::APSInt Val;
1161 if (!Cond->EvaluateAsInt(Val, Ctx))
1162 return true;
1163 return Val.getBoolValue();
1164 }
Jordan Rose76831c62012-10-11 16:10:19 +00001165 default:
1166 break;
1167 }
1168 } while ((S = PM.getParent(S)));
1169
1170 return false;
1171}
1172
Jordan Rosed3934582012-09-28 22:21:30 +00001173
1174static void diagnoseRepeatedUseOfWeak(Sema &S,
1175 const sema::FunctionScopeInfo *CurFn,
Jordan Rose76831c62012-10-11 16:10:19 +00001176 const Decl *D,
1177 const ParentMap &PM) {
Jordan Rosed3934582012-09-28 22:21:30 +00001178 typedef sema::FunctionScopeInfo::WeakObjectProfileTy WeakObjectProfileTy;
1179 typedef sema::FunctionScopeInfo::WeakObjectUseMap WeakObjectUseMap;
1180 typedef sema::FunctionScopeInfo::WeakUseVector WeakUseVector;
Benjamin Kramerbbdd7642014-03-01 14:48:57 +00001181 typedef std::pair<const Stmt *, WeakObjectUseMap::const_iterator>
1182 StmtUsesPair;
Jordan Rosed3934582012-09-28 22:21:30 +00001183
Jordan Rose25c0ea82012-10-29 17:46:47 +00001184 ASTContext &Ctx = S.getASTContext();
1185
Jordan Rosed3934582012-09-28 22:21:30 +00001186 const WeakObjectUseMap &WeakMap = CurFn->getWeakObjectUses();
1187
1188 // Extract all weak objects that are referenced more than once.
1189 SmallVector<StmtUsesPair, 8> UsesByStmt;
1190 for (WeakObjectUseMap::const_iterator I = WeakMap.begin(), E = WeakMap.end();
1191 I != E; ++I) {
1192 const WeakUseVector &Uses = I->second;
Jordan Rosed3934582012-09-28 22:21:30 +00001193
1194 // Find the first read of the weak object.
1195 WeakUseVector::const_iterator UI = Uses.begin(), UE = Uses.end();
1196 for ( ; UI != UE; ++UI) {
1197 if (UI->isUnsafe())
1198 break;
1199 }
1200
1201 // If there were only writes to this object, don't warn.
1202 if (UI == UE)
1203 continue;
1204
Jordan Rose76831c62012-10-11 16:10:19 +00001205 // If there was only one read, followed by any number of writes, and the
Jordan Rose25c0ea82012-10-29 17:46:47 +00001206 // read is not within a loop, don't warn. Additionally, don't warn in a
1207 // loop if the base object is a local variable -- local variables are often
1208 // changed in loops.
Jordan Rose76831c62012-10-11 16:10:19 +00001209 if (UI == Uses.begin()) {
1210 WeakUseVector::const_iterator UI2 = UI;
1211 for (++UI2; UI2 != UE; ++UI2)
1212 if (UI2->isUnsafe())
1213 break;
1214
Jordan Rose25c0ea82012-10-29 17:46:47 +00001215 if (UI2 == UE) {
1216 if (!isInLoop(Ctx, PM, UI->getUseExpr()))
Jordan Rose76831c62012-10-11 16:10:19 +00001217 continue;
Jordan Rose25c0ea82012-10-29 17:46:47 +00001218
1219 const WeakObjectProfileTy &Profile = I->first;
1220 if (!Profile.isExactProfile())
1221 continue;
1222
1223 const NamedDecl *Base = Profile.getBase();
1224 if (!Base)
1225 Base = Profile.getProperty();
1226 assert(Base && "A profile always has a base or property.");
1227
1228 if (const VarDecl *BaseVar = dyn_cast<VarDecl>(Base))
1229 if (BaseVar->hasLocalStorage() && !isa<ParmVarDecl>(Base))
1230 continue;
1231 }
Jordan Rose76831c62012-10-11 16:10:19 +00001232 }
1233
Jordan Rosed3934582012-09-28 22:21:30 +00001234 UsesByStmt.push_back(StmtUsesPair(UI->getUseExpr(), I));
1235 }
1236
1237 if (UsesByStmt.empty())
1238 return;
1239
1240 // Sort by first use so that we emit the warnings in a deterministic order.
Benjamin Kramerbbdd7642014-03-01 14:48:57 +00001241 SourceManager &SM = S.getSourceManager();
Jordan Rosed3934582012-09-28 22:21:30 +00001242 std::sort(UsesByStmt.begin(), UsesByStmt.end(),
Benjamin Kramerbbdd7642014-03-01 14:48:57 +00001243 [&SM](const StmtUsesPair &LHS, const StmtUsesPair &RHS) {
1244 return SM.isBeforeInTranslationUnit(LHS.first->getLocStart(),
1245 RHS.first->getLocStart());
1246 });
Jordan Rosed3934582012-09-28 22:21:30 +00001247
1248 // Classify the current code body for better warning text.
1249 // This enum should stay in sync with the cases in
1250 // warn_arc_repeated_use_of_weak and warn_arc_possible_repeated_use_of_weak.
1251 // FIXME: Should we use a common classification enum and the same set of
1252 // possibilities all throughout Sema?
1253 enum {
1254 Function,
1255 Method,
1256 Block,
1257 Lambda
1258 } FunctionKind;
1259
1260 if (isa<sema::BlockScopeInfo>(CurFn))
1261 FunctionKind = Block;
1262 else if (isa<sema::LambdaScopeInfo>(CurFn))
1263 FunctionKind = Lambda;
1264 else if (isa<ObjCMethodDecl>(D))
1265 FunctionKind = Method;
1266 else
1267 FunctionKind = Function;
1268
1269 // Iterate through the sorted problems and emit warnings for each.
Aaron Ballmane5195222014-05-15 20:50:47 +00001270 for (const auto &P : UsesByStmt) {
1271 const Stmt *FirstRead = P.first;
1272 const WeakObjectProfileTy &Key = P.second->first;
1273 const WeakUseVector &Uses = P.second->second;
Jordan Rosed3934582012-09-28 22:21:30 +00001274
Jordan Rose657b5f42012-09-28 22:21:35 +00001275 // For complicated expressions like 'a.b.c' and 'x.b.c', WeakObjectProfileTy
1276 // may not contain enough information to determine that these are different
1277 // properties. We can only be 100% sure of a repeated use in certain cases,
1278 // and we adjust the diagnostic kind accordingly so that the less certain
1279 // case can be turned off if it is too noisy.
Jordan Rosed3934582012-09-28 22:21:30 +00001280 unsigned DiagKind;
1281 if (Key.isExactProfile())
1282 DiagKind = diag::warn_arc_repeated_use_of_weak;
1283 else
1284 DiagKind = diag::warn_arc_possible_repeated_use_of_weak;
1285
Jordan Rose657b5f42012-09-28 22:21:35 +00001286 // Classify the weak object being accessed for better warning text.
1287 // This enum should stay in sync with the cases in
1288 // warn_arc_repeated_use_of_weak and warn_arc_possible_repeated_use_of_weak.
1289 enum {
1290 Variable,
1291 Property,
1292 ImplicitProperty,
1293 Ivar
1294 } ObjectKind;
1295
1296 const NamedDecl *D = Key.getProperty();
1297 if (isa<VarDecl>(D))
1298 ObjectKind = Variable;
1299 else if (isa<ObjCPropertyDecl>(D))
1300 ObjectKind = Property;
1301 else if (isa<ObjCMethodDecl>(D))
1302 ObjectKind = ImplicitProperty;
1303 else if (isa<ObjCIvarDecl>(D))
1304 ObjectKind = Ivar;
1305 else
1306 llvm_unreachable("Unexpected weak object kind!");
1307
Jordan Rosed3934582012-09-28 22:21:30 +00001308 // Show the first time the object was read.
1309 S.Diag(FirstRead->getLocStart(), DiagKind)
Joerg Sonnenbergerffc6d492013-06-26 21:31:47 +00001310 << int(ObjectKind) << D << int(FunctionKind)
Jordan Rosed3934582012-09-28 22:21:30 +00001311 << FirstRead->getSourceRange();
1312
1313 // Print all the other accesses as notes.
Aaron Ballmane5195222014-05-15 20:50:47 +00001314 for (const auto &Use : Uses) {
1315 if (Use.getUseExpr() == FirstRead)
Jordan Rosed3934582012-09-28 22:21:30 +00001316 continue;
Aaron Ballmane5195222014-05-15 20:50:47 +00001317 S.Diag(Use.getUseExpr()->getLocStart(),
Jordan Rosed3934582012-09-28 22:21:30 +00001318 diag::note_arc_weak_also_accessed_here)
Aaron Ballmane5195222014-05-15 20:50:47 +00001319 << Use.getUseExpr()->getSourceRange();
Jordan Rosed3934582012-09-28 22:21:30 +00001320 }
1321 }
1322}
1323
Jordan Rosed3934582012-09-28 22:21:30 +00001324namespace {
Ted Kremenekb749a6d2011-01-15 02:58:47 +00001325class UninitValsDiagReporter : public UninitVariablesHandler {
1326 Sema &S;
Chris Lattner0e62c1c2011-07-23 10:55:15 +00001327 typedef SmallVector<UninitUse, 2> UsesVec;
Benjamin Kramereb8c4462013-06-29 17:52:13 +00001328 typedef llvm::PointerIntPair<UsesVec *, 1, bool> MappedType;
Enea Zaffanella2f40be72013-02-15 20:09:55 +00001329 // Prefer using MapVector to DenseMap, so that iteration order will be
1330 // the same as insertion order. This is needed to obtain a deterministic
1331 // order of diagnostics when calling flushDiagnostics().
1332 typedef llvm::MapVector<const VarDecl *, MappedType> UsesMap;
Ted Kremenek39fa0562011-01-21 19:41:41 +00001333 UsesMap *uses;
1334
Ted Kremenekb749a6d2011-01-15 02:58:47 +00001335public:
Craig Topperc3ec1492014-05-26 06:22:03 +00001336 UninitValsDiagReporter(Sema &S) : S(S), uses(nullptr) {}
Alexander Kornienko34eb2072015-04-11 02:00:23 +00001337 ~UninitValsDiagReporter() override { flushDiagnostics(); }
Ted Kremenek596fa162011-10-13 18:50:06 +00001338
Enea Zaffanella2f40be72013-02-15 20:09:55 +00001339 MappedType &getUses(const VarDecl *vd) {
Ted Kremenek39fa0562011-01-21 19:41:41 +00001340 if (!uses)
1341 uses = new UsesMap();
Ted Kremenek596fa162011-10-13 18:50:06 +00001342
Enea Zaffanella2f40be72013-02-15 20:09:55 +00001343 MappedType &V = (*uses)[vd];
Benjamin Kramereb8c4462013-06-29 17:52:13 +00001344 if (!V.getPointer())
1345 V.setPointer(new UsesVec());
Ted Kremenek39fa0562011-01-21 19:41:41 +00001346
Ted Kremenek596fa162011-10-13 18:50:06 +00001347 return V;
1348 }
Craig Toppere14c0f82014-03-12 04:55:44 +00001349
1350 void handleUseOfUninitVariable(const VarDecl *vd,
1351 const UninitUse &use) override {
Benjamin Kramereb8c4462013-06-29 17:52:13 +00001352 getUses(vd).getPointer()->push_back(use);
Ted Kremenek596fa162011-10-13 18:50:06 +00001353 }
1354
Craig Toppere14c0f82014-03-12 04:55:44 +00001355 void handleSelfInit(const VarDecl *vd) override {
Benjamin Kramereb8c4462013-06-29 17:52:13 +00001356 getUses(vd).setInt(true);
Ted Kremenek39fa0562011-01-21 19:41:41 +00001357 }
1358
1359 void flushDiagnostics() {
1360 if (!uses)
1361 return;
Enea Zaffanella2f40be72013-02-15 20:09:55 +00001362
Aaron Ballmane5195222014-05-15 20:50:47 +00001363 for (const auto &P : *uses) {
1364 const VarDecl *vd = P.first;
1365 const MappedType &V = P.second;
Ted Kremenekb3dbe282011-02-02 23:35:53 +00001366
Benjamin Kramereb8c4462013-06-29 17:52:13 +00001367 UsesVec *vec = V.getPointer();
1368 bool hasSelfInit = V.getInt();
Ted Kremenek596fa162011-10-13 18:50:06 +00001369
1370 // Specially handle the case where we have uses of an uninitialized
1371 // variable, but the root cause is an idiomatic self-init. We want
1372 // to report the diagnostic at the self-init since that is the root cause.
Matt Beaumont-Gay4b489fa2011-10-19 18:53:03 +00001373 if (!vec->empty() && hasSelfInit && hasAlwaysUninitializedUse(vec))
Richard Smith4323bf82012-05-25 02:17:09 +00001374 DiagnoseUninitializedUse(S, vd,
1375 UninitUse(vd->getInit()->IgnoreParenCasts(),
1376 /* isAlwaysUninit */ true),
Matt Beaumont-Gay4b489fa2011-10-19 18:53:03 +00001377 /* alwaysReportSelfInit */ true);
Ted Kremenek596fa162011-10-13 18:50:06 +00001378 else {
1379 // Sort the uses by their SourceLocations. While not strictly
1380 // guaranteed to produce them in line/column order, this will provide
1381 // a stable ordering.
Benjamin Kramerbbdd7642014-03-01 14:48:57 +00001382 std::sort(vec->begin(), vec->end(),
1383 [](const UninitUse &a, const UninitUse &b) {
1384 // Prefer a more confident report over a less confident one.
1385 if (a.getKind() != b.getKind())
1386 return a.getKind() > b.getKind();
1387 return a.getUser()->getLocStart() < b.getUser()->getLocStart();
1388 });
1389
Aaron Ballmane5195222014-05-15 20:50:47 +00001390 for (const auto &U : *vec) {
Richard Smith4323bf82012-05-25 02:17:09 +00001391 // If we have self-init, downgrade all uses to 'may be uninitialized'.
Aaron Ballmane5195222014-05-15 20:50:47 +00001392 UninitUse Use = hasSelfInit ? UninitUse(U.getUser(), false) : U;
Richard Smith4323bf82012-05-25 02:17:09 +00001393
1394 if (DiagnoseUninitializedUse(S, vd, Use))
Ted Kremenek596fa162011-10-13 18:50:06 +00001395 // Skip further diagnostics for this variable. We try to warn only
1396 // on the first point at which a variable is used uninitialized.
1397 break;
1398 }
Chandler Carruth7a037202011-04-05 18:18:08 +00001399 }
Ted Kremenek596fa162011-10-13 18:50:06 +00001400
1401 // Release the uses vector.
Ted Kremenek39fa0562011-01-21 19:41:41 +00001402 delete vec;
1403 }
1404 delete uses;
Ted Kremenekb749a6d2011-01-15 02:58:47 +00001405 }
Matt Beaumont-Gay4b489fa2011-10-19 18:53:03 +00001406
1407private:
1408 static bool hasAlwaysUninitializedUse(const UsesVec* vec) {
Aaron Ballmane5195222014-05-15 20:50:47 +00001409 return std::any_of(vec->begin(), vec->end(), [](const UninitUse &U) {
1410 return U.getKind() == UninitUse::Always ||
1411 U.getKind() == UninitUse::AfterCall ||
1412 U.getKind() == UninitUse::AfterDecl;
1413 });
Matt Beaumont-Gay4b489fa2011-10-19 18:53:03 +00001414 }
Ted Kremenekb749a6d2011-01-15 02:58:47 +00001415};
1416}
1417
Caitlin Sadowski0b3501c2011-09-09 16:04:02 +00001418namespace clang {
DeLesley Hutchins48a31762013-08-12 21:20:55 +00001419namespace {
Dmitri Gribenkof8579502013-01-12 19:30:44 +00001420typedef SmallVector<PartialDiagnosticAt, 1> OptionalNotes;
Richard Smith92286672012-02-03 04:45:26 +00001421typedef std::pair<PartialDiagnosticAt, OptionalNotes> DelayedDiag;
Benjamin Kramer40b099b2012-03-26 14:05:40 +00001422typedef std::list<DelayedDiag> DiagList;
Caitlin Sadowski0b3501c2011-09-09 16:04:02 +00001423
Caitlin Sadowski0b3501c2011-09-09 16:04:02 +00001424struct SortDiagBySourceLocation {
Benjamin Kramer40b099b2012-03-26 14:05:40 +00001425 SourceManager &SM;
1426 SortDiagBySourceLocation(SourceManager &SM) : SM(SM) {}
Caitlin Sadowski0b3501c2011-09-09 16:04:02 +00001427
1428 bool operator()(const DelayedDiag &left, const DelayedDiag &right) {
1429 // Although this call will be slow, this is only called when outputting
1430 // multiple warnings.
Benjamin Kramer40b099b2012-03-26 14:05:40 +00001431 return SM.isBeforeInTranslationUnit(left.first.first, right.first.first);
Caitlin Sadowski0b3501c2011-09-09 16:04:02 +00001432 }
1433};
DeLesley Hutchins48a31762013-08-12 21:20:55 +00001434}}
Caitlin Sadowski0b3501c2011-09-09 16:04:02 +00001435
DeLesley Hutchins48a31762013-08-12 21:20:55 +00001436//===----------------------------------------------------------------------===//
1437// -Wthread-safety
1438//===----------------------------------------------------------------------===//
1439namespace clang {
DeLesley Hutchinsea1f8332014-07-28 15:57:27 +00001440namespace threadSafety {
Benjamin Kramer539803c2015-03-19 14:23:45 +00001441namespace {
DeLesley Hutchinsea1f8332014-07-28 15:57:27 +00001442class ThreadSafetyReporter : public clang::threadSafety::ThreadSafetyHandler {
Caitlin Sadowski0b3501c2011-09-09 16:04:02 +00001443 Sema &S;
1444 DiagList Warnings;
Richard Smith92286672012-02-03 04:45:26 +00001445 SourceLocation FunLocation, FunEndLocation;
Caitlin Sadowski0b3501c2011-09-09 16:04:02 +00001446
DeLesley Hutchinseb0ea5f2014-08-14 21:40:15 +00001447 const FunctionDecl *CurrentFunction;
1448 bool Verbose;
1449
Aaron Ballman71291bc2014-08-15 12:38:17 +00001450 OptionalNotes getNotes() const {
DeLesley Hutchinseb0ea5f2014-08-14 21:40:15 +00001451 if (Verbose && CurrentFunction) {
1452 PartialDiagnosticAt FNote(CurrentFunction->getBody()->getLocStart(),
Aaron Ballman71291bc2014-08-15 12:38:17 +00001453 S.PDiag(diag::note_thread_warning_in_fun)
1454 << CurrentFunction->getNameAsString());
DeLesley Hutchinseb0ea5f2014-08-14 21:40:15 +00001455 return OptionalNotes(1, FNote);
1456 }
Aaron Ballman71291bc2014-08-15 12:38:17 +00001457 return OptionalNotes();
DeLesley Hutchinseb0ea5f2014-08-14 21:40:15 +00001458 }
1459
Aaron Ballman71291bc2014-08-15 12:38:17 +00001460 OptionalNotes getNotes(const PartialDiagnosticAt &Note) const {
DeLesley Hutchinseb0ea5f2014-08-14 21:40:15 +00001461 OptionalNotes ONS(1, Note);
1462 if (Verbose && CurrentFunction) {
1463 PartialDiagnosticAt FNote(CurrentFunction->getBody()->getLocStart(),
Aaron Ballman71291bc2014-08-15 12:38:17 +00001464 S.PDiag(diag::note_thread_warning_in_fun)
1465 << CurrentFunction->getNameAsString());
Benjamin Kramer3204b152015-05-29 19:42:19 +00001466 ONS.push_back(std::move(FNote));
DeLesley Hutchinseb0ea5f2014-08-14 21:40:15 +00001467 }
1468 return ONS;
1469 }
1470
DeLesley Hutchinsc60dc2c2014-09-18 23:02:26 +00001471 OptionalNotes getNotes(const PartialDiagnosticAt &Note1,
1472 const PartialDiagnosticAt &Note2) const {
1473 OptionalNotes ONS;
1474 ONS.push_back(Note1);
1475 ONS.push_back(Note2);
1476 if (Verbose && CurrentFunction) {
1477 PartialDiagnosticAt FNote(CurrentFunction->getBody()->getLocStart(),
1478 S.PDiag(diag::note_thread_warning_in_fun)
1479 << CurrentFunction->getNameAsString());
Benjamin Kramer3204b152015-05-29 19:42:19 +00001480 ONS.push_back(std::move(FNote));
DeLesley Hutchinsc60dc2c2014-09-18 23:02:26 +00001481 }
1482 return ONS;
1483 }
1484
Caitlin Sadowski0b3501c2011-09-09 16:04:02 +00001485 // Helper functions
Aaron Ballmane0449042014-04-01 21:43:23 +00001486 void warnLockMismatch(unsigned DiagID, StringRef Kind, Name LockName,
1487 SourceLocation Loc) {
DeLesley Hutchinsc2090512011-10-21 18:10:14 +00001488 // Gracefully handle rare cases when the analysis can't get a more
1489 // precise source location.
1490 if (!Loc.isValid())
1491 Loc = FunLocation;
Aaron Ballmane0449042014-04-01 21:43:23 +00001492 PartialDiagnosticAt Warning(Loc, S.PDiag(DiagID) << Kind << LockName);
Benjamin Kramer3204b152015-05-29 19:42:19 +00001493 Warnings.emplace_back(std::move(Warning), getNotes());
Caitlin Sadowski0b3501c2011-09-09 16:04:02 +00001494 }
1495
1496 public:
Richard Smith92286672012-02-03 04:45:26 +00001497 ThreadSafetyReporter(Sema &S, SourceLocation FL, SourceLocation FEL)
DeLesley Hutchinseb0ea5f2014-08-14 21:40:15 +00001498 : S(S), FunLocation(FL), FunEndLocation(FEL),
1499 CurrentFunction(nullptr), Verbose(false) {}
1500
1501 void setVerbose(bool b) { Verbose = b; }
Caitlin Sadowski0b3501c2011-09-09 16:04:02 +00001502
1503 /// \brief Emit all buffered diagnostics in order of sourcelocation.
1504 /// We need to output diagnostics produced while iterating through
1505 /// the lockset in deterministic order, so this function orders diagnostics
1506 /// and outputs them.
1507 void emitDiagnostics() {
Benjamin Kramer40b099b2012-03-26 14:05:40 +00001508 Warnings.sort(SortDiagBySourceLocation(S.getSourceManager()));
Aaron Ballmane5195222014-05-15 20:50:47 +00001509 for (const auto &Diag : Warnings) {
1510 S.Diag(Diag.first.first, Diag.first.second);
1511 for (const auto &Note : Diag.second)
1512 S.Diag(Note.first, Note.second);
Richard Smith92286672012-02-03 04:45:26 +00001513 }
Caitlin Sadowski0b3501c2011-09-09 16:04:02 +00001514 }
1515
Aaron Ballmane0449042014-04-01 21:43:23 +00001516 void handleInvalidLockExp(StringRef Kind, SourceLocation Loc) override {
1517 PartialDiagnosticAt Warning(Loc, S.PDiag(diag::warn_cannot_resolve_lock)
1518 << Loc);
Benjamin Kramer3204b152015-05-29 19:42:19 +00001519 Warnings.emplace_back(std::move(Warning), getNotes());
Caitlin Sadowskiff2f3f82011-09-09 16:21:55 +00001520 }
DeLesley Hutchinseb0ea5f2014-08-14 21:40:15 +00001521
Aaron Ballmane0449042014-04-01 21:43:23 +00001522 void handleUnmatchedUnlock(StringRef Kind, Name LockName,
1523 SourceLocation Loc) override {
1524 warnLockMismatch(diag::warn_unlock_but_no_lock, Kind, LockName, Loc);
Caitlin Sadowski0b3501c2011-09-09 16:04:02 +00001525 }
DeLesley Hutchinseb0ea5f2014-08-14 21:40:15 +00001526
Aaron Ballmane0449042014-04-01 21:43:23 +00001527 void handleIncorrectUnlockKind(StringRef Kind, Name LockName,
1528 LockKind Expected, LockKind Received,
Aaron Ballmandf115d92014-03-21 14:48:48 +00001529 SourceLocation Loc) override {
1530 if (Loc.isInvalid())
1531 Loc = FunLocation;
1532 PartialDiagnosticAt Warning(Loc, S.PDiag(diag::warn_unlock_kind_mismatch)
Aaron Ballmane0449042014-04-01 21:43:23 +00001533 << Kind << LockName << Received
1534 << Expected);
Benjamin Kramer3204b152015-05-29 19:42:19 +00001535 Warnings.emplace_back(std::move(Warning), getNotes());
Aaron Ballmandf115d92014-03-21 14:48:48 +00001536 }
DeLesley Hutchinseb0ea5f2014-08-14 21:40:15 +00001537
Aaron Ballmane0449042014-04-01 21:43:23 +00001538 void handleDoubleLock(StringRef Kind, Name LockName, SourceLocation Loc) override {
1539 warnLockMismatch(diag::warn_double_lock, Kind, LockName, Loc);
Caitlin Sadowski0b3501c2011-09-09 16:04:02 +00001540 }
1541
Aaron Ballmane0449042014-04-01 21:43:23 +00001542 void handleMutexHeldEndOfScope(StringRef Kind, Name LockName,
1543 SourceLocation LocLocked,
Richard Smith92286672012-02-03 04:45:26 +00001544 SourceLocation LocEndOfScope,
Craig Toppere14c0f82014-03-12 04:55:44 +00001545 LockErrorKind LEK) override {
Caitlin Sadowskiaf9b7c52011-09-15 17:25:19 +00001546 unsigned DiagID = 0;
1547 switch (LEK) {
1548 case LEK_LockedSomePredecessors:
Richard Smith92286672012-02-03 04:45:26 +00001549 DiagID = diag::warn_lock_some_predecessors;
Caitlin Sadowskiaf9b7c52011-09-15 17:25:19 +00001550 break;
1551 case LEK_LockedSomeLoopIterations:
1552 DiagID = diag::warn_expecting_lock_held_on_loop;
1553 break;
1554 case LEK_LockedAtEndOfFunction:
1555 DiagID = diag::warn_no_unlock;
1556 break;
DeLesley Hutchins6e6dbb72012-07-02 22:16:54 +00001557 case LEK_NotLockedAtEndOfFunction:
1558 DiagID = diag::warn_expecting_locked;
1559 break;
Caitlin Sadowskiaf9b7c52011-09-15 17:25:19 +00001560 }
Richard Smith92286672012-02-03 04:45:26 +00001561 if (LocEndOfScope.isInvalid())
1562 LocEndOfScope = FunEndLocation;
1563
Aaron Ballmane0449042014-04-01 21:43:23 +00001564 PartialDiagnosticAt Warning(LocEndOfScope, S.PDiag(DiagID) << Kind
1565 << LockName);
DeLesley Hutchinsfd374bb2013-04-08 20:11:11 +00001566 if (LocLocked.isValid()) {
Aaron Ballmane0449042014-04-01 21:43:23 +00001567 PartialDiagnosticAt Note(LocLocked, S.PDiag(diag::note_locked_here)
1568 << Kind);
Benjamin Kramer3204b152015-05-29 19:42:19 +00001569 Warnings.emplace_back(std::move(Warning), getNotes(Note));
DeLesley Hutchinsfd374bb2013-04-08 20:11:11 +00001570 return;
1571 }
Benjamin Kramer3204b152015-05-29 19:42:19 +00001572 Warnings.emplace_back(std::move(Warning), getNotes());
Caitlin Sadowski0b3501c2011-09-09 16:04:02 +00001573 }
1574
Aaron Ballmane0449042014-04-01 21:43:23 +00001575 void handleExclusiveAndShared(StringRef Kind, Name LockName,
1576 SourceLocation Loc1,
Craig Toppere14c0f82014-03-12 04:55:44 +00001577 SourceLocation Loc2) override {
Aaron Ballmane0449042014-04-01 21:43:23 +00001578 PartialDiagnosticAt Warning(Loc1,
1579 S.PDiag(diag::warn_lock_exclusive_and_shared)
1580 << Kind << LockName);
1581 PartialDiagnosticAt Note(Loc2, S.PDiag(diag::note_lock_exclusive_and_shared)
1582 << Kind << LockName);
Benjamin Kramer3204b152015-05-29 19:42:19 +00001583 Warnings.emplace_back(std::move(Warning), getNotes(Note));
Caitlin Sadowski0b3501c2011-09-09 16:04:02 +00001584 }
1585
Aaron Ballmane0449042014-04-01 21:43:23 +00001586 void handleNoMutexHeld(StringRef Kind, const NamedDecl *D,
1587 ProtectedOperationKind POK, AccessKind AK,
1588 SourceLocation Loc) override {
1589 assert((POK == POK_VarAccess || POK == POK_VarDereference) &&
1590 "Only works for variables");
Caitlin Sadowskie50d8c32011-09-14 20:09:09 +00001591 unsigned DiagID = POK == POK_VarAccess?
1592 diag::warn_variable_requires_any_lock:
1593 diag::warn_var_deref_requires_any_lock;
Richard Smith92286672012-02-03 04:45:26 +00001594 PartialDiagnosticAt Warning(Loc, S.PDiag(DiagID)
DeLesley Hutchinsa15e1b42012-09-19 19:18:29 +00001595 << D->getNameAsString() << getLockKindFromAccessKind(AK));
Benjamin Kramer3204b152015-05-29 19:42:19 +00001596 Warnings.emplace_back(std::move(Warning), getNotes());
Caitlin Sadowski0b3501c2011-09-09 16:04:02 +00001597 }
1598
Aaron Ballmane0449042014-04-01 21:43:23 +00001599 void handleMutexNotHeld(StringRef Kind, const NamedDecl *D,
1600 ProtectedOperationKind POK, Name LockName,
1601 LockKind LK, SourceLocation Loc,
Craig Toppere14c0f82014-03-12 04:55:44 +00001602 Name *PossibleMatch) override {
Caitlin Sadowski427f42e2011-09-13 18:01:58 +00001603 unsigned DiagID = 0;
DeLesley Hutchins5ff16442012-09-10 19:58:23 +00001604 if (PossibleMatch) {
1605 switch (POK) {
1606 case POK_VarAccess:
1607 DiagID = diag::warn_variable_requires_lock_precise;
1608 break;
1609 case POK_VarDereference:
1610 DiagID = diag::warn_var_deref_requires_lock_precise;
1611 break;
1612 case POK_FunctionCall:
1613 DiagID = diag::warn_fun_requires_lock_precise;
1614 break;
DeLesley Hutchinsc60dc2c2014-09-18 23:02:26 +00001615 case POK_PassByRef:
1616 DiagID = diag::warn_guarded_pass_by_reference;
1617 break;
1618 case POK_PtPassByRef:
1619 DiagID = diag::warn_pt_guarded_pass_by_reference;
1620 break;
DeLesley Hutchins5ff16442012-09-10 19:58:23 +00001621 }
Aaron Ballmane0449042014-04-01 21:43:23 +00001622 PartialDiagnosticAt Warning(Loc, S.PDiag(DiagID) << Kind
1623 << D->getNameAsString()
1624 << LockName << LK);
DeLesley Hutchins5ff16442012-09-10 19:58:23 +00001625 PartialDiagnosticAt Note(Loc, S.PDiag(diag::note_found_mutex_near_match)
Aaron Ballmane0449042014-04-01 21:43:23 +00001626 << *PossibleMatch);
DeLesley Hutchinsc60dc2c2014-09-18 23:02:26 +00001627 if (Verbose && POK == POK_VarAccess) {
1628 PartialDiagnosticAt VNote(D->getLocation(),
1629 S.PDiag(diag::note_guarded_by_declared_here)
1630 << D->getNameAsString());
Benjamin Kramer3204b152015-05-29 19:42:19 +00001631 Warnings.emplace_back(std::move(Warning), getNotes(Note, VNote));
DeLesley Hutchinsc60dc2c2014-09-18 23:02:26 +00001632 } else
Benjamin Kramer3204b152015-05-29 19:42:19 +00001633 Warnings.emplace_back(std::move(Warning), getNotes(Note));
DeLesley Hutchins5ff16442012-09-10 19:58:23 +00001634 } else {
1635 switch (POK) {
1636 case POK_VarAccess:
1637 DiagID = diag::warn_variable_requires_lock;
1638 break;
1639 case POK_VarDereference:
1640 DiagID = diag::warn_var_deref_requires_lock;
1641 break;
1642 case POK_FunctionCall:
1643 DiagID = diag::warn_fun_requires_lock;
1644 break;
DeLesley Hutchinsc60dc2c2014-09-18 23:02:26 +00001645 case POK_PassByRef:
1646 DiagID = diag::warn_guarded_pass_by_reference;
1647 break;
1648 case POK_PtPassByRef:
1649 DiagID = diag::warn_pt_guarded_pass_by_reference;
1650 break;
DeLesley Hutchins5ff16442012-09-10 19:58:23 +00001651 }
Aaron Ballmane0449042014-04-01 21:43:23 +00001652 PartialDiagnosticAt Warning(Loc, S.PDiag(DiagID) << Kind
1653 << D->getNameAsString()
1654 << LockName << LK);
DeLesley Hutchinseb0ea5f2014-08-14 21:40:15 +00001655 if (Verbose && POK == POK_VarAccess) {
1656 PartialDiagnosticAt Note(D->getLocation(),
Aaron Ballman71291bc2014-08-15 12:38:17 +00001657 S.PDiag(diag::note_guarded_by_declared_here)
1658 << D->getNameAsString());
Benjamin Kramer3204b152015-05-29 19:42:19 +00001659 Warnings.emplace_back(std::move(Warning), getNotes(Note));
Aaron Ballman71291bc2014-08-15 12:38:17 +00001660 } else
Benjamin Kramer3204b152015-05-29 19:42:19 +00001661 Warnings.emplace_back(std::move(Warning), getNotes());
Caitlin Sadowski0b3501c2011-09-09 16:04:02 +00001662 }
Caitlin Sadowski0b3501c2011-09-09 16:04:02 +00001663 }
1664
Alexander Kornienko34eb2072015-04-11 02:00:23 +00001665 void handleNegativeNotHeld(StringRef Kind, Name LockName, Name Neg,
1666 SourceLocation Loc) override {
DeLesley Hutchins3efd0492014-08-04 22:13:06 +00001667 PartialDiagnosticAt Warning(Loc,
1668 S.PDiag(diag::warn_acquire_requires_negative_cap)
1669 << Kind << LockName << Neg);
Benjamin Kramer3204b152015-05-29 19:42:19 +00001670 Warnings.emplace_back(std::move(Warning), getNotes());
DeLesley Hutchins3efd0492014-08-04 22:13:06 +00001671 }
1672
1673
Aaron Ballmane0449042014-04-01 21:43:23 +00001674 void handleFunExcludesLock(StringRef Kind, Name FunName, Name LockName,
Craig Toppere14c0f82014-03-12 04:55:44 +00001675 SourceLocation Loc) override {
Aaron Ballmane0449042014-04-01 21:43:23 +00001676 PartialDiagnosticAt Warning(Loc, S.PDiag(diag::warn_fun_excludes_mutex)
1677 << Kind << FunName << LockName);
Benjamin Kramer3204b152015-05-29 19:42:19 +00001678 Warnings.emplace_back(std::move(Warning), getNotes());
DeLesley Hutchinseb0ea5f2014-08-14 21:40:15 +00001679 }
1680
Alexander Kornienko34eb2072015-04-11 02:00:23 +00001681 void handleLockAcquiredBefore(StringRef Kind, Name L1Name, Name L2Name,
1682 SourceLocation Loc) override {
DeLesley Hutchinsab1dc2d2015-02-03 22:11:04 +00001683 PartialDiagnosticAt Warning(Loc,
1684 S.PDiag(diag::warn_acquired_before) << Kind << L1Name << L2Name);
Benjamin Kramer3204b152015-05-29 19:42:19 +00001685 Warnings.emplace_back(std::move(Warning), getNotes());
DeLesley Hutchinsab1dc2d2015-02-03 22:11:04 +00001686 }
1687
Alexander Kornienko34eb2072015-04-11 02:00:23 +00001688 void handleBeforeAfterCycle(Name L1Name, SourceLocation Loc) override {
DeLesley Hutchinsab1dc2d2015-02-03 22:11:04 +00001689 PartialDiagnosticAt Warning(Loc,
1690 S.PDiag(diag::warn_acquired_before_after_cycle) << L1Name);
Benjamin Kramer3204b152015-05-29 19:42:19 +00001691 Warnings.emplace_back(std::move(Warning), getNotes());
DeLesley Hutchinsab1dc2d2015-02-03 22:11:04 +00001692 }
1693
DeLesley Hutchinseb0ea5f2014-08-14 21:40:15 +00001694 void enterFunction(const FunctionDecl* FD) override {
1695 CurrentFunction = FD;
1696 }
1697
1698 void leaveFunction(const FunctionDecl* FD) override {
1699 CurrentFunction = 0;
Caitlin Sadowski0b3501c2011-09-09 16:04:02 +00001700 }
1701};
Benjamin Kramer539803c2015-03-19 14:23:45 +00001702} // namespace
1703} // namespace threadSafety
1704} // namespace clang
Caitlin Sadowski0b3501c2011-09-09 16:04:02 +00001705
Ted Kremenekb749a6d2011-01-15 02:58:47 +00001706//===----------------------------------------------------------------------===//
DeLesley Hutchins48a31762013-08-12 21:20:55 +00001707// -Wconsumed
1708//===----------------------------------------------------------------------===//
1709
1710namespace clang {
1711namespace consumed {
1712namespace {
1713class ConsumedWarningsHandler : public ConsumedWarningsHandlerBase {
1714
1715 Sema &S;
1716 DiagList Warnings;
1717
1718public:
DeLesley Hutchinsab1dc2d2015-02-03 22:11:04 +00001719
DeLesley Hutchins48a31762013-08-12 21:20:55 +00001720 ConsumedWarningsHandler(Sema &S) : S(S) {}
Craig Toppere14c0f82014-03-12 04:55:44 +00001721
1722 void emitDiagnostics() override {
DeLesley Hutchins48a31762013-08-12 21:20:55 +00001723 Warnings.sort(SortDiagBySourceLocation(S.getSourceManager()));
Aaron Ballmane5195222014-05-15 20:50:47 +00001724 for (const auto &Diag : Warnings) {
1725 S.Diag(Diag.first.first, Diag.first.second);
1726 for (const auto &Note : Diag.second)
1727 S.Diag(Note.first, Note.second);
DeLesley Hutchins48a31762013-08-12 21:20:55 +00001728 }
1729 }
Craig Toppere14c0f82014-03-12 04:55:44 +00001730
1731 void warnLoopStateMismatch(SourceLocation Loc,
1732 StringRef VariableName) override {
DeLesley Hutchins3277a612013-10-09 18:30:24 +00001733 PartialDiagnosticAt Warning(Loc, S.PDiag(diag::warn_loop_state_mismatch) <<
1734 VariableName);
Benjamin Kramer3204b152015-05-29 19:42:19 +00001735
1736 Warnings.emplace_back(std::move(Warning), OptionalNotes());
DeLesley Hutchins3277a612013-10-09 18:30:24 +00001737 }
1738
DeLesley Hutchins36ea1dd2013-10-17 22:53:04 +00001739 void warnParamReturnTypestateMismatch(SourceLocation Loc,
1740 StringRef VariableName,
1741 StringRef ExpectedState,
Craig Toppere14c0f82014-03-12 04:55:44 +00001742 StringRef ObservedState) override {
DeLesley Hutchins36ea1dd2013-10-17 22:53:04 +00001743
1744 PartialDiagnosticAt Warning(Loc, S.PDiag(
1745 diag::warn_param_return_typestate_mismatch) << VariableName <<
1746 ExpectedState << ObservedState);
Benjamin Kramer3204b152015-05-29 19:42:19 +00001747
1748 Warnings.emplace_back(std::move(Warning), OptionalNotes());
DeLesley Hutchins36ea1dd2013-10-17 22:53:04 +00001749 }
1750
DeLesley Hutchins69391772013-10-17 23:23:53 +00001751 void warnParamTypestateMismatch(SourceLocation Loc, StringRef ExpectedState,
Craig Toppere14c0f82014-03-12 04:55:44 +00001752 StringRef ObservedState) override {
DeLesley Hutchins69391772013-10-17 23:23:53 +00001753
1754 PartialDiagnosticAt Warning(Loc, S.PDiag(
1755 diag::warn_param_typestate_mismatch) << ExpectedState << ObservedState);
Benjamin Kramer3204b152015-05-29 19:42:19 +00001756
1757 Warnings.emplace_back(std::move(Warning), OptionalNotes());
DeLesley Hutchins69391772013-10-17 23:23:53 +00001758 }
1759
DeLesley Hutchinsfc368252013-09-03 20:11:38 +00001760 void warnReturnTypestateForUnconsumableType(SourceLocation Loc,
Craig Toppere14c0f82014-03-12 04:55:44 +00001761 StringRef TypeName) override {
DeLesley Hutchinsfc368252013-09-03 20:11:38 +00001762 PartialDiagnosticAt Warning(Loc, S.PDiag(
1763 diag::warn_return_typestate_for_unconsumable_type) << TypeName);
Benjamin Kramer3204b152015-05-29 19:42:19 +00001764
1765 Warnings.emplace_back(std::move(Warning), OptionalNotes());
DeLesley Hutchinsfc368252013-09-03 20:11:38 +00001766 }
1767
1768 void warnReturnTypestateMismatch(SourceLocation Loc, StringRef ExpectedState,
Craig Toppere14c0f82014-03-12 04:55:44 +00001769 StringRef ObservedState) override {
DeLesley Hutchinsfc368252013-09-03 20:11:38 +00001770
1771 PartialDiagnosticAt Warning(Loc, S.PDiag(
1772 diag::warn_return_typestate_mismatch) << ExpectedState << ObservedState);
Benjamin Kramer3204b152015-05-29 19:42:19 +00001773
1774 Warnings.emplace_back(std::move(Warning), OptionalNotes());
DeLesley Hutchinsfc368252013-09-03 20:11:38 +00001775 }
1776
DeLesley Hutchins210791a2013-10-04 21:28:06 +00001777 void warnUseOfTempInInvalidState(StringRef MethodName, StringRef State,
Craig Toppere14c0f82014-03-12 04:55:44 +00001778 SourceLocation Loc) override {
DeLesley Hutchins48a31762013-08-12 21:20:55 +00001779
1780 PartialDiagnosticAt Warning(Loc, S.PDiag(
DeLesley Hutchins210791a2013-10-04 21:28:06 +00001781 diag::warn_use_of_temp_in_invalid_state) << MethodName << State);
Benjamin Kramer3204b152015-05-29 19:42:19 +00001782
1783 Warnings.emplace_back(std::move(Warning), OptionalNotes());
DeLesley Hutchins48a31762013-08-12 21:20:55 +00001784 }
1785
DeLesley Hutchins210791a2013-10-04 21:28:06 +00001786 void warnUseInInvalidState(StringRef MethodName, StringRef VariableName,
Craig Toppere14c0f82014-03-12 04:55:44 +00001787 StringRef State, SourceLocation Loc) override {
DeLesley Hutchins48a31762013-08-12 21:20:55 +00001788
DeLesley Hutchins210791a2013-10-04 21:28:06 +00001789 PartialDiagnosticAt Warning(Loc, S.PDiag(diag::warn_use_in_invalid_state) <<
1790 MethodName << VariableName << State);
Benjamin Kramer3204b152015-05-29 19:42:19 +00001791
1792 Warnings.emplace_back(std::move(Warning), OptionalNotes());
DeLesley Hutchins48a31762013-08-12 21:20:55 +00001793 }
1794};
1795}}}
1796
1797//===----------------------------------------------------------------------===//
Ted Kremenek918fe842010-03-20 21:06:02 +00001798// AnalysisBasedWarnings - Worker object used by Sema to execute analysis-based
1799// warnings on a function, method, or block.
1800//===----------------------------------------------------------------------===//
1801
Ted Kremenek0b405322010-03-23 00:13:23 +00001802clang::sema::AnalysisBasedWarnings::Policy::Policy() {
1803 enableCheckFallThrough = 1;
1804 enableCheckUnreachable = 0;
Caitlin Sadowskiafbbd8e2011-08-23 18:46:34 +00001805 enableThreadSafetyAnalysis = 0;
DeLesley Hutchins48a31762013-08-12 21:20:55 +00001806 enableConsumedAnalysis = 0;
Ted Kremenek0b405322010-03-23 00:13:23 +00001807}
1808
Ted Kremenekad8753c2014-03-15 05:47:06 +00001809static unsigned isEnabled(DiagnosticsEngine &D, unsigned diag) {
Alp Tokerd4a3f0e2014-06-15 23:30:39 +00001810 return (unsigned)!D.isIgnored(diag, SourceLocation());
Ted Kremenekad8753c2014-03-15 05:47:06 +00001811}
1812
Chandler Carruthb4836ea2011-07-06 16:21:37 +00001813clang::sema::AnalysisBasedWarnings::AnalysisBasedWarnings(Sema &s)
1814 : S(s),
1815 NumFunctionsAnalyzed(0),
Benjamin Kramer581f48f2011-07-08 20:38:53 +00001816 NumFunctionsWithBadCFGs(0),
Chandler Carruthb4836ea2011-07-06 16:21:37 +00001817 NumCFGBlocks(0),
Benjamin Kramer581f48f2011-07-08 20:38:53 +00001818 MaxCFGBlocksPerFunction(0),
1819 NumUninitAnalysisFunctions(0),
1820 NumUninitAnalysisVariables(0),
1821 MaxUninitAnalysisVariablesPerFunction(0),
1822 NumUninitAnalysisBlockVisits(0),
1823 MaxUninitAnalysisBlockVisitsPerFunction(0) {
Ted Kremenekad8753c2014-03-15 05:47:06 +00001824
1825 using namespace diag;
David Blaikie9c902b52011-09-25 23:23:43 +00001826 DiagnosticsEngine &D = S.getDiagnostics();
Ted Kremenekad8753c2014-03-15 05:47:06 +00001827
1828 DefaultPolicy.enableCheckUnreachable =
1829 isEnabled(D, warn_unreachable) ||
1830 isEnabled(D, warn_unreachable_break) ||
Ted Kremenek14210372014-03-21 06:02:36 +00001831 isEnabled(D, warn_unreachable_return) ||
1832 isEnabled(D, warn_unreachable_loop_increment);
Ted Kremenekad8753c2014-03-15 05:47:06 +00001833
1834 DefaultPolicy.enableThreadSafetyAnalysis =
1835 isEnabled(D, warn_double_lock);
1836
1837 DefaultPolicy.enableConsumedAnalysis =
1838 isEnabled(D, warn_use_in_invalid_state);
Ted Kremenek918fe842010-03-20 21:06:02 +00001839}
1840
Aaron Ballmane5195222014-05-15 20:50:47 +00001841static void flushDiagnostics(Sema &S, const sema::FunctionScopeInfo *fscope) {
1842 for (const auto &D : fscope->PossiblyUnreachableDiags)
Ted Kremenek3427fac2011-02-23 01:52:04 +00001843 S.Diag(D.Loc, D.PD);
Ted Kremenek3427fac2011-02-23 01:52:04 +00001844}
1845
Ted Kremenek0b405322010-03-23 00:13:23 +00001846void clang::sema::
1847AnalysisBasedWarnings::IssueWarnings(sema::AnalysisBasedWarnings::Policy P,
Ted Kremenekcc7f1f82011-02-23 01:51:53 +00001848 sema::FunctionScopeInfo *fscope,
Ted Kremenek1767a272011-02-23 01:51:48 +00001849 const Decl *D, const BlockExpr *blkExpr) {
Ted Kremenekb45ebee2010-03-20 21:11:09 +00001850
Ted Kremenek918fe842010-03-20 21:06:02 +00001851 // We avoid doing analysis-based warnings when there are errors for
1852 // two reasons:
1853 // (1) The CFGs often can't be constructed (if the body is invalid), so
1854 // don't bother trying.
1855 // (2) The code already has problems; running the analysis just takes more
1856 // time.
David Blaikie9c902b52011-09-25 23:23:43 +00001857 DiagnosticsEngine &Diags = S.getDiagnostics();
Ted Kremenekb8021922010-04-30 21:49:25 +00001858
Ted Kremenek0b405322010-03-23 00:13:23 +00001859 // Do not do any analysis for declarations in system headers if we are
1860 // going to just ignore them.
Ted Kremenekb8021922010-04-30 21:49:25 +00001861 if (Diags.getSuppressSystemWarnings() &&
Ted Kremenek0b405322010-03-23 00:13:23 +00001862 S.SourceMgr.isInSystemHeader(D->getLocation()))
1863 return;
1864
John McCall1d570a72010-08-25 05:56:39 +00001865 // For code in dependent contexts, we'll do this at instantiation time.
David Blaikie0f2ae782012-01-24 04:51:48 +00001866 if (cast<DeclContext>(D)->isDependentContext())
1867 return;
Ted Kremenek918fe842010-03-20 21:06:02 +00001868
DeLesley Hutchins8ecd4912012-12-07 22:53:48 +00001869 if (Diags.hasUncompilableErrorOccurred() || Diags.hasFatalErrorOccurred()) {
Ted Kremenek3427fac2011-02-23 01:52:04 +00001870 // Flush out any possibly unreachable diagnostics.
1871 flushDiagnostics(S, fscope);
1872 return;
1873 }
1874
Ted Kremenek918fe842010-03-20 21:06:02 +00001875 const Stmt *Body = D->getBody();
1876 assert(Body);
1877
Ted Kremenekb3a38a92013-10-14 19:11:25 +00001878 // Construct the analysis context with the specified CFG build options.
Craig Topperc3ec1492014-05-26 06:22:03 +00001879 AnalysisDeclContext AC(/* AnalysisDeclContextManager */ nullptr, D);
Ted Kremenek189ecec2011-07-21 05:22:47 +00001880
Ted Kremenek918fe842010-03-20 21:06:02 +00001881 // Don't generate EH edges for CallExprs as we'd like to avoid the n^2
Benjamin Kramer60509af2013-09-09 14:48:42 +00001882 // explosion for destructors that can result and the compile time hit.
Ted Kremenek189ecec2011-07-21 05:22:47 +00001883 AC.getCFGBuildOptions().PruneTriviallyFalseEdges = true;
1884 AC.getCFGBuildOptions().AddEHEdges = false;
1885 AC.getCFGBuildOptions().AddInitializers = true;
1886 AC.getCFGBuildOptions().AddImplicitDtors = true;
Jordan Rose91f78402012-09-05 23:11:06 +00001887 AC.getCFGBuildOptions().AddTemporaryDtors = true;
Jordan Rosec9176072014-01-13 17:59:19 +00001888 AC.getCFGBuildOptions().AddCXXNewAllocator = false;
Jordan Rose91f78402012-09-05 23:11:06 +00001889
Ted Kremenek9e100ea2011-07-19 14:18:48 +00001890 // Force that certain expressions appear as CFGElements in the CFG. This
1891 // is used to speed up various analyses.
1892 // FIXME: This isn't the right factoring. This is here for initial
1893 // prototyping, but we need a way for analyses to say what expressions they
1894 // expect to always be CFGElements and then fill in the BuildOptions
1895 // appropriately. This is essentially a layering violation.
DeLesley Hutchins48a31762013-08-12 21:20:55 +00001896 if (P.enableCheckUnreachable || P.enableThreadSafetyAnalysis ||
1897 P.enableConsumedAnalysis) {
DeLesley Hutchinsf7faa6a2011-12-08 20:23:06 +00001898 // Unreachable code analysis and thread safety require a linearized CFG.
Ted Kremenekbd913712011-08-23 23:05:11 +00001899 AC.getCFGBuildOptions().setAllAlwaysAdd();
1900 }
1901 else {
1902 AC.getCFGBuildOptions()
1903 .setAlwaysAdd(Stmt::BinaryOperatorClass)
Richard Smithb21dd022012-07-17 01:27:33 +00001904 .setAlwaysAdd(Stmt::CompoundAssignOperatorClass)
Ted Kremenekbd913712011-08-23 23:05:11 +00001905 .setAlwaysAdd(Stmt::BlockExprClass)
1906 .setAlwaysAdd(Stmt::CStyleCastExprClass)
1907 .setAlwaysAdd(Stmt::DeclRefExprClass)
1908 .setAlwaysAdd(Stmt::ImplicitCastExprClass)
Richard Smith84837d52012-05-03 18:27:39 +00001909 .setAlwaysAdd(Stmt::UnaryOperatorClass)
1910 .setAlwaysAdd(Stmt::AttributedStmtClass);
Ted Kremenekbd913712011-08-23 23:05:11 +00001911 }
Ted Kremenek918fe842010-03-20 21:06:02 +00001912
Richard Trieue9fa2662014-04-15 00:57:50 +00001913 // Install the logical handler for -Wtautological-overlap-compare
1914 std::unique_ptr<LogicalErrorHandler> LEH;
Alp Tokerd4a3f0e2014-06-15 23:30:39 +00001915 if (!Diags.isIgnored(diag::warn_tautological_overlap_comparison,
1916 D->getLocStart())) {
Richard Trieue9fa2662014-04-15 00:57:50 +00001917 LEH.reset(new LogicalErrorHandler(S));
1918 AC.getCFGBuildOptions().Observer = LEH.get();
Richard Trieuf935b562014-04-05 05:17:01 +00001919 }
Ted Kremenekb3a38a92013-10-14 19:11:25 +00001920
Ted Kremenek3427fac2011-02-23 01:52:04 +00001921 // Emit delayed diagnostics.
David Blaikie0f2ae782012-01-24 04:51:48 +00001922 if (!fscope->PossiblyUnreachableDiags.empty()) {
Ted Kremenek3427fac2011-02-23 01:52:04 +00001923 bool analyzed = false;
Ted Kremeneka099c592011-03-10 03:50:34 +00001924
1925 // Register the expressions with the CFGBuilder.
Aaron Ballmane5195222014-05-15 20:50:47 +00001926 for (const auto &D : fscope->PossiblyUnreachableDiags) {
1927 if (D.stmt)
1928 AC.registerForcedBlockExpression(D.stmt);
Ted Kremeneka099c592011-03-10 03:50:34 +00001929 }
1930
1931 if (AC.getCFG()) {
1932 analyzed = true;
Aaron Ballmane5195222014-05-15 20:50:47 +00001933 for (const auto &D : fscope->PossiblyUnreachableDiags) {
Ted Kremeneka099c592011-03-10 03:50:34 +00001934 bool processed = false;
Aaron Ballmane5195222014-05-15 20:50:47 +00001935 if (D.stmt) {
1936 const CFGBlock *block = AC.getBlockForRegisteredExpression(D.stmt);
Eli Friedmane0afc982012-01-21 01:01:51 +00001937 CFGReverseBlockReachabilityAnalysis *cra =
1938 AC.getCFGReachablityAnalysis();
1939 // FIXME: We should be able to assert that block is non-null, but
1940 // the CFG analysis can skip potentially-evaluated expressions in
1941 // edge cases; see test/Sema/vla-2.c.
1942 if (block && cra) {
Ted Kremenek3427fac2011-02-23 01:52:04 +00001943 // Can this block be reached from the entrance?
Ted Kremeneka099c592011-03-10 03:50:34 +00001944 if (cra->isReachable(&AC.getCFG()->getEntry(), block))
Ted Kremenek3427fac2011-02-23 01:52:04 +00001945 S.Diag(D.Loc, D.PD);
Ted Kremeneka099c592011-03-10 03:50:34 +00001946 processed = true;
Ted Kremenek3427fac2011-02-23 01:52:04 +00001947 }
1948 }
Ted Kremeneka099c592011-03-10 03:50:34 +00001949 if (!processed) {
1950 // Emit the warning anyway if we cannot map to a basic block.
1951 S.Diag(D.Loc, D.PD);
1952 }
Ted Kremenek3427fac2011-02-23 01:52:04 +00001953 }
Ted Kremeneka099c592011-03-10 03:50:34 +00001954 }
Ted Kremenek3427fac2011-02-23 01:52:04 +00001955
1956 if (!analyzed)
1957 flushDiagnostics(S, fscope);
1958 }
1959
1960
Ted Kremenek918fe842010-03-20 21:06:02 +00001961 // Warning: check missing 'return'
David Blaikie0f2ae782012-01-24 04:51:48 +00001962 if (P.enableCheckFallThrough) {
Ted Kremenek918fe842010-03-20 21:06:02 +00001963 const CheckFallThroughDiagnostics &CD =
1964 (isa<BlockDecl>(D) ? CheckFallThroughDiagnostics::MakeForBlock()
Douglas Gregorcf11eb72012-02-15 16:20:15 +00001965 : (isa<CXXMethodDecl>(D) &&
1966 cast<CXXMethodDecl>(D)->getOverloadedOperator() == OO_Call &&
1967 cast<CXXMethodDecl>(D)->getParent()->isLambda())
1968 ? CheckFallThroughDiagnostics::MakeForLambda()
1969 : CheckFallThroughDiagnostics::MakeForFunction(D));
Ted Kremenek1767a272011-02-23 01:51:48 +00001970 CheckFallThroughForBody(S, D, Body, blkExpr, CD, AC);
Ted Kremenek918fe842010-03-20 21:06:02 +00001971 }
1972
1973 // Warning: check for unreachable code
Ted Kremenek7f770032011-11-30 21:22:09 +00001974 if (P.enableCheckUnreachable) {
1975 // Only check for unreachable code on non-template instantiations.
1976 // Different template instantiations can effectively change the control-flow
1977 // and it is very difficult to prove that a snippet of code in a template
1978 // is unreachable for all instantiations.
Ted Kremenek85825ae2011-12-01 00:59:17 +00001979 bool isTemplateInstantiation = false;
1980 if (const FunctionDecl *Function = dyn_cast<FunctionDecl>(D))
1981 isTemplateInstantiation = Function->isTemplateInstantiation();
1982 if (!isTemplateInstantiation)
Ted Kremenek7f770032011-11-30 21:22:09 +00001983 CheckUnreachable(S, AC);
1984 }
Caitlin Sadowski0b3501c2011-09-09 16:04:02 +00001985
Caitlin Sadowskiafbbd8e2011-08-23 18:46:34 +00001986 // Check for thread safety violations
David Blaikie0f2ae782012-01-24 04:51:48 +00001987 if (P.enableThreadSafetyAnalysis) {
DeLesley Hutchinsc2090512011-10-21 18:10:14 +00001988 SourceLocation FL = AC.getDecl()->getLocation();
Richard Smith92286672012-02-03 04:45:26 +00001989 SourceLocation FEL = AC.getDecl()->getLocEnd();
DeLesley Hutchinsea1f8332014-07-28 15:57:27 +00001990 threadSafety::ThreadSafetyReporter Reporter(S, FL, FEL);
Alp Tokerd4a3f0e2014-06-15 23:30:39 +00001991 if (!Diags.isIgnored(diag::warn_thread_safety_beta, D->getLocStart()))
DeLesley Hutchins8edae132012-12-05 00:06:15 +00001992 Reporter.setIssueBetaWarnings(true);
DeLesley Hutchinseb0ea5f2014-08-14 21:40:15 +00001993 if (!Diags.isIgnored(diag::warn_thread_safety_verbose, D->getLocStart()))
1994 Reporter.setVerbose(true);
DeLesley Hutchins8edae132012-12-05 00:06:15 +00001995
DeLesley Hutchinsab1dc2d2015-02-03 22:11:04 +00001996 threadSafety::runThreadSafetyAnalysis(AC, Reporter,
1997 &S.ThreadSafetyDeclCache);
Caitlin Sadowski0b3501c2011-09-09 16:04:02 +00001998 Reporter.emitDiagnostics();
1999 }
Caitlin Sadowskiafbbd8e2011-08-23 18:46:34 +00002000
DeLesley Hutchins48a31762013-08-12 21:20:55 +00002001 // Check for violations of consumed properties.
2002 if (P.enableConsumedAnalysis) {
2003 consumed::ConsumedWarningsHandler WarningHandler(S);
Reid Klecknere846dea2013-08-12 23:49:39 +00002004 consumed::ConsumedAnalyzer Analyzer(WarningHandler);
DeLesley Hutchins48a31762013-08-12 21:20:55 +00002005 Analyzer.run(AC);
2006 }
2007
Alp Tokerd4a3f0e2014-06-15 23:30:39 +00002008 if (!Diags.isIgnored(diag::warn_uninit_var, D->getLocStart()) ||
2009 !Diags.isIgnored(diag::warn_sometimes_uninit_var, D->getLocStart()) ||
2010 !Diags.isIgnored(diag::warn_maybe_uninit_var, D->getLocStart())) {
Ted Kremenek2551fbe2011-03-17 05:29:57 +00002011 if (CFG *cfg = AC.getCFG()) {
Ted Kremenekb63931e2011-01-18 21:18:58 +00002012 UninitValsDiagReporter reporter(S);
Fariborz Jahanian8809a9d2011-07-16 18:31:33 +00002013 UninitVariablesAnalysisStats stats;
Benjamin Kramere492cb42011-07-16 20:13:06 +00002014 std::memset(&stats, 0, sizeof(UninitVariablesAnalysisStats));
Ted Kremenekbcf848f2011-01-25 19:13:48 +00002015 runUninitializedVariablesAnalysis(*cast<DeclContext>(D), *cfg, AC,
Chandler Carruthb4836ea2011-07-06 16:21:37 +00002016 reporter, stats);
2017
2018 if (S.CollectStats && stats.NumVariablesAnalyzed > 0) {
2019 ++NumUninitAnalysisFunctions;
2020 NumUninitAnalysisVariables += stats.NumVariablesAnalyzed;
2021 NumUninitAnalysisBlockVisits += stats.NumBlockVisits;
2022 MaxUninitAnalysisVariablesPerFunction =
2023 std::max(MaxUninitAnalysisVariablesPerFunction,
2024 stats.NumVariablesAnalyzed);
2025 MaxUninitAnalysisBlockVisitsPerFunction =
2026 std::max(MaxUninitAnalysisBlockVisitsPerFunction,
2027 stats.NumBlockVisits);
2028 }
Ted Kremenekb749a6d2011-01-15 02:58:47 +00002029 }
2030 }
Chandler Carruthb4836ea2011-07-06 16:21:37 +00002031
Alexander Kornienko06caf7d2012-06-02 01:01:07 +00002032 bool FallThroughDiagFull =
Alp Tokerd4a3f0e2014-06-15 23:30:39 +00002033 !Diags.isIgnored(diag::warn_unannotated_fallthrough, D->getLocStart());
2034 bool FallThroughDiagPerFunction = !Diags.isIgnored(
2035 diag::warn_unannotated_fallthrough_per_function, D->getLocStart());
Alexis Hunt2178f142012-06-15 21:22:05 +00002036 if (FallThroughDiagFull || FallThroughDiagPerFunction) {
Alexander Kornienko06caf7d2012-06-02 01:01:07 +00002037 DiagnoseSwitchLabelsFallthrough(S, AC, !FallThroughDiagFull);
Richard Smith84837d52012-05-03 18:27:39 +00002038 }
2039
Jordan Rosed3934582012-09-28 22:21:30 +00002040 if (S.getLangOpts().ObjCARCWeak &&
Alp Tokerd4a3f0e2014-06-15 23:30:39 +00002041 !Diags.isIgnored(diag::warn_arc_repeated_use_of_weak, D->getLocStart()))
Jordan Rose76831c62012-10-11 16:10:19 +00002042 diagnoseRepeatedUseOfWeak(S, fscope, D, AC.getParentMap());
Jordan Rosed3934582012-09-28 22:21:30 +00002043
Richard Trieu2f024f42013-12-21 02:33:43 +00002044
2045 // Check for infinite self-recursion in functions
Alp Tokerd4a3f0e2014-06-15 23:30:39 +00002046 if (!Diags.isIgnored(diag::warn_infinite_recursive_function,
2047 D->getLocStart())) {
Richard Trieu2f024f42013-12-21 02:33:43 +00002048 if (const FunctionDecl *FD = dyn_cast<FunctionDecl>(D)) {
2049 checkRecursiveFunction(S, FD, Body, AC);
2050 }
2051 }
2052
Richard Trieue9fa2662014-04-15 00:57:50 +00002053 // If none of the previous checks caused a CFG build, trigger one here
2054 // for -Wtautological-overlap-compare
Alp Tokerd4a3f0e2014-06-15 23:30:39 +00002055 if (!Diags.isIgnored(diag::warn_tautological_overlap_comparison,
Richard Trieue9fa2662014-04-15 00:57:50 +00002056 D->getLocStart())) {
2057 AC.getCFG();
2058 }
2059
Chandler Carruthb4836ea2011-07-06 16:21:37 +00002060 // Collect statistics about the CFG if it was built.
2061 if (S.CollectStats && AC.isCFGBuilt()) {
2062 ++NumFunctionsAnalyzed;
2063 if (CFG *cfg = AC.getCFG()) {
2064 // If we successfully built a CFG for this context, record some more
2065 // detail information about it.
Chandler Carruth50020d92011-07-06 22:21:45 +00002066 NumCFGBlocks += cfg->getNumBlockIDs();
Chandler Carruthb4836ea2011-07-06 16:21:37 +00002067 MaxCFGBlocksPerFunction = std::max(MaxCFGBlocksPerFunction,
Chandler Carruth50020d92011-07-06 22:21:45 +00002068 cfg->getNumBlockIDs());
Chandler Carruthb4836ea2011-07-06 16:21:37 +00002069 } else {
2070 ++NumFunctionsWithBadCFGs;
2071 }
2072 }
2073}
2074
2075void clang::sema::AnalysisBasedWarnings::PrintStats() const {
2076 llvm::errs() << "\n*** Analysis Based Warnings Stats:\n";
2077
2078 unsigned NumCFGsBuilt = NumFunctionsAnalyzed - NumFunctionsWithBadCFGs;
2079 unsigned AvgCFGBlocksPerFunction =
2080 !NumCFGsBuilt ? 0 : NumCFGBlocks/NumCFGsBuilt;
2081 llvm::errs() << NumFunctionsAnalyzed << " functions analyzed ("
2082 << NumFunctionsWithBadCFGs << " w/o CFGs).\n"
2083 << " " << NumCFGBlocks << " CFG blocks built.\n"
2084 << " " << AvgCFGBlocksPerFunction
2085 << " average CFG blocks per function.\n"
2086 << " " << MaxCFGBlocksPerFunction
2087 << " max CFG blocks per function.\n";
2088
2089 unsigned AvgUninitVariablesPerFunction = !NumUninitAnalysisFunctions ? 0
2090 : NumUninitAnalysisVariables/NumUninitAnalysisFunctions;
2091 unsigned AvgUninitBlockVisitsPerFunction = !NumUninitAnalysisFunctions ? 0
2092 : NumUninitAnalysisBlockVisits/NumUninitAnalysisFunctions;
2093 llvm::errs() << NumUninitAnalysisFunctions
2094 << " functions analyzed for uninitialiazed variables\n"
2095 << " " << NumUninitAnalysisVariables << " variables analyzed.\n"
2096 << " " << AvgUninitVariablesPerFunction
2097 << " average variables per function.\n"
2098 << " " << MaxUninitAnalysisVariablesPerFunction
2099 << " max variables per function.\n"
2100 << " " << NumUninitAnalysisBlockVisits << " block visits.\n"
2101 << " " << AvgUninitBlockVisitsPerFunction
2102 << " average block visits per function.\n"
2103 << " " << MaxUninitAnalysisBlockVisitsPerFunction
2104 << " max block visits per function.\n";
Ted Kremenek918fe842010-03-20 21:06:02 +00002105}