blob: fbd8a9d4d872c472a9a14676db1bb6ca7390bb18 [file] [log] [blame]
Zhongxing Xu88cca6b2009-11-12 08:38:56 +00001//=== MallocChecker.cpp - A malloc/free checker -------------------*- C++ -*--//
2//
3// The LLVM Compiler Infrastructure
4//
5// This file is distributed under the University of Illinois Open Source
6// License. See LICENSE.TXT for details.
7//
8//===----------------------------------------------------------------------===//
9//
10// This file defines malloc/free checker, which checks for potential memory
11// leaks, double free, and use-after-free problems.
12//
13//===----------------------------------------------------------------------===//
14
Argyrios Kyrtzidis183f0fb2011-02-28 01:26:35 +000015#include "ClangSACheckers.h"
Anna Zakse56167e2012-02-17 22:35:31 +000016#include "InterCheckerAPI.h"
Chandler Carruth3a022472012-12-04 09:13:33 +000017#include "clang/AST/Attr.h"
Anton Yartsev4e4cb6b2014-08-05 18:26:05 +000018#include "clang/AST/ParentMap.h"
Chandler Carruth3a022472012-12-04 09:13:33 +000019#include "clang/Basic/SourceManager.h"
Jordan Rose6b33c6f2014-03-26 17:05:46 +000020#include "clang/Basic/TargetInfo.h"
Chandler Carruth3a022472012-12-04 09:13:33 +000021#include "clang/StaticAnalyzer/Core/BugReporter/BugType.h"
Artem Dergachevb6a513d2017-05-03 11:47:13 +000022#include "clang/StaticAnalyzer/Core/BugReporter/CommonBugCategories.h"
Argyrios Kyrtzidis6a5674f2011-03-01 01:16:21 +000023#include "clang/StaticAnalyzer/Core/Checker.h"
Argyrios Kyrtzidis183f0fb2011-02-28 01:26:35 +000024#include "clang/StaticAnalyzer/Core/CheckerManager.h"
Jordan Rose4f7df9b2012-07-26 21:39:41 +000025#include "clang/StaticAnalyzer/Core/PathSensitive/CallEvent.h"
Chandler Carruth3a022472012-12-04 09:13:33 +000026#include "clang/StaticAnalyzer/Core/PathSensitive/CheckerContext.h"
Ted Kremenek001fd5b2011-08-15 22:09:50 +000027#include "clang/StaticAnalyzer/Core/PathSensitive/ProgramState.h"
28#include "clang/StaticAnalyzer/Core/PathSensitive/ProgramStateTrait.h"
Ted Kremenekf8cbac42011-02-10 01:03:03 +000029#include "clang/StaticAnalyzer/Core/PathSensitive/SymbolManager.h"
Benjamin Kramer3307c5082012-02-04 12:31:12 +000030#include "llvm/ADT/STLExtras.h"
Benjamin Kramerea70eb32012-12-01 15:09:41 +000031#include "llvm/ADT/SmallString.h"
Jordan Rosec102b352012-09-22 01:24:42 +000032#include "llvm/ADT/StringExtras.h"
Reka Kovacs18775fc2018-06-09 13:03:49 +000033#include "AllocationState.h"
Anna Zaks199e8e52012-02-22 03:14:20 +000034#include <climits>
Benjamin Kramercfeacf52016-05-27 14:27:13 +000035#include <utility>
Anna Zaks199e8e52012-02-22 03:14:20 +000036
Zhongxing Xu88cca6b2009-11-12 08:38:56 +000037using namespace clang;
Ted Kremenek98857c92010-12-23 07:20:52 +000038using namespace ento;
Zhongxing Xu88cca6b2009-11-12 08:38:56 +000039
40namespace {
41
Anton Yartsev05789592013-03-28 17:05:19 +000042// Used to check correspondence between allocators and deallocators.
43enum AllocationFamily {
44 AF_None,
45 AF_Malloc,
46 AF_CXXNew,
Anna Zaksd79b8402014-10-03 21:48:59 +000047 AF_CXXNewArray,
Anton Yartsev5b5c7ce2015-02-19 13:36:20 +000048 AF_IfNameIndex,
Reka Kovacs18775fc2018-06-09 13:03:49 +000049 AF_Alloca,
Reka Kovacs88ad7042018-07-20 15:14:49 +000050 AF_InnerBuffer
Anton Yartsev05789592013-03-28 17:05:19 +000051};
52
Zhongxing Xu1239de12009-12-11 00:55:44 +000053class RefState {
Anna Zaks9050ffd2012-06-20 20:57:46 +000054 enum Kind { // Reference to allocated memory.
55 Allocated,
Anton Yartsevb50f4ba2015-04-14 14:18:04 +000056 // Reference to zero-allocated memory.
57 AllocatedOfSizeZero,
Anna Zaks9050ffd2012-06-20 20:57:46 +000058 // Reference to released/freed memory.
59 Released,
Alp Toker5faf0c02013-12-02 03:50:25 +000060 // The responsibility for freeing resources has transferred from
Anna Zaks9050ffd2012-06-20 20:57:46 +000061 // this reference. A relinquished symbol should not be freed.
Anna Zaks93a21a82013-04-09 00:30:28 +000062 Relinquished,
63 // We are no longer guaranteed to have observed all manipulations
64 // of this pointer/memory. For example, it could have been
65 // passed as a parameter to an opaque function.
66 Escaped
67 };
Anton Yartsev05789592013-03-28 17:05:19 +000068
Zhongxing Xu4668c7e2009-11-17 07:54:15 +000069 const Stmt *S;
Anton Yartsevb50f4ba2015-04-14 14:18:04 +000070 unsigned K : 3; // Kind enum, but stored as a bitfield.
Ted Kremenek3a0678e2015-09-08 03:50:52 +000071 unsigned Family : 29; // Rest of 32-bit word, currently just an allocation
Anton Yartsev05789592013-03-28 17:05:19 +000072 // family.
Zhongxing Xu4668c7e2009-11-17 07:54:15 +000073
Ted Kremenek3a0678e2015-09-08 03:50:52 +000074 RefState(Kind k, const Stmt *s, unsigned family)
Anna Zaks93a21a82013-04-09 00:30:28 +000075 : S(s), K(k), Family(family) {
76 assert(family != AF_None);
77 }
Zhongxing Xu1239de12009-12-11 00:55:44 +000078public:
Anna Zaks9050ffd2012-06-20 20:57:46 +000079 bool isAllocated() const { return K == Allocated; }
Anton Yartsevb50f4ba2015-04-14 14:18:04 +000080 bool isAllocatedOfSizeZero() const { return K == AllocatedOfSizeZero; }
Zhongxing Xu4668c7e2009-11-17 07:54:15 +000081 bool isReleased() const { return K == Released; }
Anna Zaks9050ffd2012-06-20 20:57:46 +000082 bool isRelinquished() const { return K == Relinquished; }
Anna Zaks93a21a82013-04-09 00:30:28 +000083 bool isEscaped() const { return K == Escaped; }
84 AllocationFamily getAllocationFamily() const {
Anton Yartsev05789592013-03-28 17:05:19 +000085 return (AllocationFamily)Family;
86 }
Anna Zaksd56c8792012-02-13 18:05:39 +000087 const Stmt *getStmt() const { return S; }
Zhongxing Xu4668c7e2009-11-17 07:54:15 +000088
89 bool operator==(const RefState &X) const {
Anton Yartsev05789592013-03-28 17:05:19 +000090 return K == X.K && S == X.S && Family == X.Family;
Zhongxing Xu4668c7e2009-11-17 07:54:15 +000091 }
92
Anton Yartsev05789592013-03-28 17:05:19 +000093 static RefState getAllocated(unsigned family, const Stmt *s) {
94 return RefState(Allocated, s, family);
Zhongxing Xub0e15df2009-12-31 06:13:07 +000095 }
Anton Yartsevb50f4ba2015-04-14 14:18:04 +000096 static RefState getAllocatedOfSizeZero(const RefState *RS) {
97 return RefState(AllocatedOfSizeZero, RS->getStmt(),
98 RS->getAllocationFamily());
99 }
Ted Kremenek3a0678e2015-09-08 03:50:52 +0000100 static RefState getReleased(unsigned family, const Stmt *s) {
Anton Yartsev05789592013-03-28 17:05:19 +0000101 return RefState(Released, s, family);
102 }
103 static RefState getRelinquished(unsigned family, const Stmt *s) {
104 return RefState(Relinquished, s, family);
Ted Kremenek0bbf24d2010-08-06 21:12:55 +0000105 }
Anna Zaks93a21a82013-04-09 00:30:28 +0000106 static RefState getEscaped(const RefState *RS) {
107 return RefState(Escaped, RS->getStmt(), RS->getAllocationFamily());
108 }
Zhongxing Xu4668c7e2009-11-17 07:54:15 +0000109
110 void Profile(llvm::FoldingSetNodeID &ID) const {
111 ID.AddInteger(K);
112 ID.AddPointer(S);
Anton Yartsev05789592013-03-28 17:05:19 +0000113 ID.AddInteger(Family);
Zhongxing Xu4668c7e2009-11-17 07:54:15 +0000114 }
Ted Kremenek6fcefb52013-01-03 01:30:12 +0000115
Dmitri Gribenkof8579502013-01-12 19:30:44 +0000116 void dump(raw_ostream &OS) const {
Jordan Rose6adadb92014-01-23 03:59:01 +0000117 switch (static_cast<Kind>(K)) {
118#define CASE(ID) case ID: OS << #ID; break;
119 CASE(Allocated)
Anton Yartsevb50f4ba2015-04-14 14:18:04 +0000120 CASE(AllocatedOfSizeZero)
Jordan Rose6adadb92014-01-23 03:59:01 +0000121 CASE(Released)
122 CASE(Relinquished)
123 CASE(Escaped)
124 }
Ted Kremenek6fcefb52013-01-03 01:30:12 +0000125 }
126
Alp Tokeref6b0072014-01-04 13:47:14 +0000127 LLVM_DUMP_METHOD void dump() const { dump(llvm::errs()); }
Zhongxing Xu88cca6b2009-11-12 08:38:56 +0000128};
129
Anna Zaks75cfbb62012-09-12 22:57:34 +0000130enum ReallocPairKind {
131 RPToBeFreedAfterFailure,
132 // The symbol has been freed when reallocation failed.
133 RPIsFreeOnFailure,
134 // The symbol does not need to be freed after reallocation fails.
135 RPDoNotTrackAfterFailure
136};
137
Anna Zaksfe6eb672012-08-24 02:28:20 +0000138/// \class ReallocPair
Adrian Prantl9fc8faf2018-05-09 01:00:01 +0000139/// Stores information about the symbol being reallocated by a call to
Anna Zaksfe6eb672012-08-24 02:28:20 +0000140/// 'realloc' to allow modeling failed reallocation later in the path.
Anna Zaksac068142012-02-15 00:11:25 +0000141struct ReallocPair {
Adrian Prantl9fc8faf2018-05-09 01:00:01 +0000142 // The symbol which realloc reallocated.
Anna Zaksac068142012-02-15 00:11:25 +0000143 SymbolRef ReallocatedSym;
Anna Zaks75cfbb62012-09-12 22:57:34 +0000144 ReallocPairKind Kind;
Anna Zaksfe6eb672012-08-24 02:28:20 +0000145
Anna Zaks75cfbb62012-09-12 22:57:34 +0000146 ReallocPair(SymbolRef S, ReallocPairKind K) :
147 ReallocatedSym(S), Kind(K) {}
Anna Zaksac068142012-02-15 00:11:25 +0000148 void Profile(llvm::FoldingSetNodeID &ID) const {
Anna Zaks75cfbb62012-09-12 22:57:34 +0000149 ID.AddInteger(Kind);
Anna Zaksac068142012-02-15 00:11:25 +0000150 ID.AddPointer(ReallocatedSym);
151 }
152 bool operator==(const ReallocPair &X) const {
153 return ReallocatedSym == X.ReallocatedSym &&
Anna Zaks75cfbb62012-09-12 22:57:34 +0000154 Kind == X.Kind;
Anna Zaksac068142012-02-15 00:11:25 +0000155 }
156};
157
Anna Zaksa043d0c2013-01-08 00:25:29 +0000158typedef std::pair<const ExplodedNode*, const MemRegion*> LeakInfo;
Anna Zaksfc2e1532012-03-21 19:45:08 +0000159
Anna Zaksc68bf4c2012-02-08 20:13:28 +0000160class MallocChecker : public Checker<check::DeadSymbols,
Anna Zaksdc154152012-12-20 00:38:25 +0000161 check::PointerEscape,
Anna Zaks333481b2013-03-28 23:15:29 +0000162 check::ConstPointerEscape,
Ted Kremenek778d2bb2012-01-04 23:48:37 +0000163 check::PreStmt<ReturnStmt>,
Reka Kovacs122171e2018-08-02 23:02:08 +0000164 check::EndFunction,
Anton Yartsevcb2ccd62013-04-10 22:21:41 +0000165 check::PreCall,
Anna Zaksc68bf4c2012-02-08 20:13:28 +0000166 check::PostStmt<CallExpr>,
Anton Yartsev13df0362013-03-25 01:35:45 +0000167 check::PostStmt<CXXNewExpr>,
Artem Dergachev13b20262018-01-17 23:46:13 +0000168 check::NewAllocator,
Anton Yartsev13df0362013-03-25 01:35:45 +0000169 check::PreStmt<CXXDeleteExpr>,
Anna Zaks9fe80982012-03-22 00:57:20 +0000170 check::PostStmt<BlockExpr>,
Anna Zaks67291b92012-11-13 03:18:01 +0000171 check::PostObjCMessage,
Ted Kremenek778d2bb2012-01-04 23:48:37 +0000172 check::Location,
Anna Zaksdc154152012-12-20 00:38:25 +0000173 eval::Assume>
Ted Kremenek778d2bb2012-01-04 23:48:37 +0000174{
Zhongxing Xu88cca6b2009-11-12 08:38:56 +0000175public:
Craig Topper0dbb7832014-05-27 02:45:47 +0000176 MallocChecker()
Anna Zaks30d46682016-03-08 01:21:51 +0000177 : II_alloca(nullptr), II_win_alloca(nullptr), II_malloc(nullptr),
178 II_free(nullptr), II_realloc(nullptr), II_calloc(nullptr),
179 II_valloc(nullptr), II_reallocf(nullptr), II_strndup(nullptr),
180 II_strdup(nullptr), II_win_strdup(nullptr), II_kmalloc(nullptr),
181 II_if_nameindex(nullptr), II_if_freenameindex(nullptr),
Anna Zaksbbec97c2017-03-09 00:01:01 +0000182 II_wcsdup(nullptr), II_win_wcsdup(nullptr), II_g_malloc(nullptr),
Fangrui Song6907ce22018-07-30 19:24:48 +0000183 II_g_malloc0(nullptr), II_g_realloc(nullptr), II_g_try_malloc(nullptr),
184 II_g_try_malloc0(nullptr), II_g_try_realloc(nullptr),
185 II_g_free(nullptr), II_g_memdup(nullptr), II_g_malloc_n(nullptr),
186 II_g_malloc0_n(nullptr), II_g_realloc_n(nullptr),
187 II_g_try_malloc_n(nullptr), II_g_try_malloc0_n(nullptr),
Leslie Zhaie3986c52017-04-26 05:33:14 +0000188 II_g_try_realloc_n(nullptr) {}
Anna Zakscd37bf42012-02-08 23:16:52 +0000189
190 /// In pessimistic mode, the checker assumes that it does not know which
191 /// functions might free the memory.
Alexander Kornienko4aca9b12014-02-11 21:49:21 +0000192 enum CheckKind {
Gabor Horvathe40c71c2015-03-04 17:59:34 +0000193 CK_MallocChecker,
Alexander Kornienko4aca9b12014-02-11 21:49:21 +0000194 CK_NewDeleteChecker,
195 CK_NewDeleteLeaksChecker,
196 CK_MismatchedDeallocatorChecker,
Reka Kovacsd9f66ba2018-08-06 22:03:42 +0000197 CK_InnerPointerChecker,
Alexander Kornienko4aca9b12014-02-11 21:49:21 +0000198 CK_NumCheckKinds
Anna Zakscd37bf42012-02-08 23:16:52 +0000199 };
200
Ted Kremenek3a0678e2015-09-08 03:50:52 +0000201 enum class MemoryOperationKind {
Anna Zaksd79b8402014-10-03 21:48:59 +0000202 MOK_Allocate,
203 MOK_Free,
204 MOK_Any
205 };
206
Gabor Horvathe40c71c2015-03-04 17:59:34 +0000207 DefaultBool IsOptimistic;
208
Alexander Kornienko4aca9b12014-02-11 21:49:21 +0000209 DefaultBool ChecksEnabled[CK_NumCheckKinds];
210 CheckName CheckNames[CK_NumCheckKinds];
Anna Zakscd37bf42012-02-08 23:16:52 +0000211
Anton Yartsevcb2ccd62013-04-10 22:21:41 +0000212 void checkPreCall(const CallEvent &Call, CheckerContext &C) const;
Anna Zaksc68bf4c2012-02-08 20:13:28 +0000213 void checkPostStmt(const CallExpr *CE, CheckerContext &C) const;
Anton Yartsev13df0362013-03-25 01:35:45 +0000214 void checkPostStmt(const CXXNewExpr *NE, CheckerContext &C) const;
Artem Dergachev13b20262018-01-17 23:46:13 +0000215 void checkNewAllocator(const CXXNewExpr *NE, SVal Target,
216 CheckerContext &C) const;
Anton Yartsev13df0362013-03-25 01:35:45 +0000217 void checkPreStmt(const CXXDeleteExpr *DE, CheckerContext &C) const;
Anna Zaks67291b92012-11-13 03:18:01 +0000218 void checkPostObjCMessage(const ObjCMethodCall &Call, CheckerContext &C) const;
Anna Zaks9fe80982012-03-22 00:57:20 +0000219 void checkPostStmt(const BlockExpr *BE, CheckerContext &C) const;
Argyrios Kyrtzidis183f0fb2011-02-28 01:26:35 +0000220 void checkDeadSymbols(SymbolReaper &SymReaper, CheckerContext &C) const;
Argyrios Kyrtzidis183f0fb2011-02-28 01:26:35 +0000221 void checkPreStmt(const ReturnStmt *S, CheckerContext &C) const;
Reka Kovacs122171e2018-08-02 23:02:08 +0000222 void checkEndFunction(const ReturnStmt *S, CheckerContext &C) const;
Ted Kremenek49b1e382012-01-26 21:29:00 +0000223 ProgramStateRef evalAssume(ProgramStateRef state, SVal Cond,
Argyrios Kyrtzidis183f0fb2011-02-28 01:26:35 +0000224 bool Assumption) const;
Anna Zaks3e0f4152011-10-06 00:43:15 +0000225 void checkLocation(SVal l, bool isLoad, const Stmt *S,
226 CheckerContext &C) const;
Anna Zaksdc154152012-12-20 00:38:25 +0000227
228 ProgramStateRef checkPointerEscape(ProgramStateRef State,
229 const InvalidatedSymbols &Escaped,
Anna Zaksacdc13c2013-02-07 23:05:43 +0000230 const CallEvent *Call,
231 PointerEscapeKind Kind) const;
Anna Zaks333481b2013-03-28 23:15:29 +0000232 ProgramStateRef checkConstPointerEscape(ProgramStateRef State,
233 const InvalidatedSymbols &Escaped,
234 const CallEvent *Call,
235 PointerEscapeKind Kind) const;
Zhongxing Xub0e15df2009-12-31 06:13:07 +0000236
Anna Zaks263b7e02012-05-02 00:05:20 +0000237 void printState(raw_ostream &Out, ProgramStateRef State,
Craig Topperfb6b25b2014-03-15 04:29:04 +0000238 const char *NL, const char *Sep) const override;
Anna Zaks263b7e02012-05-02 00:05:20 +0000239
Zhongxing Xuc4902a52009-11-13 07:25:27 +0000240private:
Ahmed Charlesb8984322014-03-07 20:03:18 +0000241 mutable std::unique_ptr<BugType> BT_DoubleFree[CK_NumCheckKinds];
242 mutable std::unique_ptr<BugType> BT_DoubleDelete;
243 mutable std::unique_ptr<BugType> BT_Leak[CK_NumCheckKinds];
244 mutable std::unique_ptr<BugType> BT_UseFree[CK_NumCheckKinds];
245 mutable std::unique_ptr<BugType> BT_BadFree[CK_NumCheckKinds];
Anton Yartsev5b5c7ce2015-02-19 13:36:20 +0000246 mutable std::unique_ptr<BugType> BT_FreeAlloca[CK_NumCheckKinds];
Ahmed Charlesb8984322014-03-07 20:03:18 +0000247 mutable std::unique_ptr<BugType> BT_MismatchedDealloc;
248 mutable std::unique_ptr<BugType> BT_OffsetFree[CK_NumCheckKinds];
Anton Yartsevb50f4ba2015-04-14 14:18:04 +0000249 mutable std::unique_ptr<BugType> BT_UseZerroAllocated[CK_NumCheckKinds];
Anna Zaks30d46682016-03-08 01:21:51 +0000250 mutable IdentifierInfo *II_alloca, *II_win_alloca, *II_malloc, *II_free,
251 *II_realloc, *II_calloc, *II_valloc, *II_reallocf,
252 *II_strndup, *II_strdup, *II_win_strdup, *II_kmalloc,
253 *II_if_nameindex, *II_if_freenameindex, *II_wcsdup,
Fangrui Song6907ce22018-07-30 19:24:48 +0000254 *II_win_wcsdup, *II_g_malloc, *II_g_malloc0,
255 *II_g_realloc, *II_g_try_malloc, *II_g_try_malloc0,
256 *II_g_try_realloc, *II_g_free, *II_g_memdup,
257 *II_g_malloc_n, *II_g_malloc0_n, *II_g_realloc_n,
258 *II_g_try_malloc_n, *II_g_try_malloc0_n,
Leslie Zhaie3986c52017-04-26 05:33:14 +0000259 *II_g_try_realloc_n;
Jordan Rose6b33c6f2014-03-26 17:05:46 +0000260 mutable Optional<uint64_t> KernelZeroFlagVal;
Alexander Kornienko4aca9b12014-02-11 21:49:21 +0000261
Anna Zaks3d348342012-02-14 21:55:24 +0000262 void initIdentifierInfo(ASTContext &C) const;
263
Adrian Prantl9fc8faf2018-05-09 01:00:01 +0000264 /// Determine family of a deallocation expression.
Anton Yartseve3377fb2013-04-04 23:46:29 +0000265 AllocationFamily getAllocationFamily(CheckerContext &C, const Stmt *S) const;
Anton Yartsev05789592013-03-28 17:05:19 +0000266
Adrian Prantl9fc8faf2018-05-09 01:00:01 +0000267 /// Print names of allocators and deallocators.
Anton Yartsev05789592013-03-28 17:05:19 +0000268 ///
269 /// \returns true on success.
Ted Kremenek3a0678e2015-09-08 03:50:52 +0000270 bool printAllocDeallocName(raw_ostream &os, CheckerContext &C,
Anton Yartsev05789592013-03-28 17:05:19 +0000271 const Expr *E) const;
272
Adrian Prantl9fc8faf2018-05-09 01:00:01 +0000273 /// Print expected name of an allocator based on the deallocator's
Anton Yartsev05789592013-03-28 17:05:19 +0000274 /// family derived from the DeallocExpr.
Ted Kremenek3a0678e2015-09-08 03:50:52 +0000275 void printExpectedAllocName(raw_ostream &os, CheckerContext &C,
Anton Yartsev05789592013-03-28 17:05:19 +0000276 const Expr *DeallocExpr) const;
Adrian Prantl9fc8faf2018-05-09 01:00:01 +0000277 /// Print expected name of a deallocator based on the allocator's
Anton Yartsev05789592013-03-28 17:05:19 +0000278 /// family.
279 void printExpectedDeallocName(raw_ostream &os, AllocationFamily Family) const;
280
Jordan Rose613f3c02013-03-09 00:59:10 +0000281 ///@{
Ted Kremenek3a0678e2015-09-08 03:50:52 +0000282 /// Check if this is one of the functions which can allocate/reallocate memory
Anna Zaks3d348342012-02-14 21:55:24 +0000283 /// pointed to by one of its arguments.
284 bool isMemFunction(const FunctionDecl *FD, ASTContext &C) const;
Anna Zaksd79b8402014-10-03 21:48:59 +0000285 bool isCMemFunction(const FunctionDecl *FD,
286 ASTContext &C,
287 AllocationFamily Family,
Benjamin Kramer719772c2014-10-03 22:20:30 +0000288 MemoryOperationKind MemKind) const;
Anton Yartsev13df0362013-03-25 01:35:45 +0000289 bool isStandardNewDelete(const FunctionDecl *FD, ASTContext &C) const;
Jordan Rose613f3c02013-03-09 00:59:10 +0000290 ///@}
Anton Yartsevb50f4ba2015-04-14 14:18:04 +0000291
Adrian Prantl9fc8faf2018-05-09 01:00:01 +0000292 /// Process C++ operator new()'s allocation, which is the part of C++
Artem Dergachev13b20262018-01-17 23:46:13 +0000293 /// new-expression that goes before the constructor.
294 void processNewAllocation(const CXXNewExpr *NE, CheckerContext &C,
295 SVal Target) const;
296
Adrian Prantl9fc8faf2018-05-09 01:00:01 +0000297 /// Perform a zero-allocation check.
Artem Dergachev13b20262018-01-17 23:46:13 +0000298 /// The optional \p RetVal parameter specifies the newly allocated pointer
299 /// value; if unspecified, the value of expression \p E is used.
Anton Yartsevb50f4ba2015-04-14 14:18:04 +0000300 ProgramStateRef ProcessZeroAllocation(CheckerContext &C, const Expr *E,
301 const unsigned AllocationSizeArg,
Artem Dergachev13b20262018-01-17 23:46:13 +0000302 ProgramStateRef State,
303 Optional<SVal> RetVal = None) const;
Anton Yartsevb50f4ba2015-04-14 14:18:04 +0000304
Richard Smith852e9ce2013-11-27 01:46:48 +0000305 ProgramStateRef MallocMemReturnsAttr(CheckerContext &C,
306 const CallExpr *CE,
Anton Yartsevb3fa86d2015-02-10 20:13:08 +0000307 const OwnershipAttr* Att,
308 ProgramStateRef State) const;
Ted Kremenek49b1e382012-01-26 21:29:00 +0000309 static ProgramStateRef MallocMemAux(CheckerContext &C, const CallExpr *CE,
Anton Yartsevb3fa86d2015-02-10 20:13:08 +0000310 const Expr *SizeEx, SVal Init,
311 ProgramStateRef State,
312 AllocationFamily Family = AF_Malloc);
Ted Kremenek49b1e382012-01-26 21:29:00 +0000313 static ProgramStateRef MallocMemAux(CheckerContext &C, const CallExpr *CE,
Anton Yartsevb3fa86d2015-02-10 20:13:08 +0000314 SVal SizeEx, SVal Init,
315 ProgramStateRef State,
316 AllocationFamily Family = AF_Malloc);
Zhongxing Xu527ff6d2010-06-01 03:01:33 +0000317
Gabor Horvath73040272016-09-19 20:39:52 +0000318 static ProgramStateRef addExtentSize(CheckerContext &C, const CXXNewExpr *NE,
Artem Dergachev13b20262018-01-17 23:46:13 +0000319 ProgramStateRef State, SVal Target);
Gabor Horvath73040272016-09-19 20:39:52 +0000320
Jordan Rose6b33c6f2014-03-26 17:05:46 +0000321 // Check if this malloc() for special flags. At present that means M_ZERO or
322 // __GFP_ZERO (in which case, treat it like calloc).
323 llvm::Optional<ProgramStateRef>
324 performKernelMalloc(const CallExpr *CE, CheckerContext &C,
325 const ProgramStateRef &State) const;
326
Anna Zaks40a7eb32012-02-22 19:24:52 +0000327 /// Update the RefState to reflect the new memory allocation.
Artem Dergachev13b20262018-01-17 23:46:13 +0000328 /// The optional \p RetVal parameter specifies the newly allocated pointer
329 /// value; if unspecified, the value of expression \p E is used.
Ted Kremenek3a0678e2015-09-08 03:50:52 +0000330 static ProgramStateRef
Anton Yartsev05789592013-03-28 17:05:19 +0000331 MallocUpdateRefState(CheckerContext &C, const Expr *E, ProgramStateRef State,
Artem Dergachev13b20262018-01-17 23:46:13 +0000332 AllocationFamily Family = AF_Malloc,
333 Optional<SVal> RetVal = None);
Anna Zaks40a7eb32012-02-22 19:24:52 +0000334
335 ProgramStateRef FreeMemAttr(CheckerContext &C, const CallExpr *CE,
Anton Yartsevb3fa86d2015-02-10 20:13:08 +0000336 const OwnershipAttr* Att,
337 ProgramStateRef State) const;
Ted Kremenek49b1e382012-01-26 21:29:00 +0000338 ProgramStateRef FreeMemAux(CheckerContext &C, const CallExpr *CE,
Anna Zaks0d6989b2012-06-22 02:04:31 +0000339 ProgramStateRef state, unsigned Num,
Anna Zaksfe6eb672012-08-24 02:28:20 +0000340 bool Hold,
Anna Zaks67291b92012-11-13 03:18:01 +0000341 bool &ReleasedAllocated,
342 bool ReturnsNullOnFailure = false) const;
Anna Zaks0d6989b2012-06-22 02:04:31 +0000343 ProgramStateRef FreeMemAux(CheckerContext &C, const Expr *Arg,
344 const Expr *ParentExpr,
Anna Zaks67291b92012-11-13 03:18:01 +0000345 ProgramStateRef State,
Anna Zaksfe6eb672012-08-24 02:28:20 +0000346 bool Hold,
Anna Zaks67291b92012-11-13 03:18:01 +0000347 bool &ReleasedAllocated,
348 bool ReturnsNullOnFailure = false) const;
Zhongxing Xuc0484fa2009-12-12 12:29:38 +0000349
Leslie Zhaie3986c52017-04-26 05:33:14 +0000350 ProgramStateRef ReallocMemAux(CheckerContext &C, const CallExpr *CE,
351 bool FreesMemOnFailure,
Fangrui Song6907ce22018-07-30 19:24:48 +0000352 ProgramStateRef State,
Leslie Zhaie3986c52017-04-26 05:33:14 +0000353 bool SuffixWithN = false) const;
354 static SVal evalMulForBufferSize(CheckerContext &C, const Expr *Blocks,
355 const Expr *BlockBytes);
Anton Yartsevb3fa86d2015-02-10 20:13:08 +0000356 static ProgramStateRef CallocMem(CheckerContext &C, const CallExpr *CE,
357 ProgramStateRef State);
Ted Kremenek3a0678e2015-09-08 03:50:52 +0000358
Reka Kovacs122171e2018-08-02 23:02:08 +0000359 /// Check if the memory associated with this symbol was released.
Anna Zaks46d01602012-05-18 01:16:10 +0000360 bool isReleased(SymbolRef Sym, CheckerContext &C) const;
361
Anton Yartsev13df0362013-03-25 01:35:45 +0000362 bool checkUseAfterFree(SymbolRef Sym, CheckerContext &C, const Stmt *S) const;
Anna Zaksa1b227b2012-02-08 23:16:56 +0000363
Ted Kremenek3a0678e2015-09-08 03:50:52 +0000364 void checkUseZeroAllocated(SymbolRef Sym, CheckerContext &C,
Anton Yartsevb50f4ba2015-04-14 14:18:04 +0000365 const Stmt *S) const;
366
Jordan Rose656fdd52014-01-08 18:46:55 +0000367 bool checkDoubleDelete(SymbolRef Sym, CheckerContext &C) const;
368
Anna Zaksa4bc5e12013-05-31 23:47:32 +0000369 /// Check if the function is known free memory, or if it is
Jordan Rose613f3c02013-03-09 00:59:10 +0000370 /// "interesting" and should be modeled explicitly.
371 ///
Ted Kremenek3a0678e2015-09-08 03:50:52 +0000372 /// \param [out] EscapingSymbol A function might not free memory in general,
Anna Zaks8ebeb642013-06-08 00:29:29 +0000373 /// but could be known to free a particular symbol. In this case, false is
Anna Zaksa4bc5e12013-05-31 23:47:32 +0000374 /// returned and the single escaping symbol is returned through the out
375 /// parameter.
376 ///
Jordan Rose613f3c02013-03-09 00:59:10 +0000377 /// We assume that pointers do not escape through calls to system functions
378 /// not handled by this checker.
Anna Zaks8ebeb642013-06-08 00:29:29 +0000379 bool mayFreeAnyEscapedMemoryOrIsModeledExplicitly(const CallEvent *Call,
Anna Zaksa4bc5e12013-05-31 23:47:32 +0000380 ProgramStateRef State,
381 SymbolRef &EscapingSymbol) const;
Anna Zaks3d348342012-02-14 21:55:24 +0000382
Reka Kovacs122171e2018-08-02 23:02:08 +0000383 // Implementation of the checkPointerEscape callbacks.
Anna Zaks333481b2013-03-28 23:15:29 +0000384 ProgramStateRef checkPointerEscapeAux(ProgramStateRef State,
385 const InvalidatedSymbols &Escaped,
386 const CallEvent *Call,
387 PointerEscapeKind Kind,
388 bool(*CheckRefState)(const RefState*)) const;
389
Reka Kovacs122171e2018-08-02 23:02:08 +0000390 // Implementation of the checkPreStmt and checkEndFunction callbacks.
391 void checkEscapeOnReturn(const ReturnStmt *S, CheckerContext &C) const;
392
Anton Yartsev1e2bc9b2013-04-11 00:05:20 +0000393 ///@{
394 /// Tells if a given family/call/symbol is tracked by the current checker.
Anton Yartsev4eb394d2015-03-07 00:31:53 +0000395 /// Sets CheckKind to the kind of the checker responsible for this
396 /// family/call/symbol.
Anton Yartsev2487dd62015-03-10 22:24:21 +0000397 Optional<CheckKind> getCheckIfTracked(AllocationFamily Family,
398 bool IsALeakCheck = false) const;
Anton Yartsev4eb394d2015-03-07 00:31:53 +0000399 Optional<CheckKind> getCheckIfTracked(CheckerContext &C,
Anton Yartsev2487dd62015-03-10 22:24:21 +0000400 const Stmt *AllocDeallocStmt,
401 bool IsALeakCheck = false) const;
Ted Kremenek3a0678e2015-09-08 03:50:52 +0000402 Optional<CheckKind> getCheckIfTracked(CheckerContext &C, SymbolRef Sym,
Anton Yartsev2487dd62015-03-10 22:24:21 +0000403 bool IsALeakCheck = false) const;
Anton Yartsev1e2bc9b2013-04-11 00:05:20 +0000404 ///@}
Ted Kremenek5ef32db2011-08-12 23:37:29 +0000405 static bool SummarizeValue(raw_ostream &os, SVal V);
406 static bool SummarizeRegion(raw_ostream &os, const MemRegion *MR);
Ted Kremenek3a0678e2015-09-08 03:50:52 +0000407 void ReportBadFree(CheckerContext &C, SVal ArgVal, SourceRange Range,
Anton Yartsev05789592013-03-28 17:05:19 +0000408 const Expr *DeallocExpr) const;
Anton Yartsev5b5c7ce2015-02-19 13:36:20 +0000409 void ReportFreeAlloca(CheckerContext &C, SVal ArgVal,
410 SourceRange Range) const;
Anton Yartseve3377fb2013-04-04 23:46:29 +0000411 void ReportMismatchedDealloc(CheckerContext &C, SourceRange Range,
Anton Yartsevf0593d62013-04-05 11:25:10 +0000412 const Expr *DeallocExpr, const RefState *RS,
Anton Yartsevf5bccce2013-09-16 17:51:25 +0000413 SymbolRef Sym, bool OwnershipTransferred) const;
Ted Kremenek3a0678e2015-09-08 03:50:52 +0000414 void ReportOffsetFree(CheckerContext &C, SVal ArgVal, SourceRange Range,
415 const Expr *DeallocExpr,
Craig Topper0dbb7832014-05-27 02:45:47 +0000416 const Expr *AllocExpr = nullptr) const;
Anton Yartsev59ed15b2013-03-13 14:39:10 +0000417 void ReportUseAfterFree(CheckerContext &C, SourceRange Range,
418 SymbolRef Sym) const;
419 void ReportDoubleFree(CheckerContext &C, SourceRange Range, bool Released,
Anton Yartsev6c2af432013-03-13 17:07:32 +0000420 SymbolRef Sym, SymbolRef PrevSym) const;
Anna Zaks2b5bb972012-02-09 06:25:51 +0000421
Jordan Rose656fdd52014-01-08 18:46:55 +0000422 void ReportDoubleDelete(CheckerContext &C, SymbolRef Sym) const;
423
Anton Yartsevb50f4ba2015-04-14 14:18:04 +0000424 void ReportUseZeroAllocated(CheckerContext &C, SourceRange Range,
425 SymbolRef Sym) const;
426
Daniel Marjamakia43a8f52017-05-02 11:46:12 +0000427 void ReportFunctionPointerFree(CheckerContext &C, SVal ArgVal,
428 SourceRange Range, const Expr *FreeExpr) const;
429
Anna Zaksdf901a42012-02-23 21:38:21 +0000430 /// Find the location of the allocation for Sym on the path leading to the
431 /// exploded node N.
Anna Zaksfc2e1532012-03-21 19:45:08 +0000432 LeakInfo getAllocationSite(const ExplodedNode *N, SymbolRef Sym,
433 CheckerContext &C) const;
Anna Zaksdf901a42012-02-23 21:38:21 +0000434
Anna Zaksd3571e5a2012-02-11 21:02:40 +0000435 void reportLeak(SymbolRef Sym, ExplodedNode *N, CheckerContext &C) const;
436
Anna Zaks2b5bb972012-02-09 06:25:51 +0000437 /// The bug visitor which allows us to print extra diagnostics along the
438 /// BugReport path. For example, showing the allocation site of the leaked
439 /// region.
George Karpenkov70ec1dd2018-06-26 21:12:08 +0000440 class MallocBugVisitor final : public BugReporterVisitor {
Anna Zaks2b5bb972012-02-09 06:25:51 +0000441 protected:
Anna Zaks9eb7bc82012-02-16 22:26:07 +0000442 enum NotificationMode {
443 Normal,
Anna Zaks9eb7bc82012-02-16 22:26:07 +0000444 ReallocationFailed
445 };
446
Anna Zaks2b5bb972012-02-09 06:25:51 +0000447 // The allocated region symbol tracked by the main analysis.
448 SymbolRef Sym;
449
Anna Zaks62cce9e2012-05-10 01:37:40 +0000450 // The mode we are in, i.e. what kind of diagnostics will be emitted.
451 NotificationMode Mode;
Jordy Rose21ff76e2012-03-24 03:15:09 +0000452
Anna Zaks62cce9e2012-05-10 01:37:40 +0000453 // A symbol from when the primary region should have been reallocated.
454 SymbolRef FailedReallocSymbol;
Jordy Rose21ff76e2012-03-24 03:15:09 +0000455
Artem Dergachev5337efc2018-02-27 21:19:33 +0000456 // A C++ destructor stack frame in which memory was released. Used for
457 // miscellaneous false positive suppression.
458 const StackFrameContext *ReleaseDestructorLC;
459
Anna Zaks62cce9e2012-05-10 01:37:40 +0000460 bool IsLeak;
461
462 public:
463 MallocBugVisitor(SymbolRef S, bool isLeak = false)
Artem Dergachev5337efc2018-02-27 21:19:33 +0000464 : Sym(S), Mode(Normal), FailedReallocSymbol(nullptr),
465 ReleaseDestructorLC(nullptr), IsLeak(isLeak) {}
466
467 static void *getTag() {
468 static int Tag = 0;
469 return &Tag;
470 }
Jordy Rose21ff76e2012-03-24 03:15:09 +0000471
Craig Topperfb6b25b2014-03-15 04:29:04 +0000472 void Profile(llvm::FoldingSetNodeID &ID) const override {
Artem Dergachev5337efc2018-02-27 21:19:33 +0000473 ID.AddPointer(getTag());
Anna Zaks2b5bb972012-02-09 06:25:51 +0000474 ID.AddPointer(Sym);
475 }
476
Anna Zaks9eb7bc82012-02-16 22:26:07 +0000477 inline bool isAllocated(const RefState *S, const RefState *SPrev,
478 const Stmt *Stmt) {
Anna Zaks2b5bb972012-02-09 06:25:51 +0000479 // Did not track -> allocated. Other state (released) -> allocated.
Anton Yartsev13df0362013-03-25 01:35:45 +0000480 return (Stmt && (isa<CallExpr>(Stmt) || isa<CXXNewExpr>(Stmt)) &&
Ted Kremenek3a0678e2015-09-08 03:50:52 +0000481 (S && (S->isAllocated() || S->isAllocatedOfSizeZero())) &&
482 (!SPrev || !(SPrev->isAllocated() ||
Anton Yartsevb50f4ba2015-04-14 14:18:04 +0000483 SPrev->isAllocatedOfSizeZero())));
Anna Zaks2b5bb972012-02-09 06:25:51 +0000484 }
485
Anna Zaks9eb7bc82012-02-16 22:26:07 +0000486 inline bool isReleased(const RefState *S, const RefState *SPrev,
487 const Stmt *Stmt) {
Anna Zaks2b5bb972012-02-09 06:25:51 +0000488 // Did not track -> released. Other state (allocated) -> released.
Reka Kovacs8707cd12018-07-07 17:22:45 +0000489 // The statement associated with the release might be missing.
490 bool IsReleased = (S && S->isReleased()) &&
491 (!SPrev || !SPrev->isReleased());
492 assert(!IsReleased ||
493 (Stmt && (isa<CallExpr>(Stmt) || isa<CXXDeleteExpr>(Stmt))) ||
Reka Kovacs88ad7042018-07-20 15:14:49 +0000494 (!Stmt && S->getAllocationFamily() == AF_InnerBuffer));
Reka Kovacs8707cd12018-07-07 17:22:45 +0000495 return IsReleased;
Anna Zaks9eb7bc82012-02-16 22:26:07 +0000496 }
497
Anna Zaks0d6989b2012-06-22 02:04:31 +0000498 inline bool isRelinquished(const RefState *S, const RefState *SPrev,
499 const Stmt *Stmt) {
500 // Did not track -> relinquished. Other state (allocated) -> relinquished.
501 return (Stmt && (isa<CallExpr>(Stmt) || isa<ObjCMessageExpr>(Stmt) ||
502 isa<ObjCPropertyRefExpr>(Stmt)) &&
503 (S && S->isRelinquished()) &&
504 (!SPrev || !SPrev->isRelinquished()));
505 }
506
Anna Zaks9eb7bc82012-02-16 22:26:07 +0000507 inline bool isReallocFailedCheck(const RefState *S, const RefState *SPrev,
508 const Stmt *Stmt) {
509 // If the expression is not a call, and the state change is
510 // released -> allocated, it must be the realloc return value
511 // check. If we have to handle more cases here, it might be cleaner just
512 // to track this extra bit in the state itself.
513 return ((!Stmt || !isa<CallExpr>(Stmt)) &&
Anton Yartsevb50f4ba2015-04-14 14:18:04 +0000514 (S && (S->isAllocated() || S->isAllocatedOfSizeZero())) &&
515 (SPrev && !(SPrev->isAllocated() ||
516 SPrev->isAllocatedOfSizeZero())));
Anna Zaks2b5bb972012-02-09 06:25:51 +0000517 }
518
David Blaikie0a0c2752017-01-05 17:26:53 +0000519 std::shared_ptr<PathDiagnosticPiece> VisitNode(const ExplodedNode *N,
David Blaikie0a0c2752017-01-05 17:26:53 +0000520 BugReporterContext &BRC,
521 BugReport &BR) override;
Anna Zaks62cce9e2012-05-10 01:37:40 +0000522
George Karpenkov70ec1dd2018-06-26 21:12:08 +0000523 std::shared_ptr<PathDiagnosticPiece>
David Blaikied15481c2014-08-29 18:18:43 +0000524 getEndPath(BugReporterContext &BRC, const ExplodedNode *EndPathNode,
525 BugReport &BR) override {
Anna Zaks62cce9e2012-05-10 01:37:40 +0000526 if (!IsLeak)
Craig Topper0dbb7832014-05-27 02:45:47 +0000527 return nullptr;
Anna Zaks62cce9e2012-05-10 01:37:40 +0000528
529 PathDiagnosticLocation L =
530 PathDiagnosticLocation::createEndOfPath(EndPathNode,
531 BRC.getSourceManager());
532 // Do not add the statement itself as a range in case of leak.
George Karpenkov70ec1dd2018-06-26 21:12:08 +0000533 return std::make_shared<PathDiagnosticEventPiece>(L, BR.getDescription(),
David Blaikied15481c2014-08-29 18:18:43 +0000534 false);
Anna Zaks62cce9e2012-05-10 01:37:40 +0000535 }
536
Anna Zakscba4f292012-03-16 23:24:20 +0000537 private:
538 class StackHintGeneratorForReallocationFailed
539 : public StackHintGeneratorForSymbol {
540 public:
541 StackHintGeneratorForReallocationFailed(SymbolRef S, StringRef M)
542 : StackHintGeneratorForSymbol(S, M) {}
543
Craig Topperfb6b25b2014-03-15 04:29:04 +0000544 std::string getMessageForArg(const Expr *ArgE,
545 unsigned ArgIndex) override {
Jordan Rosec102b352012-09-22 01:24:42 +0000546 // Printed parameters start at 1, not 0.
547 ++ArgIndex;
548
Anna Zakscba4f292012-03-16 23:24:20 +0000549 SmallString<200> buf;
550 llvm::raw_svector_ostream os(buf);
551
Jordan Rosec102b352012-09-22 01:24:42 +0000552 os << "Reallocation of " << ArgIndex << llvm::getOrdinalSuffix(ArgIndex)
553 << " parameter failed";
Anna Zakscba4f292012-03-16 23:24:20 +0000554
555 return os.str();
556 }
557
Craig Topperfb6b25b2014-03-15 04:29:04 +0000558 std::string getMessageForReturn(const CallExpr *CallExpr) override {
Anna Zaksa7f457a2012-03-16 23:44:28 +0000559 return "Reallocation of returned value failed";
Anna Zakscba4f292012-03-16 23:24:20 +0000560 }
561 };
Anna Zaks2b5bb972012-02-09 06:25:51 +0000562 };
Zhongxing Xu88cca6b2009-11-12 08:38:56 +0000563};
Kovarththanan Rajaratnam65c65662009-11-28 06:07:30 +0000564} // end anonymous namespace
Zhongxing Xu88cca6b2009-11-12 08:38:56 +0000565
Jordan Rose0c153cb2012-11-02 01:54:06 +0000566REGISTER_MAP_WITH_PROGRAMSTATE(RegionState, SymbolRef, RefState)
567REGISTER_MAP_WITH_PROGRAMSTATE(ReallocPairs, SymbolRef, ReallocPair)
Devin Coughlin81771732015-09-22 22:47:14 +0000568REGISTER_SET_WITH_PROGRAMSTATE(ReallocSizeZeroSymbols, SymbolRef)
Zhongxing Xu88cca6b2009-11-12 08:38:56 +0000569
Ted Kremenek3a0678e2015-09-08 03:50:52 +0000570// A map from the freed symbol to the symbol representing the return value of
Anna Zaks67291b92012-11-13 03:18:01 +0000571// the free function.
572REGISTER_MAP_WITH_PROGRAMSTATE(FreeReturnValue, SymbolRef, SymbolRef)
573
Anna Zaksbb1ef902012-02-11 21:02:35 +0000574namespace {
David Blaikie903c2932015-08-13 22:50:09 +0000575class StopTrackingCallback final : public SymbolVisitor {
Anna Zaksbb1ef902012-02-11 21:02:35 +0000576 ProgramStateRef state;
577public:
Benjamin Kramercfeacf52016-05-27 14:27:13 +0000578 StopTrackingCallback(ProgramStateRef st) : state(std::move(st)) {}
Anna Zaksbb1ef902012-02-11 21:02:35 +0000579 ProgramStateRef getState() const { return state; }
580
Craig Topperfb6b25b2014-03-15 04:29:04 +0000581 bool VisitSymbol(SymbolRef sym) override {
Anna Zaksbb1ef902012-02-11 21:02:35 +0000582 state = state->remove<RegionState>(sym);
583 return true;
584 }
585};
586} // end anonymous namespace
587
Anna Zaks3d348342012-02-14 21:55:24 +0000588void MallocChecker::initIdentifierInfo(ASTContext &Ctx) const {
Anna Zaksb3436602012-05-18 22:47:40 +0000589 if (II_malloc)
590 return;
Anton Yartsev5b5c7ce2015-02-19 13:36:20 +0000591 II_alloca = &Ctx.Idents.get("alloca");
Anna Zaksb3436602012-05-18 22:47:40 +0000592 II_malloc = &Ctx.Idents.get("malloc");
593 II_free = &Ctx.Idents.get("free");
594 II_realloc = &Ctx.Idents.get("realloc");
595 II_reallocf = &Ctx.Idents.get("reallocf");
596 II_calloc = &Ctx.Idents.get("calloc");
597 II_valloc = &Ctx.Idents.get("valloc");
598 II_strdup = &Ctx.Idents.get("strdup");
599 II_strndup = &Ctx.Idents.get("strndup");
Anna Zaks30d46682016-03-08 01:21:51 +0000600 II_wcsdup = &Ctx.Idents.get("wcsdup");
Jordan Rose6b33c6f2014-03-26 17:05:46 +0000601 II_kmalloc = &Ctx.Idents.get("kmalloc");
Anna Zaksd79b8402014-10-03 21:48:59 +0000602 II_if_nameindex = &Ctx.Idents.get("if_nameindex");
603 II_if_freenameindex = &Ctx.Idents.get("if_freenameindex");
Anna Zaks30d46682016-03-08 01:21:51 +0000604
605 //MSVC uses `_`-prefixed instead, so we check for them too.
606 II_win_strdup = &Ctx.Idents.get("_strdup");
607 II_win_wcsdup = &Ctx.Idents.get("_wcsdup");
608 II_win_alloca = &Ctx.Idents.get("_alloca");
Anna Zaksbbec97c2017-03-09 00:01:01 +0000609
610 // Glib
611 II_g_malloc = &Ctx.Idents.get("g_malloc");
612 II_g_malloc0 = &Ctx.Idents.get("g_malloc0");
613 II_g_realloc = &Ctx.Idents.get("g_realloc");
614 II_g_try_malloc = &Ctx.Idents.get("g_try_malloc");
615 II_g_try_malloc0 = &Ctx.Idents.get("g_try_malloc0");
616 II_g_try_realloc = &Ctx.Idents.get("g_try_realloc");
617 II_g_free = &Ctx.Idents.get("g_free");
618 II_g_memdup = &Ctx.Idents.get("g_memdup");
Leslie Zhaie3986c52017-04-26 05:33:14 +0000619 II_g_malloc_n = &Ctx.Idents.get("g_malloc_n");
620 II_g_malloc0_n = &Ctx.Idents.get("g_malloc0_n");
621 II_g_realloc_n = &Ctx.Idents.get("g_realloc_n");
622 II_g_try_malloc_n = &Ctx.Idents.get("g_try_malloc_n");
623 II_g_try_malloc0_n = &Ctx.Idents.get("g_try_malloc0_n");
624 II_g_try_realloc_n = &Ctx.Idents.get("g_try_realloc_n");
Anna Zaksc68bf4c2012-02-08 20:13:28 +0000625}
626
Anna Zaks3d348342012-02-14 21:55:24 +0000627bool MallocChecker::isMemFunction(const FunctionDecl *FD, ASTContext &C) const {
Anna Zaksd79b8402014-10-03 21:48:59 +0000628 if (isCMemFunction(FD, C, AF_Malloc, MemoryOperationKind::MOK_Any))
Anna Zaks46d01602012-05-18 01:16:10 +0000629 return true;
630
Anna Zaksd79b8402014-10-03 21:48:59 +0000631 if (isCMemFunction(FD, C, AF_IfNameIndex, MemoryOperationKind::MOK_Any))
Anna Zaks46d01602012-05-18 01:16:10 +0000632 return true;
633
Anton Yartsev5b5c7ce2015-02-19 13:36:20 +0000634 if (isCMemFunction(FD, C, AF_Alloca, MemoryOperationKind::MOK_Any))
635 return true;
636
Anton Yartsev13df0362013-03-25 01:35:45 +0000637 if (isStandardNewDelete(FD, C))
638 return true;
639
Anna Zaks46d01602012-05-18 01:16:10 +0000640 return false;
641}
642
Anna Zaksd79b8402014-10-03 21:48:59 +0000643bool MallocChecker::isCMemFunction(const FunctionDecl *FD,
644 ASTContext &C,
645 AllocationFamily Family,
Benjamin Kramer719772c2014-10-03 22:20:30 +0000646 MemoryOperationKind MemKind) const {
Anna Zaksd1ff1cb2012-02-15 02:12:00 +0000647 if (!FD)
648 return false;
Anna Zaks46d01602012-05-18 01:16:10 +0000649
Anna Zaksd79b8402014-10-03 21:48:59 +0000650 bool CheckFree = (MemKind == MemoryOperationKind::MOK_Any ||
651 MemKind == MemoryOperationKind::MOK_Free);
652 bool CheckAlloc = (MemKind == MemoryOperationKind::MOK_Any ||
653 MemKind == MemoryOperationKind::MOK_Allocate);
654
Jordan Rose6cd16c52012-07-10 23:13:01 +0000655 if (FD->getKind() == Decl::Function) {
Anna Zaksd79b8402014-10-03 21:48:59 +0000656 const IdentifierInfo *FunI = FD->getIdentifier();
Jordan Rose6cd16c52012-07-10 23:13:01 +0000657 initIdentifierInfo(C);
Anna Zaks3d348342012-02-14 21:55:24 +0000658
Anna Zaksd79b8402014-10-03 21:48:59 +0000659 if (Family == AF_Malloc && CheckFree) {
Fangrui Song6907ce22018-07-30 19:24:48 +0000660 if (FunI == II_free || FunI == II_realloc || FunI == II_reallocf ||
Anna Zaksbbec97c2017-03-09 00:01:01 +0000661 FunI == II_g_free)
Anna Zaksd79b8402014-10-03 21:48:59 +0000662 return true;
663 }
664
665 if (Family == AF_Malloc && CheckAlloc) {
666 if (FunI == II_malloc || FunI == II_realloc || FunI == II_reallocf ||
667 FunI == II_calloc || FunI == II_valloc || FunI == II_strdup ||
Anna Zaks30d46682016-03-08 01:21:51 +0000668 FunI == II_win_strdup || FunI == II_strndup || FunI == II_wcsdup ||
Anna Zaksbbec97c2017-03-09 00:01:01 +0000669 FunI == II_win_wcsdup || FunI == II_kmalloc ||
Fangrui Song6907ce22018-07-30 19:24:48 +0000670 FunI == II_g_malloc || FunI == II_g_malloc0 ||
671 FunI == II_g_realloc || FunI == II_g_try_malloc ||
Anna Zaksbbec97c2017-03-09 00:01:01 +0000672 FunI == II_g_try_malloc0 || FunI == II_g_try_realloc ||
Fangrui Song6907ce22018-07-30 19:24:48 +0000673 FunI == II_g_memdup || FunI == II_g_malloc_n ||
674 FunI == II_g_malloc0_n || FunI == II_g_realloc_n ||
675 FunI == II_g_try_malloc_n || FunI == II_g_try_malloc0_n ||
Leslie Zhaie3986c52017-04-26 05:33:14 +0000676 FunI == II_g_try_realloc_n)
Anna Zaksd79b8402014-10-03 21:48:59 +0000677 return true;
678 }
679
680 if (Family == AF_IfNameIndex && CheckFree) {
681 if (FunI == II_if_freenameindex)
682 return true;
683 }
684
685 if (Family == AF_IfNameIndex && CheckAlloc) {
686 if (FunI == II_if_nameindex)
687 return true;
688 }
Anton Yartsev5b5c7ce2015-02-19 13:36:20 +0000689
690 if (Family == AF_Alloca && CheckAlloc) {
Anna Zaks30d46682016-03-08 01:21:51 +0000691 if (FunI == II_alloca || FunI == II_win_alloca)
Anton Yartsev5b5c7ce2015-02-19 13:36:20 +0000692 return true;
693 }
Jordan Rose6cd16c52012-07-10 23:13:01 +0000694 }
Anna Zaks3d348342012-02-14 21:55:24 +0000695
Anna Zaksd79b8402014-10-03 21:48:59 +0000696 if (Family != AF_Malloc)
Anna Zaks46d01602012-05-18 01:16:10 +0000697 return false;
698
Gabor Horvathe40c71c2015-03-04 17:59:34 +0000699 if (IsOptimistic && FD->hasAttrs()) {
Anna Zaksd79b8402014-10-03 21:48:59 +0000700 for (const auto *I : FD->specific_attrs<OwnershipAttr>()) {
701 OwnershipAttr::OwnershipKind OwnKind = I->getOwnKind();
702 if(OwnKind == OwnershipAttr::Takes || OwnKind == OwnershipAttr::Holds) {
703 if (CheckFree)
704 return true;
705 } else if (OwnKind == OwnershipAttr::Returns) {
706 if (CheckAlloc)
707 return true;
708 }
709 }
Jordan Rose6cd16c52012-07-10 23:13:01 +0000710 }
Anna Zaks3d348342012-02-14 21:55:24 +0000711
Anna Zaks3d348342012-02-14 21:55:24 +0000712 return false;
713}
714
Artem Dergachev32c0c852018-11-01 00:43:35 +0000715// Tells if the callee is one of the builtin new/delete operators, including
716// placement operators and other standard overloads.
Anton Yartsev13df0362013-03-25 01:35:45 +0000717bool MallocChecker::isStandardNewDelete(const FunctionDecl *FD,
718 ASTContext &C) const {
719 if (!FD)
720 return false;
721
722 OverloadedOperatorKind Kind = FD->getOverloadedOperator();
Ted Kremenek3a0678e2015-09-08 03:50:52 +0000723 if (Kind != OO_New && Kind != OO_Array_New &&
Anton Yartsev13df0362013-03-25 01:35:45 +0000724 Kind != OO_Delete && Kind != OO_Array_Delete)
725 return false;
726
Artem Dergachev32c0c852018-11-01 00:43:35 +0000727 // This is standard if and only if it's not defined in a user file.
728 SourceLocation L = FD->getLocation();
729 // If the header for operator delete is not included, it's still defined
730 // in an invalid source location. Check to make sure we don't crash.
731 return !L.isValid() || C.getSourceManager().isInSystemHeader(L);
Anton Yartsev13df0362013-03-25 01:35:45 +0000732}
733
Jordan Rose6b33c6f2014-03-26 17:05:46 +0000734llvm::Optional<ProgramStateRef> MallocChecker::performKernelMalloc(
735 const CallExpr *CE, CheckerContext &C, const ProgramStateRef &State) const {
736 // 3-argument malloc(), as commonly used in {Free,Net,Open}BSD Kernels:
737 //
738 // void *malloc(unsigned long size, struct malloc_type *mtp, int flags);
739 //
740 // One of the possible flags is M_ZERO, which means 'give me back an
741 // allocation which is already zeroed', like calloc.
742
743 // 2-argument kmalloc(), as used in the Linux kernel:
744 //
745 // void *kmalloc(size_t size, gfp_t flags);
746 //
747 // Has the similar flag value __GFP_ZERO.
748
749 // This logic is largely cloned from O_CREAT in UnixAPIChecker, maybe some
750 // code could be shared.
751
752 ASTContext &Ctx = C.getASTContext();
753 llvm::Triple::OSType OS = Ctx.getTargetInfo().getTriple().getOS();
754
755 if (!KernelZeroFlagVal.hasValue()) {
756 if (OS == llvm::Triple::FreeBSD)
757 KernelZeroFlagVal = 0x0100;
758 else if (OS == llvm::Triple::NetBSD)
759 KernelZeroFlagVal = 0x0002;
760 else if (OS == llvm::Triple::OpenBSD)
761 KernelZeroFlagVal = 0x0008;
762 else if (OS == llvm::Triple::Linux)
763 // __GFP_ZERO
764 KernelZeroFlagVal = 0x8000;
765 else
766 // FIXME: We need a more general way of getting the M_ZERO value.
767 // See also: O_CREAT in UnixAPIChecker.cpp.
768
769 // Fall back to normal malloc behavior on platforms where we don't
770 // know M_ZERO.
771 return None;
772 }
773
774 // We treat the last argument as the flags argument, and callers fall-back to
775 // normal malloc on a None return. This works for the FreeBSD kernel malloc
776 // as well as Linux kmalloc.
777 if (CE->getNumArgs() < 2)
778 return None;
779
780 const Expr *FlagsEx = CE->getArg(CE->getNumArgs() - 1);
George Karpenkovd703ec92018-01-17 20:27:29 +0000781 const SVal V = C.getSVal(FlagsEx);
Jordan Rose6b33c6f2014-03-26 17:05:46 +0000782 if (!V.getAs<NonLoc>()) {
783 // The case where 'V' can be a location can only be due to a bad header,
784 // so in this case bail out.
785 return None;
786 }
787
788 NonLoc Flags = V.castAs<NonLoc>();
789 NonLoc ZeroFlag = C.getSValBuilder()
790 .makeIntVal(KernelZeroFlagVal.getValue(), FlagsEx->getType())
791 .castAs<NonLoc>();
792 SVal MaskedFlagsUC = C.getSValBuilder().evalBinOpNN(State, BO_And,
793 Flags, ZeroFlag,
794 FlagsEx->getType());
795 if (MaskedFlagsUC.isUnknownOrUndef())
796 return None;
797 DefinedSVal MaskedFlags = MaskedFlagsUC.castAs<DefinedSVal>();
798
799 // Check if maskedFlags is non-zero.
800 ProgramStateRef TrueState, FalseState;
801 std::tie(TrueState, FalseState) = State->assume(MaskedFlags);
802
803 // If M_ZERO is set, treat this like calloc (initialized).
804 if (TrueState && !FalseState) {
805 SVal ZeroVal = C.getSValBuilder().makeZeroVal(Ctx.CharTy);
806 return MallocMemAux(C, CE, CE->getArg(0), ZeroVal, TrueState);
807 }
808
809 return None;
810}
811
Leslie Zhaie3986c52017-04-26 05:33:14 +0000812SVal MallocChecker::evalMulForBufferSize(CheckerContext &C, const Expr *Blocks,
813 const Expr *BlockBytes) {
814 SValBuilder &SB = C.getSValBuilder();
815 SVal BlocksVal = C.getSVal(Blocks);
816 SVal BlockBytesVal = C.getSVal(BlockBytes);
817 ProgramStateRef State = C.getState();
818 SVal TotalSize = SB.evalBinOp(State, BO_Mul, BlocksVal, BlockBytesVal,
819 SB.getContext().getSizeType());
820 return TotalSize;
821}
822
Anna Zaksc68bf4c2012-02-08 20:13:28 +0000823void MallocChecker::checkPostStmt(const CallExpr *CE, CheckerContext &C) const {
Jordan Rosed6e5fd52012-09-20 01:55:32 +0000824 if (C.wasInlined)
825 return;
Jordan Rose6b33c6f2014-03-26 17:05:46 +0000826
Anna Zaksc68bf4c2012-02-08 20:13:28 +0000827 const FunctionDecl *FD = C.getCalleeDecl(CE);
828 if (!FD)
829 return;
Zhongxing Xu88cca6b2009-11-12 08:38:56 +0000830
Anna Zaks40a7eb32012-02-22 19:24:52 +0000831 ProgramStateRef State = C.getState();
Anna Zaksfe6eb672012-08-24 02:28:20 +0000832 bool ReleasedAllocatedMemory = false;
Jordan Rose6cd16c52012-07-10 23:13:01 +0000833
834 if (FD->getKind() == Decl::Function) {
835 initIdentifierInfo(C.getASTContext());
836 IdentifierInfo *FunI = FD->getIdentifier();
837
Anna Zaksbbec97c2017-03-09 00:01:01 +0000838 if (FunI == II_malloc || FunI == II_g_malloc || FunI == II_g_try_malloc) {
Jordan Rose6b33c6f2014-03-26 17:05:46 +0000839 if (CE->getNumArgs() < 1)
840 return;
841 if (CE->getNumArgs() < 3) {
842 State = MallocMemAux(C, CE, CE->getArg(0), UndefinedVal(), State);
Anton Yartsevb50f4ba2015-04-14 14:18:04 +0000843 if (CE->getNumArgs() == 1)
844 State = ProcessZeroAllocation(C, CE, 0, State);
Jordan Rose6b33c6f2014-03-26 17:05:46 +0000845 } else if (CE->getNumArgs() == 3) {
846 llvm::Optional<ProgramStateRef> MaybeState =
847 performKernelMalloc(CE, C, State);
848 if (MaybeState.hasValue())
849 State = MaybeState.getValue();
850 else
851 State = MallocMemAux(C, CE, CE->getArg(0), UndefinedVal(), State);
852 }
853 } else if (FunI == II_kmalloc) {
Devin Coughlin684d19d2016-10-16 22:19:03 +0000854 if (CE->getNumArgs() < 1)
855 return;
Jordan Rose6b33c6f2014-03-26 17:05:46 +0000856 llvm::Optional<ProgramStateRef> MaybeState =
857 performKernelMalloc(CE, C, State);
858 if (MaybeState.hasValue())
859 State = MaybeState.getValue();
860 else
861 State = MallocMemAux(C, CE, CE->getArg(0), UndefinedVal(), State);
862 } else if (FunI == II_valloc) {
Anton Yartseve3377fb2013-04-04 23:46:29 +0000863 if (CE->getNumArgs() < 1)
864 return;
865 State = MallocMemAux(C, CE, CE->getArg(0), UndefinedVal(), State);
Anton Yartsevb50f4ba2015-04-14 14:18:04 +0000866 State = ProcessZeroAllocation(C, CE, 0, State);
Fangrui Song6907ce22018-07-30 19:24:48 +0000867 } else if (FunI == II_realloc || FunI == II_g_realloc ||
Anna Zaksbbec97c2017-03-09 00:01:01 +0000868 FunI == II_g_try_realloc) {
Leslie Zhaie3986c52017-04-26 05:33:14 +0000869 State = ReallocMemAux(C, CE, false, State);
Anton Yartsevb50f4ba2015-04-14 14:18:04 +0000870 State = ProcessZeroAllocation(C, CE, 1, State);
Anton Yartseve3377fb2013-04-04 23:46:29 +0000871 } else if (FunI == II_reallocf) {
Leslie Zhaie3986c52017-04-26 05:33:14 +0000872 State = ReallocMemAux(C, CE, true, State);
Anton Yartsevb50f4ba2015-04-14 14:18:04 +0000873 State = ProcessZeroAllocation(C, CE, 1, State);
Anton Yartseve3377fb2013-04-04 23:46:29 +0000874 } else if (FunI == II_calloc) {
Anton Yartsevb3fa86d2015-02-10 20:13:08 +0000875 State = CallocMem(C, CE, State);
Anton Yartsevb50f4ba2015-04-14 14:18:04 +0000876 State = ProcessZeroAllocation(C, CE, 0, State);
877 State = ProcessZeroAllocation(C, CE, 1, State);
Anna Zaksbbec97c2017-03-09 00:01:01 +0000878 } else if (FunI == II_free || FunI == II_g_free) {
Anton Yartseve3377fb2013-04-04 23:46:29 +0000879 State = FreeMemAux(C, CE, State, 0, false, ReleasedAllocatedMemory);
Anna Zaks30d46682016-03-08 01:21:51 +0000880 } else if (FunI == II_strdup || FunI == II_win_strdup ||
881 FunI == II_wcsdup || FunI == II_win_wcsdup) {
Anton Yartseve3377fb2013-04-04 23:46:29 +0000882 State = MallocUpdateRefState(C, CE, State);
883 } else if (FunI == II_strndup) {
884 State = MallocUpdateRefState(C, CE, State);
Anna Zaks30d46682016-03-08 01:21:51 +0000885 } else if (FunI == II_alloca || FunI == II_win_alloca) {
Devin Coughlin684d19d2016-10-16 22:19:03 +0000886 if (CE->getNumArgs() < 1)
887 return;
Anton Yartsev5b5c7ce2015-02-19 13:36:20 +0000888 State = MallocMemAux(C, CE, CE->getArg(0), UndefinedVal(), State,
889 AF_Alloca);
Anton Yartsevb50f4ba2015-04-14 14:18:04 +0000890 State = ProcessZeroAllocation(C, CE, 0, State);
Anton Yartsev5b5c7ce2015-02-19 13:36:20 +0000891 } else if (isStandardNewDelete(FD, C.getASTContext())) {
Anton Yartseve3377fb2013-04-04 23:46:29 +0000892 // Process direct calls to operator new/new[]/delete/delete[] functions
Ted Kremenek3a0678e2015-09-08 03:50:52 +0000893 // as distinct from new/new[]/delete/delete[] expressions that are
894 // processed by the checkPostStmt callbacks for CXXNewExpr and
Anton Yartseve3377fb2013-04-04 23:46:29 +0000895 // CXXDeleteExpr.
896 OverloadedOperatorKind K = FD->getOverloadedOperator();
Anton Yartsevb50f4ba2015-04-14 14:18:04 +0000897 if (K == OO_New) {
Anton Yartseve3377fb2013-04-04 23:46:29 +0000898 State = MallocMemAux(C, CE, CE->getArg(0), UndefinedVal(), State,
899 AF_CXXNew);
Anton Yartsevb50f4ba2015-04-14 14:18:04 +0000900 State = ProcessZeroAllocation(C, CE, 0, State);
901 }
902 else if (K == OO_Array_New) {
Anton Yartseve3377fb2013-04-04 23:46:29 +0000903 State = MallocMemAux(C, CE, CE->getArg(0), UndefinedVal(), State,
904 AF_CXXNewArray);
Anton Yartsevb50f4ba2015-04-14 14:18:04 +0000905 State = ProcessZeroAllocation(C, CE, 0, State);
906 }
Anton Yartseve3377fb2013-04-04 23:46:29 +0000907 else if (K == OO_Delete || K == OO_Array_Delete)
908 State = FreeMemAux(C, CE, State, 0, false, ReleasedAllocatedMemory);
909 else
910 llvm_unreachable("not a new/delete operator");
Anna Zaksd79b8402014-10-03 21:48:59 +0000911 } else if (FunI == II_if_nameindex) {
912 // Should we model this differently? We can allocate a fixed number of
913 // elements with zeros in the last one.
914 State = MallocMemAux(C, CE, UnknownVal(), UnknownVal(), State,
915 AF_IfNameIndex);
916 } else if (FunI == II_if_freenameindex) {
917 State = FreeMemAux(C, CE, State, 0, false, ReleasedAllocatedMemory);
Anna Zaksbbec97c2017-03-09 00:01:01 +0000918 } else if (FunI == II_g_malloc0 || FunI == II_g_try_malloc0) {
919 if (CE->getNumArgs() < 1)
920 return;
921 SValBuilder &svalBuilder = C.getSValBuilder();
922 SVal zeroVal = svalBuilder.makeZeroVal(svalBuilder.getContext().CharTy);
923 State = MallocMemAux(C, CE, CE->getArg(0), zeroVal, State);
924 State = ProcessZeroAllocation(C, CE, 0, State);
925 } else if (FunI == II_g_memdup) {
926 if (CE->getNumArgs() < 2)
927 return;
928 State = MallocMemAux(C, CE, CE->getArg(1), UndefinedVal(), State);
929 State = ProcessZeroAllocation(C, CE, 1, State);
Fangrui Song6907ce22018-07-30 19:24:48 +0000930 } else if (FunI == II_g_malloc_n || FunI == II_g_try_malloc_n ||
Leslie Zhaie3986c52017-04-26 05:33:14 +0000931 FunI == II_g_malloc0_n || FunI == II_g_try_malloc0_n) {
932 if (CE->getNumArgs() < 2)
933 return;
934 SVal Init = UndefinedVal();
935 if (FunI == II_g_malloc0_n || FunI == II_g_try_malloc0_n) {
936 SValBuilder &SB = C.getSValBuilder();
937 Init = SB.makeZeroVal(SB.getContext().CharTy);
938 }
939 SVal TotalSize = evalMulForBufferSize(C, CE->getArg(0), CE->getArg(1));
940 State = MallocMemAux(C, CE, TotalSize, Init, State);
941 State = ProcessZeroAllocation(C, CE, 0, State);
942 State = ProcessZeroAllocation(C, CE, 1, State);
943 } else if (FunI == II_g_realloc_n || FunI == II_g_try_realloc_n) {
944 if (CE->getNumArgs() < 3)
945 return;
946 State = ReallocMemAux(C, CE, false, State, true);
947 State = ProcessZeroAllocation(C, CE, 1, State);
948 State = ProcessZeroAllocation(C, CE, 2, State);
Jordan Rose6cd16c52012-07-10 23:13:01 +0000949 }
950 }
951
Gabor Horvathe40c71c2015-03-04 17:59:34 +0000952 if (IsOptimistic || ChecksEnabled[CK_MismatchedDeallocatorChecker]) {
Anna Zaks40a7eb32012-02-22 19:24:52 +0000953 // Check all the attributes, if there are any.
954 // There can be multiple of these attributes.
955 if (FD->hasAttrs())
Aaron Ballmanbe22bcb2014-03-10 17:08:28 +0000956 for (const auto *I : FD->specific_attrs<OwnershipAttr>()) {
957 switch (I->getOwnKind()) {
Anna Zaks40a7eb32012-02-22 19:24:52 +0000958 case OwnershipAttr::Returns:
Anton Yartsevb3fa86d2015-02-10 20:13:08 +0000959 State = MallocMemReturnsAttr(C, CE, I, State);
Anna Zaks40a7eb32012-02-22 19:24:52 +0000960 break;
961 case OwnershipAttr::Takes:
962 case OwnershipAttr::Holds:
Anton Yartsevb3fa86d2015-02-10 20:13:08 +0000963 State = FreeMemAttr(C, CE, I, State);
Anna Zaks40a7eb32012-02-22 19:24:52 +0000964 break;
965 }
966 }
Zhongxing Xu527ff6d2010-06-01 03:01:33 +0000967 }
Anna Zaks199e8e52012-02-22 03:14:20 +0000968 C.addTransition(State);
Zhongxing Xuc0484fa2009-12-12 12:29:38 +0000969}
970
Anton Yartsevb50f4ba2015-04-14 14:18:04 +0000971// Performs a 0-sized allocations check.
Artem Dergachev13b20262018-01-17 23:46:13 +0000972ProgramStateRef MallocChecker::ProcessZeroAllocation(
973 CheckerContext &C, const Expr *E, const unsigned AllocationSizeArg,
974 ProgramStateRef State, Optional<SVal> RetVal) const {
Anton Yartsevb50f4ba2015-04-14 14:18:04 +0000975 if (!State)
976 return nullptr;
977
Artem Dergachev13b20262018-01-17 23:46:13 +0000978 if (!RetVal)
979 RetVal = C.getSVal(E);
980
Anton Yartsevb50f4ba2015-04-14 14:18:04 +0000981 const Expr *Arg = nullptr;
982
983 if (const CallExpr *CE = dyn_cast<CallExpr>(E)) {
984 Arg = CE->getArg(AllocationSizeArg);
985 }
986 else if (const CXXNewExpr *NE = dyn_cast<CXXNewExpr>(E)) {
987 if (NE->isArray())
988 Arg = NE->getArraySize();
989 else
990 return State;
991 }
992 else
993 llvm_unreachable("not a CallExpr or CXXNewExpr");
994
995 assert(Arg);
996
George Karpenkovd703ec92018-01-17 20:27:29 +0000997 Optional<DefinedSVal> DefArgVal = C.getSVal(Arg).getAs<DefinedSVal>();
Anton Yartsevb50f4ba2015-04-14 14:18:04 +0000998
999 if (!DefArgVal)
1000 return State;
1001
1002 // Check if the allocation size is 0.
1003 ProgramStateRef TrueState, FalseState;
1004 SValBuilder &SvalBuilder = C.getSValBuilder();
1005 DefinedSVal Zero =
1006 SvalBuilder.makeZeroVal(Arg->getType()).castAs<DefinedSVal>();
1007
Ted Kremenek3a0678e2015-09-08 03:50:52 +00001008 std::tie(TrueState, FalseState) =
Anton Yartsevb50f4ba2015-04-14 14:18:04 +00001009 State->assume(SvalBuilder.evalEQ(State, *DefArgVal, Zero));
1010
1011 if (TrueState && !FalseState) {
Artem Dergachev13b20262018-01-17 23:46:13 +00001012 SymbolRef Sym = RetVal->getAsLocSymbol();
Anton Yartsevb50f4ba2015-04-14 14:18:04 +00001013 if (!Sym)
1014 return State;
1015
1016 const RefState *RS = State->get<RegionState>(Sym);
Devin Coughlin81771732015-09-22 22:47:14 +00001017 if (RS) {
1018 if (RS->isAllocated())
1019 return TrueState->set<RegionState>(Sym,
1020 RefState::getAllocatedOfSizeZero(RS));
1021 else
1022 return State;
1023 } else {
1024 // Case of zero-size realloc. Historically 'realloc(ptr, 0)' is treated as
1025 // 'free(ptr)' and the returned value from 'realloc(ptr, 0)' is not
1026 // tracked. Add zero-reallocated Sym to the state to catch references
1027 // to zero-allocated memory.
1028 return TrueState->add<ReallocSizeZeroSymbols>(Sym);
1029 }
Anton Yartsevb50f4ba2015-04-14 14:18:04 +00001030 }
1031
1032 // Assume the value is non-zero going forward.
1033 assert(FalseState);
1034 return FalseState;
1035}
1036
Anton Yartsev4e4cb6b2014-08-05 18:26:05 +00001037static QualType getDeepPointeeType(QualType T) {
1038 QualType Result = T, PointeeType = T->getPointeeType();
1039 while (!PointeeType.isNull()) {
1040 Result = PointeeType;
1041 PointeeType = PointeeType->getPointeeType();
1042 }
1043 return Result;
1044}
1045
1046static bool treatUnusedNewEscaped(const CXXNewExpr *NE) {
1047
1048 const CXXConstructExpr *ConstructE = NE->getConstructExpr();
1049 if (!ConstructE)
1050 return false;
1051
1052 if (!NE->getAllocatedType()->getAsCXXRecordDecl())
1053 return false;
1054
1055 const CXXConstructorDecl *CtorD = ConstructE->getConstructor();
1056
1057 // Iterate over the constructor parameters.
David Majnemer59f77922016-06-24 04:05:48 +00001058 for (const auto *CtorParam : CtorD->parameters()) {
Anton Yartsev4e4cb6b2014-08-05 18:26:05 +00001059
1060 QualType CtorParamPointeeT = CtorParam->getType()->getPointeeType();
1061 if (CtorParamPointeeT.isNull())
1062 continue;
1063
1064 CtorParamPointeeT = getDeepPointeeType(CtorParamPointeeT);
1065
1066 if (CtorParamPointeeT->getAsCXXRecordDecl())
1067 return true;
1068 }
1069
1070 return false;
1071}
1072
Artem Dergachev13b20262018-01-17 23:46:13 +00001073void MallocChecker::processNewAllocation(const CXXNewExpr *NE,
1074 CheckerContext &C,
1075 SVal Target) const {
Anton Yartsev13df0362013-03-25 01:35:45 +00001076 if (!isStandardNewDelete(NE->getOperatorNew(), C.getASTContext()))
1077 return;
1078
Anton Yartsev4e4cb6b2014-08-05 18:26:05 +00001079 ParentMap &PM = C.getLocationContext()->getParentMap();
1080 if (!PM.isConsumedExpr(NE) && treatUnusedNewEscaped(NE))
1081 return;
1082
Anton Yartsev13df0362013-03-25 01:35:45 +00001083 ProgramStateRef State = C.getState();
Ted Kremenek3a0678e2015-09-08 03:50:52 +00001084 // The return value from operator new is bound to a specified initialization
1085 // value (if any) and we don't want to loose this value. So we call
1086 // MallocUpdateRefState() instead of MallocMemAux() which breakes the
Anton Yartsev13df0362013-03-25 01:35:45 +00001087 // existing binding.
Ted Kremenek3a0678e2015-09-08 03:50:52 +00001088 State = MallocUpdateRefState(C, NE, State, NE->isArray() ? AF_CXXNewArray
Artem Dergachev13b20262018-01-17 23:46:13 +00001089 : AF_CXXNew, Target);
1090 State = addExtentSize(C, NE, State, Target);
1091 State = ProcessZeroAllocation(C, NE, 0, State, Target);
Anton Yartsev13df0362013-03-25 01:35:45 +00001092 C.addTransition(State);
1093}
1094
Artem Dergachev13b20262018-01-17 23:46:13 +00001095void MallocChecker::checkPostStmt(const CXXNewExpr *NE,
1096 CheckerContext &C) const {
1097 if (!C.getAnalysisManager().getAnalyzerOptions().mayInlineCXXAllocator())
1098 processNewAllocation(NE, C, C.getSVal(NE));
1099}
1100
1101void MallocChecker::checkNewAllocator(const CXXNewExpr *NE, SVal Target,
1102 CheckerContext &C) const {
1103 if (!C.wasInlined)
1104 processNewAllocation(NE, C, Target);
1105}
1106
Gabor Horvath73040272016-09-19 20:39:52 +00001107// Sets the extent value of the MemRegion allocated by
1108// new expression NE to its size in Bytes.
1109//
1110ProgramStateRef MallocChecker::addExtentSize(CheckerContext &C,
1111 const CXXNewExpr *NE,
Artem Dergachev13b20262018-01-17 23:46:13 +00001112 ProgramStateRef State,
1113 SVal Target) {
Gabor Horvath73040272016-09-19 20:39:52 +00001114 if (!State)
1115 return nullptr;
1116 SValBuilder &svalBuilder = C.getSValBuilder();
1117 SVal ElementCount;
Gabor Horvath73040272016-09-19 20:39:52 +00001118 const SubRegion *Region;
1119 if (NE->isArray()) {
1120 const Expr *SizeExpr = NE->getArraySize();
George Karpenkovd703ec92018-01-17 20:27:29 +00001121 ElementCount = C.getSVal(SizeExpr);
Gabor Horvath73040272016-09-19 20:39:52 +00001122 // Store the extent size for the (symbolic)region
1123 // containing the elements.
Artem Dergachev13b20262018-01-17 23:46:13 +00001124 Region = Target.getAsRegion()
Gabor Horvath73040272016-09-19 20:39:52 +00001125 ->getAs<SubRegion>()
Artem Dergachev13b20262018-01-17 23:46:13 +00001126 ->StripCasts()
Gabor Horvath73040272016-09-19 20:39:52 +00001127 ->getAs<SubRegion>();
1128 } else {
1129 ElementCount = svalBuilder.makeIntVal(1, true);
Artem Dergachev13b20262018-01-17 23:46:13 +00001130 Region = Target.getAsRegion()->getAs<SubRegion>();
Gabor Horvath73040272016-09-19 20:39:52 +00001131 }
1132 assert(Region);
1133
1134 // Set the region's extent equal to the Size in Bytes.
1135 QualType ElementType = NE->getAllocatedType();
1136 ASTContext &AstContext = C.getASTContext();
1137 CharUnits TypeSize = AstContext.getTypeSizeInChars(ElementType);
1138
Devin Coughline3b75de2016-12-16 18:41:40 +00001139 if (ElementCount.getAs<NonLoc>()) {
Gabor Horvath73040272016-09-19 20:39:52 +00001140 DefinedOrUnknownSVal Extent = Region->getExtent(svalBuilder);
1141 // size in Bytes = ElementCount*TypeSize
1142 SVal SizeInBytes = svalBuilder.evalBinOpNN(
1143 State, BO_Mul, ElementCount.castAs<NonLoc>(),
1144 svalBuilder.makeArrayIndex(TypeSize.getQuantity()),
1145 svalBuilder.getArrayIndexType());
1146 DefinedOrUnknownSVal extentMatchesSize = svalBuilder.evalEQ(
1147 State, Extent, SizeInBytes.castAs<DefinedOrUnknownSVal>());
1148 State = State->assume(extentMatchesSize, true);
1149 }
1150 return State;
1151}
1152
Ted Kremenek3a0678e2015-09-08 03:50:52 +00001153void MallocChecker::checkPreStmt(const CXXDeleteExpr *DE,
Anton Yartsev13df0362013-03-25 01:35:45 +00001154 CheckerContext &C) const {
1155
Alexander Kornienko4aca9b12014-02-11 21:49:21 +00001156 if (!ChecksEnabled[CK_NewDeleteChecker])
Anton Yartsev13df0362013-03-25 01:35:45 +00001157 if (SymbolRef Sym = C.getSVal(DE->getArgument()).getAsSymbol())
1158 checkUseAfterFree(Sym, C, DE->getArgument());
1159
Anton Yartsev13df0362013-03-25 01:35:45 +00001160 if (!isStandardNewDelete(DE->getOperatorDelete(), C.getASTContext()))
1161 return;
1162
1163 ProgramStateRef State = C.getState();
1164 bool ReleasedAllocated;
1165 State = FreeMemAux(C, DE->getArgument(), DE, State,
1166 /*Hold*/false, ReleasedAllocated);
1167
1168 C.addTransition(State);
1169}
1170
Jordan Rose613f3c02013-03-09 00:59:10 +00001171static bool isKnownDeallocObjCMethodName(const ObjCMethodCall &Call) {
1172 // If the first selector piece is one of the names below, assume that the
1173 // object takes ownership of the memory, promising to eventually deallocate it
1174 // with free().
1175 // Ex: [NSData dataWithBytesNoCopy:bytes length:10];
1176 // (...unless a 'freeWhenDone' parameter is false, but that's checked later.)
1177 StringRef FirstSlot = Call.getSelector().getNameForSlot(0);
Alexander Kornienko9c104902015-12-28 13:06:58 +00001178 return FirstSlot == "dataWithBytesNoCopy" ||
1179 FirstSlot == "initWithBytesNoCopy" ||
1180 FirstSlot == "initWithCharactersNoCopy";
Anna Zaks0d6989b2012-06-22 02:04:31 +00001181}
1182
Jordan Rose613f3c02013-03-09 00:59:10 +00001183static Optional<bool> getFreeWhenDoneArg(const ObjCMethodCall &Call) {
1184 Selector S = Call.getSelector();
1185
1186 // FIXME: We should not rely on fully-constrained symbols being folded.
1187 for (unsigned i = 1; i < S.getNumArgs(); ++i)
1188 if (S.getNameForSlot(i).equals("freeWhenDone"))
1189 return !Call.getArgSVal(i).isZeroConstant();
1190
1191 return None;
1192}
1193
Anna Zaks67291b92012-11-13 03:18:01 +00001194void MallocChecker::checkPostObjCMessage(const ObjCMethodCall &Call,
1195 CheckerContext &C) const {
Anna Zaksa7b1c472012-12-11 00:17:53 +00001196 if (C.wasInlined)
1197 return;
1198
Jordan Rose613f3c02013-03-09 00:59:10 +00001199 if (!isKnownDeallocObjCMethodName(Call))
1200 return;
Anna Zaks67291b92012-11-13 03:18:01 +00001201
Jordan Rose613f3c02013-03-09 00:59:10 +00001202 if (Optional<bool> FreeWhenDone = getFreeWhenDoneArg(Call))
1203 if (!*FreeWhenDone)
1204 return;
1205
1206 bool ReleasedAllocatedMemory;
1207 ProgramStateRef State = FreeMemAux(C, Call.getArgExpr(0),
1208 Call.getOriginExpr(), C.getState(),
1209 /*Hold=*/true, ReleasedAllocatedMemory,
1210 /*RetNullOnFailure=*/true);
1211
1212 C.addTransition(State);
Anna Zaks0d6989b2012-06-22 02:04:31 +00001213}
1214
Richard Smith852e9ce2013-11-27 01:46:48 +00001215ProgramStateRef
1216MallocChecker::MallocMemReturnsAttr(CheckerContext &C, const CallExpr *CE,
Ted Kremenek3a0678e2015-09-08 03:50:52 +00001217 const OwnershipAttr *Att,
Anton Yartsevb3fa86d2015-02-10 20:13:08 +00001218 ProgramStateRef State) const {
1219 if (!State)
1220 return nullptr;
1221
Richard Smith852e9ce2013-11-27 01:46:48 +00001222 if (Att->getModule() != II_malloc)
Craig Topper0dbb7832014-05-27 02:45:47 +00001223 return nullptr;
Ted Kremenekd21139a2010-07-31 01:52:11 +00001224
Joel E. Dennya6555112018-04-02 19:43:34 +00001225 OwnershipAttr::args_iterator I = Att->args_begin(), E = Att->args_end();
Ted Kremenekd21139a2010-07-31 01:52:11 +00001226 if (I != E) {
Joel E. Denny81508102018-03-13 14:51:22 +00001227 return MallocMemAux(C, CE, CE->getArg(I->getASTIndex()), UndefinedVal(),
1228 State);
Ted Kremenekd21139a2010-07-31 01:52:11 +00001229 }
Anton Yartsevb3fa86d2015-02-10 20:13:08 +00001230 return MallocMemAux(C, CE, UnknownVal(), UndefinedVal(), State);
1231}
1232
1233ProgramStateRef MallocChecker::MallocMemAux(CheckerContext &C,
1234 const CallExpr *CE,
1235 const Expr *SizeEx, SVal Init,
1236 ProgramStateRef State,
1237 AllocationFamily Family) {
1238 if (!State)
1239 return nullptr;
1240
George Karpenkovd703ec92018-01-17 20:27:29 +00001241 return MallocMemAux(C, CE, C.getSVal(SizeEx), Init, State, Family);
Ted Kremenekd21139a2010-07-31 01:52:11 +00001242}
1243
Anna Zaksc68bf4c2012-02-08 20:13:28 +00001244ProgramStateRef MallocChecker::MallocMemAux(CheckerContext &C,
Zhongxing Xuc0484fa2009-12-12 12:29:38 +00001245 const CallExpr *CE,
Zhongxing Xu527ff6d2010-06-01 03:01:33 +00001246 SVal Size, SVal Init,
Anton Yartsev05789592013-03-28 17:05:19 +00001247 ProgramStateRef State,
1248 AllocationFamily Family) {
Anton Yartsevb3fa86d2015-02-10 20:13:08 +00001249 if (!State)
1250 return nullptr;
Anna Zaks3563fde2012-06-07 03:57:32 +00001251
Jordan Rosef69e65f2014-09-05 16:33:51 +00001252 // We expect the malloc functions to return a pointer.
1253 if (!Loc::isLocType(CE->getType()))
1254 return nullptr;
1255
Anna Zaks3563fde2012-06-07 03:57:32 +00001256 // Bind the return value to the symbolic value from the heap region.
1257 // TODO: We could rewrite post visit to eval call; 'malloc' does not have
1258 // side effects other than what we model here.
Ted Kremenekd94854a2012-08-22 06:26:15 +00001259 unsigned Count = C.blockCount();
Anna Zaks3563fde2012-06-07 03:57:32 +00001260 SValBuilder &svalBuilder = C.getSValBuilder();
1261 const LocationContext *LCtx = C.getPredecessor()->getLocationContext();
David Blaikie2fdacbc2013-02-20 05:52:05 +00001262 DefinedSVal RetVal = svalBuilder.getConjuredHeapSymbolVal(CE, LCtx, Count)
1263 .castAs<DefinedSVal>();
Anton Yartsev05789592013-03-28 17:05:19 +00001264 State = State->BindExpr(CE, C.getLocationContext(), RetVal);
Zhongxing Xu9cb53b82009-12-11 03:09:01 +00001265
Jordy Rose674bd552010-07-04 00:00:41 +00001266 // Fill the region with the initialization value.
Artem Dergachev806486c2018-05-04 21:56:51 +00001267 State = State->bindDefaultInitial(RetVal, Init, LCtx);
Zhongxing Xu527ff6d2010-06-01 03:01:33 +00001268
Jordy Rose674bd552010-07-04 00:00:41 +00001269 // Set the region's extent equal to the Size parameter.
Anna Zaks31886862012-02-10 01:11:00 +00001270 const SymbolicRegion *R =
Anna Zaks3563fde2012-06-07 03:57:32 +00001271 dyn_cast_or_null<SymbolicRegion>(RetVal.getAsRegion());
Anna Zaks199e8e52012-02-22 03:14:20 +00001272 if (!R)
Craig Topper0dbb7832014-05-27 02:45:47 +00001273 return nullptr;
David Blaikie05785d12013-02-20 22:23:23 +00001274 if (Optional<DefinedOrUnknownSVal> DefinedSize =
David Blaikie2fdacbc2013-02-20 05:52:05 +00001275 Size.getAs<DefinedOrUnknownSVal>()) {
Anna Zaks40a7eb32012-02-22 19:24:52 +00001276 SValBuilder &svalBuilder = C.getSValBuilder();
Anna Zaks199e8e52012-02-22 03:14:20 +00001277 DefinedOrUnknownSVal Extent = R->getExtent(svalBuilder);
Anna Zaks199e8e52012-02-22 03:14:20 +00001278 DefinedOrUnknownSVal extentMatchesSize =
Anton Yartsev05789592013-03-28 17:05:19 +00001279 svalBuilder.evalEQ(State, Extent, *DefinedSize);
Anna Zaks31886862012-02-10 01:11:00 +00001280
Anton Yartsev05789592013-03-28 17:05:19 +00001281 State = State->assume(extentMatchesSize, true);
1282 assert(State);
Anna Zaks199e8e52012-02-22 03:14:20 +00001283 }
Ted Kremenek3a0678e2015-09-08 03:50:52 +00001284
Anton Yartsev05789592013-03-28 17:05:19 +00001285 return MallocUpdateRefState(C, CE, State, Family);
Anna Zaks40a7eb32012-02-22 19:24:52 +00001286}
1287
1288ProgramStateRef MallocChecker::MallocUpdateRefState(CheckerContext &C,
Anton Yartsev13df0362013-03-25 01:35:45 +00001289 const Expr *E,
Anton Yartsev05789592013-03-28 17:05:19 +00001290 ProgramStateRef State,
Artem Dergachev13b20262018-01-17 23:46:13 +00001291 AllocationFamily Family,
1292 Optional<SVal> RetVal) {
Anton Yartsevb3fa86d2015-02-10 20:13:08 +00001293 if (!State)
1294 return nullptr;
1295
Anna Zaks40a7eb32012-02-22 19:24:52 +00001296 // Get the return value.
Artem Dergachev13b20262018-01-17 23:46:13 +00001297 if (!RetVal)
1298 RetVal = C.getSVal(E);
Anna Zaks40a7eb32012-02-22 19:24:52 +00001299
1300 // We expect the malloc functions to return a pointer.
Artem Dergachev13b20262018-01-17 23:46:13 +00001301 if (!RetVal->getAs<Loc>())
Craig Topper0dbb7832014-05-27 02:45:47 +00001302 return nullptr;
Anna Zaks40a7eb32012-02-22 19:24:52 +00001303
Artem Dergachev13b20262018-01-17 23:46:13 +00001304 SymbolRef Sym = RetVal->getAsLocSymbol();
1305 // This is a return value of a function that was not inlined, such as malloc()
1306 // or new(). We've checked that in the caller. Therefore, it must be a symbol.
Zhongxing Xu88cca6b2009-11-12 08:38:56 +00001307 assert(Sym);
Ted Kremenek90af9092010-12-02 07:49:45 +00001308
Zhongxing Xu88cca6b2009-11-12 08:38:56 +00001309 // Set the symbol's state to Allocated.
Anton Yartsev05789592013-03-28 17:05:19 +00001310 return State->set<RegionState>(Sym, RefState::getAllocated(Family, E));
Zhongxing Xu88cca6b2009-11-12 08:38:56 +00001311}
1312
Anna Zaks40a7eb32012-02-22 19:24:52 +00001313ProgramStateRef MallocChecker::FreeMemAttr(CheckerContext &C,
1314 const CallExpr *CE,
Ted Kremenek3a0678e2015-09-08 03:50:52 +00001315 const OwnershipAttr *Att,
Anton Yartsevb3fa86d2015-02-10 20:13:08 +00001316 ProgramStateRef State) const {
1317 if (!State)
1318 return nullptr;
1319
Richard Smith852e9ce2013-11-27 01:46:48 +00001320 if (Att->getModule() != II_malloc)
Craig Topper0dbb7832014-05-27 02:45:47 +00001321 return nullptr;
Ted Kremenekd21139a2010-07-31 01:52:11 +00001322
Anna Zaksfe6eb672012-08-24 02:28:20 +00001323 bool ReleasedAllocated = false;
Anna Zaks8dc53af2012-03-01 22:06:06 +00001324
Aaron Ballmana82eaa72014-05-02 13:35:42 +00001325 for (const auto &Arg : Att->args()) {
Joel E. Denny81508102018-03-13 14:51:22 +00001326 ProgramStateRef StateI = FreeMemAux(
1327 C, CE, State, Arg.getASTIndex(),
1328 Att->getOwnKind() == OwnershipAttr::Holds, ReleasedAllocated);
Anna Zaks8dc53af2012-03-01 22:06:06 +00001329 if (StateI)
1330 State = StateI;
Ted Kremenekd21139a2010-07-31 01:52:11 +00001331 }
Anna Zaks8dc53af2012-03-01 22:06:06 +00001332 return State;
Ted Kremenekd21139a2010-07-31 01:52:11 +00001333}
1334
Ted Kremenek49b1e382012-01-26 21:29:00 +00001335ProgramStateRef MallocChecker::FreeMemAux(CheckerContext &C,
Anna Zaks31886862012-02-10 01:11:00 +00001336 const CallExpr *CE,
Anton Yartsevb3fa86d2015-02-10 20:13:08 +00001337 ProgramStateRef State,
Anna Zaks31886862012-02-10 01:11:00 +00001338 unsigned Num,
Anna Zaksfe6eb672012-08-24 02:28:20 +00001339 bool Hold,
Anna Zaks67291b92012-11-13 03:18:01 +00001340 bool &ReleasedAllocated,
1341 bool ReturnsNullOnFailure) const {
Anton Yartsevb3fa86d2015-02-10 20:13:08 +00001342 if (!State)
1343 return nullptr;
1344
Anna Zaksb508d292012-04-10 23:41:11 +00001345 if (CE->getNumArgs() < (Num + 1))
Craig Topper0dbb7832014-05-27 02:45:47 +00001346 return nullptr;
Anna Zaksb508d292012-04-10 23:41:11 +00001347
Anton Yartsevb3fa86d2015-02-10 20:13:08 +00001348 return FreeMemAux(C, CE->getArg(Num), CE, State, Hold,
Anna Zaks67291b92012-11-13 03:18:01 +00001349 ReleasedAllocated, ReturnsNullOnFailure);
1350}
1351
Anna Zaksa14c1d02012-11-13 19:47:40 +00001352/// Checks if the previous call to free on the given symbol failed - if free
1353/// failed, returns true. Also, returns the corresponding return value symbol.
Benjamin Kramerba4c85e2012-11-22 15:02:44 +00001354static bool didPreviousFreeFail(ProgramStateRef State,
1355 SymbolRef Sym, SymbolRef &RetStatusSymbol) {
Anna Zaksa14c1d02012-11-13 19:47:40 +00001356 const SymbolRef *Ret = State->get<FreeReturnValue>(Sym);
Anna Zaks67291b92012-11-13 03:18:01 +00001357 if (Ret) {
1358 assert(*Ret && "We should not store the null return symbol");
1359 ConstraintManager &CMgr = State->getConstraintManager();
1360 ConditionTruthVal FreeFailed = CMgr.isNull(State, *Ret);
Anna Zaksa14c1d02012-11-13 19:47:40 +00001361 RetStatusSymbol = *Ret;
1362 return FreeFailed.isConstrainedTrue();
Anna Zaks67291b92012-11-13 03:18:01 +00001363 }
Anna Zaksa14c1d02012-11-13 19:47:40 +00001364 return false;
Anna Zaks0d6989b2012-06-22 02:04:31 +00001365}
1366
Ted Kremenek3a0678e2015-09-08 03:50:52 +00001367AllocationFamily MallocChecker::getAllocationFamily(CheckerContext &C,
Anton Yartseve3377fb2013-04-04 23:46:29 +00001368 const Stmt *S) const {
1369 if (!S)
Anton Yartsev05789592013-03-28 17:05:19 +00001370 return AF_None;
1371
Anton Yartseve3377fb2013-04-04 23:46:29 +00001372 if (const CallExpr *CE = dyn_cast<CallExpr>(S)) {
Anton Yartsev05789592013-03-28 17:05:19 +00001373 const FunctionDecl *FD = C.getCalleeDecl(CE);
Anton Yartseve3377fb2013-04-04 23:46:29 +00001374
1375 if (!FD)
1376 FD = dyn_cast<FunctionDecl>(CE->getCalleeDecl());
1377
Anton Yartsev05789592013-03-28 17:05:19 +00001378 ASTContext &Ctx = C.getASTContext();
1379
Anna Zaksd79b8402014-10-03 21:48:59 +00001380 if (isCMemFunction(FD, Ctx, AF_Malloc, MemoryOperationKind::MOK_Any))
Anton Yartsev05789592013-03-28 17:05:19 +00001381 return AF_Malloc;
1382
1383 if (isStandardNewDelete(FD, Ctx)) {
1384 OverloadedOperatorKind Kind = FD->getOverloadedOperator();
Anton Yartseve3377fb2013-04-04 23:46:29 +00001385 if (Kind == OO_New || Kind == OO_Delete)
Anton Yartsev05789592013-03-28 17:05:19 +00001386 return AF_CXXNew;
Anton Yartseve3377fb2013-04-04 23:46:29 +00001387 else if (Kind == OO_Array_New || Kind == OO_Array_Delete)
Anton Yartsev05789592013-03-28 17:05:19 +00001388 return AF_CXXNewArray;
1389 }
1390
Anna Zaksd79b8402014-10-03 21:48:59 +00001391 if (isCMemFunction(FD, Ctx, AF_IfNameIndex, MemoryOperationKind::MOK_Any))
1392 return AF_IfNameIndex;
1393
Anton Yartsev5b5c7ce2015-02-19 13:36:20 +00001394 if (isCMemFunction(FD, Ctx, AF_Alloca, MemoryOperationKind::MOK_Any))
1395 return AF_Alloca;
1396
Anton Yartsev05789592013-03-28 17:05:19 +00001397 return AF_None;
1398 }
1399
Anton Yartseve3377fb2013-04-04 23:46:29 +00001400 if (const CXXNewExpr *NE = dyn_cast<CXXNewExpr>(S))
1401 return NE->isArray() ? AF_CXXNewArray : AF_CXXNew;
1402
1403 if (const CXXDeleteExpr *DE = dyn_cast<CXXDeleteExpr>(S))
Anton Yartsev05789592013-03-28 17:05:19 +00001404 return DE->isArrayForm() ? AF_CXXNewArray : AF_CXXNew;
1405
Anton Yartseve3377fb2013-04-04 23:46:29 +00001406 if (isa<ObjCMessageExpr>(S))
Anton Yartsev05789592013-03-28 17:05:19 +00001407 return AF_Malloc;
1408
1409 return AF_None;
1410}
1411
Ted Kremenek3a0678e2015-09-08 03:50:52 +00001412bool MallocChecker::printAllocDeallocName(raw_ostream &os, CheckerContext &C,
Anton Yartsev05789592013-03-28 17:05:19 +00001413 const Expr *E) const {
1414 if (const CallExpr *CE = dyn_cast<CallExpr>(E)) {
1415 // FIXME: This doesn't handle indirect calls.
1416 const FunctionDecl *FD = CE->getDirectCallee();
1417 if (!FD)
1418 return false;
Ted Kremenek3a0678e2015-09-08 03:50:52 +00001419
Anton Yartsev05789592013-03-28 17:05:19 +00001420 os << *FD;
1421 if (!FD->isOverloadedOperator())
1422 os << "()";
1423 return true;
1424 }
1425
1426 if (const ObjCMessageExpr *Msg = dyn_cast<ObjCMessageExpr>(E)) {
1427 if (Msg->isInstanceMessage())
1428 os << "-";
1429 else
1430 os << "+";
Aaron Ballmanb190f972014-01-03 17:59:55 +00001431 Msg->getSelector().print(os);
Anton Yartsev05789592013-03-28 17:05:19 +00001432 return true;
1433 }
1434
1435 if (const CXXNewExpr *NE = dyn_cast<CXXNewExpr>(E)) {
Ted Kremenek3a0678e2015-09-08 03:50:52 +00001436 os << "'"
Anton Yartsev05789592013-03-28 17:05:19 +00001437 << getOperatorSpelling(NE->getOperatorNew()->getOverloadedOperator())
1438 << "'";
1439 return true;
1440 }
1441
1442 if (const CXXDeleteExpr *DE = dyn_cast<CXXDeleteExpr>(E)) {
Ted Kremenek3a0678e2015-09-08 03:50:52 +00001443 os << "'"
Anton Yartsev05789592013-03-28 17:05:19 +00001444 << getOperatorSpelling(DE->getOperatorDelete()->getOverloadedOperator())
1445 << "'";
1446 return true;
1447 }
1448
1449 return false;
1450}
1451
1452void MallocChecker::printExpectedAllocName(raw_ostream &os, CheckerContext &C,
1453 const Expr *E) const {
1454 AllocationFamily Family = getAllocationFamily(C, E);
1455
1456 switch(Family) {
1457 case AF_Malloc: os << "malloc()"; return;
1458 case AF_CXXNew: os << "'new'"; return;
1459 case AF_CXXNewArray: os << "'new[]'"; return;
Anna Zaksd79b8402014-10-03 21:48:59 +00001460 case AF_IfNameIndex: os << "'if_nameindex()'"; return;
Reka Kovacs88ad7042018-07-20 15:14:49 +00001461 case AF_InnerBuffer: os << "container-specific allocator"; return;
Anton Yartsev5b5c7ce2015-02-19 13:36:20 +00001462 case AF_Alloca:
Anton Yartsev05789592013-03-28 17:05:19 +00001463 case AF_None: llvm_unreachable("not a deallocation expression");
1464 }
1465}
1466
Ted Kremenek3a0678e2015-09-08 03:50:52 +00001467void MallocChecker::printExpectedDeallocName(raw_ostream &os,
Anton Yartsev05789592013-03-28 17:05:19 +00001468 AllocationFamily Family) const {
1469 switch(Family) {
1470 case AF_Malloc: os << "free()"; return;
1471 case AF_CXXNew: os << "'delete'"; return;
1472 case AF_CXXNewArray: os << "'delete[]'"; return;
Anna Zaksd79b8402014-10-03 21:48:59 +00001473 case AF_IfNameIndex: os << "'if_freenameindex()'"; return;
Reka Kovacs88ad7042018-07-20 15:14:49 +00001474 case AF_InnerBuffer: os << "container-specific deallocator"; return;
Anton Yartsev5b5c7ce2015-02-19 13:36:20 +00001475 case AF_Alloca:
1476 case AF_None: llvm_unreachable("suspicious argument");
Anton Yartsev05789592013-03-28 17:05:19 +00001477 }
1478}
1479
Anna Zaks0d6989b2012-06-22 02:04:31 +00001480ProgramStateRef MallocChecker::FreeMemAux(CheckerContext &C,
1481 const Expr *ArgExpr,
1482 const Expr *ParentExpr,
Anna Zaks67291b92012-11-13 03:18:01 +00001483 ProgramStateRef State,
Anna Zaksfe6eb672012-08-24 02:28:20 +00001484 bool Hold,
Anna Zaks67291b92012-11-13 03:18:01 +00001485 bool &ReleasedAllocated,
1486 bool ReturnsNullOnFailure) const {
Anna Zaks0d6989b2012-06-22 02:04:31 +00001487
Anton Yartsevb3fa86d2015-02-10 20:13:08 +00001488 if (!State)
1489 return nullptr;
1490
George Karpenkovd703ec92018-01-17 20:27:29 +00001491 SVal ArgVal = C.getSVal(ArgExpr);
David Blaikie2fdacbc2013-02-20 05:52:05 +00001492 if (!ArgVal.getAs<DefinedOrUnknownSVal>())
Craig Topper0dbb7832014-05-27 02:45:47 +00001493 return nullptr;
David Blaikie2fdacbc2013-02-20 05:52:05 +00001494 DefinedOrUnknownSVal location = ArgVal.castAs<DefinedOrUnknownSVal>();
Ted Kremenekd21139a2010-07-31 01:52:11 +00001495
1496 // Check for null dereferences.
David Blaikie2fdacbc2013-02-20 05:52:05 +00001497 if (!location.getAs<Loc>())
Craig Topper0dbb7832014-05-27 02:45:47 +00001498 return nullptr;
Ted Kremenekd21139a2010-07-31 01:52:11 +00001499
Anna Zaksad01ef52012-02-14 00:26:13 +00001500 // The explicit NULL case, no operation is performed.
Ted Kremenek49b1e382012-01-26 21:29:00 +00001501 ProgramStateRef notNullState, nullState;
Benjamin Kramer867ea1d2014-03-02 13:01:17 +00001502 std::tie(notNullState, nullState) = State->assume(location);
Ted Kremenekd21139a2010-07-31 01:52:11 +00001503 if (nullState && !notNullState)
Craig Topper0dbb7832014-05-27 02:45:47 +00001504 return nullptr;
Ted Kremenekd21139a2010-07-31 01:52:11 +00001505
Jordy Rose3597b212010-06-07 19:32:37 +00001506 // Unknown values could easily be okay
1507 // Undefined values are handled elsewhere
1508 if (ArgVal.isUnknownOrUndef())
Craig Topper0dbb7832014-05-27 02:45:47 +00001509 return nullptr;
Zhongxing Xu88cca6b2009-11-12 08:38:56 +00001510
Jordy Rose3597b212010-06-07 19:32:37 +00001511 const MemRegion *R = ArgVal.getAsRegion();
Ted Kremenek3a0678e2015-09-08 03:50:52 +00001512
Jordy Rose3597b212010-06-07 19:32:37 +00001513 // Nonlocs can't be freed, of course.
1514 // Non-region locations (labels and fixed addresses) also shouldn't be freed.
1515 if (!R) {
Anton Yartsev05789592013-03-28 17:05:19 +00001516 ReportBadFree(C, ArgVal, ArgExpr->getSourceRange(), ParentExpr);
Craig Topper0dbb7832014-05-27 02:45:47 +00001517 return nullptr;
Jordy Rose3597b212010-06-07 19:32:37 +00001518 }
Ted Kremenek3a0678e2015-09-08 03:50:52 +00001519
Jordy Rose3597b212010-06-07 19:32:37 +00001520 R = R->StripCasts();
Ted Kremenek3a0678e2015-09-08 03:50:52 +00001521
Jordy Rose3597b212010-06-07 19:32:37 +00001522 // Blocks might show up as heap data, but should not be free()d
1523 if (isa<BlockDataRegion>(R)) {
Anton Yartsev05789592013-03-28 17:05:19 +00001524 ReportBadFree(C, ArgVal, ArgExpr->getSourceRange(), ParentExpr);
Craig Topper0dbb7832014-05-27 02:45:47 +00001525 return nullptr;
Jordy Rose3597b212010-06-07 19:32:37 +00001526 }
Ted Kremenek3a0678e2015-09-08 03:50:52 +00001527
Jordy Rose3597b212010-06-07 19:32:37 +00001528 const MemSpaceRegion *MS = R->getMemorySpace();
Ted Kremenek3a0678e2015-09-08 03:50:52 +00001529
1530 // Parameters, locals, statics, globals, and memory returned by
Anton Yartsevc38d7952015-03-03 22:58:46 +00001531 // __builtin_alloca() shouldn't be freed.
Jordy Rose3597b212010-06-07 19:32:37 +00001532 if (!(isa<UnknownSpaceRegion>(MS) || isa<HeapSpaceRegion>(MS))) {
1533 // FIXME: at the time this code was written, malloc() regions were
1534 // represented by conjured symbols, which are all in UnknownSpaceRegion.
1535 // This means that there isn't actually anything from HeapSpaceRegion
1536 // that should be freed, even though we allow it here.
1537 // Of course, free() can work on memory allocated outside the current
1538 // function, so UnknownSpaceRegion is always a possibility.
1539 // False negatives are better than false positives.
Anton Yartsevc38d7952015-03-03 22:58:46 +00001540
1541 if (isa<AllocaRegion>(R))
1542 ReportFreeAlloca(C, ArgVal, ArgExpr->getSourceRange());
1543 else
1544 ReportBadFree(C, ArgVal, ArgExpr->getSourceRange(), ParentExpr);
1545
Craig Topper0dbb7832014-05-27 02:45:47 +00001546 return nullptr;
Jordy Rose3597b212010-06-07 19:32:37 +00001547 }
Anna Zaksc89ad072013-02-07 23:05:47 +00001548
1549 const SymbolicRegion *SrBase = dyn_cast<SymbolicRegion>(R->getBaseRegion());
Jordy Rose3597b212010-06-07 19:32:37 +00001550 // Various cases could lead to non-symbol values here.
1551 // For now, ignore them.
Anna Zaksc89ad072013-02-07 23:05:47 +00001552 if (!SrBase)
Craig Topper0dbb7832014-05-27 02:45:47 +00001553 return nullptr;
Jordy Rose3597b212010-06-07 19:32:37 +00001554
Anna Zaksc89ad072013-02-07 23:05:47 +00001555 SymbolRef SymBase = SrBase->getSymbol();
1556 const RefState *RsBase = State->get<RegionState>(SymBase);
Craig Topper0dbb7832014-05-27 02:45:47 +00001557 SymbolRef PreviousRetStatusSymbol = nullptr;
Zhongxing Xue2bdb9a2010-01-18 03:27:34 +00001558
Anton Yartseve3377fb2013-04-04 23:46:29 +00001559 if (RsBase) {
Zhongxing Xu88cca6b2009-11-12 08:38:56 +00001560
Anton Yartsev5b5c7ce2015-02-19 13:36:20 +00001561 // Memory returned by alloca() shouldn't be freed.
1562 if (RsBase->getAllocationFamily() == AF_Alloca) {
1563 ReportFreeAlloca(C, ArgVal, ArgExpr->getSourceRange());
1564 return nullptr;
1565 }
1566
Anna Zaks93a21a82013-04-09 00:30:28 +00001567 // Check for double free first.
1568 if ((RsBase->isReleased() || RsBase->isRelinquished()) &&
Anton Yartseve3377fb2013-04-04 23:46:29 +00001569 !didPreviousFreeFail(State, SymBase, PreviousRetStatusSymbol)) {
1570 ReportDoubleFree(C, ParentExpr->getSourceRange(), RsBase->isReleased(),
1571 SymBase, PreviousRetStatusSymbol);
Craig Topper0dbb7832014-05-27 02:45:47 +00001572 return nullptr;
Anton Yartseve3377fb2013-04-04 23:46:29 +00001573
Anna Zaks93a21a82013-04-09 00:30:28 +00001574 // If the pointer is allocated or escaped, but we are now trying to free it,
1575 // check that the call to free is proper.
Ted Kremenek3a0678e2015-09-08 03:50:52 +00001576 } else if (RsBase->isAllocated() || RsBase->isAllocatedOfSizeZero() ||
Anton Yartsevb50f4ba2015-04-14 14:18:04 +00001577 RsBase->isEscaped()) {
Anna Zaks93a21a82013-04-09 00:30:28 +00001578
1579 // Check if an expected deallocation function matches the real one.
1580 bool DeallocMatchesAlloc =
1581 RsBase->getAllocationFamily() == getAllocationFamily(C, ParentExpr);
1582 if (!DeallocMatchesAlloc) {
1583 ReportMismatchedDealloc(C, ArgExpr->getSourceRange(),
Anton Yartsevf5bccce2013-09-16 17:51:25 +00001584 ParentExpr, RsBase, SymBase, Hold);
Craig Topper0dbb7832014-05-27 02:45:47 +00001585 return nullptr;
Anna Zaks93a21a82013-04-09 00:30:28 +00001586 }
1587
1588 // Check if the memory location being freed is the actual location
1589 // allocated, or an offset.
1590 RegionOffset Offset = R->getAsOffset();
1591 if (Offset.isValid() &&
1592 !Offset.hasSymbolicOffset() &&
1593 Offset.getOffset() != 0) {
1594 const Expr *AllocExpr = cast<Expr>(RsBase->getStmt());
Ted Kremenek3a0678e2015-09-08 03:50:52 +00001595 ReportOffsetFree(C, ArgVal, ArgExpr->getSourceRange(), ParentExpr,
Anna Zaks93a21a82013-04-09 00:30:28 +00001596 AllocExpr);
Craig Topper0dbb7832014-05-27 02:45:47 +00001597 return nullptr;
Anna Zaks93a21a82013-04-09 00:30:28 +00001598 }
Anton Yartseve3377fb2013-04-04 23:46:29 +00001599 }
Anna Zaksc89ad072013-02-07 23:05:47 +00001600 }
1601
Daniel Marjamakia43a8f52017-05-02 11:46:12 +00001602 if (SymBase->getType()->isFunctionPointerType()) {
1603 ReportFunctionPointerFree(C, ArgVal, ArgExpr->getSourceRange(), ParentExpr);
1604 return nullptr;
1605 }
1606
Ted Kremenek3a0678e2015-09-08 03:50:52 +00001607 ReleasedAllocated = (RsBase != nullptr) && (RsBase->isAllocated() ||
Anton Yartsevb50f4ba2015-04-14 14:18:04 +00001608 RsBase->isAllocatedOfSizeZero());
Anna Zaksfe6eb672012-08-24 02:28:20 +00001609
Anna Zaksa14c1d02012-11-13 19:47:40 +00001610 // Clean out the info on previous call to free return info.
Anna Zaksc89ad072013-02-07 23:05:47 +00001611 State = State->remove<FreeReturnValue>(SymBase);
Anna Zaksa14c1d02012-11-13 19:47:40 +00001612
Ted Kremenek3a0678e2015-09-08 03:50:52 +00001613 // Keep track of the return value. If it is NULL, we will know that free
Anna Zaks67291b92012-11-13 03:18:01 +00001614 // failed.
1615 if (ReturnsNullOnFailure) {
1616 SVal RetVal = C.getSVal(ParentExpr);
1617 SymbolRef RetStatusSymbol = RetVal.getAsSymbol();
1618 if (RetStatusSymbol) {
Anna Zaksc89ad072013-02-07 23:05:47 +00001619 C.getSymbolManager().addSymbolDependency(SymBase, RetStatusSymbol);
1620 State = State->set<FreeReturnValue>(SymBase, RetStatusSymbol);
Anna Zaks67291b92012-11-13 03:18:01 +00001621 }
1622 }
1623
Anton Yartsev030bcdd2013-04-05 19:08:04 +00001624 AllocationFamily Family = RsBase ? RsBase->getAllocationFamily()
1625 : getAllocationFamily(C, ParentExpr);
Zhongxing Xu88cca6b2009-11-12 08:38:56 +00001626 // Normal free.
Anton Yartsev05789592013-03-28 17:05:19 +00001627 if (Hold)
Anna Zaksc89ad072013-02-07 23:05:47 +00001628 return State->set<RegionState>(SymBase,
Anton Yartsev05789592013-03-28 17:05:19 +00001629 RefState::getRelinquished(Family,
1630 ParentExpr));
1631
1632 return State->set<RegionState>(SymBase,
1633 RefState::getReleased(Family, ParentExpr));
Zhongxing Xuc0484fa2009-12-12 12:29:38 +00001634}
1635
Alexander Kornienko4aca9b12014-02-11 21:49:21 +00001636Optional<MallocChecker::CheckKind>
Anton Yartsev2487dd62015-03-10 22:24:21 +00001637MallocChecker::getCheckIfTracked(AllocationFamily Family,
1638 bool IsALeakCheck) const {
Anton Yartsev717aa0e2013-04-05 00:31:02 +00001639 switch (Family) {
Anna Zaksd79b8402014-10-03 21:48:59 +00001640 case AF_Malloc:
Anton Yartsev4eb394d2015-03-07 00:31:53 +00001641 case AF_Alloca:
1642 case AF_IfNameIndex: {
1643 if (ChecksEnabled[CK_MallocChecker])
1644 return CK_MallocChecker;
Reka Kovacsd9f66ba2018-08-06 22:03:42 +00001645 return None;
Anton Yartsev717aa0e2013-04-05 00:31:02 +00001646 }
1647 case AF_CXXNew:
Reka Kovacsd9f66ba2018-08-06 22:03:42 +00001648 case AF_CXXNewArray: {
Anton Yartsev2487dd62015-03-10 22:24:21 +00001649 if (IsALeakCheck) {
1650 if (ChecksEnabled[CK_NewDeleteLeaksChecker])
1651 return CK_NewDeleteLeaksChecker;
Ted Kremenek3a0678e2015-09-08 03:50:52 +00001652 }
Anton Yartsev2487dd62015-03-10 22:24:21 +00001653 else {
1654 if (ChecksEnabled[CK_NewDeleteChecker])
1655 return CK_NewDeleteChecker;
Alexander Kornienko4aca9b12014-02-11 21:49:21 +00001656 }
Reka Kovacsd9f66ba2018-08-06 22:03:42 +00001657 return None;
1658 }
1659 case AF_InnerBuffer: {
1660 if (ChecksEnabled[CK_InnerPointerChecker])
1661 return CK_InnerPointerChecker;
1662 return None;
Anton Yartsev717aa0e2013-04-05 00:31:02 +00001663 }
1664 case AF_None: {
Anton Yartsev030bcdd2013-04-05 19:08:04 +00001665 llvm_unreachable("no family");
Anton Yartsev717aa0e2013-04-05 00:31:02 +00001666 }
Anton Yartsev717aa0e2013-04-05 00:31:02 +00001667 }
Anton Yartsev2f910042013-04-05 02:12:04 +00001668 llvm_unreachable("unhandled family");
Anton Yartseve3377fb2013-04-04 23:46:29 +00001669}
1670
Alexander Kornienko4aca9b12014-02-11 21:49:21 +00001671Optional<MallocChecker::CheckKind>
Anton Yartsev4eb394d2015-03-07 00:31:53 +00001672MallocChecker::getCheckIfTracked(CheckerContext &C,
Anton Yartsev2487dd62015-03-10 22:24:21 +00001673 const Stmt *AllocDeallocStmt,
1674 bool IsALeakCheck) const {
1675 return getCheckIfTracked(getAllocationFamily(C, AllocDeallocStmt),
1676 IsALeakCheck);
Anton Yartseve5c0c142015-02-18 00:39:06 +00001677}
1678
1679Optional<MallocChecker::CheckKind>
Anton Yartsev2487dd62015-03-10 22:24:21 +00001680MallocChecker::getCheckIfTracked(CheckerContext &C, SymbolRef Sym,
1681 bool IsALeakCheck) const {
Devin Coughlin81771732015-09-22 22:47:14 +00001682 if (C.getState()->contains<ReallocSizeZeroSymbols>(Sym))
1683 return CK_MallocChecker;
1684
Anton Yartsev030bcdd2013-04-05 19:08:04 +00001685 const RefState *RS = C.getState()->get<RegionState>(Sym);
1686 assert(RS);
Anton Yartsev2487dd62015-03-10 22:24:21 +00001687 return getCheckIfTracked(RS->getAllocationFamily(), IsALeakCheck);
Anton Yartseve3377fb2013-04-04 23:46:29 +00001688}
1689
Ted Kremenek5ef32db2011-08-12 23:37:29 +00001690bool MallocChecker::SummarizeValue(raw_ostream &os, SVal V) {
David Blaikie05785d12013-02-20 22:23:23 +00001691 if (Optional<nonloc::ConcreteInt> IntVal = V.getAs<nonloc::ConcreteInt>())
Jordy Rose3597b212010-06-07 19:32:37 +00001692 os << "an integer (" << IntVal->getValue() << ")";
David Blaikie05785d12013-02-20 22:23:23 +00001693 else if (Optional<loc::ConcreteInt> ConstAddr = V.getAs<loc::ConcreteInt>())
Jordy Rose3597b212010-06-07 19:32:37 +00001694 os << "a constant address (" << ConstAddr->getValue() << ")";
David Blaikie05785d12013-02-20 22:23:23 +00001695 else if (Optional<loc::GotoLabel> Label = V.getAs<loc::GotoLabel>())
Chris Lattner5a9b1ec2011-02-17 05:38:27 +00001696 os << "the address of the label '" << Label->getLabel()->getName() << "'";
Jordy Rose3597b212010-06-07 19:32:37 +00001697 else
1698 return false;
Ted Kremenek3a0678e2015-09-08 03:50:52 +00001699
Jordy Rose3597b212010-06-07 19:32:37 +00001700 return true;
1701}
1702
Ted Kremenek5ef32db2011-08-12 23:37:29 +00001703bool MallocChecker::SummarizeRegion(raw_ostream &os,
Jordy Rose3597b212010-06-07 19:32:37 +00001704 const MemRegion *MR) {
1705 switch (MR->getKind()) {
Artem Dergachev73f018e2016-01-13 13:49:29 +00001706 case MemRegion::FunctionCodeRegionKind: {
1707 const NamedDecl *FD = cast<FunctionCodeRegion>(MR)->getDecl();
Jordy Rose3597b212010-06-07 19:32:37 +00001708 if (FD)
Benjamin Kramerb89514a2011-10-14 18:45:37 +00001709 os << "the address of the function '" << *FD << '\'';
Jordy Rose3597b212010-06-07 19:32:37 +00001710 else
1711 os << "the address of a function";
1712 return true;
1713 }
Artem Dergachev73f018e2016-01-13 13:49:29 +00001714 case MemRegion::BlockCodeRegionKind:
Jordy Rose3597b212010-06-07 19:32:37 +00001715 os << "block text";
1716 return true;
1717 case MemRegion::BlockDataRegionKind:
1718 // FIXME: where the block came from?
1719 os << "a block";
1720 return true;
1721 default: {
1722 const MemSpaceRegion *MS = MR->getMemorySpace();
Ted Kremenek3a0678e2015-09-08 03:50:52 +00001723
Anna Zaks8158ef02012-01-04 23:54:01 +00001724 if (isa<StackLocalsSpaceRegion>(MS)) {
Jordy Rose3597b212010-06-07 19:32:37 +00001725 const VarRegion *VR = dyn_cast<VarRegion>(MR);
1726 const VarDecl *VD;
1727 if (VR)
1728 VD = VR->getDecl();
1729 else
Craig Topper0dbb7832014-05-27 02:45:47 +00001730 VD = nullptr;
1731
Jordy Rose3597b212010-06-07 19:32:37 +00001732 if (VD)
1733 os << "the address of the local variable '" << VD->getName() << "'";
1734 else
1735 os << "the address of a local stack variable";
1736 return true;
1737 }
Anna Zaks8158ef02012-01-04 23:54:01 +00001738
1739 if (isa<StackArgumentsSpaceRegion>(MS)) {
Jordy Rose3597b212010-06-07 19:32:37 +00001740 const VarRegion *VR = dyn_cast<VarRegion>(MR);
1741 const VarDecl *VD;
1742 if (VR)
1743 VD = VR->getDecl();
1744 else
Craig Topper0dbb7832014-05-27 02:45:47 +00001745 VD = nullptr;
1746
Jordy Rose3597b212010-06-07 19:32:37 +00001747 if (VD)
1748 os << "the address of the parameter '" << VD->getName() << "'";
1749 else
1750 os << "the address of a parameter";
1751 return true;
1752 }
Anna Zaks8158ef02012-01-04 23:54:01 +00001753
1754 if (isa<GlobalsSpaceRegion>(MS)) {
Jordy Rose3597b212010-06-07 19:32:37 +00001755 const VarRegion *VR = dyn_cast<VarRegion>(MR);
1756 const VarDecl *VD;
1757 if (VR)
1758 VD = VR->getDecl();
1759 else
Craig Topper0dbb7832014-05-27 02:45:47 +00001760 VD = nullptr;
1761
Jordy Rose3597b212010-06-07 19:32:37 +00001762 if (VD) {
1763 if (VD->isStaticLocal())
1764 os << "the address of the static variable '" << VD->getName() << "'";
1765 else
1766 os << "the address of the global variable '" << VD->getName() << "'";
1767 } else
1768 os << "the address of a global variable";
1769 return true;
1770 }
Anna Zaks8158ef02012-01-04 23:54:01 +00001771
1772 return false;
Jordy Rose3597b212010-06-07 19:32:37 +00001773 }
1774 }
1775}
1776
Ted Kremenek3a0678e2015-09-08 03:50:52 +00001777void MallocChecker::ReportBadFree(CheckerContext &C, SVal ArgVal,
1778 SourceRange Range,
Anton Yartsev05789592013-03-28 17:05:19 +00001779 const Expr *DeallocExpr) const {
1780
Anton Yartsev4eb394d2015-03-07 00:31:53 +00001781 if (!ChecksEnabled[CK_MallocChecker] &&
1782 !ChecksEnabled[CK_NewDeleteChecker])
1783 return;
1784
1785 Optional<MallocChecker::CheckKind> CheckKind =
1786 getCheckIfTracked(C, DeallocExpr);
Alexander Kornienko4aca9b12014-02-11 21:49:21 +00001787 if (!CheckKind.hasValue())
Anton Yartseve3377fb2013-04-04 23:46:29 +00001788 return;
1789
Devin Coughline39bd402015-09-16 22:03:05 +00001790 if (ExplodedNode *N = C.generateErrorNode()) {
Alexander Kornienko4aca9b12014-02-11 21:49:21 +00001791 if (!BT_BadFree[*CheckKind])
Artem Dergachevb6a513d2017-05-03 11:47:13 +00001792 BT_BadFree[*CheckKind].reset(new BugType(
1793 CheckNames[*CheckKind], "Bad free", categories::MemoryError));
Alexander Kornienko4aca9b12014-02-11 21:49:21 +00001794
Dylan Noblesmith2c1dd272012-02-05 02:13:05 +00001795 SmallString<100> buf;
Jordy Rose3597b212010-06-07 19:32:37 +00001796 llvm::raw_svector_ostream os(buf);
Anton Yartsev05789592013-03-28 17:05:19 +00001797
Jordy Rose3597b212010-06-07 19:32:37 +00001798 const MemRegion *MR = ArgVal.getAsRegion();
Anton Yartsev05789592013-03-28 17:05:19 +00001799 while (const ElementRegion *ER = dyn_cast_or_null<ElementRegion>(MR))
1800 MR = ER->getSuperRegion();
1801
Anton Yartsev5b5c7ce2015-02-19 13:36:20 +00001802 os << "Argument to ";
1803 if (!printAllocDeallocName(os, C, DeallocExpr))
1804 os << "deallocator";
Anton Yartsev05789592013-03-28 17:05:19 +00001805
Anton Yartsev5b5c7ce2015-02-19 13:36:20 +00001806 os << " is ";
Ted Kremenek3a0678e2015-09-08 03:50:52 +00001807 bool Summarized = MR ? SummarizeRegion(os, MR)
Anton Yartsev5b5c7ce2015-02-19 13:36:20 +00001808 : SummarizeValue(os, ArgVal);
1809 if (Summarized)
1810 os << ", which is not memory allocated by ";
1811 else
1812 os << "not memory allocated by ";
Anton Yartsev05789592013-03-28 17:05:19 +00001813
Anton Yartsev5b5c7ce2015-02-19 13:36:20 +00001814 printExpectedAllocName(os, C, DeallocExpr);
Anton Yartsev05789592013-03-28 17:05:19 +00001815
Aaron Ballman8d3a7a52015-06-23 13:15:32 +00001816 auto R = llvm::make_unique<BugReport>(*BT_BadFree[*CheckKind], os.str(), N);
Ted Kremenek1e809b42012-03-09 01:13:14 +00001817 R->markInteresting(MR);
Anton Yartsev59ed15b2013-03-13 14:39:10 +00001818 R->addRange(Range);
Aaron Ballman8d3a7a52015-06-23 13:15:32 +00001819 C.emitReport(std::move(R));
Jordy Rose3597b212010-06-07 19:32:37 +00001820 }
1821}
1822
Ted Kremenek3a0678e2015-09-08 03:50:52 +00001823void MallocChecker::ReportFreeAlloca(CheckerContext &C, SVal ArgVal,
Anton Yartsev5b5c7ce2015-02-19 13:36:20 +00001824 SourceRange Range) const {
1825
Anton Yartsev4eb394d2015-03-07 00:31:53 +00001826 Optional<MallocChecker::CheckKind> CheckKind;
1827
1828 if (ChecksEnabled[CK_MallocChecker])
1829 CheckKind = CK_MallocChecker;
1830 else if (ChecksEnabled[CK_MismatchedDeallocatorChecker])
1831 CheckKind = CK_MismatchedDeallocatorChecker;
1832 else
Anton Yartsev5b5c7ce2015-02-19 13:36:20 +00001833 return;
1834
Devin Coughline39bd402015-09-16 22:03:05 +00001835 if (ExplodedNode *N = C.generateErrorNode()) {
Anton Yartsev5b5c7ce2015-02-19 13:36:20 +00001836 if (!BT_FreeAlloca[*CheckKind])
Artem Dergachevb6a513d2017-05-03 11:47:13 +00001837 BT_FreeAlloca[*CheckKind].reset(new BugType(
1838 CheckNames[*CheckKind], "Free alloca()", categories::MemoryError));
Anton Yartsev5b5c7ce2015-02-19 13:36:20 +00001839
Aaron Ballman8d3a7a52015-06-23 13:15:32 +00001840 auto R = llvm::make_unique<BugReport>(
1841 *BT_FreeAlloca[*CheckKind],
1842 "Memory allocated by alloca() should not be deallocated", N);
Anton Yartsev5b5c7ce2015-02-19 13:36:20 +00001843 R->markInteresting(ArgVal.getAsRegion());
1844 R->addRange(Range);
Aaron Ballman8d3a7a52015-06-23 13:15:32 +00001845 C.emitReport(std::move(R));
Anton Yartsev5b5c7ce2015-02-19 13:36:20 +00001846 }
1847}
1848
Ted Kremenek3a0678e2015-09-08 03:50:52 +00001849void MallocChecker::ReportMismatchedDealloc(CheckerContext &C,
Anton Yartseve3377fb2013-04-04 23:46:29 +00001850 SourceRange Range,
Ted Kremenek3a0678e2015-09-08 03:50:52 +00001851 const Expr *DeallocExpr,
Anton Yartsevf0593d62013-04-05 11:25:10 +00001852 const RefState *RS,
Ted Kremenek3a0678e2015-09-08 03:50:52 +00001853 SymbolRef Sym,
Anton Yartsevf5bccce2013-09-16 17:51:25 +00001854 bool OwnershipTransferred) const {
Anton Yartsev05789592013-03-28 17:05:19 +00001855
Alexander Kornienko4aca9b12014-02-11 21:49:21 +00001856 if (!ChecksEnabled[CK_MismatchedDeallocatorChecker])
Anton Yartsev05789592013-03-28 17:05:19 +00001857 return;
1858
Devin Coughline39bd402015-09-16 22:03:05 +00001859 if (ExplodedNode *N = C.generateErrorNode()) {
Anton Yartseve3377fb2013-04-04 23:46:29 +00001860 if (!BT_MismatchedDealloc)
Alexander Kornienko4aca9b12014-02-11 21:49:21 +00001861 BT_MismatchedDealloc.reset(
1862 new BugType(CheckNames[CK_MismatchedDeallocatorChecker],
Artem Dergachevb6a513d2017-05-03 11:47:13 +00001863 "Bad deallocator", categories::MemoryError));
Alexander Kornienko4aca9b12014-02-11 21:49:21 +00001864
Anton Yartsev05789592013-03-28 17:05:19 +00001865 SmallString<100> buf;
1866 llvm::raw_svector_ostream os(buf);
1867
1868 const Expr *AllocExpr = cast<Expr>(RS->getStmt());
1869 SmallString<20> AllocBuf;
1870 llvm::raw_svector_ostream AllocOs(AllocBuf);
1871 SmallString<20> DeallocBuf;
1872 llvm::raw_svector_ostream DeallocOs(DeallocBuf);
1873
Anton Yartsevf5bccce2013-09-16 17:51:25 +00001874 if (OwnershipTransferred) {
1875 if (printAllocDeallocName(DeallocOs, C, DeallocExpr))
1876 os << DeallocOs.str() << " cannot";
Ted Kremenek3a0678e2015-09-08 03:50:52 +00001877 else
Anton Yartsevf5bccce2013-09-16 17:51:25 +00001878 os << "Cannot";
Anton Yartsev05789592013-03-28 17:05:19 +00001879
Anton Yartsevf5bccce2013-09-16 17:51:25 +00001880 os << " take ownership of memory";
Anton Yartsev05789592013-03-28 17:05:19 +00001881
Anton Yartsevf5bccce2013-09-16 17:51:25 +00001882 if (printAllocDeallocName(AllocOs, C, AllocExpr))
1883 os << " allocated by " << AllocOs.str();
1884 } else {
1885 os << "Memory";
1886 if (printAllocDeallocName(AllocOs, C, AllocExpr))
1887 os << " allocated by " << AllocOs.str();
1888
1889 os << " should be deallocated by ";
1890 printExpectedDeallocName(os, RS->getAllocationFamily());
1891
1892 if (printAllocDeallocName(DeallocOs, C, DeallocExpr))
1893 os << ", not " << DeallocOs.str();
1894 }
Anton Yartsev05789592013-03-28 17:05:19 +00001895
Aaron Ballman8d3a7a52015-06-23 13:15:32 +00001896 auto R = llvm::make_unique<BugReport>(*BT_MismatchedDealloc, os.str(), N);
Anton Yartsevf0593d62013-04-05 11:25:10 +00001897 R->markInteresting(Sym);
Anton Yartsev05789592013-03-28 17:05:19 +00001898 R->addRange(Range);
David Blaikie91e79022014-09-04 23:54:33 +00001899 R->addVisitor(llvm::make_unique<MallocBugVisitor>(Sym));
Aaron Ballman8d3a7a52015-06-23 13:15:32 +00001900 C.emitReport(std::move(R));
Anton Yartsev05789592013-03-28 17:05:19 +00001901 }
1902}
1903
Anna Zaksc89ad072013-02-07 23:05:47 +00001904void MallocChecker::ReportOffsetFree(CheckerContext &C, SVal ArgVal,
Anton Yartsev05789592013-03-28 17:05:19 +00001905 SourceRange Range, const Expr *DeallocExpr,
1906 const Expr *AllocExpr) const {
1907
Anton Yartsev05789592013-03-28 17:05:19 +00001908
Anton Yartsev4eb394d2015-03-07 00:31:53 +00001909 if (!ChecksEnabled[CK_MallocChecker] &&
1910 !ChecksEnabled[CK_NewDeleteChecker])
1911 return;
1912
1913 Optional<MallocChecker::CheckKind> CheckKind =
1914 getCheckIfTracked(C, AllocExpr);
Alexander Kornienko4aca9b12014-02-11 21:49:21 +00001915 if (!CheckKind.hasValue())
Anton Yartseve3377fb2013-04-04 23:46:29 +00001916 return;
1917
Devin Coughline39bd402015-09-16 22:03:05 +00001918 ExplodedNode *N = C.generateErrorNode();
Craig Topper0dbb7832014-05-27 02:45:47 +00001919 if (!N)
Anna Zaksc89ad072013-02-07 23:05:47 +00001920 return;
1921
Alexander Kornienko4aca9b12014-02-11 21:49:21 +00001922 if (!BT_OffsetFree[*CheckKind])
Artem Dergachevb6a513d2017-05-03 11:47:13 +00001923 BT_OffsetFree[*CheckKind].reset(new BugType(
1924 CheckNames[*CheckKind], "Offset free", categories::MemoryError));
Anna Zaksc89ad072013-02-07 23:05:47 +00001925
1926 SmallString<100> buf;
1927 llvm::raw_svector_ostream os(buf);
Anton Yartsev05789592013-03-28 17:05:19 +00001928 SmallString<20> AllocNameBuf;
1929 llvm::raw_svector_ostream AllocNameOs(AllocNameBuf);
Anna Zaksc89ad072013-02-07 23:05:47 +00001930
1931 const MemRegion *MR = ArgVal.getAsRegion();
1932 assert(MR && "Only MemRegion based symbols can have offset free errors");
1933
1934 RegionOffset Offset = MR->getAsOffset();
1935 assert((Offset.isValid() &&
1936 !Offset.hasSymbolicOffset() &&
1937 Offset.getOffset() != 0) &&
1938 "Only symbols with a valid offset can have offset free errors");
1939
1940 int offsetBytes = Offset.getOffset() / C.getASTContext().getCharWidth();
1941
Anton Yartsev05789592013-03-28 17:05:19 +00001942 os << "Argument to ";
1943 if (!printAllocDeallocName(os, C, DeallocExpr))
1944 os << "deallocator";
1945 os << " is offset by "
Anna Zaksc89ad072013-02-07 23:05:47 +00001946 << offsetBytes
1947 << " "
1948 << ((abs(offsetBytes) > 1) ? "bytes" : "byte")
Anton Yartsev05789592013-03-28 17:05:19 +00001949 << " from the start of ";
1950 if (AllocExpr && printAllocDeallocName(AllocNameOs, C, AllocExpr))
1951 os << "memory allocated by " << AllocNameOs.str();
1952 else
1953 os << "allocated memory";
Anna Zaksc89ad072013-02-07 23:05:47 +00001954
Aaron Ballman8d3a7a52015-06-23 13:15:32 +00001955 auto R = llvm::make_unique<BugReport>(*BT_OffsetFree[*CheckKind], os.str(), N);
Anna Zaksc89ad072013-02-07 23:05:47 +00001956 R->markInteresting(MR->getBaseRegion());
1957 R->addRange(Range);
Aaron Ballman8d3a7a52015-06-23 13:15:32 +00001958 C.emitReport(std::move(R));
Anna Zaksc89ad072013-02-07 23:05:47 +00001959}
1960
Anton Yartsev59ed15b2013-03-13 14:39:10 +00001961void MallocChecker::ReportUseAfterFree(CheckerContext &C, SourceRange Range,
1962 SymbolRef Sym) const {
1963
Anton Yartsev4eb394d2015-03-07 00:31:53 +00001964 if (!ChecksEnabled[CK_MallocChecker] &&
Reka Kovacsd9f66ba2018-08-06 22:03:42 +00001965 !ChecksEnabled[CK_NewDeleteChecker] &&
1966 !ChecksEnabled[CK_InnerPointerChecker])
Anton Yartsev4eb394d2015-03-07 00:31:53 +00001967 return;
1968
1969 Optional<MallocChecker::CheckKind> CheckKind = getCheckIfTracked(C, Sym);
Alexander Kornienko4aca9b12014-02-11 21:49:21 +00001970 if (!CheckKind.hasValue())
Anton Yartseve3377fb2013-04-04 23:46:29 +00001971 return;
1972
Devin Coughline39bd402015-09-16 22:03:05 +00001973 if (ExplodedNode *N = C.generateErrorNode()) {
Alexander Kornienko4aca9b12014-02-11 21:49:21 +00001974 if (!BT_UseFree[*CheckKind])
1975 BT_UseFree[*CheckKind].reset(new BugType(
Artem Dergachevb6a513d2017-05-03 11:47:13 +00001976 CheckNames[*CheckKind], "Use-after-free", categories::MemoryError));
Anton Yartsev59ed15b2013-03-13 14:39:10 +00001977
Reka Kovacsbb2749a2018-08-10 23:56:57 +00001978 AllocationFamily AF =
1979 C.getState()->get<RegionState>(Sym)->getAllocationFamily();
1980
Aaron Ballman8d3a7a52015-06-23 13:15:32 +00001981 auto R = llvm::make_unique<BugReport>(*BT_UseFree[*CheckKind],
Reka Kovacsbb2749a2018-08-10 23:56:57 +00001982 AF == AF_InnerBuffer
1983 ? "Inner pointer of container used after re/deallocation"
1984 : "Use of memory after it is freed",
1985 N);
Anton Yartsev59ed15b2013-03-13 14:39:10 +00001986
1987 R->markInteresting(Sym);
1988 R->addRange(Range);
David Blaikie91e79022014-09-04 23:54:33 +00001989 R->addVisitor(llvm::make_unique<MallocBugVisitor>(Sym));
Reka Kovacse453e602018-07-07 19:27:18 +00001990
Reka Kovacsbb2749a2018-08-10 23:56:57 +00001991 if (AF == AF_InnerBuffer)
Reka Kovacs88ad7042018-07-20 15:14:49 +00001992 R->addVisitor(allocation_state::getInnerPointerBRVisitor(Sym));
Reka Kovacse453e602018-07-07 19:27:18 +00001993
Aaron Ballman8d3a7a52015-06-23 13:15:32 +00001994 C.emitReport(std::move(R));
Anton Yartsev59ed15b2013-03-13 14:39:10 +00001995 }
1996}
1997
1998void MallocChecker::ReportDoubleFree(CheckerContext &C, SourceRange Range,
Ted Kremenek3a0678e2015-09-08 03:50:52 +00001999 bool Released, SymbolRef Sym,
Anton Yartsev6c2af432013-03-13 17:07:32 +00002000 SymbolRef PrevSym) const {
Anton Yartsev59ed15b2013-03-13 14:39:10 +00002001
Anton Yartsev4eb394d2015-03-07 00:31:53 +00002002 if (!ChecksEnabled[CK_MallocChecker] &&
2003 !ChecksEnabled[CK_NewDeleteChecker])
2004 return;
2005
2006 Optional<MallocChecker::CheckKind> CheckKind = getCheckIfTracked(C, Sym);
Alexander Kornienko4aca9b12014-02-11 21:49:21 +00002007 if (!CheckKind.hasValue())
Anton Yartseve3377fb2013-04-04 23:46:29 +00002008 return;
2009
Devin Coughline39bd402015-09-16 22:03:05 +00002010 if (ExplodedNode *N = C.generateErrorNode()) {
Alexander Kornienko4aca9b12014-02-11 21:49:21 +00002011 if (!BT_DoubleFree[*CheckKind])
Artem Dergachevb6a513d2017-05-03 11:47:13 +00002012 BT_DoubleFree[*CheckKind].reset(new BugType(
2013 CheckNames[*CheckKind], "Double free", categories::MemoryError));
Anton Yartsev59ed15b2013-03-13 14:39:10 +00002014
Aaron Ballman8d3a7a52015-06-23 13:15:32 +00002015 auto R = llvm::make_unique<BugReport>(
2016 *BT_DoubleFree[*CheckKind],
2017 (Released ? "Attempt to free released memory"
2018 : "Attempt to free non-owned memory"),
2019 N);
Anton Yartsev59ed15b2013-03-13 14:39:10 +00002020 R->addRange(Range);
Anton Yartsev6c2af432013-03-13 17:07:32 +00002021 R->markInteresting(Sym);
2022 if (PrevSym)
2023 R->markInteresting(PrevSym);
David Blaikie91e79022014-09-04 23:54:33 +00002024 R->addVisitor(llvm::make_unique<MallocBugVisitor>(Sym));
Aaron Ballman8d3a7a52015-06-23 13:15:32 +00002025 C.emitReport(std::move(R));
Anton Yartsev59ed15b2013-03-13 14:39:10 +00002026 }
2027}
2028
Jordan Rose656fdd52014-01-08 18:46:55 +00002029void MallocChecker::ReportDoubleDelete(CheckerContext &C, SymbolRef Sym) const {
2030
Anton Yartsev4eb394d2015-03-07 00:31:53 +00002031 if (!ChecksEnabled[CK_NewDeleteChecker])
2032 return;
2033
2034 Optional<MallocChecker::CheckKind> CheckKind = getCheckIfTracked(C, Sym);
Alexander Kornienko4aca9b12014-02-11 21:49:21 +00002035 if (!CheckKind.hasValue())
Jordan Rose656fdd52014-01-08 18:46:55 +00002036 return;
2037
Devin Coughline39bd402015-09-16 22:03:05 +00002038 if (ExplodedNode *N = C.generateErrorNode()) {
Jordan Rose656fdd52014-01-08 18:46:55 +00002039 if (!BT_DoubleDelete)
Alexander Kornienko4aca9b12014-02-11 21:49:21 +00002040 BT_DoubleDelete.reset(new BugType(CheckNames[CK_NewDeleteChecker],
Artem Dergachevb6a513d2017-05-03 11:47:13 +00002041 "Double delete",
2042 categories::MemoryError));
Jordan Rose656fdd52014-01-08 18:46:55 +00002043
Aaron Ballman8d3a7a52015-06-23 13:15:32 +00002044 auto R = llvm::make_unique<BugReport>(
2045 *BT_DoubleDelete, "Attempt to delete released memory", N);
Jordan Rose656fdd52014-01-08 18:46:55 +00002046
2047 R->markInteresting(Sym);
David Blaikie91e79022014-09-04 23:54:33 +00002048 R->addVisitor(llvm::make_unique<MallocBugVisitor>(Sym));
Aaron Ballman8d3a7a52015-06-23 13:15:32 +00002049 C.emitReport(std::move(R));
Jordan Rose656fdd52014-01-08 18:46:55 +00002050 }
2051}
2052
Anton Yartsevb50f4ba2015-04-14 14:18:04 +00002053void MallocChecker::ReportUseZeroAllocated(CheckerContext &C,
2054 SourceRange Range,
2055 SymbolRef Sym) const {
2056
2057 if (!ChecksEnabled[CK_MallocChecker] &&
2058 !ChecksEnabled[CK_NewDeleteChecker])
2059 return;
2060
2061 Optional<MallocChecker::CheckKind> CheckKind = getCheckIfTracked(C, Sym);
2062
2063 if (!CheckKind.hasValue())
2064 return;
2065
Devin Coughline39bd402015-09-16 22:03:05 +00002066 if (ExplodedNode *N = C.generateErrorNode()) {
Anton Yartsevb50f4ba2015-04-14 14:18:04 +00002067 if (!BT_UseZerroAllocated[*CheckKind])
Artem Dergachevb6a513d2017-05-03 11:47:13 +00002068 BT_UseZerroAllocated[*CheckKind].reset(
2069 new BugType(CheckNames[*CheckKind], "Use of zero allocated",
2070 categories::MemoryError));
Anton Yartsevb50f4ba2015-04-14 14:18:04 +00002071
Aaron Ballman8d3a7a52015-06-23 13:15:32 +00002072 auto R = llvm::make_unique<BugReport>(*BT_UseZerroAllocated[*CheckKind],
2073 "Use of zero-allocated memory", N);
Anton Yartsevb50f4ba2015-04-14 14:18:04 +00002074
2075 R->addRange(Range);
2076 if (Sym) {
2077 R->markInteresting(Sym);
2078 R->addVisitor(llvm::make_unique<MallocBugVisitor>(Sym));
2079 }
Aaron Ballman8d3a7a52015-06-23 13:15:32 +00002080 C.emitReport(std::move(R));
Anton Yartsevb50f4ba2015-04-14 14:18:04 +00002081 }
2082}
2083
Daniel Marjamakia43a8f52017-05-02 11:46:12 +00002084void MallocChecker::ReportFunctionPointerFree(CheckerContext &C, SVal ArgVal,
2085 SourceRange Range,
2086 const Expr *FreeExpr) const {
2087 if (!ChecksEnabled[CK_MallocChecker])
2088 return;
2089
2090 Optional<MallocChecker::CheckKind> CheckKind = getCheckIfTracked(C, FreeExpr);
2091 if (!CheckKind.hasValue())
2092 return;
2093
2094 if (ExplodedNode *N = C.generateErrorNode()) {
2095 if (!BT_BadFree[*CheckKind])
Artem Dergachev9849f592018-02-08 23:28:29 +00002096 BT_BadFree[*CheckKind].reset(new BugType(
2097 CheckNames[*CheckKind], "Bad free", categories::MemoryError));
Daniel Marjamakia43a8f52017-05-02 11:46:12 +00002098
2099 SmallString<100> Buf;
2100 llvm::raw_svector_ostream Os(Buf);
2101
2102 const MemRegion *MR = ArgVal.getAsRegion();
2103 while (const ElementRegion *ER = dyn_cast_or_null<ElementRegion>(MR))
2104 MR = ER->getSuperRegion();
2105
2106 Os << "Argument to ";
2107 if (!printAllocDeallocName(Os, C, FreeExpr))
2108 Os << "deallocator";
2109
2110 Os << " is a function pointer";
2111
2112 auto R = llvm::make_unique<BugReport>(*BT_BadFree[*CheckKind], Os.str(), N);
2113 R->markInteresting(MR);
2114 R->addRange(Range);
2115 C.emitReport(std::move(R));
2116 }
2117}
2118
Leslie Zhaie3986c52017-04-26 05:33:14 +00002119ProgramStateRef MallocChecker::ReallocMemAux(CheckerContext &C,
2120 const CallExpr *CE,
2121 bool FreesOnFail,
Daniel Marjamakia43a8f52017-05-02 11:46:12 +00002122 ProgramStateRef State,
Leslie Zhaie3986c52017-04-26 05:33:14 +00002123 bool SuffixWithN) const {
Anton Yartsevb3fa86d2015-02-10 20:13:08 +00002124 if (!State)
2125 return nullptr;
2126
Leslie Zhaie3986c52017-04-26 05:33:14 +00002127 if (SuffixWithN && CE->getNumArgs() < 3)
2128 return nullptr;
2129 else if (CE->getNumArgs() < 2)
Craig Topper0dbb7832014-05-27 02:45:47 +00002130 return nullptr;
Anna Zaksb508d292012-04-10 23:41:11 +00002131
Ted Kremenek90af9092010-12-02 07:49:45 +00002132 const Expr *arg0Expr = CE->getArg(0);
George Karpenkovd703ec92018-01-17 20:27:29 +00002133 SVal Arg0Val = C.getSVal(arg0Expr);
David Blaikie2fdacbc2013-02-20 05:52:05 +00002134 if (!Arg0Val.getAs<DefinedOrUnknownSVal>())
Craig Topper0dbb7832014-05-27 02:45:47 +00002135 return nullptr;
David Blaikie2fdacbc2013-02-20 05:52:05 +00002136 DefinedOrUnknownSVal arg0Val = Arg0Val.castAs<DefinedOrUnknownSVal>();
Zhongxing Xuc0484fa2009-12-12 12:29:38 +00002137
Ted Kremenek9d0bb1e2010-12-01 21:28:31 +00002138 SValBuilder &svalBuilder = C.getSValBuilder();
Zhongxing Xuc0484fa2009-12-12 12:29:38 +00002139
Ted Kremenek90af9092010-12-02 07:49:45 +00002140 DefinedOrUnknownSVal PtrEQ =
Anton Yartsevb3fa86d2015-02-10 20:13:08 +00002141 svalBuilder.evalEQ(State, arg0Val, svalBuilder.makeNull());
Zhongxing Xuc0484fa2009-12-12 12:29:38 +00002142
Leslie Zhaie3986c52017-04-26 05:33:14 +00002143 // Get the size argument.
Lenny Maiorani005b5c12011-04-27 14:49:29 +00002144 const Expr *Arg1 = CE->getArg(1);
Lenny Maiorani005b5c12011-04-27 14:49:29 +00002145
2146 // Get the value of the size argument.
George Karpenkovd703ec92018-01-17 20:27:29 +00002147 SVal TotalSize = C.getSVal(Arg1);
Leslie Zhaie3986c52017-04-26 05:33:14 +00002148 if (SuffixWithN)
2149 TotalSize = evalMulForBufferSize(C, Arg1, CE->getArg(2));
2150 if (!TotalSize.getAs<DefinedOrUnknownSVal>())
Craig Topper0dbb7832014-05-27 02:45:47 +00002151 return nullptr;
Lenny Maiorani005b5c12011-04-27 14:49:29 +00002152
2153 // Compare the size argument to 0.
2154 DefinedOrUnknownSVal SizeZero =
Leslie Zhaie3986c52017-04-26 05:33:14 +00002155 svalBuilder.evalEQ(State, TotalSize.castAs<DefinedOrUnknownSVal>(),
Lenny Maiorani005b5c12011-04-27 14:49:29 +00002156 svalBuilder.makeIntValWithPtrWidth(0, false));
2157
Anna Zaksd56c8792012-02-13 18:05:39 +00002158 ProgramStateRef StatePtrIsNull, StatePtrNotNull;
Anton Yartsevb3fa86d2015-02-10 20:13:08 +00002159 std::tie(StatePtrIsNull, StatePtrNotNull) = State->assume(PtrEQ);
Anna Zaksd56c8792012-02-13 18:05:39 +00002160 ProgramStateRef StateSizeIsZero, StateSizeNotZero;
Anton Yartsevb3fa86d2015-02-10 20:13:08 +00002161 std::tie(StateSizeIsZero, StateSizeNotZero) = State->assume(SizeZero);
Anna Zaksd56c8792012-02-13 18:05:39 +00002162 // We only assume exceptional states if they are definitely true; if the
2163 // state is under-constrained, assume regular realloc behavior.
2164 bool PrtIsNull = StatePtrIsNull && !StatePtrNotNull;
2165 bool SizeIsZero = StateSizeIsZero && !StateSizeNotZero;
2166
Ted Kremenek3a0678e2015-09-08 03:50:52 +00002167 // If the ptr is NULL and the size is not 0, the call is equivalent to
Lenny Maiorani005b5c12011-04-27 14:49:29 +00002168 // malloc(size).
Leslie Zhaie3986c52017-04-26 05:33:14 +00002169 if (PrtIsNull && !SizeIsZero) {
2170 ProgramStateRef stateMalloc = MallocMemAux(C, CE, TotalSize,
Anna Zaksd56c8792012-02-13 18:05:39 +00002171 UndefinedVal(), StatePtrIsNull);
Anna Zaks40a7eb32012-02-22 19:24:52 +00002172 return stateMalloc;
Zhongxing Xuc0484fa2009-12-12 12:29:38 +00002173 }
2174
Anna Zaksd56c8792012-02-13 18:05:39 +00002175 if (PrtIsNull && SizeIsZero)
Devin Coughlin81771732015-09-22 22:47:14 +00002176 return State;
Zhongxing Xuc0484fa2009-12-12 12:29:38 +00002177
Anna Zaks8fd0f2a2012-02-13 20:57:07 +00002178 // Get the from and to pointer symbols as in toPtr = realloc(fromPtr, size).
Anna Zaksd56c8792012-02-13 18:05:39 +00002179 assert(!PrtIsNull);
Anna Zaks8fd0f2a2012-02-13 20:57:07 +00002180 SymbolRef FromPtr = arg0Val.getAsSymbol();
George Karpenkovd703ec92018-01-17 20:27:29 +00002181 SVal RetVal = C.getSVal(CE);
Anna Zaks8fd0f2a2012-02-13 20:57:07 +00002182 SymbolRef ToPtr = RetVal.getAsSymbol();
2183 if (!FromPtr || !ToPtr)
Craig Topper0dbb7832014-05-27 02:45:47 +00002184 return nullptr;
Anna Zaksd56c8792012-02-13 18:05:39 +00002185
Anna Zaksfe6eb672012-08-24 02:28:20 +00002186 bool ReleasedAllocated = false;
2187
Anna Zaksd56c8792012-02-13 18:05:39 +00002188 // If the size is 0, free the memory.
2189 if (SizeIsZero)
Anna Zaksfe6eb672012-08-24 02:28:20 +00002190 if (ProgramStateRef stateFree = FreeMemAux(C, CE, StateSizeIsZero, 0,
2191 false, ReleasedAllocated)){
Anna Zaksd56c8792012-02-13 18:05:39 +00002192 // The semantics of the return value are:
2193 // If size was equal to 0, either NULL or a pointer suitable to be passed
Anna Zaks52242a62012-08-03 18:30:18 +00002194 // to free() is returned. We just free the input pointer and do not add
2195 // any constrains on the output pointer.
Anna Zaks40a7eb32012-02-22 19:24:52 +00002196 return stateFree;
Anna Zaksd56c8792012-02-13 18:05:39 +00002197 }
2198
2199 // Default behavior.
Anna Zaksfe6eb672012-08-24 02:28:20 +00002200 if (ProgramStateRef stateFree =
Anton Yartsevb3fa86d2015-02-10 20:13:08 +00002201 FreeMemAux(C, CE, State, 0, false, ReleasedAllocated)) {
Anna Zaksfe6eb672012-08-24 02:28:20 +00002202
Leslie Zhaie3986c52017-04-26 05:33:14 +00002203 ProgramStateRef stateRealloc = MallocMemAux(C, CE, TotalSize,
Anna Zaksd56c8792012-02-13 18:05:39 +00002204 UnknownVal(), stateFree);
Anna Zaks8fd0f2a2012-02-13 20:57:07 +00002205 if (!stateRealloc)
Craig Topper0dbb7832014-05-27 02:45:47 +00002206 return nullptr;
Anna Zaksfe6eb672012-08-24 02:28:20 +00002207
Anna Zaks75cfbb62012-09-12 22:57:34 +00002208 ReallocPairKind Kind = RPToBeFreedAfterFailure;
2209 if (FreesOnFail)
2210 Kind = RPIsFreeOnFailure;
2211 else if (!ReleasedAllocated)
2212 Kind = RPDoNotTrackAfterFailure;
2213
Anna Zaksfe6eb672012-08-24 02:28:20 +00002214 // Record the info about the reallocated symbol so that we could properly
2215 // process failed reallocation.
Anna Zaksac068142012-02-15 00:11:25 +00002216 stateRealloc = stateRealloc->set<ReallocPairs>(ToPtr,
Anna Zaks75cfbb62012-09-12 22:57:34 +00002217 ReallocPair(FromPtr, Kind));
Anna Zaksfe6eb672012-08-24 02:28:20 +00002218 // The reallocated symbol should stay alive for as long as the new symbol.
Anna Zaksad01ef52012-02-14 00:26:13 +00002219 C.getSymbolManager().addSymbolDependency(ToPtr, FromPtr);
Anna Zaks40a7eb32012-02-22 19:24:52 +00002220 return stateRealloc;
Zhongxing Xuc0484fa2009-12-12 12:29:38 +00002221 }
Craig Topper0dbb7832014-05-27 02:45:47 +00002222 return nullptr;
Zhongxing Xu88cca6b2009-11-12 08:38:56 +00002223}
Zhongxing Xuc4902a52009-11-13 07:25:27 +00002224
Ted Kremenek3a0678e2015-09-08 03:50:52 +00002225ProgramStateRef MallocChecker::CallocMem(CheckerContext &C, const CallExpr *CE,
Anton Yartsevb3fa86d2015-02-10 20:13:08 +00002226 ProgramStateRef State) {
2227 if (!State)
2228 return nullptr;
2229
Anna Zaksb508d292012-04-10 23:41:11 +00002230 if (CE->getNumArgs() < 2)
Craig Topper0dbb7832014-05-27 02:45:47 +00002231 return nullptr;
Anna Zaksb508d292012-04-10 23:41:11 +00002232
Ted Kremenek9d0bb1e2010-12-01 21:28:31 +00002233 SValBuilder &svalBuilder = C.getSValBuilder();
Ted Kremenek90af9092010-12-02 07:49:45 +00002234 SVal zeroVal = svalBuilder.makeZeroVal(svalBuilder.getContext().CharTy);
Leslie Zhaie3986c52017-04-26 05:33:14 +00002235 SVal TotalSize = evalMulForBufferSize(C, CE->getArg(0), CE->getArg(1));
Zhongxing Xu527ff6d2010-06-01 03:01:33 +00002236
Anton Yartsevb3fa86d2015-02-10 20:13:08 +00002237 return MallocMemAux(C, CE, TotalSize, zeroVal, State);
Zhongxing Xu527ff6d2010-06-01 03:01:33 +00002238}
2239
Anna Zaksfc2e1532012-03-21 19:45:08 +00002240LeakInfo
Anna Zaksdf901a42012-02-23 21:38:21 +00002241MallocChecker::getAllocationSite(const ExplodedNode *N, SymbolRef Sym,
2242 CheckerContext &C) const {
Anna Zaks43ffba22012-02-27 23:40:55 +00002243 const LocationContext *LeakContext = N->getLocationContext();
Anna Zaksdf901a42012-02-23 21:38:21 +00002244 // Walk the ExplodedGraph backwards and find the first node that referred to
2245 // the tracked symbol.
2246 const ExplodedNode *AllocNode = N;
Craig Topper0dbb7832014-05-27 02:45:47 +00002247 const MemRegion *ReferenceRegion = nullptr;
Anna Zaksdf901a42012-02-23 21:38:21 +00002248
2249 while (N) {
Anna Zaksfc2e1532012-03-21 19:45:08 +00002250 ProgramStateRef State = N->getState();
2251 if (!State->get<RegionState>(Sym))
Anna Zaksdf901a42012-02-23 21:38:21 +00002252 break;
Anna Zaksfc2e1532012-03-21 19:45:08 +00002253
2254 // Find the most recent expression bound to the symbol in the current
2255 // context.
Anna Zaks7c19abe2013-04-10 21:42:02 +00002256 if (!ReferenceRegion) {
2257 if (const MemRegion *MR = C.getLocationRegionIfPostStore(N)) {
2258 SVal Val = State->getSVal(MR);
2259 if (Val.getAsLocSymbol() == Sym) {
Anna Zaks07804ef2013-04-10 22:56:33 +00002260 const VarRegion* VR = MR->getBaseRegion()->getAs<VarRegion>();
Anna Zaks7c19abe2013-04-10 21:42:02 +00002261 // Do not show local variables belonging to a function other than
2262 // where the error is reported.
2263 if (!VR ||
George Karpenkovdd18b112018-06-27 01:51:55 +00002264 (VR->getStackFrame() == LeakContext->getStackFrame()))
Anna Zaks7c19abe2013-04-10 21:42:02 +00002265 ReferenceRegion = MR;
2266 }
2267 }
Benjamin Kramerc25c5e02012-03-21 21:03:48 +00002268 }
Anna Zaksfc2e1532012-03-21 19:45:08 +00002269
Anna Zaks486a0ff2015-02-05 01:02:53 +00002270 // Allocation node, is the last node in the current or parent context in
2271 // which the symbol was tracked.
2272 const LocationContext *NContext = N->getLocationContext();
2273 if (NContext == LeakContext ||
2274 NContext->isParentOf(LeakContext))
Anna Zaks43ffba22012-02-27 23:40:55 +00002275 AllocNode = N;
Craig Topper0dbb7832014-05-27 02:45:47 +00002276 N = N->pred_empty() ? nullptr : *(N->pred_begin());
Anna Zaksdf901a42012-02-23 21:38:21 +00002277 }
2278
Anna Zaksa043d0c2013-01-08 00:25:29 +00002279 return LeakInfo(AllocNode, ReferenceRegion);
Anna Zaksdf901a42012-02-23 21:38:21 +00002280}
2281
Anna Zaksd3571e5a2012-02-11 21:02:40 +00002282void MallocChecker::reportLeak(SymbolRef Sym, ExplodedNode *N,
2283 CheckerContext &C) const {
Anton Yartsev05789592013-03-28 17:05:19 +00002284
Anton Yartsev4eb394d2015-03-07 00:31:53 +00002285 if (!ChecksEnabled[CK_MallocChecker] &&
2286 !ChecksEnabled[CK_NewDeleteLeaksChecker])
Anton Yartsev6e499252013-04-05 02:25:02 +00002287 return;
2288
Anton Yartsev9907fc92015-03-04 23:18:21 +00002289 const RefState *RS = C.getState()->get<RegionState>(Sym);
Anton Yartsev4eb394d2015-03-07 00:31:53 +00002290 assert(RS && "cannot leak an untracked symbol");
2291 AllocationFamily Family = RS->getAllocationFamily();
Anton Yartsev2487dd62015-03-10 22:24:21 +00002292
2293 if (Family == AF_Alloca)
Anton Yartsev4eb394d2015-03-07 00:31:53 +00002294 return;
2295
Anton Yartsev2487dd62015-03-10 22:24:21 +00002296 Optional<MallocChecker::CheckKind>
2297 CheckKind = getCheckIfTracked(Family, true);
Anton Yartsev4eb394d2015-03-07 00:31:53 +00002298
Anton Yartsev2487dd62015-03-10 22:24:21 +00002299 if (!CheckKind.hasValue())
Anton Yartsev9907fc92015-03-04 23:18:21 +00002300 return;
2301
Anna Zaksd3571e5a2012-02-11 21:02:40 +00002302 assert(N);
Alexander Kornienko4aca9b12014-02-11 21:49:21 +00002303 if (!BT_Leak[*CheckKind]) {
Artem Dergachevb6a513d2017-05-03 11:47:13 +00002304 BT_Leak[*CheckKind].reset(new BugType(CheckNames[*CheckKind], "Memory leak",
2305 categories::MemoryError));
Anna Zaksd3571e5a2012-02-11 21:02:40 +00002306 // Leaks should not be reported if they are post-dominated by a sink:
2307 // (1) Sinks are higher importance bugs.
2308 // (2) NoReturnFunctionChecker uses sink nodes to represent paths ending
2309 // with __noreturn functions such as assert() or exit(). We choose not
2310 // to report leaks on such paths.
Alexander Kornienko4aca9b12014-02-11 21:49:21 +00002311 BT_Leak[*CheckKind]->setSuppressOnSink(true);
Anna Zaksd3571e5a2012-02-11 21:02:40 +00002312 }
2313
Anna Zaksdf901a42012-02-23 21:38:21 +00002314 // Most bug reports are cached at the location where they occurred.
2315 // With leaks, we want to unique them by the location where they were
2316 // allocated, and only report a single path.
Anna Zaks43ffba22012-02-27 23:40:55 +00002317 PathDiagnosticLocation LocUsedForUniqueing;
Craig Topper0dbb7832014-05-27 02:45:47 +00002318 const ExplodedNode *AllocNode = nullptr;
2319 const MemRegion *Region = nullptr;
Benjamin Kramer867ea1d2014-03-02 13:01:17 +00002320 std::tie(AllocNode, Region) = getAllocationSite(N, Sym, C);
Ted Kremenek3a0678e2015-09-08 03:50:52 +00002321
Gabor Horvath6ee4f902016-08-18 07:54:50 +00002322 const Stmt *AllocationStmt = PathDiagnosticLocation::getStmt(AllocNode);
Anton Yartsev6e499252013-04-05 02:25:02 +00002323 if (AllocationStmt)
Anna Zaksa043d0c2013-01-08 00:25:29 +00002324 LocUsedForUniqueing = PathDiagnosticLocation::createBegin(AllocationStmt,
2325 C.getSourceManager(),
2326 AllocNode->getLocationContext());
Anna Zaksdf901a42012-02-23 21:38:21 +00002327
Anna Zaksfc2e1532012-03-21 19:45:08 +00002328 SmallString<200> buf;
2329 llvm::raw_svector_ostream os(buf);
Jordan Rosed86b3bd2012-08-08 18:23:36 +00002330 if (Region && Region->canPrintPretty()) {
Anna Zaks6cea7d92013-04-12 18:40:21 +00002331 os << "Potential leak of memory pointed to by ";
Jordan Rosed86b3bd2012-08-08 18:23:36 +00002332 Region->printPretty(os);
Anna Zaksa1de8562013-04-06 00:41:36 +00002333 } else {
2334 os << "Potential memory leak";
Anna Zaksfc2e1532012-03-21 19:45:08 +00002335 }
2336
Aaron Ballman8d3a7a52015-06-23 13:15:32 +00002337 auto R = llvm::make_unique<BugReport>(
2338 *BT_Leak[*CheckKind], os.str(), N, LocUsedForUniqueing,
2339 AllocNode->getLocationContext()->getDecl());
Ted Kremenek1e809b42012-03-09 01:13:14 +00002340 R->markInteresting(Sym);
David Blaikie91e79022014-09-04 23:54:33 +00002341 R->addVisitor(llvm::make_unique<MallocBugVisitor>(Sym, true));
Aaron Ballman8d3a7a52015-06-23 13:15:32 +00002342 C.emitReport(std::move(R));
Anna Zaksd3571e5a2012-02-11 21:02:40 +00002343}
2344
Argyrios Kyrtzidis183f0fb2011-02-28 01:26:35 +00002345void MallocChecker::checkDeadSymbols(SymbolReaper &SymReaper,
2346 CheckerContext &C) const
Ted Kremenek90af9092010-12-02 07:49:45 +00002347{
Zhongxing Xubce831f2010-08-15 08:19:57 +00002348 if (!SymReaper.hasDeadSymbols())
2349 return;
Zhongxing Xuc7460962009-11-13 07:48:11 +00002350
Ted Kremenek49b1e382012-01-26 21:29:00 +00002351 ProgramStateRef state = C.getState();
Zhongxing Xubce831f2010-08-15 08:19:57 +00002352 RegionStateTy RS = state->get<RegionState>();
Jordy Rose82584992010-08-18 04:33:47 +00002353 RegionStateTy::Factory &F = state->get_context<RegionState>();
Zhongxing Xubce831f2010-08-15 08:19:57 +00002354
Dmitri Gribenkof8579502013-01-12 19:30:44 +00002355 SmallVector<SymbolRef, 2> Errors;
Zhongxing Xubce831f2010-08-15 08:19:57 +00002356 for (RegionStateTy::iterator I = RS.begin(), E = RS.end(); I != E; ++I) {
2357 if (SymReaper.isDead(I->first)) {
Anton Yartsevb50f4ba2015-04-14 14:18:04 +00002358 if (I->second.isAllocated() || I->second.isAllocatedOfSizeZero())
Anna Zaks78edc2f2012-02-09 06:48:19 +00002359 Errors.push_back(I->first);
Jordy Rose82584992010-08-18 04:33:47 +00002360 // Remove the dead symbol from the map.
Ted Kremenekb3b56c62010-11-24 00:54:37 +00002361 RS = F.remove(RS, I->first);
Ted Kremeneke227f492011-07-28 23:07:51 +00002362
Zhongxing Xuc7460962009-11-13 07:48:11 +00002363 }
2364 }
Ted Kremenek3a0678e2015-09-08 03:50:52 +00002365
Anna Zaksd56c8792012-02-13 18:05:39 +00002366 // Cleanup the Realloc Pairs Map.
Jordan Rose0c153cb2012-11-02 01:54:06 +00002367 ReallocPairsTy RP = state->get<ReallocPairs>();
2368 for (ReallocPairsTy::iterator I = RP.begin(), E = RP.end(); I != E; ++I) {
Anna Zaksac068142012-02-15 00:11:25 +00002369 if (SymReaper.isDead(I->first) ||
2370 SymReaper.isDead(I->second.ReallocatedSym)) {
Anna Zaksd56c8792012-02-13 18:05:39 +00002371 state = state->remove<ReallocPairs>(I->first);
2372 }
2373 }
2374
Anna Zaks67291b92012-11-13 03:18:01 +00002375 // Cleanup the FreeReturnValue Map.
2376 FreeReturnValueTy FR = state->get<FreeReturnValue>();
2377 for (FreeReturnValueTy::iterator I = FR.begin(), E = FR.end(); I != E; ++I) {
2378 if (SymReaper.isDead(I->first) ||
2379 SymReaper.isDead(I->second)) {
2380 state = state->remove<FreeReturnValue>(I->first);
2381 }
2382 }
2383
Anna Zaksdf901a42012-02-23 21:38:21 +00002384 // Generate leak node.
Anna Zaks58a2c4e2012-10-29 22:51:54 +00002385 ExplodedNode *N = C.getPredecessor();
2386 if (!Errors.empty()) {
Anton Yartsev6a619222014-02-17 18:25:34 +00002387 static CheckerProgramPointTag Tag("MallocChecker", "DeadSymbolsLeak");
Devin Coughline39bd402015-09-16 22:03:05 +00002388 N = C.generateNonFatalErrorNode(C.getState(), &Tag);
2389 if (N) {
2390 for (SmallVectorImpl<SymbolRef>::iterator
Craig Topper2341c0d2013-07-04 03:08:24 +00002391 I = Errors.begin(), E = Errors.end(); I != E; ++I) {
Devin Coughline39bd402015-09-16 22:03:05 +00002392 reportLeak(*I, N, C);
2393 }
Anna Zaks78edc2f2012-02-09 06:48:19 +00002394 }
Ted Kremeneke227f492011-07-28 23:07:51 +00002395 }
Anna Zaks58a2c4e2012-10-29 22:51:54 +00002396
Anna Zaksdf901a42012-02-23 21:38:21 +00002397 C.addTransition(state->set<RegionState>(RS), N);
Zhongxing Xuc4902a52009-11-13 07:25:27 +00002398}
Zhongxing Xu4668c7e2009-11-17 07:54:15 +00002399
Anton Yartsevcb2ccd62013-04-10 22:21:41 +00002400void MallocChecker::checkPreCall(const CallEvent &Call,
2401 CheckerContext &C) const {
2402
Jordan Rose656fdd52014-01-08 18:46:55 +00002403 if (const CXXDestructorCall *DC = dyn_cast<CXXDestructorCall>(&Call)) {
2404 SymbolRef Sym = DC->getCXXThisVal().getAsSymbol();
2405 if (!Sym || checkDoubleDelete(Sym, C))
2406 return;
2407 }
2408
Anna Zaks46d01602012-05-18 01:16:10 +00002409 // We will check for double free in the post visit.
Anton Yartsevcb2ccd62013-04-10 22:21:41 +00002410 if (const AnyFunctionCall *FC = dyn_cast<AnyFunctionCall>(&Call)) {
2411 const FunctionDecl *FD = FC->getDecl();
2412 if (!FD)
2413 return;
Anton Yartsev13df0362013-03-25 01:35:45 +00002414
Anna Zaksd79b8402014-10-03 21:48:59 +00002415 ASTContext &Ctx = C.getASTContext();
Gabor Horvathe40c71c2015-03-04 17:59:34 +00002416 if (ChecksEnabled[CK_MallocChecker] &&
Anna Zaksd79b8402014-10-03 21:48:59 +00002417 (isCMemFunction(FD, Ctx, AF_Malloc, MemoryOperationKind::MOK_Free) ||
2418 isCMemFunction(FD, Ctx, AF_IfNameIndex,
2419 MemoryOperationKind::MOK_Free)))
Anton Yartsevcb2ccd62013-04-10 22:21:41 +00002420 return;
Anton Yartsevcb2ccd62013-04-10 22:21:41 +00002421 }
2422
2423 // Check if the callee of a method is deleted.
2424 if (const CXXInstanceCall *CC = dyn_cast<CXXInstanceCall>(&Call)) {
2425 SymbolRef Sym = CC->getCXXThisVal().getAsSymbol();
2426 if (!Sym || checkUseAfterFree(Sym, C, CC->getCXXThisExpr()))
2427 return;
2428 }
2429
2430 // Check arguments for being used after free.
2431 for (unsigned I = 0, E = Call.getNumArgs(); I != E; ++I) {
2432 SVal ArgSVal = Call.getArgSVal(I);
2433 if (ArgSVal.getAs<Loc>()) {
2434 SymbolRef Sym = ArgSVal.getAsSymbol();
Anna Zaks3d348342012-02-14 21:55:24 +00002435 if (!Sym)
2436 continue;
Anton Yartsevcb2ccd62013-04-10 22:21:41 +00002437 if (checkUseAfterFree(Sym, C, Call.getArgExpr(I)))
Anna Zaks3d348342012-02-14 21:55:24 +00002438 return;
2439 }
2440 }
2441}
2442
Reka Kovacs122171e2018-08-02 23:02:08 +00002443void MallocChecker::checkPreStmt(const ReturnStmt *S,
2444 CheckerContext &C) const {
2445 checkEscapeOnReturn(S, C);
2446}
2447
2448// In the CFG, automatic destructors come after the return statement.
2449// This callback checks for returning memory that is freed by automatic
2450// destructors, as those cannot be reached in checkPreStmt().
2451void MallocChecker::checkEndFunction(const ReturnStmt *S,
2452 CheckerContext &C) const {
2453 checkEscapeOnReturn(S, C);
2454}
2455
2456void MallocChecker::checkEscapeOnReturn(const ReturnStmt *S,
2457 CheckerContext &C) const {
2458 if (!S)
2459 return;
2460
Anna Zaksa1b227b2012-02-08 23:16:56 +00002461 const Expr *E = S->getRetValue();
2462 if (!E)
2463 return;
Anna Zaks3aa52252012-02-11 21:44:39 +00002464
2465 // Check if we are returning a symbol.
Jordan Rose356279c2012-08-08 18:23:31 +00002466 ProgramStateRef State = C.getState();
George Karpenkovd703ec92018-01-17 20:27:29 +00002467 SVal RetVal = C.getSVal(E);
Anna Zaks4ca45b12012-02-22 02:36:01 +00002468 SymbolRef Sym = RetVal.getAsSymbol();
2469 if (!Sym)
2470 // If we are returning a field of the allocated struct or an array element,
2471 // the callee could still free the memory.
2472 // TODO: This logic should be a part of generic symbol escape callback.
2473 if (const MemRegion *MR = RetVal.getAsRegion())
2474 if (isa<FieldRegion>(MR) || isa<ElementRegion>(MR))
2475 if (const SymbolicRegion *BMR =
2476 dyn_cast<SymbolicRegion>(MR->getBaseRegion()))
2477 Sym = BMR->getSymbol();
Zhongxing Xu23baa012009-11-17 08:58:18 +00002478
Anna Zaks3aa52252012-02-11 21:44:39 +00002479 // Check if we are returning freed memory.
Jordan Rose356279c2012-08-08 18:23:31 +00002480 if (Sym)
Jordan Rosef1f26142012-11-15 19:11:33 +00002481 checkUseAfterFree(Sym, C, E);
Zhongxing Xu23baa012009-11-17 08:58:18 +00002482}
Zhongxing Xub0e15df2009-12-31 06:13:07 +00002483
Anna Zaks9fe80982012-03-22 00:57:20 +00002484// TODO: Blocks should be either inlined or should call invalidate regions
Ted Kremenek3a0678e2015-09-08 03:50:52 +00002485// upon invocation. After that's in place, special casing here will not be
Anna Zaks9fe80982012-03-22 00:57:20 +00002486// needed.
2487void MallocChecker::checkPostStmt(const BlockExpr *BE,
2488 CheckerContext &C) const {
2489
2490 // Scan the BlockDecRefExprs for any object the retain count checker
2491 // may be tracking.
2492 if (!BE->getBlockDecl()->hasCaptures())
2493 return;
2494
2495 ProgramStateRef state = C.getState();
2496 const BlockDataRegion *R =
George Karpenkovd703ec92018-01-17 20:27:29 +00002497 cast<BlockDataRegion>(C.getSVal(BE).getAsRegion());
Anna Zaks9fe80982012-03-22 00:57:20 +00002498
2499 BlockDataRegion::referenced_vars_iterator I = R->referenced_vars_begin(),
2500 E = R->referenced_vars_end();
2501
2502 if (I == E)
2503 return;
2504
2505 SmallVector<const MemRegion*, 10> Regions;
2506 const LocationContext *LC = C.getLocationContext();
2507 MemRegionManager &MemMgr = C.getSValBuilder().getRegionManager();
2508
2509 for ( ; I != E; ++I) {
Ted Kremenekbcf90532012-12-06 07:17:20 +00002510 const VarRegion *VR = I.getCapturedRegion();
Anna Zaks9fe80982012-03-22 00:57:20 +00002511 if (VR->getSuperRegion() == R) {
2512 VR = MemMgr.getVarRegion(VR->getDecl(), LC);
2513 }
2514 Regions.push_back(VR);
2515 }
2516
2517 state =
George Karpenkovd3e76752018-10-23 23:12:12 +00002518 state->scanReachableSymbols<StopTrackingCallback>(Regions).getState();
Anna Zaks9fe80982012-03-22 00:57:20 +00002519 C.addTransition(state);
2520}
2521
Anna Zaks46d01602012-05-18 01:16:10 +00002522bool MallocChecker::isReleased(SymbolRef Sym, CheckerContext &C) const {
Anna Zaksa1b227b2012-02-08 23:16:56 +00002523 assert(Sym);
2524 const RefState *RS = C.getState()->get<RegionState>(Sym);
Anna Zaks46d01602012-05-18 01:16:10 +00002525 return (RS && RS->isReleased());
2526}
2527
2528bool MallocChecker::checkUseAfterFree(SymbolRef Sym, CheckerContext &C,
2529 const Stmt *S) const {
Anna Zaksa1b227b2012-02-08 23:16:56 +00002530
Jordan Rose656fdd52014-01-08 18:46:55 +00002531 if (isReleased(Sym, C)) {
Anton Yartsev59ed15b2013-03-13 14:39:10 +00002532 ReportUseAfterFree(C, S->getSourceRange(), Sym);
2533 return true;
Anna Zaksa1b227b2012-02-08 23:16:56 +00002534 }
Anton Yartsev59ed15b2013-03-13 14:39:10 +00002535
Anna Zaksa1b227b2012-02-08 23:16:56 +00002536 return false;
2537}
2538
Anton Yartsevb50f4ba2015-04-14 14:18:04 +00002539void MallocChecker::checkUseZeroAllocated(SymbolRef Sym, CheckerContext &C,
2540 const Stmt *S) const {
2541 assert(Sym);
Anton Yartsevb50f4ba2015-04-14 14:18:04 +00002542
Devin Coughlin81771732015-09-22 22:47:14 +00002543 if (const RefState *RS = C.getState()->get<RegionState>(Sym)) {
2544 if (RS->isAllocatedOfSizeZero())
2545 ReportUseZeroAllocated(C, RS->getStmt()->getSourceRange(), Sym);
2546 }
2547 else if (C.getState()->contains<ReallocSizeZeroSymbols>(Sym)) {
2548 ReportUseZeroAllocated(C, S->getSourceRange(), Sym);
2549 }
Anton Yartsevb50f4ba2015-04-14 14:18:04 +00002550}
2551
Jordan Rose656fdd52014-01-08 18:46:55 +00002552bool MallocChecker::checkDoubleDelete(SymbolRef Sym, CheckerContext &C) const {
2553
2554 if (isReleased(Sym, C)) {
2555 ReportDoubleDelete(C, Sym);
2556 return true;
2557 }
2558 return false;
2559}
2560
Zhongxing Xu1bb6a1a2010-03-10 04:58:55 +00002561// Check if the location is a freed symbolic region.
Anna Zaks3e0f4152011-10-06 00:43:15 +00002562void MallocChecker::checkLocation(SVal l, bool isLoad, const Stmt *S,
2563 CheckerContext &C) const {
Zhongxing Xu1bb6a1a2010-03-10 04:58:55 +00002564 SymbolRef Sym = l.getLocSymbolInBase();
Anton Yartsevb50f4ba2015-04-14 14:18:04 +00002565 if (Sym) {
Anna Zaks46d01602012-05-18 01:16:10 +00002566 checkUseAfterFree(Sym, C, S);
Anton Yartsevb50f4ba2015-04-14 14:18:04 +00002567 checkUseZeroAllocated(Sym, C, S);
2568 }
Zhongxing Xu1bb6a1a2010-03-10 04:58:55 +00002569}
Ted Kremenekd21139a2010-07-31 01:52:11 +00002570
Anna Zaksbb1ef902012-02-11 21:02:35 +00002571// If a symbolic region is assumed to NULL (or another constant), stop tracking
2572// it - assuming that allocation failed on this path.
2573ProgramStateRef MallocChecker::evalAssume(ProgramStateRef state,
2574 SVal Cond,
2575 bool Assumption) const {
2576 RegionStateTy RS = state->get<RegionState>();
Anna Zaksbb1ef902012-02-11 21:02:35 +00002577 for (RegionStateTy::iterator I = RS.begin(), E = RS.end(); I != E; ++I) {
Ted Kremenek244e1d72012-09-07 22:31:01 +00002578 // If the symbol is assumed to be NULL, remove it from consideration.
Jordan Rose14fe9f32012-11-01 00:18:27 +00002579 ConstraintManager &CMgr = state->getConstraintManager();
2580 ConditionTruthVal AllocFailed = CMgr.isNull(state, I.getKey());
2581 if (AllocFailed.isConstrainedTrue())
Anna Zaksbb1ef902012-02-11 21:02:35 +00002582 state = state->remove<RegionState>(I.getKey());
2583 }
2584
Anna Zaksd56c8792012-02-13 18:05:39 +00002585 // Realloc returns 0 when reallocation fails, which means that we should
2586 // restore the state of the pointer being reallocated.
Jordan Rose0c153cb2012-11-02 01:54:06 +00002587 ReallocPairsTy RP = state->get<ReallocPairs>();
2588 for (ReallocPairsTy::iterator I = RP.begin(), E = RP.end(); I != E; ++I) {
Ted Kremenek244e1d72012-09-07 22:31:01 +00002589 // If the symbol is assumed to be NULL, remove it from consideration.
Jordan Rose14fe9f32012-11-01 00:18:27 +00002590 ConstraintManager &CMgr = state->getConstraintManager();
2591 ConditionTruthVal AllocFailed = CMgr.isNull(state, I.getKey());
Jordan Rose40bb12492012-11-01 00:25:15 +00002592 if (!AllocFailed.isConstrainedTrue())
Anna Zaks75cfbb62012-09-12 22:57:34 +00002593 continue;
Jordan Rose14fe9f32012-11-01 00:18:27 +00002594
Anna Zaks75cfbb62012-09-12 22:57:34 +00002595 SymbolRef ReallocSym = I.getData().ReallocatedSym;
2596 if (const RefState *RS = state->get<RegionState>(ReallocSym)) {
2597 if (RS->isReleased()) {
2598 if (I.getData().Kind == RPToBeFreedAfterFailure)
Anna Zaksac068142012-02-15 00:11:25 +00002599 state = state->set<RegionState>(ReallocSym,
Anton Yartsev05789592013-03-28 17:05:19 +00002600 RefState::getAllocated(RS->getAllocationFamily(), RS->getStmt()));
Anna Zaks75cfbb62012-09-12 22:57:34 +00002601 else if (I.getData().Kind == RPDoNotTrackAfterFailure)
2602 state = state->remove<RegionState>(ReallocSym);
2603 else
2604 assert(I.getData().Kind == RPIsFreeOnFailure);
Anna Zaksd56c8792012-02-13 18:05:39 +00002605 }
Anna Zaksd56c8792012-02-13 18:05:39 +00002606 }
Anna Zaks75cfbb62012-09-12 22:57:34 +00002607 state = state->remove<ReallocPairs>(I.getKey());
Anna Zaksd56c8792012-02-13 18:05:39 +00002608 }
2609
Anna Zaksbb1ef902012-02-11 21:02:35 +00002610 return state;
2611}
2612
Anna Zaks8ebeb642013-06-08 00:29:29 +00002613bool MallocChecker::mayFreeAnyEscapedMemoryOrIsModeledExplicitly(
Anna Zaksa4bc5e12013-05-31 23:47:32 +00002614 const CallEvent *Call,
2615 ProgramStateRef State,
2616 SymbolRef &EscapingSymbol) const {
Jordan Rose7ab01822012-07-02 19:27:51 +00002617 assert(Call);
Craig Topper0dbb7832014-05-27 02:45:47 +00002618 EscapingSymbol = nullptr;
2619
Jordan Rose2a833ca2014-01-15 17:25:15 +00002620 // For now, assume that any C++ or block call can free memory.
Anna Zaks7ac344a2012-02-24 23:56:53 +00002621 // TODO: If we want to be more optimistic here, we'll need to make sure that
2622 // regions escape to C++ containers. They seem to do that even now, but for
2623 // mysterious reasons.
Jordan Rose2a833ca2014-01-15 17:25:15 +00002624 if (!(isa<SimpleFunctionCall>(Call) || isa<ObjCMethodCall>(Call)))
Anna Zaksa4bc5e12013-05-31 23:47:32 +00002625 return true;
Anna Zaks7ac344a2012-02-24 23:56:53 +00002626
Jordan Rose742920c2012-07-02 19:27:35 +00002627 // Check Objective-C messages by selector name.
Jordan Rose6bad4902012-07-02 19:27:56 +00002628 if (const ObjCMethodCall *Msg = dyn_cast<ObjCMethodCall>(Call)) {
Jordan Rose7ab01822012-07-02 19:27:51 +00002629 // If it's not a framework call, or if it takes a callback, assume it
2630 // can free memory.
Anna Zaksfe1eca52015-10-27 20:19:45 +00002631 if (!Call->isInSystemHeader() || Call->argumentsMayEscape())
Anna Zaksa4bc5e12013-05-31 23:47:32 +00002632 return true;
Anna Zaks06a77fc2012-02-28 01:54:22 +00002633
Jordan Rose613f3c02013-03-09 00:59:10 +00002634 // If it's a method we know about, handle it explicitly post-call.
2635 // This should happen before the "freeWhenDone" check below.
2636 if (isKnownDeallocObjCMethodName(*Msg))
Anna Zaksa4bc5e12013-05-31 23:47:32 +00002637 return false;
Anna Zaks886dfb82012-06-20 23:35:57 +00002638
Jordan Rose613f3c02013-03-09 00:59:10 +00002639 // If there's a "freeWhenDone" parameter, but the method isn't one we know
2640 // about, we can't be sure that the object will use free() to deallocate the
2641 // memory, so we can't model it explicitly. The best we can do is use it to
2642 // decide whether the pointer escapes.
2643 if (Optional<bool> FreeWhenDone = getFreeWhenDoneArg(*Msg))
Anna Zaksa4bc5e12013-05-31 23:47:32 +00002644 return *FreeWhenDone;
Anna Zaks7ac344a2012-02-24 23:56:53 +00002645
Jordan Rose613f3c02013-03-09 00:59:10 +00002646 // If the first selector piece ends with "NoCopy", and there is no
2647 // "freeWhenDone" parameter set to zero, we know ownership is being
2648 // transferred. Again, though, we can't be sure that the object will use
2649 // free() to deallocate the memory, so we can't model it explicitly.
2650 StringRef FirstSlot = Msg->getSelector().getNameForSlot(0);
Jordan Rose742920c2012-07-02 19:27:35 +00002651 if (FirstSlot.endswith("NoCopy"))
Anna Zaksa4bc5e12013-05-31 23:47:32 +00002652 return true;
Anna Zaks12a8b902012-03-05 17:42:10 +00002653
Anna Zaks42908c72012-06-19 05:10:32 +00002654 // If the first selector starts with addPointer, insertPointer,
2655 // or replacePointer, assume we are dealing with NSPointerArray or similar.
2656 // This is similar to C++ containers (vector); we still might want to check
Jordan Rose742920c2012-07-02 19:27:35 +00002657 // that the pointers get freed by following the container itself.
2658 if (FirstSlot.startswith("addPointer") ||
2659 FirstSlot.startswith("insertPointer") ||
Jordan Rose514f9352014-01-07 21:39:48 +00002660 FirstSlot.startswith("replacePointer") ||
2661 FirstSlot.equals("valueWithPointer")) {
Anna Zaksa4bc5e12013-05-31 23:47:32 +00002662 return true;
Anna Zaks42908c72012-06-19 05:10:32 +00002663 }
2664
Anna Zaksa4bc5e12013-05-31 23:47:32 +00002665 // We should escape receiver on call to 'init'. This is especially relevant
2666 // to the receiver, as the corresponding symbol is usually not referenced
2667 // after the call.
2668 if (Msg->getMethodFamily() == OMF_init) {
2669 EscapingSymbol = Msg->getReceiverSVal().getAsSymbol();
2670 return true;
2671 }
Anna Zaks737926b2013-05-31 22:39:13 +00002672
Jordan Rose742920c2012-07-02 19:27:35 +00002673 // Otherwise, assume that the method does not free memory.
2674 // Most framework methods do not free memory.
Anna Zaksa4bc5e12013-05-31 23:47:32 +00002675 return false;
Anna Zaks3d348342012-02-14 21:55:24 +00002676 }
2677
Jordan Rose742920c2012-07-02 19:27:35 +00002678 // At this point the only thing left to handle is straight function calls.
Jordan Rose2a833ca2014-01-15 17:25:15 +00002679 const FunctionDecl *FD = cast<SimpleFunctionCall>(Call)->getDecl();
Jordan Rose742920c2012-07-02 19:27:35 +00002680 if (!FD)
Anna Zaksa4bc5e12013-05-31 23:47:32 +00002681 return true;
Anna Zaks7ac344a2012-02-24 23:56:53 +00002682
Jordan Rose742920c2012-07-02 19:27:35 +00002683 ASTContext &ASTC = State->getStateManager().getContext();
2684
2685 // If it's one of the allocation functions we can reason about, we model
2686 // its behavior explicitly.
2687 if (isMemFunction(FD, ASTC))
Anna Zaksa4bc5e12013-05-31 23:47:32 +00002688 return false;
Jordan Rose742920c2012-07-02 19:27:35 +00002689
2690 // If it's not a system call, assume it frees memory.
2691 if (!Call->isInSystemHeader())
Anna Zaksa4bc5e12013-05-31 23:47:32 +00002692 return true;
Jordan Rose742920c2012-07-02 19:27:35 +00002693
2694 // White list the system functions whose arguments escape.
2695 const IdentifierInfo *II = FD->getIdentifier();
2696 if (!II)
Anna Zaksa4bc5e12013-05-31 23:47:32 +00002697 return true;
Jordan Rose742920c2012-07-02 19:27:35 +00002698 StringRef FName = II->getName();
2699
Jordan Rose742920c2012-07-02 19:27:35 +00002700 // White list the 'XXXNoCopy' CoreFoundation functions.
Ted Kremenek3a0678e2015-09-08 03:50:52 +00002701 // We specifically check these before
Jordan Rose742920c2012-07-02 19:27:35 +00002702 if (FName.endswith("NoCopy")) {
2703 // Look for the deallocator argument. We know that the memory ownership
2704 // is not transferred only if the deallocator argument is
2705 // 'kCFAllocatorNull'.
2706 for (unsigned i = 1; i < Call->getNumArgs(); ++i) {
2707 const Expr *ArgE = Call->getArgExpr(i)->IgnoreParenCasts();
2708 if (const DeclRefExpr *DE = dyn_cast<DeclRefExpr>(ArgE)) {
2709 StringRef DeallocatorName = DE->getFoundDecl()->getName();
2710 if (DeallocatorName == "kCFAllocatorNull")
Anna Zaksa4bc5e12013-05-31 23:47:32 +00002711 return false;
Jordan Rose742920c2012-07-02 19:27:35 +00002712 }
2713 }
Anna Zaksa4bc5e12013-05-31 23:47:32 +00002714 return true;
Jordan Rose742920c2012-07-02 19:27:35 +00002715 }
2716
Jordan Rose742920c2012-07-02 19:27:35 +00002717 // Associating streams with malloced buffers. The pointer can escape if
Jordan Rose7ab01822012-07-02 19:27:51 +00002718 // 'closefn' is specified (and if that function does free memory),
2719 // but it will not if closefn is not specified.
Jordan Rose742920c2012-07-02 19:27:35 +00002720 // Currently, we do not inspect the 'closefn' function (PR12101).
2721 if (FName == "funopen")
Jordan Rose7ab01822012-07-02 19:27:51 +00002722 if (Call->getNumArgs() >= 4 && Call->getArgSVal(4).isConstant(0))
Anna Zaksa4bc5e12013-05-31 23:47:32 +00002723 return false;
Jordan Rose742920c2012-07-02 19:27:35 +00002724
2725 // Do not warn on pointers passed to 'setbuf' when used with std streams,
2726 // these leaks might be intentional when setting the buffer for stdio.
2727 // http://stackoverflow.com/questions/2671151/who-frees-setvbuf-buffer
2728 if (FName == "setbuf" || FName =="setbuffer" ||
2729 FName == "setlinebuf" || FName == "setvbuf") {
2730 if (Call->getNumArgs() >= 1) {
2731 const Expr *ArgE = Call->getArgExpr(0)->IgnoreParenCasts();
2732 if (const DeclRefExpr *ArgDRE = dyn_cast<DeclRefExpr>(ArgE))
2733 if (const VarDecl *D = dyn_cast<VarDecl>(ArgDRE->getDecl()))
2734 if (D->getCanonicalDecl()->getName().find("std") != StringRef::npos)
Anna Zaksa4bc5e12013-05-31 23:47:32 +00002735 return true;
Jordan Rose742920c2012-07-02 19:27:35 +00002736 }
2737 }
2738
2739 // A bunch of other functions which either take ownership of a pointer or
2740 // wrap the result up in a struct or object, meaning it can be freed later.
2741 // (See RetainCountChecker.) Not all the parameters here are invalidated,
2742 // but the Malloc checker cannot differentiate between them. The right way
2743 // of doing this would be to implement a pointer escapes callback.
2744 if (FName == "CGBitmapContextCreate" ||
2745 FName == "CGBitmapContextCreateWithData" ||
2746 FName == "CVPixelBufferCreateWithBytes" ||
2747 FName == "CVPixelBufferCreateWithPlanarBytes" ||
2748 FName == "OSAtomicEnqueue") {
Anna Zaksa4bc5e12013-05-31 23:47:32 +00002749 return true;
Jordan Rose742920c2012-07-02 19:27:35 +00002750 }
2751
Anna Zaks03f48332016-01-06 00:32:56 +00002752 if (FName == "postEvent" &&
2753 FD->getQualifiedNameAsString() == "QCoreApplication::postEvent") {
2754 return true;
2755 }
2756
2757 if (FName == "postEvent" &&
2758 FD->getQualifiedNameAsString() == "QCoreApplication::postEvent") {
2759 return true;
2760 }
2761
Artem Dergachev85c92112016-12-16 12:21:55 +00002762 if (FName == "connectImpl" &&
2763 FD->getQualifiedNameAsString() == "QObject::connectImpl") {
2764 return true;
2765 }
2766
Jordan Rose7ab01822012-07-02 19:27:51 +00002767 // Handle cases where we know a buffer's /address/ can escape.
2768 // Note that the above checks handle some special cases where we know that
2769 // even though the address escapes, it's still our responsibility to free the
2770 // buffer.
2771 if (Call->argumentsMayEscape())
Anna Zaksa4bc5e12013-05-31 23:47:32 +00002772 return true;
Jordan Rose742920c2012-07-02 19:27:35 +00002773
2774 // Otherwise, assume that the function does not free memory.
2775 // Most system calls do not free the memory.
Anna Zaksa4bc5e12013-05-31 23:47:32 +00002776 return false;
Anna Zaks3d348342012-02-14 21:55:24 +00002777}
2778
Anna Zaks333481b2013-03-28 23:15:29 +00002779static bool retTrue(const RefState *RS) {
2780 return true;
2781}
2782
2783static bool checkIfNewOrNewArrayFamily(const RefState *RS) {
2784 return (RS->getAllocationFamily() == AF_CXXNewArray ||
2785 RS->getAllocationFamily() == AF_CXXNew);
2786}
2787
Anna Zaksdc154152012-12-20 00:38:25 +00002788ProgramStateRef MallocChecker::checkPointerEscape(ProgramStateRef State,
2789 const InvalidatedSymbols &Escaped,
Anna Zaksacdc13c2013-02-07 23:05:43 +00002790 const CallEvent *Call,
2791 PointerEscapeKind Kind) const {
Anna Zaks333481b2013-03-28 23:15:29 +00002792 return checkPointerEscapeAux(State, Escaped, Call, Kind, &retTrue);
2793}
2794
2795ProgramStateRef MallocChecker::checkConstPointerEscape(ProgramStateRef State,
2796 const InvalidatedSymbols &Escaped,
2797 const CallEvent *Call,
2798 PointerEscapeKind Kind) const {
2799 return checkPointerEscapeAux(State, Escaped, Call, Kind,
2800 &checkIfNewOrNewArrayFamily);
2801}
2802
2803ProgramStateRef MallocChecker::checkPointerEscapeAux(ProgramStateRef State,
2804 const InvalidatedSymbols &Escaped,
2805 const CallEvent *Call,
2806 PointerEscapeKind Kind,
2807 bool(*CheckRefState)(const RefState*)) const {
Jordan Rose613f3c02013-03-09 00:59:10 +00002808 // If we know that the call does not free memory, or we want to process the
2809 // call later, keep tracking the top level arguments.
Craig Topper0dbb7832014-05-27 02:45:47 +00002810 SymbolRef EscapingSymbol = nullptr;
Jordan Rose757fbb02013-05-10 17:07:16 +00002811 if (Kind == PSK_DirectEscapeOnCall &&
Anna Zaks8ebeb642013-06-08 00:29:29 +00002812 !mayFreeAnyEscapedMemoryOrIsModeledExplicitly(Call, State,
2813 EscapingSymbol) &&
Anna Zaksa4bc5e12013-05-31 23:47:32 +00002814 !EscapingSymbol) {
Anna Zaks3d348342012-02-14 21:55:24 +00002815 return State;
Anna Zaksacdc13c2013-02-07 23:05:43 +00002816 }
Anna Zaks3d348342012-02-14 21:55:24 +00002817
Anna Zaksdc154152012-12-20 00:38:25 +00002818 for (InvalidatedSymbols::const_iterator I = Escaped.begin(),
Anna Zaks333481b2013-03-28 23:15:29 +00002819 E = Escaped.end();
2820 I != E; ++I) {
Anna Zaksbb1ef902012-02-11 21:02:35 +00002821 SymbolRef sym = *I;
Anna Zaksdc154152012-12-20 00:38:25 +00002822
Anna Zaksa4bc5e12013-05-31 23:47:32 +00002823 if (EscapingSymbol && EscapingSymbol != sym)
2824 continue;
Ted Kremenek3a0678e2015-09-08 03:50:52 +00002825
Anna Zaks0d6989b2012-06-22 02:04:31 +00002826 if (const RefState *RS = State->get<RegionState>(sym)) {
Anton Yartsevb50f4ba2015-04-14 14:18:04 +00002827 if ((RS->isAllocated() || RS->isAllocatedOfSizeZero()) &&
2828 CheckRefState(RS)) {
Anna Zaks23a62012012-08-09 00:42:24 +00002829 State = State->remove<RegionState>(sym);
Anna Zaks93a21a82013-04-09 00:30:28 +00002830 State = State->set<RegionState>(sym, RefState::getEscaped(RS));
2831 }
Anna Zaks0d6989b2012-06-22 02:04:31 +00002832 }
Anna Zaksbb1ef902012-02-11 21:02:35 +00002833 }
Anna Zaks3d348342012-02-14 21:55:24 +00002834 return State;
Ted Kremenekd21139a2010-07-31 01:52:11 +00002835}
Argyrios Kyrtzidis183f0fb2011-02-28 01:26:35 +00002836
Jordy Rosebf38f202012-03-18 07:43:35 +00002837static SymbolRef findFailedReallocSymbol(ProgramStateRef currState,
2838 ProgramStateRef prevState) {
Jordan Rose0c153cb2012-11-02 01:54:06 +00002839 ReallocPairsTy currMap = currState->get<ReallocPairs>();
2840 ReallocPairsTy prevMap = prevState->get<ReallocPairs>();
Jordy Rosebf38f202012-03-18 07:43:35 +00002841
Jordan Rose0c153cb2012-11-02 01:54:06 +00002842 for (ReallocPairsTy::iterator I = prevMap.begin(), E = prevMap.end();
Jordy Rosebf38f202012-03-18 07:43:35 +00002843 I != E; ++I) {
2844 SymbolRef sym = I.getKey();
2845 if (!currMap.lookup(sym))
2846 return sym;
2847 }
2848
Craig Topper0dbb7832014-05-27 02:45:47 +00002849 return nullptr;
Jordy Rosebf38f202012-03-18 07:43:35 +00002850}
2851
Artem Dergachevff1fc212018-03-21 00:49:47 +00002852static bool isReferenceCountingPointerDestructor(const CXXDestructorDecl *DD) {
2853 if (const IdentifierInfo *II = DD->getParent()->getIdentifier()) {
2854 StringRef N = II->getName();
2855 if (N.contains_lower("ptr") || N.contains_lower("pointer")) {
2856 if (N.contains_lower("ref") || N.contains_lower("cnt") ||
2857 N.contains_lower("intrusive") || N.contains_lower("shared")) {
2858 return true;
2859 }
2860 }
2861 }
2862 return false;
2863}
2864
David Blaikie0a0c2752017-01-05 17:26:53 +00002865std::shared_ptr<PathDiagnosticPiece> MallocChecker::MallocBugVisitor::VisitNode(
George Karpenkovc82d4572018-09-28 18:49:41 +00002866 const ExplodedNode *N, BugReporterContext &BRC, BugReport &BR) {
Reka Kovacs8707cd12018-07-07 17:22:45 +00002867
2868 ProgramStateRef state = N->getState();
George Karpenkovc82d4572018-09-28 18:49:41 +00002869 ProgramStateRef statePrev = N->getFirstPred()->getState();
Reka Kovacs8707cd12018-07-07 17:22:45 +00002870
2871 const RefState *RS = state->get<RegionState>(Sym);
2872 const RefState *RSPrev = statePrev->get<RegionState>(Sym);
2873
Artem Dergachev5337efc2018-02-27 21:19:33 +00002874 const Stmt *S = PathDiagnosticLocation::getStmt(N);
Reka Kovacs8707cd12018-07-07 17:22:45 +00002875 // When dealing with containers, we sometimes want to give a note
2876 // even if the statement is missing.
Reka Kovacs88ad7042018-07-20 15:14:49 +00002877 if (!S && (!RS || RS->getAllocationFamily() != AF_InnerBuffer))
Artem Dergachev5337efc2018-02-27 21:19:33 +00002878 return nullptr;
2879
2880 const LocationContext *CurrentLC = N->getLocationContext();
2881
2882 // If we find an atomic fetch_add or fetch_sub within the destructor in which
2883 // the pointer was released (before the release), this is likely a destructor
2884 // of a shared pointer.
2885 // Because we don't model atomics, and also because we don't know that the
2886 // original reference count is positive, we should not report use-after-frees
2887 // on objects deleted in such destructors. This can probably be improved
2888 // through better shared pointer modeling.
2889 if (ReleaseDestructorLC) {
2890 if (const auto *AE = dyn_cast<AtomicExpr>(S)) {
2891 AtomicExpr::AtomicOp Op = AE->getOp();
2892 if (Op == AtomicExpr::AO__c11_atomic_fetch_add ||
2893 Op == AtomicExpr::AO__c11_atomic_fetch_sub) {
2894 if (ReleaseDestructorLC == CurrentLC ||
2895 ReleaseDestructorLC->isParentOf(CurrentLC)) {
2896 BR.markInvalid(getTag(), S);
2897 }
2898 }
2899 }
2900 }
2901
Jordan Rose681cce92012-07-10 22:07:42 +00002902 // FIXME: We will eventually need to handle non-statement-based events
2903 // (__attribute__((cleanup))).
2904
Anna Zaks2b5bb972012-02-09 06:25:51 +00002905 // Find out if this is an interesting point and what is the kind.
Reka Kovacsa14a2fe2018-07-19 17:43:09 +00002906 StringRef Msg;
Gabor Horvath6ee4f902016-08-18 07:54:50 +00002907 StackHintGeneratorForSymbol *StackHint = nullptr;
Reka Kovacs52dd98b2018-07-19 15:44:46 +00002908 SmallString<256> Buf;
2909 llvm::raw_svector_ostream OS(Buf);
Reka Kovacs88ad7042018-07-20 15:14:49 +00002910
Anna Zaks9eb7bc82012-02-16 22:26:07 +00002911 if (Mode == Normal) {
Anna Zaks1ff57d52012-03-15 21:13:02 +00002912 if (isAllocated(RS, RSPrev, S)) {
Anna Zaks9eb7bc82012-02-16 22:26:07 +00002913 Msg = "Memory is allocated";
Anna Zaksa7f457a2012-03-16 23:44:28 +00002914 StackHint = new StackHintGeneratorForSymbol(Sym,
2915 "Returned allocated memory");
Anna Zaks1ff57d52012-03-15 21:13:02 +00002916 } else if (isReleased(RS, RSPrev, S)) {
Reka Kovacs8707cd12018-07-07 17:22:45 +00002917 const auto Family = RS->getAllocationFamily();
Reka Kovacsc18ecc82018-07-19 15:10:06 +00002918 switch (Family) {
Reka Kovacs8707cd12018-07-07 17:22:45 +00002919 case AF_Alloca:
2920 case AF_Malloc:
2921 case AF_CXXNew:
2922 case AF_CXXNewArray:
2923 case AF_IfNameIndex:
2924 Msg = "Memory is released";
Reka Kovacsbb2749a2018-08-10 23:56:57 +00002925 StackHint = new StackHintGeneratorForSymbol(Sym,
2926 "Returning; memory was released");
Reka Kovacs8707cd12018-07-07 17:22:45 +00002927 break;
Reka Kovacs88ad7042018-07-20 15:14:49 +00002928 case AF_InnerBuffer: {
Reka Kovacsbb2749a2018-08-10 23:56:57 +00002929 const MemRegion *ObjRegion =
2930 allocation_state::getContainerObjRegion(statePrev, Sym);
2931 const auto *TypedRegion = cast<TypedValueRegion>(ObjRegion);
2932 QualType ObjTy = TypedRegion->getValueType();
2933 OS << "Inner buffer of '" << ObjTy.getAsString() << "' ";
2934
Reka Kovacsc18ecc82018-07-19 15:10:06 +00002935 if (N->getLocation().getKind() == ProgramPoint::PostImplicitCallKind) {
Reka Kovacsbb2749a2018-08-10 23:56:57 +00002936 OS << "deallocated by call to destructor";
2937 StackHint = new StackHintGeneratorForSymbol(Sym,
2938 "Returning; inner buffer was deallocated");
Reka Kovacsc18ecc82018-07-19 15:10:06 +00002939 } else {
Reka Kovacsbb2749a2018-08-10 23:56:57 +00002940 OS << "reallocated by call to '";
Reka Kovacsc18ecc82018-07-19 15:10:06 +00002941 const Stmt *S = RS->getStmt();
2942 if (const auto *MemCallE = dyn_cast<CXXMemberCallExpr>(S)) {
2943 OS << MemCallE->getMethodDecl()->getNameAsString();
2944 } else if (const auto *OpCallE = dyn_cast<CXXOperatorCallExpr>(S)) {
2945 OS << OpCallE->getDirectCallee()->getNameAsString();
Reka Kovacsc74cfc42018-07-30 15:43:45 +00002946 } else if (const auto *CallE = dyn_cast<CallExpr>(S)) {
2947 auto &CEMgr = BRC.getStateManager().getCallEventManager();
2948 CallEventRef<> Call = CEMgr.getSimpleCall(CallE, state, CurrentLC);
2949 const auto *D = dyn_cast_or_null<NamedDecl>(Call->getDecl());
2950 OS << (D ? D->getNameAsString() : "unknown");
Reka Kovacsc18ecc82018-07-19 15:10:06 +00002951 }
2952 OS << "'";
Reka Kovacsbb2749a2018-08-10 23:56:57 +00002953 StackHint = new StackHintGeneratorForSymbol(Sym,
2954 "Returning; inner buffer was reallocated");
Reka Kovacsc18ecc82018-07-19 15:10:06 +00002955 }
Reka Kovacsa14a2fe2018-07-19 17:43:09 +00002956 Msg = OS.str();
Reka Kovacs8707cd12018-07-07 17:22:45 +00002957 break;
Reka Kovacsc18ecc82018-07-19 15:10:06 +00002958 }
Reka Kovacs8707cd12018-07-07 17:22:45 +00002959 case AF_None:
Reka Kovacs8707cd12018-07-07 17:22:45 +00002960 llvm_unreachable("Unhandled allocation family!");
2961 }
Artem Dergachev5337efc2018-02-27 21:19:33 +00002962
Artem Dergachevff1fc212018-03-21 00:49:47 +00002963 // See if we're releasing memory while inlining a destructor
2964 // (or one of its callees). This turns on various common
2965 // false positive suppressions.
2966 bool FoundAnyDestructor = false;
Artem Dergachev5337efc2018-02-27 21:19:33 +00002967 for (const LocationContext *LC = CurrentLC; LC; LC = LC->getParent()) {
Artem Dergachevff1fc212018-03-21 00:49:47 +00002968 if (const auto *DD = dyn_cast<CXXDestructorDecl>(LC->getDecl())) {
2969 if (isReferenceCountingPointerDestructor(DD)) {
2970 // This immediately looks like a reference-counting destructor.
2971 // We're bad at guessing the original reference count of the object,
2972 // so suppress the report for now.
2973 BR.markInvalid(getTag(), DD);
2974 } else if (!FoundAnyDestructor) {
2975 assert(!ReleaseDestructorLC &&
2976 "There can be only one release point!");
2977 // Suspect that it's a reference counting pointer destructor.
2978 // On one of the next nodes might find out that it has atomic
2979 // reference counting operations within it (see the code above),
2980 // and if so, we'd conclude that it likely is a reference counting
2981 // pointer destructor.
George Karpenkovdd18b112018-06-27 01:51:55 +00002982 ReleaseDestructorLC = LC->getStackFrame();
Artem Dergachevff1fc212018-03-21 00:49:47 +00002983 // It is unlikely that releasing memory is delegated to a destructor
2984 // inside a destructor of a shared pointer, because it's fairly hard
2985 // to pass the information that the pointer indeed needs to be
2986 // released into it. So we're only interested in the innermost
2987 // destructor.
2988 FoundAnyDestructor = true;
2989 }
Artem Dergachev5337efc2018-02-27 21:19:33 +00002990 }
2991 }
Anna Zaks0d6989b2012-06-22 02:04:31 +00002992 } else if (isRelinquished(RS, RSPrev, S)) {
Alp Toker5faf0c02013-12-02 03:50:25 +00002993 Msg = "Memory ownership is transferred";
Anna Zaks0d6989b2012-06-22 02:04:31 +00002994 StackHint = new StackHintGeneratorForSymbol(Sym, "");
Anna Zaks1ff57d52012-03-15 21:13:02 +00002995 } else if (isReallocFailedCheck(RS, RSPrev, S)) {
Anna Zaks9eb7bc82012-02-16 22:26:07 +00002996 Mode = ReallocationFailed;
2997 Msg = "Reallocation failed";
Anna Zakscba4f292012-03-16 23:24:20 +00002998 StackHint = new StackHintGeneratorForReallocationFailed(Sym,
Anna Zaksa7f457a2012-03-16 23:44:28 +00002999 "Reallocation failed");
Jordy Rosebf38f202012-03-18 07:43:35 +00003000
Jordy Rose21ff76e2012-03-24 03:15:09 +00003001 if (SymbolRef sym = findFailedReallocSymbol(state, statePrev)) {
3002 // Is it possible to fail two reallocs WITHOUT testing in between?
3003 assert((!FailedReallocSymbol || FailedReallocSymbol == sym) &&
3004 "We only support one failed realloc at a time.");
Jordy Rosebf38f202012-03-18 07:43:35 +00003005 BR.markInteresting(sym);
Jordy Rose21ff76e2012-03-24 03:15:09 +00003006 FailedReallocSymbol = sym;
3007 }
Anna Zaks9eb7bc82012-02-16 22:26:07 +00003008 }
3009
3010 // We are in a special mode if a reallocation failed later in the path.
3011 } else if (Mode == ReallocationFailed) {
Jordy Rose21ff76e2012-03-24 03:15:09 +00003012 assert(FailedReallocSymbol && "No symbol to look for.");
Anna Zaks9eb7bc82012-02-16 22:26:07 +00003013
Jordy Rose21ff76e2012-03-24 03:15:09 +00003014 // Is this is the first appearance of the reallocated symbol?
3015 if (!statePrev->get<RegionState>(FailedReallocSymbol)) {
Jordy Rose21ff76e2012-03-24 03:15:09 +00003016 // We're at the reallocation point.
3017 Msg = "Attempt to reallocate memory";
3018 StackHint = new StackHintGeneratorForSymbol(Sym,
3019 "Returned reallocated memory");
Craig Topper0dbb7832014-05-27 02:45:47 +00003020 FailedReallocSymbol = nullptr;
Jordy Rose21ff76e2012-03-24 03:15:09 +00003021 Mode = Normal;
3022 }
Anna Zaks9eb7bc82012-02-16 22:26:07 +00003023 }
3024
Reka Kovacsa14a2fe2018-07-19 17:43:09 +00003025 if (Msg.empty())
Craig Topper0dbb7832014-05-27 02:45:47 +00003026 return nullptr;
Anna Zakscba4f292012-03-16 23:24:20 +00003027 assert(StackHint);
Anna Zaks2b5bb972012-02-09 06:25:51 +00003028
3029 // Generate the extra diagnostic.
Reka Kovacs8707cd12018-07-07 17:22:45 +00003030 PathDiagnosticLocation Pos;
3031 if (!S) {
Reka Kovacs88ad7042018-07-20 15:14:49 +00003032 assert(RS->getAllocationFamily() == AF_InnerBuffer);
Reka Kovacs8707cd12018-07-07 17:22:45 +00003033 auto PostImplCall = N->getLocation().getAs<PostImplicitCall>();
3034 if (!PostImplCall)
3035 return nullptr;
3036 Pos = PathDiagnosticLocation(PostImplCall->getLocation(),
3037 BRC.getSourceManager());
3038 } else {
3039 Pos = PathDiagnosticLocation(S, BRC.getSourceManager(),
3040 N->getLocationContext());
3041 }
3042
David Blaikie0a0c2752017-01-05 17:26:53 +00003043 return std::make_shared<PathDiagnosticEventPiece>(Pos, Msg, true, StackHint);
Anna Zaks2b5bb972012-02-09 06:25:51 +00003044}
3045
Anna Zaks263b7e02012-05-02 00:05:20 +00003046void MallocChecker::printState(raw_ostream &Out, ProgramStateRef State,
3047 const char *NL, const char *Sep) const {
3048
3049 RegionStateTy RS = State->get<RegionState>();
3050
Ted Kremenek6fcefb52013-01-03 01:30:12 +00003051 if (!RS.isEmpty()) {
Anton Yartsev6a619222014-02-17 18:25:34 +00003052 Out << Sep << "MallocChecker :" << NL;
Ted Kremenek6fcefb52013-01-03 01:30:12 +00003053 for (RegionStateTy::iterator I = RS.begin(), E = RS.end(); I != E; ++I) {
Anton Yartsev6a619222014-02-17 18:25:34 +00003054 const RefState *RefS = State->get<RegionState>(I.getKey());
3055 AllocationFamily Family = RefS->getAllocationFamily();
Anton Yartsev4eb394d2015-03-07 00:31:53 +00003056 Optional<MallocChecker::CheckKind> CheckKind = getCheckIfTracked(Family);
Anton Yartsev2487dd62015-03-10 22:24:21 +00003057 if (!CheckKind.hasValue())
3058 CheckKind = getCheckIfTracked(Family, true);
Anton Yartsev4eb394d2015-03-07 00:31:53 +00003059
Ted Kremenek6fcefb52013-01-03 01:30:12 +00003060 I.getKey()->dumpToStream(Out);
3061 Out << " : ";
3062 I.getData().dump(Out);
Anton Yartsev6a619222014-02-17 18:25:34 +00003063 if (CheckKind.hasValue())
3064 Out << " (" << CheckNames[*CheckKind].getName() << ")";
Ted Kremenek6fcefb52013-01-03 01:30:12 +00003065 Out << NL;
3066 }
3067 }
Anna Zaks263b7e02012-05-02 00:05:20 +00003068}
Anna Zaks2b5bb972012-02-09 06:25:51 +00003069
Reka Kovacs18775fc2018-06-09 13:03:49 +00003070namespace clang {
3071namespace ento {
3072namespace allocation_state {
3073
3074ProgramStateRef
3075markReleased(ProgramStateRef State, SymbolRef Sym, const Expr *Origin) {
Reka Kovacs88ad7042018-07-20 15:14:49 +00003076 AllocationFamily Family = AF_InnerBuffer;
Reka Kovacs18775fc2018-06-09 13:03:49 +00003077 return State->set<RegionState>(Sym, RefState::getReleased(Family, Origin));
3078}
3079
3080} // end namespace allocation_state
3081} // end namespace ento
3082} // end namespace clang
3083
Anna Zakse4cfcd42013-04-16 00:22:55 +00003084void ento::registerNewDeleteLeaksChecker(CheckerManager &mgr) {
3085 registerCStringCheckerBasic(mgr);
Alexander Kornienko4aca9b12014-02-11 21:49:21 +00003086 MallocChecker *checker = mgr.registerChecker<MallocChecker>();
Gabor Horvathe40c71c2015-03-04 17:59:34 +00003087 checker->IsOptimistic = mgr.getAnalyzerOptions().getBooleanOption(
3088 "Optimistic", false, checker);
Alexander Kornienko4aca9b12014-02-11 21:49:21 +00003089 checker->ChecksEnabled[MallocChecker::CK_NewDeleteLeaksChecker] = true;
3090 checker->CheckNames[MallocChecker::CK_NewDeleteLeaksChecker] =
3091 mgr.getCurrentCheckName();
Ted Kremenek3a0678e2015-09-08 03:50:52 +00003092 // We currently treat NewDeleteLeaks checker as a subchecker of NewDelete
Anna Zakse4cfcd42013-04-16 00:22:55 +00003093 // checker.
Gabor Horvathb77bc6b2018-01-06 10:51:00 +00003094 if (!checker->ChecksEnabled[MallocChecker::CK_NewDeleteChecker]) {
Alexander Kornienko4aca9b12014-02-11 21:49:21 +00003095 checker->ChecksEnabled[MallocChecker::CK_NewDeleteChecker] = true;
Gabor Horvathb77bc6b2018-01-06 10:51:00 +00003096 // FIXME: This does not set the correct name, but without this workaround
3097 // no name will be set at all.
3098 checker->CheckNames[MallocChecker::CK_NewDeleteChecker] =
3099 mgr.getCurrentCheckName();
3100 }
Anna Zakse4cfcd42013-04-16 00:22:55 +00003101}
Anton Yartsev7af0aa82013-04-12 23:25:40 +00003102
Reka Kovacsd9f66ba2018-08-06 22:03:42 +00003103// Intended to be used in InnerPointerChecker to register the part of
3104// MallocChecker connected to it.
3105void ento::registerInnerPointerCheckerAux(CheckerManager &mgr) {
3106 registerCStringCheckerBasic(mgr);
3107 MallocChecker *checker = mgr.registerChecker<MallocChecker>();
3108 checker->IsOptimistic = mgr.getAnalyzerOptions().getBooleanOption(
3109 "Optimistic", false, checker);
3110 checker->ChecksEnabled[MallocChecker::CK_InnerPointerChecker] = true;
3111 checker->CheckNames[MallocChecker::CK_InnerPointerChecker] =
3112 mgr.getCurrentCheckName();
3113}
3114
Alexander Kornienko4aca9b12014-02-11 21:49:21 +00003115#define REGISTER_CHECKER(name) \
3116 void ento::register##name(CheckerManager &mgr) { \
3117 registerCStringCheckerBasic(mgr); \
3118 MallocChecker *checker = mgr.registerChecker<MallocChecker>(); \
Gabor Horvathe40c71c2015-03-04 17:59:34 +00003119 checker->IsOptimistic = mgr.getAnalyzerOptions().getBooleanOption( \
3120 "Optimistic", false, checker); \
Alexander Kornienko4aca9b12014-02-11 21:49:21 +00003121 checker->ChecksEnabled[MallocChecker::CK_##name] = true; \
3122 checker->CheckNames[MallocChecker::CK_##name] = mgr.getCurrentCheckName(); \
3123 }
Anna Zakscd37bf42012-02-08 23:16:52 +00003124
Gabor Horvathe40c71c2015-03-04 17:59:34 +00003125REGISTER_CHECKER(MallocChecker)
Anton Yartsev13df0362013-03-25 01:35:45 +00003126REGISTER_CHECKER(NewDeleteChecker)
Anton Yartsev05789592013-03-28 17:05:19 +00003127REGISTER_CHECKER(MismatchedDeallocatorChecker)