Chris Lattner | 466a049 | 2002-05-21 20:50:24 +0000 | [diff] [blame] | 1 | //===- SimplifyCFG.cpp - Code to perform CFG simplification ---------------===// |
Misha Brukman | b1c9317 | 2005-04-21 23:48:37 +0000 | [diff] [blame] | 2 | // |
John Criswell | 482202a | 2003-10-20 19:43:21 +0000 | [diff] [blame] | 3 | // The LLVM Compiler Infrastructure |
| 4 | // |
Chris Lattner | f3ebc3f | 2007-12-29 20:36:04 +0000 | [diff] [blame] | 5 | // This file is distributed under the University of Illinois Open Source |
| 6 | // License. See LICENSE.TXT for details. |
Misha Brukman | b1c9317 | 2005-04-21 23:48:37 +0000 | [diff] [blame] | 7 | // |
John Criswell | 482202a | 2003-10-20 19:43:21 +0000 | [diff] [blame] | 8 | //===----------------------------------------------------------------------===// |
Chris Lattner | 466a049 | 2002-05-21 20:50:24 +0000 | [diff] [blame] | 9 | // |
Chris Lattner | a704ac8 | 2002-10-08 21:36:33 +0000 | [diff] [blame] | 10 | // Peephole optimize the CFG. |
Chris Lattner | 466a049 | 2002-05-21 20:50:24 +0000 | [diff] [blame] | 11 | // |
| 12 | //===----------------------------------------------------------------------===// |
| 13 | |
Eugene Zelenko | a3fe70d | 2016-11-30 17:48:10 +0000 | [diff] [blame] | 14 | #include "llvm/ADT/APInt.h" |
| 15 | #include "llvm/ADT/ArrayRef.h" |
Chandler Carruth | ed0881b | 2012-12-03 16:50:05 +0000 | [diff] [blame] | 16 | #include "llvm/ADT/DenseMap.h" |
Eugene Zelenko | a3fe70d | 2016-11-30 17:48:10 +0000 | [diff] [blame] | 17 | #include "llvm/ADT/Optional.h" |
James Molloy | 4de84dd | 2015-11-04 15:28:04 +0000 | [diff] [blame] | 18 | #include "llvm/ADT/SetOperations.h" |
Chandler Carruth | ed0881b | 2012-12-03 16:50:05 +0000 | [diff] [blame] | 19 | #include "llvm/ADT/SetVector.h" |
| 20 | #include "llvm/ADT/SmallPtrSet.h" |
Eugene Zelenko | a3fe70d | 2016-11-30 17:48:10 +0000 | [diff] [blame] | 21 | #include "llvm/ADT/SmallSet.h" |
Chandler Carruth | ed0881b | 2012-12-03 16:50:05 +0000 | [diff] [blame] | 22 | #include "llvm/ADT/SmallVector.h" |
| 23 | #include "llvm/ADT/Statistic.h" |
Eugene Zelenko | a3fe70d | 2016-11-30 17:48:10 +0000 | [diff] [blame] | 24 | #include "llvm/ADT/STLExtras.h" |
Benjamin Kramer | 7c30260 | 2013-11-12 12:24:36 +0000 | [diff] [blame] | 25 | #include "llvm/Analysis/ConstantFolding.h" |
Joseph Tremoulet | 0d80888 | 2016-01-05 02:37:41 +0000 | [diff] [blame] | 26 | #include "llvm/Analysis/EHPersonalities.h" |
Chandler Carruth | ed0881b | 2012-12-03 16:50:05 +0000 | [diff] [blame] | 27 | #include "llvm/Analysis/InstructionSimplify.h" |
Chandler Carruth | d3e7355 | 2013-01-07 03:08:10 +0000 | [diff] [blame] | 28 | #include "llvm/Analysis/TargetTransformInfo.h" |
Chandler Carruth | ed0881b | 2012-12-03 16:50:05 +0000 | [diff] [blame] | 29 | #include "llvm/Analysis/ValueTracking.h" |
Eugene Zelenko | a3fe70d | 2016-11-30 17:48:10 +0000 | [diff] [blame] | 30 | #include "llvm/IR/BasicBlock.h" |
| 31 | #include "llvm/IR/CallSite.h" |
Chandler Carruth | 1305dc3 | 2014-03-04 11:45:46 +0000 | [diff] [blame] | 32 | #include "llvm/IR/CFG.h" |
Eugene Zelenko | a3fe70d | 2016-11-30 17:48:10 +0000 | [diff] [blame] | 33 | #include "llvm/IR/Constant.h" |
Chandler Carruth | 8cd041e | 2014-03-04 12:24:34 +0000 | [diff] [blame] | 34 | #include "llvm/IR/ConstantRange.h" |
Chandler Carruth | 9fb823b | 2013-01-02 11:36:10 +0000 | [diff] [blame] | 35 | #include "llvm/IR/Constants.h" |
| 36 | #include "llvm/IR/DataLayout.h" |
Andrea Di Biagio | f20c57e | 2016-12-15 20:01:26 +0000 | [diff] [blame] | 37 | #include "llvm/IR/DebugInfo.h" |
Chandler Carruth | 9fb823b | 2013-01-02 11:36:10 +0000 | [diff] [blame] | 38 | #include "llvm/IR/DerivedTypes.h" |
Eugene Zelenko | a3fe70d | 2016-11-30 17:48:10 +0000 | [diff] [blame] | 39 | #include "llvm/IR/GlobalValue.h" |
Chandler Carruth | 9fb823b | 2013-01-02 11:36:10 +0000 | [diff] [blame] | 40 | #include "llvm/IR/GlobalVariable.h" |
| 41 | #include "llvm/IR/IRBuilder.h" |
Eugene Zelenko | a3fe70d | 2016-11-30 17:48:10 +0000 | [diff] [blame] | 42 | #include "llvm/IR/InstrTypes.h" |
| 43 | #include "llvm/IR/Instruction.h" |
Chandler Carruth | 9fb823b | 2013-01-02 11:36:10 +0000 | [diff] [blame] | 44 | #include "llvm/IR/Instructions.h" |
| 45 | #include "llvm/IR/IntrinsicInst.h" |
Eugene Zelenko | a3fe70d | 2016-11-30 17:48:10 +0000 | [diff] [blame] | 46 | #include "llvm/IR/Intrinsics.h" |
Chandler Carruth | 9fb823b | 2013-01-02 11:36:10 +0000 | [diff] [blame] | 47 | #include "llvm/IR/LLVMContext.h" |
| 48 | #include "llvm/IR/MDBuilder.h" |
| 49 | #include "llvm/IR/Metadata.h" |
| 50 | #include "llvm/IR/Module.h" |
Chandler Carruth | 64396b0 | 2014-03-04 12:05:47 +0000 | [diff] [blame] | 51 | #include "llvm/IR/NoFolder.h" |
Chandler Carruth | 9fb823b | 2013-01-02 11:36:10 +0000 | [diff] [blame] | 52 | #include "llvm/IR/Operator.h" |
Chandler Carruth | 820a908 | 2014-03-04 11:08:18 +0000 | [diff] [blame] | 53 | #include "llvm/IR/PatternMatch.h" |
Chandler Carruth | 9fb823b | 2013-01-02 11:36:10 +0000 | [diff] [blame] | 54 | #include "llvm/IR/Type.h" |
Eugene Zelenko | a3fe70d | 2016-11-30 17:48:10 +0000 | [diff] [blame] | 55 | #include "llvm/IR/User.h" |
| 56 | #include "llvm/IR/Value.h" |
Robert Lougher | cf17674 | 2016-12-15 16:17:53 +0000 | [diff] [blame] | 57 | #include "llvm/IR/DebugInfo.h" |
Eugene Zelenko | a3fe70d | 2016-11-30 17:48:10 +0000 | [diff] [blame] | 58 | #include "llvm/Support/Casting.h" |
Evan Cheng | d983eba | 2011-01-29 04:46:23 +0000 | [diff] [blame] | 59 | #include "llvm/Support/CommandLine.h" |
Chris Lattner | d7beca3 | 2010-12-14 06:17:25 +0000 | [diff] [blame] | 60 | #include "llvm/Support/Debug.h" |
Eugene Zelenko | a3fe70d | 2016-11-30 17:48:10 +0000 | [diff] [blame] | 61 | #include "llvm/Support/ErrorHandling.h" |
| 62 | #include "llvm/Support/MathExtras.h" |
Chris Lattner | d7beca3 | 2010-12-14 06:17:25 +0000 | [diff] [blame] | 63 | #include "llvm/Support/raw_ostream.h" |
Chandler Carruth | aafe091 | 2012-06-29 12:38:19 +0000 | [diff] [blame] | 64 | #include "llvm/Transforms/Utils/BasicBlockUtils.h" |
Dehao Chen | f6c0083 | 2016-05-18 19:44:21 +0000 | [diff] [blame] | 65 | #include "llvm/Transforms/Utils/Local.h" |
Jingyue Wu | fc02967 | 2014-09-30 22:23:38 +0000 | [diff] [blame] | 66 | #include "llvm/Transforms/Utils/ValueMapper.h" |
Chris Lattner | 466a049 | 2002-05-21 20:50:24 +0000 | [diff] [blame] | 67 | #include <algorithm> |
Eugene Zelenko | a3fe70d | 2016-11-30 17:48:10 +0000 | [diff] [blame] | 68 | #include <cassert> |
| 69 | #include <climits> |
| 70 | #include <cstddef> |
| 71 | #include <cstdint> |
| 72 | #include <iterator> |
Chris Lattner | 5edb2f3 | 2004-10-18 04:07:22 +0000 | [diff] [blame] | 73 | #include <map> |
Chandler Carruth | ed0881b | 2012-12-03 16:50:05 +0000 | [diff] [blame] | 74 | #include <set> |
Eugene Zelenko | a3fe70d | 2016-11-30 17:48:10 +0000 | [diff] [blame] | 75 | #include <utility> |
| 76 | #include <vector> |
| 77 | |
Chris Lattner | df3c342 | 2004-01-09 06:12:26 +0000 | [diff] [blame] | 78 | using namespace llvm; |
Benjamin Kramer | 3717222 | 2013-07-04 14:22:02 +0000 | [diff] [blame] | 79 | using namespace PatternMatch; |
Brian Gaeke | 960707c | 2003-11-11 22:41:34 +0000 | [diff] [blame] | 80 | |
Chandler Carruth | 964daaa | 2014-04-22 02:55:47 +0000 | [diff] [blame] | 81 | #define DEBUG_TYPE "simplifycfg" |
| 82 | |
James Molloy | 1b6207e | 2015-02-13 10:48:30 +0000 | [diff] [blame] | 83 | // Chosen as 2 so as to be cheap, but still to have enough power to fold |
| 84 | // a select, so the "clamp" idiom (of a min followed by a max) will be caught. |
| 85 | // To catch this, we need to fold a compare and a select, hence '2' being the |
| 86 | // minimum reasonable default. |
Dehao Chen | f6c0083 | 2016-05-18 19:44:21 +0000 | [diff] [blame] | 87 | static cl::opt<unsigned> PHINodeFoldingThreshold( |
| 88 | "phi-node-folding-threshold", cl::Hidden, cl::init(2), |
| 89 | cl::desc( |
| 90 | "Control the amount of phi node folding to perform (default = 2)")); |
| 91 | |
| 92 | static cl::opt<bool> DupRet( |
| 93 | "simplifycfg-dup-ret", cl::Hidden, cl::init(false), |
| 94 | cl::desc("Duplicate return instructions into unconditional branches")); |
Peter Collingbourne | 616044a | 2011-04-29 18:47:38 +0000 | [diff] [blame] | 95 | |
Evan Cheng | d983eba | 2011-01-29 04:46:23 +0000 | [diff] [blame] | 96 | static cl::opt<bool> |
Dehao Chen | f6c0083 | 2016-05-18 19:44:21 +0000 | [diff] [blame] | 97 | SinkCommon("simplifycfg-sink-common", cl::Hidden, cl::init(true), |
| 98 | cl::desc("Sink common instructions down to the end block")); |
Manman Ren | 93ab649 | 2012-09-20 22:37:36 +0000 | [diff] [blame] | 99 | |
Alp Toker | cb40291 | 2014-01-24 17:20:08 +0000 | [diff] [blame] | 100 | static cl::opt<bool> HoistCondStores( |
| 101 | "simplifycfg-hoist-cond-stores", cl::Hidden, cl::init(true), |
| 102 | cl::desc("Hoist conditional stores if an unconditional store precedes")); |
Arnold Schwaighofer | 474df6d | 2013-04-29 21:28:24 +0000 | [diff] [blame] | 103 | |
James Molloy | 4de84dd | 2015-11-04 15:28:04 +0000 | [diff] [blame] | 104 | static cl::opt<bool> MergeCondStores( |
| 105 | "simplifycfg-merge-cond-stores", cl::Hidden, cl::init(true), |
| 106 | cl::desc("Hoist conditional stores even if an unconditional store does not " |
| 107 | "precede - hoist multiple conditional stores into a single " |
| 108 | "predicated store")); |
| 109 | |
| 110 | static cl::opt<bool> MergeCondStoresAggressively( |
| 111 | "simplifycfg-merge-cond-stores-aggressively", cl::Hidden, cl::init(false), |
| 112 | cl::desc("When merging conditional stores, do so even if the resultant " |
| 113 | "basic blocks are unlikely to be if-converted as a result")); |
| 114 | |
David Majnemer | fccf5c6 | 2016-01-27 02:59:41 +0000 | [diff] [blame] | 115 | static cl::opt<bool> SpeculateOneExpensiveInst( |
| 116 | "speculate-one-expensive-inst", cl::Hidden, cl::init(true), |
| 117 | cl::desc("Allow exactly one expensive instruction to be speculatively " |
| 118 | "executed")); |
| 119 | |
Sanjay Patel | 5264cc7 | 2016-01-27 19:22:45 +0000 | [diff] [blame] | 120 | static cl::opt<unsigned> MaxSpeculationDepth( |
| 121 | "max-speculation-depth", cl::Hidden, cl::init(10), |
| 122 | cl::desc("Limit maximum recursion depth when calculating costs of " |
| 123 | "speculatively executed instructions")); |
| 124 | |
Hans Wennborg | 39583b8 | 2012-09-26 09:44:49 +0000 | [diff] [blame] | 125 | STATISTIC(NumBitMaps, "Number of switch instructions turned into bitmaps"); |
Dehao Chen | f6c0083 | 2016-05-18 19:44:21 +0000 | [diff] [blame] | 126 | STATISTIC(NumLinearMaps, |
| 127 | "Number of switch instructions turned into linear mapping"); |
| 128 | STATISTIC(NumLookupTables, |
| 129 | "Number of switch instructions turned into lookup tables"); |
| 130 | STATISTIC( |
| 131 | NumLookupTablesHoles, |
| 132 | "Number of switch instructions turned into lookup tables (holes checked)"); |
Erik Eckstein | 0d86c76 | 2014-11-27 15:13:14 +0000 | [diff] [blame] | 133 | STATISTIC(NumTableCmpReuses, "Number of reused switch table lookup compares"); |
Dehao Chen | f6c0083 | 2016-05-18 19:44:21 +0000 | [diff] [blame] | 134 | STATISTIC(NumSinkCommons, |
| 135 | "Number of common instructions sunk down to the end block"); |
Hans Wennborg | cd3a11f | 2012-09-26 14:01:53 +0000 | [diff] [blame] | 136 | STATISTIC(NumSpeculations, "Number of speculative executed instructions"); |
Evan Cheng | 89553cc | 2008-06-12 21:15:59 +0000 | [diff] [blame] | 137 | |
Jakob Stoklund Olesen | 916f48a | 2010-02-05 22:03:18 +0000 | [diff] [blame] | 138 | namespace { |
Eugene Zelenko | a3fe70d | 2016-11-30 17:48:10 +0000 | [diff] [blame] | 139 | |
Dehao Chen | f6c0083 | 2016-05-18 19:44:21 +0000 | [diff] [blame] | 140 | // The first field contains the value that the switch produces when a certain |
| 141 | // case group is selected, and the second field is a vector containing the |
| 142 | // cases composing the case group. |
| 143 | typedef SmallVector<std::pair<Constant *, SmallVector<ConstantInt *, 4>>, 2> |
Marcello Maggioni | 5bbe3df | 2014-10-14 01:58:26 +0000 | [diff] [blame] | 144 | SwitchCaseResultVectorTy; |
Dehao Chen | f6c0083 | 2016-05-18 19:44:21 +0000 | [diff] [blame] | 145 | // The first field contains the phi node that generates a result of the switch |
| 146 | // and the second field contains the value generated for a certain case in the |
| 147 | // switch for that PHI. |
| 148 | typedef SmallVector<std::pair<PHINode *, Constant *>, 4> SwitchCaseResultsTy; |
Marcello Maggioni | 5bbe3df | 2014-10-14 01:58:26 +0000 | [diff] [blame] | 149 | |
Dehao Chen | f6c0083 | 2016-05-18 19:44:21 +0000 | [diff] [blame] | 150 | /// ValueEqualityComparisonCase - Represents a case of a switch. |
| 151 | struct ValueEqualityComparisonCase { |
| 152 | ConstantInt *Value; |
| 153 | BasicBlock *Dest; |
Eric Christopher | b65acc6 | 2012-07-02 23:22:21 +0000 | [diff] [blame] | 154 | |
Dehao Chen | f6c0083 | 2016-05-18 19:44:21 +0000 | [diff] [blame] | 155 | ValueEqualityComparisonCase(ConstantInt *Value, BasicBlock *Dest) |
Eric Christopher | b65acc6 | 2012-07-02 23:22:21 +0000 | [diff] [blame] | 156 | : Value(Value), Dest(Dest) {} |
| 157 | |
Dehao Chen | f6c0083 | 2016-05-18 19:44:21 +0000 | [diff] [blame] | 158 | bool operator<(ValueEqualityComparisonCase RHS) const { |
| 159 | // Comparing pointers is ok as we only rely on the order for uniquing. |
| 160 | return Value < RHS.Value; |
| 161 | } |
Benjamin Kramer | c5b0678 | 2012-10-14 11:15:42 +0000 | [diff] [blame] | 162 | |
Dehao Chen | f6c0083 | 2016-05-18 19:44:21 +0000 | [diff] [blame] | 163 | bool operator==(BasicBlock *RHSDest) const { return Dest == RHSDest; } |
| 164 | }; |
Eric Christopher | b65acc6 | 2012-07-02 23:22:21 +0000 | [diff] [blame] | 165 | |
Jakob Stoklund Olesen | 916f48a | 2010-02-05 22:03:18 +0000 | [diff] [blame] | 166 | class SimplifyCFGOpt { |
Chandler Carruth | 0b4ef9c | 2013-01-07 03:53:25 +0000 | [diff] [blame] | 167 | const TargetTransformInfo &TTI; |
Mehdi Amini | a28d91d | 2015-03-10 02:37:25 +0000 | [diff] [blame] | 168 | const DataLayout &DL; |
Jingyue Wu | fc02967 | 2014-09-30 22:23:38 +0000 | [diff] [blame] | 169 | unsigned BonusInstThreshold; |
Hyojin Sung | 4673f10 | 2016-03-29 04:08:57 +0000 | [diff] [blame] | 170 | SmallPtrSetImpl<BasicBlock *> *LoopHeaders; |
Jakob Stoklund Olesen | 916f48a | 2010-02-05 22:03:18 +0000 | [diff] [blame] | 171 | Value *isValueEqualityComparison(TerminatorInst *TI); |
Dehao Chen | f6c0083 | 2016-05-18 19:44:21 +0000 | [diff] [blame] | 172 | BasicBlock *GetValueEqualityComparisonCases( |
| 173 | TerminatorInst *TI, std::vector<ValueEqualityComparisonCase> &Cases); |
Jakob Stoklund Olesen | 916f48a | 2010-02-05 22:03:18 +0000 | [diff] [blame] | 174 | bool SimplifyEqualityComparisonWithOnlyPredecessor(TerminatorInst *TI, |
Devang Patel | a7ec47d | 2011-05-18 20:35:38 +0000 | [diff] [blame] | 175 | BasicBlock *Pred, |
| 176 | IRBuilder<> &Builder); |
Devang Patel | 5838055 | 2011-05-18 20:53:17 +0000 | [diff] [blame] | 177 | bool FoldValueComparisonIntoPredecessors(TerminatorInst *TI, |
| 178 | IRBuilder<> &Builder); |
Jakob Stoklund Olesen | 916f48a | 2010-02-05 22:03:18 +0000 | [diff] [blame] | 179 | |
Devang Patel | dd14e0f | 2011-05-18 21:33:11 +0000 | [diff] [blame] | 180 | bool SimplifyReturn(ReturnInst *RI, IRBuilder<> &Builder); |
Bill Wendling | d5d95b0 | 2012-02-06 21:16:41 +0000 | [diff] [blame] | 181 | bool SimplifyResume(ResumeInst *RI, IRBuilder<> &Builder); |
Chen Li | 1689c2f | 2016-01-10 05:48:01 +0000 | [diff] [blame] | 182 | bool SimplifySingleResume(ResumeInst *RI); |
| 183 | bool SimplifyCommonResume(ResumeInst *RI); |
Andrew Kaylor | 50e4e86 | 2015-09-04 23:39:40 +0000 | [diff] [blame] | 184 | bool SimplifyCleanupReturn(CleanupReturnInst *RI); |
Chris Lattner | 25c3af3 | 2010-12-13 06:25:44 +0000 | [diff] [blame] | 185 | bool SimplifyUnreachable(UnreachableInst *UI); |
Devang Patel | a7ec47d | 2011-05-18 20:35:38 +0000 | [diff] [blame] | 186 | bool SimplifySwitch(SwitchInst *SI, IRBuilder<> &Builder); |
Chris Lattner | 25c3af3 | 2010-12-13 06:25:44 +0000 | [diff] [blame] | 187 | bool SimplifyIndirectBr(IndirectBrInst *IBI); |
Dehao Chen | f6c0083 | 2016-05-18 19:44:21 +0000 | [diff] [blame] | 188 | bool SimplifyUncondBranch(BranchInst *BI, IRBuilder<> &Builder); |
| 189 | bool SimplifyCondBranch(BranchInst *BI, IRBuilder<> &Builder); |
Chris Lattner | 25c3af3 | 2010-12-13 06:25:44 +0000 | [diff] [blame] | 190 | |
Jakob Stoklund Olesen | 916f48a | 2010-02-05 22:03:18 +0000 | [diff] [blame] | 191 | public: |
Mehdi Amini | a28d91d | 2015-03-10 02:37:25 +0000 | [diff] [blame] | 192 | SimplifyCFGOpt(const TargetTransformInfo &TTI, const DataLayout &DL, |
Hal Finkel | 3ca4a6b | 2016-12-15 03:02:15 +0000 | [diff] [blame] | 193 | unsigned BonusInstThreshold, |
Hyojin Sung | 4673f10 | 2016-03-29 04:08:57 +0000 | [diff] [blame] | 194 | SmallPtrSetImpl<BasicBlock *> *LoopHeaders) |
Hal Finkel | 3ca4a6b | 2016-12-15 03:02:15 +0000 | [diff] [blame] | 195 | : TTI(TTI), DL(DL), BonusInstThreshold(BonusInstThreshold), |
Hyojin Sung | 4673f10 | 2016-03-29 04:08:57 +0000 | [diff] [blame] | 196 | LoopHeaders(LoopHeaders) {} |
Eugene Zelenko | a3fe70d | 2016-11-30 17:48:10 +0000 | [diff] [blame] | 197 | |
Jakob Stoklund Olesen | 916f48a | 2010-02-05 22:03:18 +0000 | [diff] [blame] | 198 | bool run(BasicBlock *BB); |
| 199 | }; |
Eugene Zelenko | a3fe70d | 2016-11-30 17:48:10 +0000 | [diff] [blame] | 200 | |
| 201 | } // end anonymous namespace |
Jakob Stoklund Olesen | 916f48a | 2010-02-05 22:03:18 +0000 | [diff] [blame] | 202 | |
Sanjay Patel | 09159b8f | 2015-06-24 20:40:57 +0000 | [diff] [blame] | 203 | /// Return true if it is safe to merge these two |
Chris Lattner | 76dc204 | 2005-08-03 00:19:45 +0000 | [diff] [blame] | 204 | /// terminator instructions together. |
James Molloy | e656642 | 2016-09-01 07:45:25 +0000 | [diff] [blame] | 205 | static bool |
| 206 | SafeToMergeTerminators(TerminatorInst *SI1, TerminatorInst *SI2, |
James Molloy | 2174468 | 2016-09-01 09:01:34 +0000 | [diff] [blame] | 207 | SmallSetVector<BasicBlock *, 4> *FailBlocks = nullptr) { |
Dehao Chen | f6c0083 | 2016-05-18 19:44:21 +0000 | [diff] [blame] | 208 | if (SI1 == SI2) |
| 209 | return false; // Can't merge with self! |
Andrew Trick | f3cf193 | 2012-08-29 21:46:36 +0000 | [diff] [blame] | 210 | |
Chris Lattner | 76dc204 | 2005-08-03 00:19:45 +0000 | [diff] [blame] | 211 | // It is not safe to merge these two switch instructions if they have a common |
| 212 | // successor, and if that successor has a PHI node, and if *that* PHI node has |
| 213 | // conflicting incoming values from the two switch blocks. |
| 214 | BasicBlock *SI1BB = SI1->getParent(); |
| 215 | BasicBlock *SI2BB = SI2->getParent(); |
James Molloy | 3c1137c | 2016-08-31 13:32:28 +0000 | [diff] [blame] | 216 | |
James Molloy | e656642 | 2016-09-01 07:45:25 +0000 | [diff] [blame] | 217 | SmallPtrSet<BasicBlock *, 16> SI1Succs(succ_begin(SI1BB), succ_end(SI1BB)); |
| 218 | bool Fail = false; |
Sanjay Patel | 5781d84 | 2016-03-12 16:52:17 +0000 | [diff] [blame] | 219 | for (BasicBlock *Succ : successors(SI2BB)) |
| 220 | if (SI1Succs.count(Succ)) |
| 221 | for (BasicBlock::iterator BBI = Succ->begin(); isa<PHINode>(BBI); ++BBI) { |
Chris Lattner | 76dc204 | 2005-08-03 00:19:45 +0000 | [diff] [blame] | 222 | PHINode *PN = cast<PHINode>(BBI); |
| 223 | if (PN->getIncomingValueForBlock(SI1BB) != |
James Molloy | e656642 | 2016-09-01 07:45:25 +0000 | [diff] [blame] | 224 | PN->getIncomingValueForBlock(SI2BB)) { |
| 225 | if (FailBlocks) |
| 226 | FailBlocks->insert(Succ); |
| 227 | Fail = true; |
| 228 | } |
Chris Lattner | 76dc204 | 2005-08-03 00:19:45 +0000 | [diff] [blame] | 229 | } |
Andrew Trick | f3cf193 | 2012-08-29 21:46:36 +0000 | [diff] [blame] | 230 | |
James Molloy | e656642 | 2016-09-01 07:45:25 +0000 | [diff] [blame] | 231 | return !Fail; |
Chris Lattner | 76dc204 | 2005-08-03 00:19:45 +0000 | [diff] [blame] | 232 | } |
| 233 | |
Sanjay Patel | 09159b8f | 2015-06-24 20:40:57 +0000 | [diff] [blame] | 234 | /// Return true if it is safe and profitable to merge these two terminator |
| 235 | /// instructions together, where SI1 is an unconditional branch. PhiNodes will |
| 236 | /// store all PHI nodes in common successors. |
Dehao Chen | f6c0083 | 2016-05-18 19:44:21 +0000 | [diff] [blame] | 237 | static bool |
| 238 | isProfitableToFoldUnconditional(BranchInst *SI1, BranchInst *SI2, |
| 239 | Instruction *Cond, |
| 240 | SmallVectorImpl<PHINode *> &PhiNodes) { |
| 241 | if (SI1 == SI2) |
| 242 | return false; // Can't merge with self! |
Manman Ren | d33f4ef | 2012-06-13 05:43:29 +0000 | [diff] [blame] | 243 | assert(SI1->isUnconditional() && SI2->isConditional()); |
| 244 | |
| 245 | // We fold the unconditional branch if we can easily update all PHI nodes in |
Andrew Trick | f3cf193 | 2012-08-29 21:46:36 +0000 | [diff] [blame] | 246 | // common successors: |
Manman Ren | d33f4ef | 2012-06-13 05:43:29 +0000 | [diff] [blame] | 247 | // 1> We have a constant incoming value for the conditional branch; |
| 248 | // 2> We have "Cond" as the incoming value for the unconditional branch; |
| 249 | // 3> SI2->getCondition() and Cond have same operands. |
| 250 | CmpInst *Ci2 = dyn_cast<CmpInst>(SI2->getCondition()); |
Dehao Chen | f6c0083 | 2016-05-18 19:44:21 +0000 | [diff] [blame] | 251 | if (!Ci2) |
| 252 | return false; |
Manman Ren | d33f4ef | 2012-06-13 05:43:29 +0000 | [diff] [blame] | 253 | if (!(Cond->getOperand(0) == Ci2->getOperand(0) && |
| 254 | Cond->getOperand(1) == Ci2->getOperand(1)) && |
| 255 | !(Cond->getOperand(0) == Ci2->getOperand(1) && |
| 256 | Cond->getOperand(1) == Ci2->getOperand(0))) |
| 257 | return false; |
| 258 | |
| 259 | BasicBlock *SI1BB = SI1->getParent(); |
| 260 | BasicBlock *SI2BB = SI2->getParent(); |
Dehao Chen | f6c0083 | 2016-05-18 19:44:21 +0000 | [diff] [blame] | 261 | SmallPtrSet<BasicBlock *, 16> SI1Succs(succ_begin(SI1BB), succ_end(SI1BB)); |
Sanjay Patel | 5781d84 | 2016-03-12 16:52:17 +0000 | [diff] [blame] | 262 | for (BasicBlock *Succ : successors(SI2BB)) |
| 263 | if (SI1Succs.count(Succ)) |
| 264 | for (BasicBlock::iterator BBI = Succ->begin(); isa<PHINode>(BBI); ++BBI) { |
Manman Ren | d33f4ef | 2012-06-13 05:43:29 +0000 | [diff] [blame] | 265 | PHINode *PN = cast<PHINode>(BBI); |
| 266 | if (PN->getIncomingValueForBlock(SI1BB) != Cond || |
Nick Lewycky | 0a045bb | 2012-06-24 10:15:42 +0000 | [diff] [blame] | 267 | !isa<ConstantInt>(PN->getIncomingValueForBlock(SI2BB))) |
Manman Ren | d33f4ef | 2012-06-13 05:43:29 +0000 | [diff] [blame] | 268 | return false; |
| 269 | PhiNodes.push_back(PN); |
| 270 | } |
| 271 | return true; |
| 272 | } |
| 273 | |
Sanjay Patel | 09159b8f | 2015-06-24 20:40:57 +0000 | [diff] [blame] | 274 | /// Update PHI nodes in Succ to indicate that there will now be entries in it |
| 275 | /// from the 'NewPred' block. The values that will be flowing into the PHI nodes |
| 276 | /// will be the same as those coming in from ExistPred, an existing predecessor |
| 277 | /// of Succ. |
Chris Lattner | 76dc204 | 2005-08-03 00:19:45 +0000 | [diff] [blame] | 278 | static void AddPredecessorToBlock(BasicBlock *Succ, BasicBlock *NewPred, |
| 279 | BasicBlock *ExistPred) { |
Dehao Chen | f6c0083 | 2016-05-18 19:44:21 +0000 | [diff] [blame] | 280 | if (!isa<PHINode>(Succ->begin())) |
| 281 | return; // Quick exit if nothing to do |
Andrew Trick | f3cf193 | 2012-08-29 21:46:36 +0000 | [diff] [blame] | 282 | |
Chris Lattner | 80b03a1 | 2008-07-13 22:23:11 +0000 | [diff] [blame] | 283 | PHINode *PN; |
Sanjay Patel | 5781d84 | 2016-03-12 16:52:17 +0000 | [diff] [blame] | 284 | for (BasicBlock::iterator I = Succ->begin(); (PN = dyn_cast<PHINode>(I)); ++I) |
Chris Lattner | 80b03a1 | 2008-07-13 22:23:11 +0000 | [diff] [blame] | 285 | PN->addIncoming(PN->getIncomingValueForBlock(ExistPred), NewPred); |
Chris Lattner | 76dc204 | 2005-08-03 00:19:45 +0000 | [diff] [blame] | 286 | } |
| 287 | |
Sanjay Patel | 09159b8f | 2015-06-24 20:40:57 +0000 | [diff] [blame] | 288 | /// Compute an abstract "cost" of speculating the given instruction, |
| 289 | /// which is assumed to be safe to speculate. TCC_Free means cheap, |
| 290 | /// TCC_Basic means less cheap, and TCC_Expensive means prohibitively |
James Molloy | 7c33657 | 2015-02-11 12:15:41 +0000 | [diff] [blame] | 291 | /// expensive. |
Mehdi Amini | a28d91d | 2015-03-10 02:37:25 +0000 | [diff] [blame] | 292 | static unsigned ComputeSpeculationCost(const User *I, |
James Molloy | 7c33657 | 2015-02-11 12:15:41 +0000 | [diff] [blame] | 293 | const TargetTransformInfo &TTI) { |
Mehdi Amini | a28d91d | 2015-03-10 02:37:25 +0000 | [diff] [blame] | 294 | assert(isSafeToSpeculativelyExecute(I) && |
Dan Gohman | 5ab9c0a | 2012-01-05 23:58:56 +0000 | [diff] [blame] | 295 | "Instruction is not safe to speculatively execute!"); |
James Molloy | 7c33657 | 2015-02-11 12:15:41 +0000 | [diff] [blame] | 296 | return TTI.getUserCost(I); |
Dan Gohman | 5ab9c0a | 2012-01-05 23:58:56 +0000 | [diff] [blame] | 297 | } |
Sanjay Patel | f9b7763 | 2015-09-15 15:24:42 +0000 | [diff] [blame] | 298 | |
Sanjay Patel | 09159b8f | 2015-06-24 20:40:57 +0000 | [diff] [blame] | 299 | /// If we have a merge point of an "if condition" as accepted above, |
| 300 | /// return true if the specified value dominates the block. We |
Bill Wendling | caf1d22 | 2009-01-19 23:43:56 +0000 | [diff] [blame] | 301 | /// don't handle the true generality of domination here, just a special case |
| 302 | /// which works well enough for us. |
| 303 | /// |
| 304 | /// If AggressiveInsts is non-null, and if V does not dominate BB, we check to |
Peter Collingbourne | e3511e1 | 2011-04-29 18:47:31 +0000 | [diff] [blame] | 305 | /// see if V (which must be an instruction) and its recursive operands |
| 306 | /// that do not dominate BB have a combined cost lower than CostRemaining and |
| 307 | /// are non-trapping. If both are true, the instruction is inserted into the |
| 308 | /// set and true is returned. |
| 309 | /// |
| 310 | /// The cost for most non-trapping instructions is defined as 1 except for |
| 311 | /// Select whose cost is 2. |
| 312 | /// |
| 313 | /// After this function returns, CostRemaining is decreased by the cost of |
| 314 | /// V plus its non-dominating operands. If that cost is greater than |
| 315 | /// CostRemaining, false is returned and CostRemaining is undefined. |
Chris Lattner | 45c35b1 | 2004-10-14 05:13:36 +0000 | [diff] [blame] | 316 | static bool DominatesMergePoint(Value *V, BasicBlock *BB, |
Dehao Chen | f6c0083 | 2016-05-18 19:44:21 +0000 | [diff] [blame] | 317 | SmallPtrSetImpl<Instruction *> *AggressiveInsts, |
Hal Finkel | a995f92 | 2014-07-10 14:41:31 +0000 | [diff] [blame] | 318 | unsigned &CostRemaining, |
David Majnemer | fccf5c6 | 2016-01-27 02:59:41 +0000 | [diff] [blame] | 319 | const TargetTransformInfo &TTI, |
| 320 | unsigned Depth = 0) { |
Sanjay Patel | 5264cc7 | 2016-01-27 19:22:45 +0000 | [diff] [blame] | 321 | // It is possible to hit a zero-cost cycle (phi/gep instructions for example), |
| 322 | // so limit the recursion depth. |
| 323 | // TODO: While this recursion limit does prevent pathological behavior, it |
| 324 | // would be better to track visited instructions to avoid cycles. |
| 325 | if (Depth == MaxSpeculationDepth) |
| 326 | return false; |
| 327 | |
Chris Lattner | 0aa5656 | 2004-04-09 22:50:22 +0000 | [diff] [blame] | 328 | Instruction *I = dyn_cast<Instruction>(V); |
Chris Lattner | b8b1159 | 2006-10-20 00:42:07 +0000 | [diff] [blame] | 329 | if (!I) { |
| 330 | // Non-instructions all dominate instructions, but not all constantexprs |
| 331 | // can be executed unconditionally. |
| 332 | if (ConstantExpr *C = dyn_cast<ConstantExpr>(V)) |
| 333 | if (C->canTrap()) |
| 334 | return false; |
| 335 | return true; |
| 336 | } |
Chris Lattner | 0aa5656 | 2004-04-09 22:50:22 +0000 | [diff] [blame] | 337 | BasicBlock *PBB = I->getParent(); |
Chris Lattner | 18d1f19 | 2004-02-11 03:36:04 +0000 | [diff] [blame] | 338 | |
Chris Lattner | 0ce80cd | 2005-02-27 06:18:25 +0000 | [diff] [blame] | 339 | // We don't want to allow weird loops that might have the "if condition" in |
Chris Lattner | 0aa5656 | 2004-04-09 22:50:22 +0000 | [diff] [blame] | 340 | // the bottom of this block. |
Dehao Chen | f6c0083 | 2016-05-18 19:44:21 +0000 | [diff] [blame] | 341 | if (PBB == BB) |
| 342 | return false; |
Chris Lattner | 18d1f19 | 2004-02-11 03:36:04 +0000 | [diff] [blame] | 343 | |
Chris Lattner | 0aa5656 | 2004-04-09 22:50:22 +0000 | [diff] [blame] | 344 | // If this instruction is defined in a block that contains an unconditional |
| 345 | // branch to BB, then it must be in the 'conditional' part of the "if |
Chris Lattner | 9ac168d | 2010-12-14 07:41:39 +0000 | [diff] [blame] | 346 | // statement". If not, it definitely dominates the region. |
| 347 | BranchInst *BI = dyn_cast<BranchInst>(PBB->getTerminator()); |
Craig Topper | f40110f | 2014-04-25 05:29:35 +0000 | [diff] [blame] | 348 | if (!BI || BI->isConditional() || BI->getSuccessor(0) != BB) |
Chris Lattner | 9ac168d | 2010-12-14 07:41:39 +0000 | [diff] [blame] | 349 | return true; |
Eli Friedman | b8f6a4f | 2009-07-17 04:28:42 +0000 | [diff] [blame] | 350 | |
Chris Lattner | 9ac168d | 2010-12-14 07:41:39 +0000 | [diff] [blame] | 351 | // If we aren't allowing aggressive promotion anymore, then don't consider |
| 352 | // instructions in the 'if region'. |
Dehao Chen | f6c0083 | 2016-05-18 19:44:21 +0000 | [diff] [blame] | 353 | if (!AggressiveInsts) |
| 354 | return false; |
Andrew Trick | f3cf193 | 2012-08-29 21:46:36 +0000 | [diff] [blame] | 355 | |
Peter Collingbourne | e3511e1 | 2011-04-29 18:47:31 +0000 | [diff] [blame] | 356 | // If we have seen this instruction before, don't count it again. |
Dehao Chen | f6c0083 | 2016-05-18 19:44:21 +0000 | [diff] [blame] | 357 | if (AggressiveInsts->count(I)) |
| 358 | return true; |
Peter Collingbourne | e3511e1 | 2011-04-29 18:47:31 +0000 | [diff] [blame] | 359 | |
Chris Lattner | 9ac168d | 2010-12-14 07:41:39 +0000 | [diff] [blame] | 360 | // Okay, it looks like the instruction IS in the "condition". Check to |
| 361 | // see if it's a cheap instruction to unconditionally compute, and if it |
| 362 | // only uses stuff defined outside of the condition. If so, hoist it out. |
Mehdi Amini | a28d91d | 2015-03-10 02:37:25 +0000 | [diff] [blame] | 363 | if (!isSafeToSpeculativelyExecute(I)) |
Chris Lattner | 9ac168d | 2010-12-14 07:41:39 +0000 | [diff] [blame] | 364 | return false; |
Misha Brukman | b1c9317 | 2005-04-21 23:48:37 +0000 | [diff] [blame] | 365 | |
Mehdi Amini | a28d91d | 2015-03-10 02:37:25 +0000 | [diff] [blame] | 366 | unsigned Cost = ComputeSpeculationCost(I, TTI); |
Chris Lattner | 0aa5656 | 2004-04-09 22:50:22 +0000 | [diff] [blame] | 367 | |
David Majnemer | fccf5c6 | 2016-01-27 02:59:41 +0000 | [diff] [blame] | 368 | // Allow exactly one instruction to be speculated regardless of its cost |
| 369 | // (as long as it is safe to do so). |
| 370 | // This is intended to flatten the CFG even if the instruction is a division |
| 371 | // or other expensive operation. The speculation of an expensive instruction |
| 372 | // is expected to be undone in CodeGenPrepare if the speculation has not |
| 373 | // enabled further IR optimizations. |
| 374 | if (Cost > CostRemaining && |
| 375 | (!SpeculateOneExpensiveInst || !AggressiveInsts->empty() || Depth > 0)) |
Peter Collingbourne | e3511e1 | 2011-04-29 18:47:31 +0000 | [diff] [blame] | 376 | return false; |
| 377 | |
David Majnemer | fccf5c6 | 2016-01-27 02:59:41 +0000 | [diff] [blame] | 378 | // Avoid unsigned wrap. |
| 379 | CostRemaining = (Cost > CostRemaining) ? 0 : CostRemaining - Cost; |
Peter Collingbourne | e3511e1 | 2011-04-29 18:47:31 +0000 | [diff] [blame] | 380 | |
| 381 | // Okay, we can only really hoist these out if their operands do |
| 382 | // not take us over the cost threshold. |
Chris Lattner | 9ac168d | 2010-12-14 07:41:39 +0000 | [diff] [blame] | 383 | for (User::op_iterator i = I->op_begin(), e = I->op_end(); i != e; ++i) |
David Majnemer | fccf5c6 | 2016-01-27 02:59:41 +0000 | [diff] [blame] | 384 | if (!DominatesMergePoint(*i, BB, AggressiveInsts, CostRemaining, TTI, |
| 385 | Depth + 1)) |
Chris Lattner | 9ac168d | 2010-12-14 07:41:39 +0000 | [diff] [blame] | 386 | return false; |
| 387 | // Okay, it's safe to do this! Remember this instruction. |
| 388 | AggressiveInsts->insert(I); |
Chris Lattner | 18d1f19 | 2004-02-11 03:36:04 +0000 | [diff] [blame] | 389 | return true; |
| 390 | } |
Chris Lattner | 466a049 | 2002-05-21 20:50:24 +0000 | [diff] [blame] | 391 | |
Sanjay Patel | 09159b8f | 2015-06-24 20:40:57 +0000 | [diff] [blame] | 392 | /// Extract ConstantInt from value, looking through IntToPtr |
Jakob Stoklund Olesen | 916f48a | 2010-02-05 22:03:18 +0000 | [diff] [blame] | 393 | /// and PointerNullValue. Return NULL if value is not a constant int. |
Mehdi Amini | a28d91d | 2015-03-10 02:37:25 +0000 | [diff] [blame] | 394 | static ConstantInt *GetConstantInt(Value *V, const DataLayout &DL) { |
Jakob Stoklund Olesen | 916f48a | 2010-02-05 22:03:18 +0000 | [diff] [blame] | 395 | // Normal constant int. |
| 396 | ConstantInt *CI = dyn_cast<ConstantInt>(V); |
Mehdi Amini | a28d91d | 2015-03-10 02:37:25 +0000 | [diff] [blame] | 397 | if (CI || !isa<Constant>(V) || !V->getType()->isPointerTy()) |
Jakob Stoklund Olesen | 916f48a | 2010-02-05 22:03:18 +0000 | [diff] [blame] | 398 | return CI; |
| 399 | |
| 400 | // This is some kind of pointer constant. Turn it into a pointer-sized |
| 401 | // ConstantInt if possible. |
Mehdi Amini | a28d91d | 2015-03-10 02:37:25 +0000 | [diff] [blame] | 402 | IntegerType *PtrTy = cast<IntegerType>(DL.getIntPtrType(V->getType())); |
Jakob Stoklund Olesen | 916f48a | 2010-02-05 22:03:18 +0000 | [diff] [blame] | 403 | |
| 404 | // Null pointer means 0, see SelectionDAGBuilder::getValue(const Value*). |
| 405 | if (isa<ConstantPointerNull>(V)) |
| 406 | return ConstantInt::get(PtrTy, 0); |
| 407 | |
| 408 | // IntToPtr const int. |
| 409 | if (ConstantExpr *CE = dyn_cast<ConstantExpr>(V)) |
| 410 | if (CE->getOpcode() == Instruction::IntToPtr) |
| 411 | if (ConstantInt *CI = dyn_cast<ConstantInt>(CE->getOperand(0))) { |
| 412 | // The constant is very likely to have the right type already. |
| 413 | if (CI->getType() == PtrTy) |
| 414 | return CI; |
| 415 | else |
Dehao Chen | f6c0083 | 2016-05-18 19:44:21 +0000 | [diff] [blame] | 416 | return cast<ConstantInt>( |
| 417 | ConstantExpr::getIntegerCast(CI, PtrTy, /*isSigned=*/false)); |
Jakob Stoklund Olesen | 916f48a | 2010-02-05 22:03:18 +0000 | [diff] [blame] | 418 | } |
Craig Topper | f40110f | 2014-04-25 05:29:35 +0000 | [diff] [blame] | 419 | return nullptr; |
Jakob Stoklund Olesen | 916f48a | 2010-02-05 22:03:18 +0000 | [diff] [blame] | 420 | } |
| 421 | |
Mehdi Amini | ffd0100 | 2014-11-20 22:40:25 +0000 | [diff] [blame] | 422 | namespace { |
Mehdi Amini | 9a25cb8 | 2014-11-19 20:09:11 +0000 | [diff] [blame] | 423 | |
Mehdi Amini | ffd0100 | 2014-11-20 22:40:25 +0000 | [diff] [blame] | 424 | /// Given a chain of or (||) or and (&&) comparison of a value against a |
| 425 | /// constant, this will try to recover the information required for a switch |
| 426 | /// structure. |
| 427 | /// It will depth-first traverse the chain of comparison, seeking for patterns |
| 428 | /// like %a == 12 or %a < 4 and combine them to produce a set of integer |
| 429 | /// representing the different cases for the switch. |
| 430 | /// Note that if the chain is composed of '||' it will build the set of elements |
| 431 | /// that matches the comparisons (i.e. any of this value validate the chain) |
| 432 | /// while for a chain of '&&' it will build the set elements that make the test |
| 433 | /// fail. |
| 434 | struct ConstantComparesGatherer { |
Mehdi Amini | a28d91d | 2015-03-10 02:37:25 +0000 | [diff] [blame] | 435 | const DataLayout &DL; |
Mehdi Amini | ffd0100 | 2014-11-20 22:40:25 +0000 | [diff] [blame] | 436 | Value *CompValue; /// Value found for the switch comparison |
| 437 | Value *Extra; /// Extra clause to be checked before the switch |
| 438 | SmallVector<ConstantInt *, 8> Vals; /// Set of integers to match in switch |
| 439 | unsigned UsedICmps; /// Number of comparisons matched in the and/or chain |
Timur Iskhodzhanov | 71526a3 | 2014-11-20 12:36:43 +0000 | [diff] [blame] | 440 | |
Mehdi Amini | ffd0100 | 2014-11-20 22:40:25 +0000 | [diff] [blame] | 441 | /// Construct and compute the result for the comparison instruction Cond |
Mehdi Amini | a28d91d | 2015-03-10 02:37:25 +0000 | [diff] [blame] | 442 | ConstantComparesGatherer(Instruction *Cond, const DataLayout &DL) |
| 443 | : DL(DL), CompValue(nullptr), Extra(nullptr), UsedICmps(0) { |
| 444 | gather(Cond); |
Mehdi Amini | 9a25cb8 | 2014-11-19 20:09:11 +0000 | [diff] [blame] | 445 | } |
| 446 | |
Mehdi Amini | ffd0100 | 2014-11-20 22:40:25 +0000 | [diff] [blame] | 447 | /// Prevent copy |
Aaron Ballman | f9a1897 | 2015-02-15 22:54:22 +0000 | [diff] [blame] | 448 | ConstantComparesGatherer(const ConstantComparesGatherer &) = delete; |
Mehdi Amini | ffd0100 | 2014-11-20 22:40:25 +0000 | [diff] [blame] | 449 | ConstantComparesGatherer & |
Aaron Ballman | f9a1897 | 2015-02-15 22:54:22 +0000 | [diff] [blame] | 450 | operator=(const ConstantComparesGatherer &) = delete; |
Mehdi Amini | 9a25cb8 | 2014-11-19 20:09:11 +0000 | [diff] [blame] | 451 | |
Mehdi Amini | ffd0100 | 2014-11-20 22:40:25 +0000 | [diff] [blame] | 452 | private: |
Mehdi Amini | ffd0100 | 2014-11-20 22:40:25 +0000 | [diff] [blame] | 453 | /// Try to set the current value used for the comparison, it succeeds only if |
| 454 | /// it wasn't set before or if the new value is the same as the old one |
| 455 | bool setValueOnce(Value *NewVal) { |
Dehao Chen | f6c0083 | 2016-05-18 19:44:21 +0000 | [diff] [blame] | 456 | if (CompValue && CompValue != NewVal) |
| 457 | return false; |
Mehdi Amini | ffd0100 | 2014-11-20 22:40:25 +0000 | [diff] [blame] | 458 | CompValue = NewVal; |
| 459 | return (CompValue != nullptr); |
| 460 | } |
| 461 | |
| 462 | /// Try to match Instruction "I" as a comparison against a constant and |
| 463 | /// populates the array Vals with the set of values that match (or do not |
| 464 | /// match depending on isEQ). |
| 465 | /// Return false on failure. On success, the Value the comparison matched |
| 466 | /// against is placed in CompValue. |
| 467 | /// If CompValue is already set, the function is expected to fail if a match |
| 468 | /// is found but the value compared to is different. |
Mehdi Amini | a28d91d | 2015-03-10 02:37:25 +0000 | [diff] [blame] | 469 | bool matchInstruction(Instruction *I, bool isEQ) { |
Mehdi Amini | ffd0100 | 2014-11-20 22:40:25 +0000 | [diff] [blame] | 470 | // If this is an icmp against a constant, handle this as one of the cases. |
| 471 | ICmpInst *ICI; |
| 472 | ConstantInt *C; |
| 473 | if (!((ICI = dyn_cast<ICmpInst>(I)) && |
Dehao Chen | f6c0083 | 2016-05-18 19:44:21 +0000 | [diff] [blame] | 474 | (C = GetConstantInt(I->getOperand(1), DL)))) { |
Mehdi Amini | ffd0100 | 2014-11-20 22:40:25 +0000 | [diff] [blame] | 475 | return false; |
| 476 | } |
| 477 | |
| 478 | Value *RHSVal; |
Chuang-Yu Cheng | 5078f94 | 2016-06-17 00:04:39 +0000 | [diff] [blame] | 479 | const APInt *RHSC; |
Mehdi Amini | ffd0100 | 2014-11-20 22:40:25 +0000 | [diff] [blame] | 480 | |
| 481 | // Pattern match a special case |
David Majnemer | c761afd | 2016-01-27 02:43:28 +0000 | [diff] [blame] | 482 | // (x & ~2^z) == y --> x == y || x == y|2^z |
Mehdi Amini | ffd0100 | 2014-11-20 22:40:25 +0000 | [diff] [blame] | 483 | // This undoes a transformation done by instcombine to fuse 2 compares. |
Dehao Chen | f6c0083 | 2016-05-18 19:44:21 +0000 | [diff] [blame] | 484 | if (ICI->getPredicate() == (isEQ ? ICmpInst::ICMP_EQ : ICmpInst::ICMP_NE)) { |
Chuang-Yu Cheng | dbe00d5 | 2016-06-16 04:44:25 +0000 | [diff] [blame] | 485 | |
| 486 | // It's a little bit hard to see why the following transformations are |
| 487 | // correct. Here is a CVC3 program to verify them for 64-bit values: |
| 488 | |
| 489 | /* |
| 490 | ONE : BITVECTOR(64) = BVZEROEXTEND(0bin1, 63); |
| 491 | x : BITVECTOR(64); |
| 492 | y : BITVECTOR(64); |
| 493 | z : BITVECTOR(64); |
| 494 | mask : BITVECTOR(64) = BVSHL(ONE, z); |
| 495 | QUERY( (y & ~mask = y) => |
| 496 | ((x & ~mask = y) <=> (x = y OR x = (y | mask))) |
| 497 | ); |
Chuang-Yu Cheng | 68f7f1c | 2016-06-24 01:59:00 +0000 | [diff] [blame] | 498 | QUERY( (y | mask = y) => |
| 499 | ((x | mask = y) <=> (x = y OR x = (y & ~mask))) |
| 500 | ); |
Chuang-Yu Cheng | dbe00d5 | 2016-06-16 04:44:25 +0000 | [diff] [blame] | 501 | */ |
| 502 | |
| 503 | // Please note that each pattern must be a dual implication (<--> or |
| 504 | // iff). One directional implication can create spurious matches. If the |
| 505 | // implication is only one-way, an unsatisfiable condition on the left |
| 506 | // side can imply a satisfiable condition on the right side. Dual |
| 507 | // implication ensures that satisfiable conditions are transformed to |
| 508 | // other satisfiable conditions and unsatisfiable conditions are |
| 509 | // transformed to other unsatisfiable conditions. |
| 510 | |
| 511 | // Here is a concrete example of a unsatisfiable condition on the left |
| 512 | // implying a satisfiable condition on the right: |
| 513 | // |
| 514 | // mask = (1 << z) |
| 515 | // (x & ~mask) == y --> (x == y || x == (y | mask)) |
| 516 | // |
| 517 | // Substituting y = 3, z = 0 yields: |
| 518 | // (x & -2) == 3 --> (x == 3 || x == 2) |
| 519 | |
| 520 | // Pattern match a special case: |
| 521 | /* |
| 522 | QUERY( (y & ~mask = y) => |
| 523 | ((x & ~mask = y) <=> (x = y OR x = (y | mask))) |
| 524 | ); |
| 525 | */ |
Mehdi Amini | ffd0100 | 2014-11-20 22:40:25 +0000 | [diff] [blame] | 526 | if (match(ICI->getOperand(0), |
Chuang-Yu Cheng | 5078f94 | 2016-06-17 00:04:39 +0000 | [diff] [blame] | 527 | m_And(m_Value(RHSVal), m_APInt(RHSC)))) { |
| 528 | APInt Mask = ~*RHSC; |
Chuang-Yu Cheng | dbe00d5 | 2016-06-16 04:44:25 +0000 | [diff] [blame] | 529 | if (Mask.isPowerOf2() && (C->getValue() & ~Mask) == C->getValue()) { |
Mehdi Amini | ffd0100 | 2014-11-20 22:40:25 +0000 | [diff] [blame] | 530 | // If we already have a value for the switch, it has to match! |
Dehao Chen | f6c0083 | 2016-05-18 19:44:21 +0000 | [diff] [blame] | 531 | if (!setValueOnce(RHSVal)) |
Mehdi Amini | ffd0100 | 2014-11-20 22:40:25 +0000 | [diff] [blame] | 532 | return false; |
| 533 | |
| 534 | Vals.push_back(C); |
Dehao Chen | f6c0083 | 2016-05-18 19:44:21 +0000 | [diff] [blame] | 535 | Vals.push_back( |
Chuang-Yu Cheng | dbe00d5 | 2016-06-16 04:44:25 +0000 | [diff] [blame] | 536 | ConstantInt::get(C->getContext(), |
| 537 | C->getValue() | Mask)); |
Mehdi Amini | ffd0100 | 2014-11-20 22:40:25 +0000 | [diff] [blame] | 538 | UsedICmps++; |
| 539 | return true; |
| 540 | } |
Mehdi Amini | 9a25cb8 | 2014-11-19 20:09:11 +0000 | [diff] [blame] | 541 | } |
Mehdi Amini | ffd0100 | 2014-11-20 22:40:25 +0000 | [diff] [blame] | 542 | |
Chuang-Yu Cheng | 68f7f1c | 2016-06-24 01:59:00 +0000 | [diff] [blame] | 543 | // Pattern match a special case: |
| 544 | /* |
| 545 | QUERY( (y | mask = y) => |
| 546 | ((x | mask = y) <=> (x = y OR x = (y & ~mask))) |
| 547 | ); |
| 548 | */ |
| 549 | if (match(ICI->getOperand(0), |
| 550 | m_Or(m_Value(RHSVal), m_APInt(RHSC)))) { |
| 551 | APInt Mask = *RHSC; |
| 552 | if (Mask.isPowerOf2() && (C->getValue() | Mask) == C->getValue()) { |
| 553 | // If we already have a value for the switch, it has to match! |
| 554 | if (!setValueOnce(RHSVal)) |
| 555 | return false; |
| 556 | |
| 557 | Vals.push_back(C); |
| 558 | Vals.push_back(ConstantInt::get(C->getContext(), |
| 559 | C->getValue() & ~Mask)); |
| 560 | UsedICmps++; |
| 561 | return true; |
| 562 | } |
| 563 | } |
| 564 | |
Mehdi Amini | ffd0100 | 2014-11-20 22:40:25 +0000 | [diff] [blame] | 565 | // If we already have a value for the switch, it has to match! |
Dehao Chen | f6c0083 | 2016-05-18 19:44:21 +0000 | [diff] [blame] | 566 | if (!setValueOnce(ICI->getOperand(0))) |
Mehdi Amini | ffd0100 | 2014-11-20 22:40:25 +0000 | [diff] [blame] | 567 | return false; |
| 568 | |
| 569 | UsedICmps++; |
| 570 | Vals.push_back(C); |
| 571 | return ICI->getOperand(0); |
| 572 | } |
| 573 | |
| 574 | // If we have "x ult 3", for example, then we can add 0,1,2 to the set. |
Sanjoy Das | 7182d36 | 2015-03-18 00:41:24 +0000 | [diff] [blame] | 575 | ConstantRange Span = ConstantRange::makeAllowedICmpRegion( |
| 576 | ICI->getPredicate(), C->getValue()); |
Mehdi Amini | ffd0100 | 2014-11-20 22:40:25 +0000 | [diff] [blame] | 577 | |
| 578 | // Shift the range if the compare is fed by an add. This is the range |
| 579 | // compare idiom as emitted by instcombine. |
| 580 | Value *CandidateVal = I->getOperand(0); |
Chuang-Yu Cheng | 5078f94 | 2016-06-17 00:04:39 +0000 | [diff] [blame] | 581 | if (match(I->getOperand(0), m_Add(m_Value(RHSVal), m_APInt(RHSC)))) { |
| 582 | Span = Span.subtract(*RHSC); |
Mehdi Amini | ffd0100 | 2014-11-20 22:40:25 +0000 | [diff] [blame] | 583 | CandidateVal = RHSVal; |
| 584 | } |
| 585 | |
| 586 | // If this is an and/!= check, then we are looking to build the set of |
| 587 | // value that *don't* pass the and chain. I.e. to turn "x ugt 2" into |
| 588 | // x != 0 && x != 1. |
| 589 | if (!isEQ) |
| 590 | Span = Span.inverse(); |
| 591 | |
| 592 | // If there are a ton of values, we don't want to make a ginormous switch. |
| 593 | if (Span.getSetSize().ugt(8) || Span.isEmptySet()) { |
| 594 | return false; |
Mehdi Amini | 9a25cb8 | 2014-11-19 20:09:11 +0000 | [diff] [blame] | 595 | } |
| 596 | |
| 597 | // If we already have a value for the switch, it has to match! |
Dehao Chen | f6c0083 | 2016-05-18 19:44:21 +0000 | [diff] [blame] | 598 | if (!setValueOnce(CandidateVal)) |
Mehdi Amini | ffd0100 | 2014-11-20 22:40:25 +0000 | [diff] [blame] | 599 | return false; |
| 600 | |
| 601 | // Add all values from the range to the set |
| 602 | for (APInt Tmp = Span.getLower(); Tmp != Span.getUpper(); ++Tmp) |
| 603 | Vals.push_back(ConstantInt::get(I->getContext(), Tmp)); |
Mehdi Amini | 9a25cb8 | 2014-11-19 20:09:11 +0000 | [diff] [blame] | 604 | |
| 605 | UsedICmps++; |
Mehdi Amini | ffd0100 | 2014-11-20 22:40:25 +0000 | [diff] [blame] | 606 | return true; |
Mehdi Amini | 9a25cb8 | 2014-11-19 20:09:11 +0000 | [diff] [blame] | 607 | } |
| 608 | |
Sanjay Patel | 09159b8f | 2015-06-24 20:40:57 +0000 | [diff] [blame] | 609 | /// Given a potentially 'or'd or 'and'd together collection of icmp |
Mehdi Amini | ffd0100 | 2014-11-20 22:40:25 +0000 | [diff] [blame] | 610 | /// eq/ne/lt/gt instructions that compare a value against a constant, extract |
| 611 | /// the value being compared, and stick the list constants into the Vals |
| 612 | /// vector. |
| 613 | /// One "Extra" case is allowed to differ from the other. |
Mehdi Amini | a28d91d | 2015-03-10 02:37:25 +0000 | [diff] [blame] | 614 | void gather(Value *V) { |
Mehdi Amini | ffd0100 | 2014-11-20 22:40:25 +0000 | [diff] [blame] | 615 | Instruction *I = dyn_cast<Instruction>(V); |
| 616 | bool isEQ = (I->getOpcode() == Instruction::Or); |
Mehdi Amini | 9a25cb8 | 2014-11-19 20:09:11 +0000 | [diff] [blame] | 617 | |
Mehdi Amini | ffd0100 | 2014-11-20 22:40:25 +0000 | [diff] [blame] | 618 | // Keep a stack (SmallVector for efficiency) for depth-first traversal |
| 619 | SmallVector<Value *, 8> DFT; |
Gerolf Hoflehner | 2432bd0 | 2016-02-03 23:54:25 +0000 | [diff] [blame] | 620 | SmallPtrSet<Value *, 8> Visited; |
Mehdi Amini | 9a25cb8 | 2014-11-19 20:09:11 +0000 | [diff] [blame] | 621 | |
Mehdi Amini | ffd0100 | 2014-11-20 22:40:25 +0000 | [diff] [blame] | 622 | // Initialize |
Gerolf Hoflehner | 2432bd0 | 2016-02-03 23:54:25 +0000 | [diff] [blame] | 623 | Visited.insert(V); |
Mehdi Amini | ffd0100 | 2014-11-20 22:40:25 +0000 | [diff] [blame] | 624 | DFT.push_back(V); |
Mehdi Amini | 9a25cb8 | 2014-11-19 20:09:11 +0000 | [diff] [blame] | 625 | |
Dehao Chen | f6c0083 | 2016-05-18 19:44:21 +0000 | [diff] [blame] | 626 | while (!DFT.empty()) { |
Mehdi Amini | ffd0100 | 2014-11-20 22:40:25 +0000 | [diff] [blame] | 627 | V = DFT.pop_back_val(); |
Mehdi Amini | 9a25cb8 | 2014-11-19 20:09:11 +0000 | [diff] [blame] | 628 | |
Mehdi Amini | ffd0100 | 2014-11-20 22:40:25 +0000 | [diff] [blame] | 629 | if (Instruction *I = dyn_cast<Instruction>(V)) { |
| 630 | // If it is a || (or && depending on isEQ), process the operands. |
| 631 | if (I->getOpcode() == (isEQ ? Instruction::Or : Instruction::And)) { |
Gerolf Hoflehner | 2432bd0 | 2016-02-03 23:54:25 +0000 | [diff] [blame] | 632 | if (Visited.insert(I->getOperand(1)).second) |
| 633 | DFT.push_back(I->getOperand(1)); |
| 634 | if (Visited.insert(I->getOperand(0)).second) |
| 635 | DFT.push_back(I->getOperand(0)); |
Mehdi Amini | ffd0100 | 2014-11-20 22:40:25 +0000 | [diff] [blame] | 636 | continue; |
| 637 | } |
Mehdi Amini | 9a25cb8 | 2014-11-19 20:09:11 +0000 | [diff] [blame] | 638 | |
Mehdi Amini | ffd0100 | 2014-11-20 22:40:25 +0000 | [diff] [blame] | 639 | // Try to match the current instruction |
Mehdi Amini | a28d91d | 2015-03-10 02:37:25 +0000 | [diff] [blame] | 640 | if (matchInstruction(I, isEQ)) |
Mehdi Amini | ffd0100 | 2014-11-20 22:40:25 +0000 | [diff] [blame] | 641 | // Match succeed, continue the loop |
| 642 | continue; |
Mehdi Amini | 9a25cb8 | 2014-11-19 20:09:11 +0000 | [diff] [blame] | 643 | } |
Timur Iskhodzhanov | 71526a3 | 2014-11-20 12:36:43 +0000 | [diff] [blame] | 644 | |
Mehdi Amini | ffd0100 | 2014-11-20 22:40:25 +0000 | [diff] [blame] | 645 | // One element of the sequence of || (or &&) could not be match as a |
| 646 | // comparison against the same value as the others. |
| 647 | // We allow only one "Extra" case to be checked before the switch |
| 648 | if (!Extra) { |
| 649 | Extra = V; |
Timur Iskhodzhanov | 71526a3 | 2014-11-20 12:36:43 +0000 | [diff] [blame] | 650 | continue; |
| 651 | } |
Mehdi Amini | ffd0100 | 2014-11-20 22:40:25 +0000 | [diff] [blame] | 652 | // Failed to parse a proper sequence, abort now |
| 653 | CompValue = nullptr; |
| 654 | break; |
Chris Lattner | 5a177e6 | 2010-12-13 04:26:26 +0000 | [diff] [blame] | 655 | } |
Anton Korobeynikov | 1bfd121 | 2008-02-20 11:26:25 +0000 | [diff] [blame] | 656 | } |
Mehdi Amini | ffd0100 | 2014-11-20 22:40:25 +0000 | [diff] [blame] | 657 | }; |
Eugene Zelenko | a3fe70d | 2016-11-30 17:48:10 +0000 | [diff] [blame] | 658 | |
| 659 | } // end anonymous namespace |
Nick Lewycky | e87d54c | 2011-12-26 20:37:40 +0000 | [diff] [blame] | 660 | |
Eli Friedman | cb61afb | 2008-12-16 20:54:32 +0000 | [diff] [blame] | 661 | static void EraseTerminatorInstAndDCECond(TerminatorInst *TI) { |
Craig Topper | f40110f | 2014-04-25 05:29:35 +0000 | [diff] [blame] | 662 | Instruction *Cond = nullptr; |
Eli Friedman | cb61afb | 2008-12-16 20:54:32 +0000 | [diff] [blame] | 663 | if (SwitchInst *SI = dyn_cast<SwitchInst>(TI)) { |
| 664 | Cond = dyn_cast<Instruction>(SI->getCondition()); |
| 665 | } else if (BranchInst *BI = dyn_cast<BranchInst>(TI)) { |
| 666 | if (BI->isConditional()) |
| 667 | Cond = dyn_cast<Instruction>(BI->getCondition()); |
Frits van Bommel | 8fb69ee | 2010-12-05 18:29:03 +0000 | [diff] [blame] | 668 | } else if (IndirectBrInst *IBI = dyn_cast<IndirectBrInst>(TI)) { |
| 669 | Cond = dyn_cast<Instruction>(IBI->getAddress()); |
Eli Friedman | cb61afb | 2008-12-16 20:54:32 +0000 | [diff] [blame] | 670 | } |
| 671 | |
| 672 | TI->eraseFromParent(); |
Dehao Chen | f6c0083 | 2016-05-18 19:44:21 +0000 | [diff] [blame] | 673 | if (Cond) |
| 674 | RecursivelyDeleteTriviallyDeadInstructions(Cond); |
Eli Friedman | cb61afb | 2008-12-16 20:54:32 +0000 | [diff] [blame] | 675 | } |
| 676 | |
Sanjay Patel | 09159b8f | 2015-06-24 20:40:57 +0000 | [diff] [blame] | 677 | /// Return true if the specified terminator checks |
Chris Lattner | 8e84c12 | 2008-11-27 23:25:44 +0000 | [diff] [blame] | 678 | /// to see if a value is equal to constant integer value. |
Jakob Stoklund Olesen | 916f48a | 2010-02-05 22:03:18 +0000 | [diff] [blame] | 679 | Value *SimplifyCFGOpt::isValueEqualityComparison(TerminatorInst *TI) { |
Craig Topper | f40110f | 2014-04-25 05:29:35 +0000 | [diff] [blame] | 680 | Value *CV = nullptr; |
Chris Lattner | a64923a | 2004-03-16 19:45:22 +0000 | [diff] [blame] | 681 | if (SwitchInst *SI = dyn_cast<SwitchInst>(TI)) { |
| 682 | // Do not permit merging of large switch instructions into their |
| 683 | // predecessors unless there is only one predecessor. |
Dehao Chen | f6c0083 | 2016-05-18 19:44:21 +0000 | [diff] [blame] | 684 | if (SI->getNumSuccessors() * std::distance(pred_begin(SI->getParent()), |
| 685 | pred_end(SI->getParent())) <= |
| 686 | 128) |
Jakob Stoklund Olesen | 916f48a | 2010-02-05 22:03:18 +0000 | [diff] [blame] | 687 | CV = SI->getCondition(); |
| 688 | } else if (BranchInst *BI = dyn_cast<BranchInst>(TI)) |
Chris Lattner | d3e6ae2 | 2004-02-28 21:28:10 +0000 | [diff] [blame] | 689 | if (BI->isConditional() && BI->getCondition()->hasOneUse()) |
Mehdi Amini | a28d91d | 2015-03-10 02:37:25 +0000 | [diff] [blame] | 690 | if (ICmpInst *ICI = dyn_cast<ICmpInst>(BI->getCondition())) { |
Rafael Espindola | 37dc9e1 | 2014-02-21 00:06:31 +0000 | [diff] [blame] | 691 | if (ICI->isEquality() && GetConstantInt(ICI->getOperand(1), DL)) |
Jakob Stoklund Olesen | 916f48a | 2010-02-05 22:03:18 +0000 | [diff] [blame] | 692 | CV = ICI->getOperand(0); |
Mehdi Amini | a28d91d | 2015-03-10 02:37:25 +0000 | [diff] [blame] | 693 | } |
Jakob Stoklund Olesen | 916f48a | 2010-02-05 22:03:18 +0000 | [diff] [blame] | 694 | |
| 695 | // Unwrap any lossless ptrtoint cast. |
Mehdi Amini | a28d91d | 2015-03-10 02:37:25 +0000 | [diff] [blame] | 696 | if (CV) { |
Matt Arsenault | fa64659 | 2013-10-21 18:55:08 +0000 | [diff] [blame] | 697 | if (PtrToIntInst *PTII = dyn_cast<PtrToIntInst>(CV)) { |
| 698 | Value *Ptr = PTII->getPointerOperand(); |
Mehdi Amini | a28d91d | 2015-03-10 02:37:25 +0000 | [diff] [blame] | 699 | if (PTII->getType() == DL.getIntPtrType(Ptr->getType())) |
Matt Arsenault | fa64659 | 2013-10-21 18:55:08 +0000 | [diff] [blame] | 700 | CV = Ptr; |
| 701 | } |
| 702 | } |
Jakob Stoklund Olesen | 916f48a | 2010-02-05 22:03:18 +0000 | [diff] [blame] | 703 | return CV; |
Chris Lattner | d3e6ae2 | 2004-02-28 21:28:10 +0000 | [diff] [blame] | 704 | } |
| 705 | |
Sanjay Patel | 09159b8f | 2015-06-24 20:40:57 +0000 | [diff] [blame] | 706 | /// Given a value comparison instruction, |
Bill Wendling | caf1d22 | 2009-01-19 23:43:56 +0000 | [diff] [blame] | 707 | /// decode all of the 'cases' that it represents and return the 'default' block. |
Dehao Chen | f6c0083 | 2016-05-18 19:44:21 +0000 | [diff] [blame] | 708 | BasicBlock *SimplifyCFGOpt::GetValueEqualityComparisonCases( |
| 709 | TerminatorInst *TI, std::vector<ValueEqualityComparisonCase> &Cases) { |
Chris Lattner | d3e6ae2 | 2004-02-28 21:28:10 +0000 | [diff] [blame] | 710 | if (SwitchInst *SI = dyn_cast<SwitchInst>(TI)) { |
Eric Christopher | b65acc6 | 2012-07-02 23:22:21 +0000 | [diff] [blame] | 711 | Cases.reserve(SI->getNumCases()); |
Dehao Chen | f6c0083 | 2016-05-18 19:44:21 +0000 | [diff] [blame] | 712 | for (SwitchInst::CaseIt i = SI->case_begin(), e = SI->case_end(); i != e; |
| 713 | ++i) |
| 714 | Cases.push_back( |
| 715 | ValueEqualityComparisonCase(i.getCaseValue(), i.getCaseSuccessor())); |
Chris Lattner | d3e6ae2 | 2004-02-28 21:28:10 +0000 | [diff] [blame] | 716 | return SI->getDefaultDest(); |
| 717 | } |
Eric Christopher | b65acc6 | 2012-07-02 23:22:21 +0000 | [diff] [blame] | 718 | |
Chris Lattner | d3e6ae2 | 2004-02-28 21:28:10 +0000 | [diff] [blame] | 719 | BranchInst *BI = cast<BranchInst>(TI); |
Reid Spencer | 266e42b | 2006-12-23 06:05:41 +0000 | [diff] [blame] | 720 | ICmpInst *ICI = cast<ICmpInst>(BI->getCondition()); |
Eric Christopher | b65acc6 | 2012-07-02 23:22:21 +0000 | [diff] [blame] | 721 | BasicBlock *Succ = BI->getSuccessor(ICI->getPredicate() == ICmpInst::ICMP_NE); |
Dehao Chen | f6c0083 | 2016-05-18 19:44:21 +0000 | [diff] [blame] | 722 | Cases.push_back(ValueEqualityComparisonCase( |
| 723 | GetConstantInt(ICI->getOperand(1), DL), Succ)); |
Reid Spencer | 266e42b | 2006-12-23 06:05:41 +0000 | [diff] [blame] | 724 | return BI->getSuccessor(ICI->getPredicate() == ICmpInst::ICMP_EQ); |
Chris Lattner | d3e6ae2 | 2004-02-28 21:28:10 +0000 | [diff] [blame] | 725 | } |
| 726 | |
Sanjay Patel | 09159b8f | 2015-06-24 20:40:57 +0000 | [diff] [blame] | 727 | /// Given a vector of bb/value pairs, remove any entries |
Eric Christopher | b65acc6 | 2012-07-02 23:22:21 +0000 | [diff] [blame] | 728 | /// in the list that match the specified block. |
Dehao Chen | f6c0083 | 2016-05-18 19:44:21 +0000 | [diff] [blame] | 729 | static void |
| 730 | EliminateBlockCases(BasicBlock *BB, |
| 731 | std::vector<ValueEqualityComparisonCase> &Cases) { |
Benjamin Kramer | c5b0678 | 2012-10-14 11:15:42 +0000 | [diff] [blame] | 732 | Cases.erase(std::remove(Cases.begin(), Cases.end(), BB), Cases.end()); |
Eric Christopher | b65acc6 | 2012-07-02 23:22:21 +0000 | [diff] [blame] | 733 | } |
| 734 | |
Sanjay Patel | 09159b8f | 2015-06-24 20:40:57 +0000 | [diff] [blame] | 735 | /// Return true if there are any keys in C1 that exist in C2 as well. |
Dehao Chen | f6c0083 | 2016-05-18 19:44:21 +0000 | [diff] [blame] | 736 | static bool ValuesOverlap(std::vector<ValueEqualityComparisonCase> &C1, |
| 737 | std::vector<ValueEqualityComparisonCase> &C2) { |
Eric Christopher | b65acc6 | 2012-07-02 23:22:21 +0000 | [diff] [blame] | 738 | std::vector<ValueEqualityComparisonCase> *V1 = &C1, *V2 = &C2; |
| 739 | |
| 740 | // Make V1 be smaller than V2. |
| 741 | if (V1->size() > V2->size()) |
| 742 | std::swap(V1, V2); |
| 743 | |
Eugene Zelenko | a3fe70d | 2016-11-30 17:48:10 +0000 | [diff] [blame] | 744 | if (V1->empty()) |
Dehao Chen | f6c0083 | 2016-05-18 19:44:21 +0000 | [diff] [blame] | 745 | return false; |
Eric Christopher | b65acc6 | 2012-07-02 23:22:21 +0000 | [diff] [blame] | 746 | if (V1->size() == 1) { |
| 747 | // Just scan V2. |
| 748 | ConstantInt *TheVal = (*V1)[0].Value; |
| 749 | for (unsigned i = 0, e = V2->size(); i != e; ++i) |
| 750 | if (TheVal == (*V2)[i].Value) |
| 751 | return true; |
| 752 | } |
| 753 | |
| 754 | // Otherwise, just sort both lists and compare element by element. |
| 755 | array_pod_sort(V1->begin(), V1->end()); |
| 756 | array_pod_sort(V2->begin(), V2->end()); |
| 757 | unsigned i1 = 0, i2 = 0, e1 = V1->size(), e2 = V2->size(); |
| 758 | while (i1 != e1 && i2 != e2) { |
| 759 | if ((*V1)[i1].Value == (*V2)[i2].Value) |
| 760 | return true; |
| 761 | if ((*V1)[i1].Value < (*V2)[i2].Value) |
| 762 | ++i1; |
| 763 | else |
| 764 | ++i2; |
| 765 | } |
| 766 | return false; |
| 767 | } |
| 768 | |
Sanjay Patel | 09159b8f | 2015-06-24 20:40:57 +0000 | [diff] [blame] | 769 | /// If TI is known to be a terminator instruction and its block is known to |
| 770 | /// only have a single predecessor block, check to see if that predecessor is |
| 771 | /// also a value comparison with the same value, and if that comparison |
| 772 | /// determines the outcome of this comparison. If so, simplify TI. This does a |
| 773 | /// very limited form of jump threading. |
Dehao Chen | f6c0083 | 2016-05-18 19:44:21 +0000 | [diff] [blame] | 774 | bool SimplifyCFGOpt::SimplifyEqualityComparisonWithOnlyPredecessor( |
| 775 | TerminatorInst *TI, BasicBlock *Pred, IRBuilder<> &Builder) { |
Chris Lattner | 1cca959 | 2005-02-24 06:17:52 +0000 | [diff] [blame] | 776 | Value *PredVal = isValueEqualityComparison(Pred->getTerminator()); |
Dehao Chen | f6c0083 | 2016-05-18 19:44:21 +0000 | [diff] [blame] | 777 | if (!PredVal) |
| 778 | return false; // Not a value comparison in predecessor. |
Chris Lattner | 1cca959 | 2005-02-24 06:17:52 +0000 | [diff] [blame] | 779 | |
| 780 | Value *ThisVal = isValueEqualityComparison(TI); |
| 781 | assert(ThisVal && "This isn't a value comparison!!"); |
Dehao Chen | f6c0083 | 2016-05-18 19:44:21 +0000 | [diff] [blame] | 782 | if (ThisVal != PredVal) |
| 783 | return false; // Different predicates. |
Chris Lattner | 1cca959 | 2005-02-24 06:17:52 +0000 | [diff] [blame] | 784 | |
Andrew Trick | 3051aa1 | 2012-08-29 21:46:38 +0000 | [diff] [blame] | 785 | // TODO: Preserve branch weight metadata, similarly to how |
| 786 | // FoldValueComparisonIntoPredecessors preserves it. |
| 787 | |
Chris Lattner | 1cca959 | 2005-02-24 06:17:52 +0000 | [diff] [blame] | 788 | // Find out information about when control will move from Pred to TI's block. |
Eric Christopher | b65acc6 | 2012-07-02 23:22:21 +0000 | [diff] [blame] | 789 | std::vector<ValueEqualityComparisonCase> PredCases; |
Dehao Chen | f6c0083 | 2016-05-18 19:44:21 +0000 | [diff] [blame] | 790 | BasicBlock *PredDef = |
| 791 | GetValueEqualityComparisonCases(Pred->getTerminator(), PredCases); |
| 792 | EliminateBlockCases(PredDef, PredCases); // Remove default from cases. |
Misha Brukman | b1c9317 | 2005-04-21 23:48:37 +0000 | [diff] [blame] | 793 | |
Chris Lattner | 1cca959 | 2005-02-24 06:17:52 +0000 | [diff] [blame] | 794 | // Find information about how control leaves this block. |
Eric Christopher | b65acc6 | 2012-07-02 23:22:21 +0000 | [diff] [blame] | 795 | std::vector<ValueEqualityComparisonCase> ThisCases; |
Chris Lattner | 1cca959 | 2005-02-24 06:17:52 +0000 | [diff] [blame] | 796 | BasicBlock *ThisDef = GetValueEqualityComparisonCases(TI, ThisCases); |
Dehao Chen | f6c0083 | 2016-05-18 19:44:21 +0000 | [diff] [blame] | 797 | EliminateBlockCases(ThisDef, ThisCases); // Remove default from cases. |
Chris Lattner | 1cca959 | 2005-02-24 06:17:52 +0000 | [diff] [blame] | 798 | |
| 799 | // If TI's block is the default block from Pred's comparison, potentially |
| 800 | // simplify TI based on this knowledge. |
| 801 | if (PredDef == TI->getParent()) { |
| 802 | // If we are here, we know that the value is none of those cases listed in |
| 803 | // PredCases. If there are any cases in ThisCases that are in PredCases, we |
| 804 | // can simplify TI. |
Eric Christopher | b65acc6 | 2012-07-02 23:22:21 +0000 | [diff] [blame] | 805 | if (!ValuesOverlap(PredCases, ThisCases)) |
Chris Lattner | 4088e2b | 2010-12-13 01:47:07 +0000 | [diff] [blame] | 806 | return false; |
Andrew Trick | f3cf193 | 2012-08-29 21:46:36 +0000 | [diff] [blame] | 807 | |
Chris Lattner | 4088e2b | 2010-12-13 01:47:07 +0000 | [diff] [blame] | 808 | if (isa<BranchInst>(TI)) { |
| 809 | // Okay, one of the successors of this condbr is dead. Convert it to a |
| 810 | // uncond br. |
| 811 | assert(ThisCases.size() == 1 && "Branch can only have one case!"); |
| 812 | // Insert the new branch. |
Devang Patel | a7ec47d | 2011-05-18 20:35:38 +0000 | [diff] [blame] | 813 | Instruction *NI = Builder.CreateBr(ThisDef); |
Dehao Chen | f6c0083 | 2016-05-18 19:44:21 +0000 | [diff] [blame] | 814 | (void)NI; |
Chris Lattner | 1cca959 | 2005-02-24 06:17:52 +0000 | [diff] [blame] | 815 | |
Chris Lattner | 4088e2b | 2010-12-13 01:47:07 +0000 | [diff] [blame] | 816 | // Remove PHI node entries for the dead edge. |
Eric Christopher | b65acc6 | 2012-07-02 23:22:21 +0000 | [diff] [blame] | 817 | ThisCases[0].Dest->removePredecessor(TI->getParent()); |
Chris Lattner | 1cca959 | 2005-02-24 06:17:52 +0000 | [diff] [blame] | 818 | |
Chris Lattner | 4088e2b | 2010-12-13 01:47:07 +0000 | [diff] [blame] | 819 | DEBUG(dbgs() << "Threading pred instr: " << *Pred->getTerminator() |
Dehao Chen | f6c0083 | 2016-05-18 19:44:21 +0000 | [diff] [blame] | 820 | << "Through successor TI: " << *TI << "Leaving: " << *NI |
| 821 | << "\n"); |
Chris Lattner | 1cca959 | 2005-02-24 06:17:52 +0000 | [diff] [blame] | 822 | |
Chris Lattner | 4088e2b | 2010-12-13 01:47:07 +0000 | [diff] [blame] | 823 | EraseTerminatorInstAndDCECond(TI); |
| 824 | return true; |
Chris Lattner | 1cca959 | 2005-02-24 06:17:52 +0000 | [diff] [blame] | 825 | } |
Andrew Trick | f3cf193 | 2012-08-29 21:46:36 +0000 | [diff] [blame] | 826 | |
Chris Lattner | 4088e2b | 2010-12-13 01:47:07 +0000 | [diff] [blame] | 827 | SwitchInst *SI = cast<SwitchInst>(TI); |
| 828 | // Okay, TI has cases that are statically dead, prune them away. |
Dehao Chen | f6c0083 | 2016-05-18 19:44:21 +0000 | [diff] [blame] | 829 | SmallPtrSet<Constant *, 16> DeadCases; |
Eric Christopher | b65acc6 | 2012-07-02 23:22:21 +0000 | [diff] [blame] | 830 | for (unsigned i = 0, e = PredCases.size(); i != e; ++i) |
| 831 | DeadCases.insert(PredCases[i].Value); |
Chris Lattner | 1cca959 | 2005-02-24 06:17:52 +0000 | [diff] [blame] | 832 | |
David Greene | 725c7c3 | 2010-01-05 01:26:52 +0000 | [diff] [blame] | 833 | DEBUG(dbgs() << "Threading pred instr: " << *Pred->getTerminator() |
Chris Lattner | 4088e2b | 2010-12-13 01:47:07 +0000 | [diff] [blame] | 834 | << "Through successor TI: " << *TI); |
Chris Lattner | 1cca959 | 2005-02-24 06:17:52 +0000 | [diff] [blame] | 835 | |
Manman Ren | 8691e52 | 2012-09-14 21:53:06 +0000 | [diff] [blame] | 836 | // Collect branch weights into a vector. |
| 837 | SmallVector<uint32_t, 8> Weights; |
Duncan P. N. Exon Smith | de36e80 | 2014-11-11 21:30:22 +0000 | [diff] [blame] | 838 | MDNode *MD = SI->getMetadata(LLVMContext::MD_prof); |
Manman Ren | 8691e52 | 2012-09-14 21:53:06 +0000 | [diff] [blame] | 839 | bool HasWeight = MD && (MD->getNumOperands() == 2 + SI->getNumCases()); |
| 840 | if (HasWeight) |
| 841 | for (unsigned MD_i = 1, MD_e = MD->getNumOperands(); MD_i < MD_e; |
| 842 | ++MD_i) { |
Duncan P. N. Exon Smith | 5bf8fef | 2014-12-09 18:38:53 +0000 | [diff] [blame] | 843 | ConstantInt *CI = mdconst::extract<ConstantInt>(MD->getOperand(MD_i)); |
Manman Ren | 8691e52 | 2012-09-14 21:53:06 +0000 | [diff] [blame] | 844 | Weights.push_back(CI->getValue().getZExtValue()); |
| 845 | } |
Eric Christopher | b65acc6 | 2012-07-02 23:22:21 +0000 | [diff] [blame] | 846 | for (SwitchInst::CaseIt i = SI->case_end(), e = SI->case_begin(); i != e;) { |
| 847 | --i; |
| 848 | if (DeadCases.count(i.getCaseValue())) { |
Manman Ren | 8691e52 | 2012-09-14 21:53:06 +0000 | [diff] [blame] | 849 | if (HasWeight) { |
Dehao Chen | f6c0083 | 2016-05-18 19:44:21 +0000 | [diff] [blame] | 850 | std::swap(Weights[i.getCaseIndex() + 1], Weights.back()); |
Manman Ren | 8691e52 | 2012-09-14 21:53:06 +0000 | [diff] [blame] | 851 | Weights.pop_back(); |
| 852 | } |
Eric Christopher | b65acc6 | 2012-07-02 23:22:21 +0000 | [diff] [blame] | 853 | i.getCaseSuccessor()->removePredecessor(TI->getParent()); |
| 854 | SI->removeCase(i); |
| 855 | } |
| 856 | } |
Manman Ren | 97c1876 | 2012-10-11 22:28:34 +0000 | [diff] [blame] | 857 | if (HasWeight && Weights.size() >= 2) |
Manman Ren | 8691e52 | 2012-09-14 21:53:06 +0000 | [diff] [blame] | 858 | SI->setMetadata(LLVMContext::MD_prof, |
Dehao Chen | f6c0083 | 2016-05-18 19:44:21 +0000 | [diff] [blame] | 859 | MDBuilder(SI->getParent()->getContext()) |
| 860 | .createBranchWeights(Weights)); |
Eric Christopher | b65acc6 | 2012-07-02 23:22:21 +0000 | [diff] [blame] | 861 | |
| 862 | DEBUG(dbgs() << "Leaving: " << *TI << "\n"); |
Chris Lattner | 1cca959 | 2005-02-24 06:17:52 +0000 | [diff] [blame] | 863 | return true; |
| 864 | } |
Andrew Trick | f3cf193 | 2012-08-29 21:46:36 +0000 | [diff] [blame] | 865 | |
Chris Lattner | 4088e2b | 2010-12-13 01:47:07 +0000 | [diff] [blame] | 866 | // Otherwise, TI's block must correspond to some matched value. Find out |
| 867 | // which value (or set of values) this is. |
Craig Topper | f40110f | 2014-04-25 05:29:35 +0000 | [diff] [blame] | 868 | ConstantInt *TIV = nullptr; |
Chris Lattner | 4088e2b | 2010-12-13 01:47:07 +0000 | [diff] [blame] | 869 | BasicBlock *TIBB = TI->getParent(); |
Eric Christopher | b65acc6 | 2012-07-02 23:22:21 +0000 | [diff] [blame] | 870 | for (unsigned i = 0, e = PredCases.size(); i != e; ++i) |
| 871 | if (PredCases[i].Dest == TIBB) { |
Craig Topper | f40110f | 2014-04-25 05:29:35 +0000 | [diff] [blame] | 872 | if (TIV) |
Dehao Chen | f6c0083 | 2016-05-18 19:44:21 +0000 | [diff] [blame] | 873 | return false; // Cannot handle multiple values coming to this block. |
Eric Christopher | b65acc6 | 2012-07-02 23:22:21 +0000 | [diff] [blame] | 874 | TIV = PredCases[i].Value; |
| 875 | } |
| 876 | assert(TIV && "No edge from pred to succ?"); |
Chris Lattner | 4088e2b | 2010-12-13 01:47:07 +0000 | [diff] [blame] | 877 | |
| 878 | // Okay, we found the one constant that our value can be if we get into TI's |
| 879 | // BB. Find out which successor will unconditionally be branched to. |
Craig Topper | f40110f | 2014-04-25 05:29:35 +0000 | [diff] [blame] | 880 | BasicBlock *TheRealDest = nullptr; |
Eric Christopher | b65acc6 | 2012-07-02 23:22:21 +0000 | [diff] [blame] | 881 | for (unsigned i = 0, e = ThisCases.size(); i != e; ++i) |
| 882 | if (ThisCases[i].Value == TIV) { |
| 883 | TheRealDest = ThisCases[i].Dest; |
| 884 | break; |
| 885 | } |
Chris Lattner | 4088e2b | 2010-12-13 01:47:07 +0000 | [diff] [blame] | 886 | |
| 887 | // If not handled by any explicit cases, it is handled by the default case. |
Dehao Chen | f6c0083 | 2016-05-18 19:44:21 +0000 | [diff] [blame] | 888 | if (!TheRealDest) |
| 889 | TheRealDest = ThisDef; |
Chris Lattner | 4088e2b | 2010-12-13 01:47:07 +0000 | [diff] [blame] | 890 | |
| 891 | // Remove PHI node entries for dead edges. |
| 892 | BasicBlock *CheckEdge = TheRealDest; |
Sanjay Patel | 5781d84 | 2016-03-12 16:52:17 +0000 | [diff] [blame] | 893 | for (BasicBlock *Succ : successors(TIBB)) |
| 894 | if (Succ != CheckEdge) |
| 895 | Succ->removePredecessor(TIBB); |
Chris Lattner | 4088e2b | 2010-12-13 01:47:07 +0000 | [diff] [blame] | 896 | else |
Craig Topper | f40110f | 2014-04-25 05:29:35 +0000 | [diff] [blame] | 897 | CheckEdge = nullptr; |
Chris Lattner | 4088e2b | 2010-12-13 01:47:07 +0000 | [diff] [blame] | 898 | |
| 899 | // Insert the new branch. |
Devang Patel | a7ec47d | 2011-05-18 20:35:38 +0000 | [diff] [blame] | 900 | Instruction *NI = Builder.CreateBr(TheRealDest); |
Dehao Chen | f6c0083 | 2016-05-18 19:44:21 +0000 | [diff] [blame] | 901 | (void)NI; |
Chris Lattner | 4088e2b | 2010-12-13 01:47:07 +0000 | [diff] [blame] | 902 | |
| 903 | DEBUG(dbgs() << "Threading pred instr: " << *Pred->getTerminator() |
Dehao Chen | f6c0083 | 2016-05-18 19:44:21 +0000 | [diff] [blame] | 904 | << "Through successor TI: " << *TI << "Leaving: " << *NI |
| 905 | << "\n"); |
Chris Lattner | 4088e2b | 2010-12-13 01:47:07 +0000 | [diff] [blame] | 906 | |
| 907 | EraseTerminatorInstAndDCECond(TI); |
| 908 | return true; |
Chris Lattner | 1cca959 | 2005-02-24 06:17:52 +0000 | [diff] [blame] | 909 | } |
| 910 | |
Dale Johannesen | 7f99d22 | 2009-03-12 21:01:11 +0000 | [diff] [blame] | 911 | namespace { |
Eugene Zelenko | a3fe70d | 2016-11-30 17:48:10 +0000 | [diff] [blame] | 912 | |
Dehao Chen | f6c0083 | 2016-05-18 19:44:21 +0000 | [diff] [blame] | 913 | /// This class implements a stable ordering of constant |
| 914 | /// integers that does not depend on their address. This is important for |
| 915 | /// applications that sort ConstantInt's to ensure uniqueness. |
| 916 | struct ConstantIntOrdering { |
| 917 | bool operator()(const ConstantInt *LHS, const ConstantInt *RHS) const { |
| 918 | return LHS->getValue().ult(RHS->getValue()); |
| 919 | } |
| 920 | }; |
Eugene Zelenko | a3fe70d | 2016-11-30 17:48:10 +0000 | [diff] [blame] | 921 | |
| 922 | } // end anonymous namespace |
Dale Johannesen | 5a41b2d | 2009-03-12 01:00:26 +0000 | [diff] [blame] | 923 | |
Benjamin Kramer | 8817cca | 2013-09-22 14:09:50 +0000 | [diff] [blame] | 924 | static int ConstantIntSortPredicate(ConstantInt *const *P1, |
| 925 | ConstantInt *const *P2) { |
| 926 | const ConstantInt *LHS = *P1; |
| 927 | const ConstantInt *RHS = *P2; |
Benjamin Kramer | 7d537ae | 2016-02-20 10:40:42 +0000 | [diff] [blame] | 928 | if (LHS == RHS) |
Chris Lattner | e893e26 | 2010-12-15 04:52:41 +0000 | [diff] [blame] | 929 | return 0; |
Benjamin Kramer | 7d537ae | 2016-02-20 10:40:42 +0000 | [diff] [blame] | 930 | return LHS->getValue().ult(RHS->getValue()) ? 1 : -1; |
Chris Lattner | 7c8e604 | 2010-12-13 02:00:58 +0000 | [diff] [blame] | 931 | } |
| 932 | |
Dehao Chen | f6c0083 | 2016-05-18 19:44:21 +0000 | [diff] [blame] | 933 | static inline bool HasBranchWeights(const Instruction *I) { |
Duncan P. N. Exon Smith | de36e80 | 2014-11-11 21:30:22 +0000 | [diff] [blame] | 934 | MDNode *ProfMD = I->getMetadata(LLVMContext::MD_prof); |
Andrew Trick | 3051aa1 | 2012-08-29 21:46:38 +0000 | [diff] [blame] | 935 | if (ProfMD && ProfMD->getOperand(0)) |
Dehao Chen | f6c0083 | 2016-05-18 19:44:21 +0000 | [diff] [blame] | 936 | if (MDString *MDS = dyn_cast<MDString>(ProfMD->getOperand(0))) |
Andrew Trick | 3051aa1 | 2012-08-29 21:46:38 +0000 | [diff] [blame] | 937 | return MDS->getString().equals("branch_weights"); |
| 938 | |
| 939 | return false; |
| 940 | } |
| 941 | |
Manman Ren | 571d9e4 | 2012-09-11 17:43:35 +0000 | [diff] [blame] | 942 | /// Get Weights of a given TerminatorInst, the default weight is at the front |
| 943 | /// of the vector. If TI is a conditional eq, we need to swap the branch-weight |
| 944 | /// metadata. |
| 945 | static void GetBranchWeights(TerminatorInst *TI, |
| 946 | SmallVectorImpl<uint64_t> &Weights) { |
Duncan P. N. Exon Smith | de36e80 | 2014-11-11 21:30:22 +0000 | [diff] [blame] | 947 | MDNode *MD = TI->getMetadata(LLVMContext::MD_prof); |
Manman Ren | 571d9e4 | 2012-09-11 17:43:35 +0000 | [diff] [blame] | 948 | assert(MD); |
| 949 | for (unsigned i = 1, e = MD->getNumOperands(); i < e; ++i) { |
Duncan P. N. Exon Smith | 5bf8fef | 2014-12-09 18:38:53 +0000 | [diff] [blame] | 950 | ConstantInt *CI = mdconst::extract<ConstantInt>(MD->getOperand(i)); |
Manman Ren | 571d9e4 | 2012-09-11 17:43:35 +0000 | [diff] [blame] | 951 | Weights.push_back(CI->getValue().getZExtValue()); |
Andrew Trick | 3051aa1 | 2012-08-29 21:46:38 +0000 | [diff] [blame] | 952 | } |
| 953 | |
Manman Ren | 571d9e4 | 2012-09-11 17:43:35 +0000 | [diff] [blame] | 954 | // If TI is a conditional eq, the default case is the false case, |
| 955 | // and the corresponding branch-weight data is at index 2. We swap the |
| 956 | // default weight to be the first entry. |
Dehao Chen | f6c0083 | 2016-05-18 19:44:21 +0000 | [diff] [blame] | 957 | if (BranchInst *BI = dyn_cast<BranchInst>(TI)) { |
Manman Ren | 571d9e4 | 2012-09-11 17:43:35 +0000 | [diff] [blame] | 958 | assert(Weights.size() == 2); |
| 959 | ICmpInst *ICI = cast<ICmpInst>(BI->getCondition()); |
| 960 | if (ICI->getPredicate() == ICmpInst::ICMP_EQ) |
| 961 | std::swap(Weights.front(), Weights.back()); |
Andrew Trick | 3051aa1 | 2012-08-29 21:46:38 +0000 | [diff] [blame] | 962 | } |
| 963 | } |
| 964 | |
Sanjay Patel | 84a0bf6 | 2016-05-06 17:51:37 +0000 | [diff] [blame] | 965 | /// Keep halving the weights until all can fit in uint32_t. |
Andrew Trick | 3051aa1 | 2012-08-29 21:46:38 +0000 | [diff] [blame] | 966 | static void FitWeights(MutableArrayRef<uint64_t> Weights) { |
Benjamin Kramer | 79da941 | 2014-03-09 14:42:55 +0000 | [diff] [blame] | 967 | uint64_t Max = *std::max_element(Weights.begin(), Weights.end()); |
| 968 | if (Max > UINT_MAX) { |
| 969 | unsigned Offset = 32 - countLeadingZeros(Max); |
| 970 | for (uint64_t &I : Weights) |
| 971 | I >>= Offset; |
Manman Ren | f1cb16e | 2014-01-27 23:39:03 +0000 | [diff] [blame] | 972 | } |
Andrew Trick | 3051aa1 | 2012-08-29 21:46:38 +0000 | [diff] [blame] | 973 | } |
| 974 | |
Sanjay Patel | 09159b8f | 2015-06-24 20:40:57 +0000 | [diff] [blame] | 975 | /// The specified terminator is a value equality comparison instruction |
| 976 | /// (either a switch or a branch on "X == c"). |
Bill Wendling | caf1d22 | 2009-01-19 23:43:56 +0000 | [diff] [blame] | 977 | /// See if any of the predecessors of the terminator block are value comparisons |
| 978 | /// on the same value. If so, and if safe to do so, fold them together. |
Devang Patel | 5838055 | 2011-05-18 20:53:17 +0000 | [diff] [blame] | 979 | bool SimplifyCFGOpt::FoldValueComparisonIntoPredecessors(TerminatorInst *TI, |
| 980 | IRBuilder<> &Builder) { |
Chris Lattner | d3e6ae2 | 2004-02-28 21:28:10 +0000 | [diff] [blame] | 981 | BasicBlock *BB = TI->getParent(); |
Dehao Chen | f6c0083 | 2016-05-18 19:44:21 +0000 | [diff] [blame] | 982 | Value *CV = isValueEqualityComparison(TI); // CondVal |
Chris Lattner | d3e6ae2 | 2004-02-28 21:28:10 +0000 | [diff] [blame] | 983 | assert(CV && "Not a comparison?"); |
| 984 | bool Changed = false; |
| 985 | |
Dehao Chen | f6c0083 | 2016-05-18 19:44:21 +0000 | [diff] [blame] | 986 | SmallVector<BasicBlock *, 16> Preds(pred_begin(BB), pred_end(BB)); |
Chris Lattner | d3e6ae2 | 2004-02-28 21:28:10 +0000 | [diff] [blame] | 987 | while (!Preds.empty()) { |
Dan Gohman | 9a6fef0 | 2009-05-06 17:22:41 +0000 | [diff] [blame] | 988 | BasicBlock *Pred = Preds.pop_back_val(); |
Misha Brukman | b1c9317 | 2005-04-21 23:48:37 +0000 | [diff] [blame] | 989 | |
Chris Lattner | d3e6ae2 | 2004-02-28 21:28:10 +0000 | [diff] [blame] | 990 | // See if the predecessor is a comparison with the same value. |
| 991 | TerminatorInst *PTI = Pred->getTerminator(); |
Dehao Chen | f6c0083 | 2016-05-18 19:44:21 +0000 | [diff] [blame] | 992 | Value *PCV = isValueEqualityComparison(PTI); // PredCondVal |
Chris Lattner | d3e6ae2 | 2004-02-28 21:28:10 +0000 | [diff] [blame] | 993 | |
James Molloy | e656642 | 2016-09-01 07:45:25 +0000 | [diff] [blame] | 994 | if (PCV == CV && TI != PTI) { |
James Molloy | 2174468 | 2016-09-01 09:01:34 +0000 | [diff] [blame] | 995 | SmallSetVector<BasicBlock*, 4> FailBlocks; |
James Molloy | e656642 | 2016-09-01 07:45:25 +0000 | [diff] [blame] | 996 | if (!SafeToMergeTerminators(TI, PTI, &FailBlocks)) { |
| 997 | for (auto *Succ : FailBlocks) { |
| 998 | std::vector<BasicBlock*> Blocks = { TI->getParent() }; |
| 999 | if (!SplitBlockPredecessors(Succ, Blocks, ".fold.split")) |
| 1000 | return false; |
| 1001 | } |
| 1002 | } |
| 1003 | |
Chris Lattner | d3e6ae2 | 2004-02-28 21:28:10 +0000 | [diff] [blame] | 1004 | // Figure out which 'cases' to copy from SI to PSI. |
Eric Christopher | b65acc6 | 2012-07-02 23:22:21 +0000 | [diff] [blame] | 1005 | std::vector<ValueEqualityComparisonCase> BBCases; |
Chris Lattner | d3e6ae2 | 2004-02-28 21:28:10 +0000 | [diff] [blame] | 1006 | BasicBlock *BBDefault = GetValueEqualityComparisonCases(TI, BBCases); |
| 1007 | |
Eric Christopher | b65acc6 | 2012-07-02 23:22:21 +0000 | [diff] [blame] | 1008 | std::vector<ValueEqualityComparisonCase> PredCases; |
Chris Lattner | d3e6ae2 | 2004-02-28 21:28:10 +0000 | [diff] [blame] | 1009 | BasicBlock *PredDefault = GetValueEqualityComparisonCases(PTI, PredCases); |
| 1010 | |
| 1011 | // Based on whether the default edge from PTI goes to BB or not, fill in |
| 1012 | // PredCases and PredDefault with the new switch cases we would like to |
| 1013 | // build. |
Dehao Chen | f6c0083 | 2016-05-18 19:44:21 +0000 | [diff] [blame] | 1014 | SmallVector<BasicBlock *, 8> NewSuccessors; |
Chris Lattner | d3e6ae2 | 2004-02-28 21:28:10 +0000 | [diff] [blame] | 1015 | |
Andrew Trick | 3051aa1 | 2012-08-29 21:46:38 +0000 | [diff] [blame] | 1016 | // Update the branch weight metadata along the way |
| 1017 | SmallVector<uint64_t, 8> Weights; |
Andrew Trick | 3051aa1 | 2012-08-29 21:46:38 +0000 | [diff] [blame] | 1018 | bool PredHasWeights = HasBranchWeights(PTI); |
| 1019 | bool SuccHasWeights = HasBranchWeights(TI); |
| 1020 | |
Manman Ren | 5e5049d | 2012-09-14 19:05:19 +0000 | [diff] [blame] | 1021 | if (PredHasWeights) { |
Manman Ren | 571d9e4 | 2012-09-11 17:43:35 +0000 | [diff] [blame] | 1022 | GetBranchWeights(PTI, Weights); |
Andrew Trick | 7656f6d | 2012-11-15 18:40:31 +0000 | [diff] [blame] | 1023 | // branch-weight metadata is inconsistent here. |
Manman Ren | 5e5049d | 2012-09-14 19:05:19 +0000 | [diff] [blame] | 1024 | if (Weights.size() != 1 + PredCases.size()) |
| 1025 | PredHasWeights = SuccHasWeights = false; |
| 1026 | } else if (SuccHasWeights) |
Andrew Trick | 3051aa1 | 2012-08-29 21:46:38 +0000 | [diff] [blame] | 1027 | // If there are no predecessor weights but there are successor weights, |
| 1028 | // populate Weights with 1, which will later be scaled to the sum of |
| 1029 | // successor's weights |
| 1030 | Weights.assign(1 + PredCases.size(), 1); |
Andrew Trick | 3051aa1 | 2012-08-29 21:46:38 +0000 | [diff] [blame] | 1031 | |
Manman Ren | 571d9e4 | 2012-09-11 17:43:35 +0000 | [diff] [blame] | 1032 | SmallVector<uint64_t, 8> SuccWeights; |
Manman Ren | 5e5049d | 2012-09-14 19:05:19 +0000 | [diff] [blame] | 1033 | if (SuccHasWeights) { |
Manman Ren | 571d9e4 | 2012-09-11 17:43:35 +0000 | [diff] [blame] | 1034 | GetBranchWeights(TI, SuccWeights); |
Andrew Trick | 7656f6d | 2012-11-15 18:40:31 +0000 | [diff] [blame] | 1035 | // branch-weight metadata is inconsistent here. |
Manman Ren | 5e5049d | 2012-09-14 19:05:19 +0000 | [diff] [blame] | 1036 | if (SuccWeights.size() != 1 + BBCases.size()) |
| 1037 | PredHasWeights = SuccHasWeights = false; |
| 1038 | } else if (PredHasWeights) |
Manman Ren | 571d9e4 | 2012-09-11 17:43:35 +0000 | [diff] [blame] | 1039 | SuccWeights.assign(1 + BBCases.size(), 1); |
Andrew Trick | 3051aa1 | 2012-08-29 21:46:38 +0000 | [diff] [blame] | 1040 | |
Chris Lattner | d3e6ae2 | 2004-02-28 21:28:10 +0000 | [diff] [blame] | 1041 | if (PredDefault == BB) { |
| 1042 | // If this is the default destination from PTI, only the edges in TI |
| 1043 | // that don't occur in PTI, or that branch to BB will be activated. |
Dehao Chen | f6c0083 | 2016-05-18 19:44:21 +0000 | [diff] [blame] | 1044 | std::set<ConstantInt *, ConstantIntOrdering> PTIHandled; |
Eric Christopher | b65acc6 | 2012-07-02 23:22:21 +0000 | [diff] [blame] | 1045 | for (unsigned i = 0, e = PredCases.size(); i != e; ++i) |
| 1046 | if (PredCases[i].Dest != BB) |
| 1047 | PTIHandled.insert(PredCases[i].Value); |
| 1048 | else { |
| 1049 | // The default destination is BB, we don't need explicit targets. |
| 1050 | std::swap(PredCases[i], PredCases.back()); |
Andrew Trick | 3051aa1 | 2012-08-29 21:46:38 +0000 | [diff] [blame] | 1051 | |
Manman Ren | 571d9e4 | 2012-09-11 17:43:35 +0000 | [diff] [blame] | 1052 | if (PredHasWeights || SuccHasWeights) { |
| 1053 | // Increase weight for the default case. |
Dehao Chen | f6c0083 | 2016-05-18 19:44:21 +0000 | [diff] [blame] | 1054 | Weights[0] += Weights[i + 1]; |
| 1055 | std::swap(Weights[i + 1], Weights.back()); |
Andrew Trick | 3051aa1 | 2012-08-29 21:46:38 +0000 | [diff] [blame] | 1056 | Weights.pop_back(); |
| 1057 | } |
| 1058 | |
Eric Christopher | b65acc6 | 2012-07-02 23:22:21 +0000 | [diff] [blame] | 1059 | PredCases.pop_back(); |
Dehao Chen | f6c0083 | 2016-05-18 19:44:21 +0000 | [diff] [blame] | 1060 | --i; |
| 1061 | --e; |
Eric Christopher | b65acc6 | 2012-07-02 23:22:21 +0000 | [diff] [blame] | 1062 | } |
Chris Lattner | d3e6ae2 | 2004-02-28 21:28:10 +0000 | [diff] [blame] | 1063 | |
Eric Christopher | b65acc6 | 2012-07-02 23:22:21 +0000 | [diff] [blame] | 1064 | // Reconstruct the new switch statement we will be building. |
Chris Lattner | d3e6ae2 | 2004-02-28 21:28:10 +0000 | [diff] [blame] | 1065 | if (PredDefault != BBDefault) { |
| 1066 | PredDefault->removePredecessor(Pred); |
| 1067 | PredDefault = BBDefault; |
| 1068 | NewSuccessors.push_back(BBDefault); |
| 1069 | } |
Andrew Trick | 3051aa1 | 2012-08-29 21:46:38 +0000 | [diff] [blame] | 1070 | |
Manman Ren | 571d9e4 | 2012-09-11 17:43:35 +0000 | [diff] [blame] | 1071 | unsigned CasesFromPred = Weights.size(); |
| 1072 | uint64_t ValidTotalSuccWeight = 0; |
Eric Christopher | b65acc6 | 2012-07-02 23:22:21 +0000 | [diff] [blame] | 1073 | for (unsigned i = 0, e = BBCases.size(); i != e; ++i) |
| 1074 | if (!PTIHandled.count(BBCases[i].Value) && |
| 1075 | BBCases[i].Dest != BBDefault) { |
| 1076 | PredCases.push_back(BBCases[i]); |
| 1077 | NewSuccessors.push_back(BBCases[i].Dest); |
Manman Ren | 571d9e4 | 2012-09-11 17:43:35 +0000 | [diff] [blame] | 1078 | if (SuccHasWeights || PredHasWeights) { |
| 1079 | // The default weight is at index 0, so weight for the ith case |
| 1080 | // should be at index i+1. Scale the cases from successor by |
| 1081 | // PredDefaultWeight (Weights[0]). |
Dehao Chen | f6c0083 | 2016-05-18 19:44:21 +0000 | [diff] [blame] | 1082 | Weights.push_back(Weights[0] * SuccWeights[i + 1]); |
| 1083 | ValidTotalSuccWeight += SuccWeights[i + 1]; |
Andrew Trick | 3051aa1 | 2012-08-29 21:46:38 +0000 | [diff] [blame] | 1084 | } |
Eric Christopher | b65acc6 | 2012-07-02 23:22:21 +0000 | [diff] [blame] | 1085 | } |
Chris Lattner | d3e6ae2 | 2004-02-28 21:28:10 +0000 | [diff] [blame] | 1086 | |
Manman Ren | 571d9e4 | 2012-09-11 17:43:35 +0000 | [diff] [blame] | 1087 | if (SuccHasWeights || PredHasWeights) { |
| 1088 | ValidTotalSuccWeight += SuccWeights[0]; |
| 1089 | // Scale the cases from predecessor by ValidTotalSuccWeight. |
| 1090 | for (unsigned i = 1; i < CasesFromPred; ++i) |
| 1091 | Weights[i] *= ValidTotalSuccWeight; |
| 1092 | // Scale the default weight by SuccDefaultWeight (SuccWeights[0]). |
| 1093 | Weights[0] *= SuccWeights[0]; |
| 1094 | } |
Chris Lattner | d3e6ae2 | 2004-02-28 21:28:10 +0000 | [diff] [blame] | 1095 | } else { |
| 1096 | // If this is not the default destination from PSI, only the edges |
| 1097 | // in SI that occur in PSI with a destination of BB will be |
| 1098 | // activated. |
Dehao Chen | f6c0083 | 2016-05-18 19:44:21 +0000 | [diff] [blame] | 1099 | std::set<ConstantInt *, ConstantIntOrdering> PTIHandled; |
| 1100 | std::map<ConstantInt *, uint64_t> WeightsForHandled; |
Eric Christopher | b65acc6 | 2012-07-02 23:22:21 +0000 | [diff] [blame] | 1101 | for (unsigned i = 0, e = PredCases.size(); i != e; ++i) |
| 1102 | if (PredCases[i].Dest == BB) { |
| 1103 | PTIHandled.insert(PredCases[i].Value); |
Manman Ren | d81b8e8 | 2012-09-14 17:29:56 +0000 | [diff] [blame] | 1104 | |
| 1105 | if (PredHasWeights || SuccHasWeights) { |
Dehao Chen | f6c0083 | 2016-05-18 19:44:21 +0000 | [diff] [blame] | 1106 | WeightsForHandled[PredCases[i].Value] = Weights[i + 1]; |
| 1107 | std::swap(Weights[i + 1], Weights.back()); |
Manman Ren | d81b8e8 | 2012-09-14 17:29:56 +0000 | [diff] [blame] | 1108 | Weights.pop_back(); |
| 1109 | } |
| 1110 | |
Eric Christopher | b65acc6 | 2012-07-02 23:22:21 +0000 | [diff] [blame] | 1111 | std::swap(PredCases[i], PredCases.back()); |
| 1112 | PredCases.pop_back(); |
Dehao Chen | f6c0083 | 2016-05-18 19:44:21 +0000 | [diff] [blame] | 1113 | --i; |
| 1114 | --e; |
Eric Christopher | b65acc6 | 2012-07-02 23:22:21 +0000 | [diff] [blame] | 1115 | } |
Chris Lattner | d3e6ae2 | 2004-02-28 21:28:10 +0000 | [diff] [blame] | 1116 | |
| 1117 | // Okay, now we know which constants were sent to BB from the |
| 1118 | // predecessor. Figure out where they will all go now. |
Eric Christopher | b65acc6 | 2012-07-02 23:22:21 +0000 | [diff] [blame] | 1119 | for (unsigned i = 0, e = BBCases.size(); i != e; ++i) |
| 1120 | if (PTIHandled.count(BBCases[i].Value)) { |
| 1121 | // If this is one we are capable of getting... |
Manman Ren | d81b8e8 | 2012-09-14 17:29:56 +0000 | [diff] [blame] | 1122 | if (PredHasWeights || SuccHasWeights) |
| 1123 | Weights.push_back(WeightsForHandled[BBCases[i].Value]); |
Eric Christopher | b65acc6 | 2012-07-02 23:22:21 +0000 | [diff] [blame] | 1124 | PredCases.push_back(BBCases[i]); |
| 1125 | NewSuccessors.push_back(BBCases[i].Dest); |
Dehao Chen | f6c0083 | 2016-05-18 19:44:21 +0000 | [diff] [blame] | 1126 | PTIHandled.erase( |
| 1127 | BBCases[i].Value); // This constant is taken care of |
Eric Christopher | b65acc6 | 2012-07-02 23:22:21 +0000 | [diff] [blame] | 1128 | } |
| 1129 | |
Chris Lattner | d3e6ae2 | 2004-02-28 21:28:10 +0000 | [diff] [blame] | 1130 | // If there are any constants vectored to BB that TI doesn't handle, |
| 1131 | // they must go to the default destination of TI. |
Benjamin Kramer | 135f735 | 2016-06-26 12:28:59 +0000 | [diff] [blame] | 1132 | for (ConstantInt *I : PTIHandled) { |
Andrew Trick | 90f5029 | 2012-11-15 18:40:29 +0000 | [diff] [blame] | 1133 | if (PredHasWeights || SuccHasWeights) |
Benjamin Kramer | 135f735 | 2016-06-26 12:28:59 +0000 | [diff] [blame] | 1134 | Weights.push_back(WeightsForHandled[I]); |
| 1135 | PredCases.push_back(ValueEqualityComparisonCase(I, BBDefault)); |
Chris Lattner | d3e6ae2 | 2004-02-28 21:28:10 +0000 | [diff] [blame] | 1136 | NewSuccessors.push_back(BBDefault); |
Eric Christopher | b65acc6 | 2012-07-02 23:22:21 +0000 | [diff] [blame] | 1137 | } |
Chris Lattner | d3e6ae2 | 2004-02-28 21:28:10 +0000 | [diff] [blame] | 1138 | } |
| 1139 | |
| 1140 | // Okay, at this point, we know which new successor Pred will get. Make |
| 1141 | // sure we update the number of entries in the PHI nodes for these |
| 1142 | // successors. |
Sanjay Patel | f4b34b7 | 2015-09-10 16:25:38 +0000 | [diff] [blame] | 1143 | for (BasicBlock *NewSuccessor : NewSuccessors) |
| 1144 | AddPredecessorToBlock(NewSuccessor, Pred, BB); |
Chris Lattner | d3e6ae2 | 2004-02-28 21:28:10 +0000 | [diff] [blame] | 1145 | |
Devang Patel | 5838055 | 2011-05-18 20:53:17 +0000 | [diff] [blame] | 1146 | Builder.SetInsertPoint(PTI); |
Jakob Stoklund Olesen | 916f48a | 2010-02-05 22:03:18 +0000 | [diff] [blame] | 1147 | // Convert pointer to int before we switch. |
Duncan Sands | 19d0b47 | 2010-02-16 11:11:14 +0000 | [diff] [blame] | 1148 | if (CV->getType()->isPointerTy()) { |
Mehdi Amini | a28d91d | 2015-03-10 02:37:25 +0000 | [diff] [blame] | 1149 | CV = Builder.CreatePtrToInt(CV, DL.getIntPtrType(CV->getType()), |
Devang Patel | 5838055 | 2011-05-18 20:53:17 +0000 | [diff] [blame] | 1150 | "magicptr"); |
Jakob Stoklund Olesen | 916f48a | 2010-02-05 22:03:18 +0000 | [diff] [blame] | 1151 | } |
| 1152 | |
Chris Lattner | d3e6ae2 | 2004-02-28 21:28:10 +0000 | [diff] [blame] | 1153 | // Now that the successors are updated, create the new Switch instruction. |
Dehao Chen | f6c0083 | 2016-05-18 19:44:21 +0000 | [diff] [blame] | 1154 | SwitchInst *NewSI = |
| 1155 | Builder.CreateSwitch(CV, PredDefault, PredCases.size()); |
Devang Patel | b849cd5 | 2011-05-17 23:29:05 +0000 | [diff] [blame] | 1156 | NewSI->setDebugLoc(PTI->getDebugLoc()); |
Sanjay Patel | 5e7bd91 | 2015-09-10 16:15:21 +0000 | [diff] [blame] | 1157 | for (ValueEqualityComparisonCase &V : PredCases) |
| 1158 | NewSI->addCase(V.Value, V.Dest); |
Chris Lattner | 3215bb6 | 2005-01-01 16:02:12 +0000 | [diff] [blame] | 1159 | |
Andrew Trick | 3051aa1 | 2012-08-29 21:46:38 +0000 | [diff] [blame] | 1160 | if (PredHasWeights || SuccHasWeights) { |
| 1161 | // Halve the weights if any of them cannot fit in an uint32_t |
| 1162 | FitWeights(Weights); |
| 1163 | |
| 1164 | SmallVector<uint32_t, 8> MDWeights(Weights.begin(), Weights.end()); |
| 1165 | |
Dehao Chen | f6c0083 | 2016-05-18 19:44:21 +0000 | [diff] [blame] | 1166 | NewSI->setMetadata( |
| 1167 | LLVMContext::MD_prof, |
| 1168 | MDBuilder(BB->getContext()).createBranchWeights(MDWeights)); |
Andrew Trick | 3051aa1 | 2012-08-29 21:46:38 +0000 | [diff] [blame] | 1169 | } |
| 1170 | |
Eli Friedman | cb61afb | 2008-12-16 20:54:32 +0000 | [diff] [blame] | 1171 | EraseTerminatorInstAndDCECond(PTI); |
Chris Lattner | 3215bb6 | 2005-01-01 16:02:12 +0000 | [diff] [blame] | 1172 | |
Chris Lattner | d3e6ae2 | 2004-02-28 21:28:10 +0000 | [diff] [blame] | 1173 | // Okay, last check. If BB is still a successor of PSI, then we must |
| 1174 | // have an infinite loop case. If so, add an infinitely looping block |
| 1175 | // to handle the case to preserve the behavior of the code. |
Craig Topper | f40110f | 2014-04-25 05:29:35 +0000 | [diff] [blame] | 1176 | BasicBlock *InfLoopBlock = nullptr; |
Chris Lattner | d3e6ae2 | 2004-02-28 21:28:10 +0000 | [diff] [blame] | 1177 | for (unsigned i = 0, e = NewSI->getNumSuccessors(); i != e; ++i) |
| 1178 | if (NewSI->getSuccessor(i) == BB) { |
Craig Topper | f40110f | 2014-04-25 05:29:35 +0000 | [diff] [blame] | 1179 | if (!InfLoopBlock) { |
Chris Lattner | 80b03a1 | 2008-07-13 22:23:11 +0000 | [diff] [blame] | 1180 | // Insert it at the end of the function, because it's either code, |
Chris Lattner | d3e6ae2 | 2004-02-28 21:28:10 +0000 | [diff] [blame] | 1181 | // or it won't matter if it's hot. :) |
Dehao Chen | f6c0083 | 2016-05-18 19:44:21 +0000 | [diff] [blame] | 1182 | InfLoopBlock = BasicBlock::Create(BB->getContext(), "infloop", |
| 1183 | BB->getParent()); |
Gabor Greif | e9ecc68 | 2008-04-06 20:25:17 +0000 | [diff] [blame] | 1184 | BranchInst::Create(InfLoopBlock, InfLoopBlock); |
Chris Lattner | d3e6ae2 | 2004-02-28 21:28:10 +0000 | [diff] [blame] | 1185 | } |
| 1186 | NewSI->setSuccessor(i, InfLoopBlock); |
| 1187 | } |
Misha Brukman | b1c9317 | 2005-04-21 23:48:37 +0000 | [diff] [blame] | 1188 | |
Chris Lattner | d3e6ae2 | 2004-02-28 21:28:10 +0000 | [diff] [blame] | 1189 | Changed = true; |
| 1190 | } |
| 1191 | } |
| 1192 | return Changed; |
| 1193 | } |
| 1194 | |
Sanjay Patel | 09159b8f | 2015-06-24 20:40:57 +0000 | [diff] [blame] | 1195 | // If we would need to insert a select that uses the value of this invoke |
| 1196 | // (comments in HoistThenElseCodeToIf explain why we would need to do this), we |
| 1197 | // can't hoist the invoke, as there is nowhere to put the select in this case. |
Dale Johannesen | 9df78ee | 2009-06-15 20:59:27 +0000 | [diff] [blame] | 1198 | static bool isSafeToHoistInvoke(BasicBlock *BB1, BasicBlock *BB2, |
| 1199 | Instruction *I1, Instruction *I2) { |
Sanjay Patel | 5781d84 | 2016-03-12 16:52:17 +0000 | [diff] [blame] | 1200 | for (BasicBlock *Succ : successors(BB1)) { |
Dale Johannesen | 9df78ee | 2009-06-15 20:59:27 +0000 | [diff] [blame] | 1201 | PHINode *PN; |
Sanjay Patel | 5781d84 | 2016-03-12 16:52:17 +0000 | [diff] [blame] | 1202 | for (BasicBlock::iterator BBI = Succ->begin(); |
Dale Johannesen | 9df78ee | 2009-06-15 20:59:27 +0000 | [diff] [blame] | 1203 | (PN = dyn_cast<PHINode>(BBI)); ++BBI) { |
| 1204 | Value *BB1V = PN->getIncomingValueForBlock(BB1); |
| 1205 | Value *BB2V = PN->getIncomingValueForBlock(BB2); |
Dehao Chen | f6c0083 | 2016-05-18 19:44:21 +0000 | [diff] [blame] | 1206 | if (BB1V != BB2V && (BB1V == I1 || BB2V == I2)) { |
Dale Johannesen | 9df78ee | 2009-06-15 20:59:27 +0000 | [diff] [blame] | 1207 | return false; |
| 1208 | } |
| 1209 | } |
| 1210 | } |
| 1211 | return true; |
| 1212 | } |
| 1213 | |
Arnold Schwaighofer | d7d010e | 2014-10-10 01:27:02 +0000 | [diff] [blame] | 1214 | static bool passingValueIsAlwaysUndefined(Value *V, Instruction *I); |
| 1215 | |
Sanjay Patel | 09159b8f | 2015-06-24 20:40:57 +0000 | [diff] [blame] | 1216 | /// Given a conditional branch that goes to BB1 and BB2, hoist any common code |
| 1217 | /// in the two blocks up into the branch block. The caller of this function |
| 1218 | /// guarantees that BI's block dominates BB1 and BB2. |
Mehdi Amini | a28d91d | 2015-03-10 02:37:25 +0000 | [diff] [blame] | 1219 | static bool HoistThenElseCodeToIf(BranchInst *BI, |
Chad Rosier | 5439005 | 2015-02-23 19:15:16 +0000 | [diff] [blame] | 1220 | const TargetTransformInfo &TTI) { |
Chris Lattner | 389cfac | 2004-11-30 00:29:14 +0000 | [diff] [blame] | 1221 | // This does very trivial matching, with limited scanning, to find identical |
| 1222 | // instructions in the two blocks. In particular, we don't want to get into |
| 1223 | // O(M*N) situations here where M and N are the sizes of BB1 and BB2. As |
| 1224 | // such, we currently just scan for obviously identical instructions in an |
| 1225 | // identical order. |
Dehao Chen | f6c0083 | 2016-05-18 19:44:21 +0000 | [diff] [blame] | 1226 | BasicBlock *BB1 = BI->getSuccessor(0); // The true destination. |
| 1227 | BasicBlock *BB2 = BI->getSuccessor(1); // The false destination |
Chris Lattner | 389cfac | 2004-11-30 00:29:14 +0000 | [diff] [blame] | 1228 | |
Devang Patel | f10e287 | 2009-02-04 00:03:08 +0000 | [diff] [blame] | 1229 | BasicBlock::iterator BB1_Itr = BB1->begin(); |
| 1230 | BasicBlock::iterator BB2_Itr = BB2->begin(); |
| 1231 | |
Duncan P. N. Exon Smith | 5b4c837 | 2015-10-13 02:39:05 +0000 | [diff] [blame] | 1232 | Instruction *I1 = &*BB1_Itr++, *I2 = &*BB2_Itr++; |
Devang Patel | 197c352 | 2011-04-07 17:27:36 +0000 | [diff] [blame] | 1233 | // Skip debug info if it is not identical. |
| 1234 | DbgInfoIntrinsic *DBI1 = dyn_cast<DbgInfoIntrinsic>(I1); |
| 1235 | DbgInfoIntrinsic *DBI2 = dyn_cast<DbgInfoIntrinsic>(I2); |
| 1236 | if (!DBI1 || !DBI2 || !DBI1->isIdenticalToWhenDefined(DBI2)) { |
| 1237 | while (isa<DbgInfoIntrinsic>(I1)) |
Duncan P. N. Exon Smith | 5b4c837 | 2015-10-13 02:39:05 +0000 | [diff] [blame] | 1238 | I1 = &*BB1_Itr++; |
Devang Patel | 197c352 | 2011-04-07 17:27:36 +0000 | [diff] [blame] | 1239 | while (isa<DbgInfoIntrinsic>(I2)) |
Duncan P. N. Exon Smith | 5b4c837 | 2015-10-13 02:39:05 +0000 | [diff] [blame] | 1240 | I2 = &*BB2_Itr++; |
Devang Patel | 197c352 | 2011-04-07 17:27:36 +0000 | [diff] [blame] | 1241 | } |
Devang Patel | e48ddf8 | 2011-04-07 00:30:15 +0000 | [diff] [blame] | 1242 | if (isa<PHINode>(I1) || !I1->isIdenticalToWhenDefined(I2) || |
Dale Johannesen | 9df78ee | 2009-06-15 20:59:27 +0000 | [diff] [blame] | 1243 | (isa<InvokeInst>(I1) && !isSafeToHoistInvoke(BB1, BB2, I1, I2))) |
Chris Lattner | 389cfac | 2004-11-30 00:29:14 +0000 | [diff] [blame] | 1244 | return false; |
| 1245 | |
Chris Lattner | 389cfac | 2004-11-30 00:29:14 +0000 | [diff] [blame] | 1246 | BasicBlock *BIParent = BI->getParent(); |
Chris Lattner | 389cfac | 2004-11-30 00:29:14 +0000 | [diff] [blame] | 1247 | |
David Majnemer | c82f27a | 2013-06-03 20:43:12 +0000 | [diff] [blame] | 1248 | bool Changed = false; |
Chris Lattner | 389cfac | 2004-11-30 00:29:14 +0000 | [diff] [blame] | 1249 | do { |
| 1250 | // If we are hoisting the terminator instruction, don't move one (making a |
| 1251 | // broken BB), instead clone it, and remove BI. |
| 1252 | if (isa<TerminatorInst>(I1)) |
| 1253 | goto HoistTerminator; |
Misha Brukman | b1c9317 | 2005-04-21 23:48:37 +0000 | [diff] [blame] | 1254 | |
Chad Rosier | 5439005 | 2015-02-23 19:15:16 +0000 | [diff] [blame] | 1255 | if (!TTI.isProfitableToHoist(I1) || !TTI.isProfitableToHoist(I2)) |
| 1256 | return Changed; |
| 1257 | |
Chris Lattner | 389cfac | 2004-11-30 00:29:14 +0000 | [diff] [blame] | 1258 | // For a normal instruction, we just move one to right before the branch, |
| 1259 | // then replace all uses of the other with the first. Finally, we remove |
| 1260 | // the now redundant second instruction. |
Duncan P. N. Exon Smith | 5b4c837 | 2015-10-13 02:39:05 +0000 | [diff] [blame] | 1261 | BIParent->getInstList().splice(BI->getIterator(), BB1->getInstList(), I1); |
Chris Lattner | 389cfac | 2004-11-30 00:29:14 +0000 | [diff] [blame] | 1262 | if (!I2->use_empty()) |
| 1263 | I2->replaceAllUsesWith(I1); |
Peter Collingbourne | 8f1dd5c | 2016-09-07 23:39:04 +0000 | [diff] [blame] | 1264 | I1->andIRFlags(I2); |
Dehao Chen | f6c0083 | 2016-05-18 19:44:21 +0000 | [diff] [blame] | 1265 | unsigned KnownIDs[] = {LLVMContext::MD_tbaa, |
| 1266 | LLVMContext::MD_range, |
| 1267 | LLVMContext::MD_fpmath, |
| 1268 | LLVMContext::MD_invariant_load, |
| 1269 | LLVMContext::MD_nonnull, |
| 1270 | LLVMContext::MD_invariant_group, |
| 1271 | LLVMContext::MD_align, |
| 1272 | LLVMContext::MD_dereferenceable, |
| 1273 | LLVMContext::MD_dereferenceable_or_null, |
| 1274 | LLVMContext::MD_mem_parallel_loop_access}; |
Rafael Espindola | ea46c32 | 2014-08-15 15:46:38 +0000 | [diff] [blame] | 1275 | combineMetadata(I1, I2, KnownIDs); |
Dehao Chen | 87823f8 | 2016-09-08 21:53:33 +0000 | [diff] [blame] | 1276 | |
| 1277 | // If the debug loc for I1 and I2 are different, as we are combining them |
| 1278 | // into one instruction, we do not want to select debug loc randomly from |
Andrea Di Biagio | f20c57e | 2016-12-15 20:01:26 +0000 | [diff] [blame] | 1279 | // I1 or I2. |
Dehao Chen | 87823f8 | 2016-09-08 21:53:33 +0000 | [diff] [blame] | 1280 | if (!isa<CallInst>(I1) && I1->getDebugLoc() != I2->getDebugLoc()) |
Andrea Di Biagio | f20c57e | 2016-12-15 20:01:26 +0000 | [diff] [blame] | 1281 | I1->setDebugLoc( |
| 1282 | DILocation::getMergedLocation(I1->getDebugLoc(), I2->getDebugLoc())); |
Dehao Chen | 87823f8 | 2016-09-08 21:53:33 +0000 | [diff] [blame] | 1283 | |
Chris Lattner | d7beca3 | 2010-12-14 06:17:25 +0000 | [diff] [blame] | 1284 | I2->eraseFromParent(); |
David Majnemer | c82f27a | 2013-06-03 20:43:12 +0000 | [diff] [blame] | 1285 | Changed = true; |
Misha Brukman | b1c9317 | 2005-04-21 23:48:37 +0000 | [diff] [blame] | 1286 | |
Duncan P. N. Exon Smith | 5b4c837 | 2015-10-13 02:39:05 +0000 | [diff] [blame] | 1287 | I1 = &*BB1_Itr++; |
| 1288 | I2 = &*BB2_Itr++; |
Devang Patel | 197c352 | 2011-04-07 17:27:36 +0000 | [diff] [blame] | 1289 | // Skip debug info if it is not identical. |
| 1290 | DbgInfoIntrinsic *DBI1 = dyn_cast<DbgInfoIntrinsic>(I1); |
| 1291 | DbgInfoIntrinsic *DBI2 = dyn_cast<DbgInfoIntrinsic>(I2); |
| 1292 | if (!DBI1 || !DBI2 || !DBI1->isIdenticalToWhenDefined(DBI2)) { |
| 1293 | while (isa<DbgInfoIntrinsic>(I1)) |
Duncan P. N. Exon Smith | 5b4c837 | 2015-10-13 02:39:05 +0000 | [diff] [blame] | 1294 | I1 = &*BB1_Itr++; |
Devang Patel | 197c352 | 2011-04-07 17:27:36 +0000 | [diff] [blame] | 1295 | while (isa<DbgInfoIntrinsic>(I2)) |
Duncan P. N. Exon Smith | 5b4c837 | 2015-10-13 02:39:05 +0000 | [diff] [blame] | 1296 | I2 = &*BB2_Itr++; |
Devang Patel | 197c352 | 2011-04-07 17:27:36 +0000 | [diff] [blame] | 1297 | } |
Devang Patel | e48ddf8 | 2011-04-07 00:30:15 +0000 | [diff] [blame] | 1298 | } while (I1->isIdenticalToWhenDefined(I2)); |
Chris Lattner | 389cfac | 2004-11-30 00:29:14 +0000 | [diff] [blame] | 1299 | |
| 1300 | return true; |
| 1301 | |
| 1302 | HoistTerminator: |
Dale Johannesen | 9df78ee | 2009-06-15 20:59:27 +0000 | [diff] [blame] | 1303 | // It may not be possible to hoist an invoke. |
| 1304 | if (isa<InvokeInst>(I1) && !isSafeToHoistInvoke(BB1, BB2, I1, I2)) |
David Majnemer | c82f27a | 2013-06-03 20:43:12 +0000 | [diff] [blame] | 1305 | return Changed; |
| 1306 | |
Sanjay Patel | 5781d84 | 2016-03-12 16:52:17 +0000 | [diff] [blame] | 1307 | for (BasicBlock *Succ : successors(BB1)) { |
David Majnemer | c82f27a | 2013-06-03 20:43:12 +0000 | [diff] [blame] | 1308 | PHINode *PN; |
Sanjay Patel | 5781d84 | 2016-03-12 16:52:17 +0000 | [diff] [blame] | 1309 | for (BasicBlock::iterator BBI = Succ->begin(); |
David Majnemer | c82f27a | 2013-06-03 20:43:12 +0000 | [diff] [blame] | 1310 | (PN = dyn_cast<PHINode>(BBI)); ++BBI) { |
| 1311 | Value *BB1V = PN->getIncomingValueForBlock(BB1); |
| 1312 | Value *BB2V = PN->getIncomingValueForBlock(BB2); |
| 1313 | if (BB1V == BB2V) |
| 1314 | continue; |
| 1315 | |
Arnold Schwaighofer | d7d010e | 2014-10-10 01:27:02 +0000 | [diff] [blame] | 1316 | // Check for passingValueIsAlwaysUndefined here because we would rather |
| 1317 | // eliminate undefined control flow then converting it to a select. |
| 1318 | if (passingValueIsAlwaysUndefined(BB1V, PN) || |
| 1319 | passingValueIsAlwaysUndefined(BB2V, PN)) |
Dehao Chen | f6c0083 | 2016-05-18 19:44:21 +0000 | [diff] [blame] | 1320 | return Changed; |
Arnold Schwaighofer | d7d010e | 2014-10-10 01:27:02 +0000 | [diff] [blame] | 1321 | |
Mehdi Amini | a28d91d | 2015-03-10 02:37:25 +0000 | [diff] [blame] | 1322 | if (isa<ConstantExpr>(BB1V) && !isSafeToSpeculativelyExecute(BB1V)) |
David Majnemer | c82f27a | 2013-06-03 20:43:12 +0000 | [diff] [blame] | 1323 | return Changed; |
Mehdi Amini | a28d91d | 2015-03-10 02:37:25 +0000 | [diff] [blame] | 1324 | if (isa<ConstantExpr>(BB2V) && !isSafeToSpeculativelyExecute(BB2V)) |
David Majnemer | c82f27a | 2013-06-03 20:43:12 +0000 | [diff] [blame] | 1325 | return Changed; |
| 1326 | } |
| 1327 | } |
Dale Johannesen | 9df78ee | 2009-06-15 20:59:27 +0000 | [diff] [blame] | 1328 | |
Chris Lattner | 389cfac | 2004-11-30 00:29:14 +0000 | [diff] [blame] | 1329 | // Okay, it is safe to hoist the terminator. |
Nick Lewycky | 42fb745 | 2009-09-27 07:38:41 +0000 | [diff] [blame] | 1330 | Instruction *NT = I1->clone(); |
Duncan P. N. Exon Smith | 5b4c837 | 2015-10-13 02:39:05 +0000 | [diff] [blame] | 1331 | BIParent->getInstList().insert(BI->getIterator(), NT); |
Benjamin Kramer | ccce8ba | 2010-01-05 13:12:22 +0000 | [diff] [blame] | 1332 | if (!NT->getType()->isVoidTy()) { |
Chris Lattner | 389cfac | 2004-11-30 00:29:14 +0000 | [diff] [blame] | 1333 | I1->replaceAllUsesWith(NT); |
| 1334 | I2->replaceAllUsesWith(NT); |
Chris Lattner | 8dd4cae | 2007-02-11 01:37:51 +0000 | [diff] [blame] | 1335 | NT->takeName(I1); |
Chris Lattner | 389cfac | 2004-11-30 00:29:14 +0000 | [diff] [blame] | 1336 | } |
| 1337 | |
Mehdi Amini | ba9fba8 | 2016-03-13 21:05:13 +0000 | [diff] [blame] | 1338 | IRBuilder<NoFolder> Builder(NT); |
Chris Lattner | 389cfac | 2004-11-30 00:29:14 +0000 | [diff] [blame] | 1339 | // Hoisting one of the terminators from our successor is a great thing. |
| 1340 | // Unfortunately, the successors of the if/else blocks may have PHI nodes in |
| 1341 | // them. If they do, all PHI entries for BB1/BB2 must agree for all PHI |
| 1342 | // nodes, so we insert select instruction to compute the final result. |
Dehao Chen | f6c0083 | 2016-05-18 19:44:21 +0000 | [diff] [blame] | 1343 | std::map<std::pair<Value *, Value *>, SelectInst *> InsertedSelects; |
Sanjay Patel | 5781d84 | 2016-03-12 16:52:17 +0000 | [diff] [blame] | 1344 | for (BasicBlock *Succ : successors(BB1)) { |
Chris Lattner | 389cfac | 2004-11-30 00:29:14 +0000 | [diff] [blame] | 1345 | PHINode *PN; |
Sanjay Patel | 5781d84 | 2016-03-12 16:52:17 +0000 | [diff] [blame] | 1346 | for (BasicBlock::iterator BBI = Succ->begin(); |
Chris Lattner | 0194457 | 2004-11-30 07:47:34 +0000 | [diff] [blame] | 1347 | (PN = dyn_cast<PHINode>(BBI)); ++BBI) { |
Chris Lattner | 389cfac | 2004-11-30 00:29:14 +0000 | [diff] [blame] | 1348 | Value *BB1V = PN->getIncomingValueForBlock(BB1); |
| 1349 | Value *BB2V = PN->getIncomingValueForBlock(BB2); |
Dehao Chen | f6c0083 | 2016-05-18 19:44:21 +0000 | [diff] [blame] | 1350 | if (BB1V == BB2V) |
| 1351 | continue; |
Andrew Trick | f3cf193 | 2012-08-29 21:46:36 +0000 | [diff] [blame] | 1352 | |
Chris Lattner | 4088e2b | 2010-12-13 01:47:07 +0000 | [diff] [blame] | 1353 | // These values do not agree. Insert a select instruction before NT |
| 1354 | // that determines the right value. |
| 1355 | SelectInst *&SI = InsertedSelects[std::make_pair(BB1V, BB2V)]; |
Craig Topper | f40110f | 2014-04-25 05:29:35 +0000 | [diff] [blame] | 1356 | if (!SI) |
Dehao Chen | f6c0083 | 2016-05-18 19:44:21 +0000 | [diff] [blame] | 1357 | SI = cast<SelectInst>( |
| 1358 | Builder.CreateSelect(BI->getCondition(), BB1V, BB2V, |
| 1359 | BB1V->getName() + "." + BB2V->getName(), BI)); |
Devang Patel | 1407fb4 | 2011-05-19 20:52:46 +0000 | [diff] [blame] | 1360 | |
Chris Lattner | 4088e2b | 2010-12-13 01:47:07 +0000 | [diff] [blame] | 1361 | // Make the PHI node use the select for all incoming values for BB1/BB2 |
| 1362 | for (unsigned i = 0, e = PN->getNumIncomingValues(); i != e; ++i) |
| 1363 | if (PN->getIncomingBlock(i) == BB1 || PN->getIncomingBlock(i) == BB2) |
| 1364 | PN->setIncomingValue(i, SI); |
Chris Lattner | 389cfac | 2004-11-30 00:29:14 +0000 | [diff] [blame] | 1365 | } |
| 1366 | } |
| 1367 | |
| 1368 | // Update any PHI nodes in our new successors. |
Sanjay Patel | 5781d84 | 2016-03-12 16:52:17 +0000 | [diff] [blame] | 1369 | for (BasicBlock *Succ : successors(BB1)) |
| 1370 | AddPredecessorToBlock(Succ, BIParent, BB1); |
Misha Brukman | b1c9317 | 2005-04-21 23:48:37 +0000 | [diff] [blame] | 1371 | |
Eli Friedman | cb61afb | 2008-12-16 20:54:32 +0000 | [diff] [blame] | 1372 | EraseTerminatorInstAndDCECond(BI); |
Chris Lattner | 389cfac | 2004-11-30 00:29:14 +0000 | [diff] [blame] | 1373 | return true; |
| 1374 | } |
| 1375 | |
James Molloy | 5bf2114 | 2016-08-22 19:07:15 +0000 | [diff] [blame] | 1376 | // Is it legal to place a variable in operand \c OpIdx of \c I? |
| 1377 | // FIXME: This should be promoted to Instruction. |
| 1378 | static bool canReplaceOperandWithVariable(const Instruction *I, |
| 1379 | unsigned OpIdx) { |
Hal Finkel | ac5803b | 2016-09-07 21:38:22 +0000 | [diff] [blame] | 1380 | // We can't have a PHI with a metadata type. |
| 1381 | if (I->getOperand(OpIdx)->getType()->isMetadataTy()) |
| 1382 | return false; |
| 1383 | |
James Molloy | 5bf2114 | 2016-08-22 19:07:15 +0000 | [diff] [blame] | 1384 | // Early exit. |
| 1385 | if (!isa<Constant>(I->getOperand(OpIdx))) |
| 1386 | return true; |
| 1387 | |
| 1388 | switch (I->getOpcode()) { |
| 1389 | default: |
| 1390 | return true; |
| 1391 | case Instruction::Call: |
| 1392 | case Instruction::Invoke: |
| 1393 | // FIXME: many arithmetic intrinsics have no issue taking a |
| 1394 | // variable, however it's hard to distingish these from |
| 1395 | // specials such as @llvm.frameaddress that require a constant. |
Sanjoy Das | bc357e8 | 2016-10-12 18:15:33 +0000 | [diff] [blame] | 1396 | if (isa<IntrinsicInst>(I)) |
| 1397 | return false; |
| 1398 | |
| 1399 | // Constant bundle operands may need to retain their constant-ness for |
| 1400 | // correctness. |
| 1401 | if (ImmutableCallSite(I).isBundleOperand(OpIdx)) |
| 1402 | return false; |
| 1403 | |
| 1404 | return true; |
| 1405 | |
James Molloy | 5bf2114 | 2016-08-22 19:07:15 +0000 | [diff] [blame] | 1406 | case Instruction::ShuffleVector: |
| 1407 | // Shufflevector masks are constant. |
| 1408 | return OpIdx != 2; |
| 1409 | case Instruction::ExtractValue: |
| 1410 | case Instruction::InsertValue: |
| 1411 | // All operands apart from the first are constant. |
| 1412 | return OpIdx == 0; |
| 1413 | case Instruction::Alloca: |
| 1414 | return false; |
| 1415 | case Instruction::GetElementPtr: |
| 1416 | if (OpIdx == 0) |
| 1417 | return true; |
| 1418 | gep_type_iterator It = std::next(gep_type_begin(I), OpIdx - 1); |
Peter Collingbourne | ab85225b | 2016-12-02 02:24:42 +0000 | [diff] [blame] | 1419 | return It.isSequential(); |
James Molloy | 5bf2114 | 2016-08-22 19:07:15 +0000 | [diff] [blame] | 1420 | } |
| 1421 | } |
| 1422 | |
James Molloy | eec6df3 | 2016-09-01 10:44:35 +0000 | [diff] [blame] | 1423 | // All instructions in Insts belong to different blocks that all unconditionally |
| 1424 | // branch to a common successor. Analyze each instruction and return true if it |
| 1425 | // would be possible to sink them into their successor, creating one common |
| 1426 | // instruction instead. For every value that would be required to be provided by |
| 1427 | // PHI node (because an operand varies in each input block), add to PHIOperands. |
| 1428 | static bool canSinkInstructions( |
| 1429 | ArrayRef<Instruction *> Insts, |
| 1430 | DenseMap<Instruction *, SmallVector<Value *, 4>> &PHIOperands) { |
James Molloy | 5bf2114 | 2016-08-22 19:07:15 +0000 | [diff] [blame] | 1431 | // Prune out obviously bad instructions to move. Any non-store instruction |
| 1432 | // must have exactly one use, and we check later that use is by a single, |
| 1433 | // common PHI instruction in the successor. |
| 1434 | for (auto *I : Insts) { |
| 1435 | // These instructions may change or break semantics if moved. |
| 1436 | if (isa<PHINode>(I) || I->isEHPad() || isa<AllocaInst>(I) || |
| 1437 | I->getType()->isTokenTy()) |
| 1438 | return false; |
James Molloy | 5bf2114 | 2016-08-22 19:07:15 +0000 | [diff] [blame] | 1439 | // Everything must have only one use too, apart from stores which |
| 1440 | // have no uses. |
| 1441 | if (!isa<StoreInst>(I) && !I->hasOneUse()) |
| 1442 | return false; |
| 1443 | } |
| 1444 | |
| 1445 | const Instruction *I0 = Insts.front(); |
| 1446 | for (auto *I : Insts) |
| 1447 | if (!I->isSameOperationAs(I0)) |
| 1448 | return false; |
| 1449 | |
James Molloy | eec6df3 | 2016-09-01 10:44:35 +0000 | [diff] [blame] | 1450 | // All instructions in Insts are known to be the same opcode. If they aren't |
| 1451 | // stores, check the only user of each is a PHI or in the same block as the |
| 1452 | // instruction, because if a user is in the same block as an instruction |
| 1453 | // we're contemplating sinking, it must already be determined to be sinkable. |
James Molloy | 5bf2114 | 2016-08-22 19:07:15 +0000 | [diff] [blame] | 1454 | if (!isa<StoreInst>(I0)) { |
| 1455 | auto *PNUse = dyn_cast<PHINode>(*I0->user_begin()); |
James Molloy | 6c009c1 | 2016-09-07 09:01:22 +0000 | [diff] [blame] | 1456 | auto *Succ = I0->getParent()->getTerminator()->getSuccessor(0); |
| 1457 | if (!all_of(Insts, [&PNUse,&Succ](const Instruction *I) -> bool { |
James Molloy | eec6df3 | 2016-09-01 10:44:35 +0000 | [diff] [blame] | 1458 | auto *U = cast<Instruction>(*I->user_begin()); |
James Molloy | bf1837d | 2016-09-07 08:15:54 +0000 | [diff] [blame] | 1459 | return (PNUse && |
James Molloy | 6c009c1 | 2016-09-07 09:01:22 +0000 | [diff] [blame] | 1460 | PNUse->getParent() == Succ && |
James Molloy | bf1837d | 2016-09-07 08:15:54 +0000 | [diff] [blame] | 1461 | PNUse->getIncomingValueForBlock(I->getParent()) == I) || |
| 1462 | U->getParent() == I->getParent(); |
James Molloy | 5bf2114 | 2016-08-22 19:07:15 +0000 | [diff] [blame] | 1463 | })) |
| 1464 | return false; |
| 1465 | } |
| 1466 | |
James Molloy | 5bf2114 | 2016-08-22 19:07:15 +0000 | [diff] [blame] | 1467 | for (unsigned OI = 0, OE = I0->getNumOperands(); OI != OE; ++OI) { |
| 1468 | if (I0->getOperand(OI)->getType()->isTokenTy()) |
| 1469 | // Don't touch any operand of token type. |
| 1470 | return false; |
James Molloy | 104370a | 2016-09-11 09:00:03 +0000 | [diff] [blame] | 1471 | |
| 1472 | // Because SROA can't handle speculating stores of selects, try not |
| 1473 | // to sink loads or stores of allocas when we'd have to create a PHI for |
| 1474 | // the address operand. Also, because it is likely that loads or stores |
| 1475 | // of allocas will disappear when Mem2Reg/SROA is run, don't sink them. |
| 1476 | // This can cause code churn which can have unintended consequences down |
| 1477 | // the line - see https://llvm.org/bugs/show_bug.cgi?id=30244. |
| 1478 | // FIXME: This is a workaround for a deficiency in SROA - see |
| 1479 | // https://llvm.org/bugs/show_bug.cgi?id=30188 |
| 1480 | if (OI == 1 && isa<StoreInst>(I0) && |
| 1481 | any_of(Insts, [](const Instruction *I) { |
| 1482 | return isa<AllocaInst>(I->getOperand(1)); |
| 1483 | })) |
| 1484 | return false; |
| 1485 | if (OI == 0 && isa<LoadInst>(I0) && any_of(Insts, [](const Instruction *I) { |
| 1486 | return isa<AllocaInst>(I->getOperand(0)); |
| 1487 | })) |
| 1488 | return false; |
| 1489 | |
James Molloy | 5bf2114 | 2016-08-22 19:07:15 +0000 | [diff] [blame] | 1490 | auto SameAsI0 = [&I0, OI](const Instruction *I) { |
James Molloy | eec6df3 | 2016-09-01 10:44:35 +0000 | [diff] [blame] | 1491 | assert(I->getNumOperands() == I0->getNumOperands()); |
| 1492 | return I->getOperand(OI) == I0->getOperand(OI); |
James Molloy | 5bf2114 | 2016-08-22 19:07:15 +0000 | [diff] [blame] | 1493 | }; |
| 1494 | if (!all_of(Insts, SameAsI0)) { |
| 1495 | if (!canReplaceOperandWithVariable(I0, OI)) |
| 1496 | // We can't create a PHI from this GEP. |
| 1497 | return false; |
James Molloy | 923e98c | 2016-08-31 10:46:16 +0000 | [diff] [blame] | 1498 | // Don't create indirect calls! The called value is the final operand. |
| 1499 | if ((isa<CallInst>(I0) || isa<InvokeInst>(I0)) && OI == OE - 1) { |
James Molloy | 5bf2114 | 2016-08-22 19:07:15 +0000 | [diff] [blame] | 1500 | // FIXME: if the call was *already* indirect, we should do this. |
| 1501 | return false; |
James Molloy | 923e98c | 2016-08-31 10:46:16 +0000 | [diff] [blame] | 1502 | } |
James Molloy | eec6df3 | 2016-09-01 10:44:35 +0000 | [diff] [blame] | 1503 | for (auto *I : Insts) |
| 1504 | PHIOperands[I].push_back(I->getOperand(OI)); |
James Molloy | 5bf2114 | 2016-08-22 19:07:15 +0000 | [diff] [blame] | 1505 | } |
| 1506 | } |
| 1507 | return true; |
| 1508 | } |
| 1509 | |
| 1510 | // Assuming canSinkLastInstruction(Blocks) has returned true, sink the last |
| 1511 | // instruction of every block in Blocks to their common successor, commoning |
| 1512 | // into one instruction. |
James Molloy | eec6df3 | 2016-09-01 10:44:35 +0000 | [diff] [blame] | 1513 | static bool sinkLastInstruction(ArrayRef<BasicBlock*> Blocks) { |
James Molloy | 5bf2114 | 2016-08-22 19:07:15 +0000 | [diff] [blame] | 1514 | auto *BBEnd = Blocks[0]->getTerminator()->getSuccessor(0); |
| 1515 | |
| 1516 | // canSinkLastInstruction returning true guarantees that every block has at |
| 1517 | // least one non-terminator instruction. |
| 1518 | SmallVector<Instruction*,4> Insts; |
Dehao Chen | 018a3af | 2016-10-17 19:28:44 +0000 | [diff] [blame] | 1519 | for (auto *BB : Blocks) { |
| 1520 | Instruction *I = BB->getTerminator(); |
| 1521 | do { |
| 1522 | I = I->getPrevNode(); |
| 1523 | } while (isa<DbgInfoIntrinsic>(I) && I != &BB->front()); |
| 1524 | if (!isa<DbgInfoIntrinsic>(I)) |
| 1525 | Insts.push_back(I); |
| 1526 | } |
James Molloy | 5bf2114 | 2016-08-22 19:07:15 +0000 | [diff] [blame] | 1527 | |
James Molloy | eec6df3 | 2016-09-01 10:44:35 +0000 | [diff] [blame] | 1528 | // The only checking we need to do now is that all users of all instructions |
| 1529 | // are the same PHI node. canSinkLastInstruction should have checked this but |
| 1530 | // it is slightly over-aggressive - it gets confused by commutative instructions |
| 1531 | // so double-check it here. |
James Molloy | 5bf2114 | 2016-08-22 19:07:15 +0000 | [diff] [blame] | 1532 | Instruction *I0 = Insts.front(); |
James Molloy | eec6df3 | 2016-09-01 10:44:35 +0000 | [diff] [blame] | 1533 | if (!isa<StoreInst>(I0)) { |
| 1534 | auto *PNUse = dyn_cast<PHINode>(*I0->user_begin()); |
| 1535 | if (!all_of(Insts, [&PNUse](const Instruction *I) -> bool { |
| 1536 | auto *U = cast<Instruction>(*I->user_begin()); |
| 1537 | return U == PNUse; |
| 1538 | })) |
| 1539 | return false; |
| 1540 | } |
| 1541 | |
| 1542 | // We don't need to do any more checking here; canSinkLastInstruction should |
| 1543 | // have done it all for us. |
James Molloy | 5bf2114 | 2016-08-22 19:07:15 +0000 | [diff] [blame] | 1544 | SmallVector<Value*, 4> NewOperands; |
| 1545 | for (unsigned O = 0, E = I0->getNumOperands(); O != E; ++O) { |
| 1546 | // This check is different to that in canSinkLastInstruction. There, we |
| 1547 | // cared about the global view once simplifycfg (and instcombine) have |
| 1548 | // completed - it takes into account PHIs that become trivially |
| 1549 | // simplifiable. However here we need a more local view; if an operand |
| 1550 | // differs we create a PHI and rely on instcombine to clean up the very |
| 1551 | // small mess we may make. |
| 1552 | bool NeedPHI = any_of(Insts, [&I0, O](const Instruction *I) { |
| 1553 | return I->getOperand(O) != I0->getOperand(O); |
| 1554 | }); |
| 1555 | if (!NeedPHI) { |
| 1556 | NewOperands.push_back(I0->getOperand(O)); |
| 1557 | continue; |
| 1558 | } |
| 1559 | |
| 1560 | // Create a new PHI in the successor block and populate it. |
| 1561 | auto *Op = I0->getOperand(O); |
| 1562 | assert(!Op->getType()->isTokenTy() && "Can't PHI tokens!"); |
| 1563 | auto *PN = PHINode::Create(Op->getType(), Insts.size(), |
| 1564 | Op->getName() + ".sink", &BBEnd->front()); |
| 1565 | for (auto *I : Insts) |
| 1566 | PN->addIncoming(I->getOperand(O), I->getParent()); |
| 1567 | NewOperands.push_back(PN); |
| 1568 | } |
| 1569 | |
| 1570 | // Arbitrarily use I0 as the new "common" instruction; remap its operands |
| 1571 | // and move it to the start of the successor block. |
| 1572 | for (unsigned O = 0, E = I0->getNumOperands(); O != E; ++O) |
| 1573 | I0->getOperandUse(O).set(NewOperands[O]); |
| 1574 | I0->moveBefore(&*BBEnd->getFirstInsertionPt()); |
| 1575 | |
Robert Lougher | 6ea759a | 2016-12-15 16:59:13 +0000 | [diff] [blame] | 1576 | // Update metadata and IR flags. |
James Molloy | d13b123 | 2016-08-30 10:56:08 +0000 | [diff] [blame] | 1577 | for (auto *I : Insts) |
James Molloy | 0efb96a | 2016-09-19 08:23:08 +0000 | [diff] [blame] | 1578 | if (I != I0) { |
James Molloy | d13b123 | 2016-08-30 10:56:08 +0000 | [diff] [blame] | 1579 | combineMetadataForCSE(I0, I); |
James Molloy | 0efb96a | 2016-09-19 08:23:08 +0000 | [diff] [blame] | 1580 | I0->andIRFlags(I); |
| 1581 | } |
James Molloy | d13b123 | 2016-08-30 10:56:08 +0000 | [diff] [blame] | 1582 | |
James Molloy | 5bf2114 | 2016-08-22 19:07:15 +0000 | [diff] [blame] | 1583 | if (!isa<StoreInst>(I0)) { |
| 1584 | // canSinkLastInstruction checked that all instructions were used by |
| 1585 | // one and only one PHI node. Find that now, RAUW it to our common |
| 1586 | // instruction and nuke it. |
| 1587 | assert(I0->hasOneUse()); |
| 1588 | auto *PN = cast<PHINode>(*I0->user_begin()); |
| 1589 | PN->replaceAllUsesWith(I0); |
| 1590 | PN->eraseFromParent(); |
| 1591 | } |
| 1592 | |
| 1593 | // Finally nuke all instructions apart from the common instruction. |
| 1594 | for (auto *I : Insts) |
| 1595 | if (I != I0) |
| 1596 | I->eraseFromParent(); |
James Molloy | eec6df3 | 2016-09-01 10:44:35 +0000 | [diff] [blame] | 1597 | |
| 1598 | return true; |
| 1599 | } |
| 1600 | |
| 1601 | namespace { |
Eugene Zelenko | a3fe70d | 2016-11-30 17:48:10 +0000 | [diff] [blame] | 1602 | |
James Molloy | eec6df3 | 2016-09-01 10:44:35 +0000 | [diff] [blame] | 1603 | // LockstepReverseIterator - Iterates through instructions |
| 1604 | // in a set of blocks in reverse order from the first non-terminator. |
| 1605 | // For example (assume all blocks have size n): |
| 1606 | // LockstepReverseIterator I([B1, B2, B3]); |
| 1607 | // *I-- = [B1[n], B2[n], B3[n]]; |
| 1608 | // *I-- = [B1[n-1], B2[n-1], B3[n-1]]; |
| 1609 | // *I-- = [B1[n-2], B2[n-2], B3[n-2]]; |
| 1610 | // ... |
| 1611 | class LockstepReverseIterator { |
| 1612 | ArrayRef<BasicBlock*> Blocks; |
| 1613 | SmallVector<Instruction*,4> Insts; |
| 1614 | bool Fail; |
| 1615 | public: |
| 1616 | LockstepReverseIterator(ArrayRef<BasicBlock*> Blocks) : |
| 1617 | Blocks(Blocks) { |
| 1618 | reset(); |
| 1619 | } |
| 1620 | |
| 1621 | void reset() { |
| 1622 | Fail = false; |
| 1623 | Insts.clear(); |
| 1624 | for (auto *BB : Blocks) { |
Dehao Chen | 018a3af | 2016-10-17 19:28:44 +0000 | [diff] [blame] | 1625 | Instruction *Inst = BB->getTerminator(); |
| 1626 | for (Inst = Inst->getPrevNode(); Inst && isa<DbgInfoIntrinsic>(Inst);) |
| 1627 | Inst = Inst->getPrevNode(); |
| 1628 | if (!Inst) { |
| 1629 | // Block wasn't big enough. |
| 1630 | Fail = true; |
| 1631 | return; |
James Molloy | eec6df3 | 2016-09-01 10:44:35 +0000 | [diff] [blame] | 1632 | } |
Dehao Chen | 018a3af | 2016-10-17 19:28:44 +0000 | [diff] [blame] | 1633 | Insts.push_back(Inst); |
James Molloy | eec6df3 | 2016-09-01 10:44:35 +0000 | [diff] [blame] | 1634 | } |
| 1635 | } |
| 1636 | |
| 1637 | bool isValid() const { |
| 1638 | return !Fail; |
| 1639 | } |
| 1640 | |
| 1641 | void operator -- () { |
| 1642 | if (Fail) |
| 1643 | return; |
| 1644 | for (auto *&Inst : Insts) { |
Dehao Chen | 018a3af | 2016-10-17 19:28:44 +0000 | [diff] [blame] | 1645 | for (Inst = Inst->getPrevNode(); Inst && isa<DbgInfoIntrinsic>(Inst);) |
| 1646 | Inst = Inst->getPrevNode(); |
Benjamin Kramer | d8b0797 | 2016-10-15 13:15:05 +0000 | [diff] [blame] | 1647 | // Already at beginning of block. |
| 1648 | if (!Inst) { |
James Molloy | eec6df3 | 2016-09-01 10:44:35 +0000 | [diff] [blame] | 1649 | Fail = true; |
| 1650 | return; |
| 1651 | } |
James Molloy | eec6df3 | 2016-09-01 10:44:35 +0000 | [diff] [blame] | 1652 | } |
| 1653 | } |
| 1654 | |
| 1655 | ArrayRef<Instruction*> operator * () const { |
| 1656 | return Insts; |
| 1657 | } |
| 1658 | }; |
Eugene Zelenko | a3fe70d | 2016-11-30 17:48:10 +0000 | [diff] [blame] | 1659 | |
| 1660 | } // end anonymous namespace |
James Molloy | 5bf2114 | 2016-08-22 19:07:15 +0000 | [diff] [blame] | 1661 | |
Sanjay Patel | 09159b8f | 2015-06-24 20:40:57 +0000 | [diff] [blame] | 1662 | /// Given an unconditional branch that goes to BBEnd, |
Manman Ren | 93ab649 | 2012-09-20 22:37:36 +0000 | [diff] [blame] | 1663 | /// check whether BBEnd has only two predecessors and the other predecessor |
| 1664 | /// ends with an unconditional branch. If it is true, sink any common code |
| 1665 | /// in the two predecessors to BBEnd. |
| 1666 | static bool SinkThenElseCodeToEnd(BranchInst *BI1) { |
| 1667 | assert(BI1->isUnconditional()); |
Manman Ren | 93ab649 | 2012-09-20 22:37:36 +0000 | [diff] [blame] | 1668 | BasicBlock *BBEnd = BI1->getSuccessor(0); |
| 1669 | |
James Molloy | 88cad7e | 2016-09-01 12:58:13 +0000 | [diff] [blame] | 1670 | // We support two situations: |
| 1671 | // (1) all incoming arcs are unconditional |
| 1672 | // (2) one incoming arc is conditional |
| 1673 | // |
| 1674 | // (2) is very common in switch defaults and |
| 1675 | // else-if patterns; |
| 1676 | // |
| 1677 | // if (a) f(1); |
| 1678 | // else if (b) f(2); |
| 1679 | // |
| 1680 | // produces: |
| 1681 | // |
| 1682 | // [if] |
| 1683 | // / \ |
| 1684 | // [f(1)] [if] |
| 1685 | // | | \ |
| 1686 | // | | \ |
| 1687 | // | [f(2)]| |
| 1688 | // \ | / |
| 1689 | // [ end ] |
| 1690 | // |
| 1691 | // [end] has two unconditional predecessor arcs and one conditional. The |
| 1692 | // conditional refers to the implicit empty 'else' arc. This conditional |
| 1693 | // arc can also be caused by an empty default block in a switch. |
| 1694 | // |
| 1695 | // In this case, we attempt to sink code from all *unconditional* arcs. |
| 1696 | // If we can sink instructions from these arcs (determined during the scan |
| 1697 | // phase below) we insert a common successor for all unconditional arcs and |
| 1698 | // connect that to [end], to enable sinking: |
| 1699 | // |
| 1700 | // [if] |
| 1701 | // / \ |
| 1702 | // [x(1)] [if] |
| 1703 | // | | \ |
| 1704 | // | | \ |
| 1705 | // | [x(2)] | |
| 1706 | // \ / | |
| 1707 | // [sink.split] | |
| 1708 | // \ / |
| 1709 | // [ end ] |
| 1710 | // |
| 1711 | SmallVector<BasicBlock*,4> UnconditionalPreds; |
| 1712 | Instruction *Cond = nullptr; |
| 1713 | for (auto *B : predecessors(BBEnd)) { |
| 1714 | auto *T = B->getTerminator(); |
| 1715 | if (isa<BranchInst>(T) && cast<BranchInst>(T)->isUnconditional()) |
| 1716 | UnconditionalPreds.push_back(B); |
| 1717 | else if ((isa<BranchInst>(T) || isa<SwitchInst>(T)) && !Cond) |
| 1718 | Cond = T; |
| 1719 | else |
| 1720 | return false; |
| 1721 | } |
| 1722 | if (UnconditionalPreds.size() < 2) |
James Molloy | 475f4a7 | 2016-08-22 18:13:12 +0000 | [diff] [blame] | 1723 | return false; |
James Molloy | 88cad7e | 2016-09-01 12:58:13 +0000 | [diff] [blame] | 1724 | |
Manman Ren | 93ab649 | 2012-09-20 22:37:36 +0000 | [diff] [blame] | 1725 | bool Changed = false; |
James Molloy | eec6df3 | 2016-09-01 10:44:35 +0000 | [diff] [blame] | 1726 | // We take a two-step approach to tail sinking. First we scan from the end of |
| 1727 | // each block upwards in lockstep. If the n'th instruction from the end of each |
| 1728 | // block can be sunk, those instructions are added to ValuesToSink and we |
| 1729 | // carry on. If we can sink an instruction but need to PHI-merge some operands |
| 1730 | // (because they're not identical in each instruction) we add these to |
| 1731 | // PHIOperands. |
| 1732 | unsigned ScanIdx = 0; |
| 1733 | SmallPtrSet<Value*,4> InstructionsToSink; |
| 1734 | DenseMap<Instruction*, SmallVector<Value*,4>> PHIOperands; |
James Molloy | 88cad7e | 2016-09-01 12:58:13 +0000 | [diff] [blame] | 1735 | LockstepReverseIterator LRI(UnconditionalPreds); |
James Molloy | eec6df3 | 2016-09-01 10:44:35 +0000 | [diff] [blame] | 1736 | while (LRI.isValid() && |
| 1737 | canSinkInstructions(*LRI, PHIOperands)) { |
| 1738 | DEBUG(dbgs() << "SINK: instruction can be sunk: " << *(*LRI)[0] << "\n"); |
| 1739 | InstructionsToSink.insert((*LRI).begin(), (*LRI).end()); |
| 1740 | ++ScanIdx; |
| 1741 | --LRI; |
| 1742 | } |
| 1743 | |
James Molloy | 18d96e8 | 2016-09-11 08:07:30 +0000 | [diff] [blame] | 1744 | auto ProfitableToSinkInstruction = [&](LockstepReverseIterator &LRI) { |
James Molloy | 88cad7e | 2016-09-01 12:58:13 +0000 | [diff] [blame] | 1745 | unsigned NumPHIdValues = 0; |
| 1746 | for (auto *I : *LRI) |
| 1747 | for (auto *V : PHIOperands[I]) |
| 1748 | if (InstructionsToSink.count(V) == 0) |
| 1749 | ++NumPHIdValues; |
| 1750 | DEBUG(dbgs() << "SINK: #phid values: " << NumPHIdValues << "\n"); |
| 1751 | unsigned NumPHIInsts = NumPHIdValues / UnconditionalPreds.size(); |
| 1752 | if ((NumPHIdValues % UnconditionalPreds.size()) != 0) |
| 1753 | NumPHIInsts++; |
| 1754 | |
| 1755 | return NumPHIInsts <= 1; |
| 1756 | }; |
| 1757 | |
| 1758 | if (ScanIdx > 0 && Cond) { |
James Molloy | 18d96e8 | 2016-09-11 08:07:30 +0000 | [diff] [blame] | 1759 | // Check if we would actually sink anything first! This mutates the CFG and |
| 1760 | // adds an extra block. The goal in doing this is to allow instructions that |
| 1761 | // couldn't be sunk before to be sunk - obviously, speculatable instructions |
| 1762 | // (such as trunc, add) can be sunk and predicated already. So we check that |
| 1763 | // we're going to sink at least one non-speculatable instruction. |
| 1764 | LRI.reset(); |
| 1765 | unsigned Idx = 0; |
| 1766 | bool Profitable = false; |
| 1767 | while (ProfitableToSinkInstruction(LRI) && Idx < ScanIdx) { |
| 1768 | if (!isSafeToSpeculativelyExecute((*LRI)[0])) { |
| 1769 | Profitable = true; |
| 1770 | break; |
| 1771 | } |
| 1772 | --LRI; |
| 1773 | ++Idx; |
| 1774 | } |
| 1775 | if (!Profitable) |
James Molloy | 88cad7e | 2016-09-01 12:58:13 +0000 | [diff] [blame] | 1776 | return false; |
| 1777 | |
| 1778 | DEBUG(dbgs() << "SINK: Splitting edge\n"); |
| 1779 | // We have a conditional edge and we're going to sink some instructions. |
| 1780 | // Insert a new block postdominating all blocks we're going to sink from. |
| 1781 | if (!SplitBlockPredecessors(BI1->getSuccessor(0), UnconditionalPreds, |
| 1782 | ".sink.split")) |
| 1783 | // Edges couldn't be split. |
| 1784 | return false; |
| 1785 | Changed = true; |
| 1786 | } |
| 1787 | |
James Molloy | eec6df3 | 2016-09-01 10:44:35 +0000 | [diff] [blame] | 1788 | // Now that we've analyzed all potential sinking candidates, perform the |
| 1789 | // actual sink. We iteratively sink the last non-terminator of the source |
| 1790 | // blocks into their common successor unless doing so would require too |
| 1791 | // many PHI instructions to be generated (currently only one PHI is allowed |
| 1792 | // per sunk instruction). |
| 1793 | // |
| 1794 | // We can use InstructionsToSink to discount values needing PHI-merging that will |
| 1795 | // actually be sunk in a later iteration. This allows us to be more |
| 1796 | // aggressive in what we sink. This does allow a false positive where we |
| 1797 | // sink presuming a later value will also be sunk, but stop half way through |
| 1798 | // and never actually sink it which means we produce more PHIs than intended. |
| 1799 | // This is unlikely in practice though. |
| 1800 | for (unsigned SinkIdx = 0; SinkIdx != ScanIdx; ++SinkIdx) { |
| 1801 | DEBUG(dbgs() << "SINK: Sink: " |
James Molloy | 88cad7e | 2016-09-01 12:58:13 +0000 | [diff] [blame] | 1802 | << *UnconditionalPreds[0]->getTerminator()->getPrevNode() |
James Molloy | eec6df3 | 2016-09-01 10:44:35 +0000 | [diff] [blame] | 1803 | << "\n"); |
| 1804 | |
| 1805 | // Because we've sunk every instruction in turn, the current instruction to |
| 1806 | // sink is always at index 0. |
James Molloy | 18d96e8 | 2016-09-11 08:07:30 +0000 | [diff] [blame] | 1807 | LRI.reset(); |
| 1808 | if (!ProfitableToSinkInstruction(LRI)) { |
James Molloy | eec6df3 | 2016-09-01 10:44:35 +0000 | [diff] [blame] | 1809 | // Too many PHIs would be created. |
James Molloy | 88cad7e | 2016-09-01 12:58:13 +0000 | [diff] [blame] | 1810 | DEBUG(dbgs() << "SINK: stopping here, too many PHIs would be created!\n"); |
James Molloy | eec6df3 | 2016-09-01 10:44:35 +0000 | [diff] [blame] | 1811 | break; |
James Molloy | 88cad7e | 2016-09-01 12:58:13 +0000 | [diff] [blame] | 1812 | } |
James Molloy | eec6df3 | 2016-09-01 10:44:35 +0000 | [diff] [blame] | 1813 | |
James Molloy | 88cad7e | 2016-09-01 12:58:13 +0000 | [diff] [blame] | 1814 | if (!sinkLastInstruction(UnconditionalPreds)) |
James Molloy | eec6df3 | 2016-09-01 10:44:35 +0000 | [diff] [blame] | 1815 | return Changed; |
Manman Ren | 93ab649 | 2012-09-20 22:37:36 +0000 | [diff] [blame] | 1816 | NumSinkCommons++; |
| 1817 | Changed = true; |
| 1818 | } |
| 1819 | return Changed; |
| 1820 | } |
| 1821 | |
Arnold Schwaighofer | 474df6d | 2013-04-29 21:28:24 +0000 | [diff] [blame] | 1822 | /// \brief Determine if we can hoist sink a sole store instruction out of a |
| 1823 | /// conditional block. |
| 1824 | /// |
| 1825 | /// We are looking for code like the following: |
| 1826 | /// BrBB: |
| 1827 | /// store i32 %add, i32* %arrayidx2 |
| 1828 | /// ... // No other stores or function calls (we could be calling a memory |
| 1829 | /// ... // function). |
| 1830 | /// %cmp = icmp ult %x, %y |
| 1831 | /// br i1 %cmp, label %EndBB, label %ThenBB |
| 1832 | /// ThenBB: |
| 1833 | /// store i32 %add5, i32* %arrayidx2 |
| 1834 | /// br label EndBB |
| 1835 | /// EndBB: |
| 1836 | /// ... |
| 1837 | /// We are going to transform this into: |
| 1838 | /// BrBB: |
| 1839 | /// store i32 %add, i32* %arrayidx2 |
| 1840 | /// ... // |
| 1841 | /// %cmp = icmp ult %x, %y |
| 1842 | /// %add.add5 = select i1 %cmp, i32 %add, %add5 |
| 1843 | /// store i32 %add.add5, i32* %arrayidx2 |
| 1844 | /// ... |
| 1845 | /// |
| 1846 | /// \return The pointer to the value of the previous store if the store can be |
| 1847 | /// hoisted into the predecessor block. 0 otherwise. |
Benjamin Kramer | ad5c24f | 2013-05-23 16:09:15 +0000 | [diff] [blame] | 1848 | static Value *isSafeToSpeculateStore(Instruction *I, BasicBlock *BrBB, |
| 1849 | BasicBlock *StoreBB, BasicBlock *EndBB) { |
Arnold Schwaighofer | 474df6d | 2013-04-29 21:28:24 +0000 | [diff] [blame] | 1850 | StoreInst *StoreToHoist = dyn_cast<StoreInst>(I); |
| 1851 | if (!StoreToHoist) |
Craig Topper | f40110f | 2014-04-25 05:29:35 +0000 | [diff] [blame] | 1852 | return nullptr; |
Arnold Schwaighofer | 474df6d | 2013-04-29 21:28:24 +0000 | [diff] [blame] | 1853 | |
| 1854 | // Volatile or atomic. |
| 1855 | if (!StoreToHoist->isSimple()) |
Craig Topper | f40110f | 2014-04-25 05:29:35 +0000 | [diff] [blame] | 1856 | return nullptr; |
Arnold Schwaighofer | 474df6d | 2013-04-29 21:28:24 +0000 | [diff] [blame] | 1857 | |
| 1858 | Value *StorePtr = StoreToHoist->getPointerOperand(); |
| 1859 | |
| 1860 | // Look for a store to the same pointer in BrBB. |
Hans Wennborg | 0c3518e | 2016-05-04 15:40:57 +0000 | [diff] [blame] | 1861 | unsigned MaxNumInstToLookAt = 9; |
David Majnemer | d770877 | 2016-06-24 04:05:21 +0000 | [diff] [blame] | 1862 | for (Instruction &CurI : reverse(*BrBB)) { |
| 1863 | if (!MaxNumInstToLookAt) |
| 1864 | break; |
Hans Wennborg | 0c3518e | 2016-05-04 15:40:57 +0000 | [diff] [blame] | 1865 | // Skip debug info. |
| 1866 | if (isa<DbgInfoIntrinsic>(CurI)) |
| 1867 | continue; |
| 1868 | --MaxNumInstToLookAt; |
Arnold Schwaighofer | 474df6d | 2013-04-29 21:28:24 +0000 | [diff] [blame] | 1869 | |
David L Kreitzer | 9667417 | 2016-08-12 21:06:53 +0000 | [diff] [blame] | 1870 | // Could be calling an instruction that affects memory like free(). |
David Majnemer | d770877 | 2016-06-24 04:05:21 +0000 | [diff] [blame] | 1871 | if (CurI.mayHaveSideEffects() && !isa<StoreInst>(CurI)) |
Craig Topper | f40110f | 2014-04-25 05:29:35 +0000 | [diff] [blame] | 1872 | return nullptr; |
Arnold Schwaighofer | 474df6d | 2013-04-29 21:28:24 +0000 | [diff] [blame] | 1873 | |
David Majnemer | d770877 | 2016-06-24 04:05:21 +0000 | [diff] [blame] | 1874 | if (auto *SI = dyn_cast<StoreInst>(&CurI)) { |
| 1875 | // Found the previous store make sure it stores to the same location. |
| 1876 | if (SI->getPointerOperand() == StorePtr) |
| 1877 | // Found the previous store, return its value operand. |
| 1878 | return SI->getValueOperand(); |
Craig Topper | f40110f | 2014-04-25 05:29:35 +0000 | [diff] [blame] | 1879 | return nullptr; // Unknown store. |
David Majnemer | d770877 | 2016-06-24 04:05:21 +0000 | [diff] [blame] | 1880 | } |
Arnold Schwaighofer | 474df6d | 2013-04-29 21:28:24 +0000 | [diff] [blame] | 1881 | } |
| 1882 | |
Craig Topper | f40110f | 2014-04-25 05:29:35 +0000 | [diff] [blame] | 1883 | return nullptr; |
Arnold Schwaighofer | 474df6d | 2013-04-29 21:28:24 +0000 | [diff] [blame] | 1884 | } |
| 1885 | |
Chandler Carruth | 8a4a166 | 2013-01-24 08:05:06 +0000 | [diff] [blame] | 1886 | /// \brief Speculate a conditional basic block flattening the CFG. |
Dan Gohman | 5ab9c0a | 2012-01-05 23:58:56 +0000 | [diff] [blame] | 1887 | /// |
Chandler Carruth | 8a4a166 | 2013-01-24 08:05:06 +0000 | [diff] [blame] | 1888 | /// Note that this is a very risky transform currently. Speculating |
| 1889 | /// instructions like this is most often not desirable. Instead, there is an MI |
| 1890 | /// pass which can do it with full awareness of the resource constraints. |
| 1891 | /// However, some cases are "obvious" and we should do directly. An example of |
| 1892 | /// this is speculating a single, reasonably cheap instruction. |
| 1893 | /// |
| 1894 | /// There is only one distinct advantage to flattening the CFG at the IR level: |
| 1895 | /// it makes very common but simplistic optimizations such as are common in |
| 1896 | /// instcombine and the DAG combiner more powerful by removing CFG edges and |
| 1897 | /// modeling their effects with easier to reason about SSA value graphs. |
| 1898 | /// |
| 1899 | /// |
| 1900 | /// An illustration of this transform is turning this IR: |
| 1901 | /// \code |
| 1902 | /// BB: |
| 1903 | /// %cmp = icmp ult %x, %y |
| 1904 | /// br i1 %cmp, label %EndBB, label %ThenBB |
| 1905 | /// ThenBB: |
| 1906 | /// %sub = sub %x, %y |
Dan Gohman | 5ab9c0a | 2012-01-05 23:58:56 +0000 | [diff] [blame] | 1907 | /// br label BB2 |
Chandler Carruth | 8a4a166 | 2013-01-24 08:05:06 +0000 | [diff] [blame] | 1908 | /// EndBB: |
| 1909 | /// %phi = phi [ %sub, %ThenBB ], [ 0, %EndBB ] |
| 1910 | /// ... |
| 1911 | /// \endcode |
| 1912 | /// |
| 1913 | /// Into this IR: |
| 1914 | /// \code |
| 1915 | /// BB: |
| 1916 | /// %cmp = icmp ult %x, %y |
| 1917 | /// %sub = sub %x, %y |
| 1918 | /// %cond = select i1 %cmp, 0, %sub |
| 1919 | /// ... |
| 1920 | /// \endcode |
| 1921 | /// |
| 1922 | /// \returns true if the conditional block is removed. |
Hal Finkel | a995f92 | 2014-07-10 14:41:31 +0000 | [diff] [blame] | 1923 | static bool SpeculativelyExecuteBB(BranchInst *BI, BasicBlock *ThenBB, |
James Molloy | 7c33657 | 2015-02-11 12:15:41 +0000 | [diff] [blame] | 1924 | const TargetTransformInfo &TTI) { |
Chandler Carruth | 1d20c02 | 2013-01-24 08:22:40 +0000 | [diff] [blame] | 1925 | // Be conservative for now. FP select instruction can often be expensive. |
| 1926 | Value *BrCond = BI->getCondition(); |
| 1927 | if (isa<FCmpInst>(BrCond)) |
| 1928 | return false; |
| 1929 | |
Chandler Carruth | e2a779f | 2013-01-24 09:59:39 +0000 | [diff] [blame] | 1930 | BasicBlock *BB = BI->getParent(); |
| 1931 | BasicBlock *EndBB = ThenBB->getTerminator()->getSuccessor(0); |
| 1932 | |
| 1933 | // If ThenBB is actually on the false edge of the conditional branch, remember |
| 1934 | // to swap the select operands later. |
| 1935 | bool Invert = false; |
| 1936 | if (ThenBB != BI->getSuccessor(0)) { |
| 1937 | assert(ThenBB == BI->getSuccessor(1) && "No edge from 'if' block?"); |
| 1938 | Invert = true; |
| 1939 | } |
| 1940 | assert(EndBB == BI->getSuccessor(!Invert) && "No edge from to end block"); |
| 1941 | |
Chandler Carruth | ceff222 | 2013-01-25 05:40:09 +0000 | [diff] [blame] | 1942 | // Keep a count of how many times instructions are used within CondBB when |
| 1943 | // they are candidates for sinking into CondBB. Specifically: |
| 1944 | // - They are defined in BB, and |
| 1945 | // - They have no side effects, and |
| 1946 | // - All of their uses are in CondBB. |
| 1947 | SmallDenseMap<Instruction *, unsigned, 4> SinkCandidateUseCounts; |
| 1948 | |
Chandler Carruth | 7481ca8 | 2013-01-24 11:52:58 +0000 | [diff] [blame] | 1949 | unsigned SpeculationCost = 0; |
Craig Topper | f40110f | 2014-04-25 05:29:35 +0000 | [diff] [blame] | 1950 | Value *SpeculatedStoreValue = nullptr; |
| 1951 | StoreInst *SpeculatedStore = nullptr; |
Chandler Carruth | 7481ca8 | 2013-01-24 11:52:58 +0000 | [diff] [blame] | 1952 | for (BasicBlock::iterator BBI = ThenBB->begin(), |
Benjamin Kramer | b6d0bd4 | 2014-03-02 12:27:27 +0000 | [diff] [blame] | 1953 | BBE = std::prev(ThenBB->end()); |
Devang Patel | 5aed776 | 2009-03-06 06:00:17 +0000 | [diff] [blame] | 1954 | BBI != BBE; ++BBI) { |
Duncan P. N. Exon Smith | 5b4c837 | 2015-10-13 02:39:05 +0000 | [diff] [blame] | 1955 | Instruction *I = &*BBI; |
Devang Patel | 5aed776 | 2009-03-06 06:00:17 +0000 | [diff] [blame] | 1956 | // Skip debug info. |
Chandler Carruth | 7481ca8 | 2013-01-24 11:52:58 +0000 | [diff] [blame] | 1957 | if (isa<DbgInfoIntrinsic>(I)) |
| 1958 | continue; |
Devang Patel | 5aed776 | 2009-03-06 06:00:17 +0000 | [diff] [blame] | 1959 | |
Mark Lacey | 274f48b | 2015-04-12 18:18:51 +0000 | [diff] [blame] | 1960 | // Only speculatively execute a single instruction (not counting the |
Chandler Carruth | 7481ca8 | 2013-01-24 11:52:58 +0000 | [diff] [blame] | 1961 | // terminator) for now. |
Chandler Carruth | 329b590 | 2013-01-27 06:42:03 +0000 | [diff] [blame] | 1962 | ++SpeculationCost; |
| 1963 | if (SpeculationCost > 1) |
Devang Patel | 5aed776 | 2009-03-06 06:00:17 +0000 | [diff] [blame] | 1964 | return false; |
Dan Gohman | 5ab9c0a | 2012-01-05 23:58:56 +0000 | [diff] [blame] | 1965 | |
Dan Gohman | 5ab9c0a | 2012-01-05 23:58:56 +0000 | [diff] [blame] | 1966 | // Don't hoist the instruction if it's unsafe or expensive. |
Mehdi Amini | a28d91d | 2015-03-10 02:37:25 +0000 | [diff] [blame] | 1967 | if (!isSafeToSpeculativelyExecute(I) && |
| 1968 | !(HoistCondStores && (SpeculatedStoreValue = isSafeToSpeculateStore( |
| 1969 | I, BB, ThenBB, EndBB)))) |
Dan Gohman | 5ab9c0a | 2012-01-05 23:58:56 +0000 | [diff] [blame] | 1970 | return false; |
Arnold Schwaighofer | 474df6d | 2013-04-29 21:28:24 +0000 | [diff] [blame] | 1971 | if (!SpeculatedStoreValue && |
Mehdi Amini | a28d91d | 2015-03-10 02:37:25 +0000 | [diff] [blame] | 1972 | ComputeSpeculationCost(I, TTI) > |
| 1973 | PHINodeFoldingThreshold * TargetTransformInfo::TCC_Basic) |
Dan Gohman | 5ab9c0a | 2012-01-05 23:58:56 +0000 | [diff] [blame] | 1974 | return false; |
| 1975 | |
Arnold Schwaighofer | 474df6d | 2013-04-29 21:28:24 +0000 | [diff] [blame] | 1976 | // Store the store speculation candidate. |
| 1977 | if (SpeculatedStoreValue) |
| 1978 | SpeculatedStore = cast<StoreInst>(I); |
| 1979 | |
Dan Gohman | 5ab9c0a | 2012-01-05 23:58:56 +0000 | [diff] [blame] | 1980 | // Do not hoist the instruction if any of its operands are defined but not |
Arnold Schwaighofer | 474df6d | 2013-04-29 21:28:24 +0000 | [diff] [blame] | 1981 | // used in BB. The transformation will prevent the operand from |
Dan Gohman | 5ab9c0a | 2012-01-05 23:58:56 +0000 | [diff] [blame] | 1982 | // being sunk into the use block. |
Dehao Chen | f6c0083 | 2016-05-18 19:44:21 +0000 | [diff] [blame] | 1983 | for (User::op_iterator i = I->op_begin(), e = I->op_end(); i != e; ++i) { |
Dan Gohman | 5ab9c0a | 2012-01-05 23:58:56 +0000 | [diff] [blame] | 1984 | Instruction *OpI = dyn_cast<Instruction>(*i); |
Dehao Chen | f6c0083 | 2016-05-18 19:44:21 +0000 | [diff] [blame] | 1985 | if (!OpI || OpI->getParent() != BB || OpI->mayHaveSideEffects()) |
Chandler Carruth | ceff222 | 2013-01-25 05:40:09 +0000 | [diff] [blame] | 1986 | continue; // Not a candidate for sinking. |
| 1987 | |
| 1988 | ++SinkCandidateUseCounts[OpI]; |
Dan Gohman | 5ab9c0a | 2012-01-05 23:58:56 +0000 | [diff] [blame] | 1989 | } |
| 1990 | } |
Evan Cheng | 89200c9 | 2008-06-07 08:52:29 +0000 | [diff] [blame] | 1991 | |
Chandler Carruth | ceff222 | 2013-01-25 05:40:09 +0000 | [diff] [blame] | 1992 | // Consider any sink candidates which are only used in CondBB as costs for |
| 1993 | // speculation. Note, while we iterate over a DenseMap here, we are summing |
| 1994 | // and so iteration order isn't significant. |
Dehao Chen | f6c0083 | 2016-05-18 19:44:21 +0000 | [diff] [blame] | 1995 | for (SmallDenseMap<Instruction *, unsigned, 4>::iterator |
| 1996 | I = SinkCandidateUseCounts.begin(), |
| 1997 | E = SinkCandidateUseCounts.end(); |
Chandler Carruth | ceff222 | 2013-01-25 05:40:09 +0000 | [diff] [blame] | 1998 | I != E; ++I) |
| 1999 | if (I->first->getNumUses() == I->second) { |
Chandler Carruth | 329b590 | 2013-01-27 06:42:03 +0000 | [diff] [blame] | 2000 | ++SpeculationCost; |
| 2001 | if (SpeculationCost > 1) |
Chandler Carruth | ceff222 | 2013-01-25 05:40:09 +0000 | [diff] [blame] | 2002 | return false; |
| 2003 | } |
| 2004 | |
Chandler Carruth | 76aacbd | 2013-01-24 10:40:51 +0000 | [diff] [blame] | 2005 | // Check that the PHI nodes can be converted to selects. |
| 2006 | bool HaveRewritablePHIs = false; |
Chandler Carruth | e2a779f | 2013-01-24 09:59:39 +0000 | [diff] [blame] | 2007 | for (BasicBlock::iterator I = EndBB->begin(); |
Dan Gohman | 5ab9c0a | 2012-01-05 23:58:56 +0000 | [diff] [blame] | 2008 | PHINode *PN = dyn_cast<PHINode>(I); ++I) { |
Chandler Carruth | e2a779f | 2013-01-24 09:59:39 +0000 | [diff] [blame] | 2009 | Value *OrigV = PN->getIncomingValueForBlock(BB); |
| 2010 | Value *ThenV = PN->getIncomingValueForBlock(ThenBB); |
Dan Gohman | 5ab9c0a | 2012-01-05 23:58:56 +0000 | [diff] [blame] | 2011 | |
Rafael Espindola | a5e536a | 2013-06-04 14:11:59 +0000 | [diff] [blame] | 2012 | // FIXME: Try to remove some of the duplication with HoistThenElseCodeToIf. |
Dan Gohman | 5ab9c0a | 2012-01-05 23:58:56 +0000 | [diff] [blame] | 2013 | // Skip PHIs which are trivial. |
Chandler Carruth | e2a779f | 2013-01-24 09:59:39 +0000 | [diff] [blame] | 2014 | if (ThenV == OrigV) |
Dan Gohman | 5ab9c0a | 2012-01-05 23:58:56 +0000 | [diff] [blame] | 2015 | continue; |
| 2016 | |
Arnold Schwaighofer | d7d010e | 2014-10-10 01:27:02 +0000 | [diff] [blame] | 2017 | // Don't convert to selects if we could remove undefined behavior instead. |
| 2018 | if (passingValueIsAlwaysUndefined(OrigV, PN) || |
| 2019 | passingValueIsAlwaysUndefined(ThenV, PN)) |
| 2020 | return false; |
| 2021 | |
Chandler Carruth | 76aacbd | 2013-01-24 10:40:51 +0000 | [diff] [blame] | 2022 | HaveRewritablePHIs = true; |
Rafael Espindola | a5e536a | 2013-06-04 14:11:59 +0000 | [diff] [blame] | 2023 | ConstantExpr *OrigCE = dyn_cast<ConstantExpr>(OrigV); |
| 2024 | ConstantExpr *ThenCE = dyn_cast<ConstantExpr>(ThenV); |
| 2025 | if (!OrigCE && !ThenCE) |
Chandler Carruth | 8a21005 | 2013-01-24 11:53:01 +0000 | [diff] [blame] | 2026 | continue; // Known safe and cheap. |
| 2027 | |
Mehdi Amini | a28d91d | 2015-03-10 02:37:25 +0000 | [diff] [blame] | 2028 | if ((ThenCE && !isSafeToSpeculativelyExecute(ThenCE)) || |
| 2029 | (OrigCE && !isSafeToSpeculativelyExecute(OrigCE))) |
Chandler Carruth | 8a21005 | 2013-01-24 11:53:01 +0000 | [diff] [blame] | 2030 | return false; |
Mehdi Amini | a28d91d | 2015-03-10 02:37:25 +0000 | [diff] [blame] | 2031 | unsigned OrigCost = OrigCE ? ComputeSpeculationCost(OrigCE, TTI) : 0; |
| 2032 | unsigned ThenCost = ThenCE ? ComputeSpeculationCost(ThenCE, TTI) : 0; |
Dehao Chen | f6c0083 | 2016-05-18 19:44:21 +0000 | [diff] [blame] | 2033 | unsigned MaxCost = |
| 2034 | 2 * PHINodeFoldingThreshold * TargetTransformInfo::TCC_Basic; |
James Molloy | 7c33657 | 2015-02-11 12:15:41 +0000 | [diff] [blame] | 2035 | if (OrigCost + ThenCost > MaxCost) |
Chandler Carruth | 8a21005 | 2013-01-24 11:53:01 +0000 | [diff] [blame] | 2036 | return false; |
Chandler Carruth | 76aacbd | 2013-01-24 10:40:51 +0000 | [diff] [blame] | 2037 | |
Chandler Carruth | 01bffaa | 2013-01-24 12:05:17 +0000 | [diff] [blame] | 2038 | // Account for the cost of an unfolded ConstantExpr which could end up |
| 2039 | // getting expanded into Instructions. |
| 2040 | // FIXME: This doesn't account for how many operations are combined in the |
Chandler Carruth | 329b590 | 2013-01-27 06:42:03 +0000 | [diff] [blame] | 2041 | // constant expression. |
| 2042 | ++SpeculationCost; |
| 2043 | if (SpeculationCost > 1) |
Chandler Carruth | 76aacbd | 2013-01-24 10:40:51 +0000 | [diff] [blame] | 2044 | return false; |
Evan Cheng | 89200c9 | 2008-06-07 08:52:29 +0000 | [diff] [blame] | 2045 | } |
Dan Gohman | 5ab9c0a | 2012-01-05 23:58:56 +0000 | [diff] [blame] | 2046 | |
| 2047 | // If there are no PHIs to process, bail early. This helps ensure idempotence |
| 2048 | // as well. |
Arnold Schwaighofer | 474df6d | 2013-04-29 21:28:24 +0000 | [diff] [blame] | 2049 | if (!HaveRewritablePHIs && !(HoistCondStores && SpeculatedStoreValue)) |
Dan Gohman | 5ab9c0a | 2012-01-05 23:58:56 +0000 | [diff] [blame] | 2050 | return false; |
Andrew Trick | f3cf193 | 2012-08-29 21:46:36 +0000 | [diff] [blame] | 2051 | |
Dan Gohman | 5ab9c0a | 2012-01-05 23:58:56 +0000 | [diff] [blame] | 2052 | // If we get here, we can hoist the instruction and if-convert. |
Chandler Carruth | e2a779f | 2013-01-24 09:59:39 +0000 | [diff] [blame] | 2053 | DEBUG(dbgs() << "SPECULATIVELY EXECUTING BB" << *ThenBB << "\n";); |
Evan Cheng | 89200c9 | 2008-06-07 08:52:29 +0000 | [diff] [blame] | 2054 | |
Arnold Schwaighofer | 474df6d | 2013-04-29 21:28:24 +0000 | [diff] [blame] | 2055 | // Insert a select of the value of the speculated store. |
| 2056 | if (SpeculatedStoreValue) { |
Mehdi Amini | ba9fba8 | 2016-03-13 21:05:13 +0000 | [diff] [blame] | 2057 | IRBuilder<NoFolder> Builder(BI); |
Arnold Schwaighofer | 474df6d | 2013-04-29 21:28:24 +0000 | [diff] [blame] | 2058 | Value *TrueV = SpeculatedStore->getValueOperand(); |
| 2059 | Value *FalseV = SpeculatedStoreValue; |
| 2060 | if (Invert) |
| 2061 | std::swap(TrueV, FalseV); |
Sanjay Patel | 796db35 | 2016-03-26 23:30:50 +0000 | [diff] [blame] | 2062 | Value *S = Builder.CreateSelect( |
| 2063 | BrCond, TrueV, FalseV, TrueV->getName() + "." + FalseV->getName(), BI); |
Arnold Schwaighofer | 474df6d | 2013-04-29 21:28:24 +0000 | [diff] [blame] | 2064 | SpeculatedStore->setOperand(0, S); |
| 2065 | } |
| 2066 | |
Igor Laevsky | 7310c68 | 2015-11-18 14:50:18 +0000 | [diff] [blame] | 2067 | // Metadata can be dependent on the condition we are hoisting above. |
| 2068 | // Conservatively strip all metadata on the instruction. |
Dehao Chen | f6c0083 | 2016-05-18 19:44:21 +0000 | [diff] [blame] | 2069 | for (auto &I : *ThenBB) |
Igor Laevsky | 7310c68 | 2015-11-18 14:50:18 +0000 | [diff] [blame] | 2070 | I.dropUnknownNonDebugMetadata(); |
| 2071 | |
Chandler Carruth | 7481ca8 | 2013-01-24 11:52:58 +0000 | [diff] [blame] | 2072 | // Hoist the instructions. |
Duncan P. N. Exon Smith | 5b4c837 | 2015-10-13 02:39:05 +0000 | [diff] [blame] | 2073 | BB->getInstList().splice(BI->getIterator(), ThenBB->getInstList(), |
| 2074 | ThenBB->begin(), std::prev(ThenBB->end())); |
Evan Cheng | 89553cc | 2008-06-12 21:15:59 +0000 | [diff] [blame] | 2075 | |
Dan Gohman | 5ab9c0a | 2012-01-05 23:58:56 +0000 | [diff] [blame] | 2076 | // Insert selects and rewrite the PHI operands. |
Mehdi Amini | ba9fba8 | 2016-03-13 21:05:13 +0000 | [diff] [blame] | 2077 | IRBuilder<NoFolder> Builder(BI); |
Chandler Carruth | 76aacbd | 2013-01-24 10:40:51 +0000 | [diff] [blame] | 2078 | for (BasicBlock::iterator I = EndBB->begin(); |
| 2079 | PHINode *PN = dyn_cast<PHINode>(I); ++I) { |
| 2080 | unsigned OrigI = PN->getBasicBlockIndex(BB); |
| 2081 | unsigned ThenI = PN->getBasicBlockIndex(ThenBB); |
| 2082 | Value *OrigV = PN->getIncomingValue(OrigI); |
| 2083 | Value *ThenV = PN->getIncomingValue(ThenI); |
| 2084 | |
| 2085 | // Skip PHIs which are trivial. |
| 2086 | if (OrigV == ThenV) |
| 2087 | continue; |
Evan Cheng | 89200c9 | 2008-06-07 08:52:29 +0000 | [diff] [blame] | 2088 | |
Dan Gohman | 5ab9c0a | 2012-01-05 23:58:56 +0000 | [diff] [blame] | 2089 | // Create a select whose true value is the speculatively executed value and |
Chandler Carruth | 76aacbd | 2013-01-24 10:40:51 +0000 | [diff] [blame] | 2090 | // false value is the preexisting value. Swap them if the branch |
| 2091 | // destinations were inverted. |
| 2092 | Value *TrueV = ThenV, *FalseV = OrigV; |
Dan Gohman | 5ab9c0a | 2012-01-05 23:58:56 +0000 | [diff] [blame] | 2093 | if (Invert) |
Chandler Carruth | 76aacbd | 2013-01-24 10:40:51 +0000 | [diff] [blame] | 2094 | std::swap(TrueV, FalseV); |
Sanjay Patel | f11ab05 | 2016-04-15 15:32:12 +0000 | [diff] [blame] | 2095 | Value *V = Builder.CreateSelect( |
| 2096 | BrCond, TrueV, FalseV, TrueV->getName() + "." + FalseV->getName(), BI); |
Chandler Carruth | 76aacbd | 2013-01-24 10:40:51 +0000 | [diff] [blame] | 2097 | PN->setIncomingValue(OrigI, V); |
| 2098 | PN->setIncomingValue(ThenI, V); |
Evan Cheng | 89200c9 | 2008-06-07 08:52:29 +0000 | [diff] [blame] | 2099 | } |
| 2100 | |
Evan Cheng | 89553cc | 2008-06-12 21:15:59 +0000 | [diff] [blame] | 2101 | ++NumSpeculations; |
Evan Cheng | 89200c9 | 2008-06-07 08:52:29 +0000 | [diff] [blame] | 2102 | return true; |
| 2103 | } |
| 2104 | |
Sanjay Patel | 09159b8f | 2015-06-24 20:40:57 +0000 | [diff] [blame] | 2105 | /// Return true if we can thread a branch across this block. |
Chris Lattner | f0bd8d0 | 2005-09-20 00:43:16 +0000 | [diff] [blame] | 2106 | static bool BlockIsSimpleEnoughToThreadThrough(BasicBlock *BB) { |
| 2107 | BranchInst *BI = cast<BranchInst>(BB->getTerminator()); |
Chris Lattner | 6c70106 | 2005-09-20 01:48:40 +0000 | [diff] [blame] | 2108 | unsigned Size = 0; |
Andrew Trick | f3cf193 | 2012-08-29 21:46:36 +0000 | [diff] [blame] | 2109 | |
Devang Patel | 84fceff | 2009-03-10 18:00:05 +0000 | [diff] [blame] | 2110 | for (BasicBlock::iterator BBI = BB->begin(); &*BBI != BI; ++BBI) { |
Dale Johannesen | ed6f5a8 | 2009-03-12 23:18:09 +0000 | [diff] [blame] | 2111 | if (isa<DbgInfoIntrinsic>(BBI)) |
| 2112 | continue; |
Dehao Chen | f6c0083 | 2016-05-18 19:44:21 +0000 | [diff] [blame] | 2113 | if (Size > 10) |
| 2114 | return false; // Don't clone large BB's. |
Dale Johannesen | ed6f5a8 | 2009-03-12 23:18:09 +0000 | [diff] [blame] | 2115 | ++Size; |
Andrew Trick | f3cf193 | 2012-08-29 21:46:36 +0000 | [diff] [blame] | 2116 | |
Dale Johannesen | ed6f5a8 | 2009-03-12 23:18:09 +0000 | [diff] [blame] | 2117 | // We can only support instructions that do not define values that are |
Chris Lattner | 6c70106 | 2005-09-20 01:48:40 +0000 | [diff] [blame] | 2118 | // live outside of the current basic block. |
Chandler Carruth | cdf4788 | 2014-03-09 03:16:01 +0000 | [diff] [blame] | 2119 | for (User *U : BBI->users()) { |
| 2120 | Instruction *UI = cast<Instruction>(U); |
Dehao Chen | f6c0083 | 2016-05-18 19:44:21 +0000 | [diff] [blame] | 2121 | if (UI->getParent() != BB || isa<PHINode>(UI)) |
| 2122 | return false; |
Chris Lattner | 6c70106 | 2005-09-20 01:48:40 +0000 | [diff] [blame] | 2123 | } |
Andrew Trick | f3cf193 | 2012-08-29 21:46:36 +0000 | [diff] [blame] | 2124 | |
Chris Lattner | f0bd8d0 | 2005-09-20 00:43:16 +0000 | [diff] [blame] | 2125 | // Looks ok, continue checking. |
| 2126 | } |
Chris Lattner | 6c70106 | 2005-09-20 01:48:40 +0000 | [diff] [blame] | 2127 | |
Chris Lattner | f0bd8d0 | 2005-09-20 00:43:16 +0000 | [diff] [blame] | 2128 | return true; |
| 2129 | } |
| 2130 | |
Sanjay Patel | 09159b8f | 2015-06-24 20:40:57 +0000 | [diff] [blame] | 2131 | /// If we have a conditional branch on a PHI node value that is defined in the |
| 2132 | /// same block as the branch and if any PHI entries are constants, thread edges |
| 2133 | /// corresponding to that entry to be branches to their ultimate destination. |
Mehdi Amini | a28d91d | 2015-03-10 02:37:25 +0000 | [diff] [blame] | 2134 | static bool FoldCondBranchOnPHI(BranchInst *BI, const DataLayout &DL) { |
Chris Lattner | 748f903 | 2005-09-19 23:49:37 +0000 | [diff] [blame] | 2135 | BasicBlock *BB = BI->getParent(); |
| 2136 | PHINode *PN = dyn_cast<PHINode>(BI->getCondition()); |
Chris Lattner | 049cb44 | 2005-09-19 23:57:04 +0000 | [diff] [blame] | 2137 | // NOTE: we currently cannot transform this case if the PHI node is used |
| 2138 | // outside of the block. |
Chris Lattner | f0bd8d0 | 2005-09-20 00:43:16 +0000 | [diff] [blame] | 2139 | if (!PN || PN->getParent() != BB || !PN->hasOneUse()) |
| 2140 | return false; |
Andrew Trick | f3cf193 | 2012-08-29 21:46:36 +0000 | [diff] [blame] | 2141 | |
Chris Lattner | 748f903 | 2005-09-19 23:49:37 +0000 | [diff] [blame] | 2142 | // Degenerate case of a single entry PHI. |
| 2143 | if (PN->getNumIncomingValues() == 1) { |
Chris Lattner | dc3f6f2 | 2008-12-03 19:44:02 +0000 | [diff] [blame] | 2144 | FoldSingleEntryPHINodes(PN->getParent()); |
Andrew Trick | f3cf193 | 2012-08-29 21:46:36 +0000 | [diff] [blame] | 2145 | return true; |
Chris Lattner | 748f903 | 2005-09-19 23:49:37 +0000 | [diff] [blame] | 2146 | } |
| 2147 | |
| 2148 | // Now we know that this block has multiple preds and two succs. |
Dehao Chen | f6c0083 | 2016-05-18 19:44:21 +0000 | [diff] [blame] | 2149 | if (!BlockIsSimpleEnoughToThreadThrough(BB)) |
| 2150 | return false; |
Andrew Trick | f3cf193 | 2012-08-29 21:46:36 +0000 | [diff] [blame] | 2151 | |
Justin Lebar | db63949 | 2016-02-12 21:01:36 +0000 | [diff] [blame] | 2152 | // Can't fold blocks that contain noduplicate or convergent calls. |
David Majnemer | 0a16c22 | 2016-08-11 21:15:00 +0000 | [diff] [blame] | 2153 | if (any_of(*BB, [](const Instruction &I) { |
Justin Lebar | db63949 | 2016-02-12 21:01:36 +0000 | [diff] [blame] | 2154 | const CallInst *CI = dyn_cast<CallInst>(&I); |
| 2155 | return CI && (CI->cannotDuplicate() || CI->isConvergent()); |
| 2156 | })) |
| 2157 | return false; |
Tom Stellard | e1631dd | 2013-10-21 20:07:30 +0000 | [diff] [blame] | 2158 | |
Chris Lattner | 748f903 | 2005-09-19 23:49:37 +0000 | [diff] [blame] | 2159 | // Okay, this is a simple enough basic block. See if any phi values are |
| 2160 | // constants. |
Zhou Sheng | 75b871f | 2007-01-11 12:24:14 +0000 | [diff] [blame] | 2161 | for (unsigned i = 0, e = PN->getNumIncomingValues(); i != e; ++i) { |
Chris Lattner | 4088e2b | 2010-12-13 01:47:07 +0000 | [diff] [blame] | 2162 | ConstantInt *CB = dyn_cast<ConstantInt>(PN->getIncomingValue(i)); |
Dehao Chen | f6c0083 | 2016-05-18 19:44:21 +0000 | [diff] [blame] | 2163 | if (!CB || !CB->getType()->isIntegerTy(1)) |
| 2164 | continue; |
Andrew Trick | f3cf193 | 2012-08-29 21:46:36 +0000 | [diff] [blame] | 2165 | |
Chris Lattner | 4088e2b | 2010-12-13 01:47:07 +0000 | [diff] [blame] | 2166 | // Okay, we now know that all edges from PredBB should be revectored to |
| 2167 | // branch to RealDest. |
| 2168 | BasicBlock *PredBB = PN->getIncomingBlock(i); |
| 2169 | BasicBlock *RealDest = BI->getSuccessor(!CB->getZExtValue()); |
Andrew Trick | f3cf193 | 2012-08-29 21:46:36 +0000 | [diff] [blame] | 2170 | |
Dehao Chen | f6c0083 | 2016-05-18 19:44:21 +0000 | [diff] [blame] | 2171 | if (RealDest == BB) |
| 2172 | continue; // Skip self loops. |
Bill Wendling | 4f163df | 2011-06-04 09:42:04 +0000 | [diff] [blame] | 2173 | // Skip if the predecessor's terminator is an indirect branch. |
Dehao Chen | f6c0083 | 2016-05-18 19:44:21 +0000 | [diff] [blame] | 2174 | if (isa<IndirectBrInst>(PredBB->getTerminator())) |
| 2175 | continue; |
Andrew Trick | f3cf193 | 2012-08-29 21:46:36 +0000 | [diff] [blame] | 2176 | |
Chris Lattner | 4088e2b | 2010-12-13 01:47:07 +0000 | [diff] [blame] | 2177 | // The dest block might have PHI nodes, other predecessors and other |
| 2178 | // difficult cases. Instead of being smart about this, just insert a new |
| 2179 | // block that jumps to the destination block, effectively splitting |
| 2180 | // the edge we are about to create. |
Dehao Chen | f6c0083 | 2016-05-18 19:44:21 +0000 | [diff] [blame] | 2181 | BasicBlock *EdgeBB = |
| 2182 | BasicBlock::Create(BB->getContext(), RealDest->getName() + ".critedge", |
| 2183 | RealDest->getParent(), RealDest); |
Chris Lattner | 4088e2b | 2010-12-13 01:47:07 +0000 | [diff] [blame] | 2184 | BranchInst::Create(RealDest, EdgeBB); |
Andrew Trick | f3cf193 | 2012-08-29 21:46:36 +0000 | [diff] [blame] | 2185 | |
Chris Lattner | 0f4d67b | 2010-12-14 07:09:42 +0000 | [diff] [blame] | 2186 | // Update PHI nodes. |
| 2187 | AddPredecessorToBlock(RealDest, EdgeBB, BB); |
Chris Lattner | 4088e2b | 2010-12-13 01:47:07 +0000 | [diff] [blame] | 2188 | |
| 2189 | // BB may have instructions that are being threaded over. Clone these |
| 2190 | // instructions into EdgeBB. We know that there will be no uses of the |
| 2191 | // cloned instructions outside of EdgeBB. |
| 2192 | BasicBlock::iterator InsertPt = EdgeBB->begin(); |
Dehao Chen | f6c0083 | 2016-05-18 19:44:21 +0000 | [diff] [blame] | 2193 | DenseMap<Value *, Value *> TranslateMap; // Track translated values. |
Chris Lattner | 4088e2b | 2010-12-13 01:47:07 +0000 | [diff] [blame] | 2194 | for (BasicBlock::iterator BBI = BB->begin(); &*BBI != BI; ++BBI) { |
| 2195 | if (PHINode *PN = dyn_cast<PHINode>(BBI)) { |
| 2196 | TranslateMap[PN] = PN->getIncomingValueForBlock(PredBB); |
| 2197 | continue; |
| 2198 | } |
| 2199 | // Clone the instruction. |
| 2200 | Instruction *N = BBI->clone(); |
Dehao Chen | f6c0083 | 2016-05-18 19:44:21 +0000 | [diff] [blame] | 2201 | if (BBI->hasName()) |
| 2202 | N->setName(BBI->getName() + ".c"); |
Andrew Trick | f3cf193 | 2012-08-29 21:46:36 +0000 | [diff] [blame] | 2203 | |
Chris Lattner | 4088e2b | 2010-12-13 01:47:07 +0000 | [diff] [blame] | 2204 | // Update operands due to translation. |
Dehao Chen | f6c0083 | 2016-05-18 19:44:21 +0000 | [diff] [blame] | 2205 | for (User::op_iterator i = N->op_begin(), e = N->op_end(); i != e; ++i) { |
| 2206 | DenseMap<Value *, Value *>::iterator PI = TranslateMap.find(*i); |
Chris Lattner | 4088e2b | 2010-12-13 01:47:07 +0000 | [diff] [blame] | 2207 | if (PI != TranslateMap.end()) |
| 2208 | *i = PI->second; |
| 2209 | } |
Andrew Trick | f3cf193 | 2012-08-29 21:46:36 +0000 | [diff] [blame] | 2210 | |
Chris Lattner | 4088e2b | 2010-12-13 01:47:07 +0000 | [diff] [blame] | 2211 | // Check for trivial simplification. |
Rafael Espindola | 37dc9e1 | 2014-02-21 00:06:31 +0000 | [diff] [blame] | 2212 | if (Value *V = SimplifyInstruction(N, DL)) { |
David Majnemer | b8da3a2 | 2016-06-25 00:04:10 +0000 | [diff] [blame] | 2213 | if (!BBI->use_empty()) |
| 2214 | TranslateMap[&*BBI] = V; |
| 2215 | if (!N->mayHaveSideEffects()) { |
| 2216 | delete N; // Instruction folded away, don't need actual inst |
| 2217 | N = nullptr; |
| 2218 | } |
Chris Lattner | 4088e2b | 2010-12-13 01:47:07 +0000 | [diff] [blame] | 2219 | } else { |
Chris Lattner | 4088e2b | 2010-12-13 01:47:07 +0000 | [diff] [blame] | 2220 | if (!BBI->use_empty()) |
Duncan P. N. Exon Smith | 5b4c837 | 2015-10-13 02:39:05 +0000 | [diff] [blame] | 2221 | TranslateMap[&*BBI] = N; |
Chris Lattner | 4088e2b | 2010-12-13 01:47:07 +0000 | [diff] [blame] | 2222 | } |
David Majnemer | b8da3a2 | 2016-06-25 00:04:10 +0000 | [diff] [blame] | 2223 | // Insert the new instruction into its new home. |
| 2224 | if (N) |
| 2225 | EdgeBB->getInstList().insert(InsertPt, N); |
Chris Lattner | 4088e2b | 2010-12-13 01:47:07 +0000 | [diff] [blame] | 2226 | } |
| 2227 | |
| 2228 | // Loop over all of the edges from PredBB to BB, changing them to branch |
| 2229 | // to EdgeBB instead. |
| 2230 | TerminatorInst *PredBBTI = PredBB->getTerminator(); |
| 2231 | for (unsigned i = 0, e = PredBBTI->getNumSuccessors(); i != e; ++i) |
| 2232 | if (PredBBTI->getSuccessor(i) == BB) { |
| 2233 | BB->removePredecessor(PredBB); |
| 2234 | PredBBTI->setSuccessor(i, EdgeBB); |
| 2235 | } |
Bill Wendling | 4f163df | 2011-06-04 09:42:04 +0000 | [diff] [blame] | 2236 | |
Chris Lattner | 4088e2b | 2010-12-13 01:47:07 +0000 | [diff] [blame] | 2237 | // Recurse, simplifying any other constants. |
Rafael Espindola | 37dc9e1 | 2014-02-21 00:06:31 +0000 | [diff] [blame] | 2238 | return FoldCondBranchOnPHI(BI, DL) | true; |
Zhou Sheng | 75b871f | 2007-01-11 12:24:14 +0000 | [diff] [blame] | 2239 | } |
Chris Lattner | 748f903 | 2005-09-19 23:49:37 +0000 | [diff] [blame] | 2240 | |
| 2241 | return false; |
| 2242 | } |
| 2243 | |
Sanjay Patel | 09159b8f | 2015-06-24 20:40:57 +0000 | [diff] [blame] | 2244 | /// Given a BB that starts with the specified two-entry PHI node, |
| 2245 | /// see if we can eliminate it. |
Mehdi Amini | a28d91d | 2015-03-10 02:37:25 +0000 | [diff] [blame] | 2246 | static bool FoldTwoEntryPHINode(PHINode *PN, const TargetTransformInfo &TTI, |
| 2247 | const DataLayout &DL) { |
Chris Lattner | cc14ebc | 2005-09-23 06:39:30 +0000 | [diff] [blame] | 2248 | // Ok, this is a two entry PHI node. Check to see if this is a simple "if |
| 2249 | // statement", which has a very simple dominance structure. Basically, we |
| 2250 | // are trying to find the condition that is being branched on, which |
| 2251 | // subsequently causes this merge to happen. We really want control |
| 2252 | // dependence information for this check, but simplifycfg can't keep it up |
| 2253 | // to date, and this catches most of the cases we care about anyway. |
Chris Lattner | cc14ebc | 2005-09-23 06:39:30 +0000 | [diff] [blame] | 2254 | BasicBlock *BB = PN->getParent(); |
| 2255 | BasicBlock *IfTrue, *IfFalse; |
| 2256 | Value *IfCond = GetIfCondition(BB, IfTrue, IfFalse); |
Chris Lattner | 335f0e4 | 2010-12-14 08:01:53 +0000 | [diff] [blame] | 2257 | if (!IfCond || |
| 2258 | // Don't bother if the branch will be constant folded trivially. |
| 2259 | isa<ConstantInt>(IfCond)) |
| 2260 | return false; |
Andrew Trick | f3cf193 | 2012-08-29 21:46:36 +0000 | [diff] [blame] | 2261 | |
Chris Lattner | 95adf8f1 | 2006-11-18 19:19:36 +0000 | [diff] [blame] | 2262 | // Okay, we found that we can merge this two-entry phi node into a select. |
| 2263 | // Doing so would require us to fold *all* two entry phi nodes in this block. |
| 2264 | // At some point this becomes non-profitable (particularly if the target |
| 2265 | // doesn't support cmov's). Only do this transformation if there are two or |
| 2266 | // fewer PHI nodes in this block. |
| 2267 | unsigned NumPhis = 0; |
| 2268 | for (BasicBlock::iterator I = BB->begin(); isa<PHINode>(I); ++NumPhis, ++I) |
| 2269 | if (NumPhis > 2) |
| 2270 | return false; |
Andrew Trick | f3cf193 | 2012-08-29 21:46:36 +0000 | [diff] [blame] | 2271 | |
Chris Lattner | cc14ebc | 2005-09-23 06:39:30 +0000 | [diff] [blame] | 2272 | // Loop over the PHI's seeing if we can promote them all to select |
| 2273 | // instructions. While we are at it, keep track of the instructions |
| 2274 | // that need to be moved to the dominating block. |
Dehao Chen | f6c0083 | 2016-05-18 19:44:21 +0000 | [diff] [blame] | 2275 | SmallPtrSet<Instruction *, 4> AggressiveInsts; |
Peter Collingbourne | 616044a | 2011-04-29 18:47:38 +0000 | [diff] [blame] | 2276 | unsigned MaxCostVal0 = PHINodeFoldingThreshold, |
| 2277 | MaxCostVal1 = PHINodeFoldingThreshold; |
James Molloy | 7c33657 | 2015-02-11 12:15:41 +0000 | [diff] [blame] | 2278 | MaxCostVal0 *= TargetTransformInfo::TCC_Basic; |
| 2279 | MaxCostVal1 *= TargetTransformInfo::TCC_Basic; |
Andrew Trick | f3cf193 | 2012-08-29 21:46:36 +0000 | [diff] [blame] | 2280 | |
Chris Lattner | 7499b45 | 2010-12-14 08:46:09 +0000 | [diff] [blame] | 2281 | for (BasicBlock::iterator II = BB->begin(); isa<PHINode>(II);) { |
| 2282 | PHINode *PN = cast<PHINode>(II++); |
Rafael Espindola | 37dc9e1 | 2014-02-21 00:06:31 +0000 | [diff] [blame] | 2283 | if (Value *V = SimplifyInstruction(PN, DL)) { |
Chris Lattner | b42d293 | 2010-12-14 07:20:29 +0000 | [diff] [blame] | 2284 | PN->replaceAllUsesWith(V); |
Chris Lattner | 7499b45 | 2010-12-14 08:46:09 +0000 | [diff] [blame] | 2285 | PN->eraseFromParent(); |
Chris Lattner | b42d293 | 2010-12-14 07:20:29 +0000 | [diff] [blame] | 2286 | continue; |
Chris Lattner | cc14ebc | 2005-09-23 06:39:30 +0000 | [diff] [blame] | 2287 | } |
Andrew Trick | f3cf193 | 2012-08-29 21:46:36 +0000 | [diff] [blame] | 2288 | |
Peter Collingbourne | e3511e1 | 2011-04-29 18:47:31 +0000 | [diff] [blame] | 2289 | if (!DominatesMergePoint(PN->getIncomingValue(0), BB, &AggressiveInsts, |
Mehdi Amini | a28d91d | 2015-03-10 02:37:25 +0000 | [diff] [blame] | 2290 | MaxCostVal0, TTI) || |
Peter Collingbourne | e3511e1 | 2011-04-29 18:47:31 +0000 | [diff] [blame] | 2291 | !DominatesMergePoint(PN->getIncomingValue(1), BB, &AggressiveInsts, |
Mehdi Amini | a28d91d | 2015-03-10 02:37:25 +0000 | [diff] [blame] | 2292 | MaxCostVal1, TTI)) |
Chris Lattner | b42d293 | 2010-12-14 07:20:29 +0000 | [diff] [blame] | 2293 | return false; |
Chris Lattner | cc14ebc | 2005-09-23 06:39:30 +0000 | [diff] [blame] | 2294 | } |
Andrew Trick | f3cf193 | 2012-08-29 21:46:36 +0000 | [diff] [blame] | 2295 | |
Sylvestre Ledru | 35521e2 | 2012-07-23 08:51:15 +0000 | [diff] [blame] | 2296 | // If we folded the first phi, PN dangles at this point. Refresh it. If |
Chris Lattner | 9ac168d | 2010-12-14 07:41:39 +0000 | [diff] [blame] | 2297 | // we ran out of PHIs then we simplified them all. |
| 2298 | PN = dyn_cast<PHINode>(BB->begin()); |
Dehao Chen | f6c0083 | 2016-05-18 19:44:21 +0000 | [diff] [blame] | 2299 | if (!PN) |
| 2300 | return true; |
Andrew Trick | f3cf193 | 2012-08-29 21:46:36 +0000 | [diff] [blame] | 2301 | |
Chris Lattner | 7499b45 | 2010-12-14 08:46:09 +0000 | [diff] [blame] | 2302 | // Don't fold i1 branches on PHIs which contain binary operators. These can |
| 2303 | // often be turned into switches and other things. |
| 2304 | if (PN->getType()->isIntegerTy(1) && |
| 2305 | (isa<BinaryOperator>(PN->getIncomingValue(0)) || |
| 2306 | isa<BinaryOperator>(PN->getIncomingValue(1)) || |
| 2307 | isa<BinaryOperator>(IfCond))) |
| 2308 | return false; |
Andrew Trick | f3cf193 | 2012-08-29 21:46:36 +0000 | [diff] [blame] | 2309 | |
Sanjay Patel | 2e00277 | 2016-03-12 18:05:53 +0000 | [diff] [blame] | 2310 | // If all PHI nodes are promotable, check to make sure that all instructions |
| 2311 | // in the predecessor blocks can be promoted as well. If not, we won't be able |
| 2312 | // to get rid of the control flow, so it's not worth promoting to select |
| 2313 | // instructions. |
Craig Topper | f40110f | 2014-04-25 05:29:35 +0000 | [diff] [blame] | 2314 | BasicBlock *DomBlock = nullptr; |
Chris Lattner | 9ac168d | 2010-12-14 07:41:39 +0000 | [diff] [blame] | 2315 | BasicBlock *IfBlock1 = PN->getIncomingBlock(0); |
| 2316 | BasicBlock *IfBlock2 = PN->getIncomingBlock(1); |
| 2317 | if (cast<BranchInst>(IfBlock1->getTerminator())->isConditional()) { |
Craig Topper | f40110f | 2014-04-25 05:29:35 +0000 | [diff] [blame] | 2318 | IfBlock1 = nullptr; |
Chris Lattner | 9ac168d | 2010-12-14 07:41:39 +0000 | [diff] [blame] | 2319 | } else { |
| 2320 | DomBlock = *pred_begin(IfBlock1); |
Dehao Chen | f6c0083 | 2016-05-18 19:44:21 +0000 | [diff] [blame] | 2321 | for (BasicBlock::iterator I = IfBlock1->begin(); !isa<TerminatorInst>(I); |
| 2322 | ++I) |
Duncan P. N. Exon Smith | 5b4c837 | 2015-10-13 02:39:05 +0000 | [diff] [blame] | 2323 | if (!AggressiveInsts.count(&*I) && !isa<DbgInfoIntrinsic>(I)) { |
Chris Lattner | cc14ebc | 2005-09-23 06:39:30 +0000 | [diff] [blame] | 2324 | // This is not an aggressive instruction that we can promote. |
Sanjay Patel | 2e00277 | 2016-03-12 18:05:53 +0000 | [diff] [blame] | 2325 | // Because of this, we won't be able to get rid of the control flow, so |
| 2326 | // the xform is not worth it. |
Chris Lattner | cc14ebc | 2005-09-23 06:39:30 +0000 | [diff] [blame] | 2327 | return false; |
| 2328 | } |
| 2329 | } |
Andrew Trick | f3cf193 | 2012-08-29 21:46:36 +0000 | [diff] [blame] | 2330 | |
Chris Lattner | 9ac168d | 2010-12-14 07:41:39 +0000 | [diff] [blame] | 2331 | if (cast<BranchInst>(IfBlock2->getTerminator())->isConditional()) { |
Craig Topper | f40110f | 2014-04-25 05:29:35 +0000 | [diff] [blame] | 2332 | IfBlock2 = nullptr; |
Chris Lattner | 9ac168d | 2010-12-14 07:41:39 +0000 | [diff] [blame] | 2333 | } else { |
| 2334 | DomBlock = *pred_begin(IfBlock2); |
Dehao Chen | f6c0083 | 2016-05-18 19:44:21 +0000 | [diff] [blame] | 2335 | for (BasicBlock::iterator I = IfBlock2->begin(); !isa<TerminatorInst>(I); |
| 2336 | ++I) |
Duncan P. N. Exon Smith | 5b4c837 | 2015-10-13 02:39:05 +0000 | [diff] [blame] | 2337 | if (!AggressiveInsts.count(&*I) && !isa<DbgInfoIntrinsic>(I)) { |
Chris Lattner | cc14ebc | 2005-09-23 06:39:30 +0000 | [diff] [blame] | 2338 | // This is not an aggressive instruction that we can promote. |
Sanjay Patel | 2e00277 | 2016-03-12 18:05:53 +0000 | [diff] [blame] | 2339 | // Because of this, we won't be able to get rid of the control flow, so |
| 2340 | // the xform is not worth it. |
Chris Lattner | cc14ebc | 2005-09-23 06:39:30 +0000 | [diff] [blame] | 2341 | return false; |
| 2342 | } |
| 2343 | } |
Andrew Trick | f3cf193 | 2012-08-29 21:46:36 +0000 | [diff] [blame] | 2344 | |
Chris Lattner | 9fd838d | 2010-12-14 07:23:10 +0000 | [diff] [blame] | 2345 | DEBUG(dbgs() << "FOUND IF CONDITION! " << *IfCond << " T: " |
Chris Lattner | 9ac168d | 2010-12-14 07:41:39 +0000 | [diff] [blame] | 2346 | << IfTrue->getName() << " F: " << IfFalse->getName() << "\n"); |
Andrew Trick | f3cf193 | 2012-08-29 21:46:36 +0000 | [diff] [blame] | 2347 | |
Chris Lattner | cc14ebc | 2005-09-23 06:39:30 +0000 | [diff] [blame] | 2348 | // If we can still promote the PHI nodes after this gauntlet of tests, |
| 2349 | // do all of the PHI's now. |
Chris Lattner | 7499b45 | 2010-12-14 08:46:09 +0000 | [diff] [blame] | 2350 | Instruction *InsertPt = DomBlock->getTerminator(); |
Mehdi Amini | ba9fba8 | 2016-03-13 21:05:13 +0000 | [diff] [blame] | 2351 | IRBuilder<NoFolder> Builder(InsertPt); |
Andrew Trick | f3cf193 | 2012-08-29 21:46:36 +0000 | [diff] [blame] | 2352 | |
Chris Lattner | cc14ebc | 2005-09-23 06:39:30 +0000 | [diff] [blame] | 2353 | // Move all 'aggressive' instructions, which are defined in the |
| 2354 | // conditional parts of the if's up to the dominating block. |
David Majnemer | e8fd5f9 | 2016-08-29 17:14:08 +0000 | [diff] [blame] | 2355 | if (IfBlock1) { |
| 2356 | for (auto &I : *IfBlock1) |
| 2357 | I.dropUnknownNonDebugMetadata(); |
Duncan P. N. Exon Smith | 5b4c837 | 2015-10-13 02:39:05 +0000 | [diff] [blame] | 2358 | DomBlock->getInstList().splice(InsertPt->getIterator(), |
Chris Lattner | 4088e2b | 2010-12-13 01:47:07 +0000 | [diff] [blame] | 2359 | IfBlock1->getInstList(), IfBlock1->begin(), |
Duncan P. N. Exon Smith | 5b4c837 | 2015-10-13 02:39:05 +0000 | [diff] [blame] | 2360 | IfBlock1->getTerminator()->getIterator()); |
David Majnemer | e8fd5f9 | 2016-08-29 17:14:08 +0000 | [diff] [blame] | 2361 | } |
| 2362 | if (IfBlock2) { |
| 2363 | for (auto &I : *IfBlock2) |
| 2364 | I.dropUnknownNonDebugMetadata(); |
Duncan P. N. Exon Smith | 5b4c837 | 2015-10-13 02:39:05 +0000 | [diff] [blame] | 2365 | DomBlock->getInstList().splice(InsertPt->getIterator(), |
Chris Lattner | 4088e2b | 2010-12-13 01:47:07 +0000 | [diff] [blame] | 2366 | IfBlock2->getInstList(), IfBlock2->begin(), |
Duncan P. N. Exon Smith | 5b4c837 | 2015-10-13 02:39:05 +0000 | [diff] [blame] | 2367 | IfBlock2->getTerminator()->getIterator()); |
David Majnemer | e8fd5f9 | 2016-08-29 17:14:08 +0000 | [diff] [blame] | 2368 | } |
Andrew Trick | f3cf193 | 2012-08-29 21:46:36 +0000 | [diff] [blame] | 2369 | |
Chris Lattner | cc14ebc | 2005-09-23 06:39:30 +0000 | [diff] [blame] | 2370 | while (PHINode *PN = dyn_cast<PHINode>(BB->begin())) { |
| 2371 | // Change the PHI node into a select instruction. |
Dehao Chen | f6c0083 | 2016-05-18 19:44:21 +0000 | [diff] [blame] | 2372 | Value *TrueVal = PN->getIncomingValue(PN->getIncomingBlock(0) == IfFalse); |
Chris Lattner | 4088e2b | 2010-12-13 01:47:07 +0000 | [diff] [blame] | 2373 | Value *FalseVal = PN->getIncomingValue(PN->getIncomingBlock(0) == IfTrue); |
Andrew Trick | f3cf193 | 2012-08-29 21:46:36 +0000 | [diff] [blame] | 2374 | |
Sanjay Patel | 9e23fed | 2016-03-17 15:30:52 +0000 | [diff] [blame] | 2375 | Value *Sel = Builder.CreateSelect(IfCond, TrueVal, FalseVal, "", InsertPt); |
| 2376 | PN->replaceAllUsesWith(Sel); |
| 2377 | Sel->takeName(PN); |
Chris Lattner | d7beca3 | 2010-12-14 06:17:25 +0000 | [diff] [blame] | 2378 | PN->eraseFromParent(); |
Chris Lattner | cc14ebc | 2005-09-23 06:39:30 +0000 | [diff] [blame] | 2379 | } |
Andrew Trick | f3cf193 | 2012-08-29 21:46:36 +0000 | [diff] [blame] | 2380 | |
Chris Lattner | 335f0e4 | 2010-12-14 08:01:53 +0000 | [diff] [blame] | 2381 | // At this point, IfBlock1 and IfBlock2 are both empty, so our if statement |
| 2382 | // has been flattened. Change DomBlock to jump directly to our new block to |
| 2383 | // avoid other simplifycfg's kicking in on the diamond. |
| 2384 | TerminatorInst *OldTI = DomBlock->getTerminator(); |
Devang Patel | 5c810ce | 2011-05-18 18:16:44 +0000 | [diff] [blame] | 2385 | Builder.SetInsertPoint(OldTI); |
| 2386 | Builder.CreateBr(BB); |
Chris Lattner | 335f0e4 | 2010-12-14 08:01:53 +0000 | [diff] [blame] | 2387 | OldTI->eraseFromParent(); |
Chris Lattner | cc14ebc | 2005-09-23 06:39:30 +0000 | [diff] [blame] | 2388 | return true; |
| 2389 | } |
Chris Lattner | 748f903 | 2005-09-19 23:49:37 +0000 | [diff] [blame] | 2390 | |
Sanjay Patel | 09159b8f | 2015-06-24 20:40:57 +0000 | [diff] [blame] | 2391 | /// If we found a conditional branch that goes to two returning blocks, |
| 2392 | /// try to merge them together into one return, |
Chris Lattner | 86bbf33 | 2008-04-24 00:01:19 +0000 | [diff] [blame] | 2393 | /// introducing a select if the return values disagree. |
Andrew Trick | f3cf193 | 2012-08-29 21:46:36 +0000 | [diff] [blame] | 2394 | static bool SimplifyCondBranchToTwoReturns(BranchInst *BI, |
Devang Patel | dd14e0f | 2011-05-18 21:33:11 +0000 | [diff] [blame] | 2395 | IRBuilder<> &Builder) { |
Chris Lattner | 86bbf33 | 2008-04-24 00:01:19 +0000 | [diff] [blame] | 2396 | assert(BI->isConditional() && "Must be a conditional branch"); |
| 2397 | BasicBlock *TrueSucc = BI->getSuccessor(0); |
| 2398 | BasicBlock *FalseSucc = BI->getSuccessor(1); |
| 2399 | ReturnInst *TrueRet = cast<ReturnInst>(TrueSucc->getTerminator()); |
| 2400 | ReturnInst *FalseRet = cast<ReturnInst>(FalseSucc->getTerminator()); |
Andrew Trick | f3cf193 | 2012-08-29 21:46:36 +0000 | [diff] [blame] | 2401 | |
Chris Lattner | 86bbf33 | 2008-04-24 00:01:19 +0000 | [diff] [blame] | 2402 | // Check to ensure both blocks are empty (just a return) or optionally empty |
| 2403 | // with PHI nodes. If there are other instructions, merging would cause extra |
| 2404 | // computation on one path or the other. |
Chris Lattner | 4088e2b | 2010-12-13 01:47:07 +0000 | [diff] [blame] | 2405 | if (!TrueSucc->getFirstNonPHIOrDbg()->isTerminator()) |
Devang Patel | 086b212 | 2009-02-05 00:30:42 +0000 | [diff] [blame] | 2406 | return false; |
Chris Lattner | 4088e2b | 2010-12-13 01:47:07 +0000 | [diff] [blame] | 2407 | if (!FalseSucc->getFirstNonPHIOrDbg()->isTerminator()) |
Devang Patel | 086b212 | 2009-02-05 00:30:42 +0000 | [diff] [blame] | 2408 | return false; |
Chris Lattner | 86bbf33 | 2008-04-24 00:01:19 +0000 | [diff] [blame] | 2409 | |
Devang Patel | dd14e0f | 2011-05-18 21:33:11 +0000 | [diff] [blame] | 2410 | Builder.SetInsertPoint(BI); |
Chris Lattner | 86bbf33 | 2008-04-24 00:01:19 +0000 | [diff] [blame] | 2411 | // Okay, we found a branch that is going to two return nodes. If |
| 2412 | // there is no return value for this function, just change the |
| 2413 | // branch into a return. |
| 2414 | if (FalseRet->getNumOperands() == 0) { |
| 2415 | TrueSucc->removePredecessor(BI->getParent()); |
| 2416 | FalseSucc->removePredecessor(BI->getParent()); |
Devang Patel | dd14e0f | 2011-05-18 21:33:11 +0000 | [diff] [blame] | 2417 | Builder.CreateRetVoid(); |
Eli Friedman | cb61afb | 2008-12-16 20:54:32 +0000 | [diff] [blame] | 2418 | EraseTerminatorInstAndDCECond(BI); |
Chris Lattner | 86bbf33 | 2008-04-24 00:01:19 +0000 | [diff] [blame] | 2419 | return true; |
| 2420 | } |
Andrew Trick | f3cf193 | 2012-08-29 21:46:36 +0000 | [diff] [blame] | 2421 | |
Dan Gohman | fa1211f | 2008-07-23 00:34:11 +0000 | [diff] [blame] | 2422 | // Otherwise, figure out what the true and false return values are |
| 2423 | // so we can insert a new select instruction. |
| 2424 | Value *TrueValue = TrueRet->getReturnValue(); |
| 2425 | Value *FalseValue = FalseRet->getReturnValue(); |
Andrew Trick | f3cf193 | 2012-08-29 21:46:36 +0000 | [diff] [blame] | 2426 | |
Dan Gohman | fa1211f | 2008-07-23 00:34:11 +0000 | [diff] [blame] | 2427 | // Unwrap any PHI nodes in the return blocks. |
| 2428 | if (PHINode *TVPN = dyn_cast_or_null<PHINode>(TrueValue)) |
| 2429 | if (TVPN->getParent() == TrueSucc) |
| 2430 | TrueValue = TVPN->getIncomingValueForBlock(BI->getParent()); |
| 2431 | if (PHINode *FVPN = dyn_cast_or_null<PHINode>(FalseValue)) |
| 2432 | if (FVPN->getParent() == FalseSucc) |
| 2433 | FalseValue = FVPN->getIncomingValueForBlock(BI->getParent()); |
Andrew Trick | f3cf193 | 2012-08-29 21:46:36 +0000 | [diff] [blame] | 2434 | |
Dan Gohman | fa1211f | 2008-07-23 00:34:11 +0000 | [diff] [blame] | 2435 | // In order for this transformation to be safe, we must be able to |
| 2436 | // unconditionally execute both operands to the return. This is |
| 2437 | // normally the case, but we could have a potentially-trapping |
| 2438 | // constant expression that prevents this transformation from being |
| 2439 | // safe. |
| 2440 | if (ConstantExpr *TCV = dyn_cast_or_null<ConstantExpr>(TrueValue)) |
| 2441 | if (TCV->canTrap()) |
| 2442 | return false; |
| 2443 | if (ConstantExpr *FCV = dyn_cast_or_null<ConstantExpr>(FalseValue)) |
| 2444 | if (FCV->canTrap()) |
| 2445 | return false; |
Andrew Trick | f3cf193 | 2012-08-29 21:46:36 +0000 | [diff] [blame] | 2446 | |
Chris Lattner | 86bbf33 | 2008-04-24 00:01:19 +0000 | [diff] [blame] | 2447 | // Okay, we collected all the mapped values and checked them for sanity, and |
| 2448 | // defined to really do this transformation. First, update the CFG. |
| 2449 | TrueSucc->removePredecessor(BI->getParent()); |
| 2450 | FalseSucc->removePredecessor(BI->getParent()); |
Andrew Trick | f3cf193 | 2012-08-29 21:46:36 +0000 | [diff] [blame] | 2451 | |
Chris Lattner | 86bbf33 | 2008-04-24 00:01:19 +0000 | [diff] [blame] | 2452 | // Insert select instructions where needed. |
| 2453 | Value *BrCond = BI->getCondition(); |
Dan Gohman | fa1211f | 2008-07-23 00:34:11 +0000 | [diff] [blame] | 2454 | if (TrueValue) { |
Chris Lattner | 86bbf33 | 2008-04-24 00:01:19 +0000 | [diff] [blame] | 2455 | // Insert a select if the results differ. |
Dan Gohman | fa1211f | 2008-07-23 00:34:11 +0000 | [diff] [blame] | 2456 | if (TrueValue == FalseValue || isa<UndefValue>(FalseValue)) { |
| 2457 | } else if (isa<UndefValue>(TrueValue)) { |
| 2458 | TrueValue = FalseValue; |
| 2459 | } else { |
Sanjay Patel | facf45a | 2016-04-27 23:14:12 +0000 | [diff] [blame] | 2460 | TrueValue = |
| 2461 | Builder.CreateSelect(BrCond, TrueValue, FalseValue, "retval", BI); |
Chris Lattner | 86bbf33 | 2008-04-24 00:01:19 +0000 | [diff] [blame] | 2462 | } |
Chris Lattner | 86bbf33 | 2008-04-24 00:01:19 +0000 | [diff] [blame] | 2463 | } |
| 2464 | |
Dehao Chen | f6c0083 | 2016-05-18 19:44:21 +0000 | [diff] [blame] | 2465 | Value *RI = |
| 2466 | !TrueValue ? Builder.CreateRetVoid() : Builder.CreateRet(TrueValue); |
Devang Patel | dd14e0f | 2011-05-18 21:33:11 +0000 | [diff] [blame] | 2467 | |
Dehao Chen | f6c0083 | 2016-05-18 19:44:21 +0000 | [diff] [blame] | 2468 | (void)RI; |
Andrew Trick | f3cf193 | 2012-08-29 21:46:36 +0000 | [diff] [blame] | 2469 | |
David Greene | 725c7c3 | 2010-01-05 01:26:52 +0000 | [diff] [blame] | 2470 | DEBUG(dbgs() << "\nCHANGING BRANCH TO TWO RETURNS INTO SELECT:" |
Chris Lattner | b25de3f | 2009-08-23 04:37:46 +0000 | [diff] [blame] | 2471 | << "\n " << *BI << "NewRet = " << *RI |
Dehao Chen | f6c0083 | 2016-05-18 19:44:21 +0000 | [diff] [blame] | 2472 | << "TRUEBLOCK: " << *TrueSucc << "FALSEBLOCK: " << *FalseSucc); |
Andrew Trick | f3cf193 | 2012-08-29 21:46:36 +0000 | [diff] [blame] | 2473 | |
Eli Friedman | cb61afb | 2008-12-16 20:54:32 +0000 | [diff] [blame] | 2474 | EraseTerminatorInstAndDCECond(BI); |
| 2475 | |
Chris Lattner | 86bbf33 | 2008-04-24 00:01:19 +0000 | [diff] [blame] | 2476 | return true; |
| 2477 | } |
| 2478 | |
Sanjay Patel | 09159b8f | 2015-06-24 20:40:57 +0000 | [diff] [blame] | 2479 | /// Return true if the given instruction is available |
Manman Ren | d33f4ef | 2012-06-13 05:43:29 +0000 | [diff] [blame] | 2480 | /// in its predecessor block. If yes, the instruction will be removed. |
Benjamin Kramer | abbfe69 | 2012-07-13 13:25:15 +0000 | [diff] [blame] | 2481 | static bool checkCSEInPredecessor(Instruction *Inst, BasicBlock *PB) { |
Manman Ren | d33f4ef | 2012-06-13 05:43:29 +0000 | [diff] [blame] | 2482 | if (!isa<BinaryOperator>(Inst) && !isa<CmpInst>(Inst)) |
| 2483 | return false; |
Benjamin Kramer | 135f735 | 2016-06-26 12:28:59 +0000 | [diff] [blame] | 2484 | for (Instruction &I : *PB) { |
| 2485 | Instruction *PBI = &I; |
Manman Ren | d33f4ef | 2012-06-13 05:43:29 +0000 | [diff] [blame] | 2486 | // Check whether Inst and PBI generate the same value. |
| 2487 | if (Inst->isIdenticalTo(PBI)) { |
| 2488 | Inst->replaceAllUsesWith(PBI); |
| 2489 | Inst->eraseFromParent(); |
| 2490 | return true; |
| 2491 | } |
| 2492 | } |
| 2493 | return false; |
| 2494 | } |
Nick Lewycky | 3c3feaf | 2012-01-25 09:43:14 +0000 | [diff] [blame] | 2495 | |
Dehao Chen | f16376b | 2016-05-18 22:41:03 +0000 | [diff] [blame] | 2496 | /// Return true if either PBI or BI has branch weight available, and store |
| 2497 | /// the weights in {Pred|Succ}{True|False}Weight. If one of PBI and BI does |
| 2498 | /// not have branch weight, use 1:1 as its weight. |
| 2499 | static bool extractPredSuccWeights(BranchInst *PBI, BranchInst *BI, |
| 2500 | uint64_t &PredTrueWeight, |
| 2501 | uint64_t &PredFalseWeight, |
| 2502 | uint64_t &SuccTrueWeight, |
| 2503 | uint64_t &SuccFalseWeight) { |
| 2504 | bool PredHasWeights = |
| 2505 | PBI->extractProfMetadata(PredTrueWeight, PredFalseWeight); |
| 2506 | bool SuccHasWeights = |
| 2507 | BI->extractProfMetadata(SuccTrueWeight, SuccFalseWeight); |
| 2508 | if (PredHasWeights || SuccHasWeights) { |
| 2509 | if (!PredHasWeights) |
| 2510 | PredTrueWeight = PredFalseWeight = 1; |
| 2511 | if (!SuccHasWeights) |
| 2512 | SuccTrueWeight = SuccFalseWeight = 1; |
| 2513 | return true; |
| 2514 | } else { |
| 2515 | return false; |
| 2516 | } |
| 2517 | } |
| 2518 | |
Sanjay Patel | 09159b8f | 2015-06-24 20:40:57 +0000 | [diff] [blame] | 2519 | /// If this basic block is simple enough, and if a predecessor branches to us |
| 2520 | /// and one of our successors, fold the block into the predecessor and use |
| 2521 | /// logical operations to pick the right destination. |
Mehdi Amini | a28d91d | 2015-03-10 02:37:25 +0000 | [diff] [blame] | 2522 | bool llvm::FoldBranchToCommonDest(BranchInst *BI, unsigned BonusInstThreshold) { |
Chris Lattner | 80b03a1 | 2008-07-13 22:23:11 +0000 | [diff] [blame] | 2523 | BasicBlock *BB = BI->getParent(); |
Devang Patel | 1407fb4 | 2011-05-19 20:52:46 +0000 | [diff] [blame] | 2524 | |
Craig Topper | f40110f | 2014-04-25 05:29:35 +0000 | [diff] [blame] | 2525 | Instruction *Cond = nullptr; |
Manman Ren | d33f4ef | 2012-06-13 05:43:29 +0000 | [diff] [blame] | 2526 | if (BI->isConditional()) |
| 2527 | Cond = dyn_cast<Instruction>(BI->getCondition()); |
| 2528 | else { |
| 2529 | // For unconditional branch, check for a simple CFG pattern, where |
| 2530 | // BB has a single predecessor and BB's successor is also its predecessor's |
| 2531 | // successor. If such pattern exisits, check for CSE between BB and its |
| 2532 | // predecessor. |
| 2533 | if (BasicBlock *PB = BB->getSinglePredecessor()) |
| 2534 | if (BranchInst *PBI = dyn_cast<BranchInst>(PB->getTerminator())) |
| 2535 | if (PBI->isConditional() && |
| 2536 | (BI->getSuccessor(0) == PBI->getSuccessor(0) || |
| 2537 | BI->getSuccessor(0) == PBI->getSuccessor(1))) { |
Dehao Chen | f6c0083 | 2016-05-18 19:44:21 +0000 | [diff] [blame] | 2538 | for (BasicBlock::iterator I = BB->begin(), E = BB->end(); I != E;) { |
Duncan P. N. Exon Smith | 5b4c837 | 2015-10-13 02:39:05 +0000 | [diff] [blame] | 2539 | Instruction *Curr = &*I++; |
Manman Ren | d33f4ef | 2012-06-13 05:43:29 +0000 | [diff] [blame] | 2540 | if (isa<CmpInst>(Curr)) { |
| 2541 | Cond = Curr; |
| 2542 | break; |
| 2543 | } |
| 2544 | // Quit if we can't remove this instruction. |
| 2545 | if (!checkCSEInPredecessor(Curr, PB)) |
| 2546 | return false; |
| 2547 | } |
| 2548 | } |
| 2549 | |
Craig Topper | f40110f | 2014-04-25 05:29:35 +0000 | [diff] [blame] | 2550 | if (!Cond) |
Manman Ren | d33f4ef | 2012-06-13 05:43:29 +0000 | [diff] [blame] | 2551 | return false; |
| 2552 | } |
Andrew Trick | f3cf193 | 2012-08-29 21:46:36 +0000 | [diff] [blame] | 2553 | |
Craig Topper | f40110f | 2014-04-25 05:29:35 +0000 | [diff] [blame] | 2554 | if (!Cond || (!isa<CmpInst>(Cond) && !isa<BinaryOperator>(Cond)) || |
| 2555 | Cond->getParent() != BB || !Cond->hasOneUse()) |
Sanjay Patel | 2e00277 | 2016-03-12 18:05:53 +0000 | [diff] [blame] | 2556 | return false; |
Devang Patel | d715ec8 | 2011-04-06 22:37:20 +0000 | [diff] [blame] | 2557 | |
Chris Lattner | 2e25b8f | 2008-07-13 21:12:01 +0000 | [diff] [blame] | 2558 | // Make sure the instruction after the condition is the cond branch. |
Duncan P. N. Exon Smith | 5b4c837 | 2015-10-13 02:39:05 +0000 | [diff] [blame] | 2559 | BasicBlock::iterator CondIt = ++Cond->getIterator(); |
Chris Lattner | fba5cdf | 2011-04-14 02:44:53 +0000 | [diff] [blame] | 2560 | |
Sanjay Patel | 0a2ada7 | 2014-07-06 23:10:24 +0000 | [diff] [blame] | 2561 | // Ignore dbg intrinsics. |
Dehao Chen | f6c0083 | 2016-05-18 19:44:21 +0000 | [diff] [blame] | 2562 | while (isa<DbgInfoIntrinsic>(CondIt)) |
| 2563 | ++CondIt; |
Andrew Trick | f3cf193 | 2012-08-29 21:46:36 +0000 | [diff] [blame] | 2564 | |
Chris Lattner | fba5cdf | 2011-04-14 02:44:53 +0000 | [diff] [blame] | 2565 | if (&*CondIt != BI) |
Chris Lattner | 2e25b8f | 2008-07-13 21:12:01 +0000 | [diff] [blame] | 2566 | return false; |
Chris Lattner | ea9f1d3 | 2009-01-19 23:03:13 +0000 | [diff] [blame] | 2567 | |
Jingyue Wu | fc02967 | 2014-09-30 22:23:38 +0000 | [diff] [blame] | 2568 | // Only allow this transformation if computing the condition doesn't involve |
| 2569 | // too many instructions and these involved instructions can be executed |
| 2570 | // unconditionally. We denote all involved instructions except the condition |
| 2571 | // as "bonus instructions", and only allow this transformation when the |
| 2572 | // number of the bonus instructions does not exceed a certain threshold. |
| 2573 | unsigned NumBonusInsts = 0; |
Duncan P. N. Exon Smith | e9bc579 | 2016-02-21 20:39:50 +0000 | [diff] [blame] | 2574 | for (auto I = BB->begin(); Cond != &*I; ++I) { |
Jingyue Wu | fc02967 | 2014-09-30 22:23:38 +0000 | [diff] [blame] | 2575 | // Ignore dbg intrinsics. |
| 2576 | if (isa<DbgInfoIntrinsic>(I)) |
| 2577 | continue; |
Duncan P. N. Exon Smith | 5b4c837 | 2015-10-13 02:39:05 +0000 | [diff] [blame] | 2578 | if (!I->hasOneUse() || !isSafeToSpeculativelyExecute(&*I)) |
Jingyue Wu | fc02967 | 2014-09-30 22:23:38 +0000 | [diff] [blame] | 2579 | return false; |
| 2580 | // I has only one use and can be executed unconditionally. |
| 2581 | Instruction *User = dyn_cast<Instruction>(I->user_back()); |
| 2582 | if (User == nullptr || User->getParent() != BB) |
| 2583 | return false; |
| 2584 | // I is used in the same BB. Since BI uses Cond and doesn't have more slots |
| 2585 | // to use any other instruction, User must be an instruction between next(I) |
| 2586 | // and Cond. |
| 2587 | ++NumBonusInsts; |
| 2588 | // Early exits once we reach the limit. |
| 2589 | if (NumBonusInsts > BonusInstThreshold) |
| 2590 | return false; |
| 2591 | } |
| 2592 | |
Chris Lattner | ea9f1d3 | 2009-01-19 23:03:13 +0000 | [diff] [blame] | 2593 | // Cond is known to be a compare or binary operator. Check to make sure that |
| 2594 | // neither operand is a potentially-trapping constant expression. |
| 2595 | if (ConstantExpr *CE = dyn_cast<ConstantExpr>(Cond->getOperand(0))) |
| 2596 | if (CE->canTrap()) |
| 2597 | return false; |
| 2598 | if (ConstantExpr *CE = dyn_cast<ConstantExpr>(Cond->getOperand(1))) |
| 2599 | if (CE->canTrap()) |
| 2600 | return false; |
Andrew Trick | f3cf193 | 2012-08-29 21:46:36 +0000 | [diff] [blame] | 2601 | |
Chris Lattner | 2e25b8f | 2008-07-13 21:12:01 +0000 | [diff] [blame] | 2602 | // Finally, don't infinitely unroll conditional loops. |
Dehao Chen | f6c0083 | 2016-05-18 19:44:21 +0000 | [diff] [blame] | 2603 | BasicBlock *TrueDest = BI->getSuccessor(0); |
Craig Topper | f40110f | 2014-04-25 05:29:35 +0000 | [diff] [blame] | 2604 | BasicBlock *FalseDest = (BI->isConditional()) ? BI->getSuccessor(1) : nullptr; |
Chris Lattner | 2e25b8f | 2008-07-13 21:12:01 +0000 | [diff] [blame] | 2605 | if (TrueDest == BB || FalseDest == BB) |
| 2606 | return false; |
Devang Patel | d715ec8 | 2011-04-06 22:37:20 +0000 | [diff] [blame] | 2607 | |
Duncan P. N. Exon Smith | 6c99015 | 2014-07-21 17:06:51 +0000 | [diff] [blame] | 2608 | for (pred_iterator PI = pred_begin(BB), E = pred_end(BB); PI != E; ++PI) { |
| 2609 | BasicBlock *PredBlock = *PI; |
Chris Lattner | 2e25b8f | 2008-07-13 21:12:01 +0000 | [diff] [blame] | 2610 | BranchInst *PBI = dyn_cast<BranchInst>(PredBlock->getTerminator()); |
Andrew Trick | f3cf193 | 2012-08-29 21:46:36 +0000 | [diff] [blame] | 2611 | |
Chris Lattner | 80b03a1 | 2008-07-13 22:23:11 +0000 | [diff] [blame] | 2612 | // Check that we have two conditional branches. If there is a PHI node in |
| 2613 | // the common successor, verify that the same value flows in from both |
| 2614 | // blocks. |
Dehao Chen | f6c0083 | 2016-05-18 19:44:21 +0000 | [diff] [blame] | 2615 | SmallVector<PHINode *, 4> PHIs; |
Craig Topper | f40110f | 2014-04-25 05:29:35 +0000 | [diff] [blame] | 2616 | if (!PBI || PBI->isUnconditional() || |
Dehao Chen | f6c0083 | 2016-05-18 19:44:21 +0000 | [diff] [blame] | 2617 | (BI->isConditional() && !SafeToMergeTerminators(BI, PBI)) || |
Manman Ren | d33f4ef | 2012-06-13 05:43:29 +0000 | [diff] [blame] | 2618 | (!BI->isConditional() && |
| 2619 | !isProfitableToFoldUnconditional(BI, PBI, Cond, PHIs))) |
Chris Lattner | 2e25b8f | 2008-07-13 21:12:01 +0000 | [diff] [blame] | 2620 | continue; |
Andrew Trick | f3cf193 | 2012-08-29 21:46:36 +0000 | [diff] [blame] | 2621 | |
Chris Lattner | fba5cdf | 2011-04-14 02:44:53 +0000 | [diff] [blame] | 2622 | // Determine if the two branches share a common destination. |
Axel Naumann | 4a12706 | 2012-09-17 14:20:57 +0000 | [diff] [blame] | 2623 | Instruction::BinaryOps Opc = Instruction::BinaryOpsEnd; |
Chris Lattner | fba5cdf | 2011-04-14 02:44:53 +0000 | [diff] [blame] | 2624 | bool InvertPredCond = false; |
Andrew Trick | f3cf193 | 2012-08-29 21:46:36 +0000 | [diff] [blame] | 2625 | |
Manman Ren | d33f4ef | 2012-06-13 05:43:29 +0000 | [diff] [blame] | 2626 | if (BI->isConditional()) { |
Richard Trieu | 7a08381 | 2016-02-18 22:09:30 +0000 | [diff] [blame] | 2627 | if (PBI->getSuccessor(0) == TrueDest) { |
Manman Ren | d33f4ef | 2012-06-13 05:43:29 +0000 | [diff] [blame] | 2628 | Opc = Instruction::Or; |
Richard Trieu | 7a08381 | 2016-02-18 22:09:30 +0000 | [diff] [blame] | 2629 | } else if (PBI->getSuccessor(1) == FalseDest) { |
Manman Ren | d33f4ef | 2012-06-13 05:43:29 +0000 | [diff] [blame] | 2630 | Opc = Instruction::And; |
Richard Trieu | 7a08381 | 2016-02-18 22:09:30 +0000 | [diff] [blame] | 2631 | } else if (PBI->getSuccessor(0) == FalseDest) { |
| 2632 | Opc = Instruction::And; |
| 2633 | InvertPredCond = true; |
| 2634 | } else if (PBI->getSuccessor(1) == TrueDest) { |
| 2635 | Opc = Instruction::Or; |
| 2636 | InvertPredCond = true; |
| 2637 | } else { |
Manman Ren | d33f4ef | 2012-06-13 05:43:29 +0000 | [diff] [blame] | 2638 | continue; |
Richard Trieu | 7a08381 | 2016-02-18 22:09:30 +0000 | [diff] [blame] | 2639 | } |
Manman Ren | d33f4ef | 2012-06-13 05:43:29 +0000 | [diff] [blame] | 2640 | } else { |
| 2641 | if (PBI->getSuccessor(0) != TrueDest && PBI->getSuccessor(1) != TrueDest) |
| 2642 | continue; |
| 2643 | } |
Chris Lattner | fba5cdf | 2011-04-14 02:44:53 +0000 | [diff] [blame] | 2644 | |
David Greene | 725c7c3 | 2010-01-05 01:26:52 +0000 | [diff] [blame] | 2645 | DEBUG(dbgs() << "FOLDING BRANCH TO COMMON DEST:\n" << *PBI << *BB); |
Andrew Trick | f3cf193 | 2012-08-29 21:46:36 +0000 | [diff] [blame] | 2646 | IRBuilder<> Builder(PBI); |
Devang Patel | 1407fb4 | 2011-05-19 20:52:46 +0000 | [diff] [blame] | 2647 | |
Chris Lattner | 55eaae1 | 2008-07-13 21:20:19 +0000 | [diff] [blame] | 2648 | // If we need to invert the condition in the pred block to match, do so now. |
| 2649 | if (InvertPredCond) { |
Chris Lattner | fbeb558 | 2010-12-13 07:00:06 +0000 | [diff] [blame] | 2650 | Value *NewCond = PBI->getCondition(); |
Andrew Trick | f3cf193 | 2012-08-29 21:46:36 +0000 | [diff] [blame] | 2651 | |
Chris Lattner | fbeb558 | 2010-12-13 07:00:06 +0000 | [diff] [blame] | 2652 | if (NewCond->hasOneUse() && isa<CmpInst>(NewCond)) { |
| 2653 | CmpInst *CI = cast<CmpInst>(NewCond); |
| 2654 | CI->setPredicate(CI->getInversePredicate()); |
| 2655 | } else { |
Dehao Chen | f6c0083 | 2016-05-18 19:44:21 +0000 | [diff] [blame] | 2656 | NewCond = |
| 2657 | Builder.CreateNot(NewCond, PBI->getCondition()->getName() + ".not"); |
Chris Lattner | fbeb558 | 2010-12-13 07:00:06 +0000 | [diff] [blame] | 2658 | } |
Andrew Trick | f3cf193 | 2012-08-29 21:46:36 +0000 | [diff] [blame] | 2659 | |
Chris Lattner | 2e25b8f | 2008-07-13 21:12:01 +0000 | [diff] [blame] | 2660 | PBI->setCondition(NewCond); |
Nick Lewycky | 8d302df | 2011-12-26 20:54:14 +0000 | [diff] [blame] | 2661 | PBI->swapSuccessors(); |
Chris Lattner | 2e25b8f | 2008-07-13 21:12:01 +0000 | [diff] [blame] | 2662 | } |
Andrew Trick | f3cf193 | 2012-08-29 21:46:36 +0000 | [diff] [blame] | 2663 | |
Jingyue Wu | fc02967 | 2014-09-30 22:23:38 +0000 | [diff] [blame] | 2664 | // If we have bonus instructions, clone them into the predecessor block. |
Sanjay Patel | adb110c | 2015-06-24 20:07:50 +0000 | [diff] [blame] | 2665 | // Note that there may be multiple predecessor blocks, so we cannot move |
Jingyue Wu | fc02967 | 2014-09-30 22:23:38 +0000 | [diff] [blame] | 2666 | // bonus instructions to a predecessor block. |
| 2667 | ValueToValueMapTy VMap; // maps original values to cloned values |
| 2668 | // We already make sure Cond is the last instruction before BI. Therefore, |
Sanjay Patel | adb110c | 2015-06-24 20:07:50 +0000 | [diff] [blame] | 2669 | // all instructions before Cond other than DbgInfoIntrinsic are bonus |
Jingyue Wu | fc02967 | 2014-09-30 22:23:38 +0000 | [diff] [blame] | 2670 | // instructions. |
Duncan P. N. Exon Smith | e9bc579 | 2016-02-21 20:39:50 +0000 | [diff] [blame] | 2671 | for (auto BonusInst = BB->begin(); Cond != &*BonusInst; ++BonusInst) { |
Jingyue Wu | fc02967 | 2014-09-30 22:23:38 +0000 | [diff] [blame] | 2672 | if (isa<DbgInfoIntrinsic>(BonusInst)) |
| 2673 | continue; |
| 2674 | Instruction *NewBonusInst = BonusInst->clone(); |
| 2675 | RemapInstruction(NewBonusInst, VMap, |
Duncan P. N. Exon Smith | da68cbc | 2016-04-07 00:26:43 +0000 | [diff] [blame] | 2676 | RF_NoModuleLevelChanges | RF_IgnoreMissingLocals); |
Duncan P. N. Exon Smith | 5b4c837 | 2015-10-13 02:39:05 +0000 | [diff] [blame] | 2677 | VMap[&*BonusInst] = NewBonusInst; |
Rafael Espindola | ab73c49 | 2014-01-28 16:56:46 +0000 | [diff] [blame] | 2678 | |
| 2679 | // If we moved a load, we cannot any longer claim any knowledge about |
| 2680 | // its potential value. The previous information might have been valid |
| 2681 | // only given the branch precondition. |
| 2682 | // For an analogous reason, we must also drop all the metadata whose |
| 2683 | // semantics we don't understand. |
Adrian Prantl | cbdfdb7 | 2015-08-20 22:00:30 +0000 | [diff] [blame] | 2684 | NewBonusInst->dropUnknownNonDebugMetadata(); |
Rafael Espindola | ab73c49 | 2014-01-28 16:56:46 +0000 | [diff] [blame] | 2685 | |
Duncan P. N. Exon Smith | 5b4c837 | 2015-10-13 02:39:05 +0000 | [diff] [blame] | 2686 | PredBlock->getInstList().insert(PBI->getIterator(), NewBonusInst); |
| 2687 | NewBonusInst->takeName(&*BonusInst); |
Jingyue Wu | fc02967 | 2014-09-30 22:23:38 +0000 | [diff] [blame] | 2688 | BonusInst->setName(BonusInst->getName() + ".old"); |
Owen Anderson | 2cfe913 | 2010-07-14 19:52:16 +0000 | [diff] [blame] | 2689 | } |
Andrew Trick | f3cf193 | 2012-08-29 21:46:36 +0000 | [diff] [blame] | 2690 | |
Chris Lattner | 55eaae1 | 2008-07-13 21:20:19 +0000 | [diff] [blame] | 2691 | // Clone Cond into the predecessor basic block, and or/and the |
| 2692 | // two conditions together. |
Nick Lewycky | 42fb745 | 2009-09-27 07:38:41 +0000 | [diff] [blame] | 2693 | Instruction *New = Cond->clone(); |
Jingyue Wu | fc02967 | 2014-09-30 22:23:38 +0000 | [diff] [blame] | 2694 | RemapInstruction(New, VMap, |
Duncan P. N. Exon Smith | da68cbc | 2016-04-07 00:26:43 +0000 | [diff] [blame] | 2695 | RF_NoModuleLevelChanges | RF_IgnoreMissingLocals); |
Duncan P. N. Exon Smith | 5b4c837 | 2015-10-13 02:39:05 +0000 | [diff] [blame] | 2696 | PredBlock->getInstList().insert(PBI->getIterator(), New); |
Chris Lattner | 55eaae1 | 2008-07-13 21:20:19 +0000 | [diff] [blame] | 2697 | New->takeName(Cond); |
Jingyue Wu | fc02967 | 2014-09-30 22:23:38 +0000 | [diff] [blame] | 2698 | Cond->setName(New->getName() + ".old"); |
Andrew Trick | f3cf193 | 2012-08-29 21:46:36 +0000 | [diff] [blame] | 2699 | |
Manman Ren | d33f4ef | 2012-06-13 05:43:29 +0000 | [diff] [blame] | 2700 | if (BI->isConditional()) { |
Dehao Chen | f6c0083 | 2016-05-18 19:44:21 +0000 | [diff] [blame] | 2701 | Instruction *NewCond = cast<Instruction>( |
| 2702 | Builder.CreateBinOp(Opc, PBI->getCondition(), New, "or.cond")); |
Manman Ren | d33f4ef | 2012-06-13 05:43:29 +0000 | [diff] [blame] | 2703 | PBI->setCondition(NewCond); |
| 2704 | |
Manman Ren | bfb9d43 | 2012-09-15 00:39:57 +0000 | [diff] [blame] | 2705 | uint64_t PredTrueWeight, PredFalseWeight, SuccTrueWeight, SuccFalseWeight; |
Dehao Chen | f16376b | 2016-05-18 22:41:03 +0000 | [diff] [blame] | 2706 | bool HasWeights = |
| 2707 | extractPredSuccWeights(PBI, BI, PredTrueWeight, PredFalseWeight, |
| 2708 | SuccTrueWeight, SuccFalseWeight); |
Manman Ren | bfb9d43 | 2012-09-15 00:39:57 +0000 | [diff] [blame] | 2709 | SmallVector<uint64_t, 8> NewWeights; |
| 2710 | |
Manman Ren | d33f4ef | 2012-06-13 05:43:29 +0000 | [diff] [blame] | 2711 | if (PBI->getSuccessor(0) == BB) { |
Dehao Chen | f16376b | 2016-05-18 22:41:03 +0000 | [diff] [blame] | 2712 | if (HasWeights) { |
Manman Ren | bfb9d43 | 2012-09-15 00:39:57 +0000 | [diff] [blame] | 2713 | // PBI: br i1 %x, BB, FalseDest |
| 2714 | // BI: br i1 %y, TrueDest, FalseDest |
Dehao Chen | f6c0083 | 2016-05-18 19:44:21 +0000 | [diff] [blame] | 2715 | // TrueWeight is TrueWeight for PBI * TrueWeight for BI. |
Manman Ren | bfb9d43 | 2012-09-15 00:39:57 +0000 | [diff] [blame] | 2716 | NewWeights.push_back(PredTrueWeight * SuccTrueWeight); |
Dehao Chen | f6c0083 | 2016-05-18 19:44:21 +0000 | [diff] [blame] | 2717 | // FalseWeight is FalseWeight for PBI * TotalWeight for BI + |
Manman Ren | bfb9d43 | 2012-09-15 00:39:57 +0000 | [diff] [blame] | 2718 | // TrueWeight for PBI * FalseWeight for BI. |
| 2719 | // We assume that total weights of a BranchInst can fit into 32 bits. |
| 2720 | // Therefore, we will not have overflow using 64-bit arithmetic. |
Dehao Chen | f6c0083 | 2016-05-18 19:44:21 +0000 | [diff] [blame] | 2721 | NewWeights.push_back(PredFalseWeight * |
| 2722 | (SuccFalseWeight + SuccTrueWeight) + |
| 2723 | PredTrueWeight * SuccFalseWeight); |
Manman Ren | bfb9d43 | 2012-09-15 00:39:57 +0000 | [diff] [blame] | 2724 | } |
Manman Ren | d33f4ef | 2012-06-13 05:43:29 +0000 | [diff] [blame] | 2725 | AddPredecessorToBlock(TrueDest, PredBlock, BB); |
| 2726 | PBI->setSuccessor(0, TrueDest); |
| 2727 | } |
| 2728 | if (PBI->getSuccessor(1) == BB) { |
Dehao Chen | f16376b | 2016-05-18 22:41:03 +0000 | [diff] [blame] | 2729 | if (HasWeights) { |
Manman Ren | bfb9d43 | 2012-09-15 00:39:57 +0000 | [diff] [blame] | 2730 | // PBI: br i1 %x, TrueDest, BB |
| 2731 | // BI: br i1 %y, TrueDest, FalseDest |
Dehao Chen | f6c0083 | 2016-05-18 19:44:21 +0000 | [diff] [blame] | 2732 | // TrueWeight is TrueWeight for PBI * TotalWeight for BI + |
Manman Ren | bfb9d43 | 2012-09-15 00:39:57 +0000 | [diff] [blame] | 2733 | // FalseWeight for PBI * TrueWeight for BI. |
Dehao Chen | f6c0083 | 2016-05-18 19:44:21 +0000 | [diff] [blame] | 2734 | NewWeights.push_back(PredTrueWeight * |
| 2735 | (SuccFalseWeight + SuccTrueWeight) + |
| 2736 | PredFalseWeight * SuccTrueWeight); |
| 2737 | // FalseWeight is FalseWeight for PBI * FalseWeight for BI. |
Manman Ren | bfb9d43 | 2012-09-15 00:39:57 +0000 | [diff] [blame] | 2738 | NewWeights.push_back(PredFalseWeight * SuccFalseWeight); |
| 2739 | } |
Manman Ren | d33f4ef | 2012-06-13 05:43:29 +0000 | [diff] [blame] | 2740 | AddPredecessorToBlock(FalseDest, PredBlock, BB); |
| 2741 | PBI->setSuccessor(1, FalseDest); |
| 2742 | } |
Manman Ren | bfb9d43 | 2012-09-15 00:39:57 +0000 | [diff] [blame] | 2743 | if (NewWeights.size() == 2) { |
| 2744 | // Halve the weights if any of them cannot fit in an uint32_t |
| 2745 | FitWeights(NewWeights); |
| 2746 | |
Dehao Chen | f6c0083 | 2016-05-18 19:44:21 +0000 | [diff] [blame] | 2747 | SmallVector<uint32_t, 8> MDWeights(NewWeights.begin(), |
| 2748 | NewWeights.end()); |
| 2749 | PBI->setMetadata( |
| 2750 | LLVMContext::MD_prof, |
| 2751 | MDBuilder(BI->getContext()).createBranchWeights(MDWeights)); |
Manman Ren | bfb9d43 | 2012-09-15 00:39:57 +0000 | [diff] [blame] | 2752 | } else |
Craig Topper | f40110f | 2014-04-25 05:29:35 +0000 | [diff] [blame] | 2753 | PBI->setMetadata(LLVMContext::MD_prof, nullptr); |
Manman Ren | d33f4ef | 2012-06-13 05:43:29 +0000 | [diff] [blame] | 2754 | } else { |
| 2755 | // Update PHI nodes in the common successors. |
| 2756 | for (unsigned i = 0, e = PHIs.size(); i != e; ++i) { |
Nick Lewycky | 0a045bb | 2012-06-24 10:15:42 +0000 | [diff] [blame] | 2757 | ConstantInt *PBI_C = cast<ConstantInt>( |
Dehao Chen | f6c0083 | 2016-05-18 19:44:21 +0000 | [diff] [blame] | 2758 | PHIs[i]->getIncomingValueForBlock(PBI->getParent())); |
Manman Ren | d33f4ef | 2012-06-13 05:43:29 +0000 | [diff] [blame] | 2759 | assert(PBI_C->getType()->isIntegerTy(1)); |
Craig Topper | f40110f | 2014-04-25 05:29:35 +0000 | [diff] [blame] | 2760 | Instruction *MergedCond = nullptr; |
Manman Ren | d33f4ef | 2012-06-13 05:43:29 +0000 | [diff] [blame] | 2761 | if (PBI->getSuccessor(0) == TrueDest) { |
| 2762 | // Create (PBI_Cond and PBI_C) or (!PBI_Cond and BI_Value) |
| 2763 | // PBI_C is true: PBI_Cond or (!PBI_Cond and BI_Value) |
| 2764 | // is false: !PBI_Cond and BI_Value |
Dehao Chen | f6c0083 | 2016-05-18 19:44:21 +0000 | [diff] [blame] | 2765 | Instruction *NotCond = cast<Instruction>( |
| 2766 | Builder.CreateNot(PBI->getCondition(), "not.cond")); |
| 2767 | MergedCond = cast<Instruction>( |
| 2768 | Builder.CreateBinOp(Instruction::And, NotCond, New, "and.cond")); |
Manman Ren | d33f4ef | 2012-06-13 05:43:29 +0000 | [diff] [blame] | 2769 | if (PBI_C->isOne()) |
Dehao Chen | f6c0083 | 2016-05-18 19:44:21 +0000 | [diff] [blame] | 2770 | MergedCond = cast<Instruction>(Builder.CreateBinOp( |
| 2771 | Instruction::Or, PBI->getCondition(), MergedCond, "or.cond")); |
Manman Ren | d33f4ef | 2012-06-13 05:43:29 +0000 | [diff] [blame] | 2772 | } else { |
| 2773 | // Create (PBI_Cond and BI_Value) or (!PBI_Cond and PBI_C) |
| 2774 | // PBI_C is true: (PBI_Cond and BI_Value) or (!PBI_Cond) |
| 2775 | // is false: PBI_Cond and BI_Value |
Dehao Chen | f6c0083 | 2016-05-18 19:44:21 +0000 | [diff] [blame] | 2776 | MergedCond = cast<Instruction>(Builder.CreateBinOp( |
| 2777 | Instruction::And, PBI->getCondition(), New, "and.cond")); |
Manman Ren | d33f4ef | 2012-06-13 05:43:29 +0000 | [diff] [blame] | 2778 | if (PBI_C->isOne()) { |
Dehao Chen | f6c0083 | 2016-05-18 19:44:21 +0000 | [diff] [blame] | 2779 | Instruction *NotCond = cast<Instruction>( |
| 2780 | Builder.CreateNot(PBI->getCondition(), "not.cond")); |
| 2781 | MergedCond = cast<Instruction>(Builder.CreateBinOp( |
| 2782 | Instruction::Or, NotCond, MergedCond, "or.cond")); |
Manman Ren | d33f4ef | 2012-06-13 05:43:29 +0000 | [diff] [blame] | 2783 | } |
| 2784 | } |
| 2785 | // Update PHI Node. |
| 2786 | PHIs[i]->setIncomingValue(PHIs[i]->getBasicBlockIndex(PBI->getParent()), |
| 2787 | MergedCond); |
| 2788 | } |
| 2789 | // Change PBI from Conditional to Unconditional. |
| 2790 | BranchInst *New_PBI = BranchInst::Create(TrueDest, PBI); |
| 2791 | EraseTerminatorInstAndDCECond(PBI); |
| 2792 | PBI = New_PBI; |
Chris Lattner | 55eaae1 | 2008-07-13 21:20:19 +0000 | [diff] [blame] | 2793 | } |
Devang Patel | d715ec8 | 2011-04-06 22:37:20 +0000 | [diff] [blame] | 2794 | |
Michael Kuperstein | 3ca147e | 2016-12-16 21:23:59 +0000 | [diff] [blame^] | 2795 | // If BI was a loop latch, it may have had associated loop metadata. |
| 2796 | // We need to copy it to the new latch, that is, PBI. |
| 2797 | if (MDNode *LoopMD = BI->getMetadata(LLVMContext::MD_loop)) |
| 2798 | PBI->setMetadata(LLVMContext::MD_loop, LoopMD); |
| 2799 | |
Nick Lewycky | c554a9b | 2011-12-27 04:31:52 +0000 | [diff] [blame] | 2800 | // TODO: If BB is reachable from all paths through PredBlock, then we |
| 2801 | // could replace PBI's branch probabilities with BI's. |
| 2802 | |
Chris Lattner | fba5cdf | 2011-04-14 02:44:53 +0000 | [diff] [blame] | 2803 | // Copy any debug value intrinsics into the end of PredBlock. |
Benjamin Kramer | 135f735 | 2016-06-26 12:28:59 +0000 | [diff] [blame] | 2804 | for (Instruction &I : *BB) |
| 2805 | if (isa<DbgInfoIntrinsic>(I)) |
| 2806 | I.clone()->insertBefore(PBI); |
Andrew Trick | f3cf193 | 2012-08-29 21:46:36 +0000 | [diff] [blame] | 2807 | |
Chris Lattner | 5a9d59d | 2010-12-14 05:57:30 +0000 | [diff] [blame] | 2808 | return true; |
Chris Lattner | 2e25b8f | 2008-07-13 21:12:01 +0000 | [diff] [blame] | 2809 | } |
| 2810 | return false; |
| 2811 | } |
| 2812 | |
James Molloy | 4de84dd | 2015-11-04 15:28:04 +0000 | [diff] [blame] | 2813 | // If there is only one store in BB1 and BB2, return it, otherwise return |
| 2814 | // nullptr. |
| 2815 | static StoreInst *findUniqueStoreInBlocks(BasicBlock *BB1, BasicBlock *BB2) { |
| 2816 | StoreInst *S = nullptr; |
| 2817 | for (auto *BB : {BB1, BB2}) { |
| 2818 | if (!BB) |
| 2819 | continue; |
| 2820 | for (auto &I : *BB) |
| 2821 | if (auto *SI = dyn_cast<StoreInst>(&I)) { |
| 2822 | if (S) |
| 2823 | // Multiple stores seen. |
| 2824 | return nullptr; |
| 2825 | else |
| 2826 | S = SI; |
| 2827 | } |
| 2828 | } |
| 2829 | return S; |
| 2830 | } |
| 2831 | |
| 2832 | static Value *ensureValueAvailableInSuccessor(Value *V, BasicBlock *BB, |
| 2833 | Value *AlternativeV = nullptr) { |
| 2834 | // PHI is going to be a PHI node that allows the value V that is defined in |
| 2835 | // BB to be referenced in BB's only successor. |
| 2836 | // |
| 2837 | // If AlternativeV is nullptr, the only value we care about in PHI is V. It |
| 2838 | // doesn't matter to us what the other operand is (it'll never get used). We |
| 2839 | // could just create a new PHI with an undef incoming value, but that could |
| 2840 | // increase register pressure if EarlyCSE/InstCombine can't fold it with some |
| 2841 | // other PHI. So here we directly look for some PHI in BB's successor with V |
| 2842 | // as an incoming operand. If we find one, we use it, else we create a new |
| 2843 | // one. |
| 2844 | // |
| 2845 | // If AlternativeV is not nullptr, we care about both incoming values in PHI. |
| 2846 | // PHI must be exactly: phi <ty> [ %BB, %V ], [ %OtherBB, %AlternativeV] |
| 2847 | // where OtherBB is the single other predecessor of BB's only successor. |
| 2848 | PHINode *PHI = nullptr; |
| 2849 | BasicBlock *Succ = BB->getSingleSuccessor(); |
Dehao Chen | f6c0083 | 2016-05-18 19:44:21 +0000 | [diff] [blame] | 2850 | |
James Molloy | 4de84dd | 2015-11-04 15:28:04 +0000 | [diff] [blame] | 2851 | for (auto I = Succ->begin(); isa<PHINode>(I); ++I) |
| 2852 | if (cast<PHINode>(I)->getIncomingValueForBlock(BB) == V) { |
| 2853 | PHI = cast<PHINode>(I); |
| 2854 | if (!AlternativeV) |
| 2855 | break; |
| 2856 | |
| 2857 | assert(std::distance(pred_begin(Succ), pred_end(Succ)) == 2); |
| 2858 | auto PredI = pred_begin(Succ); |
| 2859 | BasicBlock *OtherPredBB = *PredI == BB ? *++PredI : *PredI; |
| 2860 | if (PHI->getIncomingValueForBlock(OtherPredBB) == AlternativeV) |
| 2861 | break; |
| 2862 | PHI = nullptr; |
| 2863 | } |
| 2864 | if (PHI) |
| 2865 | return PHI; |
| 2866 | |
James Molloy | 3d21dcf | 2015-12-16 14:12:44 +0000 | [diff] [blame] | 2867 | // If V is not an instruction defined in BB, just return it. |
| 2868 | if (!AlternativeV && |
| 2869 | (!isa<Instruction>(V) || cast<Instruction>(V)->getParent() != BB)) |
| 2870 | return V; |
| 2871 | |
Duncan P. N. Exon Smith | 83c4b68 | 2015-11-07 00:01:16 +0000 | [diff] [blame] | 2872 | PHI = PHINode::Create(V->getType(), 2, "simplifycfg.merge", &Succ->front()); |
James Molloy | 4de84dd | 2015-11-04 15:28:04 +0000 | [diff] [blame] | 2873 | PHI->addIncoming(V, BB); |
| 2874 | for (BasicBlock *PredBB : predecessors(Succ)) |
| 2875 | if (PredBB != BB) |
Dehao Chen | f6c0083 | 2016-05-18 19:44:21 +0000 | [diff] [blame] | 2876 | PHI->addIncoming( |
| 2877 | AlternativeV ? AlternativeV : UndefValue::get(V->getType()), PredBB); |
James Molloy | 4de84dd | 2015-11-04 15:28:04 +0000 | [diff] [blame] | 2878 | return PHI; |
| 2879 | } |
| 2880 | |
| 2881 | static bool mergeConditionalStoreToAddress(BasicBlock *PTB, BasicBlock *PFB, |
| 2882 | BasicBlock *QTB, BasicBlock *QFB, |
| 2883 | BasicBlock *PostBB, Value *Address, |
| 2884 | bool InvertPCond, bool InvertQCond) { |
| 2885 | auto IsaBitcastOfPointerType = [](const Instruction &I) { |
| 2886 | return Operator::getOpcode(&I) == Instruction::BitCast && |
| 2887 | I.getType()->isPointerTy(); |
| 2888 | }; |
| 2889 | |
| 2890 | // If we're not in aggressive mode, we only optimize if we have some |
| 2891 | // confidence that by optimizing we'll allow P and/or Q to be if-converted. |
| 2892 | auto IsWorthwhile = [&](BasicBlock *BB) { |
| 2893 | if (!BB) |
| 2894 | return true; |
| 2895 | // Heuristic: if the block can be if-converted/phi-folded and the |
| 2896 | // instructions inside are all cheap (arithmetic/GEPs), it's worthwhile to |
| 2897 | // thread this store. |
James Molloy | 9e959ac | 2015-11-05 08:40:19 +0000 | [diff] [blame] | 2898 | unsigned N = 0; |
| 2899 | for (auto &I : *BB) { |
| 2900 | // Cheap instructions viable for folding. |
| 2901 | if (isa<BinaryOperator>(I) || isa<GetElementPtrInst>(I) || |
| 2902 | isa<StoreInst>(I)) |
| 2903 | ++N; |
| 2904 | // Free instructions. |
| 2905 | else if (isa<TerminatorInst>(I) || isa<DbgInfoIntrinsic>(I) || |
| 2906 | IsaBitcastOfPointerType(I)) |
| 2907 | continue; |
| 2908 | else |
James Molloy | 4de84dd | 2015-11-04 15:28:04 +0000 | [diff] [blame] | 2909 | return false; |
James Molloy | 9e959ac | 2015-11-05 08:40:19 +0000 | [diff] [blame] | 2910 | } |
| 2911 | return N <= PHINodeFoldingThreshold; |
James Molloy | 4de84dd | 2015-11-04 15:28:04 +0000 | [diff] [blame] | 2912 | }; |
| 2913 | |
Dehao Chen | f6c0083 | 2016-05-18 19:44:21 +0000 | [diff] [blame] | 2914 | if (!MergeCondStoresAggressively && |
| 2915 | (!IsWorthwhile(PTB) || !IsWorthwhile(PFB) || !IsWorthwhile(QTB) || |
| 2916 | !IsWorthwhile(QFB))) |
James Molloy | 4de84dd | 2015-11-04 15:28:04 +0000 | [diff] [blame] | 2917 | return false; |
| 2918 | |
| 2919 | // For every pointer, there must be exactly two stores, one coming from |
| 2920 | // PTB or PFB, and the other from QTB or QFB. We don't support more than one |
| 2921 | // store (to any address) in PTB,PFB or QTB,QFB. |
| 2922 | // FIXME: We could relax this restriction with a bit more work and performance |
| 2923 | // testing. |
| 2924 | StoreInst *PStore = findUniqueStoreInBlocks(PTB, PFB); |
| 2925 | StoreInst *QStore = findUniqueStoreInBlocks(QTB, QFB); |
| 2926 | if (!PStore || !QStore) |
| 2927 | return false; |
| 2928 | |
| 2929 | // Now check the stores are compatible. |
| 2930 | if (!QStore->isUnordered() || !PStore->isUnordered()) |
| 2931 | return false; |
| 2932 | |
| 2933 | // Check that sinking the store won't cause program behavior changes. Sinking |
| 2934 | // the store out of the Q blocks won't change any behavior as we're sinking |
| 2935 | // from a block to its unconditional successor. But we're moving a store from |
| 2936 | // the P blocks down through the middle block (QBI) and past both QFB and QTB. |
| 2937 | // So we need to check that there are no aliasing loads or stores in |
| 2938 | // QBI, QTB and QFB. We also need to check there are no conflicting memory |
| 2939 | // operations between PStore and the end of its parent block. |
| 2940 | // |
| 2941 | // The ideal way to do this is to query AliasAnalysis, but we don't |
| 2942 | // preserve AA currently so that is dangerous. Be super safe and just |
| 2943 | // check there are no other memory operations at all. |
| 2944 | for (auto &I : *QFB->getSinglePredecessor()) |
| 2945 | if (I.mayReadOrWriteMemory()) |
| 2946 | return false; |
| 2947 | for (auto &I : *QFB) |
| 2948 | if (&I != QStore && I.mayReadOrWriteMemory()) |
| 2949 | return false; |
| 2950 | if (QTB) |
| 2951 | for (auto &I : *QTB) |
| 2952 | if (&I != QStore && I.mayReadOrWriteMemory()) |
| 2953 | return false; |
| 2954 | for (auto I = BasicBlock::iterator(PStore), E = PStore->getParent()->end(); |
| 2955 | I != E; ++I) |
| 2956 | if (&*I != PStore && I->mayReadOrWriteMemory()) |
| 2957 | return false; |
| 2958 | |
| 2959 | // OK, we're going to sink the stores to PostBB. The store has to be |
| 2960 | // conditional though, so first create the predicate. |
| 2961 | Value *PCond = cast<BranchInst>(PFB->getSinglePredecessor()->getTerminator()) |
| 2962 | ->getCondition(); |
| 2963 | Value *QCond = cast<BranchInst>(QFB->getSinglePredecessor()->getTerminator()) |
| 2964 | ->getCondition(); |
| 2965 | |
| 2966 | Value *PPHI = ensureValueAvailableInSuccessor(PStore->getValueOperand(), |
| 2967 | PStore->getParent()); |
| 2968 | Value *QPHI = ensureValueAvailableInSuccessor(QStore->getValueOperand(), |
| 2969 | QStore->getParent(), PPHI); |
| 2970 | |
Duncan P. N. Exon Smith | 83c4b68 | 2015-11-07 00:01:16 +0000 | [diff] [blame] | 2971 | IRBuilder<> QB(&*PostBB->getFirstInsertionPt()); |
| 2972 | |
James Molloy | 4de84dd | 2015-11-04 15:28:04 +0000 | [diff] [blame] | 2973 | Value *PPred = PStore->getParent() == PTB ? PCond : QB.CreateNot(PCond); |
| 2974 | Value *QPred = QStore->getParent() == QTB ? QCond : QB.CreateNot(QCond); |
| 2975 | |
| 2976 | if (InvertPCond) |
| 2977 | PPred = QB.CreateNot(PPred); |
| 2978 | if (InvertQCond) |
| 2979 | QPred = QB.CreateNot(QPred); |
| 2980 | Value *CombinedPred = QB.CreateOr(PPred, QPred); |
| 2981 | |
Duncan P. N. Exon Smith | 83c4b68 | 2015-11-07 00:01:16 +0000 | [diff] [blame] | 2982 | auto *T = |
| 2983 | SplitBlockAndInsertIfThen(CombinedPred, &*QB.GetInsertPoint(), false); |
James Molloy | 4de84dd | 2015-11-04 15:28:04 +0000 | [diff] [blame] | 2984 | QB.SetInsertPoint(T); |
| 2985 | StoreInst *SI = cast<StoreInst>(QB.CreateStore(QPHI, Address)); |
| 2986 | AAMDNodes AAMD; |
| 2987 | PStore->getAAMetadata(AAMD, /*Merge=*/false); |
| 2988 | PStore->getAAMetadata(AAMD, /*Merge=*/true); |
| 2989 | SI->setAAMetadata(AAMD); |
| 2990 | |
| 2991 | QStore->eraseFromParent(); |
| 2992 | PStore->eraseFromParent(); |
Dehao Chen | f6c0083 | 2016-05-18 19:44:21 +0000 | [diff] [blame] | 2993 | |
James Molloy | 4de84dd | 2015-11-04 15:28:04 +0000 | [diff] [blame] | 2994 | return true; |
| 2995 | } |
| 2996 | |
| 2997 | static bool mergeConditionalStores(BranchInst *PBI, BranchInst *QBI) { |
| 2998 | // The intention here is to find diamonds or triangles (see below) where each |
| 2999 | // conditional block contains a store to the same address. Both of these |
| 3000 | // stores are conditional, so they can't be unconditionally sunk. But it may |
| 3001 | // be profitable to speculatively sink the stores into one merged store at the |
| 3002 | // end, and predicate the merged store on the union of the two conditions of |
| 3003 | // PBI and QBI. |
| 3004 | // |
| 3005 | // This can reduce the number of stores executed if both of the conditions are |
| 3006 | // true, and can allow the blocks to become small enough to be if-converted. |
| 3007 | // This optimization will also chain, so that ladders of test-and-set |
| 3008 | // sequences can be if-converted away. |
| 3009 | // |
| 3010 | // We only deal with simple diamonds or triangles: |
| 3011 | // |
| 3012 | // PBI or PBI or a combination of the two |
| 3013 | // / \ | \ |
| 3014 | // PTB PFB | PFB |
| 3015 | // \ / | / |
| 3016 | // QBI QBI |
| 3017 | // / \ | \ |
| 3018 | // QTB QFB | QFB |
| 3019 | // \ / | / |
| 3020 | // PostBB PostBB |
| 3021 | // |
| 3022 | // We model triangles as a type of diamond with a nullptr "true" block. |
| 3023 | // Triangles are canonicalized so that the fallthrough edge is represented by |
| 3024 | // a true condition, as in the diagram above. |
Dehao Chen | f6c0083 | 2016-05-18 19:44:21 +0000 | [diff] [blame] | 3025 | // |
James Molloy | 4de84dd | 2015-11-04 15:28:04 +0000 | [diff] [blame] | 3026 | BasicBlock *PTB = PBI->getSuccessor(0); |
| 3027 | BasicBlock *PFB = PBI->getSuccessor(1); |
| 3028 | BasicBlock *QTB = QBI->getSuccessor(0); |
| 3029 | BasicBlock *QFB = QBI->getSuccessor(1); |
| 3030 | BasicBlock *PostBB = QFB->getSingleSuccessor(); |
| 3031 | |
| 3032 | bool InvertPCond = false, InvertQCond = false; |
| 3033 | // Canonicalize fallthroughs to the true branches. |
| 3034 | if (PFB == QBI->getParent()) { |
| 3035 | std::swap(PFB, PTB); |
| 3036 | InvertPCond = true; |
| 3037 | } |
| 3038 | if (QFB == PostBB) { |
| 3039 | std::swap(QFB, QTB); |
| 3040 | InvertQCond = true; |
| 3041 | } |
| 3042 | |
| 3043 | // From this point on we can assume PTB or QTB may be fallthroughs but PFB |
| 3044 | // and QFB may not. Model fallthroughs as a nullptr block. |
| 3045 | if (PTB == QBI->getParent()) |
| 3046 | PTB = nullptr; |
| 3047 | if (QTB == PostBB) |
| 3048 | QTB = nullptr; |
| 3049 | |
| 3050 | // Legality bailouts. We must have at least the non-fallthrough blocks and |
| 3051 | // the post-dominating block, and the non-fallthroughs must only have one |
| 3052 | // predecessor. |
| 3053 | auto HasOnePredAndOneSucc = [](BasicBlock *BB, BasicBlock *P, BasicBlock *S) { |
Dehao Chen | f6c0083 | 2016-05-18 19:44:21 +0000 | [diff] [blame] | 3054 | return BB->getSinglePredecessor() == P && BB->getSingleSuccessor() == S; |
James Molloy | 4de84dd | 2015-11-04 15:28:04 +0000 | [diff] [blame] | 3055 | }; |
| 3056 | if (!PostBB || |
| 3057 | !HasOnePredAndOneSucc(PFB, PBI->getParent(), QBI->getParent()) || |
| 3058 | !HasOnePredAndOneSucc(QFB, QBI->getParent(), PostBB)) |
| 3059 | return false; |
| 3060 | if ((PTB && !HasOnePredAndOneSucc(PTB, PBI->getParent(), QBI->getParent())) || |
| 3061 | (QTB && !HasOnePredAndOneSucc(QTB, QBI->getParent(), PostBB))) |
| 3062 | return false; |
| 3063 | if (PostBB->getNumUses() != 2 || QBI->getParent()->getNumUses() != 2) |
| 3064 | return false; |
| 3065 | |
| 3066 | // OK, this is a sequence of two diamonds or triangles. |
| 3067 | // Check if there are stores in PTB or PFB that are repeated in QTB or QFB. |
Dehao Chen | f6c0083 | 2016-05-18 19:44:21 +0000 | [diff] [blame] | 3068 | SmallPtrSet<Value *, 4> PStoreAddresses, QStoreAddresses; |
James Molloy | 4de84dd | 2015-11-04 15:28:04 +0000 | [diff] [blame] | 3069 | for (auto *BB : {PTB, PFB}) { |
| 3070 | if (!BB) |
| 3071 | continue; |
| 3072 | for (auto &I : *BB) |
| 3073 | if (StoreInst *SI = dyn_cast<StoreInst>(&I)) |
| 3074 | PStoreAddresses.insert(SI->getPointerOperand()); |
| 3075 | } |
| 3076 | for (auto *BB : {QTB, QFB}) { |
| 3077 | if (!BB) |
| 3078 | continue; |
| 3079 | for (auto &I : *BB) |
| 3080 | if (StoreInst *SI = dyn_cast<StoreInst>(&I)) |
| 3081 | QStoreAddresses.insert(SI->getPointerOperand()); |
| 3082 | } |
Dehao Chen | f6c0083 | 2016-05-18 19:44:21 +0000 | [diff] [blame] | 3083 | |
James Molloy | 4de84dd | 2015-11-04 15:28:04 +0000 | [diff] [blame] | 3084 | set_intersect(PStoreAddresses, QStoreAddresses); |
| 3085 | // set_intersect mutates PStoreAddresses in place. Rename it here to make it |
| 3086 | // clear what it contains. |
| 3087 | auto &CommonAddresses = PStoreAddresses; |
| 3088 | |
| 3089 | bool Changed = false; |
| 3090 | for (auto *Address : CommonAddresses) |
| 3091 | Changed |= mergeConditionalStoreToAddress( |
| 3092 | PTB, PFB, QTB, QFB, PostBB, Address, InvertPCond, InvertQCond); |
| 3093 | return Changed; |
| 3094 | } |
| 3095 | |
Sanjay Patel | 09159b8f | 2015-06-24 20:40:57 +0000 | [diff] [blame] | 3096 | /// If we have a conditional branch as a predecessor of another block, |
| 3097 | /// this function tries to simplify it. We know |
Chris Lattner | 9aada1d | 2008-07-13 21:53:26 +0000 | [diff] [blame] | 3098 | /// that PBI and BI are both conditional branches, and BI is in one of the |
| 3099 | /// successor blocks of PBI - PBI branches to BI. |
Philip Reames | b42db21 | 2015-10-14 22:46:19 +0000 | [diff] [blame] | 3100 | static bool SimplifyCondBranchToCondBranch(BranchInst *PBI, BranchInst *BI, |
| 3101 | const DataLayout &DL) { |
Chris Lattner | 9aada1d | 2008-07-13 21:53:26 +0000 | [diff] [blame] | 3102 | assert(PBI->isConditional() && BI->isConditional()); |
| 3103 | BasicBlock *BB = BI->getParent(); |
Dan Gohman | 5476cfd | 2009-08-12 16:23:25 +0000 | [diff] [blame] | 3104 | |
Chris Lattner | 9aada1d | 2008-07-13 21:53:26 +0000 | [diff] [blame] | 3105 | // If this block ends with a branch instruction, and if there is a |
Andrew Trick | f3cf193 | 2012-08-29 21:46:36 +0000 | [diff] [blame] | 3106 | // predecessor that ends on a branch of the same condition, make |
Chris Lattner | 9aada1d | 2008-07-13 21:53:26 +0000 | [diff] [blame] | 3107 | // this conditional branch redundant. |
| 3108 | if (PBI->getCondition() == BI->getCondition() && |
| 3109 | PBI->getSuccessor(0) != PBI->getSuccessor(1)) { |
| 3110 | // Okay, the outcome of this conditional branch is statically |
| 3111 | // knowable. If this block had a single pred, handle specially. |
| 3112 | if (BB->getSinglePredecessor()) { |
| 3113 | // Turn this into a branch on constant. |
| 3114 | bool CondIsTrue = PBI->getSuccessor(0) == BB; |
Dehao Chen | f6c0083 | 2016-05-18 19:44:21 +0000 | [diff] [blame] | 3115 | BI->setCondition( |
| 3116 | ConstantInt::get(Type::getInt1Ty(BB->getContext()), CondIsTrue)); |
| 3117 | return true; // Nuke the branch on constant. |
Chris Lattner | 9aada1d | 2008-07-13 21:53:26 +0000 | [diff] [blame] | 3118 | } |
Andrew Trick | f3cf193 | 2012-08-29 21:46:36 +0000 | [diff] [blame] | 3119 | |
Chris Lattner | 9aada1d | 2008-07-13 21:53:26 +0000 | [diff] [blame] | 3120 | // Otherwise, if there are multiple predecessors, insert a PHI that merges |
| 3121 | // in the constant and simplify the block result. Subsequent passes of |
| 3122 | // simplifycfg will thread the block. |
| 3123 | if (BlockIsSimpleEnoughToThreadThrough(BB)) { |
Jay Foad | e0938d8 | 2011-03-30 11:19:20 +0000 | [diff] [blame] | 3124 | pred_iterator PB = pred_begin(BB), PE = pred_end(BB); |
Duncan P. N. Exon Smith | 5b4c837 | 2015-10-13 02:39:05 +0000 | [diff] [blame] | 3125 | PHINode *NewPN = PHINode::Create( |
| 3126 | Type::getInt1Ty(BB->getContext()), std::distance(PB, PE), |
| 3127 | BI->getCondition()->getName() + ".pr", &BB->front()); |
Chris Lattner | 5eed372 | 2008-07-13 21:55:46 +0000 | [diff] [blame] | 3128 | // Okay, we're going to insert the PHI node. Since PBI is not the only |
| 3129 | // predecessor, compute the PHI'd conditional value for all of the preds. |
| 3130 | // Any predecessor where the condition is not computable we keep symbolic. |
Jay Foad | e0938d8 | 2011-03-30 11:19:20 +0000 | [diff] [blame] | 3131 | for (pred_iterator PI = PB; PI != PE; ++PI) { |
Gabor Greif | 8629f12 | 2010-07-12 10:59:23 +0000 | [diff] [blame] | 3132 | BasicBlock *P = *PI; |
Dehao Chen | f6c0083 | 2016-05-18 19:44:21 +0000 | [diff] [blame] | 3133 | if ((PBI = dyn_cast<BranchInst>(P->getTerminator())) && PBI != BI && |
| 3134 | PBI->isConditional() && PBI->getCondition() == BI->getCondition() && |
Chris Lattner | 9aada1d | 2008-07-13 21:53:26 +0000 | [diff] [blame] | 3135 | PBI->getSuccessor(0) != PBI->getSuccessor(1)) { |
| 3136 | bool CondIsTrue = PBI->getSuccessor(0) == BB; |
Dehao Chen | f6c0083 | 2016-05-18 19:44:21 +0000 | [diff] [blame] | 3137 | NewPN->addIncoming( |
| 3138 | ConstantInt::get(Type::getInt1Ty(BB->getContext()), CondIsTrue), |
| 3139 | P); |
Chris Lattner | 9aada1d | 2008-07-13 21:53:26 +0000 | [diff] [blame] | 3140 | } else { |
Gabor Greif | 8629f12 | 2010-07-12 10:59:23 +0000 | [diff] [blame] | 3141 | NewPN->addIncoming(BI->getCondition(), P); |
Chris Lattner | 9aada1d | 2008-07-13 21:53:26 +0000 | [diff] [blame] | 3142 | } |
Gabor Greif | 8629f12 | 2010-07-12 10:59:23 +0000 | [diff] [blame] | 3143 | } |
Andrew Trick | f3cf193 | 2012-08-29 21:46:36 +0000 | [diff] [blame] | 3144 | |
Chris Lattner | 9aada1d | 2008-07-13 21:53:26 +0000 | [diff] [blame] | 3145 | BI->setCondition(NewPN); |
Chris Lattner | 9aada1d | 2008-07-13 21:53:26 +0000 | [diff] [blame] | 3146 | return true; |
| 3147 | } |
| 3148 | } |
Andrew Trick | f3cf193 | 2012-08-29 21:46:36 +0000 | [diff] [blame] | 3149 | |
Philip Reames | b42db21 | 2015-10-14 22:46:19 +0000 | [diff] [blame] | 3150 | if (auto *CE = dyn_cast<ConstantExpr>(BI->getCondition())) |
| 3151 | if (CE->canTrap()) |
| 3152 | return false; |
| 3153 | |
James Molloy | 4de84dd | 2015-11-04 15:28:04 +0000 | [diff] [blame] | 3154 | // If both branches are conditional and both contain stores to the same |
| 3155 | // address, remove the stores from the conditionals and create a conditional |
| 3156 | // merged store at the end. |
| 3157 | if (MergeCondStores && mergeConditionalStores(PBI, BI)) |
| 3158 | return true; |
| 3159 | |
Chris Lattner | 9aada1d | 2008-07-13 21:53:26 +0000 | [diff] [blame] | 3160 | // If this is a conditional branch in an empty block, and if any |
Sanjay Patel | 0a2ada7 | 2014-07-06 23:10:24 +0000 | [diff] [blame] | 3161 | // predecessors are a conditional branch to one of our destinations, |
Chris Lattner | 9aada1d | 2008-07-13 21:53:26 +0000 | [diff] [blame] | 3162 | // fold the conditions into logical ops and one cond br. |
Zhou Sheng | 264e46e | 2009-02-26 06:56:37 +0000 | [diff] [blame] | 3163 | BasicBlock::iterator BBI = BB->begin(); |
| 3164 | // Ignore dbg intrinsics. |
| 3165 | while (isa<DbgInfoIntrinsic>(BBI)) |
| 3166 | ++BBI; |
| 3167 | if (&*BBI != BI) |
Chris Lattner | 834ab4e | 2008-07-13 22:04:41 +0000 | [diff] [blame] | 3168 | return false; |
Chris Lattner | c59945b | 2009-01-20 01:15:41 +0000 | [diff] [blame] | 3169 | |
Chris Lattner | 834ab4e | 2008-07-13 22:04:41 +0000 | [diff] [blame] | 3170 | int PBIOp, BIOp; |
Richard Trieu | 7a08381 | 2016-02-18 22:09:30 +0000 | [diff] [blame] | 3171 | if (PBI->getSuccessor(0) == BI->getSuccessor(0)) { |
| 3172 | PBIOp = 0; |
| 3173 | BIOp = 0; |
| 3174 | } else if (PBI->getSuccessor(0) == BI->getSuccessor(1)) { |
| 3175 | PBIOp = 0; |
| 3176 | BIOp = 1; |
| 3177 | } else if (PBI->getSuccessor(1) == BI->getSuccessor(0)) { |
| 3178 | PBIOp = 1; |
| 3179 | BIOp = 0; |
| 3180 | } else if (PBI->getSuccessor(1) == BI->getSuccessor(1)) { |
| 3181 | PBIOp = 1; |
| 3182 | BIOp = 1; |
| 3183 | } else { |
Chris Lattner | 834ab4e | 2008-07-13 22:04:41 +0000 | [diff] [blame] | 3184 | return false; |
Richard Trieu | 7a08381 | 2016-02-18 22:09:30 +0000 | [diff] [blame] | 3185 | } |
Andrew Trick | f3cf193 | 2012-08-29 21:46:36 +0000 | [diff] [blame] | 3186 | |
Chris Lattner | 834ab4e | 2008-07-13 22:04:41 +0000 | [diff] [blame] | 3187 | // Check to make sure that the other destination of this branch |
| 3188 | // isn't BB itself. If so, this is an infinite loop that will |
| 3189 | // keep getting unwound. |
| 3190 | if (PBI->getSuccessor(PBIOp) == BB) |
| 3191 | return false; |
Andrew Trick | f3cf193 | 2012-08-29 21:46:36 +0000 | [diff] [blame] | 3192 | |
| 3193 | // Do not perform this transformation if it would require |
Chris Lattner | 834ab4e | 2008-07-13 22:04:41 +0000 | [diff] [blame] | 3194 | // insertion of a large number of select instructions. For targets |
| 3195 | // without predication/cmovs, this is a big pessimization. |
Andrew Trick | f3cf193 | 2012-08-29 21:46:36 +0000 | [diff] [blame] | 3196 | |
Sanjay Patel | a932da8 | 2014-07-07 21:19:00 +0000 | [diff] [blame] | 3197 | // Also do not perform this transformation if any phi node in the common |
| 3198 | // destination block can trap when reached by BB or PBB (PR17073). In that |
| 3199 | // case, it would be unsafe to hoist the operation into a select instruction. |
| 3200 | |
| 3201 | BasicBlock *CommonDest = PBI->getSuccessor(PBIOp); |
Chris Lattner | 834ab4e | 2008-07-13 22:04:41 +0000 | [diff] [blame] | 3202 | unsigned NumPhis = 0; |
Dehao Chen | f6c0083 | 2016-05-18 19:44:21 +0000 | [diff] [blame] | 3203 | for (BasicBlock::iterator II = CommonDest->begin(); isa<PHINode>(II); |
| 3204 | ++II, ++NumPhis) { |
Chris Lattner | 834ab4e | 2008-07-13 22:04:41 +0000 | [diff] [blame] | 3205 | if (NumPhis > 2) // Disable this xform. |
| 3206 | return false; |
Andrew Trick | f3cf193 | 2012-08-29 21:46:36 +0000 | [diff] [blame] | 3207 | |
Sanjay Patel | a932da8 | 2014-07-07 21:19:00 +0000 | [diff] [blame] | 3208 | PHINode *PN = cast<PHINode>(II); |
| 3209 | Value *BIV = PN->getIncomingValueForBlock(BB); |
| 3210 | if (ConstantExpr *CE = dyn_cast<ConstantExpr>(BIV)) |
| 3211 | if (CE->canTrap()) |
| 3212 | return false; |
| 3213 | |
| 3214 | unsigned PBBIdx = PN->getBasicBlockIndex(PBI->getParent()); |
| 3215 | Value *PBIV = PN->getIncomingValue(PBBIdx); |
| 3216 | if (ConstantExpr *CE = dyn_cast<ConstantExpr>(PBIV)) |
| 3217 | if (CE->canTrap()) |
| 3218 | return false; |
| 3219 | } |
| 3220 | |
Chris Lattner | 834ab4e | 2008-07-13 22:04:41 +0000 | [diff] [blame] | 3221 | // Finally, if everything is ok, fold the branches to logical ops. |
Sanjay Patel | a932da8 | 2014-07-07 21:19:00 +0000 | [diff] [blame] | 3222 | BasicBlock *OtherDest = BI->getSuccessor(BIOp ^ 1); |
Andrew Trick | f3cf193 | 2012-08-29 21:46:36 +0000 | [diff] [blame] | 3223 | |
David Greene | 725c7c3 | 2010-01-05 01:26:52 +0000 | [diff] [blame] | 3224 | DEBUG(dbgs() << "FOLDING BRs:" << *PBI->getParent() |
Chris Lattner | b25de3f | 2009-08-23 04:37:46 +0000 | [diff] [blame] | 3225 | << "AND: " << *BI->getParent()); |
Andrew Trick | f3cf193 | 2012-08-29 21:46:36 +0000 | [diff] [blame] | 3226 | |
Chris Lattner | 80b03a1 | 2008-07-13 22:23:11 +0000 | [diff] [blame] | 3227 | // If OtherDest *is* BB, then BB is a basic block with a single conditional |
| 3228 | // branch in it, where one edge (OtherDest) goes back to itself but the other |
| 3229 | // exits. We don't *know* that the program avoids the infinite loop |
| 3230 | // (even though that seems likely). If we do this xform naively, we'll end up |
| 3231 | // recursively unpeeling the loop. Since we know that (after the xform is |
| 3232 | // done) that the block *is* infinite if reached, we just make it an obviously |
| 3233 | // infinite loop with no cond branch. |
| 3234 | if (OtherDest == BB) { |
| 3235 | // Insert it at the end of the function, because it's either code, |
| 3236 | // or it won't matter if it's hot. :) |
Dehao Chen | f6c0083 | 2016-05-18 19:44:21 +0000 | [diff] [blame] | 3237 | BasicBlock *InfLoopBlock = |
| 3238 | BasicBlock::Create(BB->getContext(), "infloop", BB->getParent()); |
Chris Lattner | 80b03a1 | 2008-07-13 22:23:11 +0000 | [diff] [blame] | 3239 | BranchInst::Create(InfLoopBlock, InfLoopBlock); |
| 3240 | OtherDest = InfLoopBlock; |
Andrew Trick | f3cf193 | 2012-08-29 21:46:36 +0000 | [diff] [blame] | 3241 | } |
| 3242 | |
David Greene | 725c7c3 | 2010-01-05 01:26:52 +0000 | [diff] [blame] | 3243 | DEBUG(dbgs() << *PBI->getParent()->getParent()); |
Devang Patel | 1407fb4 | 2011-05-19 20:52:46 +0000 | [diff] [blame] | 3244 | |
Chris Lattner | 834ab4e | 2008-07-13 22:04:41 +0000 | [diff] [blame] | 3245 | // BI may have other predecessors. Because of this, we leave |
| 3246 | // it alone, but modify PBI. |
Andrew Trick | f3cf193 | 2012-08-29 21:46:36 +0000 | [diff] [blame] | 3247 | |
Chris Lattner | 834ab4e | 2008-07-13 22:04:41 +0000 | [diff] [blame] | 3248 | // Make sure we get to CommonDest on True&True directions. |
| 3249 | Value *PBICond = PBI->getCondition(); |
Mehdi Amini | ba9fba8 | 2016-03-13 21:05:13 +0000 | [diff] [blame] | 3250 | IRBuilder<NoFolder> Builder(PBI); |
Chris Lattner | 834ab4e | 2008-07-13 22:04:41 +0000 | [diff] [blame] | 3251 | if (PBIOp) |
Dehao Chen | f6c0083 | 2016-05-18 19:44:21 +0000 | [diff] [blame] | 3252 | PBICond = Builder.CreateNot(PBICond, PBICond->getName() + ".not"); |
Devang Patel | 1407fb4 | 2011-05-19 20:52:46 +0000 | [diff] [blame] | 3253 | |
Chris Lattner | 834ab4e | 2008-07-13 22:04:41 +0000 | [diff] [blame] | 3254 | Value *BICond = BI->getCondition(); |
| 3255 | if (BIOp) |
Dehao Chen | f6c0083 | 2016-05-18 19:44:21 +0000 | [diff] [blame] | 3256 | BICond = Builder.CreateNot(BICond, BICond->getName() + ".not"); |
Devang Patel | 1407fb4 | 2011-05-19 20:52:46 +0000 | [diff] [blame] | 3257 | |
Chris Lattner | 834ab4e | 2008-07-13 22:04:41 +0000 | [diff] [blame] | 3258 | // Merge the conditions. |
Devang Patel | 1407fb4 | 2011-05-19 20:52:46 +0000 | [diff] [blame] | 3259 | Value *Cond = Builder.CreateOr(PBICond, BICond, "brmerge"); |
Andrew Trick | f3cf193 | 2012-08-29 21:46:36 +0000 | [diff] [blame] | 3260 | |
Chris Lattner | 834ab4e | 2008-07-13 22:04:41 +0000 | [diff] [blame] | 3261 | // Modify PBI to branch on the new condition to the new dests. |
| 3262 | PBI->setCondition(Cond); |
| 3263 | PBI->setSuccessor(0, CommonDest); |
| 3264 | PBI->setSuccessor(1, OtherDest); |
Andrew Trick | f3cf193 | 2012-08-29 21:46:36 +0000 | [diff] [blame] | 3265 | |
Manman Ren | 2d4c10f | 2012-09-17 21:30:40 +0000 | [diff] [blame] | 3266 | // Update branch weight for PBI. |
| 3267 | uint64_t PredTrueWeight, PredFalseWeight, SuccTrueWeight, SuccFalseWeight; |
Dehao Chen | b76e5d9 | 2016-05-10 23:07:19 +0000 | [diff] [blame] | 3268 | uint64_t PredCommon, PredOther, SuccCommon, SuccOther; |
Dehao Chen | f16376b | 2016-05-18 22:41:03 +0000 | [diff] [blame] | 3269 | bool HasWeights = |
| 3270 | extractPredSuccWeights(PBI, BI, PredTrueWeight, PredFalseWeight, |
| 3271 | SuccTrueWeight, SuccFalseWeight); |
Dehao Chen | b76e5d9 | 2016-05-10 23:07:19 +0000 | [diff] [blame] | 3272 | if (HasWeights) { |
Dehao Chen | b76e5d9 | 2016-05-10 23:07:19 +0000 | [diff] [blame] | 3273 | PredCommon = PBIOp ? PredFalseWeight : PredTrueWeight; |
| 3274 | PredOther = PBIOp ? PredTrueWeight : PredFalseWeight; |
| 3275 | SuccCommon = BIOp ? SuccFalseWeight : SuccTrueWeight; |
| 3276 | SuccOther = BIOp ? SuccTrueWeight : SuccFalseWeight; |
Manman Ren | 2d4c10f | 2012-09-17 21:30:40 +0000 | [diff] [blame] | 3277 | // The weight to CommonDest should be PredCommon * SuccTotal + |
| 3278 | // PredOther * SuccCommon. |
| 3279 | // The weight to OtherDest should be PredOther * SuccOther. |
Benjamin Kramer | ea68a94 | 2015-02-19 15:26:17 +0000 | [diff] [blame] | 3280 | uint64_t NewWeights[2] = {PredCommon * (SuccCommon + SuccOther) + |
| 3281 | PredOther * SuccCommon, |
| 3282 | PredOther * SuccOther}; |
Sanjay Patel | 84a0bf6 | 2016-05-06 17:51:37 +0000 | [diff] [blame] | 3283 | // Halve the weights if any of them cannot fit in an uint32_t |
Manman Ren | 2d4c10f | 2012-09-17 21:30:40 +0000 | [diff] [blame] | 3284 | FitWeights(NewWeights); |
| 3285 | |
Manman Ren | 2d4c10f | 2012-09-17 21:30:40 +0000 | [diff] [blame] | 3286 | PBI->setMetadata(LLVMContext::MD_prof, |
Sanjay Patel | 84a0bf6 | 2016-05-06 17:51:37 +0000 | [diff] [blame] | 3287 | MDBuilder(BI->getContext()) |
| 3288 | .createBranchWeights(NewWeights[0], NewWeights[1])); |
Manman Ren | 2d4c10f | 2012-09-17 21:30:40 +0000 | [diff] [blame] | 3289 | } |
| 3290 | |
Chris Lattner | 834ab4e | 2008-07-13 22:04:41 +0000 | [diff] [blame] | 3291 | // OtherDest may have phi nodes. If so, add an entry from PBI's |
| 3292 | // block that are identical to the entries for BI's block. |
Chris Lattner | 0f4d67b | 2010-12-14 07:09:42 +0000 | [diff] [blame] | 3293 | AddPredecessorToBlock(OtherDest, PBI->getParent(), BB); |
Andrew Trick | f3cf193 | 2012-08-29 21:46:36 +0000 | [diff] [blame] | 3294 | |
Chris Lattner | 834ab4e | 2008-07-13 22:04:41 +0000 | [diff] [blame] | 3295 | // We know that the CommonDest already had an edge from PBI to |
| 3296 | // it. If it has PHIs though, the PHIs may have different |
| 3297 | // entries for BB and PBI's BB. If so, insert a select to make |
| 3298 | // them agree. |
Chris Lattner | 0f4d67b | 2010-12-14 07:09:42 +0000 | [diff] [blame] | 3299 | PHINode *PN; |
Chris Lattner | 834ab4e | 2008-07-13 22:04:41 +0000 | [diff] [blame] | 3300 | for (BasicBlock::iterator II = CommonDest->begin(); |
| 3301 | (PN = dyn_cast<PHINode>(II)); ++II) { |
| 3302 | Value *BIV = PN->getIncomingValueForBlock(BB); |
| 3303 | unsigned PBBIdx = PN->getBasicBlockIndex(PBI->getParent()); |
| 3304 | Value *PBIV = PN->getIncomingValue(PBBIdx); |
| 3305 | if (BIV != PBIV) { |
| 3306 | // Insert a select in PBI to pick the right value. |
Dehao Chen | f6c0083 | 2016-05-18 19:44:21 +0000 | [diff] [blame] | 3307 | SelectInst *NV = cast<SelectInst>( |
| 3308 | Builder.CreateSelect(PBICond, PBIV, BIV, PBIV->getName() + ".mux")); |
Chris Lattner | 834ab4e | 2008-07-13 22:04:41 +0000 | [diff] [blame] | 3309 | PN->setIncomingValue(PBBIdx, NV); |
Sanjay Patel | 1cb6241 | 2016-05-06 18:07:46 +0000 | [diff] [blame] | 3310 | // Although the select has the same condition as PBI, the original branch |
| 3311 | // weights for PBI do not apply to the new select because the select's |
| 3312 | // 'logical' edges are incoming edges of the phi that is eliminated, not |
| 3313 | // the outgoing edges of PBI. |
Dehao Chen | f16376b | 2016-05-18 22:41:03 +0000 | [diff] [blame] | 3314 | if (HasWeights) { |
Sanjay Patel | 1cb6241 | 2016-05-06 18:07:46 +0000 | [diff] [blame] | 3315 | uint64_t PredCommon = PBIOp ? PredFalseWeight : PredTrueWeight; |
| 3316 | uint64_t PredOther = PBIOp ? PredTrueWeight : PredFalseWeight; |
| 3317 | uint64_t SuccCommon = BIOp ? SuccFalseWeight : SuccTrueWeight; |
| 3318 | uint64_t SuccOther = BIOp ? SuccTrueWeight : SuccFalseWeight; |
| 3319 | // The weight to PredCommonDest should be PredCommon * SuccTotal. |
| 3320 | // The weight to PredOtherDest should be PredOther * SuccCommon. |
| 3321 | uint64_t NewWeights[2] = {PredCommon * (SuccCommon + SuccOther), |
| 3322 | PredOther * SuccCommon}; |
| 3323 | |
| 3324 | FitWeights(NewWeights); |
| 3325 | |
| 3326 | NV->setMetadata(LLVMContext::MD_prof, |
| 3327 | MDBuilder(BI->getContext()) |
| 3328 | .createBranchWeights(NewWeights[0], NewWeights[1])); |
| 3329 | } |
Chris Lattner | 9aada1d | 2008-07-13 21:53:26 +0000 | [diff] [blame] | 3330 | } |
| 3331 | } |
Andrew Trick | f3cf193 | 2012-08-29 21:46:36 +0000 | [diff] [blame] | 3332 | |
David Greene | 725c7c3 | 2010-01-05 01:26:52 +0000 | [diff] [blame] | 3333 | DEBUG(dbgs() << "INTO: " << *PBI->getParent()); |
| 3334 | DEBUG(dbgs() << *PBI->getParent()->getParent()); |
Andrew Trick | f3cf193 | 2012-08-29 21:46:36 +0000 | [diff] [blame] | 3335 | |
Chris Lattner | 834ab4e | 2008-07-13 22:04:41 +0000 | [diff] [blame] | 3336 | // This basic block is probably dead. We know it has at least |
| 3337 | // one fewer predecessor. |
| 3338 | return true; |
Chris Lattner | 9aada1d | 2008-07-13 21:53:26 +0000 | [diff] [blame] | 3339 | } |
| 3340 | |
Sanjay Patel | 09159b8f | 2015-06-24 20:40:57 +0000 | [diff] [blame] | 3341 | // Simplifies a terminator by replacing it with a branch to TrueBB if Cond is |
| 3342 | // true or to FalseBB if Cond is false. |
Frits van Bommel | 8e15849 | 2011-01-11 12:52:11 +0000 | [diff] [blame] | 3343 | // Takes care of updating the successors and removing the old terminator. |
| 3344 | // Also makes sure not to introduce new successors by assuming that edges to |
| 3345 | // non-successor TrueBBs and FalseBBs aren't reachable. |
| 3346 | static bool SimplifyTerminatorOnSelect(TerminatorInst *OldTerm, Value *Cond, |
Manman Ren | 774246a | 2012-09-17 22:28:55 +0000 | [diff] [blame] | 3347 | BasicBlock *TrueBB, BasicBlock *FalseBB, |
| 3348 | uint32_t TrueWeight, |
Dehao Chen | f6c0083 | 2016-05-18 19:44:21 +0000 | [diff] [blame] | 3349 | uint32_t FalseWeight) { |
Frits van Bommel | 8e15849 | 2011-01-11 12:52:11 +0000 | [diff] [blame] | 3350 | // Remove any superfluous successor edges from the CFG. |
| 3351 | // First, figure out which successors to preserve. |
| 3352 | // If TrueBB and FalseBB are equal, only try to preserve one copy of that |
| 3353 | // successor. |
| 3354 | BasicBlock *KeepEdge1 = TrueBB; |
Craig Topper | f40110f | 2014-04-25 05:29:35 +0000 | [diff] [blame] | 3355 | BasicBlock *KeepEdge2 = TrueBB != FalseBB ? FalseBB : nullptr; |
Frits van Bommel | 8e15849 | 2011-01-11 12:52:11 +0000 | [diff] [blame] | 3356 | |
| 3357 | // Then remove the rest. |
Pete Cooper | ebcd748 | 2015-08-06 20:22:46 +0000 | [diff] [blame] | 3358 | for (BasicBlock *Succ : OldTerm->successors()) { |
Frits van Bommel | 8e15849 | 2011-01-11 12:52:11 +0000 | [diff] [blame] | 3359 | // Make sure only to keep exactly one copy of each edge. |
| 3360 | if (Succ == KeepEdge1) |
Craig Topper | f40110f | 2014-04-25 05:29:35 +0000 | [diff] [blame] | 3361 | KeepEdge1 = nullptr; |
Frits van Bommel | 8e15849 | 2011-01-11 12:52:11 +0000 | [diff] [blame] | 3362 | else if (Succ == KeepEdge2) |
Craig Topper | f40110f | 2014-04-25 05:29:35 +0000 | [diff] [blame] | 3363 | KeepEdge2 = nullptr; |
Frits van Bommel | 8e15849 | 2011-01-11 12:52:11 +0000 | [diff] [blame] | 3364 | else |
David Majnemer | dc3b67b | 2015-10-21 18:22:24 +0000 | [diff] [blame] | 3365 | Succ->removePredecessor(OldTerm->getParent(), |
| 3366 | /*DontDeleteUselessPHIs=*/true); |
Frits van Bommel | 8e15849 | 2011-01-11 12:52:11 +0000 | [diff] [blame] | 3367 | } |
| 3368 | |
Devang Patel | 2c2ea22 | 2011-05-18 18:43:31 +0000 | [diff] [blame] | 3369 | IRBuilder<> Builder(OldTerm); |
| 3370 | Builder.SetCurrentDebugLocation(OldTerm->getDebugLoc()); |
| 3371 | |
Frits van Bommel | 8e15849 | 2011-01-11 12:52:11 +0000 | [diff] [blame] | 3372 | // Insert an appropriate new terminator. |
Craig Topper | f40110f | 2014-04-25 05:29:35 +0000 | [diff] [blame] | 3373 | if (!KeepEdge1 && !KeepEdge2) { |
Frits van Bommel | 8e15849 | 2011-01-11 12:52:11 +0000 | [diff] [blame] | 3374 | if (TrueBB == FalseBB) |
| 3375 | // We were only looking for one successor, and it was present. |
| 3376 | // Create an unconditional branch to it. |
Devang Patel | 2c2ea22 | 2011-05-18 18:43:31 +0000 | [diff] [blame] | 3377 | Builder.CreateBr(TrueBB); |
Manman Ren | 774246a | 2012-09-17 22:28:55 +0000 | [diff] [blame] | 3378 | else { |
Frits van Bommel | 8e15849 | 2011-01-11 12:52:11 +0000 | [diff] [blame] | 3379 | // We found both of the successors we were looking for. |
| 3380 | // Create a conditional branch sharing the condition of the select. |
Manman Ren | 774246a | 2012-09-17 22:28:55 +0000 | [diff] [blame] | 3381 | BranchInst *NewBI = Builder.CreateCondBr(Cond, TrueBB, FalseBB); |
| 3382 | if (TrueWeight != FalseWeight) |
| 3383 | NewBI->setMetadata(LLVMContext::MD_prof, |
Dehao Chen | f6c0083 | 2016-05-18 19:44:21 +0000 | [diff] [blame] | 3384 | MDBuilder(OldTerm->getContext()) |
| 3385 | .createBranchWeights(TrueWeight, FalseWeight)); |
Manman Ren | 774246a | 2012-09-17 22:28:55 +0000 | [diff] [blame] | 3386 | } |
Frits van Bommel | 8e15849 | 2011-01-11 12:52:11 +0000 | [diff] [blame] | 3387 | } else if (KeepEdge1 && (KeepEdge2 || TrueBB == FalseBB)) { |
| 3388 | // Neither of the selected blocks were successors, so this |
| 3389 | // terminator must be unreachable. |
| 3390 | new UnreachableInst(OldTerm->getContext(), OldTerm); |
| 3391 | } else { |
| 3392 | // One of the selected values was a successor, but the other wasn't. |
| 3393 | // Insert an unconditional branch to the one that was found; |
| 3394 | // the edge to the one that wasn't must be unreachable. |
Craig Topper | f40110f | 2014-04-25 05:29:35 +0000 | [diff] [blame] | 3395 | if (!KeepEdge1) |
Frits van Bommel | 8e15849 | 2011-01-11 12:52:11 +0000 | [diff] [blame] | 3396 | // Only TrueBB was found. |
Devang Patel | 2c2ea22 | 2011-05-18 18:43:31 +0000 | [diff] [blame] | 3397 | Builder.CreateBr(TrueBB); |
Frits van Bommel | 8e15849 | 2011-01-11 12:52:11 +0000 | [diff] [blame] | 3398 | else |
| 3399 | // Only FalseBB was found. |
Devang Patel | 2c2ea22 | 2011-05-18 18:43:31 +0000 | [diff] [blame] | 3400 | Builder.CreateBr(FalseBB); |
Frits van Bommel | 8e15849 | 2011-01-11 12:52:11 +0000 | [diff] [blame] | 3401 | } |
| 3402 | |
| 3403 | EraseTerminatorInstAndDCECond(OldTerm); |
| 3404 | return true; |
| 3405 | } |
| 3406 | |
Sanjay Patel | 09159b8f | 2015-06-24 20:40:57 +0000 | [diff] [blame] | 3407 | // Replaces |
Frits van Bommel | 8ae0799 | 2011-02-28 09:44:07 +0000 | [diff] [blame] | 3408 | // (switch (select cond, X, Y)) on constant X, Y |
| 3409 | // with a branch - conditional if X and Y lead to distinct BBs, |
| 3410 | // unconditional otherwise. |
| 3411 | static bool SimplifySwitchOnSelect(SwitchInst *SI, SelectInst *Select) { |
| 3412 | // Check for constant integer values in the select. |
| 3413 | ConstantInt *TrueVal = dyn_cast<ConstantInt>(Select->getTrueValue()); |
| 3414 | ConstantInt *FalseVal = dyn_cast<ConstantInt>(Select->getFalseValue()); |
| 3415 | if (!TrueVal || !FalseVal) |
| 3416 | return false; |
| 3417 | |
| 3418 | // Find the relevant condition and destinations. |
| 3419 | Value *Condition = Select->getCondition(); |
Stepan Dyatkovskiy | 5b648af | 2012-03-08 07:06:20 +0000 | [diff] [blame] | 3420 | BasicBlock *TrueBB = SI->findCaseValue(TrueVal).getCaseSuccessor(); |
| 3421 | BasicBlock *FalseBB = SI->findCaseValue(FalseVal).getCaseSuccessor(); |
Frits van Bommel | 8ae0799 | 2011-02-28 09:44:07 +0000 | [diff] [blame] | 3422 | |
Manman Ren | 774246a | 2012-09-17 22:28:55 +0000 | [diff] [blame] | 3423 | // Get weight for TrueBB and FalseBB. |
| 3424 | uint32_t TrueWeight = 0, FalseWeight = 0; |
| 3425 | SmallVector<uint64_t, 8> Weights; |
| 3426 | bool HasWeights = HasBranchWeights(SI); |
| 3427 | if (HasWeights) { |
| 3428 | GetBranchWeights(SI, Weights); |
| 3429 | if (Weights.size() == 1 + SI->getNumCases()) { |
Dehao Chen | f6c0083 | 2016-05-18 19:44:21 +0000 | [diff] [blame] | 3430 | TrueWeight = |
| 3431 | (uint32_t)Weights[SI->findCaseValue(TrueVal).getSuccessorIndex()]; |
| 3432 | FalseWeight = |
| 3433 | (uint32_t)Weights[SI->findCaseValue(FalseVal).getSuccessorIndex()]; |
Manman Ren | 774246a | 2012-09-17 22:28:55 +0000 | [diff] [blame] | 3434 | } |
| 3435 | } |
| 3436 | |
Frits van Bommel | 8ae0799 | 2011-02-28 09:44:07 +0000 | [diff] [blame] | 3437 | // Perform the actual simplification. |
Dehao Chen | f6c0083 | 2016-05-18 19:44:21 +0000 | [diff] [blame] | 3438 | return SimplifyTerminatorOnSelect(SI, Condition, TrueBB, FalseBB, TrueWeight, |
| 3439 | FalseWeight); |
Frits van Bommel | 8ae0799 | 2011-02-28 09:44:07 +0000 | [diff] [blame] | 3440 | } |
| 3441 | |
Sanjay Patel | 09159b8f | 2015-06-24 20:40:57 +0000 | [diff] [blame] | 3442 | // Replaces |
Frits van Bommel | 8fb69ee | 2010-12-05 18:29:03 +0000 | [diff] [blame] | 3443 | // (indirectbr (select cond, blockaddress(@fn, BlockA), |
| 3444 | // blockaddress(@fn, BlockB))) |
| 3445 | // with |
| 3446 | // (br cond, BlockA, BlockB). |
| 3447 | static bool SimplifyIndirectBrOnSelect(IndirectBrInst *IBI, SelectInst *SI) { |
| 3448 | // Check that both operands of the select are block addresses. |
| 3449 | BlockAddress *TBA = dyn_cast<BlockAddress>(SI->getTrueValue()); |
| 3450 | BlockAddress *FBA = dyn_cast<BlockAddress>(SI->getFalseValue()); |
| 3451 | if (!TBA || !FBA) |
| 3452 | return false; |
| 3453 | |
| 3454 | // Extract the actual blocks. |
| 3455 | BasicBlock *TrueBB = TBA->getBasicBlock(); |
| 3456 | BasicBlock *FalseBB = FBA->getBasicBlock(); |
| 3457 | |
Frits van Bommel | 8e15849 | 2011-01-11 12:52:11 +0000 | [diff] [blame] | 3458 | // Perform the actual simplification. |
Dehao Chen | f6c0083 | 2016-05-18 19:44:21 +0000 | [diff] [blame] | 3459 | return SimplifyTerminatorOnSelect(IBI, SI->getCondition(), TrueBB, FalseBB, 0, |
| 3460 | 0); |
Frits van Bommel | 8fb69ee | 2010-12-05 18:29:03 +0000 | [diff] [blame] | 3461 | } |
| 3462 | |
Sanjay Patel | 09159b8f | 2015-06-24 20:40:57 +0000 | [diff] [blame] | 3463 | /// This is called when we find an icmp instruction |
| 3464 | /// (a seteq/setne with a constant) as the only instruction in a |
Chris Lattner | d9bacc0 | 2010-12-13 03:18:54 +0000 | [diff] [blame] | 3465 | /// block that ends with an uncond branch. We are looking for a very specific |
| 3466 | /// pattern that occurs when "A == 1 || A == 2 || A == 3" gets simplified. In |
| 3467 | /// this case, we merge the first two "or's of icmp" into a switch, but then the |
| 3468 | /// default value goes to an uncond block with a seteq in it, we get something |
| 3469 | /// like: |
| 3470 | /// |
| 3471 | /// switch i8 %A, label %DEFAULT [ i8 1, label %end i8 2, label %end ] |
| 3472 | /// DEFAULT: |
| 3473 | /// %tmp = icmp eq i8 %A, 92 |
| 3474 | /// br label %end |
| 3475 | /// end: |
| 3476 | /// ... = phi i1 [ true, %entry ], [ %tmp, %DEFAULT ], [ true, %entry ] |
Andrew Trick | f3cf193 | 2012-08-29 21:46:36 +0000 | [diff] [blame] | 3477 | /// |
Chris Lattner | d9bacc0 | 2010-12-13 03:18:54 +0000 | [diff] [blame] | 3478 | /// We prefer to split the edge to 'end' so that there is a true/false entry to |
| 3479 | /// the PHI, merging the third icmp into the switch. |
Chandler Carruth | 0b4ef9c | 2013-01-07 03:53:25 +0000 | [diff] [blame] | 3480 | static bool TryToSimplifyUncondBranchWithICmpInIt( |
Mehdi Amini | a28d91d | 2015-03-10 02:37:25 +0000 | [diff] [blame] | 3481 | ICmpInst *ICI, IRBuilder<> &Builder, const DataLayout &DL, |
Hal Finkel | 3ca4a6b | 2016-12-15 03:02:15 +0000 | [diff] [blame] | 3482 | const TargetTransformInfo &TTI, unsigned BonusInstThreshold) { |
Chris Lattner | d9bacc0 | 2010-12-13 03:18:54 +0000 | [diff] [blame] | 3483 | BasicBlock *BB = ICI->getParent(); |
Devang Patel | 767f693 | 2011-05-18 18:28:48 +0000 | [diff] [blame] | 3484 | |
Chris Lattner | d9bacc0 | 2010-12-13 03:18:54 +0000 | [diff] [blame] | 3485 | // If the block has any PHIs in it or the icmp has multiple uses, it is too |
| 3486 | // complex. |
Dehao Chen | f6c0083 | 2016-05-18 19:44:21 +0000 | [diff] [blame] | 3487 | if (isa<PHINode>(BB->begin()) || !ICI->hasOneUse()) |
| 3488 | return false; |
Chris Lattner | d9bacc0 | 2010-12-13 03:18:54 +0000 | [diff] [blame] | 3489 | |
| 3490 | Value *V = ICI->getOperand(0); |
| 3491 | ConstantInt *Cst = cast<ConstantInt>(ICI->getOperand(1)); |
Andrew Trick | f3cf193 | 2012-08-29 21:46:36 +0000 | [diff] [blame] | 3492 | |
Chris Lattner | d9bacc0 | 2010-12-13 03:18:54 +0000 | [diff] [blame] | 3493 | // The pattern we're looking for is where our only predecessor is a switch on |
| 3494 | // 'V' and this block is the default case for the switch. In this case we can |
| 3495 | // fold the compared value into the switch to simplify things. |
| 3496 | BasicBlock *Pred = BB->getSinglePredecessor(); |
Dehao Chen | f6c0083 | 2016-05-18 19:44:21 +0000 | [diff] [blame] | 3497 | if (!Pred || !isa<SwitchInst>(Pred->getTerminator())) |
| 3498 | return false; |
Andrew Trick | f3cf193 | 2012-08-29 21:46:36 +0000 | [diff] [blame] | 3499 | |
Chris Lattner | d9bacc0 | 2010-12-13 03:18:54 +0000 | [diff] [blame] | 3500 | SwitchInst *SI = cast<SwitchInst>(Pred->getTerminator()); |
| 3501 | if (SI->getCondition() != V) |
| 3502 | return false; |
Andrew Trick | f3cf193 | 2012-08-29 21:46:36 +0000 | [diff] [blame] | 3503 | |
Chris Lattner | d9bacc0 | 2010-12-13 03:18:54 +0000 | [diff] [blame] | 3504 | // If BB is reachable on a non-default case, then we simply know the value of |
| 3505 | // V in this block. Substitute it and constant fold the icmp instruction |
| 3506 | // away. |
| 3507 | if (SI->getDefaultDest() != BB) { |
| 3508 | ConstantInt *VVal = SI->findCaseDest(BB); |
| 3509 | assert(VVal && "Should have a unique destination value"); |
| 3510 | ICI->setOperand(0, VVal); |
Andrew Trick | f3cf193 | 2012-08-29 21:46:36 +0000 | [diff] [blame] | 3511 | |
Rafael Espindola | 37dc9e1 | 2014-02-21 00:06:31 +0000 | [diff] [blame] | 3512 | if (Value *V = SimplifyInstruction(ICI, DL)) { |
Chris Lattner | d7beca3 | 2010-12-14 06:17:25 +0000 | [diff] [blame] | 3513 | ICI->replaceAllUsesWith(V); |
Chris Lattner | d9bacc0 | 2010-12-13 03:18:54 +0000 | [diff] [blame] | 3514 | ICI->eraseFromParent(); |
| 3515 | } |
| 3516 | // BB is now empty, so it is likely to simplify away. |
Hal Finkel | 3ca4a6b | 2016-12-15 03:02:15 +0000 | [diff] [blame] | 3517 | return SimplifyCFG(BB, TTI, BonusInstThreshold) | true; |
Chris Lattner | d9bacc0 | 2010-12-13 03:18:54 +0000 | [diff] [blame] | 3518 | } |
Andrew Trick | f3cf193 | 2012-08-29 21:46:36 +0000 | [diff] [blame] | 3519 | |
Chris Lattner | 62cc76e | 2010-12-13 03:43:57 +0000 | [diff] [blame] | 3520 | // Ok, the block is reachable from the default dest. If the constant we're |
| 3521 | // comparing exists in one of the other edges, then we can constant fold ICI |
| 3522 | // and zap it. |
Stepan Dyatkovskiy | 97b02fc | 2012-03-11 06:09:17 +0000 | [diff] [blame] | 3523 | if (SI->findCaseValue(Cst) != SI->case_default()) { |
Chris Lattner | 62cc76e | 2010-12-13 03:43:57 +0000 | [diff] [blame] | 3524 | Value *V; |
| 3525 | if (ICI->getPredicate() == ICmpInst::ICMP_EQ) |
| 3526 | V = ConstantInt::getFalse(BB->getContext()); |
| 3527 | else |
| 3528 | V = ConstantInt::getTrue(BB->getContext()); |
Andrew Trick | f3cf193 | 2012-08-29 21:46:36 +0000 | [diff] [blame] | 3529 | |
Chris Lattner | 62cc76e | 2010-12-13 03:43:57 +0000 | [diff] [blame] | 3530 | ICI->replaceAllUsesWith(V); |
| 3531 | ICI->eraseFromParent(); |
| 3532 | // BB is now empty, so it is likely to simplify away. |
Hal Finkel | 3ca4a6b | 2016-12-15 03:02:15 +0000 | [diff] [blame] | 3533 | return SimplifyCFG(BB, TTI, BonusInstThreshold) | true; |
Chris Lattner | 62cc76e | 2010-12-13 03:43:57 +0000 | [diff] [blame] | 3534 | } |
Andrew Trick | f3cf193 | 2012-08-29 21:46:36 +0000 | [diff] [blame] | 3535 | |
Chris Lattner | d9bacc0 | 2010-12-13 03:18:54 +0000 | [diff] [blame] | 3536 | // The use of the icmp has to be in the 'end' block, by the only PHI node in |
| 3537 | // the block. |
| 3538 | BasicBlock *SuccBlock = BB->getTerminator()->getSuccessor(0); |
Chandler Carruth | cdf4788 | 2014-03-09 03:16:01 +0000 | [diff] [blame] | 3539 | PHINode *PHIUse = dyn_cast<PHINode>(ICI->user_back()); |
Craig Topper | f40110f | 2014-04-25 05:29:35 +0000 | [diff] [blame] | 3540 | if (PHIUse == nullptr || PHIUse != &SuccBlock->front() || |
Chris Lattner | d9bacc0 | 2010-12-13 03:18:54 +0000 | [diff] [blame] | 3541 | isa<PHINode>(++BasicBlock::iterator(PHIUse))) |
| 3542 | return false; |
| 3543 | |
| 3544 | // If the icmp is a SETEQ, then the default dest gets false, the new edge gets |
| 3545 | // true in the PHI. |
| 3546 | Constant *DefaultCst = ConstantInt::getTrue(BB->getContext()); |
Dehao Chen | f6c0083 | 2016-05-18 19:44:21 +0000 | [diff] [blame] | 3547 | Constant *NewCst = ConstantInt::getFalse(BB->getContext()); |
Chris Lattner | d9bacc0 | 2010-12-13 03:18:54 +0000 | [diff] [blame] | 3548 | |
| 3549 | if (ICI->getPredicate() == ICmpInst::ICMP_EQ) |
| 3550 | std::swap(DefaultCst, NewCst); |
| 3551 | |
| 3552 | // Replace ICI (which is used by the PHI for the default value) with true or |
| 3553 | // false depending on if it is EQ or NE. |
| 3554 | ICI->replaceAllUsesWith(DefaultCst); |
| 3555 | ICI->eraseFromParent(); |
| 3556 | |
| 3557 | // Okay, the switch goes to this block on a default value. Add an edge from |
| 3558 | // the switch to the merge point on the compared value. |
Dehao Chen | f6c0083 | 2016-05-18 19:44:21 +0000 | [diff] [blame] | 3559 | BasicBlock *NewBB = |
| 3560 | BasicBlock::Create(BB->getContext(), "switch.edge", BB->getParent(), BB); |
Manman Ren | ce48ea7 | 2012-09-17 23:07:43 +0000 | [diff] [blame] | 3561 | SmallVector<uint64_t, 8> Weights; |
| 3562 | bool HasWeights = HasBranchWeights(SI); |
| 3563 | if (HasWeights) { |
| 3564 | GetBranchWeights(SI, Weights); |
| 3565 | if (Weights.size() == 1 + SI->getNumCases()) { |
| 3566 | // Split weight for default case to case for "Cst". |
Dehao Chen | f6c0083 | 2016-05-18 19:44:21 +0000 | [diff] [blame] | 3567 | Weights[0] = (Weights[0] + 1) >> 1; |
Manman Ren | ce48ea7 | 2012-09-17 23:07:43 +0000 | [diff] [blame] | 3568 | Weights.push_back(Weights[0]); |
| 3569 | |
| 3570 | SmallVector<uint32_t, 8> MDWeights(Weights.begin(), Weights.end()); |
Dehao Chen | f6c0083 | 2016-05-18 19:44:21 +0000 | [diff] [blame] | 3571 | SI->setMetadata( |
| 3572 | LLVMContext::MD_prof, |
| 3573 | MDBuilder(SI->getContext()).createBranchWeights(MDWeights)); |
Manman Ren | ce48ea7 | 2012-09-17 23:07:43 +0000 | [diff] [blame] | 3574 | } |
| 3575 | } |
Chris Lattner | d9bacc0 | 2010-12-13 03:18:54 +0000 | [diff] [blame] | 3576 | SI->addCase(Cst, NewBB); |
Andrew Trick | f3cf193 | 2012-08-29 21:46:36 +0000 | [diff] [blame] | 3577 | |
Chris Lattner | d9bacc0 | 2010-12-13 03:18:54 +0000 | [diff] [blame] | 3578 | // NewBB branches to the phi block, add the uncond branch and the phi entry. |
Devang Patel | 767f693 | 2011-05-18 18:28:48 +0000 | [diff] [blame] | 3579 | Builder.SetInsertPoint(NewBB); |
| 3580 | Builder.SetCurrentDebugLocation(SI->getDebugLoc()); |
| 3581 | Builder.CreateBr(SuccBlock); |
Chris Lattner | d9bacc0 | 2010-12-13 03:18:54 +0000 | [diff] [blame] | 3582 | PHIUse->addIncoming(NewCst, NewBB); |
| 3583 | return true; |
| 3584 | } |
| 3585 | |
Sanjay Patel | 09159b8f | 2015-06-24 20:40:57 +0000 | [diff] [blame] | 3586 | /// The specified branch is a conditional branch. |
Chris Lattner | a69c443 | 2010-12-13 05:03:41 +0000 | [diff] [blame] | 3587 | /// Check to see if it is branching on an or/and chain of icmp instructions, and |
| 3588 | /// fold it into a switch instruction if so. |
Mehdi Amini | a28d91d | 2015-03-10 02:37:25 +0000 | [diff] [blame] | 3589 | static bool SimplifyBranchOnICmpChain(BranchInst *BI, IRBuilder<> &Builder, |
| 3590 | const DataLayout &DL) { |
Chris Lattner | a69c443 | 2010-12-13 05:03:41 +0000 | [diff] [blame] | 3591 | Instruction *Cond = dyn_cast<Instruction>(BI->getCondition()); |
Dehao Chen | f6c0083 | 2016-05-18 19:44:21 +0000 | [diff] [blame] | 3592 | if (!Cond) |
| 3593 | return false; |
Andrew Trick | f3cf193 | 2012-08-29 21:46:36 +0000 | [diff] [blame] | 3594 | |
Chris Lattner | a69c443 | 2010-12-13 05:03:41 +0000 | [diff] [blame] | 3595 | // Change br (X == 0 | X == 1), T, F into a switch instruction. |
| 3596 | // If this is a bunch of seteq's or'd together, or if it's a bunch of |
| 3597 | // 'setne's and'ed together, collect them. |
Andrew Trick | f3cf193 | 2012-08-29 21:46:36 +0000 | [diff] [blame] | 3598 | |
Mehdi Amini | 9a25cb8 | 2014-11-19 20:09:11 +0000 | [diff] [blame] | 3599 | // Try to gather values from a chain of and/or to be turned into a switch |
Mehdi Amini | ffd0100 | 2014-11-20 22:40:25 +0000 | [diff] [blame] | 3600 | ConstantComparesGatherer ConstantCompare(Cond, DL); |
| 3601 | // Unpack the result |
Dehao Chen | f6c0083 | 2016-05-18 19:44:21 +0000 | [diff] [blame] | 3602 | SmallVectorImpl<ConstantInt *> &Values = ConstantCompare.Vals; |
Mehdi Amini | ffd0100 | 2014-11-20 22:40:25 +0000 | [diff] [blame] | 3603 | Value *CompVal = ConstantCompare.CompValue; |
| 3604 | unsigned UsedICmps = ConstantCompare.UsedICmps; |
| 3605 | Value *ExtraCase = ConstantCompare.Extra; |
Andrew Trick | f3cf193 | 2012-08-29 21:46:36 +0000 | [diff] [blame] | 3606 | |
Chris Lattner | a69c443 | 2010-12-13 05:03:41 +0000 | [diff] [blame] | 3607 | // If we didn't have a multiply compared value, fail. |
Dehao Chen | f6c0083 | 2016-05-18 19:44:21 +0000 | [diff] [blame] | 3608 | if (!CompVal) |
| 3609 | return false; |
Chris Lattner | a69c443 | 2010-12-13 05:03:41 +0000 | [diff] [blame] | 3610 | |
Benjamin Kramer | 8d6a8c1 | 2011-02-07 22:37:28 +0000 | [diff] [blame] | 3611 | // Avoid turning single icmps into a switch. |
| 3612 | if (UsedICmps <= 1) |
| 3613 | return false; |
| 3614 | |
Mehdi Amini | ffd0100 | 2014-11-20 22:40:25 +0000 | [diff] [blame] | 3615 | bool TrueWhenEqual = (Cond->getOpcode() == Instruction::Or); |
| 3616 | |
Chris Lattner | a69c443 | 2010-12-13 05:03:41 +0000 | [diff] [blame] | 3617 | // There might be duplicate constants in the list, which the switch |
| 3618 | // instruction can't handle, remove them now. |
| 3619 | array_pod_sort(Values.begin(), Values.end(), ConstantIntSortPredicate); |
| 3620 | Values.erase(std::unique(Values.begin(), Values.end()), Values.end()); |
Andrew Trick | f3cf193 | 2012-08-29 21:46:36 +0000 | [diff] [blame] | 3621 | |
Chris Lattner | a69c443 | 2010-12-13 05:03:41 +0000 | [diff] [blame] | 3622 | // If Extra was used, we require at least two switch values to do the |
Sanjay Patel | 5966145 | 2015-09-10 15:14:34 +0000 | [diff] [blame] | 3623 | // transformation. A switch with one value is just a conditional branch. |
Dehao Chen | f6c0083 | 2016-05-18 19:44:21 +0000 | [diff] [blame] | 3624 | if (ExtraCase && Values.size() < 2) |
| 3625 | return false; |
Andrew Trick | f3cf193 | 2012-08-29 21:46:36 +0000 | [diff] [blame] | 3626 | |
Andrew Trick | 3051aa1 | 2012-08-29 21:46:38 +0000 | [diff] [blame] | 3627 | // TODO: Preserve branch weight metadata, similarly to how |
| 3628 | // FoldValueComparisonIntoPredecessors preserves it. |
| 3629 | |
Chris Lattner | a69c443 | 2010-12-13 05:03:41 +0000 | [diff] [blame] | 3630 | // Figure out which block is which destination. |
| 3631 | BasicBlock *DefaultBB = BI->getSuccessor(1); |
Dehao Chen | f6c0083 | 2016-05-18 19:44:21 +0000 | [diff] [blame] | 3632 | BasicBlock *EdgeBB = BI->getSuccessor(0); |
| 3633 | if (!TrueWhenEqual) |
| 3634 | std::swap(DefaultBB, EdgeBB); |
Andrew Trick | f3cf193 | 2012-08-29 21:46:36 +0000 | [diff] [blame] | 3635 | |
Chris Lattner | a69c443 | 2010-12-13 05:03:41 +0000 | [diff] [blame] | 3636 | BasicBlock *BB = BI->getParent(); |
Andrew Trick | f3cf193 | 2012-08-29 21:46:36 +0000 | [diff] [blame] | 3637 | |
Chris Lattner | d7beca3 | 2010-12-14 06:17:25 +0000 | [diff] [blame] | 3638 | DEBUG(dbgs() << "Converting 'icmp' chain with " << Values.size() |
Dehao Chen | f6c0083 | 2016-05-18 19:44:21 +0000 | [diff] [blame] | 3639 | << " cases into SWITCH. BB is:\n" |
| 3640 | << *BB); |
Andrew Trick | f3cf193 | 2012-08-29 21:46:36 +0000 | [diff] [blame] | 3641 | |
Chris Lattner | a69c443 | 2010-12-13 05:03:41 +0000 | [diff] [blame] | 3642 | // If there are any extra values that couldn't be folded into the switch |
| 3643 | // then we evaluate them with an explicit branch first. Split the block |
| 3644 | // right before the condbr to handle it. |
| 3645 | if (ExtraCase) { |
Duncan P. N. Exon Smith | 5b4c837 | 2015-10-13 02:39:05 +0000 | [diff] [blame] | 3646 | BasicBlock *NewBB = |
| 3647 | BB->splitBasicBlock(BI->getIterator(), "switch.early.test"); |
Chris Lattner | a69c443 | 2010-12-13 05:03:41 +0000 | [diff] [blame] | 3648 | // Remove the uncond branch added to the old block. |
| 3649 | TerminatorInst *OldTI = BB->getTerminator(); |
Devang Patel | 7de6c4b | 2011-05-18 23:18:47 +0000 | [diff] [blame] | 3650 | Builder.SetInsertPoint(OldTI); |
| 3651 | |
Chris Lattner | 5a9d59d | 2010-12-14 05:57:30 +0000 | [diff] [blame] | 3652 | if (TrueWhenEqual) |
Devang Patel | 7de6c4b | 2011-05-18 23:18:47 +0000 | [diff] [blame] | 3653 | Builder.CreateCondBr(ExtraCase, EdgeBB, NewBB); |
Chris Lattner | 5a9d59d | 2010-12-14 05:57:30 +0000 | [diff] [blame] | 3654 | else |
Devang Patel | 7de6c4b | 2011-05-18 23:18:47 +0000 | [diff] [blame] | 3655 | Builder.CreateCondBr(ExtraCase, NewBB, EdgeBB); |
Andrew Trick | f3cf193 | 2012-08-29 21:46:36 +0000 | [diff] [blame] | 3656 | |
Chris Lattner | a69c443 | 2010-12-13 05:03:41 +0000 | [diff] [blame] | 3657 | OldTI->eraseFromParent(); |
Andrew Trick | f3cf193 | 2012-08-29 21:46:36 +0000 | [diff] [blame] | 3658 | |
Chris Lattner | cb570f8 | 2010-12-13 05:34:18 +0000 | [diff] [blame] | 3659 | // If there are PHI nodes in EdgeBB, then we need to add a new entry to them |
| 3660 | // for the edge we just added. |
Chris Lattner | 0f4d67b | 2010-12-14 07:09:42 +0000 | [diff] [blame] | 3661 | AddPredecessorToBlock(EdgeBB, BB, NewBB); |
Andrew Trick | f3cf193 | 2012-08-29 21:46:36 +0000 | [diff] [blame] | 3662 | |
Chris Lattner | d7beca3 | 2010-12-14 06:17:25 +0000 | [diff] [blame] | 3663 | DEBUG(dbgs() << " ** 'icmp' chain unhandled condition: " << *ExtraCase |
Dehao Chen | f6c0083 | 2016-05-18 19:44:21 +0000 | [diff] [blame] | 3664 | << "\nEXTRABB = " << *BB); |
Chris Lattner | a69c443 | 2010-12-13 05:03:41 +0000 | [diff] [blame] | 3665 | BB = NewBB; |
| 3666 | } |
Devang Patel | 7de6c4b | 2011-05-18 23:18:47 +0000 | [diff] [blame] | 3667 | |
| 3668 | Builder.SetInsertPoint(BI); |
Chris Lattner | a69c443 | 2010-12-13 05:03:41 +0000 | [diff] [blame] | 3669 | // Convert pointer to int before we switch. |
| 3670 | if (CompVal->getType()->isPointerTy()) { |
Mehdi Amini | a28d91d | 2015-03-10 02:37:25 +0000 | [diff] [blame] | 3671 | CompVal = Builder.CreatePtrToInt( |
| 3672 | CompVal, DL.getIntPtrType(CompVal->getType()), "magicptr"); |
Chris Lattner | a69c443 | 2010-12-13 05:03:41 +0000 | [diff] [blame] | 3673 | } |
Andrew Trick | f3cf193 | 2012-08-29 21:46:36 +0000 | [diff] [blame] | 3674 | |
Chris Lattner | a69c443 | 2010-12-13 05:03:41 +0000 | [diff] [blame] | 3675 | // Create the new switch instruction now. |
Devang Patel | 7de6c4b | 2011-05-18 23:18:47 +0000 | [diff] [blame] | 3676 | SwitchInst *New = Builder.CreateSwitch(CompVal, DefaultBB, Values.size()); |
Devang Patel | b849cd5 | 2011-05-17 23:29:05 +0000 | [diff] [blame] | 3677 | |
Chris Lattner | a69c443 | 2010-12-13 05:03:41 +0000 | [diff] [blame] | 3678 | // Add all of the 'cases' to the switch instruction. |
| 3679 | for (unsigned i = 0, e = Values.size(); i != e; ++i) |
| 3680 | New->addCase(Values[i], EdgeBB); |
Andrew Trick | f3cf193 | 2012-08-29 21:46:36 +0000 | [diff] [blame] | 3681 | |
Chris Lattner | a69c443 | 2010-12-13 05:03:41 +0000 | [diff] [blame] | 3682 | // We added edges from PI to the EdgeBB. As such, if there were any |
| 3683 | // PHI nodes in EdgeBB, they need entries to be added corresponding to |
| 3684 | // the number of edges added. |
Dehao Chen | f6c0083 | 2016-05-18 19:44:21 +0000 | [diff] [blame] | 3685 | for (BasicBlock::iterator BBI = EdgeBB->begin(); isa<PHINode>(BBI); ++BBI) { |
Chris Lattner | a69c443 | 2010-12-13 05:03:41 +0000 | [diff] [blame] | 3686 | PHINode *PN = cast<PHINode>(BBI); |
| 3687 | Value *InVal = PN->getIncomingValueForBlock(BB); |
Dehao Chen | f6c0083 | 2016-05-18 19:44:21 +0000 | [diff] [blame] | 3688 | for (unsigned i = 0, e = Values.size() - 1; i != e; ++i) |
Chris Lattner | a69c443 | 2010-12-13 05:03:41 +0000 | [diff] [blame] | 3689 | PN->addIncoming(InVal, BB); |
| 3690 | } |
Andrew Trick | f3cf193 | 2012-08-29 21:46:36 +0000 | [diff] [blame] | 3691 | |
Chris Lattner | a69c443 | 2010-12-13 05:03:41 +0000 | [diff] [blame] | 3692 | // Erase the old branch instruction. |
| 3693 | EraseTerminatorInstAndDCECond(BI); |
Andrew Trick | f3cf193 | 2012-08-29 21:46:36 +0000 | [diff] [blame] | 3694 | |
Chris Lattner | d7beca3 | 2010-12-14 06:17:25 +0000 | [diff] [blame] | 3695 | DEBUG(dbgs() << " ** 'icmp' chain result is:\n" << *BB << '\n'); |
Chris Lattner | a69c443 | 2010-12-13 05:03:41 +0000 | [diff] [blame] | 3696 | return true; |
| 3697 | } |
| 3698 | |
Duncan Sands | 29192d0 | 2011-09-05 12:57:57 +0000 | [diff] [blame] | 3699 | bool SimplifyCFGOpt::SimplifyResume(ResumeInst *RI, IRBuilder<> &Builder) { |
Chen Li | 1689c2f | 2016-01-10 05:48:01 +0000 | [diff] [blame] | 3700 | if (isa<PHINode>(RI->getValue())) |
| 3701 | return SimplifyCommonResume(RI); |
| 3702 | else if (isa<LandingPadInst>(RI->getParent()->getFirstNonPHI()) && |
| 3703 | RI->getValue() == RI->getParent()->getFirstNonPHI()) |
| 3704 | // The resume must unwind the exception that caused control to branch here. |
| 3705 | return SimplifySingleResume(RI); |
Chen Li | 509ff21 | 2016-01-11 19:20:53 +0000 | [diff] [blame] | 3706 | |
| 3707 | return false; |
Chen Li | 1689c2f | 2016-01-10 05:48:01 +0000 | [diff] [blame] | 3708 | } |
| 3709 | |
| 3710 | // Simplify resume that is shared by several landing pads (phi of landing pad). |
| 3711 | bool SimplifyCFGOpt::SimplifyCommonResume(ResumeInst *RI) { |
| 3712 | BasicBlock *BB = RI->getParent(); |
| 3713 | |
| 3714 | // Check that there are no other instructions except for debug intrinsics |
| 3715 | // between the phi of landing pads (RI->getValue()) and resume instruction. |
| 3716 | BasicBlock::iterator I = cast<Instruction>(RI->getValue())->getIterator(), |
Dehao Chen | f6c0083 | 2016-05-18 19:44:21 +0000 | [diff] [blame] | 3717 | E = RI->getIterator(); |
Chen Li | 1689c2f | 2016-01-10 05:48:01 +0000 | [diff] [blame] | 3718 | while (++I != E) |
| 3719 | if (!isa<DbgInfoIntrinsic>(I)) |
| 3720 | return false; |
| 3721 | |
| 3722 | SmallSet<BasicBlock *, 4> TrivialUnwindBlocks; |
| 3723 | auto *PhiLPInst = cast<PHINode>(RI->getValue()); |
| 3724 | |
| 3725 | // Check incoming blocks to see if any of them are trivial. |
Dehao Chen | f6c0083 | 2016-05-18 19:44:21 +0000 | [diff] [blame] | 3726 | for (unsigned Idx = 0, End = PhiLPInst->getNumIncomingValues(); Idx != End; |
| 3727 | Idx++) { |
Chen Li | 1689c2f | 2016-01-10 05:48:01 +0000 | [diff] [blame] | 3728 | auto *IncomingBB = PhiLPInst->getIncomingBlock(Idx); |
| 3729 | auto *IncomingValue = PhiLPInst->getIncomingValue(Idx); |
| 3730 | |
| 3731 | // If the block has other successors, we can not delete it because |
| 3732 | // it has other dependents. |
| 3733 | if (IncomingBB->getUniqueSuccessor() != BB) |
| 3734 | continue; |
| 3735 | |
Dehao Chen | f6c0083 | 2016-05-18 19:44:21 +0000 | [diff] [blame] | 3736 | auto *LandingPad = dyn_cast<LandingPadInst>(IncomingBB->getFirstNonPHI()); |
Chen Li | 1689c2f | 2016-01-10 05:48:01 +0000 | [diff] [blame] | 3737 | // Not the landing pad that caused the control to branch here. |
| 3738 | if (IncomingValue != LandingPad) |
| 3739 | continue; |
| 3740 | |
| 3741 | bool isTrivial = true; |
| 3742 | |
| 3743 | I = IncomingBB->getFirstNonPHI()->getIterator(); |
| 3744 | E = IncomingBB->getTerminator()->getIterator(); |
| 3745 | while (++I != E) |
| 3746 | if (!isa<DbgInfoIntrinsic>(I)) { |
| 3747 | isTrivial = false; |
| 3748 | break; |
| 3749 | } |
| 3750 | |
| 3751 | if (isTrivial) |
| 3752 | TrivialUnwindBlocks.insert(IncomingBB); |
| 3753 | } |
| 3754 | |
| 3755 | // If no trivial unwind blocks, don't do any simplifications. |
Dehao Chen | f6c0083 | 2016-05-18 19:44:21 +0000 | [diff] [blame] | 3756 | if (TrivialUnwindBlocks.empty()) |
| 3757 | return false; |
Chen Li | 1689c2f | 2016-01-10 05:48:01 +0000 | [diff] [blame] | 3758 | |
| 3759 | // Turn all invokes that unwind here into calls. |
| 3760 | for (auto *TrivialBB : TrivialUnwindBlocks) { |
| 3761 | // Blocks that will be simplified should be removed from the phi node. |
| 3762 | // Note there could be multiple edges to the resume block, and we need |
| 3763 | // to remove them all. |
| 3764 | while (PhiLPInst->getBasicBlockIndex(TrivialBB) != -1) |
| 3765 | BB->removePredecessor(TrivialBB, true); |
| 3766 | |
| 3767 | for (pred_iterator PI = pred_begin(TrivialBB), PE = pred_end(TrivialBB); |
| 3768 | PI != PE;) { |
| 3769 | BasicBlock *Pred = *PI++; |
| 3770 | removeUnwindEdge(Pred); |
| 3771 | } |
| 3772 | |
| 3773 | // In each SimplifyCFG run, only the current processed block can be erased. |
| 3774 | // Otherwise, it will break the iteration of SimplifyCFG pass. So instead |
| 3775 | // of erasing TrivialBB, we only remove the branch to the common resume |
| 3776 | // block so that we can later erase the resume block since it has no |
| 3777 | // predecessors. |
| 3778 | TrivialBB->getTerminator()->eraseFromParent(); |
| 3779 | new UnreachableInst(RI->getContext(), TrivialBB); |
| 3780 | } |
| 3781 | |
| 3782 | // Delete the resume block if all its predecessors have been removed. |
| 3783 | if (pred_empty(BB)) |
| 3784 | BB->eraseFromParent(); |
| 3785 | |
| 3786 | return !TrivialUnwindBlocks.empty(); |
| 3787 | } |
| 3788 | |
| 3789 | // Simplify resume that is only used by a single (non-phi) landing pad. |
| 3790 | bool SimplifyCFGOpt::SimplifySingleResume(ResumeInst *RI) { |
Duncan Sands | 29192d0 | 2011-09-05 12:57:57 +0000 | [diff] [blame] | 3791 | BasicBlock *BB = RI->getParent(); |
| 3792 | LandingPadInst *LPInst = dyn_cast<LandingPadInst>(BB->getFirstNonPHI()); |
Dehao Chen | f6c0083 | 2016-05-18 19:44:21 +0000 | [diff] [blame] | 3793 | assert(RI->getValue() == LPInst && |
| 3794 | "Resume must unwind the exception that caused control to here"); |
Duncan Sands | 29192d0 | 2011-09-05 12:57:57 +0000 | [diff] [blame] | 3795 | |
Chen Li | 7009cd3 | 2015-10-23 21:13:01 +0000 | [diff] [blame] | 3796 | // Check that there are no other instructions except for debug intrinsics. |
| 3797 | BasicBlock::iterator I = LPInst->getIterator(), E = RI->getIterator(); |
Duncan Sands | 29192d0 | 2011-09-05 12:57:57 +0000 | [diff] [blame] | 3798 | while (++I != E) |
| 3799 | if (!isa<DbgInfoIntrinsic>(I)) |
| 3800 | return false; |
| 3801 | |
Chen Li | c6e2878 | 2015-10-22 20:48:38 +0000 | [diff] [blame] | 3802 | // Turn all invokes that unwind here into calls and delete the basic block. |
Chen Li | 7009cd3 | 2015-10-23 21:13:01 +0000 | [diff] [blame] | 3803 | for (pred_iterator PI = pred_begin(BB), PE = pred_end(BB); PI != PE;) { |
| 3804 | BasicBlock *Pred = *PI++; |
| 3805 | removeUnwindEdge(Pred); |
Chen Li | c6e2878 | 2015-10-22 20:48:38 +0000 | [diff] [blame] | 3806 | } |
| 3807 | |
Chen Li | 7009cd3 | 2015-10-23 21:13:01 +0000 | [diff] [blame] | 3808 | // The landingpad is now unreachable. Zap it. |
| 3809 | BB->eraseFromParent(); |
Dehao Chen | f6c0083 | 2016-05-18 19:44:21 +0000 | [diff] [blame] | 3810 | if (LoopHeaders) |
| 3811 | LoopHeaders->erase(BB); |
Chen Li | 7009cd3 | 2015-10-23 21:13:01 +0000 | [diff] [blame] | 3812 | return true; |
Duncan Sands | 29192d0 | 2011-09-05 12:57:57 +0000 | [diff] [blame] | 3813 | } |
| 3814 | |
David Majnemer | 1efa23d | 2016-02-20 01:07:45 +0000 | [diff] [blame] | 3815 | static bool removeEmptyCleanup(CleanupReturnInst *RI) { |
Andrew Kaylor | 50e4e86 | 2015-09-04 23:39:40 +0000 | [diff] [blame] | 3816 | // If this is a trivial cleanup pad that executes no instructions, it can be |
| 3817 | // eliminated. If the cleanup pad continues to the caller, any predecessor |
| 3818 | // that is an EH pad will be updated to continue to the caller and any |
| 3819 | // predecessor that terminates with an invoke instruction will have its invoke |
| 3820 | // instruction converted to a call instruction. If the cleanup pad being |
| 3821 | // simplified does not continue to the caller, each predecessor will be |
| 3822 | // updated to continue to the unwind destination of the cleanup pad being |
| 3823 | // simplified. |
| 3824 | BasicBlock *BB = RI->getParent(); |
David Majnemer | 8a1c45d | 2015-12-12 05:38:55 +0000 | [diff] [blame] | 3825 | CleanupPadInst *CPInst = RI->getCleanupPad(); |
| 3826 | if (CPInst->getParent() != BB) |
Andrew Kaylor | 50e4e86 | 2015-09-04 23:39:40 +0000 | [diff] [blame] | 3827 | // This isn't an empty cleanup. |
| 3828 | return false; |
| 3829 | |
David Majnemer | 2482e1c | 2016-06-04 23:50:03 +0000 | [diff] [blame] | 3830 | // We cannot kill the pad if it has multiple uses. This typically arises |
| 3831 | // from unreachable basic blocks. |
| 3832 | if (!CPInst->hasOneUse()) |
| 3833 | return false; |
| 3834 | |
David Majnemer | 9f92f4c | 2016-05-21 05:12:32 +0000 | [diff] [blame] | 3835 | // Check that there are no other instructions except for benign intrinsics. |
Duncan P. N. Exon Smith | 5b4c837 | 2015-10-13 02:39:05 +0000 | [diff] [blame] | 3836 | BasicBlock::iterator I = CPInst->getIterator(), E = RI->getIterator(); |
David Majnemer | 9f92f4c | 2016-05-21 05:12:32 +0000 | [diff] [blame] | 3837 | while (++I != E) { |
| 3838 | auto *II = dyn_cast<IntrinsicInst>(I); |
| 3839 | if (!II) |
Andrew Kaylor | 50e4e86 | 2015-09-04 23:39:40 +0000 | [diff] [blame] | 3840 | return false; |
| 3841 | |
David Majnemer | 9f92f4c | 2016-05-21 05:12:32 +0000 | [diff] [blame] | 3842 | Intrinsic::ID IntrinsicID = II->getIntrinsicID(); |
| 3843 | switch (IntrinsicID) { |
| 3844 | case Intrinsic::dbg_declare: |
| 3845 | case Intrinsic::dbg_value: |
| 3846 | case Intrinsic::lifetime_end: |
| 3847 | break; |
| 3848 | default: |
| 3849 | return false; |
| 3850 | } |
| 3851 | } |
| 3852 | |
David Majnemer | 8a1c45d | 2015-12-12 05:38:55 +0000 | [diff] [blame] | 3853 | // If the cleanup return we are simplifying unwinds to the caller, this will |
| 3854 | // set UnwindDest to nullptr. |
Andrew Kaylor | 50e4e86 | 2015-09-04 23:39:40 +0000 | [diff] [blame] | 3855 | BasicBlock *UnwindDest = RI->getUnwindDest(); |
David Majnemer | 8a1c45d | 2015-12-12 05:38:55 +0000 | [diff] [blame] | 3856 | Instruction *DestEHPad = UnwindDest ? UnwindDest->getFirstNonPHI() : nullptr; |
Andrew Kaylor | 50e4e86 | 2015-09-04 23:39:40 +0000 | [diff] [blame] | 3857 | |
| 3858 | // We're about to remove BB from the control flow. Before we do, sink any |
| 3859 | // PHINodes into the unwind destination. Doing this before changing the |
| 3860 | // control flow avoids some potentially slow checks, since we can currently |
| 3861 | // be certain that UnwindDest and BB have no common predecessors (since they |
| 3862 | // are both EH pads). |
| 3863 | if (UnwindDest) { |
| 3864 | // First, go through the PHI nodes in UnwindDest and update any nodes that |
| 3865 | // reference the block we are removing |
Duncan P. N. Exon Smith | 5b4c837 | 2015-10-13 02:39:05 +0000 | [diff] [blame] | 3866 | for (BasicBlock::iterator I = UnwindDest->begin(), |
David Majnemer | 8a1c45d | 2015-12-12 05:38:55 +0000 | [diff] [blame] | 3867 | IE = DestEHPad->getIterator(); |
Andrew Kaylor | 50e4e86 | 2015-09-04 23:39:40 +0000 | [diff] [blame] | 3868 | I != IE; ++I) { |
| 3869 | PHINode *DestPN = cast<PHINode>(I); |
James Molloy | 4de84dd | 2015-11-04 15:28:04 +0000 | [diff] [blame] | 3870 | |
Andrew Kaylor | 2a9a6d8 | 2015-09-05 01:00:51 +0000 | [diff] [blame] | 3871 | int Idx = DestPN->getBasicBlockIndex(BB); |
Andrew Kaylor | 50e4e86 | 2015-09-04 23:39:40 +0000 | [diff] [blame] | 3872 | // Since BB unwinds to UnwindDest, it has to be in the PHI node. |
Craig Topper | 02a55d7 | 2015-09-05 04:49:44 +0000 | [diff] [blame] | 3873 | assert(Idx != -1); |
Andrew Kaylor | 50e4e86 | 2015-09-04 23:39:40 +0000 | [diff] [blame] | 3874 | // This PHI node has an incoming value that corresponds to a control |
| 3875 | // path through the cleanup pad we are removing. If the incoming |
| 3876 | // value is in the cleanup pad, it must be a PHINode (because we |
| 3877 | // verified above that the block is otherwise empty). Otherwise, the |
| 3878 | // value is either a constant or a value that dominates the cleanup |
| 3879 | // pad being removed. |
| 3880 | // |
| 3881 | // Because BB and UnwindDest are both EH pads, all of their |
| 3882 | // predecessors must unwind to these blocks, and since no instruction |
| 3883 | // can have multiple unwind destinations, there will be no overlap in |
| 3884 | // incoming blocks between SrcPN and DestPN. |
| 3885 | Value *SrcVal = DestPN->getIncomingValue(Idx); |
| 3886 | PHINode *SrcPN = dyn_cast<PHINode>(SrcVal); |
| 3887 | |
| 3888 | // Remove the entry for the block we are deleting. |
| 3889 | DestPN->removeIncomingValue(Idx, false); |
| 3890 | |
| 3891 | if (SrcPN && SrcPN->getParent() == BB) { |
| 3892 | // If the incoming value was a PHI node in the cleanup pad we are |
| 3893 | // removing, we need to merge that PHI node's incoming values into |
| 3894 | // DestPN. |
James Molloy | 4de84dd | 2015-11-04 15:28:04 +0000 | [diff] [blame] | 3895 | for (unsigned SrcIdx = 0, SrcE = SrcPN->getNumIncomingValues(); |
Dehao Chen | f6c0083 | 2016-05-18 19:44:21 +0000 | [diff] [blame] | 3896 | SrcIdx != SrcE; ++SrcIdx) { |
Andrew Kaylor | 50e4e86 | 2015-09-04 23:39:40 +0000 | [diff] [blame] | 3897 | DestPN->addIncoming(SrcPN->getIncomingValue(SrcIdx), |
| 3898 | SrcPN->getIncomingBlock(SrcIdx)); |
| 3899 | } |
| 3900 | } else { |
| 3901 | // Otherwise, the incoming value came from above BB and |
| 3902 | // so we can just reuse it. We must associate all of BB's |
| 3903 | // predecessors with this value. |
| 3904 | for (auto *pred : predecessors(BB)) { |
| 3905 | DestPN->addIncoming(SrcVal, pred); |
| 3906 | } |
| 3907 | } |
| 3908 | } |
| 3909 | |
| 3910 | // Sink any remaining PHI nodes directly into UnwindDest. |
David Majnemer | 8a1c45d | 2015-12-12 05:38:55 +0000 | [diff] [blame] | 3911 | Instruction *InsertPt = DestEHPad; |
Duncan P. N. Exon Smith | 5b4c837 | 2015-10-13 02:39:05 +0000 | [diff] [blame] | 3912 | for (BasicBlock::iterator I = BB->begin(), |
| 3913 | IE = BB->getFirstNonPHI()->getIterator(); |
Andrew Kaylor | 50e4e86 | 2015-09-04 23:39:40 +0000 | [diff] [blame] | 3914 | I != IE;) { |
| 3915 | // The iterator must be incremented here because the instructions are |
| 3916 | // being moved to another block. |
| 3917 | PHINode *PN = cast<PHINode>(I++); |
| 3918 | if (PN->use_empty()) |
| 3919 | // If the PHI node has no uses, just leave it. It will be erased |
| 3920 | // when we erase BB below. |
| 3921 | continue; |
| 3922 | |
| 3923 | // Otherwise, sink this PHI node into UnwindDest. |
| 3924 | // Any predecessors to UnwindDest which are not already represented |
| 3925 | // must be back edges which inherit the value from the path through |
| 3926 | // BB. In this case, the PHI value must reference itself. |
| 3927 | for (auto *pred : predecessors(UnwindDest)) |
| 3928 | if (pred != BB) |
| 3929 | PN->addIncoming(PN, pred); |
| 3930 | PN->moveBefore(InsertPt); |
| 3931 | } |
| 3932 | } |
| 3933 | |
| 3934 | for (pred_iterator PI = pred_begin(BB), PE = pred_end(BB); PI != PE;) { |
| 3935 | // The iterator must be updated here because we are removing this pred. |
| 3936 | BasicBlock *PredBB = *PI++; |
Andrew Kaylor | 50e4e86 | 2015-09-04 23:39:40 +0000 | [diff] [blame] | 3937 | if (UnwindDest == nullptr) { |
Joseph Tremoulet | 09af67a | 2015-09-27 01:47:46 +0000 | [diff] [blame] | 3938 | removeUnwindEdge(PredBB); |
Andrew Kaylor | 50e4e86 | 2015-09-04 23:39:40 +0000 | [diff] [blame] | 3939 | } else { |
Andrew Kaylor | 50e4e86 | 2015-09-04 23:39:40 +0000 | [diff] [blame] | 3940 | TerminatorInst *TI = PredBB->getTerminator(); |
Joseph Tremoulet | 09af67a | 2015-09-27 01:47:46 +0000 | [diff] [blame] | 3941 | TI->replaceUsesOfWith(BB, UnwindDest); |
Andrew Kaylor | 50e4e86 | 2015-09-04 23:39:40 +0000 | [diff] [blame] | 3942 | } |
| 3943 | } |
| 3944 | |
| 3945 | // The cleanup pad is now unreachable. Zap it. |
| 3946 | BB->eraseFromParent(); |
| 3947 | return true; |
| 3948 | } |
| 3949 | |
David Majnemer | 1efa23d | 2016-02-20 01:07:45 +0000 | [diff] [blame] | 3950 | // Try to merge two cleanuppads together. |
| 3951 | static bool mergeCleanupPad(CleanupReturnInst *RI) { |
| 3952 | // Skip any cleanuprets which unwind to caller, there is nothing to merge |
| 3953 | // with. |
| 3954 | BasicBlock *UnwindDest = RI->getUnwindDest(); |
| 3955 | if (!UnwindDest) |
| 3956 | return false; |
| 3957 | |
| 3958 | // This cleanupret isn't the only predecessor of this cleanuppad, it wouldn't |
| 3959 | // be safe to merge without code duplication. |
| 3960 | if (UnwindDest->getSinglePredecessor() != RI->getParent()) |
| 3961 | return false; |
| 3962 | |
| 3963 | // Verify that our cleanuppad's unwind destination is another cleanuppad. |
| 3964 | auto *SuccessorCleanupPad = dyn_cast<CleanupPadInst>(&UnwindDest->front()); |
| 3965 | if (!SuccessorCleanupPad) |
| 3966 | return false; |
| 3967 | |
| 3968 | CleanupPadInst *PredecessorCleanupPad = RI->getCleanupPad(); |
| 3969 | // Replace any uses of the successor cleanupad with the predecessor pad |
| 3970 | // The only cleanuppad uses should be this cleanupret, it's cleanupret and |
| 3971 | // funclet bundle operands. |
| 3972 | SuccessorCleanupPad->replaceAllUsesWith(PredecessorCleanupPad); |
| 3973 | // Remove the old cleanuppad. |
| 3974 | SuccessorCleanupPad->eraseFromParent(); |
| 3975 | // Now, we simply replace the cleanupret with a branch to the unwind |
| 3976 | // destination. |
| 3977 | BranchInst::Create(UnwindDest, RI->getParent()); |
| 3978 | RI->eraseFromParent(); |
| 3979 | |
| 3980 | return true; |
| 3981 | } |
| 3982 | |
| 3983 | bool SimplifyCFGOpt::SimplifyCleanupReturn(CleanupReturnInst *RI) { |
David Majnemer | ee0cbbb | 2016-02-24 17:30:48 +0000 | [diff] [blame] | 3984 | // It is possible to transiantly have an undef cleanuppad operand because we |
| 3985 | // have deleted some, but not all, dead blocks. |
| 3986 | // Eventually, this block will be deleted. |
| 3987 | if (isa<UndefValue>(RI->getOperand(0))) |
| 3988 | return false; |
| 3989 | |
David Majnemer | 9f92f4c | 2016-05-21 05:12:32 +0000 | [diff] [blame] | 3990 | if (mergeCleanupPad(RI)) |
David Majnemer | 1efa23d | 2016-02-20 01:07:45 +0000 | [diff] [blame] | 3991 | return true; |
| 3992 | |
David Majnemer | 9f92f4c | 2016-05-21 05:12:32 +0000 | [diff] [blame] | 3993 | if (removeEmptyCleanup(RI)) |
David Majnemer | 1efa23d | 2016-02-20 01:07:45 +0000 | [diff] [blame] | 3994 | return true; |
| 3995 | |
| 3996 | return false; |
| 3997 | } |
| 3998 | |
Devang Patel | dd14e0f | 2011-05-18 21:33:11 +0000 | [diff] [blame] | 3999 | bool SimplifyCFGOpt::SimplifyReturn(ReturnInst *RI, IRBuilder<> &Builder) { |
Chris Lattner | 25c3af3 | 2010-12-13 06:25:44 +0000 | [diff] [blame] | 4000 | BasicBlock *BB = RI->getParent(); |
Dehao Chen | f6c0083 | 2016-05-18 19:44:21 +0000 | [diff] [blame] | 4001 | if (!BB->getFirstNonPHIOrDbg()->isTerminator()) |
| 4002 | return false; |
Andrew Trick | f3cf193 | 2012-08-29 21:46:36 +0000 | [diff] [blame] | 4003 | |
Chris Lattner | 25c3af3 | 2010-12-13 06:25:44 +0000 | [diff] [blame] | 4004 | // Find predecessors that end with branches. |
Dehao Chen | f6c0083 | 2016-05-18 19:44:21 +0000 | [diff] [blame] | 4005 | SmallVector<BasicBlock *, 8> UncondBranchPreds; |
| 4006 | SmallVector<BranchInst *, 8> CondBranchPreds; |
Duncan P. N. Exon Smith | 6c99015 | 2014-07-21 17:06:51 +0000 | [diff] [blame] | 4007 | for (pred_iterator PI = pred_begin(BB), E = pred_end(BB); PI != E; ++PI) { |
| 4008 | BasicBlock *P = *PI; |
Chris Lattner | 25c3af3 | 2010-12-13 06:25:44 +0000 | [diff] [blame] | 4009 | TerminatorInst *PTI = P->getTerminator(); |
| 4010 | if (BranchInst *BI = dyn_cast<BranchInst>(PTI)) { |
| 4011 | if (BI->isUnconditional()) |
| 4012 | UncondBranchPreds.push_back(P); |
| 4013 | else |
| 4014 | CondBranchPreds.push_back(BI); |
| 4015 | } |
| 4016 | } |
Andrew Trick | f3cf193 | 2012-08-29 21:46:36 +0000 | [diff] [blame] | 4017 | |
Chris Lattner | 25c3af3 | 2010-12-13 06:25:44 +0000 | [diff] [blame] | 4018 | // If we found some, do the transformation! |
Evan Cheng | d983eba | 2011-01-29 04:46:23 +0000 | [diff] [blame] | 4019 | if (!UncondBranchPreds.empty() && DupRet) { |
Chris Lattner | 25c3af3 | 2010-12-13 06:25:44 +0000 | [diff] [blame] | 4020 | while (!UncondBranchPreds.empty()) { |
| 4021 | BasicBlock *Pred = UncondBranchPreds.pop_back_val(); |
| 4022 | DEBUG(dbgs() << "FOLDING: " << *BB |
Dehao Chen | f6c0083 | 2016-05-18 19:44:21 +0000 | [diff] [blame] | 4023 | << "INTO UNCOND BRANCH PRED: " << *Pred); |
Evan Cheng | d983eba | 2011-01-29 04:46:23 +0000 | [diff] [blame] | 4024 | (void)FoldReturnIntoUncondBranch(RI, BB, Pred); |
Chris Lattner | 25c3af3 | 2010-12-13 06:25:44 +0000 | [diff] [blame] | 4025 | } |
Andrew Trick | f3cf193 | 2012-08-29 21:46:36 +0000 | [diff] [blame] | 4026 | |
Chris Lattner | 25c3af3 | 2010-12-13 06:25:44 +0000 | [diff] [blame] | 4027 | // If we eliminated all predecessors of the block, delete the block now. |
Hyojin Sung | 4673f10 | 2016-03-29 04:08:57 +0000 | [diff] [blame] | 4028 | if (pred_empty(BB)) { |
Chris Lattner | 25c3af3 | 2010-12-13 06:25:44 +0000 | [diff] [blame] | 4029 | // We know there are no successors, so just nuke the block. |
| 4030 | BB->eraseFromParent(); |
Dehao Chen | f6c0083 | 2016-05-18 19:44:21 +0000 | [diff] [blame] | 4031 | if (LoopHeaders) |
| 4032 | LoopHeaders->erase(BB); |
Hyojin Sung | 4673f10 | 2016-03-29 04:08:57 +0000 | [diff] [blame] | 4033 | } |
Andrew Trick | f3cf193 | 2012-08-29 21:46:36 +0000 | [diff] [blame] | 4034 | |
Chris Lattner | 25c3af3 | 2010-12-13 06:25:44 +0000 | [diff] [blame] | 4035 | return true; |
| 4036 | } |
Andrew Trick | f3cf193 | 2012-08-29 21:46:36 +0000 | [diff] [blame] | 4037 | |
Chris Lattner | 25c3af3 | 2010-12-13 06:25:44 +0000 | [diff] [blame] | 4038 | // Check out all of the conditional branches going to this return |
| 4039 | // instruction. If any of them just select between returns, change the |
| 4040 | // branch itself into a select/return pair. |
| 4041 | while (!CondBranchPreds.empty()) { |
| 4042 | BranchInst *BI = CondBranchPreds.pop_back_val(); |
Andrew Trick | f3cf193 | 2012-08-29 21:46:36 +0000 | [diff] [blame] | 4043 | |
Chris Lattner | 25c3af3 | 2010-12-13 06:25:44 +0000 | [diff] [blame] | 4044 | // Check to see if the non-BB successor is also a return block. |
| 4045 | if (isa<ReturnInst>(BI->getSuccessor(0)->getTerminator()) && |
| 4046 | isa<ReturnInst>(BI->getSuccessor(1)->getTerminator()) && |
Devang Patel | dd14e0f | 2011-05-18 21:33:11 +0000 | [diff] [blame] | 4047 | SimplifyCondBranchToTwoReturns(BI, Builder)) |
Chris Lattner | 25c3af3 | 2010-12-13 06:25:44 +0000 | [diff] [blame] | 4048 | return true; |
| 4049 | } |
| 4050 | return false; |
| 4051 | } |
| 4052 | |
Chris Lattner | 25c3af3 | 2010-12-13 06:25:44 +0000 | [diff] [blame] | 4053 | bool SimplifyCFGOpt::SimplifyUnreachable(UnreachableInst *UI) { |
| 4054 | BasicBlock *BB = UI->getParent(); |
Andrew Trick | f3cf193 | 2012-08-29 21:46:36 +0000 | [diff] [blame] | 4055 | |
Chris Lattner | 25c3af3 | 2010-12-13 06:25:44 +0000 | [diff] [blame] | 4056 | bool Changed = false; |
Andrew Trick | f3cf193 | 2012-08-29 21:46:36 +0000 | [diff] [blame] | 4057 | |
Chris Lattner | 25c3af3 | 2010-12-13 06:25:44 +0000 | [diff] [blame] | 4058 | // If there are any instructions immediately before the unreachable that can |
| 4059 | // be removed, do so. |
Duncan P. N. Exon Smith | 5b4c837 | 2015-10-13 02:39:05 +0000 | [diff] [blame] | 4060 | while (UI->getIterator() != BB->begin()) { |
| 4061 | BasicBlock::iterator BBI = UI->getIterator(); |
Chris Lattner | 25c3af3 | 2010-12-13 06:25:44 +0000 | [diff] [blame] | 4062 | --BBI; |
Eli Friedman | 0ffdf2e | 2011-08-15 23:59:28 +0000 | [diff] [blame] | 4063 | // Do not delete instructions that can have side effects which might cause |
| 4064 | // the unreachable to not be reachable; specifically, calls and volatile |
| 4065 | // operations may have this effect. |
Dehao Chen | f6c0083 | 2016-05-18 19:44:21 +0000 | [diff] [blame] | 4066 | if (isa<CallInst>(BBI) && !isa<DbgInfoIntrinsic>(BBI)) |
| 4067 | break; |
Eli Friedman | 0ffdf2e | 2011-08-15 23:59:28 +0000 | [diff] [blame] | 4068 | |
| 4069 | if (BBI->mayHaveSideEffects()) { |
Joseph Tremoulet | 0d80888 | 2016-01-05 02:37:41 +0000 | [diff] [blame] | 4070 | if (auto *SI = dyn_cast<StoreInst>(BBI)) { |
Eli Friedman | 0ffdf2e | 2011-08-15 23:59:28 +0000 | [diff] [blame] | 4071 | if (SI->isVolatile()) |
| 4072 | break; |
Joseph Tremoulet | 0d80888 | 2016-01-05 02:37:41 +0000 | [diff] [blame] | 4073 | } else if (auto *LI = dyn_cast<LoadInst>(BBI)) { |
Eli Friedman | 0ffdf2e | 2011-08-15 23:59:28 +0000 | [diff] [blame] | 4074 | if (LI->isVolatile()) |
| 4075 | break; |
Joseph Tremoulet | 0d80888 | 2016-01-05 02:37:41 +0000 | [diff] [blame] | 4076 | } else if (auto *RMWI = dyn_cast<AtomicRMWInst>(BBI)) { |
Eli Friedman | 0ffdf2e | 2011-08-15 23:59:28 +0000 | [diff] [blame] | 4077 | if (RMWI->isVolatile()) |
| 4078 | break; |
Joseph Tremoulet | 0d80888 | 2016-01-05 02:37:41 +0000 | [diff] [blame] | 4079 | } else if (auto *CXI = dyn_cast<AtomicCmpXchgInst>(BBI)) { |
Eli Friedman | 0ffdf2e | 2011-08-15 23:59:28 +0000 | [diff] [blame] | 4080 | if (CXI->isVolatile()) |
| 4081 | break; |
Joseph Tremoulet | 0d80888 | 2016-01-05 02:37:41 +0000 | [diff] [blame] | 4082 | } else if (isa<CatchPadInst>(BBI)) { |
| 4083 | // A catchpad may invoke exception object constructors and such, which |
| 4084 | // in some languages can be arbitrary code, so be conservative by |
| 4085 | // default. |
| 4086 | // For CoreCLR, it just involves a type test, so can be removed. |
| 4087 | if (classifyEHPersonality(BB->getParent()->getPersonalityFn()) != |
| 4088 | EHPersonality::CoreCLR) |
| 4089 | break; |
Eli Friedman | 0ffdf2e | 2011-08-15 23:59:28 +0000 | [diff] [blame] | 4090 | } else if (!isa<FenceInst>(BBI) && !isa<VAArgInst>(BBI) && |
| 4091 | !isa<LandingPadInst>(BBI)) { |
Chris Lattner | 25c3af3 | 2010-12-13 06:25:44 +0000 | [diff] [blame] | 4092 | break; |
Eli Friedman | 0ffdf2e | 2011-08-15 23:59:28 +0000 | [diff] [blame] | 4093 | } |
Bill Wendling | 55d875f | 2011-08-16 20:41:17 +0000 | [diff] [blame] | 4094 | // Note that deleting LandingPad's here is in fact okay, although it |
| 4095 | // involves a bit of subtle reasoning. If this inst is a LandingPad, |
| 4096 | // all the predecessors of this block will be the unwind edges of Invokes, |
| 4097 | // and we can therefore guarantee this block will be erased. |
Eli Friedman | 0ffdf2e | 2011-08-15 23:59:28 +0000 | [diff] [blame] | 4098 | } |
| 4099 | |
Eli Friedman | aac35b3 | 2011-03-09 00:48:33 +0000 | [diff] [blame] | 4100 | // Delete this instruction (any uses are guaranteed to be dead) |
| 4101 | if (!BBI->use_empty()) |
| 4102 | BBI->replaceAllUsesWith(UndefValue::get(BBI->getType())); |
Chris Lattner | d7beca3 | 2010-12-14 06:17:25 +0000 | [diff] [blame] | 4103 | BBI->eraseFromParent(); |
Chris Lattner | 25c3af3 | 2010-12-13 06:25:44 +0000 | [diff] [blame] | 4104 | Changed = true; |
| 4105 | } |
Andrew Trick | f3cf193 | 2012-08-29 21:46:36 +0000 | [diff] [blame] | 4106 | |
Chris Lattner | 25c3af3 | 2010-12-13 06:25:44 +0000 | [diff] [blame] | 4107 | // If the unreachable instruction is the first in the block, take a gander |
| 4108 | // at all of the predecessors of this instruction, and simplify them. |
Dehao Chen | f6c0083 | 2016-05-18 19:44:21 +0000 | [diff] [blame] | 4109 | if (&BB->front() != UI) |
| 4110 | return Changed; |
Andrew Trick | f3cf193 | 2012-08-29 21:46:36 +0000 | [diff] [blame] | 4111 | |
Dehao Chen | f6c0083 | 2016-05-18 19:44:21 +0000 | [diff] [blame] | 4112 | SmallVector<BasicBlock *, 8> Preds(pred_begin(BB), pred_end(BB)); |
Chris Lattner | 25c3af3 | 2010-12-13 06:25:44 +0000 | [diff] [blame] | 4113 | for (unsigned i = 0, e = Preds.size(); i != e; ++i) { |
| 4114 | TerminatorInst *TI = Preds[i]->getTerminator(); |
Devang Patel | 31458a0 | 2011-05-19 00:09:21 +0000 | [diff] [blame] | 4115 | IRBuilder<> Builder(TI); |
Joseph Tremoulet | 0d80888 | 2016-01-05 02:37:41 +0000 | [diff] [blame] | 4116 | if (auto *BI = dyn_cast<BranchInst>(TI)) { |
Chris Lattner | 25c3af3 | 2010-12-13 06:25:44 +0000 | [diff] [blame] | 4117 | if (BI->isUnconditional()) { |
| 4118 | if (BI->getSuccessor(0) == BB) { |
| 4119 | new UnreachableInst(TI->getContext(), TI); |
| 4120 | TI->eraseFromParent(); |
| 4121 | Changed = true; |
| 4122 | } |
| 4123 | } else { |
| 4124 | if (BI->getSuccessor(0) == BB) { |
Devang Patel | 31458a0 | 2011-05-19 00:09:21 +0000 | [diff] [blame] | 4125 | Builder.CreateBr(BI->getSuccessor(1)); |
Chris Lattner | 25c3af3 | 2010-12-13 06:25:44 +0000 | [diff] [blame] | 4126 | EraseTerminatorInstAndDCECond(BI); |
| 4127 | } else if (BI->getSuccessor(1) == BB) { |
Devang Patel | 31458a0 | 2011-05-19 00:09:21 +0000 | [diff] [blame] | 4128 | Builder.CreateBr(BI->getSuccessor(0)); |
Chris Lattner | 25c3af3 | 2010-12-13 06:25:44 +0000 | [diff] [blame] | 4129 | EraseTerminatorInstAndDCECond(BI); |
| 4130 | Changed = true; |
| 4131 | } |
| 4132 | } |
Joseph Tremoulet | 0d80888 | 2016-01-05 02:37:41 +0000 | [diff] [blame] | 4133 | } else if (auto *SI = dyn_cast<SwitchInst>(TI)) { |
Dehao Chen | f6c0083 | 2016-05-18 19:44:21 +0000 | [diff] [blame] | 4134 | for (SwitchInst::CaseIt i = SI->case_begin(), e = SI->case_end(); i != e; |
| 4135 | ++i) |
Stepan Dyatkovskiy | 5b648af | 2012-03-08 07:06:20 +0000 | [diff] [blame] | 4136 | if (i.getCaseSuccessor() == BB) { |
Chris Lattner | 25c3af3 | 2010-12-13 06:25:44 +0000 | [diff] [blame] | 4137 | BB->removePredecessor(SI->getParent()); |
| 4138 | SI->removeCase(i); |
Dehao Chen | f6c0083 | 2016-05-18 19:44:21 +0000 | [diff] [blame] | 4139 | --i; |
| 4140 | --e; |
Chris Lattner | 25c3af3 | 2010-12-13 06:25:44 +0000 | [diff] [blame] | 4141 | Changed = true; |
| 4142 | } |
Joseph Tremoulet | 0d80888 | 2016-01-05 02:37:41 +0000 | [diff] [blame] | 4143 | } else if (auto *II = dyn_cast<InvokeInst>(TI)) { |
| 4144 | if (II->getUnwindDest() == BB) { |
| 4145 | removeUnwindEdge(TI->getParent()); |
| 4146 | Changed = true; |
| 4147 | } |
| 4148 | } else if (auto *CSI = dyn_cast<CatchSwitchInst>(TI)) { |
| 4149 | if (CSI->getUnwindDest() == BB) { |
| 4150 | removeUnwindEdge(TI->getParent()); |
| 4151 | Changed = true; |
| 4152 | continue; |
| 4153 | } |
| 4154 | |
| 4155 | for (CatchSwitchInst::handler_iterator I = CSI->handler_begin(), |
| 4156 | E = CSI->handler_end(); |
| 4157 | I != E; ++I) { |
| 4158 | if (*I == BB) { |
| 4159 | CSI->removeHandler(I); |
| 4160 | --I; |
| 4161 | --E; |
| 4162 | Changed = true; |
| 4163 | } |
| 4164 | } |
| 4165 | if (CSI->getNumHandlers() == 0) { |
| 4166 | BasicBlock *CatchSwitchBB = CSI->getParent(); |
| 4167 | if (CSI->hasUnwindDest()) { |
| 4168 | // Redirect preds to the unwind dest |
| 4169 | CatchSwitchBB->replaceAllUsesWith(CSI->getUnwindDest()); |
| 4170 | } else { |
| 4171 | // Rewrite all preds to unwind to caller (or from invoke to call). |
| 4172 | SmallVector<BasicBlock *, 8> EHPreds(predecessors(CatchSwitchBB)); |
| 4173 | for (BasicBlock *EHPred : EHPreds) |
| 4174 | removeUnwindEdge(EHPred); |
| 4175 | } |
| 4176 | // The catchswitch is no longer reachable. |
| 4177 | new UnreachableInst(CSI->getContext(), CSI); |
| 4178 | CSI->eraseFromParent(); |
| 4179 | Changed = true; |
| 4180 | } |
David Majnemer | 8a1c45d | 2015-12-12 05:38:55 +0000 | [diff] [blame] | 4181 | } else if (isa<CleanupReturnInst>(TI)) { |
Joseph Tremoulet | 09af67a | 2015-09-27 01:47:46 +0000 | [diff] [blame] | 4182 | new UnreachableInst(TI->getContext(), TI); |
| 4183 | TI->eraseFromParent(); |
| 4184 | Changed = true; |
Chris Lattner | 25c3af3 | 2010-12-13 06:25:44 +0000 | [diff] [blame] | 4185 | } |
| 4186 | } |
Andrew Trick | f3cf193 | 2012-08-29 21:46:36 +0000 | [diff] [blame] | 4187 | |
Chris Lattner | 25c3af3 | 2010-12-13 06:25:44 +0000 | [diff] [blame] | 4188 | // If this block is now dead, remove it. |
Dehao Chen | f6c0083 | 2016-05-18 19:44:21 +0000 | [diff] [blame] | 4189 | if (pred_empty(BB) && BB != &BB->getParent()->getEntryBlock()) { |
Chris Lattner | 25c3af3 | 2010-12-13 06:25:44 +0000 | [diff] [blame] | 4190 | // We know there are no successors, so just nuke the block. |
| 4191 | BB->eraseFromParent(); |
Dehao Chen | f6c0083 | 2016-05-18 19:44:21 +0000 | [diff] [blame] | 4192 | if (LoopHeaders) |
| 4193 | LoopHeaders->erase(BB); |
Chris Lattner | 25c3af3 | 2010-12-13 06:25:44 +0000 | [diff] [blame] | 4194 | return true; |
| 4195 | } |
| 4196 | |
| 4197 | return Changed; |
| 4198 | } |
| 4199 | |
Hans Wennborg | 6800008 | 2015-01-26 19:52:32 +0000 | [diff] [blame] | 4200 | static bool CasesAreContiguous(SmallVectorImpl<ConstantInt *> &Cases) { |
| 4201 | assert(Cases.size() >= 1); |
| 4202 | |
| 4203 | array_pod_sort(Cases.begin(), Cases.end(), ConstantIntSortPredicate); |
| 4204 | for (size_t I = 1, E = Cases.size(); I != E; ++I) { |
| 4205 | if (Cases[I - 1]->getValue() != Cases[I]->getValue() + 1) |
| 4206 | return false; |
| 4207 | } |
| 4208 | return true; |
| 4209 | } |
| 4210 | |
| 4211 | /// Turn a switch with two reachable destinations into an integer range |
| 4212 | /// comparison and branch. |
Devang Patel | a7ec47d | 2011-05-18 20:35:38 +0000 | [diff] [blame] | 4213 | static bool TurnSwitchRangeIntoICmp(SwitchInst *SI, IRBuilder<> &Builder) { |
Stepan Dyatkovskiy | 513aaa5 | 2012-02-01 07:49:51 +0000 | [diff] [blame] | 4214 | assert(SI->getNumCases() > 1 && "Degenerate switch?"); |
Benjamin Kramer | f4ea1d5 | 2011-02-02 15:56:22 +0000 | [diff] [blame] | 4215 | |
Hans Wennborg | 6800008 | 2015-01-26 19:52:32 +0000 | [diff] [blame] | 4216 | bool HasDefault = |
| 4217 | !isa<UnreachableInst>(SI->getDefaultDest()->getFirstNonPHIOrDbg()); |
Benjamin Kramer | 62aa46b | 2011-02-03 22:51:41 +0000 | [diff] [blame] | 4218 | |
Hans Wennborg | 6800008 | 2015-01-26 19:52:32 +0000 | [diff] [blame] | 4219 | // Partition the cases into two sets with different destinations. |
| 4220 | BasicBlock *DestA = HasDefault ? SI->getDefaultDest() : nullptr; |
| 4221 | BasicBlock *DestB = nullptr; |
Dehao Chen | f6c0083 | 2016-05-18 19:44:21 +0000 | [diff] [blame] | 4222 | SmallVector<ConstantInt *, 16> CasesA; |
| 4223 | SmallVector<ConstantInt *, 16> CasesB; |
Hans Wennborg | 6800008 | 2015-01-26 19:52:32 +0000 | [diff] [blame] | 4224 | |
| 4225 | for (SwitchInst::CaseIt I : SI->cases()) { |
| 4226 | BasicBlock *Dest = I.getCaseSuccessor(); |
Dehao Chen | f6c0083 | 2016-05-18 19:44:21 +0000 | [diff] [blame] | 4227 | if (!DestA) |
| 4228 | DestA = Dest; |
Hans Wennborg | 6800008 | 2015-01-26 19:52:32 +0000 | [diff] [blame] | 4229 | if (Dest == DestA) { |
| 4230 | CasesA.push_back(I.getCaseValue()); |
| 4231 | continue; |
| 4232 | } |
Dehao Chen | f6c0083 | 2016-05-18 19:44:21 +0000 | [diff] [blame] | 4233 | if (!DestB) |
| 4234 | DestB = Dest; |
Hans Wennborg | 6800008 | 2015-01-26 19:52:32 +0000 | [diff] [blame] | 4235 | if (Dest == DestB) { |
| 4236 | CasesB.push_back(I.getCaseValue()); |
| 4237 | continue; |
| 4238 | } |
Dehao Chen | f6c0083 | 2016-05-18 19:44:21 +0000 | [diff] [blame] | 4239 | return false; // More than two destinations. |
Benjamin Kramer | 62aa46b | 2011-02-03 22:51:41 +0000 | [diff] [blame] | 4240 | } |
| 4241 | |
Dehao Chen | f6c0083 | 2016-05-18 19:44:21 +0000 | [diff] [blame] | 4242 | assert(DestA && DestB && |
| 4243 | "Single-destination switch should have been folded."); |
Hans Wennborg | 6800008 | 2015-01-26 19:52:32 +0000 | [diff] [blame] | 4244 | assert(DestA != DestB); |
| 4245 | assert(DestB != SI->getDefaultDest()); |
| 4246 | assert(!CasesB.empty() && "There must be non-default cases."); |
| 4247 | assert(!CasesA.empty() || HasDefault); |
| 4248 | |
| 4249 | // Figure out if one of the sets of cases form a contiguous range. |
| 4250 | SmallVectorImpl<ConstantInt *> *ContiguousCases = nullptr; |
| 4251 | BasicBlock *ContiguousDest = nullptr; |
| 4252 | BasicBlock *OtherDest = nullptr; |
| 4253 | if (!CasesA.empty() && CasesAreContiguous(CasesA)) { |
| 4254 | ContiguousCases = &CasesA; |
| 4255 | ContiguousDest = DestA; |
| 4256 | OtherDest = DestB; |
| 4257 | } else if (CasesAreContiguous(CasesB)) { |
| 4258 | ContiguousCases = &CasesB; |
| 4259 | ContiguousDest = DestB; |
| 4260 | OtherDest = DestA; |
| 4261 | } else |
| 4262 | return false; |
| 4263 | |
| 4264 | // Start building the compare and branch. |
| 4265 | |
| 4266 | Constant *Offset = ConstantExpr::getNeg(ContiguousCases->back()); |
Dehao Chen | f6c0083 | 2016-05-18 19:44:21 +0000 | [diff] [blame] | 4267 | Constant *NumCases = |
| 4268 | ConstantInt::get(Offset->getType(), ContiguousCases->size()); |
Benjamin Kramer | f4ea1d5 | 2011-02-02 15:56:22 +0000 | [diff] [blame] | 4269 | |
Benjamin Kramer | 8d6a8c1 | 2011-02-07 22:37:28 +0000 | [diff] [blame] | 4270 | Value *Sub = SI->getCondition(); |
| 4271 | if (!Offset->isNullValue()) |
Hans Wennborg | 6800008 | 2015-01-26 19:52:32 +0000 | [diff] [blame] | 4272 | Sub = Builder.CreateAdd(Sub, Offset, Sub->getName() + ".off"); |
| 4273 | |
Hans Wennborg | c9e1d99 | 2013-04-16 08:35:36 +0000 | [diff] [blame] | 4274 | Value *Cmp; |
| 4275 | // If NumCases overflowed, then all possible values jump to the successor. |
Hans Wennborg | 6800008 | 2015-01-26 19:52:32 +0000 | [diff] [blame] | 4276 | if (NumCases->isNullValue() && !ContiguousCases->empty()) |
Hans Wennborg | c9e1d99 | 2013-04-16 08:35:36 +0000 | [diff] [blame] | 4277 | Cmp = ConstantInt::getTrue(SI->getContext()); |
| 4278 | else |
| 4279 | Cmp = Builder.CreateICmpULT(Sub, NumCases, "switch"); |
Hans Wennborg | 6800008 | 2015-01-26 19:52:32 +0000 | [diff] [blame] | 4280 | BranchInst *NewBI = Builder.CreateCondBr(Cmp, ContiguousDest, OtherDest); |
Benjamin Kramer | f4ea1d5 | 2011-02-02 15:56:22 +0000 | [diff] [blame] | 4281 | |
Manman Ren | 5657555 | 2012-09-18 00:47:33 +0000 | [diff] [blame] | 4282 | // Update weight for the newly-created conditional branch. |
Hans Wennborg | 6800008 | 2015-01-26 19:52:32 +0000 | [diff] [blame] | 4283 | if (HasBranchWeights(SI)) { |
| 4284 | SmallVector<uint64_t, 8> Weights; |
Manman Ren | 5657555 | 2012-09-18 00:47:33 +0000 | [diff] [blame] | 4285 | GetBranchWeights(SI, Weights); |
| 4286 | if (Weights.size() == 1 + SI->getNumCases()) { |
Hans Wennborg | 6800008 | 2015-01-26 19:52:32 +0000 | [diff] [blame] | 4287 | uint64_t TrueWeight = 0; |
| 4288 | uint64_t FalseWeight = 0; |
| 4289 | for (size_t I = 0, E = Weights.size(); I != E; ++I) { |
| 4290 | if (SI->getSuccessor(I) == ContiguousDest) |
| 4291 | TrueWeight += Weights[I]; |
| 4292 | else |
| 4293 | FalseWeight += Weights[I]; |
| 4294 | } |
| 4295 | while (TrueWeight > UINT32_MAX || FalseWeight > UINT32_MAX) { |
| 4296 | TrueWeight /= 2; |
| 4297 | FalseWeight /= 2; |
| 4298 | } |
Manman Ren | 5657555 | 2012-09-18 00:47:33 +0000 | [diff] [blame] | 4299 | NewBI->setMetadata(LLVMContext::MD_prof, |
Dehao Chen | f6c0083 | 2016-05-18 19:44:21 +0000 | [diff] [blame] | 4300 | MDBuilder(SI->getContext()) |
| 4301 | .createBranchWeights((uint32_t)TrueWeight, |
| 4302 | (uint32_t)FalseWeight)); |
Manman Ren | 5657555 | 2012-09-18 00:47:33 +0000 | [diff] [blame] | 4303 | } |
| 4304 | } |
| 4305 | |
Hans Wennborg | 6800008 | 2015-01-26 19:52:32 +0000 | [diff] [blame] | 4306 | // Prune obsolete incoming values off the successors' PHI nodes. |
| 4307 | for (auto BBI = ContiguousDest->begin(); isa<PHINode>(BBI); ++BBI) { |
| 4308 | unsigned PreviousEdges = ContiguousCases->size(); |
Dehao Chen | f6c0083 | 2016-05-18 19:44:21 +0000 | [diff] [blame] | 4309 | if (ContiguousDest == SI->getDefaultDest()) |
| 4310 | ++PreviousEdges; |
Hans Wennborg | 6800008 | 2015-01-26 19:52:32 +0000 | [diff] [blame] | 4311 | for (unsigned I = 0, E = PreviousEdges - 1; I != E; ++I) |
Benjamin Kramer | f4ea1d5 | 2011-02-02 15:56:22 +0000 | [diff] [blame] | 4312 | cast<PHINode>(BBI)->removeIncomingValue(SI->getParent()); |
| 4313 | } |
Hans Wennborg | 6800008 | 2015-01-26 19:52:32 +0000 | [diff] [blame] | 4314 | for (auto BBI = OtherDest->begin(); isa<PHINode>(BBI); ++BBI) { |
| 4315 | unsigned PreviousEdges = SI->getNumCases() - ContiguousCases->size(); |
Dehao Chen | f6c0083 | 2016-05-18 19:44:21 +0000 | [diff] [blame] | 4316 | if (OtherDest == SI->getDefaultDest()) |
| 4317 | ++PreviousEdges; |
Hans Wennborg | 6800008 | 2015-01-26 19:52:32 +0000 | [diff] [blame] | 4318 | for (unsigned I = 0, E = PreviousEdges - 1; I != E; ++I) |
| 4319 | cast<PHINode>(BBI)->removeIncomingValue(SI->getParent()); |
| 4320 | } |
| 4321 | |
| 4322 | // Drop the switch. |
Benjamin Kramer | f4ea1d5 | 2011-02-02 15:56:22 +0000 | [diff] [blame] | 4323 | SI->eraseFromParent(); |
| 4324 | |
| 4325 | return true; |
| 4326 | } |
Chris Lattner | 25c3af3 | 2010-12-13 06:25:44 +0000 | [diff] [blame] | 4327 | |
Sanjay Patel | 09159b8f | 2015-06-24 20:40:57 +0000 | [diff] [blame] | 4328 | /// Compute masked bits for the condition of a switch |
Benjamin Kramer | d96205c | 2011-05-14 15:57:25 +0000 | [diff] [blame] | 4329 | /// and use it to remove dead cases. |
Hal Finkel | 3ca4a6b | 2016-12-15 03:02:15 +0000 | [diff] [blame] | 4330 | static bool EliminateDeadSwitchCases(SwitchInst *SI, const DataLayout &DL) { |
Benjamin Kramer | d96205c | 2011-05-14 15:57:25 +0000 | [diff] [blame] | 4331 | Value *Cond = SI->getCondition(); |
Matt Arsenault | 8227b9f | 2013-09-06 00:37:24 +0000 | [diff] [blame] | 4332 | unsigned Bits = Cond->getType()->getIntegerBitWidth(); |
Benjamin Kramer | d96205c | 2011-05-14 15:57:25 +0000 | [diff] [blame] | 4333 | APInt KnownZero(Bits, 0), KnownOne(Bits, 0); |
Hal Finkel | 3ca4a6b | 2016-12-15 03:02:15 +0000 | [diff] [blame] | 4334 | computeKnownBits(Cond, KnownZero, KnownOne, DL, 0, SI); |
Benjamin Kramer | d96205c | 2011-05-14 15:57:25 +0000 | [diff] [blame] | 4335 | |
Sanjay Patel | 75892a1 | 2016-05-20 14:53:09 +0000 | [diff] [blame] | 4336 | // We can also eliminate cases by determining that their values are outside of |
| 4337 | // the limited range of the condition based on how many significant (non-sign) |
| 4338 | // bits are in the condition value. |
Hal Finkel | 3ca4a6b | 2016-12-15 03:02:15 +0000 | [diff] [blame] | 4339 | unsigned ExtraSignBits = ComputeNumSignBits(Cond, DL, 0, SI) - 1; |
Sanjay Patel | 75892a1 | 2016-05-20 14:53:09 +0000 | [diff] [blame] | 4340 | unsigned MaxSignificantBitsInCond = Bits - ExtraSignBits; |
| 4341 | |
Benjamin Kramer | d96205c | 2011-05-14 15:57:25 +0000 | [diff] [blame] | 4342 | // Gather dead cases. |
Dehao Chen | f6c0083 | 2016-05-18 19:44:21 +0000 | [diff] [blame] | 4343 | SmallVector<ConstantInt *, 8> DeadCases; |
Sanjay Patel | 5d5134f | 2016-05-13 20:24:53 +0000 | [diff] [blame] | 4344 | for (auto &Case : SI->cases()) { |
Sanjay Patel | 75892a1 | 2016-05-20 14:53:09 +0000 | [diff] [blame] | 4345 | APInt CaseVal = Case.getCaseValue()->getValue(); |
| 4346 | if ((CaseVal & KnownZero) != 0 || (CaseVal & KnownOne) != KnownOne || |
| 4347 | (CaseVal.getMinSignedBits() > MaxSignificantBitsInCond)) { |
Sanjay Patel | 5d5134f | 2016-05-13 20:24:53 +0000 | [diff] [blame] | 4348 | DeadCases.push_back(Case.getCaseValue()); |
Sanjay Patel | 75892a1 | 2016-05-20 14:53:09 +0000 | [diff] [blame] | 4349 | DEBUG(dbgs() << "SimplifyCFG: switch case " << CaseVal << " is dead.\n"); |
Benjamin Kramer | d96205c | 2011-05-14 15:57:25 +0000 | [diff] [blame] | 4350 | } |
| 4351 | } |
| 4352 | |
Dehao Chen | f6c0083 | 2016-05-18 19:44:21 +0000 | [diff] [blame] | 4353 | // If we can prove that the cases must cover all possible values, the |
| 4354 | // default destination becomes dead and we can remove it. If we know some |
Philip Reames | 0537013 | 2015-09-10 17:44:47 +0000 | [diff] [blame] | 4355 | // of the bits in the value, we can use that to more precisely compute the |
| 4356 | // number of possible unique case values. |
Philip Reames | 98a2dab | 2015-08-26 23:56:46 +0000 | [diff] [blame] | 4357 | bool HasDefault = |
Dehao Chen | f6c0083 | 2016-05-18 19:44:21 +0000 | [diff] [blame] | 4358 | !isa<UnreachableInst>(SI->getDefaultDest()->getFirstNonPHIOrDbg()); |
| 4359 | const unsigned NumUnknownBits = |
| 4360 | Bits - (KnownZero.Or(KnownOne)).countPopulation(); |
Filipe Cabecinhas | 48b090a | 2015-09-10 22:34:39 +0000 | [diff] [blame] | 4361 | assert(NumUnknownBits <= Bits); |
Philip Reames | 0537013 | 2015-09-10 17:44:47 +0000 | [diff] [blame] | 4362 | if (HasDefault && DeadCases.empty() && |
Dehao Chen | f6c0083 | 2016-05-18 19:44:21 +0000 | [diff] [blame] | 4363 | NumUnknownBits < 64 /* avoid overflow */ && |
Philip Reames | 0537013 | 2015-09-10 17:44:47 +0000 | [diff] [blame] | 4364 | SI->getNumCases() == (1ULL << NumUnknownBits)) { |
Philip Reames | 98a2dab | 2015-08-26 23:56:46 +0000 | [diff] [blame] | 4365 | DEBUG(dbgs() << "SimplifyCFG: switch default is dead.\n"); |
Dehao Chen | f6c0083 | 2016-05-18 19:44:21 +0000 | [diff] [blame] | 4366 | BasicBlock *NewDefault = |
| 4367 | SplitBlockPredecessors(SI->getDefaultDest(), SI->getParent(), ""); |
Duncan P. N. Exon Smith | 5b4c837 | 2015-10-13 02:39:05 +0000 | [diff] [blame] | 4368 | SI->setDefaultDest(&*NewDefault); |
| 4369 | SplitBlock(&*NewDefault, &NewDefault->front()); |
Philip Reames | 98a2dab | 2015-08-26 23:56:46 +0000 | [diff] [blame] | 4370 | auto *OldTI = NewDefault->getTerminator(); |
| 4371 | new UnreachableInst(SI->getContext(), OldTI); |
| 4372 | EraseTerminatorInstAndDCECond(OldTI); |
| 4373 | return true; |
| 4374 | } |
| 4375 | |
Manman Ren | 5657555 | 2012-09-18 00:47:33 +0000 | [diff] [blame] | 4376 | SmallVector<uint64_t, 8> Weights; |
| 4377 | bool HasWeight = HasBranchWeights(SI); |
| 4378 | if (HasWeight) { |
| 4379 | GetBranchWeights(SI, Weights); |
| 4380 | HasWeight = (Weights.size() == 1 + SI->getNumCases()); |
| 4381 | } |
| 4382 | |
Benjamin Kramer | d96205c | 2011-05-14 15:57:25 +0000 | [diff] [blame] | 4383 | // Remove dead cases from the switch. |
Sanjay Patel | 5d5134f | 2016-05-13 20:24:53 +0000 | [diff] [blame] | 4384 | for (ConstantInt *DeadCase : DeadCases) { |
| 4385 | SwitchInst::CaseIt Case = SI->findCaseValue(DeadCase); |
Stepan Dyatkovskiy | 97b02fc | 2012-03-11 06:09:17 +0000 | [diff] [blame] | 4386 | assert(Case != SI->case_default() && |
Stepan Dyatkovskiy | 513aaa5 | 2012-02-01 07:49:51 +0000 | [diff] [blame] | 4387 | "Case was not found. Probably mistake in DeadCases forming."); |
Manman Ren | 5657555 | 2012-09-18 00:47:33 +0000 | [diff] [blame] | 4388 | if (HasWeight) { |
Dehao Chen | f6c0083 | 2016-05-18 19:44:21 +0000 | [diff] [blame] | 4389 | std::swap(Weights[Case.getCaseIndex() + 1], Weights.back()); |
Manman Ren | 5657555 | 2012-09-18 00:47:33 +0000 | [diff] [blame] | 4390 | Weights.pop_back(); |
| 4391 | } |
| 4392 | |
Benjamin Kramer | d96205c | 2011-05-14 15:57:25 +0000 | [diff] [blame] | 4393 | // Prune unused values from PHI nodes. |
Stepan Dyatkovskiy | 5b648af | 2012-03-08 07:06:20 +0000 | [diff] [blame] | 4394 | Case.getCaseSuccessor()->removePredecessor(SI->getParent()); |
Benjamin Kramer | d96205c | 2011-05-14 15:57:25 +0000 | [diff] [blame] | 4395 | SI->removeCase(Case); |
| 4396 | } |
Justin Bogner | 0ba3f21 | 2013-12-20 08:21:30 +0000 | [diff] [blame] | 4397 | if (HasWeight && Weights.size() >= 2) { |
Manman Ren | 5657555 | 2012-09-18 00:47:33 +0000 | [diff] [blame] | 4398 | SmallVector<uint32_t, 8> MDWeights(Weights.begin(), Weights.end()); |
| 4399 | SI->setMetadata(LLVMContext::MD_prof, |
Dehao Chen | f6c0083 | 2016-05-18 19:44:21 +0000 | [diff] [blame] | 4400 | MDBuilder(SI->getParent()->getContext()) |
| 4401 | .createBranchWeights(MDWeights)); |
Manman Ren | 5657555 | 2012-09-18 00:47:33 +0000 | [diff] [blame] | 4402 | } |
Benjamin Kramer | d96205c | 2011-05-14 15:57:25 +0000 | [diff] [blame] | 4403 | |
| 4404 | return !DeadCases.empty(); |
| 4405 | } |
| 4406 | |
Sanjay Patel | 09159b8f | 2015-06-24 20:40:57 +0000 | [diff] [blame] | 4407 | /// If BB would be eligible for simplification by |
| 4408 | /// TryToSimplifyUncondBranchFromEmptyBlock (i.e. it is empty and terminated |
Hans Wennborg | 4ab4a8e | 2011-06-18 10:28:47 +0000 | [diff] [blame] | 4409 | /// by an unconditional branch), look at the phi node for BB in the successor |
| 4410 | /// block and see if the incoming value is equal to CaseValue. If so, return |
| 4411 | /// the phi node, and set PhiIndex to BB's index in the phi node. |
| 4412 | static PHINode *FindPHIForConditionForwarding(ConstantInt *CaseValue, |
Dehao Chen | f6c0083 | 2016-05-18 19:44:21 +0000 | [diff] [blame] | 4413 | BasicBlock *BB, int *PhiIndex) { |
Hans Wennborg | 4ab4a8e | 2011-06-18 10:28:47 +0000 | [diff] [blame] | 4414 | if (BB->getFirstNonPHIOrDbg() != BB->getTerminator()) |
Craig Topper | f40110f | 2014-04-25 05:29:35 +0000 | [diff] [blame] | 4415 | return nullptr; // BB must be empty to be a candidate for simplification. |
Hans Wennborg | 4ab4a8e | 2011-06-18 10:28:47 +0000 | [diff] [blame] | 4416 | if (!BB->getSinglePredecessor()) |
Craig Topper | f40110f | 2014-04-25 05:29:35 +0000 | [diff] [blame] | 4417 | return nullptr; // BB must be dominated by the switch. |
Hans Wennborg | 4ab4a8e | 2011-06-18 10:28:47 +0000 | [diff] [blame] | 4418 | |
| 4419 | BranchInst *Branch = dyn_cast<BranchInst>(BB->getTerminator()); |
| 4420 | if (!Branch || !Branch->isUnconditional()) |
Craig Topper | f40110f | 2014-04-25 05:29:35 +0000 | [diff] [blame] | 4421 | return nullptr; // Terminator must be unconditional branch. |
Hans Wennborg | 4ab4a8e | 2011-06-18 10:28:47 +0000 | [diff] [blame] | 4422 | |
| 4423 | BasicBlock *Succ = Branch->getSuccessor(0); |
| 4424 | |
| 4425 | BasicBlock::iterator I = Succ->begin(); |
| 4426 | while (PHINode *PHI = dyn_cast<PHINode>(I++)) { |
| 4427 | int Idx = PHI->getBasicBlockIndex(BB); |
| 4428 | assert(Idx >= 0 && "PHI has no entry for predecessor?"); |
| 4429 | |
| 4430 | Value *InValue = PHI->getIncomingValue(Idx); |
Dehao Chen | f6c0083 | 2016-05-18 19:44:21 +0000 | [diff] [blame] | 4431 | if (InValue != CaseValue) |
| 4432 | continue; |
Hans Wennborg | 4ab4a8e | 2011-06-18 10:28:47 +0000 | [diff] [blame] | 4433 | |
| 4434 | *PhiIndex = Idx; |
| 4435 | return PHI; |
| 4436 | } |
| 4437 | |
Craig Topper | f40110f | 2014-04-25 05:29:35 +0000 | [diff] [blame] | 4438 | return nullptr; |
Hans Wennborg | 4ab4a8e | 2011-06-18 10:28:47 +0000 | [diff] [blame] | 4439 | } |
| 4440 | |
Sanjay Patel | 09159b8f | 2015-06-24 20:40:57 +0000 | [diff] [blame] | 4441 | /// Try to forward the condition of a switch instruction to a phi node |
| 4442 | /// dominated by the switch, if that would mean that some of the destination |
| 4443 | /// blocks of the switch can be folded away. |
Hans Wennborg | 4ab4a8e | 2011-06-18 10:28:47 +0000 | [diff] [blame] | 4444 | /// Returns true if a change is made. |
| 4445 | static bool ForwardSwitchConditionToPHI(SwitchInst *SI) { |
Dehao Chen | f6c0083 | 2016-05-18 19:44:21 +0000 | [diff] [blame] | 4446 | typedef DenseMap<PHINode *, SmallVector<int, 4>> ForwardingNodesMap; |
Hans Wennborg | 4ab4a8e | 2011-06-18 10:28:47 +0000 | [diff] [blame] | 4447 | ForwardingNodesMap ForwardingNodes; |
| 4448 | |
Dehao Chen | f6c0083 | 2016-05-18 19:44:21 +0000 | [diff] [blame] | 4449 | for (SwitchInst::CaseIt I = SI->case_begin(), E = SI->case_end(); I != E; |
| 4450 | ++I) { |
Stepan Dyatkovskiy | 5b648af | 2012-03-08 07:06:20 +0000 | [diff] [blame] | 4451 | ConstantInt *CaseValue = I.getCaseValue(); |
| 4452 | BasicBlock *CaseDest = I.getCaseSuccessor(); |
Hans Wennborg | 4ab4a8e | 2011-06-18 10:28:47 +0000 | [diff] [blame] | 4453 | |
| 4454 | int PhiIndex; |
Dehao Chen | f6c0083 | 2016-05-18 19:44:21 +0000 | [diff] [blame] | 4455 | PHINode *PHI = |
| 4456 | FindPHIForConditionForwarding(CaseValue, CaseDest, &PhiIndex); |
| 4457 | if (!PHI) |
| 4458 | continue; |
Hans Wennborg | 4ab4a8e | 2011-06-18 10:28:47 +0000 | [diff] [blame] | 4459 | |
| 4460 | ForwardingNodes[PHI].push_back(PhiIndex); |
| 4461 | } |
| 4462 | |
| 4463 | bool Changed = false; |
| 4464 | |
| 4465 | for (ForwardingNodesMap::iterator I = ForwardingNodes.begin(), |
Dehao Chen | f6c0083 | 2016-05-18 19:44:21 +0000 | [diff] [blame] | 4466 | E = ForwardingNodes.end(); |
| 4467 | I != E; ++I) { |
Hans Wennborg | 4ab4a8e | 2011-06-18 10:28:47 +0000 | [diff] [blame] | 4468 | PHINode *Phi = I->first; |
Craig Topper | b94011f | 2013-07-14 04:42:23 +0000 | [diff] [blame] | 4469 | SmallVectorImpl<int> &Indexes = I->second; |
Hans Wennborg | 4ab4a8e | 2011-06-18 10:28:47 +0000 | [diff] [blame] | 4470 | |
Dehao Chen | f6c0083 | 2016-05-18 19:44:21 +0000 | [diff] [blame] | 4471 | if (Indexes.size() < 2) |
| 4472 | continue; |
Hans Wennborg | 4ab4a8e | 2011-06-18 10:28:47 +0000 | [diff] [blame] | 4473 | |
| 4474 | for (size_t I = 0, E = Indexes.size(); I != E; ++I) |
| 4475 | Phi->setIncomingValue(Indexes[I], SI->getCondition()); |
| 4476 | Changed = true; |
| 4477 | } |
| 4478 | |
| 4479 | return Changed; |
| 4480 | } |
| 4481 | |
Sanjay Patel | 09159b8f | 2015-06-24 20:40:57 +0000 | [diff] [blame] | 4482 | /// Return true if the backend will be able to handle |
Hans Wennborg | 8a62fc5 | 2012-09-06 09:43:28 +0000 | [diff] [blame] | 4483 | /// initializing an array of constants like C. |
Oliver Stannard | 4df1cc0 | 2016-10-07 08:48:24 +0000 | [diff] [blame] | 4484 | static bool ValidLookupTableConstant(Constant *C, const TargetTransformInfo &TTI) { |
Hans Wennborg | 4dc8951 | 2014-06-20 00:38:12 +0000 | [diff] [blame] | 4485 | if (C->isThreadDependent()) |
| 4486 | return false; |
| 4487 | if (C->isDLLImportDependent()) |
| 4488 | return false; |
Hans Wennborg | 8a62fc5 | 2012-09-06 09:43:28 +0000 | [diff] [blame] | 4489 | |
Oliver Stannard | 4df1cc0 | 2016-10-07 08:48:24 +0000 | [diff] [blame] | 4490 | if (!isa<ConstantFP>(C) && !isa<ConstantInt>(C) && |
| 4491 | !isa<ConstantPointerNull>(C) && !isa<GlobalValue>(C) && |
| 4492 | !isa<UndefValue>(C) && !isa<ConstantExpr>(C)) |
| 4493 | return false; |
Hans Wennborg | b03ebfb | 2014-06-26 00:30:52 +0000 | [diff] [blame] | 4494 | |
Oliver Stannard | fe4432b | 2016-10-17 12:00:24 +0000 | [diff] [blame] | 4495 | if (ConstantExpr *CE = dyn_cast<ConstantExpr>(C)) { |
Oliver Stannard | 4df1cc0 | 2016-10-07 08:48:24 +0000 | [diff] [blame] | 4496 | if (!CE->isGEPWithNoNotionalOverIndexing()) |
| 4497 | return false; |
Oliver Stannard | fe4432b | 2016-10-17 12:00:24 +0000 | [diff] [blame] | 4498 | if (!ValidLookupTableConstant(CE->getOperand(0), TTI)) |
| 4499 | return false; |
| 4500 | } |
Oliver Stannard | 4df1cc0 | 2016-10-07 08:48:24 +0000 | [diff] [blame] | 4501 | |
| 4502 | if (!TTI.shouldBuildLookupTablesForConstant(C)) |
| 4503 | return false; |
| 4504 | |
| 4505 | return true; |
Hans Wennborg | 8a62fc5 | 2012-09-06 09:43:28 +0000 | [diff] [blame] | 4506 | } |
| 4507 | |
Sanjay Patel | 09159b8f | 2015-06-24 20:40:57 +0000 | [diff] [blame] | 4508 | /// If V is a Constant, return it. Otherwise, try to look up |
Hans Wennborg | 4fef2fe | 2012-10-31 15:31:09 +0000 | [diff] [blame] | 4509 | /// its constant value in ConstantPool, returning 0 if it's not there. |
Dehao Chen | f6c0083 | 2016-05-18 19:44:21 +0000 | [diff] [blame] | 4510 | static Constant * |
| 4511 | LookupConstant(Value *V, |
| 4512 | const SmallDenseMap<Value *, Constant *> &ConstantPool) { |
Hans Wennborg | 09acdb9 | 2012-10-31 15:14:39 +0000 | [diff] [blame] | 4513 | if (Constant *C = dyn_cast<Constant>(V)) |
| 4514 | return C; |
| 4515 | return ConstantPool.lookup(V); |
| 4516 | } |
| 4517 | |
Sanjay Patel | 09159b8f | 2015-06-24 20:40:57 +0000 | [diff] [blame] | 4518 | /// Try to fold instruction I into a constant. This works for |
Hans Wennborg | 9e74dd9 | 2012-10-31 13:42:45 +0000 | [diff] [blame] | 4519 | /// simple instructions such as binary operations where both operands are |
| 4520 | /// constant or can be replaced by constants from the ConstantPool. Returns the |
Hans Wennborg | 4fef2fe | 2012-10-31 15:31:09 +0000 | [diff] [blame] | 4521 | /// resulting constant on success, 0 otherwise. |
Benjamin Kramer | 7c30260 | 2013-11-12 12:24:36 +0000 | [diff] [blame] | 4522 | static Constant * |
Mehdi Amini | a28d91d | 2015-03-10 02:37:25 +0000 | [diff] [blame] | 4523 | ConstantFold(Instruction *I, const DataLayout &DL, |
| 4524 | const SmallDenseMap<Value *, Constant *> &ConstantPool) { |
Hans Wennborg | 9e74dd9 | 2012-10-31 13:42:45 +0000 | [diff] [blame] | 4525 | if (SelectInst *Select = dyn_cast<SelectInst>(I)) { |
Hans Wennborg | 09acdb9 | 2012-10-31 15:14:39 +0000 | [diff] [blame] | 4526 | Constant *A = LookupConstant(Select->getCondition(), ConstantPool); |
| 4527 | if (!A) |
Craig Topper | f40110f | 2014-04-25 05:29:35 +0000 | [diff] [blame] | 4528 | return nullptr; |
Hans Wennborg | 09acdb9 | 2012-10-31 15:14:39 +0000 | [diff] [blame] | 4529 | if (A->isAllOnesValue()) |
| 4530 | return LookupConstant(Select->getTrueValue(), ConstantPool); |
| 4531 | if (A->isNullValue()) |
| 4532 | return LookupConstant(Select->getFalseValue(), ConstantPool); |
Craig Topper | f40110f | 2014-04-25 05:29:35 +0000 | [diff] [blame] | 4533 | return nullptr; |
Hans Wennborg | 9e74dd9 | 2012-10-31 13:42:45 +0000 | [diff] [blame] | 4534 | } |
| 4535 | |
Benjamin Kramer | 7c30260 | 2013-11-12 12:24:36 +0000 | [diff] [blame] | 4536 | SmallVector<Constant *, 4> COps; |
| 4537 | for (unsigned N = 0, E = I->getNumOperands(); N != E; ++N) { |
| 4538 | if (Constant *A = LookupConstant(I->getOperand(N), ConstantPool)) |
| 4539 | COps.push_back(A); |
| 4540 | else |
Craig Topper | f40110f | 2014-04-25 05:29:35 +0000 | [diff] [blame] | 4541 | return nullptr; |
Hans Wennborg | 9e74dd9 | 2012-10-31 13:42:45 +0000 | [diff] [blame] | 4542 | } |
| 4543 | |
Mehdi Amini | a28d91d | 2015-03-10 02:37:25 +0000 | [diff] [blame] | 4544 | if (CmpInst *Cmp = dyn_cast<CmpInst>(I)) { |
Benjamin Kramer | 7c30260 | 2013-11-12 12:24:36 +0000 | [diff] [blame] | 4545 | return ConstantFoldCompareInstOperands(Cmp->getPredicate(), COps[0], |
| 4546 | COps[1], DL); |
Mehdi Amini | a28d91d | 2015-03-10 02:37:25 +0000 | [diff] [blame] | 4547 | } |
Benjamin Kramer | 7c30260 | 2013-11-12 12:24:36 +0000 | [diff] [blame] | 4548 | |
Manuel Jacob | e902459 | 2016-01-21 06:33:22 +0000 | [diff] [blame] | 4549 | return ConstantFoldInstOperands(I, COps, DL); |
Hans Wennborg | 9e74dd9 | 2012-10-31 13:42:45 +0000 | [diff] [blame] | 4550 | } |
| 4551 | |
Sanjay Patel | 09159b8f | 2015-06-24 20:40:57 +0000 | [diff] [blame] | 4552 | /// Try to determine the resulting constant values in phi nodes |
Hans Wennborg | 9e74dd9 | 2012-10-31 13:42:45 +0000 | [diff] [blame] | 4553 | /// at the common destination basic block, *CommonDest, for one of the case |
Hans Wennborg | 4fef2fe | 2012-10-31 15:31:09 +0000 | [diff] [blame] | 4554 | /// destionations CaseDest corresponding to value CaseVal (0 for the default |
Hans Wennborg | 9e74dd9 | 2012-10-31 13:42:45 +0000 | [diff] [blame] | 4555 | /// case), of a switch instruction SI. |
Craig Topper | b94011f | 2013-07-14 04:42:23 +0000 | [diff] [blame] | 4556 | static bool |
Mehdi Amini | a28d91d | 2015-03-10 02:37:25 +0000 | [diff] [blame] | 4557 | GetCaseResults(SwitchInst *SI, ConstantInt *CaseVal, BasicBlock *CaseDest, |
Craig Topper | b94011f | 2013-07-14 04:42:23 +0000 | [diff] [blame] | 4558 | BasicBlock **CommonDest, |
Eugene Zelenko | a3fe70d | 2016-11-30 17:48:10 +0000 | [diff] [blame] | 4559 | SmallVectorImpl<std::pair<PHINode *, Constant *>> &Res, |
Oliver Stannard | 4df1cc0 | 2016-10-07 08:48:24 +0000 | [diff] [blame] | 4560 | const DataLayout &DL, const TargetTransformInfo &TTI) { |
Hans Wennborg | 8a62fc5 | 2012-09-06 09:43:28 +0000 | [diff] [blame] | 4561 | // The block from which we enter the common destination. |
| 4562 | BasicBlock *Pred = SI->getParent(); |
| 4563 | |
Hans Wennborg | 9e74dd9 | 2012-10-31 13:42:45 +0000 | [diff] [blame] | 4564 | // If CaseDest is empty except for some side-effect free instructions through |
| 4565 | // which we can constant-propagate the CaseVal, continue to its successor. |
Dehao Chen | f6c0083 | 2016-05-18 19:44:21 +0000 | [diff] [blame] | 4566 | SmallDenseMap<Value *, Constant *> ConstantPool; |
Hans Wennborg | 9e74dd9 | 2012-10-31 13:42:45 +0000 | [diff] [blame] | 4567 | ConstantPool.insert(std::make_pair(SI->getCondition(), CaseVal)); |
| 4568 | for (BasicBlock::iterator I = CaseDest->begin(), E = CaseDest->end(); I != E; |
| 4569 | ++I) { |
| 4570 | if (TerminatorInst *T = dyn_cast<TerminatorInst>(I)) { |
| 4571 | // If the terminator is a simple branch, continue to the next block. |
David Majnemer | 8c03c1b | 2016-10-07 01:38:35 +0000 | [diff] [blame] | 4572 | if (T->getNumSuccessors() != 1 || T->isExceptional()) |
Hans Wennborg | 9e74dd9 | 2012-10-31 13:42:45 +0000 | [diff] [blame] | 4573 | return false; |
| 4574 | Pred = CaseDest; |
| 4575 | CaseDest = T->getSuccessor(0); |
| 4576 | } else if (isa<DbgInfoIntrinsic>(I)) { |
| 4577 | // Skip debug intrinsic. |
| 4578 | continue; |
Duncan P. N. Exon Smith | 5b4c837 | 2015-10-13 02:39:05 +0000 | [diff] [blame] | 4579 | } else if (Constant *C = ConstantFold(&*I, DL, ConstantPool)) { |
Hans Wennborg | 9e74dd9 | 2012-10-31 13:42:45 +0000 | [diff] [blame] | 4580 | // Instruction is side-effect free and constant. |
Hans Wennborg | dcc6e5b | 2015-01-09 22:13:31 +0000 | [diff] [blame] | 4581 | |
| 4582 | // If the instruction has uses outside this block or a phi node slot for |
| 4583 | // the block, it is not safe to bypass the instruction since it would then |
| 4584 | // no longer dominate all its uses. |
| 4585 | for (auto &Use : I->uses()) { |
| 4586 | User *User = Use.getUser(); |
| 4587 | if (Instruction *I = dyn_cast<Instruction>(User)) |
| 4588 | if (I->getParent() == CaseDest) |
| 4589 | continue; |
| 4590 | if (PHINode *Phi = dyn_cast<PHINode>(User)) |
| 4591 | if (Phi->getIncomingBlock(Use) == CaseDest) |
| 4592 | continue; |
| 4593 | return false; |
| 4594 | } |
| 4595 | |
Duncan P. N. Exon Smith | 5b4c837 | 2015-10-13 02:39:05 +0000 | [diff] [blame] | 4596 | ConstantPool.insert(std::make_pair(&*I, C)); |
Hans Wennborg | 9e74dd9 | 2012-10-31 13:42:45 +0000 | [diff] [blame] | 4597 | } else { |
| 4598 | break; |
| 4599 | } |
Hans Wennborg | 8a62fc5 | 2012-09-06 09:43:28 +0000 | [diff] [blame] | 4600 | } |
| 4601 | |
| 4602 | // If we did not have a CommonDest before, use the current one. |
| 4603 | if (!*CommonDest) |
| 4604 | *CommonDest = CaseDest; |
| 4605 | // If the destination isn't the common one, abort. |
| 4606 | if (CaseDest != *CommonDest) |
| 4607 | return false; |
| 4608 | |
| 4609 | // Get the values for this case from phi nodes in the destination block. |
| 4610 | BasicBlock::iterator I = (*CommonDest)->begin(); |
| 4611 | while (PHINode *PHI = dyn_cast<PHINode>(I++)) { |
| 4612 | int Idx = PHI->getBasicBlockIndex(Pred); |
| 4613 | if (Idx == -1) |
| 4614 | continue; |
| 4615 | |
Dehao Chen | f6c0083 | 2016-05-18 19:44:21 +0000 | [diff] [blame] | 4616 | Constant *ConstVal = |
| 4617 | LookupConstant(PHI->getIncomingValue(Idx), ConstantPool); |
Hans Wennborg | 9e74dd9 | 2012-10-31 13:42:45 +0000 | [diff] [blame] | 4618 | if (!ConstVal) |
Hans Wennborg | 8a62fc5 | 2012-09-06 09:43:28 +0000 | [diff] [blame] | 4619 | return false; |
| 4620 | |
| 4621 | // Be conservative about which kinds of constants we support. |
Oliver Stannard | 4df1cc0 | 2016-10-07 08:48:24 +0000 | [diff] [blame] | 4622 | if (!ValidLookupTableConstant(ConstVal, TTI)) |
Hans Wennborg | 8a62fc5 | 2012-09-06 09:43:28 +0000 | [diff] [blame] | 4623 | return false; |
| 4624 | |
| 4625 | Res.push_back(std::make_pair(PHI, ConstVal)); |
| 4626 | } |
| 4627 | |
Hans Wennborg | ac114a3 | 2014-01-12 00:44:41 +0000 | [diff] [blame] | 4628 | return Res.size() > 0; |
Hans Wennborg | 8a62fc5 | 2012-09-06 09:43:28 +0000 | [diff] [blame] | 4629 | } |
| 4630 | |
Sanjay Patel | 09159b8f | 2015-06-24 20:40:57 +0000 | [diff] [blame] | 4631 | // Helper function used to add CaseVal to the list of cases that generate |
| 4632 | // Result. |
Marcello Maggioni | 5bbe3df | 2014-10-14 01:58:26 +0000 | [diff] [blame] | 4633 | static void MapCaseToResult(ConstantInt *CaseVal, |
Dehao Chen | f6c0083 | 2016-05-18 19:44:21 +0000 | [diff] [blame] | 4634 | SwitchCaseResultVectorTy &UniqueResults, |
| 4635 | Constant *Result) { |
Marcello Maggioni | 5bbe3df | 2014-10-14 01:58:26 +0000 | [diff] [blame] | 4636 | for (auto &I : UniqueResults) { |
| 4637 | if (I.first == Result) { |
| 4638 | I.second.push_back(CaseVal); |
| 4639 | return; |
| 4640 | } |
| 4641 | } |
Dehao Chen | f6c0083 | 2016-05-18 19:44:21 +0000 | [diff] [blame] | 4642 | UniqueResults.push_back( |
| 4643 | std::make_pair(Result, SmallVector<ConstantInt *, 4>(1, CaseVal))); |
Marcello Maggioni | 5bbe3df | 2014-10-14 01:58:26 +0000 | [diff] [blame] | 4644 | } |
| 4645 | |
Sanjay Patel | 09159b8f | 2015-06-24 20:40:57 +0000 | [diff] [blame] | 4646 | // Helper function that initializes a map containing |
Marcello Maggioni | 5bbe3df | 2014-10-14 01:58:26 +0000 | [diff] [blame] | 4647 | // results for the PHI node of the common destination block for a switch |
| 4648 | // instruction. Returns false if multiple PHI nodes have been found or if |
| 4649 | // there is not a common destination block for the switch. |
Mehdi Amini | a28d91d | 2015-03-10 02:37:25 +0000 | [diff] [blame] | 4650 | static bool InitializeUniqueCases(SwitchInst *SI, PHINode *&PHI, |
| 4651 | BasicBlock *&CommonDest, |
| 4652 | SwitchCaseResultVectorTy &UniqueResults, |
| 4653 | Constant *&DefaultResult, |
Oliver Stannard | 4df1cc0 | 2016-10-07 08:48:24 +0000 | [diff] [blame] | 4654 | const DataLayout &DL, |
| 4655 | const TargetTransformInfo &TTI) { |
Marcello Maggioni | 5bbe3df | 2014-10-14 01:58:26 +0000 | [diff] [blame] | 4656 | for (auto &I : SI->cases()) { |
| 4657 | ConstantInt *CaseVal = I.getCaseValue(); |
| 4658 | |
| 4659 | // Resulting value at phi nodes for this case value. |
| 4660 | SwitchCaseResultsTy Results; |
| 4661 | if (!GetCaseResults(SI, CaseVal, I.getCaseSuccessor(), &CommonDest, Results, |
Oliver Stannard | 4df1cc0 | 2016-10-07 08:48:24 +0000 | [diff] [blame] | 4662 | DL, TTI)) |
Marcello Maggioni | 5bbe3df | 2014-10-14 01:58:26 +0000 | [diff] [blame] | 4663 | return false; |
| 4664 | |
| 4665 | // Only one value per case is permitted |
| 4666 | if (Results.size() > 1) |
| 4667 | return false; |
| 4668 | MapCaseToResult(CaseVal, UniqueResults, Results.begin()->second); |
| 4669 | |
| 4670 | // Check the PHI consistency. |
| 4671 | if (!PHI) |
| 4672 | PHI = Results[0].first; |
| 4673 | else if (PHI != Results[0].first) |
| 4674 | return false; |
| 4675 | } |
| 4676 | // Find the default result value. |
| 4677 | SmallVector<std::pair<PHINode *, Constant *>, 1> DefaultResults; |
| 4678 | BasicBlock *DefaultDest = SI->getDefaultDest(); |
| 4679 | GetCaseResults(SI, nullptr, SI->getDefaultDest(), &CommonDest, DefaultResults, |
Oliver Stannard | 4df1cc0 | 2016-10-07 08:48:24 +0000 | [diff] [blame] | 4680 | DL, TTI); |
Marcello Maggioni | 5bbe3df | 2014-10-14 01:58:26 +0000 | [diff] [blame] | 4681 | // If the default value is not found abort unless the default destination |
| 4682 | // is unreachable. |
| 4683 | DefaultResult = |
| 4684 | DefaultResults.size() == 1 ? DefaultResults.begin()->second : nullptr; |
| 4685 | if ((!DefaultResult && |
Dehao Chen | f6c0083 | 2016-05-18 19:44:21 +0000 | [diff] [blame] | 4686 | !isa<UnreachableInst>(DefaultDest->getFirstNonPHIOrDbg()))) |
Marcello Maggioni | 5bbe3df | 2014-10-14 01:58:26 +0000 | [diff] [blame] | 4687 | return false; |
| 4688 | |
| 4689 | return true; |
| 4690 | } |
| 4691 | |
Sanjay Patel | 09159b8f | 2015-06-24 20:40:57 +0000 | [diff] [blame] | 4692 | // Helper function that checks if it is possible to transform a switch with only |
| 4693 | // two cases (or two cases + default) that produces a result into a select. |
Marcello Maggioni | 5bbe3df | 2014-10-14 01:58:26 +0000 | [diff] [blame] | 4694 | // Example: |
| 4695 | // switch (a) { |
| 4696 | // case 10: %0 = icmp eq i32 %a, 10 |
| 4697 | // return 10; %1 = select i1 %0, i32 10, i32 4 |
| 4698 | // case 20: ----> %2 = icmp eq i32 %a, 20 |
| 4699 | // return 2; %3 = select i1 %2, i32 2, i32 %1 |
| 4700 | // default: |
| 4701 | // return 4; |
| 4702 | // } |
Dehao Chen | f6c0083 | 2016-05-18 19:44:21 +0000 | [diff] [blame] | 4703 | static Value *ConvertTwoCaseSwitch(const SwitchCaseResultVectorTy &ResultVector, |
| 4704 | Constant *DefaultResult, Value *Condition, |
| 4705 | IRBuilder<> &Builder) { |
Marcello Maggioni | 5bbe3df | 2014-10-14 01:58:26 +0000 | [diff] [blame] | 4706 | assert(ResultVector.size() == 2 && |
Dehao Chen | f6c0083 | 2016-05-18 19:44:21 +0000 | [diff] [blame] | 4707 | "We should have exactly two unique results at this point"); |
Marcello Maggioni | 5bbe3df | 2014-10-14 01:58:26 +0000 | [diff] [blame] | 4708 | // If we are selecting between only two cases transform into a simple |
| 4709 | // select or a two-way select if default is possible. |
| 4710 | if (ResultVector[0].second.size() == 1 && |
| 4711 | ResultVector[1].second.size() == 1) { |
| 4712 | ConstantInt *const FirstCase = ResultVector[0].second[0]; |
| 4713 | ConstantInt *const SecondCase = ResultVector[1].second[0]; |
| 4714 | |
| 4715 | bool DefaultCanTrigger = DefaultResult; |
| 4716 | Value *SelectValue = ResultVector[1].first; |
| 4717 | if (DefaultCanTrigger) { |
| 4718 | Value *const ValueCompare = |
| 4719 | Builder.CreateICmpEQ(Condition, SecondCase, "switch.selectcmp"); |
| 4720 | SelectValue = Builder.CreateSelect(ValueCompare, ResultVector[1].first, |
| 4721 | DefaultResult, "switch.select"); |
| 4722 | } |
| 4723 | Value *const ValueCompare = |
| 4724 | Builder.CreateICmpEQ(Condition, FirstCase, "switch.selectcmp"); |
Dehao Chen | f6c0083 | 2016-05-18 19:44:21 +0000 | [diff] [blame] | 4725 | return Builder.CreateSelect(ValueCompare, ResultVector[0].first, |
| 4726 | SelectValue, "switch.select"); |
Marcello Maggioni | 5bbe3df | 2014-10-14 01:58:26 +0000 | [diff] [blame] | 4727 | } |
| 4728 | |
| 4729 | return nullptr; |
| 4730 | } |
| 4731 | |
Sanjay Patel | 09159b8f | 2015-06-24 20:40:57 +0000 | [diff] [blame] | 4732 | // Helper function to cleanup a switch instruction that has been converted into |
| 4733 | // a select, fixing up PHI nodes and basic blocks. |
Marcello Maggioni | 5bbe3df | 2014-10-14 01:58:26 +0000 | [diff] [blame] | 4734 | static void RemoveSwitchAfterSelectConversion(SwitchInst *SI, PHINode *PHI, |
| 4735 | Value *SelectValue, |
| 4736 | IRBuilder<> &Builder) { |
| 4737 | BasicBlock *SelectBB = SI->getParent(); |
| 4738 | while (PHI->getBasicBlockIndex(SelectBB) >= 0) |
| 4739 | PHI->removeIncomingValue(SelectBB); |
| 4740 | PHI->addIncoming(SelectValue, SelectBB); |
| 4741 | |
| 4742 | Builder.CreateBr(PHI->getParent()); |
| 4743 | |
| 4744 | // Remove the switch. |
| 4745 | for (unsigned i = 0, e = SI->getNumSuccessors(); i < e; ++i) { |
| 4746 | BasicBlock *Succ = SI->getSuccessor(i); |
| 4747 | |
| 4748 | if (Succ == PHI->getParent()) |
| 4749 | continue; |
| 4750 | Succ->removePredecessor(SelectBB); |
| 4751 | } |
| 4752 | SI->eraseFromParent(); |
| 4753 | } |
| 4754 | |
Sanjay Patel | 09159b8f | 2015-06-24 20:40:57 +0000 | [diff] [blame] | 4755 | /// If the switch is only used to initialize one or more |
Marcello Maggioni | 5bbe3df | 2014-10-14 01:58:26 +0000 | [diff] [blame] | 4756 | /// phi nodes in a common successor block with only two different |
| 4757 | /// constant values, replace the switch with select. |
| 4758 | static bool SwitchToSelect(SwitchInst *SI, IRBuilder<> &Builder, |
Hal Finkel | 3ca4a6b | 2016-12-15 03:02:15 +0000 | [diff] [blame] | 4759 | const DataLayout &DL, |
Oliver Stannard | 4df1cc0 | 2016-10-07 08:48:24 +0000 | [diff] [blame] | 4760 | const TargetTransformInfo &TTI) { |
Marcello Maggioni | 5bbe3df | 2014-10-14 01:58:26 +0000 | [diff] [blame] | 4761 | Value *const Cond = SI->getCondition(); |
| 4762 | PHINode *PHI = nullptr; |
| 4763 | BasicBlock *CommonDest = nullptr; |
| 4764 | Constant *DefaultResult; |
| 4765 | SwitchCaseResultVectorTy UniqueResults; |
| 4766 | // Collect all the cases that will deliver the same value from the switch. |
Mehdi Amini | a28d91d | 2015-03-10 02:37:25 +0000 | [diff] [blame] | 4767 | if (!InitializeUniqueCases(SI, PHI, CommonDest, UniqueResults, DefaultResult, |
Oliver Stannard | 4df1cc0 | 2016-10-07 08:48:24 +0000 | [diff] [blame] | 4768 | DL, TTI)) |
Marcello Maggioni | 5bbe3df | 2014-10-14 01:58:26 +0000 | [diff] [blame] | 4769 | return false; |
| 4770 | // Selects choose between maximum two values. |
| 4771 | if (UniqueResults.size() != 2) |
| 4772 | return false; |
| 4773 | assert(PHI != nullptr && "PHI for value select not found"); |
| 4774 | |
| 4775 | Builder.SetInsertPoint(SI); |
Dehao Chen | f6c0083 | 2016-05-18 19:44:21 +0000 | [diff] [blame] | 4776 | Value *SelectValue = |
| 4777 | ConvertTwoCaseSwitch(UniqueResults, DefaultResult, Cond, Builder); |
Marcello Maggioni | 5bbe3df | 2014-10-14 01:58:26 +0000 | [diff] [blame] | 4778 | if (SelectValue) { |
| 4779 | RemoveSwitchAfterSelectConversion(SI, PHI, SelectValue, Builder); |
| 4780 | return true; |
| 4781 | } |
| 4782 | // The switch couldn't be converted into a select. |
| 4783 | return false; |
| 4784 | } |
| 4785 | |
Hans Wennborg | 776d712 | 2012-09-26 09:34:53 +0000 | [diff] [blame] | 4786 | namespace { |
Eugene Zelenko | a3fe70d | 2016-11-30 17:48:10 +0000 | [diff] [blame] | 4787 | |
Dehao Chen | f6c0083 | 2016-05-18 19:44:21 +0000 | [diff] [blame] | 4788 | /// This class represents a lookup table that can be used to replace a switch. |
| 4789 | class SwitchLookupTable { |
| 4790 | public: |
| 4791 | /// Create a lookup table to use as a switch replacement with the contents |
| 4792 | /// of Values, using DefaultValue to fill any holes in the table. |
| 4793 | SwitchLookupTable( |
| 4794 | Module &M, uint64_t TableSize, ConstantInt *Offset, |
| 4795 | const SmallVectorImpl<std::pair<ConstantInt *, Constant *>> &Values, |
| 4796 | Constant *DefaultValue, const DataLayout &DL); |
Hans Wennborg | 776d712 | 2012-09-26 09:34:53 +0000 | [diff] [blame] | 4797 | |
Dehao Chen | f6c0083 | 2016-05-18 19:44:21 +0000 | [diff] [blame] | 4798 | /// Build instructions with Builder to retrieve the value at |
| 4799 | /// the position given by Index in the lookup table. |
| 4800 | Value *BuildLookup(Value *Index, IRBuilder<> &Builder); |
Hans Wennborg | 776d712 | 2012-09-26 09:34:53 +0000 | [diff] [blame] | 4801 | |
Dehao Chen | f6c0083 | 2016-05-18 19:44:21 +0000 | [diff] [blame] | 4802 | /// Return true if a table with TableSize elements of |
| 4803 | /// type ElementType would fit in a target-legal register. |
| 4804 | static bool WouldFitInRegister(const DataLayout &DL, uint64_t TableSize, |
| 4805 | Type *ElementType); |
Hans Wennborg | 39583b8 | 2012-09-26 09:44:49 +0000 | [diff] [blame] | 4806 | |
Dehao Chen | f6c0083 | 2016-05-18 19:44:21 +0000 | [diff] [blame] | 4807 | private: |
| 4808 | // Depending on the contents of the table, it can be represented in |
| 4809 | // different ways. |
| 4810 | enum { |
| 4811 | // For tables where each element contains the same value, we just have to |
| 4812 | // store that single value and return it for each lookup. |
| 4813 | SingleValueKind, |
Hans Wennborg | 776d712 | 2012-09-26 09:34:53 +0000 | [diff] [blame] | 4814 | |
Dehao Chen | f6c0083 | 2016-05-18 19:44:21 +0000 | [diff] [blame] | 4815 | // For tables where there is a linear relationship between table index |
| 4816 | // and values. We calculate the result with a simple multiplication |
| 4817 | // and addition instead of a table lookup. |
| 4818 | LinearMapKind, |
Erik Eckstein | 105374f | 2014-11-17 09:13:57 +0000 | [diff] [blame] | 4819 | |
Dehao Chen | f6c0083 | 2016-05-18 19:44:21 +0000 | [diff] [blame] | 4820 | // For small tables with integer elements, we can pack them into a bitmap |
| 4821 | // that fits into a target-legal register. Values are retrieved by |
| 4822 | // shift and mask operations. |
| 4823 | BitMapKind, |
Hans Wennborg | 39583b8 | 2012-09-26 09:44:49 +0000 | [diff] [blame] | 4824 | |
Dehao Chen | f6c0083 | 2016-05-18 19:44:21 +0000 | [diff] [blame] | 4825 | // The table is stored as an array of values. Values are retrieved by load |
| 4826 | // instructions from the table. |
| 4827 | ArrayKind |
| 4828 | } Kind; |
Hans Wennborg | 776d712 | 2012-09-26 09:34:53 +0000 | [diff] [blame] | 4829 | |
Dehao Chen | f6c0083 | 2016-05-18 19:44:21 +0000 | [diff] [blame] | 4830 | // For SingleValueKind, this is the single value. |
| 4831 | Constant *SingleValue; |
Hans Wennborg | 776d712 | 2012-09-26 09:34:53 +0000 | [diff] [blame] | 4832 | |
Dehao Chen | f6c0083 | 2016-05-18 19:44:21 +0000 | [diff] [blame] | 4833 | // For BitMapKind, this is the bitmap. |
| 4834 | ConstantInt *BitMap; |
| 4835 | IntegerType *BitMapElementTy; |
Hans Wennborg | 39583b8 | 2012-09-26 09:44:49 +0000 | [diff] [blame] | 4836 | |
Dehao Chen | f6c0083 | 2016-05-18 19:44:21 +0000 | [diff] [blame] | 4837 | // For LinearMapKind, these are the constants used to derive the value. |
| 4838 | ConstantInt *LinearOffset; |
| 4839 | ConstantInt *LinearMultiplier; |
Erik Eckstein | 105374f | 2014-11-17 09:13:57 +0000 | [diff] [blame] | 4840 | |
Dehao Chen | f6c0083 | 2016-05-18 19:44:21 +0000 | [diff] [blame] | 4841 | // For ArrayKind, this is the array. |
| 4842 | GlobalVariable *Array; |
| 4843 | }; |
Eugene Zelenko | a3fe70d | 2016-11-30 17:48:10 +0000 | [diff] [blame] | 4844 | |
| 4845 | } // end anonymous namespace |
Hans Wennborg | 776d712 | 2012-09-26 09:34:53 +0000 | [diff] [blame] | 4846 | |
Mehdi Amini | a28d91d | 2015-03-10 02:37:25 +0000 | [diff] [blame] | 4847 | SwitchLookupTable::SwitchLookupTable( |
| 4848 | Module &M, uint64_t TableSize, ConstantInt *Offset, |
| 4849 | const SmallVectorImpl<std::pair<ConstantInt *, Constant *>> &Values, |
| 4850 | Constant *DefaultValue, const DataLayout &DL) |
Craig Topper | f40110f | 2014-04-25 05:29:35 +0000 | [diff] [blame] | 4851 | : SingleValue(nullptr), BitMap(nullptr), BitMapElementTy(nullptr), |
Erik Eckstein | 105374f | 2014-11-17 09:13:57 +0000 | [diff] [blame] | 4852 | LinearOffset(nullptr), LinearMultiplier(nullptr), Array(nullptr) { |
Hans Wennborg | f2e2c10 | 2012-09-26 11:07:37 +0000 | [diff] [blame] | 4853 | assert(Values.size() && "Can't build lookup table without values!"); |
| 4854 | assert(TableSize >= Values.size() && "Can't fit values in table!"); |
Hans Wennborg | 8a62fc5 | 2012-09-06 09:43:28 +0000 | [diff] [blame] | 4855 | |
| 4856 | // If all values in the table are equal, this is that value. |
Hans Wennborg | 776d712 | 2012-09-26 09:34:53 +0000 | [diff] [blame] | 4857 | SingleValue = Values.begin()->second; |
Hans Wennborg | 8a62fc5 | 2012-09-06 09:43:28 +0000 | [diff] [blame] | 4858 | |
Hans Wennborg | ac114a3 | 2014-01-12 00:44:41 +0000 | [diff] [blame] | 4859 | Type *ValueType = Values.begin()->second->getType(); |
| 4860 | |
Hans Wennborg | 8a62fc5 | 2012-09-06 09:43:28 +0000 | [diff] [blame] | 4861 | // Build up the table contents. |
Dehao Chen | f6c0083 | 2016-05-18 19:44:21 +0000 | [diff] [blame] | 4862 | SmallVector<Constant *, 64> TableContents(TableSize); |
Hans Wennborg | 776d712 | 2012-09-26 09:34:53 +0000 | [diff] [blame] | 4863 | for (size_t I = 0, E = Values.size(); I != E; ++I) { |
| 4864 | ConstantInt *CaseVal = Values[I].first; |
| 4865 | Constant *CaseRes = Values[I].second; |
Hans Wennborg | ac114a3 | 2014-01-12 00:44:41 +0000 | [diff] [blame] | 4866 | assert(CaseRes->getType() == ValueType); |
Hans Wennborg | 8a62fc5 | 2012-09-06 09:43:28 +0000 | [diff] [blame] | 4867 | |
Dehao Chen | f6c0083 | 2016-05-18 19:44:21 +0000 | [diff] [blame] | 4868 | uint64_t Idx = (CaseVal->getValue() - Offset->getValue()).getLimitedValue(); |
Hans Wennborg | 8a62fc5 | 2012-09-06 09:43:28 +0000 | [diff] [blame] | 4869 | TableContents[Idx] = CaseRes; |
| 4870 | |
Hans Wennborg | 776d712 | 2012-09-26 09:34:53 +0000 | [diff] [blame] | 4871 | if (CaseRes != SingleValue) |
Craig Topper | f40110f | 2014-04-25 05:29:35 +0000 | [diff] [blame] | 4872 | SingleValue = nullptr; |
Hans Wennborg | 8a62fc5 | 2012-09-06 09:43:28 +0000 | [diff] [blame] | 4873 | } |
| 4874 | |
| 4875 | // Fill in any holes in the table with the default result. |
Hans Wennborg | 776d712 | 2012-09-26 09:34:53 +0000 | [diff] [blame] | 4876 | if (Values.size() < TableSize) { |
Marcello Maggioni | 89c05ad | 2014-07-03 08:29:06 +0000 | [diff] [blame] | 4877 | assert(DefaultValue && |
| 4878 | "Need a default value to fill the lookup table holes."); |
Hans Wennborg | ac114a3 | 2014-01-12 00:44:41 +0000 | [diff] [blame] | 4879 | assert(DefaultValue->getType() == ValueType); |
Hans Wennborg | 776d712 | 2012-09-26 09:34:53 +0000 | [diff] [blame] | 4880 | for (uint64_t I = 0; I < TableSize; ++I) { |
| 4881 | if (!TableContents[I]) |
| 4882 | TableContents[I] = DefaultValue; |
Hans Wennborg | 8a62fc5 | 2012-09-06 09:43:28 +0000 | [diff] [blame] | 4883 | } |
| 4884 | |
Hans Wennborg | 776d712 | 2012-09-26 09:34:53 +0000 | [diff] [blame] | 4885 | if (DefaultValue != SingleValue) |
Craig Topper | f40110f | 2014-04-25 05:29:35 +0000 | [diff] [blame] | 4886 | SingleValue = nullptr; |
Hans Wennborg | 8a62fc5 | 2012-09-06 09:43:28 +0000 | [diff] [blame] | 4887 | } |
| 4888 | |
Hans Wennborg | 776d712 | 2012-09-26 09:34:53 +0000 | [diff] [blame] | 4889 | // If each element in the table contains the same value, we only need to store |
| 4890 | // that single value. |
| 4891 | if (SingleValue) { |
| 4892 | Kind = SingleValueKind; |
| 4893 | return; |
Hans Wennborg | 8a62fc5 | 2012-09-06 09:43:28 +0000 | [diff] [blame] | 4894 | } |
| 4895 | |
Erik Eckstein | 105374f | 2014-11-17 09:13:57 +0000 | [diff] [blame] | 4896 | // Check if we can derive the value with a linear transformation from the |
| 4897 | // table index. |
| 4898 | if (isa<IntegerType>(ValueType)) { |
| 4899 | bool LinearMappingPossible = true; |
| 4900 | APInt PrevVal; |
| 4901 | APInt DistToPrev; |
| 4902 | assert(TableSize >= 2 && "Should be a SingleValue table."); |
| 4903 | // Check if there is the same distance between two consecutive values. |
| 4904 | for (uint64_t I = 0; I < TableSize; ++I) { |
| 4905 | ConstantInt *ConstVal = dyn_cast<ConstantInt>(TableContents[I]); |
| 4906 | if (!ConstVal) { |
| 4907 | // This is an undef. We could deal with it, but undefs in lookup tables |
| 4908 | // are very seldom. It's probably not worth the additional complexity. |
| 4909 | LinearMappingPossible = false; |
| 4910 | break; |
| 4911 | } |
| 4912 | APInt Val = ConstVal->getValue(); |
| 4913 | if (I != 0) { |
| 4914 | APInt Dist = Val - PrevVal; |
| 4915 | if (I == 1) { |
| 4916 | DistToPrev = Dist; |
| 4917 | } else if (Dist != DistToPrev) { |
| 4918 | LinearMappingPossible = false; |
| 4919 | break; |
| 4920 | } |
| 4921 | } |
| 4922 | PrevVal = Val; |
| 4923 | } |
| 4924 | if (LinearMappingPossible) { |
| 4925 | LinearOffset = cast<ConstantInt>(TableContents[0]); |
| 4926 | LinearMultiplier = ConstantInt::get(M.getContext(), DistToPrev); |
| 4927 | Kind = LinearMapKind; |
| 4928 | ++NumLinearMaps; |
| 4929 | return; |
| 4930 | } |
| 4931 | } |
| 4932 | |
Hans Wennborg | 39583b8 | 2012-09-26 09:44:49 +0000 | [diff] [blame] | 4933 | // If the type is integer and the table fits in a register, build a bitmap. |
Rafael Espindola | 37dc9e1 | 2014-02-21 00:06:31 +0000 | [diff] [blame] | 4934 | if (WouldFitInRegister(DL, TableSize, ValueType)) { |
Hans Wennborg | ac114a3 | 2014-01-12 00:44:41 +0000 | [diff] [blame] | 4935 | IntegerType *IT = cast<IntegerType>(ValueType); |
Hans Wennborg | 39583b8 | 2012-09-26 09:44:49 +0000 | [diff] [blame] | 4936 | APInt TableInt(TableSize * IT->getBitWidth(), 0); |
| 4937 | for (uint64_t I = TableSize; I > 0; --I) { |
| 4938 | TableInt <<= IT->getBitWidth(); |
Benjamin Kramer | 9fc3dc7 | 2012-10-01 11:31:48 +0000 | [diff] [blame] | 4939 | // Insert values into the bitmap. Undef values are set to zero. |
| 4940 | if (!isa<UndefValue>(TableContents[I - 1])) { |
| 4941 | ConstantInt *Val = cast<ConstantInt>(TableContents[I - 1]); |
| 4942 | TableInt |= Val->getValue().zext(TableInt.getBitWidth()); |
| 4943 | } |
Hans Wennborg | 39583b8 | 2012-09-26 09:44:49 +0000 | [diff] [blame] | 4944 | } |
| 4945 | BitMap = ConstantInt::get(M.getContext(), TableInt); |
| 4946 | BitMapElementTy = IT; |
| 4947 | Kind = BitMapKind; |
| 4948 | ++NumBitMaps; |
| 4949 | return; |
| 4950 | } |
| 4951 | |
Hans Wennborg | 776d712 | 2012-09-26 09:34:53 +0000 | [diff] [blame] | 4952 | // Store the table in an array. |
Hans Wennborg | ac114a3 | 2014-01-12 00:44:41 +0000 | [diff] [blame] | 4953 | ArrayType *ArrayTy = ArrayType::get(ValueType, TableSize); |
Hans Wennborg | 8a62fc5 | 2012-09-06 09:43:28 +0000 | [diff] [blame] | 4954 | Constant *Initializer = ConstantArray::get(ArrayTy, TableContents); |
| 4955 | |
Dehao Chen | f6c0083 | 2016-05-18 19:44:21 +0000 | [diff] [blame] | 4956 | Array = new GlobalVariable(M, ArrayTy, /*constant=*/true, |
| 4957 | GlobalVariable::PrivateLinkage, Initializer, |
Hans Wennborg | 776d712 | 2012-09-26 09:34:53 +0000 | [diff] [blame] | 4958 | "switch.table"); |
Peter Collingbourne | 96efdd6 | 2016-06-14 21:01:22 +0000 | [diff] [blame] | 4959 | Array->setUnnamedAddr(GlobalValue::UnnamedAddr::Global); |
Hans Wennborg | 776d712 | 2012-09-26 09:34:53 +0000 | [diff] [blame] | 4960 | Kind = ArrayKind; |
| 4961 | } |
| 4962 | |
Manman Ren | 4d189fb | 2014-07-24 21:13:20 +0000 | [diff] [blame] | 4963 | Value *SwitchLookupTable::BuildLookup(Value *Index, IRBuilder<> &Builder) { |
Hans Wennborg | 776d712 | 2012-09-26 09:34:53 +0000 | [diff] [blame] | 4964 | switch (Kind) { |
Dehao Chen | f6c0083 | 2016-05-18 19:44:21 +0000 | [diff] [blame] | 4965 | case SingleValueKind: |
| 4966 | return SingleValue; |
| 4967 | case LinearMapKind: { |
| 4968 | // Derive the result value from the input value. |
| 4969 | Value *Result = Builder.CreateIntCast(Index, LinearMultiplier->getType(), |
| 4970 | false, "switch.idx.cast"); |
| 4971 | if (!LinearMultiplier->isOne()) |
| 4972 | Result = Builder.CreateMul(Result, LinearMultiplier, "switch.idx.mult"); |
| 4973 | if (!LinearOffset->isZero()) |
| 4974 | Result = Builder.CreateAdd(Result, LinearOffset, "switch.offset"); |
| 4975 | return Result; |
| 4976 | } |
| 4977 | case BitMapKind: { |
| 4978 | // Type of the bitmap (e.g. i59). |
| 4979 | IntegerType *MapTy = BitMap->getType(); |
Hans Wennborg | 39583b8 | 2012-09-26 09:44:49 +0000 | [diff] [blame] | 4980 | |
Dehao Chen | f6c0083 | 2016-05-18 19:44:21 +0000 | [diff] [blame] | 4981 | // Cast Index to the same type as the bitmap. |
| 4982 | // Note: The Index is <= the number of elements in the table, so |
| 4983 | // truncating it to the width of the bitmask is safe. |
| 4984 | Value *ShiftAmt = Builder.CreateZExtOrTrunc(Index, MapTy, "switch.cast"); |
Hans Wennborg | 39583b8 | 2012-09-26 09:44:49 +0000 | [diff] [blame] | 4985 | |
Dehao Chen | f6c0083 | 2016-05-18 19:44:21 +0000 | [diff] [blame] | 4986 | // Multiply the shift amount by the element width. |
| 4987 | ShiftAmt = Builder.CreateMul( |
| 4988 | ShiftAmt, ConstantInt::get(MapTy, BitMapElementTy->getBitWidth()), |
| 4989 | "switch.shiftamt"); |
Hans Wennborg | 39583b8 | 2012-09-26 09:44:49 +0000 | [diff] [blame] | 4990 | |
Dehao Chen | f6c0083 | 2016-05-18 19:44:21 +0000 | [diff] [blame] | 4991 | // Shift down. |
| 4992 | Value *DownShifted = |
| 4993 | Builder.CreateLShr(BitMap, ShiftAmt, "switch.downshift"); |
| 4994 | // Mask off. |
| 4995 | return Builder.CreateTrunc(DownShifted, BitMapElementTy, "switch.masked"); |
| 4996 | } |
| 4997 | case ArrayKind: { |
| 4998 | // Make sure the table index will not overflow when treated as signed. |
| 4999 | IntegerType *IT = cast<IntegerType>(Index->getType()); |
| 5000 | uint64_t TableSize = |
| 5001 | Array->getInitializer()->getType()->getArrayNumElements(); |
| 5002 | if (TableSize > (1ULL << (IT->getBitWidth() - 1))) |
| 5003 | Index = Builder.CreateZExt( |
| 5004 | Index, IntegerType::get(IT->getContext(), IT->getBitWidth() + 1), |
| 5005 | "switch.tableidx.zext"); |
Manman Ren | edc6037 | 2014-07-23 23:13:23 +0000 | [diff] [blame] | 5006 | |
Dehao Chen | f6c0083 | 2016-05-18 19:44:21 +0000 | [diff] [blame] | 5007 | Value *GEPIndices[] = {Builder.getInt32(0), Index}; |
| 5008 | Value *GEP = Builder.CreateInBoundsGEP(Array->getValueType(), Array, |
| 5009 | GEPIndices, "switch.gep"); |
| 5010 | return Builder.CreateLoad(GEP, "switch.load"); |
| 5011 | } |
Hans Wennborg | 776d712 | 2012-09-26 09:34:53 +0000 | [diff] [blame] | 5012 | } |
| 5013 | llvm_unreachable("Unknown lookup table kind!"); |
| 5014 | } |
| 5015 | |
Mehdi Amini | a28d91d | 2015-03-10 02:37:25 +0000 | [diff] [blame] | 5016 | bool SwitchLookupTable::WouldFitInRegister(const DataLayout &DL, |
Hans Wennborg | 39583b8 | 2012-09-26 09:44:49 +0000 | [diff] [blame] | 5017 | uint64_t TableSize, |
Craig Topper | e3dcce9 | 2015-08-01 22:20:21 +0000 | [diff] [blame] | 5018 | Type *ElementType) { |
| 5019 | auto *IT = dyn_cast<IntegerType>(ElementType); |
Hans Wennborg | 39583b8 | 2012-09-26 09:44:49 +0000 | [diff] [blame] | 5020 | if (!IT) |
| 5021 | return false; |
| 5022 | // FIXME: If the type is wider than it needs to be, e.g. i8 but all values |
| 5023 | // are <= 15, we could try to narrow the type. |
Benjamin Kramer | c2081d1 | 2012-09-27 18:29:58 +0000 | [diff] [blame] | 5024 | |
| 5025 | // Avoid overflow, fitsInLegalInteger uses unsigned int for the width. |
Dehao Chen | f6c0083 | 2016-05-18 19:44:21 +0000 | [diff] [blame] | 5026 | if (TableSize >= UINT_MAX / IT->getBitWidth()) |
Benjamin Kramer | c2081d1 | 2012-09-27 18:29:58 +0000 | [diff] [blame] | 5027 | return false; |
Mehdi Amini | a28d91d | 2015-03-10 02:37:25 +0000 | [diff] [blame] | 5028 | return DL.fitsInLegalInteger(TableSize * IT->getBitWidth()); |
Hans Wennborg | 39583b8 | 2012-09-26 09:44:49 +0000 | [diff] [blame] | 5029 | } |
| 5030 | |
Sanjay Patel | 09159b8f | 2015-06-24 20:40:57 +0000 | [diff] [blame] | 5031 | /// Determine whether a lookup table should be built for this switch, based on |
| 5032 | /// the number of cases, size of the table, and the types of the results. |
Mehdi Amini | a28d91d | 2015-03-10 02:37:25 +0000 | [diff] [blame] | 5033 | static bool |
| 5034 | ShouldBuildLookupTable(SwitchInst *SI, uint64_t TableSize, |
| 5035 | const TargetTransformInfo &TTI, const DataLayout &DL, |
| 5036 | const SmallDenseMap<PHINode *, Type *> &ResultTypes) { |
Hans Wennborg | f2e2c10 | 2012-09-26 11:07:37 +0000 | [diff] [blame] | 5037 | if (SI->getNumCases() > TableSize || TableSize >= UINT64_MAX / 10) |
| 5038 | return false; // TableSize overflowed, or mul below might overflow. |
Hans Wennborg | 776d712 | 2012-09-26 09:34:53 +0000 | [diff] [blame] | 5039 | |
Chandler Carruth | 77d433d | 2012-11-30 09:26:25 +0000 | [diff] [blame] | 5040 | bool AllTablesFitInRegister = true; |
Evan Cheng | 65df808 | 2012-11-30 02:02:42 +0000 | [diff] [blame] | 5041 | bool HasIllegalType = false; |
Hans Wennborg | a6a11a9 | 2014-11-18 02:37:11 +0000 | [diff] [blame] | 5042 | for (const auto &I : ResultTypes) { |
| 5043 | Type *Ty = I.second; |
Chandler Carruth | d9ef81e | 2012-11-30 09:34:29 +0000 | [diff] [blame] | 5044 | |
| 5045 | // Saturate this flag to true. |
Chandler Carruth | 0b4ef9c | 2013-01-07 03:53:25 +0000 | [diff] [blame] | 5046 | HasIllegalType = HasIllegalType || !TTI.isTypeLegal(Ty); |
Chandler Carruth | d9ef81e | 2012-11-30 09:34:29 +0000 | [diff] [blame] | 5047 | |
| 5048 | // Saturate this flag to false. |
Dehao Chen | f6c0083 | 2016-05-18 19:44:21 +0000 | [diff] [blame] | 5049 | AllTablesFitInRegister = |
| 5050 | AllTablesFitInRegister && |
| 5051 | SwitchLookupTable::WouldFitInRegister(DL, TableSize, Ty); |
Chandler Carruth | d9ef81e | 2012-11-30 09:34:29 +0000 | [diff] [blame] | 5052 | |
| 5053 | // If both flags saturate, we're done. NOTE: This *only* works with |
| 5054 | // saturating flags, and all flags have to saturate first due to the |
| 5055 | // non-deterministic behavior of iterating over a dense map. |
| 5056 | if (HasIllegalType && !AllTablesFitInRegister) |
Evan Cheng | 65df808 | 2012-11-30 02:02:42 +0000 | [diff] [blame] | 5057 | break; |
Hans Wennborg | 39583b8 | 2012-09-26 09:44:49 +0000 | [diff] [blame] | 5058 | } |
Evan Cheng | 65df808 | 2012-11-30 02:02:42 +0000 | [diff] [blame] | 5059 | |
Chandler Carruth | 77d433d | 2012-11-30 09:26:25 +0000 | [diff] [blame] | 5060 | // If each table would fit in a register, we should build it anyway. |
| 5061 | if (AllTablesFitInRegister) |
| 5062 | return true; |
| 5063 | |
| 5064 | // Don't build a table that doesn't fit in-register if it has illegal types. |
| 5065 | if (HasIllegalType) |
| 5066 | return false; |
| 5067 | |
| 5068 | // The table density should be at least 40%. This is the same criterion as for |
| 5069 | // jump tables, see SelectionDAGBuilder::handleJTSwitchCase. |
| 5070 | // FIXME: Find the best cut-off. |
| 5071 | return SI->getNumCases() * 10 >= TableSize * 4; |
Hans Wennborg | 8a62fc5 | 2012-09-06 09:43:28 +0000 | [diff] [blame] | 5072 | } |
| 5073 | |
Erik Eckstein | 0d86c76 | 2014-11-27 15:13:14 +0000 | [diff] [blame] | 5074 | /// Try to reuse the switch table index compare. Following pattern: |
| 5075 | /// \code |
| 5076 | /// if (idx < tablesize) |
| 5077 | /// r = table[idx]; // table does not contain default_value |
| 5078 | /// else |
| 5079 | /// r = default_value; |
| 5080 | /// if (r != default_value) |
| 5081 | /// ... |
| 5082 | /// \endcode |
| 5083 | /// Is optimized to: |
| 5084 | /// \code |
| 5085 | /// cond = idx < tablesize; |
| 5086 | /// if (cond) |
| 5087 | /// r = table[idx]; |
| 5088 | /// else |
| 5089 | /// r = default_value; |
| 5090 | /// if (cond) |
| 5091 | /// ... |
| 5092 | /// \endcode |
| 5093 | /// Jump threading will then eliminate the second if(cond). |
Dehao Chen | f6c0083 | 2016-05-18 19:44:21 +0000 | [diff] [blame] | 5094 | static void reuseTableCompare( |
| 5095 | User *PhiUser, BasicBlock *PhiBlock, BranchInst *RangeCheckBranch, |
| 5096 | Constant *DefaultValue, |
| 5097 | const SmallVectorImpl<std::pair<ConstantInt *, Constant *>> &Values) { |
Erik Eckstein | 0d86c76 | 2014-11-27 15:13:14 +0000 | [diff] [blame] | 5098 | |
| 5099 | ICmpInst *CmpInst = dyn_cast<ICmpInst>(PhiUser); |
| 5100 | if (!CmpInst) |
| 5101 | return; |
| 5102 | |
| 5103 | // We require that the compare is in the same block as the phi so that jump |
| 5104 | // threading can do its work afterwards. |
| 5105 | if (CmpInst->getParent() != PhiBlock) |
| 5106 | return; |
| 5107 | |
| 5108 | Constant *CmpOp1 = dyn_cast<Constant>(CmpInst->getOperand(1)); |
| 5109 | if (!CmpOp1) |
| 5110 | return; |
| 5111 | |
| 5112 | Value *RangeCmp = RangeCheckBranch->getCondition(); |
| 5113 | Constant *TrueConst = ConstantInt::getTrue(RangeCmp->getType()); |
| 5114 | Constant *FalseConst = ConstantInt::getFalse(RangeCmp->getType()); |
| 5115 | |
| 5116 | // Check if the compare with the default value is constant true or false. |
| 5117 | Constant *DefaultConst = ConstantExpr::getICmp(CmpInst->getPredicate(), |
| 5118 | DefaultValue, CmpOp1, true); |
| 5119 | if (DefaultConst != TrueConst && DefaultConst != FalseConst) |
| 5120 | return; |
| 5121 | |
| 5122 | // Check if the compare with the case values is distinct from the default |
| 5123 | // compare result. |
| 5124 | for (auto ValuePair : Values) { |
| 5125 | Constant *CaseConst = ConstantExpr::getICmp(CmpInst->getPredicate(), |
Dehao Chen | f6c0083 | 2016-05-18 19:44:21 +0000 | [diff] [blame] | 5126 | ValuePair.second, CmpOp1, true); |
Erik Eckstein | 0d86c76 | 2014-11-27 15:13:14 +0000 | [diff] [blame] | 5127 | if (!CaseConst || CaseConst == DefaultConst) |
| 5128 | return; |
| 5129 | assert((CaseConst == TrueConst || CaseConst == FalseConst) && |
| 5130 | "Expect true or false as compare result."); |
| 5131 | } |
Dehao Chen | f6c0083 | 2016-05-18 19:44:21 +0000 | [diff] [blame] | 5132 | |
Erik Eckstein | 0d86c76 | 2014-11-27 15:13:14 +0000 | [diff] [blame] | 5133 | // Check if the branch instruction dominates the phi node. It's a simple |
| 5134 | // dominance check, but sufficient for our needs. |
| 5135 | // Although this check is invariant in the calling loops, it's better to do it |
| 5136 | // at this late stage. Practically we do it at most once for a switch. |
| 5137 | BasicBlock *BranchBlock = RangeCheckBranch->getParent(); |
| 5138 | for (auto PI = pred_begin(PhiBlock), E = pred_end(PhiBlock); PI != E; ++PI) { |
| 5139 | BasicBlock *Pred = *PI; |
| 5140 | if (Pred != BranchBlock && Pred->getUniquePredecessor() != BranchBlock) |
| 5141 | return; |
| 5142 | } |
| 5143 | |
| 5144 | if (DefaultConst == FalseConst) { |
| 5145 | // The compare yields the same result. We can replace it. |
| 5146 | CmpInst->replaceAllUsesWith(RangeCmp); |
| 5147 | ++NumTableCmpReuses; |
| 5148 | } else { |
| 5149 | // The compare yields the same result, just inverted. We can replace it. |
Dehao Chen | f6c0083 | 2016-05-18 19:44:21 +0000 | [diff] [blame] | 5150 | Value *InvertedTableCmp = BinaryOperator::CreateXor( |
| 5151 | RangeCmp, ConstantInt::get(RangeCmp->getType(), 1), "inverted.cmp", |
| 5152 | RangeCheckBranch); |
Erik Eckstein | 0d86c76 | 2014-11-27 15:13:14 +0000 | [diff] [blame] | 5153 | CmpInst->replaceAllUsesWith(InvertedTableCmp); |
| 5154 | ++NumTableCmpReuses; |
| 5155 | } |
| 5156 | } |
| 5157 | |
Sanjay Patel | 09159b8f | 2015-06-24 20:40:57 +0000 | [diff] [blame] | 5158 | /// If the switch is only used to initialize one or more phi nodes in a common |
| 5159 | /// successor block with different constant values, replace the switch with |
| 5160 | /// lookup tables. |
Mehdi Amini | a28d91d | 2015-03-10 02:37:25 +0000 | [diff] [blame] | 5161 | static bool SwitchToLookupTable(SwitchInst *SI, IRBuilder<> &Builder, |
| 5162 | const DataLayout &DL, |
| 5163 | const TargetTransformInfo &TTI) { |
Hans Wennborg | 8a62fc5 | 2012-09-06 09:43:28 +0000 | [diff] [blame] | 5164 | assert(SI->getNumCases() > 1 && "Degenerate switch?"); |
Hans Wennborg | f325483 | 2012-10-30 11:23:25 +0000 | [diff] [blame] | 5165 | |
Hans Wennborg | c3c8d95 | 2012-11-07 21:35:12 +0000 | [diff] [blame] | 5166 | // Only build lookup table when we have a target that supports it. |
Chandler Carruth | 0b4ef9c | 2013-01-07 03:53:25 +0000 | [diff] [blame] | 5167 | if (!TTI.shouldBuildLookupTables()) |
Hans Wennborg | f325483 | 2012-10-30 11:23:25 +0000 | [diff] [blame] | 5168 | return false; |
| 5169 | |
Hans Wennborg | 8a62fc5 | 2012-09-06 09:43:28 +0000 | [diff] [blame] | 5170 | // FIXME: If the switch is too sparse for a lookup table, perhaps we could |
| 5171 | // split off a dense part and build a lookup table for that. |
| 5172 | |
Hans Wennborg | 8a62fc5 | 2012-09-06 09:43:28 +0000 | [diff] [blame] | 5173 | // FIXME: This creates arrays of GEPs to constant strings, which means each |
| 5174 | // GEP needs a runtime relocation in PIC code. We should just build one big |
| 5175 | // string and lookup indices into that. |
| 5176 | |
Dehao Chen | f6c0083 | 2016-05-18 19:44:21 +0000 | [diff] [blame] | 5177 | // Ignore switches with less than three cases. Lookup tables will not make |
| 5178 | // them |
Hans Wennborg | 4744ac1 | 2014-01-15 05:00:27 +0000 | [diff] [blame] | 5179 | // faster, so we don't analyze them. |
| 5180 | if (SI->getNumCases() < 3) |
Hans Wennborg | 8a62fc5 | 2012-09-06 09:43:28 +0000 | [diff] [blame] | 5181 | return false; |
| 5182 | |
| 5183 | // Figure out the corresponding result for each case value and phi node in the |
Eric Christopher | 572e03a | 2015-06-19 01:53:21 +0000 | [diff] [blame] | 5184 | // common destination, as well as the min and max case values. |
Hans Wennborg | 8a62fc5 | 2012-09-06 09:43:28 +0000 | [diff] [blame] | 5185 | assert(SI->case_begin() != SI->case_end()); |
| 5186 | SwitchInst::CaseIt CI = SI->case_begin(); |
| 5187 | ConstantInt *MinCaseVal = CI.getCaseValue(); |
| 5188 | ConstantInt *MaxCaseVal = CI.getCaseValue(); |
| 5189 | |
Craig Topper | f40110f | 2014-04-25 05:29:35 +0000 | [diff] [blame] | 5190 | BasicBlock *CommonDest = nullptr; |
Dehao Chen | f6c0083 | 2016-05-18 19:44:21 +0000 | [diff] [blame] | 5191 | typedef SmallVector<std::pair<ConstantInt *, Constant *>, 4> ResultListTy; |
| 5192 | SmallDenseMap<PHINode *, ResultListTy> ResultLists; |
| 5193 | SmallDenseMap<PHINode *, Constant *> DefaultResults; |
| 5194 | SmallDenseMap<PHINode *, Type *> ResultTypes; |
| 5195 | SmallVector<PHINode *, 4> PHIs; |
Hans Wennborg | 8a62fc5 | 2012-09-06 09:43:28 +0000 | [diff] [blame] | 5196 | |
| 5197 | for (SwitchInst::CaseIt E = SI->case_end(); CI != E; ++CI) { |
| 5198 | ConstantInt *CaseVal = CI.getCaseValue(); |
| 5199 | if (CaseVal->getValue().slt(MinCaseVal->getValue())) |
| 5200 | MinCaseVal = CaseVal; |
| 5201 | if (CaseVal->getValue().sgt(MaxCaseVal->getValue())) |
| 5202 | MaxCaseVal = CaseVal; |
| 5203 | |
| 5204 | // Resulting value at phi nodes for this case value. |
Dehao Chen | f6c0083 | 2016-05-18 19:44:21 +0000 | [diff] [blame] | 5205 | typedef SmallVector<std::pair<PHINode *, Constant *>, 4> ResultsTy; |
Hans Wennborg | 8a62fc5 | 2012-09-06 09:43:28 +0000 | [diff] [blame] | 5206 | ResultsTy Results; |
Hans Wennborg | 9e74dd9 | 2012-10-31 13:42:45 +0000 | [diff] [blame] | 5207 | if (!GetCaseResults(SI, CaseVal, CI.getCaseSuccessor(), &CommonDest, |
Oliver Stannard | 4df1cc0 | 2016-10-07 08:48:24 +0000 | [diff] [blame] | 5208 | Results, DL, TTI)) |
Hans Wennborg | 8a62fc5 | 2012-09-06 09:43:28 +0000 | [diff] [blame] | 5209 | return false; |
| 5210 | |
| 5211 | // Append the result from this case to the list for each phi. |
Hans Wennborg | a6a11a9 | 2014-11-18 02:37:11 +0000 | [diff] [blame] | 5212 | for (const auto &I : Results) { |
| 5213 | PHINode *PHI = I.first; |
| 5214 | Constant *Value = I.second; |
| 5215 | if (!ResultLists.count(PHI)) |
| 5216 | PHIs.push_back(PHI); |
| 5217 | ResultLists[PHI].push_back(std::make_pair(CaseVal, Value)); |
Hans Wennborg | 8a62fc5 | 2012-09-06 09:43:28 +0000 | [diff] [blame] | 5218 | } |
| 5219 | } |
| 5220 | |
Hans Wennborg | ac114a3 | 2014-01-12 00:44:41 +0000 | [diff] [blame] | 5221 | // Keep track of the result types. |
Hans Wennborg | a6a11a9 | 2014-11-18 02:37:11 +0000 | [diff] [blame] | 5222 | for (PHINode *PHI : PHIs) { |
Hans Wennborg | ac114a3 | 2014-01-12 00:44:41 +0000 | [diff] [blame] | 5223 | ResultTypes[PHI] = ResultLists[PHI][0].second->getType(); |
| 5224 | } |
| 5225 | |
| 5226 | uint64_t NumResults = ResultLists[PHIs[0]].size(); |
| 5227 | APInt RangeSpread = MaxCaseVal->getValue() - MinCaseVal->getValue(); |
| 5228 | uint64_t TableSize = RangeSpread.getLimitedValue() + 1; |
| 5229 | bool TableHasHoles = (NumResults < TableSize); |
| 5230 | |
Hans Wennborg | b73c0b0 | 2014-03-12 18:35:40 +0000 | [diff] [blame] | 5231 | // If the table has holes, we need a constant result for the default case |
| 5232 | // or a bitmask that fits in a register. |
Dehao Chen | f6c0083 | 2016-05-18 19:44:21 +0000 | [diff] [blame] | 5233 | SmallVector<std::pair<PHINode *, Constant *>, 4> DefaultResultsList; |
Oliver Stannard | 4df1cc0 | 2016-10-07 08:48:24 +0000 | [diff] [blame] | 5234 | bool HasDefaultResults = |
| 5235 | GetCaseResults(SI, nullptr, SI->getDefaultDest(), &CommonDest, |
| 5236 | DefaultResultsList, DL, TTI); |
Hans Wennborg | a6a11a9 | 2014-11-18 02:37:11 +0000 | [diff] [blame] | 5237 | |
Hans Wennborg | b73c0b0 | 2014-03-12 18:35:40 +0000 | [diff] [blame] | 5238 | bool NeedMask = (TableHasHoles && !HasDefaultResults); |
| 5239 | if (NeedMask) { |
| 5240 | // As an extra penalty for the validity test we require more cases. |
Dehao Chen | f6c0083 | 2016-05-18 19:44:21 +0000 | [diff] [blame] | 5241 | if (SI->getNumCases() < 4) // FIXME: Find best threshold value (benchmark). |
Hans Wennborg | b73c0b0 | 2014-03-12 18:35:40 +0000 | [diff] [blame] | 5242 | return false; |
Mehdi Amini | a28d91d | 2015-03-10 02:37:25 +0000 | [diff] [blame] | 5243 | if (!DL.fitsInLegalInteger(TableSize)) |
Hans Wennborg | b73c0b0 | 2014-03-12 18:35:40 +0000 | [diff] [blame] | 5244 | return false; |
| 5245 | } |
Hans Wennborg | ac114a3 | 2014-01-12 00:44:41 +0000 | [diff] [blame] | 5246 | |
Hans Wennborg | a6a11a9 | 2014-11-18 02:37:11 +0000 | [diff] [blame] | 5247 | for (const auto &I : DefaultResultsList) { |
| 5248 | PHINode *PHI = I.first; |
| 5249 | Constant *Result = I.second; |
Hans Wennborg | 7fd5c844 | 2012-09-10 07:44:22 +0000 | [diff] [blame] | 5250 | DefaultResults[PHI] = Result; |
Hans Wennborg | 8a62fc5 | 2012-09-06 09:43:28 +0000 | [diff] [blame] | 5251 | } |
| 5252 | |
Rafael Espindola | 37dc9e1 | 2014-02-21 00:06:31 +0000 | [diff] [blame] | 5253 | if (!ShouldBuildLookupTable(SI, TableSize, TTI, DL, ResultTypes)) |
Hans Wennborg | 8a62fc5 | 2012-09-06 09:43:28 +0000 | [diff] [blame] | 5254 | return false; |
| 5255 | |
Hans Wennborg | 8a62fc5 | 2012-09-06 09:43:28 +0000 | [diff] [blame] | 5256 | // Create the BB that does the lookups. |
Hans Wennborg | 776d712 | 2012-09-26 09:34:53 +0000 | [diff] [blame] | 5257 | Module &Mod = *CommonDest->getParent()->getParent(); |
Dehao Chen | f6c0083 | 2016-05-18 19:44:21 +0000 | [diff] [blame] | 5258 | BasicBlock *LookupBB = BasicBlock::Create( |
| 5259 | Mod.getContext(), "switch.lookup", CommonDest->getParent(), CommonDest); |
Hans Wennborg | 8a62fc5 | 2012-09-06 09:43:28 +0000 | [diff] [blame] | 5260 | |
Michael Gottesman | c024f32 | 2013-10-20 07:04:37 +0000 | [diff] [blame] | 5261 | // Compute the table index value. |
Hans Wennborg | 8a62fc5 | 2012-09-06 09:43:28 +0000 | [diff] [blame] | 5262 | Builder.SetInsertPoint(SI); |
Dehao Chen | f6c0083 | 2016-05-18 19:44:21 +0000 | [diff] [blame] | 5263 | Value *TableIndex = |
| 5264 | Builder.CreateSub(SI->getCondition(), MinCaseVal, "switch.tableidx"); |
Michael Gottesman | c024f32 | 2013-10-20 07:04:37 +0000 | [diff] [blame] | 5265 | |
| 5266 | // Compute the maximum table size representable by the integer type we are |
| 5267 | // switching upon. |
Michael Gottesman | 63c63ac | 2013-10-21 05:20:11 +0000 | [diff] [blame] | 5268 | unsigned CaseSize = MinCaseVal->getType()->getPrimitiveSizeInBits(); |
Hans Wennborg | ac114a3 | 2014-01-12 00:44:41 +0000 | [diff] [blame] | 5269 | uint64_t MaxTableSize = CaseSize > 63 ? UINT64_MAX : 1ULL << CaseSize; |
Michael Gottesman | c024f32 | 2013-10-20 07:04:37 +0000 | [diff] [blame] | 5270 | assert(MaxTableSize >= TableSize && |
| 5271 | "It is impossible for a switch to have more entries than the max " |
| 5272 | "representable value of its input integer type's size."); |
| 5273 | |
Hans Wennborg | b64cb27 | 2015-01-26 19:52:34 +0000 | [diff] [blame] | 5274 | // If the default destination is unreachable, or if the lookup table covers |
| 5275 | // all values of the conditional variable, branch directly to the lookup table |
| 5276 | // BB. Otherwise, check that the condition is within the case range. |
| 5277 | const bool DefaultIsReachable = |
| 5278 | !isa<UnreachableInst>(SI->getDefaultDest()->getFirstNonPHIOrDbg()); |
| 5279 | const bool GeneratingCoveredLookupTable = (MaxTableSize == TableSize); |
Erik Eckstein | 0d86c76 | 2014-11-27 15:13:14 +0000 | [diff] [blame] | 5280 | BranchInst *RangeCheckBranch = nullptr; |
| 5281 | |
Hans Wennborg | b64cb27 | 2015-01-26 19:52:34 +0000 | [diff] [blame] | 5282 | if (!DefaultIsReachable || GeneratingCoveredLookupTable) { |
Michael Gottesman | c024f32 | 2013-10-20 07:04:37 +0000 | [diff] [blame] | 5283 | Builder.CreateBr(LookupBB); |
Hans Wennborg | 86ac630 | 2015-04-24 20:57:56 +0000 | [diff] [blame] | 5284 | // Note: We call removeProdecessor later since we need to be able to get the |
| 5285 | // PHI value for the default case in case we're using a bit mask. |
Michael Gottesman | c024f32 | 2013-10-20 07:04:37 +0000 | [diff] [blame] | 5286 | } else { |
Dehao Chen | f6c0083 | 2016-05-18 19:44:21 +0000 | [diff] [blame] | 5287 | Value *Cmp = Builder.CreateICmpULT( |
| 5288 | TableIndex, ConstantInt::get(MinCaseVal->getType(), TableSize)); |
| 5289 | RangeCheckBranch = |
| 5290 | Builder.CreateCondBr(Cmp, LookupBB, SI->getDefaultDest()); |
Michael Gottesman | c024f32 | 2013-10-20 07:04:37 +0000 | [diff] [blame] | 5291 | } |
Hans Wennborg | 8a62fc5 | 2012-09-06 09:43:28 +0000 | [diff] [blame] | 5292 | |
| 5293 | // Populate the BB that does the lookups. |
| 5294 | Builder.SetInsertPoint(LookupBB); |
Hans Wennborg | b73c0b0 | 2014-03-12 18:35:40 +0000 | [diff] [blame] | 5295 | |
| 5296 | if (NeedMask) { |
| 5297 | // Before doing the lookup we do the hole check. |
| 5298 | // The LookupBB is therefore re-purposed to do the hole check |
| 5299 | // and we create a new LookupBB. |
| 5300 | BasicBlock *MaskBB = LookupBB; |
| 5301 | MaskBB->setName("switch.hole_check"); |
Dehao Chen | f6c0083 | 2016-05-18 19:44:21 +0000 | [diff] [blame] | 5302 | LookupBB = BasicBlock::Create(Mod.getContext(), "switch.lookup", |
| 5303 | CommonDest->getParent(), CommonDest); |
Hans Wennborg | b73c0b0 | 2014-03-12 18:35:40 +0000 | [diff] [blame] | 5304 | |
Juergen Ributzka | c9591e9 | 2014-11-17 19:39:56 +0000 | [diff] [blame] | 5305 | // Make the mask's bitwidth at least 8bit and a power-of-2 to avoid |
| 5306 | // unnecessary illegal types. |
| 5307 | uint64_t TableSizePowOf2 = NextPowerOf2(std::max(7ULL, TableSize - 1ULL)); |
| 5308 | APInt MaskInt(TableSizePowOf2, 0); |
| 5309 | APInt One(TableSizePowOf2, 1); |
Hans Wennborg | b73c0b0 | 2014-03-12 18:35:40 +0000 | [diff] [blame] | 5310 | // Build bitmask; fill in a 1 bit for every case. |
Hans Wennborg | b73c0b0 | 2014-03-12 18:35:40 +0000 | [diff] [blame] | 5311 | const ResultListTy &ResultList = ResultLists[PHIs[0]]; |
| 5312 | for (size_t I = 0, E = ResultList.size(); I != E; ++I) { |
Dehao Chen | f6c0083 | 2016-05-18 19:44:21 +0000 | [diff] [blame] | 5313 | uint64_t Idx = (ResultList[I].first->getValue() - MinCaseVal->getValue()) |
| 5314 | .getLimitedValue(); |
Hans Wennborg | b73c0b0 | 2014-03-12 18:35:40 +0000 | [diff] [blame] | 5315 | MaskInt |= One << Idx; |
| 5316 | } |
| 5317 | ConstantInt *TableMask = ConstantInt::get(Mod.getContext(), MaskInt); |
| 5318 | |
| 5319 | // Get the TableIndex'th bit of the bitmask. |
| 5320 | // If this bit is 0 (meaning hole) jump to the default destination, |
| 5321 | // else continue with table lookup. |
| 5322 | IntegerType *MapTy = TableMask->getType(); |
Dehao Chen | f6c0083 | 2016-05-18 19:44:21 +0000 | [diff] [blame] | 5323 | Value *MaskIndex = |
| 5324 | Builder.CreateZExtOrTrunc(TableIndex, MapTy, "switch.maskindex"); |
| 5325 | Value *Shifted = Builder.CreateLShr(TableMask, MaskIndex, "switch.shifted"); |
| 5326 | Value *LoBit = Builder.CreateTrunc( |
| 5327 | Shifted, Type::getInt1Ty(Mod.getContext()), "switch.lobit"); |
Hans Wennborg | b73c0b0 | 2014-03-12 18:35:40 +0000 | [diff] [blame] | 5328 | Builder.CreateCondBr(LoBit, LookupBB, SI->getDefaultDest()); |
| 5329 | |
| 5330 | Builder.SetInsertPoint(LookupBB); |
| 5331 | AddPredecessorToBlock(SI->getDefaultDest(), MaskBB, SI->getParent()); |
| 5332 | } |
| 5333 | |
Hans Wennborg | 86ac630 | 2015-04-24 20:57:56 +0000 | [diff] [blame] | 5334 | if (!DefaultIsReachable || GeneratingCoveredLookupTable) { |
| 5335 | // We cached PHINodes in PHIs, to avoid accessing deleted PHINodes later, |
| 5336 | // do not delete PHINodes here. |
| 5337 | SI->getDefaultDest()->removePredecessor(SI->getParent(), |
| 5338 | /*DontDeleteUselessPHIs=*/true); |
| 5339 | } |
| 5340 | |
Hans Wennborg | 8a62fc5 | 2012-09-06 09:43:28 +0000 | [diff] [blame] | 5341 | bool ReturnedEarly = false; |
Hans Wennborg | 776d712 | 2012-09-26 09:34:53 +0000 | [diff] [blame] | 5342 | for (size_t I = 0, E = PHIs.size(); I != E; ++I) { |
| 5343 | PHINode *PHI = PHIs[I]; |
Erik Eckstein | 0d86c76 | 2014-11-27 15:13:14 +0000 | [diff] [blame] | 5344 | const ResultListTy &ResultList = ResultLists[PHI]; |
Hans Wennborg | 8a62fc5 | 2012-09-06 09:43:28 +0000 | [diff] [blame] | 5345 | |
Hans Wennborg | b73c0b0 | 2014-03-12 18:35:40 +0000 | [diff] [blame] | 5346 | // If using a bitmask, use any value to fill the lookup table holes. |
| 5347 | Constant *DV = NeedMask ? ResultLists[PHI][0].second : DefaultResults[PHI]; |
Erik Eckstein | 0d86c76 | 2014-11-27 15:13:14 +0000 | [diff] [blame] | 5348 | SwitchLookupTable Table(Mod, TableSize, MinCaseVal, ResultList, DV, DL); |
Hans Wennborg | 776d712 | 2012-09-26 09:34:53 +0000 | [diff] [blame] | 5349 | |
Manman Ren | 4d189fb | 2014-07-24 21:13:20 +0000 | [diff] [blame] | 5350 | Value *Result = Table.BuildLookup(TableIndex, Builder); |
Hans Wennborg | 8a62fc5 | 2012-09-06 09:43:28 +0000 | [diff] [blame] | 5351 | |
Hans Wennborg | f744fa9 | 2012-09-19 14:24:21 +0000 | [diff] [blame] | 5352 | // If the result is used to return immediately from the function, we want to |
| 5353 | // do that right here. |
Chandler Carruth | cdf4788 | 2014-03-09 03:16:01 +0000 | [diff] [blame] | 5354 | if (PHI->hasOneUse() && isa<ReturnInst>(*PHI->user_begin()) && |
| 5355 | PHI->user_back() == CommonDest->getFirstNonPHIOrDbg()) { |
Hans Wennborg | f744fa9 | 2012-09-19 14:24:21 +0000 | [diff] [blame] | 5356 | Builder.CreateRet(Result); |
| 5357 | ReturnedEarly = true; |
| 5358 | break; |
Hans Wennborg | 8a62fc5 | 2012-09-06 09:43:28 +0000 | [diff] [blame] | 5359 | } |
| 5360 | |
Erik Eckstein | 0d86c76 | 2014-11-27 15:13:14 +0000 | [diff] [blame] | 5361 | // Do a small peephole optimization: re-use the switch table compare if |
| 5362 | // possible. |
| 5363 | if (!TableHasHoles && HasDefaultResults && RangeCheckBranch) { |
| 5364 | BasicBlock *PhiBlock = PHI->getParent(); |
| 5365 | // Search for compare instructions which use the phi. |
| 5366 | for (auto *User : PHI->users()) { |
| 5367 | reuseTableCompare(User, PhiBlock, RangeCheckBranch, DV, ResultList); |
| 5368 | } |
| 5369 | } |
| 5370 | |
Hans Wennborg | f744fa9 | 2012-09-19 14:24:21 +0000 | [diff] [blame] | 5371 | PHI->addIncoming(Result, LookupBB); |
Hans Wennborg | 8a62fc5 | 2012-09-06 09:43:28 +0000 | [diff] [blame] | 5372 | } |
| 5373 | |
| 5374 | if (!ReturnedEarly) |
| 5375 | Builder.CreateBr(CommonDest); |
| 5376 | |
| 5377 | // Remove the switch. |
Michael Gottesman | 63c63ac | 2013-10-21 05:20:11 +0000 | [diff] [blame] | 5378 | for (unsigned i = 0, e = SI->getNumSuccessors(); i < e; ++i) { |
Hans Wennborg | 8a62fc5 | 2012-09-06 09:43:28 +0000 | [diff] [blame] | 5379 | BasicBlock *Succ = SI->getSuccessor(i); |
Michael Gottesman | c024f32 | 2013-10-20 07:04:37 +0000 | [diff] [blame] | 5380 | |
Michael Gottesman | 63c63ac | 2013-10-21 05:20:11 +0000 | [diff] [blame] | 5381 | if (Succ == SI->getDefaultDest()) |
Michael Gottesman | c024f32 | 2013-10-20 07:04:37 +0000 | [diff] [blame] | 5382 | continue; |
Hans Wennborg | 8a62fc5 | 2012-09-06 09:43:28 +0000 | [diff] [blame] | 5383 | Succ->removePredecessor(SI->getParent()); |
| 5384 | } |
| 5385 | SI->eraseFromParent(); |
| 5386 | |
| 5387 | ++NumLookupTables; |
Hans Wennborg | b73c0b0 | 2014-03-12 18:35:40 +0000 | [diff] [blame] | 5388 | if (NeedMask) |
| 5389 | ++NumLookupTablesHoles; |
Hans Wennborg | 8a62fc5 | 2012-09-06 09:43:28 +0000 | [diff] [blame] | 5390 | return true; |
| 5391 | } |
| 5392 | |
James Molloy | b2e436d | 2016-08-01 07:45:11 +0000 | [diff] [blame] | 5393 | static bool isSwitchDense(ArrayRef<int64_t> Values) { |
| 5394 | // See also SelectionDAGBuilder::isDense(), which this function was based on. |
| 5395 | uint64_t Diff = (uint64_t)Values.back() - (uint64_t)Values.front(); |
| 5396 | uint64_t Range = Diff + 1; |
| 5397 | uint64_t NumCases = Values.size(); |
| 5398 | // 40% is the default density for building a jump table in optsize/minsize mode. |
| 5399 | uint64_t MinDensity = 40; |
Junmo Park | db8f6ee | 2016-08-02 04:38:27 +0000 | [diff] [blame] | 5400 | |
James Molloy | b2e436d | 2016-08-01 07:45:11 +0000 | [diff] [blame] | 5401 | return NumCases * 100 >= Range * MinDensity; |
| 5402 | } |
| 5403 | |
| 5404 | // Try and transform a switch that has "holes" in it to a contiguous sequence |
| 5405 | // of cases. |
| 5406 | // |
| 5407 | // A switch such as: switch(i) {case 5: case 9: case 13: case 17:} can be |
| 5408 | // range-reduced to: switch ((i-5) / 4) {case 0: case 1: case 2: case 3:}. |
| 5409 | // |
| 5410 | // This converts a sparse switch into a dense switch which allows better |
| 5411 | // lowering and could also allow transforming into a lookup table. |
| 5412 | static bool ReduceSwitchRange(SwitchInst *SI, IRBuilder<> &Builder, |
| 5413 | const DataLayout &DL, |
| 5414 | const TargetTransformInfo &TTI) { |
| 5415 | auto *CondTy = cast<IntegerType>(SI->getCondition()->getType()); |
| 5416 | if (CondTy->getIntegerBitWidth() > 64 || |
| 5417 | !DL.fitsInLegalInteger(CondTy->getIntegerBitWidth())) |
| 5418 | return false; |
| 5419 | // Only bother with this optimization if there are more than 3 switch cases; |
| 5420 | // SDAG will only bother creating jump tables for 4 or more cases. |
| 5421 | if (SI->getNumCases() < 4) |
| 5422 | return false; |
| 5423 | |
| 5424 | // This transform is agnostic to the signedness of the input or case values. We |
| 5425 | // can treat the case values as signed or unsigned. We can optimize more common |
| 5426 | // cases such as a sequence crossing zero {-4,0,4,8} if we interpret case values |
| 5427 | // as signed. |
| 5428 | SmallVector<int64_t,4> Values; |
| 5429 | for (auto &C : SI->cases()) |
| 5430 | Values.push_back(C.getCaseValue()->getValue().getSExtValue()); |
| 5431 | std::sort(Values.begin(), Values.end()); |
| 5432 | |
| 5433 | // If the switch is already dense, there's nothing useful to do here. |
| 5434 | if (isSwitchDense(Values)) |
| 5435 | return false; |
| 5436 | |
| 5437 | // First, transform the values such that they start at zero and ascend. |
| 5438 | int64_t Base = Values[0]; |
| 5439 | for (auto &V : Values) |
| 5440 | V -= Base; |
| 5441 | |
| 5442 | // Now we have signed numbers that have been shifted so that, given enough |
| 5443 | // precision, there are no negative values. Since the rest of the transform |
| 5444 | // is bitwise only, we switch now to an unsigned representation. |
| 5445 | uint64_t GCD = 0; |
| 5446 | for (auto &V : Values) |
Eugene Zelenko | a3fe70d | 2016-11-30 17:48:10 +0000 | [diff] [blame] | 5447 | GCD = GreatestCommonDivisor64(GCD, (uint64_t)V); |
James Molloy | b2e436d | 2016-08-01 07:45:11 +0000 | [diff] [blame] | 5448 | |
| 5449 | // This transform can be done speculatively because it is so cheap - it results |
| 5450 | // in a single rotate operation being inserted. This can only happen if the |
| 5451 | // factor extracted is a power of 2. |
| 5452 | // FIXME: If the GCD is an odd number we can multiply by the multiplicative |
| 5453 | // inverse of GCD and then perform this transform. |
| 5454 | // FIXME: It's possible that optimizing a switch on powers of two might also |
| 5455 | // be beneficial - flag values are often powers of two and we could use a CLZ |
| 5456 | // as the key function. |
Eugene Zelenko | a3fe70d | 2016-11-30 17:48:10 +0000 | [diff] [blame] | 5457 | if (GCD <= 1 || !isPowerOf2_64(GCD)) |
James Molloy | b2e436d | 2016-08-01 07:45:11 +0000 | [diff] [blame] | 5458 | // No common divisor found or too expensive to compute key function. |
| 5459 | return false; |
| 5460 | |
Eugene Zelenko | a3fe70d | 2016-11-30 17:48:10 +0000 | [diff] [blame] | 5461 | unsigned Shift = Log2_64(GCD); |
James Molloy | b2e436d | 2016-08-01 07:45:11 +0000 | [diff] [blame] | 5462 | for (auto &V : Values) |
| 5463 | V = (int64_t)((uint64_t)V >> Shift); |
| 5464 | |
| 5465 | if (!isSwitchDense(Values)) |
| 5466 | // Transform didn't create a dense switch. |
| 5467 | return false; |
| 5468 | |
| 5469 | // The obvious transform is to shift the switch condition right and emit a |
| 5470 | // check that the condition actually cleanly divided by GCD, i.e. |
| 5471 | // C & (1 << Shift - 1) == 0 |
| 5472 | // inserting a new CFG edge to handle the case where it didn't divide cleanly. |
| 5473 | // |
| 5474 | // A cheaper way of doing this is a simple ROTR(C, Shift). This performs the |
| 5475 | // shift and puts the shifted-off bits in the uppermost bits. If any of these |
| 5476 | // are nonzero then the switch condition will be very large and will hit the |
| 5477 | // default case. |
Junmo Park | db8f6ee | 2016-08-02 04:38:27 +0000 | [diff] [blame] | 5478 | |
James Molloy | b2e436d | 2016-08-01 07:45:11 +0000 | [diff] [blame] | 5479 | auto *Ty = cast<IntegerType>(SI->getCondition()->getType()); |
| 5480 | Builder.SetInsertPoint(SI); |
| 5481 | auto *ShiftC = ConstantInt::get(Ty, Shift); |
| 5482 | auto *Sub = Builder.CreateSub(SI->getCondition(), ConstantInt::get(Ty, Base)); |
Benjamin Kramer | aa160c2 | 2016-08-05 14:55:02 +0000 | [diff] [blame] | 5483 | auto *LShr = Builder.CreateLShr(Sub, ShiftC); |
| 5484 | auto *Shl = Builder.CreateShl(Sub, Ty->getBitWidth() - Shift); |
| 5485 | auto *Rot = Builder.CreateOr(LShr, Shl); |
James Molloy | b2e436d | 2016-08-01 07:45:11 +0000 | [diff] [blame] | 5486 | SI->replaceUsesOfWith(SI->getCondition(), Rot); |
| 5487 | |
James Molloy | bade86c | 2016-08-01 09:34:48 +0000 | [diff] [blame] | 5488 | for (SwitchInst::CaseIt C = SI->case_begin(), E = SI->case_end(); C != E; |
| 5489 | ++C) { |
James Molloy | b2e436d | 2016-08-01 07:45:11 +0000 | [diff] [blame] | 5490 | auto *Orig = C.getCaseValue(); |
| 5491 | auto Sub = Orig->getValue() - APInt(Ty->getBitWidth(), Base); |
James Molloy | bade86c | 2016-08-01 09:34:48 +0000 | [diff] [blame] | 5492 | C.setValue( |
| 5493 | cast<ConstantInt>(ConstantInt::get(Ty, Sub.lshr(ShiftC->getValue())))); |
James Molloy | b2e436d | 2016-08-01 07:45:11 +0000 | [diff] [blame] | 5494 | } |
| 5495 | return true; |
| 5496 | } |
| 5497 | |
Devang Patel | a7ec47d | 2011-05-18 20:35:38 +0000 | [diff] [blame] | 5498 | bool SimplifyCFGOpt::SimplifySwitch(SwitchInst *SI, IRBuilder<> &Builder) { |
Chris Lattner | 25c3af3 | 2010-12-13 06:25:44 +0000 | [diff] [blame] | 5499 | BasicBlock *BB = SI->getParent(); |
| 5500 | |
Jakob Stoklund Olesen | 977f41a | 2012-10-25 18:51:15 +0000 | [diff] [blame] | 5501 | if (isValueEqualityComparison(SI)) { |
| 5502 | // If we only have one predecessor, and if it is a branch on this value, |
| 5503 | // see if that predecessor totally determines the outcome of this switch. |
| 5504 | if (BasicBlock *OnlyPred = BB->getSinglePredecessor()) |
| 5505 | if (SimplifyEqualityComparisonWithOnlyPredecessor(SI, OnlyPred, Builder)) |
Hal Finkel | 3ca4a6b | 2016-12-15 03:02:15 +0000 | [diff] [blame] | 5506 | return SimplifyCFG(BB, TTI, BonusInstThreshold) | true; |
Frits van Bommel | 8ae0799 | 2011-02-28 09:44:07 +0000 | [diff] [blame] | 5507 | |
Jakob Stoklund Olesen | 977f41a | 2012-10-25 18:51:15 +0000 | [diff] [blame] | 5508 | Value *Cond = SI->getCondition(); |
| 5509 | if (SelectInst *Select = dyn_cast<SelectInst>(Cond)) |
| 5510 | if (SimplifySwitchOnSelect(SI, Select)) |
Hal Finkel | 3ca4a6b | 2016-12-15 03:02:15 +0000 | [diff] [blame] | 5511 | return SimplifyCFG(BB, TTI, BonusInstThreshold) | true; |
Frits van Bommel | 8ae0799 | 2011-02-28 09:44:07 +0000 | [diff] [blame] | 5512 | |
Jakob Stoklund Olesen | 977f41a | 2012-10-25 18:51:15 +0000 | [diff] [blame] | 5513 | // If the block only contains the switch, see if we can fold the block |
| 5514 | // away into any preds. |
| 5515 | BasicBlock::iterator BBI = BB->begin(); |
| 5516 | // Ignore dbg intrinsics. |
| 5517 | while (isa<DbgInfoIntrinsic>(BBI)) |
| 5518 | ++BBI; |
| 5519 | if (SI == &*BBI) |
| 5520 | if (FoldValueComparisonIntoPredecessors(SI, Builder)) |
Hal Finkel | 3ca4a6b | 2016-12-15 03:02:15 +0000 | [diff] [blame] | 5521 | return SimplifyCFG(BB, TTI, BonusInstThreshold) | true; |
Jakob Stoklund Olesen | 977f41a | 2012-10-25 18:51:15 +0000 | [diff] [blame] | 5522 | } |
Benjamin Kramer | f4ea1d5 | 2011-02-02 15:56:22 +0000 | [diff] [blame] | 5523 | |
| 5524 | // Try to transform the switch into an icmp and a branch. |
Devang Patel | a7ec47d | 2011-05-18 20:35:38 +0000 | [diff] [blame] | 5525 | if (TurnSwitchRangeIntoICmp(SI, Builder)) |
Hal Finkel | 3ca4a6b | 2016-12-15 03:02:15 +0000 | [diff] [blame] | 5526 | return SimplifyCFG(BB, TTI, BonusInstThreshold) | true; |
Benjamin Kramer | d96205c | 2011-05-14 15:57:25 +0000 | [diff] [blame] | 5527 | |
| 5528 | // Remove unreachable cases. |
Hal Finkel | 3ca4a6b | 2016-12-15 03:02:15 +0000 | [diff] [blame] | 5529 | if (EliminateDeadSwitchCases(SI, DL)) |
| 5530 | return SimplifyCFG(BB, TTI, BonusInstThreshold) | true; |
Benjamin Kramer | d96205c | 2011-05-14 15:57:25 +0000 | [diff] [blame] | 5531 | |
Hal Finkel | 3ca4a6b | 2016-12-15 03:02:15 +0000 | [diff] [blame] | 5532 | if (SwitchToSelect(SI, Builder, DL, TTI)) |
| 5533 | return SimplifyCFG(BB, TTI, BonusInstThreshold) | true; |
Marcello Maggioni | 5bbe3df | 2014-10-14 01:58:26 +0000 | [diff] [blame] | 5534 | |
Hans Wennborg | 4ab4a8e | 2011-06-18 10:28:47 +0000 | [diff] [blame] | 5535 | if (ForwardSwitchConditionToPHI(SI)) |
Hal Finkel | 3ca4a6b | 2016-12-15 03:02:15 +0000 | [diff] [blame] | 5536 | return SimplifyCFG(BB, TTI, BonusInstThreshold) | true; |
Hans Wennborg | 4ab4a8e | 2011-06-18 10:28:47 +0000 | [diff] [blame] | 5537 | |
Mehdi Amini | a28d91d | 2015-03-10 02:37:25 +0000 | [diff] [blame] | 5538 | if (SwitchToLookupTable(SI, Builder, DL, TTI)) |
Hal Finkel | 3ca4a6b | 2016-12-15 03:02:15 +0000 | [diff] [blame] | 5539 | return SimplifyCFG(BB, TTI, BonusInstThreshold) | true; |
Hans Wennborg | 8a62fc5 | 2012-09-06 09:43:28 +0000 | [diff] [blame] | 5540 | |
James Molloy | b2e436d | 2016-08-01 07:45:11 +0000 | [diff] [blame] | 5541 | if (ReduceSwitchRange(SI, Builder, DL, TTI)) |
Hal Finkel | 3ca4a6b | 2016-12-15 03:02:15 +0000 | [diff] [blame] | 5542 | return SimplifyCFG(BB, TTI, BonusInstThreshold) | true; |
James Molloy | b2e436d | 2016-08-01 07:45:11 +0000 | [diff] [blame] | 5543 | |
Chris Lattner | 25c3af3 | 2010-12-13 06:25:44 +0000 | [diff] [blame] | 5544 | return false; |
| 5545 | } |
| 5546 | |
| 5547 | bool SimplifyCFGOpt::SimplifyIndirectBr(IndirectBrInst *IBI) { |
| 5548 | BasicBlock *BB = IBI->getParent(); |
| 5549 | bool Changed = false; |
Andrew Trick | f3cf193 | 2012-08-29 21:46:36 +0000 | [diff] [blame] | 5550 | |
Chris Lattner | 25c3af3 | 2010-12-13 06:25:44 +0000 | [diff] [blame] | 5551 | // Eliminate redundant destinations. |
| 5552 | SmallPtrSet<Value *, 8> Succs; |
| 5553 | for (unsigned i = 0, e = IBI->getNumDestinations(); i != e; ++i) { |
| 5554 | BasicBlock *Dest = IBI->getDestination(i); |
David Blaikie | 70573dc | 2014-11-19 07:49:26 +0000 | [diff] [blame] | 5555 | if (!Dest->hasAddressTaken() || !Succs.insert(Dest).second) { |
Chris Lattner | 25c3af3 | 2010-12-13 06:25:44 +0000 | [diff] [blame] | 5556 | Dest->removePredecessor(BB); |
| 5557 | IBI->removeDestination(i); |
Dehao Chen | f6c0083 | 2016-05-18 19:44:21 +0000 | [diff] [blame] | 5558 | --i; |
| 5559 | --e; |
Chris Lattner | 25c3af3 | 2010-12-13 06:25:44 +0000 | [diff] [blame] | 5560 | Changed = true; |
| 5561 | } |
Andrew Trick | f3cf193 | 2012-08-29 21:46:36 +0000 | [diff] [blame] | 5562 | } |
Chris Lattner | 25c3af3 | 2010-12-13 06:25:44 +0000 | [diff] [blame] | 5563 | |
| 5564 | if (IBI->getNumDestinations() == 0) { |
| 5565 | // If the indirectbr has no successors, change it to unreachable. |
| 5566 | new UnreachableInst(IBI->getContext(), IBI); |
| 5567 | EraseTerminatorInstAndDCECond(IBI); |
| 5568 | return true; |
| 5569 | } |
Andrew Trick | f3cf193 | 2012-08-29 21:46:36 +0000 | [diff] [blame] | 5570 | |
Chris Lattner | 25c3af3 | 2010-12-13 06:25:44 +0000 | [diff] [blame] | 5571 | if (IBI->getNumDestinations() == 1) { |
| 5572 | // If the indirectbr has one successor, change it to a direct branch. |
| 5573 | BranchInst::Create(IBI->getDestination(0), IBI); |
| 5574 | EraseTerminatorInstAndDCECond(IBI); |
| 5575 | return true; |
| 5576 | } |
Andrew Trick | f3cf193 | 2012-08-29 21:46:36 +0000 | [diff] [blame] | 5577 | |
Chris Lattner | 25c3af3 | 2010-12-13 06:25:44 +0000 | [diff] [blame] | 5578 | if (SelectInst *SI = dyn_cast<SelectInst>(IBI->getAddress())) { |
| 5579 | if (SimplifyIndirectBrOnSelect(IBI, SI)) |
Hal Finkel | 3ca4a6b | 2016-12-15 03:02:15 +0000 | [diff] [blame] | 5580 | return SimplifyCFG(BB, TTI, BonusInstThreshold) | true; |
Chris Lattner | 25c3af3 | 2010-12-13 06:25:44 +0000 | [diff] [blame] | 5581 | } |
| 5582 | return Changed; |
| 5583 | } |
| 5584 | |
Philip Reames | 2b969d7 | 2015-03-24 22:28:45 +0000 | [diff] [blame] | 5585 | /// Given an block with only a single landing pad and a unconditional branch |
| 5586 | /// try to find another basic block which this one can be merged with. This |
| 5587 | /// handles cases where we have multiple invokes with unique landing pads, but |
| 5588 | /// a shared handler. |
| 5589 | /// |
| 5590 | /// We specifically choose to not worry about merging non-empty blocks |
| 5591 | /// here. That is a PRE/scheduling problem and is best solved elsewhere. In |
| 5592 | /// practice, the optimizer produces empty landing pad blocks quite frequently |
| 5593 | /// when dealing with exception dense code. (see: instcombine, gvn, if-else |
| 5594 | /// sinking in this file) |
| 5595 | /// |
| 5596 | /// This is primarily a code size optimization. We need to avoid performing |
| 5597 | /// any transform which might inhibit optimization (such as our ability to |
| 5598 | /// specialize a particular handler via tail commoning). We do this by not |
| 5599 | /// merging any blocks which require us to introduce a phi. Since the same |
| 5600 | /// values are flowing through both blocks, we don't loose any ability to |
| 5601 | /// specialize. If anything, we make such specialization more likely. |
| 5602 | /// |
| 5603 | /// TODO - This transformation could remove entries from a phi in the target |
| 5604 | /// block when the inputs in the phi are the same for the two blocks being |
| 5605 | /// merged. In some cases, this could result in removal of the PHI entirely. |
| 5606 | static bool TryToMergeLandingPad(LandingPadInst *LPad, BranchInst *BI, |
| 5607 | BasicBlock *BB) { |
| 5608 | auto Succ = BB->getUniqueSuccessor(); |
| 5609 | assert(Succ); |
| 5610 | // If there's a phi in the successor block, we'd likely have to introduce |
| 5611 | // a phi into the merged landing pad block. |
| 5612 | if (isa<PHINode>(*Succ->begin())) |
| 5613 | return false; |
| 5614 | |
| 5615 | for (BasicBlock *OtherPred : predecessors(Succ)) { |
| 5616 | if (BB == OtherPred) |
| 5617 | continue; |
| 5618 | BasicBlock::iterator I = OtherPred->begin(); |
| 5619 | LandingPadInst *LPad2 = dyn_cast<LandingPadInst>(I); |
| 5620 | if (!LPad2 || !LPad2->isIdenticalTo(LPad)) |
| 5621 | continue; |
Dehao Chen | f6c0083 | 2016-05-18 19:44:21 +0000 | [diff] [blame] | 5622 | for (++I; isa<DbgInfoIntrinsic>(I); ++I) { |
| 5623 | } |
Philip Reames | 2b969d7 | 2015-03-24 22:28:45 +0000 | [diff] [blame] | 5624 | BranchInst *BI2 = dyn_cast<BranchInst>(I); |
| 5625 | if (!BI2 || !BI2->isIdenticalTo(BI)) |
| 5626 | continue; |
| 5627 | |
David Majnemer | 1efa23d | 2016-02-20 01:07:45 +0000 | [diff] [blame] | 5628 | // We've found an identical block. Update our predecessors to take that |
Philip Reames | 2b969d7 | 2015-03-24 22:28:45 +0000 | [diff] [blame] | 5629 | // path instead and make ourselves dead. |
| 5630 | SmallSet<BasicBlock *, 16> Preds; |
| 5631 | Preds.insert(pred_begin(BB), pred_end(BB)); |
| 5632 | for (BasicBlock *Pred : Preds) { |
| 5633 | InvokeInst *II = cast<InvokeInst>(Pred->getTerminator()); |
Dehao Chen | f6c0083 | 2016-05-18 19:44:21 +0000 | [diff] [blame] | 5634 | assert(II->getNormalDest() != BB && II->getUnwindDest() == BB && |
| 5635 | "unexpected successor"); |
Philip Reames | 2b969d7 | 2015-03-24 22:28:45 +0000 | [diff] [blame] | 5636 | II->setUnwindDest(OtherPred); |
| 5637 | } |
| 5638 | |
| 5639 | // The debug info in OtherPred doesn't cover the merged control flow that |
| 5640 | // used to go through BB. We need to delete it or update it. |
Dehao Chen | f6c0083 | 2016-05-18 19:44:21 +0000 | [diff] [blame] | 5641 | for (auto I = OtherPred->begin(), E = OtherPred->end(); I != E;) { |
| 5642 | Instruction &Inst = *I; |
| 5643 | I++; |
Philip Reames | 2b969d7 | 2015-03-24 22:28:45 +0000 | [diff] [blame] | 5644 | if (isa<DbgInfoIntrinsic>(Inst)) |
| 5645 | Inst.eraseFromParent(); |
| 5646 | } |
| 5647 | |
| 5648 | SmallSet<BasicBlock *, 16> Succs; |
| 5649 | Succs.insert(succ_begin(BB), succ_end(BB)); |
| 5650 | for (BasicBlock *Succ : Succs) { |
| 5651 | Succ->removePredecessor(BB); |
| 5652 | } |
| 5653 | |
| 5654 | IRBuilder<> Builder(BI); |
| 5655 | Builder.CreateUnreachable(); |
| 5656 | BI->eraseFromParent(); |
| 5657 | return true; |
| 5658 | } |
| 5659 | return false; |
| 5660 | } |
| 5661 | |
Dehao Chen | f6c0083 | 2016-05-18 19:44:21 +0000 | [diff] [blame] | 5662 | bool SimplifyCFGOpt::SimplifyUncondBranch(BranchInst *BI, |
| 5663 | IRBuilder<> &Builder) { |
Chris Lattner | 25c3af3 | 2010-12-13 06:25:44 +0000 | [diff] [blame] | 5664 | BasicBlock *BB = BI->getParent(); |
Andrew Trick | f3cf193 | 2012-08-29 21:46:36 +0000 | [diff] [blame] | 5665 | |
Manman Ren | 93ab649 | 2012-09-20 22:37:36 +0000 | [diff] [blame] | 5666 | if (SinkCommon && SinkThenElseCodeToEnd(BI)) |
| 5667 | return true; |
Reid Kleckner | bca59d2 | 2016-05-02 19:43:22 +0000 | [diff] [blame] | 5668 | |
| 5669 | // If the Terminator is the only non-phi instruction, simplify the block. |
| 5670 | // if LoopHeader is provided, check if the block is a loop header |
Hyojin Sung | 4673f10 | 2016-03-29 04:08:57 +0000 | [diff] [blame] | 5671 | // (This is for early invocations before loop simplify and vectorization |
| 5672 | // to keep canonical loop forms for nested loops. |
| 5673 | // These blocks can be eliminated when the pass is invoked later |
| 5674 | // in the back-end.) |
Reid Kleckner | bca59d2 | 2016-05-02 19:43:22 +0000 | [diff] [blame] | 5675 | BasicBlock::iterator I = BB->getFirstNonPHIOrDbg()->getIterator(); |
Chris Lattner | 25c3af3 | 2010-12-13 06:25:44 +0000 | [diff] [blame] | 5676 | if (I->isTerminator() && BB != &BB->getParent()->getEntryBlock() && |
Hans Wennborg | e913489 | 2016-04-11 20:35:01 +0000 | [diff] [blame] | 5677 | (!LoopHeaders || !LoopHeaders->count(BB)) && |
Chris Lattner | 25c3af3 | 2010-12-13 06:25:44 +0000 | [diff] [blame] | 5678 | TryToSimplifyUncondBranchFromEmptyBlock(BB)) |
| 5679 | return true; |
Andrew Trick | f3cf193 | 2012-08-29 21:46:36 +0000 | [diff] [blame] | 5680 | |
Chris Lattner | 25c3af3 | 2010-12-13 06:25:44 +0000 | [diff] [blame] | 5681 | // If the only instruction in the block is a seteq/setne comparison |
| 5682 | // against a constant, try to simplify the block. |
| 5683 | if (ICmpInst *ICI = dyn_cast<ICmpInst>(I)) |
| 5684 | if (ICI->isEquality() && isa<ConstantInt>(ICI->getOperand(1))) { |
| 5685 | for (++I; isa<DbgInfoIntrinsic>(I); ++I) |
| 5686 | ; |
Nick Lewycky | e87d54c | 2011-12-26 20:37:40 +0000 | [diff] [blame] | 5687 | if (I->isTerminator() && |
Mehdi Amini | a28d91d | 2015-03-10 02:37:25 +0000 | [diff] [blame] | 5688 | TryToSimplifyUncondBranchWithICmpInIt(ICI, Builder, DL, TTI, |
Hal Finkel | 3ca4a6b | 2016-12-15 03:02:15 +0000 | [diff] [blame] | 5689 | BonusInstThreshold)) |
Chris Lattner | 25c3af3 | 2010-12-13 06:25:44 +0000 | [diff] [blame] | 5690 | return true; |
| 5691 | } |
Andrew Trick | f3cf193 | 2012-08-29 21:46:36 +0000 | [diff] [blame] | 5692 | |
Philip Reames | 2b969d7 | 2015-03-24 22:28:45 +0000 | [diff] [blame] | 5693 | // See if we can merge an empty landing pad block with another which is |
| 5694 | // equivalent. |
| 5695 | if (LandingPadInst *LPad = dyn_cast<LandingPadInst>(I)) { |
Dehao Chen | f6c0083 | 2016-05-18 19:44:21 +0000 | [diff] [blame] | 5696 | for (++I; isa<DbgInfoIntrinsic>(I); ++I) { |
| 5697 | } |
| 5698 | if (I->isTerminator() && TryToMergeLandingPad(LPad, BI, BB)) |
Philip Reames | 2b969d7 | 2015-03-24 22:28:45 +0000 | [diff] [blame] | 5699 | return true; |
| 5700 | } |
| 5701 | |
Manman Ren | d33f4ef | 2012-06-13 05:43:29 +0000 | [diff] [blame] | 5702 | // If this basic block is ONLY a compare and a branch, and if a predecessor |
| 5703 | // branches to us and our successor, fold the comparison into the |
| 5704 | // predecessor and use logical operations to update the incoming value |
| 5705 | // for PHI nodes in common successor. |
Mehdi Amini | a28d91d | 2015-03-10 02:37:25 +0000 | [diff] [blame] | 5706 | if (FoldBranchToCommonDest(BI, BonusInstThreshold)) |
Hal Finkel | 3ca4a6b | 2016-12-15 03:02:15 +0000 | [diff] [blame] | 5707 | return SimplifyCFG(BB, TTI, BonusInstThreshold) | true; |
Chris Lattner | 25c3af3 | 2010-12-13 06:25:44 +0000 | [diff] [blame] | 5708 | return false; |
| 5709 | } |
| 5710 | |
James Molloy | 4de84dd | 2015-11-04 15:28:04 +0000 | [diff] [blame] | 5711 | static BasicBlock *allPredecessorsComeFromSameSource(BasicBlock *BB) { |
| 5712 | BasicBlock *PredPred = nullptr; |
| 5713 | for (auto *P : predecessors(BB)) { |
| 5714 | BasicBlock *PPred = P->getSinglePredecessor(); |
| 5715 | if (!PPred || (PredPred && PredPred != PPred)) |
| 5716 | return nullptr; |
| 5717 | PredPred = PPred; |
| 5718 | } |
| 5719 | return PredPred; |
| 5720 | } |
Chris Lattner | 25c3af3 | 2010-12-13 06:25:44 +0000 | [diff] [blame] | 5721 | |
Devang Patel | a7ec47d | 2011-05-18 20:35:38 +0000 | [diff] [blame] | 5722 | bool SimplifyCFGOpt::SimplifyCondBranch(BranchInst *BI, IRBuilder<> &Builder) { |
Chris Lattner | 25c3af3 | 2010-12-13 06:25:44 +0000 | [diff] [blame] | 5723 | BasicBlock *BB = BI->getParent(); |
Andrew Trick | f3cf193 | 2012-08-29 21:46:36 +0000 | [diff] [blame] | 5724 | |
Chris Lattner | 25c3af3 | 2010-12-13 06:25:44 +0000 | [diff] [blame] | 5725 | // Conditional branch |
| 5726 | if (isValueEqualityComparison(BI)) { |
| 5727 | // If we only have one predecessor, and if it is a branch on this value, |
| 5728 | // see if that predecessor totally determines the outcome of this |
| 5729 | // switch. |
| 5730 | if (BasicBlock *OnlyPred = BB->getSinglePredecessor()) |
Devang Patel | a7ec47d | 2011-05-18 20:35:38 +0000 | [diff] [blame] | 5731 | if (SimplifyEqualityComparisonWithOnlyPredecessor(BI, OnlyPred, Builder)) |
Hal Finkel | 3ca4a6b | 2016-12-15 03:02:15 +0000 | [diff] [blame] | 5732 | return SimplifyCFG(BB, TTI, BonusInstThreshold) | true; |
Andrew Trick | f3cf193 | 2012-08-29 21:46:36 +0000 | [diff] [blame] | 5733 | |
Chris Lattner | 25c3af3 | 2010-12-13 06:25:44 +0000 | [diff] [blame] | 5734 | // This block must be empty, except for the setcond inst, if it exists. |
| 5735 | // Ignore dbg intrinsics. |
| 5736 | BasicBlock::iterator I = BB->begin(); |
| 5737 | // Ignore dbg intrinsics. |
| 5738 | while (isa<DbgInfoIntrinsic>(I)) |
| 5739 | ++I; |
| 5740 | if (&*I == BI) { |
Devang Patel | 5838055 | 2011-05-18 20:53:17 +0000 | [diff] [blame] | 5741 | if (FoldValueComparisonIntoPredecessors(BI, Builder)) |
Hal Finkel | 3ca4a6b | 2016-12-15 03:02:15 +0000 | [diff] [blame] | 5742 | return SimplifyCFG(BB, TTI, BonusInstThreshold) | true; |
Dehao Chen | f6c0083 | 2016-05-18 19:44:21 +0000 | [diff] [blame] | 5743 | } else if (&*I == cast<Instruction>(BI->getCondition())) { |
Chris Lattner | 25c3af3 | 2010-12-13 06:25:44 +0000 | [diff] [blame] | 5744 | ++I; |
| 5745 | // Ignore dbg intrinsics. |
| 5746 | while (isa<DbgInfoIntrinsic>(I)) |
| 5747 | ++I; |
Devang Patel | 5838055 | 2011-05-18 20:53:17 +0000 | [diff] [blame] | 5748 | if (&*I == BI && FoldValueComparisonIntoPredecessors(BI, Builder)) |
Hal Finkel | 3ca4a6b | 2016-12-15 03:02:15 +0000 | [diff] [blame] | 5749 | return SimplifyCFG(BB, TTI, BonusInstThreshold) | true; |
Chris Lattner | 25c3af3 | 2010-12-13 06:25:44 +0000 | [diff] [blame] | 5750 | } |
| 5751 | } |
Andrew Trick | f3cf193 | 2012-08-29 21:46:36 +0000 | [diff] [blame] | 5752 | |
Chris Lattner | 25c3af3 | 2010-12-13 06:25:44 +0000 | [diff] [blame] | 5753 | // Try to turn "br (X == 0 | X == 1), T, F" into a switch instruction. |
Mehdi Amini | a28d91d | 2015-03-10 02:37:25 +0000 | [diff] [blame] | 5754 | if (SimplifyBranchOnICmpChain(BI, Builder, DL)) |
Chris Lattner | 25c3af3 | 2010-12-13 06:25:44 +0000 | [diff] [blame] | 5755 | return true; |
Andrew Trick | f3cf193 | 2012-08-29 21:46:36 +0000 | [diff] [blame] | 5756 | |
Chad Rosier | 4ab37c0 | 2016-05-06 14:25:14 +0000 | [diff] [blame] | 5757 | // If this basic block has a single dominating predecessor block and the |
| 5758 | // dominating block's condition implies BI's condition, we know the direction |
| 5759 | // of the BI branch. |
| 5760 | if (BasicBlock *Dom = BB->getSinglePredecessor()) { |
| 5761 | auto *PBI = dyn_cast_or_null<BranchInst>(Dom->getTerminator()); |
| 5762 | if (PBI && PBI->isConditional() && |
| 5763 | PBI->getSuccessor(0) != PBI->getSuccessor(1) && |
| 5764 | (PBI->getSuccessor(0) == BB || PBI->getSuccessor(1) == BB)) { |
| 5765 | bool CondIsFalse = PBI->getSuccessor(1) == BB; |
| 5766 | Optional<bool> Implication = isImpliedCondition( |
| 5767 | PBI->getCondition(), BI->getCondition(), DL, CondIsFalse); |
| 5768 | if (Implication) { |
| 5769 | // Turn this into a branch on constant. |
| 5770 | auto *OldCond = BI->getCondition(); |
| 5771 | ConstantInt *CI = *Implication |
| 5772 | ? ConstantInt::getTrue(BB->getContext()) |
| 5773 | : ConstantInt::getFalse(BB->getContext()); |
| 5774 | BI->setCondition(CI); |
| 5775 | RecursivelyDeleteTriviallyDeadInstructions(OldCond); |
Hal Finkel | 3ca4a6b | 2016-12-15 03:02:15 +0000 | [diff] [blame] | 5776 | return SimplifyCFG(BB, TTI, BonusInstThreshold) | true; |
Chad Rosier | 4ab37c0 | 2016-05-06 14:25:14 +0000 | [diff] [blame] | 5777 | } |
| 5778 | } |
| 5779 | } |
| 5780 | |
Dan Gohman | 5ab9c0a | 2012-01-05 23:58:56 +0000 | [diff] [blame] | 5781 | // If this basic block is ONLY a compare and a branch, and if a predecessor |
| 5782 | // branches to us and one of our successors, fold the comparison into the |
| 5783 | // predecessor and use logical operations to pick the right destination. |
Mehdi Amini | a28d91d | 2015-03-10 02:37:25 +0000 | [diff] [blame] | 5784 | if (FoldBranchToCommonDest(BI, BonusInstThreshold)) |
Hal Finkel | 3ca4a6b | 2016-12-15 03:02:15 +0000 | [diff] [blame] | 5785 | return SimplifyCFG(BB, TTI, BonusInstThreshold) | true; |
Andrew Trick | f3cf193 | 2012-08-29 21:46:36 +0000 | [diff] [blame] | 5786 | |
Chris Lattner | 25c3af3 | 2010-12-13 06:25:44 +0000 | [diff] [blame] | 5787 | // We have a conditional branch to two blocks that are only reachable |
| 5788 | // from BI. We know that the condbr dominates the two blocks, so see if |
| 5789 | // there is any identical code in the "then" and "else" blocks. If so, we |
| 5790 | // can hoist it up to the branching block. |
Craig Topper | f40110f | 2014-04-25 05:29:35 +0000 | [diff] [blame] | 5791 | if (BI->getSuccessor(0)->getSinglePredecessor()) { |
| 5792 | if (BI->getSuccessor(1)->getSinglePredecessor()) { |
Mehdi Amini | a28d91d | 2015-03-10 02:37:25 +0000 | [diff] [blame] | 5793 | if (HoistThenElseCodeToIf(BI, TTI)) |
Hal Finkel | 3ca4a6b | 2016-12-15 03:02:15 +0000 | [diff] [blame] | 5794 | return SimplifyCFG(BB, TTI, BonusInstThreshold) | true; |
Chris Lattner | 25c3af3 | 2010-12-13 06:25:44 +0000 | [diff] [blame] | 5795 | } else { |
| 5796 | // If Successor #1 has multiple preds, we may be able to conditionally |
Sanjay Patel | 0a2ada7 | 2014-07-06 23:10:24 +0000 | [diff] [blame] | 5797 | // execute Successor #0 if it branches to Successor #1. |
Chris Lattner | 25c3af3 | 2010-12-13 06:25:44 +0000 | [diff] [blame] | 5798 | TerminatorInst *Succ0TI = BI->getSuccessor(0)->getTerminator(); |
| 5799 | if (Succ0TI->getNumSuccessors() == 1 && |
| 5800 | Succ0TI->getSuccessor(0) == BI->getSuccessor(1)) |
Mehdi Amini | a28d91d | 2015-03-10 02:37:25 +0000 | [diff] [blame] | 5801 | if (SpeculativelyExecuteBB(BI, BI->getSuccessor(0), TTI)) |
Hal Finkel | 3ca4a6b | 2016-12-15 03:02:15 +0000 | [diff] [blame] | 5802 | return SimplifyCFG(BB, TTI, BonusInstThreshold) | true; |
Chris Lattner | 25c3af3 | 2010-12-13 06:25:44 +0000 | [diff] [blame] | 5803 | } |
Craig Topper | f40110f | 2014-04-25 05:29:35 +0000 | [diff] [blame] | 5804 | } else if (BI->getSuccessor(1)->getSinglePredecessor()) { |
Chris Lattner | 25c3af3 | 2010-12-13 06:25:44 +0000 | [diff] [blame] | 5805 | // If Successor #0 has multiple preds, we may be able to conditionally |
Sanjay Patel | 0a2ada7 | 2014-07-06 23:10:24 +0000 | [diff] [blame] | 5806 | // execute Successor #1 if it branches to Successor #0. |
Chris Lattner | 25c3af3 | 2010-12-13 06:25:44 +0000 | [diff] [blame] | 5807 | TerminatorInst *Succ1TI = BI->getSuccessor(1)->getTerminator(); |
| 5808 | if (Succ1TI->getNumSuccessors() == 1 && |
| 5809 | Succ1TI->getSuccessor(0) == BI->getSuccessor(0)) |
Mehdi Amini | a28d91d | 2015-03-10 02:37:25 +0000 | [diff] [blame] | 5810 | if (SpeculativelyExecuteBB(BI, BI->getSuccessor(1), TTI)) |
Hal Finkel | 3ca4a6b | 2016-12-15 03:02:15 +0000 | [diff] [blame] | 5811 | return SimplifyCFG(BB, TTI, BonusInstThreshold) | true; |
Chris Lattner | 25c3af3 | 2010-12-13 06:25:44 +0000 | [diff] [blame] | 5812 | } |
Andrew Trick | f3cf193 | 2012-08-29 21:46:36 +0000 | [diff] [blame] | 5813 | |
Chris Lattner | 25c3af3 | 2010-12-13 06:25:44 +0000 | [diff] [blame] | 5814 | // If this is a branch on a phi node in the current block, thread control |
| 5815 | // through this block if any PHI node entries are constants. |
| 5816 | if (PHINode *PN = dyn_cast<PHINode>(BI->getCondition())) |
| 5817 | if (PN->getParent() == BI->getParent()) |
Rafael Espindola | 37dc9e1 | 2014-02-21 00:06:31 +0000 | [diff] [blame] | 5818 | if (FoldCondBranchOnPHI(BI, DL)) |
Hal Finkel | 3ca4a6b | 2016-12-15 03:02:15 +0000 | [diff] [blame] | 5819 | return SimplifyCFG(BB, TTI, BonusInstThreshold) | true; |
Andrew Trick | f3cf193 | 2012-08-29 21:46:36 +0000 | [diff] [blame] | 5820 | |
Chris Lattner | 25c3af3 | 2010-12-13 06:25:44 +0000 | [diff] [blame] | 5821 | // Scan predecessor blocks for conditional branches. |
Duncan P. N. Exon Smith | 6c99015 | 2014-07-21 17:06:51 +0000 | [diff] [blame] | 5822 | for (pred_iterator PI = pred_begin(BB), E = pred_end(BB); PI != E; ++PI) |
| 5823 | if (BranchInst *PBI = dyn_cast<BranchInst>((*PI)->getTerminator())) |
Chris Lattner | 25c3af3 | 2010-12-13 06:25:44 +0000 | [diff] [blame] | 5824 | if (PBI != BI && PBI->isConditional()) |
Philip Reames | b42db21 | 2015-10-14 22:46:19 +0000 | [diff] [blame] | 5825 | if (SimplifyCondBranchToCondBranch(PBI, BI, DL)) |
Hal Finkel | 3ca4a6b | 2016-12-15 03:02:15 +0000 | [diff] [blame] | 5826 | return SimplifyCFG(BB, TTI, BonusInstThreshold) | true; |
Chris Lattner | 25c3af3 | 2010-12-13 06:25:44 +0000 | [diff] [blame] | 5827 | |
James Molloy | 4de84dd | 2015-11-04 15:28:04 +0000 | [diff] [blame] | 5828 | // Look for diamond patterns. |
| 5829 | if (MergeCondStores) |
| 5830 | if (BasicBlock *PrevBB = allPredecessorsComeFromSameSource(BB)) |
| 5831 | if (BranchInst *PBI = dyn_cast<BranchInst>(PrevBB->getTerminator())) |
| 5832 | if (PBI != BI && PBI->isConditional()) |
| 5833 | if (mergeConditionalStores(PBI, BI)) |
Hal Finkel | 3ca4a6b | 2016-12-15 03:02:15 +0000 | [diff] [blame] | 5834 | return SimplifyCFG(BB, TTI, BonusInstThreshold) | true; |
Dehao Chen | f6c0083 | 2016-05-18 19:44:21 +0000 | [diff] [blame] | 5835 | |
Chris Lattner | 25c3af3 | 2010-12-13 06:25:44 +0000 | [diff] [blame] | 5836 | return false; |
| 5837 | } |
| 5838 | |
Benjamin Kramer | fb212a6 | 2011-08-26 01:22:29 +0000 | [diff] [blame] | 5839 | /// Check if passing a value to an instruction will cause undefined behavior. |
| 5840 | static bool passingValueIsAlwaysUndefined(Value *V, Instruction *I) { |
| 5841 | Constant *C = dyn_cast<Constant>(V); |
| 5842 | if (!C) |
| 5843 | return false; |
| 5844 | |
Benjamin Kramer | d12e82e | 2012-10-04 16:11:49 +0000 | [diff] [blame] | 5845 | if (I->use_empty()) |
Benjamin Kramer | fb212a6 | 2011-08-26 01:22:29 +0000 | [diff] [blame] | 5846 | return false; |
| 5847 | |
David Majnemer | 1fea77c | 2016-06-25 07:37:27 +0000 | [diff] [blame] | 5848 | if (C->isNullValue() || isa<UndefValue>(C)) { |
Benjamin Kramer | d12e82e | 2012-10-04 16:11:49 +0000 | [diff] [blame] | 5849 | // Only look at the first use, avoid hurting compile time with long uselists |
Chandler Carruth | cdf4788 | 2014-03-09 03:16:01 +0000 | [diff] [blame] | 5850 | User *Use = *I->user_begin(); |
Benjamin Kramer | fb212a6 | 2011-08-26 01:22:29 +0000 | [diff] [blame] | 5851 | |
| 5852 | // Now make sure that there are no instructions in between that can alter |
| 5853 | // control flow (eg. calls) |
Duncan P. N. Exon Smith | 0a12729f | 2016-08-16 23:57:56 +0000 | [diff] [blame] | 5854 | for (BasicBlock::iterator |
| 5855 | i = ++BasicBlock::iterator(I), |
| 5856 | UI = BasicBlock::iterator(dyn_cast<Instruction>(Use)); |
| 5857 | i != UI; ++i) |
Benjamin Kramer | 0655b78 | 2011-08-26 02:25:55 +0000 | [diff] [blame] | 5858 | if (i == I->getParent()->end() || i->mayHaveSideEffects()) |
Benjamin Kramer | fb212a6 | 2011-08-26 01:22:29 +0000 | [diff] [blame] | 5859 | return false; |
| 5860 | |
| 5861 | // Look through GEPs. A load from a GEP derived from NULL is still undefined |
| 5862 | if (GetElementPtrInst *GEP = dyn_cast<GetElementPtrInst>(Use)) |
| 5863 | if (GEP->getPointerOperand() == I) |
| 5864 | return passingValueIsAlwaysUndefined(V, GEP); |
| 5865 | |
| 5866 | // Look through bitcasts. |
| 5867 | if (BitCastInst *BC = dyn_cast<BitCastInst>(Use)) |
| 5868 | return passingValueIsAlwaysUndefined(V, BC); |
| 5869 | |
Benjamin Kramer | 0655b78 | 2011-08-26 02:25:55 +0000 | [diff] [blame] | 5870 | // Load from null is undefined. |
| 5871 | if (LoadInst *LI = dyn_cast<LoadInst>(Use)) |
Andrew Trick | a0a5ca0 | 2013-03-07 01:03:35 +0000 | [diff] [blame] | 5872 | if (!LI->isVolatile()) |
| 5873 | return LI->getPointerAddressSpace() == 0; |
Benjamin Kramer | fb212a6 | 2011-08-26 01:22:29 +0000 | [diff] [blame] | 5874 | |
Benjamin Kramer | 0655b78 | 2011-08-26 02:25:55 +0000 | [diff] [blame] | 5875 | // Store to null is undefined. |
| 5876 | if (StoreInst *SI = dyn_cast<StoreInst>(Use)) |
Andrew Trick | a0a5ca0 | 2013-03-07 01:03:35 +0000 | [diff] [blame] | 5877 | if (!SI->isVolatile()) |
Dehao Chen | f6c0083 | 2016-05-18 19:44:21 +0000 | [diff] [blame] | 5878 | return SI->getPointerAddressSpace() == 0 && |
| 5879 | SI->getPointerOperand() == I; |
David Majnemer | 1fea77c | 2016-06-25 07:37:27 +0000 | [diff] [blame] | 5880 | |
| 5881 | // A call to null is undefined. |
| 5882 | if (auto CS = CallSite(Use)) |
| 5883 | return CS.getCalledValue() == I; |
Benjamin Kramer | fb212a6 | 2011-08-26 01:22:29 +0000 | [diff] [blame] | 5884 | } |
| 5885 | return false; |
| 5886 | } |
| 5887 | |
| 5888 | /// If BB has an incoming value that will always trigger undefined behavior |
Nick Lewycky | e87d54c | 2011-12-26 20:37:40 +0000 | [diff] [blame] | 5889 | /// (eg. null pointer dereference), remove the branch leading here. |
Benjamin Kramer | fb212a6 | 2011-08-26 01:22:29 +0000 | [diff] [blame] | 5890 | static bool removeUndefIntroducingPredecessor(BasicBlock *BB) { |
| 5891 | for (BasicBlock::iterator i = BB->begin(); |
| 5892 | PHINode *PHI = dyn_cast<PHINode>(i); ++i) |
| 5893 | for (unsigned i = 0, e = PHI->getNumIncomingValues(); i != e; ++i) |
| 5894 | if (passingValueIsAlwaysUndefined(PHI->getIncomingValue(i), PHI)) { |
| 5895 | TerminatorInst *T = PHI->getIncomingBlock(i)->getTerminator(); |
| 5896 | IRBuilder<> Builder(T); |
| 5897 | if (BranchInst *BI = dyn_cast<BranchInst>(T)) { |
| 5898 | BB->removePredecessor(PHI->getIncomingBlock(i)); |
| 5899 | // Turn uncoditional branches into unreachables and remove the dead |
| 5900 | // destination from conditional branches. |
| 5901 | if (BI->isUnconditional()) |
| 5902 | Builder.CreateUnreachable(); |
| 5903 | else |
Dehao Chen | f6c0083 | 2016-05-18 19:44:21 +0000 | [diff] [blame] | 5904 | Builder.CreateBr(BI->getSuccessor(0) == BB ? BI->getSuccessor(1) |
| 5905 | : BI->getSuccessor(0)); |
Benjamin Kramer | fb212a6 | 2011-08-26 01:22:29 +0000 | [diff] [blame] | 5906 | BI->eraseFromParent(); |
| 5907 | return true; |
| 5908 | } |
| 5909 | // TODO: SwitchInst. |
| 5910 | } |
| 5911 | |
| 5912 | return false; |
| 5913 | } |
| 5914 | |
Jakob Stoklund Olesen | 916f48a | 2010-02-05 22:03:18 +0000 | [diff] [blame] | 5915 | bool SimplifyCFGOpt::run(BasicBlock *BB) { |
Chris Lattner | 3f5823f | 2003-08-24 18:36:16 +0000 | [diff] [blame] | 5916 | bool Changed = false; |
Chris Lattner | 466a049 | 2002-05-21 20:50:24 +0000 | [diff] [blame] | 5917 | |
Chris Lattner | d7beca3 | 2010-12-14 06:17:25 +0000 | [diff] [blame] | 5918 | assert(BB && BB->getParent() && "Block not embedded in function!"); |
Chris Lattner | 466a049 | 2002-05-21 20:50:24 +0000 | [diff] [blame] | 5919 | assert(BB->getTerminator() && "Degenerate basic block encountered!"); |
Chris Lattner | 466a049 | 2002-05-21 20:50:24 +0000 | [diff] [blame] | 5920 | |
Dan Gohman | 4a63fad | 2010-08-14 00:29:42 +0000 | [diff] [blame] | 5921 | // Remove basic blocks that have no predecessors (except the entry block)... |
| 5922 | // or that just have themself as a predecessor. These are unreachable. |
Dehao Chen | f6c0083 | 2016-05-18 19:44:21 +0000 | [diff] [blame] | 5923 | if ((pred_empty(BB) && BB != &BB->getParent()->getEntryBlock()) || |
Dan Gohman | 4a63fad | 2010-08-14 00:29:42 +0000 | [diff] [blame] | 5924 | BB->getSinglePredecessor() == BB) { |
David Majnemer | ee0cbbb | 2016-02-24 17:30:48 +0000 | [diff] [blame] | 5925 | DEBUG(dbgs() << "Removing BB: \n" << *BB); |
| 5926 | DeleteDeadBlock(BB); |
| 5927 | return true; |
Chris Lattner | 466a049 | 2002-05-21 20:50:24 +0000 | [diff] [blame] | 5928 | } |
| 5929 | |
Chris Lattner | 031340a | 2003-08-17 19:41:53 +0000 | [diff] [blame] | 5930 | // Check to see if we can constant propagate this terminator instruction |
| 5931 | // away... |
Frits van Bommel | ad96455 | 2011-05-22 16:24:18 +0000 | [diff] [blame] | 5932 | Changed |= ConstantFoldTerminator(BB, true); |
Chris Lattner | 031340a | 2003-08-17 19:41:53 +0000 | [diff] [blame] | 5933 | |
Dan Gohman | 1a95106 | 2009-10-30 22:39:04 +0000 | [diff] [blame] | 5934 | // Check for and eliminate duplicate PHI nodes in this block. |
| 5935 | Changed |= EliminateDuplicatePHINodes(BB); |
| 5936 | |
Benjamin Kramer | fb212a6 | 2011-08-26 01:22:29 +0000 | [diff] [blame] | 5937 | // Check for and remove branches that will always cause undefined behavior. |
| 5938 | Changed |= removeUndefIntroducingPredecessor(BB); |
| 5939 | |
Chris Lattner | 2e3832d | 2010-12-13 05:10:48 +0000 | [diff] [blame] | 5940 | // Merge basic blocks into their predecessor if there is only one distinct |
| 5941 | // pred, and if there is only one distinct successor of the predecessor, and |
| 5942 | // if there are no PHI nodes. |
| 5943 | // |
| 5944 | if (MergeBlockIntoPredecessor(BB)) |
| 5945 | return true; |
Andrew Trick | f3cf193 | 2012-08-29 21:46:36 +0000 | [diff] [blame] | 5946 | |
Devang Patel | 15ad676 | 2011-05-18 18:01:27 +0000 | [diff] [blame] | 5947 | IRBuilder<> Builder(BB); |
| 5948 | |
Dan Gohman | 20af5a0 | 2008-03-11 21:53:06 +0000 | [diff] [blame] | 5949 | // If there is a trivial two-entry PHI node in this basic block, and we can |
| 5950 | // eliminate it, do so now. |
| 5951 | if (PHINode *PN = dyn_cast<PHINode>(BB->begin())) |
| 5952 | if (PN->getNumIncomingValues() == 2) |
Mehdi Amini | a28d91d | 2015-03-10 02:37:25 +0000 | [diff] [blame] | 5953 | Changed |= FoldTwoEntryPHINode(PN, TTI, DL); |
Dan Gohman | 20af5a0 | 2008-03-11 21:53:06 +0000 | [diff] [blame] | 5954 | |
Devang Patel | a7ec47d | 2011-05-18 20:35:38 +0000 | [diff] [blame] | 5955 | Builder.SetInsertPoint(BB->getTerminator()); |
Chris Lattner | 25c3af3 | 2010-12-13 06:25:44 +0000 | [diff] [blame] | 5956 | if (BranchInst *BI = dyn_cast<BranchInst>(BB->getTerminator())) { |
Chris Lattner | 1d05761 | 2010-12-13 06:36:51 +0000 | [diff] [blame] | 5957 | if (BI->isUnconditional()) { |
Dehao Chen | f6c0083 | 2016-05-18 19:44:21 +0000 | [diff] [blame] | 5958 | if (SimplifyUncondBranch(BI, Builder)) |
| 5959 | return true; |
Chris Lattner | 1d05761 | 2010-12-13 06:36:51 +0000 | [diff] [blame] | 5960 | } else { |
Dehao Chen | f6c0083 | 2016-05-18 19:44:21 +0000 | [diff] [blame] | 5961 | if (SimplifyCondBranch(BI, Builder)) |
| 5962 | return true; |
Chris Lattner | 1d05761 | 2010-12-13 06:36:51 +0000 | [diff] [blame] | 5963 | } |
| 5964 | } else if (ReturnInst *RI = dyn_cast<ReturnInst>(BB->getTerminator())) { |
Dehao Chen | f6c0083 | 2016-05-18 19:44:21 +0000 | [diff] [blame] | 5965 | if (SimplifyReturn(RI, Builder)) |
| 5966 | return true; |
Bill Wendling | d5d95b0 | 2012-02-06 21:16:41 +0000 | [diff] [blame] | 5967 | } else if (ResumeInst *RI = dyn_cast<ResumeInst>(BB->getTerminator())) { |
Dehao Chen | f6c0083 | 2016-05-18 19:44:21 +0000 | [diff] [blame] | 5968 | if (SimplifyResume(RI, Builder)) |
| 5969 | return true; |
Andrew Kaylor | 50e4e86 | 2015-09-04 23:39:40 +0000 | [diff] [blame] | 5970 | } else if (CleanupReturnInst *RI = |
Dehao Chen | f6c0083 | 2016-05-18 19:44:21 +0000 | [diff] [blame] | 5971 | dyn_cast<CleanupReturnInst>(BB->getTerminator())) { |
| 5972 | if (SimplifyCleanupReturn(RI)) |
| 5973 | return true; |
Chris Lattner | 1d05761 | 2010-12-13 06:36:51 +0000 | [diff] [blame] | 5974 | } else if (SwitchInst *SI = dyn_cast<SwitchInst>(BB->getTerminator())) { |
Dehao Chen | f6c0083 | 2016-05-18 19:44:21 +0000 | [diff] [blame] | 5975 | if (SimplifySwitch(SI, Builder)) |
| 5976 | return true; |
Chris Lattner | 1d05761 | 2010-12-13 06:36:51 +0000 | [diff] [blame] | 5977 | } else if (UnreachableInst *UI = |
Dehao Chen | f6c0083 | 2016-05-18 19:44:21 +0000 | [diff] [blame] | 5978 | dyn_cast<UnreachableInst>(BB->getTerminator())) { |
| 5979 | if (SimplifyUnreachable(UI)) |
| 5980 | return true; |
Chris Lattner | 1d05761 | 2010-12-13 06:36:51 +0000 | [diff] [blame] | 5981 | } else if (IndirectBrInst *IBI = |
Dehao Chen | f6c0083 | 2016-05-18 19:44:21 +0000 | [diff] [blame] | 5982 | dyn_cast<IndirectBrInst>(BB->getTerminator())) { |
| 5983 | if (SimplifyIndirectBr(IBI)) |
| 5984 | return true; |
Chris Lattner | e42732e | 2004-02-16 06:35:48 +0000 | [diff] [blame] | 5985 | } |
| 5986 | |
Chris Lattner | 031340a | 2003-08-17 19:41:53 +0000 | [diff] [blame] | 5987 | return Changed; |
Chris Lattner | 466a049 | 2002-05-21 20:50:24 +0000 | [diff] [blame] | 5988 | } |
Jakob Stoklund Olesen | 916f48a | 2010-02-05 22:03:18 +0000 | [diff] [blame] | 5989 | |
Sanjay Patel | 09159b8f | 2015-06-24 20:40:57 +0000 | [diff] [blame] | 5990 | /// This function is used to do simplification of a CFG. |
| 5991 | /// For example, it adjusts branches to branches to eliminate the extra hop, |
Jakob Stoklund Olesen | 916f48a | 2010-02-05 22:03:18 +0000 | [diff] [blame] | 5992 | /// eliminates unreachable basic blocks, and does other "peephole" optimization |
| 5993 | /// of the CFG. It returns true if a modification was made. |
| 5994 | /// |
Chandler Carruth | 0b4ef9c | 2013-01-07 03:53:25 +0000 | [diff] [blame] | 5995 | bool llvm::SimplifyCFG(BasicBlock *BB, const TargetTransformInfo &TTI, |
Hal Finkel | 3ca4a6b | 2016-12-15 03:02:15 +0000 | [diff] [blame] | 5996 | unsigned BonusInstThreshold, |
Hyojin Sung | 4673f10 | 2016-03-29 04:08:57 +0000 | [diff] [blame] | 5997 | SmallPtrSetImpl<BasicBlock *> *LoopHeaders) { |
Mehdi Amini | a28d91d | 2015-03-10 02:37:25 +0000 | [diff] [blame] | 5998 | return SimplifyCFGOpt(TTI, BB->getModule()->getDataLayout(), |
Hal Finkel | 3ca4a6b | 2016-12-15 03:02:15 +0000 | [diff] [blame] | 5999 | BonusInstThreshold, LoopHeaders) |
Dehao Chen | f6c0083 | 2016-05-18 19:44:21 +0000 | [diff] [blame] | 6000 | .run(BB); |
Jakob Stoklund Olesen | 916f48a | 2010-02-05 22:03:18 +0000 | [diff] [blame] | 6001 | } |