| Kirill Bobyrev | 8e35f1e | 2018-08-14 16:03:32 +0000 | [diff] [blame] | 1 | //===--- Quality.cpp ---------------------------------------------*- C++-*-===// |
| Sam McCall | c5707b6 | 2018-05-15 17:43:27 +0000 | [diff] [blame] | 2 | // |
| 3 | // The LLVM Compiler Infrastructure |
| 4 | // |
| 5 | // This file is distributed under the University of Illinois Open Source |
| 6 | // License. See LICENSE.TXT for details. |
| 7 | // |
| Kirill Bobyrev | 8e35f1e | 2018-08-14 16:03:32 +0000 | [diff] [blame] | 8 | //===----------------------------------------------------------------------===// |
| Sam McCall | c5707b6 | 2018-05-15 17:43:27 +0000 | [diff] [blame] | 9 | #include "Quality.h" |
| Sam McCall | 3f0243f | 2018-07-03 08:09:29 +0000 | [diff] [blame] | 10 | #include "FileDistance.h" |
| Eric Liu | 09c3c37 | 2018-06-15 08:58:12 +0000 | [diff] [blame] | 11 | #include "URI.h" |
| Sam McCall | c5707b6 | 2018-05-15 17:43:27 +0000 | [diff] [blame] | 12 | #include "index/Index.h" |
| Ilya Biryukov | f029646 | 2018-06-04 14:50:59 +0000 | [diff] [blame] | 13 | #include "clang/AST/ASTContext.h" |
| Eric Liu | 5d2a807 | 2018-07-23 10:56:37 +0000 | [diff] [blame] | 14 | #include "clang/AST/Decl.h" |
| Eric Liu | 8944f0e | 2018-07-05 08:14:04 +0000 | [diff] [blame] | 15 | #include "clang/AST/DeclCXX.h" |
| Eric Liu | 5d2a807 | 2018-07-23 10:56:37 +0000 | [diff] [blame] | 16 | #include "clang/AST/DeclTemplate.h" |
| Sam McCall | 4a3c69b | 2018-06-06 08:53:36 +0000 | [diff] [blame] | 17 | #include "clang/AST/DeclVisitor.h" |
| Sam McCall | 3f0243f | 2018-07-03 08:09:29 +0000 | [diff] [blame] | 18 | #include "clang/Basic/CharInfo.h" |
| Ilya Biryukov | f029646 | 2018-06-04 14:50:59 +0000 | [diff] [blame] | 19 | #include "clang/Basic/SourceManager.h" |
| Sam McCall | c5707b6 | 2018-05-15 17:43:27 +0000 | [diff] [blame] | 20 | #include "clang/Sema/CodeCompleteConsumer.h" |
| Eric Liu | 8944f0e | 2018-07-05 08:14:04 +0000 | [diff] [blame] | 21 | #include "llvm/Support/Casting.h" |
| Sam McCall | c5707b6 | 2018-05-15 17:43:27 +0000 | [diff] [blame] | 22 | #include "llvm/Support/FormatVariadic.h" |
| 23 | #include "llvm/Support/MathExtras.h" |
| 24 | #include "llvm/Support/raw_ostream.h" |
| Sam McCall | 3f0243f | 2018-07-03 08:09:29 +0000 | [diff] [blame] | 25 | #include <cmath> |
| Sam McCall | c5707b6 | 2018-05-15 17:43:27 +0000 | [diff] [blame] | 26 | |
| 27 | namespace clang { |
| 28 | namespace clangd { |
| 29 | using namespace llvm; |
| Ilya Biryukov | 74f2655 | 2018-07-26 12:05:31 +0000 | [diff] [blame] | 30 | static bool isReserved(StringRef Name) { |
| Sam McCall | e018b36 | 2018-06-08 09:36:34 +0000 | [diff] [blame] | 31 | // FIXME: Should we exclude _Bool and others recognized by the standard? |
| 32 | return Name.size() >= 2 && Name[0] == '_' && |
| 33 | (isUppercase(Name[1]) || Name[1] == '_'); |
| 34 | } |
| Sam McCall | c5707b6 | 2018-05-15 17:43:27 +0000 | [diff] [blame] | 35 | |
| Ilya Biryukov | f029646 | 2018-06-04 14:50:59 +0000 | [diff] [blame] | 36 | static bool hasDeclInMainFile(const Decl &D) { |
| 37 | auto &SourceMgr = D.getASTContext().getSourceManager(); |
| 38 | for (auto *Redecl : D.redecls()) { |
| 39 | auto Loc = SourceMgr.getSpellingLoc(Redecl->getLocation()); |
| 40 | if (SourceMgr.isWrittenInMainFile(Loc)) |
| 41 | return true; |
| 42 | } |
| 43 | return false; |
| 44 | } |
| 45 | |
| Kirill Bobyrev | 47d7f52 | 2018-07-11 14:49:49 +0000 | [diff] [blame] | 46 | static bool hasUsingDeclInMainFile(const CodeCompletionResult &R) { |
| 47 | const auto &Context = R.Declaration->getASTContext(); |
| 48 | const auto &SourceMgr = Context.getSourceManager(); |
| 49 | if (R.ShadowDecl) { |
| 50 | const auto Loc = SourceMgr.getExpansionLoc(R.ShadowDecl->getLocation()); |
| 51 | if (SourceMgr.isWrittenInMainFile(Loc)) |
| 52 | return true; |
| 53 | } |
| 54 | return false; |
| 55 | } |
| 56 | |
| Sam McCall | 4a3c69b | 2018-06-06 08:53:36 +0000 | [diff] [blame] | 57 | static SymbolQualitySignals::SymbolCategory categorize(const NamedDecl &ND) { |
| 58 | class Switch |
| 59 | : public ConstDeclVisitor<Switch, SymbolQualitySignals::SymbolCategory> { |
| 60 | public: |
| 61 | #define MAP(DeclType, Category) \ |
| 62 | SymbolQualitySignals::SymbolCategory Visit##DeclType(const DeclType *) { \ |
| 63 | return SymbolQualitySignals::Category; \ |
| 64 | } |
| 65 | MAP(NamespaceDecl, Namespace); |
| 66 | MAP(NamespaceAliasDecl, Namespace); |
| 67 | MAP(TypeDecl, Type); |
| 68 | MAP(TypeAliasTemplateDecl, Type); |
| 69 | MAP(ClassTemplateDecl, Type); |
| Eric Liu | d7de811 | 2018-07-24 08:51:52 +0000 | [diff] [blame] | 70 | MAP(CXXConstructorDecl, Constructor); |
| Sam McCall | 4a3c69b | 2018-06-06 08:53:36 +0000 | [diff] [blame] | 71 | MAP(ValueDecl, Variable); |
| 72 | MAP(VarTemplateDecl, Variable); |
| 73 | MAP(FunctionDecl, Function); |
| 74 | MAP(FunctionTemplateDecl, Function); |
| 75 | MAP(Decl, Unknown); |
| 76 | #undef MAP |
| 77 | }; |
| 78 | return Switch().Visit(&ND); |
| 79 | } |
| 80 | |
| Kirill Bobyrev | 7cf29bc | 2018-07-05 09:37:26 +0000 | [diff] [blame] | 81 | static SymbolQualitySignals::SymbolCategory |
| 82 | categorize(const CodeCompletionResult &R) { |
| Sam McCall | c3b5bad | 2018-06-14 13:42:21 +0000 | [diff] [blame] | 83 | if (R.Declaration) |
| 84 | return categorize(*R.Declaration); |
| 85 | if (R.Kind == CodeCompletionResult::RK_Macro) |
| 86 | return SymbolQualitySignals::Macro; |
| 87 | // Everything else is a keyword or a pattern. Patterns are mostly keywords |
| 88 | // too, except a few which we recognize by cursor kind. |
| 89 | switch (R.CursorKind) { |
| Kirill Bobyrev | 7cf29bc | 2018-07-05 09:37:26 +0000 | [diff] [blame] | 90 | case CXCursor_CXXMethod: |
| 91 | return SymbolQualitySignals::Function; |
| 92 | case CXCursor_ModuleImportDecl: |
| 93 | return SymbolQualitySignals::Namespace; |
| 94 | case CXCursor_MacroDefinition: |
| 95 | return SymbolQualitySignals::Macro; |
| 96 | case CXCursor_TypeRef: |
| 97 | return SymbolQualitySignals::Type; |
| 98 | case CXCursor_MemberRef: |
| 99 | return SymbolQualitySignals::Variable; |
| Eric Liu | d7de811 | 2018-07-24 08:51:52 +0000 | [diff] [blame] | 100 | case CXCursor_Constructor: |
| 101 | return SymbolQualitySignals::Constructor; |
| Kirill Bobyrev | 7cf29bc | 2018-07-05 09:37:26 +0000 | [diff] [blame] | 102 | default: |
| 103 | return SymbolQualitySignals::Keyword; |
| Sam McCall | c3b5bad | 2018-06-14 13:42:21 +0000 | [diff] [blame] | 104 | } |
| 105 | } |
| 106 | |
| Sam McCall | 4a3c69b | 2018-06-06 08:53:36 +0000 | [diff] [blame] | 107 | static SymbolQualitySignals::SymbolCategory |
| 108 | categorize(const index::SymbolInfo &D) { |
| 109 | switch (D.Kind) { |
| Kirill Bobyrev | 7cf29bc | 2018-07-05 09:37:26 +0000 | [diff] [blame] | 110 | case index::SymbolKind::Namespace: |
| 111 | case index::SymbolKind::NamespaceAlias: |
| 112 | return SymbolQualitySignals::Namespace; |
| 113 | case index::SymbolKind::Macro: |
| 114 | return SymbolQualitySignals::Macro; |
| 115 | case index::SymbolKind::Enum: |
| 116 | case index::SymbolKind::Struct: |
| 117 | case index::SymbolKind::Class: |
| 118 | case index::SymbolKind::Protocol: |
| 119 | case index::SymbolKind::Extension: |
| 120 | case index::SymbolKind::Union: |
| 121 | case index::SymbolKind::TypeAlias: |
| 122 | return SymbolQualitySignals::Type; |
| 123 | case index::SymbolKind::Function: |
| 124 | case index::SymbolKind::ClassMethod: |
| 125 | case index::SymbolKind::InstanceMethod: |
| 126 | case index::SymbolKind::StaticMethod: |
| 127 | case index::SymbolKind::InstanceProperty: |
| 128 | case index::SymbolKind::ClassProperty: |
| 129 | case index::SymbolKind::StaticProperty: |
| Kirill Bobyrev | 7cf29bc | 2018-07-05 09:37:26 +0000 | [diff] [blame] | 130 | case index::SymbolKind::Destructor: |
| 131 | case index::SymbolKind::ConversionFunction: |
| 132 | return SymbolQualitySignals::Function; |
| Eric Liu | d7de811 | 2018-07-24 08:51:52 +0000 | [diff] [blame] | 133 | case index::SymbolKind::Constructor: |
| 134 | return SymbolQualitySignals::Constructor; |
| Kirill Bobyrev | 7cf29bc | 2018-07-05 09:37:26 +0000 | [diff] [blame] | 135 | case index::SymbolKind::Variable: |
| 136 | case index::SymbolKind::Field: |
| 137 | case index::SymbolKind::EnumConstant: |
| 138 | case index::SymbolKind::Parameter: |
| 139 | return SymbolQualitySignals::Variable; |
| 140 | case index::SymbolKind::Using: |
| 141 | case index::SymbolKind::Module: |
| 142 | case index::SymbolKind::Unknown: |
| 143 | return SymbolQualitySignals::Unknown; |
| Sam McCall | 4a3c69b | 2018-06-06 08:53:36 +0000 | [diff] [blame] | 144 | } |
| Tim Northover | 0698e96 | 2018-06-06 13:28:49 +0000 | [diff] [blame] | 145 | llvm_unreachable("Unknown index::SymbolKind"); |
| Sam McCall | 4a3c69b | 2018-06-06 08:53:36 +0000 | [diff] [blame] | 146 | } |
| 147 | |
| Eric Liu | 5d2a807 | 2018-07-23 10:56:37 +0000 | [diff] [blame] | 148 | static bool isInstanceMember(const NamedDecl *ND) { |
| 149 | if (!ND) |
| 150 | return false; |
| 151 | if (const auto *TP = dyn_cast<FunctionTemplateDecl>(ND)) |
| 152 | ND = TP->TemplateDecl::getTemplatedDecl(); |
| 153 | if (const auto *CM = dyn_cast<CXXMethodDecl>(ND)) |
| 154 | return !CM->isStatic(); |
| 155 | return isa<FieldDecl>(ND); // Note that static fields are VarDecl. |
| 156 | } |
| 157 | |
| 158 | static bool isInstanceMember(const index::SymbolInfo &D) { |
| 159 | switch (D.Kind) { |
| 160 | case index::SymbolKind::InstanceMethod: |
| 161 | case index::SymbolKind::InstanceProperty: |
| 162 | case index::SymbolKind::Field: |
| 163 | return true; |
| 164 | default: |
| 165 | return false; |
| 166 | } |
| 167 | } |
| 168 | |
| Sam McCall | c5707b6 | 2018-05-15 17:43:27 +0000 | [diff] [blame] | 169 | void SymbolQualitySignals::merge(const CodeCompletionResult &SemaCCResult) { |
| Eric Liu | 6df6600 | 2018-09-06 18:52:26 +0000 | [diff] [blame] | 170 | Deprecated |= (SemaCCResult.Availability == CXAvailability_Deprecated); |
| Sam McCall | c3b5bad | 2018-06-14 13:42:21 +0000 | [diff] [blame] | 171 | Category = categorize(SemaCCResult); |
| Sam McCall | e018b36 | 2018-06-08 09:36:34 +0000 | [diff] [blame] | 172 | |
| 173 | if (SemaCCResult.Declaration) { |
| 174 | if (auto *ID = SemaCCResult.Declaration->getIdentifier()) |
| Ilya Biryukov | 74f2655 | 2018-07-26 12:05:31 +0000 | [diff] [blame] | 175 | ReservedName = ReservedName || isReserved(ID->getName()); |
| Sam McCall | e018b36 | 2018-06-08 09:36:34 +0000 | [diff] [blame] | 176 | } else if (SemaCCResult.Kind == CodeCompletionResult::RK_Macro) |
| Ilya Biryukov | 74f2655 | 2018-07-26 12:05:31 +0000 | [diff] [blame] | 177 | ReservedName = ReservedName || isReserved(SemaCCResult.Macro->getName()); |
| Sam McCall | c5707b6 | 2018-05-15 17:43:27 +0000 | [diff] [blame] | 178 | } |
| 179 | |
| 180 | void SymbolQualitySignals::merge(const Symbol &IndexResult) { |
| Eric Liu | 6df6600 | 2018-09-06 18:52:26 +0000 | [diff] [blame] | 181 | Deprecated |= (IndexResult.Flags & Symbol::Deprecated); |
| Sam McCall | c5707b6 | 2018-05-15 17:43:27 +0000 | [diff] [blame] | 182 | References = std::max(IndexResult.References, References); |
| Sam McCall | 4a3c69b | 2018-06-06 08:53:36 +0000 | [diff] [blame] | 183 | Category = categorize(IndexResult.SymInfo); |
| Ilya Biryukov | 74f2655 | 2018-07-26 12:05:31 +0000 | [diff] [blame] | 184 | ReservedName = ReservedName || isReserved(IndexResult.Name); |
| Sam McCall | c5707b6 | 2018-05-15 17:43:27 +0000 | [diff] [blame] | 185 | } |
| 186 | |
| 187 | float SymbolQualitySignals::evaluate() const { |
| 188 | float Score = 1; |
| 189 | |
| 190 | // This avoids a sharp gradient for tail symbols, and also neatly avoids the |
| 191 | // question of whether 0 references means a bad symbol or missing data. |
| Eric Liu | 84bd5db | 2018-07-25 11:26:35 +0000 | [diff] [blame] | 192 | if (References >= 10) { |
| 193 | // Use a sigmoid style boosting function, which flats out nicely for large |
| 194 | // numbers (e.g. 2.58 for 1M refererences). |
| 195 | // The following boosting function is equivalent to: |
| 196 | // m = 0.06 |
| 197 | // f = 12.0 |
| 198 | // boost = f * sigmoid(m * std::log(References)) - 0.5 * f + 0.59 |
| 199 | // Sample data points: (10, 1.00), (100, 1.41), (1000, 1.82), |
| 200 | // (10K, 2.21), (100K, 2.58), (1M, 2.94) |
| Ilya Biryukov | 74f2655 | 2018-07-26 12:05:31 +0000 | [diff] [blame] | 201 | float S = std::pow(References, -0.06); |
| 202 | Score *= 6.0 * (1 - S) / (1 + S) + 0.59; |
| Eric Liu | 84bd5db | 2018-07-25 11:26:35 +0000 | [diff] [blame] | 203 | } |
| Sam McCall | c5707b6 | 2018-05-15 17:43:27 +0000 | [diff] [blame] | 204 | |
| Sam McCall | c5707b6 | 2018-05-15 17:43:27 +0000 | [diff] [blame] | 205 | if (Deprecated) |
| Aaron Ballman | 215e471 | 2018-05-18 13:18:41 +0000 | [diff] [blame] | 206 | Score *= 0.1f; |
| Sam McCall | e018b36 | 2018-06-08 09:36:34 +0000 | [diff] [blame] | 207 | if (ReservedName) |
| 208 | Score *= 0.1f; |
| Sam McCall | c5707b6 | 2018-05-15 17:43:27 +0000 | [diff] [blame] | 209 | |
| Sam McCall | 4a3c69b | 2018-06-06 08:53:36 +0000 | [diff] [blame] | 210 | switch (Category) { |
| Kirill Bobyrev | 7cf29bc | 2018-07-05 09:37:26 +0000 | [diff] [blame] | 211 | case Keyword: // Often relevant, but misses most signals. |
| 212 | Score *= 4; // FIXME: important keywords should have specific boosts. |
| 213 | break; |
| 214 | case Type: |
| 215 | case Function: |
| 216 | case Variable: |
| 217 | Score *= 1.1f; |
| 218 | break; |
| 219 | case Namespace: |
| 220 | Score *= 0.8f; |
| 221 | break; |
| 222 | case Macro: |
| Eric Liu | f592d28 | 2018-09-05 07:40:38 +0000 | [diff] [blame] | 223 | Score *= 0.5f; |
| Kirill Bobyrev | 7cf29bc | 2018-07-05 09:37:26 +0000 | [diff] [blame] | 224 | break; |
| 225 | case Unknown: |
| Eric Liu | d7de811 | 2018-07-24 08:51:52 +0000 | [diff] [blame] | 226 | case Constructor: // No boost constructors so they are after class types. |
| Kirill Bobyrev | 7cf29bc | 2018-07-05 09:37:26 +0000 | [diff] [blame] | 227 | break; |
| Sam McCall | 4a3c69b | 2018-06-06 08:53:36 +0000 | [diff] [blame] | 228 | } |
| 229 | |
| Sam McCall | c5707b6 | 2018-05-15 17:43:27 +0000 | [diff] [blame] | 230 | return Score; |
| 231 | } |
| 232 | |
| 233 | raw_ostream &operator<<(raw_ostream &OS, const SymbolQualitySignals &S) { |
| 234 | OS << formatv("=== Symbol quality: {0}\n", S.evaluate()); |
| Sam McCall | c5707b6 | 2018-05-15 17:43:27 +0000 | [diff] [blame] | 235 | OS << formatv("\tReferences: {0}\n", S.References); |
| 236 | OS << formatv("\tDeprecated: {0}\n", S.Deprecated); |
| Sam McCall | e018b36 | 2018-06-08 09:36:34 +0000 | [diff] [blame] | 237 | OS << formatv("\tReserved name: {0}\n", S.ReservedName); |
| Sam McCall | 4a3c69b | 2018-06-06 08:53:36 +0000 | [diff] [blame] | 238 | OS << formatv("\tCategory: {0}\n", static_cast<int>(S.Category)); |
| Sam McCall | c5707b6 | 2018-05-15 17:43:27 +0000 | [diff] [blame] | 239 | return OS; |
| 240 | } |
| 241 | |
| Sam McCall | d9b54f0 | 2018-06-05 16:30:25 +0000 | [diff] [blame] | 242 | static SymbolRelevanceSignals::AccessibleScope |
| Ilya Biryukov | 74f2655 | 2018-07-26 12:05:31 +0000 | [diff] [blame] | 243 | computeScope(const NamedDecl *D) { |
| Sam McCall | abe3737 | 2018-06-27 11:43:54 +0000 | [diff] [blame] | 244 | // Injected "Foo" within the class "Foo" has file scope, not class scope. |
| 245 | const DeclContext *DC = D->getDeclContext(); |
| 246 | if (auto *R = dyn_cast_or_null<RecordDecl>(D)) |
| 247 | if (R->isInjectedClassName()) |
| 248 | DC = DC->getParent(); |
| Eric Liu | 8944f0e | 2018-07-05 08:14:04 +0000 | [diff] [blame] | 249 | // Class constructor should have the same scope as the class. |
| Simon Pilgrim | 4a03201 | 2018-07-05 09:35:12 +0000 | [diff] [blame] | 250 | if (isa<CXXConstructorDecl>(D)) |
| Eric Liu | 8944f0e | 2018-07-05 08:14:04 +0000 | [diff] [blame] | 251 | DC = DC->getParent(); |
| Sam McCall | 89f5293 | 2018-06-05 18:00:48 +0000 | [diff] [blame] | 252 | bool InClass = false; |
| Sam McCall | abe3737 | 2018-06-27 11:43:54 +0000 | [diff] [blame] | 253 | for (; !DC->isFileContext(); DC = DC->getParent()) { |
| Sam McCall | d9b54f0 | 2018-06-05 16:30:25 +0000 | [diff] [blame] | 254 | if (DC->isFunctionOrMethod()) |
| 255 | return SymbolRelevanceSignals::FunctionScope; |
| 256 | InClass = InClass || DC->isRecord(); |
| 257 | } |
| 258 | if (InClass) |
| 259 | return SymbolRelevanceSignals::ClassScope; |
| 260 | // This threshold could be tweaked, e.g. to treat module-visible as global. |
| Sam McCall | abe3737 | 2018-06-27 11:43:54 +0000 | [diff] [blame] | 261 | if (D->getLinkageInternal() < ExternalLinkage) |
| Sam McCall | d9b54f0 | 2018-06-05 16:30:25 +0000 | [diff] [blame] | 262 | return SymbolRelevanceSignals::FileScope; |
| 263 | return SymbolRelevanceSignals::GlobalScope; |
| 264 | } |
| 265 | |
| 266 | void SymbolRelevanceSignals::merge(const Symbol &IndexResult) { |
| 267 | // FIXME: Index results always assumed to be at global scope. If Scope becomes |
| 268 | // relevant to non-completion requests, we should recognize class members etc. |
| Eric Liu | 09c3c37 | 2018-06-15 08:58:12 +0000 | [diff] [blame] | 269 | |
| 270 | SymbolURI = IndexResult.CanonicalDeclaration.FileURI; |
| Eric Liu | 5d2a807 | 2018-07-23 10:56:37 +0000 | [diff] [blame] | 271 | IsInstanceMember |= isInstanceMember(IndexResult.SymInfo); |
| Sam McCall | d9b54f0 | 2018-06-05 16:30:25 +0000 | [diff] [blame] | 272 | } |
| 273 | |
| Sam McCall | c5707b6 | 2018-05-15 17:43:27 +0000 | [diff] [blame] | 274 | void SymbolRelevanceSignals::merge(const CodeCompletionResult &SemaCCResult) { |
| 275 | if (SemaCCResult.Availability == CXAvailability_NotAvailable || |
| 276 | SemaCCResult.Availability == CXAvailability_NotAccessible) |
| 277 | Forbidden = true; |
| Ilya Biryukov | f029646 | 2018-06-04 14:50:59 +0000 | [diff] [blame] | 278 | |
| 279 | if (SemaCCResult.Declaration) { |
| Eric Liu | 09c3c37 | 2018-06-15 08:58:12 +0000 | [diff] [blame] | 280 | // We boost things that have decls in the main file. We give a fixed score |
| 281 | // for all other declarations in sema as they are already included in the |
| 282 | // translation unit. |
| Kirill Bobyrev | 47d7f52 | 2018-07-11 14:49:49 +0000 | [diff] [blame] | 283 | float DeclProximity = (hasDeclInMainFile(*SemaCCResult.Declaration) || |
| 284 | hasUsingDeclInMainFile(SemaCCResult)) |
| 285 | ? 1.0 |
| 286 | : 0.6; |
| Eric Liu | 09c3c37 | 2018-06-15 08:58:12 +0000 | [diff] [blame] | 287 | SemaProximityScore = std::max(DeclProximity, SemaProximityScore); |
| Eric Liu | 5d2a807 | 2018-07-23 10:56:37 +0000 | [diff] [blame] | 288 | IsInstanceMember |= isInstanceMember(SemaCCResult.Declaration); |
| Ilya Biryukov | f029646 | 2018-06-04 14:50:59 +0000 | [diff] [blame] | 289 | } |
| Sam McCall | d9b54f0 | 2018-06-05 16:30:25 +0000 | [diff] [blame] | 290 | |
| 291 | // Declarations are scoped, others (like macros) are assumed global. |
| Sam McCall | 661d89c | 2018-06-05 17:58:12 +0000 | [diff] [blame] | 292 | if (SemaCCResult.Declaration) |
| Ilya Biryukov | 74f2655 | 2018-07-26 12:05:31 +0000 | [diff] [blame] | 293 | Scope = std::min(Scope, computeScope(SemaCCResult.Declaration)); |
| Kadir Cetinkaya | 2f84d91 | 2018-08-08 08:59:29 +0000 | [diff] [blame] | 294 | |
| 295 | NeedsFixIts = !SemaCCResult.FixIts.empty(); |
| Sam McCall | c5707b6 | 2018-05-15 17:43:27 +0000 | [diff] [blame] | 296 | } |
| 297 | |
| Sam McCall | 3f0243f | 2018-07-03 08:09:29 +0000 | [diff] [blame] | 298 | static std::pair<float, unsigned> proximityScore(llvm::StringRef SymbolURI, |
| 299 | URIDistance *D) { |
| 300 | if (!D || SymbolURI.empty()) |
| 301 | return {0.f, 0u}; |
| 302 | unsigned Distance = D->distance(SymbolURI); |
| 303 | // Assume approximately default options are used for sensible scoring. |
| 304 | return {std::exp(Distance * -0.4f / FileDistanceOptions().UpCost), Distance}; |
| 305 | } |
| 306 | |
| Sam McCall | c5707b6 | 2018-05-15 17:43:27 +0000 | [diff] [blame] | 307 | float SymbolRelevanceSignals::evaluate() const { |
| Sam McCall | d9b54f0 | 2018-06-05 16:30:25 +0000 | [diff] [blame] | 308 | float Score = 1; |
| 309 | |
| Sam McCall | c5707b6 | 2018-05-15 17:43:27 +0000 | [diff] [blame] | 310 | if (Forbidden) |
| 311 | return 0; |
| Ilya Biryukov | f029646 | 2018-06-04 14:50:59 +0000 | [diff] [blame] | 312 | |
| Sam McCall | d9b54f0 | 2018-06-05 16:30:25 +0000 | [diff] [blame] | 313 | Score *= NameMatch; |
| 314 | |
| Ilya Biryukov | f029646 | 2018-06-04 14:50:59 +0000 | [diff] [blame] | 315 | // Proximity scores are [0,1] and we translate them into a multiplier in the |
| Sam McCall | 3f0243f | 2018-07-03 08:09:29 +0000 | [diff] [blame] | 316 | // range from 1 to 3. |
| 317 | Score *= 1 + 2 * std::max(proximityScore(SymbolURI, FileProximityMatch).first, |
| 318 | SemaProximityScore); |
| Sam McCall | d9b54f0 | 2018-06-05 16:30:25 +0000 | [diff] [blame] | 319 | |
| 320 | // Symbols like local variables may only be referenced within their scope. |
| 321 | // Conversely if we're in that scope, it's likely we'll reference them. |
| 322 | if (Query == CodeComplete) { |
| 323 | // The narrower the scope where a symbol is visible, the more likely it is |
| 324 | // to be relevant when it is available. |
| 325 | switch (Scope) { |
| 326 | case GlobalScope: |
| 327 | break; |
| 328 | case FileScope: |
| 329 | Score *= 1.5; |
| Sam McCall | c22c9aa | 2018-06-07 08:16:36 +0000 | [diff] [blame] | 330 | break; |
| Sam McCall | d9b54f0 | 2018-06-05 16:30:25 +0000 | [diff] [blame] | 331 | case ClassScope: |
| 332 | Score *= 2; |
| Sam McCall | c22c9aa | 2018-06-07 08:16:36 +0000 | [diff] [blame] | 333 | break; |
| Sam McCall | d9b54f0 | 2018-06-05 16:30:25 +0000 | [diff] [blame] | 334 | case FunctionScope: |
| 335 | Score *= 4; |
| Sam McCall | c22c9aa | 2018-06-07 08:16:36 +0000 | [diff] [blame] | 336 | break; |
| Sam McCall | d9b54f0 | 2018-06-05 16:30:25 +0000 | [diff] [blame] | 337 | } |
| 338 | } |
| 339 | |
| Eric Liu | 5d2a807 | 2018-07-23 10:56:37 +0000 | [diff] [blame] | 340 | // Penalize non-instance members when they are accessed via a class instance. |
| 341 | if (!IsInstanceMember && |
| 342 | (Context == CodeCompletionContext::CCC_DotMemberAccess || |
| 343 | Context == CodeCompletionContext::CCC_ArrowMemberAccess)) { |
| 344 | Score *= 0.5; |
| 345 | } |
| 346 | |
| Kadir Cetinkaya | 2f84d91 | 2018-08-08 08:59:29 +0000 | [diff] [blame] | 347 | // Penalize for FixIts. |
| 348 | if (NeedsFixIts) |
| 349 | Score *= 0.5; |
| 350 | |
| Ilya Biryukov | f029646 | 2018-06-04 14:50:59 +0000 | [diff] [blame] | 351 | return Score; |
| Sam McCall | c5707b6 | 2018-05-15 17:43:27 +0000 | [diff] [blame] | 352 | } |
| Eric Liu | 09c3c37 | 2018-06-15 08:58:12 +0000 | [diff] [blame] | 353 | |
| Sam McCall | c5707b6 | 2018-05-15 17:43:27 +0000 | [diff] [blame] | 354 | raw_ostream &operator<<(raw_ostream &OS, const SymbolRelevanceSignals &S) { |
| 355 | OS << formatv("=== Symbol relevance: {0}\n", S.evaluate()); |
| 356 | OS << formatv("\tName match: {0}\n", S.NameMatch); |
| 357 | OS << formatv("\tForbidden: {0}\n", S.Forbidden); |
| Kadir Cetinkaya | 2f84d91 | 2018-08-08 08:59:29 +0000 | [diff] [blame] | 358 | OS << formatv("\tNeedsFixIts: {0}\n", S.NeedsFixIts); |
| Eric Liu | 5d2a807 | 2018-07-23 10:56:37 +0000 | [diff] [blame] | 359 | OS << formatv("\tIsInstanceMember: {0}\n", S.IsInstanceMember); |
| 360 | OS << formatv("\tContext: {0}\n", getCompletionKindString(S.Context)); |
| Eric Liu | 09c3c37 | 2018-06-15 08:58:12 +0000 | [diff] [blame] | 361 | OS << formatv("\tSymbol URI: {0}\n", S.SymbolURI); |
| 362 | if (S.FileProximityMatch) { |
| Sam McCall | 3f0243f | 2018-07-03 08:09:29 +0000 | [diff] [blame] | 363 | auto Score = proximityScore(S.SymbolURI, S.FileProximityMatch); |
| 364 | OS << formatv("\tIndex proximity: {0} (distance={1})\n", Score.first, |
| 365 | Score.second); |
| Eric Liu | 09c3c37 | 2018-06-15 08:58:12 +0000 | [diff] [blame] | 366 | } |
| 367 | OS << formatv("\tSema proximity: {0}\n", S.SemaProximityScore); |
| Sam McCall | 661d89c | 2018-06-05 17:58:12 +0000 | [diff] [blame] | 368 | OS << formatv("\tQuery type: {0}\n", static_cast<int>(S.Query)); |
| 369 | OS << formatv("\tScope: {0}\n", static_cast<int>(S.Scope)); |
| Sam McCall | c5707b6 | 2018-05-15 17:43:27 +0000 | [diff] [blame] | 370 | return OS; |
| 371 | } |
| 372 | |
| 373 | float evaluateSymbolAndRelevance(float SymbolQuality, float SymbolRelevance) { |
| 374 | return SymbolQuality * SymbolRelevance; |
| 375 | } |
| 376 | |
| 377 | // Produces an integer that sorts in the same order as F. |
| 378 | // That is: a < b <==> encodeFloat(a) < encodeFloat(b). |
| 379 | static uint32_t encodeFloat(float F) { |
| 380 | static_assert(std::numeric_limits<float>::is_iec559, ""); |
| 381 | constexpr uint32_t TopBit = ~(~uint32_t{0} >> 1); |
| 382 | |
| 383 | // Get the bits of the float. Endianness is the same as for integers. |
| 384 | uint32_t U = FloatToBits(F); |
| 385 | // IEEE 754 floats compare like sign-magnitude integers. |
| 386 | if (U & TopBit) // Negative float. |
| 387 | return 0 - U; // Map onto the low half of integers, order reversed. |
| 388 | return U + TopBit; // Positive floats map onto the high half of integers. |
| 389 | } |
| 390 | |
| 391 | std::string sortText(float Score, llvm::StringRef Name) { |
| 392 | // We convert -Score to an integer, and hex-encode for readability. |
| 393 | // Example: [0.5, "foo"] -> "41000000foo" |
| 394 | std::string S; |
| 395 | llvm::raw_string_ostream OS(S); |
| 396 | write_hex(OS, encodeFloat(-Score), llvm::HexPrintStyle::Lower, |
| 397 | /*Width=*/2 * sizeof(Score)); |
| 398 | OS << Name; |
| 399 | OS.flush(); |
| 400 | return S; |
| 401 | } |
| 402 | |
| Kadir Cetinkaya | e486e37 | 2018-08-13 08:40:05 +0000 | [diff] [blame] | 403 | llvm::raw_ostream &operator<<(llvm::raw_ostream &OS, |
| 404 | const SignatureQualitySignals &S) { |
| 405 | OS << formatv("=== Signature Quality:\n"); |
| 406 | OS << formatv("\tNumber of parameters: {0}\n", S.NumberOfParameters); |
| 407 | OS << formatv("\tNumber of optional parameters: {0}\n", |
| 408 | S.NumberOfOptionalParameters); |
| 409 | OS << formatv("\tContains active parameter: {0}\n", |
| 410 | S.ContainsActiveParameter); |
| 411 | OS << formatv("\tKind: {0}\n", S.Kind); |
| 412 | return OS; |
| 413 | } |
| 414 | |
| Sam McCall | c5707b6 | 2018-05-15 17:43:27 +0000 | [diff] [blame] | 415 | } // namespace clangd |
| 416 | } // namespace clang |