Eugene Zelenko | ffec81c | 2015-11-04 22:32:32 +0000 | [diff] [blame] | 1 | //===- InstCombineAddSub.cpp ------------------------------------*- C++ -*-===// |
Chris Lattner | 82aa888 | 2010-01-05 07:18:46 +0000 | [diff] [blame] | 2 | // |
| 3 | // The LLVM Compiler Infrastructure |
| 4 | // |
| 5 | // This file is distributed under the University of Illinois Open Source |
| 6 | // License. See LICENSE.TXT for details. |
| 7 | // |
| 8 | //===----------------------------------------------------------------------===// |
| 9 | // |
| 10 | // This file implements the visit functions for add, fadd, sub, and fsub. |
| 11 | // |
| 12 | //===----------------------------------------------------------------------===// |
| 13 | |
Chandler Carruth | a917458 | 2015-01-22 05:25:13 +0000 | [diff] [blame] | 14 | #include "InstCombineInternal.h" |
Craig Topper | 5871321 | 2013-07-15 04:27:47 +0000 | [diff] [blame] | 15 | #include "llvm/ADT/STLExtras.h" |
Chris Lattner | 82aa888 | 2010-01-05 07:18:46 +0000 | [diff] [blame] | 16 | #include "llvm/Analysis/InstructionSimplify.h" |
Chandler Carruth | 9fb823b | 2013-01-02 11:36:10 +0000 | [diff] [blame] | 17 | #include "llvm/IR/DataLayout.h" |
Chandler Carruth | 03eb0de | 2014-03-04 10:40:04 +0000 | [diff] [blame] | 18 | #include "llvm/IR/GetElementPtrTypeIterator.h" |
Chandler Carruth | 820a908 | 2014-03-04 11:08:18 +0000 | [diff] [blame] | 19 | #include "llvm/IR/PatternMatch.h" |
Craig Topper | b45eabc | 2017-04-26 16:39:58 +0000 | [diff] [blame] | 20 | #include "llvm/Support/KnownBits.h" |
Eugene Zelenko | ffec81c | 2015-11-04 22:32:32 +0000 | [diff] [blame] | 21 | |
Chris Lattner | 82aa888 | 2010-01-05 07:18:46 +0000 | [diff] [blame] | 22 | using namespace llvm; |
| 23 | using namespace PatternMatch; |
| 24 | |
Chandler Carruth | 964daaa | 2014-04-22 02:55:47 +0000 | [diff] [blame] | 25 | #define DEBUG_TYPE "instcombine" |
| 26 | |
Shuxin Yang | 37a1efe | 2012-12-18 23:10:12 +0000 | [diff] [blame] | 27 | namespace { |
| 28 | |
| 29 | /// Class representing coefficient of floating-point addend. |
| 30 | /// This class needs to be highly efficient, which is especially true for |
| 31 | /// the constructor. As of I write this comment, the cost of the default |
Jim Grosbach | bdbd734 | 2013-04-05 21:20:12 +0000 | [diff] [blame] | 32 | /// constructor is merely 4-byte-store-zero (Assuming compiler is able to |
Shuxin Yang | 37a1efe | 2012-12-18 23:10:12 +0000 | [diff] [blame] | 33 | /// perform write-merging). |
Jim Grosbach | bdbd734 | 2013-04-05 21:20:12 +0000 | [diff] [blame] | 34 | /// |
Shuxin Yang | 37a1efe | 2012-12-18 23:10:12 +0000 | [diff] [blame] | 35 | class FAddendCoef { |
| 36 | public: |
Suyog Sarda | de409fd | 2014-07-17 06:09:34 +0000 | [diff] [blame] | 37 | // The constructor has to initialize a APFloat, which is unnecessary for |
Shuxin Yang | 37a1efe | 2012-12-18 23:10:12 +0000 | [diff] [blame] | 38 | // most addends which have coefficient either 1 or -1. So, the constructor |
| 39 | // is expensive. In order to avoid the cost of the constructor, we should |
| 40 | // reuse some instances whenever possible. The pre-created instances |
| 41 | // FAddCombine::Add[0-5] embodies this idea. |
| 42 | // |
| 43 | FAddendCoef() : IsFp(false), BufHasFpVal(false), IntVal(0) {} |
| 44 | ~FAddendCoef(); |
Jim Grosbach | bdbd734 | 2013-04-05 21:20:12 +0000 | [diff] [blame] | 45 | |
Shuxin Yang | 37a1efe | 2012-12-18 23:10:12 +0000 | [diff] [blame] | 46 | void set(short C) { |
| 47 | assert(!insaneIntVal(C) && "Insane coefficient"); |
| 48 | IsFp = false; IntVal = C; |
| 49 | } |
Jim Grosbach | bdbd734 | 2013-04-05 21:20:12 +0000 | [diff] [blame] | 50 | |
Shuxin Yang | 37a1efe | 2012-12-18 23:10:12 +0000 | [diff] [blame] | 51 | void set(const APFloat& C); |
Shuxin Yang | 389ed4b | 2013-03-25 20:43:41 +0000 | [diff] [blame] | 52 | |
Shuxin Yang | 37a1efe | 2012-12-18 23:10:12 +0000 | [diff] [blame] | 53 | void negate(); |
Jim Grosbach | bdbd734 | 2013-04-05 21:20:12 +0000 | [diff] [blame] | 54 | |
Shuxin Yang | 37a1efe | 2012-12-18 23:10:12 +0000 | [diff] [blame] | 55 | bool isZero() const { return isInt() ? !IntVal : getFpVal().isZero(); } |
| 56 | Value *getValue(Type *) const; |
Jim Grosbach | bdbd734 | 2013-04-05 21:20:12 +0000 | [diff] [blame] | 57 | |
Shuxin Yang | 37a1efe | 2012-12-18 23:10:12 +0000 | [diff] [blame] | 58 | // If possible, don't define operator+/operator- etc because these |
| 59 | // operators inevitably call FAddendCoef's constructor which is not cheap. |
| 60 | void operator=(const FAddendCoef &A); |
| 61 | void operator+=(const FAddendCoef &A); |
Shuxin Yang | 37a1efe | 2012-12-18 23:10:12 +0000 | [diff] [blame] | 62 | void operator*=(const FAddendCoef &S); |
Jim Grosbach | bdbd734 | 2013-04-05 21:20:12 +0000 | [diff] [blame] | 63 | |
Shuxin Yang | 37a1efe | 2012-12-18 23:10:12 +0000 | [diff] [blame] | 64 | bool isOne() const { return isInt() && IntVal == 1; } |
| 65 | bool isTwo() const { return isInt() && IntVal == 2; } |
| 66 | bool isMinusOne() const { return isInt() && IntVal == -1; } |
| 67 | bool isMinusTwo() const { return isInt() && IntVal == -2; } |
Jim Grosbach | bdbd734 | 2013-04-05 21:20:12 +0000 | [diff] [blame] | 68 | |
Shuxin Yang | 37a1efe | 2012-12-18 23:10:12 +0000 | [diff] [blame] | 69 | private: |
| 70 | bool insaneIntVal(int V) { return V > 4 || V < -4; } |
Eugene Zelenko | ffec81c | 2015-11-04 22:32:32 +0000 | [diff] [blame] | 71 | APFloat *getFpValPtr() |
Shuxin Yang | 5b841c4 | 2012-12-19 01:10:17 +0000 | [diff] [blame] | 72 | { return reinterpret_cast<APFloat*>(&FpValBuf.buffer[0]); } |
Eugene Zelenko | ffec81c | 2015-11-04 22:32:32 +0000 | [diff] [blame] | 73 | const APFloat *getFpValPtr() const |
David Greene | 530430b | 2013-01-14 21:04:40 +0000 | [diff] [blame] | 74 | { return reinterpret_cast<const APFloat*>(&FpValBuf.buffer[0]); } |
Shuxin Yang | 37a1efe | 2012-12-18 23:10:12 +0000 | [diff] [blame] | 75 | |
Eugene Zelenko | ffec81c | 2015-11-04 22:32:32 +0000 | [diff] [blame] | 76 | const APFloat &getFpVal() const { |
Shuxin Yang | 37a1efe | 2012-12-18 23:10:12 +0000 | [diff] [blame] | 77 | assert(IsFp && BufHasFpVal && "Incorret state"); |
David Greene | 530430b | 2013-01-14 21:04:40 +0000 | [diff] [blame] | 78 | return *getFpValPtr(); |
Shuxin Yang | 37a1efe | 2012-12-18 23:10:12 +0000 | [diff] [blame] | 79 | } |
| 80 | |
Eugene Zelenko | ffec81c | 2015-11-04 22:32:32 +0000 | [diff] [blame] | 81 | APFloat &getFpVal() { |
Jim Grosbach | bdbd734 | 2013-04-05 21:20:12 +0000 | [diff] [blame] | 82 | assert(IsFp && BufHasFpVal && "Incorret state"); |
| 83 | return *getFpValPtr(); |
| 84 | } |
| 85 | |
Shuxin Yang | 37a1efe | 2012-12-18 23:10:12 +0000 | [diff] [blame] | 86 | bool isInt() const { return !IsFp; } |
| 87 | |
Shuxin Yang | 389ed4b | 2013-03-25 20:43:41 +0000 | [diff] [blame] | 88 | // If the coefficient is represented by an integer, promote it to a |
Jim Grosbach | bdbd734 | 2013-04-05 21:20:12 +0000 | [diff] [blame] | 89 | // floating point. |
Shuxin Yang | 389ed4b | 2013-03-25 20:43:41 +0000 | [diff] [blame] | 90 | void convertToFpType(const fltSemantics &Sem); |
| 91 | |
| 92 | // Construct an APFloat from a signed integer. |
| 93 | // TODO: We should get rid of this function when APFloat can be constructed |
Jim Grosbach | bdbd734 | 2013-04-05 21:20:12 +0000 | [diff] [blame] | 94 | // from an *SIGNED* integer. |
Shuxin Yang | 389ed4b | 2013-03-25 20:43:41 +0000 | [diff] [blame] | 95 | APFloat createAPFloatFromInt(const fltSemantics &Sem, int Val); |
Shuxin Yang | 5b841c4 | 2012-12-19 01:10:17 +0000 | [diff] [blame] | 96 | |
Eugene Zelenko | ffec81c | 2015-11-04 22:32:32 +0000 | [diff] [blame] | 97 | private: |
Shuxin Yang | 37a1efe | 2012-12-18 23:10:12 +0000 | [diff] [blame] | 98 | bool IsFp; |
Jim Grosbach | bdbd734 | 2013-04-05 21:20:12 +0000 | [diff] [blame] | 99 | |
Shuxin Yang | 37a1efe | 2012-12-18 23:10:12 +0000 | [diff] [blame] | 100 | // True iff FpValBuf contains an instance of APFloat. |
| 101 | bool BufHasFpVal; |
Jim Grosbach | bdbd734 | 2013-04-05 21:20:12 +0000 | [diff] [blame] | 102 | |
Shuxin Yang | 37a1efe | 2012-12-18 23:10:12 +0000 | [diff] [blame] | 103 | // The integer coefficient of an individual addend is either 1 or -1, |
| 104 | // and we try to simplify at most 4 addends from neighboring at most |
| 105 | // two instructions. So the range of <IntVal> falls in [-4, 4]. APInt |
| 106 | // is overkill of this end. |
| 107 | short IntVal; |
Shuxin Yang | 5b841c4 | 2012-12-19 01:10:17 +0000 | [diff] [blame] | 108 | |
| 109 | AlignedCharArrayUnion<APFloat> FpValBuf; |
Shuxin Yang | 37a1efe | 2012-12-18 23:10:12 +0000 | [diff] [blame] | 110 | }; |
Jim Grosbach | bdbd734 | 2013-04-05 21:20:12 +0000 | [diff] [blame] | 111 | |
Shuxin Yang | 37a1efe | 2012-12-18 23:10:12 +0000 | [diff] [blame] | 112 | /// FAddend is used to represent floating-point addend. An addend is |
| 113 | /// represented as <C, V>, where the V is a symbolic value, and C is a |
| 114 | /// constant coefficient. A constant addend is represented as <C, 0>. |
| 115 | /// |
| 116 | class FAddend { |
| 117 | public: |
Eugene Zelenko | ffec81c | 2015-11-04 22:32:32 +0000 | [diff] [blame] | 118 | FAddend() : Val(nullptr) {} |
Jim Grosbach | bdbd734 | 2013-04-05 21:20:12 +0000 | [diff] [blame] | 119 | |
Eugene Zelenko | ffec81c | 2015-11-04 22:32:32 +0000 | [diff] [blame] | 120 | Value *getSymVal() const { return Val; } |
| 121 | const FAddendCoef &getCoef() const { return Coeff; } |
Jim Grosbach | bdbd734 | 2013-04-05 21:20:12 +0000 | [diff] [blame] | 122 | |
Craig Topper | f40110f | 2014-04-25 05:29:35 +0000 | [diff] [blame] | 123 | bool isConstant() const { return Val == nullptr; } |
Shuxin Yang | 37a1efe | 2012-12-18 23:10:12 +0000 | [diff] [blame] | 124 | bool isZero() const { return Coeff.isZero(); } |
| 125 | |
Richard Trieu | 7a08381 | 2016-02-18 22:09:30 +0000 | [diff] [blame] | 126 | void set(short Coefficient, Value *V) { |
| 127 | Coeff.set(Coefficient); |
| 128 | Val = V; |
| 129 | } |
| 130 | void set(const APFloat &Coefficient, Value *V) { |
| 131 | Coeff.set(Coefficient); |
| 132 | Val = V; |
| 133 | } |
| 134 | void set(const ConstantFP *Coefficient, Value *V) { |
| 135 | Coeff.set(Coefficient->getValueAPF()); |
| 136 | Val = V; |
| 137 | } |
Jim Grosbach | bdbd734 | 2013-04-05 21:20:12 +0000 | [diff] [blame] | 138 | |
Shuxin Yang | 37a1efe | 2012-12-18 23:10:12 +0000 | [diff] [blame] | 139 | void negate() { Coeff.negate(); } |
Jim Grosbach | bdbd734 | 2013-04-05 21:20:12 +0000 | [diff] [blame] | 140 | |
Shuxin Yang | 37a1efe | 2012-12-18 23:10:12 +0000 | [diff] [blame] | 141 | /// Drill down the U-D chain one step to find the definition of V, and |
| 142 | /// try to break the definition into one or two addends. |
| 143 | static unsigned drillValueDownOneStep(Value* V, FAddend &A0, FAddend &A1); |
Jim Grosbach | bdbd734 | 2013-04-05 21:20:12 +0000 | [diff] [blame] | 144 | |
Shuxin Yang | 37a1efe | 2012-12-18 23:10:12 +0000 | [diff] [blame] | 145 | /// Similar to FAddend::drillDownOneStep() except that the value being |
| 146 | /// splitted is the addend itself. |
| 147 | unsigned drillAddendDownOneStep(FAddend &Addend0, FAddend &Addend1) const; |
Jim Grosbach | bdbd734 | 2013-04-05 21:20:12 +0000 | [diff] [blame] | 148 | |
Shuxin Yang | 37a1efe | 2012-12-18 23:10:12 +0000 | [diff] [blame] | 149 | void operator+=(const FAddend &T) { |
| 150 | assert((Val == T.Val) && "Symbolic-values disagree"); |
| 151 | Coeff += T.Coeff; |
| 152 | } |
| 153 | |
| 154 | private: |
| 155 | void Scale(const FAddendCoef& ScaleAmt) { Coeff *= ScaleAmt; } |
Jim Grosbach | bdbd734 | 2013-04-05 21:20:12 +0000 | [diff] [blame] | 156 | |
Shuxin Yang | 37a1efe | 2012-12-18 23:10:12 +0000 | [diff] [blame] | 157 | // This addend has the value of "Coeff * Val". |
| 158 | Value *Val; |
| 159 | FAddendCoef Coeff; |
| 160 | }; |
Jim Grosbach | bdbd734 | 2013-04-05 21:20:12 +0000 | [diff] [blame] | 161 | |
Shuxin Yang | 37a1efe | 2012-12-18 23:10:12 +0000 | [diff] [blame] | 162 | /// FAddCombine is the class for optimizing an unsafe fadd/fsub along |
| 163 | /// with its neighboring at most two instructions. |
| 164 | /// |
| 165 | class FAddCombine { |
| 166 | public: |
Craig Topper | f40110f | 2014-04-25 05:29:35 +0000 | [diff] [blame] | 167 | FAddCombine(InstCombiner::BuilderTy *B) : Builder(B), Instr(nullptr) {} |
Shuxin Yang | 37a1efe | 2012-12-18 23:10:12 +0000 | [diff] [blame] | 168 | Value *simplify(Instruction *FAdd); |
Jim Grosbach | bdbd734 | 2013-04-05 21:20:12 +0000 | [diff] [blame] | 169 | |
Shuxin Yang | 37a1efe | 2012-12-18 23:10:12 +0000 | [diff] [blame] | 170 | private: |
| 171 | typedef SmallVector<const FAddend*, 4> AddendVect; |
Jim Grosbach | bdbd734 | 2013-04-05 21:20:12 +0000 | [diff] [blame] | 172 | |
Shuxin Yang | 37a1efe | 2012-12-18 23:10:12 +0000 | [diff] [blame] | 173 | Value *simplifyFAdd(AddendVect& V, unsigned InstrQuota); |
Shuxin Yang | 2eca602 | 2013-03-14 18:08:26 +0000 | [diff] [blame] | 174 | |
| 175 | Value *performFactorization(Instruction *I); |
| 176 | |
Shuxin Yang | 37a1efe | 2012-12-18 23:10:12 +0000 | [diff] [blame] | 177 | /// Convert given addend to a Value |
| 178 | Value *createAddendVal(const FAddend &A, bool& NeedNeg); |
Jim Grosbach | bdbd734 | 2013-04-05 21:20:12 +0000 | [diff] [blame] | 179 | |
Shuxin Yang | 37a1efe | 2012-12-18 23:10:12 +0000 | [diff] [blame] | 180 | /// Return the number of instructions needed to emit the N-ary addition. |
| 181 | unsigned calcInstrNumber(const AddendVect& Vect); |
| 182 | Value *createFSub(Value *Opnd0, Value *Opnd1); |
| 183 | Value *createFAdd(Value *Opnd0, Value *Opnd1); |
| 184 | Value *createFMul(Value *Opnd0, Value *Opnd1); |
Shuxin Yang | 2eca602 | 2013-03-14 18:08:26 +0000 | [diff] [blame] | 185 | Value *createFDiv(Value *Opnd0, Value *Opnd1); |
Shuxin Yang | 37a1efe | 2012-12-18 23:10:12 +0000 | [diff] [blame] | 186 | Value *createFNeg(Value *V); |
| 187 | Value *createNaryFAdd(const AddendVect& Opnds, unsigned InstrQuota); |
Owen Anderson | 1664dc8 | 2014-01-20 07:44:53 +0000 | [diff] [blame] | 188 | void createInstPostProc(Instruction *NewInst, bool NoNumber = false); |
Jim Grosbach | bdbd734 | 2013-04-05 21:20:12 +0000 | [diff] [blame] | 189 | |
Shuxin Yang | 37a1efe | 2012-12-18 23:10:12 +0000 | [diff] [blame] | 190 | InstCombiner::BuilderTy *Builder; |
| 191 | Instruction *Instr; |
Jim Grosbach | bdbd734 | 2013-04-05 21:20:12 +0000 | [diff] [blame] | 192 | |
Shuxin Yang | 37a1efe | 2012-12-18 23:10:12 +0000 | [diff] [blame] | 193 | // Debugging stuff are clustered here. |
| 194 | #ifndef NDEBUG |
| 195 | unsigned CreateInstrNum; |
| 196 | void initCreateInstNum() { CreateInstrNum = 0; } |
| 197 | void incCreateInstNum() { CreateInstrNum++; } |
| 198 | #else |
| 199 | void initCreateInstNum() {} |
| 200 | void incCreateInstNum() {} |
| 201 | #endif |
| 202 | }; |
Eugene Zelenko | ffec81c | 2015-11-04 22:32:32 +0000 | [diff] [blame] | 203 | |
| 204 | } // anonymous namespace |
Shuxin Yang | 37a1efe | 2012-12-18 23:10:12 +0000 | [diff] [blame] | 205 | |
| 206 | //===----------------------------------------------------------------------===// |
| 207 | // |
| 208 | // Implementation of |
| 209 | // {FAddendCoef, FAddend, FAddition, FAddCombine}. |
| 210 | // |
| 211 | //===----------------------------------------------------------------------===// |
| 212 | FAddendCoef::~FAddendCoef() { |
| 213 | if (BufHasFpVal) |
| 214 | getFpValPtr()->~APFloat(); |
| 215 | } |
| 216 | |
| 217 | void FAddendCoef::set(const APFloat& C) { |
| 218 | APFloat *P = getFpValPtr(); |
| 219 | |
| 220 | if (isInt()) { |
| 221 | // As the buffer is meanless byte stream, we cannot call |
| 222 | // APFloat::operator=(). |
| 223 | new(P) APFloat(C); |
| 224 | } else |
| 225 | *P = C; |
| 226 | |
Jim Grosbach | bdbd734 | 2013-04-05 21:20:12 +0000 | [diff] [blame] | 227 | IsFp = BufHasFpVal = true; |
Shuxin Yang | 37a1efe | 2012-12-18 23:10:12 +0000 | [diff] [blame] | 228 | } |
| 229 | |
Shuxin Yang | 389ed4b | 2013-03-25 20:43:41 +0000 | [diff] [blame] | 230 | void FAddendCoef::convertToFpType(const fltSemantics &Sem) { |
| 231 | if (!isInt()) |
| 232 | return; |
| 233 | |
| 234 | APFloat *P = getFpValPtr(); |
| 235 | if (IntVal > 0) |
| 236 | new(P) APFloat(Sem, IntVal); |
| 237 | else { |
| 238 | new(P) APFloat(Sem, 0 - IntVal); |
| 239 | P->changeSign(); |
| 240 | } |
Jim Grosbach | bdbd734 | 2013-04-05 21:20:12 +0000 | [diff] [blame] | 241 | IsFp = BufHasFpVal = true; |
Shuxin Yang | 389ed4b | 2013-03-25 20:43:41 +0000 | [diff] [blame] | 242 | } |
| 243 | |
| 244 | APFloat FAddendCoef::createAPFloatFromInt(const fltSemantics &Sem, int Val) { |
| 245 | if (Val >= 0) |
| 246 | return APFloat(Sem, Val); |
| 247 | |
| 248 | APFloat T(Sem, 0 - Val); |
| 249 | T.changeSign(); |
| 250 | |
| 251 | return T; |
| 252 | } |
| 253 | |
| 254 | void FAddendCoef::operator=(const FAddendCoef &That) { |
Shuxin Yang | 37a1efe | 2012-12-18 23:10:12 +0000 | [diff] [blame] | 255 | if (That.isInt()) |
| 256 | set(That.IntVal); |
| 257 | else |
| 258 | set(That.getFpVal()); |
| 259 | } |
| 260 | |
| 261 | void FAddendCoef::operator+=(const FAddendCoef &That) { |
| 262 | enum APFloat::roundingMode RndMode = APFloat::rmNearestTiesToEven; |
| 263 | if (isInt() == That.isInt()) { |
| 264 | if (isInt()) |
| 265 | IntVal += That.IntVal; |
| 266 | else |
| 267 | getFpVal().add(That.getFpVal(), RndMode); |
| 268 | return; |
| 269 | } |
Jim Grosbach | bdbd734 | 2013-04-05 21:20:12 +0000 | [diff] [blame] | 270 | |
Shuxin Yang | 37a1efe | 2012-12-18 23:10:12 +0000 | [diff] [blame] | 271 | if (isInt()) { |
| 272 | const APFloat &T = That.getFpVal(); |
Shuxin Yang | 389ed4b | 2013-03-25 20:43:41 +0000 | [diff] [blame] | 273 | convertToFpType(T.getSemantics()); |
| 274 | getFpVal().add(T, RndMode); |
Shuxin Yang | 37a1efe | 2012-12-18 23:10:12 +0000 | [diff] [blame] | 275 | return; |
| 276 | } |
Jim Grosbach | bdbd734 | 2013-04-05 21:20:12 +0000 | [diff] [blame] | 277 | |
Shuxin Yang | 37a1efe | 2012-12-18 23:10:12 +0000 | [diff] [blame] | 278 | APFloat &T = getFpVal(); |
Shuxin Yang | 389ed4b | 2013-03-25 20:43:41 +0000 | [diff] [blame] | 279 | T.add(createAPFloatFromInt(T.getSemantics(), That.IntVal), RndMode); |
Shuxin Yang | 37a1efe | 2012-12-18 23:10:12 +0000 | [diff] [blame] | 280 | } |
| 281 | |
Shuxin Yang | 37a1efe | 2012-12-18 23:10:12 +0000 | [diff] [blame] | 282 | void FAddendCoef::operator*=(const FAddendCoef &That) { |
| 283 | if (That.isOne()) |
| 284 | return; |
| 285 | |
| 286 | if (That.isMinusOne()) { |
| 287 | negate(); |
| 288 | return; |
| 289 | } |
| 290 | |
| 291 | if (isInt() && That.isInt()) { |
| 292 | int Res = IntVal * (int)That.IntVal; |
| 293 | assert(!insaneIntVal(Res) && "Insane int value"); |
| 294 | IntVal = Res; |
| 295 | return; |
| 296 | } |
| 297 | |
Jim Grosbach | bdbd734 | 2013-04-05 21:20:12 +0000 | [diff] [blame] | 298 | const fltSemantics &Semantic = |
Shuxin Yang | 37a1efe | 2012-12-18 23:10:12 +0000 | [diff] [blame] | 299 | isInt() ? That.getFpVal().getSemantics() : getFpVal().getSemantics(); |
| 300 | |
| 301 | if (isInt()) |
Shuxin Yang | 389ed4b | 2013-03-25 20:43:41 +0000 | [diff] [blame] | 302 | convertToFpType(Semantic); |
Shuxin Yang | 37a1efe | 2012-12-18 23:10:12 +0000 | [diff] [blame] | 303 | APFloat &F0 = getFpVal(); |
| 304 | |
| 305 | if (That.isInt()) |
Shuxin Yang | 389ed4b | 2013-03-25 20:43:41 +0000 | [diff] [blame] | 306 | F0.multiply(createAPFloatFromInt(Semantic, That.IntVal), |
| 307 | APFloat::rmNearestTiesToEven); |
Shuxin Yang | 37a1efe | 2012-12-18 23:10:12 +0000 | [diff] [blame] | 308 | else |
| 309 | F0.multiply(That.getFpVal(), APFloat::rmNearestTiesToEven); |
Shuxin Yang | 37a1efe | 2012-12-18 23:10:12 +0000 | [diff] [blame] | 310 | } |
| 311 | |
| 312 | void FAddendCoef::negate() { |
| 313 | if (isInt()) |
| 314 | IntVal = 0 - IntVal; |
| 315 | else |
| 316 | getFpVal().changeSign(); |
| 317 | } |
| 318 | |
| 319 | Value *FAddendCoef::getValue(Type *Ty) const { |
| 320 | return isInt() ? |
| 321 | ConstantFP::get(Ty, float(IntVal)) : |
| 322 | ConstantFP::get(Ty->getContext(), getFpVal()); |
| 323 | } |
| 324 | |
| 325 | // The definition of <Val> Addends |
| 326 | // ========================================= |
| 327 | // A + B <1, A>, <1,B> |
| 328 | // A - B <1, A>, <1,B> |
| 329 | // 0 - B <-1, B> |
| 330 | // C * A, <C, A> |
Jim Grosbach | bdbd734 | 2013-04-05 21:20:12 +0000 | [diff] [blame] | 331 | // A + C <1, A> <C, NULL> |
Shuxin Yang | 37a1efe | 2012-12-18 23:10:12 +0000 | [diff] [blame] | 332 | // 0 +/- 0 <0, NULL> (corner case) |
| 333 | // |
| 334 | // Legend: A and B are not constant, C is constant |
Jim Grosbach | bdbd734 | 2013-04-05 21:20:12 +0000 | [diff] [blame] | 335 | // |
Shuxin Yang | 37a1efe | 2012-12-18 23:10:12 +0000 | [diff] [blame] | 336 | unsigned FAddend::drillValueDownOneStep |
| 337 | (Value *Val, FAddend &Addend0, FAddend &Addend1) { |
Craig Topper | f40110f | 2014-04-25 05:29:35 +0000 | [diff] [blame] | 338 | Instruction *I = nullptr; |
| 339 | if (!Val || !(I = dyn_cast<Instruction>(Val))) |
Shuxin Yang | 37a1efe | 2012-12-18 23:10:12 +0000 | [diff] [blame] | 340 | return 0; |
| 341 | |
| 342 | unsigned Opcode = I->getOpcode(); |
| 343 | |
| 344 | if (Opcode == Instruction::FAdd || Opcode == Instruction::FSub) { |
| 345 | ConstantFP *C0, *C1; |
| 346 | Value *Opnd0 = I->getOperand(0); |
| 347 | Value *Opnd1 = I->getOperand(1); |
| 348 | if ((C0 = dyn_cast<ConstantFP>(Opnd0)) && C0->isZero()) |
Craig Topper | f40110f | 2014-04-25 05:29:35 +0000 | [diff] [blame] | 349 | Opnd0 = nullptr; |
Shuxin Yang | 37a1efe | 2012-12-18 23:10:12 +0000 | [diff] [blame] | 350 | |
| 351 | if ((C1 = dyn_cast<ConstantFP>(Opnd1)) && C1->isZero()) |
Craig Topper | f40110f | 2014-04-25 05:29:35 +0000 | [diff] [blame] | 352 | Opnd1 = nullptr; |
Shuxin Yang | 37a1efe | 2012-12-18 23:10:12 +0000 | [diff] [blame] | 353 | |
| 354 | if (Opnd0) { |
| 355 | if (!C0) |
| 356 | Addend0.set(1, Opnd0); |
| 357 | else |
Craig Topper | f40110f | 2014-04-25 05:29:35 +0000 | [diff] [blame] | 358 | Addend0.set(C0, nullptr); |
Shuxin Yang | 37a1efe | 2012-12-18 23:10:12 +0000 | [diff] [blame] | 359 | } |
| 360 | |
| 361 | if (Opnd1) { |
| 362 | FAddend &Addend = Opnd0 ? Addend1 : Addend0; |
| 363 | if (!C1) |
| 364 | Addend.set(1, Opnd1); |
| 365 | else |
Craig Topper | f40110f | 2014-04-25 05:29:35 +0000 | [diff] [blame] | 366 | Addend.set(C1, nullptr); |
Shuxin Yang | 37a1efe | 2012-12-18 23:10:12 +0000 | [diff] [blame] | 367 | if (Opcode == Instruction::FSub) |
| 368 | Addend.negate(); |
| 369 | } |
| 370 | |
| 371 | if (Opnd0 || Opnd1) |
| 372 | return Opnd0 && Opnd1 ? 2 : 1; |
| 373 | |
| 374 | // Both operands are zero. Weird! |
Craig Topper | f40110f | 2014-04-25 05:29:35 +0000 | [diff] [blame] | 375 | Addend0.set(APFloat(C0->getValueAPF().getSemantics()), nullptr); |
Shuxin Yang | 37a1efe | 2012-12-18 23:10:12 +0000 | [diff] [blame] | 376 | return 1; |
| 377 | } |
| 378 | |
| 379 | if (I->getOpcode() == Instruction::FMul) { |
| 380 | Value *V0 = I->getOperand(0); |
| 381 | Value *V1 = I->getOperand(1); |
| 382 | if (ConstantFP *C = dyn_cast<ConstantFP>(V0)) { |
| 383 | Addend0.set(C, V1); |
| 384 | return 1; |
| 385 | } |
| 386 | |
| 387 | if (ConstantFP *C = dyn_cast<ConstantFP>(V1)) { |
| 388 | Addend0.set(C, V0); |
| 389 | return 1; |
| 390 | } |
| 391 | } |
| 392 | |
| 393 | return 0; |
| 394 | } |
| 395 | |
| 396 | // Try to break *this* addend into two addends. e.g. Suppose this addend is |
| 397 | // <2.3, V>, and V = X + Y, by calling this function, we obtain two addends, |
| 398 | // i.e. <2.3, X> and <2.3, Y>. |
| 399 | // |
| 400 | unsigned FAddend::drillAddendDownOneStep |
| 401 | (FAddend &Addend0, FAddend &Addend1) const { |
| 402 | if (isConstant()) |
| 403 | return 0; |
| 404 | |
| 405 | unsigned BreakNum = FAddend::drillValueDownOneStep(Val, Addend0, Addend1); |
Jim Grosbach | bdbd734 | 2013-04-05 21:20:12 +0000 | [diff] [blame] | 406 | if (!BreakNum || Coeff.isOne()) |
Shuxin Yang | 37a1efe | 2012-12-18 23:10:12 +0000 | [diff] [blame] | 407 | return BreakNum; |
| 408 | |
| 409 | Addend0.Scale(Coeff); |
| 410 | |
| 411 | if (BreakNum == 2) |
| 412 | Addend1.Scale(Coeff); |
| 413 | |
| 414 | return BreakNum; |
| 415 | } |
| 416 | |
Shuxin Yang | 2eca602 | 2013-03-14 18:08:26 +0000 | [diff] [blame] | 417 | // Try to perform following optimization on the input instruction I. Return the |
| 418 | // simplified expression if was successful; otherwise, return 0. |
| 419 | // |
| 420 | // Instruction "I" is Simplified into |
| 421 | // ------------------------------------------------------- |
| 422 | // (x * y) +/- (x * z) x * (y +/- z) |
| 423 | // (y / x) +/- (z / x) (y +/- z) / x |
| 424 | // |
| 425 | Value *FAddCombine::performFactorization(Instruction *I) { |
| 426 | assert((I->getOpcode() == Instruction::FAdd || |
| 427 | I->getOpcode() == Instruction::FSub) && "Expect add/sub"); |
Jim Grosbach | bdbd734 | 2013-04-05 21:20:12 +0000 | [diff] [blame] | 428 | |
Shuxin Yang | 2eca602 | 2013-03-14 18:08:26 +0000 | [diff] [blame] | 429 | Instruction *I0 = dyn_cast<Instruction>(I->getOperand(0)); |
| 430 | Instruction *I1 = dyn_cast<Instruction>(I->getOperand(1)); |
Jim Grosbach | bdbd734 | 2013-04-05 21:20:12 +0000 | [diff] [blame] | 431 | |
Shuxin Yang | 2eca602 | 2013-03-14 18:08:26 +0000 | [diff] [blame] | 432 | if (!I0 || !I1 || I0->getOpcode() != I1->getOpcode()) |
Craig Topper | f40110f | 2014-04-25 05:29:35 +0000 | [diff] [blame] | 433 | return nullptr; |
Shuxin Yang | 2eca602 | 2013-03-14 18:08:26 +0000 | [diff] [blame] | 434 | |
| 435 | bool isMpy = false; |
| 436 | if (I0->getOpcode() == Instruction::FMul) |
| 437 | isMpy = true; |
| 438 | else if (I0->getOpcode() != Instruction::FDiv) |
Craig Topper | f40110f | 2014-04-25 05:29:35 +0000 | [diff] [blame] | 439 | return nullptr; |
Shuxin Yang | 2eca602 | 2013-03-14 18:08:26 +0000 | [diff] [blame] | 440 | |
| 441 | Value *Opnd0_0 = I0->getOperand(0); |
| 442 | Value *Opnd0_1 = I0->getOperand(1); |
| 443 | Value *Opnd1_0 = I1->getOperand(0); |
| 444 | Value *Opnd1_1 = I1->getOperand(1); |
| 445 | |
Jim Grosbach | bdbd734 | 2013-04-05 21:20:12 +0000 | [diff] [blame] | 446 | // Input Instr I Factor AddSub0 AddSub1 |
Shuxin Yang | 2eca602 | 2013-03-14 18:08:26 +0000 | [diff] [blame] | 447 | // ---------------------------------------------- |
| 448 | // (x*y) +/- (x*z) x y z |
| 449 | // (y/x) +/- (z/x) x y z |
| 450 | // |
Craig Topper | f40110f | 2014-04-25 05:29:35 +0000 | [diff] [blame] | 451 | Value *Factor = nullptr; |
| 452 | Value *AddSub0 = nullptr, *AddSub1 = nullptr; |
Jim Grosbach | bdbd734 | 2013-04-05 21:20:12 +0000 | [diff] [blame] | 453 | |
Shuxin Yang | 2eca602 | 2013-03-14 18:08:26 +0000 | [diff] [blame] | 454 | if (isMpy) { |
| 455 | if (Opnd0_0 == Opnd1_0 || Opnd0_0 == Opnd1_1) |
| 456 | Factor = Opnd0_0; |
| 457 | else if (Opnd0_1 == Opnd1_0 || Opnd0_1 == Opnd1_1) |
| 458 | Factor = Opnd0_1; |
| 459 | |
| 460 | if (Factor) { |
| 461 | AddSub0 = (Factor == Opnd0_0) ? Opnd0_1 : Opnd0_0; |
| 462 | AddSub1 = (Factor == Opnd1_0) ? Opnd1_1 : Opnd1_0; |
| 463 | } |
| 464 | } else if (Opnd0_1 == Opnd1_1) { |
| 465 | Factor = Opnd0_1; |
| 466 | AddSub0 = Opnd0_0; |
| 467 | AddSub1 = Opnd1_0; |
| 468 | } |
| 469 | |
| 470 | if (!Factor) |
Craig Topper | f40110f | 2014-04-25 05:29:35 +0000 | [diff] [blame] | 471 | return nullptr; |
Shuxin Yang | 2eca602 | 2013-03-14 18:08:26 +0000 | [diff] [blame] | 472 | |
Owen Anderson | 1664dc8 | 2014-01-20 07:44:53 +0000 | [diff] [blame] | 473 | FastMathFlags Flags; |
| 474 | Flags.setUnsafeAlgebra(); |
| 475 | if (I0) Flags &= I->getFastMathFlags(); |
| 476 | if (I1) Flags &= I->getFastMathFlags(); |
| 477 | |
Shuxin Yang | 2eca602 | 2013-03-14 18:08:26 +0000 | [diff] [blame] | 478 | // Create expression "NewAddSub = AddSub0 +/- AddsSub1" |
| 479 | Value *NewAddSub = (I->getOpcode() == Instruction::FAdd) ? |
| 480 | createFAdd(AddSub0, AddSub1) : |
| 481 | createFSub(AddSub0, AddSub1); |
| 482 | if (ConstantFP *CFP = dyn_cast<ConstantFP>(NewAddSub)) { |
| 483 | const APFloat &F = CFP->getValueAPF(); |
Michael Gottesman | c2af8d6 | 2013-06-26 23:17:31 +0000 | [diff] [blame] | 484 | if (!F.isNormal()) |
Craig Topper | f40110f | 2014-04-25 05:29:35 +0000 | [diff] [blame] | 485 | return nullptr; |
Owen Anderson | 1664dc8 | 2014-01-20 07:44:53 +0000 | [diff] [blame] | 486 | } else if (Instruction *II = dyn_cast<Instruction>(NewAddSub)) |
| 487 | II->setFastMathFlags(Flags); |
| 488 | |
| 489 | if (isMpy) { |
| 490 | Value *RI = createFMul(Factor, NewAddSub); |
| 491 | if (Instruction *II = dyn_cast<Instruction>(RI)) |
| 492 | II->setFastMathFlags(Flags); |
| 493 | return RI; |
Shuxin Yang | 2eca602 | 2013-03-14 18:08:26 +0000 | [diff] [blame] | 494 | } |
| 495 | |
Owen Anderson | 1664dc8 | 2014-01-20 07:44:53 +0000 | [diff] [blame] | 496 | Value *RI = createFDiv(NewAddSub, Factor); |
| 497 | if (Instruction *II = dyn_cast<Instruction>(RI)) |
| 498 | II->setFastMathFlags(Flags); |
| 499 | return RI; |
Shuxin Yang | 2eca602 | 2013-03-14 18:08:26 +0000 | [diff] [blame] | 500 | } |
| 501 | |
Shuxin Yang | 37a1efe | 2012-12-18 23:10:12 +0000 | [diff] [blame] | 502 | Value *FAddCombine::simplify(Instruction *I) { |
| 503 | assert(I->hasUnsafeAlgebra() && "Should be in unsafe mode"); |
| 504 | |
| 505 | // Currently we are not able to handle vector type. |
| 506 | if (I->getType()->isVectorTy()) |
Craig Topper | f40110f | 2014-04-25 05:29:35 +0000 | [diff] [blame] | 507 | return nullptr; |
Shuxin Yang | 37a1efe | 2012-12-18 23:10:12 +0000 | [diff] [blame] | 508 | |
| 509 | assert((I->getOpcode() == Instruction::FAdd || |
| 510 | I->getOpcode() == Instruction::FSub) && "Expect add/sub"); |
| 511 | |
Jim Grosbach | bdbd734 | 2013-04-05 21:20:12 +0000 | [diff] [blame] | 512 | // Save the instruction before calling other member-functions. |
Shuxin Yang | 37a1efe | 2012-12-18 23:10:12 +0000 | [diff] [blame] | 513 | Instr = I; |
| 514 | |
| 515 | FAddend Opnd0, Opnd1, Opnd0_0, Opnd0_1, Opnd1_0, Opnd1_1; |
| 516 | |
| 517 | unsigned OpndNum = FAddend::drillValueDownOneStep(I, Opnd0, Opnd1); |
| 518 | |
| 519 | // Step 1: Expand the 1st addend into Opnd0_0 and Opnd0_1. |
| 520 | unsigned Opnd0_ExpNum = 0; |
| 521 | unsigned Opnd1_ExpNum = 0; |
| 522 | |
Jim Grosbach | bdbd734 | 2013-04-05 21:20:12 +0000 | [diff] [blame] | 523 | if (!Opnd0.isConstant()) |
Shuxin Yang | 37a1efe | 2012-12-18 23:10:12 +0000 | [diff] [blame] | 524 | Opnd0_ExpNum = Opnd0.drillAddendDownOneStep(Opnd0_0, Opnd0_1); |
| 525 | |
| 526 | // Step 2: Expand the 2nd addend into Opnd1_0 and Opnd1_1. |
| 527 | if (OpndNum == 2 && !Opnd1.isConstant()) |
| 528 | Opnd1_ExpNum = Opnd1.drillAddendDownOneStep(Opnd1_0, Opnd1_1); |
| 529 | |
| 530 | // Step 3: Try to optimize Opnd0_0 + Opnd0_1 + Opnd1_0 + Opnd1_1 |
| 531 | if (Opnd0_ExpNum && Opnd1_ExpNum) { |
| 532 | AddendVect AllOpnds; |
| 533 | AllOpnds.push_back(&Opnd0_0); |
| 534 | AllOpnds.push_back(&Opnd1_0); |
| 535 | if (Opnd0_ExpNum == 2) |
| 536 | AllOpnds.push_back(&Opnd0_1); |
| 537 | if (Opnd1_ExpNum == 2) |
| 538 | AllOpnds.push_back(&Opnd1_1); |
| 539 | |
| 540 | // Compute instruction quota. We should save at least one instruction. |
| 541 | unsigned InstQuota = 0; |
| 542 | |
| 543 | Value *V0 = I->getOperand(0); |
| 544 | Value *V1 = I->getOperand(1); |
Jim Grosbach | bdbd734 | 2013-04-05 21:20:12 +0000 | [diff] [blame] | 545 | InstQuota = ((!isa<Constant>(V0) && V0->hasOneUse()) && |
Shuxin Yang | 37a1efe | 2012-12-18 23:10:12 +0000 | [diff] [blame] | 546 | (!isa<Constant>(V1) && V1->hasOneUse())) ? 2 : 1; |
| 547 | |
| 548 | if (Value *R = simplifyFAdd(AllOpnds, InstQuota)) |
| 549 | return R; |
| 550 | } |
| 551 | |
| 552 | if (OpndNum != 2) { |
| 553 | // The input instruction is : "I=0.0 +/- V". If the "V" were able to be |
| 554 | // splitted into two addends, say "V = X - Y", the instruction would have |
| 555 | // been optimized into "I = Y - X" in the previous steps. |
| 556 | // |
| 557 | const FAddendCoef &CE = Opnd0.getCoef(); |
Craig Topper | f40110f | 2014-04-25 05:29:35 +0000 | [diff] [blame] | 558 | return CE.isOne() ? Opnd0.getSymVal() : nullptr; |
Shuxin Yang | 37a1efe | 2012-12-18 23:10:12 +0000 | [diff] [blame] | 559 | } |
| 560 | |
| 561 | // step 4: Try to optimize Opnd0 + Opnd1_0 [+ Opnd1_1] |
| 562 | if (Opnd1_ExpNum) { |
| 563 | AddendVect AllOpnds; |
| 564 | AllOpnds.push_back(&Opnd0); |
| 565 | AllOpnds.push_back(&Opnd1_0); |
| 566 | if (Opnd1_ExpNum == 2) |
| 567 | AllOpnds.push_back(&Opnd1_1); |
| 568 | |
| 569 | if (Value *R = simplifyFAdd(AllOpnds, 1)) |
| 570 | return R; |
| 571 | } |
| 572 | |
| 573 | // step 5: Try to optimize Opnd1 + Opnd0_0 [+ Opnd0_1] |
| 574 | if (Opnd0_ExpNum) { |
| 575 | AddendVect AllOpnds; |
| 576 | AllOpnds.push_back(&Opnd1); |
| 577 | AllOpnds.push_back(&Opnd0_0); |
| 578 | if (Opnd0_ExpNum == 2) |
| 579 | AllOpnds.push_back(&Opnd0_1); |
| 580 | |
| 581 | if (Value *R = simplifyFAdd(AllOpnds, 1)) |
| 582 | return R; |
| 583 | } |
| 584 | |
Jim Grosbach | bdbd734 | 2013-04-05 21:20:12 +0000 | [diff] [blame] | 585 | // step 6: Try factorization as the last resort, |
Shuxin Yang | 2eca602 | 2013-03-14 18:08:26 +0000 | [diff] [blame] | 586 | return performFactorization(I); |
Shuxin Yang | 37a1efe | 2012-12-18 23:10:12 +0000 | [diff] [blame] | 587 | } |
| 588 | |
| 589 | Value *FAddCombine::simplifyFAdd(AddendVect& Addends, unsigned InstrQuota) { |
Shuxin Yang | 37a1efe | 2012-12-18 23:10:12 +0000 | [diff] [blame] | 590 | unsigned AddendNum = Addends.size(); |
| 591 | assert(AddendNum <= 4 && "Too many addends"); |
| 592 | |
Jim Grosbach | bdbd734 | 2013-04-05 21:20:12 +0000 | [diff] [blame] | 593 | // For saving intermediate results; |
Shuxin Yang | 37a1efe | 2012-12-18 23:10:12 +0000 | [diff] [blame] | 594 | unsigned NextTmpIdx = 0; |
| 595 | FAddend TmpResult[3]; |
| 596 | |
| 597 | // Points to the constant addend of the resulting simplified expression. |
| 598 | // If the resulting expr has constant-addend, this constant-addend is |
| 599 | // desirable to reside at the top of the resulting expression tree. Placing |
| 600 | // constant close to supper-expr(s) will potentially reveal some optimization |
| 601 | // opportunities in super-expr(s). |
| 602 | // |
Craig Topper | f40110f | 2014-04-25 05:29:35 +0000 | [diff] [blame] | 603 | const FAddend *ConstAdd = nullptr; |
Shuxin Yang | 37a1efe | 2012-12-18 23:10:12 +0000 | [diff] [blame] | 604 | |
| 605 | // Simplified addends are placed <SimpVect>. |
| 606 | AddendVect SimpVect; |
| 607 | |
| 608 | // The outer loop works on one symbolic-value at a time. Suppose the input |
Jim Grosbach | bdbd734 | 2013-04-05 21:20:12 +0000 | [diff] [blame] | 609 | // addends are : <a1, x>, <b1, y>, <a2, x>, <c1, z>, <b2, y>, ... |
Shuxin Yang | 37a1efe | 2012-12-18 23:10:12 +0000 | [diff] [blame] | 610 | // The symbolic-values will be processed in this order: x, y, z. |
| 611 | // |
| 612 | for (unsigned SymIdx = 0; SymIdx < AddendNum; SymIdx++) { |
| 613 | |
| 614 | const FAddend *ThisAddend = Addends[SymIdx]; |
| 615 | if (!ThisAddend) { |
| 616 | // This addend was processed before. |
| 617 | continue; |
| 618 | } |
| 619 | |
| 620 | Value *Val = ThisAddend->getSymVal(); |
| 621 | unsigned StartIdx = SimpVect.size(); |
| 622 | SimpVect.push_back(ThisAddend); |
| 623 | |
| 624 | // The inner loop collects addends sharing same symbolic-value, and these |
| 625 | // addends will be later on folded into a single addend. Following above |
| 626 | // example, if the symbolic value "y" is being processed, the inner loop |
| 627 | // will collect two addends "<b1,y>" and "<b2,Y>". These two addends will |
| 628 | // be later on folded into "<b1+b2, y>". |
| 629 | // |
| 630 | for (unsigned SameSymIdx = SymIdx + 1; |
| 631 | SameSymIdx < AddendNum; SameSymIdx++) { |
| 632 | const FAddend *T = Addends[SameSymIdx]; |
| 633 | if (T && T->getSymVal() == Val) { |
| 634 | // Set null such that next iteration of the outer loop will not process |
| 635 | // this addend again. |
Craig Topper | f40110f | 2014-04-25 05:29:35 +0000 | [diff] [blame] | 636 | Addends[SameSymIdx] = nullptr; |
Shuxin Yang | 37a1efe | 2012-12-18 23:10:12 +0000 | [diff] [blame] | 637 | SimpVect.push_back(T); |
| 638 | } |
| 639 | } |
| 640 | |
| 641 | // If multiple addends share same symbolic value, fold them together. |
| 642 | if (StartIdx + 1 != SimpVect.size()) { |
| 643 | FAddend &R = TmpResult[NextTmpIdx ++]; |
| 644 | R = *SimpVect[StartIdx]; |
| 645 | for (unsigned Idx = StartIdx + 1; Idx < SimpVect.size(); Idx++) |
| 646 | R += *SimpVect[Idx]; |
| 647 | |
| 648 | // Pop all addends being folded and push the resulting folded addend. |
Jim Grosbach | bdbd734 | 2013-04-05 21:20:12 +0000 | [diff] [blame] | 649 | SimpVect.resize(StartIdx); |
Craig Topper | f40110f | 2014-04-25 05:29:35 +0000 | [diff] [blame] | 650 | if (Val) { |
Shuxin Yang | 37a1efe | 2012-12-18 23:10:12 +0000 | [diff] [blame] | 651 | if (!R.isZero()) { |
| 652 | SimpVect.push_back(&R); |
| 653 | } |
| 654 | } else { |
| 655 | // Don't push constant addend at this time. It will be the last element |
| 656 | // of <SimpVect>. |
| 657 | ConstAdd = &R; |
| 658 | } |
| 659 | } |
| 660 | } |
| 661 | |
Craig Topper | 5871321 | 2013-07-15 04:27:47 +0000 | [diff] [blame] | 662 | assert((NextTmpIdx <= array_lengthof(TmpResult) + 1) && |
Shuxin Yang | 37a1efe | 2012-12-18 23:10:12 +0000 | [diff] [blame] | 663 | "out-of-bound access"); |
| 664 | |
| 665 | if (ConstAdd) |
| 666 | SimpVect.push_back(ConstAdd); |
| 667 | |
| 668 | Value *Result; |
| 669 | if (!SimpVect.empty()) |
| 670 | Result = createNaryFAdd(SimpVect, InstrQuota); |
| 671 | else { |
| 672 | // The addition is folded to 0.0. |
| 673 | Result = ConstantFP::get(Instr->getType(), 0.0); |
| 674 | } |
| 675 | |
| 676 | return Result; |
| 677 | } |
| 678 | |
| 679 | Value *FAddCombine::createNaryFAdd |
| 680 | (const AddendVect &Opnds, unsigned InstrQuota) { |
| 681 | assert(!Opnds.empty() && "Expect at least one addend"); |
| 682 | |
| 683 | // Step 1: Check if the # of instructions needed exceeds the quota. |
Jim Grosbach | bdbd734 | 2013-04-05 21:20:12 +0000 | [diff] [blame] | 684 | // |
Shuxin Yang | 37a1efe | 2012-12-18 23:10:12 +0000 | [diff] [blame] | 685 | unsigned InstrNeeded = calcInstrNumber(Opnds); |
| 686 | if (InstrNeeded > InstrQuota) |
Craig Topper | f40110f | 2014-04-25 05:29:35 +0000 | [diff] [blame] | 687 | return nullptr; |
Shuxin Yang | 37a1efe | 2012-12-18 23:10:12 +0000 | [diff] [blame] | 688 | |
| 689 | initCreateInstNum(); |
| 690 | |
| 691 | // step 2: Emit the N-ary addition. |
| 692 | // Note that at most three instructions are involved in Fadd-InstCombine: the |
| 693 | // addition in question, and at most two neighboring instructions. |
| 694 | // The resulting optimized addition should have at least one less instruction |
| 695 | // than the original addition expression tree. This implies that the resulting |
| 696 | // N-ary addition has at most two instructions, and we don't need to worry |
| 697 | // about tree-height when constructing the N-ary addition. |
| 698 | |
Craig Topper | f40110f | 2014-04-25 05:29:35 +0000 | [diff] [blame] | 699 | Value *LastVal = nullptr; |
Shuxin Yang | 37a1efe | 2012-12-18 23:10:12 +0000 | [diff] [blame] | 700 | bool LastValNeedNeg = false; |
| 701 | |
| 702 | // Iterate the addends, creating fadd/fsub using adjacent two addends. |
Benjamin Kramer | 135f735 | 2016-06-26 12:28:59 +0000 | [diff] [blame] | 703 | for (const FAddend *Opnd : Opnds) { |
Jim Grosbach | bdbd734 | 2013-04-05 21:20:12 +0000 | [diff] [blame] | 704 | bool NeedNeg; |
Benjamin Kramer | 135f735 | 2016-06-26 12:28:59 +0000 | [diff] [blame] | 705 | Value *V = createAddendVal(*Opnd, NeedNeg); |
Shuxin Yang | 37a1efe | 2012-12-18 23:10:12 +0000 | [diff] [blame] | 706 | if (!LastVal) { |
| 707 | LastVal = V; |
| 708 | LastValNeedNeg = NeedNeg; |
| 709 | continue; |
| 710 | } |
| 711 | |
| 712 | if (LastValNeedNeg == NeedNeg) { |
| 713 | LastVal = createFAdd(LastVal, V); |
| 714 | continue; |
| 715 | } |
| 716 | |
| 717 | if (LastValNeedNeg) |
| 718 | LastVal = createFSub(V, LastVal); |
| 719 | else |
| 720 | LastVal = createFSub(LastVal, V); |
| 721 | |
| 722 | LastValNeedNeg = false; |
| 723 | } |
| 724 | |
| 725 | if (LastValNeedNeg) { |
| 726 | LastVal = createFNeg(LastVal); |
| 727 | } |
| 728 | |
| 729 | #ifndef NDEBUG |
Jim Grosbach | bdbd734 | 2013-04-05 21:20:12 +0000 | [diff] [blame] | 730 | assert(CreateInstrNum == InstrNeeded && |
Shuxin Yang | 37a1efe | 2012-12-18 23:10:12 +0000 | [diff] [blame] | 731 | "Inconsistent in instruction numbers"); |
| 732 | #endif |
| 733 | |
| 734 | return LastVal; |
| 735 | } |
| 736 | |
Sanjay Patel | c242dbb | 2014-12-18 21:11:09 +0000 | [diff] [blame] | 737 | Value *FAddCombine::createFSub(Value *Opnd0, Value *Opnd1) { |
Shuxin Yang | 37a1efe | 2012-12-18 23:10:12 +0000 | [diff] [blame] | 738 | Value *V = Builder->CreateFSub(Opnd0, Opnd1); |
Shuxin Yang | 2eca602 | 2013-03-14 18:08:26 +0000 | [diff] [blame] | 739 | if (Instruction *I = dyn_cast<Instruction>(V)) |
| 740 | createInstPostProc(I); |
Shuxin Yang | 37a1efe | 2012-12-18 23:10:12 +0000 | [diff] [blame] | 741 | return V; |
| 742 | } |
| 743 | |
| 744 | Value *FAddCombine::createFNeg(Value *V) { |
Sanjay Patel | ea3c802 | 2014-12-19 16:44:08 +0000 | [diff] [blame] | 745 | Value *Zero = cast<Value>(ConstantFP::getZeroValueForNegation(V->getType())); |
Owen Anderson | 1664dc8 | 2014-01-20 07:44:53 +0000 | [diff] [blame] | 746 | Value *NewV = createFSub(Zero, V); |
| 747 | if (Instruction *I = dyn_cast<Instruction>(NewV)) |
| 748 | createInstPostProc(I, true); // fneg's don't receive instruction numbers. |
| 749 | return NewV; |
Shuxin Yang | 37a1efe | 2012-12-18 23:10:12 +0000 | [diff] [blame] | 750 | } |
| 751 | |
Sanjay Patel | c242dbb | 2014-12-18 21:11:09 +0000 | [diff] [blame] | 752 | Value *FAddCombine::createFAdd(Value *Opnd0, Value *Opnd1) { |
Shuxin Yang | 37a1efe | 2012-12-18 23:10:12 +0000 | [diff] [blame] | 753 | Value *V = Builder->CreateFAdd(Opnd0, Opnd1); |
Shuxin Yang | 2eca602 | 2013-03-14 18:08:26 +0000 | [diff] [blame] | 754 | if (Instruction *I = dyn_cast<Instruction>(V)) |
| 755 | createInstPostProc(I); |
Shuxin Yang | 37a1efe | 2012-12-18 23:10:12 +0000 | [diff] [blame] | 756 | return V; |
| 757 | } |
| 758 | |
| 759 | Value *FAddCombine::createFMul(Value *Opnd0, Value *Opnd1) { |
| 760 | Value *V = Builder->CreateFMul(Opnd0, Opnd1); |
Shuxin Yang | 2eca602 | 2013-03-14 18:08:26 +0000 | [diff] [blame] | 761 | if (Instruction *I = dyn_cast<Instruction>(V)) |
| 762 | createInstPostProc(I); |
| 763 | return V; |
| 764 | } |
| 765 | |
| 766 | Value *FAddCombine::createFDiv(Value *Opnd0, Value *Opnd1) { |
| 767 | Value *V = Builder->CreateFDiv(Opnd0, Opnd1); |
| 768 | if (Instruction *I = dyn_cast<Instruction>(V)) |
| 769 | createInstPostProc(I); |
Shuxin Yang | 37a1efe | 2012-12-18 23:10:12 +0000 | [diff] [blame] | 770 | return V; |
| 771 | } |
| 772 | |
Sanjay Patel | c242dbb | 2014-12-18 21:11:09 +0000 | [diff] [blame] | 773 | void FAddCombine::createInstPostProc(Instruction *NewInstr, bool NoNumber) { |
Shuxin Yang | 37a1efe | 2012-12-18 23:10:12 +0000 | [diff] [blame] | 774 | NewInstr->setDebugLoc(Instr->getDebugLoc()); |
| 775 | |
| 776 | // Keep track of the number of instruction created. |
Owen Anderson | 1664dc8 | 2014-01-20 07:44:53 +0000 | [diff] [blame] | 777 | if (!NoNumber) |
| 778 | incCreateInstNum(); |
Shuxin Yang | 37a1efe | 2012-12-18 23:10:12 +0000 | [diff] [blame] | 779 | |
| 780 | // Propagate fast-math flags |
| 781 | NewInstr->setFastMathFlags(Instr->getFastMathFlags()); |
| 782 | } |
| 783 | |
| 784 | // Return the number of instruction needed to emit the N-ary addition. |
| 785 | // NOTE: Keep this function in sync with createAddendVal(). |
| 786 | unsigned FAddCombine::calcInstrNumber(const AddendVect &Opnds) { |
| 787 | unsigned OpndNum = Opnds.size(); |
| 788 | unsigned InstrNeeded = OpndNum - 1; |
| 789 | |
Jim Grosbach | bdbd734 | 2013-04-05 21:20:12 +0000 | [diff] [blame] | 790 | // The number of addends in the form of "(-1)*x". |
| 791 | unsigned NegOpndNum = 0; |
Shuxin Yang | 37a1efe | 2012-12-18 23:10:12 +0000 | [diff] [blame] | 792 | |
| 793 | // Adjust the number of instructions needed to emit the N-ary add. |
Benjamin Kramer | 135f735 | 2016-06-26 12:28:59 +0000 | [diff] [blame] | 794 | for (const FAddend *Opnd : Opnds) { |
Shuxin Yang | 37a1efe | 2012-12-18 23:10:12 +0000 | [diff] [blame] | 795 | if (Opnd->isConstant()) |
| 796 | continue; |
| 797 | |
Matt Arsenault | 02907f3 | 2017-04-24 17:24:37 +0000 | [diff] [blame] | 798 | // The constant check above is really for a few special constant |
| 799 | // coefficients. |
| 800 | if (isa<UndefValue>(Opnd->getSymVal())) |
| 801 | continue; |
| 802 | |
Shuxin Yang | 37a1efe | 2012-12-18 23:10:12 +0000 | [diff] [blame] | 803 | const FAddendCoef &CE = Opnd->getCoef(); |
| 804 | if (CE.isMinusOne() || CE.isMinusTwo()) |
| 805 | NegOpndNum++; |
| 806 | |
| 807 | // Let the addend be "c * x". If "c == +/-1", the value of the addend |
| 808 | // is immediately available; otherwise, it needs exactly one instruction |
| 809 | // to evaluate the value. |
| 810 | if (!CE.isMinusOne() && !CE.isOne()) |
| 811 | InstrNeeded++; |
| 812 | } |
| 813 | if (NegOpndNum == OpndNum) |
| 814 | InstrNeeded++; |
| 815 | return InstrNeeded; |
| 816 | } |
| 817 | |
| 818 | // Input Addend Value NeedNeg(output) |
| 819 | // ================================================================ |
| 820 | // Constant C C false |
| 821 | // <+/-1, V> V coefficient is -1 |
| 822 | // <2/-2, V> "fadd V, V" coefficient is -2 |
| 823 | // <C, V> "fmul V, C" false |
| 824 | // |
| 825 | // NOTE: Keep this function in sync with FAddCombine::calcInstrNumber. |
Sanjay Patel | c242dbb | 2014-12-18 21:11:09 +0000 | [diff] [blame] | 826 | Value *FAddCombine::createAddendVal(const FAddend &Opnd, bool &NeedNeg) { |
Shuxin Yang | 37a1efe | 2012-12-18 23:10:12 +0000 | [diff] [blame] | 827 | const FAddendCoef &Coeff = Opnd.getCoef(); |
| 828 | |
| 829 | if (Opnd.isConstant()) { |
| 830 | NeedNeg = false; |
| 831 | return Coeff.getValue(Instr->getType()); |
| 832 | } |
| 833 | |
| 834 | Value *OpndVal = Opnd.getSymVal(); |
| 835 | |
| 836 | if (Coeff.isMinusOne() || Coeff.isOne()) { |
| 837 | NeedNeg = Coeff.isMinusOne(); |
| 838 | return OpndVal; |
| 839 | } |
| 840 | |
| 841 | if (Coeff.isTwo() || Coeff.isMinusTwo()) { |
| 842 | NeedNeg = Coeff.isMinusTwo(); |
| 843 | return createFAdd(OpndVal, OpndVal); |
| 844 | } |
| 845 | |
| 846 | NeedNeg = false; |
| 847 | return createFMul(OpndVal, Coeff.getValue(Instr->getType())); |
| 848 | } |
| 849 | |
Craig Topper | cff357c | 2017-05-03 23:22:46 +0000 | [diff] [blame] | 850 | /// \brief Return true if we can prove that adding the two values of the |
| 851 | /// knownbits will not overflow. |
| 852 | /// Otherwise return false. |
| 853 | static bool checkRippleForAdd(const KnownBits &LHSKnown, |
| 854 | const KnownBits &RHSKnown) { |
| 855 | // Addition of two 2's complement numbers having opposite signs will never |
| 856 | // overflow. |
| 857 | if ((LHSKnown.isNegative() && RHSKnown.isNonNegative()) || |
| 858 | (LHSKnown.isNonNegative() && RHSKnown.isNegative())) |
| 859 | return true; |
Rafael Espindola | 04c2258 | 2014-06-04 15:39:14 +0000 | [diff] [blame] | 860 | |
Craig Topper | cff357c | 2017-05-03 23:22:46 +0000 | [diff] [blame] | 861 | // If either of the values is known to be non-negative, adding them can only |
| 862 | // overflow if the second is also non-negative, so we can assume that. |
| 863 | // Two non-negative numbers will only overflow if there is a carry to the |
| 864 | // sign bit, so we can check if even when the values are as big as possible |
| 865 | // there is no overflow to the sign bit. |
| 866 | if (LHSKnown.isNonNegative() || RHSKnown.isNonNegative()) { |
| 867 | APInt MaxLHS = ~LHSKnown.Zero; |
| 868 | MaxLHS.clearSignBit(); |
| 869 | APInt MaxRHS = ~RHSKnown.Zero; |
| 870 | MaxRHS.clearSignBit(); |
| 871 | APInt Result = std::move(MaxLHS) + std::move(MaxRHS); |
| 872 | return Result.isSignBitClear(); |
| 873 | } |
Rafael Espindola | 04c2258 | 2014-06-04 15:39:14 +0000 | [diff] [blame] | 874 | |
Craig Topper | cff357c | 2017-05-03 23:22:46 +0000 | [diff] [blame] | 875 | // If either of the values is known to be negative, adding them can only |
| 876 | // overflow if the second is also negative, so we can assume that. |
| 877 | // Two negative number will only overflow if there is no carry to the sign |
| 878 | // bit, so we can check if even when the values are as small as possible |
| 879 | // there is overflow to the sign bit. |
| 880 | if (LHSKnown.isNegative() || RHSKnown.isNegative()) { |
| 881 | APInt MinLHS = LHSKnown.One; |
| 882 | MinLHS.clearSignBit(); |
| 883 | APInt MinRHS = RHSKnown.One; |
| 884 | MinRHS.clearSignBit(); |
| 885 | APInt Result = std::move(MinLHS) + std::move(MinRHS); |
| 886 | return Result.isSignBitSet(); |
| 887 | } |
Rafael Espindola | 04c2258 | 2014-06-04 15:39:14 +0000 | [diff] [blame] | 888 | |
Craig Topper | cff357c | 2017-05-03 23:22:46 +0000 | [diff] [blame] | 889 | // If we reached here it means that we know nothing about the sign bits. |
| 890 | // In this case we can't know if there will be an overflow, since by |
| 891 | // changing the sign bits any two values can be made to overflow. |
| 892 | return false; |
Rafael Espindola | 04c2258 | 2014-06-04 15:39:14 +0000 | [diff] [blame] | 893 | } |
Chris Lattner | 82aa888 | 2010-01-05 07:18:46 +0000 | [diff] [blame] | 894 | |
Sanjay Patel | 6eccf48 | 2015-09-09 15:24:36 +0000 | [diff] [blame] | 895 | /// Return true if we can prove that: |
Chris Lattner | 82aa888 | 2010-01-05 07:18:46 +0000 | [diff] [blame] | 896 | /// (sext (add LHS, RHS)) === (add (sext LHS), (sext RHS)) |
| 897 | /// This basically requires proving that the add in the original type would not |
| 898 | /// overflow to change the sign bit or have a carry out. |
Hal Finkel | 60db058 | 2014-09-07 18:57:58 +0000 | [diff] [blame] | 899 | bool InstCombiner::WillNotOverflowSignedAdd(Value *LHS, Value *RHS, |
Mehdi Amini | a28d91d | 2015-03-10 02:37:25 +0000 | [diff] [blame] | 900 | Instruction &CxtI) { |
Chris Lattner | 82aa888 | 2010-01-05 07:18:46 +0000 | [diff] [blame] | 901 | // There are different heuristics we can use for this. Here are some simple |
| 902 | // ones. |
Michael Ilseman | 9fc0f25 | 2012-12-12 20:57:53 +0000 | [diff] [blame] | 903 | |
Rafael Espindola | d1a2c2d | 2014-06-02 22:01:04 +0000 | [diff] [blame] | 904 | // If LHS and RHS each have at least two sign bits, the addition will look |
| 905 | // like |
| 906 | // |
| 907 | // XX..... + |
| 908 | // YY..... |
| 909 | // |
| 910 | // If the carry into the most significant position is 0, X and Y can't both |
| 911 | // be 1 and therefore the carry out of the addition is also 0. |
| 912 | // |
| 913 | // If the carry into the most significant position is 1, X and Y can't both |
| 914 | // be 0 and therefore the carry out of the addition is also 1. |
| 915 | // |
| 916 | // Since the carry into the most significant position is always equal to |
| 917 | // the carry out of the addition, there is no signed overflow. |
Mehdi Amini | a28d91d | 2015-03-10 02:37:25 +0000 | [diff] [blame] | 918 | if (ComputeNumSignBits(LHS, 0, &CxtI) > 1 && |
| 919 | ComputeNumSignBits(RHS, 0, &CxtI) > 1) |
Chris Lattner | 82aa888 | 2010-01-05 07:18:46 +0000 | [diff] [blame] | 920 | return true; |
Michael Ilseman | 9fc0f25 | 2012-12-12 20:57:53 +0000 | [diff] [blame] | 921 | |
David Majnemer | 54c2ca2 | 2014-12-26 09:10:14 +0000 | [diff] [blame] | 922 | unsigned BitWidth = LHS->getType()->getScalarSizeInBits(); |
Craig Topper | b45eabc | 2017-04-26 16:39:58 +0000 | [diff] [blame] | 923 | KnownBits LHSKnown(BitWidth); |
| 924 | computeKnownBits(LHS, LHSKnown, 0, &CxtI); |
Michael Ilseman | 9fc0f25 | 2012-12-12 20:57:53 +0000 | [diff] [blame] | 925 | |
Craig Topper | b45eabc | 2017-04-26 16:39:58 +0000 | [diff] [blame] | 926 | KnownBits RHSKnown(BitWidth); |
| 927 | computeKnownBits(RHS, RHSKnown, 0, &CxtI); |
Michael Ilseman | 9fc0f25 | 2012-12-12 20:57:53 +0000 | [diff] [blame] | 928 | |
David Majnemer | 54c2ca2 | 2014-12-26 09:10:14 +0000 | [diff] [blame] | 929 | // Check if carry bit of addition will not cause overflow. |
Craig Topper | cff357c | 2017-05-03 23:22:46 +0000 | [diff] [blame] | 930 | if (checkRippleForAdd(LHSKnown, RHSKnown)) |
David Majnemer | 54c2ca2 | 2014-12-26 09:10:14 +0000 | [diff] [blame] | 931 | return true; |
| 932 | |
Chris Lattner | 82aa888 | 2010-01-05 07:18:46 +0000 | [diff] [blame] | 933 | return false; |
| 934 | } |
| 935 | |
David Majnemer | 57d5bc8 | 2014-08-19 23:36:30 +0000 | [diff] [blame] | 936 | /// \brief Return true if we can prove that: |
| 937 | /// (sub LHS, RHS) === (sub nsw LHS, RHS) |
| 938 | /// This basically requires proving that the add in the original type would not |
| 939 | /// overflow to change the sign bit or have a carry out. |
| 940 | /// TODO: Handle this for Vectors. |
Hal Finkel | 60db058 | 2014-09-07 18:57:58 +0000 | [diff] [blame] | 941 | bool InstCombiner::WillNotOverflowSignedSub(Value *LHS, Value *RHS, |
Mehdi Amini | a28d91d | 2015-03-10 02:37:25 +0000 | [diff] [blame] | 942 | Instruction &CxtI) { |
David Majnemer | 57d5bc8 | 2014-08-19 23:36:30 +0000 | [diff] [blame] | 943 | // If LHS and RHS each have at least two sign bits, the subtraction |
| 944 | // cannot overflow. |
Mehdi Amini | a28d91d | 2015-03-10 02:37:25 +0000 | [diff] [blame] | 945 | if (ComputeNumSignBits(LHS, 0, &CxtI) > 1 && |
| 946 | ComputeNumSignBits(RHS, 0, &CxtI) > 1) |
David Majnemer | 57d5bc8 | 2014-08-19 23:36:30 +0000 | [diff] [blame] | 947 | return true; |
| 948 | |
David Majnemer | 54c2ca2 | 2014-12-26 09:10:14 +0000 | [diff] [blame] | 949 | unsigned BitWidth = LHS->getType()->getScalarSizeInBits(); |
Craig Topper | b45eabc | 2017-04-26 16:39:58 +0000 | [diff] [blame] | 950 | KnownBits LHSKnown(BitWidth); |
| 951 | computeKnownBits(LHS, LHSKnown, 0, &CxtI); |
David Majnemer | 57d5bc8 | 2014-08-19 23:36:30 +0000 | [diff] [blame] | 952 | |
Craig Topper | b45eabc | 2017-04-26 16:39:58 +0000 | [diff] [blame] | 953 | KnownBits RHSKnown(BitWidth); |
| 954 | computeKnownBits(RHS, RHSKnown, 0, &CxtI); |
David Majnemer | 57d5bc8 | 2014-08-19 23:36:30 +0000 | [diff] [blame] | 955 | |
Craig Topper | 957a94c | 2017-04-11 18:47:58 +0000 | [diff] [blame] | 956 | // Subtraction of two 2's complement numbers having identical signs will |
David Majnemer | 54c2ca2 | 2014-12-26 09:10:14 +0000 | [diff] [blame] | 957 | // never overflow. |
Craig Topper | b45eabc | 2017-04-26 16:39:58 +0000 | [diff] [blame] | 958 | if ((LHSKnown.One[BitWidth - 1] && RHSKnown.One[BitWidth - 1]) || |
| 959 | (LHSKnown.Zero[BitWidth - 1] && RHSKnown.Zero[BitWidth - 1])) |
David Majnemer | 54c2ca2 | 2014-12-26 09:10:14 +0000 | [diff] [blame] | 960 | return true; |
David Majnemer | 57d5bc8 | 2014-08-19 23:36:30 +0000 | [diff] [blame] | 961 | |
David Majnemer | 54c2ca2 | 2014-12-26 09:10:14 +0000 | [diff] [blame] | 962 | // TODO: implement logic similar to checkRippleForAdd |
David Majnemer | 57d5bc8 | 2014-08-19 23:36:30 +0000 | [diff] [blame] | 963 | return false; |
| 964 | } |
| 965 | |
David Majnemer | 42158f3 | 2014-08-20 07:17:31 +0000 | [diff] [blame] | 966 | /// \brief Return true if we can prove that: |
| 967 | /// (sub LHS, RHS) === (sub nuw LHS, RHS) |
Hal Finkel | 60db058 | 2014-09-07 18:57:58 +0000 | [diff] [blame] | 968 | bool InstCombiner::WillNotOverflowUnsignedSub(Value *LHS, Value *RHS, |
Mehdi Amini | a28d91d | 2015-03-10 02:37:25 +0000 | [diff] [blame] | 969 | Instruction &CxtI) { |
David Majnemer | 42158f3 | 2014-08-20 07:17:31 +0000 | [diff] [blame] | 970 | // If the LHS is negative and the RHS is non-negative, no unsigned wrap. |
| 971 | bool LHSKnownNonNegative, LHSKnownNegative; |
| 972 | bool RHSKnownNonNegative, RHSKnownNegative; |
Mehdi Amini | a28d91d | 2015-03-10 02:37:25 +0000 | [diff] [blame] | 973 | ComputeSignBit(LHS, LHSKnownNonNegative, LHSKnownNegative, /*Depth=*/0, |
| 974 | &CxtI); |
| 975 | ComputeSignBit(RHS, RHSKnownNonNegative, RHSKnownNegative, /*Depth=*/0, |
| 976 | &CxtI); |
David Majnemer | 42158f3 | 2014-08-20 07:17:31 +0000 | [diff] [blame] | 977 | if (LHSKnownNegative && RHSKnownNonNegative) |
| 978 | return true; |
| 979 | |
| 980 | return false; |
| 981 | } |
| 982 | |
Dinesh Dwivedi | 562fd75 | 2014-06-19 10:36:52 +0000 | [diff] [blame] | 983 | // Checks if any operand is negative and we can convert add to sub. |
Dinesh Dwivedi | adc0773 | 2014-06-27 07:47:35 +0000 | [diff] [blame] | 984 | // This function checks for following negative patterns |
| 985 | // ADD(XOR(OR(Z, NOT(C)), C)), 1) == NEG(AND(Z, C)) |
| 986 | // ADD(XOR(AND(Z, C), C), 1) == NEG(OR(Z, ~C)) |
| 987 | // XOR(AND(Z, C), (C + 1)) == NEG(OR(Z, ~C)) if C is even |
Benjamin Kramer | 6cbe670 | 2014-07-07 14:47:51 +0000 | [diff] [blame] | 988 | static Value *checkForNegativeOperand(BinaryOperator &I, |
| 989 | InstCombiner::BuilderTy *Builder) { |
Dinesh Dwivedi | adc0773 | 2014-06-27 07:47:35 +0000 | [diff] [blame] | 990 | Value *LHS = I.getOperand(0), *RHS = I.getOperand(1); |
Dinesh Dwivedi | 562fd75 | 2014-06-19 10:36:52 +0000 | [diff] [blame] | 991 | |
Dinesh Dwivedi | adc0773 | 2014-06-27 07:47:35 +0000 | [diff] [blame] | 992 | // This function creates 2 instructions to replace ADD, we need at least one |
| 993 | // of LHS or RHS to have one use to ensure benefit in transform. |
| 994 | if (!LHS->hasOneUse() && !RHS->hasOneUse()) |
| 995 | return nullptr; |
Dinesh Dwivedi | 562fd75 | 2014-06-19 10:36:52 +0000 | [diff] [blame] | 996 | |
Dinesh Dwivedi | adc0773 | 2014-06-27 07:47:35 +0000 | [diff] [blame] | 997 | Value *X = nullptr, *Y = nullptr, *Z = nullptr; |
| 998 | const APInt *C1 = nullptr, *C2 = nullptr; |
Dinesh Dwivedi | 562fd75 | 2014-06-19 10:36:52 +0000 | [diff] [blame] | 999 | |
Dinesh Dwivedi | adc0773 | 2014-06-27 07:47:35 +0000 | [diff] [blame] | 1000 | // if ONE is on other side, swap |
| 1001 | if (match(RHS, m_Add(m_Value(X), m_One()))) |
| 1002 | std::swap(LHS, RHS); |
Dinesh Dwivedi | 562fd75 | 2014-06-19 10:36:52 +0000 | [diff] [blame] | 1003 | |
Dinesh Dwivedi | adc0773 | 2014-06-27 07:47:35 +0000 | [diff] [blame] | 1004 | if (match(LHS, m_Add(m_Value(X), m_One()))) { |
| 1005 | // if XOR on other side, swap |
| 1006 | if (match(RHS, m_Xor(m_Value(Y), m_APInt(C1)))) |
| 1007 | std::swap(X, RHS); |
Dinesh Dwivedi | 562fd75 | 2014-06-19 10:36:52 +0000 | [diff] [blame] | 1008 | |
Dinesh Dwivedi | adc0773 | 2014-06-27 07:47:35 +0000 | [diff] [blame] | 1009 | if (match(X, m_Xor(m_Value(Y), m_APInt(C1)))) { |
| 1010 | // X = XOR(Y, C1), Y = OR(Z, C2), C2 = NOT(C1) ==> X == NOT(AND(Z, C1)) |
| 1011 | // ADD(ADD(X, 1), RHS) == ADD(X, ADD(RHS, 1)) == SUB(RHS, AND(Z, C1)) |
| 1012 | if (match(Y, m_Or(m_Value(Z), m_APInt(C2))) && (*C2 == ~(*C1))) { |
| 1013 | Value *NewAnd = Builder->CreateAnd(Z, *C1); |
| 1014 | return Builder->CreateSub(RHS, NewAnd, "sub"); |
| 1015 | } else if (match(Y, m_And(m_Value(Z), m_APInt(C2))) && (*C1 == *C2)) { |
| 1016 | // X = XOR(Y, C1), Y = AND(Z, C2), C2 == C1 ==> X == NOT(OR(Z, ~C1)) |
| 1017 | // ADD(ADD(X, 1), RHS) == ADD(X, ADD(RHS, 1)) == SUB(RHS, OR(Z, ~C1)) |
| 1018 | Value *NewOr = Builder->CreateOr(Z, ~(*C1)); |
| 1019 | return Builder->CreateSub(RHS, NewOr, "sub"); |
| 1020 | } |
| 1021 | } |
| 1022 | } |
Dinesh Dwivedi | 562fd75 | 2014-06-19 10:36:52 +0000 | [diff] [blame] | 1023 | |
Dinesh Dwivedi | adc0773 | 2014-06-27 07:47:35 +0000 | [diff] [blame] | 1024 | // Restore LHS and RHS |
| 1025 | LHS = I.getOperand(0); |
| 1026 | RHS = I.getOperand(1); |
Dinesh Dwivedi | 562fd75 | 2014-06-19 10:36:52 +0000 | [diff] [blame] | 1027 | |
Dinesh Dwivedi | adc0773 | 2014-06-27 07:47:35 +0000 | [diff] [blame] | 1028 | // if XOR is on other side, swap |
| 1029 | if (match(RHS, m_Xor(m_Value(Y), m_APInt(C1)))) |
| 1030 | std::swap(LHS, RHS); |
| 1031 | |
| 1032 | // C2 is ODD |
| 1033 | // LHS = XOR(Y, C1), Y = AND(Z, C2), C1 == (C2 + 1) => LHS == NEG(OR(Z, ~C2)) |
| 1034 | // ADD(LHS, RHS) == SUB(RHS, OR(Z, ~C2)) |
| 1035 | if (match(LHS, m_Xor(m_Value(Y), m_APInt(C1)))) |
| 1036 | if (C1->countTrailingZeros() == 0) |
| 1037 | if (match(Y, m_And(m_Value(Z), m_APInt(C2))) && *C1 == (*C2 + 1)) { |
| 1038 | Value *NewOr = Builder->CreateOr(Z, ~(*C2)); |
| 1039 | return Builder->CreateSub(RHS, NewOr, "sub"); |
| 1040 | } |
| 1041 | return nullptr; |
| 1042 | } |
| 1043 | |
Sanjay Patel | 4133d4a | 2017-05-10 00:07:16 +0000 | [diff] [blame^] | 1044 | static Instruction *foldAddWithConstant(BinaryOperator &Add, |
| 1045 | InstCombiner::BuilderTy &Builder) { |
| 1046 | Value *Op0 = Add.getOperand(0), *Op1 = Add.getOperand(1); |
| 1047 | const APInt *C; |
| 1048 | if (!match(Op1, m_APInt(C))) |
| 1049 | return nullptr; |
| 1050 | |
| 1051 | if (C->isSignMask()) { |
| 1052 | // If wrapping is not allowed, then the addition must set the sign bit: |
| 1053 | // X + (signmask) --> X | signmask |
| 1054 | if (Add.hasNoSignedWrap() || Add.hasNoUnsignedWrap()) |
| 1055 | return BinaryOperator::CreateOr(Op0, Op1); |
| 1056 | |
| 1057 | // If wrapping is allowed, then the addition flips the sign bit of LHS: |
| 1058 | // X + (signmask) --> X ^ signmask |
| 1059 | return BinaryOperator::CreateXor(Op0, Op1); |
| 1060 | } |
| 1061 | |
| 1062 | Value *X; |
| 1063 | const APInt *C2; |
| 1064 | Type *Ty = Add.getType(); |
| 1065 | |
| 1066 | // Is this add the last step in a convoluted sext? |
| 1067 | // add(zext(xor i16 X, -32768), -32768) --> sext X |
| 1068 | if (match(Op0, m_ZExt(m_Xor(m_Value(X), m_APInt(C2)))) && |
| 1069 | C2->isMinSignedValue() && C2->sext(Ty->getScalarSizeInBits()) == *C) |
| 1070 | return CastInst::Create(Instruction::SExt, X, Ty); |
| 1071 | |
| 1072 | // (add (zext (add nuw X, C2)), C) --> (zext (add nuw X, C2 + C)) |
| 1073 | // FIXME: This should check hasOneUse to not increase the instruction count? |
| 1074 | if (C->isNegative() && |
| 1075 | match(Op0, m_ZExt(m_NUWAdd(m_Value(X), m_APInt(C2)))) && |
| 1076 | C->sge(-C2->sext(C->getBitWidth()))) { |
| 1077 | Constant *NewC = |
| 1078 | ConstantInt::get(X->getType(), *C2 + C->trunc(C2->getBitWidth())); |
| 1079 | return new ZExtInst(Builder.CreateNUWAdd(X, NewC), Ty); |
| 1080 | } |
| 1081 | |
| 1082 | return nullptr; |
| 1083 | } |
| 1084 | |
Dinesh Dwivedi | adc0773 | 2014-06-27 07:47:35 +0000 | [diff] [blame] | 1085 | Instruction *InstCombiner::visitAdd(BinaryOperator &I) { |
Mehdi Amini | a28d91d | 2015-03-10 02:37:25 +0000 | [diff] [blame] | 1086 | bool Changed = SimplifyAssociativeOrCommutative(I); |
| 1087 | Value *LHS = I.getOperand(0), *RHS = I.getOperand(1); |
Jingyue Wu | 33bd53d | 2014-06-17 00:42:07 +0000 | [diff] [blame] | 1088 | |
Mehdi Amini | a28d91d | 2015-03-10 02:37:25 +0000 | [diff] [blame] | 1089 | if (Value *V = SimplifyVectorOp(I)) |
Sanjay Patel | 4b19880 | 2016-02-01 22:23:39 +0000 | [diff] [blame] | 1090 | return replaceInstUsesWith(I, V); |
Chris Lattner | 82aa888 | 2010-01-05 07:18:46 +0000 | [diff] [blame] | 1091 | |
Mehdi Amini | a28d91d | 2015-03-10 02:37:25 +0000 | [diff] [blame] | 1092 | if (Value *V = SimplifyAddInst(LHS, RHS, I.hasNoSignedWrap(), |
Daniel Berlin | 2c75c63 | 2017-04-26 20:56:07 +0000 | [diff] [blame] | 1093 | I.hasNoUnsignedWrap(), SQ)) |
Sanjay Patel | 4b19880 | 2016-02-01 22:23:39 +0000 | [diff] [blame] | 1094 | return replaceInstUsesWith(I, V); |
Serge Pavlov | 9ef66a8 | 2014-05-11 08:46:12 +0000 | [diff] [blame] | 1095 | |
Dinesh Dwivedi | a7161735 | 2014-06-26 05:40:22 +0000 | [diff] [blame] | 1096 | // (A*B)+(A*C) -> A*(B+C) etc |
Duncan Sands | fbb9ac3 | 2010-12-22 13:36:08 +0000 | [diff] [blame] | 1097 | if (Value *V = SimplifyUsingDistributiveLaws(I)) |
Sanjay Patel | 4b19880 | 2016-02-01 22:23:39 +0000 | [diff] [blame] | 1098 | return replaceInstUsesWith(I, V); |
Duncan Sands | fbb9ac3 | 2010-12-22 13:36:08 +0000 | [diff] [blame] | 1099 | |
Sanjay Patel | 4133d4a | 2017-05-10 00:07:16 +0000 | [diff] [blame^] | 1100 | if (Instruction *X = foldAddWithConstant(I, *Builder)) |
| 1101 | return X; |
Sanjay Patel | 53c5c3d | 2017-02-18 22:20:09 +0000 | [diff] [blame] | 1102 | |
Sanjay Patel | 4133d4a | 2017-05-10 00:07:16 +0000 | [diff] [blame^] | 1103 | // FIXME: This should be moved into the above helper function to allow these |
| 1104 | // transforms for splat vectors. |
Sanjay Patel | 79acd2a | 2016-07-16 18:29:26 +0000 | [diff] [blame] | 1105 | if (ConstantInt *CI = dyn_cast<ConstantInt>(RHS)) { |
Chris Lattner | 7d0e43f | 2011-02-10 05:14:58 +0000 | [diff] [blame] | 1106 | // zext(bool) + C -> bool ? C + 1 : C |
| 1107 | if (ZExtInst *ZI = dyn_cast<ZExtInst>(LHS)) |
| 1108 | if (ZI->getSrcTy()->isIntegerTy(1)) |
| 1109 | return SelectInst::Create(ZI->getOperand(0), AddOne(CI), CI); |
Michael Ilseman | 9fc0f25 | 2012-12-12 20:57:53 +0000 | [diff] [blame] | 1110 | |
Craig Topper | f40110f | 2014-04-25 05:29:35 +0000 | [diff] [blame] | 1111 | Value *XorLHS = nullptr; ConstantInt *XorRHS = nullptr; |
Chris Lattner | 7d0e43f | 2011-02-10 05:14:58 +0000 | [diff] [blame] | 1112 | if (match(LHS, m_Xor(m_Value(XorLHS), m_ConstantInt(XorRHS)))) { |
Chris Lattner | 82aa888 | 2010-01-05 07:18:46 +0000 | [diff] [blame] | 1113 | uint32_t TySizeBits = I.getType()->getScalarSizeInBits(); |
Chris Lattner | 7d0e43f | 2011-02-10 05:14:58 +0000 | [diff] [blame] | 1114 | const APInt &RHSVal = CI->getValue(); |
Eli Friedman | a2cc287 | 2010-01-31 04:29:12 +0000 | [diff] [blame] | 1115 | unsigned ExtendAmt = 0; |
| 1116 | // If we have ADD(XOR(AND(X, 0xFF), 0x80), 0xF..F80), it's a sext. |
| 1117 | // If we have ADD(XOR(AND(X, 0xFF), 0xF..F80), 0x80), it's a sext. |
| 1118 | if (XorRHS->getValue() == -RHSVal) { |
| 1119 | if (RHSVal.isPowerOf2()) |
| 1120 | ExtendAmt = TySizeBits - RHSVal.logBase2() - 1; |
| 1121 | else if (XorRHS->getValue().isPowerOf2()) |
| 1122 | ExtendAmt = TySizeBits - XorRHS->getValue().logBase2() - 1; |
Chris Lattner | 82aa888 | 2010-01-05 07:18:46 +0000 | [diff] [blame] | 1123 | } |
Michael Ilseman | 9fc0f25 | 2012-12-12 20:57:53 +0000 | [diff] [blame] | 1124 | |
Eli Friedman | a2cc287 | 2010-01-31 04:29:12 +0000 | [diff] [blame] | 1125 | if (ExtendAmt) { |
| 1126 | APInt Mask = APInt::getHighBitsSet(TySizeBits, ExtendAmt); |
Hal Finkel | 60db058 | 2014-09-07 18:57:58 +0000 | [diff] [blame] | 1127 | if (!MaskedValueIsZero(XorLHS, Mask, 0, &I)) |
Eli Friedman | a2cc287 | 2010-01-31 04:29:12 +0000 | [diff] [blame] | 1128 | ExtendAmt = 0; |
| 1129 | } |
Michael Ilseman | 9fc0f25 | 2012-12-12 20:57:53 +0000 | [diff] [blame] | 1130 | |
Eli Friedman | a2cc287 | 2010-01-31 04:29:12 +0000 | [diff] [blame] | 1131 | if (ExtendAmt) { |
| 1132 | Constant *ShAmt = ConstantInt::get(I.getType(), ExtendAmt); |
| 1133 | Value *NewShl = Builder->CreateShl(XorLHS, ShAmt, "sext"); |
| 1134 | return BinaryOperator::CreateAShr(NewShl, ShAmt); |
Chris Lattner | 82aa888 | 2010-01-05 07:18:46 +0000 | [diff] [blame] | 1135 | } |
Benjamin Kramer | b16bd77 | 2011-12-24 17:31:53 +0000 | [diff] [blame] | 1136 | |
| 1137 | // If this is a xor that was canonicalized from a sub, turn it back into |
| 1138 | // a sub and fuse this add with it. |
| 1139 | if (LHS->hasOneUse() && (XorRHS->getValue()+1).isPowerOf2()) { |
| 1140 | IntegerType *IT = cast<IntegerType>(I.getType()); |
Craig Topper | b45eabc | 2017-04-26 16:39:58 +0000 | [diff] [blame] | 1141 | KnownBits LHSKnown(IT->getBitWidth()); |
| 1142 | computeKnownBits(XorLHS, LHSKnown, 0, &I); |
| 1143 | if ((XorRHS->getValue() | LHSKnown.Zero).isAllOnesValue()) |
Benjamin Kramer | b16bd77 | 2011-12-24 17:31:53 +0000 | [diff] [blame] | 1144 | return BinaryOperator::CreateSub(ConstantExpr::getAdd(XorRHS, CI), |
| 1145 | XorLHS); |
| 1146 | } |
Craig Topper | bcfd2d1 | 2017-04-20 16:56:25 +0000 | [diff] [blame] | 1147 | // (X + signmask) + C could have gotten canonicalized to (X^signmask) + C, |
| 1148 | // transform them into (X + (signmask ^ C)) |
| 1149 | if (XorRHS->getValue().isSignMask()) |
Craig Topper | eafbd57 | 2015-12-21 01:02:28 +0000 | [diff] [blame] | 1150 | return BinaryOperator::CreateAdd(XorLHS, |
| 1151 | ConstantExpr::getXor(XorRHS, CI)); |
Chris Lattner | 82aa888 | 2010-01-05 07:18:46 +0000 | [diff] [blame] | 1152 | } |
| 1153 | } |
| 1154 | |
Craig Topper | 3eec73e | 2017-04-10 16:40:00 +0000 | [diff] [blame] | 1155 | if (isa<Constant>(RHS)) |
| 1156 | if (Instruction *NV = foldOpWithConstantIntoOperand(I)) |
Chris Lattner | 7d0e43f | 2011-02-10 05:14:58 +0000 | [diff] [blame] | 1157 | return NV; |
| 1158 | |
Benjamin Kramer | 72196f3 | 2014-01-19 15:24:22 +0000 | [diff] [blame] | 1159 | if (I.getType()->getScalarType()->isIntegerTy(1)) |
Chris Lattner | 82aa888 | 2010-01-05 07:18:46 +0000 | [diff] [blame] | 1160 | return BinaryOperator::CreateXor(LHS, RHS); |
| 1161 | |
Chris Lattner | 7d0e43f | 2011-02-10 05:14:58 +0000 | [diff] [blame] | 1162 | // X + X --> X << 1 |
Chris Lattner | d406764 | 2011-02-17 20:55:29 +0000 | [diff] [blame] | 1163 | if (LHS == RHS) { |
Chris Lattner | 5592071 | 2011-02-17 02:23:02 +0000 | [diff] [blame] | 1164 | BinaryOperator *New = |
| 1165 | BinaryOperator::CreateShl(LHS, ConstantInt::get(I.getType(), 1)); |
| 1166 | New->setHasNoSignedWrap(I.hasNoSignedWrap()); |
| 1167 | New->setHasNoUnsignedWrap(I.hasNoUnsignedWrap()); |
| 1168 | return New; |
| 1169 | } |
Chris Lattner | 82aa888 | 2010-01-05 07:18:46 +0000 | [diff] [blame] | 1170 | |
| 1171 | // -A + B --> B - A |
| 1172 | // -A + -B --> -(A + B) |
| 1173 | if (Value *LHSV = dyn_castNegVal(LHS)) { |
Nuno Lopes | 2710f1b | 2012-06-08 22:30:05 +0000 | [diff] [blame] | 1174 | if (!isa<Constant>(RHS)) |
| 1175 | if (Value *RHSV = dyn_castNegVal(RHS)) { |
| 1176 | Value *NewAdd = Builder->CreateAdd(LHSV, RHSV, "sum"); |
| 1177 | return BinaryOperator::CreateNeg(NewAdd); |
| 1178 | } |
Michael Ilseman | 9fc0f25 | 2012-12-12 20:57:53 +0000 | [diff] [blame] | 1179 | |
Chris Lattner | 82aa888 | 2010-01-05 07:18:46 +0000 | [diff] [blame] | 1180 | return BinaryOperator::CreateSub(RHS, LHSV); |
| 1181 | } |
| 1182 | |
| 1183 | // A + -B --> A - B |
| 1184 | if (!isa<Constant>(RHS)) |
| 1185 | if (Value *V = dyn_castNegVal(RHS)) |
| 1186 | return BinaryOperator::CreateSub(LHS, V); |
| 1187 | |
Dinesh Dwivedi | 562fd75 | 2014-06-19 10:36:52 +0000 | [diff] [blame] | 1188 | if (Value *V = checkForNegativeOperand(I, Builder)) |
Sanjay Patel | 4b19880 | 2016-02-01 22:23:39 +0000 | [diff] [blame] | 1189 | return replaceInstUsesWith(I, V); |
Dinesh Dwivedi | 562fd75 | 2014-06-19 10:36:52 +0000 | [diff] [blame] | 1190 | |
Sylvestre Ledru | 91ce36c | 2012-09-27 10:14:43 +0000 | [diff] [blame] | 1191 | // A+B --> A|B iff A and B have no bits set in common. |
Daniel Jasper | aec2fa3 | 2016-12-19 08:22:17 +0000 | [diff] [blame] | 1192 | if (haveNoCommonBitsSet(LHS, RHS, DL, &AC, &I, &DT)) |
Jingyue Wu | ca32190 | 2015-05-14 23:53:19 +0000 | [diff] [blame] | 1193 | return BinaryOperator::CreateOr(LHS, RHS); |
Chris Lattner | 82aa888 | 2010-01-05 07:18:46 +0000 | [diff] [blame] | 1194 | |
Benjamin Kramer | 72196f3 | 2014-01-19 15:24:22 +0000 | [diff] [blame] | 1195 | if (Constant *CRHS = dyn_cast<Constant>(RHS)) { |
| 1196 | Value *X; |
| 1197 | if (match(LHS, m_Not(m_Value(X)))) // ~X + C --> (C-1) - X |
Chris Lattner | 82aa888 | 2010-01-05 07:18:46 +0000 | [diff] [blame] | 1198 | return BinaryOperator::CreateSub(SubOne(CRHS), X); |
Benjamin Kramer | 72196f3 | 2014-01-19 15:24:22 +0000 | [diff] [blame] | 1199 | } |
Chris Lattner | 82aa888 | 2010-01-05 07:18:46 +0000 | [diff] [blame] | 1200 | |
Sanjay Patel | 79acd2a | 2016-07-16 18:29:26 +0000 | [diff] [blame] | 1201 | // FIXME: We already did a check for ConstantInt RHS above this. |
| 1202 | // FIXME: Is this pattern covered by another fold? No regression tests fail on |
| 1203 | // removal. |
Benjamin Kramer | 72196f3 | 2014-01-19 15:24:22 +0000 | [diff] [blame] | 1204 | if (ConstantInt *CRHS = dyn_cast<ConstantInt>(RHS)) { |
Chris Lattner | 82aa888 | 2010-01-05 07:18:46 +0000 | [diff] [blame] | 1205 | // (X & FF00) + xx00 -> (X+xx00) & FF00 |
Benjamin Kramer | 72196f3 | 2014-01-19 15:24:22 +0000 | [diff] [blame] | 1206 | Value *X; |
| 1207 | ConstantInt *C2; |
Chris Lattner | 82aa888 | 2010-01-05 07:18:46 +0000 | [diff] [blame] | 1208 | if (LHS->hasOneUse() && |
Chris Lattner | 7d0e43f | 2011-02-10 05:14:58 +0000 | [diff] [blame] | 1209 | match(LHS, m_And(m_Value(X), m_ConstantInt(C2))) && |
| 1210 | CRHS->getValue() == (CRHS->getValue() & C2->getValue())) { |
| 1211 | // See if all bits from the first bit set in the Add RHS up are included |
| 1212 | // in the mask. First, get the rightmost bit. |
| 1213 | const APInt &AddRHSV = CRHS->getValue(); |
Michael Ilseman | 9fc0f25 | 2012-12-12 20:57:53 +0000 | [diff] [blame] | 1214 | |
Chris Lattner | 7d0e43f | 2011-02-10 05:14:58 +0000 | [diff] [blame] | 1215 | // Form a mask of all bits from the lowest bit added through the top. |
| 1216 | APInt AddRHSHighBits(~((AddRHSV & -AddRHSV)-1)); |
Chris Lattner | 82aa888 | 2010-01-05 07:18:46 +0000 | [diff] [blame] | 1217 | |
Chris Lattner | 7d0e43f | 2011-02-10 05:14:58 +0000 | [diff] [blame] | 1218 | // See if the and mask includes all of these bits. |
| 1219 | APInt AddRHSHighBitsAnd(AddRHSHighBits & C2->getValue()); |
Chris Lattner | 82aa888 | 2010-01-05 07:18:46 +0000 | [diff] [blame] | 1220 | |
Chris Lattner | 7d0e43f | 2011-02-10 05:14:58 +0000 | [diff] [blame] | 1221 | if (AddRHSHighBits == AddRHSHighBitsAnd) { |
| 1222 | // Okay, the xform is safe. Insert the new add pronto. |
| 1223 | Value *NewAdd = Builder->CreateAdd(X, CRHS, LHS->getName()); |
| 1224 | return BinaryOperator::CreateAnd(NewAdd, C2); |
Chris Lattner | 82aa888 | 2010-01-05 07:18:46 +0000 | [diff] [blame] | 1225 | } |
| 1226 | } |
Chris Lattner | 82aa888 | 2010-01-05 07:18:46 +0000 | [diff] [blame] | 1227 | } |
| 1228 | |
| 1229 | // add (select X 0 (sub n A)) A --> select X A n |
| 1230 | { |
| 1231 | SelectInst *SI = dyn_cast<SelectInst>(LHS); |
| 1232 | Value *A = RHS; |
| 1233 | if (!SI) { |
| 1234 | SI = dyn_cast<SelectInst>(RHS); |
| 1235 | A = LHS; |
| 1236 | } |
| 1237 | if (SI && SI->hasOneUse()) { |
| 1238 | Value *TV = SI->getTrueValue(); |
| 1239 | Value *FV = SI->getFalseValue(); |
| 1240 | Value *N; |
| 1241 | |
| 1242 | // Can we fold the add into the argument of the select? |
| 1243 | // We check both true and false select arguments for a matching subtract. |
Chris Lattner | 7d0e43f | 2011-02-10 05:14:58 +0000 | [diff] [blame] | 1244 | if (match(FV, m_Zero()) && match(TV, m_Sub(m_Value(N), m_Specific(A)))) |
Chris Lattner | 82aa888 | 2010-01-05 07:18:46 +0000 | [diff] [blame] | 1245 | // Fold the add into the true select value. |
| 1246 | return SelectInst::Create(SI->getCondition(), N, A); |
Michael Ilseman | 9fc0f25 | 2012-12-12 20:57:53 +0000 | [diff] [blame] | 1247 | |
Chris Lattner | 7d0e43f | 2011-02-10 05:14:58 +0000 | [diff] [blame] | 1248 | if (match(TV, m_Zero()) && match(FV, m_Sub(m_Value(N), m_Specific(A)))) |
Chris Lattner | 82aa888 | 2010-01-05 07:18:46 +0000 | [diff] [blame] | 1249 | // Fold the add into the false select value. |
| 1250 | return SelectInst::Create(SI->getCondition(), A, N); |
| 1251 | } |
| 1252 | } |
| 1253 | |
| 1254 | // Check for (add (sext x), y), see if we can merge this into an |
| 1255 | // integer add followed by a sext. |
| 1256 | if (SExtInst *LHSConv = dyn_cast<SExtInst>(LHS)) { |
| 1257 | // (add (sext x), cst) --> (sext (add x, cst')) |
| 1258 | if (ConstantInt *RHSC = dyn_cast<ConstantInt>(RHS)) { |
David Majnemer | a1cfd7c | 2016-12-30 00:28:58 +0000 | [diff] [blame] | 1259 | if (LHSConv->hasOneUse()) { |
| 1260 | Constant *CI = |
| 1261 | ConstantExpr::getTrunc(RHSC, LHSConv->getOperand(0)->getType()); |
| 1262 | if (ConstantExpr::getSExt(CI, I.getType()) == RHSC && |
| 1263 | WillNotOverflowSignedAdd(LHSConv->getOperand(0), CI, I)) { |
| 1264 | // Insert the new, smaller add. |
| 1265 | Value *NewAdd = |
| 1266 | Builder->CreateNSWAdd(LHSConv->getOperand(0), CI, "addconv"); |
| 1267 | return new SExtInst(NewAdd, I.getType()); |
| 1268 | } |
Chris Lattner | 82aa888 | 2010-01-05 07:18:46 +0000 | [diff] [blame] | 1269 | } |
| 1270 | } |
Michael Ilseman | 9fc0f25 | 2012-12-12 20:57:53 +0000 | [diff] [blame] | 1271 | |
Chris Lattner | 82aa888 | 2010-01-05 07:18:46 +0000 | [diff] [blame] | 1272 | // (add (sext x), (sext y)) --> (sext (add int x, y)) |
| 1273 | if (SExtInst *RHSConv = dyn_cast<SExtInst>(RHS)) { |
Craig Topper | 79e5bc5 | 2017-03-30 22:28:55 +0000 | [diff] [blame] | 1274 | // Only do this if x/y have the same type, if at least one of them has a |
Chris Lattner | 82aa888 | 2010-01-05 07:18:46 +0000 | [diff] [blame] | 1275 | // single use (so we don't increase the number of sexts), and if the |
| 1276 | // integer add will not overflow. |
Mehdi Amini | a28d91d | 2015-03-10 02:37:25 +0000 | [diff] [blame] | 1277 | if (LHSConv->getOperand(0)->getType() == |
| 1278 | RHSConv->getOperand(0)->getType() && |
Chris Lattner | 82aa888 | 2010-01-05 07:18:46 +0000 | [diff] [blame] | 1279 | (LHSConv->hasOneUse() || RHSConv->hasOneUse()) && |
| 1280 | WillNotOverflowSignedAdd(LHSConv->getOperand(0), |
Mehdi Amini | a28d91d | 2015-03-10 02:37:25 +0000 | [diff] [blame] | 1281 | RHSConv->getOperand(0), I)) { |
Chris Lattner | 82aa888 | 2010-01-05 07:18:46 +0000 | [diff] [blame] | 1282 | // Insert the new integer add. |
Michael Ilseman | 9fc0f25 | 2012-12-12 20:57:53 +0000 | [diff] [blame] | 1283 | Value *NewAdd = Builder->CreateNSWAdd(LHSConv->getOperand(0), |
Chris Lattner | dec6847 | 2010-01-05 20:56:24 +0000 | [diff] [blame] | 1284 | RHSConv->getOperand(0), "addconv"); |
Chris Lattner | 82aa888 | 2010-01-05 07:18:46 +0000 | [diff] [blame] | 1285 | return new SExtInst(NewAdd, I.getType()); |
| 1286 | } |
| 1287 | } |
| 1288 | } |
| 1289 | |
David Majnemer | a1cfd7c | 2016-12-30 00:28:58 +0000 | [diff] [blame] | 1290 | // Check for (add (zext x), y), see if we can merge this into an |
| 1291 | // integer add followed by a zext. |
| 1292 | if (auto *LHSConv = dyn_cast<ZExtInst>(LHS)) { |
| 1293 | // (add (zext x), cst) --> (zext (add x, cst')) |
| 1294 | if (ConstantInt *RHSC = dyn_cast<ConstantInt>(RHS)) { |
| 1295 | if (LHSConv->hasOneUse()) { |
| 1296 | Constant *CI = |
| 1297 | ConstantExpr::getTrunc(RHSC, LHSConv->getOperand(0)->getType()); |
| 1298 | if (ConstantExpr::getZExt(CI, I.getType()) == RHSC && |
David Majnemer | 5ec5f27 | 2016-12-30 03:36:17 +0000 | [diff] [blame] | 1299 | computeOverflowForUnsignedAdd(LHSConv->getOperand(0), CI, &I) == |
| 1300 | OverflowResult::NeverOverflows) { |
David Majnemer | a1cfd7c | 2016-12-30 00:28:58 +0000 | [diff] [blame] | 1301 | // Insert the new, smaller add. |
| 1302 | Value *NewAdd = |
| 1303 | Builder->CreateNUWAdd(LHSConv->getOperand(0), CI, "addconv"); |
| 1304 | return new ZExtInst(NewAdd, I.getType()); |
| 1305 | } |
| 1306 | } |
| 1307 | } |
| 1308 | |
| 1309 | // (add (zext x), (zext y)) --> (zext (add int x, y)) |
| 1310 | if (auto *RHSConv = dyn_cast<ZExtInst>(RHS)) { |
Craig Topper | 79e5bc5 | 2017-03-30 22:28:55 +0000 | [diff] [blame] | 1311 | // Only do this if x/y have the same type, if at least one of them has a |
David Majnemer | a1cfd7c | 2016-12-30 00:28:58 +0000 | [diff] [blame] | 1312 | // single use (so we don't increase the number of zexts), and if the |
| 1313 | // integer add will not overflow. |
| 1314 | if (LHSConv->getOperand(0)->getType() == |
| 1315 | RHSConv->getOperand(0)->getType() && |
| 1316 | (LHSConv->hasOneUse() || RHSConv->hasOneUse()) && |
| 1317 | computeOverflowForUnsignedAdd(LHSConv->getOperand(0), |
| 1318 | RHSConv->getOperand(0), |
| 1319 | &I) == OverflowResult::NeverOverflows) { |
| 1320 | // Insert the new integer add. |
| 1321 | Value *NewAdd = Builder->CreateNUWAdd( |
| 1322 | LHSConv->getOperand(0), RHSConv->getOperand(0), "addconv"); |
| 1323 | return new ZExtInst(NewAdd, I.getType()); |
| 1324 | } |
| 1325 | } |
| 1326 | } |
| 1327 | |
David Majnemer | ab07f00 | 2014-08-11 22:32:02 +0000 | [diff] [blame] | 1328 | // (add (xor A, B) (and A, B)) --> (or A, B) |
Chad Rosier | 7813dce | 2012-04-26 23:29:14 +0000 | [diff] [blame] | 1329 | { |
Craig Topper | f40110f | 2014-04-25 05:29:35 +0000 | [diff] [blame] | 1330 | Value *A = nullptr, *B = nullptr; |
Chad Rosier | 7813dce | 2012-04-26 23:29:14 +0000 | [diff] [blame] | 1331 | if (match(RHS, m_Xor(m_Value(A), m_Value(B))) && |
Craig Topper | 31cc143 | 2017-04-10 07:13:40 +0000 | [diff] [blame] | 1332 | match(LHS, m_c_And(m_Specific(A), m_Specific(B)))) |
Chad Rosier | 7813dce | 2012-04-26 23:29:14 +0000 | [diff] [blame] | 1333 | return BinaryOperator::CreateOr(A, B); |
| 1334 | |
| 1335 | if (match(LHS, m_Xor(m_Value(A), m_Value(B))) && |
Craig Topper | 31cc143 | 2017-04-10 07:13:40 +0000 | [diff] [blame] | 1336 | match(RHS, m_c_And(m_Specific(A), m_Specific(B)))) |
Chad Rosier | 7813dce | 2012-04-26 23:29:14 +0000 | [diff] [blame] | 1337 | return BinaryOperator::CreateOr(A, B); |
| 1338 | } |
| 1339 | |
David Majnemer | ab07f00 | 2014-08-11 22:32:02 +0000 | [diff] [blame] | 1340 | // (add (or A, B) (and A, B)) --> (add A, B) |
| 1341 | { |
| 1342 | Value *A = nullptr, *B = nullptr; |
| 1343 | if (match(RHS, m_Or(m_Value(A), m_Value(B))) && |
Craig Topper | 31cc143 | 2017-04-10 07:13:40 +0000 | [diff] [blame] | 1344 | match(LHS, m_c_And(m_Specific(A), m_Specific(B)))) { |
David Majnemer | ab07f00 | 2014-08-11 22:32:02 +0000 | [diff] [blame] | 1345 | auto *New = BinaryOperator::CreateAdd(A, B); |
| 1346 | New->setHasNoSignedWrap(I.hasNoSignedWrap()); |
| 1347 | New->setHasNoUnsignedWrap(I.hasNoUnsignedWrap()); |
| 1348 | return New; |
| 1349 | } |
| 1350 | |
| 1351 | if (match(LHS, m_Or(m_Value(A), m_Value(B))) && |
Craig Topper | 31cc143 | 2017-04-10 07:13:40 +0000 | [diff] [blame] | 1352 | match(RHS, m_c_And(m_Specific(A), m_Specific(B)))) { |
David Majnemer | ab07f00 | 2014-08-11 22:32:02 +0000 | [diff] [blame] | 1353 | auto *New = BinaryOperator::CreateAdd(A, B); |
| 1354 | New->setHasNoSignedWrap(I.hasNoSignedWrap()); |
| 1355 | New->setHasNoUnsignedWrap(I.hasNoUnsignedWrap()); |
| 1356 | return New; |
| 1357 | } |
| 1358 | } |
| 1359 | |
Jingyue Wu | 33bd53d | 2014-06-17 00:42:07 +0000 | [diff] [blame] | 1360 | // TODO(jingyue): Consider WillNotOverflowSignedAdd and |
| 1361 | // WillNotOverflowUnsignedAdd to reduce the number of invocations of |
| 1362 | // computeKnownBits. |
Mehdi Amini | a28d91d | 2015-03-10 02:37:25 +0000 | [diff] [blame] | 1363 | if (!I.hasNoSignedWrap() && WillNotOverflowSignedAdd(LHS, RHS, I)) { |
Rafael Espindola | d1a2c2d | 2014-06-02 22:01:04 +0000 | [diff] [blame] | 1364 | Changed = true; |
| 1365 | I.setHasNoSignedWrap(true); |
| 1366 | } |
David Majnemer | 5310c1e | 2015-01-07 00:39:50 +0000 | [diff] [blame] | 1367 | if (!I.hasNoUnsignedWrap() && |
| 1368 | computeOverflowForUnsignedAdd(LHS, RHS, &I) == |
| 1369 | OverflowResult::NeverOverflows) { |
Jingyue Wu | 33bd53d | 2014-06-17 00:42:07 +0000 | [diff] [blame] | 1370 | Changed = true; |
| 1371 | I.setHasNoUnsignedWrap(true); |
| 1372 | } |
Rafael Espindola | d1a2c2d | 2014-06-02 22:01:04 +0000 | [diff] [blame] | 1373 | |
Craig Topper | f40110f | 2014-04-25 05:29:35 +0000 | [diff] [blame] | 1374 | return Changed ? &I : nullptr; |
Chris Lattner | 82aa888 | 2010-01-05 07:18:46 +0000 | [diff] [blame] | 1375 | } |
| 1376 | |
| 1377 | Instruction *InstCombiner::visitFAdd(BinaryOperator &I) { |
Duncan Sands | 641baf1 | 2010-11-13 15:10:37 +0000 | [diff] [blame] | 1378 | bool Changed = SimplifyAssociativeOrCommutative(I); |
Chris Lattner | 82aa888 | 2010-01-05 07:18:46 +0000 | [diff] [blame] | 1379 | Value *LHS = I.getOperand(0), *RHS = I.getOperand(1); |
| 1380 | |
Serge Pavlov | 9ef66a8 | 2014-05-11 08:46:12 +0000 | [diff] [blame] | 1381 | if (Value *V = SimplifyVectorOp(I)) |
Sanjay Patel | 4b19880 | 2016-02-01 22:23:39 +0000 | [diff] [blame] | 1382 | return replaceInstUsesWith(I, V); |
Serge Pavlov | 9ef66a8 | 2014-05-11 08:46:12 +0000 | [diff] [blame] | 1383 | |
Daniel Berlin | 2c75c63 | 2017-04-26 20:56:07 +0000 | [diff] [blame] | 1384 | if (Value *V = SimplifyFAddInst(LHS, RHS, I.getFastMathFlags(), SQ)) |
Sanjay Patel | 4b19880 | 2016-02-01 22:23:39 +0000 | [diff] [blame] | 1385 | return replaceInstUsesWith(I, V); |
Chris Lattner | 82aa888 | 2010-01-05 07:18:46 +0000 | [diff] [blame] | 1386 | |
Sanjay Patel | db0938f | 2017-01-10 23:49:07 +0000 | [diff] [blame] | 1387 | if (isa<Constant>(RHS)) |
| 1388 | if (Instruction *FoldedFAdd = foldOpWithConstantIntoOperand(I)) |
| 1389 | return FoldedFAdd; |
Michael Ilseman | e2754dc | 2012-12-14 22:08:26 +0000 | [diff] [blame] | 1390 | |
Chris Lattner | 82aa888 | 2010-01-05 07:18:46 +0000 | [diff] [blame] | 1391 | // -A + B --> B - A |
| 1392 | // -A + -B --> -(A + B) |
Owen Anderson | e732166 | 2014-01-16 21:26:02 +0000 | [diff] [blame] | 1393 | if (Value *LHSV = dyn_castFNegVal(LHS)) { |
| 1394 | Instruction *RI = BinaryOperator::CreateFSub(RHS, LHSV); |
| 1395 | RI->copyFastMathFlags(&I); |
| 1396 | return RI; |
| 1397 | } |
Chris Lattner | 82aa888 | 2010-01-05 07:18:46 +0000 | [diff] [blame] | 1398 | |
| 1399 | // A + -B --> A - B |
| 1400 | if (!isa<Constant>(RHS)) |
Owen Anderson | e732166 | 2014-01-16 21:26:02 +0000 | [diff] [blame] | 1401 | if (Value *V = dyn_castFNegVal(RHS)) { |
| 1402 | Instruction *RI = BinaryOperator::CreateFSub(LHS, V); |
| 1403 | RI->copyFastMathFlags(&I); |
| 1404 | return RI; |
| 1405 | } |
Chris Lattner | 82aa888 | 2010-01-05 07:18:46 +0000 | [diff] [blame] | 1406 | |
Dan Gohman | 6f34abd | 2010-03-02 01:11:08 +0000 | [diff] [blame] | 1407 | // Check for (fadd double (sitofp x), y), see if we can merge this into an |
Chris Lattner | 82aa888 | 2010-01-05 07:18:46 +0000 | [diff] [blame] | 1408 | // integer add followed by a promotion. |
| 1409 | if (SIToFPInst *LHSConv = dyn_cast<SIToFPInst>(LHS)) { |
Artur Pilipenko | 4cc6130 | 2017-03-21 11:32:15 +0000 | [diff] [blame] | 1410 | Value *LHSIntVal = LHSConv->getOperand(0); |
Artur Pilipenko | 134d94f | 2017-04-21 18:45:25 +0000 | [diff] [blame] | 1411 | Type *FPType = LHSConv->getType(); |
| 1412 | |
| 1413 | // TODO: This check is overly conservative. In many cases known bits |
| 1414 | // analysis can tell us that the result of the addition has less significant |
| 1415 | // bits than the integer type can hold. |
| 1416 | auto IsValidPromotion = [](Type *FTy, Type *ITy) { |
Artur Pilipenko | 0632bdc | 2017-04-22 07:24:52 +0000 | [diff] [blame] | 1417 | Type *FScalarTy = FTy->getScalarType(); |
| 1418 | Type *IScalarTy = ITy->getScalarType(); |
| 1419 | |
Artur Pilipenko | 134d94f | 2017-04-21 18:45:25 +0000 | [diff] [blame] | 1420 | // Do we have enough bits in the significand to represent the result of |
| 1421 | // the integer addition? |
| 1422 | unsigned MaxRepresentableBits = |
Artur Pilipenko | 0632bdc | 2017-04-22 07:24:52 +0000 | [diff] [blame] | 1423 | APFloat::semanticsPrecision(FScalarTy->getFltSemantics()); |
| 1424 | return IScalarTy->getIntegerBitWidth() <= MaxRepresentableBits; |
Artur Pilipenko | 134d94f | 2017-04-21 18:45:25 +0000 | [diff] [blame] | 1425 | }; |
Artur Pilipenko | 4cc6130 | 2017-03-21 11:32:15 +0000 | [diff] [blame] | 1426 | |
Dan Gohman | 6f34abd | 2010-03-02 01:11:08 +0000 | [diff] [blame] | 1427 | // (fadd double (sitofp x), fpcst) --> (sitofp (add int x, intcst)) |
Chris Lattner | 82aa888 | 2010-01-05 07:18:46 +0000 | [diff] [blame] | 1428 | // ... if the constant fits in the integer value. This is useful for things |
| 1429 | // like (double)(x & 1234) + 4.0 -> (double)((X & 1234)+4) which no longer |
| 1430 | // requires a constant pool load, and generally allows the add to be better |
| 1431 | // instcombined. |
Artur Pilipenko | 134d94f | 2017-04-21 18:45:25 +0000 | [diff] [blame] | 1432 | if (ConstantFP *CFP = dyn_cast<ConstantFP>(RHS)) |
| 1433 | if (IsValidPromotion(FPType, LHSIntVal->getType())) { |
| 1434 | Constant *CI = |
| 1435 | ConstantExpr::getFPToSI(CFP, LHSIntVal->getType()); |
| 1436 | if (LHSConv->hasOneUse() && |
| 1437 | ConstantExpr::getSIToFP(CI, I.getType()) == CFP && |
| 1438 | WillNotOverflowSignedAdd(LHSIntVal, CI, I)) { |
| 1439 | // Insert the new integer add. |
| 1440 | Value *NewAdd = Builder->CreateNSWAdd(LHSIntVal, |
| 1441 | CI, "addconv"); |
| 1442 | return new SIToFPInst(NewAdd, I.getType()); |
| 1443 | } |
Chris Lattner | 82aa888 | 2010-01-05 07:18:46 +0000 | [diff] [blame] | 1444 | } |
Michael Ilseman | 9fc0f25 | 2012-12-12 20:57:53 +0000 | [diff] [blame] | 1445 | |
Dan Gohman | 6f34abd | 2010-03-02 01:11:08 +0000 | [diff] [blame] | 1446 | // (fadd double (sitofp x), (sitofp y)) --> (sitofp (add int x, y)) |
Chris Lattner | 82aa888 | 2010-01-05 07:18:46 +0000 | [diff] [blame] | 1447 | if (SIToFPInst *RHSConv = dyn_cast<SIToFPInst>(RHS)) { |
Artur Pilipenko | 4cc6130 | 2017-03-21 11:32:15 +0000 | [diff] [blame] | 1448 | Value *RHSIntVal = RHSConv->getOperand(0); |
Artur Pilipenko | 134d94f | 2017-04-21 18:45:25 +0000 | [diff] [blame] | 1449 | // It's enough to check LHS types only because we require int types to |
| 1450 | // be the same for this transform. |
| 1451 | if (IsValidPromotion(FPType, LHSIntVal->getType())) { |
| 1452 | // Only do this if x/y have the same type, if at least one of them has a |
| 1453 | // single use (so we don't increase the number of int->fp conversions), |
| 1454 | // and if the integer add will not overflow. |
| 1455 | if (LHSIntVal->getType() == RHSIntVal->getType() && |
| 1456 | (LHSConv->hasOneUse() || RHSConv->hasOneUse()) && |
| 1457 | WillNotOverflowSignedAdd(LHSIntVal, RHSIntVal, I)) { |
| 1458 | // Insert the new integer add. |
| 1459 | Value *NewAdd = Builder->CreateNSWAdd(LHSIntVal, |
| 1460 | RHSIntVal, "addconv"); |
| 1461 | return new SIToFPInst(NewAdd, I.getType()); |
| 1462 | } |
Chris Lattner | 82aa888 | 2010-01-05 07:18:46 +0000 | [diff] [blame] | 1463 | } |
| 1464 | } |
| 1465 | } |
Michael Ilseman | 9fc0f25 | 2012-12-12 20:57:53 +0000 | [diff] [blame] | 1466 | |
Jean-Luc Duprat | 3e4fc3e | 2013-05-06 16:55:50 +0000 | [diff] [blame] | 1467 | // select C, 0, B + select C, A, 0 -> select C, A, B |
| 1468 | { |
| 1469 | Value *A1, *B1, *C1, *A2, *B2, *C2; |
| 1470 | if (match(LHS, m_Select(m_Value(C1), m_Value(A1), m_Value(B1))) && |
| 1471 | match(RHS, m_Select(m_Value(C2), m_Value(A2), m_Value(B2)))) { |
| 1472 | if (C1 == C2) { |
Craig Topper | f40110f | 2014-04-25 05:29:35 +0000 | [diff] [blame] | 1473 | Constant *Z1=nullptr, *Z2=nullptr; |
Jean-Luc Duprat | 3e4fc3e | 2013-05-06 16:55:50 +0000 | [diff] [blame] | 1474 | Value *A, *B, *C=C1; |
| 1475 | if (match(A1, m_AnyZero()) && match(B2, m_AnyZero())) { |
| 1476 | Z1 = dyn_cast<Constant>(A1); A = A2; |
| 1477 | Z2 = dyn_cast<Constant>(B2); B = B1; |
| 1478 | } else if (match(B1, m_AnyZero()) && match(A2, m_AnyZero())) { |
| 1479 | Z1 = dyn_cast<Constant>(B1); B = B2; |
David Majnemer | 72a643d | 2014-11-03 05:53:55 +0000 | [diff] [blame] | 1480 | Z2 = dyn_cast<Constant>(A2); A = A1; |
Jean-Luc Duprat | 3e4fc3e | 2013-05-06 16:55:50 +0000 | [diff] [blame] | 1481 | } |
David Majnemer | 72a643d | 2014-11-03 05:53:55 +0000 | [diff] [blame] | 1482 | |
| 1483 | if (Z1 && Z2 && |
| 1484 | (I.hasNoSignedZeros() || |
Jean-Luc Duprat | 3e4fc3e | 2013-05-06 16:55:50 +0000 | [diff] [blame] | 1485 | (Z1->isNegativeZeroValue() && Z2->isNegativeZeroValue()))) { |
| 1486 | return SelectInst::Create(C, A, B); |
| 1487 | } |
| 1488 | } |
| 1489 | } |
| 1490 | } |
| 1491 | |
Shuxin Yang | 37a1efe | 2012-12-18 23:10:12 +0000 | [diff] [blame] | 1492 | if (I.hasUnsafeAlgebra()) { |
| 1493 | if (Value *V = FAddCombine(Builder).simplify(&I)) |
Sanjay Patel | 4b19880 | 2016-02-01 22:23:39 +0000 | [diff] [blame] | 1494 | return replaceInstUsesWith(I, V); |
Shuxin Yang | 37a1efe | 2012-12-18 23:10:12 +0000 | [diff] [blame] | 1495 | } |
| 1496 | |
Craig Topper | f40110f | 2014-04-25 05:29:35 +0000 | [diff] [blame] | 1497 | return Changed ? &I : nullptr; |
Chris Lattner | 82aa888 | 2010-01-05 07:18:46 +0000 | [diff] [blame] | 1498 | } |
| 1499 | |
Chris Lattner | 82aa888 | 2010-01-05 07:18:46 +0000 | [diff] [blame] | 1500 | /// Optimize pointer differences into the same array into a size. Consider: |
| 1501 | /// &A[10] - &A[0]: we should compile this to "10". LHS/RHS are the pointer |
| 1502 | /// operands to the ptrtoint instructions for the LHS/RHS of the subtract. |
| 1503 | /// |
| 1504 | Value *InstCombiner::OptimizePointerDifference(Value *LHS, Value *RHS, |
Chris Lattner | 229907c | 2011-07-18 04:54:35 +0000 | [diff] [blame] | 1505 | Type *Ty) { |
Chris Lattner | 82aa888 | 2010-01-05 07:18:46 +0000 | [diff] [blame] | 1506 | // If LHS is a gep based on RHS or RHS is a gep based on LHS, we can optimize |
| 1507 | // this. |
| 1508 | bool Swapped = false; |
Craig Topper | f40110f | 2014-04-25 05:29:35 +0000 | [diff] [blame] | 1509 | GEPOperator *GEP1 = nullptr, *GEP2 = nullptr; |
Benjamin Kramer | 7746eb6 | 2012-02-20 14:34:57 +0000 | [diff] [blame] | 1510 | |
Chris Lattner | 82aa888 | 2010-01-05 07:18:46 +0000 | [diff] [blame] | 1511 | // For now we require one side to be the base pointer "A" or a constant |
Benjamin Kramer | 7746eb6 | 2012-02-20 14:34:57 +0000 | [diff] [blame] | 1512 | // GEP derived from it. |
| 1513 | if (GEPOperator *LHSGEP = dyn_cast<GEPOperator>(LHS)) { |
Chris Lattner | 82aa888 | 2010-01-05 07:18:46 +0000 | [diff] [blame] | 1514 | // (gep X, ...) - X |
| 1515 | if (LHSGEP->getOperand(0) == RHS) { |
Benjamin Kramer | 7746eb6 | 2012-02-20 14:34:57 +0000 | [diff] [blame] | 1516 | GEP1 = LHSGEP; |
Chris Lattner | 82aa888 | 2010-01-05 07:18:46 +0000 | [diff] [blame] | 1517 | Swapped = false; |
Benjamin Kramer | 7746eb6 | 2012-02-20 14:34:57 +0000 | [diff] [blame] | 1518 | } else if (GEPOperator *RHSGEP = dyn_cast<GEPOperator>(RHS)) { |
| 1519 | // (gep X, ...) - (gep X, ...) |
| 1520 | if (LHSGEP->getOperand(0)->stripPointerCasts() == |
| 1521 | RHSGEP->getOperand(0)->stripPointerCasts()) { |
| 1522 | GEP2 = RHSGEP; |
| 1523 | GEP1 = LHSGEP; |
Chris Lattner | 82aa888 | 2010-01-05 07:18:46 +0000 | [diff] [blame] | 1524 | Swapped = false; |
| 1525 | } |
| 1526 | } |
| 1527 | } |
Michael Ilseman | 9fc0f25 | 2012-12-12 20:57:53 +0000 | [diff] [blame] | 1528 | |
Benjamin Kramer | 7746eb6 | 2012-02-20 14:34:57 +0000 | [diff] [blame] | 1529 | if (GEPOperator *RHSGEP = dyn_cast<GEPOperator>(RHS)) { |
Chris Lattner | 82aa888 | 2010-01-05 07:18:46 +0000 | [diff] [blame] | 1530 | // X - (gep X, ...) |
| 1531 | if (RHSGEP->getOperand(0) == LHS) { |
Benjamin Kramer | 7746eb6 | 2012-02-20 14:34:57 +0000 | [diff] [blame] | 1532 | GEP1 = RHSGEP; |
Chris Lattner | 82aa888 | 2010-01-05 07:18:46 +0000 | [diff] [blame] | 1533 | Swapped = true; |
Benjamin Kramer | 7746eb6 | 2012-02-20 14:34:57 +0000 | [diff] [blame] | 1534 | } else if (GEPOperator *LHSGEP = dyn_cast<GEPOperator>(LHS)) { |
| 1535 | // (gep X, ...) - (gep X, ...) |
| 1536 | if (RHSGEP->getOperand(0)->stripPointerCasts() == |
| 1537 | LHSGEP->getOperand(0)->stripPointerCasts()) { |
| 1538 | GEP2 = LHSGEP; |
| 1539 | GEP1 = RHSGEP; |
Chris Lattner | 82aa888 | 2010-01-05 07:18:46 +0000 | [diff] [blame] | 1540 | Swapped = true; |
| 1541 | } |
| 1542 | } |
| 1543 | } |
Michael Ilseman | 9fc0f25 | 2012-12-12 20:57:53 +0000 | [diff] [blame] | 1544 | |
Benjamin Kramer | 7746eb6 | 2012-02-20 14:34:57 +0000 | [diff] [blame] | 1545 | // Avoid duplicating the arithmetic if GEP2 has non-constant indices and |
| 1546 | // multiple users. |
Craig Topper | f40110f | 2014-04-25 05:29:35 +0000 | [diff] [blame] | 1547 | if (!GEP1 || |
| 1548 | (GEP2 && !GEP2->hasAllConstantIndices() && !GEP2->hasOneUse())) |
| 1549 | return nullptr; |
Michael Ilseman | 9fc0f25 | 2012-12-12 20:57:53 +0000 | [diff] [blame] | 1550 | |
Chris Lattner | 82aa888 | 2010-01-05 07:18:46 +0000 | [diff] [blame] | 1551 | // Emit the offset of the GEP and an intptr_t. |
Benjamin Kramer | 7746eb6 | 2012-02-20 14:34:57 +0000 | [diff] [blame] | 1552 | Value *Result = EmitGEPOffset(GEP1); |
Michael Ilseman | 9fc0f25 | 2012-12-12 20:57:53 +0000 | [diff] [blame] | 1553 | |
Chris Lattner | 82aa888 | 2010-01-05 07:18:46 +0000 | [diff] [blame] | 1554 | // If we had a constant expression GEP on the other side offsetting the |
| 1555 | // pointer, subtract it from the offset we have. |
Benjamin Kramer | 7746eb6 | 2012-02-20 14:34:57 +0000 | [diff] [blame] | 1556 | if (GEP2) { |
| 1557 | Value *Offset = EmitGEPOffset(GEP2); |
| 1558 | Result = Builder->CreateSub(Result, Offset); |
Chris Lattner | 82aa888 | 2010-01-05 07:18:46 +0000 | [diff] [blame] | 1559 | } |
Chris Lattner | 82aa888 | 2010-01-05 07:18:46 +0000 | [diff] [blame] | 1560 | |
| 1561 | // If we have p - gep(p, ...) then we have to negate the result. |
| 1562 | if (Swapped) |
| 1563 | Result = Builder->CreateNeg(Result, "diff.neg"); |
| 1564 | |
| 1565 | return Builder->CreateIntCast(Result, Ty, true); |
| 1566 | } |
| 1567 | |
Chris Lattner | 82aa888 | 2010-01-05 07:18:46 +0000 | [diff] [blame] | 1568 | Instruction *InstCombiner::visitSub(BinaryOperator &I) { |
| 1569 | Value *Op0 = I.getOperand(0), *Op1 = I.getOperand(1); |
| 1570 | |
Serge Pavlov | 9ef66a8 | 2014-05-11 08:46:12 +0000 | [diff] [blame] | 1571 | if (Value *V = SimplifyVectorOp(I)) |
Sanjay Patel | 4b19880 | 2016-02-01 22:23:39 +0000 | [diff] [blame] | 1572 | return replaceInstUsesWith(I, V); |
Serge Pavlov | 9ef66a8 | 2014-05-11 08:46:12 +0000 | [diff] [blame] | 1573 | |
Duncan Sands | 0a2c4168 | 2010-12-15 14:07:39 +0000 | [diff] [blame] | 1574 | if (Value *V = SimplifySubInst(Op0, Op1, I.hasNoSignedWrap(), |
Daniel Berlin | 2c75c63 | 2017-04-26 20:56:07 +0000 | [diff] [blame] | 1575 | I.hasNoUnsignedWrap(), SQ)) |
Sanjay Patel | 4b19880 | 2016-02-01 22:23:39 +0000 | [diff] [blame] | 1576 | return replaceInstUsesWith(I, V); |
Chris Lattner | 82aa888 | 2010-01-05 07:18:46 +0000 | [diff] [blame] | 1577 | |
Duncan Sands | fbb9ac3 | 2010-12-22 13:36:08 +0000 | [diff] [blame] | 1578 | // (A*B)-(A*C) -> A*(B-C) etc |
| 1579 | if (Value *V = SimplifyUsingDistributiveLaws(I)) |
Sanjay Patel | 4b19880 | 2016-02-01 22:23:39 +0000 | [diff] [blame] | 1580 | return replaceInstUsesWith(I, V); |
Duncan Sands | fbb9ac3 | 2010-12-22 13:36:08 +0000 | [diff] [blame] | 1581 | |
David Majnemer | a92687d | 2014-07-31 04:49:29 +0000 | [diff] [blame] | 1582 | // If this is a 'B = x-(-A)', change to B = x+A. |
Chris Lattner | 82aa888 | 2010-01-05 07:18:46 +0000 | [diff] [blame] | 1583 | if (Value *V = dyn_castNegVal(Op1)) { |
| 1584 | BinaryOperator *Res = BinaryOperator::CreateAdd(Op0, V); |
David Majnemer | a92687d | 2014-07-31 04:49:29 +0000 | [diff] [blame] | 1585 | |
| 1586 | if (const auto *BO = dyn_cast<BinaryOperator>(Op1)) { |
| 1587 | assert(BO->getOpcode() == Instruction::Sub && |
| 1588 | "Expected a subtraction operator!"); |
| 1589 | if (BO->hasNoSignedWrap() && I.hasNoSignedWrap()) |
| 1590 | Res->setHasNoSignedWrap(true); |
David Majnemer | 0e6c986 | 2014-08-22 16:41:23 +0000 | [diff] [blame] | 1591 | } else { |
| 1592 | if (cast<Constant>(Op1)->isNotMinSignedValue() && I.hasNoSignedWrap()) |
| 1593 | Res->setHasNoSignedWrap(true); |
David Majnemer | a92687d | 2014-07-31 04:49:29 +0000 | [diff] [blame] | 1594 | } |
| 1595 | |
Chris Lattner | 82aa888 | 2010-01-05 07:18:46 +0000 | [diff] [blame] | 1596 | return Res; |
| 1597 | } |
| 1598 | |
Craig Topper | c745b6a | 2017-04-04 21:44:56 +0000 | [diff] [blame] | 1599 | if (I.getType()->getScalarType()->isIntegerTy(1)) |
Chris Lattner | 82aa888 | 2010-01-05 07:18:46 +0000 | [diff] [blame] | 1600 | return BinaryOperator::CreateXor(Op0, Op1); |
Chris Lattner | 7d0e43f | 2011-02-10 05:14:58 +0000 | [diff] [blame] | 1601 | |
| 1602 | // Replace (-1 - A) with (~A). |
| 1603 | if (match(Op0, m_AllOnes())) |
| 1604 | return BinaryOperator::CreateNot(Op1); |
Michael Ilseman | 9fc0f25 | 2012-12-12 20:57:53 +0000 | [diff] [blame] | 1605 | |
Benjamin Kramer | 72196f3 | 2014-01-19 15:24:22 +0000 | [diff] [blame] | 1606 | if (Constant *C = dyn_cast<Constant>(Op0)) { |
Chris Lattner | 82aa888 | 2010-01-05 07:18:46 +0000 | [diff] [blame] | 1607 | // C - ~X == X + (1+C) |
Craig Topper | f40110f | 2014-04-25 05:29:35 +0000 | [diff] [blame] | 1608 | Value *X = nullptr; |
Chris Lattner | 82aa888 | 2010-01-05 07:18:46 +0000 | [diff] [blame] | 1609 | if (match(Op1, m_Not(m_Value(X)))) |
| 1610 | return BinaryOperator::CreateAdd(X, AddOne(C)); |
| 1611 | |
Benjamin Kramer | 72196f3 | 2014-01-19 15:24:22 +0000 | [diff] [blame] | 1612 | // Try to fold constant sub into select arguments. |
| 1613 | if (SelectInst *SI = dyn_cast<SelectInst>(Op1)) |
| 1614 | if (Instruction *R = FoldOpIntoSelect(I, SI)) |
| 1615 | return R; |
| 1616 | |
Craig Topper | fb71b7d | 2017-04-14 19:20:12 +0000 | [diff] [blame] | 1617 | // Try to fold constant sub into PHI values. |
| 1618 | if (PHINode *PN = dyn_cast<PHINode>(Op1)) |
| 1619 | if (Instruction *R = foldOpIntoPhi(I, PN)) |
| 1620 | return R; |
| 1621 | |
Benjamin Kramer | 72196f3 | 2014-01-19 15:24:22 +0000 | [diff] [blame] | 1622 | // C-(X+C2) --> (C-C2)-X |
| 1623 | Constant *C2; |
| 1624 | if (match(Op1, m_Add(m_Value(X), m_Constant(C2)))) |
| 1625 | return BinaryOperator::CreateSub(ConstantExpr::getSub(C, C2), X); |
| 1626 | |
Benjamin Kramer | 72196f3 | 2014-01-19 15:24:22 +0000 | [diff] [blame] | 1627 | // Fold (sub 0, (zext bool to B)) --> (sext bool to B) |
| 1628 | if (C->isNullValue() && match(Op1, m_ZExt(m_Value(X)))) |
| 1629 | if (X->getType()->getScalarType()->isIntegerTy(1)) |
| 1630 | return CastInst::CreateSExtOrBitCast(X, Op1->getType()); |
| 1631 | |
| 1632 | // Fold (sub 0, (sext bool to B)) --> (zext bool to B) |
| 1633 | if (C->isNullValue() && match(Op1, m_SExt(m_Value(X)))) |
| 1634 | if (X->getType()->getScalarType()->isIntegerTy(1)) |
| 1635 | return CastInst::CreateZExtOrBitCast(X, Op1->getType()); |
| 1636 | } |
| 1637 | |
Sanjay Patel | 6d6eca5 | 2016-10-14 16:31:54 +0000 | [diff] [blame] | 1638 | const APInt *Op0C; |
| 1639 | if (match(Op0, m_APInt(Op0C))) { |
| 1640 | unsigned BitWidth = I.getType()->getScalarSizeInBits(); |
| 1641 | |
Chris Lattner | 82aa888 | 2010-01-05 07:18:46 +0000 | [diff] [blame] | 1642 | // -(X >>u 31) -> (X >>s 31) |
| 1643 | // -(X >>s 31) -> (X >>u 31) |
Sanjay Patel | 6d6eca5 | 2016-10-14 16:31:54 +0000 | [diff] [blame] | 1644 | if (*Op0C == 0) { |
David Majnemer | 72a643d | 2014-11-03 05:53:55 +0000 | [diff] [blame] | 1645 | Value *X; |
Sanjay Patel | 6d6eca5 | 2016-10-14 16:31:54 +0000 | [diff] [blame] | 1646 | const APInt *ShAmt; |
| 1647 | if (match(Op1, m_LShr(m_Value(X), m_APInt(ShAmt))) && |
| 1648 | *ShAmt == BitWidth - 1) { |
| 1649 | Value *ShAmtOp = cast<Instruction>(Op1)->getOperand(1); |
| 1650 | return BinaryOperator::CreateAShr(X, ShAmtOp); |
| 1651 | } |
| 1652 | if (match(Op1, m_AShr(m_Value(X), m_APInt(ShAmt))) && |
| 1653 | *ShAmt == BitWidth - 1) { |
| 1654 | Value *ShAmtOp = cast<Instruction>(Op1)->getOperand(1); |
| 1655 | return BinaryOperator::CreateLShr(X, ShAmtOp); |
| 1656 | } |
Chris Lattner | 82aa888 | 2010-01-05 07:18:46 +0000 | [diff] [blame] | 1657 | } |
Matthias Braun | ec68334 | 2015-04-30 22:04:26 +0000 | [diff] [blame] | 1658 | |
| 1659 | // Turn this into a xor if LHS is 2^n-1 and the remaining bits are known |
| 1660 | // zero. |
Craig Topper | b4da684 | 2017-04-06 21:06:03 +0000 | [diff] [blame] | 1661 | if (Op0C->isMask()) { |
Craig Topper | b45eabc | 2017-04-26 16:39:58 +0000 | [diff] [blame] | 1662 | KnownBits RHSKnown(BitWidth); |
| 1663 | computeKnownBits(Op1, RHSKnown, 0, &I); |
| 1664 | if ((*Op0C | RHSKnown.Zero).isAllOnesValue()) |
Sanjay Patel | 6d6eca5 | 2016-10-14 16:31:54 +0000 | [diff] [blame] | 1665 | return BinaryOperator::CreateXor(Op1, Op0); |
Matthias Braun | ec68334 | 2015-04-30 22:04:26 +0000 | [diff] [blame] | 1666 | } |
Chris Lattner | 82aa888 | 2010-01-05 07:18:46 +0000 | [diff] [blame] | 1667 | } |
| 1668 | |
David Majnemer | 72a643d | 2014-11-03 05:53:55 +0000 | [diff] [blame] | 1669 | { |
Suyog Sarda | cba4b1d | 2014-10-08 08:37:49 +0000 | [diff] [blame] | 1670 | Value *Y; |
Chris Lattner | 7d0e43f | 2011-02-10 05:14:58 +0000 | [diff] [blame] | 1671 | // X-(X+Y) == -Y X-(Y+X) == -Y |
Craig Topper | 98851ad | 2017-04-10 16:59:40 +0000 | [diff] [blame] | 1672 | if (match(Op1, m_c_Add(m_Specific(Op0), m_Value(Y)))) |
Chris Lattner | 7d0e43f | 2011-02-10 05:14:58 +0000 | [diff] [blame] | 1673 | return BinaryOperator::CreateNeg(Y); |
Michael Ilseman | 9fc0f25 | 2012-12-12 20:57:53 +0000 | [diff] [blame] | 1674 | |
Chris Lattner | 7d0e43f | 2011-02-10 05:14:58 +0000 | [diff] [blame] | 1675 | // (X-Y)-X == -Y |
| 1676 | if (match(Op0, m_Sub(m_Specific(Op1), m_Value(Y)))) |
| 1677 | return BinaryOperator::CreateNeg(Y); |
| 1678 | } |
Michael Ilseman | 9fc0f25 | 2012-12-12 20:57:53 +0000 | [diff] [blame] | 1679 | |
David Majnemer | 312c3e5 | 2014-10-19 08:32:32 +0000 | [diff] [blame] | 1680 | // (sub (or A, B) (xor A, B)) --> (and A, B) |
| 1681 | { |
Craig Topper | 0d830ff | 2017-04-10 18:09:25 +0000 | [diff] [blame] | 1682 | Value *A, *B; |
David Majnemer | 312c3e5 | 2014-10-19 08:32:32 +0000 | [diff] [blame] | 1683 | if (match(Op1, m_Xor(m_Value(A), m_Value(B))) && |
Craig Topper | 0d830ff | 2017-04-10 18:09:25 +0000 | [diff] [blame] | 1684 | match(Op0, m_c_Or(m_Specific(A), m_Specific(B)))) |
David Majnemer | 312c3e5 | 2014-10-19 08:32:32 +0000 | [diff] [blame] | 1685 | return BinaryOperator::CreateAnd(A, B); |
| 1686 | } |
| 1687 | |
Craig Topper | 0d830ff | 2017-04-10 18:09:25 +0000 | [diff] [blame] | 1688 | { |
| 1689 | Value *Y; |
David Majnemer | 72a643d | 2014-11-03 05:53:55 +0000 | [diff] [blame] | 1690 | // ((X | Y) - X) --> (~X & Y) |
Craig Topper | 0d830ff | 2017-04-10 18:09:25 +0000 | [diff] [blame] | 1691 | if (match(Op0, m_OneUse(m_c_Or(m_Value(Y), m_Specific(Op1))))) |
David Majnemer | 72a643d | 2014-11-03 05:53:55 +0000 | [diff] [blame] | 1692 | return BinaryOperator::CreateAnd( |
| 1693 | Y, Builder->CreateNot(Op1, Op1->getName() + ".not")); |
| 1694 | } |
| 1695 | |
Chris Lattner | 7d0e43f | 2011-02-10 05:14:58 +0000 | [diff] [blame] | 1696 | if (Op1->hasOneUse()) { |
Craig Topper | f40110f | 2014-04-25 05:29:35 +0000 | [diff] [blame] | 1697 | Value *X = nullptr, *Y = nullptr, *Z = nullptr; |
| 1698 | Constant *C = nullptr; |
Chris Lattner | 7d0e43f | 2011-02-10 05:14:58 +0000 | [diff] [blame] | 1699 | |
| 1700 | // (X - (Y - Z)) --> (X + (Z - Y)). |
| 1701 | if (match(Op1, m_Sub(m_Value(Y), m_Value(Z)))) |
| 1702 | return BinaryOperator::CreateAdd(Op0, |
| 1703 | Builder->CreateSub(Z, Y, Op1->getName())); |
| 1704 | |
| 1705 | // (X - (X & Y)) --> (X & ~Y) |
| 1706 | // |
Craig Topper | 0d830ff | 2017-04-10 18:09:25 +0000 | [diff] [blame] | 1707 | if (match(Op1, m_c_And(m_Value(Y), m_Specific(Op0)))) |
Chris Lattner | 7d0e43f | 2011-02-10 05:14:58 +0000 | [diff] [blame] | 1708 | return BinaryOperator::CreateAnd(Op0, |
| 1709 | Builder->CreateNot(Y, Y->getName() + ".not")); |
Michael Ilseman | 9fc0f25 | 2012-12-12 20:57:53 +0000 | [diff] [blame] | 1710 | |
David Majnemer | bdeef60 | 2014-07-02 06:07:09 +0000 | [diff] [blame] | 1711 | // 0 - (X sdiv C) -> (X sdiv -C) provided the negation doesn't overflow. |
| 1712 | if (match(Op1, m_SDiv(m_Value(X), m_Constant(C))) && match(Op0, m_Zero()) && |
David Majnemer | 0e6c986 | 2014-08-22 16:41:23 +0000 | [diff] [blame] | 1713 | C->isNotMinSignedValue() && !C->isOneValue()) |
Chris Lattner | 7d0e43f | 2011-02-10 05:14:58 +0000 | [diff] [blame] | 1714 | return BinaryOperator::CreateSDiv(X, ConstantExpr::getNeg(C)); |
| 1715 | |
| 1716 | // 0 - (X << Y) -> (-X << Y) when X is freely negatable. |
| 1717 | if (match(Op1, m_Shl(m_Value(X), m_Value(Y))) && match(Op0, m_Zero())) |
| 1718 | if (Value *XNeg = dyn_castNegVal(X)) |
| 1719 | return BinaryOperator::CreateShl(XNeg, Y); |
| 1720 | |
Sanjay Patel | c6c5965 | 2016-10-14 15:24:31 +0000 | [diff] [blame] | 1721 | // Subtracting -1/0 is the same as adding 1/0: |
| 1722 | // sub [nsw] Op0, sext(bool Y) -> add [nsw] Op0, zext(bool Y) |
| 1723 | // 'nuw' is dropped in favor of the canonical form. |
| 1724 | if (match(Op1, m_SExt(m_Value(Y))) && |
| 1725 | Y->getType()->getScalarSizeInBits() == 1) { |
| 1726 | Value *Zext = Builder->CreateZExt(Y, I.getType()); |
| 1727 | BinaryOperator *Add = BinaryOperator::CreateAdd(Op0, Zext); |
| 1728 | Add->setHasNoSignedWrap(I.hasNoSignedWrap()); |
| 1729 | return Add; |
| 1730 | } |
| 1731 | |
Chris Lattner | 7d0e43f | 2011-02-10 05:14:58 +0000 | [diff] [blame] | 1732 | // X - A*-B -> X + A*B |
| 1733 | // X - -A*B -> X + A*B |
| 1734 | Value *A, *B; |
Craig Topper | 0d830ff | 2017-04-10 18:09:25 +0000 | [diff] [blame] | 1735 | Constant *CI; |
| 1736 | if (match(Op1, m_c_Mul(m_Value(A), m_Neg(m_Value(B))))) |
Chris Lattner | 7d0e43f | 2011-02-10 05:14:58 +0000 | [diff] [blame] | 1737 | return BinaryOperator::CreateAdd(Op0, Builder->CreateMul(A, B)); |
Michael Ilseman | 9fc0f25 | 2012-12-12 20:57:53 +0000 | [diff] [blame] | 1738 | |
Chris Lattner | 7d0e43f | 2011-02-10 05:14:58 +0000 | [diff] [blame] | 1739 | // X - A*CI -> X + A*-CI |
Craig Topper | 0d830ff | 2017-04-10 18:09:25 +0000 | [diff] [blame] | 1740 | // No need to handle commuted multiply because multiply handling will |
| 1741 | // ensure constant will be move to the right hand side. |
| 1742 | if (match(Op1, m_Mul(m_Value(A), m_Constant(CI)))) { |
Chris Lattner | 7d0e43f | 2011-02-10 05:14:58 +0000 | [diff] [blame] | 1743 | Value *NewMul = Builder->CreateMul(A, ConstantExpr::getNeg(CI)); |
| 1744 | return BinaryOperator::CreateAdd(Op0, NewMul); |
Chris Lattner | 82aa888 | 2010-01-05 07:18:46 +0000 | [diff] [blame] | 1745 | } |
| 1746 | } |
| 1747 | |
Chris Lattner | 82aa888 | 2010-01-05 07:18:46 +0000 | [diff] [blame] | 1748 | // Optimize pointer differences into the same array into a size. Consider: |
| 1749 | // &A[10] - &A[0]: we should compile this to "10". |
Mehdi Amini | a28d91d | 2015-03-10 02:37:25 +0000 | [diff] [blame] | 1750 | Value *LHSOp, *RHSOp; |
| 1751 | if (match(Op0, m_PtrToInt(m_Value(LHSOp))) && |
| 1752 | match(Op1, m_PtrToInt(m_Value(RHSOp)))) |
| 1753 | if (Value *Res = OptimizePointerDifference(LHSOp, RHSOp, I.getType())) |
Sanjay Patel | 4b19880 | 2016-02-01 22:23:39 +0000 | [diff] [blame] | 1754 | return replaceInstUsesWith(I, Res); |
Michael Ilseman | 9fc0f25 | 2012-12-12 20:57:53 +0000 | [diff] [blame] | 1755 | |
Mehdi Amini | a28d91d | 2015-03-10 02:37:25 +0000 | [diff] [blame] | 1756 | // trunc(p)-trunc(q) -> trunc(p-q) |
| 1757 | if (match(Op0, m_Trunc(m_PtrToInt(m_Value(LHSOp)))) && |
| 1758 | match(Op1, m_Trunc(m_PtrToInt(m_Value(RHSOp))))) |
| 1759 | if (Value *Res = OptimizePointerDifference(LHSOp, RHSOp, I.getType())) |
Sanjay Patel | 4b19880 | 2016-02-01 22:23:39 +0000 | [diff] [blame] | 1760 | return replaceInstUsesWith(I, Res); |
Michael Ilseman | 9fc0f25 | 2012-12-12 20:57:53 +0000 | [diff] [blame] | 1761 | |
David Majnemer | 57d5bc8 | 2014-08-19 23:36:30 +0000 | [diff] [blame] | 1762 | bool Changed = false; |
Mehdi Amini | a28d91d | 2015-03-10 02:37:25 +0000 | [diff] [blame] | 1763 | if (!I.hasNoSignedWrap() && WillNotOverflowSignedSub(Op0, Op1, I)) { |
David Majnemer | 57d5bc8 | 2014-08-19 23:36:30 +0000 | [diff] [blame] | 1764 | Changed = true; |
| 1765 | I.setHasNoSignedWrap(true); |
| 1766 | } |
Mehdi Amini | a28d91d | 2015-03-10 02:37:25 +0000 | [diff] [blame] | 1767 | if (!I.hasNoUnsignedWrap() && WillNotOverflowUnsignedSub(Op0, Op1, I)) { |
David Majnemer | 42158f3 | 2014-08-20 07:17:31 +0000 | [diff] [blame] | 1768 | Changed = true; |
| 1769 | I.setHasNoUnsignedWrap(true); |
| 1770 | } |
David Majnemer | 57d5bc8 | 2014-08-19 23:36:30 +0000 | [diff] [blame] | 1771 | |
| 1772 | return Changed ? &I : nullptr; |
Chris Lattner | 82aa888 | 2010-01-05 07:18:46 +0000 | [diff] [blame] | 1773 | } |
| 1774 | |
| 1775 | Instruction *InstCombiner::visitFSub(BinaryOperator &I) { |
| 1776 | Value *Op0 = I.getOperand(0), *Op1 = I.getOperand(1); |
| 1777 | |
Serge Pavlov | 9ef66a8 | 2014-05-11 08:46:12 +0000 | [diff] [blame] | 1778 | if (Value *V = SimplifyVectorOp(I)) |
Sanjay Patel | 4b19880 | 2016-02-01 22:23:39 +0000 | [diff] [blame] | 1779 | return replaceInstUsesWith(I, V); |
Serge Pavlov | 9ef66a8 | 2014-05-11 08:46:12 +0000 | [diff] [blame] | 1780 | |
Daniel Berlin | 2c75c63 | 2017-04-26 20:56:07 +0000 | [diff] [blame] | 1781 | if (Value *V = SimplifyFSubInst(Op0, Op1, I.getFastMathFlags(), SQ)) |
Sanjay Patel | 4b19880 | 2016-02-01 22:23:39 +0000 | [diff] [blame] | 1782 | return replaceInstUsesWith(I, V); |
Michael Ilseman | d5787be | 2012-12-12 00:28:32 +0000 | [diff] [blame] | 1783 | |
Sanjay Patel | e68f715 | 2014-12-31 22:14:05 +0000 | [diff] [blame] | 1784 | // fsub nsz 0, X ==> fsub nsz -0.0, X |
| 1785 | if (I.getFastMathFlags().noSignedZeros() && match(Op0, m_Zero())) { |
| 1786 | // Subtraction from -0.0 is the canonical form of fneg. |
| 1787 | Instruction *NewI = BinaryOperator::CreateFNeg(Op1); |
| 1788 | NewI->copyFastMathFlags(&I); |
| 1789 | return NewI; |
| 1790 | } |
| 1791 | |
Stephen Lin | a9b57f6 | 2013-07-20 07:13:13 +0000 | [diff] [blame] | 1792 | if (isa<Constant>(Op0)) |
| 1793 | if (SelectInst *SI = dyn_cast<SelectInst>(Op1)) |
| 1794 | if (Instruction *NV = FoldOpIntoSelect(I, SI)) |
| 1795 | return NV; |
| 1796 | |
Owen Anderson | e37c2e4 | 2013-07-26 21:40:29 +0000 | [diff] [blame] | 1797 | // If this is a 'B = x-(-A)', change to B = x+A, potentially looking |
| 1798 | // through FP extensions/truncations along the way. |
Owen Anderson | c7be519 | 2013-07-30 23:53:17 +0000 | [diff] [blame] | 1799 | if (Value *V = dyn_castFNegVal(Op1)) { |
| 1800 | Instruction *NewI = BinaryOperator::CreateFAdd(Op0, V); |
| 1801 | NewI->copyFastMathFlags(&I); |
| 1802 | return NewI; |
| 1803 | } |
Owen Anderson | e37c2e4 | 2013-07-26 21:40:29 +0000 | [diff] [blame] | 1804 | if (FPTruncInst *FPTI = dyn_cast<FPTruncInst>(Op1)) { |
| 1805 | if (Value *V = dyn_castFNegVal(FPTI->getOperand(0))) { |
| 1806 | Value *NewTrunc = Builder->CreateFPTrunc(V, I.getType()); |
Owen Anderson | c7be519 | 2013-07-30 23:53:17 +0000 | [diff] [blame] | 1807 | Instruction *NewI = BinaryOperator::CreateFAdd(Op0, NewTrunc); |
| 1808 | NewI->copyFastMathFlags(&I); |
| 1809 | return NewI; |
Owen Anderson | e37c2e4 | 2013-07-26 21:40:29 +0000 | [diff] [blame] | 1810 | } |
| 1811 | } else if (FPExtInst *FPEI = dyn_cast<FPExtInst>(Op1)) { |
| 1812 | if (Value *V = dyn_castFNegVal(FPEI->getOperand(0))) { |
Owen Anderson | d6d4da0 | 2013-07-26 22:06:21 +0000 | [diff] [blame] | 1813 | Value *NewExt = Builder->CreateFPExt(V, I.getType()); |
Owen Anderson | c7be519 | 2013-07-30 23:53:17 +0000 | [diff] [blame] | 1814 | Instruction *NewI = BinaryOperator::CreateFAdd(Op0, NewExt); |
| 1815 | NewI->copyFastMathFlags(&I); |
| 1816 | return NewI; |
Owen Anderson | e37c2e4 | 2013-07-26 21:40:29 +0000 | [diff] [blame] | 1817 | } |
| 1818 | } |
Chris Lattner | 82aa888 | 2010-01-05 07:18:46 +0000 | [diff] [blame] | 1819 | |
Shuxin Yang | 37a1efe | 2012-12-18 23:10:12 +0000 | [diff] [blame] | 1820 | if (I.hasUnsafeAlgebra()) { |
| 1821 | if (Value *V = FAddCombine(Builder).simplify(&I)) |
Sanjay Patel | 4b19880 | 2016-02-01 22:23:39 +0000 | [diff] [blame] | 1822 | return replaceInstUsesWith(I, V); |
Shuxin Yang | 37a1efe | 2012-12-18 23:10:12 +0000 | [diff] [blame] | 1823 | } |
| 1824 | |
Craig Topper | f40110f | 2014-04-25 05:29:35 +0000 | [diff] [blame] | 1825 | return nullptr; |
Chris Lattner | 82aa888 | 2010-01-05 07:18:46 +0000 | [diff] [blame] | 1826 | } |