blob: 822a2d894776db3e986d61656ca405e270625fea [file] [log] [blame]
Chris Lattnerc0f58002002-05-08 22:19:27 +00001//===- Reassociate.cpp - Reassociate binary expressions -------------------===//
John Criswell482202a2003-10-20 19:43:21 +00002//
3// The LLVM Compiler Infrastructure
4//
5// This file was developed by the LLVM research group and is distributed under
6// the University of Illinois Open Source License. See LICENSE.TXT for details.
7//
8//===----------------------------------------------------------------------===//
Chris Lattnerc0f58002002-05-08 22:19:27 +00009//
10// This pass reassociates commutative expressions in an order that is designed
Chris Lattner36663782003-05-02 19:26:34 +000011// to promote better constant propagation, GCSE, LICM, PRE...
Chris Lattnerc0f58002002-05-08 22:19:27 +000012//
13// For example: 4 + (x + 5) -> x + (4 + 5)
14//
15// Note that this pass works best if left shifts have been promoted to explicit
16// multiplies before this pass executes.
17//
18// In the implementation of this algorithm, constants are assigned rank = 0,
19// function arguments are rank = 1, and other values are assigned ranks
20// corresponding to the reverse post order traversal of current function
21// (starting at 2), which effectively gives values in deep loops higher rank
22// than values not in loops.
23//
24//===----------------------------------------------------------------------===//
25
26#include "llvm/Transforms/Scalar.h"
27#include "llvm/Function.h"
Chris Lattnerc0f58002002-05-08 22:19:27 +000028#include "llvm/iOperators.h"
29#include "llvm/Type.h"
30#include "llvm/Pass.h"
31#include "llvm/Constant.h"
32#include "llvm/Support/CFG.h"
Chris Lattner8abcd562003-08-01 22:15:03 +000033#include "Support/Debug.h"
Chris Lattnerc0f58002002-05-08 22:19:27 +000034#include "Support/PostOrderIterator.h"
Chris Lattnerbf3a0992002-10-01 22:38:41 +000035#include "Support/Statistic.h"
Chris Lattnerc0f58002002-05-08 22:19:27 +000036
37namespace {
Chris Lattnerbf3a0992002-10-01 22:38:41 +000038 Statistic<> NumLinear ("reassociate","Number of insts linearized");
39 Statistic<> NumChanged("reassociate","Number of insts reassociated");
40 Statistic<> NumSwapped("reassociate","Number of insts with operands swapped");
41
Chris Lattnerc0f58002002-05-08 22:19:27 +000042 class Reassociate : public FunctionPass {
Chris Lattner10073a92002-07-25 06:17:51 +000043 std::map<BasicBlock*, unsigned> RankMap;
Chris Lattner8ac196d2003-08-13 16:16:26 +000044 std::map<Value*, unsigned> ValueRankMap;
Chris Lattnerc0f58002002-05-08 22:19:27 +000045 public:
Chris Lattner113f4f42002-06-25 16:13:24 +000046 bool runOnFunction(Function &F);
Chris Lattnerc0f58002002-05-08 22:19:27 +000047
48 virtual void getAnalysisUsage(AnalysisUsage &AU) const {
Chris Lattner820d9712002-10-21 20:00:28 +000049 AU.setPreservesCFG();
Chris Lattnerc0f58002002-05-08 22:19:27 +000050 }
51 private:
Chris Lattner113f4f42002-06-25 16:13:24 +000052 void BuildRankMap(Function &F);
Chris Lattnerc0f58002002-05-08 22:19:27 +000053 unsigned getRank(Value *V);
54 bool ReassociateExpr(BinaryOperator *I);
55 bool ReassociateBB(BasicBlock *BB);
56 };
Chris Lattnerb28b6802002-07-23 18:06:35 +000057
Chris Lattnerc8b70922002-07-26 21:12:46 +000058 RegisterOpt<Reassociate> X("reassociate", "Reassociate expressions");
Chris Lattnerc0f58002002-05-08 22:19:27 +000059}
60
61Pass *createReassociatePass() { return new Reassociate(); }
62
Chris Lattner113f4f42002-06-25 16:13:24 +000063void Reassociate::BuildRankMap(Function &F) {
Chris Lattner58c7eb62003-08-12 20:14:27 +000064 unsigned i = 2;
Chris Lattner8ac196d2003-08-13 16:16:26 +000065
66 // Assign distinct ranks to function arguments
67 for (Function::aiterator I = F.abegin(), E = F.aend(); I != E; ++I)
68 ValueRankMap[I] = ++i;
69
Chris Lattner113f4f42002-06-25 16:13:24 +000070 ReversePostOrderTraversal<Function*> RPOT(&F);
Chris Lattnerc0f58002002-05-08 22:19:27 +000071 for (ReversePostOrderTraversal<Function*>::rpo_iterator I = RPOT.begin(),
72 E = RPOT.end(); I != E; ++I)
Chris Lattner58c7eb62003-08-12 20:14:27 +000073 RankMap[*I] = ++i << 16;
Chris Lattnerc0f58002002-05-08 22:19:27 +000074}
75
76unsigned Reassociate::getRank(Value *V) {
Chris Lattner8ac196d2003-08-13 16:16:26 +000077 if (isa<Argument>(V)) return ValueRankMap[V]; // Function argument...
78
Chris Lattnerc0f58002002-05-08 22:19:27 +000079 if (Instruction *I = dyn_cast<Instruction>(V)) {
Chris Lattner58c7eb62003-08-12 20:14:27 +000080 // If this is an expression, return the 1+MAX(rank(LHS), rank(RHS)) so that
81 // we can reassociate expressions for code motion! Since we do not recurse
82 // for PHI nodes, we cannot have infinite recursion here, because there
83 // cannot be loops in the value graph that do not go through PHI nodes.
Chris Lattnerc0f58002002-05-08 22:19:27 +000084 //
Chris Lattnerb94550e2003-10-19 21:34:28 +000085 if (I->getOpcode() == Instruction::PHI ||
Chris Lattnerc0f58002002-05-08 22:19:27 +000086 I->getOpcode() == Instruction::Alloca ||
87 I->getOpcode() == Instruction::Malloc || isa<TerminatorInst>(I) ||
Chris Lattner4869f372003-02-24 20:48:32 +000088 I->mayWriteToMemory()) // Cannot move inst if it writes to memory!
Chris Lattnerc0f58002002-05-08 22:19:27 +000089 return RankMap[I->getParent()];
90
Chris Lattner8ac196d2003-08-13 16:16:26 +000091 unsigned &CachedRank = ValueRankMap[I];
Chris Lattner3aa77672002-12-15 03:56:00 +000092 if (CachedRank) return CachedRank; // Rank already known?
93
94 // If not, compute it!
Chris Lattner7bc532d2002-05-16 04:37:07 +000095 unsigned Rank = 0, MaxRank = RankMap[I->getParent()];
96 for (unsigned i = 0, e = I->getNumOperands();
97 i != e && Rank != MaxRank; ++i)
Chris Lattnerc0f58002002-05-08 22:19:27 +000098 Rank = std::max(Rank, getRank(I->getOperand(i)));
99
Chris Lattner58c7eb62003-08-12 20:14:27 +0000100 DEBUG(std::cerr << "Calculated Rank[" << V->getName() << "] = "
101 << Rank+1 << "\n");
102
103 return CachedRank = Rank+1;
Chris Lattnerc0f58002002-05-08 22:19:27 +0000104 }
105
106 // Otherwise it's a global or constant, rank 0.
107 return 0;
108}
109
110
Chris Lattnerc0f58002002-05-08 22:19:27 +0000111bool Reassociate::ReassociateExpr(BinaryOperator *I) {
112 Value *LHS = I->getOperand(0);
113 Value *RHS = I->getOperand(1);
114 unsigned LHSRank = getRank(LHS);
115 unsigned RHSRank = getRank(RHS);
116
117 bool Changed = false;
118
119 // Make sure the LHS of the operand always has the greater rank...
120 if (LHSRank < RHSRank) {
Chris Lattner8fdf75c2002-10-31 17:12:59 +0000121 bool Success = !I->swapOperands();
122 assert(Success && "swapOperands failed");
123
Chris Lattnerc0f58002002-05-08 22:19:27 +0000124 std::swap(LHS, RHS);
125 std::swap(LHSRank, RHSRank);
126 Changed = true;
Chris Lattner0b18c1d2002-05-10 15:38:35 +0000127 ++NumSwapped;
Chris Lattnerf96c8be2002-12-15 03:49:50 +0000128 DEBUG(std::cerr << "Transposed: " << I
129 /* << " Result BB: " << I->getParent()*/);
Chris Lattnerc0f58002002-05-08 22:19:27 +0000130 }
131
132 // If the LHS is the same operator as the current one is, and if we are the
133 // only expression using it...
134 //
135 if (BinaryOperator *LHSI = dyn_cast<BinaryOperator>(LHS))
Chris Lattnerf95d9b92003-10-15 16:48:29 +0000136 if (LHSI->getOpcode() == I->getOpcode() && LHSI->hasOneUse()) {
Chris Lattnerc0f58002002-05-08 22:19:27 +0000137 // If the rank of our current RHS is less than the rank of the LHS's LHS,
138 // then we reassociate the two instructions...
Chris Lattnerc0f58002002-05-08 22:19:27 +0000139
Chris Lattner98b3ecd2003-08-12 21:45:24 +0000140 unsigned TakeOp = 0;
141 if (BinaryOperator *IOp = dyn_cast<BinaryOperator>(LHSI->getOperand(0)))
142 if (IOp->getOpcode() == LHSI->getOpcode())
143 TakeOp = 1; // Hoist out non-tree portion
144
145 if (RHSRank < getRank(LHSI->getOperand(TakeOp))) {
Chris Lattnerc0f58002002-05-08 22:19:27 +0000146 // Convert ((a + 12) + 10) into (a + (12 + 10))
147 I->setOperand(0, LHSI->getOperand(TakeOp));
Chris Lattnerf96c8be2002-12-15 03:49:50 +0000148 LHSI->setOperand(TakeOp, RHS);
149 I->setOperand(1, LHSI);
Chris Lattner8fdf75c2002-10-31 17:12:59 +0000150
151 // Move the LHS expression forward, to ensure that it is dominated by
152 // its operands.
Chris Lattnerf96c8be2002-12-15 03:49:50 +0000153 LHSI->getParent()->getInstList().remove(LHSI);
154 I->getParent()->getInstList().insert(I, LHSI);
Chris Lattnerc0f58002002-05-08 22:19:27 +0000155
Chris Lattner0b18c1d2002-05-10 15:38:35 +0000156 ++NumChanged;
Chris Lattnerf96c8be2002-12-15 03:49:50 +0000157 DEBUG(std::cerr << "Reassociated: " << I/* << " Result BB: "
158 << I->getParent()*/);
Chris Lattnerc0f58002002-05-08 22:19:27 +0000159
160 // Since we modified the RHS instruction, make sure that we recheck it.
Chris Lattnerf96c8be2002-12-15 03:49:50 +0000161 ReassociateExpr(LHSI);
Chris Lattner58c7eb62003-08-12 20:14:27 +0000162 ReassociateExpr(I);
Chris Lattnerc0f58002002-05-08 22:19:27 +0000163 return true;
164 }
165 }
166
167 return Changed;
168}
169
170
Chris Lattner7bc532d2002-05-16 04:37:07 +0000171// NegateValue - Insert instructions before the instruction pointed to by BI,
172// that computes the negative version of the value specified. The negative
173// version of the value is returned, and BI is left pointing at the instruction
174// that should be processed next by the reassociation pass.
175//
Chris Lattner8fdf75c2002-10-31 17:12:59 +0000176static Value *NegateValue(Value *V, BasicBlock::iterator &BI) {
Chris Lattner7bc532d2002-05-16 04:37:07 +0000177 // We are trying to expose opportunity for reassociation. One of the things
178 // that we want to do to achieve this is to push a negation as deep into an
179 // expression chain as possible, to expose the add instructions. In practice,
180 // this means that we turn this:
181 // X = -(A+12+C+D) into X = -A + -12 + -C + -D = -12 + -A + -C + -D
182 // so that later, a: Y = 12+X could get reassociated with the -12 to eliminate
183 // the constants. We assume that instcombine will clean up the mess later if
Misha Brukman7eb05a12003-08-18 14:43:39 +0000184 // we introduce tons of unnecessary negation instructions...
Chris Lattner7bc532d2002-05-16 04:37:07 +0000185 //
186 if (Instruction *I = dyn_cast<Instruction>(V))
Chris Lattnerf95d9b92003-10-15 16:48:29 +0000187 if (I->getOpcode() == Instruction::Add && I->hasOneUse()) {
Chris Lattner8fdf75c2002-10-31 17:12:59 +0000188 Value *RHS = NegateValue(I->getOperand(1), BI);
189 Value *LHS = NegateValue(I->getOperand(0), BI);
Chris Lattner7bc532d2002-05-16 04:37:07 +0000190
191 // We must actually insert a new add instruction here, because the neg
192 // instructions do not dominate the old add instruction in general. By
193 // adding it now, we are assured that the neg instructions we just
194 // inserted dominate the instruction we are about to insert after them.
195 //
Chris Lattner28a8d242002-09-10 17:04:02 +0000196 return BinaryOperator::create(Instruction::Add, LHS, RHS,
197 I->getName()+".neg",
198 cast<Instruction>(RHS)->getNext());
Chris Lattner7bc532d2002-05-16 04:37:07 +0000199 }
200
201 // Insert a 'neg' instruction that subtracts the value from zero to get the
202 // negation.
203 //
Chris Lattner8fdf75c2002-10-31 17:12:59 +0000204 return BI = BinaryOperator::createNeg(V, V->getName() + ".neg", BI);
Chris Lattner7bc532d2002-05-16 04:37:07 +0000205}
206
207
Chris Lattnerc0f58002002-05-08 22:19:27 +0000208bool Reassociate::ReassociateBB(BasicBlock *BB) {
209 bool Changed = false;
210 for (BasicBlock::iterator BI = BB->begin(); BI != BB->end(); ++BI) {
Chris Lattnerc0f58002002-05-08 22:19:27 +0000211
Chris Lattnerf96c8be2002-12-15 03:49:50 +0000212 DEBUG(std::cerr << "Processing: " << *BI);
Chris Lattner8fdf75c2002-10-31 17:12:59 +0000213 if (BI->getOpcode() == Instruction::Sub && !BinaryOperator::isNeg(BI)) {
214 // Convert a subtract into an add and a neg instruction... so that sub
215 // instructions can be commuted with other add instructions...
216 //
217 // Calculate the negative value of Operand 1 of the sub instruction...
218 // and set it as the RHS of the add instruction we just made...
219 //
220 std::string Name = BI->getName();
221 BI->setName("");
222 Instruction *New =
223 BinaryOperator::create(Instruction::Add, BI->getOperand(0),
224 BI->getOperand(1), Name, BI);
225
226 // Everyone now refers to the add instruction...
227 BI->replaceAllUsesWith(New);
228
229 // Put the new add in the place of the subtract... deleting the subtract
230 BB->getInstList().erase(BI);
231
232 BI = New;
233 New->setOperand(1, NegateValue(New->getOperand(1), BI));
234
235 Changed = true;
Chris Lattnerf96c8be2002-12-15 03:49:50 +0000236 DEBUG(std::cerr << "Negated: " << New /*<< " Result BB: " << BB*/);
Chris Lattner8fdf75c2002-10-31 17:12:59 +0000237 }
238
Chris Lattnerc0f58002002-05-08 22:19:27 +0000239 // If this instruction is a commutative binary operator, and the ranks of
240 // the two operands are sorted incorrectly, fix it now.
241 //
Chris Lattner8fdf75c2002-10-31 17:12:59 +0000242 if (BI->isAssociative()) {
Chris Lattner889f6202003-04-23 16:37:45 +0000243 BinaryOperator *I = cast<BinaryOperator>(BI);
Chris Lattner7bc532d2002-05-16 04:37:07 +0000244 if (!I->use_empty()) {
245 // Make sure that we don't have a tree-shaped computation. If we do,
246 // linearize it. Convert (A+B)+(C+D) into ((A+B)+C)+D
247 //
248 Instruction *LHSI = dyn_cast<Instruction>(I->getOperand(0));
249 Instruction *RHSI = dyn_cast<Instruction>(I->getOperand(1));
250 if (LHSI && (int)LHSI->getOpcode() == I->getOpcode() &&
251 RHSI && (int)RHSI->getOpcode() == I->getOpcode() &&
Chris Lattnerf95d9b92003-10-15 16:48:29 +0000252 RHSI->hasOneUse()) {
Chris Lattner7bc532d2002-05-16 04:37:07 +0000253 // Insert a new temporary instruction... (A+B)+C
254 BinaryOperator *Tmp = BinaryOperator::create(I->getOpcode(), LHSI,
255 RHSI->getOperand(0),
Chris Lattner28a8d242002-09-10 17:04:02 +0000256 RHSI->getName()+".ra",
257 BI);
258 BI = Tmp;
Chris Lattner7bc532d2002-05-16 04:37:07 +0000259 I->setOperand(0, Tmp);
260 I->setOperand(1, RHSI->getOperand(1));
261
262 // Process the temporary instruction for reassociation now.
263 I = Tmp;
264 ++NumLinear;
265 Changed = true;
Chris Lattnerf96c8be2002-12-15 03:49:50 +0000266 DEBUG(std::cerr << "Linearized: " << I/* << " Result BB: " << BB*/);
Chris Lattner7bc532d2002-05-16 04:37:07 +0000267 }
268
269 // Make sure that this expression is correctly reassociated with respect
270 // to it's used values...
271 //
272 Changed |= ReassociateExpr(I);
273 }
Chris Lattnerc0f58002002-05-08 22:19:27 +0000274 }
275 }
276
277 return Changed;
278}
279
280
Chris Lattner113f4f42002-06-25 16:13:24 +0000281bool Reassociate::runOnFunction(Function &F) {
Chris Lattnerc0f58002002-05-08 22:19:27 +0000282 // Recalculate the rank map for F
283 BuildRankMap(F);
284
285 bool Changed = false;
Chris Lattner113f4f42002-06-25 16:13:24 +0000286 for (Function::iterator FI = F.begin(), FE = F.end(); FI != FE; ++FI)
287 Changed |= ReassociateBB(FI);
Chris Lattnerc0f58002002-05-08 22:19:27 +0000288
289 // We are done with the rank map...
290 RankMap.clear();
Chris Lattner8ac196d2003-08-13 16:16:26 +0000291 ValueRankMap.clear();
Chris Lattnerc0f58002002-05-08 22:19:27 +0000292 return Changed;
293}