blob: b532deb55336d50885ca996567aa41687b935459 [file] [log] [blame]
Gabor Horvath28690922015-08-26 23:17:43 +00001//== Nullabilityhecker.cpp - Nullability checker ----------------*- C++ -*--==//
2//
3// The LLVM Compiler Infrastructure
4//
5// This file is distributed under the University of Illinois Open Source
6// License. See LICENSE.TXT for details.
7//
8//===----------------------------------------------------------------------===//
9//
10// This checker tries to find nullability violations. There are several kinds of
11// possible violations:
12// * Null pointer is passed to a pointer which has a _Nonnull type.
13// * Null pointer is returned from a function which has a _Nonnull return type.
14// * Nullable pointer is passed to a pointer which has a _Nonnull type.
15// * Nullable pointer is returned from a function which has a _Nonnull return
16// type.
17// * Nullable pointer is dereferenced.
18//
19// This checker propagates the nullability information of the pointers and looks
20// for the patterns that are described above. Explicit casts are trusted and are
21// considered a way to suppress false positives for this checker. The other way
22// to suppress warnings would be to add asserts or guarding if statements to the
23// code. In addition to the nullability propagation this checker also uses some
24// heuristics to suppress potential false positives.
25//
26//===----------------------------------------------------------------------===//
27
28#include "ClangSACheckers.h"
29#include "llvm/Support/Path.h"
30#include "clang/StaticAnalyzer/Core/BugReporter/BugType.h"
31#include "clang/StaticAnalyzer/Core/Checker.h"
32#include "clang/StaticAnalyzer/Core/CheckerManager.h"
33#include "clang/StaticAnalyzer/Core/PathSensitive/CheckerContext.h"
34#include "clang/StaticAnalyzer/Core/PathSensitive/CallEvent.h"
35
36using namespace clang;
37using namespace ento;
38
39namespace {
40// Do not reorder! The getMostNullable method relies on the order.
41// Optimization: Most pointers expected to be unspecified. When a symbol has an
42// unspecified or nonnull type non of the rules would indicate any problem for
43// that symbol. For this reason only nullable and contradicted nullability are
44// stored for a symbol. When a symbol is already contradicted, it can not be
45// casted back to nullable.
46enum class Nullability : char {
47 Contradicted, // Tracked nullability is contradicted by an explicit cast. Do
48 // not report any nullability related issue for this symbol.
49 // This nullability is propagated agressively to avoid false
50 // positive results. See the comment on getMostNullable method.
51 Nullable,
52 Unspecified,
53 Nonnull
54};
55
56/// Returns the most nullable nullability. This is used for message expressions
57/// like [reciever method], where the nullability of this expression is either
58/// the nullability of the receiver or the nullability of the return type of the
59/// method, depending on which is more nullable. Contradicted is considered to
60/// be the most nullable, to avoid false positive results.
Gabor Horvath3943adb2015-09-11 16:29:05 +000061Nullability getMostNullable(Nullability Lhs, Nullability Rhs) {
Gabor Horvath28690922015-08-26 23:17:43 +000062 return static_cast<Nullability>(
63 std::min(static_cast<char>(Lhs), static_cast<char>(Rhs)));
64}
65
Gabor Horvath3943adb2015-09-11 16:29:05 +000066const char *getNullabilityString(Nullability Nullab) {
Gabor Horvath28690922015-08-26 23:17:43 +000067 switch (Nullab) {
68 case Nullability::Contradicted:
69 return "contradicted";
70 case Nullability::Nullable:
71 return "nullable";
72 case Nullability::Unspecified:
73 return "unspecified";
74 case Nullability::Nonnull:
75 return "nonnull";
76 }
Gabor Horvath3943adb2015-09-11 16:29:05 +000077 llvm_unreachable("Unexpected enumeration.");
Gabor Horvath28690922015-08-26 23:17:43 +000078 return "";
79}
80
81// These enums are used as an index to ErrorMessages array.
82enum class ErrorKind : int {
83 NilAssignedToNonnull,
84 NilPassedToNonnull,
85 NilReturnedToNonnull,
86 NullableAssignedToNonnull,
87 NullableReturnedToNonnull,
88 NullableDereferenced,
89 NullablePassedToNonnull
90};
91
Gabor Horvath3943adb2015-09-11 16:29:05 +000092const char *const ErrorMessages[] = {
93 "Null is assigned to a pointer which is expected to have non-null value",
94 "Null passed to a callee that requires a non-null argument",
95 "Null is returned from a function that is expected to return a non-null "
96 "value",
97 "Nullable pointer is assigned to a pointer which is expected to have "
98 "non-null value",
99 "Nullable pointer is returned from a function that is expected to return a "
100 "non-null value",
101 "Nullable pointer is dereferenced",
Gabor Horvath17dacc42015-09-11 18:41:50 +0000102 "Nullable pointer is passed to a callee that requires a non-null argument"};
Gabor Horvath28690922015-08-26 23:17:43 +0000103
104class NullabilityChecker
105 : public Checker<check::Bind, check::PreCall, check::PreStmt<ReturnStmt>,
106 check::PostCall, check::PostStmt<ExplicitCastExpr>,
107 check::PostObjCMessage, check::DeadSymbols,
108 check::Event<ImplicitNullDerefEvent>> {
109 mutable std::unique_ptr<BugType> BT;
110
111public:
112 void checkBind(SVal L, SVal V, const Stmt *S, CheckerContext &C) const;
113 void checkPostStmt(const ExplicitCastExpr *CE, CheckerContext &C) const;
114 void checkPreStmt(const ReturnStmt *S, CheckerContext &C) const;
115 void checkPostObjCMessage(const ObjCMethodCall &M, CheckerContext &C) const;
116 void checkPostCall(const CallEvent &Call, CheckerContext &C) const;
117 void checkPreCall(const CallEvent &Call, CheckerContext &C) const;
118 void checkDeadSymbols(SymbolReaper &SR, CheckerContext &C) const;
119 void checkEvent(ImplicitNullDerefEvent Event) const;
120
121 void printState(raw_ostream &Out, ProgramStateRef State, const char *NL,
122 const char *Sep) const override;
123
124 struct NullabilityChecksFilter {
125 DefaultBool CheckNullPassedToNonnull;
126 DefaultBool CheckNullReturnedFromNonnull;
127 DefaultBool CheckNullableDereferenced;
128 DefaultBool CheckNullablePassedToNonnull;
129 DefaultBool CheckNullableReturnedFromNonnull;
130
131 CheckName CheckNameNullPassedToNonnull;
132 CheckName CheckNameNullReturnedFromNonnull;
133 CheckName CheckNameNullableDereferenced;
134 CheckName CheckNameNullablePassedToNonnull;
135 CheckName CheckNameNullableReturnedFromNonnull;
136 };
137
138 NullabilityChecksFilter Filter;
Gabor Horvath29307352015-09-14 18:31:34 +0000139 // When set to false no nullability information will be tracked in
140 // NullabilityMap. It is possible to catch errors like passing a null pointer
141 // to a callee that expects nonnull argument without the information that is
142 // stroed in the NullabilityMap. This is an optimization.
143 DefaultBool NeedTracking;
Gabor Horvath28690922015-08-26 23:17:43 +0000144
145private:
146 class NullabilityBugVisitor
147 : public BugReporterVisitorImpl<NullabilityBugVisitor> {
148 public:
149 NullabilityBugVisitor(const MemRegion *M) : Region(M) {}
150
151 void Profile(llvm::FoldingSetNodeID &ID) const override {
152 static int X = 0;
153 ID.AddPointer(&X);
154 ID.AddPointer(Region);
155 }
156
157 PathDiagnosticPiece *VisitNode(const ExplodedNode *N,
158 const ExplodedNode *PrevN,
159 BugReporterContext &BRC,
160 BugReport &BR) override;
161
162 private:
163 // The tracked region.
164 const MemRegion *Region;
165 };
166
Gabor Horvathb47128a2015-09-03 23:16:21 +0000167 /// When any of the nonnull arguments of the analyzed function is null, do not
168 /// report anything and turn off the check.
169 ///
170 /// When \p SuppressPath is set to true, no more bugs will be reported on this
171 /// path by this checker.
172 void reportBugIfPreconditionHolds(ErrorKind Error, ExplodedNode *N,
173 const MemRegion *Region, CheckerContext &C,
174 const Stmt *ValueExpr = nullptr,
175 bool SuppressPath = false) const;
176
Gabor Horvath28690922015-08-26 23:17:43 +0000177 void reportBug(ErrorKind Error, ExplodedNode *N, const MemRegion *Region,
178 BugReporter &BR, const Stmt *ValueExpr = nullptr) const {
179 if (!BT)
180 BT.reset(new BugType(this, "Nullability", "Memory error"));
181 const char *Msg = ErrorMessages[static_cast<int>(Error)];
Gabor Horvath28690922015-08-26 23:17:43 +0000182 std::unique_ptr<BugReport> R(new BugReport(*BT, Msg, N));
183 if (Region) {
184 R->markInteresting(Region);
185 R->addVisitor(llvm::make_unique<NullabilityBugVisitor>(Region));
186 }
187 if (ValueExpr) {
188 R->addRange(ValueExpr->getSourceRange());
189 if (Error == ErrorKind::NilAssignedToNonnull ||
190 Error == ErrorKind::NilPassedToNonnull ||
191 Error == ErrorKind::NilReturnedToNonnull)
192 bugreporter::trackNullOrUndefValue(N, ValueExpr, *R);
193 }
194 BR.emitReport(std::move(R));
195 }
Gabor Horvath29307352015-09-14 18:31:34 +0000196
197 /// If an SVal wraps a region that should be tracked, it will return a pointer
198 /// to the wrapped region. Otherwise it will return a nullptr.
199 const SymbolicRegion *getTrackRegion(SVal Val,
200 bool CheckSuperRegion = false) const;
Gabor Horvath28690922015-08-26 23:17:43 +0000201};
202
203class NullabilityState {
204public:
205 NullabilityState(Nullability Nullab, const Stmt *Source = nullptr)
206 : Nullab(Nullab), Source(Source) {}
207
208 const Stmt *getNullabilitySource() const { return Source; }
209
210 Nullability getValue() const { return Nullab; }
211
212 void Profile(llvm::FoldingSetNodeID &ID) const {
213 ID.AddInteger(static_cast<char>(Nullab));
214 ID.AddPointer(Source);
215 }
216
217 void print(raw_ostream &Out) const {
218 Out << getNullabilityString(Nullab) << "\n";
219 }
220
221private:
222 Nullability Nullab;
223 // Source is the expression which determined the nullability. For example in a
224 // message like [nullable nonnull_returning] has nullable nullability, because
225 // the receiver is nullable. Here the receiver will be the source of the
226 // nullability. This is useful information when the diagnostics are generated.
227 const Stmt *Source;
228};
229
230bool operator==(NullabilityState Lhs, NullabilityState Rhs) {
231 return Lhs.getValue() == Rhs.getValue() &&
232 Lhs.getNullabilitySource() == Rhs.getNullabilitySource();
233}
234
235} // end anonymous namespace
236
237REGISTER_MAP_WITH_PROGRAMSTATE(NullabilityMap, const MemRegion *,
238 NullabilityState)
239
Gabor Horvathb47128a2015-09-03 23:16:21 +0000240// If the nullability precondition of a function is violated, we should not
241// report nullability related issues on that path. For this reason once a
242// precondition is not met on a path, this checker will be esentially turned off
243// for the rest of the analysis. We do not want to generate a sink node however,
244// so this checker would not lead to reduced coverage.
245REGISTER_TRAIT_WITH_PROGRAMSTATE(PreconditionViolated, bool)
246
Gabor Horvath28690922015-08-26 23:17:43 +0000247enum class NullConstraint { IsNull, IsNotNull, Unknown };
248
249static NullConstraint getNullConstraint(DefinedOrUnknownSVal Val,
250 ProgramStateRef State) {
251 ConditionTruthVal Nullness = State->isNull(Val);
252 if (Nullness.isConstrainedFalse())
253 return NullConstraint::IsNotNull;
254 if (Nullness.isConstrainedTrue())
255 return NullConstraint::IsNull;
256 return NullConstraint::Unknown;
257}
258
Gabor Horvath29307352015-09-14 18:31:34 +0000259const SymbolicRegion *
260NullabilityChecker::getTrackRegion(SVal Val, bool CheckSuperRegion) const {
261 if (!NeedTracking)
262 return nullptr;
263
Gabor Horvath28690922015-08-26 23:17:43 +0000264 auto RegionSVal = Val.getAs<loc::MemRegionVal>();
265 if (!RegionSVal)
266 return nullptr;
267
268 const MemRegion *Region = RegionSVal->getRegion();
269
270 if (CheckSuperRegion) {
271 if (auto FieldReg = Region->getAs<FieldRegion>())
272 return dyn_cast<SymbolicRegion>(FieldReg->getSuperRegion());
Gabor Horvath3943adb2015-09-11 16:29:05 +0000273 if (auto ElementReg = Region->getAs<ElementRegion>())
Gabor Horvath28690922015-08-26 23:17:43 +0000274 return dyn_cast<SymbolicRegion>(ElementReg->getSuperRegion());
275 }
276
277 return dyn_cast<SymbolicRegion>(Region);
278}
279
280PathDiagnosticPiece *NullabilityChecker::NullabilityBugVisitor::VisitNode(
281 const ExplodedNode *N, const ExplodedNode *PrevN, BugReporterContext &BRC,
282 BugReport &BR) {
Gabor Horvath3943adb2015-09-11 16:29:05 +0000283 ProgramStateRef State = N->getState();
284 ProgramStateRef StatePrev = PrevN->getState();
Gabor Horvath28690922015-08-26 23:17:43 +0000285
Gabor Horvath3943adb2015-09-11 16:29:05 +0000286 const NullabilityState *TrackedNullab = State->get<NullabilityMap>(Region);
Gabor Horvath28690922015-08-26 23:17:43 +0000287 const NullabilityState *TrackedNullabPrev =
Gabor Horvath3943adb2015-09-11 16:29:05 +0000288 StatePrev->get<NullabilityMap>(Region);
Gabor Horvath28690922015-08-26 23:17:43 +0000289 if (!TrackedNullab)
290 return nullptr;
291
292 if (TrackedNullabPrev &&
293 TrackedNullabPrev->getValue() == TrackedNullab->getValue())
294 return nullptr;
295
296 // Retrieve the associated statement.
297 const Stmt *S = TrackedNullab->getNullabilitySource();
298 if (!S) {
299 ProgramPoint ProgLoc = N->getLocation();
300 if (Optional<StmtPoint> SP = ProgLoc.getAs<StmtPoint>()) {
301 S = SP->getStmt();
302 }
303 }
304
305 if (!S)
306 return nullptr;
307
308 std::string InfoText =
309 (llvm::Twine("Nullability '") +
310 getNullabilityString(TrackedNullab->getValue()) + "' is infered")
311 .str();
312
313 // Generate the extra diagnostic.
314 PathDiagnosticLocation Pos(S, BRC.getSourceManager(),
315 N->getLocationContext());
316 return new PathDiagnosticEventPiece(Pos, InfoText, true, nullptr);
317}
318
319static Nullability getNullabilityAnnotation(QualType Type) {
320 const auto *AttrType = Type->getAs<AttributedType>();
321 if (!AttrType)
322 return Nullability::Unspecified;
323 if (AttrType->getAttrKind() == AttributedType::attr_nullable)
324 return Nullability::Nullable;
325 else if (AttrType->getAttrKind() == AttributedType::attr_nonnull)
326 return Nullability::Nonnull;
327 return Nullability::Unspecified;
328}
329
Gabor Horvathb47128a2015-09-03 23:16:21 +0000330template <typename ParamVarDeclRange>
331static bool
332checkParamsForPreconditionViolation(const ParamVarDeclRange &Params,
333 ProgramStateRef State,
334 const LocationContext *LocCtxt) {
335 for (const auto *ParamDecl : Params) {
336 if (ParamDecl->isParameterPack())
337 break;
338
339 if (getNullabilityAnnotation(ParamDecl->getType()) != Nullability::Nonnull)
340 continue;
341
342 auto RegVal = State->getLValue(ParamDecl, LocCtxt)
343 .template getAs<loc::MemRegionVal>();
344 if (!RegVal)
345 continue;
346
347 auto ParamValue = State->getSVal(RegVal->getRegion())
348 .template getAs<DefinedOrUnknownSVal>();
349 if (!ParamValue)
350 continue;
351
352 if (getNullConstraint(*ParamValue, State) == NullConstraint::IsNull) {
353 return true;
354 }
355 }
356 return false;
357}
358
359static bool checkPreconditionViolation(ProgramStateRef State, ExplodedNode *N,
360 CheckerContext &C) {
361 if (State->get<PreconditionViolated>())
362 return true;
363
364 const LocationContext *LocCtxt = C.getLocationContext();
365 const Decl *D = LocCtxt->getDecl();
366 if (!D)
367 return false;
368
Devin Coughlin851da712016-01-15 21:35:40 +0000369 ArrayRef<ParmVarDecl*> Params;
370 if (const auto *BD = dyn_cast<BlockDecl>(D))
371 Params = BD->parameters();
372 else if (const auto *FD = dyn_cast<FunctionDecl>(D))
373 Params = FD->parameters();
374 else if (const auto *MD = dyn_cast<ObjCMethodDecl>(D))
375 Params = MD->parameters();
376 else
Gabor Horvathb47128a2015-09-03 23:16:21 +0000377 return false;
Gabor Horvathb47128a2015-09-03 23:16:21 +0000378
Devin Coughlin851da712016-01-15 21:35:40 +0000379 if (checkParamsForPreconditionViolation(Params, State, LocCtxt)) {
380 if (!N->isSink())
381 C.addTransition(State->set<PreconditionViolated>(true), N);
382 return true;
Gabor Horvathb47128a2015-09-03 23:16:21 +0000383 }
384 return false;
385}
386
387void NullabilityChecker::reportBugIfPreconditionHolds(
388 ErrorKind Error, ExplodedNode *N, const MemRegion *Region,
389 CheckerContext &C, const Stmt *ValueExpr, bool SuppressPath) const {
390 ProgramStateRef OriginalState = N->getState();
391
392 if (checkPreconditionViolation(OriginalState, N, C))
393 return;
394 if (SuppressPath) {
395 OriginalState = OriginalState->set<PreconditionViolated>(true);
396 N = C.addTransition(OriginalState, N);
397 }
398
399 reportBug(Error, N, Region, C.getBugReporter(), ValueExpr);
400}
401
Gabor Horvath28690922015-08-26 23:17:43 +0000402/// Cleaning up the program state.
403void NullabilityChecker::checkDeadSymbols(SymbolReaper &SR,
404 CheckerContext &C) const {
Gabor Horvathbe87d5b2015-09-14 20:31:46 +0000405 if (!SR.hasDeadSymbols())
406 return;
407
Gabor Horvath28690922015-08-26 23:17:43 +0000408 ProgramStateRef State = C.getState();
409 NullabilityMapTy Nullabilities = State->get<NullabilityMap>();
410 for (NullabilityMapTy::iterator I = Nullabilities.begin(),
411 E = Nullabilities.end();
412 I != E; ++I) {
Gabor Horvathbe87d5b2015-09-14 20:31:46 +0000413 const auto *Region = I->first->getAs<SymbolicRegion>();
414 assert(Region && "Non-symbolic region is tracked.");
415 if (SR.isDead(Region->getSymbol())) {
Gabor Horvath28690922015-08-26 23:17:43 +0000416 State = State->remove<NullabilityMap>(I->first);
417 }
418 }
Gabor Horvathb47128a2015-09-03 23:16:21 +0000419 // When one of the nonnull arguments are constrained to be null, nullability
420 // preconditions are violated. It is not enough to check this only when we
421 // actually report an error, because at that time interesting symbols might be
422 // reaped.
423 if (checkPreconditionViolation(State, C.getPredecessor(), C))
424 return;
425 C.addTransition(State);
Gabor Horvath28690922015-08-26 23:17:43 +0000426}
427
428/// This callback triggers when a pointer is dereferenced and the analyzer does
429/// not know anything about the value of that pointer. When that pointer is
430/// nullable, this code emits a warning.
431void NullabilityChecker::checkEvent(ImplicitNullDerefEvent Event) const {
Gabor Horvathb47128a2015-09-03 23:16:21 +0000432 if (Event.SinkNode->getState()->get<PreconditionViolated>())
433 return;
434
Gabor Horvath28690922015-08-26 23:17:43 +0000435 const MemRegion *Region =
436 getTrackRegion(Event.Location, /*CheckSuperregion=*/true);
437 if (!Region)
438 return;
439
440 ProgramStateRef State = Event.SinkNode->getState();
441 const NullabilityState *TrackedNullability =
442 State->get<NullabilityMap>(Region);
443
444 if (!TrackedNullability)
445 return;
446
447 if (Filter.CheckNullableDereferenced &&
448 TrackedNullability->getValue() == Nullability::Nullable) {
449 BugReporter &BR = *Event.BR;
Gabor Horvathb47128a2015-09-03 23:16:21 +0000450 // Do not suppress errors on defensive code paths, because dereferencing
451 // a nullable pointer is always an error.
Gabor Horvath8d3ad6b2015-08-27 18:49:07 +0000452 if (Event.IsDirectDereference)
453 reportBug(ErrorKind::NullableDereferenced, Event.SinkNode, Region, BR);
454 else
455 reportBug(ErrorKind::NullablePassedToNonnull, Event.SinkNode, Region, BR);
Gabor Horvath28690922015-08-26 23:17:43 +0000456 }
457}
458
Devin Coughlin5a3843e2016-01-18 18:53:33 +0000459/// Find the outermost subexpression of E that is not an implicit cast.
460/// This looks through the implicit casts to _Nonnull that ARC adds to
461/// return expressions of ObjC types when the return type of the function or
462/// method is non-null but the express is not.
463static const Expr *lookThroughImplicitCasts(const Expr *E) {
464 assert(E);
465
466 while (auto *ICE = dyn_cast<ImplicitCastExpr>(E)) {
467 E = ICE->getSubExpr();
468 }
469
470 return E;
471}
472
Gabor Horvath28690922015-08-26 23:17:43 +0000473/// This method check when nullable pointer or null value is returned from a
474/// function that has nonnull return type.
475///
476/// TODO: when nullability preconditons are violated, it is ok to violate the
477/// nullability postconditons (i.e.: when one of the nonnull parameters are null
478/// this check should not report any nullability related issue).
479void NullabilityChecker::checkPreStmt(const ReturnStmt *S,
480 CheckerContext &C) const {
481 auto RetExpr = S->getRetValue();
482 if (!RetExpr)
483 return;
484
485 if (!RetExpr->getType()->isAnyPointerType())
486 return;
487
488 ProgramStateRef State = C.getState();
Gabor Horvathb47128a2015-09-03 23:16:21 +0000489 if (State->get<PreconditionViolated>())
490 return;
491
Gabor Horvath28690922015-08-26 23:17:43 +0000492 auto RetSVal =
493 State->getSVal(S, C.getLocationContext()).getAs<DefinedOrUnknownSVal>();
494 if (!RetSVal)
495 return;
496
Devin Coughlin851da712016-01-15 21:35:40 +0000497 QualType RequiredRetType;
Gabor Horvath28690922015-08-26 23:17:43 +0000498 AnalysisDeclContext *DeclCtxt =
499 C.getLocationContext()->getAnalysisDeclContext();
Devin Coughlin851da712016-01-15 21:35:40 +0000500 const Decl *D = DeclCtxt->getDecl();
501 if (auto *MD = dyn_cast<ObjCMethodDecl>(D))
502 RequiredRetType = MD->getReturnType();
503 else if (auto *FD = dyn_cast<FunctionDecl>(D))
504 RequiredRetType = FD->getReturnType();
505 else
Gabor Horvath28690922015-08-26 23:17:43 +0000506 return;
507
508 NullConstraint Nullness = getNullConstraint(*RetSVal, State);
509
Devin Coughlin851da712016-01-15 21:35:40 +0000510 Nullability RequiredNullability = getNullabilityAnnotation(RequiredRetType);
Gabor Horvath28690922015-08-26 23:17:43 +0000511
Devin Coughlin755baa42015-12-29 17:40:49 +0000512 // If the returned value is null but the type of the expression
513 // generating it is nonnull then we will suppress the diagnostic.
514 // This enables explicit suppression when returning a nil literal in a
515 // function with a _Nonnull return type:
516 // return (NSString * _Nonnull)0;
517 Nullability RetExprTypeLevelNullability =
Devin Coughlin5a3843e2016-01-18 18:53:33 +0000518 getNullabilityAnnotation(lookThroughImplicitCasts(RetExpr)->getType());
Devin Coughlin755baa42015-12-29 17:40:49 +0000519
Gabor Horvath28690922015-08-26 23:17:43 +0000520 if (Filter.CheckNullReturnedFromNonnull &&
521 Nullness == NullConstraint::IsNull &&
Devin Coughlin755baa42015-12-29 17:40:49 +0000522 RetExprTypeLevelNullability != Nullability::Nonnull &&
523 RequiredNullability == Nullability::Nonnull) {
Gabor Horvath28690922015-08-26 23:17:43 +0000524 static CheckerProgramPointTag Tag(this, "NullReturnedFromNonnull");
Devin Coughline39bd402015-09-16 22:03:05 +0000525 ExplodedNode *N = C.generateErrorNode(State, &Tag);
526 if (!N)
527 return;
Gabor Horvathb47128a2015-09-03 23:16:21 +0000528 reportBugIfPreconditionHolds(ErrorKind::NilReturnedToNonnull, N, nullptr, C,
529 RetExpr);
Gabor Horvath28690922015-08-26 23:17:43 +0000530 return;
531 }
532
533 const MemRegion *Region = getTrackRegion(*RetSVal);
534 if (!Region)
535 return;
536
537 const NullabilityState *TrackedNullability =
538 State->get<NullabilityMap>(Region);
539 if (TrackedNullability) {
540 Nullability TrackedNullabValue = TrackedNullability->getValue();
541 if (Filter.CheckNullableReturnedFromNonnull &&
542 Nullness != NullConstraint::IsNotNull &&
543 TrackedNullabValue == Nullability::Nullable &&
Devin Coughlin755baa42015-12-29 17:40:49 +0000544 RequiredNullability == Nullability::Nonnull) {
Gabor Horvath28690922015-08-26 23:17:43 +0000545 static CheckerProgramPointTag Tag(this, "NullableReturnedFromNonnull");
546 ExplodedNode *N = C.addTransition(State, C.getPredecessor(), &Tag);
Gabor Horvathb47128a2015-09-03 23:16:21 +0000547 reportBugIfPreconditionHolds(ErrorKind::NullableReturnedToNonnull, N,
548 Region, C);
Gabor Horvath28690922015-08-26 23:17:43 +0000549 }
550 return;
551 }
Devin Coughlin755baa42015-12-29 17:40:49 +0000552 if (RequiredNullability == Nullability::Nullable) {
Gabor Horvath28690922015-08-26 23:17:43 +0000553 State = State->set<NullabilityMap>(Region,
Devin Coughlin755baa42015-12-29 17:40:49 +0000554 NullabilityState(RequiredNullability,
555 S));
Gabor Horvath28690922015-08-26 23:17:43 +0000556 C.addTransition(State);
557 }
558}
559
560/// This callback warns when a nullable pointer or a null value is passed to a
561/// function that expects its argument to be nonnull.
562void NullabilityChecker::checkPreCall(const CallEvent &Call,
563 CheckerContext &C) const {
564 if (!Call.getDecl())
565 return;
566
567 ProgramStateRef State = C.getState();
Gabor Horvathb47128a2015-09-03 23:16:21 +0000568 if (State->get<PreconditionViolated>())
569 return;
570
Gabor Horvath28690922015-08-26 23:17:43 +0000571 ProgramStateRef OrigState = State;
572
573 unsigned Idx = 0;
574 for (const ParmVarDecl *Param : Call.parameters()) {
575 if (Param->isParameterPack())
576 break;
577
578 const Expr *ArgExpr = nullptr;
579 if (Idx < Call.getNumArgs())
580 ArgExpr = Call.getArgExpr(Idx);
581 auto ArgSVal = Call.getArgSVal(Idx++).getAs<DefinedOrUnknownSVal>();
582 if (!ArgSVal)
583 continue;
584
585 if (!Param->getType()->isAnyPointerType() &&
586 !Param->getType()->isReferenceType())
587 continue;
588
589 NullConstraint Nullness = getNullConstraint(*ArgSVal, State);
590
Devin Coughlin755baa42015-12-29 17:40:49 +0000591 Nullability RequiredNullability =
592 getNullabilityAnnotation(Param->getType());
593 Nullability ArgExprTypeLevelNullability =
Gabor Horvath28690922015-08-26 23:17:43 +0000594 getNullabilityAnnotation(ArgExpr->getType());
595
596 if (Filter.CheckNullPassedToNonnull && Nullness == NullConstraint::IsNull &&
Devin Coughlin755baa42015-12-29 17:40:49 +0000597 ArgExprTypeLevelNullability != Nullability::Nonnull &&
598 RequiredNullability == Nullability::Nonnull) {
Devin Coughline39bd402015-09-16 22:03:05 +0000599 ExplodedNode *N = C.generateErrorNode(State);
600 if (!N)
601 return;
Gabor Horvathb47128a2015-09-03 23:16:21 +0000602 reportBugIfPreconditionHolds(ErrorKind::NilPassedToNonnull, N, nullptr, C,
603 ArgExpr);
Gabor Horvath28690922015-08-26 23:17:43 +0000604 return;
605 }
606
607 const MemRegion *Region = getTrackRegion(*ArgSVal);
608 if (!Region)
609 continue;
610
611 const NullabilityState *TrackedNullability =
612 State->get<NullabilityMap>(Region);
613
614 if (TrackedNullability) {
615 if (Nullness == NullConstraint::IsNotNull ||
616 TrackedNullability->getValue() != Nullability::Nullable)
617 continue;
618
619 if (Filter.CheckNullablePassedToNonnull &&
Devin Coughlin755baa42015-12-29 17:40:49 +0000620 RequiredNullability == Nullability::Nonnull) {
Gabor Horvathb47128a2015-09-03 23:16:21 +0000621 ExplodedNode *N = C.addTransition(State);
622 reportBugIfPreconditionHolds(ErrorKind::NullablePassedToNonnull, N,
623 Region, C, ArgExpr, /*SuppressPath=*/true);
Gabor Horvath28690922015-08-26 23:17:43 +0000624 return;
625 }
626 if (Filter.CheckNullableDereferenced &&
627 Param->getType()->isReferenceType()) {
Gabor Horvathb47128a2015-09-03 23:16:21 +0000628 ExplodedNode *N = C.addTransition(State);
629 reportBugIfPreconditionHolds(ErrorKind::NullableDereferenced, N, Region,
630 C, ArgExpr, /*SuppressPath=*/true);
Gabor Horvath28690922015-08-26 23:17:43 +0000631 return;
632 }
633 continue;
634 }
635 // No tracked nullability yet.
Devin Coughlin755baa42015-12-29 17:40:49 +0000636 if (ArgExprTypeLevelNullability != Nullability::Nullable)
Gabor Horvath28690922015-08-26 23:17:43 +0000637 continue;
638 State = State->set<NullabilityMap>(
Devin Coughlin755baa42015-12-29 17:40:49 +0000639 Region, NullabilityState(ArgExprTypeLevelNullability, ArgExpr));
Gabor Horvath28690922015-08-26 23:17:43 +0000640 }
641 if (State != OrigState)
642 C.addTransition(State);
643}
644
645/// Suppress the nullability warnings for some functions.
646void NullabilityChecker::checkPostCall(const CallEvent &Call,
647 CheckerContext &C) const {
648 auto Decl = Call.getDecl();
649 if (!Decl)
650 return;
651 // ObjC Messages handles in a different callback.
652 if (Call.getKind() == CE_ObjCMessage)
653 return;
654 const FunctionType *FuncType = Decl->getFunctionType();
655 if (!FuncType)
656 return;
657 QualType ReturnType = FuncType->getReturnType();
658 if (!ReturnType->isAnyPointerType())
659 return;
Gabor Horvathb47128a2015-09-03 23:16:21 +0000660 ProgramStateRef State = C.getState();
661 if (State->get<PreconditionViolated>())
662 return;
663
Gabor Horvath28690922015-08-26 23:17:43 +0000664 const MemRegion *Region = getTrackRegion(Call.getReturnValue());
665 if (!Region)
666 return;
Gabor Horvath28690922015-08-26 23:17:43 +0000667
668 // CG headers are misannotated. Do not warn for symbols that are the results
669 // of CG calls.
670 const SourceManager &SM = C.getSourceManager();
671 StringRef FilePath = SM.getFilename(SM.getSpellingLoc(Decl->getLocStart()));
672 if (llvm::sys::path::filename(FilePath).startswith("CG")) {
673 State = State->set<NullabilityMap>(Region, Nullability::Contradicted);
674 C.addTransition(State);
675 return;
676 }
677
678 const NullabilityState *TrackedNullability =
679 State->get<NullabilityMap>(Region);
680
681 if (!TrackedNullability &&
682 getNullabilityAnnotation(ReturnType) == Nullability::Nullable) {
683 State = State->set<NullabilityMap>(Region, Nullability::Nullable);
684 C.addTransition(State);
685 }
686}
687
688static Nullability getReceiverNullability(const ObjCMethodCall &M,
689 ProgramStateRef State) {
Gabor Horvath28690922015-08-26 23:17:43 +0000690 if (M.isReceiverSelfOrSuper()) {
691 // For super and super class receivers we assume that the receiver is
692 // nonnull.
Gabor Horvath3943adb2015-09-11 16:29:05 +0000693 return Nullability::Nonnull;
Gabor Horvath28690922015-08-26 23:17:43 +0000694 }
Gabor Horvath3943adb2015-09-11 16:29:05 +0000695 // Otherwise look up nullability in the state.
696 SVal Receiver = M.getReceiverSVal();
697 if (auto DefOrUnknown = Receiver.getAs<DefinedOrUnknownSVal>()) {
698 // If the receiver is constrained to be nonnull, assume that it is nonnull
699 // regardless of its type.
700 NullConstraint Nullness = getNullConstraint(*DefOrUnknown, State);
701 if (Nullness == NullConstraint::IsNotNull)
702 return Nullability::Nonnull;
703 }
704 auto ValueRegionSVal = Receiver.getAs<loc::MemRegionVal>();
705 if (ValueRegionSVal) {
706 const MemRegion *SelfRegion = ValueRegionSVal->getRegion();
707 assert(SelfRegion);
708
709 const NullabilityState *TrackedSelfNullability =
710 State->get<NullabilityMap>(SelfRegion);
711 if (TrackedSelfNullability)
712 return TrackedSelfNullability->getValue();
713 }
714 return Nullability::Unspecified;
Gabor Horvath28690922015-08-26 23:17:43 +0000715}
716
717/// Calculate the nullability of the result of a message expr based on the
718/// nullability of the receiver, the nullability of the return value, and the
719/// constraints.
720void NullabilityChecker::checkPostObjCMessage(const ObjCMethodCall &M,
721 CheckerContext &C) const {
722 auto Decl = M.getDecl();
723 if (!Decl)
724 return;
725 QualType RetType = Decl->getReturnType();
726 if (!RetType->isAnyPointerType())
727 return;
728
Gabor Horvathb47128a2015-09-03 23:16:21 +0000729 ProgramStateRef State = C.getState();
730 if (State->get<PreconditionViolated>())
731 return;
732
Gabor Horvath28690922015-08-26 23:17:43 +0000733 const MemRegion *ReturnRegion = getTrackRegion(M.getReturnValue());
734 if (!ReturnRegion)
735 return;
736
Gabor Horvath28690922015-08-26 23:17:43 +0000737 auto Interface = Decl->getClassInterface();
738 auto Name = Interface ? Interface->getName() : "";
739 // In order to reduce the noise in the diagnostics generated by this checker,
740 // some framework and programming style based heuristics are used. These
741 // heuristics are for Cocoa APIs which have NS prefix.
742 if (Name.startswith("NS")) {
743 // Developers rely on dynamic invariants such as an item should be available
744 // in a collection, or a collection is not empty often. Those invariants can
745 // not be inferred by any static analysis tool. To not to bother the users
746 // with too many false positives, every item retrieval function should be
747 // ignored for collections. The instance methods of dictionaries in Cocoa
748 // are either item retrieval related or not interesting nullability wise.
749 // Using this fact, to keep the code easier to read just ignore the return
750 // value of every instance method of dictionaries.
751 if (M.isInstanceMessage() && Name.find("Dictionary") != StringRef::npos) {
752 State =
753 State->set<NullabilityMap>(ReturnRegion, Nullability::Contradicted);
754 C.addTransition(State);
755 return;
756 }
757 // For similar reasons ignore some methods of Cocoa arrays.
758 StringRef FirstSelectorSlot = M.getSelector().getNameForSlot(0);
759 if (Name.find("Array") != StringRef::npos &&
760 (FirstSelectorSlot == "firstObject" ||
761 FirstSelectorSlot == "lastObject")) {
762 State =
763 State->set<NullabilityMap>(ReturnRegion, Nullability::Contradicted);
764 C.addTransition(State);
765 return;
766 }
767
768 // Encoding related methods of string should not fail when lossless
769 // encodings are used. Using lossless encodings is so frequent that ignoring
770 // this class of methods reduced the emitted diagnostics by about 30% on
771 // some projects (and all of that was false positives).
772 if (Name.find("String") != StringRef::npos) {
773 for (auto Param : M.parameters()) {
774 if (Param->getName() == "encoding") {
775 State = State->set<NullabilityMap>(ReturnRegion,
776 Nullability::Contradicted);
777 C.addTransition(State);
778 return;
779 }
780 }
781 }
782 }
783
784 const ObjCMessageExpr *Message = M.getOriginExpr();
785 Nullability SelfNullability = getReceiverNullability(M, State);
786
787 const NullabilityState *NullabilityOfReturn =
788 State->get<NullabilityMap>(ReturnRegion);
789
790 if (NullabilityOfReturn) {
791 // When we have a nullability tracked for the return value, the nullability
792 // of the expression will be the most nullable of the receiver and the
793 // return value.
794 Nullability RetValTracked = NullabilityOfReturn->getValue();
795 Nullability ComputedNullab =
796 getMostNullable(RetValTracked, SelfNullability);
797 if (ComputedNullab != RetValTracked &&
798 ComputedNullab != Nullability::Unspecified) {
799 const Stmt *NullabilitySource =
800 ComputedNullab == RetValTracked
801 ? NullabilityOfReturn->getNullabilitySource()
802 : Message->getInstanceReceiver();
803 State = State->set<NullabilityMap>(
804 ReturnRegion, NullabilityState(ComputedNullab, NullabilitySource));
805 C.addTransition(State);
806 }
807 return;
808 }
809
810 // No tracked information. Use static type information for return value.
811 Nullability RetNullability = getNullabilityAnnotation(RetType);
812
813 // Properties might be computed. For this reason the static analyzer creates a
814 // new symbol each time an unknown property is read. To avoid false pozitives
815 // do not treat unknown properties as nullable, even when they explicitly
816 // marked nullable.
817 if (M.getMessageKind() == OCM_PropertyAccess && !C.wasInlined)
818 RetNullability = Nullability::Nonnull;
819
820 Nullability ComputedNullab = getMostNullable(RetNullability, SelfNullability);
821 if (ComputedNullab == Nullability::Nullable) {
822 const Stmt *NullabilitySource = ComputedNullab == RetNullability
823 ? Message
824 : Message->getInstanceReceiver();
825 State = State->set<NullabilityMap>(
826 ReturnRegion, NullabilityState(ComputedNullab, NullabilitySource));
827 C.addTransition(State);
828 }
829}
830
831/// Explicit casts are trusted. If there is a disagreement in the nullability
832/// annotations in the destination and the source or '0' is casted to nonnull
833/// track the value as having contraditory nullability. This will allow users to
834/// suppress warnings.
835void NullabilityChecker::checkPostStmt(const ExplicitCastExpr *CE,
836 CheckerContext &C) const {
837 QualType OriginType = CE->getSubExpr()->getType();
838 QualType DestType = CE->getType();
839 if (!OriginType->isAnyPointerType())
840 return;
841 if (!DestType->isAnyPointerType())
842 return;
843
Gabor Horvathb47128a2015-09-03 23:16:21 +0000844 ProgramStateRef State = C.getState();
845 if (State->get<PreconditionViolated>())
846 return;
847
Gabor Horvath28690922015-08-26 23:17:43 +0000848 Nullability DestNullability = getNullabilityAnnotation(DestType);
849
850 // No explicit nullability in the destination type, so this cast does not
851 // change the nullability.
852 if (DestNullability == Nullability::Unspecified)
853 return;
854
Gabor Horvath28690922015-08-26 23:17:43 +0000855 auto RegionSVal =
856 State->getSVal(CE, C.getLocationContext()).getAs<DefinedOrUnknownSVal>();
857 const MemRegion *Region = getTrackRegion(*RegionSVal);
858 if (!Region)
859 return;
860
861 // When 0 is converted to nonnull mark it as contradicted.
862 if (DestNullability == Nullability::Nonnull) {
863 NullConstraint Nullness = getNullConstraint(*RegionSVal, State);
864 if (Nullness == NullConstraint::IsNull) {
865 State = State->set<NullabilityMap>(Region, Nullability::Contradicted);
866 C.addTransition(State);
867 return;
868 }
869 }
870
871 const NullabilityState *TrackedNullability =
872 State->get<NullabilityMap>(Region);
873
874 if (!TrackedNullability) {
875 if (DestNullability != Nullability::Nullable)
876 return;
877 State = State->set<NullabilityMap>(Region,
878 NullabilityState(DestNullability, CE));
879 C.addTransition(State);
880 return;
881 }
882
883 if (TrackedNullability->getValue() != DestNullability &&
884 TrackedNullability->getValue() != Nullability::Contradicted) {
885 State = State->set<NullabilityMap>(Region, Nullability::Contradicted);
886 C.addTransition(State);
887 }
888}
889
Devin Coughlinc1986632015-11-24 19:15:11 +0000890/// For a given statement performing a bind, attempt to syntactically
891/// match the expression resulting in the bound value.
892static const Expr * matchValueExprForBind(const Stmt *S) {
893 // For `x = e` the value expression is the right-hand side.
894 if (auto *BinOp = dyn_cast<BinaryOperator>(S)) {
895 if (BinOp->getOpcode() == BO_Assign)
896 return BinOp->getRHS();
897 }
898
899 // For `int x = e` the value expression is the initializer.
900 if (auto *DS = dyn_cast<DeclStmt>(S)) {
901 if (DS->isSingleDecl()) {
902 auto *VD = dyn_cast<VarDecl>(DS->getSingleDecl());
903 if (!VD)
904 return nullptr;
905
906 if (const Expr *Init = VD->getInit())
907 return Init;
908 }
909 }
910
911 return nullptr;
912}
913
Devin Coughlin3ab8b2e72015-12-29 23:44:19 +0000914/// Returns true if \param S is a DeclStmt for a local variable that
915/// ObjC automated reference counting initialized with zero.
916static bool isARCNilInitializedLocal(CheckerContext &C, const Stmt *S) {
917 // We suppress diagnostics for ARC zero-initialized _Nonnull locals. This
918 // prevents false positives when a _Nonnull local variable cannot be
919 // initialized with an initialization expression:
920 // NSString * _Nonnull s; // no-warning
921 // @autoreleasepool {
922 // s = ...
923 // }
924 //
925 // FIXME: We should treat implicitly zero-initialized _Nonnull locals as
926 // uninitialized in Sema's UninitializedValues analysis to warn when a use of
927 // the zero-initialized definition will unexpectedly yield nil.
928
929 // Locals are only zero-initialized when automated reference counting
930 // is turned on.
931 if (!C.getASTContext().getLangOpts().ObjCAutoRefCount)
932 return false;
933
934 auto *DS = dyn_cast<DeclStmt>(S);
935 if (!DS || !DS->isSingleDecl())
936 return false;
937
938 auto *VD = dyn_cast<VarDecl>(DS->getSingleDecl());
939 if (!VD)
940 return false;
941
942 // Sema only zero-initializes locals with ObjCLifetimes.
943 if(!VD->getType().getQualifiers().hasObjCLifetime())
944 return false;
945
946 const Expr *Init = VD->getInit();
947 assert(Init && "ObjC local under ARC without initializer");
948
949 // Return false if the local is explicitly initialized (e.g., with '= nil').
950 if (!isa<ImplicitValueInitExpr>(Init))
951 return false;
952
953 return true;
954}
955
Gabor Horvath28690922015-08-26 23:17:43 +0000956/// Propagate the nullability information through binds and warn when nullable
957/// pointer or null symbol is assigned to a pointer with a nonnull type.
958void NullabilityChecker::checkBind(SVal L, SVal V, const Stmt *S,
959 CheckerContext &C) const {
960 const TypedValueRegion *TVR =
961 dyn_cast_or_null<TypedValueRegion>(L.getAsRegion());
962 if (!TVR)
963 return;
964
965 QualType LocType = TVR->getValueType();
966 if (!LocType->isAnyPointerType())
967 return;
968
Gabor Horvathb47128a2015-09-03 23:16:21 +0000969 ProgramStateRef State = C.getState();
970 if (State->get<PreconditionViolated>())
971 return;
972
Gabor Horvath28690922015-08-26 23:17:43 +0000973 auto ValDefOrUnknown = V.getAs<DefinedOrUnknownSVal>();
974 if (!ValDefOrUnknown)
975 return;
976
Gabor Horvath28690922015-08-26 23:17:43 +0000977 NullConstraint RhsNullness = getNullConstraint(*ValDefOrUnknown, State);
978
979 Nullability ValNullability = Nullability::Unspecified;
980 if (SymbolRef Sym = ValDefOrUnknown->getAsSymbol())
981 ValNullability = getNullabilityAnnotation(Sym->getType());
982
983 Nullability LocNullability = getNullabilityAnnotation(LocType);
984 if (Filter.CheckNullPassedToNonnull &&
985 RhsNullness == NullConstraint::IsNull &&
986 ValNullability != Nullability::Nonnull &&
Devin Coughlin3ab8b2e72015-12-29 23:44:19 +0000987 LocNullability == Nullability::Nonnull &&
988 !isARCNilInitializedLocal(C, S)) {
Gabor Horvath28690922015-08-26 23:17:43 +0000989 static CheckerProgramPointTag Tag(this, "NullPassedToNonnull");
Devin Coughline39bd402015-09-16 22:03:05 +0000990 ExplodedNode *N = C.generateErrorNode(State, &Tag);
991 if (!N)
992 return;
Devin Coughlinc1986632015-11-24 19:15:11 +0000993
994 const Stmt *ValueExpr = matchValueExprForBind(S);
995 if (!ValueExpr)
996 ValueExpr = S;
997
Gabor Horvathb47128a2015-09-03 23:16:21 +0000998 reportBugIfPreconditionHolds(ErrorKind::NilAssignedToNonnull, N, nullptr, C,
Devin Coughlinc1986632015-11-24 19:15:11 +0000999 ValueExpr);
Gabor Horvath28690922015-08-26 23:17:43 +00001000 return;
1001 }
1002 // Intentionally missing case: '0' is bound to a reference. It is handled by
1003 // the DereferenceChecker.
1004
1005 const MemRegion *ValueRegion = getTrackRegion(*ValDefOrUnknown);
1006 if (!ValueRegion)
1007 return;
1008
1009 const NullabilityState *TrackedNullability =
1010 State->get<NullabilityMap>(ValueRegion);
1011
1012 if (TrackedNullability) {
1013 if (RhsNullness == NullConstraint::IsNotNull ||
1014 TrackedNullability->getValue() != Nullability::Nullable)
1015 return;
1016 if (Filter.CheckNullablePassedToNonnull &&
1017 LocNullability == Nullability::Nonnull) {
1018 static CheckerProgramPointTag Tag(this, "NullablePassedToNonnull");
1019 ExplodedNode *N = C.addTransition(State, C.getPredecessor(), &Tag);
Gabor Horvathb47128a2015-09-03 23:16:21 +00001020 reportBugIfPreconditionHolds(ErrorKind::NullableAssignedToNonnull, N,
1021 ValueRegion, C);
Gabor Horvath28690922015-08-26 23:17:43 +00001022 }
1023 return;
1024 }
1025
1026 const auto *BinOp = dyn_cast<BinaryOperator>(S);
1027
1028 if (ValNullability == Nullability::Nullable) {
1029 // Trust the static information of the value more than the static
1030 // information on the location.
1031 const Stmt *NullabilitySource = BinOp ? BinOp->getRHS() : S;
1032 State = State->set<NullabilityMap>(
1033 ValueRegion, NullabilityState(ValNullability, NullabilitySource));
1034 C.addTransition(State);
1035 return;
1036 }
1037
1038 if (LocNullability == Nullability::Nullable) {
1039 const Stmt *NullabilitySource = BinOp ? BinOp->getLHS() : S;
1040 State = State->set<NullabilityMap>(
1041 ValueRegion, NullabilityState(LocNullability, NullabilitySource));
1042 C.addTransition(State);
1043 }
1044}
1045
1046void NullabilityChecker::printState(raw_ostream &Out, ProgramStateRef State,
1047 const char *NL, const char *Sep) const {
1048
1049 NullabilityMapTy B = State->get<NullabilityMap>();
1050
1051 if (B.isEmpty())
1052 return;
1053
1054 Out << Sep << NL;
1055
1056 for (NullabilityMapTy::iterator I = B.begin(), E = B.end(); I != E; ++I) {
1057 Out << I->first << " : ";
1058 I->second.print(Out);
1059 Out << NL;
1060 }
1061}
1062
Gabor Horvath29307352015-09-14 18:31:34 +00001063#define REGISTER_CHECKER(name, trackingRequired) \
Gabor Horvath28690922015-08-26 23:17:43 +00001064 void ento::register##name##Checker(CheckerManager &mgr) { \
1065 NullabilityChecker *checker = mgr.registerChecker<NullabilityChecker>(); \
1066 checker->Filter.Check##name = true; \
1067 checker->Filter.CheckName##name = mgr.getCurrentCheckName(); \
Gabor Horvath29307352015-09-14 18:31:34 +00001068 checker->NeedTracking = checker->NeedTracking || trackingRequired; \
Gabor Horvath28690922015-08-26 23:17:43 +00001069 }
1070
Gabor Horvath29307352015-09-14 18:31:34 +00001071// The checks are likely to be turned on by default and it is possible to do
1072// them without tracking any nullability related information. As an optimization
1073// no nullability information will be tracked when only these two checks are
1074// enables.
1075REGISTER_CHECKER(NullPassedToNonnull, false)
1076REGISTER_CHECKER(NullReturnedFromNonnull, false)
1077
1078REGISTER_CHECKER(NullableDereferenced, true)
1079REGISTER_CHECKER(NullablePassedToNonnull, true)
1080REGISTER_CHECKER(NullableReturnedFromNonnull, true)