blob: 95825991cee96ef54113a21d7903fd2664db8f4a [file] [log] [blame]
Chris Lattnerb03832d2002-09-24 00:08:39 +00001//===- BreakCriticalEdges.cpp - Critical Edge Elimination Pass ------------===//
Misha Brukmanb1c93172005-04-21 23:48:37 +00002//
John Criswell482202a2003-10-20 19:43:21 +00003// The LLVM Compiler Infrastructure
4//
Chris Lattnerf3ebc3f2007-12-29 20:36:04 +00005// This file is distributed under the University of Illinois Open Source
6// License. See LICENSE.TXT for details.
Misha Brukmanb1c93172005-04-21 23:48:37 +00007//
John Criswell482202a2003-10-20 19:43:21 +00008//===----------------------------------------------------------------------===//
Chris Lattnerb03832d2002-09-24 00:08:39 +00009//
10// BreakCriticalEdges pass - Break all of the critical edges in the CFG by
11// inserting a dummy basic block. This pass may be "required" by passes that
12// cannot deal with critical edges. For this usage, the structure type is
13// forward declared. This pass obviously invalidates the CFG, but can update
Cameron Zwarichb7036542011-01-18 04:11:31 +000014// dominator trees.
Chris Lattnerb03832d2002-09-24 00:08:39 +000015//
16//===----------------------------------------------------------------------===//
17
18#include "llvm/Transforms/Scalar.h"
Chandler Carruthed0881b2012-12-03 16:50:05 +000019#include "llvm/ADT/SmallVector.h"
20#include "llvm/ADT/Statistic.h"
Chandler Carruthb5797b62015-01-18 09:21:15 +000021#include "llvm/Analysis/AliasAnalysis.h"
Nick Lewycky0b682452013-07-27 01:24:00 +000022#include "llvm/Analysis/CFG.h"
Chris Lattner89c1dfc2005-08-13 01:38:43 +000023#include "llvm/Analysis/LoopInfo.h"
Chandler Carruth1305dc32014-03-04 11:45:46 +000024#include "llvm/IR/CFG.h"
Chandler Carruth5ad5f152014-01-13 09:26:24 +000025#include "llvm/IR/Dominators.h"
Chandler Carruth9fb823b2013-01-02 11:36:10 +000026#include "llvm/IR/Function.h"
27#include "llvm/IR/Instructions.h"
28#include "llvm/IR/Type.h"
Torok Edwin56d06592009-07-11 20:10:48 +000029#include "llvm/Support/ErrorHandling.h"
Chandler Carruthed0881b2012-12-03 16:50:05 +000030#include "llvm/Transforms/Utils/BasicBlockUtils.h"
Chris Lattnerdf3c3422004-01-09 06:12:26 +000031using namespace llvm;
Brian Gaeke960707c2003-11-11 22:41:34 +000032
Chandler Carruth964daaa2014-04-22 02:55:47 +000033#define DEBUG_TYPE "break-crit-edges"
34
Chris Lattner45f966d2006-12-19 22:17:40 +000035STATISTIC(NumBroken, "Number of blocks inserted");
Chris Lattnerb03832d2002-09-24 00:08:39 +000036
Chris Lattner45f966d2006-12-19 22:17:40 +000037namespace {
Nick Lewycky02d5f772009-10-25 06:33:48 +000038 struct BreakCriticalEdges : public FunctionPass {
Nick Lewyckye7da2d62007-05-06 13:37:16 +000039 static char ID; // Pass identification, replacement for typeid
Owen Anderson6c18d1a2010-10-19 17:21:58 +000040 BreakCriticalEdges() : FunctionPass(ID) {
41 initializeBreakCriticalEdgesPass(*PassRegistry::getPassRegistry());
42 }
Devang Patel09f162c2007-05-01 21:15:47 +000043
Kostya Serebryanye5ea4242014-11-19 00:17:31 +000044 bool runOnFunction(Function &F) override {
Chandler Carruth37df2cf2015-01-19 12:09:11 +000045 auto *DTWP = getAnalysisIfAvailable<DominatorTreeWrapperPass>();
46 auto *DT = DTWP ? &DTWP->getDomTree() : nullptr;
47 auto *LIWP = getAnalysisIfAvailable<LoopInfoWrapperPass>();
48 auto *LI = LIWP ? &LIWP->getLoopInfo() : nullptr;
49 unsigned N =
50 SplitAllCriticalEdges(F, CriticalEdgeSplittingOptions(DT, LI));
Kostya Serebryanye5ea4242014-11-19 00:17:31 +000051 NumBroken += N;
52 return N > 0;
53 }
Misha Brukmanb1c93172005-04-21 23:48:37 +000054
Craig Topper3e4c6972014-03-05 09:10:37 +000055 void getAnalysisUsage(AnalysisUsage &AU) const override {
Chandler Carruth73523022014-01-13 13:07:17 +000056 AU.addPreserved<DominatorTreeWrapperPass>();
Chandler Carruth4f8f3072015-01-17 14:16:18 +000057 AU.addPreserved<LoopInfoWrapperPass>();
Chris Lattner72272a72003-10-12 21:52:28 +000058
59 // No loop canonicalization guarantees are broken by this pass.
60 AU.addPreservedID(LoopSimplifyID);
Chris Lattner4bec6652002-09-24 15:43:12 +000061 }
62 };
Alexander Kornienkof00654e2015-06-23 09:49:53 +000063}
Chris Lattnerb03832d2002-09-24 00:08:39 +000064
Dan Gohmand78c4002008-05-13 00:00:25 +000065char BreakCriticalEdges::ID = 0;
Owen Andersond31d82d2010-08-23 17:52:01 +000066INITIALIZE_PASS(BreakCriticalEdges, "break-crit-edges",
Owen Andersondf7a4f22010-10-07 22:25:06 +000067 "Break critical edges in CFG", false, false)
Dan Gohmand78c4002008-05-13 00:00:25 +000068
Chris Lattner0ab5e2c2011-04-15 05:18:47 +000069// Publicly exposed interface to pass...
Owen Andersona7aed182010-08-06 18:33:48 +000070char &llvm::BreakCriticalEdgesID = BreakCriticalEdges::ID;
Chris Lattner7471b962004-07-31 10:01:58 +000071FunctionPass *llvm::createBreakCriticalEdgesPass() {
72 return new BreakCriticalEdges();
73}
Chris Lattnerb03832d2002-09-24 00:08:39 +000074
Chris Lattner1e6d3052003-11-10 04:42:42 +000075//===----------------------------------------------------------------------===//
76// Implementation of the external critical edge manipulation functions
77//===----------------------------------------------------------------------===//
Chris Lattner75f80bd2002-09-24 15:51:56 +000078
Bill Wendling325e6cd2012-04-30 10:25:51 +000079/// createPHIsForSplitLoopExit - When a loop exit edge is split, LCSSA form
Dan Gohmanec4557f2009-09-09 18:18:18 +000080/// may require new PHIs in the new exit block. This function inserts the
Bill Wendlingbf4b9af2012-04-30 10:44:54 +000081/// new PHIs, as needed. Preds is a list of preds inside the loop, SplitBB
Dan Gohmanec4557f2009-09-09 18:18:18 +000082/// is the new loop exit block, and DestBB is the old loop exit, now the
83/// successor of SplitBB.
Bill Wendling325e6cd2012-04-30 10:25:51 +000084static void createPHIsForSplitLoopExit(ArrayRef<BasicBlock *> Preds,
Dan Gohmanec4557f2009-09-09 18:18:18 +000085 BasicBlock *SplitBB,
86 BasicBlock *DestBB) {
87 // SplitBB shouldn't have anything non-trivial in it yet.
Bill Wendlingbf4b9af2012-04-30 10:44:54 +000088 assert((SplitBB->getFirstNonPHI() == SplitBB->getTerminator() ||
89 SplitBB->isLandingPad()) && "SplitBB has non-PHI nodes!");
Dan Gohmanec4557f2009-09-09 18:18:18 +000090
Bill Wendlingbf4b9af2012-04-30 10:44:54 +000091 // For each PHI in the destination block.
Dan Gohmanec4557f2009-09-09 18:18:18 +000092 for (BasicBlock::iterator I = DestBB->begin();
93 PHINode *PN = dyn_cast<PHINode>(I); ++I) {
94 unsigned Idx = PN->getBasicBlockIndex(SplitBB);
95 Value *V = PN->getIncomingValue(Idx);
Bill Wendlingbf4b9af2012-04-30 10:44:54 +000096
Dan Gohmanec4557f2009-09-09 18:18:18 +000097 // If the input is a PHI which already satisfies LCSSA, don't create
98 // a new one.
99 if (const PHINode *VP = dyn_cast<PHINode>(V))
100 if (VP->getParent() == SplitBB)
101 continue;
Bill Wendlingbf4b9af2012-04-30 10:44:54 +0000102
Dan Gohmanec4557f2009-09-09 18:18:18 +0000103 // Otherwise a new PHI is needed. Create one and populate it.
Duncan P. N. Exon Smith5b4c8372015-10-13 02:39:05 +0000104 PHINode *NewPN = PHINode::Create(
105 PN->getType(), Preds.size(), "split",
106 SplitBB->isLandingPad() ? &SplitBB->front() : SplitBB->getTerminator());
Dan Gohmanec4557f2009-09-09 18:18:18 +0000107 for (unsigned i = 0, e = Preds.size(); i != e; ++i)
108 NewPN->addIncoming(V, Preds[i]);
Bill Wendlingbf4b9af2012-04-30 10:44:54 +0000109
Dan Gohmanec4557f2009-09-09 18:18:18 +0000110 // Update the original PHI.
111 PN->setIncomingValue(Idx, NewPN);
112 }
113}
114
Chris Lattner38806c32008-04-21 00:19:16 +0000115/// SplitCriticalEdge - If this edge is a critical edge, insert a new node to
Cameron Zwarichb7036542011-01-18 04:11:31 +0000116/// split the critical edge. This will update DominatorTree information if it
117/// is available, thus calling this pass will not invalidate either of them.
118/// This returns the new block if the edge was split, null otherwise.
Chris Lattnerba364b02009-10-31 21:51:10 +0000119///
120/// If MergeIdenticalEdges is true (not the default), *all* edges from TI to the
Andrew Trick411842f2011-10-04 03:34:49 +0000121/// specified successor will be merged into the same critical edge block.
122/// This is most commonly interesting with switch instructions, which may
Chris Lattnerba364b02009-10-31 21:51:10 +0000123/// have many edges to any one destination. This ensures that all edges to that
Andrew Trick411842f2011-10-04 03:34:49 +0000124/// dest go to one block instead of each going to a different block, but isn't
Chris Lattnerba364b02009-10-31 21:51:10 +0000125/// the standard definition of a "critical edge".
126///
127/// It is invalid to call this function on a critical edge that starts at an
128/// IndirectBrInst. Splitting these edges will almost always create an invalid
Chris Lattner249f96e2009-11-01 18:17:37 +0000129/// program because the address of the new block won't be the one that is jumped
Chris Lattnerba364b02009-10-31 21:51:10 +0000130/// to.
131///
Dan Gohman3ddbc242009-09-08 15:45:00 +0000132BasicBlock *llvm::SplitCriticalEdge(TerminatorInst *TI, unsigned SuccNum,
Chandler Carruth37df2cf2015-01-19 12:09:11 +0000133 const CriticalEdgeSplittingOptions &Options) {
134 if (!isCriticalEdge(TI, SuccNum, Options.MergeIdenticalEdges))
135 return nullptr;
Andrew Trick411842f2011-10-04 03:34:49 +0000136
Chris Lattnerba364b02009-10-31 21:51:10 +0000137 assert(!isa<IndirectBrInst>(TI) &&
138 "Cannot split critical edge from IndirectBrInst");
Andrew Trick411842f2011-10-04 03:34:49 +0000139
Chris Lattner75f80bd2002-09-24 15:51:56 +0000140 BasicBlock *TIBB = TI->getParent();
Chris Lattner12764c82002-10-31 02:44:36 +0000141 BasicBlock *DestBB = TI->getSuccessor(SuccNum);
Chris Lattner75f80bd2002-09-24 15:51:56 +0000142
David Majnemereb518bd2015-08-04 08:21:40 +0000143 // Splitting the critical edge to a pad block is non-trivial. Don't do
Bill Wendling2dfbcc42011-08-17 21:04:05 +0000144 // it in this generic function.
David Majnemereb518bd2015-08-04 08:21:40 +0000145 if (DestBB->isEHPad()) return nullptr;
Bill Wendling2dfbcc42011-08-17 21:04:05 +0000146
Chris Lattner75f80bd2002-09-24 15:51:56 +0000147 // Create a new basic block, linking it into the CFG.
Owen Anderson55f1c092009-08-13 21:58:54 +0000148 BasicBlock *NewBB = BasicBlock::Create(TI->getContext(),
149 TIBB->getName() + "." + DestBB->getName() + "_crit_edge");
Chris Lattner72c4dce2010-02-13 04:24:19 +0000150 // Create our unconditional branch.
Devang Patelc23bcbc2011-05-17 19:43:06 +0000151 BranchInst *NewBI = BranchInst::Create(DestBB, NewBB);
152 NewBI->setDebugLoc(TI->getDebugLoc());
Misha Brukmanb1c93172005-04-21 23:48:37 +0000153
Chris Lattner80ea2072006-10-28 06:44:56 +0000154 // Branch to the new block, breaking the edge.
Chris Lattner75f80bd2002-09-24 15:51:56 +0000155 TI->setSuccessor(SuccNum, NewBB);
156
157 // Insert the block into the function... right after the block TI lives in.
158 Function &F = *TIBB->getParent();
Duncan P. N. Exon Smith5b4c8372015-10-13 02:39:05 +0000159 Function::iterator FBBI = TIBB->getIterator();
Chris Lattner233f97a2007-04-17 18:09:47 +0000160 F.getBasicBlockList().insert(++FBBI, NewBB);
Andrew Trick411842f2011-10-04 03:34:49 +0000161
Chris Lattner75f80bd2002-09-24 15:51:56 +0000162 // If there are any PHI nodes in DestBB, we need to update them so that they
163 // merge incoming values from NewBB instead of from TIBB.
Jay Foad61ea0e42011-06-23 09:09:15 +0000164 {
165 unsigned BBIdx = 0;
166 for (BasicBlock::iterator I = DestBB->begin(); isa<PHINode>(I); ++I) {
167 // We no longer enter through TIBB, now we come in through NewBB.
168 // Revector exactly one entry in the PHI node that used to come from
169 // TIBB to come from NewBB.
170 PHINode *PN = cast<PHINode>(I);
171
172 // Reuse the previous value of BBIdx if it lines up. In cases where we
173 // have multiple phi nodes with *lots* of predecessors, this is a speed
174 // win because we don't have to scan the PHI looking for TIBB. This
175 // happens because the BB list of PHI nodes are usually in the same
176 // order.
177 if (PN->getIncomingBlock(BBIdx) != TIBB)
Andrew Trick411842f2011-10-04 03:34:49 +0000178 BBIdx = PN->getBasicBlockIndex(TIBB);
Jay Foad61ea0e42011-06-23 09:09:15 +0000179 PN->setIncomingBlock(BBIdx, NewBB);
Chris Lattner5e7f7052010-02-13 05:01:14 +0000180 }
Chris Lattner75f80bd2002-09-24 15:51:56 +0000181 }
Andrew Trick411842f2011-10-04 03:34:49 +0000182
Chris Lattner80ea2072006-10-28 06:44:56 +0000183 // If there are any other edges from TIBB to DestBB, update those to go
184 // through the split block, making those edges non-critical as well (and
185 // reducing the number of phi entries in the DestBB if relevant).
Chandler Carruth37df2cf2015-01-19 12:09:11 +0000186 if (Options.MergeIdenticalEdges) {
Chris Lattner80ea2072006-10-28 06:44:56 +0000187 for (unsigned i = SuccNum+1, e = TI->getNumSuccessors(); i != e; ++i) {
188 if (TI->getSuccessor(i) != DestBB) continue;
Andrew Trick411842f2011-10-04 03:34:49 +0000189
Chris Lattner80ea2072006-10-28 06:44:56 +0000190 // Remove an entry for TIBB from DestBB phi nodes.
Chandler Carruth37df2cf2015-01-19 12:09:11 +0000191 DestBB->removePredecessor(TIBB, Options.DontDeleteUselessPHIs);
Andrew Trick411842f2011-10-04 03:34:49 +0000192
Chris Lattner80ea2072006-10-28 06:44:56 +0000193 // We found another edge to DestBB, go to NewBB instead.
194 TI->setSuccessor(i, NewBB);
195 }
196 }
Andrew Trick411842f2011-10-04 03:34:49 +0000197
Chris Lattner5e7f7052010-02-13 05:01:14 +0000198 // If we have nothing to update, just return.
Chandler Carruth37df2cf2015-01-19 12:09:11 +0000199 auto *DT = Options.DT;
200 auto *LI = Options.LI;
Craig Topperf40110f2014-04-25 05:29:35 +0000201 if (!DT && !LI)
Chris Lattner5e7f7052010-02-13 05:01:14 +0000202 return NewBB;
Chris Lattner5ac72de2002-10-08 21:06:27 +0000203
Chris Lattner8aca0ee2006-10-03 07:02:02 +0000204 // Now update analysis information. Since the only predecessor of NewBB is
205 // the TIBB, TIBB clearly dominates NewBB. TIBB usually doesn't dominate
206 // anything, as there are other successors of DestBB. However, if all other
207 // predecessors of DestBB are already dominated by DestBB (e.g. DestBB is a
208 // loop header) then NewBB dominates DestBB.
209 SmallVector<BasicBlock*, 8> OtherPreds;
Chris Lattner75f80bd2002-09-24 15:51:56 +0000210
Chris Lattnerb0ebb652010-02-13 04:15:26 +0000211 // If there is a PHI in the block, loop over predecessors with it, which is
212 // faster than iterating pred_begin/end.
213 if (PHINode *PN = dyn_cast<PHINode>(DestBB->begin())) {
214 for (unsigned i = 0, e = PN->getNumIncomingValues(); i != e; ++i)
215 if (PN->getIncomingBlock(i) != NewBB)
216 OtherPreds.push_back(PN->getIncomingBlock(i));
217 } else {
Duncan P. N. Exon Smith6c990152014-07-21 17:06:51 +0000218 for (pred_iterator I = pred_begin(DestBB), E = pred_end(DestBB);
219 I != E; ++I) {
220 BasicBlock *P = *I;
Gabor Greif6d8870f2010-07-09 15:25:42 +0000221 if (P != NewBB)
Chris Lattner90f3a9a2011-01-14 04:23:53 +0000222 OtherPreds.push_back(P);
Gabor Greif6d8870f2010-07-09 15:25:42 +0000223 }
Chris Lattnerb0ebb652010-02-13 04:15:26 +0000224 }
Gabor Greif6d8870f2010-07-09 15:25:42 +0000225
Chris Lattner8aca0ee2006-10-03 07:02:02 +0000226 bool NewBBDominatesDestBB = true;
Andrew Trick411842f2011-10-04 03:34:49 +0000227
Chris Lattnerbedbd6b2002-09-26 16:18:51 +0000228 // Should we update DominatorTree information?
Chris Lattner5e7f7052010-02-13 05:01:14 +0000229 if (DT) {
Devang Patelbdd1aae2007-06-04 00:32:22 +0000230 DomTreeNode *TINode = DT->getNode(TIBB);
Misha Brukmanb1c93172005-04-21 23:48:37 +0000231
Chris Lattnerbedbd6b2002-09-26 16:18:51 +0000232 // The new block is not the immediate dominator for any other nodes, but
233 // TINode is the immediate dominator for the new node.
234 //
Chris Lattner8aca0ee2006-10-03 07:02:02 +0000235 if (TINode) { // Don't break unreachable code!
Devang Patelebc5b962007-06-04 16:43:25 +0000236 DomTreeNode *NewBBNode = DT->addNewBlock(NewBB, TIBB);
Craig Topperf40110f2014-04-25 05:29:35 +0000237 DomTreeNode *DestBBNode = nullptr;
Andrew Trick411842f2011-10-04 03:34:49 +0000238
Chris Lattner8aca0ee2006-10-03 07:02:02 +0000239 // If NewBBDominatesDestBB hasn't been computed yet, do so with DT.
240 if (!OtherPreds.empty()) {
241 DestBBNode = DT->getNode(DestBB);
242 while (!OtherPreds.empty() && NewBBDominatesDestBB) {
Devang Patelbdd1aae2007-06-04 00:32:22 +0000243 if (DomTreeNode *OPNode = DT->getNode(OtherPreds.back()))
Devang Patelaf41e4a2007-06-07 17:47:21 +0000244 NewBBDominatesDestBB = DT->dominates(DestBBNode, OPNode);
Chris Lattner8aca0ee2006-10-03 07:02:02 +0000245 OtherPreds.pop_back();
246 }
247 OtherPreds.clear();
248 }
Andrew Trick411842f2011-10-04 03:34:49 +0000249
Chris Lattner8aca0ee2006-10-03 07:02:02 +0000250 // If NewBBDominatesDestBB, then NewBB dominates DestBB, otherwise it
251 // doesn't dominate anything.
252 if (NewBBDominatesDestBB) {
253 if (!DestBBNode) DestBBNode = DT->getNode(DestBB);
254 DT->changeImmediateDominator(DestBBNode, NewBBNode);
255 }
256 }
Chris Lattner75f80bd2002-09-24 15:51:56 +0000257 }
Chris Lattner12764c82002-10-31 02:44:36 +0000258
Chris Lattner89c1dfc2005-08-13 01:38:43 +0000259 // Update LoopInfo if it is around.
Chris Lattner5e7f7052010-02-13 05:01:14 +0000260 if (LI) {
Dan Gohman3ddbc242009-09-08 15:45:00 +0000261 if (Loop *TIL = LI->getLoopFor(TIBB)) {
262 // If one or the other blocks were not in a loop, the new block is not
263 // either, and thus LI doesn't need to be updated.
Chris Lattner89c1dfc2005-08-13 01:38:43 +0000264 if (Loop *DestLoop = LI->getLoopFor(DestBB)) {
265 if (TIL == DestLoop) {
266 // Both in the same loop, the NewBB joins loop.
Chandler Carruth691addc2015-01-18 01:25:51 +0000267 DestLoop->addBasicBlockToLoop(NewBB, *LI);
Dan Gohman18fa5682009-12-18 01:24:09 +0000268 } else if (TIL->contains(DestLoop)) {
Chris Lattner8aca0ee2006-10-03 07:02:02 +0000269 // Edge from an outer loop to an inner loop. Add to the outer loop.
Chandler Carruth691addc2015-01-18 01:25:51 +0000270 TIL->addBasicBlockToLoop(NewBB, *LI);
Dan Gohman18fa5682009-12-18 01:24:09 +0000271 } else if (DestLoop->contains(TIL)) {
Chris Lattner8aca0ee2006-10-03 07:02:02 +0000272 // Edge from an inner loop to an outer loop. Add to the outer loop.
Chandler Carruth691addc2015-01-18 01:25:51 +0000273 DestLoop->addBasicBlockToLoop(NewBB, *LI);
Chris Lattner89c1dfc2005-08-13 01:38:43 +0000274 } else {
275 // Edge from two loops with no containment relation. Because these
276 // are natural loops, we know that the destination block must be the
277 // header of its loop (adding a branch into a loop elsewhere would
278 // create an irreducible loop).
279 assert(DestLoop->getHeader() == DestBB &&
280 "Should not create irreducible loops!");
281 if (Loop *P = DestLoop->getParentLoop())
Chandler Carruth691addc2015-01-18 01:25:51 +0000282 P->addBasicBlockToLoop(NewBB, *LI);
Chris Lattner89c1dfc2005-08-13 01:38:43 +0000283 }
284 }
Chandler Carruthad34d912015-01-19 10:23:00 +0000285
Chandler Carruthd4be9dc2014-01-29 13:16:53 +0000286 // If TIBB is in a loop and DestBB is outside of that loop, we may need
287 // to update LoopSimplify form and LCSSA form.
Chandler Carruthad34d912015-01-19 10:23:00 +0000288 if (!TIL->contains(DestBB)) {
Dan Gohmanec4557f2009-09-09 18:18:18 +0000289 assert(!TIL->contains(NewBB) &&
290 "Split point for loop exit is contained in loop!");
291
292 // Update LCSSA form in the newly created exit block.
Chandler Carruth37df2cf2015-01-19 12:09:11 +0000293 if (Options.PreserveLCSSA) {
Bill Wendling325e6cd2012-04-30 10:25:51 +0000294 createPHIsForSplitLoopExit(TIBB, NewBB, DestBB);
Chandler Carruthad34d912015-01-19 10:23:00 +0000295 }
Dan Gohmanec4557f2009-09-09 18:18:18 +0000296
Chandler Carruthd4be9dc2014-01-29 13:16:53 +0000297 // The only that we can break LoopSimplify form by splitting a critical
298 // edge is if after the split there exists some edge from TIL to DestBB
299 // *and* the only edge into DestBB from outside of TIL is that of
300 // NewBB. If the first isn't true, then LoopSimplify still holds, NewBB
301 // is the new exit block and it has no non-loop predecessors. If the
302 // second isn't true, then DestBB was not in LoopSimplify form prior to
303 // the split as it had a non-loop predecessor. In both of these cases,
304 // the predecessor must be directly in TIL, not in a subloop, or again
305 // LoopSimplify doesn't hold.
306 SmallVector<BasicBlock *, 4> LoopPreds;
Duncan P. N. Exon Smith6c990152014-07-21 17:06:51 +0000307 for (pred_iterator I = pred_begin(DestBB), E = pred_end(DestBB); I != E;
308 ++I) {
309 BasicBlock *P = *I;
Chandler Carruthd4be9dc2014-01-29 13:16:53 +0000310 if (P == NewBB)
311 continue; // The new block is known.
312 if (LI->getLoopFor(P) != TIL) {
313 // No need to re-simplify, it wasn't to start with.
314 LoopPreds.clear();
315 break;
Gabor Greiffd8e7d42010-07-09 16:31:08 +0000316 }
Chandler Carruthd4be9dc2014-01-29 13:16:53 +0000317 LoopPreds.push_back(P);
318 }
319 if (!LoopPreds.empty()) {
David Majnemereb518bd2015-08-04 08:21:40 +0000320 assert(!DestBB->isEHPad() && "We don't split edges to EH pads!");
Chandler Carruthb5797b62015-01-18 09:21:15 +0000321 BasicBlock *NewExitBB = SplitBlockPredecessors(
Chandler Carruth96ada252015-07-22 09:52:54 +0000322 DestBB, LoopPreds, "split", DT, LI, Options.PreserveLCSSA);
Chandler Carruth37df2cf2015-01-19 12:09:11 +0000323 if (Options.PreserveLCSSA)
Chandler Carruthd4be9dc2014-01-29 13:16:53 +0000324 createPHIsForSplitLoopExit(LoopPreds, NewExitBB, DestBB);
Dan Gohman3ddbc242009-09-08 15:45:00 +0000325 }
326 }
Dan Gohman3ddbc242009-09-08 15:45:00 +0000327 }
Chris Lattner89c1dfc2005-08-13 01:38:43 +0000328 }
Dan Gohman3ddbc242009-09-08 15:45:00 +0000329
330 return NewBB;
Chris Lattner75f80bd2002-09-24 15:51:56 +0000331}