Sam Clegg | c94d393 | 2017-11-17 18:14:09 +0000 | [diff] [blame] | 1 | //===- SymbolTable.cpp ----------------------------------------------------===// |
| 2 | // |
| 3 | // The LLVM Linker |
| 4 | // |
| 5 | // This file is distributed under the University of Illinois Open Source |
| 6 | // License. See LICENSE.TXT for details. |
| 7 | // |
| 8 | //===----------------------------------------------------------------------===// |
| 9 | |
| 10 | #include "SymbolTable.h" |
Sam Clegg | c94d393 | 2017-11-17 18:14:09 +0000 | [diff] [blame] | 11 | #include "Config.h" |
Sam Clegg | 5fa274b | 2018-01-10 01:13:34 +0000 | [diff] [blame] | 12 | #include "InputChunks.h" |
Sam Clegg | 9310297 | 2018-02-23 05:08:53 +0000 | [diff] [blame] | 13 | #include "InputGlobal.h" |
Sam Clegg | b862159 | 2017-11-30 01:40:08 +0000 | [diff] [blame] | 14 | #include "WriterUtils.h" |
Sam Clegg | c94d393 | 2017-11-17 18:14:09 +0000 | [diff] [blame] | 15 | #include "lld/Common/ErrorHandler.h" |
Rui Ueyama | 2017d52 | 2017-11-28 20:39:17 +0000 | [diff] [blame] | 16 | #include "lld/Common/Memory.h" |
Rui Ueyama | 7d67dd1 | 2018-02-13 22:30:52 +0000 | [diff] [blame] | 17 | #include "llvm/ADT/SetVector.h" |
Sam Clegg | c94d393 | 2017-11-17 18:14:09 +0000 | [diff] [blame] | 18 | |
| 19 | #define DEBUG_TYPE "lld" |
| 20 | |
| 21 | using namespace llvm; |
Sam Clegg | 20db381 | 2018-01-10 00:52:20 +0000 | [diff] [blame] | 22 | using namespace llvm::wasm; |
Sam Clegg | c94d393 | 2017-11-17 18:14:09 +0000 | [diff] [blame] | 23 | using namespace lld; |
| 24 | using namespace lld::wasm; |
| 25 | |
| 26 | SymbolTable *lld::wasm::Symtab; |
| 27 | |
| 28 | void SymbolTable::addFile(InputFile *File) { |
| 29 | log("Processing: " + toString(File)); |
| 30 | File->parse(); |
| 31 | |
| 32 | if (auto *F = dyn_cast<ObjFile>(File)) |
| 33 | ObjectFiles.push_back(F); |
| 34 | } |
| 35 | |
| 36 | void SymbolTable::reportRemainingUndefines() { |
Rui Ueyama | 7d67dd1 | 2018-02-13 22:30:52 +0000 | [diff] [blame] | 37 | SetVector<Symbol *> Undefs; |
Sam Clegg | 74fe0ba | 2017-12-07 01:51:24 +0000 | [diff] [blame] | 38 | for (Symbol *Sym : SymVector) { |
Sam Clegg | c94d393 | 2017-11-17 18:14:09 +0000 | [diff] [blame] | 39 | if (Sym->isUndefined() && !Sym->isWeak() && |
| 40 | Config->AllowUndefinedSymbols.count(Sym->getName()) == 0) { |
| 41 | Undefs.insert(Sym); |
| 42 | } |
| 43 | } |
| 44 | |
| 45 | if (Undefs.empty()) |
| 46 | return; |
| 47 | |
| 48 | for (ObjFile *File : ObjectFiles) |
| 49 | for (Symbol *Sym : File->getSymbols()) |
| 50 | if (Undefs.count(Sym)) |
| 51 | error(toString(File) + ": undefined symbol: " + toString(*Sym)); |
| 52 | |
| 53 | for (Symbol *Sym : Undefs) |
| 54 | if (!Sym->getFile()) |
| 55 | error("undefined symbol: " + toString(*Sym)); |
| 56 | } |
| 57 | |
| 58 | Symbol *SymbolTable::find(StringRef Name) { |
Rui Ueyama | 67d6908 | 2018-02-28 23:03:06 +0000 | [diff] [blame] | 59 | return SymMap.lookup(CachedHashStringRef(Name)); |
Sam Clegg | c94d393 | 2017-11-17 18:14:09 +0000 | [diff] [blame] | 60 | } |
| 61 | |
| 62 | std::pair<Symbol *, bool> SymbolTable::insert(StringRef Name) { |
Sam Clegg | a80d94d | 2017-11-27 23:16:06 +0000 | [diff] [blame] | 63 | Symbol *&Sym = SymMap[CachedHashStringRef(Name)]; |
Sam Clegg | c94d393 | 2017-11-17 18:14:09 +0000 | [diff] [blame] | 64 | if (Sym) |
| 65 | return {Sym, false}; |
Sam Clegg | dfb0b2c | 2018-02-14 18:27:59 +0000 | [diff] [blame] | 66 | Sym = reinterpret_cast<Symbol *>(make<SymbolUnion>()); |
Sam Clegg | 74fe0ba | 2017-12-07 01:51:24 +0000 | [diff] [blame] | 67 | SymVector.emplace_back(Sym); |
Sam Clegg | c94d393 | 2017-11-17 18:14:09 +0000 | [diff] [blame] | 68 | return {Sym, true}; |
| 69 | } |
| 70 | |
Rui Ueyama | e3498ec | 2018-02-28 00:09:22 +0000 | [diff] [blame] | 71 | static void reportTypeError(const Symbol *Existing, const InputFile *File, |
Sam Clegg | 3876d89a | 2018-05-14 22:42:33 +0000 | [diff] [blame] | 72 | llvm::wasm::WasmSymbolType Type) { |
Rui Ueyama | e3498ec | 2018-02-28 00:09:22 +0000 | [diff] [blame] | 73 | error("symbol type mismatch: " + toString(*Existing) + "\n>>> defined as " + |
| 74 | toString(Existing->getWasmType()) + " in " + |
Sam Clegg | 3876d89a | 2018-05-14 22:42:33 +0000 | [diff] [blame] | 75 | toString(Existing->getFile()) + "\n>>> defined as " + toString(Type) + |
| 76 | " in " + toString(File)); |
Rui Ueyama | e3498ec | 2018-02-28 00:09:22 +0000 | [diff] [blame] | 77 | } |
| 78 | |
| 79 | static void checkFunctionType(const Symbol *Existing, const InputFile *File, |
| 80 | const WasmSignature *NewSig) { |
Sam Clegg | 65d6380 | 2018-05-14 23:01:16 +0000 | [diff] [blame^] | 81 | auto ExistingFunction = dyn_cast<FunctionSymbol>(Existing); |
| 82 | if (!ExistingFunction) { |
Sam Clegg | 3876d89a | 2018-05-14 22:42:33 +0000 | [diff] [blame] | 83 | reportTypeError(Existing, File, WASM_SYMBOL_TYPE_FUNCTION); |
Rui Ueyama | e3498ec | 2018-02-28 00:09:22 +0000 | [diff] [blame] | 84 | return; |
| 85 | } |
| 86 | |
Sam Clegg | 65d6380 | 2018-05-14 23:01:16 +0000 | [diff] [blame^] | 87 | const WasmSignature *OldSig = ExistingFunction->getFunctionType(); |
| 88 | if (OldSig && NewSig && *NewSig != *OldSig) { |
Sam Clegg | 752494b | 2018-05-05 01:23:07 +0000 | [diff] [blame] | 89 | warn("Function type mismatch: " + Existing->getName() + |
| 90 | "\n>>> defined as " + toString(*OldSig) + " in " + |
| 91 | toString(Existing->getFile()) + "\n>>> defined as " + |
| 92 | toString(*NewSig) + " in " + toString(File)); |
Rui Ueyama | e3498ec | 2018-02-28 00:09:22 +0000 | [diff] [blame] | 93 | } |
| 94 | } |
| 95 | |
Sam Clegg | b862159 | 2017-11-30 01:40:08 +0000 | [diff] [blame] | 96 | // Check the type of new symbol matches that of the symbol is replacing. |
| 97 | // For functions this can also involve verifying that the signatures match. |
Rui Ueyama | e3498ec | 2018-02-28 00:09:22 +0000 | [diff] [blame] | 98 | static void checkGlobalType(const Symbol *Existing, const InputFile *File, |
| 99 | const WasmGlobalType *NewType) { |
| 100 | if (!isa<GlobalSymbol>(Existing)) { |
Sam Clegg | 3876d89a | 2018-05-14 22:42:33 +0000 | [diff] [blame] | 101 | reportTypeError(Existing, File, WASM_SYMBOL_TYPE_GLOBAL); |
Sam Clegg | b862159 | 2017-11-30 01:40:08 +0000 | [diff] [blame] | 102 | return; |
| 103 | } |
| 104 | |
Rui Ueyama | e3498ec | 2018-02-28 00:09:22 +0000 | [diff] [blame] | 105 | const WasmGlobalType *OldType = cast<GlobalSymbol>(Existing)->getGlobalType(); |
| 106 | if (*NewType != *OldType) { |
| 107 | error("Global type mismatch: " + Existing->getName() + "\n>>> defined as " + |
| 108 | toString(*OldType) + " in " + toString(Existing->getFile()) + |
| 109 | "\n>>> defined as " + toString(*NewType) + " in " + toString(File)); |
Sam Clegg | 9310297 | 2018-02-23 05:08:53 +0000 | [diff] [blame] | 110 | } |
Sam Clegg | 24b3dcd | 2018-01-28 19:57:01 +0000 | [diff] [blame] | 111 | } |
| 112 | |
Rui Ueyama | e3498ec | 2018-02-28 00:09:22 +0000 | [diff] [blame] | 113 | static void checkDataType(const Symbol *Existing, const InputFile *File) { |
| 114 | if (!isa<DataSymbol>(Existing)) |
Sam Clegg | 3876d89a | 2018-05-14 22:42:33 +0000 | [diff] [blame] | 115 | reportTypeError(Existing, File, WASM_SYMBOL_TYPE_DATA); |
Rui Ueyama | e3498ec | 2018-02-28 00:09:22 +0000 | [diff] [blame] | 116 | } |
| 117 | |
Sam Clegg | dfb0b2c | 2018-02-14 18:27:59 +0000 | [diff] [blame] | 118 | DefinedFunction *SymbolTable::addSyntheticFunction(StringRef Name, |
Nicholas Wilson | ebda41f | 2018-03-09 16:43:05 +0000 | [diff] [blame] | 119 | uint32_t Flags, |
| 120 | InputFunction *Function) { |
Sam Clegg | a189230 | 2018-02-13 20:14:26 +0000 | [diff] [blame] | 121 | DEBUG(dbgs() << "addSyntheticFunction: " << Name << "\n"); |
Rui Ueyama | b961abc | 2018-02-28 22:51:51 +0000 | [diff] [blame] | 122 | assert(!find(Name)); |
Nicholas Wilson | ebda41f | 2018-03-09 16:43:05 +0000 | [diff] [blame] | 123 | SyntheticFunctions.emplace_back(Function); |
| 124 | return replaceSymbol<DefinedFunction>(insert(Name).first, Name, Flags, |
| 125 | nullptr, Function); |
Sam Clegg | 5068685 | 2018-01-12 18:35:13 +0000 | [diff] [blame] | 126 | } |
| 127 | |
Sam Clegg | 0024553 | 2018-02-20 23:38:27 +0000 | [diff] [blame] | 128 | DefinedData *SymbolTable::addSyntheticDataSymbol(StringRef Name, |
| 129 | uint32_t Flags) { |
| 130 | DEBUG(dbgs() << "addSyntheticDataSymbol: " << Name << "\n"); |
Rui Ueyama | b961abc | 2018-02-28 22:51:51 +0000 | [diff] [blame] | 131 | assert(!find(Name)); |
| 132 | return replaceSymbol<DefinedData>(insert(Name).first, Name, Flags); |
Sam Clegg | c94d393 | 2017-11-17 18:14:09 +0000 | [diff] [blame] | 133 | } |
| 134 | |
Sam Clegg | 9310297 | 2018-02-23 05:08:53 +0000 | [diff] [blame] | 135 | DefinedGlobal *SymbolTable::addSyntheticGlobal(StringRef Name, uint32_t Flags, |
| 136 | InputGlobal *Global) { |
| 137 | DEBUG(dbgs() << "addSyntheticGlobal: " << Name << " -> " << Global << "\n"); |
Rui Ueyama | b961abc | 2018-02-28 22:51:51 +0000 | [diff] [blame] | 138 | assert(!find(Name)); |
Nicholas Wilson | ebda41f | 2018-03-09 16:43:05 +0000 | [diff] [blame] | 139 | SyntheticGlobals.emplace_back(Global); |
Rui Ueyama | b961abc | 2018-02-28 22:51:51 +0000 | [diff] [blame] | 140 | return replaceSymbol<DefinedGlobal>(insert(Name).first, Name, Flags, nullptr, |
| 141 | Global); |
Sam Clegg | 9310297 | 2018-02-23 05:08:53 +0000 | [diff] [blame] | 142 | } |
| 143 | |
Rui Ueyama | e3498ec | 2018-02-28 00:09:22 +0000 | [diff] [blame] | 144 | static bool shouldReplace(const Symbol *Existing, InputFile *NewFile, |
| 145 | uint32_t NewFlags) { |
Rui Ueyama | c03c904 | 2018-02-20 21:08:47 +0000 | [diff] [blame] | 146 | // If existing symbol is undefined, replace it. |
Rui Ueyama | e3498ec | 2018-02-28 00:09:22 +0000 | [diff] [blame] | 147 | if (!Existing->isDefined()) { |
Rui Ueyama | c03c904 | 2018-02-20 21:08:47 +0000 | [diff] [blame] | 148 | DEBUG(dbgs() << "resolving existing undefined symbol: " |
Rui Ueyama | e3498ec | 2018-02-28 00:09:22 +0000 | [diff] [blame] | 149 | << Existing->getName() << "\n"); |
Rui Ueyama | c03c904 | 2018-02-20 21:08:47 +0000 | [diff] [blame] | 150 | return true; |
| 151 | } |
| 152 | |
| 153 | // Now we have two defined symbols. If the new one is weak, we can ignore it. |
| 154 | if ((NewFlags & WASM_SYMBOL_BINDING_MASK) == WASM_SYMBOL_BINDING_WEAK) { |
| 155 | DEBUG(dbgs() << "existing symbol takes precedence\n"); |
| 156 | return false; |
| 157 | } |
| 158 | |
| 159 | // If the existing symbol is weak, we should replace it. |
Rui Ueyama | e3498ec | 2018-02-28 00:09:22 +0000 | [diff] [blame] | 160 | if (Existing->isWeak()) { |
Rui Ueyama | c03c904 | 2018-02-20 21:08:47 +0000 | [diff] [blame] | 161 | DEBUG(dbgs() << "replacing existing weak symbol\n"); |
| 162 | return true; |
| 163 | } |
| 164 | |
| 165 | // Neither symbol is week. They conflict. |
Rui Ueyama | e3498ec | 2018-02-28 00:09:22 +0000 | [diff] [blame] | 166 | error("duplicate symbol: " + toString(*Existing) + "\n>>> defined in " + |
| 167 | toString(Existing->getFile()) + "\n>>> defined in " + |
| 168 | toString(NewFile)); |
Rui Ueyama | c03c904 | 2018-02-20 21:08:47 +0000 | [diff] [blame] | 169 | return true; |
Sam Clegg | 93e559b | 2018-02-20 18:55:06 +0000 | [diff] [blame] | 170 | } |
| 171 | |
| 172 | Symbol *SymbolTable::addDefinedFunction(StringRef Name, uint32_t Flags, |
Rui Ueyama | e3498ec | 2018-02-28 00:09:22 +0000 | [diff] [blame] | 173 | InputFile *File, |
| 174 | InputFunction *Function) { |
Sam Clegg | 93e559b | 2018-02-20 18:55:06 +0000 | [diff] [blame] | 175 | DEBUG(dbgs() << "addDefinedFunction: " << Name << "\n"); |
| 176 | Symbol *S; |
| 177 | bool WasInserted; |
| 178 | std::tie(S, WasInserted) = insert(Name); |
Rui Ueyama | e3498ec | 2018-02-28 00:09:22 +0000 | [diff] [blame] | 179 | |
| 180 | if (WasInserted || S->isLazy()) { |
| 181 | replaceSymbol<DefinedFunction>(S, Name, Flags, File, Function); |
| 182 | return S; |
| 183 | } |
| 184 | |
| 185 | checkFunctionType(S, File, &Function->Signature); |
| 186 | |
| 187 | if (shouldReplace(S, File, Flags)) |
| 188 | replaceSymbol<DefinedFunction>(S, Name, Flags, File, Function); |
Sam Clegg | 93e559b | 2018-02-20 18:55:06 +0000 | [diff] [blame] | 189 | return S; |
| 190 | } |
| 191 | |
Sam Clegg | 0024553 | 2018-02-20 23:38:27 +0000 | [diff] [blame] | 192 | Symbol *SymbolTable::addDefinedData(StringRef Name, uint32_t Flags, |
Rui Ueyama | e3498ec | 2018-02-28 00:09:22 +0000 | [diff] [blame] | 193 | InputFile *File, InputSegment *Segment, |
Sam Clegg | 9310297 | 2018-02-23 05:08:53 +0000 | [diff] [blame] | 194 | uint32_t Address, uint32_t Size) { |
Sam Clegg | 0024553 | 2018-02-20 23:38:27 +0000 | [diff] [blame] | 195 | DEBUG(dbgs() << "addDefinedData:" << Name << " addr:" << Address << "\n"); |
Sam Clegg | 93e559b | 2018-02-20 18:55:06 +0000 | [diff] [blame] | 196 | Symbol *S; |
| 197 | bool WasInserted; |
| 198 | std::tie(S, WasInserted) = insert(Name); |
Rui Ueyama | e3498ec | 2018-02-28 00:09:22 +0000 | [diff] [blame] | 199 | |
| 200 | if (WasInserted || S->isLazy()) { |
| 201 | replaceSymbol<DefinedData>(S, Name, Flags, File, Segment, Address, Size); |
| 202 | return S; |
| 203 | } |
| 204 | |
| 205 | checkDataType(S, File); |
| 206 | |
| 207 | if (shouldReplace(S, File, Flags)) |
| 208 | replaceSymbol<DefinedData>(S, Name, Flags, File, Segment, Address, Size); |
Sam Clegg | c94d393 | 2017-11-17 18:14:09 +0000 | [diff] [blame] | 209 | return S; |
| 210 | } |
| 211 | |
Sam Clegg | 9310297 | 2018-02-23 05:08:53 +0000 | [diff] [blame] | 212 | Symbol *SymbolTable::addDefinedGlobal(StringRef Name, uint32_t Flags, |
Rui Ueyama | e3498ec | 2018-02-28 00:09:22 +0000 | [diff] [blame] | 213 | InputFile *File, InputGlobal *Global) { |
Sam Clegg | 9310297 | 2018-02-23 05:08:53 +0000 | [diff] [blame] | 214 | DEBUG(dbgs() << "addDefinedGlobal:" << Name << "\n"); |
| 215 | Symbol *S; |
| 216 | bool WasInserted; |
| 217 | std::tie(S, WasInserted) = insert(Name); |
Rui Ueyama | e3498ec | 2018-02-28 00:09:22 +0000 | [diff] [blame] | 218 | |
| 219 | if (WasInserted || S->isLazy()) { |
| 220 | replaceSymbol<DefinedGlobal>(S, Name, Flags, File, Global); |
| 221 | return S; |
| 222 | } |
| 223 | |
| 224 | checkGlobalType(S, File, &Global->getType()); |
| 225 | |
| 226 | if (shouldReplace(S, File, Flags)) |
| 227 | replaceSymbol<DefinedGlobal>(S, Name, Flags, File, Global); |
Sam Clegg | 9310297 | 2018-02-23 05:08:53 +0000 | [diff] [blame] | 228 | return S; |
| 229 | } |
| 230 | |
Rui Ueyama | e3498ec | 2018-02-28 00:09:22 +0000 | [diff] [blame] | 231 | Symbol *SymbolTable::addUndefinedFunction(StringRef Name, uint32_t Flags, |
| 232 | InputFile *File, |
| 233 | const WasmSignature *Sig) { |
| 234 | DEBUG(dbgs() << "addUndefinedFunction: " << Name << "\n"); |
Rui Ueyama | c03c904 | 2018-02-20 21:08:47 +0000 | [diff] [blame] | 235 | |
Sam Clegg | c94d393 | 2017-11-17 18:14:09 +0000 | [diff] [blame] | 236 | Symbol *S; |
| 237 | bool WasInserted; |
Sam Clegg | 20db381 | 2018-01-10 00:52:20 +0000 | [diff] [blame] | 238 | std::tie(S, WasInserted) = insert(Name); |
Rui Ueyama | c03c904 | 2018-02-20 21:08:47 +0000 | [diff] [blame] | 239 | |
Rui Ueyama | e3498ec | 2018-02-28 00:09:22 +0000 | [diff] [blame] | 240 | if (WasInserted) |
| 241 | replaceSymbol<UndefinedFunction>(S, Name, Flags, File, Sig); |
| 242 | else if (auto *Lazy = dyn_cast<LazySymbol>(S)) |
Rui Ueyama | b961abc | 2018-02-28 22:51:51 +0000 | [diff] [blame] | 243 | Lazy->fetch(); |
Rui Ueyama | e3498ec | 2018-02-28 00:09:22 +0000 | [diff] [blame] | 244 | else if (S->isDefined()) |
| 245 | checkFunctionType(S, File, Sig); |
Sam Clegg | c94d393 | 2017-11-17 18:14:09 +0000 | [diff] [blame] | 246 | return S; |
| 247 | } |
| 248 | |
Rui Ueyama | e3498ec | 2018-02-28 00:09:22 +0000 | [diff] [blame] | 249 | Symbol *SymbolTable::addUndefinedData(StringRef Name, uint32_t Flags, |
| 250 | InputFile *File) { |
| 251 | DEBUG(dbgs() << "addUndefinedData: " << Name << "\n"); |
| 252 | |
| 253 | Symbol *S; |
| 254 | bool WasInserted; |
| 255 | std::tie(S, WasInserted) = insert(Name); |
| 256 | |
| 257 | if (WasInserted) |
| 258 | replaceSymbol<UndefinedData>(S, Name, Flags, File); |
| 259 | else if (auto *Lazy = dyn_cast<LazySymbol>(S)) |
Rui Ueyama | b961abc | 2018-02-28 22:51:51 +0000 | [diff] [blame] | 260 | Lazy->fetch(); |
Rui Ueyama | e3498ec | 2018-02-28 00:09:22 +0000 | [diff] [blame] | 261 | else if (S->isDefined()) |
| 262 | checkDataType(S, File); |
| 263 | return S; |
| 264 | } |
| 265 | |
| 266 | Symbol *SymbolTable::addUndefinedGlobal(StringRef Name, uint32_t Flags, |
| 267 | InputFile *File, |
| 268 | const WasmGlobalType *Type) { |
| 269 | DEBUG(dbgs() << "addUndefinedGlobal: " << Name << "\n"); |
| 270 | |
| 271 | Symbol *S; |
| 272 | bool WasInserted; |
| 273 | std::tie(S, WasInserted) = insert(Name); |
| 274 | |
| 275 | if (WasInserted) |
| 276 | replaceSymbol<UndefinedGlobal>(S, Name, Flags, File, Type); |
| 277 | else if (auto *Lazy = dyn_cast<LazySymbol>(S)) |
Rui Ueyama | b961abc | 2018-02-28 22:51:51 +0000 | [diff] [blame] | 278 | Lazy->fetch(); |
Rui Ueyama | e3498ec | 2018-02-28 00:09:22 +0000 | [diff] [blame] | 279 | else if (S->isDefined()) |
| 280 | checkGlobalType(S, File, Type); |
| 281 | return S; |
| 282 | } |
| 283 | |
| 284 | void SymbolTable::addLazy(ArchiveFile *File, const Archive::Symbol *Sym) { |
Sam Clegg | a681a11 | 2017-12-06 03:10:39 +0000 | [diff] [blame] | 285 | DEBUG(dbgs() << "addLazy: " << Sym->getName() << "\n"); |
Sam Clegg | c94d393 | 2017-11-17 18:14:09 +0000 | [diff] [blame] | 286 | StringRef Name = Sym->getName(); |
Rui Ueyama | c03c904 | 2018-02-20 21:08:47 +0000 | [diff] [blame] | 287 | |
Sam Clegg | c94d393 | 2017-11-17 18:14:09 +0000 | [diff] [blame] | 288 | Symbol *S; |
| 289 | bool WasInserted; |
| 290 | std::tie(S, WasInserted) = insert(Name); |
Rui Ueyama | c03c904 | 2018-02-20 21:08:47 +0000 | [diff] [blame] | 291 | |
Sam Clegg | c94d393 | 2017-11-17 18:14:09 +0000 | [diff] [blame] | 292 | if (WasInserted) { |
Rui Ueyama | e3498ec | 2018-02-28 00:09:22 +0000 | [diff] [blame] | 293 | replaceSymbol<LazySymbol>(S, Name, File, *Sym); |
Rui Ueyama | c03c904 | 2018-02-20 21:08:47 +0000 | [diff] [blame] | 294 | return; |
| 295 | } |
| 296 | |
| 297 | // If there is an existing undefined symbol, load a new one from the archive. |
| 298 | if (S->isUndefined()) { |
Sam Clegg | c94d393 | 2017-11-17 18:14:09 +0000 | [diff] [blame] | 299 | DEBUG(dbgs() << "replacing existing undefined\n"); |
Rui Ueyama | e3498ec | 2018-02-28 00:09:22 +0000 | [diff] [blame] | 300 | File->addMember(Sym); |
Sam Clegg | c94d393 | 2017-11-17 18:14:09 +0000 | [diff] [blame] | 301 | } |
| 302 | } |
Sam Clegg | e0f6fcd | 2018-01-12 22:25:17 +0000 | [diff] [blame] | 303 | |
Nicholas Wilson | c4d9aa1 | 2018-03-14 15:45:11 +0000 | [diff] [blame] | 304 | bool SymbolTable::addComdat(StringRef Name) { |
| 305 | return Comdats.insert(CachedHashStringRef(Name)).second; |
Sam Clegg | e0f6fcd | 2018-01-12 22:25:17 +0000 | [diff] [blame] | 306 | } |