Eugene Zelenko | dd40f5e | 2017-10-16 21:34:24 +0000 | [diff] [blame] | 1 | //===- LoopInterchange.cpp - Loop interchange pass-------------------------===// |
Karthik Bhat | 88db86d | 2015-03-06 10:11:25 +0000 | [diff] [blame] | 2 | // |
| 3 | // The LLVM Compiler Infrastructure |
| 4 | // |
| 5 | // This file is distributed under the University of Illinois Open Source |
| 6 | // License. See LICENSE.TXT for details. |
| 7 | // |
| 8 | //===----------------------------------------------------------------------===// |
| 9 | // |
| 10 | // This Pass handles loop interchange transform. |
| 11 | // This pass interchanges loops to provide a more cache-friendly memory access |
| 12 | // patterns. |
| 13 | // |
| 14 | //===----------------------------------------------------------------------===// |
| 15 | |
Eugene Zelenko | dd40f5e | 2017-10-16 21:34:24 +0000 | [diff] [blame] | 16 | #include "llvm/ADT/STLExtras.h" |
Karthik Bhat | 88db86d | 2015-03-06 10:11:25 +0000 | [diff] [blame] | 17 | #include "llvm/ADT/SmallVector.h" |
Florian Hahn | 6e00433 | 2018-04-05 10:39:23 +0000 | [diff] [blame] | 18 | #include "llvm/ADT/Statistic.h" |
Eugene Zelenko | dd40f5e | 2017-10-16 21:34:24 +0000 | [diff] [blame] | 19 | #include "llvm/ADT/StringRef.h" |
Karthik Bhat | 88db86d | 2015-03-06 10:11:25 +0000 | [diff] [blame] | 20 | #include "llvm/Analysis/AliasAnalysis.h" |
Karthik Bhat | 88db86d | 2015-03-06 10:11:25 +0000 | [diff] [blame] | 21 | #include "llvm/Analysis/DependenceAnalysis.h" |
| 22 | #include "llvm/Analysis/LoopInfo.h" |
Adam Nemet | 0965da2 | 2017-10-09 23:19:02 +0000 | [diff] [blame] | 23 | #include "llvm/Analysis/OptimizationRemarkEmitter.h" |
Karthik Bhat | 88db86d | 2015-03-06 10:11:25 +0000 | [diff] [blame] | 24 | #include "llvm/Analysis/ScalarEvolution.h" |
Karthik Bhat | 88db86d | 2015-03-06 10:11:25 +0000 | [diff] [blame] | 25 | #include "llvm/Analysis/ScalarEvolutionExpressions.h" |
Eugene Zelenko | dd40f5e | 2017-10-16 21:34:24 +0000 | [diff] [blame] | 26 | #include "llvm/IR/BasicBlock.h" |
| 27 | #include "llvm/IR/Constants.h" |
| 28 | #include "llvm/IR/DiagnosticInfo.h" |
Benjamin Kramer | 799003b | 2015-03-23 19:32:43 +0000 | [diff] [blame] | 29 | #include "llvm/IR/Dominators.h" |
Karthik Bhat | 88db86d | 2015-03-06 10:11:25 +0000 | [diff] [blame] | 30 | #include "llvm/IR/Function.h" |
Eugene Zelenko | dd40f5e | 2017-10-16 21:34:24 +0000 | [diff] [blame] | 31 | #include "llvm/IR/InstrTypes.h" |
| 32 | #include "llvm/IR/Instruction.h" |
| 33 | #include "llvm/IR/Instructions.h" |
| 34 | #include "llvm/IR/Type.h" |
| 35 | #include "llvm/IR/User.h" |
| 36 | #include "llvm/IR/Value.h" |
Karthik Bhat | 88db86d | 2015-03-06 10:11:25 +0000 | [diff] [blame] | 37 | #include "llvm/Pass.h" |
Eugene Zelenko | dd40f5e | 2017-10-16 21:34:24 +0000 | [diff] [blame] | 38 | #include "llvm/Support/Casting.h" |
| 39 | #include "llvm/Support/CommandLine.h" |
Karthik Bhat | 88db86d | 2015-03-06 10:11:25 +0000 | [diff] [blame] | 40 | #include "llvm/Support/Debug.h" |
Eugene Zelenko | dd40f5e | 2017-10-16 21:34:24 +0000 | [diff] [blame] | 41 | #include "llvm/Support/ErrorHandling.h" |
Karthik Bhat | 88db86d | 2015-03-06 10:11:25 +0000 | [diff] [blame] | 42 | #include "llvm/Support/raw_ostream.h" |
Benjamin Kramer | 799003b | 2015-03-23 19:32:43 +0000 | [diff] [blame] | 43 | #include "llvm/Transforms/Scalar.h" |
David Blaikie | a373d18 | 2018-03-28 17:44:36 +0000 | [diff] [blame] | 44 | #include "llvm/Transforms/Utils.h" |
Karthik Bhat | 88db86d | 2015-03-06 10:11:25 +0000 | [diff] [blame] | 45 | #include "llvm/Transforms/Utils/BasicBlockUtils.h" |
Benjamin Kramer | 799003b | 2015-03-23 19:32:43 +0000 | [diff] [blame] | 46 | #include "llvm/Transforms/Utils/LoopUtils.h" |
Eugene Zelenko | dd40f5e | 2017-10-16 21:34:24 +0000 | [diff] [blame] | 47 | #include <cassert> |
| 48 | #include <utility> |
| 49 | #include <vector> |
Davide Italiano | 9d8f6f8 | 2017-01-29 01:55:24 +0000 | [diff] [blame] | 50 | |
Karthik Bhat | 88db86d | 2015-03-06 10:11:25 +0000 | [diff] [blame] | 51 | using namespace llvm; |
| 52 | |
| 53 | #define DEBUG_TYPE "loop-interchange" |
| 54 | |
Florian Hahn | 6e00433 | 2018-04-05 10:39:23 +0000 | [diff] [blame] | 55 | STATISTIC(LoopsInterchanged, "Number of loops interchanged"); |
| 56 | |
Chad Rosier | 7243189 | 2016-09-14 17:07:13 +0000 | [diff] [blame] | 57 | static cl::opt<int> LoopInterchangeCostThreshold( |
| 58 | "loop-interchange-threshold", cl::init(0), cl::Hidden, |
| 59 | cl::desc("Interchange if you gain more than this number")); |
| 60 | |
Karthik Bhat | 88db86d | 2015-03-06 10:11:25 +0000 | [diff] [blame] | 61 | namespace { |
| 62 | |
Eugene Zelenko | dd40f5e | 2017-10-16 21:34:24 +0000 | [diff] [blame] | 63 | using LoopVector = SmallVector<Loop *, 8>; |
Karthik Bhat | 88db86d | 2015-03-06 10:11:25 +0000 | [diff] [blame] | 64 | |
| 65 | // TODO: Check if we can use a sparse matrix here. |
Eugene Zelenko | dd40f5e | 2017-10-16 21:34:24 +0000 | [diff] [blame] | 66 | using CharMatrix = std::vector<std::vector<char>>; |
| 67 | |
| 68 | } // end anonymous namespace |
Karthik Bhat | 88db86d | 2015-03-06 10:11:25 +0000 | [diff] [blame] | 69 | |
| 70 | // Maximum number of dependencies that can be handled in the dependency matrix. |
| 71 | static const unsigned MaxMemInstrCount = 100; |
| 72 | |
| 73 | // Maximum loop depth supported. |
| 74 | static const unsigned MaxLoopNestDepth = 10; |
| 75 | |
Karthik Bhat | 88db86d | 2015-03-06 10:11:25 +0000 | [diff] [blame] | 76 | #ifdef DUMP_DEP_MATRICIES |
Eugene Zelenko | dd40f5e | 2017-10-16 21:34:24 +0000 | [diff] [blame] | 77 | static void printDepMatrix(CharMatrix &DepMatrix) { |
Florian Hahn | f66efd6 | 2017-07-24 11:41:30 +0000 | [diff] [blame] | 78 | for (auto &Row : DepMatrix) { |
| 79 | for (auto D : Row) |
Nicola Zaghen | d34e60c | 2018-05-14 12:53:11 +0000 | [diff] [blame] | 80 | LLVM_DEBUG(dbgs() << D << " "); |
| 81 | LLVM_DEBUG(dbgs() << "\n"); |
Karthik Bhat | 88db86d | 2015-03-06 10:11:25 +0000 | [diff] [blame] | 82 | } |
| 83 | } |
| 84 | #endif |
| 85 | |
Karthik Bhat | 8210fdf | 2015-04-23 04:51:44 +0000 | [diff] [blame] | 86 | static bool populateDependencyMatrix(CharMatrix &DepMatrix, unsigned Level, |
Chandler Carruth | 49c2219 | 2016-05-12 22:19:39 +0000 | [diff] [blame] | 87 | Loop *L, DependenceInfo *DI) { |
Eugene Zelenko | dd40f5e | 2017-10-16 21:34:24 +0000 | [diff] [blame] | 88 | using ValueVector = SmallVector<Value *, 16>; |
| 89 | |
Karthik Bhat | 88db86d | 2015-03-06 10:11:25 +0000 | [diff] [blame] | 90 | ValueVector MemInstr; |
| 91 | |
Karthik Bhat | 88db86d | 2015-03-06 10:11:25 +0000 | [diff] [blame] | 92 | // For each block. |
Florian Hahn | f66efd6 | 2017-07-24 11:41:30 +0000 | [diff] [blame] | 93 | for (BasicBlock *BB : L->blocks()) { |
Karthik Bhat | 88db86d | 2015-03-06 10:11:25 +0000 | [diff] [blame] | 94 | // Scan the BB and collect legal loads and stores. |
Florian Hahn | f66efd6 | 2017-07-24 11:41:30 +0000 | [diff] [blame] | 95 | for (Instruction &I : *BB) { |
Chad Rosier | 09c1109 | 2016-09-13 12:56:04 +0000 | [diff] [blame] | 96 | if (!isa<Instruction>(I)) |
Karthik Bhat | 88db86d | 2015-03-06 10:11:25 +0000 | [diff] [blame] | 97 | return false; |
Florian Hahn | f66efd6 | 2017-07-24 11:41:30 +0000 | [diff] [blame] | 98 | if (auto *Ld = dyn_cast<LoadInst>(&I)) { |
Chad Rosier | 09c1109 | 2016-09-13 12:56:04 +0000 | [diff] [blame] | 99 | if (!Ld->isSimple()) |
| 100 | return false; |
Florian Hahn | f66efd6 | 2017-07-24 11:41:30 +0000 | [diff] [blame] | 101 | MemInstr.push_back(&I); |
| 102 | } else if (auto *St = dyn_cast<StoreInst>(&I)) { |
Chad Rosier | 09c1109 | 2016-09-13 12:56:04 +0000 | [diff] [blame] | 103 | if (!St->isSimple()) |
| 104 | return false; |
Florian Hahn | f66efd6 | 2017-07-24 11:41:30 +0000 | [diff] [blame] | 105 | MemInstr.push_back(&I); |
Chad Rosier | 09c1109 | 2016-09-13 12:56:04 +0000 | [diff] [blame] | 106 | } |
Karthik Bhat | 88db86d | 2015-03-06 10:11:25 +0000 | [diff] [blame] | 107 | } |
| 108 | } |
| 109 | |
Nicola Zaghen | d34e60c | 2018-05-14 12:53:11 +0000 | [diff] [blame] | 110 | LLVM_DEBUG(dbgs() << "Found " << MemInstr.size() |
| 111 | << " Loads and Stores to analyze\n"); |
Karthik Bhat | 88db86d | 2015-03-06 10:11:25 +0000 | [diff] [blame] | 112 | |
| 113 | ValueVector::iterator I, IE, J, JE; |
| 114 | |
| 115 | for (I = MemInstr.begin(), IE = MemInstr.end(); I != IE; ++I) { |
| 116 | for (J = I, JE = MemInstr.end(); J != JE; ++J) { |
| 117 | std::vector<char> Dep; |
Chad Rosier | 09c1109 | 2016-09-13 12:56:04 +0000 | [diff] [blame] | 118 | Instruction *Src = cast<Instruction>(*I); |
| 119 | Instruction *Dst = cast<Instruction>(*J); |
Chad Rosier | 90bcb91 | 2016-09-07 16:07:17 +0000 | [diff] [blame] | 120 | if (Src == Dst) |
Karthik Bhat | 88db86d | 2015-03-06 10:11:25 +0000 | [diff] [blame] | 121 | continue; |
Chad Rosier | 00eb8db | 2016-09-21 19:16:47 +0000 | [diff] [blame] | 122 | // Ignore Input dependencies. |
Chad Rosier | 90bcb91 | 2016-09-07 16:07:17 +0000 | [diff] [blame] | 123 | if (isa<LoadInst>(Src) && isa<LoadInst>(Dst)) |
Karthik Bhat | 88db86d | 2015-03-06 10:11:25 +0000 | [diff] [blame] | 124 | continue; |
Chad Rosier | 00eb8db | 2016-09-21 19:16:47 +0000 | [diff] [blame] | 125 | // Track Output, Flow, and Anti dependencies. |
Chad Rosier | 90bcb91 | 2016-09-07 16:07:17 +0000 | [diff] [blame] | 126 | if (auto D = DI->depends(Src, Dst, true)) { |
Chad Rosier | 00eb8db | 2016-09-21 19:16:47 +0000 | [diff] [blame] | 127 | assert(D->isOrdered() && "Expected an output, flow or anti dep."); |
Nicola Zaghen | d34e60c | 2018-05-14 12:53:11 +0000 | [diff] [blame] | 128 | LLVM_DEBUG(StringRef DepType = |
| 129 | D->isFlow() ? "flow" : D->isAnti() ? "anti" : "output"; |
| 130 | dbgs() << "Found " << DepType |
| 131 | << " dependency between Src and Dst\n" |
| 132 | << " Src:" << *Src << "\n Dst:" << *Dst << '\n'); |
Chad Rosier | 00eb8db | 2016-09-21 19:16:47 +0000 | [diff] [blame] | 133 | unsigned Levels = D->getLevels(); |
| 134 | char Direction; |
| 135 | for (unsigned II = 1; II <= Levels; ++II) { |
| 136 | const SCEV *Distance = D->getDistance(II); |
| 137 | const SCEVConstant *SCEVConst = |
| 138 | dyn_cast_or_null<SCEVConstant>(Distance); |
| 139 | if (SCEVConst) { |
| 140 | const ConstantInt *CI = SCEVConst->getValue(); |
| 141 | if (CI->isNegative()) |
| 142 | Direction = '<'; |
| 143 | else if (CI->isZero()) |
| 144 | Direction = '='; |
| 145 | else |
| 146 | Direction = '>'; |
| 147 | Dep.push_back(Direction); |
| 148 | } else if (D->isScalar(II)) { |
| 149 | Direction = 'S'; |
| 150 | Dep.push_back(Direction); |
| 151 | } else { |
| 152 | unsigned Dir = D->getDirection(II); |
| 153 | if (Dir == Dependence::DVEntry::LT || |
| 154 | Dir == Dependence::DVEntry::LE) |
| 155 | Direction = '<'; |
| 156 | else if (Dir == Dependence::DVEntry::GT || |
| 157 | Dir == Dependence::DVEntry::GE) |
| 158 | Direction = '>'; |
| 159 | else if (Dir == Dependence::DVEntry::EQ) |
| 160 | Direction = '='; |
| 161 | else |
| 162 | Direction = '*'; |
| 163 | Dep.push_back(Direction); |
| 164 | } |
Karthik Bhat | 88db86d | 2015-03-06 10:11:25 +0000 | [diff] [blame] | 165 | } |
Chad Rosier | 00eb8db | 2016-09-21 19:16:47 +0000 | [diff] [blame] | 166 | while (Dep.size() != Level) { |
| 167 | Dep.push_back('I'); |
| 168 | } |
Karthik Bhat | 88db86d | 2015-03-06 10:11:25 +0000 | [diff] [blame] | 169 | |
Chad Rosier | 00eb8db | 2016-09-21 19:16:47 +0000 | [diff] [blame] | 170 | DepMatrix.push_back(Dep); |
| 171 | if (DepMatrix.size() > MaxMemInstrCount) { |
Nicola Zaghen | d34e60c | 2018-05-14 12:53:11 +0000 | [diff] [blame] | 172 | LLVM_DEBUG(dbgs() << "Cannot handle more than " << MaxMemInstrCount |
| 173 | << " dependencies inside loop\n"); |
Chad Rosier | 00eb8db | 2016-09-21 19:16:47 +0000 | [diff] [blame] | 174 | return false; |
Karthik Bhat | 88db86d | 2015-03-06 10:11:25 +0000 | [diff] [blame] | 175 | } |
| 176 | } |
| 177 | } |
| 178 | } |
| 179 | |
Karthik Bhat | 88db86d | 2015-03-06 10:11:25 +0000 | [diff] [blame] | 180 | return true; |
| 181 | } |
| 182 | |
| 183 | // A loop is moved from index 'from' to an index 'to'. Update the Dependence |
| 184 | // matrix by exchanging the two columns. |
Chad Rosier | d18ea06 | 2016-09-13 13:00:29 +0000 | [diff] [blame] | 185 | static void interChangeDependencies(CharMatrix &DepMatrix, unsigned FromIndx, |
| 186 | unsigned ToIndx) { |
Karthik Bhat | 88db86d | 2015-03-06 10:11:25 +0000 | [diff] [blame] | 187 | unsigned numRows = DepMatrix.size(); |
| 188 | for (unsigned i = 0; i < numRows; ++i) { |
| 189 | char TmpVal = DepMatrix[i][ToIndx]; |
| 190 | DepMatrix[i][ToIndx] = DepMatrix[i][FromIndx]; |
| 191 | DepMatrix[i][FromIndx] = TmpVal; |
| 192 | } |
| 193 | } |
| 194 | |
| 195 | // Checks if outermost non '=','S'or'I' dependence in the dependence matrix is |
| 196 | // '>' |
Karthik Bhat | 8210fdf | 2015-04-23 04:51:44 +0000 | [diff] [blame] | 197 | static bool isOuterMostDepPositive(CharMatrix &DepMatrix, unsigned Row, |
| 198 | unsigned Column) { |
Karthik Bhat | 88db86d | 2015-03-06 10:11:25 +0000 | [diff] [blame] | 199 | for (unsigned i = 0; i <= Column; ++i) { |
| 200 | if (DepMatrix[Row][i] == '<') |
| 201 | return false; |
| 202 | if (DepMatrix[Row][i] == '>') |
| 203 | return true; |
| 204 | } |
| 205 | // All dependencies were '=','S' or 'I' |
| 206 | return false; |
| 207 | } |
| 208 | |
| 209 | // Checks if no dependence exist in the dependency matrix in Row before Column. |
Karthik Bhat | 8210fdf | 2015-04-23 04:51:44 +0000 | [diff] [blame] | 210 | static bool containsNoDependence(CharMatrix &DepMatrix, unsigned Row, |
| 211 | unsigned Column) { |
Karthik Bhat | 88db86d | 2015-03-06 10:11:25 +0000 | [diff] [blame] | 212 | for (unsigned i = 0; i < Column; ++i) { |
Chandler Carruth | fca1ff0 | 2016-11-03 16:39:25 +0000 | [diff] [blame] | 213 | if (DepMatrix[Row][i] != '=' && DepMatrix[Row][i] != 'S' && |
Karthik Bhat | 88db86d | 2015-03-06 10:11:25 +0000 | [diff] [blame] | 214 | DepMatrix[Row][i] != 'I') |
| 215 | return false; |
| 216 | } |
| 217 | return true; |
| 218 | } |
| 219 | |
Karthik Bhat | 8210fdf | 2015-04-23 04:51:44 +0000 | [diff] [blame] | 220 | static bool validDepInterchange(CharMatrix &DepMatrix, unsigned Row, |
| 221 | unsigned OuterLoopId, char InnerDep, |
| 222 | char OuterDep) { |
Karthik Bhat | 88db86d | 2015-03-06 10:11:25 +0000 | [diff] [blame] | 223 | if (isOuterMostDepPositive(DepMatrix, Row, OuterLoopId)) |
| 224 | return false; |
| 225 | |
| 226 | if (InnerDep == OuterDep) |
| 227 | return true; |
| 228 | |
| 229 | // It is legal to interchange if and only if after interchange no row has a |
| 230 | // '>' direction as the leftmost non-'='. |
| 231 | |
| 232 | if (InnerDep == '=' || InnerDep == 'S' || InnerDep == 'I') |
| 233 | return true; |
| 234 | |
| 235 | if (InnerDep == '<') |
| 236 | return true; |
| 237 | |
| 238 | if (InnerDep == '>') { |
| 239 | // If OuterLoopId represents outermost loop then interchanging will make the |
| 240 | // 1st dependency as '>' |
| 241 | if (OuterLoopId == 0) |
| 242 | return false; |
| 243 | |
| 244 | // If all dependencies before OuterloopId are '=','S'or 'I'. Then |
| 245 | // interchanging will result in this row having an outermost non '=' |
| 246 | // dependency of '>' |
| 247 | if (!containsNoDependence(DepMatrix, Row, OuterLoopId)) |
| 248 | return true; |
| 249 | } |
| 250 | |
| 251 | return false; |
| 252 | } |
| 253 | |
| 254 | // Checks if it is legal to interchange 2 loops. |
Karthik Bhat | 8210fdf | 2015-04-23 04:51:44 +0000 | [diff] [blame] | 255 | // [Theorem] A permutation of the loops in a perfect nest is legal if and only |
Chad Rosier | 61683a2 | 2016-09-13 13:08:53 +0000 | [diff] [blame] | 256 | // if the direction matrix, after the same permutation is applied to its |
| 257 | // columns, has no ">" direction as the leftmost non-"=" direction in any row. |
Karthik Bhat | 8210fdf | 2015-04-23 04:51:44 +0000 | [diff] [blame] | 258 | static bool isLegalToInterChangeLoops(CharMatrix &DepMatrix, |
| 259 | unsigned InnerLoopId, |
| 260 | unsigned OuterLoopId) { |
Karthik Bhat | 88db86d | 2015-03-06 10:11:25 +0000 | [diff] [blame] | 261 | unsigned NumRows = DepMatrix.size(); |
| 262 | // For each row check if it is valid to interchange. |
| 263 | for (unsigned Row = 0; Row < NumRows; ++Row) { |
| 264 | char InnerDep = DepMatrix[Row][InnerLoopId]; |
| 265 | char OuterDep = DepMatrix[Row][OuterLoopId]; |
| 266 | if (InnerDep == '*' || OuterDep == '*') |
| 267 | return false; |
Chad Rosier | 61683a2 | 2016-09-13 13:08:53 +0000 | [diff] [blame] | 268 | if (!validDepInterchange(DepMatrix, Row, OuterLoopId, InnerDep, OuterDep)) |
Karthik Bhat | 88db86d | 2015-03-06 10:11:25 +0000 | [diff] [blame] | 269 | return false; |
| 270 | } |
| 271 | return true; |
| 272 | } |
| 273 | |
| 274 | static void populateWorklist(Loop &L, SmallVector<LoopVector, 8> &V) { |
Nicola Zaghen | d34e60c | 2018-05-14 12:53:11 +0000 | [diff] [blame] | 275 | LLVM_DEBUG(dbgs() << "Calling populateWorklist on Func: " |
| 276 | << L.getHeader()->getParent()->getName() << " Loop: %" |
| 277 | << L.getHeader()->getName() << '\n'); |
Karthik Bhat | 88db86d | 2015-03-06 10:11:25 +0000 | [diff] [blame] | 278 | LoopVector LoopList; |
| 279 | Loop *CurrentLoop = &L; |
Benjamin Kramer | e448b5b | 2015-07-13 17:21:14 +0000 | [diff] [blame] | 280 | const std::vector<Loop *> *Vec = &CurrentLoop->getSubLoops(); |
| 281 | while (!Vec->empty()) { |
Karthik Bhat | 88db86d | 2015-03-06 10:11:25 +0000 | [diff] [blame] | 282 | // The current loop has multiple subloops in it hence it is not tightly |
| 283 | // nested. |
| 284 | // Discard all loops above it added into Worklist. |
Benjamin Kramer | e448b5b | 2015-07-13 17:21:14 +0000 | [diff] [blame] | 285 | if (Vec->size() != 1) { |
Karthik Bhat | 88db86d | 2015-03-06 10:11:25 +0000 | [diff] [blame] | 286 | LoopList.clear(); |
| 287 | return; |
| 288 | } |
| 289 | LoopList.push_back(CurrentLoop); |
Benjamin Kramer | e448b5b | 2015-07-13 17:21:14 +0000 | [diff] [blame] | 290 | CurrentLoop = Vec->front(); |
| 291 | Vec = &CurrentLoop->getSubLoops(); |
Karthik Bhat | 88db86d | 2015-03-06 10:11:25 +0000 | [diff] [blame] | 292 | } |
| 293 | LoopList.push_back(CurrentLoop); |
Benjamin Kramer | e448b5b | 2015-07-13 17:21:14 +0000 | [diff] [blame] | 294 | V.push_back(std::move(LoopList)); |
Karthik Bhat | 88db86d | 2015-03-06 10:11:25 +0000 | [diff] [blame] | 295 | } |
| 296 | |
| 297 | static PHINode *getInductionVariable(Loop *L, ScalarEvolution *SE) { |
| 298 | PHINode *InnerIndexVar = L->getCanonicalInductionVariable(); |
| 299 | if (InnerIndexVar) |
| 300 | return InnerIndexVar; |
| 301 | if (L->getLoopLatch() == nullptr || L->getLoopPredecessor() == nullptr) |
| 302 | return nullptr; |
| 303 | for (BasicBlock::iterator I = L->getHeader()->begin(); isa<PHINode>(I); ++I) { |
| 304 | PHINode *PhiVar = cast<PHINode>(I); |
| 305 | Type *PhiTy = PhiVar->getType(); |
| 306 | if (!PhiTy->isIntegerTy() && !PhiTy->isFloatingPointTy() && |
| 307 | !PhiTy->isPointerTy()) |
| 308 | return nullptr; |
| 309 | const SCEVAddRecExpr *AddRec = |
| 310 | dyn_cast<SCEVAddRecExpr>(SE->getSCEV(PhiVar)); |
| 311 | if (!AddRec || !AddRec->isAffine()) |
| 312 | continue; |
| 313 | const SCEV *Step = AddRec->getStepRecurrence(*SE); |
Chad Rosier | f7c76f9 | 2016-09-21 13:28:41 +0000 | [diff] [blame] | 314 | if (!isa<SCEVConstant>(Step)) |
Karthik Bhat | 88db86d | 2015-03-06 10:11:25 +0000 | [diff] [blame] | 315 | continue; |
| 316 | // Found the induction variable. |
| 317 | // FIXME: Handle loops with more than one induction variable. Note that, |
| 318 | // currently, legality makes sure we have only one induction variable. |
| 319 | return PhiVar; |
| 320 | } |
| 321 | return nullptr; |
| 322 | } |
| 323 | |
Eugene Zelenko | dd40f5e | 2017-10-16 21:34:24 +0000 | [diff] [blame] | 324 | namespace { |
| 325 | |
Karthik Bhat | 88db86d | 2015-03-06 10:11:25 +0000 | [diff] [blame] | 326 | /// LoopInterchangeLegality checks if it is legal to interchange the loop. |
| 327 | class LoopInterchangeLegality { |
| 328 | public: |
| 329 | LoopInterchangeLegality(Loop *Outer, Loop *Inner, ScalarEvolution *SE, |
Florian Hahn | ad99352 | 2017-07-15 13:13:19 +0000 | [diff] [blame] | 330 | OptimizationRemarkEmitter *ORE) |
Florian Hahn | c51d088 | 2018-09-06 10:41:01 +0000 | [diff] [blame] | 331 | : OuterLoop(Outer), InnerLoop(Inner), SE(SE), ORE(ORE) {} |
Karthik Bhat | 88db86d | 2015-03-06 10:11:25 +0000 | [diff] [blame] | 332 | |
| 333 | /// Check if the loops can be interchanged. |
| 334 | bool canInterchangeLoops(unsigned InnerLoopId, unsigned OuterLoopId, |
| 335 | CharMatrix &DepMatrix); |
Eugene Zelenko | dd40f5e | 2017-10-16 21:34:24 +0000 | [diff] [blame] | 336 | |
Karthik Bhat | 88db86d | 2015-03-06 10:11:25 +0000 | [diff] [blame] | 337 | /// Check if the loop structure is understood. We do not handle triangular |
| 338 | /// loops for now. |
| 339 | bool isLoopStructureUnderstood(PHINode *InnerInductionVar); |
| 340 | |
| 341 | bool currentLimitations(); |
| 342 | |
Karthik Bhat | 8210fdf | 2015-04-23 04:51:44 +0000 | [diff] [blame] | 343 | bool hasInnerLoopReduction() { return InnerLoopHasReduction; } |
| 344 | |
Karthik Bhat | 88db86d | 2015-03-06 10:11:25 +0000 | [diff] [blame] | 345 | private: |
| 346 | bool tightlyNested(Loop *Outer, Loop *Inner); |
Karthik Bhat | 8210fdf | 2015-04-23 04:51:44 +0000 | [diff] [blame] | 347 | bool containsUnsafeInstructionsInHeader(BasicBlock *BB); |
| 348 | bool areAllUsesReductions(Instruction *Ins, Loop *L); |
| 349 | bool containsUnsafeInstructionsInLatch(BasicBlock *BB); |
| 350 | bool findInductionAndReductions(Loop *L, |
| 351 | SmallVector<PHINode *, 8> &Inductions, |
| 352 | SmallVector<PHINode *, 8> &Reductions); |
Eugene Zelenko | dd40f5e | 2017-10-16 21:34:24 +0000 | [diff] [blame] | 353 | |
Karthik Bhat | 88db86d | 2015-03-06 10:11:25 +0000 | [diff] [blame] | 354 | Loop *OuterLoop; |
| 355 | Loop *InnerLoop; |
| 356 | |
Karthik Bhat | 88db86d | 2015-03-06 10:11:25 +0000 | [diff] [blame] | 357 | ScalarEvolution *SE; |
Eugene Zelenko | dd40f5e | 2017-10-16 21:34:24 +0000 | [diff] [blame] | 358 | |
Florian Hahn | ad99352 | 2017-07-15 13:13:19 +0000 | [diff] [blame] | 359 | /// Interface to emit optimization remarks. |
| 360 | OptimizationRemarkEmitter *ORE; |
Karthik Bhat | 8210fdf | 2015-04-23 04:51:44 +0000 | [diff] [blame] | 361 | |
Eugene Zelenko | dd40f5e | 2017-10-16 21:34:24 +0000 | [diff] [blame] | 362 | bool InnerLoopHasReduction = false; |
Karthik Bhat | 88db86d | 2015-03-06 10:11:25 +0000 | [diff] [blame] | 363 | }; |
| 364 | |
| 365 | /// LoopInterchangeProfitability checks if it is profitable to interchange the |
| 366 | /// loop. |
| 367 | class LoopInterchangeProfitability { |
| 368 | public: |
Florian Hahn | ad99352 | 2017-07-15 13:13:19 +0000 | [diff] [blame] | 369 | LoopInterchangeProfitability(Loop *Outer, Loop *Inner, ScalarEvolution *SE, |
| 370 | OptimizationRemarkEmitter *ORE) |
| 371 | : OuterLoop(Outer), InnerLoop(Inner), SE(SE), ORE(ORE) {} |
Karthik Bhat | 88db86d | 2015-03-06 10:11:25 +0000 | [diff] [blame] | 372 | |
Vikram TV | 74b4111 | 2015-12-09 05:16:24 +0000 | [diff] [blame] | 373 | /// Check if the loop interchange is profitable. |
Karthik Bhat | 88db86d | 2015-03-06 10:11:25 +0000 | [diff] [blame] | 374 | bool isProfitable(unsigned InnerLoopId, unsigned OuterLoopId, |
| 375 | CharMatrix &DepMatrix); |
| 376 | |
| 377 | private: |
| 378 | int getInstrOrderCost(); |
| 379 | |
| 380 | Loop *OuterLoop; |
| 381 | Loop *InnerLoop; |
| 382 | |
| 383 | /// Scev analysis. |
| 384 | ScalarEvolution *SE; |
Eugene Zelenko | dd40f5e | 2017-10-16 21:34:24 +0000 | [diff] [blame] | 385 | |
Florian Hahn | ad99352 | 2017-07-15 13:13:19 +0000 | [diff] [blame] | 386 | /// Interface to emit optimization remarks. |
| 387 | OptimizationRemarkEmitter *ORE; |
Karthik Bhat | 88db86d | 2015-03-06 10:11:25 +0000 | [diff] [blame] | 388 | }; |
| 389 | |
Vikram TV | 74b4111 | 2015-12-09 05:16:24 +0000 | [diff] [blame] | 390 | /// LoopInterchangeTransform interchanges the loop. |
Karthik Bhat | 88db86d | 2015-03-06 10:11:25 +0000 | [diff] [blame] | 391 | class LoopInterchangeTransform { |
| 392 | public: |
| 393 | LoopInterchangeTransform(Loop *Outer, Loop *Inner, ScalarEvolution *SE, |
| 394 | LoopInfo *LI, DominatorTree *DT, |
Justin Bogner | 843fb20 | 2015-12-15 19:40:57 +0000 | [diff] [blame] | 395 | BasicBlock *LoopNestExit, |
Karthik Bhat | 8210fdf | 2015-04-23 04:51:44 +0000 | [diff] [blame] | 396 | bool InnerLoopContainsReductions) |
Karthik Bhat | 88db86d | 2015-03-06 10:11:25 +0000 | [diff] [blame] | 397 | : OuterLoop(Outer), InnerLoop(Inner), SE(SE), LI(LI), DT(DT), |
Karthik Bhat | 8210fdf | 2015-04-23 04:51:44 +0000 | [diff] [blame] | 398 | LoopExit(LoopNestExit), |
| 399 | InnerLoopHasReduction(InnerLoopContainsReductions) {} |
Karthik Bhat | 88db86d | 2015-03-06 10:11:25 +0000 | [diff] [blame] | 400 | |
| 401 | /// Interchange OuterLoop and InnerLoop. |
| 402 | bool transform(); |
Florian Hahn | 831a757 | 2018-04-05 09:48:45 +0000 | [diff] [blame] | 403 | void restructureLoops(Loop *NewInner, Loop *NewOuter, |
| 404 | BasicBlock *OrigInnerPreHeader, |
| 405 | BasicBlock *OrigOuterPreHeader); |
Karthik Bhat | 88db86d | 2015-03-06 10:11:25 +0000 | [diff] [blame] | 406 | void removeChildLoop(Loop *OuterLoop, Loop *InnerLoop); |
Karthik Bhat | 88db86d | 2015-03-06 10:11:25 +0000 | [diff] [blame] | 407 | |
| 408 | private: |
| 409 | void splitInnerLoopLatch(Instruction *); |
Karthik Bhat | 88db86d | 2015-03-06 10:11:25 +0000 | [diff] [blame] | 410 | void splitInnerLoopHeader(); |
| 411 | bool adjustLoopLinks(); |
| 412 | void adjustLoopPreheaders(); |
Karthik Bhat | 88db86d | 2015-03-06 10:11:25 +0000 | [diff] [blame] | 413 | bool adjustLoopBranches(); |
Karthik Bhat | 8210fdf | 2015-04-23 04:51:44 +0000 | [diff] [blame] | 414 | void updateIncomingBlock(BasicBlock *CurrBlock, BasicBlock *OldPred, |
| 415 | BasicBlock *NewPred); |
Karthik Bhat | 88db86d | 2015-03-06 10:11:25 +0000 | [diff] [blame] | 416 | |
| 417 | Loop *OuterLoop; |
| 418 | Loop *InnerLoop; |
| 419 | |
| 420 | /// Scev analysis. |
| 421 | ScalarEvolution *SE; |
Eugene Zelenko | dd40f5e | 2017-10-16 21:34:24 +0000 | [diff] [blame] | 422 | |
Karthik Bhat | 88db86d | 2015-03-06 10:11:25 +0000 | [diff] [blame] | 423 | LoopInfo *LI; |
| 424 | DominatorTree *DT; |
| 425 | BasicBlock *LoopExit; |
Karthik Bhat | 8210fdf | 2015-04-23 04:51:44 +0000 | [diff] [blame] | 426 | bool InnerLoopHasReduction; |
Karthik Bhat | 88db86d | 2015-03-06 10:11:25 +0000 | [diff] [blame] | 427 | }; |
| 428 | |
Vikram TV | 74b4111 | 2015-12-09 05:16:24 +0000 | [diff] [blame] | 429 | // Main LoopInterchange Pass. |
Karthik Bhat | 88db86d | 2015-03-06 10:11:25 +0000 | [diff] [blame] | 430 | struct LoopInterchange : public FunctionPass { |
| 431 | static char ID; |
Eugene Zelenko | dd40f5e | 2017-10-16 21:34:24 +0000 | [diff] [blame] | 432 | ScalarEvolution *SE = nullptr; |
| 433 | LoopInfo *LI = nullptr; |
| 434 | DependenceInfo *DI = nullptr; |
| 435 | DominatorTree *DT = nullptr; |
Justin Bogner | 843fb20 | 2015-12-15 19:40:57 +0000 | [diff] [blame] | 436 | bool PreserveLCSSA; |
Eugene Zelenko | dd40f5e | 2017-10-16 21:34:24 +0000 | [diff] [blame] | 437 | |
Florian Hahn | ad99352 | 2017-07-15 13:13:19 +0000 | [diff] [blame] | 438 | /// Interface to emit optimization remarks. |
| 439 | OptimizationRemarkEmitter *ORE; |
| 440 | |
Eugene Zelenko | dd40f5e | 2017-10-16 21:34:24 +0000 | [diff] [blame] | 441 | LoopInterchange() : FunctionPass(ID) { |
Karthik Bhat | 88db86d | 2015-03-06 10:11:25 +0000 | [diff] [blame] | 442 | initializeLoopInterchangePass(*PassRegistry::getPassRegistry()); |
| 443 | } |
| 444 | |
| 445 | void getAnalysisUsage(AnalysisUsage &AU) const override { |
Chandler Carruth | 2f1fd16 | 2015-08-17 02:08:17 +0000 | [diff] [blame] | 446 | AU.addRequired<ScalarEvolutionWrapperPass>(); |
Chandler Carruth | 7b560d4 | 2015-09-09 17:55:00 +0000 | [diff] [blame] | 447 | AU.addRequired<AAResultsWrapperPass>(); |
Karthik Bhat | 88db86d | 2015-03-06 10:11:25 +0000 | [diff] [blame] | 448 | AU.addRequired<DominatorTreeWrapperPass>(); |
| 449 | AU.addRequired<LoopInfoWrapperPass>(); |
Chandler Carruth | 49c2219 | 2016-05-12 22:19:39 +0000 | [diff] [blame] | 450 | AU.addRequired<DependenceAnalysisWrapperPass>(); |
Karthik Bhat | 88db86d | 2015-03-06 10:11:25 +0000 | [diff] [blame] | 451 | AU.addRequiredID(LoopSimplifyID); |
| 452 | AU.addRequiredID(LCSSAID); |
Florian Hahn | ad99352 | 2017-07-15 13:13:19 +0000 | [diff] [blame] | 453 | AU.addRequired<OptimizationRemarkEmitterWrapperPass>(); |
Florian Hahn | c6296fe | 2018-02-14 13:13:15 +0000 | [diff] [blame] | 454 | |
| 455 | AU.addPreserved<DominatorTreeWrapperPass>(); |
Florian Hahn | 831a757 | 2018-04-05 09:48:45 +0000 | [diff] [blame] | 456 | AU.addPreserved<LoopInfoWrapperPass>(); |
Florian Hahn | 3afb974 | 2018-09-14 07:50:20 +0000 | [diff] [blame] | 457 | AU.addPreserved<ScalarEvolutionWrapperPass>(); |
Karthik Bhat | 88db86d | 2015-03-06 10:11:25 +0000 | [diff] [blame] | 458 | } |
| 459 | |
| 460 | bool runOnFunction(Function &F) override { |
Andrew Kaylor | 50271f7 | 2016-05-03 22:32:30 +0000 | [diff] [blame] | 461 | if (skipFunction(F)) |
| 462 | return false; |
| 463 | |
Chandler Carruth | 2f1fd16 | 2015-08-17 02:08:17 +0000 | [diff] [blame] | 464 | SE = &getAnalysis<ScalarEvolutionWrapperPass>().getSE(); |
Karthik Bhat | 88db86d | 2015-03-06 10:11:25 +0000 | [diff] [blame] | 465 | LI = &getAnalysis<LoopInfoWrapperPass>().getLoopInfo(); |
Chandler Carruth | 49c2219 | 2016-05-12 22:19:39 +0000 | [diff] [blame] | 466 | DI = &getAnalysis<DependenceAnalysisWrapperPass>().getDI(); |
Florian Hahn | c6296fe | 2018-02-14 13:13:15 +0000 | [diff] [blame] | 467 | DT = &getAnalysis<DominatorTreeWrapperPass>().getDomTree(); |
Florian Hahn | ad99352 | 2017-07-15 13:13:19 +0000 | [diff] [blame] | 468 | ORE = &getAnalysis<OptimizationRemarkEmitterWrapperPass>().getORE(); |
Justin Bogner | 843fb20 | 2015-12-15 19:40:57 +0000 | [diff] [blame] | 469 | PreserveLCSSA = mustPreserveAnalysisID(LCSSAID); |
| 470 | |
Karthik Bhat | 88db86d | 2015-03-06 10:11:25 +0000 | [diff] [blame] | 471 | // Build up a worklist of loop pairs to analyze. |
| 472 | SmallVector<LoopVector, 8> Worklist; |
| 473 | |
| 474 | for (Loop *L : *LI) |
| 475 | populateWorklist(*L, Worklist); |
| 476 | |
Nicola Zaghen | d34e60c | 2018-05-14 12:53:11 +0000 | [diff] [blame] | 477 | LLVM_DEBUG(dbgs() << "Worklist size = " << Worklist.size() << "\n"); |
Karthik Bhat | 88db86d | 2015-03-06 10:11:25 +0000 | [diff] [blame] | 478 | bool Changed = true; |
| 479 | while (!Worklist.empty()) { |
| 480 | LoopVector LoopList = Worklist.pop_back_val(); |
Karthik Bhat | 8210fdf | 2015-04-23 04:51:44 +0000 | [diff] [blame] | 481 | Changed = processLoopList(LoopList, F); |
Karthik Bhat | 88db86d | 2015-03-06 10:11:25 +0000 | [diff] [blame] | 482 | } |
| 483 | return Changed; |
| 484 | } |
| 485 | |
| 486 | bool isComputableLoopNest(LoopVector LoopList) { |
Benjamin Kramer | 135f735 | 2016-06-26 12:28:59 +0000 | [diff] [blame] | 487 | for (Loop *L : LoopList) { |
Karthik Bhat | 88db86d | 2015-03-06 10:11:25 +0000 | [diff] [blame] | 488 | const SCEV *ExitCountOuter = SE->getBackedgeTakenCount(L); |
| 489 | if (ExitCountOuter == SE->getCouldNotCompute()) { |
Nicola Zaghen | d34e60c | 2018-05-14 12:53:11 +0000 | [diff] [blame] | 490 | LLVM_DEBUG(dbgs() << "Couldn't compute backedge count\n"); |
Karthik Bhat | 88db86d | 2015-03-06 10:11:25 +0000 | [diff] [blame] | 491 | return false; |
| 492 | } |
| 493 | if (L->getNumBackEdges() != 1) { |
Nicola Zaghen | d34e60c | 2018-05-14 12:53:11 +0000 | [diff] [blame] | 494 | LLVM_DEBUG(dbgs() << "NumBackEdges is not equal to 1\n"); |
Karthik Bhat | 88db86d | 2015-03-06 10:11:25 +0000 | [diff] [blame] | 495 | return false; |
| 496 | } |
| 497 | if (!L->getExitingBlock()) { |
Nicola Zaghen | d34e60c | 2018-05-14 12:53:11 +0000 | [diff] [blame] | 498 | LLVM_DEBUG(dbgs() << "Loop doesn't have unique exit block\n"); |
Karthik Bhat | 88db86d | 2015-03-06 10:11:25 +0000 | [diff] [blame] | 499 | return false; |
| 500 | } |
| 501 | } |
| 502 | return true; |
| 503 | } |
| 504 | |
Benjamin Kramer | c321e53 | 2016-06-08 19:09:22 +0000 | [diff] [blame] | 505 | unsigned selectLoopForInterchange(const LoopVector &LoopList) { |
Karthik Bhat | 88db86d | 2015-03-06 10:11:25 +0000 | [diff] [blame] | 506 | // TODO: Add a better heuristic to select the loop to be interchanged based |
Benjamin Kramer | df005cb | 2015-08-08 18:27:36 +0000 | [diff] [blame] | 507 | // on the dependence matrix. Currently we select the innermost loop. |
Karthik Bhat | 88db86d | 2015-03-06 10:11:25 +0000 | [diff] [blame] | 508 | return LoopList.size() - 1; |
| 509 | } |
| 510 | |
Karthik Bhat | 8210fdf | 2015-04-23 04:51:44 +0000 | [diff] [blame] | 511 | bool processLoopList(LoopVector LoopList, Function &F) { |
Karthik Bhat | 88db86d | 2015-03-06 10:11:25 +0000 | [diff] [blame] | 512 | bool Changed = false; |
Chad Rosier | 7ea0d39 | 2016-09-13 13:30:30 +0000 | [diff] [blame] | 513 | unsigned LoopNestDepth = LoopList.size(); |
| 514 | if (LoopNestDepth < 2) { |
Nicola Zaghen | d34e60c | 2018-05-14 12:53:11 +0000 | [diff] [blame] | 515 | LLVM_DEBUG(dbgs() << "Loop doesn't contain minimum nesting level.\n"); |
Karthik Bhat | 88db86d | 2015-03-06 10:11:25 +0000 | [diff] [blame] | 516 | return false; |
| 517 | } |
Chad Rosier | 7ea0d39 | 2016-09-13 13:30:30 +0000 | [diff] [blame] | 518 | if (LoopNestDepth > MaxLoopNestDepth) { |
Nicola Zaghen | d34e60c | 2018-05-14 12:53:11 +0000 | [diff] [blame] | 519 | LLVM_DEBUG(dbgs() << "Cannot handle loops of depth greater than " |
| 520 | << MaxLoopNestDepth << "\n"); |
Chad Rosier | 7ea0d39 | 2016-09-13 13:30:30 +0000 | [diff] [blame] | 521 | return false; |
| 522 | } |
Karthik Bhat | 88db86d | 2015-03-06 10:11:25 +0000 | [diff] [blame] | 523 | if (!isComputableLoopNest(LoopList)) { |
Nicola Zaghen | d34e60c | 2018-05-14 12:53:11 +0000 | [diff] [blame] | 524 | LLVM_DEBUG(dbgs() << "Not valid loop candidate for interchange\n"); |
Karthik Bhat | 88db86d | 2015-03-06 10:11:25 +0000 | [diff] [blame] | 525 | return false; |
| 526 | } |
Chad Rosier | 7ea0d39 | 2016-09-13 13:30:30 +0000 | [diff] [blame] | 527 | |
Nicola Zaghen | d34e60c | 2018-05-14 12:53:11 +0000 | [diff] [blame] | 528 | LLVM_DEBUG(dbgs() << "Processing LoopList of size = " << LoopNestDepth |
| 529 | << "\n"); |
Chad Rosier | 7ea0d39 | 2016-09-13 13:30:30 +0000 | [diff] [blame] | 530 | |
| 531 | CharMatrix DependencyMatrix; |
Karthik Bhat | 88db86d | 2015-03-06 10:11:25 +0000 | [diff] [blame] | 532 | Loop *OuterMostLoop = *(LoopList.begin()); |
Chad Rosier | 7ea0d39 | 2016-09-13 13:30:30 +0000 | [diff] [blame] | 533 | if (!populateDependencyMatrix(DependencyMatrix, LoopNestDepth, |
Chandler Carruth | 49c2219 | 2016-05-12 22:19:39 +0000 | [diff] [blame] | 534 | OuterMostLoop, DI)) { |
Nicola Zaghen | d34e60c | 2018-05-14 12:53:11 +0000 | [diff] [blame] | 535 | LLVM_DEBUG(dbgs() << "Populating dependency matrix failed\n"); |
Karthik Bhat | 88db86d | 2015-03-06 10:11:25 +0000 | [diff] [blame] | 536 | return false; |
| 537 | } |
| 538 | #ifdef DUMP_DEP_MATRICIES |
Nicola Zaghen | d34e60c | 2018-05-14 12:53:11 +0000 | [diff] [blame] | 539 | LLVM_DEBUG(dbgs() << "Dependence before interchange\n"); |
Karthik Bhat | 88db86d | 2015-03-06 10:11:25 +0000 | [diff] [blame] | 540 | printDepMatrix(DependencyMatrix); |
| 541 | #endif |
| 542 | |
Karthik Bhat | 88db86d | 2015-03-06 10:11:25 +0000 | [diff] [blame] | 543 | // Get the Outermost loop exit. |
Florian Hahn | 1da30c6 | 2018-04-25 09:35:54 +0000 | [diff] [blame] | 544 | BasicBlock *LoopNestExit = OuterMostLoop->getExitBlock(); |
| 545 | if (!LoopNestExit) { |
Nicola Zaghen | d34e60c | 2018-05-14 12:53:11 +0000 | [diff] [blame] | 546 | LLVM_DEBUG(dbgs() << "OuterMostLoop needs an unique exit block"); |
Florian Hahn | 1da30c6 | 2018-04-25 09:35:54 +0000 | [diff] [blame] | 547 | return false; |
| 548 | } |
Karthik Bhat | 88db86d | 2015-03-06 10:11:25 +0000 | [diff] [blame] | 549 | |
Karthik Bhat | 88db86d | 2015-03-06 10:11:25 +0000 | [diff] [blame] | 550 | unsigned SelecLoopId = selectLoopForInterchange(LoopList); |
Benjamin Kramer | df005cb | 2015-08-08 18:27:36 +0000 | [diff] [blame] | 551 | // Move the selected loop outwards to the best possible position. |
Karthik Bhat | 88db86d | 2015-03-06 10:11:25 +0000 | [diff] [blame] | 552 | for (unsigned i = SelecLoopId; i > 0; i--) { |
| 553 | bool Interchanged = |
| 554 | processLoop(LoopList, i, i - 1, LoopNestExit, DependencyMatrix); |
| 555 | if (!Interchanged) |
| 556 | return Changed; |
| 557 | // Loops interchanged reflect the same in LoopList |
Benjamin Kramer | 7944292 | 2015-03-06 18:59:14 +0000 | [diff] [blame] | 558 | std::swap(LoopList[i - 1], LoopList[i]); |
Karthik Bhat | 88db86d | 2015-03-06 10:11:25 +0000 | [diff] [blame] | 559 | |
| 560 | // Update the DependencyMatrix |
Chad Rosier | d18ea06 | 2016-09-13 13:00:29 +0000 | [diff] [blame] | 561 | interChangeDependencies(DependencyMatrix, i, i - 1); |
Karthik Bhat | 88db86d | 2015-03-06 10:11:25 +0000 | [diff] [blame] | 562 | #ifdef DUMP_DEP_MATRICIES |
Nicola Zaghen | d34e60c | 2018-05-14 12:53:11 +0000 | [diff] [blame] | 563 | LLVM_DEBUG(dbgs() << "Dependence after interchange\n"); |
Karthik Bhat | 88db86d | 2015-03-06 10:11:25 +0000 | [diff] [blame] | 564 | printDepMatrix(DependencyMatrix); |
| 565 | #endif |
| 566 | Changed |= Interchanged; |
| 567 | } |
| 568 | return Changed; |
| 569 | } |
| 570 | |
| 571 | bool processLoop(LoopVector LoopList, unsigned InnerLoopId, |
| 572 | unsigned OuterLoopId, BasicBlock *LoopNestExit, |
| 573 | std::vector<std::vector<char>> &DependencyMatrix) { |
Nicola Zaghen | d34e60c | 2018-05-14 12:53:11 +0000 | [diff] [blame] | 574 | LLVM_DEBUG(dbgs() << "Processing Inner Loop Id = " << InnerLoopId |
| 575 | << " and OuterLoopId = " << OuterLoopId << "\n"); |
Karthik Bhat | 88db86d | 2015-03-06 10:11:25 +0000 | [diff] [blame] | 576 | Loop *InnerLoop = LoopList[InnerLoopId]; |
| 577 | Loop *OuterLoop = LoopList[OuterLoopId]; |
| 578 | |
Florian Hahn | c51d088 | 2018-09-06 10:41:01 +0000 | [diff] [blame] | 579 | LoopInterchangeLegality LIL(OuterLoop, InnerLoop, SE, ORE); |
Karthik Bhat | 88db86d | 2015-03-06 10:11:25 +0000 | [diff] [blame] | 580 | if (!LIL.canInterchangeLoops(InnerLoopId, OuterLoopId, DependencyMatrix)) { |
Nicola Zaghen | d34e60c | 2018-05-14 12:53:11 +0000 | [diff] [blame] | 581 | LLVM_DEBUG(dbgs() << "Not interchanging loops. Cannot prove legality.\n"); |
Karthik Bhat | 88db86d | 2015-03-06 10:11:25 +0000 | [diff] [blame] | 582 | return false; |
| 583 | } |
Nicola Zaghen | d34e60c | 2018-05-14 12:53:11 +0000 | [diff] [blame] | 584 | LLVM_DEBUG(dbgs() << "Loops are legal to interchange\n"); |
Florian Hahn | ad99352 | 2017-07-15 13:13:19 +0000 | [diff] [blame] | 585 | LoopInterchangeProfitability LIP(OuterLoop, InnerLoop, SE, ORE); |
Karthik Bhat | 88db86d | 2015-03-06 10:11:25 +0000 | [diff] [blame] | 586 | if (!LIP.isProfitable(InnerLoopId, OuterLoopId, DependencyMatrix)) { |
Nicola Zaghen | d34e60c | 2018-05-14 12:53:11 +0000 | [diff] [blame] | 587 | LLVM_DEBUG(dbgs() << "Interchanging loops not profitable.\n"); |
Karthik Bhat | 88db86d | 2015-03-06 10:11:25 +0000 | [diff] [blame] | 588 | return false; |
| 589 | } |
| 590 | |
Vivek Pandya | 9590658 | 2017-10-11 17:12:59 +0000 | [diff] [blame] | 591 | ORE->emit([&]() { |
| 592 | return OptimizationRemark(DEBUG_TYPE, "Interchanged", |
| 593 | InnerLoop->getStartLoc(), |
| 594 | InnerLoop->getHeader()) |
| 595 | << "Loop interchanged with enclosing loop."; |
| 596 | }); |
Florian Hahn | ad99352 | 2017-07-15 13:13:19 +0000 | [diff] [blame] | 597 | |
Justin Bogner | 843fb20 | 2015-12-15 19:40:57 +0000 | [diff] [blame] | 598 | LoopInterchangeTransform LIT(OuterLoop, InnerLoop, SE, LI, DT, |
Karthik Bhat | 8210fdf | 2015-04-23 04:51:44 +0000 | [diff] [blame] | 599 | LoopNestExit, LIL.hasInnerLoopReduction()); |
Karthik Bhat | 88db86d | 2015-03-06 10:11:25 +0000 | [diff] [blame] | 600 | LIT.transform(); |
Nicola Zaghen | d34e60c | 2018-05-14 12:53:11 +0000 | [diff] [blame] | 601 | LLVM_DEBUG(dbgs() << "Loops interchanged.\n"); |
Florian Hahn | 6e00433 | 2018-04-05 10:39:23 +0000 | [diff] [blame] | 602 | LoopsInterchanged++; |
Karthik Bhat | 88db86d | 2015-03-06 10:11:25 +0000 | [diff] [blame] | 603 | return true; |
| 604 | } |
| 605 | }; |
| 606 | |
Eugene Zelenko | dd40f5e | 2017-10-16 21:34:24 +0000 | [diff] [blame] | 607 | } // end anonymous namespace |
| 608 | |
Karthik Bhat | 8210fdf | 2015-04-23 04:51:44 +0000 | [diff] [blame] | 609 | bool LoopInterchangeLegality::areAllUsesReductions(Instruction *Ins, Loop *L) { |
Eugene Zelenko | dd40f5e | 2017-10-16 21:34:24 +0000 | [diff] [blame] | 610 | return llvm::none_of(Ins->users(), [=](User *U) -> bool { |
David Majnemer | 0a16c22 | 2016-08-11 21:15:00 +0000 | [diff] [blame] | 611 | auto *UserIns = dyn_cast<PHINode>(U); |
Tyler Nowicki | 0a91310 | 2015-06-16 18:07:34 +0000 | [diff] [blame] | 612 | RecurrenceDescriptor RD; |
| 613 | return !UserIns || !RecurrenceDescriptor::isReductionPHI(UserIns, L, RD); |
Karthik Bhat | 8210fdf | 2015-04-23 04:51:44 +0000 | [diff] [blame] | 614 | }); |
| 615 | } |
Karthik Bhat | 88db86d | 2015-03-06 10:11:25 +0000 | [diff] [blame] | 616 | |
Karthik Bhat | 8210fdf | 2015-04-23 04:51:44 +0000 | [diff] [blame] | 617 | bool LoopInterchangeLegality::containsUnsafeInstructionsInHeader( |
| 618 | BasicBlock *BB) { |
Florian Hahn | 5912c66 | 2018-05-02 10:53:04 +0000 | [diff] [blame] | 619 | for (Instruction &I : *BB) { |
Karthik Bhat | 8210fdf | 2015-04-23 04:51:44 +0000 | [diff] [blame] | 620 | // Load corresponding to reduction PHI's are safe while concluding if |
| 621 | // tightly nested. |
Florian Hahn | 5912c66 | 2018-05-02 10:53:04 +0000 | [diff] [blame] | 622 | if (LoadInst *L = dyn_cast<LoadInst>(&I)) { |
Karthik Bhat | 8210fdf | 2015-04-23 04:51:44 +0000 | [diff] [blame] | 623 | if (!areAllUsesReductions(L, InnerLoop)) |
| 624 | return true; |
Florian Hahn | 5912c66 | 2018-05-02 10:53:04 +0000 | [diff] [blame] | 625 | } else if (I.mayHaveSideEffects() || I.mayReadFromMemory()) |
Karthik Bhat | 8210fdf | 2015-04-23 04:51:44 +0000 | [diff] [blame] | 626 | return true; |
| 627 | } |
| 628 | return false; |
| 629 | } |
| 630 | |
| 631 | bool LoopInterchangeLegality::containsUnsafeInstructionsInLatch( |
| 632 | BasicBlock *BB) { |
Florian Hahn | 5912c66 | 2018-05-02 10:53:04 +0000 | [diff] [blame] | 633 | for (Instruction &I : *BB) { |
Karthik Bhat | 8210fdf | 2015-04-23 04:51:44 +0000 | [diff] [blame] | 634 | // Stores corresponding to reductions are safe while concluding if tightly |
| 635 | // nested. |
Florian Hahn | 5912c66 | 2018-05-02 10:53:04 +0000 | [diff] [blame] | 636 | if (StoreInst *L = dyn_cast<StoreInst>(&I)) { |
Chad Rosier | f7c76f9 | 2016-09-21 13:28:41 +0000 | [diff] [blame] | 637 | if (!isa<PHINode>(L->getOperand(0))) |
Karthik Bhat | 8210fdf | 2015-04-23 04:51:44 +0000 | [diff] [blame] | 638 | return true; |
Florian Hahn | 5912c66 | 2018-05-02 10:53:04 +0000 | [diff] [blame] | 639 | } else if (I.mayHaveSideEffects() || I.mayReadFromMemory()) |
Karthik Bhat | 88db86d | 2015-03-06 10:11:25 +0000 | [diff] [blame] | 640 | return true; |
| 641 | } |
| 642 | return false; |
| 643 | } |
| 644 | |
| 645 | bool LoopInterchangeLegality::tightlyNested(Loop *OuterLoop, Loop *InnerLoop) { |
| 646 | BasicBlock *OuterLoopHeader = OuterLoop->getHeader(); |
| 647 | BasicBlock *InnerLoopPreHeader = InnerLoop->getLoopPreheader(); |
| 648 | BasicBlock *OuterLoopLatch = OuterLoop->getLoopLatch(); |
| 649 | |
Nicola Zaghen | d34e60c | 2018-05-14 12:53:11 +0000 | [diff] [blame] | 650 | LLVM_DEBUG(dbgs() << "Checking if loops are tightly nested\n"); |
Karthik Bhat | 88db86d | 2015-03-06 10:11:25 +0000 | [diff] [blame] | 651 | |
| 652 | // A perfectly nested loop will not have any branch in between the outer and |
| 653 | // inner block i.e. outer header will branch to either inner preheader and |
| 654 | // outerloop latch. |
Chad Rosier | f7c76f9 | 2016-09-21 13:28:41 +0000 | [diff] [blame] | 655 | BranchInst *OuterLoopHeaderBI = |
Karthik Bhat | 88db86d | 2015-03-06 10:11:25 +0000 | [diff] [blame] | 656 | dyn_cast<BranchInst>(OuterLoopHeader->getTerminator()); |
Chad Rosier | f7c76f9 | 2016-09-21 13:28:41 +0000 | [diff] [blame] | 657 | if (!OuterLoopHeaderBI) |
Karthik Bhat | 88db86d | 2015-03-06 10:11:25 +0000 | [diff] [blame] | 658 | return false; |
Chad Rosier | f7c76f9 | 2016-09-21 13:28:41 +0000 | [diff] [blame] | 659 | |
Chandler Carruth | 96fc1de | 2018-08-26 08:41:15 +0000 | [diff] [blame] | 660 | for (BasicBlock *Succ : successors(OuterLoopHeaderBI)) |
Florian Hahn | 236f6fe | 2018-09-06 09:57:27 +0000 | [diff] [blame] | 661 | if (Succ != InnerLoopPreHeader && Succ != InnerLoop->getHeader() && |
| 662 | Succ != OuterLoopLatch) |
Karthik Bhat | 88db86d | 2015-03-06 10:11:25 +0000 | [diff] [blame] | 663 | return false; |
Karthik Bhat | 88db86d | 2015-03-06 10:11:25 +0000 | [diff] [blame] | 664 | |
Nicola Zaghen | d34e60c | 2018-05-14 12:53:11 +0000 | [diff] [blame] | 665 | LLVM_DEBUG(dbgs() << "Checking instructions in Loop header and Loop latch\n"); |
Karthik Bhat | 88db86d | 2015-03-06 10:11:25 +0000 | [diff] [blame] | 666 | // We do not have any basic block in between now make sure the outer header |
Benjamin Kramer | df005cb | 2015-08-08 18:27:36 +0000 | [diff] [blame] | 667 | // and outer loop latch doesn't contain any unsafe instructions. |
Karthik Bhat | 8210fdf | 2015-04-23 04:51:44 +0000 | [diff] [blame] | 668 | if (containsUnsafeInstructionsInHeader(OuterLoopHeader) || |
| 669 | containsUnsafeInstructionsInLatch(OuterLoopLatch)) |
Karthik Bhat | 88db86d | 2015-03-06 10:11:25 +0000 | [diff] [blame] | 670 | return false; |
| 671 | |
Nicola Zaghen | d34e60c | 2018-05-14 12:53:11 +0000 | [diff] [blame] | 672 | LLVM_DEBUG(dbgs() << "Loops are perfectly nested\n"); |
Karthik Bhat | 88db86d | 2015-03-06 10:11:25 +0000 | [diff] [blame] | 673 | // We have a perfect loop nest. |
| 674 | return true; |
| 675 | } |
| 676 | |
Karthik Bhat | 88db86d | 2015-03-06 10:11:25 +0000 | [diff] [blame] | 677 | bool LoopInterchangeLegality::isLoopStructureUnderstood( |
| 678 | PHINode *InnerInduction) { |
Karthik Bhat | 88db86d | 2015-03-06 10:11:25 +0000 | [diff] [blame] | 679 | unsigned Num = InnerInduction->getNumOperands(); |
| 680 | BasicBlock *InnerLoopPreheader = InnerLoop->getLoopPreheader(); |
| 681 | for (unsigned i = 0; i < Num; ++i) { |
| 682 | Value *Val = InnerInduction->getOperand(i); |
| 683 | if (isa<Constant>(Val)) |
| 684 | continue; |
| 685 | Instruction *I = dyn_cast<Instruction>(Val); |
| 686 | if (!I) |
| 687 | return false; |
| 688 | // TODO: Handle triangular loops. |
| 689 | // e.g. for(int i=0;i<N;i++) |
| 690 | // for(int j=i;j<N;j++) |
| 691 | unsigned IncomBlockIndx = PHINode::getIncomingValueNumForOperand(i); |
| 692 | if (InnerInduction->getIncomingBlock(IncomBlockIndx) == |
| 693 | InnerLoopPreheader && |
| 694 | !OuterLoop->isLoopInvariant(I)) { |
| 695 | return false; |
| 696 | } |
| 697 | } |
| 698 | return true; |
| 699 | } |
| 700 | |
Karthik Bhat | 8210fdf | 2015-04-23 04:51:44 +0000 | [diff] [blame] | 701 | bool LoopInterchangeLegality::findInductionAndReductions( |
| 702 | Loop *L, SmallVector<PHINode *, 8> &Inductions, |
| 703 | SmallVector<PHINode *, 8> &Reductions) { |
| 704 | if (!L->getLoopLatch() || !L->getLoopPredecessor()) |
| 705 | return false; |
Florian Hahn | 5912c66 | 2018-05-02 10:53:04 +0000 | [diff] [blame] | 706 | for (PHINode &PHI : L->getHeader()->phis()) { |
Tyler Nowicki | 0a91310 | 2015-06-16 18:07:34 +0000 | [diff] [blame] | 707 | RecurrenceDescriptor RD; |
James Molloy | 1bbf15c | 2015-08-27 09:53:00 +0000 | [diff] [blame] | 708 | InductionDescriptor ID; |
Florian Hahn | 5912c66 | 2018-05-02 10:53:04 +0000 | [diff] [blame] | 709 | if (InductionDescriptor::isInductionPHI(&PHI, L, SE, ID)) |
| 710 | Inductions.push_back(&PHI); |
| 711 | else if (RecurrenceDescriptor::isReductionPHI(&PHI, L, RD)) |
| 712 | Reductions.push_back(&PHI); |
Karthik Bhat | 8210fdf | 2015-04-23 04:51:44 +0000 | [diff] [blame] | 713 | else { |
Nicola Zaghen | d34e60c | 2018-05-14 12:53:11 +0000 | [diff] [blame] | 714 | LLVM_DEBUG( |
Karthik Bhat | 8210fdf | 2015-04-23 04:51:44 +0000 | [diff] [blame] | 715 | dbgs() << "Failed to recognize PHI as an induction or reduction.\n"); |
| 716 | return false; |
| 717 | } |
| 718 | } |
| 719 | return true; |
| 720 | } |
| 721 | |
| 722 | static bool containsSafePHI(BasicBlock *Block, bool isOuterLoopExitBlock) { |
Florian Hahn | 5912c66 | 2018-05-02 10:53:04 +0000 | [diff] [blame] | 723 | for (PHINode &PHI : Block->phis()) { |
Karthik Bhat | 8210fdf | 2015-04-23 04:51:44 +0000 | [diff] [blame] | 724 | // Reduction lcssa phi will have only 1 incoming block that from loop latch. |
Florian Hahn | 5912c66 | 2018-05-02 10:53:04 +0000 | [diff] [blame] | 725 | if (PHI.getNumIncomingValues() > 1) |
Karthik Bhat | 8210fdf | 2015-04-23 04:51:44 +0000 | [diff] [blame] | 726 | return false; |
Florian Hahn | 5912c66 | 2018-05-02 10:53:04 +0000 | [diff] [blame] | 727 | Instruction *Ins = dyn_cast<Instruction>(PHI.getIncomingValue(0)); |
Karthik Bhat | 8210fdf | 2015-04-23 04:51:44 +0000 | [diff] [blame] | 728 | if (!Ins) |
| 729 | return false; |
| 730 | // Incoming value for lcssa phi's in outer loop exit can only be inner loop |
| 731 | // exits lcssa phi else it would not be tightly nested. |
| 732 | if (!isa<PHINode>(Ins) && isOuterLoopExitBlock) |
| 733 | return false; |
| 734 | } |
| 735 | return true; |
| 736 | } |
| 737 | |
Karthik Bhat | 88db86d | 2015-03-06 10:11:25 +0000 | [diff] [blame] | 738 | // This function indicates the current limitations in the transform as a result |
| 739 | // of which we do not proceed. |
| 740 | bool LoopInterchangeLegality::currentLimitations() { |
Karthik Bhat | 88db86d | 2015-03-06 10:11:25 +0000 | [diff] [blame] | 741 | BasicBlock *InnerLoopPreHeader = InnerLoop->getLoopPreheader(); |
Karthik Bhat | 88db86d | 2015-03-06 10:11:25 +0000 | [diff] [blame] | 742 | BasicBlock *InnerLoopLatch = InnerLoop->getLoopLatch(); |
Florian Hahn | 1da30c6 | 2018-04-25 09:35:54 +0000 | [diff] [blame] | 743 | |
| 744 | // transform currently expects the loop latches to also be the exiting |
| 745 | // blocks. |
| 746 | if (InnerLoop->getExitingBlock() != InnerLoopLatch || |
| 747 | OuterLoop->getExitingBlock() != OuterLoop->getLoopLatch() || |
| 748 | !isa<BranchInst>(InnerLoopLatch->getTerminator()) || |
| 749 | !isa<BranchInst>(OuterLoop->getLoopLatch()->getTerminator())) { |
Nicola Zaghen | d34e60c | 2018-05-14 12:53:11 +0000 | [diff] [blame] | 750 | LLVM_DEBUG( |
| 751 | dbgs() << "Loops where the latch is not the exiting block are not" |
| 752 | << " supported currently.\n"); |
Florian Hahn | 1da30c6 | 2018-04-25 09:35:54 +0000 | [diff] [blame] | 753 | ORE->emit([&]() { |
| 754 | return OptimizationRemarkMissed(DEBUG_TYPE, "ExitingNotLatch", |
| 755 | OuterLoop->getStartLoc(), |
| 756 | OuterLoop->getHeader()) |
| 757 | << "Loops where the latch is not the exiting block cannot be" |
| 758 | " interchange currently."; |
| 759 | }); |
| 760 | return true; |
| 761 | } |
Karthik Bhat | 88db86d | 2015-03-06 10:11:25 +0000 | [diff] [blame] | 762 | |
| 763 | PHINode *InnerInductionVar; |
Karthik Bhat | 8210fdf | 2015-04-23 04:51:44 +0000 | [diff] [blame] | 764 | SmallVector<PHINode *, 8> Inductions; |
| 765 | SmallVector<PHINode *, 8> Reductions; |
Florian Hahn | 4eeff39 | 2017-07-03 15:32:00 +0000 | [diff] [blame] | 766 | if (!findInductionAndReductions(InnerLoop, Inductions, Reductions)) { |
Nicola Zaghen | d34e60c | 2018-05-14 12:53:11 +0000 | [diff] [blame] | 767 | LLVM_DEBUG( |
| 768 | dbgs() << "Only inner loops with induction or reduction PHI nodes " |
| 769 | << "are supported currently.\n"); |
Vivek Pandya | 9590658 | 2017-10-11 17:12:59 +0000 | [diff] [blame] | 770 | ORE->emit([&]() { |
| 771 | return OptimizationRemarkMissed(DEBUG_TYPE, "UnsupportedPHIInner", |
| 772 | InnerLoop->getStartLoc(), |
| 773 | InnerLoop->getHeader()) |
| 774 | << "Only inner loops with induction or reduction PHI nodes can be" |
| 775 | " interchange currently."; |
| 776 | }); |
Karthik Bhat | 88db86d | 2015-03-06 10:11:25 +0000 | [diff] [blame] | 777 | return true; |
Florian Hahn | 4eeff39 | 2017-07-03 15:32:00 +0000 | [diff] [blame] | 778 | } |
Karthik Bhat | 88db86d | 2015-03-06 10:11:25 +0000 | [diff] [blame] | 779 | |
Karthik Bhat | 8210fdf | 2015-04-23 04:51:44 +0000 | [diff] [blame] | 780 | // TODO: Currently we handle only loops with 1 induction variable. |
| 781 | if (Inductions.size() != 1) { |
Nicola Zaghen | d34e60c | 2018-05-14 12:53:11 +0000 | [diff] [blame] | 782 | LLVM_DEBUG( |
| 783 | dbgs() << "We currently only support loops with 1 induction variable." |
| 784 | << "Failed to interchange due to current limitation\n"); |
Vivek Pandya | 9590658 | 2017-10-11 17:12:59 +0000 | [diff] [blame] | 785 | ORE->emit([&]() { |
| 786 | return OptimizationRemarkMissed(DEBUG_TYPE, "MultiInductionInner", |
| 787 | InnerLoop->getStartLoc(), |
| 788 | InnerLoop->getHeader()) |
| 789 | << "Only inner loops with 1 induction variable can be " |
| 790 | "interchanged currently."; |
| 791 | }); |
Karthik Bhat | 88db86d | 2015-03-06 10:11:25 +0000 | [diff] [blame] | 792 | return true; |
| 793 | } |
Karthik Bhat | 8210fdf | 2015-04-23 04:51:44 +0000 | [diff] [blame] | 794 | if (Reductions.size() > 0) |
| 795 | InnerLoopHasReduction = true; |
| 796 | |
| 797 | InnerInductionVar = Inductions.pop_back_val(); |
| 798 | Reductions.clear(); |
Florian Hahn | 4eeff39 | 2017-07-03 15:32:00 +0000 | [diff] [blame] | 799 | if (!findInductionAndReductions(OuterLoop, Inductions, Reductions)) { |
Nicola Zaghen | d34e60c | 2018-05-14 12:53:11 +0000 | [diff] [blame] | 800 | LLVM_DEBUG( |
| 801 | dbgs() << "Only outer loops with induction or reduction PHI nodes " |
| 802 | << "are supported currently.\n"); |
Vivek Pandya | 9590658 | 2017-10-11 17:12:59 +0000 | [diff] [blame] | 803 | ORE->emit([&]() { |
| 804 | return OptimizationRemarkMissed(DEBUG_TYPE, "UnsupportedPHIOuter", |
| 805 | OuterLoop->getStartLoc(), |
| 806 | OuterLoop->getHeader()) |
| 807 | << "Only outer loops with induction or reduction PHI nodes can be" |
| 808 | " interchanged currently."; |
| 809 | }); |
Karthik Bhat | 8210fdf | 2015-04-23 04:51:44 +0000 | [diff] [blame] | 810 | return true; |
Florian Hahn | 4eeff39 | 2017-07-03 15:32:00 +0000 | [diff] [blame] | 811 | } |
Karthik Bhat | 8210fdf | 2015-04-23 04:51:44 +0000 | [diff] [blame] | 812 | |
| 813 | // Outer loop cannot have reduction because then loops will not be tightly |
| 814 | // nested. |
Florian Hahn | 4eeff39 | 2017-07-03 15:32:00 +0000 | [diff] [blame] | 815 | if (!Reductions.empty()) { |
Nicola Zaghen | d34e60c | 2018-05-14 12:53:11 +0000 | [diff] [blame] | 816 | LLVM_DEBUG(dbgs() << "Outer loops with reductions are not supported " |
| 817 | << "currently.\n"); |
Vivek Pandya | 9590658 | 2017-10-11 17:12:59 +0000 | [diff] [blame] | 818 | ORE->emit([&]() { |
| 819 | return OptimizationRemarkMissed(DEBUG_TYPE, "ReductionsOuter", |
| 820 | OuterLoop->getStartLoc(), |
| 821 | OuterLoop->getHeader()) |
| 822 | << "Outer loops with reductions cannot be interchangeed " |
| 823 | "currently."; |
| 824 | }); |
Karthik Bhat | 8210fdf | 2015-04-23 04:51:44 +0000 | [diff] [blame] | 825 | return true; |
Florian Hahn | 4eeff39 | 2017-07-03 15:32:00 +0000 | [diff] [blame] | 826 | } |
Karthik Bhat | 8210fdf | 2015-04-23 04:51:44 +0000 | [diff] [blame] | 827 | // TODO: Currently we handle only loops with 1 induction variable. |
Florian Hahn | 4eeff39 | 2017-07-03 15:32:00 +0000 | [diff] [blame] | 828 | if (Inductions.size() != 1) { |
Nicola Zaghen | d34e60c | 2018-05-14 12:53:11 +0000 | [diff] [blame] | 829 | LLVM_DEBUG(dbgs() << "Loops with more than 1 induction variables are not " |
| 830 | << "supported currently.\n"); |
Vivek Pandya | 9590658 | 2017-10-11 17:12:59 +0000 | [diff] [blame] | 831 | ORE->emit([&]() { |
| 832 | return OptimizationRemarkMissed(DEBUG_TYPE, "MultiIndutionOuter", |
| 833 | OuterLoop->getStartLoc(), |
| 834 | OuterLoop->getHeader()) |
| 835 | << "Only outer loops with 1 induction variable can be " |
| 836 | "interchanged currently."; |
| 837 | }); |
Karthik Bhat | 8210fdf | 2015-04-23 04:51:44 +0000 | [diff] [blame] | 838 | return true; |
Florian Hahn | 4eeff39 | 2017-07-03 15:32:00 +0000 | [diff] [blame] | 839 | } |
Karthik Bhat | 88db86d | 2015-03-06 10:11:25 +0000 | [diff] [blame] | 840 | |
| 841 | // TODO: Triangular loops are not handled for now. |
| 842 | if (!isLoopStructureUnderstood(InnerInductionVar)) { |
Nicola Zaghen | d34e60c | 2018-05-14 12:53:11 +0000 | [diff] [blame] | 843 | LLVM_DEBUG(dbgs() << "Loop structure not understood by pass\n"); |
Vivek Pandya | 9590658 | 2017-10-11 17:12:59 +0000 | [diff] [blame] | 844 | ORE->emit([&]() { |
| 845 | return OptimizationRemarkMissed(DEBUG_TYPE, "UnsupportedStructureInner", |
| 846 | InnerLoop->getStartLoc(), |
| 847 | InnerLoop->getHeader()) |
| 848 | << "Inner loop structure not understood currently."; |
| 849 | }); |
Karthik Bhat | 88db86d | 2015-03-06 10:11:25 +0000 | [diff] [blame] | 850 | return true; |
| 851 | } |
| 852 | |
Karthik Bhat | 8210fdf | 2015-04-23 04:51:44 +0000 | [diff] [blame] | 853 | // TODO: We only handle LCSSA PHI's corresponding to reduction for now. |
Florian Hahn | 1da30c6 | 2018-04-25 09:35:54 +0000 | [diff] [blame] | 854 | BasicBlock *InnerExit = InnerLoop->getExitBlock(); |
| 855 | if (!containsSafePHI(InnerExit, false)) { |
Nicola Zaghen | d34e60c | 2018-05-14 12:53:11 +0000 | [diff] [blame] | 856 | LLVM_DEBUG( |
| 857 | dbgs() << "Can only handle LCSSA PHIs in inner loops currently.\n"); |
Vivek Pandya | 9590658 | 2017-10-11 17:12:59 +0000 | [diff] [blame] | 858 | ORE->emit([&]() { |
| 859 | return OptimizationRemarkMissed(DEBUG_TYPE, "NoLCSSAPHIOuterInner", |
| 860 | InnerLoop->getStartLoc(), |
| 861 | InnerLoop->getHeader()) |
| 862 | << "Only inner loops with LCSSA PHIs can be interchange " |
| 863 | "currently."; |
| 864 | }); |
Karthik Bhat | 88db86d | 2015-03-06 10:11:25 +0000 | [diff] [blame] | 865 | return true; |
Florian Hahn | 4eeff39 | 2017-07-03 15:32:00 +0000 | [diff] [blame] | 866 | } |
Karthik Bhat | 88db86d | 2015-03-06 10:11:25 +0000 | [diff] [blame] | 867 | |
| 868 | // TODO: Current limitation: Since we split the inner loop latch at the point |
| 869 | // were induction variable is incremented (induction.next); We cannot have |
| 870 | // more than 1 user of induction.next since it would result in broken code |
| 871 | // after split. |
| 872 | // e.g. |
| 873 | // for(i=0;i<N;i++) { |
| 874 | // for(j = 0;j<M;j++) { |
| 875 | // A[j+1][i+2] = A[j][i]+k; |
| 876 | // } |
| 877 | // } |
Karthik Bhat | 88db86d | 2015-03-06 10:11:25 +0000 | [diff] [blame] | 878 | Instruction *InnerIndexVarInc = nullptr; |
| 879 | if (InnerInductionVar->getIncomingBlock(0) == InnerLoopPreHeader) |
| 880 | InnerIndexVarInc = |
| 881 | dyn_cast<Instruction>(InnerInductionVar->getIncomingValue(1)); |
| 882 | else |
| 883 | InnerIndexVarInc = |
| 884 | dyn_cast<Instruction>(InnerInductionVar->getIncomingValue(0)); |
| 885 | |
Florian Hahn | 4eeff39 | 2017-07-03 15:32:00 +0000 | [diff] [blame] | 886 | if (!InnerIndexVarInc) { |
Nicola Zaghen | d34e60c | 2018-05-14 12:53:11 +0000 | [diff] [blame] | 887 | LLVM_DEBUG( |
| 888 | dbgs() << "Did not find an instruction to increment the induction " |
| 889 | << "variable.\n"); |
Vivek Pandya | 9590658 | 2017-10-11 17:12:59 +0000 | [diff] [blame] | 890 | ORE->emit([&]() { |
| 891 | return OptimizationRemarkMissed(DEBUG_TYPE, "NoIncrementInInner", |
| 892 | InnerLoop->getStartLoc(), |
| 893 | InnerLoop->getHeader()) |
| 894 | << "The inner loop does not increment the induction variable."; |
| 895 | }); |
Pete Cooper | 11bd958 | 2015-07-27 18:37:58 +0000 | [diff] [blame] | 896 | return true; |
Florian Hahn | 4eeff39 | 2017-07-03 15:32:00 +0000 | [diff] [blame] | 897 | } |
Pete Cooper | 11bd958 | 2015-07-27 18:37:58 +0000 | [diff] [blame] | 898 | |
Karthik Bhat | 88db86d | 2015-03-06 10:11:25 +0000 | [diff] [blame] | 899 | // Since we split the inner loop latch on this induction variable. Make sure |
| 900 | // we do not have any instruction between the induction variable and branch |
| 901 | // instruction. |
| 902 | |
David Majnemer | d770877 | 2016-06-24 04:05:21 +0000 | [diff] [blame] | 903 | bool FoundInduction = false; |
Florian Hahn | fd2bc11 | 2018-04-26 10:26:17 +0000 | [diff] [blame] | 904 | for (const Instruction &I : |
| 905 | llvm::reverse(InnerLoopLatch->instructionsWithoutDebug())) { |
Florian Hahn | cd78345 | 2017-08-25 16:52:29 +0000 | [diff] [blame] | 906 | if (isa<BranchInst>(I) || isa<CmpInst>(I) || isa<TruncInst>(I) || |
| 907 | isa<ZExtInst>(I)) |
Karthik Bhat | 88db86d | 2015-03-06 10:11:25 +0000 | [diff] [blame] | 908 | continue; |
Florian Hahn | 4eeff39 | 2017-07-03 15:32:00 +0000 | [diff] [blame] | 909 | |
Karthik Bhat | 88db86d | 2015-03-06 10:11:25 +0000 | [diff] [blame] | 910 | // We found an instruction. If this is not induction variable then it is not |
| 911 | // safe to split this loop latch. |
Florian Hahn | 4eeff39 | 2017-07-03 15:32:00 +0000 | [diff] [blame] | 912 | if (!I.isIdenticalTo(InnerIndexVarInc)) { |
Nicola Zaghen | d34e60c | 2018-05-14 12:53:11 +0000 | [diff] [blame] | 913 | LLVM_DEBUG(dbgs() << "Found unsupported instructions between induction " |
| 914 | << "variable increment and branch.\n"); |
Vivek Pandya | 9590658 | 2017-10-11 17:12:59 +0000 | [diff] [blame] | 915 | ORE->emit([&]() { |
| 916 | return OptimizationRemarkMissed( |
| 917 | DEBUG_TYPE, "UnsupportedInsBetweenInduction", |
| 918 | InnerLoop->getStartLoc(), InnerLoop->getHeader()) |
| 919 | << "Found unsupported instruction between induction variable " |
| 920 | "increment and branch."; |
| 921 | }); |
Karthik Bhat | 88db86d | 2015-03-06 10:11:25 +0000 | [diff] [blame] | 922 | return true; |
Florian Hahn | 4eeff39 | 2017-07-03 15:32:00 +0000 | [diff] [blame] | 923 | } |
David Majnemer | d770877 | 2016-06-24 04:05:21 +0000 | [diff] [blame] | 924 | |
| 925 | FoundInduction = true; |
| 926 | break; |
Karthik Bhat | 88db86d | 2015-03-06 10:11:25 +0000 | [diff] [blame] | 927 | } |
Benjamin Kramer | df005cb | 2015-08-08 18:27:36 +0000 | [diff] [blame] | 928 | // The loop latch ended and we didn't find the induction variable return as |
Karthik Bhat | 88db86d | 2015-03-06 10:11:25 +0000 | [diff] [blame] | 929 | // current limitation. |
Florian Hahn | 4eeff39 | 2017-07-03 15:32:00 +0000 | [diff] [blame] | 930 | if (!FoundInduction) { |
Nicola Zaghen | d34e60c | 2018-05-14 12:53:11 +0000 | [diff] [blame] | 931 | LLVM_DEBUG(dbgs() << "Did not find the induction variable.\n"); |
Vivek Pandya | 9590658 | 2017-10-11 17:12:59 +0000 | [diff] [blame] | 932 | ORE->emit([&]() { |
| 933 | return OptimizationRemarkMissed(DEBUG_TYPE, "NoIndutionVariable", |
| 934 | InnerLoop->getStartLoc(), |
| 935 | InnerLoop->getHeader()) |
| 936 | << "Did not find the induction variable."; |
| 937 | }); |
Karthik Bhat | 88db86d | 2015-03-06 10:11:25 +0000 | [diff] [blame] | 938 | return true; |
Florian Hahn | 4eeff39 | 2017-07-03 15:32:00 +0000 | [diff] [blame] | 939 | } |
Karthik Bhat | 88db86d | 2015-03-06 10:11:25 +0000 | [diff] [blame] | 940 | return false; |
| 941 | } |
| 942 | |
Florian Hahn | f3fea0f | 2018-04-27 13:52:51 +0000 | [diff] [blame] | 943 | // We currently support LCSSA PHI nodes in the outer loop exit, if their |
| 944 | // incoming values do not come from the outer loop latch or if the |
| 945 | // outer loop latch has a single predecessor. In that case, the value will |
| 946 | // be available if both the inner and outer loop conditions are true, which |
| 947 | // will still be true after interchanging. If we have multiple predecessor, |
| 948 | // that may not be the case, e.g. because the outer loop latch may be executed |
| 949 | // if the inner loop is not executed. |
| 950 | static bool areLoopExitPHIsSupported(Loop *OuterLoop, Loop *InnerLoop) { |
| 951 | BasicBlock *LoopNestExit = OuterLoop->getUniqueExitBlock(); |
| 952 | for (PHINode &PHI : LoopNestExit->phis()) { |
| 953 | // FIXME: We currently are not able to detect floating point reductions |
| 954 | // and have to use floating point PHIs as a proxy to prevent |
| 955 | // interchanging in the presence of floating point reductions. |
| 956 | if (PHI.getType()->isFloatingPointTy()) |
| 957 | return false; |
| 958 | for (unsigned i = 0; i < PHI.getNumIncomingValues(); i++) { |
| 959 | Instruction *IncomingI = dyn_cast<Instruction>(PHI.getIncomingValue(i)); |
| 960 | if (!IncomingI || IncomingI->getParent() != OuterLoop->getLoopLatch()) |
| 961 | continue; |
| 962 | |
| 963 | // The incoming value is defined in the outer loop latch. Currently we |
| 964 | // only support that in case the outer loop latch has a single predecessor. |
| 965 | // This guarantees that the outer loop latch is executed if and only if |
| 966 | // the inner loop is executed (because tightlyNested() guarantees that the |
| 967 | // outer loop header only branches to the inner loop or the outer loop |
| 968 | // latch). |
| 969 | // FIXME: We could weaken this logic and allow multiple predecessors, |
| 970 | // if the values are produced outside the loop latch. We would need |
| 971 | // additional logic to update the PHI nodes in the exit block as |
| 972 | // well. |
| 973 | if (OuterLoop->getLoopLatch()->getUniquePredecessor() == nullptr) |
| 974 | return false; |
| 975 | } |
| 976 | } |
| 977 | return true; |
| 978 | } |
| 979 | |
Karthik Bhat | 88db86d | 2015-03-06 10:11:25 +0000 | [diff] [blame] | 980 | bool LoopInterchangeLegality::canInterchangeLoops(unsigned InnerLoopId, |
| 981 | unsigned OuterLoopId, |
| 982 | CharMatrix &DepMatrix) { |
Karthik Bhat | 88db86d | 2015-03-06 10:11:25 +0000 | [diff] [blame] | 983 | if (!isLegalToInterChangeLoops(DepMatrix, InnerLoopId, OuterLoopId)) { |
Nicola Zaghen | d34e60c | 2018-05-14 12:53:11 +0000 | [diff] [blame] | 984 | LLVM_DEBUG(dbgs() << "Failed interchange InnerLoopId = " << InnerLoopId |
| 985 | << " and OuterLoopId = " << OuterLoopId |
| 986 | << " due to dependence\n"); |
Vivek Pandya | 9590658 | 2017-10-11 17:12:59 +0000 | [diff] [blame] | 987 | ORE->emit([&]() { |
| 988 | return OptimizationRemarkMissed(DEBUG_TYPE, "Dependence", |
| 989 | InnerLoop->getStartLoc(), |
| 990 | InnerLoop->getHeader()) |
| 991 | << "Cannot interchange loops due to dependences."; |
| 992 | }); |
Karthik Bhat | 88db86d | 2015-03-06 10:11:25 +0000 | [diff] [blame] | 993 | return false; |
| 994 | } |
Florian Hahn | 4284049 | 2017-07-31 09:00:52 +0000 | [diff] [blame] | 995 | // Check if outer and inner loop contain legal instructions only. |
| 996 | for (auto *BB : OuterLoop->blocks()) |
Florian Hahn | fd2bc11 | 2018-04-26 10:26:17 +0000 | [diff] [blame] | 997 | for (Instruction &I : BB->instructionsWithoutDebug()) |
Florian Hahn | 4284049 | 2017-07-31 09:00:52 +0000 | [diff] [blame] | 998 | if (CallInst *CI = dyn_cast<CallInst>(&I)) { |
| 999 | // readnone functions do not prevent interchanging. |
| 1000 | if (CI->doesNotReadMemory()) |
| 1001 | continue; |
Nicola Zaghen | d34e60c | 2018-05-14 12:53:11 +0000 | [diff] [blame] | 1002 | LLVM_DEBUG( |
| 1003 | dbgs() << "Loops with call instructions cannot be interchanged " |
| 1004 | << "safely."); |
Florian Hahn | 9467ccf | 2018-04-03 20:54:04 +0000 | [diff] [blame] | 1005 | ORE->emit([&]() { |
| 1006 | return OptimizationRemarkMissed(DEBUG_TYPE, "CallInst", |
| 1007 | CI->getDebugLoc(), |
| 1008 | CI->getParent()) |
| 1009 | << "Cannot interchange loops due to call instruction."; |
| 1010 | }); |
| 1011 | |
Florian Hahn | 4284049 | 2017-07-31 09:00:52 +0000 | [diff] [blame] | 1012 | return false; |
| 1013 | } |
| 1014 | |
Karthik Bhat | 88db86d | 2015-03-06 10:11:25 +0000 | [diff] [blame] | 1015 | // TODO: The loops could not be interchanged due to current limitations in the |
| 1016 | // transform module. |
| 1017 | if (currentLimitations()) { |
Nicola Zaghen | d34e60c | 2018-05-14 12:53:11 +0000 | [diff] [blame] | 1018 | LLVM_DEBUG(dbgs() << "Not legal because of current transform limitation\n"); |
Karthik Bhat | 88db86d | 2015-03-06 10:11:25 +0000 | [diff] [blame] | 1019 | return false; |
| 1020 | } |
| 1021 | |
Karthik Bhat | 8210fdf | 2015-04-23 04:51:44 +0000 | [diff] [blame] | 1022 | // Check if the loops are tightly nested. |
| 1023 | if (!tightlyNested(OuterLoop, InnerLoop)) { |
Nicola Zaghen | d34e60c | 2018-05-14 12:53:11 +0000 | [diff] [blame] | 1024 | LLVM_DEBUG(dbgs() << "Loops not tightly nested\n"); |
Vivek Pandya | 9590658 | 2017-10-11 17:12:59 +0000 | [diff] [blame] | 1025 | ORE->emit([&]() { |
| 1026 | return OptimizationRemarkMissed(DEBUG_TYPE, "NotTightlyNested", |
| 1027 | InnerLoop->getStartLoc(), |
| 1028 | InnerLoop->getHeader()) |
| 1029 | << "Cannot interchange loops because they are not tightly " |
| 1030 | "nested."; |
| 1031 | }); |
Karthik Bhat | 8210fdf | 2015-04-23 04:51:44 +0000 | [diff] [blame] | 1032 | return false; |
| 1033 | } |
| 1034 | |
Florian Hahn | f3fea0f | 2018-04-27 13:52:51 +0000 | [diff] [blame] | 1035 | if (!areLoopExitPHIsSupported(OuterLoop, InnerLoop)) { |
Nicola Zaghen | d34e60c | 2018-05-14 12:53:11 +0000 | [diff] [blame] | 1036 | LLVM_DEBUG(dbgs() << "Found unsupported PHI nodes in outer loop exit.\n"); |
Florian Hahn | f3fea0f | 2018-04-27 13:52:51 +0000 | [diff] [blame] | 1037 | ORE->emit([&]() { |
| 1038 | return OptimizationRemarkMissed(DEBUG_TYPE, "UnsupportedExitPHI", |
| 1039 | OuterLoop->getStartLoc(), |
| 1040 | OuterLoop->getHeader()) |
| 1041 | << "Found unsupported PHI node in loop exit."; |
| 1042 | }); |
| 1043 | return false; |
| 1044 | } |
| 1045 | |
Karthik Bhat | 88db86d | 2015-03-06 10:11:25 +0000 | [diff] [blame] | 1046 | return true; |
| 1047 | } |
| 1048 | |
| 1049 | int LoopInterchangeProfitability::getInstrOrderCost() { |
| 1050 | unsigned GoodOrder, BadOrder; |
| 1051 | BadOrder = GoodOrder = 0; |
Florian Hahn | f66efd6 | 2017-07-24 11:41:30 +0000 | [diff] [blame] | 1052 | for (BasicBlock *BB : InnerLoop->blocks()) { |
| 1053 | for (Instruction &Ins : *BB) { |
Karthik Bhat | 88db86d | 2015-03-06 10:11:25 +0000 | [diff] [blame] | 1054 | if (const GetElementPtrInst *GEP = dyn_cast<GetElementPtrInst>(&Ins)) { |
| 1055 | unsigned NumOp = GEP->getNumOperands(); |
| 1056 | bool FoundInnerInduction = false; |
| 1057 | bool FoundOuterInduction = false; |
| 1058 | for (unsigned i = 0; i < NumOp; ++i) { |
| 1059 | const SCEV *OperandVal = SE->getSCEV(GEP->getOperand(i)); |
| 1060 | const SCEVAddRecExpr *AR = dyn_cast<SCEVAddRecExpr>(OperandVal); |
| 1061 | if (!AR) |
| 1062 | continue; |
| 1063 | |
| 1064 | // If we find the inner induction after an outer induction e.g. |
| 1065 | // for(int i=0;i<N;i++) |
| 1066 | // for(int j=0;j<N;j++) |
| 1067 | // A[i][j] = A[i-1][j-1]+k; |
| 1068 | // then it is a good order. |
| 1069 | if (AR->getLoop() == InnerLoop) { |
| 1070 | // We found an InnerLoop induction after OuterLoop induction. It is |
| 1071 | // a good order. |
| 1072 | FoundInnerInduction = true; |
| 1073 | if (FoundOuterInduction) { |
| 1074 | GoodOrder++; |
| 1075 | break; |
| 1076 | } |
| 1077 | } |
| 1078 | // If we find the outer induction after an inner induction e.g. |
| 1079 | // for(int i=0;i<N;i++) |
| 1080 | // for(int j=0;j<N;j++) |
| 1081 | // A[j][i] = A[j-1][i-1]+k; |
| 1082 | // then it is a bad order. |
| 1083 | if (AR->getLoop() == OuterLoop) { |
| 1084 | // We found an OuterLoop induction after InnerLoop induction. It is |
| 1085 | // a bad order. |
| 1086 | FoundOuterInduction = true; |
| 1087 | if (FoundInnerInduction) { |
| 1088 | BadOrder++; |
| 1089 | break; |
| 1090 | } |
| 1091 | } |
| 1092 | } |
| 1093 | } |
| 1094 | } |
| 1095 | } |
| 1096 | return GoodOrder - BadOrder; |
| 1097 | } |
| 1098 | |
Chad Rosier | e6b3a63 | 2016-09-14 17:12:30 +0000 | [diff] [blame] | 1099 | static bool isProfitableForVectorization(unsigned InnerLoopId, |
| 1100 | unsigned OuterLoopId, |
| 1101 | CharMatrix &DepMatrix) { |
Karthik Bhat | 88db86d | 2015-03-06 10:11:25 +0000 | [diff] [blame] | 1102 | // TODO: Improve this heuristic to catch more cases. |
| 1103 | // If the inner loop is loop independent or doesn't carry any dependency it is |
| 1104 | // profitable to move this to outer position. |
Florian Hahn | f66efd6 | 2017-07-24 11:41:30 +0000 | [diff] [blame] | 1105 | for (auto &Row : DepMatrix) { |
| 1106 | if (Row[InnerLoopId] != 'S' && Row[InnerLoopId] != 'I') |
Karthik Bhat | 88db86d | 2015-03-06 10:11:25 +0000 | [diff] [blame] | 1107 | return false; |
| 1108 | // TODO: We need to improve this heuristic. |
Florian Hahn | f66efd6 | 2017-07-24 11:41:30 +0000 | [diff] [blame] | 1109 | if (Row[OuterLoopId] != '=') |
Karthik Bhat | 88db86d | 2015-03-06 10:11:25 +0000 | [diff] [blame] | 1110 | return false; |
| 1111 | } |
| 1112 | // If outer loop has dependence and inner loop is loop independent then it is |
| 1113 | // profitable to interchange to enable parallelism. |
Florian Hahn | ceee788 | 2018-04-24 16:55:32 +0000 | [diff] [blame] | 1114 | // If there are no dependences, interchanging will not improve anything. |
| 1115 | return !DepMatrix.empty(); |
Karthik Bhat | 88db86d | 2015-03-06 10:11:25 +0000 | [diff] [blame] | 1116 | } |
| 1117 | |
| 1118 | bool LoopInterchangeProfitability::isProfitable(unsigned InnerLoopId, |
| 1119 | unsigned OuterLoopId, |
| 1120 | CharMatrix &DepMatrix) { |
Benjamin Kramer | df005cb | 2015-08-08 18:27:36 +0000 | [diff] [blame] | 1121 | // TODO: Add better profitability checks. |
Karthik Bhat | 88db86d | 2015-03-06 10:11:25 +0000 | [diff] [blame] | 1122 | // e.g |
| 1123 | // 1) Construct dependency matrix and move the one with no loop carried dep |
| 1124 | // inside to enable vectorization. |
| 1125 | |
| 1126 | // This is rough cost estimation algorithm. It counts the good and bad order |
| 1127 | // of induction variables in the instruction and allows reordering if number |
| 1128 | // of bad orders is more than good. |
Chad Rosier | 7243189 | 2016-09-14 17:07:13 +0000 | [diff] [blame] | 1129 | int Cost = getInstrOrderCost(); |
Nicola Zaghen | d34e60c | 2018-05-14 12:53:11 +0000 | [diff] [blame] | 1130 | LLVM_DEBUG(dbgs() << "Cost = " << Cost << "\n"); |
Chad Rosier | 7243189 | 2016-09-14 17:07:13 +0000 | [diff] [blame] | 1131 | if (Cost < -LoopInterchangeCostThreshold) |
Karthik Bhat | 88db86d | 2015-03-06 10:11:25 +0000 | [diff] [blame] | 1132 | return true; |
| 1133 | |
Benjamin Kramer | df005cb | 2015-08-08 18:27:36 +0000 | [diff] [blame] | 1134 | // It is not profitable as per current cache profitability model. But check if |
Karthik Bhat | 88db86d | 2015-03-06 10:11:25 +0000 | [diff] [blame] | 1135 | // we can move this loop outside to improve parallelism. |
Florian Hahn | ad99352 | 2017-07-15 13:13:19 +0000 | [diff] [blame] | 1136 | if (isProfitableForVectorization(InnerLoopId, OuterLoopId, DepMatrix)) |
| 1137 | return true; |
| 1138 | |
Vivek Pandya | 9590658 | 2017-10-11 17:12:59 +0000 | [diff] [blame] | 1139 | ORE->emit([&]() { |
| 1140 | return OptimizationRemarkMissed(DEBUG_TYPE, "InterchangeNotProfitable", |
| 1141 | InnerLoop->getStartLoc(), |
| 1142 | InnerLoop->getHeader()) |
| 1143 | << "Interchanging loops is too costly (cost=" |
| 1144 | << ore::NV("Cost", Cost) << ", threshold=" |
| 1145 | << ore::NV("Threshold", LoopInterchangeCostThreshold) |
| 1146 | << ") and it does not improve parallelism."; |
| 1147 | }); |
Florian Hahn | ad99352 | 2017-07-15 13:13:19 +0000 | [diff] [blame] | 1148 | return false; |
Karthik Bhat | 88db86d | 2015-03-06 10:11:25 +0000 | [diff] [blame] | 1149 | } |
| 1150 | |
| 1151 | void LoopInterchangeTransform::removeChildLoop(Loop *OuterLoop, |
| 1152 | Loop *InnerLoop) { |
Florian Hahn | 5912c66 | 2018-05-02 10:53:04 +0000 | [diff] [blame] | 1153 | for (Loop *L : *OuterLoop) |
| 1154 | if (L == InnerLoop) { |
| 1155 | OuterLoop->removeChildLoop(L); |
Karthik Bhat | 88db86d | 2015-03-06 10:11:25 +0000 | [diff] [blame] | 1156 | return; |
| 1157 | } |
Benjamin Kramer | 8ceb323 | 2015-10-25 22:28:27 +0000 | [diff] [blame] | 1158 | llvm_unreachable("Couldn't find loop"); |
Karthik Bhat | 88db86d | 2015-03-06 10:11:25 +0000 | [diff] [blame] | 1159 | } |
Daniel Jasper | 6adbd7a | 2015-03-06 10:39:14 +0000 | [diff] [blame] | 1160 | |
Florian Hahn | 831a757 | 2018-04-05 09:48:45 +0000 | [diff] [blame] | 1161 | /// Update LoopInfo, after interchanging. NewInner and NewOuter refer to the |
| 1162 | /// new inner and outer loop after interchanging: NewInner is the original |
| 1163 | /// outer loop and NewOuter is the original inner loop. |
| 1164 | /// |
| 1165 | /// Before interchanging, we have the following structure |
| 1166 | /// Outer preheader |
| 1167 | // Outer header |
| 1168 | // Inner preheader |
| 1169 | // Inner header |
| 1170 | // Inner body |
| 1171 | // Inner latch |
| 1172 | // outer bbs |
| 1173 | // Outer latch |
| 1174 | // |
| 1175 | // After interchanging: |
| 1176 | // Inner preheader |
| 1177 | // Inner header |
| 1178 | // Outer preheader |
| 1179 | // Outer header |
| 1180 | // Inner body |
| 1181 | // outer bbs |
| 1182 | // Outer latch |
| 1183 | // Inner latch |
| 1184 | void LoopInterchangeTransform::restructureLoops( |
| 1185 | Loop *NewInner, Loop *NewOuter, BasicBlock *OrigInnerPreHeader, |
| 1186 | BasicBlock *OrigOuterPreHeader) { |
Karthik Bhat | 88db86d | 2015-03-06 10:11:25 +0000 | [diff] [blame] | 1187 | Loop *OuterLoopParent = OuterLoop->getParentLoop(); |
Florian Hahn | 831a757 | 2018-04-05 09:48:45 +0000 | [diff] [blame] | 1188 | // The original inner loop preheader moves from the new inner loop to |
| 1189 | // the parent loop, if there is one. |
| 1190 | NewInner->removeBlockFromLoop(OrigInnerPreHeader); |
| 1191 | LI->changeLoopFor(OrigInnerPreHeader, OuterLoopParent); |
| 1192 | |
| 1193 | // Switch the loop levels. |
Karthik Bhat | 88db86d | 2015-03-06 10:11:25 +0000 | [diff] [blame] | 1194 | if (OuterLoopParent) { |
| 1195 | // Remove the loop from its parent loop. |
Florian Hahn | 831a757 | 2018-04-05 09:48:45 +0000 | [diff] [blame] | 1196 | removeChildLoop(OuterLoopParent, NewInner); |
| 1197 | removeChildLoop(NewInner, NewOuter); |
| 1198 | OuterLoopParent->addChildLoop(NewOuter); |
Karthik Bhat | 88db86d | 2015-03-06 10:11:25 +0000 | [diff] [blame] | 1199 | } else { |
Florian Hahn | 831a757 | 2018-04-05 09:48:45 +0000 | [diff] [blame] | 1200 | removeChildLoop(NewInner, NewOuter); |
| 1201 | LI->changeTopLevelLoop(NewInner, NewOuter); |
| 1202 | } |
| 1203 | while (!NewOuter->empty()) |
| 1204 | NewInner->addChildLoop(NewOuter->removeChildLoop(NewOuter->begin())); |
| 1205 | NewOuter->addChildLoop(NewInner); |
| 1206 | |
| 1207 | // BBs from the original inner loop. |
| 1208 | SmallVector<BasicBlock *, 8> OrigInnerBBs(NewOuter->blocks()); |
| 1209 | |
| 1210 | // Add BBs from the original outer loop to the original inner loop (excluding |
| 1211 | // BBs already in inner loop) |
| 1212 | for (BasicBlock *BB : NewInner->blocks()) |
| 1213 | if (LI->getLoopFor(BB) == NewInner) |
| 1214 | NewOuter->addBlockEntry(BB); |
| 1215 | |
| 1216 | // Now remove inner loop header and latch from the new inner loop and move |
| 1217 | // other BBs (the loop body) to the new inner loop. |
| 1218 | BasicBlock *OuterHeader = NewOuter->getHeader(); |
| 1219 | BasicBlock *OuterLatch = NewOuter->getLoopLatch(); |
| 1220 | for (BasicBlock *BB : OrigInnerBBs) { |
Florian Hahn | 74418185 | 2018-04-23 21:38:19 +0000 | [diff] [blame] | 1221 | // Nothing will change for BBs in child loops. |
| 1222 | if (LI->getLoopFor(BB) != NewOuter) |
| 1223 | continue; |
Florian Hahn | 831a757 | 2018-04-05 09:48:45 +0000 | [diff] [blame] | 1224 | // Remove the new outer loop header and latch from the new inner loop. |
| 1225 | if (BB == OuterHeader || BB == OuterLatch) |
| 1226 | NewInner->removeBlockFromLoop(BB); |
| 1227 | else |
| 1228 | LI->changeLoopFor(BB, NewInner); |
Karthik Bhat | 88db86d | 2015-03-06 10:11:25 +0000 | [diff] [blame] | 1229 | } |
| 1230 | |
Florian Hahn | 831a757 | 2018-04-05 09:48:45 +0000 | [diff] [blame] | 1231 | // The preheader of the original outer loop becomes part of the new |
| 1232 | // outer loop. |
| 1233 | NewOuter->addBlockEntry(OrigOuterPreHeader); |
| 1234 | LI->changeLoopFor(OrigOuterPreHeader, NewOuter); |
Florian Hahn | 3afb974 | 2018-09-14 07:50:20 +0000 | [diff] [blame] | 1235 | |
| 1236 | // Tell SE that we move the loops around. |
| 1237 | SE->forgetLoop(NewOuter); |
| 1238 | SE->forgetLoop(NewInner); |
Karthik Bhat | 88db86d | 2015-03-06 10:11:25 +0000 | [diff] [blame] | 1239 | } |
| 1240 | |
| 1241 | bool LoopInterchangeTransform::transform() { |
Karthik Bhat | 88db86d | 2015-03-06 10:11:25 +0000 | [diff] [blame] | 1242 | bool Transformed = false; |
| 1243 | Instruction *InnerIndexVar; |
| 1244 | |
Eugene Zelenko | dd40f5e | 2017-10-16 21:34:24 +0000 | [diff] [blame] | 1245 | if (InnerLoop->getSubLoops().empty()) { |
Karthik Bhat | 88db86d | 2015-03-06 10:11:25 +0000 | [diff] [blame] | 1246 | BasicBlock *InnerLoopPreHeader = InnerLoop->getLoopPreheader(); |
Nicola Zaghen | d34e60c | 2018-05-14 12:53:11 +0000 | [diff] [blame] | 1247 | LLVM_DEBUG(dbgs() << "Calling Split Inner Loop\n"); |
Karthik Bhat | 88db86d | 2015-03-06 10:11:25 +0000 | [diff] [blame] | 1248 | PHINode *InductionPHI = getInductionVariable(InnerLoop, SE); |
| 1249 | if (!InductionPHI) { |
Nicola Zaghen | d34e60c | 2018-05-14 12:53:11 +0000 | [diff] [blame] | 1250 | LLVM_DEBUG(dbgs() << "Failed to find the point to split loop latch \n"); |
Karthik Bhat | 88db86d | 2015-03-06 10:11:25 +0000 | [diff] [blame] | 1251 | return false; |
| 1252 | } |
| 1253 | |
| 1254 | if (InductionPHI->getIncomingBlock(0) == InnerLoopPreHeader) |
| 1255 | InnerIndexVar = dyn_cast<Instruction>(InductionPHI->getIncomingValue(1)); |
| 1256 | else |
| 1257 | InnerIndexVar = dyn_cast<Instruction>(InductionPHI->getIncomingValue(0)); |
| 1258 | |
Florian Hahn | d8fcf0d | 2018-06-19 08:03:24 +0000 | [diff] [blame] | 1259 | // Ensure that InductionPHI is the first Phi node. |
David Green | 907b60f | 2017-10-21 13:58:37 +0000 | [diff] [blame] | 1260 | if (&InductionPHI->getParent()->front() != InductionPHI) |
| 1261 | InductionPHI->moveBefore(&InductionPHI->getParent()->front()); |
| 1262 | |
Karthik Bhat | 88db86d | 2015-03-06 10:11:25 +0000 | [diff] [blame] | 1263 | // Split at the place were the induction variable is |
| 1264 | // incremented/decremented. |
| 1265 | // TODO: This splitting logic may not work always. Fix this. |
| 1266 | splitInnerLoopLatch(InnerIndexVar); |
Nicola Zaghen | d34e60c | 2018-05-14 12:53:11 +0000 | [diff] [blame] | 1267 | LLVM_DEBUG(dbgs() << "splitInnerLoopLatch done\n"); |
Karthik Bhat | 88db86d | 2015-03-06 10:11:25 +0000 | [diff] [blame] | 1268 | |
Benjamin Kramer | df005cb | 2015-08-08 18:27:36 +0000 | [diff] [blame] | 1269 | // Splits the inner loops phi nodes out into a separate basic block. |
Florian Hahn | d8fcf0d | 2018-06-19 08:03:24 +0000 | [diff] [blame] | 1270 | BasicBlock *InnerLoopHeader = InnerLoop->getHeader(); |
| 1271 | SplitBlock(InnerLoopHeader, InnerLoopHeader->getFirstNonPHI(), DT, LI); |
| 1272 | LLVM_DEBUG(dbgs() << "splitting InnerLoopHeader done\n"); |
Karthik Bhat | 88db86d | 2015-03-06 10:11:25 +0000 | [diff] [blame] | 1273 | } |
| 1274 | |
| 1275 | Transformed |= adjustLoopLinks(); |
| 1276 | if (!Transformed) { |
Nicola Zaghen | d34e60c | 2018-05-14 12:53:11 +0000 | [diff] [blame] | 1277 | LLVM_DEBUG(dbgs() << "adjustLoopLinks failed\n"); |
Karthik Bhat | 88db86d | 2015-03-06 10:11:25 +0000 | [diff] [blame] | 1278 | return false; |
| 1279 | } |
| 1280 | |
Karthik Bhat | 88db86d | 2015-03-06 10:11:25 +0000 | [diff] [blame] | 1281 | return true; |
| 1282 | } |
| 1283 | |
Benjamin Kramer | 7944292 | 2015-03-06 18:59:14 +0000 | [diff] [blame] | 1284 | void LoopInterchangeTransform::splitInnerLoopLatch(Instruction *Inc) { |
Karthik Bhat | 88db86d | 2015-03-06 10:11:25 +0000 | [diff] [blame] | 1285 | BasicBlock *InnerLoopLatch = InnerLoop->getLoopLatch(); |
Karthik Bhat | 88db86d | 2015-03-06 10:11:25 +0000 | [diff] [blame] | 1286 | BasicBlock *InnerLoopLatchPred = InnerLoopLatch; |
Benjamin Kramer | 7944292 | 2015-03-06 18:59:14 +0000 | [diff] [blame] | 1287 | InnerLoopLatch = SplitBlock(InnerLoopLatchPred, Inc, DT, LI); |
Karthik Bhat | 88db86d | 2015-03-06 10:11:25 +0000 | [diff] [blame] | 1288 | } |
| 1289 | |
Florian Hahn | d8fcf0d | 2018-06-19 08:03:24 +0000 | [diff] [blame] | 1290 | /// \brief Move all instructions except the terminator from FromBB right before |
Benjamin Kramer | 7944292 | 2015-03-06 18:59:14 +0000 | [diff] [blame] | 1291 | /// InsertBefore |
| 1292 | static void moveBBContents(BasicBlock *FromBB, Instruction *InsertBefore) { |
| 1293 | auto &ToList = InsertBefore->getParent()->getInstList(); |
| 1294 | auto &FromList = FromBB->getInstList(); |
| 1295 | |
Duncan P. N. Exon Smith | be4d8cb | 2015-10-13 19:26:58 +0000 | [diff] [blame] | 1296 | ToList.splice(InsertBefore->getIterator(), FromList, FromList.begin(), |
| 1297 | FromBB->getTerminator()->getIterator()); |
Benjamin Kramer | 7944292 | 2015-03-06 18:59:14 +0000 | [diff] [blame] | 1298 | } |
| 1299 | |
Karthik Bhat | 8210fdf | 2015-04-23 04:51:44 +0000 | [diff] [blame] | 1300 | void LoopInterchangeTransform::updateIncomingBlock(BasicBlock *CurrBlock, |
| 1301 | BasicBlock *OldPred, |
| 1302 | BasicBlock *NewPred) { |
Florian Hahn | 5912c66 | 2018-05-02 10:53:04 +0000 | [diff] [blame] | 1303 | for (PHINode &PHI : CurrBlock->phis()) { |
| 1304 | unsigned Num = PHI.getNumIncomingValues(); |
Karthik Bhat | 8210fdf | 2015-04-23 04:51:44 +0000 | [diff] [blame] | 1305 | for (unsigned i = 0; i < Num; ++i) { |
Florian Hahn | 5912c66 | 2018-05-02 10:53:04 +0000 | [diff] [blame] | 1306 | if (PHI.getIncomingBlock(i) == OldPred) |
| 1307 | PHI.setIncomingBlock(i, NewPred); |
Karthik Bhat | 8210fdf | 2015-04-23 04:51:44 +0000 | [diff] [blame] | 1308 | } |
| 1309 | } |
| 1310 | } |
| 1311 | |
Adrian Prantl | 5f8f34e4 | 2018-05-01 15:54:18 +0000 | [diff] [blame] | 1312 | /// Update BI to jump to NewBB instead of OldBB. Records updates to |
Florian Hahn | c6296fe | 2018-02-14 13:13:15 +0000 | [diff] [blame] | 1313 | /// the dominator tree in DTUpdates, if DT should be preserved. |
| 1314 | static void updateSuccessor(BranchInst *BI, BasicBlock *OldBB, |
| 1315 | BasicBlock *NewBB, |
| 1316 | std::vector<DominatorTree::UpdateType> &DTUpdates) { |
Chandler Carruth | 96fc1de | 2018-08-26 08:41:15 +0000 | [diff] [blame] | 1317 | assert(llvm::count_if(successors(BI), |
Florian Hahn | c6296fe | 2018-02-14 13:13:15 +0000 | [diff] [blame] | 1318 | [OldBB](BasicBlock *BB) { return BB == OldBB; }) < 2 && |
| 1319 | "BI must jump to OldBB at most once."); |
| 1320 | for (unsigned i = 0, e = BI->getNumSuccessors(); i < e; ++i) { |
| 1321 | if (BI->getSuccessor(i) == OldBB) { |
| 1322 | BI->setSuccessor(i, NewBB); |
| 1323 | |
| 1324 | DTUpdates.push_back( |
| 1325 | {DominatorTree::UpdateKind::Insert, BI->getParent(), NewBB}); |
| 1326 | DTUpdates.push_back( |
| 1327 | {DominatorTree::UpdateKind::Delete, BI->getParent(), OldBB}); |
| 1328 | break; |
| 1329 | } |
| 1330 | } |
| 1331 | } |
| 1332 | |
Karthik Bhat | 88db86d | 2015-03-06 10:11:25 +0000 | [diff] [blame] | 1333 | bool LoopInterchangeTransform::adjustLoopBranches() { |
Nicola Zaghen | d34e60c | 2018-05-14 12:53:11 +0000 | [diff] [blame] | 1334 | LLVM_DEBUG(dbgs() << "adjustLoopBranches called\n"); |
Florian Hahn | c6296fe | 2018-02-14 13:13:15 +0000 | [diff] [blame] | 1335 | std::vector<DominatorTree::UpdateType> DTUpdates; |
| 1336 | |
Florian Hahn | 236f6fe | 2018-09-06 09:57:27 +0000 | [diff] [blame] | 1337 | BasicBlock *OuterLoopPreHeader = OuterLoop->getLoopPreheader(); |
| 1338 | BasicBlock *InnerLoopPreHeader = InnerLoop->getLoopPreheader(); |
| 1339 | |
| 1340 | assert(OuterLoopPreHeader != OuterLoop->getHeader() && |
| 1341 | InnerLoopPreHeader != InnerLoop->getHeader() && OuterLoopPreHeader && |
| 1342 | InnerLoopPreHeader && "Guaranteed by loop-simplify form"); |
| 1343 | // Ensure that both preheaders do not contain PHI nodes and have single |
| 1344 | // predecessors. This allows us to move them easily. We use |
| 1345 | // InsertPreHeaderForLoop to create an 'extra' preheader, if the existing |
| 1346 | // preheaders do not satisfy those conditions. |
| 1347 | if (isa<PHINode>(OuterLoopPreHeader->begin()) || |
| 1348 | !OuterLoopPreHeader->getUniquePredecessor()) |
| 1349 | OuterLoopPreHeader = InsertPreheaderForLoop(OuterLoop, DT, LI, true); |
| 1350 | if (InnerLoopPreHeader == OuterLoop->getHeader()) |
| 1351 | InnerLoopPreHeader = InsertPreheaderForLoop(InnerLoop, DT, LI, true); |
| 1352 | |
Karthik Bhat | 88db86d | 2015-03-06 10:11:25 +0000 | [diff] [blame] | 1353 | // Adjust the loop preheader |
| 1354 | BasicBlock *InnerLoopHeader = InnerLoop->getHeader(); |
| 1355 | BasicBlock *OuterLoopHeader = OuterLoop->getHeader(); |
| 1356 | BasicBlock *InnerLoopLatch = InnerLoop->getLoopLatch(); |
| 1357 | BasicBlock *OuterLoopLatch = OuterLoop->getLoopLatch(); |
Karthik Bhat | 88db86d | 2015-03-06 10:11:25 +0000 | [diff] [blame] | 1358 | BasicBlock *OuterLoopPredecessor = OuterLoopPreHeader->getUniquePredecessor(); |
| 1359 | BasicBlock *InnerLoopLatchPredecessor = |
| 1360 | InnerLoopLatch->getUniquePredecessor(); |
| 1361 | BasicBlock *InnerLoopLatchSuccessor; |
| 1362 | BasicBlock *OuterLoopLatchSuccessor; |
| 1363 | |
| 1364 | BranchInst *OuterLoopLatchBI = |
| 1365 | dyn_cast<BranchInst>(OuterLoopLatch->getTerminator()); |
| 1366 | BranchInst *InnerLoopLatchBI = |
| 1367 | dyn_cast<BranchInst>(InnerLoopLatch->getTerminator()); |
| 1368 | BranchInst *OuterLoopHeaderBI = |
| 1369 | dyn_cast<BranchInst>(OuterLoopHeader->getTerminator()); |
| 1370 | BranchInst *InnerLoopHeaderBI = |
| 1371 | dyn_cast<BranchInst>(InnerLoopHeader->getTerminator()); |
| 1372 | |
| 1373 | if (!OuterLoopPredecessor || !InnerLoopLatchPredecessor || |
| 1374 | !OuterLoopLatchBI || !InnerLoopLatchBI || !OuterLoopHeaderBI || |
| 1375 | !InnerLoopHeaderBI) |
| 1376 | return false; |
| 1377 | |
| 1378 | BranchInst *InnerLoopLatchPredecessorBI = |
| 1379 | dyn_cast<BranchInst>(InnerLoopLatchPredecessor->getTerminator()); |
| 1380 | BranchInst *OuterLoopPredecessorBI = |
| 1381 | dyn_cast<BranchInst>(OuterLoopPredecessor->getTerminator()); |
| 1382 | |
| 1383 | if (!OuterLoopPredecessorBI || !InnerLoopLatchPredecessorBI) |
| 1384 | return false; |
Benjamin Kramer | df005cb | 2015-08-08 18:27:36 +0000 | [diff] [blame] | 1385 | BasicBlock *InnerLoopHeaderSuccessor = InnerLoopHeader->getUniqueSuccessor(); |
| 1386 | if (!InnerLoopHeaderSuccessor) |
Karthik Bhat | 88db86d | 2015-03-06 10:11:25 +0000 | [diff] [blame] | 1387 | return false; |
| 1388 | |
| 1389 | // Adjust Loop Preheader and headers |
Florian Hahn | c6296fe | 2018-02-14 13:13:15 +0000 | [diff] [blame] | 1390 | updateSuccessor(OuterLoopPredecessorBI, OuterLoopPreHeader, |
| 1391 | InnerLoopPreHeader, DTUpdates); |
| 1392 | updateSuccessor(OuterLoopHeaderBI, OuterLoopLatch, LoopExit, DTUpdates); |
| 1393 | updateSuccessor(OuterLoopHeaderBI, InnerLoopPreHeader, |
| 1394 | InnerLoopHeaderSuccessor, DTUpdates); |
Karthik Bhat | 88db86d | 2015-03-06 10:11:25 +0000 | [diff] [blame] | 1395 | |
Karthik Bhat | 8210fdf | 2015-04-23 04:51:44 +0000 | [diff] [blame] | 1396 | // Adjust reduction PHI's now that the incoming block has changed. |
Benjamin Kramer | df005cb | 2015-08-08 18:27:36 +0000 | [diff] [blame] | 1397 | updateIncomingBlock(InnerLoopHeaderSuccessor, InnerLoopHeader, |
Karthik Bhat | 8210fdf | 2015-04-23 04:51:44 +0000 | [diff] [blame] | 1398 | OuterLoopHeader); |
| 1399 | |
Florian Hahn | c6296fe | 2018-02-14 13:13:15 +0000 | [diff] [blame] | 1400 | updateSuccessor(InnerLoopHeaderBI, InnerLoopHeaderSuccessor, |
| 1401 | OuterLoopPreHeader, DTUpdates); |
Karthik Bhat | 88db86d | 2015-03-06 10:11:25 +0000 | [diff] [blame] | 1402 | |
| 1403 | // -------------Adjust loop latches----------- |
| 1404 | if (InnerLoopLatchBI->getSuccessor(0) == InnerLoopHeader) |
| 1405 | InnerLoopLatchSuccessor = InnerLoopLatchBI->getSuccessor(1); |
| 1406 | else |
| 1407 | InnerLoopLatchSuccessor = InnerLoopLatchBI->getSuccessor(0); |
| 1408 | |
Florian Hahn | c6296fe | 2018-02-14 13:13:15 +0000 | [diff] [blame] | 1409 | updateSuccessor(InnerLoopLatchPredecessorBI, InnerLoopLatch, |
| 1410 | InnerLoopLatchSuccessor, DTUpdates); |
Karthik Bhat | 88db86d | 2015-03-06 10:11:25 +0000 | [diff] [blame] | 1411 | |
Karthik Bhat | 8210fdf | 2015-04-23 04:51:44 +0000 | [diff] [blame] | 1412 | // Adjust PHI nodes in InnerLoopLatchSuccessor. Update all uses of PHI with |
| 1413 | // the value and remove this PHI node from inner loop. |
| 1414 | SmallVector<PHINode *, 8> LcssaVec; |
Florian Hahn | 5912c66 | 2018-05-02 10:53:04 +0000 | [diff] [blame] | 1415 | for (PHINode &P : InnerLoopLatchSuccessor->phis()) |
| 1416 | LcssaVec.push_back(&P); |
| 1417 | |
Benjamin Kramer | 135f735 | 2016-06-26 12:28:59 +0000 | [diff] [blame] | 1418 | for (PHINode *P : LcssaVec) { |
Karthik Bhat | 8210fdf | 2015-04-23 04:51:44 +0000 | [diff] [blame] | 1419 | Value *Incoming = P->getIncomingValueForBlock(InnerLoopLatch); |
| 1420 | P->replaceAllUsesWith(Incoming); |
| 1421 | P->eraseFromParent(); |
| 1422 | } |
| 1423 | |
Karthik Bhat | 88db86d | 2015-03-06 10:11:25 +0000 | [diff] [blame] | 1424 | if (OuterLoopLatchBI->getSuccessor(0) == OuterLoopHeader) |
| 1425 | OuterLoopLatchSuccessor = OuterLoopLatchBI->getSuccessor(1); |
| 1426 | else |
| 1427 | OuterLoopLatchSuccessor = OuterLoopLatchBI->getSuccessor(0); |
| 1428 | |
Florian Hahn | c6296fe | 2018-02-14 13:13:15 +0000 | [diff] [blame] | 1429 | updateSuccessor(InnerLoopLatchBI, InnerLoopLatchSuccessor, |
| 1430 | OuterLoopLatchSuccessor, DTUpdates); |
| 1431 | updateSuccessor(OuterLoopLatchBI, OuterLoopLatchSuccessor, InnerLoopLatch, |
| 1432 | DTUpdates); |
Karthik Bhat | 88db86d | 2015-03-06 10:11:25 +0000 | [diff] [blame] | 1433 | |
Karthik Bhat | 8210fdf | 2015-04-23 04:51:44 +0000 | [diff] [blame] | 1434 | updateIncomingBlock(OuterLoopLatchSuccessor, OuterLoopLatch, InnerLoopLatch); |
| 1435 | |
Florian Hahn | c6296fe | 2018-02-14 13:13:15 +0000 | [diff] [blame] | 1436 | DT->applyUpdates(DTUpdates); |
Florian Hahn | 831a757 | 2018-04-05 09:48:45 +0000 | [diff] [blame] | 1437 | restructureLoops(OuterLoop, InnerLoop, InnerLoopPreHeader, |
| 1438 | OuterLoopPreHeader); |
| 1439 | |
Florian Hahn | d8fcf0d | 2018-06-19 08:03:24 +0000 | [diff] [blame] | 1440 | // Now update the reduction PHIs in the inner and outer loop headers. |
| 1441 | SmallVector<PHINode *, 4> InnerLoopPHIs, OuterLoopPHIs; |
| 1442 | for (PHINode &PHI : drop_begin(InnerLoopHeader->phis(), 1)) |
| 1443 | InnerLoopPHIs.push_back(cast<PHINode>(&PHI)); |
| 1444 | for (PHINode &PHI : drop_begin(OuterLoopHeader->phis(), 1)) |
| 1445 | OuterLoopPHIs.push_back(cast<PHINode>(&PHI)); |
| 1446 | |
| 1447 | for (PHINode *PHI : OuterLoopPHIs) |
| 1448 | PHI->moveBefore(InnerLoopHeader->getFirstNonPHI()); |
| 1449 | |
| 1450 | // Move the PHI nodes from the inner loop header to the outer loop header. |
| 1451 | // We have to deal with one kind of PHI nodes: |
| 1452 | // 1) PHI nodes that are part of inner loop-only reductions. |
| 1453 | // We only have to move the PHI node and update the incoming blocks. |
| 1454 | for (PHINode *PHI : InnerLoopPHIs) { |
| 1455 | PHI->moveBefore(OuterLoopHeader->getFirstNonPHI()); |
| 1456 | for (BasicBlock *InBB : PHI->blocks()) { |
| 1457 | if (InnerLoop->contains(InBB)) |
| 1458 | continue; |
| 1459 | |
| 1460 | assert(!isa<PHINode>(PHI->getIncomingValueForBlock(InBB)) && |
| 1461 | "Unexpected incoming PHI node, reductions in outer loop are not " |
| 1462 | "supported yet"); |
| 1463 | PHI->replaceAllUsesWith(PHI->getIncomingValueForBlock(InBB)); |
| 1464 | PHI->eraseFromParent(); |
| 1465 | break; |
| 1466 | } |
| 1467 | } |
| 1468 | |
| 1469 | // Update the incoming blocks for moved PHI nodes. |
| 1470 | updateIncomingBlock(OuterLoopHeader, InnerLoopPreHeader, OuterLoopPreHeader); |
| 1471 | updateIncomingBlock(OuterLoopHeader, InnerLoopLatch, OuterLoopLatch); |
| 1472 | updateIncomingBlock(InnerLoopHeader, OuterLoopPreHeader, InnerLoopPreHeader); |
| 1473 | updateIncomingBlock(InnerLoopHeader, OuterLoopLatch, InnerLoopLatch); |
| 1474 | |
Karthik Bhat | 88db86d | 2015-03-06 10:11:25 +0000 | [diff] [blame] | 1475 | return true; |
| 1476 | } |
Karthik Bhat | 88db86d | 2015-03-06 10:11:25 +0000 | [diff] [blame] | 1477 | |
Eugene Zelenko | dd40f5e | 2017-10-16 21:34:24 +0000 | [diff] [blame] | 1478 | void LoopInterchangeTransform::adjustLoopPreheaders() { |
Karthik Bhat | 88db86d | 2015-03-06 10:11:25 +0000 | [diff] [blame] | 1479 | // We have interchanged the preheaders so we need to interchange the data in |
| 1480 | // the preheader as well. |
| 1481 | // This is because the content of inner preheader was previously executed |
| 1482 | // inside the outer loop. |
| 1483 | BasicBlock *OuterLoopPreHeader = OuterLoop->getLoopPreheader(); |
| 1484 | BasicBlock *InnerLoopPreHeader = InnerLoop->getLoopPreheader(); |
| 1485 | BasicBlock *OuterLoopHeader = OuterLoop->getHeader(); |
| 1486 | BranchInst *InnerTermBI = |
| 1487 | cast<BranchInst>(InnerLoopPreHeader->getTerminator()); |
| 1488 | |
Karthik Bhat | 88db86d | 2015-03-06 10:11:25 +0000 | [diff] [blame] | 1489 | // These instructions should now be executed inside the loop. |
| 1490 | // Move instruction into a new block after outer header. |
Karthik Bhat | 8210fdf | 2015-04-23 04:51:44 +0000 | [diff] [blame] | 1491 | moveBBContents(InnerLoopPreHeader, OuterLoopHeader->getTerminator()); |
Karthik Bhat | 88db86d | 2015-03-06 10:11:25 +0000 | [diff] [blame] | 1492 | // These instructions were not executed previously in the loop so move them to |
| 1493 | // the older inner loop preheader. |
Benjamin Kramer | 7944292 | 2015-03-06 18:59:14 +0000 | [diff] [blame] | 1494 | moveBBContents(OuterLoopPreHeader, InnerTermBI); |
Karthik Bhat | 88db86d | 2015-03-06 10:11:25 +0000 | [diff] [blame] | 1495 | } |
| 1496 | |
| 1497 | bool LoopInterchangeTransform::adjustLoopLinks() { |
Karthik Bhat | 88db86d | 2015-03-06 10:11:25 +0000 | [diff] [blame] | 1498 | // Adjust all branches in the inner and outer loop. |
| 1499 | bool Changed = adjustLoopBranches(); |
| 1500 | if (Changed) |
| 1501 | adjustLoopPreheaders(); |
| 1502 | return Changed; |
| 1503 | } |
| 1504 | |
| 1505 | char LoopInterchange::ID = 0; |
Eugene Zelenko | dd40f5e | 2017-10-16 21:34:24 +0000 | [diff] [blame] | 1506 | |
Karthik Bhat | 88db86d | 2015-03-06 10:11:25 +0000 | [diff] [blame] | 1507 | INITIALIZE_PASS_BEGIN(LoopInterchange, "loop-interchange", |
| 1508 | "Interchanges loops for cache reuse", false, false) |
Chandler Carruth | 7b560d4 | 2015-09-09 17:55:00 +0000 | [diff] [blame] | 1509 | INITIALIZE_PASS_DEPENDENCY(AAResultsWrapperPass) |
Chandler Carruth | 49c2219 | 2016-05-12 22:19:39 +0000 | [diff] [blame] | 1510 | INITIALIZE_PASS_DEPENDENCY(DependenceAnalysisWrapperPass) |
Karthik Bhat | 88db86d | 2015-03-06 10:11:25 +0000 | [diff] [blame] | 1511 | INITIALIZE_PASS_DEPENDENCY(DominatorTreeWrapperPass) |
Chandler Carruth | 2f1fd16 | 2015-08-17 02:08:17 +0000 | [diff] [blame] | 1512 | INITIALIZE_PASS_DEPENDENCY(ScalarEvolutionWrapperPass) |
Karthik Bhat | 88db86d | 2015-03-06 10:11:25 +0000 | [diff] [blame] | 1513 | INITIALIZE_PASS_DEPENDENCY(LoopSimplify) |
Easwaran Raman | e12c487 | 2016-06-09 19:44:46 +0000 | [diff] [blame] | 1514 | INITIALIZE_PASS_DEPENDENCY(LCSSAWrapperPass) |
Karthik Bhat | 88db86d | 2015-03-06 10:11:25 +0000 | [diff] [blame] | 1515 | INITIALIZE_PASS_DEPENDENCY(LoopInfoWrapperPass) |
Florian Hahn | ad99352 | 2017-07-15 13:13:19 +0000 | [diff] [blame] | 1516 | INITIALIZE_PASS_DEPENDENCY(OptimizationRemarkEmitterWrapperPass) |
Karthik Bhat | 88db86d | 2015-03-06 10:11:25 +0000 | [diff] [blame] | 1517 | |
| 1518 | INITIALIZE_PASS_END(LoopInterchange, "loop-interchange", |
| 1519 | "Interchanges loops for cache reuse", false, false) |
| 1520 | |
| 1521 | Pass *llvm::createLoopInterchangePass() { return new LoopInterchange(); } |