blob: 3ed3cdeee1a93aba9d48937dc98d8ed5fb748243 [file] [log] [blame]
Alexander Kornienkoa48a12c2013-12-03 10:50:16 +00001//===- unittest/Format/FormatTestJS.cpp - Formatting unit tests for JS ----===//
2//
3// The LLVM Compiler Infrastructure
4//
5// This file is distributed under the University of Illinois Open Source
6// License. See LICENSE.TXT for details.
7//
8//===----------------------------------------------------------------------===//
9
Alexander Kornienkoa48a12c2013-12-03 10:50:16 +000010#include "FormatTestUtils.h"
Alexander Kornienkoa48a12c2013-12-03 10:50:16 +000011#include "clang/Format/Format.h"
12#include "llvm/Support/Debug.h"
13#include "gtest/gtest.h"
14
Chandler Carruth10346662014-04-22 03:17:02 +000015#define DEBUG_TYPE "format-test"
16
Alexander Kornienkoa48a12c2013-12-03 10:50:16 +000017namespace clang {
18namespace format {
19
20class FormatTestJS : public ::testing::Test {
21protected:
22 static std::string format(llvm::StringRef Code, unsigned Offset,
23 unsigned Length, const FormatStyle &Style) {
24 DEBUG(llvm::errs() << "---\n");
25 DEBUG(llvm::errs() << Code << "\n\n");
26 std::vector<tooling::Range> Ranges(1, tooling::Range(Offset, Length));
27 tooling::Replacements Replaces = reformat(Style, Code, Ranges);
28 std::string Result = applyAllReplacements(Code, Replaces);
29 EXPECT_NE("", Result);
30 DEBUG(llvm::errs() << "\n" << Result << "\n\n");
31 return Result;
32 }
33
Daniel Jasper069e5f42014-05-20 11:14:57 +000034 static std::string format(
35 llvm::StringRef Code,
36 const FormatStyle &Style = getGoogleStyle(FormatStyle::LK_JavaScript)) {
Alexander Kornienkoa48a12c2013-12-03 10:50:16 +000037 return format(Code, 0, Code.size(), Style);
38 }
39
Alexander Kornienkoc1637f12013-12-10 11:28:13 +000040 static FormatStyle getGoogleJSStyleWithColumns(unsigned ColumnLimit) {
Nico Weber514ecc82014-02-02 20:50:45 +000041 FormatStyle Style = getGoogleStyle(FormatStyle::LK_JavaScript);
Alexander Kornienkoa48a12c2013-12-03 10:50:16 +000042 Style.ColumnLimit = ColumnLimit;
43 return Style;
44 }
45
Nico Weber514ecc82014-02-02 20:50:45 +000046 static void verifyFormat(
47 llvm::StringRef Code,
48 const FormatStyle &Style = getGoogleStyle(FormatStyle::LK_JavaScript)) {
Alexander Kornienkoa48a12c2013-12-03 10:50:16 +000049 EXPECT_EQ(Code.str(), format(test::messUp(Code), Style));
50 }
51};
52
53TEST_F(FormatTestJS, UnderstandsJavaScriptOperators) {
54 verifyFormat("a == = b;");
55 verifyFormat("a != = b;");
56
57 verifyFormat("a === b;");
Daniel Jaspere551bb72014-11-05 17:22:31 +000058 verifyFormat("aaaaaaa ===\n b;", getGoogleJSStyleWithColumns(10));
Alexander Kornienkoa48a12c2013-12-03 10:50:16 +000059 verifyFormat("a !== b;");
Daniel Jaspere551bb72014-11-05 17:22:31 +000060 verifyFormat("aaaaaaa !==\n b;", getGoogleJSStyleWithColumns(10));
61 verifyFormat("if (a + b + c +\n"
62 " d !==\n"
63 " e + f + g)\n"
Alexander Kornienkoa48a12c2013-12-03 10:50:16 +000064 " q();",
Alexander Kornienkoc1637f12013-12-10 11:28:13 +000065 getGoogleJSStyleWithColumns(20));
Alexander Kornienkoa48a12c2013-12-03 10:50:16 +000066
67 verifyFormat("a >> >= b;");
68
69 verifyFormat("a >>> b;");
Daniel Jaspere551bb72014-11-05 17:22:31 +000070 verifyFormat("aaaaaaa >>>\n b;", getGoogleJSStyleWithColumns(10));
Alexander Kornienkoa48a12c2013-12-03 10:50:16 +000071 verifyFormat("a >>>= b;");
Daniel Jaspere551bb72014-11-05 17:22:31 +000072 verifyFormat("aaaaaaa >>>=\n b;", getGoogleJSStyleWithColumns(10));
73 verifyFormat("if (a + b + c +\n"
74 " d >>>\n"
75 " e + f + g)\n"
Alexander Kornienkoa48a12c2013-12-03 10:50:16 +000076 " q();",
Alexander Kornienkoc1637f12013-12-10 11:28:13 +000077 getGoogleJSStyleWithColumns(20));
Daniel Jaspere551bb72014-11-05 17:22:31 +000078 verifyFormat("var x = aaaaaaaaaa ?\n"
79 " bbbbbb :\n"
80 " ccc;",
Alexander Kornienkoc1637f12013-12-10 11:28:13 +000081 getGoogleJSStyleWithColumns(20));
Daniel Jasper78214392014-05-19 07:27:02 +000082
83 verifyFormat("var b = a.map((x) => x + 1);");
Daniel Jasper3549ea12014-09-19 10:48:15 +000084 verifyFormat("return ('aaa') in bbbb;");
Daniel Jasper08051992015-05-26 07:18:56 +000085
86 // ES6 spread operator.
87 verifyFormat("someFunction(...a);");
88 verifyFormat("var x = [1, ...a, 2];");
Alexander Kornienkoa48a12c2013-12-03 10:50:16 +000089}
90
Daniel Jasper3a038de2014-09-05 08:53:45 +000091TEST_F(FormatTestJS, UnderstandsAmpAmp) {
92 verifyFormat("e && e.SomeFunction();");
93}
94
Daniel Jasper4db69bd2014-09-04 18:23:42 +000095TEST_F(FormatTestJS, LiteralOperatorsCanBeKeywords) {
96 verifyFormat("not.and.or.not_eq = 1;");
97}
98
Daniel Jasper0dd52912014-05-19 07:37:07 +000099TEST_F(FormatTestJS, ES6DestructuringAssignment) {
100 verifyFormat("var [a, b, c] = [1, 2, 3];");
Daniel Jasper60948b12015-03-15 13:55:54 +0000101 verifyFormat("var {a, b} = {a: 1, b: 2};");
Daniel Jasper0dd52912014-05-19 07:37:07 +0000102}
103
Daniel Jasper17062ff2014-06-10 14:44:02 +0000104TEST_F(FormatTestJS, ContainerLiterals) {
Manuel Klimek79e06082015-05-21 12:23:34 +0000105 verifyFormat("var x = {y: function(a) { return a; }};");
Daniel Jasper17062ff2014-06-10 14:44:02 +0000106 verifyFormat("return {\n"
107 " link: function() {\n"
108 " f(); //\n"
109 " }\n"
110 "};");
111 verifyFormat("return {\n"
112 " a: a,\n"
113 " link: function() {\n"
114 " f(); //\n"
115 " }\n"
116 "};");
117 verifyFormat("return {\n"
118 " a: a,\n"
Daniel Jasper90ebc982014-09-05 09:27:38 +0000119 " link: function() {\n"
120 " f(); //\n"
121 " },\n"
122 " link: function() {\n"
123 " f(); //\n"
124 " }\n"
Daniel Jasper17062ff2014-06-10 14:44:02 +0000125 "};");
Daniel Jasper94e11d02014-09-04 14:58:30 +0000126 verifyFormat("var stuff = {\n"
127 " // comment for update\n"
128 " update: false,\n"
129 " // comment for modules\n"
130 " modules: false,\n"
131 " // comment for tasks\n"
132 " tasks: false\n"
133 "};");
Daniel Jasper97bfb7b2014-09-05 08:29:31 +0000134 verifyFormat("return {\n"
135 " 'finish':\n"
136 " //\n"
137 " a\n"
138 "};");
Daniel Jasper40874322014-11-27 15:24:48 +0000139 verifyFormat("var obj = {\n"
140 " fooooooooo: function(x) {\n"
141 " return x.zIsTooLongForOneLineWithTheDeclarationLine();\n"
142 " }\n"
143 "};");
Daniel Jasper60948b12015-03-15 13:55:54 +0000144 // Simple object literal, as opposed to enum style below.
145 verifyFormat("var obj = {a: 123};");
146 // Enum style top level assignment.
147 verifyFormat("X = {\n a: 123\n};");
148 verifyFormat("X.Y = {\n a: 123\n};");
149 verifyFormat("x = foo && {a: 123};");
Manuel Klimek79e06082015-05-21 12:23:34 +0000150
151 // Arrow functions in object literals.
152 verifyFormat("var x = {y: (a) => { return a; }};");
153 verifyFormat("var x = {y: (a) => a};");
Daniel Jasper8c42d442015-05-29 06:19:49 +0000154
155 // Computed keys.
Daniel Jaspercd8d4ff2015-05-31 08:40:37 +0000156 verifyFormat("var x = {[a]: 1, b: 2, [c]: 3};");
Daniel Jasper8c42d442015-05-29 06:19:49 +0000157 verifyFormat("var x = {\n"
158 " [a]: 1,\n"
Daniel Jaspercd8d4ff2015-05-31 08:40:37 +0000159 " b: 2,\n"
160 " [c]: 3,\n"
Daniel Jasper8c42d442015-05-29 06:19:49 +0000161 "};");
Daniel Jasper17062ff2014-06-10 14:44:02 +0000162}
163
Daniel Jasperf46dec82015-03-31 14:34:15 +0000164TEST_F(FormatTestJS, MethodsInObjectLiterals) {
165 verifyFormat("var o = {\n"
166 " value: 'test',\n"
167 " get value() { // getter\n"
168 " return this.value;\n"
169 " }\n"
170 "};");
171 verifyFormat("var o = {\n"
172 " value: 'test',\n"
173 " set value(val) { // setter\n"
174 " this.value = val;\n"
175 " }\n"
176 "};");
177 verifyFormat("var o = {\n"
178 " value: 'test',\n"
179 " someMethod(val) { // method\n"
180 " doSomething(this.value + val);\n"
181 " }\n"
182 "};");
Daniel Jasper739ec532015-04-04 07:56:55 +0000183 verifyFormat("var o = {\n"
184 " someMethod(val) { // method\n"
185 " doSomething(this.value + val);\n"
186 " },\n"
187 " someOtherMethod(val) { // method\n"
188 " doSomething(this.value + val);\n"
189 " }\n"
190 "};");
Daniel Jasperf46dec82015-03-31 14:34:15 +0000191}
192
Daniel Jasperb2e10a52014-01-15 15:09:08 +0000193TEST_F(FormatTestJS, SpacesInContainerLiterals) {
194 verifyFormat("var arr = [1, 2, 3];");
Daniel Jaspera4e55f42014-12-04 16:07:17 +0000195 verifyFormat("f({a: 1, b: 2, c: 3});");
Nico Weber514ecc82014-02-02 20:50:45 +0000196
Daniel Jasper2a958322014-05-21 13:26:58 +0000197 verifyFormat("var object_literal_with_long_name = {\n"
198 " a: 'aaaaaaaaaaaaaaaaaa',\n"
199 " b: 'bbbbbbbbbbbbbbbbbb'\n"
200 "};");
201
Daniel Jaspera4e55f42014-12-04 16:07:17 +0000202 verifyFormat("f({a: 1, b: 2, c: 3});",
Nico Weber514ecc82014-02-02 20:50:45 +0000203 getChromiumStyle(FormatStyle::LK_JavaScript));
Daniel Jaspera4e55f42014-12-04 16:07:17 +0000204 verifyFormat("f({'a': [{}]});");
Daniel Jasperb2e10a52014-01-15 15:09:08 +0000205}
206
Daniel Jasper86fee2f2014-01-31 12:49:42 +0000207TEST_F(FormatTestJS, SingleQuoteStrings) {
208 verifyFormat("this.function('', true);");
209}
210
Daniel Jasper4a39c842014-05-06 13:54:10 +0000211TEST_F(FormatTestJS, GoogScopes) {
212 verifyFormat("goog.scope(function() {\n"
213 "var x = a.b;\n"
214 "var y = c.d;\n"
215 "}); // goog.scope");
Daniel Jasper02c7bca2015-03-30 09:56:50 +0000216 verifyFormat("goog.scope(function() {\n"
217 "// test\n"
218 "var x = 0;\n"
219 "// test\n"
220 "});");
Daniel Jasper4a39c842014-05-06 13:54:10 +0000221}
222
Daniel Jasper616de8642014-11-23 16:46:28 +0000223TEST_F(FormatTestJS, GoogModules) {
224 verifyFormat("goog.module('this.is.really.absurdly.long');",
225 getGoogleJSStyleWithColumns(40));
226 verifyFormat("goog.require('this.is.really.absurdly.long');",
227 getGoogleJSStyleWithColumns(40));
228 verifyFormat("goog.provide('this.is.really.absurdly.long');",
229 getGoogleJSStyleWithColumns(40));
230 verifyFormat("var long = goog.require('this.is.really.absurdly.long');",
231 getGoogleJSStyleWithColumns(40));
Daniel Jasper53c38f42014-11-27 14:46:03 +0000232
233 // These should be wrapped normally.
234 verifyFormat(
235 "var MyLongClassName =\n"
236 " goog.module.get('my.long.module.name.followedBy.MyLongClassName');");
Daniel Jasper616de8642014-11-23 16:46:28 +0000237}
238
Daniel Jasperad9eb0d2014-06-30 13:24:54 +0000239TEST_F(FormatTestJS, FormatsFreestandingFunctions) {
240 verifyFormat("function outer1(a, b) {\n"
241 " function inner1(a, b) { return a; }\n"
242 " inner1(a, b);\n"
243 "}\n"
244 "function outer2(a, b) {\n"
245 " function inner2(a, b) { return a; }\n"
246 " inner2(a, b);\n"
247 "}");
248}
249
Daniel Jasperf841d3a2015-05-28 07:21:50 +0000250TEST_F(FormatTestJS, ArrayLiterals) {
251 verifyFormat("var aaaaa: List<SomeThing> = [\n"
252 " new SomeThingAAAAAAAAAAAA(),\n"
253 " new SomeThingBBBBBBBBB()\n"
254 "];");
Daniel Jasperd492b5e2015-06-02 21:57:51 +0000255 verifyFormat("return [\n"
256 " aaaaaaaaaaaaaaaaaaaaaaaaaaa,\n"
257 " bbbbbbbbbbbbbbbbbbbbbbbbbbb,\n"
258 " ccccccccccccccccccccccccccc\n"
259 "];");
Daniel Jasper5ce80de2015-06-02 13:56:43 +0000260 verifyFormat("var someVariable = SomeFuntion([\n"
261 " aaaaaaaaaaaaaaaaaaaaaaaaaaa,\n"
262 " bbbbbbbbbbbbbbbbbbbbbbbbbbb,\n"
263 " ccccccccccccccccccccccccccc\n"
264 "]);");
Daniel Jasper40432ce2015-06-02 15:04:29 +0000265 verifyFormat("var someVariable = SomeFuntion([\n"
266 " [aaaaaaaaaaaaaaaaaaaaaa, bbbbbbbbbbbbbbbbbbbbbb],\n"
Daniel Jasper199d0c92015-06-02 15:14:21 +0000267 "]);",
268 getGoogleJSStyleWithColumns(51));
Daniel Jasper4284e362015-06-02 14:20:08 +0000269 verifyFormat("var someVariable = SomeFuntion(aaaa, [\n"
270 " aaaaaaaaaaaaaaaaaaaaaaaaaaa,\n"
271 " bbbbbbbbbbbbbbbbbbbbbbbbbbb,\n"
272 " ccccccccccccccccccccccccccc\n"
273 "]);");
Daniel Jasper1feab0f2015-06-02 15:31:37 +0000274
275 verifyFormat("someFunction([], {a: a});");
Daniel Jasperf841d3a2015-05-28 07:21:50 +0000276}
277
Daniel Jasper5217a8b2014-06-13 07:02:04 +0000278TEST_F(FormatTestJS, FunctionLiterals) {
Daniel Jasper3f69ba12014-09-05 08:42:27 +0000279 verifyFormat("doFoo(function() {});");
Daniel Jasper79dffb42014-05-07 09:48:30 +0000280 verifyFormat("doFoo(function() { return 1; });");
Daniel Jasper67f8ad22014-09-30 17:57:06 +0000281 verifyFormat("var func = function() {\n"
282 " return 1;\n"
283 "};");
Daniel Jasperc03e16a2014-05-08 09:25:39 +0000284 verifyFormat("return {\n"
285 " body: {\n"
286 " setAttribute: function(key, val) { this[key] = val; },\n"
287 " getAttribute: function(key) { return this[key]; },\n"
288 " style: {direction: ''}\n"
289 " }\n"
290 "};");
Daniel Jaspere551bb72014-11-05 17:22:31 +0000291 EXPECT_EQ("abc = xyz ?\n"
292 " function() {\n"
293 " return 1;\n"
294 " } :\n"
295 " function() {\n"
Daniel Jasper11a0ac62014-12-12 09:40:58 +0000296 " return -1;\n"
297 " };",
Daniel Jasper069e5f42014-05-20 11:14:57 +0000298 format("abc=xyz?function(){return 1;}:function(){return -1;};"));
Daniel Jasperb16b9692014-05-21 12:51:23 +0000299
300 verifyFormat("var closure = goog.bind(\n"
301 " function() { // comment\n"
302 " foo();\n"
303 " bar();\n"
304 " },\n"
305 " this, arg1IsReallyLongAndNeeedsLineBreaks,\n"
306 " arg3IsReallyLongAndNeeedsLineBreaks);");
307 verifyFormat("var closure = goog.bind(function() { // comment\n"
308 " foo();\n"
309 " bar();\n"
310 "}, this);");
Daniel Jasper58cb2ed2014-06-06 13:49:04 +0000311 verifyFormat("return {\n"
312 " a: 'E',\n"
313 " b: function() {\n"
314 " return function() {\n"
315 " f(); //\n"
316 " };\n"
317 " }\n"
318 "};");
Daniel Jasper41368e92014-11-27 15:37:42 +0000319 verifyFormat("{\n"
320 " var someVariable = function(x) {\n"
321 " return x.zIsTooLongForOneLineWithTheDeclarationLine();\n"
322 " };\n"
323 "}");
Daniel Jasper7325aee2015-05-08 08:38:52 +0000324 verifyFormat("someLooooooooongFunction(\n"
325 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa,\n"
326 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa,\n"
327 " function(aaaaaaaaaaaaaaaaaaaaaaaaaaaaa) {\n"
328 " // code\n"
329 " });");
Daniel Jasper5f3ea472014-05-22 08:36:53 +0000330
Daniel Jaspera4e55f42014-12-04 16:07:17 +0000331 verifyFormat("f({a: function() { return 1; }});",
332 getGoogleJSStyleWithColumns(33));
333 verifyFormat("f({\n"
Daniel Jasper5f3ea472014-05-22 08:36:53 +0000334 " a: function() { return 1; }\n"
Daniel Jaspera4e55f42014-12-04 16:07:17 +0000335 "});",
336 getGoogleJSStyleWithColumns(32));
Daniel Jasper5217a8b2014-06-13 07:02:04 +0000337
338 verifyFormat("return {\n"
339 " a: function SomeFunction() {\n"
340 " // ...\n"
341 " return 1;\n"
342 " }\n"
343 "};");
Daniel Jasper11a0ac62014-12-12 09:40:58 +0000344 verifyFormat("this.someObject.doSomething(aaaaaaaaaaaaaaaaaaaaaaaaaa)\n"
345 " .then(goog.bind(function(aaaaaaaaaaa) {\n"
346 " someFunction();\n"
347 " someFunction();\n"
348 " }, this), aaaaaaaaaaaaaaaaa);");
349
350 // FIXME: This is not ideal yet.
351 verifyFormat("someFunction(goog.bind(\n"
352 " function() {\n"
353 " doSomething();\n"
354 " doSomething();\n"
355 " },\n"
356 " this),\n"
357 " goog.bind(function() {\n"
358 " doSomething();\n"
359 " doSomething();\n"
360 " }, this));");
Daniel Jasper1699eca2015-06-01 09:56:32 +0000361
362 // FIXME: This is bad, we should be wrapping before "function() {".
363 verifyFormat("someFunction(function() {\n"
364 " doSomething(); // break\n"
365 "})\n"
366 " .doSomethingElse(\n"
367 " // break\n"
368 " );");
Daniel Jasper79dffb42014-05-07 09:48:30 +0000369}
370
Daniel Jasper67f8ad22014-09-30 17:57:06 +0000371TEST_F(FormatTestJS, InliningFunctionLiterals) {
372 FormatStyle Style = getGoogleStyle(FormatStyle::LK_JavaScript);
373 Style.AllowShortFunctionsOnASingleLine = FormatStyle::SFS_Inline;
374 verifyFormat("var func = function() {\n"
375 " return 1;\n"
376 "};",
377 Style);
378 verifyFormat("var func = doSomething(function() { return 1; });", Style);
379 verifyFormat("var outer = function() {\n"
380 " var inner = function() { return 1; }\n"
381 "};",
382 Style);
383 verifyFormat("function outer1(a, b) {\n"
384 " function inner1(a, b) { return a; }\n"
385 "}",
386 Style);
387
388 Style.AllowShortFunctionsOnASingleLine = FormatStyle::SFS_All;
389 verifyFormat("var func = function() { return 1; };", Style);
390 verifyFormat("var func = doSomething(function() { return 1; });", Style);
391 verifyFormat(
392 "var outer = function() { var inner = function() { return 1; } };",
393 Style);
394 verifyFormat("function outer1(a, b) {\n"
395 " function inner1(a, b) { return a; }\n"
396 "}",
397 Style);
398
399 Style.AllowShortFunctionsOnASingleLine = FormatStyle::SFS_None;
400 verifyFormat("var func = function() {\n"
401 " return 1;\n"
402 "};",
403 Style);
404 verifyFormat("var func = doSomething(function() {\n"
405 " return 1;\n"
406 "});",
407 Style);
408 verifyFormat("var outer = function() {\n"
409 " var inner = function() {\n"
410 " return 1;\n"
411 " }\n"
412 "};",
413 Style);
414 verifyFormat("function outer1(a, b) {\n"
415 " function inner1(a, b) {\n"
416 " return a;\n"
417 " }\n"
418 "}",
419 Style);
420}
421
Daniel Jasper114a2bc2014-06-03 12:02:45 +0000422TEST_F(FormatTestJS, MultipleFunctionLiterals) {
423 verifyFormat("promise.then(\n"
424 " function success() {\n"
425 " doFoo();\n"
426 " doBar();\n"
427 " },\n"
428 " function error() {\n"
429 " doFoo();\n"
430 " doBaz();\n"
431 " },\n"
432 " []);\n");
433 verifyFormat("promise.then(\n"
434 " function success() {\n"
435 " doFoo();\n"
436 " doBar();\n"
437 " },\n"
438 " [],\n"
439 " function error() {\n"
440 " doFoo();\n"
441 " doBaz();\n"
442 " });\n");
443 // FIXME: Here, we should probably break right after the "(" for consistency.
444 verifyFormat("promise.then([],\n"
445 " function success() {\n"
446 " doFoo();\n"
447 " doBar();\n"
448 " },\n"
449 " function error() {\n"
450 " doFoo();\n"
451 " doBaz();\n"
452 " });\n");
Daniel Jasper1779d432014-09-29 07:54:54 +0000453
454 verifyFormat("getSomeLongPromise()\n"
455 " .then(function(value) { body(); })\n"
Daniel Jasper11a0ac62014-12-12 09:40:58 +0000456 " .thenCatch(function(error) {\n"
457 " body();\n"
458 " body();\n"
459 " });");
Daniel Jasper1779d432014-09-29 07:54:54 +0000460 verifyFormat("getSomeLongPromise()\n"
461 " .then(function(value) {\n"
462 " body();\n"
463 " body();\n"
464 " })\n"
465 " .thenCatch(function(error) {\n"
466 " body();\n"
467 " body();\n"
468 " });");
Daniel Jasper11a0ac62014-12-12 09:40:58 +0000469
Daniel Jasperacf67e32015-04-07 08:20:35 +0000470 verifyFormat("getSomeLongPromise()\n"
471 " .then(function(value) { body(); })\n"
472 " .thenCatch(function(error) { body(); });");
Daniel Jasper114a2bc2014-06-03 12:02:45 +0000473}
474
Manuel Klimek79e06082015-05-21 12:23:34 +0000475TEST_F(FormatTestJS, ArrowFunctions) {
476 verifyFormat("var x = (a) => {\n"
477 " return a;\n"
478 "};");
479 verifyFormat("var x = (a) => {\n"
480 " function y() { return 42; }\n"
481 " return a;\n"
482 "};");
483 verifyFormat("var x = (a: type): {some: type} => {\n"
484 " return a;\n"
485 "};");
486 verifyFormat("var x = (a) => a;");
Daniel Jaspere497bed2015-06-02 22:06:07 +0000487 verifyFormat("return () => [];");
Daniel Jasper1699eca2015-06-01 09:56:32 +0000488
489 // FIXME: This is bad, we should be wrapping before "() => {".
490 verifyFormat("someFunction(() => {\n"
491 " doSomething(); // break\n"
492 "})\n"
493 " .doSomethingElse(\n"
494 " // break\n"
495 " );");
Manuel Klimek79e06082015-05-21 12:23:34 +0000496}
497
Daniel Jasper166c19b2014-05-06 14:12:21 +0000498TEST_F(FormatTestJS, ReturnStatements) {
Daniel Jasper67f8ad22014-09-30 17:57:06 +0000499 verifyFormat("function() {\n"
500 " return [hello, world];\n"
501 "}");
Daniel Jasper166c19b2014-05-06 14:12:21 +0000502}
503
Manuel Klimek79e06082015-05-21 12:23:34 +0000504TEST_F(FormatTestJS, ClosureStyleCasts) {
Daniel Jasper484033b2014-05-06 14:41:29 +0000505 verifyFormat("var x = /** @type {foo} */ (bar);");
506}
507
Daniel Jasper04a71a42014-05-08 11:58:24 +0000508TEST_F(FormatTestJS, TryCatch) {
509 verifyFormat("try {\n"
510 " f();\n"
511 "} catch (e) {\n"
512 " g();\n"
513 "} finally {\n"
514 " h();\n"
515 "}");
Daniel Jasper8f2e94c2014-09-04 15:03:34 +0000516
517 // But, of course, "catch" is a perfectly fine function name in JavaScript.
518 verifyFormat("someObject.catch();");
Daniel Jasper79121232014-11-27 14:55:17 +0000519 verifyFormat("someObject.new();");
520 verifyFormat("someObject.delete();");
Daniel Jasper04a71a42014-05-08 11:58:24 +0000521}
522
Daniel Jasper49802ef2014-05-22 09:10:04 +0000523TEST_F(FormatTestJS, StringLiteralConcatenation) {
524 verifyFormat("var literal = 'hello ' +\n"
525 " 'world';");
526}
527
Daniel Jasperf9ae3122014-05-08 07:01:45 +0000528TEST_F(FormatTestJS, RegexLiteralClassification) {
529 // Regex literals.
530 verifyFormat("var regex = /abc/;");
531 verifyFormat("f(/abc/);");
532 verifyFormat("f(abc, /abc/);");
533 verifyFormat("some_map[/abc/];");
534 verifyFormat("var x = a ? /abc/ : /abc/;");
535 verifyFormat("for (var i = 0; /abc/.test(s[i]); i++) {\n}");
536 verifyFormat("var x = !/abc/.test(y);");
537 verifyFormat("var x = a && /abc/.test(y);");
538 verifyFormat("var x = a || /abc/.test(y);");
539 verifyFormat("var x = a + /abc/.search(y);");
Daniel Jasperf7405c12014-05-08 07:45:18 +0000540 verifyFormat("var regexs = {/abc/, /abc/};");
541 verifyFormat("return /abc/;");
Daniel Jasperf9ae3122014-05-08 07:01:45 +0000542
543 // Not regex literals.
544 verifyFormat("var a = a / 2 + b / 3;");
545}
546
547TEST_F(FormatTestJS, RegexLiteralSpecialCharacters) {
Daniel Jasper69694b02015-05-08 07:55:13 +0000548 verifyFormat("var regex = /=/;");
Daniel Jasperf9ae3122014-05-08 07:01:45 +0000549 verifyFormat("var regex = /a*/;");
550 verifyFormat("var regex = /a+/;");
551 verifyFormat("var regex = /a?/;");
552 verifyFormat("var regex = /.a./;");
553 verifyFormat("var regex = /a\\*/;");
554 verifyFormat("var regex = /^a$/;");
555 verifyFormat("var regex = /\\/a/;");
556 verifyFormat("var regex = /(?:x)/;");
557 verifyFormat("var regex = /x(?=y)/;");
558 verifyFormat("var regex = /x(?!y)/;");
559 verifyFormat("var regex = /x|y/;");
560 verifyFormat("var regex = /a{2}/;");
561 verifyFormat("var regex = /a{1,3}/;");
562 verifyFormat("var regex = /[abc]/;");
563 verifyFormat("var regex = /[^abc]/;");
564 verifyFormat("var regex = /[\\b]/;");
565 verifyFormat("var regex = /\\b/;");
566 verifyFormat("var regex = /\\B/;");
567 verifyFormat("var regex = /\\d/;");
568 verifyFormat("var regex = /\\D/;");
569 verifyFormat("var regex = /\\f/;");
570 verifyFormat("var regex = /\\n/;");
571 verifyFormat("var regex = /\\r/;");
572 verifyFormat("var regex = /\\s/;");
573 verifyFormat("var regex = /\\S/;");
574 verifyFormat("var regex = /\\t/;");
575 verifyFormat("var regex = /\\v/;");
576 verifyFormat("var regex = /\\w/;");
577 verifyFormat("var regex = /\\W/;");
578 verifyFormat("var regex = /a(a)\\1/;");
579 verifyFormat("var regex = /\\0/;");
Daniel Jasperfb4333b2014-05-12 11:29:50 +0000580 verifyFormat("var regex = /\\\\/g;");
581 verifyFormat("var regex = /\\a\\\\/g;");
582 verifyFormat("var regex = /\a\\//g;");
Daniel Jasper23376252014-09-09 14:37:39 +0000583 verifyFormat("var regex = /a\\//;\n"
584 "var x = 0;");
Daniel Jasper49a9a282014-10-29 16:51:38 +0000585 EXPECT_EQ("var regex = /\\/*/;\n"
586 "var x = 0;",
587 format("var regex = /\\/*/;\n"
588 "var x=0;"));
Daniel Jasperf9ae3122014-05-08 07:01:45 +0000589}
590
591TEST_F(FormatTestJS, RegexLiteralModifiers) {
592 verifyFormat("var regex = /abc/g;");
593 verifyFormat("var regex = /abc/i;");
594 verifyFormat("var regex = /abc/m;");
595 verifyFormat("var regex = /abc/y;");
596}
597
598TEST_F(FormatTestJS, RegexLiteralLength) {
599 verifyFormat("var regex = /aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa/;",
600 getGoogleJSStyleWithColumns(60));
601 verifyFormat("var regex =\n"
602 " /aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa/;",
603 getGoogleJSStyleWithColumns(60));
Daniel Jasper0580ff02014-12-17 09:11:08 +0000604 verifyFormat("var regex = /\\xaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa/;",
605 getGoogleJSStyleWithColumns(50));
Daniel Jasperf9ae3122014-05-08 07:01:45 +0000606}
607
608TEST_F(FormatTestJS, RegexLiteralExamples) {
609 verifyFormat("var regex = search.match(/(?:\?|&)times=([^?&]+)/i);");
610}
611
Daniel Jasperb10bdff2015-02-18 17:09:53 +0000612TEST_F(FormatTestJS, TypeAnnotations) {
613 verifyFormat("var x: string;");
614 verifyFormat("function x(): string {\n return 'x';\n}");
Manuel Klimek79e06082015-05-21 12:23:34 +0000615 verifyFormat("function x(): {x: string} {\n return {x: 'x'};\n}");
Daniel Jasperb10bdff2015-02-18 17:09:53 +0000616 verifyFormat("function x(y: string): string {\n return 'x';\n}");
617 verifyFormat("for (var y: string in x) {\n x();\n}");
618 verifyFormat("((a: string, b: number): string => a + b);");
619 verifyFormat("var x: (y: number) => string;");
620 verifyFormat("var x: P<string, (a: number) => string>;");
Manuel Klimek79e06082015-05-21 12:23:34 +0000621 verifyFormat("var x = {y: function(): z { return 1; }};");
622 verifyFormat("var x = {y: function(): {a: number} { return 1; }};");
Daniel Jasperb10bdff2015-02-18 17:09:53 +0000623}
624
Daniel Jasper83709082015-02-18 17:14:05 +0000625TEST_F(FormatTestJS, ClassDeclarations) {
626 verifyFormat("class C {\n x: string = 12;\n}");
627 verifyFormat("class C {\n x(): string => 12;\n}");
628 verifyFormat("class C {\n ['x' + 2]: string = 12;\n}");
629 verifyFormat("class C {\n private x: string = 12;\n}");
630 verifyFormat("class C {\n private static x: string = 12;\n}");
631 verifyFormat("class C {\n static x(): string { return 'asd'; }\n}");
632 verifyFormat("class C extends P implements I {}");
Daniel Jasper6a5d38d2015-04-13 14:56:54 +0000633 verifyFormat("class C extends p.P implements i.I {}");
Daniel Jasper81dbb562015-06-03 08:43:18 +0000634
635 // ':' is not a type declaration here.
636 verifyFormat("class X {\n"
637 " subs = {\n"
638 " 'b': {\n"
639 " 'c': 1,\n"
640 " },\n"
641 " };\n"
642 "}");
Daniel Jasper83709082015-02-18 17:14:05 +0000643}
644
Daniel Jasper29647492015-05-05 08:12:50 +0000645TEST_F(FormatTestJS, InterfaceDeclarations) {
646 verifyFormat("interface I {\n"
647 " x: string;\n"
648 "}");
649}
650
Daniel Jasper3c42dba2015-02-18 17:17:15 +0000651TEST_F(FormatTestJS, MetadataAnnotations) {
652 verifyFormat("@A\nclass C {\n}");
653 verifyFormat("@A({arg: 'value'})\nclass C {\n}");
654 verifyFormat("@A\n@B\nclass C {\n}");
655 verifyFormat("class C {\n @A x: string;\n}");
656 verifyFormat("class C {\n"
657 " @A\n"
658 " private x(): string {\n"
659 " return 'y';\n"
660 " }\n"
661 "}");
Daniel Jasper6fa9ec72015-02-19 16:03:16 +0000662 verifyFormat("class X {}\n"
663 "class Y {}");
Daniel Jasper3c42dba2015-02-18 17:17:15 +0000664}
665
Daniel Jasper354aa512015-02-19 16:07:32 +0000666TEST_F(FormatTestJS, Modules) {
667 verifyFormat("import SomeThing from 'some/module.js';");
668 verifyFormat("import {X, Y} from 'some/module.js';");
669 verifyFormat("import {\n"
670 " VeryLongImportsAreAnnoying,\n"
671 " VeryLongImportsAreAnnoying,\n"
672 " VeryLongImportsAreAnnoying,\n"
673 " VeryLongImportsAreAnnoying\n"
674 "} from 'some/module.js';");
675 verifyFormat("import {\n"
676 " X,\n"
677 " Y,\n"
678 "} from 'some/module.js';");
679 verifyFormat("import {\n"
680 " X,\n"
681 " Y,\n"
682 "} from 'some/long/module.js';",
683 getGoogleJSStyleWithColumns(20));
684 verifyFormat("import {X as myLocalX, Y as myLocalY} from 'some/module.js';");
685 verifyFormat("import * as lib from 'some/module.js';");
Daniel Jasper60948b12015-03-15 13:55:54 +0000686 verifyFormat("var x = {import: 1};\nx.import = 2;");
Daniel Jasperfca735c2015-02-19 16:14:18 +0000687
688 verifyFormat("export function fn() {\n"
689 " return 'fn';\n"
690 "}");
Daniel Jasper668c7bb2015-05-11 09:03:10 +0000691 verifyFormat("export function A() {\n"
692 "}\n"
693 "export default function B() {\n"
694 "}\n"
695 "export function C() {\n"
696 "}");
Daniel Jasper354aa512015-02-19 16:07:32 +0000697 verifyFormat("export const x = 12;");
698 verifyFormat("export default class X {}");
Daniel Jasperfca735c2015-02-19 16:14:18 +0000699 verifyFormat("export {X, Y} from 'some/module.js';");
700 verifyFormat("export {\n"
701 " X,\n"
702 " Y,\n"
703 "} from 'some/module.js';");
704 verifyFormat("export class C {\n"
705 " x: number;\n"
706 " y: string;\n"
707 "}");
708 verifyFormat("export class X { y: number; }");
709 verifyFormat("export default class X { y: number }");
710 verifyFormat("export default function() {\n return 1;\n}");
711 verifyFormat("export var x = 12;");
712 verifyFormat("export var x: number = 12;");
713 verifyFormat("export const y = {\n"
714 " a: 1,\n"
715 " b: 2\n"
716 "};");
Daniel Jasper354aa512015-02-19 16:07:32 +0000717}
718
Daniel Jaspera0ef4f32015-02-20 13:47:38 +0000719TEST_F(FormatTestJS, TemplateStrings) {
720 // Keeps any whitespace/indentation within the template string.
721 EXPECT_EQ("var x = `hello\n"
722 " ${ name }\n"
723 " !`;",
724 format("var x = `hello\n"
725 " ${ name }\n"
726 " !`;"));
727
728 // FIXME: +1 / -1 offsets are to work around clang-format miscalculating
729 // widths for unknown tokens that are not whitespace (e.g. '`'). Remove when
730 // the code is corrected.
731
732 verifyFormat("var x =\n"
733 " `hello ${world}` >= some();",
734 getGoogleJSStyleWithColumns(34)); // Barely doesn't fit.
735 verifyFormat("var x = `hello ${world}` >= some();",
736 getGoogleJSStyleWithColumns(35 + 1)); // Barely fits.
737 EXPECT_EQ("var x = `hello\n"
738 " ${world}` >=\n"
739 " some();",
740 format("var x =\n"
741 " `hello\n"
742 " ${world}` >= some();",
743 getGoogleJSStyleWithColumns(21))); // Barely doesn't fit.
744 EXPECT_EQ("var x = `hello\n"
745 " ${world}` >= some();",
746 format("var x =\n"
747 " `hello\n"
748 " ${world}` >= some();",
749 getGoogleJSStyleWithColumns(22))); // Barely fits.
750
751 verifyFormat("var x =\n `h`;", getGoogleJSStyleWithColumns(13 - 1));
752 EXPECT_EQ(
753 "var x =\n `multi\n line`;",
754 format("var x = `multi\n line`;", getGoogleJSStyleWithColumns(14 - 1)));
755
Daniel Jasperf69b9222015-05-02 08:05:38 +0000756 // Make sure template strings get a proper ColumnWidth assigned, even if they
757 // are first token in line.
758 verifyFormat(
759 "var a = aaaaaaaaaaaaaaaaaaaaaaaaaaaa ||\n"
760 " `aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa`;");
761
Daniel Jaspera0ef4f32015-02-20 13:47:38 +0000762 // Two template strings.
763 verifyFormat("var x = `hello` == `hello`;");
Daniel Jasper0d6ac272015-04-16 08:20:51 +0000764
765 // Comments in template strings.
766 EXPECT_EQ("var x = `//a`;\n"
767 "var y;",
768 format("var x =\n `//a`;\n"
769 "var y ;"));
770 EXPECT_EQ("var x = `/*a`;\n"
771 "var y;",
772 format("var x =\n `/*a`;\n"
773 "var y;"));
774 // Backticks in a comment - not a template string.
775 EXPECT_EQ("var x = 1 // `/*a`;\n"
776 " ;",
777 format("var x =\n 1 // `/*a`;\n"
778 " ;"));
779 EXPECT_EQ("/* ` */ var x = 1; /* ` */",
780 format("/* ` */ var x\n= 1; /* ` */"));
781 // Comment spans multiple template strings.
782 EXPECT_EQ("var x = `/*a`;\n"
783 "var y = ` */ `;",
784 format("var x =\n `/*a`;\n"
785 "var y =\n ` */ `;"));
786 // Escaped backtick.
787 EXPECT_EQ("var x = ` \\` a`;\n"
788 "var y;",
789 format("var x = ` \\` a`;\n"
790 "var y;"));
Daniel Jaspera0ef4f32015-02-20 13:47:38 +0000791}
792
Daniel Jasperbc46b932015-03-15 13:59:51 +0000793TEST_F(FormatTestJS, CastSyntax) {
794 verifyFormat("var x = <type>foo;");
795}
796
797TEST_F(FormatTestJS, TypeArguments) {
798 verifyFormat("class X<Y> {}");
799 verifyFormat("new X<Y>();");
800 verifyFormat("foo<Y>(a);");
801 verifyFormat("var x: X<Y>[];");
802 verifyFormat("class C extends D<E> implements F<G>, H<I> {}");
Daniel Jasperd2219062015-05-02 07:54:58 +0000803 verifyFormat("function f(a: List<any> = null) {\n}");
804 verifyFormat("function f(): List<any> {\n}");
Daniel Jasperbc46b932015-03-15 13:59:51 +0000805}
806
Daniel Jaspera74f5072015-04-13 15:01:40 +0000807TEST_F(FormatTestJS, OptionalTypes) {
808 verifyFormat("function x(a?: b, c?, d?) {\n}");
809 verifyFormat("class X {\n"
810 " y?: z;\n"
811 " z?;\n"
812 "}");
Daniel Jasper9326f912015-05-05 08:40:32 +0000813 verifyFormat("interface X {\n"
814 " y?(): z;\n"
815 "}");
816 verifyFormat("x ? 1 : 2;");
Daniel Jasper3e0dcc22015-05-27 05:37:40 +0000817 verifyFormat("constructor({aa}: {\n"
818 " aa?: string,\n"
819 " aaaaaaaa?: string,\n"
820 " aaaaaaaaaaaaaaa?: boolean,\n"
821 " aaaaaa?: List<string>\n"
822 "}) {\n"
823 "}");
Daniel Jaspera74f5072015-04-13 15:01:40 +0000824}
825
Daniel Jasperd9309772015-04-13 15:03:30 +0000826TEST_F(FormatTestJS, IndexSignature) {
827 verifyFormat("var x: {[k: string]: v};");
828}
829
Alexander Kornienkoa48a12c2013-12-03 10:50:16 +0000830} // end namespace tooling
831} // end namespace clang