blob: 5ca0ed2567529c586104e7bc15eb596311ac8ddc [file] [log] [blame]
Chris Lattner2188e402010-01-04 07:37:31 +00001//===- InstCombineCompares.cpp --------------------------------------------===//
2//
3// The LLVM Compiler Infrastructure
4//
5// This file is distributed under the University of Illinois Open Source
6// License. See LICENSE.TXT for details.
7//
8//===----------------------------------------------------------------------===//
9//
10// This file implements the visitICmp and visitFCmp functions.
11//
12//===----------------------------------------------------------------------===//
13
Chandler Carrutha9174582015-01-22 05:25:13 +000014#include "InstCombineInternal.h"
Matt Arsenault55e73122015-01-06 15:50:59 +000015#include "llvm/ADT/APSInt.h"
Silviu Barangaf29dfd32016-01-15 15:52:05 +000016#include "llvm/ADT/SetVector.h"
Gerolf Hoflehnerec6217c2014-11-21 23:36:44 +000017#include "llvm/ADT/Statistic.h"
Eli Friedman911e12f2011-07-20 21:57:23 +000018#include "llvm/Analysis/ConstantFolding.h"
Chris Lattner2188e402010-01-04 07:37:31 +000019#include "llvm/Analysis/InstructionSimplify.h"
20#include "llvm/Analysis/MemoryBuiltins.h"
Mehdi Aminib550cb12016-04-18 09:17:29 +000021#include "llvm/Analysis/TargetLibraryInfo.h"
22#include "llvm/Analysis/VectorUtils.h"
Chandler Carruth8cd041e2014-03-04 12:24:34 +000023#include "llvm/IR/ConstantRange.h"
Chandler Carruth9fb823b2013-01-02 11:36:10 +000024#include "llvm/IR/DataLayout.h"
Chandler Carruth03eb0de2014-03-04 10:40:04 +000025#include "llvm/IR/GetElementPtrTypeIterator.h"
Chandler Carruth9fb823b2013-01-02 11:36:10 +000026#include "llvm/IR/IntrinsicInst.h"
Chandler Carruth820a9082014-03-04 11:08:18 +000027#include "llvm/IR/PatternMatch.h"
Gerolf Hoflehnerec6217c2014-11-21 23:36:44 +000028#include "llvm/Support/Debug.h"
Craig Topperb45eabc2017-04-26 16:39:58 +000029#include "llvm/Support/KnownBits.h"
Gerolf Hoflehnerec6217c2014-11-21 23:36:44 +000030
Chris Lattner2188e402010-01-04 07:37:31 +000031using namespace llvm;
32using namespace PatternMatch;
33
Chandler Carruth964daaa2014-04-22 02:55:47 +000034#define DEBUG_TYPE "instcombine"
35
Gerolf Hoflehnerec6217c2014-11-21 23:36:44 +000036// How many times is a select replaced by one of its operands?
37STATISTIC(NumSel, "Number of select opts");
38
Chris Lattner98457102011-02-10 05:23:05 +000039
Sanjay Pateld93c4c02016-09-15 18:22:25 +000040static ConstantInt *extractElement(Constant *V, Constant *Idx) {
Chris Lattner2188e402010-01-04 07:37:31 +000041 return cast<ConstantInt>(ConstantExpr::getExtractElement(V, Idx));
42}
43
Sanjay Pateld93c4c02016-09-15 18:22:25 +000044static bool hasAddOverflow(ConstantInt *Result,
Chris Lattner2188e402010-01-04 07:37:31 +000045 ConstantInt *In1, ConstantInt *In2,
46 bool IsSigned) {
Chris Lattnerb1a15122011-07-15 06:08:15 +000047 if (!IsSigned)
Chris Lattner2188e402010-01-04 07:37:31 +000048 return Result->getValue().ult(In1->getValue());
Chris Lattnerb1a15122011-07-15 06:08:15 +000049
50 if (In2->isNegative())
51 return Result->getValue().sgt(In1->getValue());
52 return Result->getValue().slt(In1->getValue());
Chris Lattner2188e402010-01-04 07:37:31 +000053}
54
Sanjay Patel5f0217f2016-06-05 16:46:18 +000055/// Compute Result = In1+In2, returning true if the result overflowed for this
56/// type.
Sanjay Pateld93c4c02016-09-15 18:22:25 +000057static bool addWithOverflow(Constant *&Result, Constant *In1,
Chris Lattner2188e402010-01-04 07:37:31 +000058 Constant *In2, bool IsSigned = false) {
59 Result = ConstantExpr::getAdd(In1, In2);
60
Chris Lattner229907c2011-07-18 04:54:35 +000061 if (VectorType *VTy = dyn_cast<VectorType>(In1->getType())) {
Chris Lattner2188e402010-01-04 07:37:31 +000062 for (unsigned i = 0, e = VTy->getNumElements(); i != e; ++i) {
63 Constant *Idx = ConstantInt::get(Type::getInt32Ty(In1->getContext()), i);
Sanjay Pateld93c4c02016-09-15 18:22:25 +000064 if (hasAddOverflow(extractElement(Result, Idx),
65 extractElement(In1, Idx),
66 extractElement(In2, Idx),
Chris Lattner2188e402010-01-04 07:37:31 +000067 IsSigned))
68 return true;
69 }
70 return false;
71 }
72
Sanjay Pateld93c4c02016-09-15 18:22:25 +000073 return hasAddOverflow(cast<ConstantInt>(Result),
Chris Lattner2188e402010-01-04 07:37:31 +000074 cast<ConstantInt>(In1), cast<ConstantInt>(In2),
75 IsSigned);
76}
77
Sanjay Pateld93c4c02016-09-15 18:22:25 +000078static bool hasSubOverflow(ConstantInt *Result,
Chris Lattner2188e402010-01-04 07:37:31 +000079 ConstantInt *In1, ConstantInt *In2,
80 bool IsSigned) {
Chris Lattnerb1a15122011-07-15 06:08:15 +000081 if (!IsSigned)
Chris Lattner2188e402010-01-04 07:37:31 +000082 return Result->getValue().ugt(In1->getValue());
Jim Grosbach129c52a2011-09-30 18:09:53 +000083
Chris Lattnerb1a15122011-07-15 06:08:15 +000084 if (In2->isNegative())
85 return Result->getValue().slt(In1->getValue());
86
87 return Result->getValue().sgt(In1->getValue());
Chris Lattner2188e402010-01-04 07:37:31 +000088}
89
Sanjay Patel5f0217f2016-06-05 16:46:18 +000090/// Compute Result = In1-In2, returning true if the result overflowed for this
91/// type.
Sanjay Pateld93c4c02016-09-15 18:22:25 +000092static bool subWithOverflow(Constant *&Result, Constant *In1,
Chris Lattner2188e402010-01-04 07:37:31 +000093 Constant *In2, bool IsSigned = false) {
94 Result = ConstantExpr::getSub(In1, In2);
95
Chris Lattner229907c2011-07-18 04:54:35 +000096 if (VectorType *VTy = dyn_cast<VectorType>(In1->getType())) {
Chris Lattner2188e402010-01-04 07:37:31 +000097 for (unsigned i = 0, e = VTy->getNumElements(); i != e; ++i) {
98 Constant *Idx = ConstantInt::get(Type::getInt32Ty(In1->getContext()), i);
Sanjay Pateld93c4c02016-09-15 18:22:25 +000099 if (hasSubOverflow(extractElement(Result, Idx),
100 extractElement(In1, Idx),
101 extractElement(In2, Idx),
Chris Lattner2188e402010-01-04 07:37:31 +0000102 IsSigned))
103 return true;
104 }
105 return false;
106 }
107
Sanjay Pateld93c4c02016-09-15 18:22:25 +0000108 return hasSubOverflow(cast<ConstantInt>(Result),
Chris Lattner2188e402010-01-04 07:37:31 +0000109 cast<ConstantInt>(In1), cast<ConstantInt>(In2),
110 IsSigned);
111}
112
Balaram Makam569eaec2016-05-04 21:32:14 +0000113/// Given an icmp instruction, return true if any use of this comparison is a
114/// branch on sign bit comparison.
115static bool isBranchOnSignBitCheck(ICmpInst &I, bool isSignBit) {
116 for (auto *U : I.users())
117 if (isa<BranchInst>(U))
118 return isSignBit;
119 return false;
120}
121
Sanjay Patel5f0217f2016-06-05 16:46:18 +0000122/// Given an exploded icmp instruction, return true if the comparison only
123/// checks the sign bit. If it only checks the sign bit, set TrueIfSigned if the
124/// result of the comparison is true when the input value is signed.
Sanjay Patel79263662016-08-21 15:07:45 +0000125static bool isSignBitCheck(ICmpInst::Predicate Pred, const APInt &RHS,
Chris Lattner2188e402010-01-04 07:37:31 +0000126 bool &TrueIfSigned) {
Sanjay Patel5f0217f2016-06-05 16:46:18 +0000127 switch (Pred) {
Chris Lattner2188e402010-01-04 07:37:31 +0000128 case ICmpInst::ICMP_SLT: // True if LHS s< 0
129 TrueIfSigned = true;
Sanjay Patel79263662016-08-21 15:07:45 +0000130 return RHS == 0;
Chris Lattner2188e402010-01-04 07:37:31 +0000131 case ICmpInst::ICMP_SLE: // True if LHS s<= RHS and RHS == -1
132 TrueIfSigned = true;
Sanjay Patel79263662016-08-21 15:07:45 +0000133 return RHS.isAllOnesValue();
Chris Lattner2188e402010-01-04 07:37:31 +0000134 case ICmpInst::ICMP_SGT: // True if LHS s> -1
135 TrueIfSigned = false;
Sanjay Patel79263662016-08-21 15:07:45 +0000136 return RHS.isAllOnesValue();
Chris Lattner2188e402010-01-04 07:37:31 +0000137 case ICmpInst::ICMP_UGT:
138 // True if LHS u> RHS and RHS == high-bit-mask - 1
139 TrueIfSigned = true;
Sanjay Patel79263662016-08-21 15:07:45 +0000140 return RHS.isMaxSignedValue();
Jim Grosbach129c52a2011-09-30 18:09:53 +0000141 case ICmpInst::ICMP_UGE:
Chris Lattner2188e402010-01-04 07:37:31 +0000142 // True if LHS u>= RHS and RHS == high-bit-mask (2^7, 2^15, 2^31, etc)
143 TrueIfSigned = true;
Craig Topperbcfd2d12017-04-20 16:56:25 +0000144 return RHS.isSignMask();
Chris Lattner2188e402010-01-04 07:37:31 +0000145 default:
146 return false;
147 }
148}
149
Arnaud A. de Grandmaison3ee88e82013-03-25 11:47:38 +0000150/// Returns true if the exploded icmp can be expressed as a signed comparison
151/// to zero and updates the predicate accordingly.
152/// The signedness of the comparison is preserved.
Sanjay Patel5b112842016-08-18 14:59:14 +0000153/// TODO: Refactor with decomposeBitTestICmp()?
154static bool isSignTest(ICmpInst::Predicate &Pred, const APInt &C) {
Sanjay Patel5f0217f2016-06-05 16:46:18 +0000155 if (!ICmpInst::isSigned(Pred))
Arnaud A. de Grandmaison9c383d62013-03-25 09:48:49 +0000156 return false;
157
Sanjay Patel5b112842016-08-18 14:59:14 +0000158 if (C == 0)
Sanjay Patel5f0217f2016-06-05 16:46:18 +0000159 return ICmpInst::isRelational(Pred);
Arnaud A. de Grandmaison9c383d62013-03-25 09:48:49 +0000160
Sanjay Patel5b112842016-08-18 14:59:14 +0000161 if (C == 1) {
Sanjay Patel5f0217f2016-06-05 16:46:18 +0000162 if (Pred == ICmpInst::ICMP_SLT) {
163 Pred = ICmpInst::ICMP_SLE;
Arnaud A. de Grandmaison9c383d62013-03-25 09:48:49 +0000164 return true;
Arnaud A. de Grandmaison9c383d62013-03-25 09:48:49 +0000165 }
Sanjay Patel5b112842016-08-18 14:59:14 +0000166 } else if (C.isAllOnesValue()) {
Sanjay Patel5f0217f2016-06-05 16:46:18 +0000167 if (Pred == ICmpInst::ICMP_SGT) {
168 Pred = ICmpInst::ICMP_SGE;
Arnaud A. de Grandmaison9c383d62013-03-25 09:48:49 +0000169 return true;
Arnaud A. de Grandmaison9c383d62013-03-25 09:48:49 +0000170 }
Arnaud A. de Grandmaison3ee88e82013-03-25 11:47:38 +0000171 }
Arnaud A. de Grandmaison9c383d62013-03-25 09:48:49 +0000172
173 return false;
174}
175
Sanjay Patel5f0217f2016-06-05 16:46:18 +0000176/// Given a signed integer type and a set of known zero and one bits, compute
177/// the maximum and minimum values that could have the specified known zero and
178/// known one bits, returning them in Min/Max.
Craig Topperb45eabc2017-04-26 16:39:58 +0000179/// TODO: Move to method on KnownBits struct?
180static void computeSignedMinMaxValuesFromKnownBits(const KnownBits &Known,
Sanjay Patel5f0217f2016-06-05 16:46:18 +0000181 APInt &Min, APInt &Max) {
Craig Topperb45eabc2017-04-26 16:39:58 +0000182 assert(Known.getBitWidth() == Min.getBitWidth() &&
183 Known.getBitWidth() == Max.getBitWidth() &&
Chris Lattner2188e402010-01-04 07:37:31 +0000184 "KnownZero, KnownOne and Min, Max must have equal bitwidth.");
Craig Topperb45eabc2017-04-26 16:39:58 +0000185 APInt UnknownBits = ~(Known.Zero|Known.One);
Chris Lattner2188e402010-01-04 07:37:31 +0000186
187 // The minimum value is when all unknown bits are zeros, EXCEPT for the sign
188 // bit if it is unknown.
Craig Topperb45eabc2017-04-26 16:39:58 +0000189 Min = Known.One;
190 Max = Known.One|UnknownBits;
Jim Grosbach129c52a2011-09-30 18:09:53 +0000191
Chris Lattner2188e402010-01-04 07:37:31 +0000192 if (UnknownBits.isNegative()) { // Sign bit is unknown
Craig Topper24db6b82017-04-28 16:58:05 +0000193 Min.setSignBit();
194 Max.clearSignBit();
Chris Lattner2188e402010-01-04 07:37:31 +0000195 }
196}
197
Sanjay Patel5f0217f2016-06-05 16:46:18 +0000198/// Given an unsigned integer type and a set of known zero and one bits, compute
199/// the maximum and minimum values that could have the specified known zero and
200/// known one bits, returning them in Min/Max.
Craig Topperb45eabc2017-04-26 16:39:58 +0000201/// TODO: Move to method on KnownBits struct?
202static void computeUnsignedMinMaxValuesFromKnownBits(const KnownBits &Known,
Chris Lattner2188e402010-01-04 07:37:31 +0000203 APInt &Min, APInt &Max) {
Craig Topperb45eabc2017-04-26 16:39:58 +0000204 assert(Known.getBitWidth() == Min.getBitWidth() &&
205 Known.getBitWidth() == Max.getBitWidth() &&
Chris Lattner2188e402010-01-04 07:37:31 +0000206 "Ty, KnownZero, KnownOne and Min, Max must have equal bitwidth.");
Craig Topperb45eabc2017-04-26 16:39:58 +0000207 APInt UnknownBits = ~(Known.Zero|Known.One);
Jim Grosbach129c52a2011-09-30 18:09:53 +0000208
Chris Lattner2188e402010-01-04 07:37:31 +0000209 // The minimum value is when the unknown bits are all zeros.
Craig Topperb45eabc2017-04-26 16:39:58 +0000210 Min = Known.One;
Chris Lattner2188e402010-01-04 07:37:31 +0000211 // The maximum value is when the unknown bits are all ones.
Craig Topperb45eabc2017-04-26 16:39:58 +0000212 Max = Known.One|UnknownBits;
Chris Lattner2188e402010-01-04 07:37:31 +0000213}
214
Sanjay Patel5f0217f2016-06-05 16:46:18 +0000215/// This is called when we see this pattern:
Chris Lattner2188e402010-01-04 07:37:31 +0000216/// cmp pred (load (gep GV, ...)), cmpcst
Sanjay Patel5f0217f2016-06-05 16:46:18 +0000217/// where GV is a global variable with a constant initializer. Try to simplify
218/// this into some simple computation that does not need the load. For example
Chris Lattner2188e402010-01-04 07:37:31 +0000219/// we can optimize "icmp eq (load (gep "foo", 0, i)), 0" into "icmp eq i, 3".
220///
221/// If AndCst is non-null, then the loaded value is masked with that constant
Sanjay Patel5f0217f2016-06-05 16:46:18 +0000222/// before doing the comparison. This handles cases like "A[i]&4 == 0".
Sanjay Patel43395062016-07-21 18:07:40 +0000223Instruction *InstCombiner::foldCmpLoadFromIndexedGlobal(GetElementPtrInst *GEP,
224 GlobalVariable *GV,
225 CmpInst &ICI,
226 ConstantInt *AndCst) {
Chris Lattnerfe741762012-01-31 02:55:06 +0000227 Constant *Init = GV->getInitializer();
228 if (!isa<ConstantArray>(Init) && !isa<ConstantDataArray>(Init))
Craig Topperf40110f2014-04-25 05:29:35 +0000229 return nullptr;
Jim Grosbachbdbd7342013-04-05 21:20:12 +0000230
Chris Lattnerfe741762012-01-31 02:55:06 +0000231 uint64_t ArrayElementCount = Init->getType()->getArrayNumElements();
Davide Italiano2133bf52017-02-07 17:56:50 +0000232 // Don't blow up on huge arrays.
233 if (ArrayElementCount > MaxArraySizeForCombine)
234 return nullptr;
Jim Grosbach129c52a2011-09-30 18:09:53 +0000235
Chris Lattner2188e402010-01-04 07:37:31 +0000236 // There are many forms of this optimization we can handle, for now, just do
237 // the simple index into a single-dimensional array.
238 //
239 // Require: GEP GV, 0, i {{, constant indices}}
240 if (GEP->getNumOperands() < 3 ||
241 !isa<ConstantInt>(GEP->getOperand(1)) ||
242 !cast<ConstantInt>(GEP->getOperand(1))->isZero() ||
243 isa<Constant>(GEP->getOperand(2)))
Craig Topperf40110f2014-04-25 05:29:35 +0000244 return nullptr;
Chris Lattner2188e402010-01-04 07:37:31 +0000245
246 // Check that indices after the variable are constants and in-range for the
247 // type they index. Collect the indices. This is typically for arrays of
248 // structs.
249 SmallVector<unsigned, 4> LaterIndices;
Jim Grosbach129c52a2011-09-30 18:09:53 +0000250
Chris Lattnerfe741762012-01-31 02:55:06 +0000251 Type *EltTy = Init->getType()->getArrayElementType();
Chris Lattner2188e402010-01-04 07:37:31 +0000252 for (unsigned i = 3, e = GEP->getNumOperands(); i != e; ++i) {
253 ConstantInt *Idx = dyn_cast<ConstantInt>(GEP->getOperand(i));
Craig Topperf40110f2014-04-25 05:29:35 +0000254 if (!Idx) return nullptr; // Variable index.
Jim Grosbach129c52a2011-09-30 18:09:53 +0000255
Chris Lattner2188e402010-01-04 07:37:31 +0000256 uint64_t IdxVal = Idx->getZExtValue();
Craig Topperf40110f2014-04-25 05:29:35 +0000257 if ((unsigned)IdxVal != IdxVal) return nullptr; // Too large array index.
Jim Grosbach129c52a2011-09-30 18:09:53 +0000258
Chris Lattner229907c2011-07-18 04:54:35 +0000259 if (StructType *STy = dyn_cast<StructType>(EltTy))
Chris Lattner2188e402010-01-04 07:37:31 +0000260 EltTy = STy->getElementType(IdxVal);
Chris Lattner229907c2011-07-18 04:54:35 +0000261 else if (ArrayType *ATy = dyn_cast<ArrayType>(EltTy)) {
Craig Topperf40110f2014-04-25 05:29:35 +0000262 if (IdxVal >= ATy->getNumElements()) return nullptr;
Chris Lattner2188e402010-01-04 07:37:31 +0000263 EltTy = ATy->getElementType();
264 } else {
Craig Topperf40110f2014-04-25 05:29:35 +0000265 return nullptr; // Unknown type.
Chris Lattner2188e402010-01-04 07:37:31 +0000266 }
Jim Grosbach129c52a2011-09-30 18:09:53 +0000267
Chris Lattner2188e402010-01-04 07:37:31 +0000268 LaterIndices.push_back(IdxVal);
269 }
Jim Grosbach129c52a2011-09-30 18:09:53 +0000270
Chris Lattner2188e402010-01-04 07:37:31 +0000271 enum { Overdefined = -3, Undefined = -2 };
272
273 // Variables for our state machines.
Jim Grosbach129c52a2011-09-30 18:09:53 +0000274
Chris Lattner2188e402010-01-04 07:37:31 +0000275 // FirstTrueElement/SecondTrueElement - Used to emit a comparison of the form
276 // "i == 47 | i == 87", where 47 is the first index the condition is true for,
277 // and 87 is the second (and last) index. FirstTrueElement is -2 when
278 // undefined, otherwise set to the first true element. SecondTrueElement is
279 // -2 when undefined, -3 when overdefined and >= 0 when that index is true.
280 int FirstTrueElement = Undefined, SecondTrueElement = Undefined;
281
282 // FirstFalseElement/SecondFalseElement - Used to emit a comparison of the
283 // form "i != 47 & i != 87". Same state transitions as for true elements.
284 int FirstFalseElement = Undefined, SecondFalseElement = Undefined;
Jim Grosbach129c52a2011-09-30 18:09:53 +0000285
Chris Lattner2188e402010-01-04 07:37:31 +0000286 /// TrueRangeEnd/FalseRangeEnd - In conjunction with First*Element, these
287 /// define a state machine that triggers for ranges of values that the index
288 /// is true or false for. This triggers on things like "abbbbc"[i] == 'b'.
289 /// This is -2 when undefined, -3 when overdefined, and otherwise the last
290 /// index in the range (inclusive). We use -2 for undefined here because we
291 /// use relative comparisons and don't want 0-1 to match -1.
292 int TrueRangeEnd = Undefined, FalseRangeEnd = Undefined;
Jim Grosbach129c52a2011-09-30 18:09:53 +0000293
Chris Lattner2188e402010-01-04 07:37:31 +0000294 // MagicBitvector - This is a magic bitvector where we set a bit if the
295 // comparison is true for element 'i'. If there are 64 elements or less in
296 // the array, this will fully represent all the comparison results.
297 uint64_t MagicBitvector = 0;
Jim Grosbach129c52a2011-09-30 18:09:53 +0000298
Chris Lattner2188e402010-01-04 07:37:31 +0000299 // Scan the array and see if one of our patterns matches.
300 Constant *CompareRHS = cast<Constant>(ICI.getOperand(1));
Chris Lattnerfe741762012-01-31 02:55:06 +0000301 for (unsigned i = 0, e = ArrayElementCount; i != e; ++i) {
302 Constant *Elt = Init->getAggregateElement(i);
Craig Topperf40110f2014-04-25 05:29:35 +0000303 if (!Elt) return nullptr;
Jim Grosbach129c52a2011-09-30 18:09:53 +0000304
Chris Lattner2188e402010-01-04 07:37:31 +0000305 // If this is indexing an array of structures, get the structure element.
306 if (!LaterIndices.empty())
Jay Foad57aa6362011-07-13 10:26:04 +0000307 Elt = ConstantExpr::getExtractValue(Elt, LaterIndices);
Jim Grosbach129c52a2011-09-30 18:09:53 +0000308
Chris Lattner2188e402010-01-04 07:37:31 +0000309 // If the element is masked, handle it.
310 if (AndCst) Elt = ConstantExpr::getAnd(Elt, AndCst);
Jim Grosbach129c52a2011-09-30 18:09:53 +0000311
Chris Lattner2188e402010-01-04 07:37:31 +0000312 // Find out if the comparison would be true or false for the i'th element.
313 Constant *C = ConstantFoldCompareInstOperands(ICI.getPredicate(), Elt,
Justin Bogner99798402016-08-05 01:06:44 +0000314 CompareRHS, DL, &TLI);
Chris Lattner2188e402010-01-04 07:37:31 +0000315 // If the result is undef for this element, ignore it.
316 if (isa<UndefValue>(C)) {
317 // Extend range state machines to cover this element in case there is an
318 // undef in the middle of the range.
319 if (TrueRangeEnd == (int)i-1)
320 TrueRangeEnd = i;
321 if (FalseRangeEnd == (int)i-1)
322 FalseRangeEnd = i;
323 continue;
324 }
Jim Grosbach129c52a2011-09-30 18:09:53 +0000325
Chris Lattner2188e402010-01-04 07:37:31 +0000326 // If we can't compute the result for any of the elements, we have to give
327 // up evaluating the entire conditional.
Craig Topperf40110f2014-04-25 05:29:35 +0000328 if (!isa<ConstantInt>(C)) return nullptr;
Jim Grosbach129c52a2011-09-30 18:09:53 +0000329
Chris Lattner2188e402010-01-04 07:37:31 +0000330 // Otherwise, we know if the comparison is true or false for this element,
331 // update our state machines.
332 bool IsTrueForElt = !cast<ConstantInt>(C)->isZero();
Jim Grosbach129c52a2011-09-30 18:09:53 +0000333
Chris Lattner2188e402010-01-04 07:37:31 +0000334 // State machine for single/double/range index comparison.
335 if (IsTrueForElt) {
336 // Update the TrueElement state machine.
337 if (FirstTrueElement == Undefined)
338 FirstTrueElement = TrueRangeEnd = i; // First true element.
339 else {
340 // Update double-compare state machine.
341 if (SecondTrueElement == Undefined)
342 SecondTrueElement = i;
343 else
344 SecondTrueElement = Overdefined;
Jim Grosbach129c52a2011-09-30 18:09:53 +0000345
Chris Lattner2188e402010-01-04 07:37:31 +0000346 // Update range state machine.
347 if (TrueRangeEnd == (int)i-1)
348 TrueRangeEnd = i;
349 else
350 TrueRangeEnd = Overdefined;
351 }
352 } else {
353 // Update the FalseElement state machine.
354 if (FirstFalseElement == Undefined)
355 FirstFalseElement = FalseRangeEnd = i; // First false element.
356 else {
357 // Update double-compare state machine.
358 if (SecondFalseElement == Undefined)
359 SecondFalseElement = i;
360 else
361 SecondFalseElement = Overdefined;
Jim Grosbach129c52a2011-09-30 18:09:53 +0000362
Chris Lattner2188e402010-01-04 07:37:31 +0000363 // Update range state machine.
364 if (FalseRangeEnd == (int)i-1)
365 FalseRangeEnd = i;
366 else
367 FalseRangeEnd = Overdefined;
368 }
369 }
Jim Grosbach129c52a2011-09-30 18:09:53 +0000370
Chris Lattner2188e402010-01-04 07:37:31 +0000371 // If this element is in range, update our magic bitvector.
372 if (i < 64 && IsTrueForElt)
373 MagicBitvector |= 1ULL << i;
Jim Grosbach129c52a2011-09-30 18:09:53 +0000374
Chris Lattner2188e402010-01-04 07:37:31 +0000375 // If all of our states become overdefined, bail out early. Since the
376 // predicate is expensive, only check it every 8 elements. This is only
377 // really useful for really huge arrays.
378 if ((i & 8) == 0 && i >= 64 && SecondTrueElement == Overdefined &&
379 SecondFalseElement == Overdefined && TrueRangeEnd == Overdefined &&
380 FalseRangeEnd == Overdefined)
Craig Topperf40110f2014-04-25 05:29:35 +0000381 return nullptr;
Chris Lattner2188e402010-01-04 07:37:31 +0000382 }
383
384 // Now that we've scanned the entire array, emit our new comparison(s). We
385 // order the state machines in complexity of the generated code.
386 Value *Idx = GEP->getOperand(2);
387
Matt Arsenault5aeae182013-08-19 21:40:31 +0000388 // If the index is larger than the pointer size of the target, truncate the
389 // index down like the GEP would do implicitly. We don't have to do this for
390 // an inbounds GEP because the index can't be out of range.
Matt Arsenault84680622013-09-30 21:11:01 +0000391 if (!GEP->isInBounds()) {
Mehdi Aminia28d91d2015-03-10 02:37:25 +0000392 Type *IntPtrTy = DL.getIntPtrType(GEP->getType());
Matt Arsenault84680622013-09-30 21:11:01 +0000393 unsigned PtrSize = IntPtrTy->getIntegerBitWidth();
394 if (Idx->getType()->getPrimitiveSizeInBits() > PtrSize)
395 Idx = Builder->CreateTrunc(Idx, IntPtrTy);
396 }
Matt Arsenault5aeae182013-08-19 21:40:31 +0000397
Chris Lattner2188e402010-01-04 07:37:31 +0000398 // If the comparison is only true for one or two elements, emit direct
399 // comparisons.
400 if (SecondTrueElement != Overdefined) {
401 // None true -> false.
402 if (FirstTrueElement == Undefined)
Sanjay Patel4b198802016-02-01 22:23:39 +0000403 return replaceInstUsesWith(ICI, Builder->getFalse());
Jim Grosbach129c52a2011-09-30 18:09:53 +0000404
Chris Lattner2188e402010-01-04 07:37:31 +0000405 Value *FirstTrueIdx = ConstantInt::get(Idx->getType(), FirstTrueElement);
Jim Grosbach129c52a2011-09-30 18:09:53 +0000406
Chris Lattner2188e402010-01-04 07:37:31 +0000407 // True for one element -> 'i == 47'.
408 if (SecondTrueElement == Undefined)
409 return new ICmpInst(ICmpInst::ICMP_EQ, Idx, FirstTrueIdx);
Jim Grosbach129c52a2011-09-30 18:09:53 +0000410
Chris Lattner2188e402010-01-04 07:37:31 +0000411 // True for two elements -> 'i == 47 | i == 72'.
412 Value *C1 = Builder->CreateICmpEQ(Idx, FirstTrueIdx);
413 Value *SecondTrueIdx = ConstantInt::get(Idx->getType(), SecondTrueElement);
414 Value *C2 = Builder->CreateICmpEQ(Idx, SecondTrueIdx);
415 return BinaryOperator::CreateOr(C1, C2);
416 }
417
418 // If the comparison is only false for one or two elements, emit direct
419 // comparisons.
420 if (SecondFalseElement != Overdefined) {
421 // None false -> true.
422 if (FirstFalseElement == Undefined)
Sanjay Patel4b198802016-02-01 22:23:39 +0000423 return replaceInstUsesWith(ICI, Builder->getTrue());
Jim Grosbach129c52a2011-09-30 18:09:53 +0000424
Chris Lattner2188e402010-01-04 07:37:31 +0000425 Value *FirstFalseIdx = ConstantInt::get(Idx->getType(), FirstFalseElement);
426
427 // False for one element -> 'i != 47'.
428 if (SecondFalseElement == Undefined)
429 return new ICmpInst(ICmpInst::ICMP_NE, Idx, FirstFalseIdx);
Jim Grosbach129c52a2011-09-30 18:09:53 +0000430
Chris Lattner2188e402010-01-04 07:37:31 +0000431 // False for two elements -> 'i != 47 & i != 72'.
432 Value *C1 = Builder->CreateICmpNE(Idx, FirstFalseIdx);
433 Value *SecondFalseIdx = ConstantInt::get(Idx->getType(),SecondFalseElement);
434 Value *C2 = Builder->CreateICmpNE(Idx, SecondFalseIdx);
435 return BinaryOperator::CreateAnd(C1, C2);
436 }
Jim Grosbach129c52a2011-09-30 18:09:53 +0000437
Chris Lattner2188e402010-01-04 07:37:31 +0000438 // If the comparison can be replaced with a range comparison for the elements
439 // where it is true, emit the range check.
440 if (TrueRangeEnd != Overdefined) {
441 assert(TrueRangeEnd != FirstTrueElement && "Should emit single compare");
Jim Grosbach129c52a2011-09-30 18:09:53 +0000442
Chris Lattner2188e402010-01-04 07:37:31 +0000443 // Generate (i-FirstTrue) <u (TrueRangeEnd-FirstTrue+1).
444 if (FirstTrueElement) {
445 Value *Offs = ConstantInt::get(Idx->getType(), -FirstTrueElement);
446 Idx = Builder->CreateAdd(Idx, Offs);
447 }
Jim Grosbach129c52a2011-09-30 18:09:53 +0000448
Chris Lattner2188e402010-01-04 07:37:31 +0000449 Value *End = ConstantInt::get(Idx->getType(),
450 TrueRangeEnd-FirstTrueElement+1);
451 return new ICmpInst(ICmpInst::ICMP_ULT, Idx, End);
452 }
Jim Grosbach129c52a2011-09-30 18:09:53 +0000453
Chris Lattner2188e402010-01-04 07:37:31 +0000454 // False range check.
455 if (FalseRangeEnd != Overdefined) {
456 assert(FalseRangeEnd != FirstFalseElement && "Should emit single compare");
457 // Generate (i-FirstFalse) >u (FalseRangeEnd-FirstFalse).
458 if (FirstFalseElement) {
459 Value *Offs = ConstantInt::get(Idx->getType(), -FirstFalseElement);
460 Idx = Builder->CreateAdd(Idx, Offs);
461 }
Jim Grosbach129c52a2011-09-30 18:09:53 +0000462
Chris Lattner2188e402010-01-04 07:37:31 +0000463 Value *End = ConstantInt::get(Idx->getType(),
464 FalseRangeEnd-FirstFalseElement);
465 return new ICmpInst(ICmpInst::ICMP_UGT, Idx, End);
466 }
Jim Grosbach129c52a2011-09-30 18:09:53 +0000467
Arnaud A. de Grandmaisonf364bc62013-03-22 08:25:01 +0000468 // If a magic bitvector captures the entire comparison state
Chris Lattner2188e402010-01-04 07:37:31 +0000469 // of this load, replace it with computation that does:
470 // ((magic_cst >> i) & 1) != 0
Arnaud A. de Grandmaisonf364bc62013-03-22 08:25:01 +0000471 {
Craig Topperf40110f2014-04-25 05:29:35 +0000472 Type *Ty = nullptr;
Arnaud A. de Grandmaisonf364bc62013-03-22 08:25:01 +0000473
474 // Look for an appropriate type:
475 // - The type of Idx if the magic fits
476 // - The smallest fitting legal type if we have a DataLayout
477 // - Default to i32
478 if (ArrayElementCount <= Idx->getType()->getIntegerBitWidth())
479 Ty = Idx->getType();
Mehdi Aminia28d91d2015-03-10 02:37:25 +0000480 else
481 Ty = DL.getSmallestLegalIntType(Init->getContext(), ArrayElementCount);
Arnaud A. de Grandmaisonf364bc62013-03-22 08:25:01 +0000482
Craig Topperf40110f2014-04-25 05:29:35 +0000483 if (Ty) {
Arnaud A. de Grandmaisonf364bc62013-03-22 08:25:01 +0000484 Value *V = Builder->CreateIntCast(Idx, Ty, false);
485 V = Builder->CreateLShr(ConstantInt::get(Ty, MagicBitvector), V);
486 V = Builder->CreateAnd(ConstantInt::get(Ty, 1), V);
487 return new ICmpInst(ICmpInst::ICMP_NE, V, ConstantInt::get(Ty, 0));
488 }
Chris Lattner2188e402010-01-04 07:37:31 +0000489 }
Jim Grosbach129c52a2011-09-30 18:09:53 +0000490
Craig Topperf40110f2014-04-25 05:29:35 +0000491 return nullptr;
Chris Lattner2188e402010-01-04 07:37:31 +0000492}
493
Sanjay Patel5f0217f2016-06-05 16:46:18 +0000494/// Return a value that can be used to compare the *offset* implied by a GEP to
495/// zero. For example, if we have &A[i], we want to return 'i' for
496/// "icmp ne i, 0". Note that, in general, indices can be complex, and scales
497/// are involved. The above expression would also be legal to codegen as
498/// "icmp ne (i*4), 0" (assuming A is a pointer to i32).
499/// This latter form is less amenable to optimization though, and we are allowed
Chris Lattner2188e402010-01-04 07:37:31 +0000500/// to generate the first by knowing that pointer arithmetic doesn't overflow.
501///
502/// If we can't emit an optimized form for this expression, this returns null.
Jim Grosbach129c52a2011-09-30 18:09:53 +0000503///
Sanjay Pateld93c4c02016-09-15 18:22:25 +0000504static Value *evaluateGEPOffsetExpression(User *GEP, InstCombiner &IC,
Mehdi Aminia28d91d2015-03-10 02:37:25 +0000505 const DataLayout &DL) {
Chris Lattner2188e402010-01-04 07:37:31 +0000506 gep_type_iterator GTI = gep_type_begin(GEP);
Jim Grosbach129c52a2011-09-30 18:09:53 +0000507
Chris Lattner2188e402010-01-04 07:37:31 +0000508 // Check to see if this gep only has a single variable index. If so, and if
509 // any constant indices are a multiple of its scale, then we can compute this
510 // in terms of the scale of the variable index. For example, if the GEP
511 // implies an offset of "12 + i*4", then we can codegen this as "3 + i",
512 // because the expression will cross zero at the same point.
513 unsigned i, e = GEP->getNumOperands();
514 int64_t Offset = 0;
515 for (i = 1; i != e; ++i, ++GTI) {
516 if (ConstantInt *CI = dyn_cast<ConstantInt>(GEP->getOperand(i))) {
517 // Compute the aggregate offset of constant indices.
518 if (CI->isZero()) continue;
Jim Grosbach129c52a2011-09-30 18:09:53 +0000519
Chris Lattner2188e402010-01-04 07:37:31 +0000520 // Handle a struct index, which adds its field offset to the pointer.
Peter Collingbourneab85225b2016-12-02 02:24:42 +0000521 if (StructType *STy = GTI.getStructTypeOrNull()) {
Rafael Espindola37dc9e12014-02-21 00:06:31 +0000522 Offset += DL.getStructLayout(STy)->getElementOffset(CI->getZExtValue());
Chris Lattner2188e402010-01-04 07:37:31 +0000523 } else {
Rafael Espindola37dc9e12014-02-21 00:06:31 +0000524 uint64_t Size = DL.getTypeAllocSize(GTI.getIndexedType());
Chris Lattner2188e402010-01-04 07:37:31 +0000525 Offset += Size*CI->getSExtValue();
526 }
527 } else {
528 // Found our variable index.
529 break;
530 }
531 }
Jim Grosbach129c52a2011-09-30 18:09:53 +0000532
Chris Lattner2188e402010-01-04 07:37:31 +0000533 // If there are no variable indices, we must have a constant offset, just
534 // evaluate it the general way.
Craig Topperf40110f2014-04-25 05:29:35 +0000535 if (i == e) return nullptr;
Jim Grosbach129c52a2011-09-30 18:09:53 +0000536
Chris Lattner2188e402010-01-04 07:37:31 +0000537 Value *VariableIdx = GEP->getOperand(i);
538 // Determine the scale factor of the variable element. For example, this is
539 // 4 if the variable index is into an array of i32.
Rafael Espindola37dc9e12014-02-21 00:06:31 +0000540 uint64_t VariableScale = DL.getTypeAllocSize(GTI.getIndexedType());
Jim Grosbach129c52a2011-09-30 18:09:53 +0000541
Chris Lattner2188e402010-01-04 07:37:31 +0000542 // Verify that there are no other variable indices. If so, emit the hard way.
543 for (++i, ++GTI; i != e; ++i, ++GTI) {
544 ConstantInt *CI = dyn_cast<ConstantInt>(GEP->getOperand(i));
Craig Topperf40110f2014-04-25 05:29:35 +0000545 if (!CI) return nullptr;
Jim Grosbach129c52a2011-09-30 18:09:53 +0000546
Chris Lattner2188e402010-01-04 07:37:31 +0000547 // Compute the aggregate offset of constant indices.
548 if (CI->isZero()) continue;
Jim Grosbach129c52a2011-09-30 18:09:53 +0000549
Chris Lattner2188e402010-01-04 07:37:31 +0000550 // Handle a struct index, which adds its field offset to the pointer.
Peter Collingbourneab85225b2016-12-02 02:24:42 +0000551 if (StructType *STy = GTI.getStructTypeOrNull()) {
Rafael Espindola37dc9e12014-02-21 00:06:31 +0000552 Offset += DL.getStructLayout(STy)->getElementOffset(CI->getZExtValue());
Chris Lattner2188e402010-01-04 07:37:31 +0000553 } else {
Rafael Espindola37dc9e12014-02-21 00:06:31 +0000554 uint64_t Size = DL.getTypeAllocSize(GTI.getIndexedType());
Chris Lattner2188e402010-01-04 07:37:31 +0000555 Offset += Size*CI->getSExtValue();
556 }
557 }
Jim Grosbach129c52a2011-09-30 18:09:53 +0000558
Chris Lattner2188e402010-01-04 07:37:31 +0000559 // Okay, we know we have a single variable index, which must be a
560 // pointer/array/vector index. If there is no offset, life is simple, return
561 // the index.
Rafael Espindola37dc9e12014-02-21 00:06:31 +0000562 Type *IntPtrTy = DL.getIntPtrType(GEP->getOperand(0)->getType());
Matt Arsenault745101d2013-08-21 19:53:10 +0000563 unsigned IntPtrWidth = IntPtrTy->getIntegerBitWidth();
Chris Lattner2188e402010-01-04 07:37:31 +0000564 if (Offset == 0) {
565 // Cast to intptrty in case a truncation occurs. If an extension is needed,
566 // we don't need to bother extending: the extension won't affect where the
567 // computation crosses zero.
Eli Friedman1754a252011-05-18 23:11:30 +0000568 if (VariableIdx->getType()->getPrimitiveSizeInBits() > IntPtrWidth) {
Eli Friedman1754a252011-05-18 23:11:30 +0000569 VariableIdx = IC.Builder->CreateTrunc(VariableIdx, IntPtrTy);
570 }
Chris Lattner2188e402010-01-04 07:37:31 +0000571 return VariableIdx;
572 }
Jim Grosbach129c52a2011-09-30 18:09:53 +0000573
Chris Lattner2188e402010-01-04 07:37:31 +0000574 // Otherwise, there is an index. The computation we will do will be modulo
575 // the pointer size, so get it.
576 uint64_t PtrSizeMask = ~0ULL >> (64-IntPtrWidth);
Jim Grosbach129c52a2011-09-30 18:09:53 +0000577
Chris Lattner2188e402010-01-04 07:37:31 +0000578 Offset &= PtrSizeMask;
579 VariableScale &= PtrSizeMask;
Jim Grosbach129c52a2011-09-30 18:09:53 +0000580
Chris Lattner2188e402010-01-04 07:37:31 +0000581 // To do this transformation, any constant index must be a multiple of the
582 // variable scale factor. For example, we can evaluate "12 + 4*i" as "3 + i",
583 // but we can't evaluate "10 + 3*i" in terms of i. Check that the offset is a
584 // multiple of the variable scale.
585 int64_t NewOffs = Offset / (int64_t)VariableScale;
586 if (Offset != NewOffs*(int64_t)VariableScale)
Craig Topperf40110f2014-04-25 05:29:35 +0000587 return nullptr;
Jim Grosbach129c52a2011-09-30 18:09:53 +0000588
Chris Lattner2188e402010-01-04 07:37:31 +0000589 // Okay, we can do this evaluation. Start by converting the index to intptr.
Chris Lattner2188e402010-01-04 07:37:31 +0000590 if (VariableIdx->getType() != IntPtrTy)
Eli Friedman1754a252011-05-18 23:11:30 +0000591 VariableIdx = IC.Builder->CreateIntCast(VariableIdx, IntPtrTy,
592 true /*Signed*/);
Chris Lattner2188e402010-01-04 07:37:31 +0000593 Constant *OffsetVal = ConstantInt::get(IntPtrTy, NewOffs);
Eli Friedman1754a252011-05-18 23:11:30 +0000594 return IC.Builder->CreateAdd(VariableIdx, OffsetVal, "offset");
Chris Lattner2188e402010-01-04 07:37:31 +0000595}
596
Silviu Barangaf29dfd32016-01-15 15:52:05 +0000597/// Returns true if we can rewrite Start as a GEP with pointer Base
598/// and some integer offset. The nodes that need to be re-written
599/// for this transformation will be added to Explored.
600static bool canRewriteGEPAsOffset(Value *Start, Value *Base,
601 const DataLayout &DL,
602 SetVector<Value *> &Explored) {
603 SmallVector<Value *, 16> WorkList(1, Start);
604 Explored.insert(Base);
605
606 // The following traversal gives us an order which can be used
607 // when doing the final transformation. Since in the final
608 // transformation we create the PHI replacement instructions first,
609 // we don't have to get them in any particular order.
610 //
611 // However, for other instructions we will have to traverse the
612 // operands of an instruction first, which means that we have to
613 // do a post-order traversal.
614 while (!WorkList.empty()) {
615 SetVector<PHINode *> PHIs;
616
617 while (!WorkList.empty()) {
618 if (Explored.size() >= 100)
619 return false;
620
621 Value *V = WorkList.back();
622
623 if (Explored.count(V) != 0) {
624 WorkList.pop_back();
625 continue;
626 }
627
628 if (!isa<IntToPtrInst>(V) && !isa<PtrToIntInst>(V) &&
David Majnemer8b16da82016-09-15 20:10:09 +0000629 !isa<GetElementPtrInst>(V) && !isa<PHINode>(V))
Silviu Barangaf29dfd32016-01-15 15:52:05 +0000630 // We've found some value that we can't explore which is different from
631 // the base. Therefore we can't do this transformation.
632 return false;
633
634 if (isa<IntToPtrInst>(V) || isa<PtrToIntInst>(V)) {
635 auto *CI = dyn_cast<CastInst>(V);
636 if (!CI->isNoopCast(DL))
637 return false;
638
639 if (Explored.count(CI->getOperand(0)) == 0)
640 WorkList.push_back(CI->getOperand(0));
641 }
642
643 if (auto *GEP = dyn_cast<GEPOperator>(V)) {
644 // We're limiting the GEP to having one index. This will preserve
645 // the original pointer type. We could handle more cases in the
646 // future.
647 if (GEP->getNumIndices() != 1 || !GEP->isInBounds() ||
648 GEP->getType() != Start->getType())
649 return false;
650
651 if (Explored.count(GEP->getOperand(0)) == 0)
652 WorkList.push_back(GEP->getOperand(0));
653 }
654
655 if (WorkList.back() == V) {
656 WorkList.pop_back();
657 // We've finished visiting this node, mark it as such.
658 Explored.insert(V);
659 }
660
661 if (auto *PN = dyn_cast<PHINode>(V)) {
David Majnemercdf28732016-03-19 04:39:52 +0000662 // We cannot transform PHIs on unsplittable basic blocks.
663 if (isa<CatchSwitchInst>(PN->getParent()->getTerminator()))
664 return false;
Silviu Barangaf29dfd32016-01-15 15:52:05 +0000665 Explored.insert(PN);
666 PHIs.insert(PN);
667 }
668 }
669
670 // Explore the PHI nodes further.
671 for (auto *PN : PHIs)
672 for (Value *Op : PN->incoming_values())
673 if (Explored.count(Op) == 0)
674 WorkList.push_back(Op);
675 }
676
677 // Make sure that we can do this. Since we can't insert GEPs in a basic
678 // block before a PHI node, we can't easily do this transformation if
679 // we have PHI node users of transformed instructions.
680 for (Value *Val : Explored) {
681 for (Value *Use : Val->uses()) {
682
683 auto *PHI = dyn_cast<PHINode>(Use);
684 auto *Inst = dyn_cast<Instruction>(Val);
685
686 if (Inst == Base || Inst == PHI || !Inst || !PHI ||
687 Explored.count(PHI) == 0)
688 continue;
689
690 if (PHI->getParent() == Inst->getParent())
691 return false;
692 }
693 }
694 return true;
695}
696
697// Sets the appropriate insert point on Builder where we can add
698// a replacement Instruction for V (if that is possible).
699static void setInsertionPoint(IRBuilder<> &Builder, Value *V,
700 bool Before = true) {
701 if (auto *PHI = dyn_cast<PHINode>(V)) {
702 Builder.SetInsertPoint(&*PHI->getParent()->getFirstInsertionPt());
703 return;
704 }
705 if (auto *I = dyn_cast<Instruction>(V)) {
706 if (!Before)
707 I = &*std::next(I->getIterator());
708 Builder.SetInsertPoint(I);
709 return;
710 }
711 if (auto *A = dyn_cast<Argument>(V)) {
712 // Set the insertion point in the entry block.
713 BasicBlock &Entry = A->getParent()->getEntryBlock();
714 Builder.SetInsertPoint(&*Entry.getFirstInsertionPt());
715 return;
716 }
717 // Otherwise, this is a constant and we don't need to set a new
718 // insertion point.
719 assert(isa<Constant>(V) && "Setting insertion point for unknown value!");
720}
721
722/// Returns a re-written value of Start as an indexed GEP using Base as a
723/// pointer.
724static Value *rewriteGEPAsOffset(Value *Start, Value *Base,
725 const DataLayout &DL,
726 SetVector<Value *> &Explored) {
727 // Perform all the substitutions. This is a bit tricky because we can
728 // have cycles in our use-def chains.
729 // 1. Create the PHI nodes without any incoming values.
730 // 2. Create all the other values.
731 // 3. Add the edges for the PHI nodes.
732 // 4. Emit GEPs to get the original pointers.
733 // 5. Remove the original instructions.
734 Type *IndexType = IntegerType::get(
735 Base->getContext(), DL.getPointerTypeSizeInBits(Start->getType()));
736
737 DenseMap<Value *, Value *> NewInsts;
738 NewInsts[Base] = ConstantInt::getNullValue(IndexType);
739
740 // Create the new PHI nodes, without adding any incoming values.
741 for (Value *Val : Explored) {
742 if (Val == Base)
743 continue;
744 // Create empty phi nodes. This avoids cyclic dependencies when creating
745 // the remaining instructions.
746 if (auto *PHI = dyn_cast<PHINode>(Val))
747 NewInsts[PHI] = PHINode::Create(IndexType, PHI->getNumIncomingValues(),
748 PHI->getName() + ".idx", PHI);
749 }
750 IRBuilder<> Builder(Base->getContext());
751
752 // Create all the other instructions.
753 for (Value *Val : Explored) {
754
755 if (NewInsts.find(Val) != NewInsts.end())
756 continue;
757
758 if (auto *CI = dyn_cast<CastInst>(Val)) {
759 NewInsts[CI] = NewInsts[CI->getOperand(0)];
760 continue;
761 }
762 if (auto *GEP = dyn_cast<GEPOperator>(Val)) {
763 Value *Index = NewInsts[GEP->getOperand(1)] ? NewInsts[GEP->getOperand(1)]
764 : GEP->getOperand(1);
765 setInsertionPoint(Builder, GEP);
766 // Indices might need to be sign extended. GEPs will magically do
767 // this, but we need to do it ourselves here.
768 if (Index->getType()->getScalarSizeInBits() !=
769 NewInsts[GEP->getOperand(0)]->getType()->getScalarSizeInBits()) {
770 Index = Builder.CreateSExtOrTrunc(
771 Index, NewInsts[GEP->getOperand(0)]->getType(),
772 GEP->getOperand(0)->getName() + ".sext");
773 }
774
775 auto *Op = NewInsts[GEP->getOperand(0)];
776 if (isa<ConstantInt>(Op) && dyn_cast<ConstantInt>(Op)->isZero())
777 NewInsts[GEP] = Index;
778 else
779 NewInsts[GEP] = Builder.CreateNSWAdd(
780 Op, Index, GEP->getOperand(0)->getName() + ".add");
781 continue;
782 }
783 if (isa<PHINode>(Val))
784 continue;
785
786 llvm_unreachable("Unexpected instruction type");
787 }
788
789 // Add the incoming values to the PHI nodes.
790 for (Value *Val : Explored) {
791 if (Val == Base)
792 continue;
793 // All the instructions have been created, we can now add edges to the
794 // phi nodes.
795 if (auto *PHI = dyn_cast<PHINode>(Val)) {
796 PHINode *NewPhi = static_cast<PHINode *>(NewInsts[PHI]);
797 for (unsigned I = 0, E = PHI->getNumIncomingValues(); I < E; ++I) {
798 Value *NewIncoming = PHI->getIncomingValue(I);
799
800 if (NewInsts.find(NewIncoming) != NewInsts.end())
801 NewIncoming = NewInsts[NewIncoming];
802
803 NewPhi->addIncoming(NewIncoming, PHI->getIncomingBlock(I));
804 }
805 }
806 }
807
808 for (Value *Val : Explored) {
809 if (Val == Base)
810 continue;
811
812 // Depending on the type, for external users we have to emit
813 // a GEP or a GEP + ptrtoint.
814 setInsertionPoint(Builder, Val, false);
815
816 // If required, create an inttoptr instruction for Base.
817 Value *NewBase = Base;
818 if (!Base->getType()->isPointerTy())
819 NewBase = Builder.CreateBitOrPointerCast(Base, Start->getType(),
820 Start->getName() + "to.ptr");
821
822 Value *GEP = Builder.CreateInBoundsGEP(
823 Start->getType()->getPointerElementType(), NewBase,
824 makeArrayRef(NewInsts[Val]), Val->getName() + ".ptr");
825
826 if (!Val->getType()->isPointerTy()) {
827 Value *Cast = Builder.CreatePointerCast(GEP, Val->getType(),
828 Val->getName() + ".conv");
829 GEP = Cast;
830 }
831 Val->replaceAllUsesWith(GEP);
832 }
833
834 return NewInsts[Start];
835}
836
837/// Looks through GEPs, IntToPtrInsts and PtrToIntInsts in order to express
838/// the input Value as a constant indexed GEP. Returns a pair containing
839/// the GEPs Pointer and Index.
840static std::pair<Value *, Value *>
841getAsConstantIndexedAddress(Value *V, const DataLayout &DL) {
842 Type *IndexType = IntegerType::get(V->getContext(),
843 DL.getPointerTypeSizeInBits(V->getType()));
844
845 Constant *Index = ConstantInt::getNullValue(IndexType);
846 while (true) {
847 if (GEPOperator *GEP = dyn_cast<GEPOperator>(V)) {
848 // We accept only inbouds GEPs here to exclude the possibility of
849 // overflow.
850 if (!GEP->isInBounds())
851 break;
852 if (GEP->hasAllConstantIndices() && GEP->getNumIndices() == 1 &&
853 GEP->getType() == V->getType()) {
854 V = GEP->getOperand(0);
855 Constant *GEPIndex = static_cast<Constant *>(GEP->getOperand(1));
856 Index = ConstantExpr::getAdd(
857 Index, ConstantExpr::getSExtOrBitCast(GEPIndex, IndexType));
858 continue;
859 }
860 break;
861 }
862 if (auto *CI = dyn_cast<IntToPtrInst>(V)) {
863 if (!CI->isNoopCast(DL))
864 break;
865 V = CI->getOperand(0);
866 continue;
867 }
868 if (auto *CI = dyn_cast<PtrToIntInst>(V)) {
869 if (!CI->isNoopCast(DL))
870 break;
871 V = CI->getOperand(0);
872 continue;
873 }
874 break;
875 }
876 return {V, Index};
877}
878
Sanjay Patel5f0217f2016-06-05 16:46:18 +0000879/// Converts (CMP GEPLHS, RHS) if this change would make RHS a constant.
880/// We can look through PHIs, GEPs and casts in order to determine a common base
881/// between GEPLHS and RHS.
Silviu Barangaf29dfd32016-01-15 15:52:05 +0000882static Instruction *transformToIndexedCompare(GEPOperator *GEPLHS, Value *RHS,
883 ICmpInst::Predicate Cond,
884 const DataLayout &DL) {
885 if (!GEPLHS->hasAllConstantIndices())
886 return nullptr;
887
Silviu Barangac6d21eb2017-01-31 14:04:15 +0000888 // Make sure the pointers have the same type.
889 if (GEPLHS->getType() != RHS->getType())
890 return nullptr;
891
Silviu Barangaf29dfd32016-01-15 15:52:05 +0000892 Value *PtrBase, *Index;
893 std::tie(PtrBase, Index) = getAsConstantIndexedAddress(GEPLHS, DL);
894
895 // The set of nodes that will take part in this transformation.
896 SetVector<Value *> Nodes;
897
898 if (!canRewriteGEPAsOffset(RHS, PtrBase, DL, Nodes))
899 return nullptr;
900
901 // We know we can re-write this as
902 // ((gep Ptr, OFFSET1) cmp (gep Ptr, OFFSET2)
903 // Since we've only looked through inbouds GEPs we know that we
904 // can't have overflow on either side. We can therefore re-write
905 // this as:
906 // OFFSET1 cmp OFFSET2
907 Value *NewRHS = rewriteGEPAsOffset(RHS, PtrBase, DL, Nodes);
908
909 // RewriteGEPAsOffset has replaced RHS and all of its uses with a re-written
910 // GEP having PtrBase as the pointer base, and has returned in NewRHS the
911 // offset. Since Index is the offset of LHS to the base pointer, we will now
912 // compare the offsets instead of comparing the pointers.
913 return new ICmpInst(ICmpInst::getSignedPredicate(Cond), Index, NewRHS);
914}
915
Sanjay Patel5f0217f2016-06-05 16:46:18 +0000916/// Fold comparisons between a GEP instruction and something else. At this point
917/// we know that the GEP is on the LHS of the comparison.
Sanjay Patel43395062016-07-21 18:07:40 +0000918Instruction *InstCombiner::foldGEPICmp(GEPOperator *GEPLHS, Value *RHS,
Chris Lattner2188e402010-01-04 07:37:31 +0000919 ICmpInst::Predicate Cond,
920 Instruction &I) {
Benjamin Kramer6ee86902012-02-21 13:31:09 +0000921 // Don't transform signed compares of GEPs into index compares. Even if the
922 // GEP is inbounds, the final add of the base pointer can have signed overflow
923 // and would change the result of the icmp.
924 // e.g. "&foo[0] <s &foo[1]" can't be folded to "true" because "foo" could be
Benjamin Kramerc7a22fe2012-02-21 13:40:06 +0000925 // the maximum signed value for the pointer type.
Benjamin Kramer6ee86902012-02-21 13:31:09 +0000926 if (ICmpInst::isSigned(Cond))
Craig Topperf40110f2014-04-25 05:29:35 +0000927 return nullptr;
Benjamin Kramer6ee86902012-02-21 13:31:09 +0000928
Matt Arsenault44f60d02014-06-09 19:20:29 +0000929 // Look through bitcasts and addrspacecasts. We do not however want to remove
930 // 0 GEPs.
931 if (!isa<GetElementPtrInst>(RHS))
932 RHS = RHS->stripPointerCasts();
Chris Lattner2188e402010-01-04 07:37:31 +0000933
934 Value *PtrBase = GEPLHS->getOperand(0);
Mehdi Aminia28d91d2015-03-10 02:37:25 +0000935 if (PtrBase == RHS && GEPLHS->isInBounds()) {
Chris Lattner2188e402010-01-04 07:37:31 +0000936 // ((gep Ptr, OFFSET) cmp Ptr) ---> (OFFSET cmp 0).
937 // This transformation (ignoring the base and scales) is valid because we
938 // know pointers can't overflow since the gep is inbounds. See if we can
939 // output an optimized form.
Sanjay Pateld93c4c02016-09-15 18:22:25 +0000940 Value *Offset = evaluateGEPOffsetExpression(GEPLHS, *this, DL);
Jim Grosbach129c52a2011-09-30 18:09:53 +0000941
Chris Lattner2188e402010-01-04 07:37:31 +0000942 // If not, synthesize the offset the hard way.
Craig Topperf40110f2014-04-25 05:29:35 +0000943 if (!Offset)
Chris Lattner2188e402010-01-04 07:37:31 +0000944 Offset = EmitGEPOffset(GEPLHS);
945 return new ICmpInst(ICmpInst::getSignedPredicate(Cond), Offset,
946 Constant::getNullValue(Offset->getType()));
947 } else if (GEPOperator *GEPRHS = dyn_cast<GEPOperator>(RHS)) {
948 // If the base pointers are different, but the indices are the same, just
949 // compare the base pointer.
950 if (PtrBase != GEPRHS->getOperand(0)) {
951 bool IndicesTheSame = GEPLHS->getNumOperands()==GEPRHS->getNumOperands();
952 IndicesTheSame &= GEPLHS->getOperand(0)->getType() ==
953 GEPRHS->getOperand(0)->getType();
954 if (IndicesTheSame)
955 for (unsigned i = 1, e = GEPLHS->getNumOperands(); i != e; ++i)
956 if (GEPLHS->getOperand(i) != GEPRHS->getOperand(i)) {
957 IndicesTheSame = false;
958 break;
959 }
960
961 // If all indices are the same, just compare the base pointers.
962 if (IndicesTheSame)
David Majnemer5953d372013-06-29 10:28:04 +0000963 return new ICmpInst(Cond, GEPLHS->getOperand(0), GEPRHS->getOperand(0));
Chris Lattner2188e402010-01-04 07:37:31 +0000964
Benjamin Kramer7adb1892012-02-20 15:07:47 +0000965 // If we're comparing GEPs with two base pointers that only differ in type
966 // and both GEPs have only constant indices or just one use, then fold
967 // the compare with the adjusted indices.
Mehdi Aminia28d91d2015-03-10 02:37:25 +0000968 if (GEPLHS->isInBounds() && GEPRHS->isInBounds() &&
Benjamin Kramer7adb1892012-02-20 15:07:47 +0000969 (GEPLHS->hasAllConstantIndices() || GEPLHS->hasOneUse()) &&
970 (GEPRHS->hasAllConstantIndices() || GEPRHS->hasOneUse()) &&
971 PtrBase->stripPointerCasts() ==
Mehdi Aminia28d91d2015-03-10 02:37:25 +0000972 GEPRHS->getOperand(0)->stripPointerCasts()) {
Matt Arsenault44f60d02014-06-09 19:20:29 +0000973 Value *LOffset = EmitGEPOffset(GEPLHS);
974 Value *ROffset = EmitGEPOffset(GEPRHS);
975
976 // If we looked through an addrspacecast between different sized address
977 // spaces, the LHS and RHS pointers are different sized
978 // integers. Truncate to the smaller one.
979 Type *LHSIndexTy = LOffset->getType();
980 Type *RHSIndexTy = ROffset->getType();
981 if (LHSIndexTy != RHSIndexTy) {
982 if (LHSIndexTy->getPrimitiveSizeInBits() <
983 RHSIndexTy->getPrimitiveSizeInBits()) {
984 ROffset = Builder->CreateTrunc(ROffset, LHSIndexTy);
985 } else
986 LOffset = Builder->CreateTrunc(LOffset, RHSIndexTy);
987 }
988
Benjamin Kramer7adb1892012-02-20 15:07:47 +0000989 Value *Cmp = Builder->CreateICmp(ICmpInst::getSignedPredicate(Cond),
Matt Arsenault44f60d02014-06-09 19:20:29 +0000990 LOffset, ROffset);
Sanjay Patel4b198802016-02-01 22:23:39 +0000991 return replaceInstUsesWith(I, Cmp);
Benjamin Kramer7adb1892012-02-20 15:07:47 +0000992 }
993
Chris Lattner2188e402010-01-04 07:37:31 +0000994 // Otherwise, the base pointers are different and the indices are
Silviu Barangaf29dfd32016-01-15 15:52:05 +0000995 // different. Try convert this to an indexed compare by looking through
996 // PHIs/casts.
997 return transformToIndexedCompare(GEPLHS, RHS, Cond, DL);
Chris Lattner2188e402010-01-04 07:37:31 +0000998 }
999
1000 // If one of the GEPs has all zero indices, recurse.
Benjamin Kramerd0993e02014-07-07 11:01:16 +00001001 if (GEPLHS->hasAllZeroIndices())
Sanjay Patel43395062016-07-21 18:07:40 +00001002 return foldGEPICmp(GEPRHS, GEPLHS->getOperand(0),
David Majnemer92a8a7d2013-06-29 09:45:35 +00001003 ICmpInst::getSwappedPredicate(Cond), I);
Chris Lattner2188e402010-01-04 07:37:31 +00001004
1005 // If the other GEP has all zero indices, recurse.
Benjamin Kramerd0993e02014-07-07 11:01:16 +00001006 if (GEPRHS->hasAllZeroIndices())
Sanjay Patel43395062016-07-21 18:07:40 +00001007 return foldGEPICmp(GEPLHS, GEPRHS->getOperand(0), Cond, I);
Chris Lattner2188e402010-01-04 07:37:31 +00001008
Stuart Hastings66a82b92011-05-14 05:55:10 +00001009 bool GEPsInBounds = GEPLHS->isInBounds() && GEPRHS->isInBounds();
Chris Lattner2188e402010-01-04 07:37:31 +00001010 if (GEPLHS->getNumOperands() == GEPRHS->getNumOperands()) {
1011 // If the GEPs only differ by one index, compare it.
1012 unsigned NumDifferences = 0; // Keep track of # differences.
1013 unsigned DiffOperand = 0; // The operand that differs.
1014 for (unsigned i = 1, e = GEPRHS->getNumOperands(); i != e; ++i)
1015 if (GEPLHS->getOperand(i) != GEPRHS->getOperand(i)) {
1016 if (GEPLHS->getOperand(i)->getType()->getPrimitiveSizeInBits() !=
1017 GEPRHS->getOperand(i)->getType()->getPrimitiveSizeInBits()) {
1018 // Irreconcilable differences.
1019 NumDifferences = 2;
1020 break;
1021 } else {
1022 if (NumDifferences++) break;
1023 DiffOperand = i;
1024 }
1025 }
1026
Rafael Espindolaa7bbc0b2013-06-06 17:03:05 +00001027 if (NumDifferences == 0) // SAME GEP?
Sanjay Patel4b198802016-02-01 22:23:39 +00001028 return replaceInstUsesWith(I, // No comparison is needed here.
Jakub Staszakbddea112013-06-06 20:18:46 +00001029 Builder->getInt1(ICmpInst::isTrueWhenEqual(Cond)));
Chris Lattner2188e402010-01-04 07:37:31 +00001030
Stuart Hastings66a82b92011-05-14 05:55:10 +00001031 else if (NumDifferences == 1 && GEPsInBounds) {
Chris Lattner2188e402010-01-04 07:37:31 +00001032 Value *LHSV = GEPLHS->getOperand(DiffOperand);
1033 Value *RHSV = GEPRHS->getOperand(DiffOperand);
1034 // Make sure we do a signed comparison here.
1035 return new ICmpInst(ICmpInst::getSignedPredicate(Cond), LHSV, RHSV);
1036 }
1037 }
1038
1039 // Only lower this if the icmp is the only user of the GEP or if we expect
1040 // the result to fold to a constant!
Mehdi Aminia28d91d2015-03-10 02:37:25 +00001041 if (GEPsInBounds && (isa<ConstantExpr>(GEPLHS) || GEPLHS->hasOneUse()) &&
Chris Lattner2188e402010-01-04 07:37:31 +00001042 (isa<ConstantExpr>(GEPRHS) || GEPRHS->hasOneUse())) {
1043 // ((gep Ptr, OFFSET1) cmp (gep Ptr, OFFSET2) ---> (OFFSET1 cmp OFFSET2)
1044 Value *L = EmitGEPOffset(GEPLHS);
1045 Value *R = EmitGEPOffset(GEPRHS);
1046 return new ICmpInst(ICmpInst::getSignedPredicate(Cond), L, R);
1047 }
1048 }
Silviu Barangaf29dfd32016-01-15 15:52:05 +00001049
1050 // Try convert this to an indexed compare by looking through PHIs/casts as a
1051 // last resort.
1052 return transformToIndexedCompare(GEPLHS, RHS, Cond, DL);
Chris Lattner2188e402010-01-04 07:37:31 +00001053}
1054
Pete Cooper980a9352016-08-12 17:13:28 +00001055Instruction *InstCombiner::foldAllocaCmp(ICmpInst &ICI,
1056 const AllocaInst *Alloca,
1057 const Value *Other) {
Hans Wennborgf1f36512015-10-07 00:20:07 +00001058 assert(ICI.isEquality() && "Cannot fold non-equality comparison.");
1059
1060 // It would be tempting to fold away comparisons between allocas and any
1061 // pointer not based on that alloca (e.g. an argument). However, even
1062 // though such pointers cannot alias, they can still compare equal.
1063 //
1064 // But LLVM doesn't specify where allocas get their memory, so if the alloca
1065 // doesn't escape we can argue that it's impossible to guess its value, and we
1066 // can therefore act as if any such guesses are wrong.
1067 //
1068 // The code below checks that the alloca doesn't escape, and that it's only
1069 // used in a comparison once (the current instruction). The
1070 // single-comparison-use condition ensures that we're trivially folding all
1071 // comparisons against the alloca consistently, and avoids the risk of
1072 // erroneously folding a comparison of the pointer with itself.
1073
1074 unsigned MaxIter = 32; // Break cycles and bound to constant-time.
1075
Pete Cooper980a9352016-08-12 17:13:28 +00001076 SmallVector<const Use *, 32> Worklist;
1077 for (const Use &U : Alloca->uses()) {
Hans Wennborgf1f36512015-10-07 00:20:07 +00001078 if (Worklist.size() >= MaxIter)
1079 return nullptr;
1080 Worklist.push_back(&U);
1081 }
1082
1083 unsigned NumCmps = 0;
1084 while (!Worklist.empty()) {
1085 assert(Worklist.size() <= MaxIter);
Pete Cooper980a9352016-08-12 17:13:28 +00001086 const Use *U = Worklist.pop_back_val();
1087 const Value *V = U->getUser();
Hans Wennborgf1f36512015-10-07 00:20:07 +00001088 --MaxIter;
1089
1090 if (isa<BitCastInst>(V) || isa<GetElementPtrInst>(V) || isa<PHINode>(V) ||
1091 isa<SelectInst>(V)) {
1092 // Track the uses.
1093 } else if (isa<LoadInst>(V)) {
1094 // Loading from the pointer doesn't escape it.
1095 continue;
Pete Cooper980a9352016-08-12 17:13:28 +00001096 } else if (const auto *SI = dyn_cast<StoreInst>(V)) {
Hans Wennborgf1f36512015-10-07 00:20:07 +00001097 // Storing *to* the pointer is fine, but storing the pointer escapes it.
1098 if (SI->getValueOperand() == U->get())
1099 return nullptr;
1100 continue;
1101 } else if (isa<ICmpInst>(V)) {
1102 if (NumCmps++)
1103 return nullptr; // Found more than one cmp.
1104 continue;
Pete Cooper980a9352016-08-12 17:13:28 +00001105 } else if (const auto *Intrin = dyn_cast<IntrinsicInst>(V)) {
Hans Wennborgf1f36512015-10-07 00:20:07 +00001106 switch (Intrin->getIntrinsicID()) {
1107 // These intrinsics don't escape or compare the pointer. Memset is safe
1108 // because we don't allow ptrtoint. Memcpy and memmove are safe because
1109 // we don't allow stores, so src cannot point to V.
1110 case Intrinsic::lifetime_start: case Intrinsic::lifetime_end:
1111 case Intrinsic::dbg_declare: case Intrinsic::dbg_value:
1112 case Intrinsic::memcpy: case Intrinsic::memmove: case Intrinsic::memset:
1113 continue;
1114 default:
1115 return nullptr;
1116 }
1117 } else {
1118 return nullptr;
1119 }
Pete Cooper980a9352016-08-12 17:13:28 +00001120 for (const Use &U : V->uses()) {
Hans Wennborgf1f36512015-10-07 00:20:07 +00001121 if (Worklist.size() >= MaxIter)
1122 return nullptr;
1123 Worklist.push_back(&U);
1124 }
1125 }
1126
1127 Type *CmpTy = CmpInst::makeCmpResultType(Other->getType());
Sanjay Patel4b198802016-02-01 22:23:39 +00001128 return replaceInstUsesWith(
Hans Wennborgf1f36512015-10-07 00:20:07 +00001129 ICI,
1130 ConstantInt::get(CmpTy, !CmpInst::isTrueWhenEqual(ICI.getPredicate())));
1131}
1132
Sanjay Patel5f0217f2016-06-05 16:46:18 +00001133/// Fold "icmp pred (X+CI), X".
Sanjay Patel43395062016-07-21 18:07:40 +00001134Instruction *InstCombiner::foldICmpAddOpConst(Instruction &ICI,
1135 Value *X, ConstantInt *CI,
1136 ICmpInst::Predicate Pred) {
Chris Lattner2188e402010-01-04 07:37:31 +00001137 // From this point on, we know that (X+C <= X) --> (X+C < X) because C != 0,
Chris Lattner0ab5e2c2011-04-15 05:18:47 +00001138 // so the values can never be equal. Similarly for all other "or equals"
Chris Lattner2188e402010-01-04 07:37:31 +00001139 // operators.
Jim Grosbach129c52a2011-09-30 18:09:53 +00001140
Chris Lattner8c92b572010-01-08 17:48:19 +00001141 // (X+1) <u X --> X >u (MAXUINT-1) --> X == 255
Chris Lattner2188e402010-01-04 07:37:31 +00001142 // (X+2) <u X --> X >u (MAXUINT-2) --> X > 253
1143 // (X+MAXUINT) <u X --> X >u (MAXUINT-MAXUINT) --> X != 0
1144 if (Pred == ICmpInst::ICMP_ULT || Pred == ICmpInst::ICMP_ULE) {
Jim Grosbach129c52a2011-09-30 18:09:53 +00001145 Value *R =
Chris Lattner8c92b572010-01-08 17:48:19 +00001146 ConstantExpr::getSub(ConstantInt::getAllOnesValue(CI->getType()), CI);
Chris Lattner2188e402010-01-04 07:37:31 +00001147 return new ICmpInst(ICmpInst::ICMP_UGT, X, R);
1148 }
Jim Grosbach129c52a2011-09-30 18:09:53 +00001149
Chris Lattner2188e402010-01-04 07:37:31 +00001150 // (X+1) >u X --> X <u (0-1) --> X != 255
1151 // (X+2) >u X --> X <u (0-2) --> X <u 254
1152 // (X+MAXUINT) >u X --> X <u (0-MAXUINT) --> X <u 1 --> X == 0
Duncan Sandse5220012011-02-17 07:46:37 +00001153 if (Pred == ICmpInst::ICMP_UGT || Pred == ICmpInst::ICMP_UGE)
Chris Lattner2188e402010-01-04 07:37:31 +00001154 return new ICmpInst(ICmpInst::ICMP_ULT, X, ConstantExpr::getNeg(CI));
Jim Grosbach129c52a2011-09-30 18:09:53 +00001155
Chris Lattner2188e402010-01-04 07:37:31 +00001156 unsigned BitWidth = CI->getType()->getPrimitiveSizeInBits();
1157 ConstantInt *SMax = ConstantInt::get(X->getContext(),
1158 APInt::getSignedMaxValue(BitWidth));
1159
1160 // (X+ 1) <s X --> X >s (MAXSINT-1) --> X == 127
1161 // (X+ 2) <s X --> X >s (MAXSINT-2) --> X >s 125
1162 // (X+MAXSINT) <s X --> X >s (MAXSINT-MAXSINT) --> X >s 0
1163 // (X+MINSINT) <s X --> X >s (MAXSINT-MINSINT) --> X >s -1
1164 // (X+ -2) <s X --> X >s (MAXSINT- -2) --> X >s 126
1165 // (X+ -1) <s X --> X >s (MAXSINT- -1) --> X != 127
Duncan Sandse5220012011-02-17 07:46:37 +00001166 if (Pred == ICmpInst::ICMP_SLT || Pred == ICmpInst::ICMP_SLE)
Chris Lattner2188e402010-01-04 07:37:31 +00001167 return new ICmpInst(ICmpInst::ICMP_SGT, X, ConstantExpr::getSub(SMax, CI));
Jim Grosbach129c52a2011-09-30 18:09:53 +00001168
Chris Lattner2188e402010-01-04 07:37:31 +00001169 // (X+ 1) >s X --> X <s (MAXSINT-(1-1)) --> X != 127
1170 // (X+ 2) >s X --> X <s (MAXSINT-(2-1)) --> X <s 126
1171 // (X+MAXSINT) >s X --> X <s (MAXSINT-(MAXSINT-1)) --> X <s 1
1172 // (X+MINSINT) >s X --> X <s (MAXSINT-(MINSINT-1)) --> X <s -2
1173 // (X+ -2) >s X --> X <s (MAXSINT-(-2-1)) --> X <s -126
1174 // (X+ -1) >s X --> X <s (MAXSINT-(-1-1)) --> X == -128
Jim Grosbach129c52a2011-09-30 18:09:53 +00001175
Chris Lattner2188e402010-01-04 07:37:31 +00001176 assert(Pred == ICmpInst::ICMP_SGT || Pred == ICmpInst::ICMP_SGE);
Jakub Staszakbddea112013-06-06 20:18:46 +00001177 Constant *C = Builder->getInt(CI->getValue()-1);
Chris Lattner2188e402010-01-04 07:37:31 +00001178 return new ICmpInst(ICmpInst::ICMP_SLT, X, ConstantExpr::getSub(SMax, C));
1179}
1180
Sanjay Patel8da42cc2016-09-15 22:26:31 +00001181/// Handle "(icmp eq/ne (ashr/lshr AP2, A), AP1)" ->
1182/// (icmp eq/ne A, Log2(AP2/AP1)) ->
1183/// (icmp eq/ne A, Log2(AP2) - Log2(AP1)).
1184Instruction *InstCombiner::foldICmpShrConstConst(ICmpInst &I, Value *A,
1185 const APInt &AP1,
1186 const APInt &AP2) {
Suyog Sarda3a8c2c12014-07-22 19:19:36 +00001187 assert(I.isEquality() && "Cannot fold icmp gt/lt");
1188
Suyog Sarda3a8c2c12014-07-22 19:19:36 +00001189 auto getICmp = [&I](CmpInst::Predicate Pred, Value *LHS, Value *RHS) {
1190 if (I.getPredicate() == I.ICMP_NE)
1191 Pred = CmpInst::getInversePredicate(Pred);
1192 return new ICmpInst(Pred, LHS, RHS);
1193 };
1194
David Majnemer2abb8182014-10-25 07:13:13 +00001195 // Don't bother doing any work for cases which InstSimplify handles.
1196 if (AP2 == 0)
1197 return nullptr;
Sanjay Patel8da42cc2016-09-15 22:26:31 +00001198
1199 bool IsAShr = isa<AShrOperator>(I.getOperand(0));
David Majnemer2abb8182014-10-25 07:13:13 +00001200 if (IsAShr) {
1201 if (AP2.isAllOnesValue())
1202 return nullptr;
1203 if (AP2.isNegative() != AP1.isNegative())
1204 return nullptr;
1205 if (AP2.sgt(AP1))
1206 return nullptr;
1207 }
Suyog Sarda3a8c2c12014-07-22 19:19:36 +00001208
David Majnemerd2056022014-10-21 19:51:55 +00001209 if (!AP1)
Suyog Sarda3a8c2c12014-07-22 19:19:36 +00001210 // 'A' must be large enough to shift out the highest set bit.
1211 return getICmp(I.ICMP_UGT, A,
1212 ConstantInt::get(A->getType(), AP2.logBase2()));
Suyog Sarda3a8c2c12014-07-22 19:19:36 +00001213
David Majnemerd2056022014-10-21 19:51:55 +00001214 if (AP1 == AP2)
1215 return getICmp(I.ICMP_EQ, A, ConstantInt::getNullValue(A->getType()));
Suyog Sarda3a8c2c12014-07-22 19:19:36 +00001216
Andrea Di Biagio5b92b492014-09-17 11:32:31 +00001217 int Shift;
David Majnemerd2056022014-10-21 19:51:55 +00001218 if (IsAShr && AP1.isNegative())
David Majnemere5977eb2015-09-19 00:48:26 +00001219 Shift = AP1.countLeadingOnes() - AP2.countLeadingOnes();
Andrea Di Biagio5b92b492014-09-17 11:32:31 +00001220 else
David Majnemere5977eb2015-09-19 00:48:26 +00001221 Shift = AP1.countLeadingZeros() - AP2.countLeadingZeros();
Suyog Sarda3a8c2c12014-07-22 19:19:36 +00001222
David Majnemerd2056022014-10-21 19:51:55 +00001223 if (Shift > 0) {
David Majnemere5977eb2015-09-19 00:48:26 +00001224 if (IsAShr && AP1 == AP2.ashr(Shift)) {
1225 // There are multiple solutions if we are comparing against -1 and the LHS
David Majnemer47ce0b82015-09-19 00:48:31 +00001226 // of the ashr is not a power of two.
David Majnemere5977eb2015-09-19 00:48:26 +00001227 if (AP1.isAllOnesValue() && !AP2.isPowerOf2())
1228 return getICmp(I.ICMP_UGE, A, ConstantInt::get(A->getType(), Shift));
David Majnemerd2056022014-10-21 19:51:55 +00001229 return getICmp(I.ICMP_EQ, A, ConstantInt::get(A->getType(), Shift));
David Majnemere5977eb2015-09-19 00:48:26 +00001230 } else if (AP1 == AP2.lshr(Shift)) {
1231 return getICmp(I.ICMP_EQ, A, ConstantInt::get(A->getType(), Shift));
1232 }
David Majnemerd2056022014-10-21 19:51:55 +00001233 }
Sanjay Patel524fcdf2016-09-15 19:04:55 +00001234
Suyog Sarda3a8c2c12014-07-22 19:19:36 +00001235 // Shifting const2 will never be equal to const1.
Sanjay Patel524fcdf2016-09-15 19:04:55 +00001236 // FIXME: This should always be handled by InstSimplify?
1237 auto *TorF = ConstantInt::get(I.getType(), I.getPredicate() == I.ICMP_NE);
1238 return replaceInstUsesWith(I, TorF);
Suyog Sarda3a8c2c12014-07-22 19:19:36 +00001239}
Chris Lattner2188e402010-01-04 07:37:31 +00001240
Sanjay Patel8da42cc2016-09-15 22:26:31 +00001241/// Handle "(icmp eq/ne (shl AP2, A), AP1)" ->
1242/// (icmp eq/ne A, TrailingZeros(AP1) - TrailingZeros(AP2)).
1243Instruction *InstCombiner::foldICmpShlConstConst(ICmpInst &I, Value *A,
1244 const APInt &AP1,
1245 const APInt &AP2) {
David Majnemer59939ac2014-10-19 08:23:08 +00001246 assert(I.isEquality() && "Cannot fold icmp gt/lt");
1247
David Majnemer59939ac2014-10-19 08:23:08 +00001248 auto getICmp = [&I](CmpInst::Predicate Pred, Value *LHS, Value *RHS) {
1249 if (I.getPredicate() == I.ICMP_NE)
1250 Pred = CmpInst::getInversePredicate(Pred);
1251 return new ICmpInst(Pred, LHS, RHS);
1252 };
1253
David Majnemer2abb8182014-10-25 07:13:13 +00001254 // Don't bother doing any work for cases which InstSimplify handles.
1255 if (AP2 == 0)
1256 return nullptr;
David Majnemer59939ac2014-10-19 08:23:08 +00001257
1258 unsigned AP2TrailingZeros = AP2.countTrailingZeros();
1259
1260 if (!AP1 && AP2TrailingZeros != 0)
Sanjay Patelaf91d1f2016-09-15 21:35:30 +00001261 return getICmp(
1262 I.ICMP_UGE, A,
1263 ConstantInt::get(A->getType(), AP2.getBitWidth() - AP2TrailingZeros));
David Majnemer59939ac2014-10-19 08:23:08 +00001264
1265 if (AP1 == AP2)
1266 return getICmp(I.ICMP_EQ, A, ConstantInt::getNullValue(A->getType()));
1267
1268 // Get the distance between the lowest bits that are set.
1269 int Shift = AP1.countTrailingZeros() - AP2TrailingZeros;
1270
1271 if (Shift > 0 && AP2.shl(Shift) == AP1)
1272 return getICmp(I.ICMP_EQ, A, ConstantInt::get(A->getType(), Shift));
1273
1274 // Shifting const2 will never be equal to const1.
Sanjay Patel524fcdf2016-09-15 19:04:55 +00001275 // FIXME: This should always be handled by InstSimplify?
1276 auto *TorF = ConstantInt::get(I.getType(), I.getPredicate() == I.ICMP_NE);
1277 return replaceInstUsesWith(I, TorF);
David Majnemer59939ac2014-10-19 08:23:08 +00001278}
1279
Sanjay Patel06b127a2016-09-15 14:37:50 +00001280/// The caller has matched a pattern of the form:
1281/// I = icmp ugt (add (add A, B), CI2), CI1
1282/// If this is of the form:
1283/// sum = a + b
1284/// if (sum+128 >u 255)
1285/// Then replace it with llvm.sadd.with.overflow.i8.
1286///
Sanjay Pateld93c4c02016-09-15 18:22:25 +00001287static Instruction *processUGT_ADDCST_ADD(ICmpInst &I, Value *A, Value *B,
Sanjay Patel06b127a2016-09-15 14:37:50 +00001288 ConstantInt *CI2, ConstantInt *CI1,
1289 InstCombiner &IC) {
1290 // The transformation we're trying to do here is to transform this into an
1291 // llvm.sadd.with.overflow. To do this, we have to replace the original add
1292 // with a narrower add, and discard the add-with-constant that is part of the
1293 // range check (if we can't eliminate it, this isn't profitable).
1294
1295 // In order to eliminate the add-with-constant, the compare can be its only
1296 // use.
1297 Instruction *AddWithCst = cast<Instruction>(I.getOperand(0));
1298 if (!AddWithCst->hasOneUse())
1299 return nullptr;
1300
1301 // If CI2 is 2^7, 2^15, 2^31, then it might be an sadd.with.overflow.
1302 if (!CI2->getValue().isPowerOf2())
1303 return nullptr;
1304 unsigned NewWidth = CI2->getValue().countTrailingZeros();
1305 if (NewWidth != 7 && NewWidth != 15 && NewWidth != 31)
1306 return nullptr;
1307
1308 // The width of the new add formed is 1 more than the bias.
1309 ++NewWidth;
1310
1311 // Check to see that CI1 is an all-ones value with NewWidth bits.
1312 if (CI1->getBitWidth() == NewWidth ||
1313 CI1->getValue() != APInt::getLowBitsSet(CI1->getBitWidth(), NewWidth))
1314 return nullptr;
1315
1316 // This is only really a signed overflow check if the inputs have been
1317 // sign-extended; check for that condition. For example, if CI2 is 2^31 and
1318 // the operands of the add are 64 bits wide, we need at least 33 sign bits.
1319 unsigned NeededSignBits = CI1->getBitWidth() - NewWidth + 1;
1320 if (IC.ComputeNumSignBits(A, 0, &I) < NeededSignBits ||
1321 IC.ComputeNumSignBits(B, 0, &I) < NeededSignBits)
1322 return nullptr;
1323
1324 // In order to replace the original add with a narrower
1325 // llvm.sadd.with.overflow, the only uses allowed are the add-with-constant
1326 // and truncates that discard the high bits of the add. Verify that this is
1327 // the case.
1328 Instruction *OrigAdd = cast<Instruction>(AddWithCst->getOperand(0));
1329 for (User *U : OrigAdd->users()) {
1330 if (U == AddWithCst)
1331 continue;
1332
1333 // Only accept truncates for now. We would really like a nice recursive
1334 // predicate like SimplifyDemandedBits, but which goes downwards the use-def
1335 // chain to see which bits of a value are actually demanded. If the
1336 // original add had another add which was then immediately truncated, we
1337 // could still do the transformation.
1338 TruncInst *TI = dyn_cast<TruncInst>(U);
1339 if (!TI || TI->getType()->getPrimitiveSizeInBits() > NewWidth)
1340 return nullptr;
1341 }
1342
1343 // If the pattern matches, truncate the inputs to the narrower type and
1344 // use the sadd_with_overflow intrinsic to efficiently compute both the
1345 // result and the overflow bit.
1346 Type *NewType = IntegerType::get(OrigAdd->getContext(), NewWidth);
1347 Value *F = Intrinsic::getDeclaration(I.getModule(),
1348 Intrinsic::sadd_with_overflow, NewType);
1349
1350 InstCombiner::BuilderTy *Builder = IC.Builder;
1351
1352 // Put the new code above the original add, in case there are any uses of the
1353 // add between the add and the compare.
1354 Builder->SetInsertPoint(OrigAdd);
1355
1356 Value *TruncA = Builder->CreateTrunc(A, NewType, A->getName() + ".trunc");
1357 Value *TruncB = Builder->CreateTrunc(B, NewType, B->getName() + ".trunc");
1358 CallInst *Call = Builder->CreateCall(F, {TruncA, TruncB}, "sadd");
1359 Value *Add = Builder->CreateExtractValue(Call, 0, "sadd.result");
1360 Value *ZExt = Builder->CreateZExt(Add, OrigAdd->getType());
1361
1362 // The inner add was the result of the narrow add, zero extended to the
1363 // wider type. Replace it with the result computed by the intrinsic.
1364 IC.replaceInstUsesWith(*OrigAdd, ZExt);
1365
1366 // The original icmp gets replaced with the overflow value.
1367 return ExtractValueInst::Create(Call, 1, "sadd.overflow");
1368}
1369
1370// Fold icmp Pred X, C.
Sanjay Patel97459832016-09-15 15:11:12 +00001371Instruction *InstCombiner::foldICmpWithConstant(ICmpInst &Cmp) {
1372 CmpInst::Predicate Pred = Cmp.getPredicate();
Sanjay Patel40c53ea2016-09-15 16:23:20 +00001373 Value *X = Cmp.getOperand(0);
Sanjay Patel06b127a2016-09-15 14:37:50 +00001374
Sanjay Patel40c53ea2016-09-15 16:23:20 +00001375 const APInt *C;
1376 if (!match(Cmp.getOperand(1), m_APInt(C)))
Sanjay Patel97459832016-09-15 15:11:12 +00001377 return nullptr;
Sanjay Patel06b127a2016-09-15 14:37:50 +00001378
Sanjay Patel97459832016-09-15 15:11:12 +00001379 Value *A = nullptr, *B = nullptr;
Sanjay Patel06b127a2016-09-15 14:37:50 +00001380
Sanjay Patel97459832016-09-15 15:11:12 +00001381 // Match the following pattern, which is a common idiom when writing
1382 // overflow-safe integer arithmetic functions. The source performs an addition
1383 // in wider type and explicitly checks for overflow using comparisons against
1384 // INT_MIN and INT_MAX. Simplify by using the sadd_with_overflow intrinsic.
1385 //
1386 // TODO: This could probably be generalized to handle other overflow-safe
1387 // operations if we worked out the formulas to compute the appropriate magic
1388 // constants.
1389 //
1390 // sum = a + b
1391 // if (sum+128 >u 255) ... -> llvm.sadd.with.overflow.i8
1392 {
1393 ConstantInt *CI2; // I = icmp ugt (add (add A, B), CI2), CI
1394 if (Pred == ICmpInst::ICMP_UGT &&
1395 match(X, m_Add(m_Add(m_Value(A), m_Value(B)), m_ConstantInt(CI2))))
Sanjay Pateld93c4c02016-09-15 18:22:25 +00001396 if (Instruction *Res = processUGT_ADDCST_ADD(
Sanjay Patel40c53ea2016-09-15 16:23:20 +00001397 Cmp, A, B, CI2, cast<ConstantInt>(Cmp.getOperand(1)), *this))
Sanjay Patel97459832016-09-15 15:11:12 +00001398 return Res;
1399 }
Sanjay Patel06b127a2016-09-15 14:37:50 +00001400
Sanjay Patel97459832016-09-15 15:11:12 +00001401 // (icmp sgt smin(PosA, B) 0) -> (icmp sgt B 0)
Sanjay Patel40c53ea2016-09-15 16:23:20 +00001402 if (*C == 0 && Pred == ICmpInst::ICMP_SGT) {
1403 SelectPatternResult SPR = matchSelectPattern(X, A, B);
1404 if (SPR.Flavor == SPF_SMIN) {
1405 if (isKnownPositive(A, DL))
1406 return new ICmpInst(Pred, B, Cmp.getOperand(1));
1407 if (isKnownPositive(B, DL))
1408 return new ICmpInst(Pred, A, Cmp.getOperand(1));
Sanjay Patel06b127a2016-09-15 14:37:50 +00001409 }
Sanjay Patel40c53ea2016-09-15 16:23:20 +00001410 }
1411
1412 // FIXME: Use m_APInt to allow folds for splat constants.
1413 ConstantInt *CI = dyn_cast<ConstantInt>(Cmp.getOperand(1));
1414 if (!CI)
1415 return nullptr;
Sanjay Patel06b127a2016-09-15 14:37:50 +00001416
Sanjay Patel97459832016-09-15 15:11:12 +00001417 // Canonicalize icmp instructions based on dominating conditions.
1418 BasicBlock *Parent = Cmp.getParent();
1419 BasicBlock *Dom = Parent->getSinglePredecessor();
1420 auto *BI = Dom ? dyn_cast<BranchInst>(Dom->getTerminator()) : nullptr;
1421 ICmpInst::Predicate Pred2;
1422 BasicBlock *TrueBB, *FalseBB;
1423 ConstantInt *CI2;
1424 if (BI && match(BI, m_Br(m_ICmp(Pred2, m_Specific(X), m_ConstantInt(CI2)),
1425 TrueBB, FalseBB)) &&
1426 TrueBB != FalseBB) {
1427 ConstantRange CR =
1428 ConstantRange::makeAllowedICmpRegion(Pred, CI->getValue());
1429 ConstantRange DominatingCR =
1430 (Parent == TrueBB)
1431 ? ConstantRange::makeExactICmpRegion(Pred2, CI2->getValue())
1432 : ConstantRange::makeExactICmpRegion(
1433 CmpInst::getInversePredicate(Pred2), CI2->getValue());
1434 ConstantRange Intersection = DominatingCR.intersectWith(CR);
1435 ConstantRange Difference = DominatingCR.difference(CR);
1436 if (Intersection.isEmptySet())
1437 return replaceInstUsesWith(Cmp, Builder->getFalse());
1438 if (Difference.isEmptySet())
1439 return replaceInstUsesWith(Cmp, Builder->getTrue());
Sanjay Patel06b127a2016-09-15 14:37:50 +00001440
Sanjay Patel97459832016-09-15 15:11:12 +00001441 // If this is a normal comparison, it demands all bits. If it is a sign
1442 // bit comparison, it only demands the sign bit.
1443 bool UnusedBit;
1444 bool IsSignBit = isSignBitCheck(Pred, CI->getValue(), UnusedBit);
1445
1446 // Canonicalizing a sign bit comparison that gets used in a branch,
1447 // pessimizes codegen by generating branch on zero instruction instead
1448 // of a test and branch. So we avoid canonicalizing in such situations
1449 // because test and branch instruction has better branch displacement
1450 // than compare and branch instruction.
1451 if (!isBranchOnSignBitCheck(Cmp, IsSignBit) && !Cmp.isEquality()) {
1452 if (auto *AI = Intersection.getSingleElement())
1453 return new ICmpInst(ICmpInst::ICMP_EQ, X, Builder->getInt(*AI));
1454 if (auto *AD = Difference.getSingleElement())
1455 return new ICmpInst(ICmpInst::ICMP_NE, X, Builder->getInt(*AD));
Sanjay Patel06b127a2016-09-15 14:37:50 +00001456 }
1457 }
1458
1459 return nullptr;
1460}
1461
Sanjay Patel5f4ce4e2016-08-18 20:25:16 +00001462/// Fold icmp (trunc X, Y), C.
1463Instruction *InstCombiner::foldICmpTruncConstant(ICmpInst &Cmp,
1464 Instruction *Trunc,
1465 const APInt *C) {
Sanjay Patel5f4ce4e2016-08-18 20:25:16 +00001466 ICmpInst::Predicate Pred = Cmp.getPredicate();
1467 Value *X = Trunc->getOperand(0);
Sanjay Patel40e8ca42016-08-18 20:28:54 +00001468 if (*C == 1 && C->getBitWidth() > 1) {
Sanjay Patela3f4f082016-08-16 17:54:36 +00001469 // icmp slt trunc(signum(V)) 1 --> icmp slt V, 1
1470 Value *V = nullptr;
Sanjay Patel5f4ce4e2016-08-18 20:25:16 +00001471 if (Pred == ICmpInst::ICMP_SLT && match(X, m_Signum(m_Value(V))))
Sanjay Patela3f4f082016-08-16 17:54:36 +00001472 return new ICmpInst(ICmpInst::ICMP_SLT, V,
1473 ConstantInt::get(V->getType(), 1));
1474 }
Sanjay Patel5f4ce4e2016-08-18 20:25:16 +00001475
1476 if (Cmp.isEquality() && Trunc->hasOneUse()) {
Sanjay Patela3f4f082016-08-16 17:54:36 +00001477 // Simplify icmp eq (trunc x to i8), 42 -> icmp eq x, 42|highbits if all
1478 // of the high bits truncated out of x are known.
Sanjay Patel40e8ca42016-08-18 20:28:54 +00001479 unsigned DstBits = Trunc->getType()->getScalarSizeInBits(),
1480 SrcBits = X->getType()->getScalarSizeInBits();
Craig Topper8205a1a2017-05-24 16:53:07 +00001481 KnownBits Known = computeKnownBits(X, 0, &Cmp);
Sanjay Patela3f4f082016-08-16 17:54:36 +00001482
1483 // If all the high bits are known, we can do this xform.
Craig Topperb45eabc2017-04-26 16:39:58 +00001484 if ((Known.Zero | Known.One).countLeadingOnes() >= SrcBits - DstBits) {
Sanjay Patela3f4f082016-08-16 17:54:36 +00001485 // Pull in the high bits from known-ones set.
Sanjay Patel5f4ce4e2016-08-18 20:25:16 +00001486 APInt NewRHS = C->zext(SrcBits);
Craig Topperb45eabc2017-04-26 16:39:58 +00001487 NewRHS |= Known.One & APInt::getHighBitsSet(SrcBits, SrcBits - DstBits);
Sanjay Patel40e8ca42016-08-18 20:28:54 +00001488 return new ICmpInst(Pred, X, ConstantInt::get(X->getType(), NewRHS));
Sanjay Patela3f4f082016-08-16 17:54:36 +00001489 }
1490 }
Sanjay Patel5f4ce4e2016-08-18 20:25:16 +00001491
Sanjay Patela3f4f082016-08-16 17:54:36 +00001492 return nullptr;
1493}
1494
Sanjay Patel6d5f4482016-08-17 19:23:42 +00001495/// Fold icmp (xor X, Y), C.
Sanjay Patelc9196c42016-08-22 21:24:29 +00001496Instruction *InstCombiner::foldICmpXorConstant(ICmpInst &Cmp,
1497 BinaryOperator *Xor,
Sanjay Patel6d5f4482016-08-17 19:23:42 +00001498 const APInt *C) {
Sanjay Patel4c5e60d2016-08-18 14:10:48 +00001499 Value *X = Xor->getOperand(0);
1500 Value *Y = Xor->getOperand(1);
Sanjay Pateldaffec912016-08-17 19:45:18 +00001501 const APInt *XorC;
Sanjay Patel4c5e60d2016-08-18 14:10:48 +00001502 if (!match(Y, m_APInt(XorC)))
Sanjay Patel6d5f4482016-08-17 19:23:42 +00001503 return nullptr;
Sanjay Patela3f4f082016-08-16 17:54:36 +00001504
Sanjay Patel6d5f4482016-08-17 19:23:42 +00001505 // If this is a comparison that tests the signbit (X < 0) or (x > -1),
1506 // fold the xor.
1507 ICmpInst::Predicate Pred = Cmp.getPredicate();
1508 if ((Pred == ICmpInst::ICMP_SLT && *C == 0) ||
1509 (Pred == ICmpInst::ICMP_SGT && C->isAllOnesValue())) {
Sanjay Patela3f4f082016-08-16 17:54:36 +00001510
Sanjay Patel6d5f4482016-08-17 19:23:42 +00001511 // If the sign bit of the XorCst is not set, there is no change to
1512 // the operation, just stop using the Xor.
Sanjay Pateldaffec912016-08-17 19:45:18 +00001513 if (!XorC->isNegative()) {
1514 Cmp.setOperand(0, X);
Sanjay Patel6d5f4482016-08-17 19:23:42 +00001515 Worklist.Add(Xor);
1516 return &Cmp;
Sanjay Patela3f4f082016-08-16 17:54:36 +00001517 }
1518
Sanjay Patel6d5f4482016-08-17 19:23:42 +00001519 // Was the old condition true if the operand is positive?
1520 bool isTrueIfPositive = Pred == ICmpInst::ICMP_SGT;
Sanjay Patela3f4f082016-08-16 17:54:36 +00001521
Sanjay Patel6d5f4482016-08-17 19:23:42 +00001522 // If so, the new one isn't.
1523 isTrueIfPositive ^= true;
Sanjay Patela3f4f082016-08-16 17:54:36 +00001524
Sanjay Patel4c5e60d2016-08-18 14:10:48 +00001525 Constant *CmpConstant = cast<Constant>(Cmp.getOperand(1));
Sanjay Patel6d5f4482016-08-17 19:23:42 +00001526 if (isTrueIfPositive)
Sanjay Patel4c5e60d2016-08-18 14:10:48 +00001527 return new ICmpInst(ICmpInst::ICMP_SGT, X, SubOne(CmpConstant));
Sanjay Patel6d5f4482016-08-17 19:23:42 +00001528 else
Sanjay Patel4c5e60d2016-08-18 14:10:48 +00001529 return new ICmpInst(ICmpInst::ICMP_SLT, X, AddOne(CmpConstant));
Sanjay Patela3f4f082016-08-16 17:54:36 +00001530 }
Sanjay Patel6d5f4482016-08-17 19:23:42 +00001531
1532 if (Xor->hasOneUse()) {
Craig Topperbcfd2d12017-04-20 16:56:25 +00001533 // (icmp u/s (xor X SignMask), C) -> (icmp s/u X, (xor C SignMask))
1534 if (!Cmp.isEquality() && XorC->isSignMask()) {
Sanjay Pateldaffec912016-08-17 19:45:18 +00001535 Pred = Cmp.isSigned() ? Cmp.getUnsignedPredicate()
1536 : Cmp.getSignedPredicate();
Sanjay Patel4c5e60d2016-08-18 14:10:48 +00001537 return new ICmpInst(Pred, X, ConstantInt::get(X->getType(), *C ^ *XorC));
Sanjay Patel6d5f4482016-08-17 19:23:42 +00001538 }
1539
Craig Topperbcfd2d12017-04-20 16:56:25 +00001540 // (icmp u/s (xor X ~SignMask), C) -> (icmp s/u X, (xor C ~SignMask))
Sanjay Pateldaffec912016-08-17 19:45:18 +00001541 if (!Cmp.isEquality() && XorC->isMaxSignedValue()) {
1542 Pred = Cmp.isSigned() ? Cmp.getUnsignedPredicate()
1543 : Cmp.getSignedPredicate();
Sanjay Patel6d5f4482016-08-17 19:23:42 +00001544 Pred = Cmp.getSwappedPredicate(Pred);
Sanjay Patel4c5e60d2016-08-18 14:10:48 +00001545 return new ICmpInst(Pred, X, ConstantInt::get(X->getType(), *C ^ *XorC));
Sanjay Patel6d5f4482016-08-17 19:23:42 +00001546 }
1547 }
1548
1549 // (icmp ugt (xor X, C), ~C) -> (icmp ult X, C)
1550 // iff -C is a power of 2
Sanjay Pateldaffec912016-08-17 19:45:18 +00001551 if (Pred == ICmpInst::ICMP_UGT && *XorC == ~(*C) && (*C + 1).isPowerOf2())
Sanjay Patel4c5e60d2016-08-18 14:10:48 +00001552 return new ICmpInst(ICmpInst::ICMP_ULT, X, Y);
Sanjay Patel6d5f4482016-08-17 19:23:42 +00001553
1554 // (icmp ult (xor X, C), -C) -> (icmp uge X, C)
1555 // iff -C is a power of 2
Sanjay Pateldaffec912016-08-17 19:45:18 +00001556 if (Pred == ICmpInst::ICMP_ULT && *XorC == -(*C) && C->isPowerOf2())
Sanjay Patel4c5e60d2016-08-18 14:10:48 +00001557 return new ICmpInst(ICmpInst::ICMP_UGE, X, Y);
Sanjay Patel6d5f4482016-08-17 19:23:42 +00001558
Sanjay Patela3f4f082016-08-16 17:54:36 +00001559 return nullptr;
1560}
1561
Sanjay Patel14e0e182016-08-26 18:28:46 +00001562/// Fold icmp (and (sh X, Y), C2), C1.
1563Instruction *InstCombiner::foldICmpAndShift(ICmpInst &Cmp, BinaryOperator *And,
Sanjay Patel9b40f982016-09-07 22:33:03 +00001564 const APInt *C1, const APInt *C2) {
1565 BinaryOperator *Shift = dyn_cast<BinaryOperator>(And->getOperand(0));
1566 if (!Shift || !Shift->isShift())
Sanjay Patelda9c5622016-08-26 17:15:22 +00001567 return nullptr;
Sanjay Patela3f4f082016-08-16 17:54:36 +00001568
Sanjay Patelda9c5622016-08-26 17:15:22 +00001569 // If this is: (X >> C3) & C2 != C1 (where any shift and any compare could
1570 // exist), turn it into (X & (C2 << C3)) != (C1 << C3). This happens a LOT in
1571 // code produced by the clang front-end, for bitfield access.
Sanjay Patelda9c5622016-08-26 17:15:22 +00001572 // This seemingly simple opportunity to fold away a shift turns out to be
1573 // rather complicated. See PR17827 for details.
Sanjay Patel9b40f982016-09-07 22:33:03 +00001574 unsigned ShiftOpcode = Shift->getOpcode();
1575 bool IsShl = ShiftOpcode == Instruction::Shl;
1576 const APInt *C3;
1577 if (match(Shift->getOperand(1), m_APInt(C3))) {
Sanjay Patelda9c5622016-08-26 17:15:22 +00001578 bool CanFold = false;
Sanjay Patelda9c5622016-08-26 17:15:22 +00001579 if (ShiftOpcode == Instruction::AShr) {
1580 // There may be some constraints that make this possible, but nothing
1581 // simple has been discovered yet.
1582 CanFold = false;
1583 } else if (ShiftOpcode == Instruction::Shl) {
1584 // For a left shift, we can fold if the comparison is not signed. We can
1585 // also fold a signed comparison if the mask value and comparison value
1586 // are not negative. These constraints may not be obvious, but we can
1587 // prove that they are correct using an SMT solver.
Sanjay Patel9b40f982016-09-07 22:33:03 +00001588 if (!Cmp.isSigned() || (!C2->isNegative() && !C1->isNegative()))
Sanjay Patelda9c5622016-08-26 17:15:22 +00001589 CanFold = true;
1590 } else if (ShiftOpcode == Instruction::LShr) {
1591 // For a logical right shift, we can fold if the comparison is not signed.
1592 // We can also fold a signed comparison if the shifted mask value and the
1593 // shifted comparison value are not negative. These constraints may not be
1594 // obvious, but we can prove that they are correct using an SMT solver.
Sanjay Patel9b40f982016-09-07 22:33:03 +00001595 if (!Cmp.isSigned() ||
1596 (!C2->shl(*C3).isNegative() && !C1->shl(*C3).isNegative()))
Sanjay Patelda9c5622016-08-26 17:15:22 +00001597 CanFold = true;
Sanjay Patela3f4f082016-08-16 17:54:36 +00001598 }
1599
Sanjay Patelda9c5622016-08-26 17:15:22 +00001600 if (CanFold) {
Sanjay Patel9b40f982016-09-07 22:33:03 +00001601 APInt NewCst = IsShl ? C1->lshr(*C3) : C1->shl(*C3);
1602 APInt SameAsC1 = IsShl ? NewCst.shl(*C3) : NewCst.lshr(*C3);
Sanjay Patelda9c5622016-08-26 17:15:22 +00001603 // Check to see if we are shifting out any of the bits being compared.
Sanjay Patel9b40f982016-09-07 22:33:03 +00001604 if (SameAsC1 != *C1) {
Sanjay Patelda9c5622016-08-26 17:15:22 +00001605 // If we shifted bits out, the fold is not going to work out. As a
1606 // special case, check to see if this means that the result is always
1607 // true or false now.
1608 if (Cmp.getPredicate() == ICmpInst::ICMP_EQ)
Sanjay Patel1c608f42016-09-08 16:54:02 +00001609 return replaceInstUsesWith(Cmp, ConstantInt::getFalse(Cmp.getType()));
Sanjay Patelda9c5622016-08-26 17:15:22 +00001610 if (Cmp.getPredicate() == ICmpInst::ICMP_NE)
Sanjay Patel1c608f42016-09-08 16:54:02 +00001611 return replaceInstUsesWith(Cmp, ConstantInt::getTrue(Cmp.getType()));
Sanjay Patela3f4f082016-08-16 17:54:36 +00001612 } else {
Sanjay Patel9b40f982016-09-07 22:33:03 +00001613 Cmp.setOperand(1, ConstantInt::get(And->getType(), NewCst));
1614 APInt NewAndCst = IsShl ? C2->lshr(*C3) : C2->shl(*C3);
1615 And->setOperand(1, ConstantInt::get(And->getType(), NewAndCst));
Sanjay Patelda9c5622016-08-26 17:15:22 +00001616 And->setOperand(0, Shift->getOperand(0));
1617 Worklist.Add(Shift); // Shift is dead.
1618 return &Cmp;
Sanjay Patela3f4f082016-08-16 17:54:36 +00001619 }
Sanjay Patelda9c5622016-08-26 17:15:22 +00001620 }
1621 }
Sanjay Patela3f4f082016-08-16 17:54:36 +00001622
Sanjay Patelda9c5622016-08-26 17:15:22 +00001623 // Turn ((X >> Y) & C2) == 0 into (X & (C2 << Y)) == 0. The latter is
1624 // preferable because it allows the C2 << Y expression to be hoisted out of a
1625 // loop if Y is invariant and X is not.
Sanjay Patel14e0e182016-08-26 18:28:46 +00001626 if (Shift->hasOneUse() && *C1 == 0 && Cmp.isEquality() &&
Sanjay Patelda9c5622016-08-26 17:15:22 +00001627 !Shift->isArithmeticShift() && !isa<Constant>(Shift->getOperand(0))) {
1628 // Compute C2 << Y.
Sanjay Patel9b40f982016-09-07 22:33:03 +00001629 Value *NewShift =
1630 IsShl ? Builder->CreateLShr(And->getOperand(1), Shift->getOperand(1))
1631 : Builder->CreateShl(And->getOperand(1), Shift->getOperand(1));
Sanjay Patela3f4f082016-08-16 17:54:36 +00001632
Sanjay Patelda9c5622016-08-26 17:15:22 +00001633 // Compute X & (C2 << Y).
Sanjay Patel9b40f982016-09-07 22:33:03 +00001634 Value *NewAnd = Builder->CreateAnd(Shift->getOperand(0), NewShift);
Sanjay Patelda9c5622016-08-26 17:15:22 +00001635 Cmp.setOperand(0, NewAnd);
1636 return &Cmp;
1637 }
1638
Sanjay Patel14e0e182016-08-26 18:28:46 +00001639 return nullptr;
1640}
1641
1642/// Fold icmp (and X, C2), C1.
1643Instruction *InstCombiner::foldICmpAndConstConst(ICmpInst &Cmp,
1644 BinaryOperator *And,
1645 const APInt *C1) {
Sanjay Patel6b490972016-09-04 14:32:15 +00001646 const APInt *C2;
1647 if (!match(And->getOperand(1), m_APInt(C2)))
Sanjay Patel14e0e182016-08-26 18:28:46 +00001648 return nullptr;
1649
1650 if (!And->hasOneUse() || !And->getOperand(0)->hasOneUse())
1651 return nullptr;
1652
Sanjay Patel6b490972016-09-04 14:32:15 +00001653 // If the LHS is an 'and' of a truncate and we can widen the and/compare to
1654 // the input width without changing the value produced, eliminate the cast:
1655 //
1656 // icmp (and (trunc W), C2), C1 -> icmp (and W, C2'), C1'
1657 //
1658 // We can do this transformation if the constants do not have their sign bits
1659 // set or if it is an equality comparison. Extending a relational comparison
1660 // when we're checking the sign bit would not work.
1661 Value *W;
1662 if (match(And->getOperand(0), m_Trunc(m_Value(W))) &&
1663 (Cmp.isEquality() || (!C1->isNegative() && !C2->isNegative()))) {
1664 // TODO: Is this a good transform for vectors? Wider types may reduce
1665 // throughput. Should this transform be limited (even for scalars) by using
Sanjay Patel2217f752017-01-31 17:25:42 +00001666 // shouldChangeType()?
Sanjay Patel6b490972016-09-04 14:32:15 +00001667 if (!Cmp.getType()->isVectorTy()) {
1668 Type *WideType = W->getType();
1669 unsigned WideScalarBits = WideType->getScalarSizeInBits();
1670 Constant *ZextC1 = ConstantInt::get(WideType, C1->zext(WideScalarBits));
1671 Constant *ZextC2 = ConstantInt::get(WideType, C2->zext(WideScalarBits));
1672 Value *NewAnd = Builder->CreateAnd(W, ZextC2, And->getName());
1673 return new ICmpInst(Cmp.getPredicate(), NewAnd, ZextC1);
Sanjay Patel14e0e182016-08-26 18:28:46 +00001674 }
1675 }
1676
Sanjay Patel9b40f982016-09-07 22:33:03 +00001677 if (Instruction *I = foldICmpAndShift(Cmp, And, C1, C2))
Sanjay Patel14e0e182016-08-26 18:28:46 +00001678 return I;
1679
Sanjay Patelda9c5622016-08-26 17:15:22 +00001680 // (icmp pred (and (or (lshr A, B), A), 1), 0) -->
Sanjay Patel6b490972016-09-04 14:32:15 +00001681 // (icmp pred (and A, (or (shl 1, B), 1), 0))
Sanjay Patelda9c5622016-08-26 17:15:22 +00001682 //
1683 // iff pred isn't signed
Sanjay Pateldef931e2016-09-07 20:50:44 +00001684 if (!Cmp.isSigned() && *C1 == 0 && match(And->getOperand(1), m_One())) {
1685 Constant *One = cast<Constant>(And->getOperand(1));
1686 Value *Or = And->getOperand(0);
Sanjay Patelda9c5622016-08-26 17:15:22 +00001687 Value *A, *B, *LShr;
Sanjay Pateldef931e2016-09-07 20:50:44 +00001688 if (match(Or, m_Or(m_Value(LShr), m_Value(A))) &&
1689 match(LShr, m_LShr(m_Specific(A), m_Value(B)))) {
1690 unsigned UsesRemoved = 0;
1691 if (And->hasOneUse())
1692 ++UsesRemoved;
1693 if (Or->hasOneUse())
1694 ++UsesRemoved;
1695 if (LShr->hasOneUse())
1696 ++UsesRemoved;
1697
1698 // Compute A & ((1 << B) | 1)
1699 Value *NewOr = nullptr;
1700 if (auto *C = dyn_cast<Constant>(B)) {
1701 if (UsesRemoved >= 1)
1702 NewOr = ConstantExpr::getOr(ConstantExpr::getNUWShl(One, C), One);
1703 } else {
1704 if (UsesRemoved >= 3)
1705 NewOr = Builder->CreateOr(Builder->CreateShl(One, B, LShr->getName(),
Sanjay Patelda9c5622016-08-26 17:15:22 +00001706 /*HasNUW=*/true),
1707 One, Or->getName());
Sanjay Pateldef931e2016-09-07 20:50:44 +00001708 }
1709 if (NewOr) {
1710 Value *NewAnd = Builder->CreateAnd(A, NewOr, And->getName());
1711 Cmp.setOperand(0, NewAnd);
1712 return &Cmp;
Sanjay Patela3f4f082016-08-16 17:54:36 +00001713 }
1714 }
Sanjay Patela3f4f082016-08-16 17:54:36 +00001715 }
Sanjay Patelda9c5622016-08-26 17:15:22 +00001716
Sanjay Pateldef931e2016-09-07 20:50:44 +00001717 // (X & C2) > C1 --> (X & C2) != 0, if any bit set in (X & C2) will produce a
1718 // result greater than C1.
1719 unsigned NumTZ = C2->countTrailingZeros();
1720 if (Cmp.getPredicate() == ICmpInst::ICMP_UGT && NumTZ < C2->getBitWidth() &&
1721 APInt::getOneBitSet(C2->getBitWidth(), NumTZ).ugt(*C1)) {
1722 Constant *Zero = Constant::getNullValue(And->getType());
1723 return new ICmpInst(ICmpInst::ICMP_NE, And, Zero);
Sanjay Patelda9c5622016-08-26 17:15:22 +00001724 }
1725
Sanjay Pateld3c7bb282016-08-26 16:42:33 +00001726 return nullptr;
1727}
1728
1729/// Fold icmp (and X, Y), C.
1730Instruction *InstCombiner::foldICmpAndConstant(ICmpInst &Cmp,
1731 BinaryOperator *And,
1732 const APInt *C) {
1733 if (Instruction *I = foldICmpAndConstConst(Cmp, And, C))
1734 return I;
1735
Sanjay Patel5c5311f2016-08-28 18:18:00 +00001736 // TODO: These all require that Y is constant too, so refactor with the above.
Sanjay Patela3f4f082016-08-16 17:54:36 +00001737
Sanjay Patel5c5311f2016-08-28 18:18:00 +00001738 // Try to optimize things like "A[i] & 42 == 0" to index computations.
1739 Value *X = And->getOperand(0);
1740 Value *Y = And->getOperand(1);
1741 if (auto *LI = dyn_cast<LoadInst>(X))
1742 if (auto *GEP = dyn_cast<GetElementPtrInst>(LI->getOperand(0)))
1743 if (auto *GV = dyn_cast<GlobalVariable>(GEP->getOperand(0)))
Sanjay Patela3f4f082016-08-16 17:54:36 +00001744 if (GV->isConstant() && GV->hasDefinitiveInitializer() &&
Sanjay Patel5c5311f2016-08-28 18:18:00 +00001745 !LI->isVolatile() && isa<ConstantInt>(Y)) {
1746 ConstantInt *C2 = cast<ConstantInt>(Y);
1747 if (Instruction *Res = foldCmpLoadFromIndexedGlobal(GEP, GV, Cmp, C2))
Sanjay Patela3f4f082016-08-16 17:54:36 +00001748 return Res;
1749 }
Sanjay Patel5c5311f2016-08-28 18:18:00 +00001750
1751 if (!Cmp.isEquality())
1752 return nullptr;
Sanjay Patela3f4f082016-08-16 17:54:36 +00001753
1754 // X & -C == -C -> X > u ~C
1755 // X & -C != -C -> X <= u ~C
1756 // iff C is a power of 2
Sanjay Patel5c5311f2016-08-28 18:18:00 +00001757 if (Cmp.getOperand(1) == Y && (-(*C)).isPowerOf2()) {
1758 auto NewPred = Cmp.getPredicate() == CmpInst::ICMP_EQ ? CmpInst::ICMP_UGT
1759 : CmpInst::ICMP_ULE;
1760 return new ICmpInst(NewPred, X, SubOne(cast<Constant>(Cmp.getOperand(1))));
1761 }
Sanjay Patela3f4f082016-08-16 17:54:36 +00001762
Sanjay Patel5c5311f2016-08-28 18:18:00 +00001763 // (X & C2) == 0 -> (trunc X) >= 0
1764 // (X & C2) != 0 -> (trunc X) < 0
1765 // iff C2 is a power of 2 and it masks the sign bit of a legal integer type.
1766 const APInt *C2;
1767 if (And->hasOneUse() && *C == 0 && match(Y, m_APInt(C2))) {
1768 int32_t ExactLogBase2 = C2->exactLogBase2();
1769 if (ExactLogBase2 != -1 && DL.isLegalInteger(ExactLogBase2 + 1)) {
1770 Type *NTy = IntegerType::get(Cmp.getContext(), ExactLogBase2 + 1);
1771 if (And->getType()->isVectorTy())
1772 NTy = VectorType::get(NTy, And->getType()->getVectorNumElements());
1773 Value *Trunc = Builder->CreateTrunc(X, NTy);
1774 auto NewPred = Cmp.getPredicate() == CmpInst::ICMP_EQ ? CmpInst::ICMP_SGE
1775 : CmpInst::ICMP_SLT;
1776 return new ICmpInst(NewPred, Trunc, Constant::getNullValue(NTy));
Sanjay Patela3f4f082016-08-16 17:54:36 +00001777 }
1778 }
Sanjay Patel5c5311f2016-08-28 18:18:00 +00001779
Sanjay Patela3f4f082016-08-16 17:54:36 +00001780 return nullptr;
1781}
1782
Sanjay Patel943e92e2016-08-17 16:30:43 +00001783/// Fold icmp (or X, Y), C.
Sanjay Patelc9196c42016-08-22 21:24:29 +00001784Instruction *InstCombiner::foldICmpOrConstant(ICmpInst &Cmp, BinaryOperator *Or,
Sanjay Patel943e92e2016-08-17 16:30:43 +00001785 const APInt *C) {
Sanjay Patel943e92e2016-08-17 16:30:43 +00001786 ICmpInst::Predicate Pred = Cmp.getPredicate();
1787 if (*C == 1) {
Sanjay Patela3f4f082016-08-16 17:54:36 +00001788 // icmp slt signum(V) 1 --> icmp slt V, 1
1789 Value *V = nullptr;
Sanjay Patel943e92e2016-08-17 16:30:43 +00001790 if (Pred == ICmpInst::ICMP_SLT && match(Or, m_Signum(m_Value(V))))
Sanjay Patela3f4f082016-08-16 17:54:36 +00001791 return new ICmpInst(ICmpInst::ICMP_SLT, V,
1792 ConstantInt::get(V->getType(), 1));
1793 }
1794
Sanjay Patel50c82c42017-04-05 17:57:05 +00001795 // X | C == C --> X <=u C
1796 // X | C != C --> X >u C
1797 // iff C+1 is a power of 2 (C is a bitmask of the low bits)
1798 if (Cmp.isEquality() && Cmp.getOperand(1) == Or->getOperand(1) &&
1799 (*C + 1).isPowerOf2()) {
1800 Pred = (Pred == CmpInst::ICMP_EQ) ? CmpInst::ICMP_ULE : CmpInst::ICMP_UGT;
1801 return new ICmpInst(Pred, Or->getOperand(0), Or->getOperand(1));
1802 }
1803
Sanjay Patel943e92e2016-08-17 16:30:43 +00001804 if (!Cmp.isEquality() || *C != 0 || !Or->hasOneUse())
Sanjay Patela3f4f082016-08-16 17:54:36 +00001805 return nullptr;
1806
1807 Value *P, *Q;
Sanjay Patel943e92e2016-08-17 16:30:43 +00001808 if (match(Or, m_Or(m_PtrToInt(m_Value(P)), m_PtrToInt(m_Value(Q))))) {
Sanjay Patela3f4f082016-08-16 17:54:36 +00001809 // Simplify icmp eq (or (ptrtoint P), (ptrtoint Q)), 0
1810 // -> and (icmp eq P, null), (icmp eq Q, null).
Reid Klecknera871d382016-08-19 16:53:18 +00001811 Value *CmpP =
1812 Builder->CreateICmp(Pred, P, ConstantInt::getNullValue(P->getType()));
1813 Value *CmpQ =
1814 Builder->CreateICmp(Pred, Q, ConstantInt::getNullValue(Q->getType()));
Sanjay Patel943e92e2016-08-17 16:30:43 +00001815 auto LogicOpc = Pred == ICmpInst::Predicate::ICMP_EQ ? Instruction::And
1816 : Instruction::Or;
1817 return BinaryOperator::Create(LogicOpc, CmpP, CmpQ);
Sanjay Patela3f4f082016-08-16 17:54:36 +00001818 }
Sanjay Patel943e92e2016-08-17 16:30:43 +00001819
Sanjay Patela3f4f082016-08-16 17:54:36 +00001820 return nullptr;
1821}
1822
Sanjay Patel63478072016-08-18 15:44:44 +00001823/// Fold icmp (mul X, Y), C.
Sanjay Patelc9196c42016-08-22 21:24:29 +00001824Instruction *InstCombiner::foldICmpMulConstant(ICmpInst &Cmp,
1825 BinaryOperator *Mul,
Sanjay Patel63478072016-08-18 15:44:44 +00001826 const APInt *C) {
1827 const APInt *MulC;
1828 if (!match(Mul->getOperand(1), m_APInt(MulC)))
Sanjay Patela3f4f082016-08-16 17:54:36 +00001829 return nullptr;
1830
Sanjay Patel63478072016-08-18 15:44:44 +00001831 // If this is a test of the sign bit and the multiply is sign-preserving with
1832 // a constant operand, use the multiply LHS operand instead.
1833 ICmpInst::Predicate Pred = Cmp.getPredicate();
Sanjay Patelc9196c42016-08-22 21:24:29 +00001834 if (isSignTest(Pred, *C) && Mul->hasNoSignedWrap()) {
Sanjay Patel63478072016-08-18 15:44:44 +00001835 if (MulC->isNegative())
1836 Pred = ICmpInst::getSwappedPredicate(Pred);
1837 return new ICmpInst(Pred, Mul->getOperand(0),
1838 Constant::getNullValue(Mul->getType()));
1839 }
Sanjay Patela3f4f082016-08-16 17:54:36 +00001840
1841 return nullptr;
1842}
1843
Sanjay Patel98cd99d2016-08-18 21:28:30 +00001844/// Fold icmp (shl 1, Y), C.
1845static Instruction *foldICmpShlOne(ICmpInst &Cmp, Instruction *Shl,
1846 const APInt *C) {
1847 Value *Y;
1848 if (!match(Shl, m_Shl(m_One(), m_Value(Y))))
1849 return nullptr;
1850
1851 Type *ShiftType = Shl->getType();
1852 uint32_t TypeBits = C->getBitWidth();
1853 bool CIsPowerOf2 = C->isPowerOf2();
1854 ICmpInst::Predicate Pred = Cmp.getPredicate();
1855 if (Cmp.isUnsigned()) {
1856 // (1 << Y) pred C -> Y pred Log2(C)
1857 if (!CIsPowerOf2) {
1858 // (1 << Y) < 30 -> Y <= 4
1859 // (1 << Y) <= 30 -> Y <= 4
1860 // (1 << Y) >= 30 -> Y > 4
1861 // (1 << Y) > 30 -> Y > 4
1862 if (Pred == ICmpInst::ICMP_ULT)
1863 Pred = ICmpInst::ICMP_ULE;
1864 else if (Pred == ICmpInst::ICMP_UGE)
1865 Pred = ICmpInst::ICMP_UGT;
1866 }
1867
1868 // (1 << Y) >= 2147483648 -> Y >= 31 -> Y == 31
1869 // (1 << Y) < 2147483648 -> Y < 31 -> Y != 31
1870 unsigned CLog2 = C->logBase2();
1871 if (CLog2 == TypeBits - 1) {
1872 if (Pred == ICmpInst::ICMP_UGE)
1873 Pred = ICmpInst::ICMP_EQ;
1874 else if (Pred == ICmpInst::ICMP_ULT)
1875 Pred = ICmpInst::ICMP_NE;
1876 }
1877 return new ICmpInst(Pred, Y, ConstantInt::get(ShiftType, CLog2));
1878 } else if (Cmp.isSigned()) {
1879 Constant *BitWidthMinusOne = ConstantInt::get(ShiftType, TypeBits - 1);
1880 if (C->isAllOnesValue()) {
1881 // (1 << Y) <= -1 -> Y == 31
1882 if (Pred == ICmpInst::ICMP_SLE)
1883 return new ICmpInst(ICmpInst::ICMP_EQ, Y, BitWidthMinusOne);
1884
1885 // (1 << Y) > -1 -> Y != 31
1886 if (Pred == ICmpInst::ICMP_SGT)
1887 return new ICmpInst(ICmpInst::ICMP_NE, Y, BitWidthMinusOne);
1888 } else if (!(*C)) {
1889 // (1 << Y) < 0 -> Y == 31
1890 // (1 << Y) <= 0 -> Y == 31
1891 if (Pred == ICmpInst::ICMP_SLT || Pred == ICmpInst::ICMP_SLE)
1892 return new ICmpInst(ICmpInst::ICMP_EQ, Y, BitWidthMinusOne);
1893
1894 // (1 << Y) >= 0 -> Y != 31
1895 // (1 << Y) > 0 -> Y != 31
1896 if (Pred == ICmpInst::ICMP_SGT || Pred == ICmpInst::ICMP_SGE)
1897 return new ICmpInst(ICmpInst::ICMP_NE, Y, BitWidthMinusOne);
1898 }
1899 } else if (Cmp.isEquality() && CIsPowerOf2) {
1900 return new ICmpInst(Pred, Y, ConstantInt::get(ShiftType, C->logBase2()));
1901 }
1902
1903 return nullptr;
1904}
1905
Sanjay Patel38b75062016-08-19 17:20:37 +00001906/// Fold icmp (shl X, Y), C.
Sanjay Patelc9196c42016-08-22 21:24:29 +00001907Instruction *InstCombiner::foldICmpShlConstant(ICmpInst &Cmp,
1908 BinaryOperator *Shl,
Sanjay Patel38b75062016-08-19 17:20:37 +00001909 const APInt *C) {
Sanjay Patel8da42cc2016-09-15 22:26:31 +00001910 const APInt *ShiftVal;
1911 if (Cmp.isEquality() && match(Shl->getOperand(0), m_APInt(ShiftVal)))
1912 return foldICmpShlConstConst(Cmp, Shl->getOperand(1), *C, *ShiftVal);
1913
Sanjay Patelfa7de602016-08-19 22:33:26 +00001914 const APInt *ShiftAmt;
1915 if (!match(Shl->getOperand(1), m_APInt(ShiftAmt)))
Sanjay Patel38b75062016-08-19 17:20:37 +00001916 return foldICmpShlOne(Cmp, Shl, C);
Sanjay Patela867afe2016-08-19 16:12:16 +00001917
Sanjay Patel38b75062016-08-19 17:20:37 +00001918 // Check that the shift amount is in range. If not, don't perform undefined
Sanjay Patel940c0612017-01-09 16:27:56 +00001919 // shifts. When the shift is visited, it will be simplified.
Sanjay Patel38b75062016-08-19 17:20:37 +00001920 unsigned TypeBits = C->getBitWidth();
Sanjay Patelfa7de602016-08-19 22:33:26 +00001921 if (ShiftAmt->uge(TypeBits))
Sanjay Patela3f4f082016-08-16 17:54:36 +00001922 return nullptr;
1923
Sanjay Patele38e79c2016-08-19 17:34:05 +00001924 ICmpInst::Predicate Pred = Cmp.getPredicate();
1925 Value *X = Shl->getOperand(0);
Sanjay Patel14715b32017-01-17 21:25:16 +00001926 Type *ShType = Shl->getType();
1927
Sanjay Patel291c3d82017-01-19 16:12:10 +00001928 // NSW guarantees that we are only shifting out sign bits from the high bits,
1929 // so we can ASHR the compare constant without needing a mask and eliminate
1930 // the shift.
1931 if (Shl->hasNoSignedWrap()) {
1932 if (Pred == ICmpInst::ICMP_SGT) {
1933 // icmp Pred (shl nsw X, ShiftAmt), C --> icmp Pred X, (C >>s ShiftAmt)
1934 APInt ShiftedC = C->ashr(*ShiftAmt);
1935 return new ICmpInst(Pred, X, ConstantInt::get(ShType, ShiftedC));
1936 }
1937 if (Pred == ICmpInst::ICMP_EQ || Pred == ICmpInst::ICMP_NE) {
1938 // This is the same code as the SGT case, but assert the pre-condition
1939 // that is needed for this to work with equality predicates.
1940 assert(C->ashr(*ShiftAmt).shl(*ShiftAmt) == *C &&
1941 "Compare known true or false was not folded");
1942 APInt ShiftedC = C->ashr(*ShiftAmt);
1943 return new ICmpInst(Pred, X, ConstantInt::get(ShType, ShiftedC));
1944 }
1945 if (Pred == ICmpInst::ICMP_SLT) {
1946 // SLE is the same as above, but SLE is canonicalized to SLT, so convert:
1947 // (X << S) <=s C is equiv to X <=s (C >> S) for all C
1948 // (X << S) <s (C + 1) is equiv to X <s (C >> S) + 1 if C <s SMAX
1949 // (X << S) <s C is equiv to X <s ((C - 1) >> S) + 1 if C >s SMIN
1950 assert(!C->isMinSignedValue() && "Unexpected icmp slt");
1951 APInt ShiftedC = (*C - 1).ashr(*ShiftAmt) + 1;
1952 return new ICmpInst(Pred, X, ConstantInt::get(ShType, ShiftedC));
1953 }
1954 // If this is a signed comparison to 0 and the shift is sign preserving,
1955 // use the shift LHS operand instead; isSignTest may change 'Pred', so only
1956 // do that if we're sure to not continue on in this function.
1957 if (isSignTest(Pred, *C))
1958 return new ICmpInst(Pred, X, Constant::getNullValue(ShType));
1959 }
Sanjay Patel14715b32017-01-17 21:25:16 +00001960
Sanjay Patel291c3d82017-01-19 16:12:10 +00001961 // NUW guarantees that we are only shifting out zero bits from the high bits,
1962 // so we can LSHR the compare constant without needing a mask and eliminate
1963 // the shift.
Sanjay Patel14715b32017-01-17 21:25:16 +00001964 if (Shl->hasNoUnsignedWrap()) {
Sanjay Patelae23d652017-01-18 21:16:12 +00001965 if (Pred == ICmpInst::ICMP_UGT) {
Sanjay Patel14715b32017-01-17 21:25:16 +00001966 // icmp Pred (shl nuw X, ShiftAmt), C --> icmp Pred X, (C >>u ShiftAmt)
1967 APInt ShiftedC = C->lshr(*ShiftAmt);
1968 return new ICmpInst(Pred, X, ConstantInt::get(ShType, ShiftedC));
1969 }
Sanjay Patelae23d652017-01-18 21:16:12 +00001970 if (Pred == ICmpInst::ICMP_EQ || Pred == ICmpInst::ICMP_NE) {
1971 // This is the same code as the UGT case, but assert the pre-condition
1972 // that is needed for this to work with equality predicates.
1973 assert(C->lshr(*ShiftAmt).shl(*ShiftAmt) == *C &&
1974 "Compare known true or false was not folded");
1975 APInt ShiftedC = C->lshr(*ShiftAmt);
1976 return new ICmpInst(Pred, X, ConstantInt::get(ShType, ShiftedC));
1977 }
Sanjay Patel14715b32017-01-17 21:25:16 +00001978 if (Pred == ICmpInst::ICMP_ULT) {
1979 // ULE is the same as above, but ULE is canonicalized to ULT, so convert:
1980 // (X << S) <=u C is equiv to X <=u (C >> S) for all C
1981 // (X << S) <u (C + 1) is equiv to X <u (C >> S) + 1 if C <u ~0u
1982 // (X << S) <u C is equiv to X <u ((C - 1) >> S) + 1 if C >u 0
1983 assert(C->ugt(0) && "ult 0 should have been eliminated");
1984 APInt ShiftedC = (*C - 1).lshr(*ShiftAmt) + 1;
1985 return new ICmpInst(Pred, X, ConstantInt::get(ShType, ShiftedC));
1986 }
1987 }
1988
Sanjay Patel291c3d82017-01-19 16:12:10 +00001989 if (Cmp.isEquality() && Shl->hasOneUse()) {
1990 // Strength-reduce the shift into an 'and'.
1991 Constant *Mask = ConstantInt::get(
1992 ShType,
1993 APInt::getLowBitsSet(TypeBits, TypeBits - ShiftAmt->getZExtValue()));
1994 Value *And = Builder->CreateAnd(X, Mask, Shl->getName() + ".mask");
Sanjay Patel14715b32017-01-17 21:25:16 +00001995 Constant *LShrC = ConstantInt::get(ShType, C->lshr(*ShiftAmt));
Sanjay Patel291c3d82017-01-19 16:12:10 +00001996 return new ICmpInst(Pred, And, LShrC);
Sanjay Patela3f4f082016-08-16 17:54:36 +00001997 }
1998
Sanjay Patela3f4f082016-08-16 17:54:36 +00001999 // Otherwise, if this is a comparison of the sign bit, simplify to and/test.
2000 bool TrueIfSigned = false;
Sanjay Patel79263662016-08-21 15:07:45 +00002001 if (Shl->hasOneUse() && isSignBitCheck(Pred, *C, TrueIfSigned)) {
Sanjay Patel7ffcde72016-08-21 16:35:34 +00002002 // (X << 31) <s 0 --> (X & 1) != 0
Sanjay Patela3f4f082016-08-16 17:54:36 +00002003 Constant *Mask = ConstantInt::get(
Sanjay Patel14715b32017-01-17 21:25:16 +00002004 ShType,
Sanjay Patelfa7de602016-08-19 22:33:26 +00002005 APInt::getOneBitSet(TypeBits, TypeBits - ShiftAmt->getZExtValue() - 1));
Sanjay Patele38e79c2016-08-19 17:34:05 +00002006 Value *And = Builder->CreateAnd(X, Mask, Shl->getName() + ".mask");
Sanjay Patela3f4f082016-08-16 17:54:36 +00002007 return new ICmpInst(TrueIfSigned ? ICmpInst::ICMP_NE : ICmpInst::ICMP_EQ,
Sanjay Patel14715b32017-01-17 21:25:16 +00002008 And, Constant::getNullValue(ShType));
Sanjay Patelc0339c72016-11-01 19:19:29 +00002009 }
2010
Sanjay Patel643d21a2016-08-21 17:10:07 +00002011 // Transform (icmp pred iM (shl iM %v, N), C)
2012 // -> (icmp pred i(M-N) (trunc %v iM to i(M-N)), (trunc (C>>N))
2013 // Transform the shl to a trunc if (trunc (C>>N)) has no loss and M-N.
Sanjay Patel940c0612017-01-09 16:27:56 +00002014 // This enables us to get rid of the shift in favor of a trunc that may be
Sanjay Patela3f4f082016-08-16 17:54:36 +00002015 // free on the target. It has the additional benefit of comparing to a
Sanjay Patel940c0612017-01-09 16:27:56 +00002016 // smaller constant that may be more target-friendly.
Sanjay Patelfa7de602016-08-19 22:33:26 +00002017 unsigned Amt = ShiftAmt->getLimitedValue(TypeBits - 1);
Sanjay Patelf3dda132016-10-25 20:11:47 +00002018 if (Shl->hasOneUse() && Amt != 0 && C->countTrailingZeros() >= Amt &&
2019 DL.isLegalInteger(TypeBits - Amt)) {
Sanjay Patel643d21a2016-08-21 17:10:07 +00002020 Type *TruncTy = IntegerType::get(Cmp.getContext(), TypeBits - Amt);
Sanjay Patel14715b32017-01-17 21:25:16 +00002021 if (ShType->isVectorTy())
2022 TruncTy = VectorType::get(TruncTy, ShType->getVectorNumElements());
Sanjay Patel643d21a2016-08-21 17:10:07 +00002023 Constant *NewC =
2024 ConstantInt::get(TruncTy, C->ashr(*ShiftAmt).trunc(TypeBits - Amt));
2025 return new ICmpInst(Pred, Builder->CreateTrunc(X, TruncTy), NewC);
Sanjay Patela3f4f082016-08-16 17:54:36 +00002026 }
2027
2028 return nullptr;
2029}
2030
Sanjay Patela3920492016-08-22 20:45:06 +00002031/// Fold icmp ({al}shr X, Y), C.
Sanjay Patelc9196c42016-08-22 21:24:29 +00002032Instruction *InstCombiner::foldICmpShrConstant(ICmpInst &Cmp,
2033 BinaryOperator *Shr,
2034 const APInt *C) {
Sanjay Patela3920492016-08-22 20:45:06 +00002035 // An exact shr only shifts out zero bits, so:
2036 // icmp eq/ne (shr X, Y), 0 --> icmp eq/ne X, 0
Sanjay Pateld64e9882016-08-23 22:05:55 +00002037 Value *X = Shr->getOperand(0);
Sanjay Patelc9196c42016-08-22 21:24:29 +00002038 CmpInst::Predicate Pred = Cmp.getPredicate();
2039 if (Cmp.isEquality() && Shr->isExact() && Shr->hasOneUse() && *C == 0)
Sanjay Pateld64e9882016-08-23 22:05:55 +00002040 return new ICmpInst(Pred, X, Cmp.getOperand(1));
Sanjay Patela3920492016-08-22 20:45:06 +00002041
Sanjay Patel8da42cc2016-09-15 22:26:31 +00002042 const APInt *ShiftVal;
2043 if (Cmp.isEquality() && match(Shr->getOperand(0), m_APInt(ShiftVal)))
2044 return foldICmpShrConstConst(Cmp, Shr->getOperand(1), *C, *ShiftVal);
2045
Sanjay Pateld398d4a2016-08-24 22:22:06 +00002046 const APInt *ShiftAmt;
2047 if (!match(Shr->getOperand(1), m_APInt(ShiftAmt)))
Sanjay Patela3f4f082016-08-16 17:54:36 +00002048 return nullptr;
2049
Sanjay Pateld398d4a2016-08-24 22:22:06 +00002050 // Check that the shift amount is in range. If not, don't perform undefined
2051 // shifts. When the shift is visited it will be simplified.
2052 unsigned TypeBits = C->getBitWidth();
2053 unsigned ShAmtVal = ShiftAmt->getLimitedValue(TypeBits);
Sanjay Pateldcac0df2016-08-23 21:25:13 +00002054 if (ShAmtVal >= TypeBits || ShAmtVal == 0)
2055 return nullptr;
2056
Sanjay Pateld64e9882016-08-23 22:05:55 +00002057 bool IsAShr = Shr->getOpcode() == Instruction::AShr;
Sanjay Pateldcac0df2016-08-23 21:25:13 +00002058 if (!Cmp.isEquality()) {
2059 // If we have an unsigned comparison and an ashr, we can't simplify this.
2060 // Similarly for signed comparisons with lshr.
Sanjay Pateld64e9882016-08-23 22:05:55 +00002061 if (Cmp.isSigned() != IsAShr)
Sanjay Pateldcac0df2016-08-23 21:25:13 +00002062 return nullptr;
2063
2064 // Otherwise, all lshr and most exact ashr's are equivalent to a udiv/sdiv
2065 // by a power of 2. Since we already have logic to simplify these,
2066 // transform to div and then simplify the resultant comparison.
Sanjay Pateld64e9882016-08-23 22:05:55 +00002067 if (IsAShr && (!Shr->isExact() || ShAmtVal == TypeBits - 1))
Sanjay Pateldcac0df2016-08-23 21:25:13 +00002068 return nullptr;
2069
2070 // Revisit the shift (to delete it).
2071 Worklist.Add(Shr);
2072
2073 Constant *DivCst = ConstantInt::get(
2074 Shr->getType(), APInt::getOneBitSet(TypeBits, ShAmtVal));
2075
Sanjay Pateld64e9882016-08-23 22:05:55 +00002076 Value *Tmp = IsAShr ? Builder->CreateSDiv(X, DivCst, "", Shr->isExact())
2077 : Builder->CreateUDiv(X, DivCst, "", Shr->isExact());
Sanjay Pateldcac0df2016-08-23 21:25:13 +00002078
2079 Cmp.setOperand(0, Tmp);
2080
2081 // If the builder folded the binop, just return it.
2082 BinaryOperator *TheDiv = dyn_cast<BinaryOperator>(Tmp);
2083 if (!TheDiv)
2084 return &Cmp;
2085
2086 // Otherwise, fold this div/compare.
2087 assert(TheDiv->getOpcode() == Instruction::SDiv ||
2088 TheDiv->getOpcode() == Instruction::UDiv);
2089
Sanjay Patelf7ba0892016-08-26 15:53:01 +00002090 Instruction *Res = foldICmpDivConstant(Cmp, TheDiv, C);
Sanjay Pateldcac0df2016-08-23 21:25:13 +00002091 assert(Res && "This div/cst should have folded!");
Sanjay Patela3920492016-08-22 20:45:06 +00002092 return Res;
Sanjay Pateldcac0df2016-08-23 21:25:13 +00002093 }
2094
Sanjay Pateld398d4a2016-08-24 22:22:06 +00002095 // Handle equality comparisons of shift-by-constant.
2096
Sanjay Patel8e297742016-08-24 13:55:55 +00002097 // If the comparison constant changes with the shift, the comparison cannot
2098 // succeed (bits of the comparison constant cannot match the shifted value).
2099 // This should be known by InstSimplify and already be folded to true/false.
2100 assert(((IsAShr && C->shl(ShAmtVal).ashr(ShAmtVal) == *C) ||
2101 (!IsAShr && C->shl(ShAmtVal).lshr(ShAmtVal) == *C)) &&
2102 "Expected icmp+shr simplify did not occur.");
2103
Sanjay Pateldcac0df2016-08-23 21:25:13 +00002104 // Check if the bits shifted out are known to be zero. If so, we can compare
2105 // against the unshifted value:
2106 // (X & 4) >> 1 == 2 --> (X & 4) == 4.
Sanjay Pateld398d4a2016-08-24 22:22:06 +00002107 Constant *ShiftedCmpRHS = ConstantInt::get(Shr->getType(), *C << ShAmtVal);
Sanjay Pateldcac0df2016-08-23 21:25:13 +00002108 if (Shr->hasOneUse()) {
Sanjay Pateld398d4a2016-08-24 22:22:06 +00002109 if (Shr->isExact())
2110 return new ICmpInst(Pred, X, ShiftedCmpRHS);
Sanjay Pateldcac0df2016-08-23 21:25:13 +00002111
Sanjay Pateld398d4a2016-08-24 22:22:06 +00002112 // Otherwise strength reduce the shift into an 'and'.
2113 APInt Val(APInt::getHighBitsSet(TypeBits, TypeBits - ShAmtVal));
2114 Constant *Mask = ConstantInt::get(Shr->getType(), Val);
Sanjay Pateld64e9882016-08-23 22:05:55 +00002115 Value *And = Builder->CreateAnd(X, Mask, Shr->getName() + ".mask");
Sanjay Pateldcac0df2016-08-23 21:25:13 +00002116 return new ICmpInst(Pred, And, ShiftedCmpRHS);
2117 }
Sanjay Patela3f4f082016-08-16 17:54:36 +00002118
2119 return nullptr;
2120}
2121
Sanjay Patel12a41052016-08-18 17:37:26 +00002122/// Fold icmp (udiv X, Y), C.
2123Instruction *InstCombiner::foldICmpUDivConstant(ICmpInst &Cmp,
Sanjay Patelc9196c42016-08-22 21:24:29 +00002124 BinaryOperator *UDiv,
Sanjay Patel12a41052016-08-18 17:37:26 +00002125 const APInt *C) {
Sanjay Patelfa5ca2b2016-08-18 17:55:59 +00002126 const APInt *C2;
2127 if (!match(UDiv->getOperand(0), m_APInt(C2)))
2128 return nullptr;
2129
2130 assert(C2 != 0 && "udiv 0, X should have been simplified already.");
2131
2132 // (icmp ugt (udiv C2, Y), C) -> (icmp ule Y, C2/(C+1))
2133 Value *Y = UDiv->getOperand(1);
2134 if (Cmp.getPredicate() == ICmpInst::ICMP_UGT) {
2135 assert(!C->isMaxValue() &&
2136 "icmp ugt X, UINT_MAX should have been simplified already.");
2137 return new ICmpInst(ICmpInst::ICMP_ULE, Y,
2138 ConstantInt::get(Y->getType(), C2->udiv(*C + 1)));
2139 }
2140
2141 // (icmp ult (udiv C2, Y), C) -> (icmp ugt Y, C2/C)
2142 if (Cmp.getPredicate() == ICmpInst::ICMP_ULT) {
2143 assert(C != 0 && "icmp ult X, 0 should have been simplified already.");
2144 return new ICmpInst(ICmpInst::ICMP_UGT, Y,
2145 ConstantInt::get(Y->getType(), C2->udiv(*C)));
Sanjay Patela3f4f082016-08-16 17:54:36 +00002146 }
2147
2148 return nullptr;
2149}
2150
Sanjay Patelf7ba0892016-08-26 15:53:01 +00002151/// Fold icmp ({su}div X, Y), C.
2152Instruction *InstCombiner::foldICmpDivConstant(ICmpInst &Cmp,
2153 BinaryOperator *Div,
2154 const APInt *C) {
Sanjay Patela7cb4772016-08-30 17:10:49 +00002155 // Fold: icmp pred ([us]div X, C2), C -> range test
Sanjay Patela3f4f082016-08-16 17:54:36 +00002156 // Fold this div into the comparison, producing a range check.
2157 // Determine, based on the divide type, what the range is being
2158 // checked. If there is an overflow on the low or high side, remember
2159 // it, otherwise compute the range [low, hi) bounding the new value.
2160 // See: InsertRangeTest above for the kinds of replacements possible.
Sanjay Patela7cb4772016-08-30 17:10:49 +00002161 const APInt *C2;
2162 if (!match(Div->getOperand(1), m_APInt(C2)))
Sanjay Patel16554142016-08-24 23:03:36 +00002163 return nullptr;
2164
Sanjay Patel16554142016-08-24 23:03:36 +00002165 // FIXME: If the operand types don't match the type of the divide
2166 // then don't attempt this transform. The code below doesn't have the
2167 // logic to deal with a signed divide and an unsigned compare (and
Sanjay Patela7cb4772016-08-30 17:10:49 +00002168 // vice versa). This is because (x /s C2) <s C produces different
2169 // results than (x /s C2) <u C or (x /u C2) <s C or even
2170 // (x /u C2) <u C. Simply casting the operands and result won't
Sanjay Patel16554142016-08-24 23:03:36 +00002171 // work. :( The if statement below tests that condition and bails
2172 // if it finds it.
Sanjay Patelf7ba0892016-08-26 15:53:01 +00002173 bool DivIsSigned = Div->getOpcode() == Instruction::SDiv;
2174 if (!Cmp.isEquality() && DivIsSigned != Cmp.isSigned())
Sanjay Patel16554142016-08-24 23:03:36 +00002175 return nullptr;
Sanjay Patela7cb4772016-08-30 17:10:49 +00002176
Sanjay Pateleea2ef72016-09-05 23:38:22 +00002177 // The ProdOV computation fails on divide by 0 and divide by -1. Cases with
2178 // INT_MIN will also fail if the divisor is 1. Although folds of all these
2179 // division-by-constant cases should be present, we can not assert that they
2180 // have happened before we reach this icmp instruction.
2181 if (*C2 == 0 || *C2 == 1 || (DivIsSigned && C2->isAllOnesValue()))
2182 return nullptr;
Sanjay Patelb3714572016-08-30 17:31:34 +00002183
Sanjay Patel541aef42016-08-31 21:57:21 +00002184 // TODO: We could do all of the computations below using APInt.
2185 Constant *CmpRHS = cast<Constant>(Cmp.getOperand(1));
2186 Constant *DivRHS = cast<Constant>(Div->getOperand(1));
Sanjay Patelb3714572016-08-30 17:31:34 +00002187
Sanjay Patel541aef42016-08-31 21:57:21 +00002188 // Compute Prod = CmpRHS * DivRHS. We are essentially solving an equation of
2189 // form X / C2 = C. We solve for X by multiplying C2 (DivRHS) and C (CmpRHS).
2190 // By solving for X, we can turn this into a range check instead of computing
2191 // a divide.
2192 Constant *Prod = ConstantExpr::getMul(CmpRHS, DivRHS);
Sanjay Patel16554142016-08-24 23:03:36 +00002193
Sanjay Patel541aef42016-08-31 21:57:21 +00002194 // Determine if the product overflows by seeing if the product is not equal to
2195 // the divide. Make sure we do the same kind of divide as in the LHS
2196 // instruction that we're folding.
2197 bool ProdOV = (DivIsSigned ? ConstantExpr::getSDiv(Prod, DivRHS)
2198 : ConstantExpr::getUDiv(Prod, DivRHS)) != CmpRHS;
Sanjay Patel16554142016-08-24 23:03:36 +00002199
Sanjay Patelf7ba0892016-08-26 15:53:01 +00002200 ICmpInst::Predicate Pred = Cmp.getPredicate();
Sanjay Patel16554142016-08-24 23:03:36 +00002201
2202 // If the division is known to be exact, then there is no remainder from the
2203 // divide, so the covered range size is unit, otherwise it is the divisor.
Sanjay Patel541aef42016-08-31 21:57:21 +00002204 Constant *RangeSize =
2205 Div->isExact() ? ConstantInt::get(Div->getType(), 1) : DivRHS;
Sanjay Patel16554142016-08-24 23:03:36 +00002206
2207 // Figure out the interval that is being checked. For example, a comparison
2208 // like "X /u 5 == 0" is really checking that X is in the interval [0, 5).
2209 // Compute this interval based on the constants involved and the signedness of
2210 // the compare/divide. This computes a half-open interval, keeping track of
2211 // whether either value in the interval overflows. After analysis each
2212 // overflow variable is set to 0 if it's corresponding bound variable is valid
2213 // -1 if overflowed off the bottom end, or +1 if overflowed off the top end.
2214 int LoOverflow = 0, HiOverflow = 0;
2215 Constant *LoBound = nullptr, *HiBound = nullptr;
2216
2217 if (!DivIsSigned) { // udiv
2218 // e.g. X/5 op 3 --> [15, 20)
2219 LoBound = Prod;
2220 HiOverflow = LoOverflow = ProdOV;
2221 if (!HiOverflow) {
2222 // If this is not an exact divide, then many values in the range collapse
2223 // to the same result value.
Sanjay Pateld93c4c02016-09-15 18:22:25 +00002224 HiOverflow = addWithOverflow(HiBound, LoBound, RangeSize, false);
Sanjay Patel16554142016-08-24 23:03:36 +00002225 }
Sanjay Patel541aef42016-08-31 21:57:21 +00002226 } else if (C2->isStrictlyPositive()) { // Divisor is > 0.
Sanjay Patelf7ba0892016-08-26 15:53:01 +00002227 if (*C == 0) { // (X / pos) op 0
Sanjay Patel16554142016-08-24 23:03:36 +00002228 // Can't overflow. e.g. X/2 op 0 --> [-1, 2)
2229 LoBound = ConstantExpr::getNeg(SubOne(RangeSize));
2230 HiBound = RangeSize;
Sanjay Patelf7ba0892016-08-26 15:53:01 +00002231 } else if (C->isStrictlyPositive()) { // (X / pos) op pos
Sanjay Patel16554142016-08-24 23:03:36 +00002232 LoBound = Prod; // e.g. X/5 op 3 --> [15, 20)
2233 HiOverflow = LoOverflow = ProdOV;
2234 if (!HiOverflow)
Sanjay Pateld93c4c02016-09-15 18:22:25 +00002235 HiOverflow = addWithOverflow(HiBound, Prod, RangeSize, true);
Sanjay Patel16554142016-08-24 23:03:36 +00002236 } else { // (X / pos) op neg
2237 // e.g. X/5 op -3 --> [-15-4, -15+1) --> [-19, -14)
2238 HiBound = AddOne(Prod);
2239 LoOverflow = HiOverflow = ProdOV ? -1 : 0;
2240 if (!LoOverflow) {
Sanjay Patel541aef42016-08-31 21:57:21 +00002241 Constant *DivNeg = ConstantExpr::getNeg(RangeSize);
Sanjay Pateld93c4c02016-09-15 18:22:25 +00002242 LoOverflow = addWithOverflow(LoBound, HiBound, DivNeg, true) ? -1 : 0;
Sanjay Patel16554142016-08-24 23:03:36 +00002243 }
2244 }
Sanjay Patel541aef42016-08-31 21:57:21 +00002245 } else if (C2->isNegative()) { // Divisor is < 0.
Sanjay Patelf7ba0892016-08-26 15:53:01 +00002246 if (Div->isExact())
Sanjay Patel541aef42016-08-31 21:57:21 +00002247 RangeSize = ConstantExpr::getNeg(RangeSize);
Sanjay Patelf7ba0892016-08-26 15:53:01 +00002248 if (*C == 0) { // (X / neg) op 0
Sanjay Patel16554142016-08-24 23:03:36 +00002249 // e.g. X/-5 op 0 --> [-4, 5)
2250 LoBound = AddOne(RangeSize);
Sanjay Patel541aef42016-08-31 21:57:21 +00002251 HiBound = ConstantExpr::getNeg(RangeSize);
Sanjay Patel16554142016-08-24 23:03:36 +00002252 if (HiBound == DivRHS) { // -INTMIN = INTMIN
2253 HiOverflow = 1; // [INTMIN+1, overflow)
2254 HiBound = nullptr; // e.g. X/INTMIN = 0 --> X > INTMIN
2255 }
Sanjay Patelf7ba0892016-08-26 15:53:01 +00002256 } else if (C->isStrictlyPositive()) { // (X / neg) op pos
Sanjay Patel16554142016-08-24 23:03:36 +00002257 // e.g. X/-5 op 3 --> [-19, -14)
2258 HiBound = AddOne(Prod);
2259 HiOverflow = LoOverflow = ProdOV ? -1 : 0;
2260 if (!LoOverflow)
Sanjay Pateld93c4c02016-09-15 18:22:25 +00002261 LoOverflow = addWithOverflow(LoBound, HiBound, RangeSize, true) ? -1:0;
Sanjay Patel16554142016-08-24 23:03:36 +00002262 } else { // (X / neg) op neg
2263 LoBound = Prod; // e.g. X/-5 op -3 --> [15, 20)
2264 LoOverflow = HiOverflow = ProdOV;
2265 if (!HiOverflow)
Sanjay Pateld93c4c02016-09-15 18:22:25 +00002266 HiOverflow = subWithOverflow(HiBound, Prod, RangeSize, true);
Sanjay Patel16554142016-08-24 23:03:36 +00002267 }
2268
2269 // Dividing by a negative swaps the condition. LT <-> GT
2270 Pred = ICmpInst::getSwappedPredicate(Pred);
2271 }
2272
Sanjay Patelf7ba0892016-08-26 15:53:01 +00002273 Value *X = Div->getOperand(0);
Sanjay Patel16554142016-08-24 23:03:36 +00002274 switch (Pred) {
2275 default: llvm_unreachable("Unhandled icmp opcode!");
2276 case ICmpInst::ICMP_EQ:
2277 if (LoOverflow && HiOverflow)
Sanjay Patelf7ba0892016-08-26 15:53:01 +00002278 return replaceInstUsesWith(Cmp, Builder->getFalse());
Sanjay Patel16554142016-08-24 23:03:36 +00002279 if (HiOverflow)
2280 return new ICmpInst(DivIsSigned ? ICmpInst::ICMP_SGE :
2281 ICmpInst::ICMP_UGE, X, LoBound);
2282 if (LoOverflow)
2283 return new ICmpInst(DivIsSigned ? ICmpInst::ICMP_SLT :
2284 ICmpInst::ICMP_ULT, X, HiBound);
Sanjay Patel85d79742016-08-31 19:49:56 +00002285 return replaceInstUsesWith(
Sanjay Patel541aef42016-08-31 21:57:21 +00002286 Cmp, insertRangeTest(X, LoBound->getUniqueInteger(),
2287 HiBound->getUniqueInteger(), DivIsSigned, true));
Sanjay Patel16554142016-08-24 23:03:36 +00002288 case ICmpInst::ICMP_NE:
2289 if (LoOverflow && HiOverflow)
Sanjay Patelf7ba0892016-08-26 15:53:01 +00002290 return replaceInstUsesWith(Cmp, Builder->getTrue());
Sanjay Patel16554142016-08-24 23:03:36 +00002291 if (HiOverflow)
2292 return new ICmpInst(DivIsSigned ? ICmpInst::ICMP_SLT :
2293 ICmpInst::ICMP_ULT, X, LoBound);
2294 if (LoOverflow)
2295 return new ICmpInst(DivIsSigned ? ICmpInst::ICMP_SGE :
2296 ICmpInst::ICMP_UGE, X, HiBound);
Sanjay Patel541aef42016-08-31 21:57:21 +00002297 return replaceInstUsesWith(Cmp,
2298 insertRangeTest(X, LoBound->getUniqueInteger(),
2299 HiBound->getUniqueInteger(),
2300 DivIsSigned, false));
Sanjay Patel16554142016-08-24 23:03:36 +00002301 case ICmpInst::ICMP_ULT:
2302 case ICmpInst::ICMP_SLT:
2303 if (LoOverflow == +1) // Low bound is greater than input range.
Sanjay Patelf7ba0892016-08-26 15:53:01 +00002304 return replaceInstUsesWith(Cmp, Builder->getTrue());
Sanjay Patel16554142016-08-24 23:03:36 +00002305 if (LoOverflow == -1) // Low bound is less than input range.
Sanjay Patelf7ba0892016-08-26 15:53:01 +00002306 return replaceInstUsesWith(Cmp, Builder->getFalse());
Sanjay Patel16554142016-08-24 23:03:36 +00002307 return new ICmpInst(Pred, X, LoBound);
2308 case ICmpInst::ICMP_UGT:
2309 case ICmpInst::ICMP_SGT:
2310 if (HiOverflow == +1) // High bound greater than input range.
Sanjay Patelf7ba0892016-08-26 15:53:01 +00002311 return replaceInstUsesWith(Cmp, Builder->getFalse());
Sanjay Patel16554142016-08-24 23:03:36 +00002312 if (HiOverflow == -1) // High bound less than input range.
Sanjay Patelf7ba0892016-08-26 15:53:01 +00002313 return replaceInstUsesWith(Cmp, Builder->getTrue());
Sanjay Patel16554142016-08-24 23:03:36 +00002314 if (Pred == ICmpInst::ICMP_UGT)
2315 return new ICmpInst(ICmpInst::ICMP_UGE, X, HiBound);
2316 return new ICmpInst(ICmpInst::ICMP_SGE, X, HiBound);
2317 }
Sanjay Patela3f4f082016-08-16 17:54:36 +00002318
2319 return nullptr;
2320}
2321
Sanjay Patelb9aa67b2016-08-16 21:26:10 +00002322/// Fold icmp (sub X, Y), C.
Sanjay Patelc9196c42016-08-22 21:24:29 +00002323Instruction *InstCombiner::foldICmpSubConstant(ICmpInst &Cmp,
2324 BinaryOperator *Sub,
Sanjay Patelb9aa67b2016-08-16 21:26:10 +00002325 const APInt *C) {
Sanjay Patel886a5422016-09-15 18:05:17 +00002326 Value *X = Sub->getOperand(0), *Y = Sub->getOperand(1);
2327 ICmpInst::Predicate Pred = Cmp.getPredicate();
2328
2329 // The following transforms are only worth it if the only user of the subtract
2330 // is the icmp.
2331 if (!Sub->hasOneUse())
Sanjay Patela3f4f082016-08-16 17:54:36 +00002332 return nullptr;
2333
Sanjay Patel886a5422016-09-15 18:05:17 +00002334 if (Sub->hasNoSignedWrap()) {
2335 // (icmp sgt (sub nsw X, Y), -1) -> (icmp sge X, Y)
2336 if (Pred == ICmpInst::ICMP_SGT && C->isAllOnesValue())
2337 return new ICmpInst(ICmpInst::ICMP_SGE, X, Y);
Sanjay Patela3f4f082016-08-16 17:54:36 +00002338
Sanjay Patel886a5422016-09-15 18:05:17 +00002339 // (icmp sgt (sub nsw X, Y), 0) -> (icmp sgt X, Y)
2340 if (Pred == ICmpInst::ICMP_SGT && *C == 0)
2341 return new ICmpInst(ICmpInst::ICMP_SGT, X, Y);
2342
2343 // (icmp slt (sub nsw X, Y), 0) -> (icmp slt X, Y)
2344 if (Pred == ICmpInst::ICMP_SLT && *C == 0)
2345 return new ICmpInst(ICmpInst::ICMP_SLT, X, Y);
2346
2347 // (icmp slt (sub nsw X, Y), 1) -> (icmp sle X, Y)
2348 if (Pred == ICmpInst::ICMP_SLT && *C == 1)
2349 return new ICmpInst(ICmpInst::ICMP_SLE, X, Y);
2350 }
2351
2352 const APInt *C2;
2353 if (!match(X, m_APInt(C2)))
2354 return nullptr;
2355
2356 // C2 - Y <u C -> (Y | (C - 1)) == C2
2357 // iff (C2 & (C - 1)) == C - 1 and C is a power of 2
2358 if (Pred == ICmpInst::ICMP_ULT && C->isPowerOf2() &&
2359 (*C2 & (*C - 1)) == (*C - 1))
2360 return new ICmpInst(ICmpInst::ICMP_EQ, Builder->CreateOr(Y, *C - 1), X);
2361
2362 // C2 - Y >u C -> (Y | C) != C2
2363 // iff C2 & C == C and C + 1 is a power of 2
2364 if (Pred == ICmpInst::ICMP_UGT && (*C + 1).isPowerOf2() && (*C2 & *C) == *C)
2365 return new ICmpInst(ICmpInst::ICMP_NE, Builder->CreateOr(Y, *C), X);
Sanjay Patela3f4f082016-08-16 17:54:36 +00002366
2367 return nullptr;
2368}
2369
Sanjay Patel60ea1b42016-08-16 22:34:42 +00002370/// Fold icmp (add X, Y), C.
Sanjay Patelc9196c42016-08-22 21:24:29 +00002371Instruction *InstCombiner::foldICmpAddConstant(ICmpInst &Cmp,
2372 BinaryOperator *Add,
Sanjay Patel60ea1b42016-08-16 22:34:42 +00002373 const APInt *C) {
Sanjay Patel4f7eb2a2016-08-17 15:24:30 +00002374 Value *Y = Add->getOperand(1);
2375 const APInt *C2;
2376 if (Cmp.isEquality() || !match(Y, m_APInt(C2)))
Sanjay Patela3f4f082016-08-16 17:54:36 +00002377 return nullptr;
2378
Sanjay Patel4f7eb2a2016-08-17 15:24:30 +00002379 // Fold icmp pred (add X, C2), C.
Sanjay Patel60ea1b42016-08-16 22:34:42 +00002380 Value *X = Add->getOperand(0);
Sanjay Patel4f7eb2a2016-08-17 15:24:30 +00002381 Type *Ty = Add->getType();
Sanjay Patel6dd2eae2017-02-08 16:19:36 +00002382 CmpInst::Predicate Pred = Cmp.getPredicate();
Sanjay Patel45b7e692017-02-12 16:40:30 +00002383
2384 // If the add does not wrap, we can always adjust the compare by subtracting
2385 // the constants. Equality comparisons are handled elsewhere. SGE/SLE are
2386 // canonicalized to SGT/SLT.
2387 if (Add->hasNoSignedWrap() &&
2388 (Pred == ICmpInst::ICMP_SGT || Pred == ICmpInst::ICMP_SLT)) {
2389 bool Overflow;
2390 APInt NewC = C->ssub_ov(*C2, Overflow);
2391 // If there is overflow, the result must be true or false.
2392 // TODO: Can we assert there is no overflow because InstSimplify always
2393 // handles those cases?
2394 if (!Overflow)
2395 // icmp Pred (add nsw X, C2), C --> icmp Pred X, (C - C2)
2396 return new ICmpInst(Pred, X, ConstantInt::get(Ty, NewC));
2397 }
2398
Sanjay Patel6dd2eae2017-02-08 16:19:36 +00002399 auto CR = ConstantRange::makeExactICmpRegion(Pred, *C).subtract(*C2);
Sanjay Patel60ea1b42016-08-16 22:34:42 +00002400 const APInt &Upper = CR.getUpper();
2401 const APInt &Lower = CR.getLower();
2402 if (Cmp.isSigned()) {
Craig Topperbcfd2d12017-04-20 16:56:25 +00002403 if (Lower.isSignMask())
Sanjay Patel4f7eb2a2016-08-17 15:24:30 +00002404 return new ICmpInst(ICmpInst::ICMP_SLT, X, ConstantInt::get(Ty, Upper));
Craig Topperbcfd2d12017-04-20 16:56:25 +00002405 if (Upper.isSignMask())
Sanjay Patel4f7eb2a2016-08-17 15:24:30 +00002406 return new ICmpInst(ICmpInst::ICMP_SGE, X, ConstantInt::get(Ty, Lower));
Sanjay Patel60ea1b42016-08-16 22:34:42 +00002407 } else {
2408 if (Lower.isMinValue())
Sanjay Patel4f7eb2a2016-08-17 15:24:30 +00002409 return new ICmpInst(ICmpInst::ICMP_ULT, X, ConstantInt::get(Ty, Upper));
Sanjay Patel60ea1b42016-08-16 22:34:42 +00002410 if (Upper.isMinValue())
Sanjay Patel4f7eb2a2016-08-17 15:24:30 +00002411 return new ICmpInst(ICmpInst::ICMP_UGE, X, ConstantInt::get(Ty, Lower));
Sanjay Patel60ea1b42016-08-16 22:34:42 +00002412 }
Sanjay Patela3f4f082016-08-16 17:54:36 +00002413
Sanjay Patel4f7eb2a2016-08-17 15:24:30 +00002414 if (!Add->hasOneUse())
2415 return nullptr;
Sanjay Patela3f4f082016-08-16 17:54:36 +00002416
Sanjay Patel4f7eb2a2016-08-17 15:24:30 +00002417 // X+C <u C2 -> (X & -C2) == C
2418 // iff C & (C2-1) == 0
2419 // C2 is a power of 2
Sanjay Patel6dd2eae2017-02-08 16:19:36 +00002420 if (Pred == ICmpInst::ICMP_ULT && C->isPowerOf2() && (*C2 & (*C - 1)) == 0)
Sanjay Patel4f7eb2a2016-08-17 15:24:30 +00002421 return new ICmpInst(ICmpInst::ICMP_EQ, Builder->CreateAnd(X, -(*C)),
2422 ConstantExpr::getNeg(cast<Constant>(Y)));
2423
2424 // X+C >u C2 -> (X & ~C2) != C
2425 // iff C & C2 == 0
2426 // C2+1 is a power of 2
Sanjay Patel6dd2eae2017-02-08 16:19:36 +00002427 if (Pred == ICmpInst::ICMP_UGT && (*C + 1).isPowerOf2() && (*C2 & *C) == 0)
Sanjay Patel4f7eb2a2016-08-17 15:24:30 +00002428 return new ICmpInst(ICmpInst::ICMP_NE, Builder->CreateAnd(X, ~(*C)),
2429 ConstantExpr::getNeg(cast<Constant>(Y)));
2430
Sanjay Patela3f4f082016-08-16 17:54:36 +00002431 return nullptr;
2432}
2433
Sanjay Patelf58f68c2016-09-10 15:03:44 +00002434/// Try to fold integer comparisons with a constant operand: icmp Pred X, C
2435/// where X is some kind of instruction.
2436Instruction *InstCombiner::foldICmpInstWithConstant(ICmpInst &Cmp) {
Sanjay Patelc9196c42016-08-22 21:24:29 +00002437 const APInt *C;
2438 if (!match(Cmp.getOperand(1), m_APInt(C)))
Sanjay Patel1e5b2d12016-08-16 16:08:11 +00002439 return nullptr;
2440
Sanjay Patelc9196c42016-08-22 21:24:29 +00002441 BinaryOperator *BO;
2442 if (match(Cmp.getOperand(0), m_BinOp(BO))) {
2443 switch (BO->getOpcode()) {
2444 case Instruction::Xor:
2445 if (Instruction *I = foldICmpXorConstant(Cmp, BO, C))
2446 return I;
2447 break;
2448 case Instruction::And:
2449 if (Instruction *I = foldICmpAndConstant(Cmp, BO, C))
2450 return I;
2451 break;
2452 case Instruction::Or:
2453 if (Instruction *I = foldICmpOrConstant(Cmp, BO, C))
2454 return I;
2455 break;
2456 case Instruction::Mul:
2457 if (Instruction *I = foldICmpMulConstant(Cmp, BO, C))
2458 return I;
2459 break;
2460 case Instruction::Shl:
2461 if (Instruction *I = foldICmpShlConstant(Cmp, BO, C))
2462 return I;
2463 break;
2464 case Instruction::LShr:
2465 case Instruction::AShr:
2466 if (Instruction *I = foldICmpShrConstant(Cmp, BO, C))
2467 return I;
2468 break;
2469 case Instruction::UDiv:
2470 if (Instruction *I = foldICmpUDivConstant(Cmp, BO, C))
2471 return I;
2472 LLVM_FALLTHROUGH;
2473 case Instruction::SDiv:
2474 if (Instruction *I = foldICmpDivConstant(Cmp, BO, C))
2475 return I;
2476 break;
2477 case Instruction::Sub:
2478 if (Instruction *I = foldICmpSubConstant(Cmp, BO, C))
2479 return I;
2480 break;
2481 case Instruction::Add:
2482 if (Instruction *I = foldICmpAddConstant(Cmp, BO, C))
2483 return I;
2484 break;
2485 default:
2486 break;
2487 }
Sanjay Patelf58f68c2016-09-10 15:03:44 +00002488 // TODO: These folds could be refactored to be part of the above calls.
2489 if (Instruction *I = foldICmpBinOpEqualityWithConstant(Cmp, BO, C))
2490 return I;
Chris Lattner2188e402010-01-04 07:37:31 +00002491 }
Jim Grosbach129c52a2011-09-30 18:09:53 +00002492
Sanjay Patelc9196c42016-08-22 21:24:29 +00002493 Instruction *LHSI;
2494 if (match(Cmp.getOperand(0), m_Instruction(LHSI)) &&
2495 LHSI->getOpcode() == Instruction::Trunc)
2496 if (Instruction *I = foldICmpTruncConstant(Cmp, LHSI, C))
2497 return I;
2498
Sanjay Patelf58f68c2016-09-10 15:03:44 +00002499 if (Instruction *I = foldICmpIntrinsicWithConstant(Cmp, C))
2500 return I;
2501
Sanjay Patel1710e7c2016-07-21 17:15:49 +00002502 return nullptr;
2503}
Jim Grosbach129c52a2011-09-30 18:09:53 +00002504
Sanjay Patel0a3d72b2016-09-10 15:33:39 +00002505/// Fold an icmp equality instruction with binary operator LHS and constant RHS:
2506/// icmp eq/ne BO, C.
2507Instruction *InstCombiner::foldICmpBinOpEqualityWithConstant(ICmpInst &Cmp,
2508 BinaryOperator *BO,
2509 const APInt *C) {
2510 // TODO: Some of these folds could work with arbitrary constants, but this
2511 // function is limited to scalar and vector splat constants.
2512 if (!Cmp.isEquality())
Sanjay Patel1710e7c2016-07-21 17:15:49 +00002513 return nullptr;
2514
Sanjay Patel0a3d72b2016-09-10 15:33:39 +00002515 ICmpInst::Predicate Pred = Cmp.getPredicate();
2516 bool isICMP_NE = Pred == ICmpInst::ICMP_NE;
2517 Constant *RHS = cast<Constant>(Cmp.getOperand(1));
Sanjay Patel51a767c2016-08-03 17:23:08 +00002518 Value *BOp0 = BO->getOperand(0), *BOp1 = BO->getOperand(1);
Sanjay Patel1710e7c2016-07-21 17:15:49 +00002519
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002520 switch (BO->getOpcode()) {
2521 case Instruction::SRem:
2522 // If we have a signed (X % (2^c)) == 0, turn it into an unsigned one.
Sanjay Patel0a3d72b2016-09-10 15:33:39 +00002523 if (*C == 0 && BO->hasOneUse()) {
Sanjay Patel2e9675f2016-08-03 19:48:40 +00002524 const APInt *BOC;
2525 if (match(BOp1, m_APInt(BOC)) && BOC->sgt(1) && BOC->isPowerOf2()) {
Sanjay Patel51a767c2016-08-03 17:23:08 +00002526 Value *NewRem = Builder->CreateURem(BOp0, BOp1, BO->getName());
Sanjay Patel0a3d72b2016-09-10 15:33:39 +00002527 return new ICmpInst(Pred, NewRem,
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002528 Constant::getNullValue(BO->getType()));
Chris Lattner2188e402010-01-04 07:37:31 +00002529 }
Sanjay Patel1710e7c2016-07-21 17:15:49 +00002530 }
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002531 break;
Sanjay Patel00a324e2016-08-03 22:08:44 +00002532 case Instruction::Add: {
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002533 // Replace ((add A, B) != C) with (A != C-B) if B & C are constants.
Sanjay Patel00a324e2016-08-03 22:08:44 +00002534 const APInt *BOC;
2535 if (match(BOp1, m_APInt(BOC))) {
2536 if (BO->hasOneUse()) {
2537 Constant *SubC = ConstantExpr::getSub(RHS, cast<Constant>(BOp1));
Sanjay Patel0a3d72b2016-09-10 15:33:39 +00002538 return new ICmpInst(Pred, BOp0, SubC);
Sanjay Patel00a324e2016-08-03 22:08:44 +00002539 }
Sanjay Patel0a3d72b2016-09-10 15:33:39 +00002540 } else if (*C == 0) {
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002541 // Replace ((add A, B) != 0) with (A != -B) if A or B is
2542 // efficiently invertible, or if the add has just this one use.
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002543 if (Value *NegVal = dyn_castNegVal(BOp1))
Sanjay Patel0a3d72b2016-09-10 15:33:39 +00002544 return new ICmpInst(Pred, BOp0, NegVal);
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002545 if (Value *NegVal = dyn_castNegVal(BOp0))
Sanjay Patel0a3d72b2016-09-10 15:33:39 +00002546 return new ICmpInst(Pred, NegVal, BOp1);
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002547 if (BO->hasOneUse()) {
2548 Value *Neg = Builder->CreateNeg(BOp1);
2549 Neg->takeName(BO);
Sanjay Patel0a3d72b2016-09-10 15:33:39 +00002550 return new ICmpInst(Pred, BOp0, Neg);
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002551 }
2552 }
2553 break;
Sanjay Patel00a324e2016-08-03 22:08:44 +00002554 }
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002555 case Instruction::Xor:
2556 if (BO->hasOneUse()) {
Sanjay Patel51a767c2016-08-03 17:23:08 +00002557 if (Constant *BOC = dyn_cast<Constant>(BOp1)) {
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002558 // For the xor case, we can xor two constants together, eliminating
2559 // the explicit xor.
Sanjay Patel0a3d72b2016-09-10 15:33:39 +00002560 return new ICmpInst(Pred, BOp0, ConstantExpr::getXor(RHS, BOC));
2561 } else if (*C == 0) {
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002562 // Replace ((xor A, B) != 0) with (A != B)
Sanjay Patel0a3d72b2016-09-10 15:33:39 +00002563 return new ICmpInst(Pred, BOp0, BOp1);
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002564 }
2565 }
2566 break;
2567 case Instruction::Sub:
2568 if (BO->hasOneUse()) {
Sanjay Patel9d591d12016-08-04 15:19:25 +00002569 const APInt *BOC;
2570 if (match(BOp0, m_APInt(BOC))) {
Sanjay Patel362ff5c2016-09-15 17:01:17 +00002571 // Replace ((sub BOC, B) != C) with (B != BOC-C).
Sanjay Patel9d591d12016-08-04 15:19:25 +00002572 Constant *SubC = ConstantExpr::getSub(cast<Constant>(BOp0), RHS);
Sanjay Patel0a3d72b2016-09-10 15:33:39 +00002573 return new ICmpInst(Pred, BOp1, SubC);
2574 } else if (*C == 0) {
Sanjay Patel362ff5c2016-09-15 17:01:17 +00002575 // Replace ((sub A, B) != 0) with (A != B).
Sanjay Patel0a3d72b2016-09-10 15:33:39 +00002576 return new ICmpInst(Pred, BOp0, BOp1);
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002577 }
2578 }
2579 break;
Sanjay Patelb3de75d2016-08-04 19:12:12 +00002580 case Instruction::Or: {
2581 const APInt *BOC;
2582 if (match(BOp1, m_APInt(BOC)) && BO->hasOneUse() && RHS->isAllOnesValue()) {
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002583 // Comparing if all bits outside of a constant mask are set?
2584 // Replace (X | C) == -1 with (X & ~C) == ~C.
2585 // This removes the -1 constant.
Sanjay Patelb3de75d2016-08-04 19:12:12 +00002586 Constant *NotBOC = ConstantExpr::getNot(cast<Constant>(BOp1));
2587 Value *And = Builder->CreateAnd(BOp0, NotBOC);
Sanjay Patel0a3d72b2016-09-10 15:33:39 +00002588 return new ICmpInst(Pred, And, NotBOC);
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002589 }
2590 break;
Sanjay Patelb3de75d2016-08-04 19:12:12 +00002591 }
Sanjay Pateld938e882016-08-04 20:05:02 +00002592 case Instruction::And: {
2593 const APInt *BOC;
2594 if (match(BOp1, m_APInt(BOC))) {
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002595 // If we have ((X & C) == C), turn it into ((X & C) != 0).
Sanjay Patel0a3d72b2016-09-10 15:33:39 +00002596 if (C == BOC && C->isPowerOf2())
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002597 return new ICmpInst(isICMP_NE ? ICmpInst::ICMP_EQ : ICmpInst::ICMP_NE,
Sanjay Patelab50a932016-08-02 22:38:33 +00002598 BO, Constant::getNullValue(RHS->getType()));
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002599
2600 // Don't perform the following transforms if the AND has multiple uses
2601 if (!BO->hasOneUse())
2602 break;
2603
2604 // Replace (and X, (1 << size(X)-1) != 0) with x s< 0
Craig Topperbcfd2d12017-04-20 16:56:25 +00002605 if (BOC->isSignMask()) {
Sanjay Patel51a767c2016-08-03 17:23:08 +00002606 Constant *Zero = Constant::getNullValue(BOp0->getType());
Sanjay Patel0a3d72b2016-09-10 15:33:39 +00002607 auto NewPred = isICMP_NE ? ICmpInst::ICMP_SLT : ICmpInst::ICMP_SGE;
2608 return new ICmpInst(NewPred, BOp0, Zero);
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002609 }
2610
2611 // ((X & ~7) == 0) --> X < 8
Sanjay Patel0a3d72b2016-09-10 15:33:39 +00002612 if (*C == 0 && (~(*BOC) + 1).isPowerOf2()) {
Sanjay Pateld938e882016-08-04 20:05:02 +00002613 Constant *NegBOC = ConstantExpr::getNeg(cast<Constant>(BOp1));
Sanjay Patel0a3d72b2016-09-10 15:33:39 +00002614 auto NewPred = isICMP_NE ? ICmpInst::ICMP_UGE : ICmpInst::ICMP_ULT;
2615 return new ICmpInst(NewPred, BOp0, NegBOC);
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002616 }
2617 }
2618 break;
Sanjay Pateld938e882016-08-04 20:05:02 +00002619 }
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002620 case Instruction::Mul:
Sanjay Patel0a3d72b2016-09-10 15:33:39 +00002621 if (*C == 0 && BO->hasNoSignedWrap()) {
Sanjay Patel3bade132016-08-04 22:19:27 +00002622 const APInt *BOC;
2623 if (match(BOp1, m_APInt(BOC)) && *BOC != 0) {
2624 // The trivial case (mul X, 0) is handled by InstSimplify.
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002625 // General case : (mul X, C) != 0 iff X != 0
2626 // (mul X, C) == 0 iff X == 0
Sanjay Patel0a3d72b2016-09-10 15:33:39 +00002627 return new ICmpInst(Pred, BOp0, Constant::getNullValue(RHS->getType()));
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002628 }
2629 }
2630 break;
Sanjay Patel6ebd5852016-07-23 00:28:39 +00002631 case Instruction::UDiv:
Sanjay Patel0a3d72b2016-09-10 15:33:39 +00002632 if (*C == 0) {
Sanjay Patel6ebd5852016-07-23 00:28:39 +00002633 // (icmp eq/ne (udiv A, B), 0) -> (icmp ugt/ule i32 B, A)
Sanjay Patel0a3d72b2016-09-10 15:33:39 +00002634 auto NewPred = isICMP_NE ? ICmpInst::ICMP_ULE : ICmpInst::ICMP_UGT;
2635 return new ICmpInst(NewPred, BOp1, BOp0);
Sanjay Patel6ebd5852016-07-23 00:28:39 +00002636 }
2637 break;
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002638 default:
2639 break;
2640 }
2641 return nullptr;
2642}
2643
Sanjay Patel0a3d72b2016-09-10 15:33:39 +00002644/// Fold an icmp with LLVM intrinsic and constant operand: icmp Pred II, C.
2645Instruction *InstCombiner::foldICmpIntrinsicWithConstant(ICmpInst &Cmp,
2646 const APInt *C) {
2647 IntrinsicInst *II = dyn_cast<IntrinsicInst>(Cmp.getOperand(0));
2648 if (!II || !Cmp.isEquality())
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002649 return nullptr;
2650
2651 // Handle icmp {eq|ne} <intrinsic>, intcst.
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002652 switch (II->getIntrinsicID()) {
2653 case Intrinsic::bswap:
2654 Worklist.Add(II);
Sanjay Patel0a3d72b2016-09-10 15:33:39 +00002655 Cmp.setOperand(0, II->getArgOperand(0));
2656 Cmp.setOperand(1, Builder->getInt(C->byteSwap()));
2657 return &Cmp;
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002658 case Intrinsic::ctlz:
2659 case Intrinsic::cttz:
Amaury Sechet6bea6742016-08-04 05:27:20 +00002660 // ctz(A) == bitwidth(A) -> A == 0 and likewise for !=
Sanjay Patel0a3d72b2016-09-10 15:33:39 +00002661 if (*C == C->getBitWidth()) {
Sanjay Patel1710e7c2016-07-21 17:15:49 +00002662 Worklist.Add(II);
Sanjay Patel0a3d72b2016-09-10 15:33:39 +00002663 Cmp.setOperand(0, II->getArgOperand(0));
2664 Cmp.setOperand(1, ConstantInt::getNullValue(II->getType()));
2665 return &Cmp;
Chris Lattner2188e402010-01-04 07:37:31 +00002666 }
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002667 break;
Amaury Sechet6bea6742016-08-04 05:27:20 +00002668 case Intrinsic::ctpop: {
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002669 // popcount(A) == 0 -> A == 0 and likewise for !=
Amaury Sechet6bea6742016-08-04 05:27:20 +00002670 // popcount(A) == bitwidth(A) -> A == -1 and likewise for !=
Sanjay Patel0a3d72b2016-09-10 15:33:39 +00002671 bool IsZero = *C == 0;
2672 if (IsZero || *C == C->getBitWidth()) {
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002673 Worklist.Add(II);
Sanjay Patel0a3d72b2016-09-10 15:33:39 +00002674 Cmp.setOperand(0, II->getArgOperand(0));
2675 auto *NewOp = IsZero ? Constant::getNullValue(II->getType())
2676 : Constant::getAllOnesValue(II->getType());
2677 Cmp.setOperand(1, NewOp);
2678 return &Cmp;
Amaury Sechet6bea6742016-08-04 05:27:20 +00002679 }
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002680 break;
Sanjay Patel0a3d72b2016-09-10 15:33:39 +00002681 }
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002682 default:
2683 break;
Chris Lattner2188e402010-01-04 07:37:31 +00002684 }
Craig Topperf40110f2014-04-25 05:29:35 +00002685 return nullptr;
Chris Lattner2188e402010-01-04 07:37:31 +00002686}
2687
Sanjay Patel10494b22016-09-16 16:10:22 +00002688/// Handle icmp with constant (but not simple integer constant) RHS.
2689Instruction *InstCombiner::foldICmpInstWithConstantNotInt(ICmpInst &I) {
2690 Value *Op0 = I.getOperand(0), *Op1 = I.getOperand(1);
2691 Constant *RHSC = dyn_cast<Constant>(Op1);
2692 Instruction *LHSI = dyn_cast<Instruction>(Op0);
2693 if (!RHSC || !LHSI)
2694 return nullptr;
2695
2696 switch (LHSI->getOpcode()) {
2697 case Instruction::GetElementPtr:
2698 // icmp pred GEP (P, int 0, int 0, int 0), null -> icmp pred P, null
2699 if (RHSC->isNullValue() &&
2700 cast<GetElementPtrInst>(LHSI)->hasAllZeroIndices())
2701 return new ICmpInst(
2702 I.getPredicate(), LHSI->getOperand(0),
2703 Constant::getNullValue(LHSI->getOperand(0)->getType()));
2704 break;
2705 case Instruction::PHI:
2706 // Only fold icmp into the PHI if the phi and icmp are in the same
2707 // block. If in the same block, we're encouraging jump threading. If
2708 // not, we are just pessimizing the code by making an i1 phi.
2709 if (LHSI->getParent() == I.getParent())
Craig Topperfb71b7d2017-04-14 19:20:12 +00002710 if (Instruction *NV = foldOpIntoPhi(I, cast<PHINode>(LHSI)))
Sanjay Patel10494b22016-09-16 16:10:22 +00002711 return NV;
2712 break;
2713 case Instruction::Select: {
2714 // If either operand of the select is a constant, we can fold the
2715 // comparison into the select arms, which will cause one to be
2716 // constant folded and the select turned into a bitwise or.
2717 Value *Op1 = nullptr, *Op2 = nullptr;
2718 ConstantInt *CI = nullptr;
2719 if (Constant *C = dyn_cast<Constant>(LHSI->getOperand(1))) {
2720 Op1 = ConstantExpr::getICmp(I.getPredicate(), C, RHSC);
2721 CI = dyn_cast<ConstantInt>(Op1);
2722 }
2723 if (Constant *C = dyn_cast<Constant>(LHSI->getOperand(2))) {
2724 Op2 = ConstantExpr::getICmp(I.getPredicate(), C, RHSC);
2725 CI = dyn_cast<ConstantInt>(Op2);
2726 }
2727
2728 // We only want to perform this transformation if it will not lead to
2729 // additional code. This is true if either both sides of the select
2730 // fold to a constant (in which case the icmp is replaced with a select
2731 // which will usually simplify) or this is the only user of the
2732 // select (in which case we are trading a select+icmp for a simpler
2733 // select+icmp) or all uses of the select can be replaced based on
2734 // dominance information ("Global cases").
2735 bool Transform = false;
2736 if (Op1 && Op2)
2737 Transform = true;
2738 else if (Op1 || Op2) {
2739 // Local case
2740 if (LHSI->hasOneUse())
2741 Transform = true;
2742 // Global cases
2743 else if (CI && !CI->isZero())
2744 // When Op1 is constant try replacing select with second operand.
2745 // Otherwise Op2 is constant and try replacing select with first
2746 // operand.
2747 Transform =
2748 replacedSelectWithOperand(cast<SelectInst>(LHSI), &I, Op1 ? 2 : 1);
2749 }
2750 if (Transform) {
2751 if (!Op1)
2752 Op1 = Builder->CreateICmp(I.getPredicate(), LHSI->getOperand(1), RHSC,
2753 I.getName());
2754 if (!Op2)
2755 Op2 = Builder->CreateICmp(I.getPredicate(), LHSI->getOperand(2), RHSC,
2756 I.getName());
2757 return SelectInst::Create(LHSI->getOperand(0), Op1, Op2);
2758 }
2759 break;
2760 }
2761 case Instruction::IntToPtr:
2762 // icmp pred inttoptr(X), null -> icmp pred X, 0
2763 if (RHSC->isNullValue() &&
2764 DL.getIntPtrType(RHSC->getType()) == LHSI->getOperand(0)->getType())
2765 return new ICmpInst(
2766 I.getPredicate(), LHSI->getOperand(0),
2767 Constant::getNullValue(LHSI->getOperand(0)->getType()));
2768 break;
2769
2770 case Instruction::Load:
2771 // Try to optimize things like "A[i] > 4" to index computations.
2772 if (GetElementPtrInst *GEP =
2773 dyn_cast<GetElementPtrInst>(LHSI->getOperand(0))) {
2774 if (GlobalVariable *GV = dyn_cast<GlobalVariable>(GEP->getOperand(0)))
2775 if (GV->isConstant() && GV->hasDefinitiveInitializer() &&
2776 !cast<LoadInst>(LHSI)->isVolatile())
2777 if (Instruction *Res = foldCmpLoadFromIndexedGlobal(GEP, GV, I))
2778 return Res;
2779 }
2780 break;
2781 }
2782
2783 return nullptr;
2784}
2785
2786/// Try to fold icmp (binop), X or icmp X, (binop).
Sanjay Patel2df38a82017-05-08 16:21:55 +00002787/// TODO: A large part of this logic is duplicated in InstSimplify's
2788/// simplifyICmpWithBinOp(). We should be able to share that and avoid the code
2789/// duplication.
Sanjay Patel10494b22016-09-16 16:10:22 +00002790Instruction *InstCombiner::foldICmpBinOp(ICmpInst &I) {
2791 Value *Op0 = I.getOperand(0), *Op1 = I.getOperand(1);
2792
2793 // Special logic for binary operators.
2794 BinaryOperator *BO0 = dyn_cast<BinaryOperator>(Op0);
2795 BinaryOperator *BO1 = dyn_cast<BinaryOperator>(Op1);
2796 if (!BO0 && !BO1)
2797 return nullptr;
2798
Sanjay Patel2a062632017-05-08 16:33:42 +00002799 const CmpInst::Predicate Pred = I.getPredicate();
Sanjay Patel10494b22016-09-16 16:10:22 +00002800 bool NoOp0WrapProblem = false, NoOp1WrapProblem = false;
2801 if (BO0 && isa<OverflowingBinaryOperator>(BO0))
2802 NoOp0WrapProblem =
2803 ICmpInst::isEquality(Pred) ||
2804 (CmpInst::isUnsigned(Pred) && BO0->hasNoUnsignedWrap()) ||
2805 (CmpInst::isSigned(Pred) && BO0->hasNoSignedWrap());
2806 if (BO1 && isa<OverflowingBinaryOperator>(BO1))
2807 NoOp1WrapProblem =
2808 ICmpInst::isEquality(Pred) ||
2809 (CmpInst::isUnsigned(Pred) && BO1->hasNoUnsignedWrap()) ||
2810 (CmpInst::isSigned(Pred) && BO1->hasNoSignedWrap());
2811
2812 // Analyze the case when either Op0 or Op1 is an add instruction.
2813 // Op0 = A + B (or A and B are null); Op1 = C + D (or C and D are null).
2814 Value *A = nullptr, *B = nullptr, *C = nullptr, *D = nullptr;
2815 if (BO0 && BO0->getOpcode() == Instruction::Add) {
2816 A = BO0->getOperand(0);
2817 B = BO0->getOperand(1);
2818 }
2819 if (BO1 && BO1->getOpcode() == Instruction::Add) {
2820 C = BO1->getOperand(0);
2821 D = BO1->getOperand(1);
2822 }
2823
Sanjay Patel10494b22016-09-16 16:10:22 +00002824 // icmp (X+Y), X -> icmp Y, 0 for equalities or if there is no overflow.
2825 if ((A == Op1 || B == Op1) && NoOp0WrapProblem)
2826 return new ICmpInst(Pred, A == Op1 ? B : A,
2827 Constant::getNullValue(Op1->getType()));
2828
2829 // icmp X, (X+Y) -> icmp 0, Y for equalities or if there is no overflow.
2830 if ((C == Op0 || D == Op0) && NoOp1WrapProblem)
2831 return new ICmpInst(Pred, Constant::getNullValue(Op0->getType()),
2832 C == Op0 ? D : C);
2833
2834 // icmp (X+Y), (X+Z) -> icmp Y, Z for equalities or if there is no overflow.
2835 if (A && C && (A == C || A == D || B == C || B == D) && NoOp0WrapProblem &&
2836 NoOp1WrapProblem &&
2837 // Try not to increase register pressure.
2838 BO0->hasOneUse() && BO1->hasOneUse()) {
2839 // Determine Y and Z in the form icmp (X+Y), (X+Z).
2840 Value *Y, *Z;
2841 if (A == C) {
2842 // C + B == C + D -> B == D
2843 Y = B;
2844 Z = D;
2845 } else if (A == D) {
2846 // D + B == C + D -> B == C
2847 Y = B;
2848 Z = C;
2849 } else if (B == C) {
2850 // A + C == C + D -> A == D
2851 Y = A;
2852 Z = D;
2853 } else {
2854 assert(B == D);
2855 // A + D == C + D -> A == C
2856 Y = A;
2857 Z = C;
2858 }
2859 return new ICmpInst(Pred, Y, Z);
2860 }
2861
2862 // icmp slt (X + -1), Y -> icmp sle X, Y
2863 if (A && NoOp0WrapProblem && Pred == CmpInst::ICMP_SLT &&
2864 match(B, m_AllOnes()))
2865 return new ICmpInst(CmpInst::ICMP_SLE, A, Op1);
2866
2867 // icmp sge (X + -1), Y -> icmp sgt X, Y
2868 if (A && NoOp0WrapProblem && Pred == CmpInst::ICMP_SGE &&
2869 match(B, m_AllOnes()))
2870 return new ICmpInst(CmpInst::ICMP_SGT, A, Op1);
2871
2872 // icmp sle (X + 1), Y -> icmp slt X, Y
2873 if (A && NoOp0WrapProblem && Pred == CmpInst::ICMP_SLE && match(B, m_One()))
2874 return new ICmpInst(CmpInst::ICMP_SLT, A, Op1);
2875
2876 // icmp sgt (X + 1), Y -> icmp sge X, Y
2877 if (A && NoOp0WrapProblem && Pred == CmpInst::ICMP_SGT && match(B, m_One()))
2878 return new ICmpInst(CmpInst::ICMP_SGE, A, Op1);
2879
2880 // icmp sgt X, (Y + -1) -> icmp sge X, Y
2881 if (C && NoOp1WrapProblem && Pred == CmpInst::ICMP_SGT &&
2882 match(D, m_AllOnes()))
2883 return new ICmpInst(CmpInst::ICMP_SGE, Op0, C);
2884
2885 // icmp sle X, (Y + -1) -> icmp slt X, Y
2886 if (C && NoOp1WrapProblem && Pred == CmpInst::ICMP_SLE &&
2887 match(D, m_AllOnes()))
2888 return new ICmpInst(CmpInst::ICMP_SLT, Op0, C);
2889
2890 // icmp sge X, (Y + 1) -> icmp sgt X, Y
2891 if (C && NoOp1WrapProblem && Pred == CmpInst::ICMP_SGE && match(D, m_One()))
2892 return new ICmpInst(CmpInst::ICMP_SGT, Op0, C);
2893
2894 // icmp slt X, (Y + 1) -> icmp sle X, Y
2895 if (C && NoOp1WrapProblem && Pred == CmpInst::ICMP_SLT && match(D, m_One()))
2896 return new ICmpInst(CmpInst::ICMP_SLE, Op0, C);
2897
Sanjay Patel40f40172017-01-13 23:25:46 +00002898 // TODO: The subtraction-related identities shown below also hold, but
2899 // canonicalization from (X -nuw 1) to (X + -1) means that the combinations
2900 // wouldn't happen even if they were implemented.
2901 //
2902 // icmp ult (X - 1), Y -> icmp ule X, Y
2903 // icmp uge (X - 1), Y -> icmp ugt X, Y
2904 // icmp ugt X, (Y - 1) -> icmp uge X, Y
2905 // icmp ule X, (Y - 1) -> icmp ult X, Y
2906
2907 // icmp ule (X + 1), Y -> icmp ult X, Y
2908 if (A && NoOp0WrapProblem && Pred == CmpInst::ICMP_ULE && match(B, m_One()))
2909 return new ICmpInst(CmpInst::ICMP_ULT, A, Op1);
2910
2911 // icmp ugt (X + 1), Y -> icmp uge X, Y
2912 if (A && NoOp0WrapProblem && Pred == CmpInst::ICMP_UGT && match(B, m_One()))
2913 return new ICmpInst(CmpInst::ICMP_UGE, A, Op1);
2914
2915 // icmp uge X, (Y + 1) -> icmp ugt X, Y
2916 if (C && NoOp1WrapProblem && Pred == CmpInst::ICMP_UGE && match(D, m_One()))
2917 return new ICmpInst(CmpInst::ICMP_UGT, Op0, C);
2918
2919 // icmp ult X, (Y + 1) -> icmp ule X, Y
2920 if (C && NoOp1WrapProblem && Pred == CmpInst::ICMP_ULT && match(D, m_One()))
2921 return new ICmpInst(CmpInst::ICMP_ULE, Op0, C);
2922
Sanjay Patel10494b22016-09-16 16:10:22 +00002923 // if C1 has greater magnitude than C2:
2924 // icmp (X + C1), (Y + C2) -> icmp (X + C3), Y
2925 // s.t. C3 = C1 - C2
2926 //
2927 // if C2 has greater magnitude than C1:
2928 // icmp (X + C1), (Y + C2) -> icmp X, (Y + C3)
2929 // s.t. C3 = C2 - C1
2930 if (A && C && NoOp0WrapProblem && NoOp1WrapProblem &&
2931 (BO0->hasOneUse() || BO1->hasOneUse()) && !I.isUnsigned())
2932 if (ConstantInt *C1 = dyn_cast<ConstantInt>(B))
2933 if (ConstantInt *C2 = dyn_cast<ConstantInt>(D)) {
2934 const APInt &AP1 = C1->getValue();
2935 const APInt &AP2 = C2->getValue();
2936 if (AP1.isNegative() == AP2.isNegative()) {
2937 APInt AP1Abs = C1->getValue().abs();
2938 APInt AP2Abs = C2->getValue().abs();
2939 if (AP1Abs.uge(AP2Abs)) {
2940 ConstantInt *C3 = Builder->getInt(AP1 - AP2);
2941 Value *NewAdd = Builder->CreateNSWAdd(A, C3);
2942 return new ICmpInst(Pred, NewAdd, C);
2943 } else {
2944 ConstantInt *C3 = Builder->getInt(AP2 - AP1);
2945 Value *NewAdd = Builder->CreateNSWAdd(C, C3);
2946 return new ICmpInst(Pred, A, NewAdd);
2947 }
2948 }
2949 }
2950
2951 // Analyze the case when either Op0 or Op1 is a sub instruction.
2952 // Op0 = A - B (or A and B are null); Op1 = C - D (or C and D are null).
2953 A = nullptr;
2954 B = nullptr;
2955 C = nullptr;
2956 D = nullptr;
2957 if (BO0 && BO0->getOpcode() == Instruction::Sub) {
2958 A = BO0->getOperand(0);
2959 B = BO0->getOperand(1);
2960 }
2961 if (BO1 && BO1->getOpcode() == Instruction::Sub) {
2962 C = BO1->getOperand(0);
2963 D = BO1->getOperand(1);
2964 }
2965
2966 // icmp (X-Y), X -> icmp 0, Y for equalities or if there is no overflow.
2967 if (A == Op1 && NoOp0WrapProblem)
2968 return new ICmpInst(Pred, Constant::getNullValue(Op1->getType()), B);
2969
2970 // icmp X, (X-Y) -> icmp Y, 0 for equalities or if there is no overflow.
2971 if (C == Op0 && NoOp1WrapProblem)
2972 return new ICmpInst(Pred, D, Constant::getNullValue(Op0->getType()));
2973
2974 // icmp (Y-X), (Z-X) -> icmp Y, Z for equalities or if there is no overflow.
2975 if (B && D && B == D && NoOp0WrapProblem && NoOp1WrapProblem &&
2976 // Try not to increase register pressure.
2977 BO0->hasOneUse() && BO1->hasOneUse())
2978 return new ICmpInst(Pred, A, C);
2979
2980 // icmp (X-Y), (X-Z) -> icmp Z, Y for equalities or if there is no overflow.
2981 if (A && C && A == C && NoOp0WrapProblem && NoOp1WrapProblem &&
2982 // Try not to increase register pressure.
2983 BO0->hasOneUse() && BO1->hasOneUse())
2984 return new ICmpInst(Pred, D, B);
2985
2986 // icmp (0-X) < cst --> x > -cst
2987 if (NoOp0WrapProblem && ICmpInst::isSigned(Pred)) {
2988 Value *X;
2989 if (match(BO0, m_Neg(m_Value(X))))
2990 if (ConstantInt *RHSC = dyn_cast<ConstantInt>(Op1))
2991 if (!RHSC->isMinValue(/*isSigned=*/true))
2992 return new ICmpInst(I.getSwappedPredicate(), X,
2993 ConstantExpr::getNeg(RHSC));
2994 }
2995
2996 BinaryOperator *SRem = nullptr;
2997 // icmp (srem X, Y), Y
2998 if (BO0 && BO0->getOpcode() == Instruction::SRem && Op1 == BO0->getOperand(1))
2999 SRem = BO0;
3000 // icmp Y, (srem X, Y)
3001 else if (BO1 && BO1->getOpcode() == Instruction::SRem &&
3002 Op0 == BO1->getOperand(1))
3003 SRem = BO1;
3004 if (SRem) {
3005 // We don't check hasOneUse to avoid increasing register pressure because
3006 // the value we use is the same value this instruction was already using.
3007 switch (SRem == BO0 ? ICmpInst::getSwappedPredicate(Pred) : Pred) {
3008 default:
3009 break;
3010 case ICmpInst::ICMP_EQ:
3011 return replaceInstUsesWith(I, ConstantInt::getFalse(I.getType()));
3012 case ICmpInst::ICMP_NE:
3013 return replaceInstUsesWith(I, ConstantInt::getTrue(I.getType()));
3014 case ICmpInst::ICMP_SGT:
3015 case ICmpInst::ICMP_SGE:
3016 return new ICmpInst(ICmpInst::ICMP_SGT, SRem->getOperand(1),
3017 Constant::getAllOnesValue(SRem->getType()));
3018 case ICmpInst::ICMP_SLT:
3019 case ICmpInst::ICMP_SLE:
3020 return new ICmpInst(ICmpInst::ICMP_SLT, SRem->getOperand(1),
3021 Constant::getNullValue(SRem->getType()));
3022 }
3023 }
3024
3025 if (BO0 && BO1 && BO0->getOpcode() == BO1->getOpcode() && BO0->hasOneUse() &&
3026 BO1->hasOneUse() && BO0->getOperand(1) == BO1->getOperand(1)) {
3027 switch (BO0->getOpcode()) {
3028 default:
3029 break;
3030 case Instruction::Add:
3031 case Instruction::Sub:
Sanjay Pateld3106ad2017-05-23 17:29:58 +00003032 case Instruction::Xor: {
Sanjay Patel10494b22016-09-16 16:10:22 +00003033 if (I.isEquality()) // a+x icmp eq/ne b+x --> a icmp b
Sanjay Patel2a062632017-05-08 16:33:42 +00003034 return new ICmpInst(Pred, BO0->getOperand(0), BO1->getOperand(0));
Sanjay Pateld3106ad2017-05-23 17:29:58 +00003035
3036 const APInt *C;
3037 if (match(BO0->getOperand(1), m_APInt(C))) {
3038 // icmp u/s (a ^ signmask), (b ^ signmask) --> icmp s/u a, b
3039 if (C->isSignMask()) {
Sanjay Patel2a062632017-05-08 16:33:42 +00003040 ICmpInst::Predicate NewPred =
Sanjay Patel10494b22016-09-16 16:10:22 +00003041 I.isSigned() ? I.getUnsignedPredicate() : I.getSignedPredicate();
Sanjay Patel2a062632017-05-08 16:33:42 +00003042 return new ICmpInst(NewPred, BO0->getOperand(0), BO1->getOperand(0));
Sanjay Patel10494b22016-09-16 16:10:22 +00003043 }
3044
Sanjay Pateld3106ad2017-05-23 17:29:58 +00003045 // icmp u/s (a ^ maxsignval), (b ^ maxsignval) --> icmp s/u' a, b
3046 if (BO0->getOpcode() == Instruction::Xor && C->isMaxSignedValue()) {
Sanjay Patel2a062632017-05-08 16:33:42 +00003047 ICmpInst::Predicate NewPred =
Sanjay Patel10494b22016-09-16 16:10:22 +00003048 I.isSigned() ? I.getUnsignedPredicate() : I.getSignedPredicate();
Sanjay Patel2a062632017-05-08 16:33:42 +00003049 NewPred = I.getSwappedPredicate(NewPred);
3050 return new ICmpInst(NewPred, BO0->getOperand(0), BO1->getOperand(0));
Sanjay Patel10494b22016-09-16 16:10:22 +00003051 }
3052 }
3053 break;
Sanjay Pateld3106ad2017-05-23 17:29:58 +00003054 }
Sanjay Patel10494b22016-09-16 16:10:22 +00003055 case Instruction::Mul:
3056 if (!I.isEquality())
3057 break;
3058
3059 if (ConstantInt *CI = dyn_cast<ConstantInt>(BO0->getOperand(1))) {
3060 // a * Cst icmp eq/ne b * Cst --> a & Mask icmp b & Mask
3061 // Mask = -1 >> count-trailing-zeros(Cst).
3062 if (!CI->isZero() && !CI->isOne()) {
3063 const APInt &AP = CI->getValue();
3064 ConstantInt *Mask = ConstantInt::get(
3065 I.getContext(),
3066 APInt::getLowBitsSet(AP.getBitWidth(),
3067 AP.getBitWidth() - AP.countTrailingZeros()));
3068 Value *And1 = Builder->CreateAnd(BO0->getOperand(0), Mask);
3069 Value *And2 = Builder->CreateAnd(BO1->getOperand(0), Mask);
Sanjay Patel2a062632017-05-08 16:33:42 +00003070 return new ICmpInst(Pred, And1, And2);
Sanjay Patel10494b22016-09-16 16:10:22 +00003071 }
3072 }
3073 break;
Sanjay Patel878715f2017-05-15 19:27:53 +00003074
Sanjay Patel10494b22016-09-16 16:10:22 +00003075 case Instruction::UDiv:
3076 case Instruction::LShr:
Sanjay Patel878715f2017-05-15 19:27:53 +00003077 if (I.isSigned() || !BO0->isExact() || !BO1->isExact())
Sanjay Patel10494b22016-09-16 16:10:22 +00003078 break;
Sanjay Patel878715f2017-05-15 19:27:53 +00003079 return new ICmpInst(Pred, BO0->getOperand(0), BO1->getOperand(0));
3080
Sanjay Patel10494b22016-09-16 16:10:22 +00003081 case Instruction::SDiv:
Sanjay Patel878715f2017-05-15 19:27:53 +00003082 if (!I.isEquality() || !BO0->isExact() || !BO1->isExact())
3083 break;
3084 return new ICmpInst(Pred, BO0->getOperand(0), BO1->getOperand(0));
3085
Sanjay Patel10494b22016-09-16 16:10:22 +00003086 case Instruction::AShr:
3087 if (!BO0->isExact() || !BO1->isExact())
3088 break;
Sanjay Patel2a062632017-05-08 16:33:42 +00003089 return new ICmpInst(Pred, BO0->getOperand(0), BO1->getOperand(0));
Sanjay Patel878715f2017-05-15 19:27:53 +00003090
Sanjay Patel10494b22016-09-16 16:10:22 +00003091 case Instruction::Shl: {
3092 bool NUW = BO0->hasNoUnsignedWrap() && BO1->hasNoUnsignedWrap();
3093 bool NSW = BO0->hasNoSignedWrap() && BO1->hasNoSignedWrap();
3094 if (!NUW && !NSW)
3095 break;
3096 if (!NSW && I.isSigned())
3097 break;
Sanjay Patel2a062632017-05-08 16:33:42 +00003098 return new ICmpInst(Pred, BO0->getOperand(0), BO1->getOperand(0));
Sanjay Patel10494b22016-09-16 16:10:22 +00003099 }
3100 }
3101 }
3102
3103 if (BO0) {
3104 // Transform A & (L - 1) `ult` L --> L != 0
3105 auto LSubOne = m_Add(m_Specific(Op1), m_AllOnes());
3106 auto BitwiseAnd =
3107 m_CombineOr(m_And(m_Value(), LSubOne), m_And(LSubOne, m_Value()));
3108
Sanjay Patel2a062632017-05-08 16:33:42 +00003109 if (match(BO0, BitwiseAnd) && Pred == ICmpInst::ICMP_ULT) {
Sanjay Patel10494b22016-09-16 16:10:22 +00003110 auto *Zero = Constant::getNullValue(BO0->getType());
3111 return new ICmpInst(ICmpInst::ICMP_NE, Op1, Zero);
3112 }
3113 }
3114
3115 return nullptr;
3116}
3117
Sanjay Pateldd46b522016-12-19 17:32:37 +00003118/// Fold icmp Pred min|max(X, Y), X.
3119static Instruction *foldICmpWithMinMax(ICmpInst &Cmp) {
Sanjay Pateld6406412016-12-15 19:13:37 +00003120 ICmpInst::Predicate Pred = Cmp.getPredicate();
3121 Value *Op0 = Cmp.getOperand(0);
3122 Value *X = Cmp.getOperand(1);
3123
Sanjay Pateldd46b522016-12-19 17:32:37 +00003124 // Canonicalize minimum or maximum operand to LHS of the icmp.
Sanjay Patel8296c6c2016-12-19 16:28:53 +00003125 if (match(X, m_c_SMin(m_Specific(Op0), m_Value())) ||
Sanjay Pateldd46b522016-12-19 17:32:37 +00003126 match(X, m_c_SMax(m_Specific(Op0), m_Value())) ||
3127 match(X, m_c_UMin(m_Specific(Op0), m_Value())) ||
3128 match(X, m_c_UMax(m_Specific(Op0), m_Value()))) {
Sanjay Pateld6406412016-12-15 19:13:37 +00003129 std::swap(Op0, X);
3130 Pred = Cmp.getSwappedPredicate();
3131 }
3132
3133 Value *Y;
Sanjay Patel8296c6c2016-12-19 16:28:53 +00003134 if (match(Op0, m_c_SMin(m_Specific(X), m_Value(Y)))) {
Sanjay Pateldd46b522016-12-19 17:32:37 +00003135 // smin(X, Y) == X --> X s<= Y
3136 // smin(X, Y) s>= X --> X s<= Y
Sanjay Patel8296c6c2016-12-19 16:28:53 +00003137 if (Pred == CmpInst::ICMP_EQ || Pred == CmpInst::ICMP_SGE)
3138 return new ICmpInst(ICmpInst::ICMP_SLE, X, Y);
3139
Sanjay Pateldd46b522016-12-19 17:32:37 +00003140 // smin(X, Y) != X --> X s> Y
3141 // smin(X, Y) s< X --> X s> Y
Sanjay Patel8296c6c2016-12-19 16:28:53 +00003142 if (Pred == CmpInst::ICMP_NE || Pred == CmpInst::ICMP_SLT)
3143 return new ICmpInst(ICmpInst::ICMP_SGT, X, Y);
3144
3145 // These cases should be handled in InstSimplify:
Sanjay Pateldd46b522016-12-19 17:32:37 +00003146 // smin(X, Y) s<= X --> true
3147 // smin(X, Y) s> X --> false
Sanjay Pateld6406412016-12-15 19:13:37 +00003148 return nullptr;
Sanjay Patel8296c6c2016-12-19 16:28:53 +00003149 }
Sanjay Pateldd46b522016-12-19 17:32:37 +00003150
Sanjay Patel8296c6c2016-12-19 16:28:53 +00003151 if (match(Op0, m_c_SMax(m_Specific(X), m_Value(Y)))) {
Sanjay Pateldd46b522016-12-19 17:32:37 +00003152 // smax(X, Y) == X --> X s>= Y
3153 // smax(X, Y) s<= X --> X s>= Y
Sanjay Patel8296c6c2016-12-19 16:28:53 +00003154 if (Pred == CmpInst::ICMP_EQ || Pred == CmpInst::ICMP_SLE)
3155 return new ICmpInst(ICmpInst::ICMP_SGE, X, Y);
Sanjay Pateld6406412016-12-15 19:13:37 +00003156
Sanjay Pateldd46b522016-12-19 17:32:37 +00003157 // smax(X, Y) != X --> X s< Y
3158 // smax(X, Y) s> X --> X s< Y
Sanjay Patel8296c6c2016-12-19 16:28:53 +00003159 if (Pred == CmpInst::ICMP_NE || Pred == CmpInst::ICMP_SGT)
3160 return new ICmpInst(ICmpInst::ICMP_SLT, X, Y);
Sanjay Pateld6406412016-12-15 19:13:37 +00003161
Sanjay Patel8296c6c2016-12-19 16:28:53 +00003162 // These cases should be handled in InstSimplify:
Sanjay Pateldd46b522016-12-19 17:32:37 +00003163 // smax(X, Y) s>= X --> true
3164 // smax(X, Y) s< X --> false
3165 return nullptr;
3166 }
3167
3168 if (match(Op0, m_c_UMin(m_Specific(X), m_Value(Y)))) {
3169 // umin(X, Y) == X --> X u<= Y
3170 // umin(X, Y) u>= X --> X u<= Y
3171 if (Pred == CmpInst::ICMP_EQ || Pred == CmpInst::ICMP_UGE)
3172 return new ICmpInst(ICmpInst::ICMP_ULE, X, Y);
3173
3174 // umin(X, Y) != X --> X u> Y
3175 // umin(X, Y) u< X --> X u> Y
3176 if (Pred == CmpInst::ICMP_NE || Pred == CmpInst::ICMP_ULT)
3177 return new ICmpInst(ICmpInst::ICMP_UGT, X, Y);
3178
3179 // These cases should be handled in InstSimplify:
3180 // umin(X, Y) u<= X --> true
3181 // umin(X, Y) u> X --> false
3182 return nullptr;
3183 }
3184
3185 if (match(Op0, m_c_UMax(m_Specific(X), m_Value(Y)))) {
3186 // umax(X, Y) == X --> X u>= Y
3187 // umax(X, Y) u<= X --> X u>= Y
3188 if (Pred == CmpInst::ICMP_EQ || Pred == CmpInst::ICMP_ULE)
3189 return new ICmpInst(ICmpInst::ICMP_UGE, X, Y);
3190
3191 // umax(X, Y) != X --> X u< Y
3192 // umax(X, Y) u> X --> X u< Y
3193 if (Pred == CmpInst::ICMP_NE || Pred == CmpInst::ICMP_UGT)
3194 return new ICmpInst(ICmpInst::ICMP_ULT, X, Y);
3195
3196 // These cases should be handled in InstSimplify:
3197 // umax(X, Y) u>= X --> true
3198 // umax(X, Y) u< X --> false
Sanjay Patel8296c6c2016-12-19 16:28:53 +00003199 return nullptr;
3200 }
Sanjay Pateld6406412016-12-15 19:13:37 +00003201
Sanjay Pateld6406412016-12-15 19:13:37 +00003202 return nullptr;
3203}
3204
Sanjay Patel10494b22016-09-16 16:10:22 +00003205Instruction *InstCombiner::foldICmpEquality(ICmpInst &I) {
3206 if (!I.isEquality())
3207 return nullptr;
3208
3209 Value *Op0 = I.getOperand(0), *Op1 = I.getOperand(1);
3210 Value *A, *B, *C, *D;
3211 if (match(Op0, m_Xor(m_Value(A), m_Value(B)))) {
3212 if (A == Op1 || B == Op1) { // (A^B) == A -> B == 0
3213 Value *OtherVal = A == Op1 ? B : A;
3214 return new ICmpInst(I.getPredicate(), OtherVal,
3215 Constant::getNullValue(A->getType()));
3216 }
3217
3218 if (match(Op1, m_Xor(m_Value(C), m_Value(D)))) {
3219 // A^c1 == C^c2 --> A == C^(c1^c2)
3220 ConstantInt *C1, *C2;
3221 if (match(B, m_ConstantInt(C1)) && match(D, m_ConstantInt(C2)) &&
3222 Op1->hasOneUse()) {
3223 Constant *NC = Builder->getInt(C1->getValue() ^ C2->getValue());
3224 Value *Xor = Builder->CreateXor(C, NC);
3225 return new ICmpInst(I.getPredicate(), A, Xor);
3226 }
3227
3228 // A^B == A^D -> B == D
3229 if (A == C)
3230 return new ICmpInst(I.getPredicate(), B, D);
3231 if (A == D)
3232 return new ICmpInst(I.getPredicate(), B, C);
3233 if (B == C)
3234 return new ICmpInst(I.getPredicate(), A, D);
3235 if (B == D)
3236 return new ICmpInst(I.getPredicate(), A, C);
3237 }
3238 }
3239
3240 if (match(Op1, m_Xor(m_Value(A), m_Value(B))) && (A == Op0 || B == Op0)) {
3241 // A == (A^B) -> B == 0
3242 Value *OtherVal = A == Op0 ? B : A;
3243 return new ICmpInst(I.getPredicate(), OtherVal,
3244 Constant::getNullValue(A->getType()));
3245 }
3246
3247 // (X&Z) == (Y&Z) -> (X^Y) & Z == 0
3248 if (match(Op0, m_OneUse(m_And(m_Value(A), m_Value(B)))) &&
3249 match(Op1, m_OneUse(m_And(m_Value(C), m_Value(D))))) {
3250 Value *X = nullptr, *Y = nullptr, *Z = nullptr;
3251
3252 if (A == C) {
3253 X = B;
3254 Y = D;
3255 Z = A;
3256 } else if (A == D) {
3257 X = B;
3258 Y = C;
3259 Z = A;
3260 } else if (B == C) {
3261 X = A;
3262 Y = D;
3263 Z = B;
3264 } else if (B == D) {
3265 X = A;
3266 Y = C;
3267 Z = B;
3268 }
3269
3270 if (X) { // Build (X^Y) & Z
3271 Op1 = Builder->CreateXor(X, Y);
3272 Op1 = Builder->CreateAnd(Op1, Z);
3273 I.setOperand(0, Op1);
3274 I.setOperand(1, Constant::getNullValue(Op1->getType()));
3275 return &I;
3276 }
3277 }
3278
3279 // Transform (zext A) == (B & (1<<X)-1) --> A == (trunc B)
3280 // and (B & (1<<X)-1) == (zext A) --> A == (trunc B)
3281 ConstantInt *Cst1;
3282 if ((Op0->hasOneUse() && match(Op0, m_ZExt(m_Value(A))) &&
3283 match(Op1, m_And(m_Value(B), m_ConstantInt(Cst1)))) ||
3284 (Op1->hasOneUse() && match(Op0, m_And(m_Value(B), m_ConstantInt(Cst1))) &&
3285 match(Op1, m_ZExt(m_Value(A))))) {
3286 APInt Pow2 = Cst1->getValue() + 1;
3287 if (Pow2.isPowerOf2() && isa<IntegerType>(A->getType()) &&
3288 Pow2.logBase2() == cast<IntegerType>(A->getType())->getBitWidth())
3289 return new ICmpInst(I.getPredicate(), A,
3290 Builder->CreateTrunc(B, A->getType()));
3291 }
3292
3293 // (A >> C) == (B >> C) --> (A^B) u< (1 << C)
3294 // For lshr and ashr pairs.
3295 if ((match(Op0, m_OneUse(m_LShr(m_Value(A), m_ConstantInt(Cst1)))) &&
3296 match(Op1, m_OneUse(m_LShr(m_Value(B), m_Specific(Cst1))))) ||
3297 (match(Op0, m_OneUse(m_AShr(m_Value(A), m_ConstantInt(Cst1)))) &&
3298 match(Op1, m_OneUse(m_AShr(m_Value(B), m_Specific(Cst1)))))) {
3299 unsigned TypeBits = Cst1->getBitWidth();
3300 unsigned ShAmt = (unsigned)Cst1->getLimitedValue(TypeBits);
3301 if (ShAmt < TypeBits && ShAmt != 0) {
3302 ICmpInst::Predicate Pred = I.getPredicate() == ICmpInst::ICMP_NE
3303 ? ICmpInst::ICMP_UGE
3304 : ICmpInst::ICMP_ULT;
3305 Value *Xor = Builder->CreateXor(A, B, I.getName() + ".unshifted");
3306 APInt CmpVal = APInt::getOneBitSet(TypeBits, ShAmt);
3307 return new ICmpInst(Pred, Xor, Builder->getInt(CmpVal));
3308 }
3309 }
3310
3311 // (A << C) == (B << C) --> ((A^B) & (~0U >> C)) == 0
3312 if (match(Op0, m_OneUse(m_Shl(m_Value(A), m_ConstantInt(Cst1)))) &&
3313 match(Op1, m_OneUse(m_Shl(m_Value(B), m_Specific(Cst1))))) {
3314 unsigned TypeBits = Cst1->getBitWidth();
3315 unsigned ShAmt = (unsigned)Cst1->getLimitedValue(TypeBits);
3316 if (ShAmt < TypeBits && ShAmt != 0) {
3317 Value *Xor = Builder->CreateXor(A, B, I.getName() + ".unshifted");
3318 APInt AndVal = APInt::getLowBitsSet(TypeBits, TypeBits - ShAmt);
3319 Value *And = Builder->CreateAnd(Xor, Builder->getInt(AndVal),
3320 I.getName() + ".mask");
3321 return new ICmpInst(I.getPredicate(), And,
3322 Constant::getNullValue(Cst1->getType()));
3323 }
3324 }
3325
3326 // Transform "icmp eq (trunc (lshr(X, cst1)), cst" to
3327 // "icmp (and X, mask), cst"
3328 uint64_t ShAmt = 0;
3329 if (Op0->hasOneUse() &&
3330 match(Op0, m_Trunc(m_OneUse(m_LShr(m_Value(A), m_ConstantInt(ShAmt))))) &&
3331 match(Op1, m_ConstantInt(Cst1)) &&
3332 // Only do this when A has multiple uses. This is most important to do
3333 // when it exposes other optimizations.
3334 !A->hasOneUse()) {
3335 unsigned ASize = cast<IntegerType>(A->getType())->getPrimitiveSizeInBits();
3336
3337 if (ShAmt < ASize) {
3338 APInt MaskV =
3339 APInt::getLowBitsSet(ASize, Op0->getType()->getPrimitiveSizeInBits());
3340 MaskV <<= ShAmt;
3341
3342 APInt CmpV = Cst1->getValue().zext(ASize);
3343 CmpV <<= ShAmt;
3344
3345 Value *Mask = Builder->CreateAnd(A, Builder->getInt(MaskV));
3346 return new ICmpInst(I.getPredicate(), Mask, Builder->getInt(CmpV));
3347 }
3348 }
3349
3350 return nullptr;
3351}
3352
Sanjay Patel6f8f47b2016-06-05 00:12:32 +00003353/// Handle icmp (cast x to y), (cast/cst). We only handle extending casts so
3354/// far.
Sanjay Patel43395062016-07-21 18:07:40 +00003355Instruction *InstCombiner::foldICmpWithCastAndCast(ICmpInst &ICmp) {
Sanjay Patel6f8f47b2016-06-05 00:12:32 +00003356 const CastInst *LHSCI = cast<CastInst>(ICmp.getOperand(0));
Chris Lattner2188e402010-01-04 07:37:31 +00003357 Value *LHSCIOp = LHSCI->getOperand(0);
Chris Lattner229907c2011-07-18 04:54:35 +00003358 Type *SrcTy = LHSCIOp->getType();
3359 Type *DestTy = LHSCI->getType();
Chris Lattner2188e402010-01-04 07:37:31 +00003360 Value *RHSCIOp;
3361
Jim Grosbach129c52a2011-09-30 18:09:53 +00003362 // Turn icmp (ptrtoint x), (ptrtoint/c) into a compare of the input if the
Chris Lattner2188e402010-01-04 07:37:31 +00003363 // integer type is the same size as the pointer type.
Mehdi Aminia28d91d2015-03-10 02:37:25 +00003364 if (LHSCI->getOpcode() == Instruction::PtrToInt &&
3365 DL.getPointerTypeSizeInBits(SrcTy) == DestTy->getIntegerBitWidth()) {
Craig Topperf40110f2014-04-25 05:29:35 +00003366 Value *RHSOp = nullptr;
Sanjay Patel6f8f47b2016-06-05 00:12:32 +00003367 if (auto *RHSC = dyn_cast<PtrToIntOperator>(ICmp.getOperand(1))) {
Michael Liaod266b922015-02-13 04:51:26 +00003368 Value *RHSCIOp = RHSC->getOperand(0);
3369 if (RHSCIOp->getType()->getPointerAddressSpace() ==
3370 LHSCIOp->getType()->getPointerAddressSpace()) {
3371 RHSOp = RHSC->getOperand(0);
3372 // If the pointer types don't match, insert a bitcast.
3373 if (LHSCIOp->getType() != RHSOp->getType())
3374 RHSOp = Builder->CreateBitCast(RHSOp, LHSCIOp->getType());
3375 }
Sanjay Patel6f8f47b2016-06-05 00:12:32 +00003376 } else if (auto *RHSC = dyn_cast<Constant>(ICmp.getOperand(1))) {
Chris Lattner2188e402010-01-04 07:37:31 +00003377 RHSOp = ConstantExpr::getIntToPtr(RHSC, SrcTy);
Sanjay Patel6f8f47b2016-06-05 00:12:32 +00003378 }
Chris Lattner2188e402010-01-04 07:37:31 +00003379
3380 if (RHSOp)
Sanjay Patel6f8f47b2016-06-05 00:12:32 +00003381 return new ICmpInst(ICmp.getPredicate(), LHSCIOp, RHSOp);
Chris Lattner2188e402010-01-04 07:37:31 +00003382 }
Jim Grosbach129c52a2011-09-30 18:09:53 +00003383
Chris Lattner2188e402010-01-04 07:37:31 +00003384 // The code below only handles extension cast instructions, so far.
3385 // Enforce this.
3386 if (LHSCI->getOpcode() != Instruction::ZExt &&
3387 LHSCI->getOpcode() != Instruction::SExt)
Craig Topperf40110f2014-04-25 05:29:35 +00003388 return nullptr;
Chris Lattner2188e402010-01-04 07:37:31 +00003389
3390 bool isSignedExt = LHSCI->getOpcode() == Instruction::SExt;
Sanjay Patel6f8f47b2016-06-05 00:12:32 +00003391 bool isSignedCmp = ICmp.isSigned();
Chris Lattner2188e402010-01-04 07:37:31 +00003392
Sanjay Patel6f8f47b2016-06-05 00:12:32 +00003393 if (auto *CI = dyn_cast<CastInst>(ICmp.getOperand(1))) {
Chris Lattner2188e402010-01-04 07:37:31 +00003394 // Not an extension from the same type?
3395 RHSCIOp = CI->getOperand(0);
Jim Grosbach129c52a2011-09-30 18:09:53 +00003396 if (RHSCIOp->getType() != LHSCIOp->getType())
Craig Topperf40110f2014-04-25 05:29:35 +00003397 return nullptr;
Jim Grosbach129c52a2011-09-30 18:09:53 +00003398
Chris Lattner2188e402010-01-04 07:37:31 +00003399 // If the signedness of the two casts doesn't agree (i.e. one is a sext
3400 // and the other is a zext), then we can't handle this.
3401 if (CI->getOpcode() != LHSCI->getOpcode())
Craig Topperf40110f2014-04-25 05:29:35 +00003402 return nullptr;
Chris Lattner2188e402010-01-04 07:37:31 +00003403
3404 // Deal with equality cases early.
Sanjay Patel6f8f47b2016-06-05 00:12:32 +00003405 if (ICmp.isEquality())
3406 return new ICmpInst(ICmp.getPredicate(), LHSCIOp, RHSCIOp);
Chris Lattner2188e402010-01-04 07:37:31 +00003407
3408 // A signed comparison of sign extended values simplifies into a
3409 // signed comparison.
3410 if (isSignedCmp && isSignedExt)
Sanjay Patel6f8f47b2016-06-05 00:12:32 +00003411 return new ICmpInst(ICmp.getPredicate(), LHSCIOp, RHSCIOp);
Chris Lattner2188e402010-01-04 07:37:31 +00003412
3413 // The other three cases all fold into an unsigned comparison.
Sanjay Patel6f8f47b2016-06-05 00:12:32 +00003414 return new ICmpInst(ICmp.getUnsignedPredicate(), LHSCIOp, RHSCIOp);
Chris Lattner2188e402010-01-04 07:37:31 +00003415 }
3416
Sanjay Patel4c204232016-06-04 20:39:22 +00003417 // If we aren't dealing with a constant on the RHS, exit early.
Sanjay Patel6f8f47b2016-06-05 00:12:32 +00003418 auto *C = dyn_cast<Constant>(ICmp.getOperand(1));
3419 if (!C)
Craig Topperf40110f2014-04-25 05:29:35 +00003420 return nullptr;
Chris Lattner2188e402010-01-04 07:37:31 +00003421
3422 // Compute the constant that would happen if we truncated to SrcTy then
Sanjay Patelc774f8c2016-06-04 21:20:44 +00003423 // re-extended to DestTy.
Sanjay Patel6f8f47b2016-06-05 00:12:32 +00003424 Constant *Res1 = ConstantExpr::getTrunc(C, SrcTy);
Sanjay Patelc774f8c2016-06-04 21:20:44 +00003425 Constant *Res2 = ConstantExpr::getCast(LHSCI->getOpcode(), Res1, DestTy);
Chris Lattner2188e402010-01-04 07:37:31 +00003426
3427 // If the re-extended constant didn't change...
Sanjay Patel6f8f47b2016-06-05 00:12:32 +00003428 if (Res2 == C) {
Chris Lattner2188e402010-01-04 07:37:31 +00003429 // Deal with equality cases early.
Sanjay Patel6f8f47b2016-06-05 00:12:32 +00003430 if (ICmp.isEquality())
3431 return new ICmpInst(ICmp.getPredicate(), LHSCIOp, Res1);
Chris Lattner2188e402010-01-04 07:37:31 +00003432
3433 // A signed comparison of sign extended values simplifies into a
3434 // signed comparison.
3435 if (isSignedExt && isSignedCmp)
Sanjay Patel6f8f47b2016-06-05 00:12:32 +00003436 return new ICmpInst(ICmp.getPredicate(), LHSCIOp, Res1);
Chris Lattner2188e402010-01-04 07:37:31 +00003437
3438 // The other three cases all fold into an unsigned comparison.
Sanjay Patel6f8f47b2016-06-05 00:12:32 +00003439 return new ICmpInst(ICmp.getUnsignedPredicate(), LHSCIOp, Res1);
Chris Lattner2188e402010-01-04 07:37:31 +00003440 }
3441
Sanjay Patel6a333c32016-06-06 16:56:57 +00003442 // The re-extended constant changed, partly changed (in the case of a vector),
3443 // or could not be determined to be equal (in the case of a constant
3444 // expression), so the constant cannot be represented in the shorter type.
3445 // Consequently, we cannot emit a simple comparison.
Duncan Sands8fb2c382011-01-20 13:21:55 +00003446 // All the cases that fold to true or false will have already been handled
3447 // by SimplifyICmpInst, so only deal with the tricky case.
Chris Lattner2188e402010-01-04 07:37:31 +00003448
Sanjay Patel6a333c32016-06-06 16:56:57 +00003449 if (isSignedCmp || !isSignedExt || !isa<ConstantInt>(C))
Craig Topperf40110f2014-04-25 05:29:35 +00003450 return nullptr;
Chris Lattner2188e402010-01-04 07:37:31 +00003451
3452 // Evaluate the comparison for LT (we invert for GT below). LE and GE cases
3453 // should have been folded away previously and not enter in here.
Duncan Sands8fb2c382011-01-20 13:21:55 +00003454
3455 // We're performing an unsigned comp with a sign extended value.
3456 // This is true if the input is >= 0. [aka >s -1]
3457 Constant *NegOne = Constant::getAllOnesValue(SrcTy);
Sanjay Patel6f8f47b2016-06-05 00:12:32 +00003458 Value *Result = Builder->CreateICmpSGT(LHSCIOp, NegOne, ICmp.getName());
Chris Lattner2188e402010-01-04 07:37:31 +00003459
3460 // Finally, return the value computed.
Sanjay Patel6f8f47b2016-06-05 00:12:32 +00003461 if (ICmp.getPredicate() == ICmpInst::ICMP_ULT)
3462 return replaceInstUsesWith(ICmp, Result);
Chris Lattner2188e402010-01-04 07:37:31 +00003463
Sanjay Patel6f8f47b2016-06-05 00:12:32 +00003464 assert(ICmp.getPredicate() == ICmpInst::ICMP_UGT && "ICmp should be folded!");
Chris Lattner2188e402010-01-04 07:37:31 +00003465 return BinaryOperator::CreateNot(Result);
3466}
3467
Sanjoy Dasb0984472015-04-08 04:27:22 +00003468bool InstCombiner::OptimizeOverflowCheck(OverflowCheckFlavor OCF, Value *LHS,
3469 Value *RHS, Instruction &OrigI,
3470 Value *&Result, Constant *&Overflow) {
Sanjoy Das827529e2015-08-11 21:33:55 +00003471 if (OrigI.isCommutative() && isa<Constant>(LHS) && !isa<Constant>(RHS))
3472 std::swap(LHS, RHS);
Sanjoy Dasb0984472015-04-08 04:27:22 +00003473
3474 auto SetResult = [&](Value *OpResult, Constant *OverflowVal, bool ReuseName) {
3475 Result = OpResult;
3476 Overflow = OverflowVal;
3477 if (ReuseName)
3478 Result->takeName(&OrigI);
3479 return true;
3480 };
3481
Sanjoy Das6f5dca72015-08-28 19:09:31 +00003482 // If the overflow check was an add followed by a compare, the insertion point
3483 // may be pointing to the compare. We want to insert the new instructions
3484 // before the add in case there are uses of the add between the add and the
3485 // compare.
3486 Builder->SetInsertPoint(&OrigI);
3487
Sanjoy Dasb0984472015-04-08 04:27:22 +00003488 switch (OCF) {
3489 case OCF_INVALID:
3490 llvm_unreachable("bad overflow check kind!");
3491
3492 case OCF_UNSIGNED_ADD: {
3493 OverflowResult OR = computeOverflowForUnsignedAdd(LHS, RHS, &OrigI);
3494 if (OR == OverflowResult::NeverOverflows)
3495 return SetResult(Builder->CreateNUWAdd(LHS, RHS), Builder->getFalse(),
3496 true);
3497
3498 if (OR == OverflowResult::AlwaysOverflows)
3499 return SetResult(Builder->CreateAdd(LHS, RHS), Builder->getTrue(), true);
Justin Bognercd1d5aa2016-08-17 20:30:52 +00003500
3501 // Fall through uadd into sadd
3502 LLVM_FALLTHROUGH;
Sanjoy Dasb0984472015-04-08 04:27:22 +00003503 }
Sanjoy Dasb0984472015-04-08 04:27:22 +00003504 case OCF_SIGNED_ADD: {
David Majnemer27e89ba2015-05-21 23:04:21 +00003505 // X + 0 -> {X, false}
3506 if (match(RHS, m_Zero()))
3507 return SetResult(LHS, Builder->getFalse(), false);
Sanjoy Dasb0984472015-04-08 04:27:22 +00003508
3509 // We can strength reduce this signed add into a regular add if we can prove
3510 // that it will never overflow.
3511 if (OCF == OCF_SIGNED_ADD)
Craig Topper2b1fc322017-05-22 06:25:31 +00003512 if (willNotOverflowSignedAdd(LHS, RHS, OrigI))
Sanjoy Dasb0984472015-04-08 04:27:22 +00003513 return SetResult(Builder->CreateNSWAdd(LHS, RHS), Builder->getFalse(),
3514 true);
Sanjoy Das72cb5e12015-06-05 18:04:42 +00003515 break;
Sanjoy Dasb0984472015-04-08 04:27:22 +00003516 }
3517
3518 case OCF_UNSIGNED_SUB:
3519 case OCF_SIGNED_SUB: {
David Majnemer27e89ba2015-05-21 23:04:21 +00003520 // X - 0 -> {X, false}
3521 if (match(RHS, m_Zero()))
3522 return SetResult(LHS, Builder->getFalse(), false);
Sanjoy Dasb0984472015-04-08 04:27:22 +00003523
3524 if (OCF == OCF_SIGNED_SUB) {
Craig Topper2b1fc322017-05-22 06:25:31 +00003525 if (willNotOverflowSignedSub(LHS, RHS, OrigI))
Sanjoy Dasb0984472015-04-08 04:27:22 +00003526 return SetResult(Builder->CreateNSWSub(LHS, RHS), Builder->getFalse(),
3527 true);
3528 } else {
Craig Topper2b1fc322017-05-22 06:25:31 +00003529 if (willNotOverflowUnsignedSub(LHS, RHS, OrigI))
Sanjoy Dasb0984472015-04-08 04:27:22 +00003530 return SetResult(Builder->CreateNUWSub(LHS, RHS), Builder->getFalse(),
3531 true);
3532 }
3533 break;
3534 }
3535
3536 case OCF_UNSIGNED_MUL: {
3537 OverflowResult OR = computeOverflowForUnsignedMul(LHS, RHS, &OrigI);
3538 if (OR == OverflowResult::NeverOverflows)
3539 return SetResult(Builder->CreateNUWMul(LHS, RHS), Builder->getFalse(),
3540 true);
3541 if (OR == OverflowResult::AlwaysOverflows)
3542 return SetResult(Builder->CreateMul(LHS, RHS), Builder->getTrue(), true);
Justin Bognercd1d5aa2016-08-17 20:30:52 +00003543 LLVM_FALLTHROUGH;
3544 }
Sanjoy Dasb0984472015-04-08 04:27:22 +00003545 case OCF_SIGNED_MUL:
3546 // X * undef -> undef
3547 if (isa<UndefValue>(RHS))
David Majnemer27e89ba2015-05-21 23:04:21 +00003548 return SetResult(RHS, UndefValue::get(Builder->getInt1Ty()), false);
Sanjoy Dasb0984472015-04-08 04:27:22 +00003549
David Majnemer27e89ba2015-05-21 23:04:21 +00003550 // X * 0 -> {0, false}
3551 if (match(RHS, m_Zero()))
3552 return SetResult(RHS, Builder->getFalse(), false);
Sanjoy Dasb0984472015-04-08 04:27:22 +00003553
David Majnemer27e89ba2015-05-21 23:04:21 +00003554 // X * 1 -> {X, false}
3555 if (match(RHS, m_One()))
3556 return SetResult(LHS, Builder->getFalse(), false);
Sanjoy Dasb0984472015-04-08 04:27:22 +00003557
3558 if (OCF == OCF_SIGNED_MUL)
Craig Topper2b1fc322017-05-22 06:25:31 +00003559 if (willNotOverflowSignedMul(LHS, RHS, OrigI))
Sanjoy Dasb0984472015-04-08 04:27:22 +00003560 return SetResult(Builder->CreateNSWMul(LHS, RHS), Builder->getFalse(),
3561 true);
Sanjoy Dasc80dad62015-06-05 18:04:46 +00003562 break;
Sanjoy Dasb0984472015-04-08 04:27:22 +00003563 }
3564
3565 return false;
3566}
3567
Serge Pavlov4bb54d52014-04-13 18:23:41 +00003568/// \brief Recognize and process idiom involving test for multiplication
3569/// overflow.
3570///
3571/// The caller has matched a pattern of the form:
3572/// I = cmp u (mul(zext A, zext B), V
3573/// The function checks if this is a test for overflow and if so replaces
3574/// multiplication with call to 'mul.with.overflow' intrinsic.
3575///
3576/// \param I Compare instruction.
3577/// \param MulVal Result of 'mult' instruction. It is one of the arguments of
3578/// the compare instruction. Must be of integer type.
3579/// \param OtherVal The other argument of compare instruction.
3580/// \returns Instruction which must replace the compare instruction, NULL if no
3581/// replacement required.
Sanjay Pateld93c4c02016-09-15 18:22:25 +00003582static Instruction *processUMulZExtIdiom(ICmpInst &I, Value *MulVal,
Serge Pavlov4bb54d52014-04-13 18:23:41 +00003583 Value *OtherVal, InstCombiner &IC) {
Benjamin Kramerc96a7f82014-06-24 10:47:52 +00003584 // Don't bother doing this transformation for pointers, don't do it for
3585 // vectors.
3586 if (!isa<IntegerType>(MulVal->getType()))
3587 return nullptr;
3588
Serge Pavlov4bb54d52014-04-13 18:23:41 +00003589 assert(I.getOperand(0) == MulVal || I.getOperand(1) == MulVal);
3590 assert(I.getOperand(0) == OtherVal || I.getOperand(1) == OtherVal);
David Majnemerdaa24b92015-09-05 20:44:56 +00003591 auto *MulInstr = dyn_cast<Instruction>(MulVal);
3592 if (!MulInstr)
3593 return nullptr;
Serge Pavlov4bb54d52014-04-13 18:23:41 +00003594 assert(MulInstr->getOpcode() == Instruction::Mul);
3595
David Majnemer634ca232014-11-01 23:46:05 +00003596 auto *LHS = cast<ZExtOperator>(MulInstr->getOperand(0)),
3597 *RHS = cast<ZExtOperator>(MulInstr->getOperand(1));
Serge Pavlov4bb54d52014-04-13 18:23:41 +00003598 assert(LHS->getOpcode() == Instruction::ZExt);
3599 assert(RHS->getOpcode() == Instruction::ZExt);
3600 Value *A = LHS->getOperand(0), *B = RHS->getOperand(0);
3601
3602 // Calculate type and width of the result produced by mul.with.overflow.
3603 Type *TyA = A->getType(), *TyB = B->getType();
3604 unsigned WidthA = TyA->getPrimitiveSizeInBits(),
3605 WidthB = TyB->getPrimitiveSizeInBits();
3606 unsigned MulWidth;
3607 Type *MulType;
3608 if (WidthB > WidthA) {
3609 MulWidth = WidthB;
3610 MulType = TyB;
3611 } else {
3612 MulWidth = WidthA;
3613 MulType = TyA;
3614 }
3615
3616 // In order to replace the original mul with a narrower mul.with.overflow,
3617 // all uses must ignore upper bits of the product. The number of used low
3618 // bits must be not greater than the width of mul.with.overflow.
3619 if (MulVal->hasNUsesOrMore(2))
3620 for (User *U : MulVal->users()) {
3621 if (U == &I)
3622 continue;
3623 if (TruncInst *TI = dyn_cast<TruncInst>(U)) {
3624 // Check if truncation ignores bits above MulWidth.
3625 unsigned TruncWidth = TI->getType()->getPrimitiveSizeInBits();
3626 if (TruncWidth > MulWidth)
Craig Topperf40110f2014-04-25 05:29:35 +00003627 return nullptr;
Serge Pavlov4bb54d52014-04-13 18:23:41 +00003628 } else if (BinaryOperator *BO = dyn_cast<BinaryOperator>(U)) {
3629 // Check if AND ignores bits above MulWidth.
3630 if (BO->getOpcode() != Instruction::And)
Craig Topperf40110f2014-04-25 05:29:35 +00003631 return nullptr;
Serge Pavlov4bb54d52014-04-13 18:23:41 +00003632 if (ConstantInt *CI = dyn_cast<ConstantInt>(BO->getOperand(1))) {
3633 const APInt &CVal = CI->getValue();
3634 if (CVal.getBitWidth() - CVal.countLeadingZeros() > MulWidth)
Craig Topperf40110f2014-04-25 05:29:35 +00003635 return nullptr;
Serge Pavlov4bb54d52014-04-13 18:23:41 +00003636 }
3637 } else {
3638 // Other uses prohibit this transformation.
Craig Topperf40110f2014-04-25 05:29:35 +00003639 return nullptr;
Serge Pavlov4bb54d52014-04-13 18:23:41 +00003640 }
3641 }
3642
3643 // Recognize patterns
3644 switch (I.getPredicate()) {
3645 case ICmpInst::ICMP_EQ:
3646 case ICmpInst::ICMP_NE:
3647 // Recognize pattern:
3648 // mulval = mul(zext A, zext B)
3649 // cmp eq/neq mulval, zext trunc mulval
3650 if (ZExtInst *Zext = dyn_cast<ZExtInst>(OtherVal))
3651 if (Zext->hasOneUse()) {
3652 Value *ZextArg = Zext->getOperand(0);
3653 if (TruncInst *Trunc = dyn_cast<TruncInst>(ZextArg))
3654 if (Trunc->getType()->getPrimitiveSizeInBits() == MulWidth)
3655 break; //Recognized
3656 }
3657
3658 // Recognize pattern:
3659 // mulval = mul(zext A, zext B)
3660 // cmp eq/neq mulval, and(mulval, mask), mask selects low MulWidth bits.
3661 ConstantInt *CI;
3662 Value *ValToMask;
3663 if (match(OtherVal, m_And(m_Value(ValToMask), m_ConstantInt(CI)))) {
3664 if (ValToMask != MulVal)
Craig Topperf40110f2014-04-25 05:29:35 +00003665 return nullptr;
Serge Pavlov4bb54d52014-04-13 18:23:41 +00003666 const APInt &CVal = CI->getValue() + 1;
3667 if (CVal.isPowerOf2()) {
3668 unsigned MaskWidth = CVal.logBase2();
3669 if (MaskWidth == MulWidth)
3670 break; // Recognized
3671 }
3672 }
Craig Topperf40110f2014-04-25 05:29:35 +00003673 return nullptr;
Serge Pavlov4bb54d52014-04-13 18:23:41 +00003674
3675 case ICmpInst::ICMP_UGT:
3676 // Recognize pattern:
3677 // mulval = mul(zext A, zext B)
3678 // cmp ugt mulval, max
3679 if (ConstantInt *CI = dyn_cast<ConstantInt>(OtherVal)) {
3680 APInt MaxVal = APInt::getMaxValue(MulWidth);
3681 MaxVal = MaxVal.zext(CI->getBitWidth());
3682 if (MaxVal.eq(CI->getValue()))
3683 break; // Recognized
3684 }
Craig Topperf40110f2014-04-25 05:29:35 +00003685 return nullptr;
Serge Pavlov4bb54d52014-04-13 18:23:41 +00003686
3687 case ICmpInst::ICMP_UGE:
3688 // Recognize pattern:
3689 // mulval = mul(zext A, zext B)
3690 // cmp uge mulval, max+1
3691 if (ConstantInt *CI = dyn_cast<ConstantInt>(OtherVal)) {
3692 APInt MaxVal = APInt::getOneBitSet(CI->getBitWidth(), MulWidth);
3693 if (MaxVal.eq(CI->getValue()))
3694 break; // Recognized
3695 }
Craig Topperf40110f2014-04-25 05:29:35 +00003696 return nullptr;
Serge Pavlov4bb54d52014-04-13 18:23:41 +00003697
3698 case ICmpInst::ICMP_ULE:
3699 // Recognize pattern:
3700 // mulval = mul(zext A, zext B)
3701 // cmp ule mulval, max
3702 if (ConstantInt *CI = dyn_cast<ConstantInt>(OtherVal)) {
3703 APInt MaxVal = APInt::getMaxValue(MulWidth);
3704 MaxVal = MaxVal.zext(CI->getBitWidth());
3705 if (MaxVal.eq(CI->getValue()))
3706 break; // Recognized
3707 }
Craig Topperf40110f2014-04-25 05:29:35 +00003708 return nullptr;
Serge Pavlov4bb54d52014-04-13 18:23:41 +00003709
3710 case ICmpInst::ICMP_ULT:
3711 // Recognize pattern:
3712 // mulval = mul(zext A, zext B)
3713 // cmp ule mulval, max + 1
3714 if (ConstantInt *CI = dyn_cast<ConstantInt>(OtherVal)) {
Serge Pavlovb5f3ddc2014-04-14 02:20:19 +00003715 APInt MaxVal = APInt::getOneBitSet(CI->getBitWidth(), MulWidth);
Serge Pavlov4bb54d52014-04-13 18:23:41 +00003716 if (MaxVal.eq(CI->getValue()))
3717 break; // Recognized
3718 }
Craig Topperf40110f2014-04-25 05:29:35 +00003719 return nullptr;
Serge Pavlov4bb54d52014-04-13 18:23:41 +00003720
3721 default:
Craig Topperf40110f2014-04-25 05:29:35 +00003722 return nullptr;
Serge Pavlov4bb54d52014-04-13 18:23:41 +00003723 }
3724
3725 InstCombiner::BuilderTy *Builder = IC.Builder;
3726 Builder->SetInsertPoint(MulInstr);
Serge Pavlov4bb54d52014-04-13 18:23:41 +00003727
3728 // Replace: mul(zext A, zext B) --> mul.with.overflow(A, B)
3729 Value *MulA = A, *MulB = B;
3730 if (WidthA < MulWidth)
3731 MulA = Builder->CreateZExt(A, MulType);
3732 if (WidthB < MulWidth)
3733 MulB = Builder->CreateZExt(B, MulType);
Sanjay Patelaf674fb2015-12-14 17:24:23 +00003734 Value *F = Intrinsic::getDeclaration(I.getModule(),
3735 Intrinsic::umul_with_overflow, MulType);
David Blaikieff6409d2015-05-18 22:13:54 +00003736 CallInst *Call = Builder->CreateCall(F, {MulA, MulB}, "umul");
Serge Pavlov4bb54d52014-04-13 18:23:41 +00003737 IC.Worklist.Add(MulInstr);
3738
3739 // If there are uses of mul result other than the comparison, we know that
3740 // they are truncation or binary AND. Change them to use result of
Serge Pavlovb5f3ddc2014-04-14 02:20:19 +00003741 // mul.with.overflow and adjust properly mask/size.
Serge Pavlov4bb54d52014-04-13 18:23:41 +00003742 if (MulVal->hasNUsesOrMore(2)) {
3743 Value *Mul = Builder->CreateExtractValue(Call, 0, "umul.value");
3744 for (User *U : MulVal->users()) {
3745 if (U == &I || U == OtherVal)
3746 continue;
3747 if (TruncInst *TI = dyn_cast<TruncInst>(U)) {
3748 if (TI->getType()->getPrimitiveSizeInBits() == MulWidth)
Sanjay Patel4b198802016-02-01 22:23:39 +00003749 IC.replaceInstUsesWith(*TI, Mul);
Serge Pavlov4bb54d52014-04-13 18:23:41 +00003750 else
3751 TI->setOperand(0, Mul);
3752 } else if (BinaryOperator *BO = dyn_cast<BinaryOperator>(U)) {
3753 assert(BO->getOpcode() == Instruction::And);
3754 // Replace (mul & mask) --> zext (mul.with.overflow & short_mask)
3755 ConstantInt *CI = cast<ConstantInt>(BO->getOperand(1));
3756 APInt ShortMask = CI->getValue().trunc(MulWidth);
3757 Value *ShortAnd = Builder->CreateAnd(Mul, ShortMask);
3758 Instruction *Zext =
3759 cast<Instruction>(Builder->CreateZExt(ShortAnd, BO->getType()));
3760 IC.Worklist.Add(Zext);
Sanjay Patel4b198802016-02-01 22:23:39 +00003761 IC.replaceInstUsesWith(*BO, Zext);
Serge Pavlov4bb54d52014-04-13 18:23:41 +00003762 } else {
3763 llvm_unreachable("Unexpected Binary operation");
3764 }
3765 IC.Worklist.Add(cast<Instruction>(U));
3766 }
3767 }
3768 if (isa<Instruction>(OtherVal))
3769 IC.Worklist.Add(cast<Instruction>(OtherVal));
3770
3771 // The original icmp gets replaced with the overflow value, maybe inverted
3772 // depending on predicate.
3773 bool Inverse = false;
3774 switch (I.getPredicate()) {
3775 case ICmpInst::ICMP_NE:
3776 break;
3777 case ICmpInst::ICMP_EQ:
3778 Inverse = true;
3779 break;
3780 case ICmpInst::ICMP_UGT:
3781 case ICmpInst::ICMP_UGE:
3782 if (I.getOperand(0) == MulVal)
3783 break;
3784 Inverse = true;
3785 break;
3786 case ICmpInst::ICMP_ULT:
3787 case ICmpInst::ICMP_ULE:
3788 if (I.getOperand(1) == MulVal)
3789 break;
3790 Inverse = true;
3791 break;
3792 default:
3793 llvm_unreachable("Unexpected predicate");
3794 }
3795 if (Inverse) {
3796 Value *Res = Builder->CreateExtractValue(Call, 1);
3797 return BinaryOperator::CreateNot(Res);
3798 }
3799
3800 return ExtractValueInst::Create(Call, 1);
3801}
3802
Sanjay Patel5f0217f2016-06-05 16:46:18 +00003803/// When performing a comparison against a constant, it is possible that not all
3804/// the bits in the LHS are demanded. This helper method computes the mask that
3805/// IS demanded.
Sanjay Pateld93c4c02016-09-15 18:22:25 +00003806static APInt getDemandedBitsLHSMask(ICmpInst &I, unsigned BitWidth,
3807 bool isSignCheck) {
Owen Andersond490c2d2011-01-11 00:36:45 +00003808 if (isSignCheck)
Craig Topperbcfd2d12017-04-20 16:56:25 +00003809 return APInt::getSignMask(BitWidth);
Jim Grosbach129c52a2011-09-30 18:09:53 +00003810
Owen Andersond490c2d2011-01-11 00:36:45 +00003811 ConstantInt *CI = dyn_cast<ConstantInt>(I.getOperand(1));
3812 if (!CI) return APInt::getAllOnesValue(BitWidth);
Owen Anderson0022a4b2011-01-11 18:26:37 +00003813 const APInt &RHS = CI->getValue();
Jim Grosbach129c52a2011-09-30 18:09:53 +00003814
Owen Andersond490c2d2011-01-11 00:36:45 +00003815 switch (I.getPredicate()) {
Jim Grosbach129c52a2011-09-30 18:09:53 +00003816 // For a UGT comparison, we don't care about any bits that
Owen Andersond490c2d2011-01-11 00:36:45 +00003817 // correspond to the trailing ones of the comparand. The value of these
3818 // bits doesn't impact the outcome of the comparison, because any value
3819 // greater than the RHS must differ in a bit higher than these due to carry.
3820 case ICmpInst::ICMP_UGT: {
3821 unsigned trailingOnes = RHS.countTrailingOnes();
Craig Toppere7563f82017-04-13 21:49:48 +00003822 return APInt::getBitsSetFrom(BitWidth, trailingOnes);
Owen Andersond490c2d2011-01-11 00:36:45 +00003823 }
Jim Grosbach129c52a2011-09-30 18:09:53 +00003824
Owen Andersond490c2d2011-01-11 00:36:45 +00003825 // Similarly, for a ULT comparison, we don't care about the trailing zeros.
3826 // Any value less than the RHS must differ in a higher bit because of carries.
3827 case ICmpInst::ICMP_ULT: {
3828 unsigned trailingZeros = RHS.countTrailingZeros();
Craig Toppere7563f82017-04-13 21:49:48 +00003829 return APInt::getBitsSetFrom(BitWidth, trailingZeros);
Owen Andersond490c2d2011-01-11 00:36:45 +00003830 }
Jim Grosbach129c52a2011-09-30 18:09:53 +00003831
Owen Andersond490c2d2011-01-11 00:36:45 +00003832 default:
3833 return APInt::getAllOnesValue(BitWidth);
3834 }
Owen Andersond490c2d2011-01-11 00:36:45 +00003835}
Chris Lattner2188e402010-01-04 07:37:31 +00003836
Quentin Colombet5ab55552013-09-09 20:56:48 +00003837/// \brief Check if the order of \p Op0 and \p Op1 as operand in an ICmpInst
3838/// should be swapped.
Alp Tokercb402912014-01-24 17:20:08 +00003839/// The decision is based on how many times these two operands are reused
Quentin Colombet5ab55552013-09-09 20:56:48 +00003840/// as subtract operands and their positions in those instructions.
3841/// The rational is that several architectures use the same instruction for
3842/// both subtract and cmp, thus it is better if the order of those operands
3843/// match.
3844/// \return true if Op0 and Op1 should be swapped.
3845static bool swapMayExposeCSEOpportunities(const Value * Op0,
3846 const Value * Op1) {
3847 // Filter out pointer value as those cannot appears directly in subtract.
3848 // FIXME: we may want to go through inttoptrs or bitcasts.
3849 if (Op0->getType()->isPointerTy())
3850 return false;
3851 // Count every uses of both Op0 and Op1 in a subtract.
3852 // Each time Op0 is the first operand, count -1: swapping is bad, the
3853 // subtract has already the same layout as the compare.
3854 // Each time Op0 is the second operand, count +1: swapping is good, the
Alp Tokercb402912014-01-24 17:20:08 +00003855 // subtract has a different layout as the compare.
Quentin Colombet5ab55552013-09-09 20:56:48 +00003856 // At the end, if the benefit is greater than 0, Op0 should come second to
3857 // expose more CSE opportunities.
3858 int GlobalSwapBenefits = 0;
Chandler Carruthcdf47882014-03-09 03:16:01 +00003859 for (const User *U : Op0->users()) {
3860 const BinaryOperator *BinOp = dyn_cast<BinaryOperator>(U);
Quentin Colombet5ab55552013-09-09 20:56:48 +00003861 if (!BinOp || BinOp->getOpcode() != Instruction::Sub)
3862 continue;
3863 // If Op0 is the first argument, this is not beneficial to swap the
3864 // arguments.
3865 int LocalSwapBenefits = -1;
3866 unsigned Op1Idx = 1;
3867 if (BinOp->getOperand(Op1Idx) == Op0) {
3868 Op1Idx = 0;
3869 LocalSwapBenefits = 1;
3870 }
3871 if (BinOp->getOperand(Op1Idx) != Op1)
3872 continue;
3873 GlobalSwapBenefits += LocalSwapBenefits;
3874 }
3875 return GlobalSwapBenefits > 0;
3876}
3877
Gerolf Hoflehnerec6217c2014-11-21 23:36:44 +00003878/// \brief Check that one use is in the same block as the definition and all
Sanjay Patel53523312016-09-12 14:25:46 +00003879/// other uses are in blocks dominated by a given block.
Gerolf Hoflehnerec6217c2014-11-21 23:36:44 +00003880///
3881/// \param DI Definition
3882/// \param UI Use
3883/// \param DB Block that must dominate all uses of \p DI outside
3884/// the parent block
3885/// \return true when \p UI is the only use of \p DI in the parent block
3886/// and all other uses of \p DI are in blocks dominated by \p DB.
3887///
3888bool InstCombiner::dominatesAllUses(const Instruction *DI,
3889 const Instruction *UI,
3890 const BasicBlock *DB) const {
3891 assert(DI && UI && "Instruction not defined\n");
Sanjay Patel53523312016-09-12 14:25:46 +00003892 // Ignore incomplete definitions.
Gerolf Hoflehnerec6217c2014-11-21 23:36:44 +00003893 if (!DI->getParent())
3894 return false;
Sanjay Patel53523312016-09-12 14:25:46 +00003895 // DI and UI must be in the same block.
Gerolf Hoflehnerec6217c2014-11-21 23:36:44 +00003896 if (DI->getParent() != UI->getParent())
3897 return false;
Sanjay Patel53523312016-09-12 14:25:46 +00003898 // Protect from self-referencing blocks.
Gerolf Hoflehnerec6217c2014-11-21 23:36:44 +00003899 if (DI->getParent() == DB)
3900 return false;
Gerolf Hoflehnerec6217c2014-11-21 23:36:44 +00003901 for (const User *U : DI->users()) {
3902 auto *Usr = cast<Instruction>(U);
Justin Bogner99798402016-08-05 01:06:44 +00003903 if (Usr != UI && !DT.dominates(DB, Usr->getParent()))
Gerolf Hoflehnerec6217c2014-11-21 23:36:44 +00003904 return false;
3905 }
3906 return true;
3907}
3908
Sanjay Patel5f0217f2016-06-05 16:46:18 +00003909/// Return true when the instruction sequence within a block is select-cmp-br.
Gerolf Hoflehnerec6217c2014-11-21 23:36:44 +00003910static bool isChainSelectCmpBranch(const SelectInst *SI) {
3911 const BasicBlock *BB = SI->getParent();
3912 if (!BB)
3913 return false;
3914 auto *BI = dyn_cast_or_null<BranchInst>(BB->getTerminator());
3915 if (!BI || BI->getNumSuccessors() != 2)
3916 return false;
3917 auto *IC = dyn_cast<ICmpInst>(BI->getCondition());
3918 if (!IC || (IC->getOperand(0) != SI && IC->getOperand(1) != SI))
3919 return false;
3920 return true;
3921}
3922
Gerolf Hoflehnerec6217c2014-11-21 23:36:44 +00003923/// \brief True when a select result is replaced by one of its operands
3924/// in select-icmp sequence. This will eventually result in the elimination
3925/// of the select.
3926///
3927/// \param SI Select instruction
3928/// \param Icmp Compare instruction
3929/// \param SIOpd Operand that replaces the select
3930///
3931/// Notes:
3932/// - The replacement is global and requires dominator information
3933/// - The caller is responsible for the actual replacement
3934///
3935/// Example:
3936///
3937/// entry:
3938/// %4 = select i1 %3, %C* %0, %C* null
3939/// %5 = icmp eq %C* %4, null
3940/// br i1 %5, label %9, label %7
3941/// ...
3942/// ; <label>:7 ; preds = %entry
3943/// %8 = getelementptr inbounds %C* %4, i64 0, i32 0
3944/// ...
3945///
3946/// can be transformed to
3947///
3948/// %5 = icmp eq %C* %0, null
3949/// %6 = select i1 %3, i1 %5, i1 true
3950/// br i1 %6, label %9, label %7
3951/// ...
3952/// ; <label>:7 ; preds = %entry
3953/// %8 = getelementptr inbounds %C* %0, i64 0, i32 0 // replace by %0!
3954///
3955/// Similar when the first operand of the select is a constant or/and
3956/// the compare is for not equal rather than equal.
3957///
3958/// NOTE: The function is only called when the select and compare constants
3959/// are equal, the optimization can work only for EQ predicates. This is not a
3960/// major restriction since a NE compare should be 'normalized' to an equal
3961/// compare, which usually happens in the combiner and test case
Sanjay Patel53523312016-09-12 14:25:46 +00003962/// select-cmp-br.ll checks for it.
Gerolf Hoflehnerec6217c2014-11-21 23:36:44 +00003963bool InstCombiner::replacedSelectWithOperand(SelectInst *SI,
3964 const ICmpInst *Icmp,
3965 const unsigned SIOpd) {
David Majnemer83484fd2014-11-22 06:09:28 +00003966 assert((SIOpd == 1 || SIOpd == 2) && "Invalid select operand!");
Gerolf Hoflehnerec6217c2014-11-21 23:36:44 +00003967 if (isChainSelectCmpBranch(SI) && Icmp->getPredicate() == ICmpInst::ICMP_EQ) {
3968 BasicBlock *Succ = SI->getParent()->getTerminator()->getSuccessor(1);
Bjorn Petterssone5027cf2017-03-02 15:18:58 +00003969 // The check for the single predecessor is not the best that can be
Sanjay Patel53523312016-09-12 14:25:46 +00003970 // done. But it protects efficiently against cases like when SI's
Gerolf Hoflehnerec6217c2014-11-21 23:36:44 +00003971 // home block has two successors, Succ and Succ1, and Succ1 predecessor
3972 // of Succ. Then SI can't be replaced by SIOpd because the use that gets
3973 // replaced can be reached on either path. So the uniqueness check
3974 // guarantees that the path all uses of SI (outside SI's parent) are on
3975 // is disjoint from all other paths out of SI. But that information
3976 // is more expensive to compute, and the trade-off here is in favor
Bjorn Petterssone5027cf2017-03-02 15:18:58 +00003977 // of compile-time. It should also be noticed that we check for a single
3978 // predecessor and not only uniqueness. This to handle the situation when
3979 // Succ and Succ1 points to the same basic block.
3980 if (Succ->getSinglePredecessor() && dominatesAllUses(SI, Icmp, Succ)) {
Gerolf Hoflehnerec6217c2014-11-21 23:36:44 +00003981 NumSel++;
3982 SI->replaceUsesOutsideBlock(SI->getOperand(SIOpd), SI->getParent());
3983 return true;
3984 }
3985 }
3986 return false;
3987}
3988
Sanjay Patel3151dec2016-09-12 15:24:31 +00003989/// Try to fold the comparison based on range information we can get by checking
3990/// whether bits are known to be zero or one in the inputs.
3991Instruction *InstCombiner::foldICmpUsingKnownBits(ICmpInst &I) {
3992 Value *Op0 = I.getOperand(0), *Op1 = I.getOperand(1);
3993 Type *Ty = Op0->getType();
Sanjay Patel0531f0a2016-09-12 15:52:28 +00003994 ICmpInst::Predicate Pred = I.getPredicate();
Sanjay Patel3151dec2016-09-12 15:24:31 +00003995
3996 // Get scalar or pointer size.
3997 unsigned BitWidth = Ty->isIntOrIntVectorTy()
3998 ? Ty->getScalarSizeInBits()
3999 : DL.getTypeSizeInBits(Ty->getScalarType());
4000
4001 if (!BitWidth)
4002 return nullptr;
4003
4004 // If this is a normal comparison, it demands all bits. If it is a sign bit
4005 // comparison, it only demands the sign bit.
4006 bool IsSignBit = false;
Sanjay Patelf5887f12016-09-12 16:25:41 +00004007 const APInt *CmpC;
4008 if (match(Op1, m_APInt(CmpC))) {
Sanjay Patel3151dec2016-09-12 15:24:31 +00004009 bool UnusedBit;
Sanjay Patelf5887f12016-09-12 16:25:41 +00004010 IsSignBit = isSignBitCheck(Pred, *CmpC, UnusedBit);
Sanjay Patel3151dec2016-09-12 15:24:31 +00004011 }
4012
Craig Topperb45eabc2017-04-26 16:39:58 +00004013 KnownBits Op0Known(BitWidth);
4014 KnownBits Op1Known(BitWidth);
Sanjay Patel3151dec2016-09-12 15:24:31 +00004015
Craig Topper47596dd2017-03-25 06:52:52 +00004016 if (SimplifyDemandedBits(&I, 0,
Sanjay Pateld93c4c02016-09-15 18:22:25 +00004017 getDemandedBitsLHSMask(I, BitWidth, IsSignBit),
Craig Topperb45eabc2017-04-26 16:39:58 +00004018 Op0Known, 0))
Sanjay Patel3151dec2016-09-12 15:24:31 +00004019 return &I;
4020
Craig Topper47596dd2017-03-25 06:52:52 +00004021 if (SimplifyDemandedBits(&I, 1, APInt::getAllOnesValue(BitWidth),
Craig Topperb45eabc2017-04-26 16:39:58 +00004022 Op1Known, 0))
Sanjay Patel3151dec2016-09-12 15:24:31 +00004023 return &I;
4024
4025 // Given the known and unknown bits, compute a range that the LHS could be
4026 // in. Compute the Min, Max and RHS values based on the known bits. For the
4027 // EQ and NE we use unsigned values.
4028 APInt Op0Min(BitWidth, 0), Op0Max(BitWidth, 0);
4029 APInt Op1Min(BitWidth, 0), Op1Max(BitWidth, 0);
4030 if (I.isSigned()) {
Craig Topperb45eabc2017-04-26 16:39:58 +00004031 computeSignedMinMaxValuesFromKnownBits(Op0Known, Op0Min, Op0Max);
4032 computeSignedMinMaxValuesFromKnownBits(Op1Known, Op1Min, Op1Max);
Sanjay Patel3151dec2016-09-12 15:24:31 +00004033 } else {
Craig Topperb45eabc2017-04-26 16:39:58 +00004034 computeUnsignedMinMaxValuesFromKnownBits(Op0Known, Op0Min, Op0Max);
4035 computeUnsignedMinMaxValuesFromKnownBits(Op1Known, Op1Min, Op1Max);
Sanjay Patel3151dec2016-09-12 15:24:31 +00004036 }
4037
4038 // If Min and Max are known to be the same, then SimplifyDemandedBits
Sanjay Patel0531f0a2016-09-12 15:52:28 +00004039 // figured out that the LHS is a constant. Constant fold this now, so that
4040 // code below can assume that Min != Max.
Sanjay Patel3151dec2016-09-12 15:24:31 +00004041 if (!isa<Constant>(Op0) && Op0Min == Op0Max)
Sanjay Patel0531f0a2016-09-12 15:52:28 +00004042 return new ICmpInst(Pred, ConstantInt::get(Op0->getType(), Op0Min), Op1);
Sanjay Patel3151dec2016-09-12 15:24:31 +00004043 if (!isa<Constant>(Op1) && Op1Min == Op1Max)
Sanjay Patel0531f0a2016-09-12 15:52:28 +00004044 return new ICmpInst(Pred, Op0, ConstantInt::get(Op1->getType(), Op1Min));
Sanjay Patel3151dec2016-09-12 15:24:31 +00004045
4046 // Based on the range information we know about the LHS, see if we can
4047 // simplify this comparison. For example, (x&4) < 8 is always true.
Sanjay Patel0531f0a2016-09-12 15:52:28 +00004048 switch (Pred) {
Sanjay Patel3151dec2016-09-12 15:24:31 +00004049 default:
4050 llvm_unreachable("Unknown icmp opcode!");
Sanjay Patel9efb1bd2016-09-14 23:38:56 +00004051 case ICmpInst::ICMP_EQ:
Sanjay Patel3151dec2016-09-12 15:24:31 +00004052 case ICmpInst::ICMP_NE: {
Sanjay Patel9efb1bd2016-09-14 23:38:56 +00004053 if (Op0Max.ult(Op1Min) || Op0Min.ugt(Op1Max)) {
4054 return Pred == CmpInst::ICMP_EQ
4055 ? replaceInstUsesWith(I, ConstantInt::getFalse(I.getType()))
4056 : replaceInstUsesWith(I, ConstantInt::getTrue(I.getType()));
4057 }
Sanjay Patel3151dec2016-09-12 15:24:31 +00004058
Sanjay Patel0531f0a2016-09-12 15:52:28 +00004059 // If all bits are known zero except for one, then we know at most one bit
4060 // is set. If the comparison is against zero, then this is a check to see if
4061 // *that* bit is set.
Craig Topperb45eabc2017-04-26 16:39:58 +00004062 APInt Op0KnownZeroInverted = ~Op0Known.Zero;
Craig Topperf0aeee02017-05-05 17:36:09 +00004063 if (Op1Known.isZero()) {
Sanjay Patel3151dec2016-09-12 15:24:31 +00004064 // If the LHS is an AND with the same constant, look through it.
4065 Value *LHS = nullptr;
Sanjay Patel7577a3d2016-09-15 14:15:47 +00004066 const APInt *LHSC;
4067 if (!match(Op0, m_And(m_Value(LHS), m_APInt(LHSC))) ||
4068 *LHSC != Op0KnownZeroInverted)
Sanjay Patel3151dec2016-09-12 15:24:31 +00004069 LHS = Op0;
4070
Sanjay Patel9efb1bd2016-09-14 23:38:56 +00004071 Value *X;
Sanjay Patel3151dec2016-09-12 15:24:31 +00004072 if (match(LHS, m_Shl(m_One(), m_Value(X)))) {
4073 APInt ValToCheck = Op0KnownZeroInverted;
Sanjay Patel9efb1bd2016-09-14 23:38:56 +00004074 Type *XTy = X->getType();
Sanjay Patel3151dec2016-09-12 15:24:31 +00004075 if (ValToCheck.isPowerOf2()) {
Sanjay Patel9efb1bd2016-09-14 23:38:56 +00004076 // ((1 << X) & 8) == 0 -> X != 3
4077 // ((1 << X) & 8) != 0 -> X == 3
4078 auto *CmpC = ConstantInt::get(XTy, ValToCheck.countTrailingZeros());
4079 auto NewPred = ICmpInst::getInversePredicate(Pred);
4080 return new ICmpInst(NewPred, X, CmpC);
Sanjay Patel3151dec2016-09-12 15:24:31 +00004081 } else if ((++ValToCheck).isPowerOf2()) {
Sanjay Patel9efb1bd2016-09-14 23:38:56 +00004082 // ((1 << X) & 7) == 0 -> X >= 3
4083 // ((1 << X) & 7) != 0 -> X < 3
4084 auto *CmpC = ConstantInt::get(XTy, ValToCheck.countTrailingZeros());
4085 auto NewPred =
4086 Pred == CmpInst::ICMP_EQ ? CmpInst::ICMP_UGE : CmpInst::ICMP_ULT;
4087 return new ICmpInst(NewPred, X, CmpC);
Sanjay Patel3151dec2016-09-12 15:24:31 +00004088 }
4089 }
4090
Sanjay Patel9efb1bd2016-09-14 23:38:56 +00004091 // Check if the LHS is 8 >>u x and the result is a power of 2 like 1.
Sanjay Patel3151dec2016-09-12 15:24:31 +00004092 const APInt *CI;
4093 if (Op0KnownZeroInverted == 1 &&
Sanjay Patel9efb1bd2016-09-14 23:38:56 +00004094 match(LHS, m_LShr(m_Power2(CI), m_Value(X)))) {
4095 // ((8 >>u X) & 1) == 0 -> X != 3
4096 // ((8 >>u X) & 1) != 0 -> X == 3
4097 unsigned CmpVal = CI->countTrailingZeros();
4098 auto NewPred = ICmpInst::getInversePredicate(Pred);
4099 return new ICmpInst(NewPred, X, ConstantInt::get(X->getType(), CmpVal));
4100 }
Sanjay Patel3151dec2016-09-12 15:24:31 +00004101 }
4102 break;
4103 }
4104 case ICmpInst::ICMP_ULT: {
4105 if (Op0Max.ult(Op1Min)) // A <u B -> true if max(A) < min(B)
4106 return replaceInstUsesWith(I, ConstantInt::getTrue(I.getType()));
4107 if (Op0Min.uge(Op1Max)) // A <u B -> false if min(A) >= max(B)
4108 return replaceInstUsesWith(I, ConstantInt::getFalse(I.getType()));
4109 if (Op1Min == Op0Max) // A <u B -> A != B if max(A) == min(B)
4110 return new ICmpInst(ICmpInst::ICMP_NE, Op0, Op1);
4111
4112 const APInt *CmpC;
4113 if (match(Op1, m_APInt(CmpC))) {
4114 // A <u C -> A == C-1 if min(A)+1 == C
4115 if (Op1Max == Op0Min + 1) {
4116 Constant *CMinus1 = ConstantInt::get(Op0->getType(), *CmpC - 1);
4117 return new ICmpInst(ICmpInst::ICMP_EQ, Op0, CMinus1);
4118 }
Sanjay Patel3151dec2016-09-12 15:24:31 +00004119 }
4120 break;
4121 }
4122 case ICmpInst::ICMP_UGT: {
4123 if (Op0Min.ugt(Op1Max)) // A >u B -> true if min(A) > max(B)
4124 return replaceInstUsesWith(I, ConstantInt::getTrue(I.getType()));
4125
4126 if (Op0Max.ule(Op1Min)) // A >u B -> false if max(A) <= max(B)
4127 return replaceInstUsesWith(I, ConstantInt::getFalse(I.getType()));
4128
4129 if (Op1Max == Op0Min) // A >u B -> A != B if min(A) == max(B)
4130 return new ICmpInst(ICmpInst::ICMP_NE, Op0, Op1);
4131
4132 const APInt *CmpC;
4133 if (match(Op1, m_APInt(CmpC))) {
4134 // A >u C -> A == C+1 if max(a)-1 == C
4135 if (*CmpC == Op0Max - 1)
4136 return new ICmpInst(ICmpInst::ICMP_EQ, Op0,
4137 ConstantInt::get(Op1->getType(), *CmpC + 1));
Sanjay Patel3151dec2016-09-12 15:24:31 +00004138 }
4139 break;
4140 }
4141 case ICmpInst::ICMP_SLT:
4142 if (Op0Max.slt(Op1Min)) // A <s B -> true if max(A) < min(C)
4143 return replaceInstUsesWith(I, ConstantInt::getTrue(I.getType()));
4144 if (Op0Min.sge(Op1Max)) // A <s B -> false if min(A) >= max(C)
4145 return replaceInstUsesWith(I, ConstantInt::getFalse(I.getType()));
4146 if (Op1Min == Op0Max) // A <s B -> A != B if max(A) == min(B)
4147 return new ICmpInst(ICmpInst::ICMP_NE, Op0, Op1);
4148 if (ConstantInt *CI = dyn_cast<ConstantInt>(Op1)) {
4149 if (Op1Max == Op0Min + 1) // A <s C -> A == C-1 if min(A)+1 == C
4150 return new ICmpInst(ICmpInst::ICMP_EQ, Op0,
4151 Builder->getInt(CI->getValue() - 1));
4152 }
4153 break;
4154 case ICmpInst::ICMP_SGT:
4155 if (Op0Min.sgt(Op1Max)) // A >s B -> true if min(A) > max(B)
4156 return replaceInstUsesWith(I, ConstantInt::getTrue(I.getType()));
4157 if (Op0Max.sle(Op1Min)) // A >s B -> false if max(A) <= min(B)
4158 return replaceInstUsesWith(I, ConstantInt::getFalse(I.getType()));
4159
4160 if (Op1Max == Op0Min) // A >s B -> A != B if min(A) == max(B)
4161 return new ICmpInst(ICmpInst::ICMP_NE, Op0, Op1);
4162 if (ConstantInt *CI = dyn_cast<ConstantInt>(Op1)) {
4163 if (Op1Min == Op0Max - 1) // A >s C -> A == C+1 if max(A)-1 == C
4164 return new ICmpInst(ICmpInst::ICMP_EQ, Op0,
4165 Builder->getInt(CI->getValue() + 1));
4166 }
4167 break;
4168 case ICmpInst::ICMP_SGE:
4169 assert(!isa<ConstantInt>(Op1) && "ICMP_SGE with ConstantInt not folded!");
4170 if (Op0Min.sge(Op1Max)) // A >=s B -> true if min(A) >= max(B)
4171 return replaceInstUsesWith(I, ConstantInt::getTrue(I.getType()));
4172 if (Op0Max.slt(Op1Min)) // A >=s B -> false if max(A) < min(B)
4173 return replaceInstUsesWith(I, ConstantInt::getFalse(I.getType()));
4174 break;
4175 case ICmpInst::ICMP_SLE:
4176 assert(!isa<ConstantInt>(Op1) && "ICMP_SLE with ConstantInt not folded!");
4177 if (Op0Max.sle(Op1Min)) // A <=s B -> true if max(A) <= min(B)
4178 return replaceInstUsesWith(I, ConstantInt::getTrue(I.getType()));
4179 if (Op0Min.sgt(Op1Max)) // A <=s B -> false if min(A) > max(B)
4180 return replaceInstUsesWith(I, ConstantInt::getFalse(I.getType()));
4181 break;
4182 case ICmpInst::ICMP_UGE:
4183 assert(!isa<ConstantInt>(Op1) && "ICMP_UGE with ConstantInt not folded!");
4184 if (Op0Min.uge(Op1Max)) // A >=u B -> true if min(A) >= max(B)
4185 return replaceInstUsesWith(I, ConstantInt::getTrue(I.getType()));
4186 if (Op0Max.ult(Op1Min)) // A >=u B -> false if max(A) < min(B)
4187 return replaceInstUsesWith(I, ConstantInt::getFalse(I.getType()));
4188 break;
4189 case ICmpInst::ICMP_ULE:
4190 assert(!isa<ConstantInt>(Op1) && "ICMP_ULE with ConstantInt not folded!");
4191 if (Op0Max.ule(Op1Min)) // A <=u B -> true if max(A) <= min(B)
4192 return replaceInstUsesWith(I, ConstantInt::getTrue(I.getType()));
4193 if (Op0Min.ugt(Op1Max)) // A <=u B -> false if min(A) > max(B)
4194 return replaceInstUsesWith(I, ConstantInt::getFalse(I.getType()));
4195 break;
4196 }
4197
4198 // Turn a signed comparison into an unsigned one if both operands are known to
4199 // have the same sign.
4200 if (I.isSigned() &&
Craig Topperb45eabc2017-04-26 16:39:58 +00004201 ((Op0Known.Zero.isNegative() && Op1Known.Zero.isNegative()) ||
4202 (Op0Known.One.isNegative() && Op1Known.One.isNegative())))
Sanjay Patel3151dec2016-09-12 15:24:31 +00004203 return new ICmpInst(I.getUnsignedPredicate(), Op0, Op1);
4204
4205 return nullptr;
4206}
4207
Sanjay Pateld5b0e542016-04-29 16:22:25 +00004208/// If we have an icmp le or icmp ge instruction with a constant operand, turn
4209/// it into the appropriate icmp lt or icmp gt instruction. This transform
4210/// allows them to be folded in visitICmpInst.
Sanjay Patele9b2c322016-05-17 00:57:57 +00004211static ICmpInst *canonicalizeCmpWithConstant(ICmpInst &I) {
4212 ICmpInst::Predicate Pred = I.getPredicate();
4213 if (Pred != ICmpInst::ICMP_SLE && Pred != ICmpInst::ICMP_SGE &&
4214 Pred != ICmpInst::ICMP_ULE && Pred != ICmpInst::ICMP_UGE)
4215 return nullptr;
4216
Sanjay Pateld5b0e542016-04-29 16:22:25 +00004217 Value *Op0 = I.getOperand(0);
4218 Value *Op1 = I.getOperand(1);
Sanjay Patele9b2c322016-05-17 00:57:57 +00004219 auto *Op1C = dyn_cast<Constant>(Op1);
4220 if (!Op1C)
4221 return nullptr;
Sanjay Pateld5b0e542016-04-29 16:22:25 +00004222
Sanjay Patele9b2c322016-05-17 00:57:57 +00004223 // Check if the constant operand can be safely incremented/decremented without
4224 // overflowing/underflowing. For scalars, SimplifyICmpInst has already handled
4225 // the edge cases for us, so we just assert on them. For vectors, we must
4226 // handle the edge cases.
4227 Type *Op1Type = Op1->getType();
4228 bool IsSigned = I.isSigned();
4229 bool IsLE = (Pred == ICmpInst::ICMP_SLE || Pred == ICmpInst::ICMP_ULE);
Sanjay Patel18254932016-05-17 01:12:31 +00004230 auto *CI = dyn_cast<ConstantInt>(Op1C);
4231 if (CI) {
Sanjay Patele9b2c322016-05-17 00:57:57 +00004232 // A <= MAX -> TRUE ; A >= MIN -> TRUE
4233 assert(IsLE ? !CI->isMaxValue(IsSigned) : !CI->isMinValue(IsSigned));
4234 } else if (Op1Type->isVectorTy()) {
Sanjay Patelb79ab272016-05-13 15:10:46 +00004235 // TODO? If the edge cases for vectors were guaranteed to be handled as they
Sanjay Patele9b2c322016-05-17 00:57:57 +00004236 // are for scalar, we could remove the min/max checks. However, to do that,
4237 // we would have to use insertelement/shufflevector to replace edge values.
4238 unsigned NumElts = Op1Type->getVectorNumElements();
4239 for (unsigned i = 0; i != NumElts; ++i) {
4240 Constant *Elt = Op1C->getAggregateElement(i);
Benjamin Kramerca9a0fe2016-05-17 12:08:55 +00004241 if (!Elt)
4242 return nullptr;
4243
Sanjay Patele9b2c322016-05-17 00:57:57 +00004244 if (isa<UndefValue>(Elt))
4245 continue;
Sanjay Patel06b127a2016-09-15 14:37:50 +00004246
Sanjay Patele9b2c322016-05-17 00:57:57 +00004247 // Bail out if we can't determine if this constant is min/max or if we
4248 // know that this constant is min/max.
4249 auto *CI = dyn_cast<ConstantInt>(Elt);
4250 if (!CI || (IsLE ? CI->isMaxValue(IsSigned) : CI->isMinValue(IsSigned)))
4251 return nullptr;
Sanjay Patelb79ab272016-05-13 15:10:46 +00004252 }
Sanjay Patele9b2c322016-05-17 00:57:57 +00004253 } else {
4254 // ConstantExpr?
4255 return nullptr;
Sanjay Patelb79ab272016-05-13 15:10:46 +00004256 }
Sanjay Pateld5b0e542016-04-29 16:22:25 +00004257
Sanjay Patele9b2c322016-05-17 00:57:57 +00004258 // Increment or decrement the constant and set the new comparison predicate:
4259 // ULE -> ULT ; UGE -> UGT ; SLE -> SLT ; SGE -> SGT
Sanjay Patel22b01fe2016-05-17 20:20:40 +00004260 Constant *OneOrNegOne = ConstantInt::get(Op1Type, IsLE ? 1 : -1, true);
Sanjay Patele9b2c322016-05-17 00:57:57 +00004261 CmpInst::Predicate NewPred = IsLE ? ICmpInst::ICMP_ULT: ICmpInst::ICMP_UGT;
4262 NewPred = IsSigned ? ICmpInst::getSignedPredicate(NewPred) : NewPred;
4263 return new ICmpInst(NewPred, Op0, ConstantExpr::getAdd(Op1C, OneOrNegOne));
Sanjay Pateld5b0e542016-04-29 16:22:25 +00004264}
4265
Sanjay Patele5747e32017-05-17 22:15:07 +00004266/// Integer compare with boolean values can always be turned into bitwise ops.
4267static Instruction *canonicalizeICmpBool(ICmpInst &I,
4268 InstCombiner::BuilderTy &Builder) {
4269 Value *A = I.getOperand(0), *B = I.getOperand(1);
4270 assert(A->getType()->getScalarType()->isIntegerTy(1) && "Bools only");
4271
Sanjay Patelba212c22017-05-17 22:29:40 +00004272 // A boolean compared to true/false can be simplified to Op0/true/false in
4273 // 14 out of the 20 (10 predicates * 2 constants) possible combinations.
4274 // Cases not handled by InstSimplify are always 'not' of Op0.
4275 if (match(B, m_Zero())) {
4276 switch (I.getPredicate()) {
4277 case CmpInst::ICMP_EQ: // A == 0 -> !A
4278 case CmpInst::ICMP_ULE: // A <=u 0 -> !A
4279 case CmpInst::ICMP_SGE: // A >=s 0 -> !A
4280 return BinaryOperator::CreateNot(A);
4281 default:
4282 llvm_unreachable("ICmp i1 X, C not simplified as expected.");
4283 }
4284 } else if (match(B, m_One())) {
4285 switch (I.getPredicate()) {
4286 case CmpInst::ICMP_NE: // A != 1 -> !A
4287 case CmpInst::ICMP_ULT: // A <u 1 -> !A
4288 case CmpInst::ICMP_SGT: // A >s -1 -> !A
4289 return BinaryOperator::CreateNot(A);
4290 default:
4291 llvm_unreachable("ICmp i1 X, C not simplified as expected.");
4292 }
4293 }
4294
Sanjay Patele5747e32017-05-17 22:15:07 +00004295 switch (I.getPredicate()) {
4296 default:
4297 llvm_unreachable("Invalid icmp instruction!");
4298 case ICmpInst::ICMP_EQ:
4299 // icmp eq i1 A, B -> ~(A ^ B)
4300 return BinaryOperator::CreateNot(Builder.CreateXor(A, B));
4301
4302 case ICmpInst::ICMP_NE:
4303 // icmp ne i1 A, B -> A ^ B
4304 return BinaryOperator::CreateXor(A, B);
4305
4306 case ICmpInst::ICMP_UGT:
4307 // icmp ugt -> icmp ult
4308 std::swap(A, B);
4309 LLVM_FALLTHROUGH;
4310 case ICmpInst::ICMP_ULT:
4311 // icmp ult i1 A, B -> ~A & B
4312 return BinaryOperator::CreateAnd(Builder.CreateNot(A), B);
4313
4314 case ICmpInst::ICMP_SGT:
4315 // icmp sgt -> icmp slt
4316 std::swap(A, B);
4317 LLVM_FALLTHROUGH;
4318 case ICmpInst::ICMP_SLT:
4319 // icmp slt i1 A, B -> A & ~B
4320 return BinaryOperator::CreateAnd(Builder.CreateNot(B), A);
4321
4322 case ICmpInst::ICMP_UGE:
4323 // icmp uge -> icmp ule
4324 std::swap(A, B);
4325 LLVM_FALLTHROUGH;
4326 case ICmpInst::ICMP_ULE:
4327 // icmp ule i1 A, B -> ~A | B
4328 return BinaryOperator::CreateOr(Builder.CreateNot(A), B);
4329
4330 case ICmpInst::ICMP_SGE:
4331 // icmp sge -> icmp sle
4332 std::swap(A, B);
4333 LLVM_FALLTHROUGH;
4334 case ICmpInst::ICMP_SLE:
4335 // icmp sle i1 A, B -> A | ~B
4336 return BinaryOperator::CreateOr(Builder.CreateNot(B), A);
4337 }
4338}
4339
Chris Lattner2188e402010-01-04 07:37:31 +00004340Instruction *InstCombiner::visitICmpInst(ICmpInst &I) {
4341 bool Changed = false;
Chris Lattner9306ffa2010-02-01 19:54:45 +00004342 Value *Op0 = I.getOperand(0), *Op1 = I.getOperand(1);
Quentin Colombet5ab55552013-09-09 20:56:48 +00004343 unsigned Op0Cplxity = getComplexity(Op0);
4344 unsigned Op1Cplxity = getComplexity(Op1);
Jim Grosbach129c52a2011-09-30 18:09:53 +00004345
Chris Lattner2188e402010-01-04 07:37:31 +00004346 /// Orders the operands of the compare so that they are listed from most
4347 /// complex to least complex. This puts constants before unary operators,
4348 /// before binary operators.
Quentin Colombet5ab55552013-09-09 20:56:48 +00004349 if (Op0Cplxity < Op1Cplxity ||
Sanjay Patel4c204232016-06-04 20:39:22 +00004350 (Op0Cplxity == Op1Cplxity && swapMayExposeCSEOpportunities(Op0, Op1))) {
Chris Lattner2188e402010-01-04 07:37:31 +00004351 I.swapOperands();
Chris Lattner9306ffa2010-02-01 19:54:45 +00004352 std::swap(Op0, Op1);
Chris Lattner2188e402010-01-04 07:37:31 +00004353 Changed = true;
4354 }
Jim Grosbach129c52a2011-09-30 18:09:53 +00004355
Daniel Berlin2c75c632017-04-26 20:56:07 +00004356 if (Value *V = SimplifyICmpInst(I.getPredicate(), Op0, Op1,
4357 SQ.getWithInstruction(&I)))
Sanjay Patel4b198802016-02-01 22:23:39 +00004358 return replaceInstUsesWith(I, V);
Jim Grosbach129c52a2011-09-30 18:09:53 +00004359
Pete Cooperbc5c5242011-12-01 03:58:40 +00004360 // comparing -val or val with non-zero is the same as just comparing val
Pete Cooperfdddc272011-12-01 19:13:26 +00004361 // ie, abs(val) != 0 -> val != 0
Sanjay Patel4c204232016-06-04 20:39:22 +00004362 if (I.getPredicate() == ICmpInst::ICMP_NE && match(Op1, m_Zero())) {
Pete Cooperfdddc272011-12-01 19:13:26 +00004363 Value *Cond, *SelectTrue, *SelectFalse;
4364 if (match(Op0, m_Select(m_Value(Cond), m_Value(SelectTrue),
Pete Cooperbc5c5242011-12-01 03:58:40 +00004365 m_Value(SelectFalse)))) {
Pete Cooperfdddc272011-12-01 19:13:26 +00004366 if (Value *V = dyn_castNegVal(SelectTrue)) {
4367 if (V == SelectFalse)
4368 return CmpInst::Create(Instruction::ICmp, I.getPredicate(), V, Op1);
4369 }
4370 else if (Value *V = dyn_castNegVal(SelectFalse)) {
4371 if (V == SelectTrue)
4372 return CmpInst::Create(Instruction::ICmp, I.getPredicate(), V, Op1);
Pete Cooperbc5c5242011-12-01 03:58:40 +00004373 }
4374 }
4375 }
4376
Sanjay Patele5747e32017-05-17 22:15:07 +00004377 if (Op0->getType()->getScalarType()->isIntegerTy(1))
4378 if (Instruction *Res = canonicalizeICmpBool(I, *Builder))
4379 return Res;
Chris Lattner2188e402010-01-04 07:37:31 +00004380
Sanjay Patele9b2c322016-05-17 00:57:57 +00004381 if (ICmpInst *NewICmp = canonicalizeCmpWithConstant(I))
Sanjay Pateld5b0e542016-04-29 16:22:25 +00004382 return NewICmp;
4383
Sanjay Patel06b127a2016-09-15 14:37:50 +00004384 if (Instruction *Res = foldICmpWithConstant(I))
4385 return Res;
Chris Lattner2188e402010-01-04 07:37:31 +00004386
Sanjay Patel3151dec2016-09-12 15:24:31 +00004387 if (Instruction *Res = foldICmpUsingKnownBits(I))
4388 return Res;
Chris Lattner2188e402010-01-04 07:37:31 +00004389
4390 // Test if the ICmpInst instruction is used exclusively by a select as
4391 // part of a minimum or maximum operation. If so, refrain from doing
4392 // any other folding. This helps out other analyses which understand
4393 // non-obfuscated minimum and maximum idioms, such as ScalarEvolution
4394 // and CodeGen. And in this case, at least one of the comparison
4395 // operands has at least one user besides the compare (the select),
4396 // which would often largely negate the benefit of folding anyway.
4397 if (I.hasOneUse())
Chandler Carruthcdf47882014-03-09 03:16:01 +00004398 if (SelectInst *SI = dyn_cast<SelectInst>(*I.user_begin()))
Chris Lattner2188e402010-01-04 07:37:31 +00004399 if ((SI->getOperand(1) == Op0 && SI->getOperand(2) == Op1) ||
4400 (SI->getOperand(2) == Op0 && SI->getOperand(1) == Op1))
Craig Topperf40110f2014-04-25 05:29:35 +00004401 return nullptr;
Chris Lattner2188e402010-01-04 07:37:31 +00004402
Sanjay Patelfebcb9c2017-01-27 23:26:27 +00004403 // FIXME: We only do this after checking for min/max to prevent infinite
4404 // looping caused by a reverse canonicalization of these patterns for min/max.
4405 // FIXME: The organization of folds is a mess. These would naturally go into
4406 // canonicalizeCmpWithConstant(), but we can't move all of the above folds
4407 // down here after the min/max restriction.
4408 ICmpInst::Predicate Pred = I.getPredicate();
4409 const APInt *C;
4410 if (match(Op1, m_APInt(C))) {
4411 // For i32: x >u 2147483647 -> x <s 0 -> true if sign bit set
4412 if (Pred == ICmpInst::ICMP_UGT && C->isMaxSignedValue()) {
4413 Constant *Zero = Constant::getNullValue(Op0->getType());
4414 return new ICmpInst(ICmpInst::ICMP_SLT, Op0, Zero);
4415 }
4416
4417 // For i32: x <u 2147483648 -> x >s -1 -> true if sign bit clear
4418 if (Pred == ICmpInst::ICMP_ULT && C->isMinSignedValue()) {
4419 Constant *AllOnes = Constant::getAllOnesValue(Op0->getType());
4420 return new ICmpInst(ICmpInst::ICMP_SGT, Op0, AllOnes);
4421 }
4422 }
4423
Sanjay Patelf58f68c2016-09-10 15:03:44 +00004424 if (Instruction *Res = foldICmpInstWithConstant(I))
Sanjay Patel1271bf92016-07-23 13:06:49 +00004425 return Res;
4426
Sanjay Patel10494b22016-09-16 16:10:22 +00004427 if (Instruction *Res = foldICmpInstWithConstantNotInt(I))
4428 return Res;
Chris Lattner2188e402010-01-04 07:37:31 +00004429
4430 // If we can optimize a 'icmp GEP, P' or 'icmp P, GEP', do so now.
4431 if (GEPOperator *GEP = dyn_cast<GEPOperator>(Op0))
Sanjay Patel43395062016-07-21 18:07:40 +00004432 if (Instruction *NI = foldGEPICmp(GEP, Op1, I.getPredicate(), I))
Chris Lattner2188e402010-01-04 07:37:31 +00004433 return NI;
4434 if (GEPOperator *GEP = dyn_cast<GEPOperator>(Op1))
Sanjay Patel43395062016-07-21 18:07:40 +00004435 if (Instruction *NI = foldGEPICmp(GEP, Op0,
Chris Lattner2188e402010-01-04 07:37:31 +00004436 ICmpInst::getSwappedPredicate(I.getPredicate()), I))
4437 return NI;
4438
Hans Wennborgf1f36512015-10-07 00:20:07 +00004439 // Try to optimize equality comparisons against alloca-based pointers.
4440 if (Op0->getType()->isPointerTy() && I.isEquality()) {
4441 assert(Op1->getType()->isPointerTy() && "Comparing pointer with non-pointer?");
4442 if (auto *Alloca = dyn_cast<AllocaInst>(GetUnderlyingObject(Op0, DL)))
Sanjay Patel43395062016-07-21 18:07:40 +00004443 if (Instruction *New = foldAllocaCmp(I, Alloca, Op1))
Hans Wennborgf1f36512015-10-07 00:20:07 +00004444 return New;
4445 if (auto *Alloca = dyn_cast<AllocaInst>(GetUnderlyingObject(Op1, DL)))
Sanjay Patel43395062016-07-21 18:07:40 +00004446 if (Instruction *New = foldAllocaCmp(I, Alloca, Op0))
Hans Wennborgf1f36512015-10-07 00:20:07 +00004447 return New;
4448 }
4449
Chris Lattner2188e402010-01-04 07:37:31 +00004450 // Test to see if the operands of the icmp are casted versions of other
4451 // values. If the ptr->ptr cast can be stripped off both arguments, we do so
4452 // now.
4453 if (BitCastInst *CI = dyn_cast<BitCastInst>(Op0)) {
Jim Grosbach129c52a2011-09-30 18:09:53 +00004454 if (Op0->getType()->isPointerTy() &&
4455 (isa<Constant>(Op1) || isa<BitCastInst>(Op1))) {
Chris Lattner2188e402010-01-04 07:37:31 +00004456 // We keep moving the cast from the left operand over to the right
4457 // operand, where it can often be eliminated completely.
4458 Op0 = CI->getOperand(0);
4459
4460 // If operand #1 is a bitcast instruction, it must also be a ptr->ptr cast
4461 // so eliminate it as well.
4462 if (BitCastInst *CI2 = dyn_cast<BitCastInst>(Op1))
4463 Op1 = CI2->getOperand(0);
4464
4465 // If Op1 is a constant, we can fold the cast into the constant.
4466 if (Op0->getType() != Op1->getType()) {
4467 if (Constant *Op1C = dyn_cast<Constant>(Op1)) {
4468 Op1 = ConstantExpr::getBitCast(Op1C, Op0->getType());
4469 } else {
4470 // Otherwise, cast the RHS right before the icmp
4471 Op1 = Builder->CreateBitCast(Op1, Op0->getType());
4472 }
4473 }
4474 return new ICmpInst(I.getPredicate(), Op0, Op1);
4475 }
4476 }
Jim Grosbach129c52a2011-09-30 18:09:53 +00004477
Chris Lattner2188e402010-01-04 07:37:31 +00004478 if (isa<CastInst>(Op0)) {
4479 // Handle the special case of: icmp (cast bool to X), <cst>
4480 // This comes up when you have code like
4481 // int X = A < B;
4482 // if (X) ...
4483 // For generality, we handle any zero-extension of any operand comparison
4484 // with a constant or another cast from the same type.
4485 if (isa<Constant>(Op1) || isa<CastInst>(Op1))
Sanjay Patel43395062016-07-21 18:07:40 +00004486 if (Instruction *R = foldICmpWithCastAndCast(I))
Chris Lattner2188e402010-01-04 07:37:31 +00004487 return R;
4488 }
Chris Lattner2188e402010-01-04 07:37:31 +00004489
Sanjay Patel10494b22016-09-16 16:10:22 +00004490 if (Instruction *Res = foldICmpBinOp(I))
4491 return Res;
Duncan Sandse5220012011-02-17 07:46:37 +00004492
Sanjay Pateldd46b522016-12-19 17:32:37 +00004493 if (Instruction *Res = foldICmpWithMinMax(I))
Sanjay Pateld6406412016-12-15 19:13:37 +00004494 return Res;
4495
Sanjay Patel10494b22016-09-16 16:10:22 +00004496 {
4497 Value *A, *B;
David Majnemer1a08acc2013-04-12 17:25:07 +00004498 // Transform (A & ~B) == 0 --> (A & B) != 0
4499 // and (A & ~B) != 0 --> (A & B) == 0
4500 // if A is a power of 2.
4501 if (match(Op0, m_And(m_Value(A), m_Not(m_Value(B)))) &&
Chandler Carruth66b31302015-01-04 12:03:27 +00004502 match(Op1, m_Zero()) &&
Daniel Jasperaec2fa32016-12-19 08:22:17 +00004503 isKnownToBeAPowerOfTwo(A, DL, false, 0, &AC, &I, &DT) && I.isEquality())
David Majnemer1a08acc2013-04-12 17:25:07 +00004504 return new ICmpInst(I.getInversePredicate(),
4505 Builder->CreateAnd(A, B),
4506 Op1);
4507
Chris Lattnerf3c4eef2011-01-15 05:41:33 +00004508 // ~x < ~y --> y < x
4509 // ~x < cst --> ~cst < x
4510 if (match(Op0, m_Not(m_Value(A)))) {
4511 if (match(Op1, m_Not(m_Value(B))))
4512 return new ICmpInst(I.getPredicate(), B, A);
Chris Lattner497459d2011-01-15 05:42:47 +00004513 if (ConstantInt *RHSC = dyn_cast<ConstantInt>(Op1))
Chris Lattnerf3c4eef2011-01-15 05:41:33 +00004514 return new ICmpInst(I.getPredicate(), ConstantExpr::getNot(RHSC), A);
4515 }
Chris Lattner5e0c0c72010-12-19 19:37:52 +00004516
Sanjoy Dasb6c59142015-04-10 21:07:09 +00004517 Instruction *AddI = nullptr;
4518 if (match(&I, m_UAddWithOverflow(m_Value(A), m_Value(B),
4519 m_Instruction(AddI))) &&
4520 isa<IntegerType>(A->getType())) {
4521 Value *Result;
4522 Constant *Overflow;
4523 if (OptimizeOverflowCheck(OCF_UNSIGNED_ADD, A, B, *AddI, Result,
4524 Overflow)) {
Sanjay Patel4b198802016-02-01 22:23:39 +00004525 replaceInstUsesWith(*AddI, Result);
4526 return replaceInstUsesWith(I, Overflow);
Sanjoy Dasb6c59142015-04-10 21:07:09 +00004527 }
4528 }
Serge Pavlov4bb54d52014-04-13 18:23:41 +00004529
4530 // (zext a) * (zext b) --> llvm.umul.with.overflow.
4531 if (match(Op0, m_Mul(m_ZExt(m_Value(A)), m_ZExt(m_Value(B))))) {
Sanjay Pateld93c4c02016-09-15 18:22:25 +00004532 if (Instruction *R = processUMulZExtIdiom(I, Op0, Op1, *this))
Serge Pavlov4bb54d52014-04-13 18:23:41 +00004533 return R;
4534 }
4535 if (match(Op1, m_Mul(m_ZExt(m_Value(A)), m_ZExt(m_Value(B))))) {
Sanjay Pateld93c4c02016-09-15 18:22:25 +00004536 if (Instruction *R = processUMulZExtIdiom(I, Op1, Op0, *this))
Serge Pavlov4bb54d52014-04-13 18:23:41 +00004537 return R;
4538 }
Chris Lattner2188e402010-01-04 07:37:31 +00004539 }
Jim Grosbach129c52a2011-09-30 18:09:53 +00004540
Sanjay Patel10494b22016-09-16 16:10:22 +00004541 if (Instruction *Res = foldICmpEquality(I))
4542 return Res;
Jim Grosbach129c52a2011-09-30 18:09:53 +00004543
David Majnemerc1eca5a2014-11-06 23:23:30 +00004544 // The 'cmpxchg' instruction returns an aggregate containing the old value and
4545 // an i1 which indicates whether or not we successfully did the swap.
4546 //
4547 // Replace comparisons between the old value and the expected value with the
4548 // indicator that 'cmpxchg' returns.
4549 //
4550 // N.B. This transform is only valid when the 'cmpxchg' is not permitted to
4551 // spuriously fail. In those cases, the old value may equal the expected
4552 // value but it is possible for the swap to not occur.
4553 if (I.getPredicate() == ICmpInst::ICMP_EQ)
4554 if (auto *EVI = dyn_cast<ExtractValueInst>(Op0))
4555 if (auto *ACXI = dyn_cast<AtomicCmpXchgInst>(EVI->getAggregateOperand()))
4556 if (EVI->getIndices()[0] == 0 && ACXI->getCompareOperand() == Op1 &&
4557 !ACXI->isWeak())
4558 return ExtractValueInst::Create(ACXI, 1);
4559
Chris Lattner2188e402010-01-04 07:37:31 +00004560 {
4561 Value *X; ConstantInt *Cst;
4562 // icmp X+Cst, X
4563 if (match(Op0, m_Add(m_Value(X), m_ConstantInt(Cst))) && Op1 == X)
Sanjay Patel43395062016-07-21 18:07:40 +00004564 return foldICmpAddOpConst(I, X, Cst, I.getPredicate());
Chris Lattner2188e402010-01-04 07:37:31 +00004565
4566 // icmp X, X+Cst
4567 if (match(Op1, m_Add(m_Value(X), m_ConstantInt(Cst))) && Op0 == X)
Sanjay Patel43395062016-07-21 18:07:40 +00004568 return foldICmpAddOpConst(I, X, Cst, I.getSwappedPredicate());
Chris Lattner2188e402010-01-04 07:37:31 +00004569 }
Craig Topperf40110f2014-04-25 05:29:35 +00004570 return Changed ? &I : nullptr;
Chris Lattner2188e402010-01-04 07:37:31 +00004571}
4572
Sanjay Patel5f0217f2016-06-05 16:46:18 +00004573/// Fold fcmp ([us]itofp x, cst) if possible.
Sanjay Patel43395062016-07-21 18:07:40 +00004574Instruction *InstCombiner::foldFCmpIntToFPConst(FCmpInst &I, Instruction *LHSI,
Chris Lattner2188e402010-01-04 07:37:31 +00004575 Constant *RHSC) {
Craig Topperf40110f2014-04-25 05:29:35 +00004576 if (!isa<ConstantFP>(RHSC)) return nullptr;
Chris Lattner2188e402010-01-04 07:37:31 +00004577 const APFloat &RHS = cast<ConstantFP>(RHSC)->getValueAPF();
Jim Grosbach129c52a2011-09-30 18:09:53 +00004578
Chris Lattner2188e402010-01-04 07:37:31 +00004579 // Get the width of the mantissa. We don't want to hack on conversions that
4580 // might lose information from the integer, e.g. "i64 -> float"
4581 int MantissaWidth = LHSI->getType()->getFPMantissaWidth();
Craig Topperf40110f2014-04-25 05:29:35 +00004582 if (MantissaWidth == -1) return nullptr; // Unknown.
Jim Grosbach129c52a2011-09-30 18:09:53 +00004583
Matt Arsenault55e73122015-01-06 15:50:59 +00004584 IntegerType *IntTy = cast<IntegerType>(LHSI->getOperand(0)->getType());
4585
Chris Lattner2188e402010-01-04 07:37:31 +00004586 bool LHSUnsigned = isa<UIToFPInst>(LHSI);
Jim Grosbach129c52a2011-09-30 18:09:53 +00004587
Matt Arsenault55e73122015-01-06 15:50:59 +00004588 if (I.isEquality()) {
4589 FCmpInst::Predicate P = I.getPredicate();
4590 bool IsExact = false;
4591 APSInt RHSCvt(IntTy->getBitWidth(), LHSUnsigned);
4592 RHS.convertToInteger(RHSCvt, APFloat::rmNearestTiesToEven, &IsExact);
4593
4594 // If the floating point constant isn't an integer value, we know if we will
4595 // ever compare equal / not equal to it.
4596 if (!IsExact) {
4597 // TODO: Can never be -0.0 and other non-representable values
4598 APFloat RHSRoundInt(RHS);
4599 RHSRoundInt.roundToIntegral(APFloat::rmNearestTiesToEven);
4600 if (RHS.compare(RHSRoundInt) != APFloat::cmpEqual) {
4601 if (P == FCmpInst::FCMP_OEQ || P == FCmpInst::FCMP_UEQ)
Sanjay Patel4b198802016-02-01 22:23:39 +00004602 return replaceInstUsesWith(I, Builder->getFalse());
Matt Arsenault55e73122015-01-06 15:50:59 +00004603
4604 assert(P == FCmpInst::FCMP_ONE || P == FCmpInst::FCMP_UNE);
Sanjay Patel4b198802016-02-01 22:23:39 +00004605 return replaceInstUsesWith(I, Builder->getTrue());
Matt Arsenault55e73122015-01-06 15:50:59 +00004606 }
4607 }
4608
4609 // TODO: If the constant is exactly representable, is it always OK to do
4610 // equality compares as integer?
4611 }
4612
Arch D. Robison8ed08542015-09-15 17:51:59 +00004613 // Check to see that the input is converted from an integer type that is small
4614 // enough that preserves all bits. TODO: check here for "known" sign bits.
4615 // This would allow us to handle (fptosi (x >>s 62) to float) if x is i64 f.e.
4616 unsigned InputSize = IntTy->getScalarSizeInBits();
Matt Arsenault55e73122015-01-06 15:50:59 +00004617
Justin Bognerc7e4fbe2016-08-05 01:09:48 +00004618 // Following test does NOT adjust InputSize downwards for signed inputs,
4619 // because the most negative value still requires all the mantissa bits
Arch D. Robison8ed08542015-09-15 17:51:59 +00004620 // to distinguish it from one less than that value.
4621 if ((int)InputSize > MantissaWidth) {
4622 // Conversion would lose accuracy. Check if loss can impact comparison.
4623 int Exp = ilogb(RHS);
4624 if (Exp == APFloat::IEK_Inf) {
4625 int MaxExponent = ilogb(APFloat::getLargest(RHS.getSemantics()));
Justin Bognerc7e4fbe2016-08-05 01:09:48 +00004626 if (MaxExponent < (int)InputSize - !LHSUnsigned)
Arch D. Robison8ed08542015-09-15 17:51:59 +00004627 // Conversion could create infinity.
4628 return nullptr;
4629 } else {
Justin Bognerc7e4fbe2016-08-05 01:09:48 +00004630 // Note that if RHS is zero or NaN, then Exp is negative
Arch D. Robison8ed08542015-09-15 17:51:59 +00004631 // and first condition is trivially false.
Justin Bognerc7e4fbe2016-08-05 01:09:48 +00004632 if (MantissaWidth <= Exp && Exp <= (int)InputSize - !LHSUnsigned)
Arch D. Robison8ed08542015-09-15 17:51:59 +00004633 // Conversion could affect comparison.
4634 return nullptr;
4635 }
4636 }
Jim Grosbach129c52a2011-09-30 18:09:53 +00004637
Chris Lattner2188e402010-01-04 07:37:31 +00004638 // Otherwise, we can potentially simplify the comparison. We know that it
4639 // will always come through as an integer value and we know the constant is
4640 // not a NAN (it would have been previously simplified).
4641 assert(!RHS.isNaN() && "NaN comparison not already folded!");
Jim Grosbach129c52a2011-09-30 18:09:53 +00004642
Chris Lattner2188e402010-01-04 07:37:31 +00004643 ICmpInst::Predicate Pred;
4644 switch (I.getPredicate()) {
4645 default: llvm_unreachable("Unexpected predicate!");
4646 case FCmpInst::FCMP_UEQ:
4647 case FCmpInst::FCMP_OEQ:
4648 Pred = ICmpInst::ICMP_EQ;
4649 break;
4650 case FCmpInst::FCMP_UGT:
4651 case FCmpInst::FCMP_OGT:
4652 Pred = LHSUnsigned ? ICmpInst::ICMP_UGT : ICmpInst::ICMP_SGT;
4653 break;
4654 case FCmpInst::FCMP_UGE:
4655 case FCmpInst::FCMP_OGE:
4656 Pred = LHSUnsigned ? ICmpInst::ICMP_UGE : ICmpInst::ICMP_SGE;
4657 break;
4658 case FCmpInst::FCMP_ULT:
4659 case FCmpInst::FCMP_OLT:
4660 Pred = LHSUnsigned ? ICmpInst::ICMP_ULT : ICmpInst::ICMP_SLT;
4661 break;
4662 case FCmpInst::FCMP_ULE:
4663 case FCmpInst::FCMP_OLE:
4664 Pred = LHSUnsigned ? ICmpInst::ICMP_ULE : ICmpInst::ICMP_SLE;
4665 break;
4666 case FCmpInst::FCMP_UNE:
4667 case FCmpInst::FCMP_ONE:
4668 Pred = ICmpInst::ICMP_NE;
4669 break;
4670 case FCmpInst::FCMP_ORD:
Sanjay Patel4b198802016-02-01 22:23:39 +00004671 return replaceInstUsesWith(I, Builder->getTrue());
Chris Lattner2188e402010-01-04 07:37:31 +00004672 case FCmpInst::FCMP_UNO:
Sanjay Patel4b198802016-02-01 22:23:39 +00004673 return replaceInstUsesWith(I, Builder->getFalse());
Chris Lattner2188e402010-01-04 07:37:31 +00004674 }
Jim Grosbach129c52a2011-09-30 18:09:53 +00004675
Chris Lattner2188e402010-01-04 07:37:31 +00004676 // Now we know that the APFloat is a normal number, zero or inf.
Jim Grosbach129c52a2011-09-30 18:09:53 +00004677
Chris Lattner2188e402010-01-04 07:37:31 +00004678 // See if the FP constant is too large for the integer. For example,
4679 // comparing an i8 to 300.0.
4680 unsigned IntWidth = IntTy->getScalarSizeInBits();
Jim Grosbach129c52a2011-09-30 18:09:53 +00004681
Chris Lattner2188e402010-01-04 07:37:31 +00004682 if (!LHSUnsigned) {
4683 // If the RHS value is > SignedMax, fold the comparison. This handles +INF
4684 // and large values.
Michael Gottesman79b09672013-06-27 21:58:19 +00004685 APFloat SMax(RHS.getSemantics());
Chris Lattner2188e402010-01-04 07:37:31 +00004686 SMax.convertFromAPInt(APInt::getSignedMaxValue(IntWidth), true,
4687 APFloat::rmNearestTiesToEven);
4688 if (SMax.compare(RHS) == APFloat::cmpLessThan) { // smax < 13123.0
4689 if (Pred == ICmpInst::ICMP_NE || Pred == ICmpInst::ICMP_SLT ||
4690 Pred == ICmpInst::ICMP_SLE)
Sanjay Patel4b198802016-02-01 22:23:39 +00004691 return replaceInstUsesWith(I, Builder->getTrue());
4692 return replaceInstUsesWith(I, Builder->getFalse());
Chris Lattner2188e402010-01-04 07:37:31 +00004693 }
4694 } else {
4695 // If the RHS value is > UnsignedMax, fold the comparison. This handles
4696 // +INF and large values.
Michael Gottesman79b09672013-06-27 21:58:19 +00004697 APFloat UMax(RHS.getSemantics());
Chris Lattner2188e402010-01-04 07:37:31 +00004698 UMax.convertFromAPInt(APInt::getMaxValue(IntWidth), false,
4699 APFloat::rmNearestTiesToEven);
4700 if (UMax.compare(RHS) == APFloat::cmpLessThan) { // umax < 13123.0
4701 if (Pred == ICmpInst::ICMP_NE || Pred == ICmpInst::ICMP_ULT ||
4702 Pred == ICmpInst::ICMP_ULE)
Sanjay Patel4b198802016-02-01 22:23:39 +00004703 return replaceInstUsesWith(I, Builder->getTrue());
4704 return replaceInstUsesWith(I, Builder->getFalse());
Chris Lattner2188e402010-01-04 07:37:31 +00004705 }
4706 }
Jim Grosbach129c52a2011-09-30 18:09:53 +00004707
Chris Lattner2188e402010-01-04 07:37:31 +00004708 if (!LHSUnsigned) {
4709 // See if the RHS value is < SignedMin.
Michael Gottesman79b09672013-06-27 21:58:19 +00004710 APFloat SMin(RHS.getSemantics());
Chris Lattner2188e402010-01-04 07:37:31 +00004711 SMin.convertFromAPInt(APInt::getSignedMinValue(IntWidth), true,
4712 APFloat::rmNearestTiesToEven);
4713 if (SMin.compare(RHS) == APFloat::cmpGreaterThan) { // smin > 12312.0
4714 if (Pred == ICmpInst::ICMP_NE || Pred == ICmpInst::ICMP_SGT ||
4715 Pred == ICmpInst::ICMP_SGE)
Sanjay Patel4b198802016-02-01 22:23:39 +00004716 return replaceInstUsesWith(I, Builder->getTrue());
4717 return replaceInstUsesWith(I, Builder->getFalse());
Chris Lattner2188e402010-01-04 07:37:31 +00004718 }
Devang Patel698452b2012-02-13 23:05:18 +00004719 } else {
4720 // See if the RHS value is < UnsignedMin.
Michael Gottesman79b09672013-06-27 21:58:19 +00004721 APFloat SMin(RHS.getSemantics());
Devang Patel698452b2012-02-13 23:05:18 +00004722 SMin.convertFromAPInt(APInt::getMinValue(IntWidth), true,
4723 APFloat::rmNearestTiesToEven);
4724 if (SMin.compare(RHS) == APFloat::cmpGreaterThan) { // umin > 12312.0
4725 if (Pred == ICmpInst::ICMP_NE || Pred == ICmpInst::ICMP_UGT ||
4726 Pred == ICmpInst::ICMP_UGE)
Sanjay Patel4b198802016-02-01 22:23:39 +00004727 return replaceInstUsesWith(I, Builder->getTrue());
4728 return replaceInstUsesWith(I, Builder->getFalse());
Devang Patel698452b2012-02-13 23:05:18 +00004729 }
Chris Lattner2188e402010-01-04 07:37:31 +00004730 }
4731
4732 // Okay, now we know that the FP constant fits in the range [SMIN, SMAX] or
4733 // [0, UMAX], but it may still be fractional. See if it is fractional by
4734 // casting the FP value to the integer value and back, checking for equality.
4735 // Don't do this for zero, because -0.0 is not fractional.
4736 Constant *RHSInt = LHSUnsigned
4737 ? ConstantExpr::getFPToUI(RHSC, IntTy)
4738 : ConstantExpr::getFPToSI(RHSC, IntTy);
4739 if (!RHS.isZero()) {
4740 bool Equal = LHSUnsigned
4741 ? ConstantExpr::getUIToFP(RHSInt, RHSC->getType()) == RHSC
4742 : ConstantExpr::getSIToFP(RHSInt, RHSC->getType()) == RHSC;
4743 if (!Equal) {
4744 // If we had a comparison against a fractional value, we have to adjust
4745 // the compare predicate and sometimes the value. RHSC is rounded towards
4746 // zero at this point.
4747 switch (Pred) {
4748 default: llvm_unreachable("Unexpected integer comparison!");
4749 case ICmpInst::ICMP_NE: // (float)int != 4.4 --> true
Sanjay Patel4b198802016-02-01 22:23:39 +00004750 return replaceInstUsesWith(I, Builder->getTrue());
Chris Lattner2188e402010-01-04 07:37:31 +00004751 case ICmpInst::ICMP_EQ: // (float)int == 4.4 --> false
Sanjay Patel4b198802016-02-01 22:23:39 +00004752 return replaceInstUsesWith(I, Builder->getFalse());
Chris Lattner2188e402010-01-04 07:37:31 +00004753 case ICmpInst::ICMP_ULE:
4754 // (float)int <= 4.4 --> int <= 4
4755 // (float)int <= -4.4 --> false
4756 if (RHS.isNegative())
Sanjay Patel4b198802016-02-01 22:23:39 +00004757 return replaceInstUsesWith(I, Builder->getFalse());
Chris Lattner2188e402010-01-04 07:37:31 +00004758 break;
4759 case ICmpInst::ICMP_SLE:
4760 // (float)int <= 4.4 --> int <= 4
4761 // (float)int <= -4.4 --> int < -4
4762 if (RHS.isNegative())
4763 Pred = ICmpInst::ICMP_SLT;
4764 break;
4765 case ICmpInst::ICMP_ULT:
4766 // (float)int < -4.4 --> false
4767 // (float)int < 4.4 --> int <= 4
4768 if (RHS.isNegative())
Sanjay Patel4b198802016-02-01 22:23:39 +00004769 return replaceInstUsesWith(I, Builder->getFalse());
Chris Lattner2188e402010-01-04 07:37:31 +00004770 Pred = ICmpInst::ICMP_ULE;
4771 break;
4772 case ICmpInst::ICMP_SLT:
4773 // (float)int < -4.4 --> int < -4
4774 // (float)int < 4.4 --> int <= 4
4775 if (!RHS.isNegative())
4776 Pred = ICmpInst::ICMP_SLE;
4777 break;
4778 case ICmpInst::ICMP_UGT:
4779 // (float)int > 4.4 --> int > 4
4780 // (float)int > -4.4 --> true
4781 if (RHS.isNegative())
Sanjay Patel4b198802016-02-01 22:23:39 +00004782 return replaceInstUsesWith(I, Builder->getTrue());
Chris Lattner2188e402010-01-04 07:37:31 +00004783 break;
4784 case ICmpInst::ICMP_SGT:
4785 // (float)int > 4.4 --> int > 4
4786 // (float)int > -4.4 --> int >= -4
4787 if (RHS.isNegative())
4788 Pred = ICmpInst::ICMP_SGE;
4789 break;
4790 case ICmpInst::ICMP_UGE:
4791 // (float)int >= -4.4 --> true
4792 // (float)int >= 4.4 --> int > 4
Bob Wilson61f3ad52012-08-07 22:35:16 +00004793 if (RHS.isNegative())
Sanjay Patel4b198802016-02-01 22:23:39 +00004794 return replaceInstUsesWith(I, Builder->getTrue());
Chris Lattner2188e402010-01-04 07:37:31 +00004795 Pred = ICmpInst::ICMP_UGT;
4796 break;
4797 case ICmpInst::ICMP_SGE:
4798 // (float)int >= -4.4 --> int >= -4
4799 // (float)int >= 4.4 --> int > 4
4800 if (!RHS.isNegative())
4801 Pred = ICmpInst::ICMP_SGT;
4802 break;
4803 }
4804 }
4805 }
4806
4807 // Lower this FP comparison into an appropriate integer version of the
4808 // comparison.
4809 return new ICmpInst(Pred, LHSI->getOperand(0), RHSInt);
4810}
4811
4812Instruction *InstCombiner::visitFCmpInst(FCmpInst &I) {
4813 bool Changed = false;
Jim Grosbach129c52a2011-09-30 18:09:53 +00004814
Chris Lattner2188e402010-01-04 07:37:31 +00004815 /// Orders the operands of the compare so that they are listed from most
4816 /// complex to least complex. This puts constants before unary operators,
4817 /// before binary operators.
4818 if (getComplexity(I.getOperand(0)) < getComplexity(I.getOperand(1))) {
4819 I.swapOperands();
4820 Changed = true;
4821 }
4822
4823 Value *Op0 = I.getOperand(0), *Op1 = I.getOperand(1);
Jim Grosbach129c52a2011-09-30 18:09:53 +00004824
Daniel Berlin2c75c632017-04-26 20:56:07 +00004825 if (Value *V =
4826 SimplifyFCmpInst(I.getPredicate(), Op0, Op1, I.getFastMathFlags(),
4827 SQ.getWithInstruction(&I)))
Sanjay Patel4b198802016-02-01 22:23:39 +00004828 return replaceInstUsesWith(I, V);
Chris Lattner2188e402010-01-04 07:37:31 +00004829
4830 // Simplify 'fcmp pred X, X'
4831 if (Op0 == Op1) {
4832 switch (I.getPredicate()) {
4833 default: llvm_unreachable("Unknown predicate!");
4834 case FCmpInst::FCMP_UNO: // True if unordered: isnan(X) | isnan(Y)
4835 case FCmpInst::FCMP_ULT: // True if unordered or less than
4836 case FCmpInst::FCMP_UGT: // True if unordered or greater than
4837 case FCmpInst::FCMP_UNE: // True if unordered or not equal
4838 // Canonicalize these to be 'fcmp uno %X, 0.0'.
4839 I.setPredicate(FCmpInst::FCMP_UNO);
4840 I.setOperand(1, Constant::getNullValue(Op0->getType()));
4841 return &I;
Jim Grosbach129c52a2011-09-30 18:09:53 +00004842
Chris Lattner2188e402010-01-04 07:37:31 +00004843 case FCmpInst::FCMP_ORD: // True if ordered (no nans)
4844 case FCmpInst::FCMP_OEQ: // True if ordered and equal
4845 case FCmpInst::FCMP_OGE: // True if ordered and greater than or equal
4846 case FCmpInst::FCMP_OLE: // True if ordered and less than or equal
4847 // Canonicalize these to be 'fcmp ord %X, 0.0'.
4848 I.setPredicate(FCmpInst::FCMP_ORD);
4849 I.setOperand(1, Constant::getNullValue(Op0->getType()));
4850 return &I;
4851 }
4852 }
Jim Grosbach129c52a2011-09-30 18:09:53 +00004853
James Molloy2b21a7c2015-05-20 18:41:25 +00004854 // Test if the FCmpInst instruction is used exclusively by a select as
4855 // part of a minimum or maximum operation. If so, refrain from doing
4856 // any other folding. This helps out other analyses which understand
4857 // non-obfuscated minimum and maximum idioms, such as ScalarEvolution
4858 // and CodeGen. And in this case, at least one of the comparison
4859 // operands has at least one user besides the compare (the select),
4860 // which would often largely negate the benefit of folding anyway.
4861 if (I.hasOneUse())
4862 if (SelectInst *SI = dyn_cast<SelectInst>(*I.user_begin()))
4863 if ((SI->getOperand(1) == Op0 && SI->getOperand(2) == Op1) ||
4864 (SI->getOperand(2) == Op0 && SI->getOperand(1) == Op1))
4865 return nullptr;
4866
Chris Lattner2188e402010-01-04 07:37:31 +00004867 // Handle fcmp with constant RHS
4868 if (Constant *RHSC = dyn_cast<Constant>(Op1)) {
4869 if (Instruction *LHSI = dyn_cast<Instruction>(Op0))
4870 switch (LHSI->getOpcode()) {
Benjamin Kramercbb18e92011-03-31 10:12:07 +00004871 case Instruction::FPExt: {
4872 // fcmp (fpext x), C -> fcmp x, (fptrunc C) if fptrunc is lossless
4873 FPExtInst *LHSExt = cast<FPExtInst>(LHSI);
4874 ConstantFP *RHSF = dyn_cast<ConstantFP>(RHSC);
4875 if (!RHSF)
4876 break;
4877
4878 const fltSemantics *Sem;
4879 // FIXME: This shouldn't be here.
Dan Gohman518cda42011-12-17 00:04:22 +00004880 if (LHSExt->getSrcTy()->isHalfTy())
Stephan Bergmann17c7f702016-12-14 11:57:17 +00004881 Sem = &APFloat::IEEEhalf();
Dan Gohman518cda42011-12-17 00:04:22 +00004882 else if (LHSExt->getSrcTy()->isFloatTy())
Stephan Bergmann17c7f702016-12-14 11:57:17 +00004883 Sem = &APFloat::IEEEsingle();
Benjamin Kramercbb18e92011-03-31 10:12:07 +00004884 else if (LHSExt->getSrcTy()->isDoubleTy())
Stephan Bergmann17c7f702016-12-14 11:57:17 +00004885 Sem = &APFloat::IEEEdouble();
Benjamin Kramercbb18e92011-03-31 10:12:07 +00004886 else if (LHSExt->getSrcTy()->isFP128Ty())
Stephan Bergmann17c7f702016-12-14 11:57:17 +00004887 Sem = &APFloat::IEEEquad();
Benjamin Kramercbb18e92011-03-31 10:12:07 +00004888 else if (LHSExt->getSrcTy()->isX86_FP80Ty())
Stephan Bergmann17c7f702016-12-14 11:57:17 +00004889 Sem = &APFloat::x87DoubleExtended();
Ulrich Weigand6a9bb512012-10-30 12:33:18 +00004890 else if (LHSExt->getSrcTy()->isPPC_FP128Ty())
Stephan Bergmann17c7f702016-12-14 11:57:17 +00004891 Sem = &APFloat::PPCDoubleDouble();
Benjamin Kramercbb18e92011-03-31 10:12:07 +00004892 else
4893 break;
4894
4895 bool Lossy;
4896 APFloat F = RHSF->getValueAPF();
4897 F.convert(*Sem, APFloat::rmNearestTiesToEven, &Lossy);
4898
Jim Grosbach24ff8342011-09-30 18:45:50 +00004899 // Avoid lossy conversions and denormals. Zero is a special case
4900 // that's OK to convert.
Jim Grosbach011dafb2011-09-30 19:58:46 +00004901 APFloat Fabs = F;
4902 Fabs.clearSign();
Benjamin Kramercbb18e92011-03-31 10:12:07 +00004903 if (!Lossy &&
Jim Grosbach011dafb2011-09-30 19:58:46 +00004904 ((Fabs.compare(APFloat::getSmallestNormalized(*Sem)) !=
4905 APFloat::cmpLessThan) || Fabs.isZero()))
Jim Grosbach24ff8342011-09-30 18:45:50 +00004906
Benjamin Kramercbb18e92011-03-31 10:12:07 +00004907 return new FCmpInst(I.getPredicate(), LHSExt->getOperand(0),
4908 ConstantFP::get(RHSC->getContext(), F));
4909 break;
4910 }
Chris Lattner2188e402010-01-04 07:37:31 +00004911 case Instruction::PHI:
4912 // Only fold fcmp into the PHI if the phi and fcmp are in the same
4913 // block. If in the same block, we're encouraging jump threading. If
4914 // not, we are just pessimizing the code by making an i1 phi.
4915 if (LHSI->getParent() == I.getParent())
Craig Topperfb71b7d2017-04-14 19:20:12 +00004916 if (Instruction *NV = foldOpIntoPhi(I, cast<PHINode>(LHSI)))
Chris Lattner2188e402010-01-04 07:37:31 +00004917 return NV;
4918 break;
4919 case Instruction::SIToFP:
4920 case Instruction::UIToFP:
Sanjay Patel43395062016-07-21 18:07:40 +00004921 if (Instruction *NV = foldFCmpIntToFPConst(I, LHSI, RHSC))
Chris Lattner2188e402010-01-04 07:37:31 +00004922 return NV;
4923 break;
Benjamin Kramera8c5d082011-03-31 10:12:15 +00004924 case Instruction::FSub: {
4925 // fcmp pred (fneg x), C -> fcmp swap(pred) x, -C
4926 Value *Op;
4927 if (match(LHSI, m_FNeg(m_Value(Op))))
4928 return new FCmpInst(I.getSwappedPredicate(), Op,
4929 ConstantExpr::getFNeg(RHSC));
4930 break;
4931 }
Dan Gohman94732022010-02-24 06:46:09 +00004932 case Instruction::Load:
4933 if (GetElementPtrInst *GEP =
4934 dyn_cast<GetElementPtrInst>(LHSI->getOperand(0))) {
4935 if (GlobalVariable *GV = dyn_cast<GlobalVariable>(GEP->getOperand(0)))
4936 if (GV->isConstant() && GV->hasDefinitiveInitializer() &&
4937 !cast<LoadInst>(LHSI)->isVolatile())
Sanjay Patel43395062016-07-21 18:07:40 +00004938 if (Instruction *Res = foldCmpLoadFromIndexedGlobal(GEP, GV, I))
Dan Gohman94732022010-02-24 06:46:09 +00004939 return Res;
4940 }
4941 break;
Benjamin Kramer8c2a7332012-08-18 20:06:47 +00004942 case Instruction::Call: {
Matt Arsenaultb935d9d2015-01-08 20:09:34 +00004943 if (!RHSC->isNullValue())
4944 break;
4945
Benjamin Kramer8c2a7332012-08-18 20:06:47 +00004946 CallInst *CI = cast<CallInst>(LHSI);
Justin Bogner99798402016-08-05 01:06:44 +00004947 Intrinsic::ID IID = getIntrinsicForCallSite(CI, &TLI);
David Majnemer2e02ba72016-04-15 17:21:03 +00004948 if (IID != Intrinsic::fabs)
Matt Arsenaultb935d9d2015-01-08 20:09:34 +00004949 break;
4950
Benjamin Kramer8c2a7332012-08-18 20:06:47 +00004951 // Various optimization for fabs compared with zero.
David Majnemer2e02ba72016-04-15 17:21:03 +00004952 switch (I.getPredicate()) {
4953 default:
4954 break;
4955 // fabs(x) < 0 --> false
4956 case FCmpInst::FCMP_OLT:
4957 llvm_unreachable("handled by SimplifyFCmpInst");
4958 // fabs(x) > 0 --> x != 0
4959 case FCmpInst::FCMP_OGT:
4960 return new FCmpInst(FCmpInst::FCMP_ONE, CI->getArgOperand(0), RHSC);
4961 // fabs(x) <= 0 --> x == 0
4962 case FCmpInst::FCMP_OLE:
4963 return new FCmpInst(FCmpInst::FCMP_OEQ, CI->getArgOperand(0), RHSC);
4964 // fabs(x) >= 0 --> !isnan(x)
4965 case FCmpInst::FCMP_OGE:
4966 return new FCmpInst(FCmpInst::FCMP_ORD, CI->getArgOperand(0), RHSC);
4967 // fabs(x) == 0 --> x == 0
4968 // fabs(x) != 0 --> x != 0
4969 case FCmpInst::FCMP_OEQ:
4970 case FCmpInst::FCMP_UEQ:
4971 case FCmpInst::FCMP_ONE:
4972 case FCmpInst::FCMP_UNE:
4973 return new FCmpInst(I.getPredicate(), CI->getArgOperand(0), RHSC);
Benjamin Kramer8c2a7332012-08-18 20:06:47 +00004974 }
4975 }
Chris Lattner2188e402010-01-04 07:37:31 +00004976 }
Chris Lattner2188e402010-01-04 07:37:31 +00004977 }
4978
Benjamin Kramerbe209ab2011-03-31 10:46:03 +00004979 // fcmp pred (fneg x), (fneg y) -> fcmp swap(pred) x, y
Benjamin Kramerd159d942011-03-31 10:12:22 +00004980 Value *X, *Y;
4981 if (match(Op0, m_FNeg(m_Value(X))) && match(Op1, m_FNeg(m_Value(Y))))
Benjamin Kramerbe209ab2011-03-31 10:46:03 +00004982 return new FCmpInst(I.getSwappedPredicate(), X, Y);
Benjamin Kramerd159d942011-03-31 10:12:22 +00004983
Benjamin Kramer2ccfbc82011-03-31 10:11:58 +00004984 // fcmp (fpext x), (fpext y) -> fcmp x, y
4985 if (FPExtInst *LHSExt = dyn_cast<FPExtInst>(Op0))
4986 if (FPExtInst *RHSExt = dyn_cast<FPExtInst>(Op1))
4987 if (LHSExt->getSrcTy() == RHSExt->getSrcTy())
4988 return new FCmpInst(I.getPredicate(), LHSExt->getOperand(0),
4989 RHSExt->getOperand(0));
4990
Craig Topperf40110f2014-04-25 05:29:35 +00004991 return Changed ? &I : nullptr;
Chris Lattner2188e402010-01-04 07:37:31 +00004992}