blob: cef8e055d0f7e2f05c2842158dd43246ce30a049 [file] [log] [blame]
Chris Lattner2188e402010-01-04 07:37:31 +00001//===- InstCombineCompares.cpp --------------------------------------------===//
2//
Chandler Carruth2946cd72019-01-19 08:50:56 +00003// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
4// See https://llvm.org/LICENSE.txt for license information.
5// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
Chris Lattner2188e402010-01-04 07:37:31 +00006//
7//===----------------------------------------------------------------------===//
8//
9// This file implements the visitICmp and visitFCmp functions.
10//
11//===----------------------------------------------------------------------===//
12
Chandler Carrutha9174582015-01-22 05:25:13 +000013#include "InstCombineInternal.h"
Matt Arsenault55e73122015-01-06 15:50:59 +000014#include "llvm/ADT/APSInt.h"
Silviu Barangaf29dfd32016-01-15 15:52:05 +000015#include "llvm/ADT/SetVector.h"
Gerolf Hoflehnerec6217c2014-11-21 23:36:44 +000016#include "llvm/ADT/Statistic.h"
Eli Friedman911e12f2011-07-20 21:57:23 +000017#include "llvm/Analysis/ConstantFolding.h"
Chris Lattner2188e402010-01-04 07:37:31 +000018#include "llvm/Analysis/InstructionSimplify.h"
Mehdi Aminib550cb12016-04-18 09:17:29 +000019#include "llvm/Analysis/TargetLibraryInfo.h"
Chandler Carruth8cd041e2014-03-04 12:24:34 +000020#include "llvm/IR/ConstantRange.h"
Chandler Carruth9fb823b2013-01-02 11:36:10 +000021#include "llvm/IR/DataLayout.h"
Chandler Carruth03eb0de2014-03-04 10:40:04 +000022#include "llvm/IR/GetElementPtrTypeIterator.h"
Chandler Carruth9fb823b2013-01-02 11:36:10 +000023#include "llvm/IR/IntrinsicInst.h"
Chandler Carruth820a9082014-03-04 11:08:18 +000024#include "llvm/IR/PatternMatch.h"
Gerolf Hoflehnerec6217c2014-11-21 23:36:44 +000025#include "llvm/Support/Debug.h"
Craig Topperb45eabc2017-04-26 16:39:58 +000026#include "llvm/Support/KnownBits.h"
Gerolf Hoflehnerec6217c2014-11-21 23:36:44 +000027
Chris Lattner2188e402010-01-04 07:37:31 +000028using namespace llvm;
29using namespace PatternMatch;
30
Chandler Carruth964daaa2014-04-22 02:55:47 +000031#define DEBUG_TYPE "instcombine"
32
Gerolf Hoflehnerec6217c2014-11-21 23:36:44 +000033// How many times is a select replaced by one of its operands?
34STATISTIC(NumSel, "Number of select opts");
35
Chris Lattner98457102011-02-10 05:23:05 +000036
Sanjay Patel5f0217f2016-06-05 16:46:18 +000037/// Compute Result = In1+In2, returning true if the result overflowed for this
38/// type.
Craig Topper6e025a32017-10-01 23:53:54 +000039static bool addWithOverflow(APInt &Result, const APInt &In1,
40 const APInt &In2, bool IsSigned = false) {
41 bool Overflow;
42 if (IsSigned)
43 Result = In1.sadd_ov(In2, Overflow);
44 else
45 Result = In1.uadd_ov(In2, Overflow);
Chris Lattner2188e402010-01-04 07:37:31 +000046
Craig Topper6e025a32017-10-01 23:53:54 +000047 return Overflow;
Chris Lattner2188e402010-01-04 07:37:31 +000048}
49
Sanjay Patel5f0217f2016-06-05 16:46:18 +000050/// Compute Result = In1-In2, returning true if the result overflowed for this
51/// type.
Craig Topper6e025a32017-10-01 23:53:54 +000052static bool subWithOverflow(APInt &Result, const APInt &In1,
53 const APInt &In2, bool IsSigned = false) {
54 bool Overflow;
55 if (IsSigned)
56 Result = In1.ssub_ov(In2, Overflow);
57 else
58 Result = In1.usub_ov(In2, Overflow);
Chris Lattner2188e402010-01-04 07:37:31 +000059
Craig Topper6e025a32017-10-01 23:53:54 +000060 return Overflow;
Chris Lattner2188e402010-01-04 07:37:31 +000061}
62
Balaram Makam569eaec2016-05-04 21:32:14 +000063/// Given an icmp instruction, return true if any use of this comparison is a
64/// branch on sign bit comparison.
Eric Christopher710c1c82017-06-30 01:35:31 +000065static bool hasBranchUse(ICmpInst &I) {
Balaram Makam569eaec2016-05-04 21:32:14 +000066 for (auto *U : I.users())
67 if (isa<BranchInst>(U))
Eric Christopher710c1c82017-06-30 01:35:31 +000068 return true;
Balaram Makam569eaec2016-05-04 21:32:14 +000069 return false;
70}
71
Sanjay Patel5f0217f2016-06-05 16:46:18 +000072/// Given an exploded icmp instruction, return true if the comparison only
73/// checks the sign bit. If it only checks the sign bit, set TrueIfSigned if the
74/// result of the comparison is true when the input value is signed.
Sanjay Patel79263662016-08-21 15:07:45 +000075static bool isSignBitCheck(ICmpInst::Predicate Pred, const APInt &RHS,
Chris Lattner2188e402010-01-04 07:37:31 +000076 bool &TrueIfSigned) {
Sanjay Patel5f0217f2016-06-05 16:46:18 +000077 switch (Pred) {
Chris Lattner2188e402010-01-04 07:37:31 +000078 case ICmpInst::ICMP_SLT: // True if LHS s< 0
79 TrueIfSigned = true;
Craig Topper73ba1c82017-06-07 07:40:37 +000080 return RHS.isNullValue();
Chris Lattner2188e402010-01-04 07:37:31 +000081 case ICmpInst::ICMP_SLE: // True if LHS s<= RHS and RHS == -1
82 TrueIfSigned = true;
Sanjay Patel79263662016-08-21 15:07:45 +000083 return RHS.isAllOnesValue();
Chris Lattner2188e402010-01-04 07:37:31 +000084 case ICmpInst::ICMP_SGT: // True if LHS s> -1
85 TrueIfSigned = false;
Sanjay Patel79263662016-08-21 15:07:45 +000086 return RHS.isAllOnesValue();
Chris Lattner2188e402010-01-04 07:37:31 +000087 case ICmpInst::ICMP_UGT:
88 // True if LHS u> RHS and RHS == high-bit-mask - 1
89 TrueIfSigned = true;
Sanjay Patel79263662016-08-21 15:07:45 +000090 return RHS.isMaxSignedValue();
Jim Grosbach129c52a2011-09-30 18:09:53 +000091 case ICmpInst::ICMP_UGE:
Chris Lattner2188e402010-01-04 07:37:31 +000092 // True if LHS u>= RHS and RHS == high-bit-mask (2^7, 2^15, 2^31, etc)
93 TrueIfSigned = true;
Craig Topperbcfd2d12017-04-20 16:56:25 +000094 return RHS.isSignMask();
Chris Lattner2188e402010-01-04 07:37:31 +000095 default:
96 return false;
97 }
98}
99
Arnaud A. de Grandmaison3ee88e82013-03-25 11:47:38 +0000100/// Returns true if the exploded icmp can be expressed as a signed comparison
101/// to zero and updates the predicate accordingly.
102/// The signedness of the comparison is preserved.
Sanjay Patel5b112842016-08-18 14:59:14 +0000103/// TODO: Refactor with decomposeBitTestICmp()?
104static bool isSignTest(ICmpInst::Predicate &Pred, const APInt &C) {
Sanjay Patel5f0217f2016-06-05 16:46:18 +0000105 if (!ICmpInst::isSigned(Pred))
Arnaud A. de Grandmaison9c383d62013-03-25 09:48:49 +0000106 return false;
107
Craig Topper73ba1c82017-06-07 07:40:37 +0000108 if (C.isNullValue())
Sanjay Patel5f0217f2016-06-05 16:46:18 +0000109 return ICmpInst::isRelational(Pred);
Arnaud A. de Grandmaison9c383d62013-03-25 09:48:49 +0000110
Craig Topper73ba1c82017-06-07 07:40:37 +0000111 if (C.isOneValue()) {
Sanjay Patel5f0217f2016-06-05 16:46:18 +0000112 if (Pred == ICmpInst::ICMP_SLT) {
113 Pred = ICmpInst::ICMP_SLE;
Arnaud A. de Grandmaison9c383d62013-03-25 09:48:49 +0000114 return true;
Arnaud A. de Grandmaison9c383d62013-03-25 09:48:49 +0000115 }
Sanjay Patel5b112842016-08-18 14:59:14 +0000116 } else if (C.isAllOnesValue()) {
Sanjay Patel5f0217f2016-06-05 16:46:18 +0000117 if (Pred == ICmpInst::ICMP_SGT) {
118 Pred = ICmpInst::ICMP_SGE;
Arnaud A. de Grandmaison9c383d62013-03-25 09:48:49 +0000119 return true;
Arnaud A. de Grandmaison9c383d62013-03-25 09:48:49 +0000120 }
Arnaud A. de Grandmaison3ee88e82013-03-25 11:47:38 +0000121 }
Arnaud A. de Grandmaison9c383d62013-03-25 09:48:49 +0000122
123 return false;
124}
125
Sanjay Patel5f0217f2016-06-05 16:46:18 +0000126/// Given a signed integer type and a set of known zero and one bits, compute
127/// the maximum and minimum values that could have the specified known zero and
128/// known one bits, returning them in Min/Max.
Craig Topperb45eabc2017-04-26 16:39:58 +0000129/// TODO: Move to method on KnownBits struct?
130static void computeSignedMinMaxValuesFromKnownBits(const KnownBits &Known,
Sanjay Patel5f0217f2016-06-05 16:46:18 +0000131 APInt &Min, APInt &Max) {
Craig Topperb45eabc2017-04-26 16:39:58 +0000132 assert(Known.getBitWidth() == Min.getBitWidth() &&
133 Known.getBitWidth() == Max.getBitWidth() &&
Chris Lattner2188e402010-01-04 07:37:31 +0000134 "KnownZero, KnownOne and Min, Max must have equal bitwidth.");
Craig Topperb45eabc2017-04-26 16:39:58 +0000135 APInt UnknownBits = ~(Known.Zero|Known.One);
Chris Lattner2188e402010-01-04 07:37:31 +0000136
137 // The minimum value is when all unknown bits are zeros, EXCEPT for the sign
138 // bit if it is unknown.
Craig Topperb45eabc2017-04-26 16:39:58 +0000139 Min = Known.One;
140 Max = Known.One|UnknownBits;
Jim Grosbach129c52a2011-09-30 18:09:53 +0000141
Chris Lattner2188e402010-01-04 07:37:31 +0000142 if (UnknownBits.isNegative()) { // Sign bit is unknown
Craig Topper24db6b82017-04-28 16:58:05 +0000143 Min.setSignBit();
144 Max.clearSignBit();
Chris Lattner2188e402010-01-04 07:37:31 +0000145 }
146}
147
Sanjay Patel5f0217f2016-06-05 16:46:18 +0000148/// Given an unsigned integer type and a set of known zero and one bits, compute
149/// the maximum and minimum values that could have the specified known zero and
150/// known one bits, returning them in Min/Max.
Craig Topperb45eabc2017-04-26 16:39:58 +0000151/// TODO: Move to method on KnownBits struct?
152static void computeUnsignedMinMaxValuesFromKnownBits(const KnownBits &Known,
Chris Lattner2188e402010-01-04 07:37:31 +0000153 APInt &Min, APInt &Max) {
Craig Topperb45eabc2017-04-26 16:39:58 +0000154 assert(Known.getBitWidth() == Min.getBitWidth() &&
155 Known.getBitWidth() == Max.getBitWidth() &&
Chris Lattner2188e402010-01-04 07:37:31 +0000156 "Ty, KnownZero, KnownOne and Min, Max must have equal bitwidth.");
Craig Topperb45eabc2017-04-26 16:39:58 +0000157 APInt UnknownBits = ~(Known.Zero|Known.One);
Jim Grosbach129c52a2011-09-30 18:09:53 +0000158
Chris Lattner2188e402010-01-04 07:37:31 +0000159 // The minimum value is when the unknown bits are all zeros.
Craig Topperb45eabc2017-04-26 16:39:58 +0000160 Min = Known.One;
Chris Lattner2188e402010-01-04 07:37:31 +0000161 // The maximum value is when the unknown bits are all ones.
Craig Topperb45eabc2017-04-26 16:39:58 +0000162 Max = Known.One|UnknownBits;
Chris Lattner2188e402010-01-04 07:37:31 +0000163}
164
Sanjay Patel5f0217f2016-06-05 16:46:18 +0000165/// This is called when we see this pattern:
Chris Lattner2188e402010-01-04 07:37:31 +0000166/// cmp pred (load (gep GV, ...)), cmpcst
Sanjay Patel5f0217f2016-06-05 16:46:18 +0000167/// where GV is a global variable with a constant initializer. Try to simplify
168/// this into some simple computation that does not need the load. For example
Chris Lattner2188e402010-01-04 07:37:31 +0000169/// we can optimize "icmp eq (load (gep "foo", 0, i)), 0" into "icmp eq i, 3".
170///
171/// If AndCst is non-null, then the loaded value is masked with that constant
Sanjay Patel5f0217f2016-06-05 16:46:18 +0000172/// before doing the comparison. This handles cases like "A[i]&4 == 0".
Sanjay Patel43395062016-07-21 18:07:40 +0000173Instruction *InstCombiner::foldCmpLoadFromIndexedGlobal(GetElementPtrInst *GEP,
174 GlobalVariable *GV,
175 CmpInst &ICI,
176 ConstantInt *AndCst) {
Chris Lattnerfe741762012-01-31 02:55:06 +0000177 Constant *Init = GV->getInitializer();
178 if (!isa<ConstantArray>(Init) && !isa<ConstantDataArray>(Init))
Craig Topperf40110f2014-04-25 05:29:35 +0000179 return nullptr;
Jim Grosbachbdbd7342013-04-05 21:20:12 +0000180
Chris Lattnerfe741762012-01-31 02:55:06 +0000181 uint64_t ArrayElementCount = Init->getType()->getArrayNumElements();
Davide Italiano2133bf52017-02-07 17:56:50 +0000182 // Don't blow up on huge arrays.
183 if (ArrayElementCount > MaxArraySizeForCombine)
184 return nullptr;
Jim Grosbach129c52a2011-09-30 18:09:53 +0000185
Chris Lattner2188e402010-01-04 07:37:31 +0000186 // There are many forms of this optimization we can handle, for now, just do
187 // the simple index into a single-dimensional array.
188 //
189 // Require: GEP GV, 0, i {{, constant indices}}
190 if (GEP->getNumOperands() < 3 ||
191 !isa<ConstantInt>(GEP->getOperand(1)) ||
192 !cast<ConstantInt>(GEP->getOperand(1))->isZero() ||
193 isa<Constant>(GEP->getOperand(2)))
Craig Topperf40110f2014-04-25 05:29:35 +0000194 return nullptr;
Chris Lattner2188e402010-01-04 07:37:31 +0000195
196 // Check that indices after the variable are constants and in-range for the
197 // type they index. Collect the indices. This is typically for arrays of
198 // structs.
199 SmallVector<unsigned, 4> LaterIndices;
Jim Grosbach129c52a2011-09-30 18:09:53 +0000200
Chris Lattnerfe741762012-01-31 02:55:06 +0000201 Type *EltTy = Init->getType()->getArrayElementType();
Chris Lattner2188e402010-01-04 07:37:31 +0000202 for (unsigned i = 3, e = GEP->getNumOperands(); i != e; ++i) {
203 ConstantInt *Idx = dyn_cast<ConstantInt>(GEP->getOperand(i));
Craig Topperf40110f2014-04-25 05:29:35 +0000204 if (!Idx) return nullptr; // Variable index.
Jim Grosbach129c52a2011-09-30 18:09:53 +0000205
Chris Lattner2188e402010-01-04 07:37:31 +0000206 uint64_t IdxVal = Idx->getZExtValue();
Craig Topperf40110f2014-04-25 05:29:35 +0000207 if ((unsigned)IdxVal != IdxVal) return nullptr; // Too large array index.
Jim Grosbach129c52a2011-09-30 18:09:53 +0000208
Chris Lattner229907c2011-07-18 04:54:35 +0000209 if (StructType *STy = dyn_cast<StructType>(EltTy))
Chris Lattner2188e402010-01-04 07:37:31 +0000210 EltTy = STy->getElementType(IdxVal);
Chris Lattner229907c2011-07-18 04:54:35 +0000211 else if (ArrayType *ATy = dyn_cast<ArrayType>(EltTy)) {
Craig Topperf40110f2014-04-25 05:29:35 +0000212 if (IdxVal >= ATy->getNumElements()) return nullptr;
Chris Lattner2188e402010-01-04 07:37:31 +0000213 EltTy = ATy->getElementType();
214 } else {
Craig Topperf40110f2014-04-25 05:29:35 +0000215 return nullptr; // Unknown type.
Chris Lattner2188e402010-01-04 07:37:31 +0000216 }
Jim Grosbach129c52a2011-09-30 18:09:53 +0000217
Chris Lattner2188e402010-01-04 07:37:31 +0000218 LaterIndices.push_back(IdxVal);
219 }
Jim Grosbach129c52a2011-09-30 18:09:53 +0000220
Chris Lattner2188e402010-01-04 07:37:31 +0000221 enum { Overdefined = -3, Undefined = -2 };
222
223 // Variables for our state machines.
Jim Grosbach129c52a2011-09-30 18:09:53 +0000224
Chris Lattner2188e402010-01-04 07:37:31 +0000225 // FirstTrueElement/SecondTrueElement - Used to emit a comparison of the form
226 // "i == 47 | i == 87", where 47 is the first index the condition is true for,
227 // and 87 is the second (and last) index. FirstTrueElement is -2 when
228 // undefined, otherwise set to the first true element. SecondTrueElement is
229 // -2 when undefined, -3 when overdefined and >= 0 when that index is true.
230 int FirstTrueElement = Undefined, SecondTrueElement = Undefined;
231
232 // FirstFalseElement/SecondFalseElement - Used to emit a comparison of the
233 // form "i != 47 & i != 87". Same state transitions as for true elements.
234 int FirstFalseElement = Undefined, SecondFalseElement = Undefined;
Jim Grosbach129c52a2011-09-30 18:09:53 +0000235
Chris Lattner2188e402010-01-04 07:37:31 +0000236 /// TrueRangeEnd/FalseRangeEnd - In conjunction with First*Element, these
237 /// define a state machine that triggers for ranges of values that the index
238 /// is true or false for. This triggers on things like "abbbbc"[i] == 'b'.
239 /// This is -2 when undefined, -3 when overdefined, and otherwise the last
240 /// index in the range (inclusive). We use -2 for undefined here because we
241 /// use relative comparisons and don't want 0-1 to match -1.
242 int TrueRangeEnd = Undefined, FalseRangeEnd = Undefined;
Jim Grosbach129c52a2011-09-30 18:09:53 +0000243
Chris Lattner2188e402010-01-04 07:37:31 +0000244 // MagicBitvector - This is a magic bitvector where we set a bit if the
245 // comparison is true for element 'i'. If there are 64 elements or less in
246 // the array, this will fully represent all the comparison results.
247 uint64_t MagicBitvector = 0;
Jim Grosbach129c52a2011-09-30 18:09:53 +0000248
Chris Lattner2188e402010-01-04 07:37:31 +0000249 // Scan the array and see if one of our patterns matches.
250 Constant *CompareRHS = cast<Constant>(ICI.getOperand(1));
Chris Lattnerfe741762012-01-31 02:55:06 +0000251 for (unsigned i = 0, e = ArrayElementCount; i != e; ++i) {
252 Constant *Elt = Init->getAggregateElement(i);
Craig Topperf40110f2014-04-25 05:29:35 +0000253 if (!Elt) return nullptr;
Jim Grosbach129c52a2011-09-30 18:09:53 +0000254
Chris Lattner2188e402010-01-04 07:37:31 +0000255 // If this is indexing an array of structures, get the structure element.
256 if (!LaterIndices.empty())
Jay Foad57aa6362011-07-13 10:26:04 +0000257 Elt = ConstantExpr::getExtractValue(Elt, LaterIndices);
Jim Grosbach129c52a2011-09-30 18:09:53 +0000258
Chris Lattner2188e402010-01-04 07:37:31 +0000259 // If the element is masked, handle it.
260 if (AndCst) Elt = ConstantExpr::getAnd(Elt, AndCst);
Jim Grosbach129c52a2011-09-30 18:09:53 +0000261
Chris Lattner2188e402010-01-04 07:37:31 +0000262 // Find out if the comparison would be true or false for the i'th element.
263 Constant *C = ConstantFoldCompareInstOperands(ICI.getPredicate(), Elt,
Justin Bogner99798402016-08-05 01:06:44 +0000264 CompareRHS, DL, &TLI);
Chris Lattner2188e402010-01-04 07:37:31 +0000265 // If the result is undef for this element, ignore it.
266 if (isa<UndefValue>(C)) {
267 // Extend range state machines to cover this element in case there is an
268 // undef in the middle of the range.
269 if (TrueRangeEnd == (int)i-1)
270 TrueRangeEnd = i;
271 if (FalseRangeEnd == (int)i-1)
272 FalseRangeEnd = i;
273 continue;
274 }
Jim Grosbach129c52a2011-09-30 18:09:53 +0000275
Chris Lattner2188e402010-01-04 07:37:31 +0000276 // If we can't compute the result for any of the elements, we have to give
277 // up evaluating the entire conditional.
Craig Topperf40110f2014-04-25 05:29:35 +0000278 if (!isa<ConstantInt>(C)) return nullptr;
Jim Grosbach129c52a2011-09-30 18:09:53 +0000279
Chris Lattner2188e402010-01-04 07:37:31 +0000280 // Otherwise, we know if the comparison is true or false for this element,
281 // update our state machines.
282 bool IsTrueForElt = !cast<ConstantInt>(C)->isZero();
Jim Grosbach129c52a2011-09-30 18:09:53 +0000283
Chris Lattner2188e402010-01-04 07:37:31 +0000284 // State machine for single/double/range index comparison.
285 if (IsTrueForElt) {
286 // Update the TrueElement state machine.
287 if (FirstTrueElement == Undefined)
288 FirstTrueElement = TrueRangeEnd = i; // First true element.
289 else {
290 // Update double-compare state machine.
291 if (SecondTrueElement == Undefined)
292 SecondTrueElement = i;
293 else
294 SecondTrueElement = Overdefined;
Jim Grosbach129c52a2011-09-30 18:09:53 +0000295
Chris Lattner2188e402010-01-04 07:37:31 +0000296 // Update range state machine.
297 if (TrueRangeEnd == (int)i-1)
298 TrueRangeEnd = i;
299 else
300 TrueRangeEnd = Overdefined;
301 }
302 } else {
303 // Update the FalseElement state machine.
304 if (FirstFalseElement == Undefined)
305 FirstFalseElement = FalseRangeEnd = i; // First false element.
306 else {
307 // Update double-compare state machine.
308 if (SecondFalseElement == Undefined)
309 SecondFalseElement = i;
310 else
311 SecondFalseElement = Overdefined;
Jim Grosbach129c52a2011-09-30 18:09:53 +0000312
Chris Lattner2188e402010-01-04 07:37:31 +0000313 // Update range state machine.
314 if (FalseRangeEnd == (int)i-1)
315 FalseRangeEnd = i;
316 else
317 FalseRangeEnd = Overdefined;
318 }
319 }
Jim Grosbach129c52a2011-09-30 18:09:53 +0000320
Chris Lattner2188e402010-01-04 07:37:31 +0000321 // If this element is in range, update our magic bitvector.
322 if (i < 64 && IsTrueForElt)
323 MagicBitvector |= 1ULL << i;
Jim Grosbach129c52a2011-09-30 18:09:53 +0000324
Chris Lattner2188e402010-01-04 07:37:31 +0000325 // If all of our states become overdefined, bail out early. Since the
326 // predicate is expensive, only check it every 8 elements. This is only
327 // really useful for really huge arrays.
328 if ((i & 8) == 0 && i >= 64 && SecondTrueElement == Overdefined &&
329 SecondFalseElement == Overdefined && TrueRangeEnd == Overdefined &&
330 FalseRangeEnd == Overdefined)
Craig Topperf40110f2014-04-25 05:29:35 +0000331 return nullptr;
Chris Lattner2188e402010-01-04 07:37:31 +0000332 }
333
334 // Now that we've scanned the entire array, emit our new comparison(s). We
335 // order the state machines in complexity of the generated code.
336 Value *Idx = GEP->getOperand(2);
337
Matt Arsenault5aeae182013-08-19 21:40:31 +0000338 // If the index is larger than the pointer size of the target, truncate the
339 // index down like the GEP would do implicitly. We don't have to do this for
340 // an inbounds GEP because the index can't be out of range.
Matt Arsenault84680622013-09-30 21:11:01 +0000341 if (!GEP->isInBounds()) {
Mehdi Aminia28d91d2015-03-10 02:37:25 +0000342 Type *IntPtrTy = DL.getIntPtrType(GEP->getType());
Matt Arsenault84680622013-09-30 21:11:01 +0000343 unsigned PtrSize = IntPtrTy->getIntegerBitWidth();
344 if (Idx->getType()->getPrimitiveSizeInBits() > PtrSize)
Craig Topperbb4069e2017-07-07 23:16:26 +0000345 Idx = Builder.CreateTrunc(Idx, IntPtrTy);
Matt Arsenault84680622013-09-30 21:11:01 +0000346 }
Matt Arsenault5aeae182013-08-19 21:40:31 +0000347
Chris Lattner2188e402010-01-04 07:37:31 +0000348 // If the comparison is only true for one or two elements, emit direct
349 // comparisons.
350 if (SecondTrueElement != Overdefined) {
351 // None true -> false.
352 if (FirstTrueElement == Undefined)
Craig Topperbb4069e2017-07-07 23:16:26 +0000353 return replaceInstUsesWith(ICI, Builder.getFalse());
Jim Grosbach129c52a2011-09-30 18:09:53 +0000354
Chris Lattner2188e402010-01-04 07:37:31 +0000355 Value *FirstTrueIdx = ConstantInt::get(Idx->getType(), FirstTrueElement);
Jim Grosbach129c52a2011-09-30 18:09:53 +0000356
Chris Lattner2188e402010-01-04 07:37:31 +0000357 // True for one element -> 'i == 47'.
358 if (SecondTrueElement == Undefined)
359 return new ICmpInst(ICmpInst::ICMP_EQ, Idx, FirstTrueIdx);
Jim Grosbach129c52a2011-09-30 18:09:53 +0000360
Chris Lattner2188e402010-01-04 07:37:31 +0000361 // True for two elements -> 'i == 47 | i == 72'.
Craig Topperbb4069e2017-07-07 23:16:26 +0000362 Value *C1 = Builder.CreateICmpEQ(Idx, FirstTrueIdx);
Chris Lattner2188e402010-01-04 07:37:31 +0000363 Value *SecondTrueIdx = ConstantInt::get(Idx->getType(), SecondTrueElement);
Craig Topperbb4069e2017-07-07 23:16:26 +0000364 Value *C2 = Builder.CreateICmpEQ(Idx, SecondTrueIdx);
Chris Lattner2188e402010-01-04 07:37:31 +0000365 return BinaryOperator::CreateOr(C1, C2);
366 }
367
368 // If the comparison is only false for one or two elements, emit direct
369 // comparisons.
370 if (SecondFalseElement != Overdefined) {
371 // None false -> true.
372 if (FirstFalseElement == Undefined)
Craig Topperbb4069e2017-07-07 23:16:26 +0000373 return replaceInstUsesWith(ICI, Builder.getTrue());
Jim Grosbach129c52a2011-09-30 18:09:53 +0000374
Chris Lattner2188e402010-01-04 07:37:31 +0000375 Value *FirstFalseIdx = ConstantInt::get(Idx->getType(), FirstFalseElement);
376
377 // False for one element -> 'i != 47'.
378 if (SecondFalseElement == Undefined)
379 return new ICmpInst(ICmpInst::ICMP_NE, Idx, FirstFalseIdx);
Jim Grosbach129c52a2011-09-30 18:09:53 +0000380
Chris Lattner2188e402010-01-04 07:37:31 +0000381 // False for two elements -> 'i != 47 & i != 72'.
Craig Topperbb4069e2017-07-07 23:16:26 +0000382 Value *C1 = Builder.CreateICmpNE(Idx, FirstFalseIdx);
Chris Lattner2188e402010-01-04 07:37:31 +0000383 Value *SecondFalseIdx = ConstantInt::get(Idx->getType(),SecondFalseElement);
Craig Topperbb4069e2017-07-07 23:16:26 +0000384 Value *C2 = Builder.CreateICmpNE(Idx, SecondFalseIdx);
Chris Lattner2188e402010-01-04 07:37:31 +0000385 return BinaryOperator::CreateAnd(C1, C2);
386 }
Jim Grosbach129c52a2011-09-30 18:09:53 +0000387
Chris Lattner2188e402010-01-04 07:37:31 +0000388 // If the comparison can be replaced with a range comparison for the elements
389 // where it is true, emit the range check.
390 if (TrueRangeEnd != Overdefined) {
391 assert(TrueRangeEnd != FirstTrueElement && "Should emit single compare");
Jim Grosbach129c52a2011-09-30 18:09:53 +0000392
Chris Lattner2188e402010-01-04 07:37:31 +0000393 // Generate (i-FirstTrue) <u (TrueRangeEnd-FirstTrue+1).
394 if (FirstTrueElement) {
395 Value *Offs = ConstantInt::get(Idx->getType(), -FirstTrueElement);
Craig Topperbb4069e2017-07-07 23:16:26 +0000396 Idx = Builder.CreateAdd(Idx, Offs);
Chris Lattner2188e402010-01-04 07:37:31 +0000397 }
Jim Grosbach129c52a2011-09-30 18:09:53 +0000398
Chris Lattner2188e402010-01-04 07:37:31 +0000399 Value *End = ConstantInt::get(Idx->getType(),
400 TrueRangeEnd-FirstTrueElement+1);
401 return new ICmpInst(ICmpInst::ICMP_ULT, Idx, End);
402 }
Jim Grosbach129c52a2011-09-30 18:09:53 +0000403
Chris Lattner2188e402010-01-04 07:37:31 +0000404 // False range check.
405 if (FalseRangeEnd != Overdefined) {
406 assert(FalseRangeEnd != FirstFalseElement && "Should emit single compare");
407 // Generate (i-FirstFalse) >u (FalseRangeEnd-FirstFalse).
408 if (FirstFalseElement) {
409 Value *Offs = ConstantInt::get(Idx->getType(), -FirstFalseElement);
Craig Topperbb4069e2017-07-07 23:16:26 +0000410 Idx = Builder.CreateAdd(Idx, Offs);
Chris Lattner2188e402010-01-04 07:37:31 +0000411 }
Jim Grosbach129c52a2011-09-30 18:09:53 +0000412
Chris Lattner2188e402010-01-04 07:37:31 +0000413 Value *End = ConstantInt::get(Idx->getType(),
414 FalseRangeEnd-FirstFalseElement);
415 return new ICmpInst(ICmpInst::ICMP_UGT, Idx, End);
416 }
Jim Grosbach129c52a2011-09-30 18:09:53 +0000417
Arnaud A. de Grandmaisonf364bc62013-03-22 08:25:01 +0000418 // If a magic bitvector captures the entire comparison state
Chris Lattner2188e402010-01-04 07:37:31 +0000419 // of this load, replace it with computation that does:
420 // ((magic_cst >> i) & 1) != 0
Arnaud A. de Grandmaisonf364bc62013-03-22 08:25:01 +0000421 {
Craig Topperf40110f2014-04-25 05:29:35 +0000422 Type *Ty = nullptr;
Arnaud A. de Grandmaisonf364bc62013-03-22 08:25:01 +0000423
424 // Look for an appropriate type:
425 // - The type of Idx if the magic fits
Craig Topper386fc252017-11-07 17:37:32 +0000426 // - The smallest fitting legal type
Arnaud A. de Grandmaisonf364bc62013-03-22 08:25:01 +0000427 if (ArrayElementCount <= Idx->getType()->getIntegerBitWidth())
428 Ty = Idx->getType();
Mehdi Aminia28d91d2015-03-10 02:37:25 +0000429 else
430 Ty = DL.getSmallestLegalIntType(Init->getContext(), ArrayElementCount);
Arnaud A. de Grandmaisonf364bc62013-03-22 08:25:01 +0000431
Craig Topperf40110f2014-04-25 05:29:35 +0000432 if (Ty) {
Craig Topperbb4069e2017-07-07 23:16:26 +0000433 Value *V = Builder.CreateIntCast(Idx, Ty, false);
434 V = Builder.CreateLShr(ConstantInt::get(Ty, MagicBitvector), V);
435 V = Builder.CreateAnd(ConstantInt::get(Ty, 1), V);
Arnaud A. de Grandmaisonf364bc62013-03-22 08:25:01 +0000436 return new ICmpInst(ICmpInst::ICMP_NE, V, ConstantInt::get(Ty, 0));
437 }
Chris Lattner2188e402010-01-04 07:37:31 +0000438 }
Jim Grosbach129c52a2011-09-30 18:09:53 +0000439
Craig Topperf40110f2014-04-25 05:29:35 +0000440 return nullptr;
Chris Lattner2188e402010-01-04 07:37:31 +0000441}
442
Sanjay Patel5f0217f2016-06-05 16:46:18 +0000443/// Return a value that can be used to compare the *offset* implied by a GEP to
444/// zero. For example, if we have &A[i], we want to return 'i' for
445/// "icmp ne i, 0". Note that, in general, indices can be complex, and scales
446/// are involved. The above expression would also be legal to codegen as
447/// "icmp ne (i*4), 0" (assuming A is a pointer to i32).
448/// This latter form is less amenable to optimization though, and we are allowed
Chris Lattner2188e402010-01-04 07:37:31 +0000449/// to generate the first by knowing that pointer arithmetic doesn't overflow.
450///
451/// If we can't emit an optimized form for this expression, this returns null.
Jim Grosbach129c52a2011-09-30 18:09:53 +0000452///
Sanjay Pateld93c4c02016-09-15 18:22:25 +0000453static Value *evaluateGEPOffsetExpression(User *GEP, InstCombiner &IC,
Mehdi Aminia28d91d2015-03-10 02:37:25 +0000454 const DataLayout &DL) {
Chris Lattner2188e402010-01-04 07:37:31 +0000455 gep_type_iterator GTI = gep_type_begin(GEP);
Jim Grosbach129c52a2011-09-30 18:09:53 +0000456
Chris Lattner2188e402010-01-04 07:37:31 +0000457 // Check to see if this gep only has a single variable index. If so, and if
458 // any constant indices are a multiple of its scale, then we can compute this
459 // in terms of the scale of the variable index. For example, if the GEP
460 // implies an offset of "12 + i*4", then we can codegen this as "3 + i",
461 // because the expression will cross zero at the same point.
462 unsigned i, e = GEP->getNumOperands();
463 int64_t Offset = 0;
464 for (i = 1; i != e; ++i, ++GTI) {
465 if (ConstantInt *CI = dyn_cast<ConstantInt>(GEP->getOperand(i))) {
466 // Compute the aggregate offset of constant indices.
467 if (CI->isZero()) continue;
Jim Grosbach129c52a2011-09-30 18:09:53 +0000468
Chris Lattner2188e402010-01-04 07:37:31 +0000469 // Handle a struct index, which adds its field offset to the pointer.
Peter Collingbourneab85225b2016-12-02 02:24:42 +0000470 if (StructType *STy = GTI.getStructTypeOrNull()) {
Rafael Espindola37dc9e12014-02-21 00:06:31 +0000471 Offset += DL.getStructLayout(STy)->getElementOffset(CI->getZExtValue());
Chris Lattner2188e402010-01-04 07:37:31 +0000472 } else {
Rafael Espindola37dc9e12014-02-21 00:06:31 +0000473 uint64_t Size = DL.getTypeAllocSize(GTI.getIndexedType());
Chris Lattner2188e402010-01-04 07:37:31 +0000474 Offset += Size*CI->getSExtValue();
475 }
476 } else {
477 // Found our variable index.
478 break;
479 }
480 }
Jim Grosbach129c52a2011-09-30 18:09:53 +0000481
Chris Lattner2188e402010-01-04 07:37:31 +0000482 // If there are no variable indices, we must have a constant offset, just
483 // evaluate it the general way.
Craig Topperf40110f2014-04-25 05:29:35 +0000484 if (i == e) return nullptr;
Jim Grosbach129c52a2011-09-30 18:09:53 +0000485
Chris Lattner2188e402010-01-04 07:37:31 +0000486 Value *VariableIdx = GEP->getOperand(i);
487 // Determine the scale factor of the variable element. For example, this is
488 // 4 if the variable index is into an array of i32.
Rafael Espindola37dc9e12014-02-21 00:06:31 +0000489 uint64_t VariableScale = DL.getTypeAllocSize(GTI.getIndexedType());
Jim Grosbach129c52a2011-09-30 18:09:53 +0000490
Chris Lattner2188e402010-01-04 07:37:31 +0000491 // Verify that there are no other variable indices. If so, emit the hard way.
492 for (++i, ++GTI; i != e; ++i, ++GTI) {
493 ConstantInt *CI = dyn_cast<ConstantInt>(GEP->getOperand(i));
Craig Topperf40110f2014-04-25 05:29:35 +0000494 if (!CI) return nullptr;
Jim Grosbach129c52a2011-09-30 18:09:53 +0000495
Chris Lattner2188e402010-01-04 07:37:31 +0000496 // Compute the aggregate offset of constant indices.
497 if (CI->isZero()) continue;
Jim Grosbach129c52a2011-09-30 18:09:53 +0000498
Chris Lattner2188e402010-01-04 07:37:31 +0000499 // Handle a struct index, which adds its field offset to the pointer.
Peter Collingbourneab85225b2016-12-02 02:24:42 +0000500 if (StructType *STy = GTI.getStructTypeOrNull()) {
Rafael Espindola37dc9e12014-02-21 00:06:31 +0000501 Offset += DL.getStructLayout(STy)->getElementOffset(CI->getZExtValue());
Chris Lattner2188e402010-01-04 07:37:31 +0000502 } else {
Rafael Espindola37dc9e12014-02-21 00:06:31 +0000503 uint64_t Size = DL.getTypeAllocSize(GTI.getIndexedType());
Chris Lattner2188e402010-01-04 07:37:31 +0000504 Offset += Size*CI->getSExtValue();
505 }
506 }
Jim Grosbach129c52a2011-09-30 18:09:53 +0000507
Chris Lattner2188e402010-01-04 07:37:31 +0000508 // Okay, we know we have a single variable index, which must be a
509 // pointer/array/vector index. If there is no offset, life is simple, return
510 // the index.
Rafael Espindola37dc9e12014-02-21 00:06:31 +0000511 Type *IntPtrTy = DL.getIntPtrType(GEP->getOperand(0)->getType());
Matt Arsenault745101d2013-08-21 19:53:10 +0000512 unsigned IntPtrWidth = IntPtrTy->getIntegerBitWidth();
Chris Lattner2188e402010-01-04 07:37:31 +0000513 if (Offset == 0) {
514 // Cast to intptrty in case a truncation occurs. If an extension is needed,
515 // we don't need to bother extending: the extension won't affect where the
516 // computation crosses zero.
Eli Friedman1754a252011-05-18 23:11:30 +0000517 if (VariableIdx->getType()->getPrimitiveSizeInBits() > IntPtrWidth) {
Craig Topperbb4069e2017-07-07 23:16:26 +0000518 VariableIdx = IC.Builder.CreateTrunc(VariableIdx, IntPtrTy);
Eli Friedman1754a252011-05-18 23:11:30 +0000519 }
Chris Lattner2188e402010-01-04 07:37:31 +0000520 return VariableIdx;
521 }
Jim Grosbach129c52a2011-09-30 18:09:53 +0000522
Chris Lattner2188e402010-01-04 07:37:31 +0000523 // Otherwise, there is an index. The computation we will do will be modulo
Nikita Popov36e03ac2018-12-12 23:19:03 +0000524 // the pointer size.
525 Offset = SignExtend64(Offset, IntPtrWidth);
526 VariableScale = SignExtend64(VariableScale, IntPtrWidth);
Jim Grosbach129c52a2011-09-30 18:09:53 +0000527
Chris Lattner2188e402010-01-04 07:37:31 +0000528 // To do this transformation, any constant index must be a multiple of the
529 // variable scale factor. For example, we can evaluate "12 + 4*i" as "3 + i",
530 // but we can't evaluate "10 + 3*i" in terms of i. Check that the offset is a
531 // multiple of the variable scale.
532 int64_t NewOffs = Offset / (int64_t)VariableScale;
533 if (Offset != NewOffs*(int64_t)VariableScale)
Craig Topperf40110f2014-04-25 05:29:35 +0000534 return nullptr;
Jim Grosbach129c52a2011-09-30 18:09:53 +0000535
Chris Lattner2188e402010-01-04 07:37:31 +0000536 // Okay, we can do this evaluation. Start by converting the index to intptr.
Chris Lattner2188e402010-01-04 07:37:31 +0000537 if (VariableIdx->getType() != IntPtrTy)
Craig Topperbb4069e2017-07-07 23:16:26 +0000538 VariableIdx = IC.Builder.CreateIntCast(VariableIdx, IntPtrTy,
Eli Friedman1754a252011-05-18 23:11:30 +0000539 true /*Signed*/);
Chris Lattner2188e402010-01-04 07:37:31 +0000540 Constant *OffsetVal = ConstantInt::get(IntPtrTy, NewOffs);
Craig Topperbb4069e2017-07-07 23:16:26 +0000541 return IC.Builder.CreateAdd(VariableIdx, OffsetVal, "offset");
Chris Lattner2188e402010-01-04 07:37:31 +0000542}
543
Silviu Barangaf29dfd32016-01-15 15:52:05 +0000544/// Returns true if we can rewrite Start as a GEP with pointer Base
545/// and some integer offset. The nodes that need to be re-written
546/// for this transformation will be added to Explored.
547static bool canRewriteGEPAsOffset(Value *Start, Value *Base,
548 const DataLayout &DL,
549 SetVector<Value *> &Explored) {
550 SmallVector<Value *, 16> WorkList(1, Start);
551 Explored.insert(Base);
552
553 // The following traversal gives us an order which can be used
554 // when doing the final transformation. Since in the final
555 // transformation we create the PHI replacement instructions first,
556 // we don't have to get them in any particular order.
557 //
558 // However, for other instructions we will have to traverse the
559 // operands of an instruction first, which means that we have to
560 // do a post-order traversal.
561 while (!WorkList.empty()) {
562 SetVector<PHINode *> PHIs;
563
564 while (!WorkList.empty()) {
565 if (Explored.size() >= 100)
566 return false;
567
568 Value *V = WorkList.back();
569
570 if (Explored.count(V) != 0) {
571 WorkList.pop_back();
572 continue;
573 }
574
575 if (!isa<IntToPtrInst>(V) && !isa<PtrToIntInst>(V) &&
David Majnemer8b16da82016-09-15 20:10:09 +0000576 !isa<GetElementPtrInst>(V) && !isa<PHINode>(V))
Silviu Barangaf29dfd32016-01-15 15:52:05 +0000577 // We've found some value that we can't explore which is different from
578 // the base. Therefore we can't do this transformation.
579 return false;
580
581 if (isa<IntToPtrInst>(V) || isa<PtrToIntInst>(V)) {
582 auto *CI = dyn_cast<CastInst>(V);
583 if (!CI->isNoopCast(DL))
584 return false;
585
586 if (Explored.count(CI->getOperand(0)) == 0)
587 WorkList.push_back(CI->getOperand(0));
588 }
589
590 if (auto *GEP = dyn_cast<GEPOperator>(V)) {
591 // We're limiting the GEP to having one index. This will preserve
592 // the original pointer type. We could handle more cases in the
593 // future.
594 if (GEP->getNumIndices() != 1 || !GEP->isInBounds() ||
595 GEP->getType() != Start->getType())
596 return false;
597
598 if (Explored.count(GEP->getOperand(0)) == 0)
599 WorkList.push_back(GEP->getOperand(0));
600 }
601
602 if (WorkList.back() == V) {
603 WorkList.pop_back();
604 // We've finished visiting this node, mark it as such.
605 Explored.insert(V);
606 }
607
608 if (auto *PN = dyn_cast<PHINode>(V)) {
David Majnemercdf28732016-03-19 04:39:52 +0000609 // We cannot transform PHIs on unsplittable basic blocks.
610 if (isa<CatchSwitchInst>(PN->getParent()->getTerminator()))
611 return false;
Silviu Barangaf29dfd32016-01-15 15:52:05 +0000612 Explored.insert(PN);
613 PHIs.insert(PN);
614 }
615 }
616
617 // Explore the PHI nodes further.
618 for (auto *PN : PHIs)
619 for (Value *Op : PN->incoming_values())
620 if (Explored.count(Op) == 0)
621 WorkList.push_back(Op);
622 }
623
624 // Make sure that we can do this. Since we can't insert GEPs in a basic
625 // block before a PHI node, we can't easily do this transformation if
626 // we have PHI node users of transformed instructions.
627 for (Value *Val : Explored) {
628 for (Value *Use : Val->uses()) {
629
630 auto *PHI = dyn_cast<PHINode>(Use);
631 auto *Inst = dyn_cast<Instruction>(Val);
632
633 if (Inst == Base || Inst == PHI || !Inst || !PHI ||
634 Explored.count(PHI) == 0)
635 continue;
636
637 if (PHI->getParent() == Inst->getParent())
638 return false;
639 }
640 }
641 return true;
642}
643
644// Sets the appropriate insert point on Builder where we can add
645// a replacement Instruction for V (if that is possible).
646static void setInsertionPoint(IRBuilder<> &Builder, Value *V,
647 bool Before = true) {
648 if (auto *PHI = dyn_cast<PHINode>(V)) {
649 Builder.SetInsertPoint(&*PHI->getParent()->getFirstInsertionPt());
650 return;
651 }
652 if (auto *I = dyn_cast<Instruction>(V)) {
653 if (!Before)
654 I = &*std::next(I->getIterator());
655 Builder.SetInsertPoint(I);
656 return;
657 }
658 if (auto *A = dyn_cast<Argument>(V)) {
659 // Set the insertion point in the entry block.
660 BasicBlock &Entry = A->getParent()->getEntryBlock();
661 Builder.SetInsertPoint(&*Entry.getFirstInsertionPt());
662 return;
663 }
664 // Otherwise, this is a constant and we don't need to set a new
665 // insertion point.
666 assert(isa<Constant>(V) && "Setting insertion point for unknown value!");
667}
668
669/// Returns a re-written value of Start as an indexed GEP using Base as a
670/// pointer.
671static Value *rewriteGEPAsOffset(Value *Start, Value *Base,
672 const DataLayout &DL,
673 SetVector<Value *> &Explored) {
674 // Perform all the substitutions. This is a bit tricky because we can
675 // have cycles in our use-def chains.
676 // 1. Create the PHI nodes without any incoming values.
677 // 2. Create all the other values.
678 // 3. Add the edges for the PHI nodes.
679 // 4. Emit GEPs to get the original pointers.
680 // 5. Remove the original instructions.
681 Type *IndexType = IntegerType::get(
Elena Demikhovsky945b7e52018-02-14 06:58:08 +0000682 Base->getContext(), DL.getIndexTypeSizeInBits(Start->getType()));
Silviu Barangaf29dfd32016-01-15 15:52:05 +0000683
684 DenseMap<Value *, Value *> NewInsts;
685 NewInsts[Base] = ConstantInt::getNullValue(IndexType);
686
687 // Create the new PHI nodes, without adding any incoming values.
688 for (Value *Val : Explored) {
689 if (Val == Base)
690 continue;
691 // Create empty phi nodes. This avoids cyclic dependencies when creating
692 // the remaining instructions.
693 if (auto *PHI = dyn_cast<PHINode>(Val))
694 NewInsts[PHI] = PHINode::Create(IndexType, PHI->getNumIncomingValues(),
695 PHI->getName() + ".idx", PHI);
696 }
697 IRBuilder<> Builder(Base->getContext());
698
699 // Create all the other instructions.
700 for (Value *Val : Explored) {
701
702 if (NewInsts.find(Val) != NewInsts.end())
703 continue;
704
705 if (auto *CI = dyn_cast<CastInst>(Val)) {
Martin Storsjo0fe645c2019-05-30 20:53:21 +0000706 // Don't get rid of the intermediate variable here; the store can grow
707 // the map which will invalidate the reference to the input value.
708 Value *V = NewInsts[CI->getOperand(0)];
709 NewInsts[CI] = V;
Silviu Barangaf29dfd32016-01-15 15:52:05 +0000710 continue;
711 }
712 if (auto *GEP = dyn_cast<GEPOperator>(Val)) {
713 Value *Index = NewInsts[GEP->getOperand(1)] ? NewInsts[GEP->getOperand(1)]
714 : GEP->getOperand(1);
715 setInsertionPoint(Builder, GEP);
716 // Indices might need to be sign extended. GEPs will magically do
717 // this, but we need to do it ourselves here.
718 if (Index->getType()->getScalarSizeInBits() !=
719 NewInsts[GEP->getOperand(0)]->getType()->getScalarSizeInBits()) {
720 Index = Builder.CreateSExtOrTrunc(
721 Index, NewInsts[GEP->getOperand(0)]->getType(),
722 GEP->getOperand(0)->getName() + ".sext");
723 }
724
725 auto *Op = NewInsts[GEP->getOperand(0)];
Craig Topper781aa182018-05-05 01:57:00 +0000726 if (isa<ConstantInt>(Op) && cast<ConstantInt>(Op)->isZero())
Silviu Barangaf29dfd32016-01-15 15:52:05 +0000727 NewInsts[GEP] = Index;
728 else
729 NewInsts[GEP] = Builder.CreateNSWAdd(
730 Op, Index, GEP->getOperand(0)->getName() + ".add");
731 continue;
732 }
733 if (isa<PHINode>(Val))
734 continue;
735
736 llvm_unreachable("Unexpected instruction type");
737 }
738
739 // Add the incoming values to the PHI nodes.
740 for (Value *Val : Explored) {
741 if (Val == Base)
742 continue;
743 // All the instructions have been created, we can now add edges to the
744 // phi nodes.
745 if (auto *PHI = dyn_cast<PHINode>(Val)) {
746 PHINode *NewPhi = static_cast<PHINode *>(NewInsts[PHI]);
747 for (unsigned I = 0, E = PHI->getNumIncomingValues(); I < E; ++I) {
748 Value *NewIncoming = PHI->getIncomingValue(I);
749
750 if (NewInsts.find(NewIncoming) != NewInsts.end())
751 NewIncoming = NewInsts[NewIncoming];
752
753 NewPhi->addIncoming(NewIncoming, PHI->getIncomingBlock(I));
754 }
755 }
756 }
757
758 for (Value *Val : Explored) {
759 if (Val == Base)
760 continue;
761
762 // Depending on the type, for external users we have to emit
763 // a GEP or a GEP + ptrtoint.
764 setInsertionPoint(Builder, Val, false);
765
766 // If required, create an inttoptr instruction for Base.
767 Value *NewBase = Base;
768 if (!Base->getType()->isPointerTy())
769 NewBase = Builder.CreateBitOrPointerCast(Base, Start->getType(),
770 Start->getName() + "to.ptr");
771
772 Value *GEP = Builder.CreateInBoundsGEP(
773 Start->getType()->getPointerElementType(), NewBase,
774 makeArrayRef(NewInsts[Val]), Val->getName() + ".ptr");
775
776 if (!Val->getType()->isPointerTy()) {
777 Value *Cast = Builder.CreatePointerCast(GEP, Val->getType(),
778 Val->getName() + ".conv");
779 GEP = Cast;
780 }
781 Val->replaceAllUsesWith(GEP);
782 }
783
784 return NewInsts[Start];
785}
786
787/// Looks through GEPs, IntToPtrInsts and PtrToIntInsts in order to express
788/// the input Value as a constant indexed GEP. Returns a pair containing
789/// the GEPs Pointer and Index.
790static std::pair<Value *, Value *>
791getAsConstantIndexedAddress(Value *V, const DataLayout &DL) {
792 Type *IndexType = IntegerType::get(V->getContext(),
Elena Demikhovsky945b7e52018-02-14 06:58:08 +0000793 DL.getIndexTypeSizeInBits(V->getType()));
Silviu Barangaf29dfd32016-01-15 15:52:05 +0000794
795 Constant *Index = ConstantInt::getNullValue(IndexType);
796 while (true) {
797 if (GEPOperator *GEP = dyn_cast<GEPOperator>(V)) {
798 // We accept only inbouds GEPs here to exclude the possibility of
799 // overflow.
800 if (!GEP->isInBounds())
801 break;
802 if (GEP->hasAllConstantIndices() && GEP->getNumIndices() == 1 &&
803 GEP->getType() == V->getType()) {
804 V = GEP->getOperand(0);
805 Constant *GEPIndex = static_cast<Constant *>(GEP->getOperand(1));
806 Index = ConstantExpr::getAdd(
807 Index, ConstantExpr::getSExtOrBitCast(GEPIndex, IndexType));
808 continue;
809 }
810 break;
811 }
812 if (auto *CI = dyn_cast<IntToPtrInst>(V)) {
813 if (!CI->isNoopCast(DL))
814 break;
815 V = CI->getOperand(0);
816 continue;
817 }
818 if (auto *CI = dyn_cast<PtrToIntInst>(V)) {
819 if (!CI->isNoopCast(DL))
820 break;
821 V = CI->getOperand(0);
822 continue;
823 }
824 break;
825 }
826 return {V, Index};
827}
828
Sanjay Patel5f0217f2016-06-05 16:46:18 +0000829/// Converts (CMP GEPLHS, RHS) if this change would make RHS a constant.
830/// We can look through PHIs, GEPs and casts in order to determine a common base
831/// between GEPLHS and RHS.
Silviu Barangaf29dfd32016-01-15 15:52:05 +0000832static Instruction *transformToIndexedCompare(GEPOperator *GEPLHS, Value *RHS,
833 ICmpInst::Predicate Cond,
834 const DataLayout &DL) {
Craig Topper5bbb6042019-08-27 21:38:56 +0000835 // FIXME: Support vector of pointers.
836 if (GEPLHS->getType()->isVectorTy())
837 return nullptr;
838
Silviu Barangaf29dfd32016-01-15 15:52:05 +0000839 if (!GEPLHS->hasAllConstantIndices())
840 return nullptr;
841
Silviu Barangac6d21eb2017-01-31 14:04:15 +0000842 // Make sure the pointers have the same type.
843 if (GEPLHS->getType() != RHS->getType())
844 return nullptr;
845
Silviu Barangaf29dfd32016-01-15 15:52:05 +0000846 Value *PtrBase, *Index;
847 std::tie(PtrBase, Index) = getAsConstantIndexedAddress(GEPLHS, DL);
848
849 // The set of nodes that will take part in this transformation.
850 SetVector<Value *> Nodes;
851
852 if (!canRewriteGEPAsOffset(RHS, PtrBase, DL, Nodes))
853 return nullptr;
854
855 // We know we can re-write this as
856 // ((gep Ptr, OFFSET1) cmp (gep Ptr, OFFSET2)
857 // Since we've only looked through inbouds GEPs we know that we
858 // can't have overflow on either side. We can therefore re-write
859 // this as:
860 // OFFSET1 cmp OFFSET2
861 Value *NewRHS = rewriteGEPAsOffset(RHS, PtrBase, DL, Nodes);
862
863 // RewriteGEPAsOffset has replaced RHS and all of its uses with a re-written
864 // GEP having PtrBase as the pointer base, and has returned in NewRHS the
865 // offset. Since Index is the offset of LHS to the base pointer, we will now
866 // compare the offsets instead of comparing the pointers.
867 return new ICmpInst(ICmpInst::getSignedPredicate(Cond), Index, NewRHS);
868}
869
Sanjay Patel5f0217f2016-06-05 16:46:18 +0000870/// Fold comparisons between a GEP instruction and something else. At this point
871/// we know that the GEP is on the LHS of the comparison.
Sanjay Patel43395062016-07-21 18:07:40 +0000872Instruction *InstCombiner::foldGEPICmp(GEPOperator *GEPLHS, Value *RHS,
Chris Lattner2188e402010-01-04 07:37:31 +0000873 ICmpInst::Predicate Cond,
874 Instruction &I) {
Benjamin Kramer6ee86902012-02-21 13:31:09 +0000875 // Don't transform signed compares of GEPs into index compares. Even if the
876 // GEP is inbounds, the final add of the base pointer can have signed overflow
877 // and would change the result of the icmp.
878 // e.g. "&foo[0] <s &foo[1]" can't be folded to "true" because "foo" could be
Benjamin Kramerc7a22fe2012-02-21 13:40:06 +0000879 // the maximum signed value for the pointer type.
Benjamin Kramer6ee86902012-02-21 13:31:09 +0000880 if (ICmpInst::isSigned(Cond))
Craig Topperf40110f2014-04-25 05:29:35 +0000881 return nullptr;
Benjamin Kramer6ee86902012-02-21 13:31:09 +0000882
Matt Arsenault44f60d02014-06-09 19:20:29 +0000883 // Look through bitcasts and addrspacecasts. We do not however want to remove
884 // 0 GEPs.
885 if (!isa<GetElementPtrInst>(RHS))
886 RHS = RHS->stripPointerCasts();
Chris Lattner2188e402010-01-04 07:37:31 +0000887
888 Value *PtrBase = GEPLHS->getOperand(0);
Craig Topper5bbb6042019-08-27 21:38:56 +0000889 // FIXME: Support vector pointer GEPs.
890 if (PtrBase == RHS && GEPLHS->isInBounds() &&
891 !GEPLHS->getType()->isVectorTy()) {
Chris Lattner2188e402010-01-04 07:37:31 +0000892 // ((gep Ptr, OFFSET) cmp Ptr) ---> (OFFSET cmp 0).
893 // This transformation (ignoring the base and scales) is valid because we
894 // know pointers can't overflow since the gep is inbounds. See if we can
895 // output an optimized form.
Sanjay Pateld93c4c02016-09-15 18:22:25 +0000896 Value *Offset = evaluateGEPOffsetExpression(GEPLHS, *this, DL);
Jim Grosbach129c52a2011-09-30 18:09:53 +0000897
Chris Lattner2188e402010-01-04 07:37:31 +0000898 // If not, synthesize the offset the hard way.
Craig Topperf40110f2014-04-25 05:29:35 +0000899 if (!Offset)
Chris Lattner2188e402010-01-04 07:37:31 +0000900 Offset = EmitGEPOffset(GEPLHS);
901 return new ICmpInst(ICmpInst::getSignedPredicate(Cond), Offset,
902 Constant::getNullValue(Offset->getType()));
Craig Topper5bbb6042019-08-27 21:38:56 +0000903 }
904
905 if (GEPLHS->isInBounds() && ICmpInst::isEquality(Cond) &&
906 isa<Constant>(RHS) && cast<Constant>(RHS)->isNullValue() &&
907 !NullPointerIsDefined(I.getFunction(),
908 RHS->getType()->getPointerAddressSpace())) {
Philip Reames5b02cfa2019-08-23 17:58:58 +0000909 // For most address spaces, an allocation can't be placed at null, but null
910 // itself is treated as a 0 size allocation in the in bounds rules. Thus,
911 // the only valid inbounds address derived from null, is null itself.
912 // Thus, we have four cases to consider:
913 // 1) Base == nullptr, Offset == 0 -> inbounds, null
914 // 2) Base == nullptr, Offset != 0 -> poison as the result is out of bounds
915 // 3) Base != nullptr, Offset == (-base) -> poison (crossing allocations)
916 // 4) Base != nullptr, Offset != (-base) -> nonnull (and possibly poison)
917 //
918 // (Note if we're indexing a type of size 0, that simply collapses into one
919 // of the buckets above.)
920 //
921 // In general, we're allowed to make values less poison (i.e. remove
922 // sources of full UB), so in this case, we just select between the two
923 // non-poison cases (1 and 4 above).
Philip Reamesb92c9712019-08-26 19:11:49 +0000924 //
925 // For vectors, we apply the same reasoning on a per-lane basis.
Philip Reames9cb059f2019-08-23 18:27:57 +0000926 auto *Base = GEPLHS->getPointerOperand();
Philip Reamesb92c9712019-08-26 19:11:49 +0000927 if (GEPLHS->getType()->isVectorTy() && Base->getType()->isPointerTy()) {
928 int NumElts = GEPLHS->getType()->getVectorNumElements();
929 Base = Builder.CreateVectorSplat(NumElts, Base);
930 }
Philip Reames9cb059f2019-08-23 18:27:57 +0000931 return new ICmpInst(Cond, Base,
932 ConstantExpr::getBitCast(cast<Constant>(RHS),
933 Base->getType()));
Chris Lattner2188e402010-01-04 07:37:31 +0000934 } else if (GEPOperator *GEPRHS = dyn_cast<GEPOperator>(RHS)) {
935 // If the base pointers are different, but the indices are the same, just
936 // compare the base pointer.
937 if (PtrBase != GEPRHS->getOperand(0)) {
938 bool IndicesTheSame = GEPLHS->getNumOperands()==GEPRHS->getNumOperands();
939 IndicesTheSame &= GEPLHS->getOperand(0)->getType() ==
940 GEPRHS->getOperand(0)->getType();
941 if (IndicesTheSame)
942 for (unsigned i = 1, e = GEPLHS->getNumOperands(); i != e; ++i)
943 if (GEPLHS->getOperand(i) != GEPRHS->getOperand(i)) {
944 IndicesTheSame = false;
945 break;
946 }
947
948 // If all indices are the same, just compare the base pointers.
Jesper Antonssonc954b862018-10-01 14:59:25 +0000949 Type *BaseType = GEPLHS->getOperand(0)->getType();
950 if (IndicesTheSame && CmpInst::makeCmpResultType(BaseType) == I.getType())
David Majnemer5953d372013-06-29 10:28:04 +0000951 return new ICmpInst(Cond, GEPLHS->getOperand(0), GEPRHS->getOperand(0));
Chris Lattner2188e402010-01-04 07:37:31 +0000952
Benjamin Kramer7adb1892012-02-20 15:07:47 +0000953 // If we're comparing GEPs with two base pointers that only differ in type
954 // and both GEPs have only constant indices or just one use, then fold
955 // the compare with the adjusted indices.
Craig Topper5bbb6042019-08-27 21:38:56 +0000956 // FIXME: Support vector of pointers.
Mehdi Aminia28d91d2015-03-10 02:37:25 +0000957 if (GEPLHS->isInBounds() && GEPRHS->isInBounds() &&
Benjamin Kramer7adb1892012-02-20 15:07:47 +0000958 (GEPLHS->hasAllConstantIndices() || GEPLHS->hasOneUse()) &&
959 (GEPRHS->hasAllConstantIndices() || GEPRHS->hasOneUse()) &&
960 PtrBase->stripPointerCasts() ==
Craig Topper5bbb6042019-08-27 21:38:56 +0000961 GEPRHS->getOperand(0)->stripPointerCasts() &&
962 !GEPLHS->getType()->isVectorTy()) {
Matt Arsenault44f60d02014-06-09 19:20:29 +0000963 Value *LOffset = EmitGEPOffset(GEPLHS);
964 Value *ROffset = EmitGEPOffset(GEPRHS);
965
966 // If we looked through an addrspacecast between different sized address
967 // spaces, the LHS and RHS pointers are different sized
968 // integers. Truncate to the smaller one.
969 Type *LHSIndexTy = LOffset->getType();
970 Type *RHSIndexTy = ROffset->getType();
971 if (LHSIndexTy != RHSIndexTy) {
972 if (LHSIndexTy->getPrimitiveSizeInBits() <
973 RHSIndexTy->getPrimitiveSizeInBits()) {
Craig Topperbb4069e2017-07-07 23:16:26 +0000974 ROffset = Builder.CreateTrunc(ROffset, LHSIndexTy);
Matt Arsenault44f60d02014-06-09 19:20:29 +0000975 } else
Craig Topperbb4069e2017-07-07 23:16:26 +0000976 LOffset = Builder.CreateTrunc(LOffset, RHSIndexTy);
Matt Arsenault44f60d02014-06-09 19:20:29 +0000977 }
978
Craig Topperbb4069e2017-07-07 23:16:26 +0000979 Value *Cmp = Builder.CreateICmp(ICmpInst::getSignedPredicate(Cond),
980 LOffset, ROffset);
Sanjay Patel4b198802016-02-01 22:23:39 +0000981 return replaceInstUsesWith(I, Cmp);
Benjamin Kramer7adb1892012-02-20 15:07:47 +0000982 }
983
Chris Lattner2188e402010-01-04 07:37:31 +0000984 // Otherwise, the base pointers are different and the indices are
Silviu Barangaf29dfd32016-01-15 15:52:05 +0000985 // different. Try convert this to an indexed compare by looking through
986 // PHIs/casts.
987 return transformToIndexedCompare(GEPLHS, RHS, Cond, DL);
Chris Lattner2188e402010-01-04 07:37:31 +0000988 }
989
990 // If one of the GEPs has all zero indices, recurse.
Craig Topperf79d8a02019-08-28 15:40:34 +0000991 // FIXME: Handle vector of pointers.
992 if (!GEPLHS->getType()->isVectorTy() && GEPLHS->hasAllZeroIndices())
Sanjay Patel43395062016-07-21 18:07:40 +0000993 return foldGEPICmp(GEPRHS, GEPLHS->getOperand(0),
David Majnemer92a8a7d2013-06-29 09:45:35 +0000994 ICmpInst::getSwappedPredicate(Cond), I);
Chris Lattner2188e402010-01-04 07:37:31 +0000995
996 // If the other GEP has all zero indices, recurse.
Craig Topperf79d8a02019-08-28 15:40:34 +0000997 // FIXME: Handle vector of pointers.
998 if (!GEPRHS->getType()->isVectorTy() && GEPRHS->hasAllZeroIndices())
Sanjay Patel43395062016-07-21 18:07:40 +0000999 return foldGEPICmp(GEPLHS, GEPRHS->getOperand(0), Cond, I);
Chris Lattner2188e402010-01-04 07:37:31 +00001000
Stuart Hastings66a82b92011-05-14 05:55:10 +00001001 bool GEPsInBounds = GEPLHS->isInBounds() && GEPRHS->isInBounds();
Chris Lattner2188e402010-01-04 07:37:31 +00001002 if (GEPLHS->getNumOperands() == GEPRHS->getNumOperands()) {
1003 // If the GEPs only differ by one index, compare it.
1004 unsigned NumDifferences = 0; // Keep track of # differences.
1005 unsigned DiffOperand = 0; // The operand that differs.
1006 for (unsigned i = 1, e = GEPRHS->getNumOperands(); i != e; ++i)
1007 if (GEPLHS->getOperand(i) != GEPRHS->getOperand(i)) {
Craig Topper5bbb6042019-08-27 21:38:56 +00001008 Type *LHSType = GEPLHS->getOperand(i)->getType();
1009 Type *RHSType = GEPRHS->getOperand(i)->getType();
1010 // FIXME: Better support for vector of pointers.
1011 if (LHSType->getPrimitiveSizeInBits() !=
1012 RHSType->getPrimitiveSizeInBits() ||
1013 (GEPLHS->getType()->isVectorTy() &&
1014 (!LHSType->isVectorTy() || !RHSType->isVectorTy()))) {
Chris Lattner2188e402010-01-04 07:37:31 +00001015 // Irreconcilable differences.
1016 NumDifferences = 2;
1017 break;
Chris Lattner2188e402010-01-04 07:37:31 +00001018 }
Craig Topper5bbb6042019-08-27 21:38:56 +00001019
1020 if (NumDifferences++) break;
1021 DiffOperand = i;
Chris Lattner2188e402010-01-04 07:37:31 +00001022 }
1023
Rafael Espindolaa7bbc0b2013-06-06 17:03:05 +00001024 if (NumDifferences == 0) // SAME GEP?
Sanjay Patel4b198802016-02-01 22:23:39 +00001025 return replaceInstUsesWith(I, // No comparison is needed here.
Jesper Antonsson719fa052018-09-20 13:37:28 +00001026 ConstantInt::get(I.getType(), ICmpInst::isTrueWhenEqual(Cond)));
Chris Lattner2188e402010-01-04 07:37:31 +00001027
Stuart Hastings66a82b92011-05-14 05:55:10 +00001028 else if (NumDifferences == 1 && GEPsInBounds) {
Chris Lattner2188e402010-01-04 07:37:31 +00001029 Value *LHSV = GEPLHS->getOperand(DiffOperand);
1030 Value *RHSV = GEPRHS->getOperand(DiffOperand);
1031 // Make sure we do a signed comparison here.
1032 return new ICmpInst(ICmpInst::getSignedPredicate(Cond), LHSV, RHSV);
1033 }
1034 }
1035
1036 // Only lower this if the icmp is the only user of the GEP or if we expect
1037 // the result to fold to a constant!
Mehdi Aminia28d91d2015-03-10 02:37:25 +00001038 if (GEPsInBounds && (isa<ConstantExpr>(GEPLHS) || GEPLHS->hasOneUse()) &&
Chris Lattner2188e402010-01-04 07:37:31 +00001039 (isa<ConstantExpr>(GEPRHS) || GEPRHS->hasOneUse())) {
1040 // ((gep Ptr, OFFSET1) cmp (gep Ptr, OFFSET2) ---> (OFFSET1 cmp OFFSET2)
1041 Value *L = EmitGEPOffset(GEPLHS);
1042 Value *R = EmitGEPOffset(GEPRHS);
1043 return new ICmpInst(ICmpInst::getSignedPredicate(Cond), L, R);
1044 }
1045 }
Silviu Barangaf29dfd32016-01-15 15:52:05 +00001046
1047 // Try convert this to an indexed compare by looking through PHIs/casts as a
1048 // last resort.
1049 return transformToIndexedCompare(GEPLHS, RHS, Cond, DL);
Chris Lattner2188e402010-01-04 07:37:31 +00001050}
1051
Pete Cooper980a9352016-08-12 17:13:28 +00001052Instruction *InstCombiner::foldAllocaCmp(ICmpInst &ICI,
1053 const AllocaInst *Alloca,
1054 const Value *Other) {
Hans Wennborgf1f36512015-10-07 00:20:07 +00001055 assert(ICI.isEquality() && "Cannot fold non-equality comparison.");
1056
1057 // It would be tempting to fold away comparisons between allocas and any
1058 // pointer not based on that alloca (e.g. an argument). However, even
1059 // though such pointers cannot alias, they can still compare equal.
1060 //
1061 // But LLVM doesn't specify where allocas get their memory, so if the alloca
1062 // doesn't escape we can argue that it's impossible to guess its value, and we
1063 // can therefore act as if any such guesses are wrong.
1064 //
1065 // The code below checks that the alloca doesn't escape, and that it's only
1066 // used in a comparison once (the current instruction). The
1067 // single-comparison-use condition ensures that we're trivially folding all
1068 // comparisons against the alloca consistently, and avoids the risk of
1069 // erroneously folding a comparison of the pointer with itself.
1070
1071 unsigned MaxIter = 32; // Break cycles and bound to constant-time.
1072
Pete Cooper980a9352016-08-12 17:13:28 +00001073 SmallVector<const Use *, 32> Worklist;
1074 for (const Use &U : Alloca->uses()) {
Hans Wennborgf1f36512015-10-07 00:20:07 +00001075 if (Worklist.size() >= MaxIter)
1076 return nullptr;
1077 Worklist.push_back(&U);
1078 }
1079
1080 unsigned NumCmps = 0;
1081 while (!Worklist.empty()) {
1082 assert(Worklist.size() <= MaxIter);
Pete Cooper980a9352016-08-12 17:13:28 +00001083 const Use *U = Worklist.pop_back_val();
1084 const Value *V = U->getUser();
Hans Wennborgf1f36512015-10-07 00:20:07 +00001085 --MaxIter;
1086
1087 if (isa<BitCastInst>(V) || isa<GetElementPtrInst>(V) || isa<PHINode>(V) ||
1088 isa<SelectInst>(V)) {
1089 // Track the uses.
1090 } else if (isa<LoadInst>(V)) {
1091 // Loading from the pointer doesn't escape it.
1092 continue;
Pete Cooper980a9352016-08-12 17:13:28 +00001093 } else if (const auto *SI = dyn_cast<StoreInst>(V)) {
Hans Wennborgf1f36512015-10-07 00:20:07 +00001094 // Storing *to* the pointer is fine, but storing the pointer escapes it.
1095 if (SI->getValueOperand() == U->get())
1096 return nullptr;
1097 continue;
1098 } else if (isa<ICmpInst>(V)) {
1099 if (NumCmps++)
1100 return nullptr; // Found more than one cmp.
1101 continue;
Pete Cooper980a9352016-08-12 17:13:28 +00001102 } else if (const auto *Intrin = dyn_cast<IntrinsicInst>(V)) {
Hans Wennborgf1f36512015-10-07 00:20:07 +00001103 switch (Intrin->getIntrinsicID()) {
1104 // These intrinsics don't escape or compare the pointer. Memset is safe
1105 // because we don't allow ptrtoint. Memcpy and memmove are safe because
1106 // we don't allow stores, so src cannot point to V.
1107 case Intrinsic::lifetime_start: case Intrinsic::lifetime_end:
Hans Wennborgf1f36512015-10-07 00:20:07 +00001108 case Intrinsic::memcpy: case Intrinsic::memmove: case Intrinsic::memset:
1109 continue;
1110 default:
1111 return nullptr;
1112 }
1113 } else {
1114 return nullptr;
1115 }
Pete Cooper980a9352016-08-12 17:13:28 +00001116 for (const Use &U : V->uses()) {
Hans Wennborgf1f36512015-10-07 00:20:07 +00001117 if (Worklist.size() >= MaxIter)
1118 return nullptr;
1119 Worklist.push_back(&U);
1120 }
1121 }
1122
1123 Type *CmpTy = CmpInst::makeCmpResultType(Other->getType());
Sanjay Patel4b198802016-02-01 22:23:39 +00001124 return replaceInstUsesWith(
Hans Wennborgf1f36512015-10-07 00:20:07 +00001125 ICI,
1126 ConstantInt::get(CmpTy, !CmpInst::isTrueWhenEqual(ICI.getPredicate())));
1127}
1128
Craig Topperbee74792018-08-20 23:04:25 +00001129/// Fold "icmp pred (X+C), X".
1130Instruction *InstCombiner::foldICmpAddOpConst(Value *X, const APInt &C,
Sanjay Patel43395062016-07-21 18:07:40 +00001131 ICmpInst::Predicate Pred) {
Chris Lattner2188e402010-01-04 07:37:31 +00001132 // From this point on, we know that (X+C <= X) --> (X+C < X) because C != 0,
Chris Lattner0ab5e2c2011-04-15 05:18:47 +00001133 // so the values can never be equal. Similarly for all other "or equals"
Chris Lattner2188e402010-01-04 07:37:31 +00001134 // operators.
Craig Topperbee74792018-08-20 23:04:25 +00001135 assert(!!C && "C should not be zero!");
Jim Grosbach129c52a2011-09-30 18:09:53 +00001136
Chris Lattner8c92b572010-01-08 17:48:19 +00001137 // (X+1) <u X --> X >u (MAXUINT-1) --> X == 255
Chris Lattner2188e402010-01-04 07:37:31 +00001138 // (X+2) <u X --> X >u (MAXUINT-2) --> X > 253
1139 // (X+MAXUINT) <u X --> X >u (MAXUINT-MAXUINT) --> X != 0
1140 if (Pred == ICmpInst::ICMP_ULT || Pred == ICmpInst::ICMP_ULE) {
Craig Topperbee74792018-08-20 23:04:25 +00001141 Constant *R = ConstantInt::get(X->getType(),
1142 APInt::getMaxValue(C.getBitWidth()) - C);
Chris Lattner2188e402010-01-04 07:37:31 +00001143 return new ICmpInst(ICmpInst::ICMP_UGT, X, R);
1144 }
Jim Grosbach129c52a2011-09-30 18:09:53 +00001145
Chris Lattner2188e402010-01-04 07:37:31 +00001146 // (X+1) >u X --> X <u (0-1) --> X != 255
1147 // (X+2) >u X --> X <u (0-2) --> X <u 254
1148 // (X+MAXUINT) >u X --> X <u (0-MAXUINT) --> X <u 1 --> X == 0
Duncan Sandse5220012011-02-17 07:46:37 +00001149 if (Pred == ICmpInst::ICMP_UGT || Pred == ICmpInst::ICMP_UGE)
Craig Topperbee74792018-08-20 23:04:25 +00001150 return new ICmpInst(ICmpInst::ICMP_ULT, X,
1151 ConstantInt::get(X->getType(), -C));
Jim Grosbach129c52a2011-09-30 18:09:53 +00001152
Craig Topperbee74792018-08-20 23:04:25 +00001153 APInt SMax = APInt::getSignedMaxValue(C.getBitWidth());
Chris Lattner2188e402010-01-04 07:37:31 +00001154
1155 // (X+ 1) <s X --> X >s (MAXSINT-1) --> X == 127
1156 // (X+ 2) <s X --> X >s (MAXSINT-2) --> X >s 125
1157 // (X+MAXSINT) <s X --> X >s (MAXSINT-MAXSINT) --> X >s 0
1158 // (X+MINSINT) <s X --> X >s (MAXSINT-MINSINT) --> X >s -1
1159 // (X+ -2) <s X --> X >s (MAXSINT- -2) --> X >s 126
1160 // (X+ -1) <s X --> X >s (MAXSINT- -1) --> X != 127
Duncan Sandse5220012011-02-17 07:46:37 +00001161 if (Pred == ICmpInst::ICMP_SLT || Pred == ICmpInst::ICMP_SLE)
Craig Topperbee74792018-08-20 23:04:25 +00001162 return new ICmpInst(ICmpInst::ICMP_SGT, X,
1163 ConstantInt::get(X->getType(), SMax - C));
Jim Grosbach129c52a2011-09-30 18:09:53 +00001164
Chris Lattner2188e402010-01-04 07:37:31 +00001165 // (X+ 1) >s X --> X <s (MAXSINT-(1-1)) --> X != 127
1166 // (X+ 2) >s X --> X <s (MAXSINT-(2-1)) --> X <s 126
1167 // (X+MAXSINT) >s X --> X <s (MAXSINT-(MAXSINT-1)) --> X <s 1
1168 // (X+MINSINT) >s X --> X <s (MAXSINT-(MINSINT-1)) --> X <s -2
1169 // (X+ -2) >s X --> X <s (MAXSINT-(-2-1)) --> X <s -126
1170 // (X+ -1) >s X --> X <s (MAXSINT-(-1-1)) --> X == -128
Jim Grosbach129c52a2011-09-30 18:09:53 +00001171
Chris Lattner2188e402010-01-04 07:37:31 +00001172 assert(Pred == ICmpInst::ICMP_SGT || Pred == ICmpInst::ICMP_SGE);
Craig Topperbee74792018-08-20 23:04:25 +00001173 return new ICmpInst(ICmpInst::ICMP_SLT, X,
1174 ConstantInt::get(X->getType(), SMax - (C - 1)));
Chris Lattner2188e402010-01-04 07:37:31 +00001175}
1176
Sanjay Patel8da42cc2016-09-15 22:26:31 +00001177/// Handle "(icmp eq/ne (ashr/lshr AP2, A), AP1)" ->
1178/// (icmp eq/ne A, Log2(AP2/AP1)) ->
1179/// (icmp eq/ne A, Log2(AP2) - Log2(AP1)).
1180Instruction *InstCombiner::foldICmpShrConstConst(ICmpInst &I, Value *A,
1181 const APInt &AP1,
1182 const APInt &AP2) {
Suyog Sarda3a8c2c12014-07-22 19:19:36 +00001183 assert(I.isEquality() && "Cannot fold icmp gt/lt");
1184
Suyog Sarda3a8c2c12014-07-22 19:19:36 +00001185 auto getICmp = [&I](CmpInst::Predicate Pred, Value *LHS, Value *RHS) {
1186 if (I.getPredicate() == I.ICMP_NE)
1187 Pred = CmpInst::getInversePredicate(Pred);
1188 return new ICmpInst(Pred, LHS, RHS);
1189 };
1190
David Majnemer2abb8182014-10-25 07:13:13 +00001191 // Don't bother doing any work for cases which InstSimplify handles.
Craig Topper73ba1c82017-06-07 07:40:37 +00001192 if (AP2.isNullValue())
David Majnemer2abb8182014-10-25 07:13:13 +00001193 return nullptr;
Sanjay Patel8da42cc2016-09-15 22:26:31 +00001194
1195 bool IsAShr = isa<AShrOperator>(I.getOperand(0));
David Majnemer2abb8182014-10-25 07:13:13 +00001196 if (IsAShr) {
1197 if (AP2.isAllOnesValue())
1198 return nullptr;
1199 if (AP2.isNegative() != AP1.isNegative())
1200 return nullptr;
1201 if (AP2.sgt(AP1))
1202 return nullptr;
1203 }
Suyog Sarda3a8c2c12014-07-22 19:19:36 +00001204
David Majnemerd2056022014-10-21 19:51:55 +00001205 if (!AP1)
Suyog Sarda3a8c2c12014-07-22 19:19:36 +00001206 // 'A' must be large enough to shift out the highest set bit.
1207 return getICmp(I.ICMP_UGT, A,
1208 ConstantInt::get(A->getType(), AP2.logBase2()));
Suyog Sarda3a8c2c12014-07-22 19:19:36 +00001209
David Majnemerd2056022014-10-21 19:51:55 +00001210 if (AP1 == AP2)
1211 return getICmp(I.ICMP_EQ, A, ConstantInt::getNullValue(A->getType()));
Suyog Sarda3a8c2c12014-07-22 19:19:36 +00001212
Andrea Di Biagio5b92b492014-09-17 11:32:31 +00001213 int Shift;
David Majnemerd2056022014-10-21 19:51:55 +00001214 if (IsAShr && AP1.isNegative())
David Majnemere5977eb2015-09-19 00:48:26 +00001215 Shift = AP1.countLeadingOnes() - AP2.countLeadingOnes();
Andrea Di Biagio5b92b492014-09-17 11:32:31 +00001216 else
David Majnemere5977eb2015-09-19 00:48:26 +00001217 Shift = AP1.countLeadingZeros() - AP2.countLeadingZeros();
Suyog Sarda3a8c2c12014-07-22 19:19:36 +00001218
David Majnemerd2056022014-10-21 19:51:55 +00001219 if (Shift > 0) {
David Majnemere5977eb2015-09-19 00:48:26 +00001220 if (IsAShr && AP1 == AP2.ashr(Shift)) {
1221 // There are multiple solutions if we are comparing against -1 and the LHS
David Majnemer47ce0b82015-09-19 00:48:31 +00001222 // of the ashr is not a power of two.
David Majnemere5977eb2015-09-19 00:48:26 +00001223 if (AP1.isAllOnesValue() && !AP2.isPowerOf2())
1224 return getICmp(I.ICMP_UGE, A, ConstantInt::get(A->getType(), Shift));
David Majnemerd2056022014-10-21 19:51:55 +00001225 return getICmp(I.ICMP_EQ, A, ConstantInt::get(A->getType(), Shift));
David Majnemere5977eb2015-09-19 00:48:26 +00001226 } else if (AP1 == AP2.lshr(Shift)) {
1227 return getICmp(I.ICMP_EQ, A, ConstantInt::get(A->getType(), Shift));
1228 }
David Majnemerd2056022014-10-21 19:51:55 +00001229 }
Sanjay Patel524fcdf2016-09-15 19:04:55 +00001230
Suyog Sarda3a8c2c12014-07-22 19:19:36 +00001231 // Shifting const2 will never be equal to const1.
Sanjay Patel524fcdf2016-09-15 19:04:55 +00001232 // FIXME: This should always be handled by InstSimplify?
1233 auto *TorF = ConstantInt::get(I.getType(), I.getPredicate() == I.ICMP_NE);
1234 return replaceInstUsesWith(I, TorF);
Suyog Sarda3a8c2c12014-07-22 19:19:36 +00001235}
Chris Lattner2188e402010-01-04 07:37:31 +00001236
Sanjay Patel8da42cc2016-09-15 22:26:31 +00001237/// Handle "(icmp eq/ne (shl AP2, A), AP1)" ->
1238/// (icmp eq/ne A, TrailingZeros(AP1) - TrailingZeros(AP2)).
1239Instruction *InstCombiner::foldICmpShlConstConst(ICmpInst &I, Value *A,
1240 const APInt &AP1,
1241 const APInt &AP2) {
David Majnemer59939ac2014-10-19 08:23:08 +00001242 assert(I.isEquality() && "Cannot fold icmp gt/lt");
1243
David Majnemer59939ac2014-10-19 08:23:08 +00001244 auto getICmp = [&I](CmpInst::Predicate Pred, Value *LHS, Value *RHS) {
1245 if (I.getPredicate() == I.ICMP_NE)
1246 Pred = CmpInst::getInversePredicate(Pred);
1247 return new ICmpInst(Pred, LHS, RHS);
1248 };
1249
David Majnemer2abb8182014-10-25 07:13:13 +00001250 // Don't bother doing any work for cases which InstSimplify handles.
Craig Topper73ba1c82017-06-07 07:40:37 +00001251 if (AP2.isNullValue())
David Majnemer2abb8182014-10-25 07:13:13 +00001252 return nullptr;
David Majnemer59939ac2014-10-19 08:23:08 +00001253
1254 unsigned AP2TrailingZeros = AP2.countTrailingZeros();
1255
1256 if (!AP1 && AP2TrailingZeros != 0)
Sanjay Patelaf91d1f2016-09-15 21:35:30 +00001257 return getICmp(
1258 I.ICMP_UGE, A,
1259 ConstantInt::get(A->getType(), AP2.getBitWidth() - AP2TrailingZeros));
David Majnemer59939ac2014-10-19 08:23:08 +00001260
1261 if (AP1 == AP2)
1262 return getICmp(I.ICMP_EQ, A, ConstantInt::getNullValue(A->getType()));
1263
1264 // Get the distance between the lowest bits that are set.
1265 int Shift = AP1.countTrailingZeros() - AP2TrailingZeros;
1266
1267 if (Shift > 0 && AP2.shl(Shift) == AP1)
1268 return getICmp(I.ICMP_EQ, A, ConstantInt::get(A->getType(), Shift));
1269
1270 // Shifting const2 will never be equal to const1.
Sanjay Patel524fcdf2016-09-15 19:04:55 +00001271 // FIXME: This should always be handled by InstSimplify?
1272 auto *TorF = ConstantInt::get(I.getType(), I.getPredicate() == I.ICMP_NE);
1273 return replaceInstUsesWith(I, TorF);
David Majnemer59939ac2014-10-19 08:23:08 +00001274}
1275
Sanjay Patel06b127a2016-09-15 14:37:50 +00001276/// The caller has matched a pattern of the form:
1277/// I = icmp ugt (add (add A, B), CI2), CI1
1278/// If this is of the form:
1279/// sum = a + b
1280/// if (sum+128 >u 255)
1281/// Then replace it with llvm.sadd.with.overflow.i8.
1282///
Sanjay Pateld93c4c02016-09-15 18:22:25 +00001283static Instruction *processUGT_ADDCST_ADD(ICmpInst &I, Value *A, Value *B,
Sanjay Patel06b127a2016-09-15 14:37:50 +00001284 ConstantInt *CI2, ConstantInt *CI1,
1285 InstCombiner &IC) {
1286 // The transformation we're trying to do here is to transform this into an
1287 // llvm.sadd.with.overflow. To do this, we have to replace the original add
1288 // with a narrower add, and discard the add-with-constant that is part of the
1289 // range check (if we can't eliminate it, this isn't profitable).
1290
1291 // In order to eliminate the add-with-constant, the compare can be its only
1292 // use.
1293 Instruction *AddWithCst = cast<Instruction>(I.getOperand(0));
1294 if (!AddWithCst->hasOneUse())
1295 return nullptr;
1296
1297 // If CI2 is 2^7, 2^15, 2^31, then it might be an sadd.with.overflow.
1298 if (!CI2->getValue().isPowerOf2())
1299 return nullptr;
1300 unsigned NewWidth = CI2->getValue().countTrailingZeros();
1301 if (NewWidth != 7 && NewWidth != 15 && NewWidth != 31)
1302 return nullptr;
1303
1304 // The width of the new add formed is 1 more than the bias.
1305 ++NewWidth;
1306
1307 // Check to see that CI1 is an all-ones value with NewWidth bits.
1308 if (CI1->getBitWidth() == NewWidth ||
1309 CI1->getValue() != APInt::getLowBitsSet(CI1->getBitWidth(), NewWidth))
1310 return nullptr;
1311
1312 // This is only really a signed overflow check if the inputs have been
1313 // sign-extended; check for that condition. For example, if CI2 is 2^31 and
1314 // the operands of the add are 64 bits wide, we need at least 33 sign bits.
1315 unsigned NeededSignBits = CI1->getBitWidth() - NewWidth + 1;
1316 if (IC.ComputeNumSignBits(A, 0, &I) < NeededSignBits ||
1317 IC.ComputeNumSignBits(B, 0, &I) < NeededSignBits)
1318 return nullptr;
1319
1320 // In order to replace the original add with a narrower
1321 // llvm.sadd.with.overflow, the only uses allowed are the add-with-constant
1322 // and truncates that discard the high bits of the add. Verify that this is
1323 // the case.
1324 Instruction *OrigAdd = cast<Instruction>(AddWithCst->getOperand(0));
1325 for (User *U : OrigAdd->users()) {
1326 if (U == AddWithCst)
1327 continue;
1328
1329 // Only accept truncates for now. We would really like a nice recursive
1330 // predicate like SimplifyDemandedBits, but which goes downwards the use-def
1331 // chain to see which bits of a value are actually demanded. If the
1332 // original add had another add which was then immediately truncated, we
1333 // could still do the transformation.
1334 TruncInst *TI = dyn_cast<TruncInst>(U);
1335 if (!TI || TI->getType()->getPrimitiveSizeInBits() > NewWidth)
1336 return nullptr;
1337 }
1338
1339 // If the pattern matches, truncate the inputs to the narrower type and
1340 // use the sadd_with_overflow intrinsic to efficiently compute both the
1341 // result and the overflow bit.
1342 Type *NewType = IntegerType::get(OrigAdd->getContext(), NewWidth);
James Y Knight7976eb52019-02-01 20:43:25 +00001343 Function *F = Intrinsic::getDeclaration(
1344 I.getModule(), Intrinsic::sadd_with_overflow, NewType);
Sanjay Patel06b127a2016-09-15 14:37:50 +00001345
Craig Topperbb4069e2017-07-07 23:16:26 +00001346 InstCombiner::BuilderTy &Builder = IC.Builder;
Sanjay Patel06b127a2016-09-15 14:37:50 +00001347
1348 // Put the new code above the original add, in case there are any uses of the
1349 // add between the add and the compare.
Craig Topperbb4069e2017-07-07 23:16:26 +00001350 Builder.SetInsertPoint(OrigAdd);
Sanjay Patel06b127a2016-09-15 14:37:50 +00001351
Craig Topperbb4069e2017-07-07 23:16:26 +00001352 Value *TruncA = Builder.CreateTrunc(A, NewType, A->getName() + ".trunc");
1353 Value *TruncB = Builder.CreateTrunc(B, NewType, B->getName() + ".trunc");
1354 CallInst *Call = Builder.CreateCall(F, {TruncA, TruncB}, "sadd");
1355 Value *Add = Builder.CreateExtractValue(Call, 0, "sadd.result");
1356 Value *ZExt = Builder.CreateZExt(Add, OrigAdd->getType());
Sanjay Patel06b127a2016-09-15 14:37:50 +00001357
1358 // The inner add was the result of the narrow add, zero extended to the
1359 // wider type. Replace it with the result computed by the intrinsic.
1360 IC.replaceInstUsesWith(*OrigAdd, ZExt);
1361
1362 // The original icmp gets replaced with the overflow value.
1363 return ExtractValueInst::Create(Call, 1, "sadd.overflow");
1364}
1365
Roman Lebedevbe612ea2019-07-30 15:28:22 +00001366/// If we have:
1367/// icmp eq/ne (urem/srem %x, %y), 0
1368/// iff %y is a power-of-two, we can replace this with a bit test:
1369/// icmp eq/ne (and %x, (add %y, -1)), 0
1370Instruction *InstCombiner::foldIRemByPowerOfTwoToBitTest(ICmpInst &I) {
1371 // This fold is only valid for equality predicates.
1372 if (!I.isEquality())
1373 return nullptr;
1374 ICmpInst::Predicate Pred;
1375 Value *X, *Y, *Zero;
1376 if (!match(&I, m_ICmp(Pred, m_OneUse(m_IRem(m_Value(X), m_Value(Y))),
1377 m_CombineAnd(m_Zero(), m_Value(Zero)))))
1378 return nullptr;
1379 if (!isKnownToBeAPowerOfTwo(Y, /*OrZero*/ true, 0, &I))
1380 return nullptr;
1381 // This may increase instruction count, we don't enforce that Y is a constant.
1382 Value *Mask = Builder.CreateAdd(Y, Constant::getAllOnesValue(Y->getType()));
1383 Value *Masked = Builder.CreateAnd(X, Mask);
1384 return ICmpInst::Create(Instruction::ICmp, Pred, Masked, Zero);
1385}
1386
Roman Lebedevf55818e2019-07-01 09:41:43 +00001387// Handle icmp pred X, 0
Nikolai Bozhenov0e7ebbc2017-10-16 09:19:21 +00001388Instruction *InstCombiner::foldICmpWithZero(ICmpInst &Cmp) {
1389 CmpInst::Predicate Pred = Cmp.getPredicate();
Roman Lebedevf55818e2019-07-01 09:41:43 +00001390 if (!match(Cmp.getOperand(1), m_Zero()))
1391 return nullptr;
Nikolai Bozhenov0e7ebbc2017-10-16 09:19:21 +00001392
Roman Lebedevf55818e2019-07-01 09:41:43 +00001393 // (icmp sgt smin(PosA, B) 0) -> (icmp sgt B 0)
1394 if (Pred == ICmpInst::ICMP_SGT) {
Nikolai Bozhenov0e7ebbc2017-10-16 09:19:21 +00001395 Value *A, *B;
Roman Lebedevf55818e2019-07-01 09:41:43 +00001396 SelectPatternResult SPR = matchSelectPattern(Cmp.getOperand(0), A, B);
Nikolai Bozhenov0e7ebbc2017-10-16 09:19:21 +00001397 if (SPR.Flavor == SPF_SMIN) {
1398 if (isKnownPositive(A, DL, 0, &AC, &Cmp, &DT))
1399 return new ICmpInst(Pred, B, Cmp.getOperand(1));
1400 if (isKnownPositive(B, DL, 0, &AC, &Cmp, &DT))
1401 return new ICmpInst(Pred, A, Cmp.getOperand(1));
1402 }
1403 }
Roman Lebedevf55818e2019-07-01 09:41:43 +00001404
Roman Lebedevbe612ea2019-07-30 15:28:22 +00001405 if (Instruction *New = foldIRemByPowerOfTwoToBitTest(Cmp))
1406 return New;
1407
Roman Lebedevf55818e2019-07-01 09:41:43 +00001408 // Given:
1409 // icmp eq/ne (urem %x, %y), 0
1410 // Iff %x has 0 or 1 bits set, and %y has at least 2 bits set, omit 'urem':
1411 // icmp eq/ne %x, 0
1412 Value *X, *Y;
1413 if (match(Cmp.getOperand(0), m_URem(m_Value(X), m_Value(Y))) &&
1414 ICmpInst::isEquality(Pred)) {
1415 KnownBits XKnown = computeKnownBits(X, 0, &Cmp);
1416 KnownBits YKnown = computeKnownBits(Y, 0, &Cmp);
1417 if (XKnown.countMaxPopulation() == 1 && YKnown.countMinPopulation() >= 2)
1418 return new ICmpInst(Pred, X, Cmp.getOperand(1));
1419 }
1420
Nikolai Bozhenov0e7ebbc2017-10-16 09:19:21 +00001421 return nullptr;
1422}
1423
Sanjay Patela40bf9ff2018-12-04 15:35:17 +00001424/// Fold icmp Pred X, C.
Sanjay Pateld23b5ed2018-12-04 17:44:24 +00001425/// TODO: This code structure does not make sense. The saturating add fold
Sanjay Patela40bf9ff2018-12-04 15:35:17 +00001426/// should be moved to some other helper and extended as noted below (it is also
Sanjay Pateld23b5ed2018-12-04 17:44:24 +00001427/// possible that code has been made unnecessary - do we canonicalize IR to
1428/// overflow/saturating intrinsics or not?).
Sanjay Patel97459832016-09-15 15:11:12 +00001429Instruction *InstCombiner::foldICmpWithConstant(ICmpInst &Cmp) {
Sanjay Patel97459832016-09-15 15:11:12 +00001430 // Match the following pattern, which is a common idiom when writing
1431 // overflow-safe integer arithmetic functions. The source performs an addition
1432 // in wider type and explicitly checks for overflow using comparisons against
1433 // INT_MIN and INT_MAX. Simplify by using the sadd_with_overflow intrinsic.
1434 //
1435 // TODO: This could probably be generalized to handle other overflow-safe
1436 // operations if we worked out the formulas to compute the appropriate magic
1437 // constants.
1438 //
1439 // sum = a + b
1440 // if (sum+128 >u 255) ... -> llvm.sadd.with.overflow.i8
Sanjay Patela40bf9ff2018-12-04 15:35:17 +00001441 CmpInst::Predicate Pred = Cmp.getPredicate();
1442 Value *Op0 = Cmp.getOperand(0), *Op1 = Cmp.getOperand(1);
1443 Value *A, *B;
1444 ConstantInt *CI, *CI2; // I = icmp ugt (add (add A, B), CI2), CI
1445 if (Pred == ICmpInst::ICMP_UGT && match(Op1, m_ConstantInt(CI)) &&
1446 match(Op0, m_Add(m_Add(m_Value(A), m_Value(B)), m_ConstantInt(CI2))))
1447 if (Instruction *Res = processUGT_ADDCST_ADD(Cmp, A, B, CI2, CI, *this))
1448 return Res;
Sanjay Patel06b127a2016-09-15 14:37:50 +00001449
Sanjay Patela40bf9ff2018-12-04 15:35:17 +00001450 return nullptr;
1451}
1452
1453/// Canonicalize icmp instructions based on dominating conditions.
1454Instruction *InstCombiner::foldICmpWithDominatingICmp(ICmpInst &Cmp) {
Sanjay Pateld23b5ed2018-12-04 17:44:24 +00001455 // This is a cheap/incomplete check for dominance - just match a single
1456 // predecessor with a conditional branch.
1457 BasicBlock *CmpBB = Cmp.getParent();
1458 BasicBlock *DomBB = CmpBB->getSinglePredecessor();
1459 if (!DomBB)
Sanjay Patel40c53ea2016-09-15 16:23:20 +00001460 return nullptr;
Sanjay Patel06b127a2016-09-15 14:37:50 +00001461
Sanjay Pateld23b5ed2018-12-04 17:44:24 +00001462 Value *DomCond;
Sanjay Patel97459832016-09-15 15:11:12 +00001463 BasicBlock *TrueBB, *FalseBB;
Sanjay Pateld23b5ed2018-12-04 17:44:24 +00001464 if (!match(DomBB->getTerminator(), m_Br(m_Value(DomCond), TrueBB, FalseBB)))
1465 return nullptr;
1466
1467 assert((TrueBB == CmpBB || FalseBB == CmpBB) &&
1468 "Predecessor block does not point to successor?");
1469
1470 // The branch should get simplified. Don't bother simplifying this condition.
1471 if (TrueBB == FalseBB)
1472 return nullptr;
1473
Sanjay Patelbaffae92018-12-05 15:04:00 +00001474 // Try to simplify this compare to T/F based on the dominating condition.
1475 Optional<bool> Imp = isImpliedCondition(DomCond, &Cmp, DL, TrueBB == CmpBB);
1476 if (Imp)
1477 return replaceInstUsesWith(Cmp, ConstantInt::get(Cmp.getType(), *Imp));
1478
Sanjay Pateld23b5ed2018-12-04 17:44:24 +00001479 CmpInst::Predicate Pred = Cmp.getPredicate();
1480 Value *X = Cmp.getOperand(0), *Y = Cmp.getOperand(1);
1481 ICmpInst::Predicate DomPred;
1482 const APInt *C, *DomC;
1483 if (match(DomCond, m_ICmp(DomPred, m_Specific(X), m_APInt(DomC))) &&
1484 match(Y, m_APInt(C))) {
1485 // We have 2 compares of a variable with constants. Calculate the constant
1486 // ranges of those compares to see if we can transform the 2nd compare:
1487 // DomBB:
1488 // DomCond = icmp DomPred X, DomC
1489 // br DomCond, CmpBB, FalseBB
1490 // CmpBB:
1491 // Cmp = icmp Pred X, C
1492 ConstantRange CR = ConstantRange::makeAllowedICmpRegion(Pred, *C);
Sanjay Patel97459832016-09-15 15:11:12 +00001493 ConstantRange DominatingCR =
Sanjay Pateld23b5ed2018-12-04 17:44:24 +00001494 (CmpBB == TrueBB) ? ConstantRange::makeExactICmpRegion(DomPred, *DomC)
1495 : ConstantRange::makeExactICmpRegion(
1496 CmpInst::getInversePredicate(DomPred), *DomC);
Sanjay Patel97459832016-09-15 15:11:12 +00001497 ConstantRange Intersection = DominatingCR.intersectWith(CR);
1498 ConstantRange Difference = DominatingCR.difference(CR);
1499 if (Intersection.isEmptySet())
Craig Topperbb4069e2017-07-07 23:16:26 +00001500 return replaceInstUsesWith(Cmp, Builder.getFalse());
Sanjay Patel97459832016-09-15 15:11:12 +00001501 if (Difference.isEmptySet())
Craig Topperbb4069e2017-07-07 23:16:26 +00001502 return replaceInstUsesWith(Cmp, Builder.getTrue());
Sanjay Patel06b127a2016-09-15 14:37:50 +00001503
Sanjay Patel97459832016-09-15 15:11:12 +00001504 // Canonicalizing a sign bit comparison that gets used in a branch,
1505 // pessimizes codegen by generating branch on zero instruction instead
1506 // of a test and branch. So we avoid canonicalizing in such situations
1507 // because test and branch instruction has better branch displacement
1508 // than compare and branch instruction.
Sanjay Pateld23b5ed2018-12-04 17:44:24 +00001509 bool UnusedBit;
1510 bool IsSignBit = isSignBitCheck(Pred, *C, UnusedBit);
Eric Christophera95aac32017-06-30 01:57:48 +00001511 if (Cmp.isEquality() || (IsSignBit && hasBranchUse(Cmp)))
1512 return nullptr;
1513
Sanjay Pateld23b5ed2018-12-04 17:44:24 +00001514 if (const APInt *EqC = Intersection.getSingleElement())
1515 return new ICmpInst(ICmpInst::ICMP_EQ, X, Builder.getInt(*EqC));
1516 if (const APInt *NeC = Difference.getSingleElement())
1517 return new ICmpInst(ICmpInst::ICMP_NE, X, Builder.getInt(*NeC));
Sanjay Patel06b127a2016-09-15 14:37:50 +00001518 }
1519
1520 return nullptr;
1521}
1522
Sanjay Patel5f4ce4e2016-08-18 20:25:16 +00001523/// Fold icmp (trunc X, Y), C.
1524Instruction *InstCombiner::foldICmpTruncConstant(ICmpInst &Cmp,
Craig Topper524c44f2017-08-23 05:46:07 +00001525 TruncInst *Trunc,
Craig Topper8ed1aa92017-10-03 05:31:07 +00001526 const APInt &C) {
Sanjay Patel5f4ce4e2016-08-18 20:25:16 +00001527 ICmpInst::Predicate Pred = Cmp.getPredicate();
1528 Value *X = Trunc->getOperand(0);
Craig Topper8ed1aa92017-10-03 05:31:07 +00001529 if (C.isOneValue() && C.getBitWidth() > 1) {
Sanjay Patela3f4f082016-08-16 17:54:36 +00001530 // icmp slt trunc(signum(V)) 1 --> icmp slt V, 1
1531 Value *V = nullptr;
Sanjay Patel5f4ce4e2016-08-18 20:25:16 +00001532 if (Pred == ICmpInst::ICMP_SLT && match(X, m_Signum(m_Value(V))))
Sanjay Patela3f4f082016-08-16 17:54:36 +00001533 return new ICmpInst(ICmpInst::ICMP_SLT, V,
1534 ConstantInt::get(V->getType(), 1));
1535 }
Sanjay Patel5f4ce4e2016-08-18 20:25:16 +00001536
1537 if (Cmp.isEquality() && Trunc->hasOneUse()) {
Sanjay Patela3f4f082016-08-16 17:54:36 +00001538 // Simplify icmp eq (trunc x to i8), 42 -> icmp eq x, 42|highbits if all
1539 // of the high bits truncated out of x are known.
Sanjay Patel40e8ca42016-08-18 20:28:54 +00001540 unsigned DstBits = Trunc->getType()->getScalarSizeInBits(),
1541 SrcBits = X->getType()->getScalarSizeInBits();
Craig Topper8205a1a2017-05-24 16:53:07 +00001542 KnownBits Known = computeKnownBits(X, 0, &Cmp);
Sanjay Patela3f4f082016-08-16 17:54:36 +00001543
1544 // If all the high bits are known, we can do this xform.
Craig Topperb45eabc2017-04-26 16:39:58 +00001545 if ((Known.Zero | Known.One).countLeadingOnes() >= SrcBits - DstBits) {
Sanjay Patela3f4f082016-08-16 17:54:36 +00001546 // Pull in the high bits from known-ones set.
Craig Topper8ed1aa92017-10-03 05:31:07 +00001547 APInt NewRHS = C.zext(SrcBits);
Craig Topperb45eabc2017-04-26 16:39:58 +00001548 NewRHS |= Known.One & APInt::getHighBitsSet(SrcBits, SrcBits - DstBits);
Sanjay Patel40e8ca42016-08-18 20:28:54 +00001549 return new ICmpInst(Pred, X, ConstantInt::get(X->getType(), NewRHS));
Sanjay Patela3f4f082016-08-16 17:54:36 +00001550 }
1551 }
Sanjay Patel5f4ce4e2016-08-18 20:25:16 +00001552
Sanjay Patela3f4f082016-08-16 17:54:36 +00001553 return nullptr;
1554}
1555
Sanjay Patel6d5f4482016-08-17 19:23:42 +00001556/// Fold icmp (xor X, Y), C.
Sanjay Patelc9196c42016-08-22 21:24:29 +00001557Instruction *InstCombiner::foldICmpXorConstant(ICmpInst &Cmp,
1558 BinaryOperator *Xor,
Craig Topper8ed1aa92017-10-03 05:31:07 +00001559 const APInt &C) {
Sanjay Patel4c5e60d2016-08-18 14:10:48 +00001560 Value *X = Xor->getOperand(0);
1561 Value *Y = Xor->getOperand(1);
Sanjay Pateldaffec912016-08-17 19:45:18 +00001562 const APInt *XorC;
Sanjay Patel4c5e60d2016-08-18 14:10:48 +00001563 if (!match(Y, m_APInt(XorC)))
Sanjay Patel6d5f4482016-08-17 19:23:42 +00001564 return nullptr;
Sanjay Patela3f4f082016-08-16 17:54:36 +00001565
Sanjay Patel6d5f4482016-08-17 19:23:42 +00001566 // If this is a comparison that tests the signbit (X < 0) or (x > -1),
1567 // fold the xor.
1568 ICmpInst::Predicate Pred = Cmp.getPredicate();
Craig Topperdf63b962017-10-03 19:14:23 +00001569 bool TrueIfSigned = false;
1570 if (isSignBitCheck(Cmp.getPredicate(), C, TrueIfSigned)) {
Sanjay Patela3f4f082016-08-16 17:54:36 +00001571
Sanjay Patel6d5f4482016-08-17 19:23:42 +00001572 // If the sign bit of the XorCst is not set, there is no change to
1573 // the operation, just stop using the Xor.
Sanjay Pateldaffec912016-08-17 19:45:18 +00001574 if (!XorC->isNegative()) {
1575 Cmp.setOperand(0, X);
Sanjay Patel6d5f4482016-08-17 19:23:42 +00001576 Worklist.Add(Xor);
1577 return &Cmp;
Sanjay Patela3f4f082016-08-16 17:54:36 +00001578 }
1579
Craig Topperdf63b962017-10-03 19:14:23 +00001580 // Emit the opposite comparison.
1581 if (TrueIfSigned)
1582 return new ICmpInst(ICmpInst::ICMP_SGT, X,
1583 ConstantInt::getAllOnesValue(X->getType()));
Sanjay Patel6d5f4482016-08-17 19:23:42 +00001584 else
Craig Topperdf63b962017-10-03 19:14:23 +00001585 return new ICmpInst(ICmpInst::ICMP_SLT, X,
1586 ConstantInt::getNullValue(X->getType()));
Sanjay Patela3f4f082016-08-16 17:54:36 +00001587 }
Sanjay Patel6d5f4482016-08-17 19:23:42 +00001588
1589 if (Xor->hasOneUse()) {
Craig Topperbcfd2d12017-04-20 16:56:25 +00001590 // (icmp u/s (xor X SignMask), C) -> (icmp s/u X, (xor C SignMask))
1591 if (!Cmp.isEquality() && XorC->isSignMask()) {
Sanjay Pateldaffec912016-08-17 19:45:18 +00001592 Pred = Cmp.isSigned() ? Cmp.getUnsignedPredicate()
1593 : Cmp.getSignedPredicate();
Craig Topper8ed1aa92017-10-03 05:31:07 +00001594 return new ICmpInst(Pred, X, ConstantInt::get(X->getType(), C ^ *XorC));
Sanjay Patel6d5f4482016-08-17 19:23:42 +00001595 }
1596
Craig Topperbcfd2d12017-04-20 16:56:25 +00001597 // (icmp u/s (xor X ~SignMask), C) -> (icmp s/u X, (xor C ~SignMask))
Sanjay Pateldaffec912016-08-17 19:45:18 +00001598 if (!Cmp.isEquality() && XorC->isMaxSignedValue()) {
1599 Pred = Cmp.isSigned() ? Cmp.getUnsignedPredicate()
1600 : Cmp.getSignedPredicate();
Sanjay Patel6d5f4482016-08-17 19:23:42 +00001601 Pred = Cmp.getSwappedPredicate(Pred);
Craig Topper8ed1aa92017-10-03 05:31:07 +00001602 return new ICmpInst(Pred, X, ConstantInt::get(X->getType(), C ^ *XorC));
Sanjay Patel6d5f4482016-08-17 19:23:42 +00001603 }
1604 }
1605
Sanjay Patel26725bd2018-09-11 22:00:15 +00001606 // Mask constant magic can eliminate an 'xor' with unsigned compares.
1607 if (Pred == ICmpInst::ICMP_UGT) {
1608 // (xor X, ~C) >u C --> X <u ~C (when C+1 is a power of 2)
1609 if (*XorC == ~C && (C + 1).isPowerOf2())
1610 return new ICmpInst(ICmpInst::ICMP_ULT, X, Y);
1611 // (xor X, C) >u C --> X >u C (when C+1 is a power of 2)
1612 if (*XorC == C && (C + 1).isPowerOf2())
1613 return new ICmpInst(ICmpInst::ICMP_UGT, X, Y);
1614 }
1615 if (Pred == ICmpInst::ICMP_ULT) {
1616 // (xor X, -C) <u C --> X >u ~C (when C is a power of 2)
1617 if (*XorC == -C && C.isPowerOf2())
1618 return new ICmpInst(ICmpInst::ICMP_UGT, X,
1619 ConstantInt::get(X->getType(), ~C));
1620 // (xor X, C) <u C --> X >u ~C (when -C is a power of 2)
1621 if (*XorC == C && (-C).isPowerOf2())
1622 return new ICmpInst(ICmpInst::ICMP_UGT, X,
1623 ConstantInt::get(X->getType(), ~C));
1624 }
Sanjay Patela3f4f082016-08-16 17:54:36 +00001625 return nullptr;
1626}
1627
Sanjay Patel14e0e182016-08-26 18:28:46 +00001628/// Fold icmp (and (sh X, Y), C2), C1.
1629Instruction *InstCombiner::foldICmpAndShift(ICmpInst &Cmp, BinaryOperator *And,
Craig Topper8ed1aa92017-10-03 05:31:07 +00001630 const APInt &C1, const APInt &C2) {
Sanjay Patel9b40f982016-09-07 22:33:03 +00001631 BinaryOperator *Shift = dyn_cast<BinaryOperator>(And->getOperand(0));
1632 if (!Shift || !Shift->isShift())
Sanjay Patelda9c5622016-08-26 17:15:22 +00001633 return nullptr;
Sanjay Patela3f4f082016-08-16 17:54:36 +00001634
Sanjay Patelda9c5622016-08-26 17:15:22 +00001635 // If this is: (X >> C3) & C2 != C1 (where any shift and any compare could
1636 // exist), turn it into (X & (C2 << C3)) != (C1 << C3). This happens a LOT in
1637 // code produced by the clang front-end, for bitfield access.
Sanjay Patelda9c5622016-08-26 17:15:22 +00001638 // This seemingly simple opportunity to fold away a shift turns out to be
1639 // rather complicated. See PR17827 for details.
Sanjay Patel9b40f982016-09-07 22:33:03 +00001640 unsigned ShiftOpcode = Shift->getOpcode();
1641 bool IsShl = ShiftOpcode == Instruction::Shl;
1642 const APInt *C3;
1643 if (match(Shift->getOperand(1), m_APInt(C3))) {
Sanjay Patelda9c5622016-08-26 17:15:22 +00001644 bool CanFold = false;
Craig Topper7a930922017-10-04 23:06:13 +00001645 if (ShiftOpcode == Instruction::Shl) {
Sanjay Patelda9c5622016-08-26 17:15:22 +00001646 // For a left shift, we can fold if the comparison is not signed. We can
1647 // also fold a signed comparison if the mask value and comparison value
1648 // are not negative. These constraints may not be obvious, but we can
1649 // prove that they are correct using an SMT solver.
Craig Topper8ed1aa92017-10-03 05:31:07 +00001650 if (!Cmp.isSigned() || (!C2.isNegative() && !C1.isNegative()))
Sanjay Patelda9c5622016-08-26 17:15:22 +00001651 CanFold = true;
Craig Topper7a930922017-10-04 23:06:13 +00001652 } else {
1653 bool IsAshr = ShiftOpcode == Instruction::AShr;
Sanjay Patelda9c5622016-08-26 17:15:22 +00001654 // For a logical right shift, we can fold if the comparison is not signed.
1655 // We can also fold a signed comparison if the shifted mask value and the
1656 // shifted comparison value are not negative. These constraints may not be
1657 // obvious, but we can prove that they are correct using an SMT solver.
Craig Topper7a930922017-10-04 23:06:13 +00001658 // For an arithmetic shift right we can do the same, if we ensure
1659 // the And doesn't use any bits being shifted in. Normally these would
1660 // be turned into lshr by SimplifyDemandedBits, but not if there is an
1661 // additional user.
1662 if (!IsAshr || (C2.shl(*C3).lshr(*C3) == C2)) {
1663 if (!Cmp.isSigned() ||
1664 (!C2.shl(*C3).isNegative() && !C1.shl(*C3).isNegative()))
1665 CanFold = true;
1666 }
Sanjay Patela3f4f082016-08-16 17:54:36 +00001667 }
1668
Sanjay Patelda9c5622016-08-26 17:15:22 +00001669 if (CanFold) {
Craig Topper8ed1aa92017-10-03 05:31:07 +00001670 APInt NewCst = IsShl ? C1.lshr(*C3) : C1.shl(*C3);
Sanjay Patel9b40f982016-09-07 22:33:03 +00001671 APInt SameAsC1 = IsShl ? NewCst.shl(*C3) : NewCst.lshr(*C3);
Sanjay Patelda9c5622016-08-26 17:15:22 +00001672 // Check to see if we are shifting out any of the bits being compared.
Craig Topper8ed1aa92017-10-03 05:31:07 +00001673 if (SameAsC1 != C1) {
Sanjay Patelda9c5622016-08-26 17:15:22 +00001674 // If we shifted bits out, the fold is not going to work out. As a
1675 // special case, check to see if this means that the result is always
1676 // true or false now.
1677 if (Cmp.getPredicate() == ICmpInst::ICMP_EQ)
Sanjay Patel1c608f42016-09-08 16:54:02 +00001678 return replaceInstUsesWith(Cmp, ConstantInt::getFalse(Cmp.getType()));
Sanjay Patelda9c5622016-08-26 17:15:22 +00001679 if (Cmp.getPredicate() == ICmpInst::ICMP_NE)
Sanjay Patel1c608f42016-09-08 16:54:02 +00001680 return replaceInstUsesWith(Cmp, ConstantInt::getTrue(Cmp.getType()));
Sanjay Patela3f4f082016-08-16 17:54:36 +00001681 } else {
Sanjay Patel9b40f982016-09-07 22:33:03 +00001682 Cmp.setOperand(1, ConstantInt::get(And->getType(), NewCst));
Craig Topper8ed1aa92017-10-03 05:31:07 +00001683 APInt NewAndCst = IsShl ? C2.lshr(*C3) : C2.shl(*C3);
Sanjay Patel9b40f982016-09-07 22:33:03 +00001684 And->setOperand(1, ConstantInt::get(And->getType(), NewAndCst));
Sanjay Patelda9c5622016-08-26 17:15:22 +00001685 And->setOperand(0, Shift->getOperand(0));
1686 Worklist.Add(Shift); // Shift is dead.
1687 return &Cmp;
Sanjay Patela3f4f082016-08-16 17:54:36 +00001688 }
Sanjay Patelda9c5622016-08-26 17:15:22 +00001689 }
1690 }
Sanjay Patela3f4f082016-08-16 17:54:36 +00001691
Sanjay Patelda9c5622016-08-26 17:15:22 +00001692 // Turn ((X >> Y) & C2) == 0 into (X & (C2 << Y)) == 0. The latter is
1693 // preferable because it allows the C2 << Y expression to be hoisted out of a
1694 // loop if Y is invariant and X is not.
Craig Topper8ed1aa92017-10-03 05:31:07 +00001695 if (Shift->hasOneUse() && C1.isNullValue() && Cmp.isEquality() &&
Sanjay Patelda9c5622016-08-26 17:15:22 +00001696 !Shift->isArithmeticShift() && !isa<Constant>(Shift->getOperand(0))) {
1697 // Compute C2 << Y.
Sanjay Patel9b40f982016-09-07 22:33:03 +00001698 Value *NewShift =
Craig Topperbb4069e2017-07-07 23:16:26 +00001699 IsShl ? Builder.CreateLShr(And->getOperand(1), Shift->getOperand(1))
1700 : Builder.CreateShl(And->getOperand(1), Shift->getOperand(1));
Sanjay Patela3f4f082016-08-16 17:54:36 +00001701
Sanjay Patelda9c5622016-08-26 17:15:22 +00001702 // Compute X & (C2 << Y).
Craig Topperbb4069e2017-07-07 23:16:26 +00001703 Value *NewAnd = Builder.CreateAnd(Shift->getOperand(0), NewShift);
Sanjay Patelda9c5622016-08-26 17:15:22 +00001704 Cmp.setOperand(0, NewAnd);
1705 return &Cmp;
1706 }
1707
Sanjay Patel14e0e182016-08-26 18:28:46 +00001708 return nullptr;
1709}
1710
1711/// Fold icmp (and X, C2), C1.
1712Instruction *InstCombiner::foldICmpAndConstConst(ICmpInst &Cmp,
1713 BinaryOperator *And,
Craig Topper8ed1aa92017-10-03 05:31:07 +00001714 const APInt &C1) {
Huihui Zhang670778c2019-06-19 17:31:39 +00001715 bool isICMP_NE = Cmp.getPredicate() == ICmpInst::ICMP_NE;
1716
Sanjay Patel05aadf82018-10-10 20:47:46 +00001717 // For vectors: icmp ne (and X, 1), 0 --> trunc X to N x i1
1718 // TODO: We canonicalize to the longer form for scalars because we have
1719 // better analysis/folds for icmp, and codegen may be better with icmp.
Huihui Zhang670778c2019-06-19 17:31:39 +00001720 if (isICMP_NE && Cmp.getType()->isVectorTy() && C1.isNullValue() &&
1721 match(And->getOperand(1), m_One()))
Sanjay Patel05aadf82018-10-10 20:47:46 +00001722 return new TruncInst(And->getOperand(0), Cmp.getType());
1723
Sanjay Patel6b490972016-09-04 14:32:15 +00001724 const APInt *C2;
Huihui Zhang670778c2019-06-19 17:31:39 +00001725 Value *X;
1726 if (!match(And, m_And(m_Value(X), m_APInt(C2))))
Sanjay Patel14e0e182016-08-26 18:28:46 +00001727 return nullptr;
1728
Huihui Zhang670778c2019-06-19 17:31:39 +00001729 // Don't perform the following transforms if the AND has multiple uses
Craig Topper8bf62212017-09-26 18:47:25 +00001730 if (!And->hasOneUse())
Sanjay Patel14e0e182016-08-26 18:28:46 +00001731 return nullptr;
1732
Huihui Zhang670778c2019-06-19 17:31:39 +00001733 if (Cmp.isEquality() && C1.isNullValue()) {
1734 // Restrict this fold to single-use 'and' (PR10267).
1735 // Replace (and X, (1 << size(X)-1) != 0) with X s< 0
1736 if (C2->isSignMask()) {
1737 Constant *Zero = Constant::getNullValue(X->getType());
1738 auto NewPred = isICMP_NE ? ICmpInst::ICMP_SLT : ICmpInst::ICMP_SGE;
1739 return new ICmpInst(NewPred, X, Zero);
1740 }
Huihui Zhang46266132019-06-25 00:09:10 +00001741
1742 // Restrict this fold only for single-use 'and' (PR10267).
1743 // ((%x & C) == 0) --> %x u< (-C) iff (-C) is power of two.
1744 if ((~(*C2) + 1).isPowerOf2()) {
1745 Constant *NegBOC =
1746 ConstantExpr::getNeg(cast<Constant>(And->getOperand(1)));
1747 auto NewPred = isICMP_NE ? ICmpInst::ICMP_UGE : ICmpInst::ICMP_ULT;
1748 return new ICmpInst(NewPred, X, NegBOC);
1749 }
Huihui Zhang670778c2019-06-19 17:31:39 +00001750 }
1751
Sanjay Patel6b490972016-09-04 14:32:15 +00001752 // If the LHS is an 'and' of a truncate and we can widen the and/compare to
1753 // the input width without changing the value produced, eliminate the cast:
1754 //
1755 // icmp (and (trunc W), C2), C1 -> icmp (and W, C2'), C1'
1756 //
1757 // We can do this transformation if the constants do not have their sign bits
1758 // set or if it is an equality comparison. Extending a relational comparison
1759 // when we're checking the sign bit would not work.
1760 Value *W;
Craig Topper8bf62212017-09-26 18:47:25 +00001761 if (match(And->getOperand(0), m_OneUse(m_Trunc(m_Value(W)))) &&
Craig Topper8ed1aa92017-10-03 05:31:07 +00001762 (Cmp.isEquality() || (!C1.isNegative() && !C2->isNegative()))) {
Sanjay Patel6b490972016-09-04 14:32:15 +00001763 // TODO: Is this a good transform for vectors? Wider types may reduce
1764 // throughput. Should this transform be limited (even for scalars) by using
Sanjay Patel2217f752017-01-31 17:25:42 +00001765 // shouldChangeType()?
Sanjay Patel6b490972016-09-04 14:32:15 +00001766 if (!Cmp.getType()->isVectorTy()) {
1767 Type *WideType = W->getType();
1768 unsigned WideScalarBits = WideType->getScalarSizeInBits();
Craig Topper8ed1aa92017-10-03 05:31:07 +00001769 Constant *ZextC1 = ConstantInt::get(WideType, C1.zext(WideScalarBits));
Sanjay Patel6b490972016-09-04 14:32:15 +00001770 Constant *ZextC2 = ConstantInt::get(WideType, C2->zext(WideScalarBits));
Craig Topperbb4069e2017-07-07 23:16:26 +00001771 Value *NewAnd = Builder.CreateAnd(W, ZextC2, And->getName());
Sanjay Patel6b490972016-09-04 14:32:15 +00001772 return new ICmpInst(Cmp.getPredicate(), NewAnd, ZextC1);
Sanjay Patel14e0e182016-08-26 18:28:46 +00001773 }
1774 }
1775
Craig Topper8ed1aa92017-10-03 05:31:07 +00001776 if (Instruction *I = foldICmpAndShift(Cmp, And, C1, *C2))
Sanjay Patel14e0e182016-08-26 18:28:46 +00001777 return I;
1778
Sanjay Patelda9c5622016-08-26 17:15:22 +00001779 // (icmp pred (and (or (lshr A, B), A), 1), 0) -->
Sanjay Patel6b490972016-09-04 14:32:15 +00001780 // (icmp pred (and A, (or (shl 1, B), 1), 0))
Sanjay Patelda9c5622016-08-26 17:15:22 +00001781 //
1782 // iff pred isn't signed
Craig Topper8ed1aa92017-10-03 05:31:07 +00001783 if (!Cmp.isSigned() && C1.isNullValue() && And->getOperand(0)->hasOneUse() &&
Craig Topper73ba1c82017-06-07 07:40:37 +00001784 match(And->getOperand(1), m_One())) {
Sanjay Pateldef931e2016-09-07 20:50:44 +00001785 Constant *One = cast<Constant>(And->getOperand(1));
1786 Value *Or = And->getOperand(0);
Sanjay Patelda9c5622016-08-26 17:15:22 +00001787 Value *A, *B, *LShr;
Sanjay Pateldef931e2016-09-07 20:50:44 +00001788 if (match(Or, m_Or(m_Value(LShr), m_Value(A))) &&
1789 match(LShr, m_LShr(m_Specific(A), m_Value(B)))) {
1790 unsigned UsesRemoved = 0;
1791 if (And->hasOneUse())
1792 ++UsesRemoved;
1793 if (Or->hasOneUse())
1794 ++UsesRemoved;
1795 if (LShr->hasOneUse())
1796 ++UsesRemoved;
1797
1798 // Compute A & ((1 << B) | 1)
1799 Value *NewOr = nullptr;
1800 if (auto *C = dyn_cast<Constant>(B)) {
1801 if (UsesRemoved >= 1)
1802 NewOr = ConstantExpr::getOr(ConstantExpr::getNUWShl(One, C), One);
1803 } else {
1804 if (UsesRemoved >= 3)
Craig Topperbb4069e2017-07-07 23:16:26 +00001805 NewOr = Builder.CreateOr(Builder.CreateShl(One, B, LShr->getName(),
1806 /*HasNUW=*/true),
1807 One, Or->getName());
Sanjay Pateldef931e2016-09-07 20:50:44 +00001808 }
1809 if (NewOr) {
Craig Topperbb4069e2017-07-07 23:16:26 +00001810 Value *NewAnd = Builder.CreateAnd(A, NewOr, And->getName());
Sanjay Pateldef931e2016-09-07 20:50:44 +00001811 Cmp.setOperand(0, NewAnd);
1812 return &Cmp;
Sanjay Patela3f4f082016-08-16 17:54:36 +00001813 }
1814 }
Sanjay Patela3f4f082016-08-16 17:54:36 +00001815 }
Sanjay Patelda9c5622016-08-26 17:15:22 +00001816
Sanjay Pateld3c7bb282016-08-26 16:42:33 +00001817 return nullptr;
1818}
1819
1820/// Fold icmp (and X, Y), C.
1821Instruction *InstCombiner::foldICmpAndConstant(ICmpInst &Cmp,
1822 BinaryOperator *And,
Craig Topper8ed1aa92017-10-03 05:31:07 +00001823 const APInt &C) {
Sanjay Pateld3c7bb282016-08-26 16:42:33 +00001824 if (Instruction *I = foldICmpAndConstConst(Cmp, And, C))
1825 return I;
1826
Sanjay Patel5c5311f2016-08-28 18:18:00 +00001827 // TODO: These all require that Y is constant too, so refactor with the above.
Sanjay Patela3f4f082016-08-16 17:54:36 +00001828
Sanjay Patel5c5311f2016-08-28 18:18:00 +00001829 // Try to optimize things like "A[i] & 42 == 0" to index computations.
1830 Value *X = And->getOperand(0);
1831 Value *Y = And->getOperand(1);
1832 if (auto *LI = dyn_cast<LoadInst>(X))
1833 if (auto *GEP = dyn_cast<GetElementPtrInst>(LI->getOperand(0)))
1834 if (auto *GV = dyn_cast<GlobalVariable>(GEP->getOperand(0)))
Sanjay Patela3f4f082016-08-16 17:54:36 +00001835 if (GV->isConstant() && GV->hasDefinitiveInitializer() &&
Sanjay Patel5c5311f2016-08-28 18:18:00 +00001836 !LI->isVolatile() && isa<ConstantInt>(Y)) {
1837 ConstantInt *C2 = cast<ConstantInt>(Y);
1838 if (Instruction *Res = foldCmpLoadFromIndexedGlobal(GEP, GV, Cmp, C2))
Sanjay Patela3f4f082016-08-16 17:54:36 +00001839 return Res;
1840 }
Sanjay Patel5c5311f2016-08-28 18:18:00 +00001841
1842 if (!Cmp.isEquality())
1843 return nullptr;
Sanjay Patela3f4f082016-08-16 17:54:36 +00001844
1845 // X & -C == -C -> X > u ~C
1846 // X & -C != -C -> X <= u ~C
1847 // iff C is a power of 2
Craig Topper8ed1aa92017-10-03 05:31:07 +00001848 if (Cmp.getOperand(1) == Y && (-C).isPowerOf2()) {
Sanjay Patel5c5311f2016-08-28 18:18:00 +00001849 auto NewPred = Cmp.getPredicate() == CmpInst::ICMP_EQ ? CmpInst::ICMP_UGT
1850 : CmpInst::ICMP_ULE;
1851 return new ICmpInst(NewPred, X, SubOne(cast<Constant>(Cmp.getOperand(1))));
1852 }
Sanjay Patela3f4f082016-08-16 17:54:36 +00001853
Sanjay Patel5c5311f2016-08-28 18:18:00 +00001854 // (X & C2) == 0 -> (trunc X) >= 0
1855 // (X & C2) != 0 -> (trunc X) < 0
1856 // iff C2 is a power of 2 and it masks the sign bit of a legal integer type.
1857 const APInt *C2;
Craig Topper8ed1aa92017-10-03 05:31:07 +00001858 if (And->hasOneUse() && C.isNullValue() && match(Y, m_APInt(C2))) {
Sanjay Patel5c5311f2016-08-28 18:18:00 +00001859 int32_t ExactLogBase2 = C2->exactLogBase2();
1860 if (ExactLogBase2 != -1 && DL.isLegalInteger(ExactLogBase2 + 1)) {
1861 Type *NTy = IntegerType::get(Cmp.getContext(), ExactLogBase2 + 1);
1862 if (And->getType()->isVectorTy())
1863 NTy = VectorType::get(NTy, And->getType()->getVectorNumElements());
Craig Topperbb4069e2017-07-07 23:16:26 +00001864 Value *Trunc = Builder.CreateTrunc(X, NTy);
Sanjay Patel5c5311f2016-08-28 18:18:00 +00001865 auto NewPred = Cmp.getPredicate() == CmpInst::ICMP_EQ ? CmpInst::ICMP_SGE
1866 : CmpInst::ICMP_SLT;
1867 return new ICmpInst(NewPred, Trunc, Constant::getNullValue(NTy));
Sanjay Patela3f4f082016-08-16 17:54:36 +00001868 }
1869 }
Sanjay Patel5c5311f2016-08-28 18:18:00 +00001870
Sanjay Patela3f4f082016-08-16 17:54:36 +00001871 return nullptr;
1872}
1873
Sanjay Patel943e92e2016-08-17 16:30:43 +00001874/// Fold icmp (or X, Y), C.
Sanjay Patelc9196c42016-08-22 21:24:29 +00001875Instruction *InstCombiner::foldICmpOrConstant(ICmpInst &Cmp, BinaryOperator *Or,
Craig Topper8ed1aa92017-10-03 05:31:07 +00001876 const APInt &C) {
Sanjay Patel943e92e2016-08-17 16:30:43 +00001877 ICmpInst::Predicate Pred = Cmp.getPredicate();
Craig Topper8ed1aa92017-10-03 05:31:07 +00001878 if (C.isOneValue()) {
Sanjay Patela3f4f082016-08-16 17:54:36 +00001879 // icmp slt signum(V) 1 --> icmp slt V, 1
1880 Value *V = nullptr;
Sanjay Patel943e92e2016-08-17 16:30:43 +00001881 if (Pred == ICmpInst::ICMP_SLT && match(Or, m_Signum(m_Value(V))))
Sanjay Patela3f4f082016-08-16 17:54:36 +00001882 return new ICmpInst(ICmpInst::ICMP_SLT, V,
1883 ConstantInt::get(V->getType(), 1));
1884 }
1885
Sanjay Patel68bc5fb2019-02-06 16:43:54 +00001886 Value *OrOp0 = Or->getOperand(0), *OrOp1 = Or->getOperand(1);
1887 if (Cmp.isEquality() && Cmp.getOperand(1) == OrOp1) {
1888 // X | C == C --> X <=u C
1889 // X | C != C --> X >u C
1890 // iff C+1 is a power of 2 (C is a bitmask of the low bits)
1891 if ((C + 1).isPowerOf2()) {
1892 Pred = (Pred == CmpInst::ICMP_EQ) ? CmpInst::ICMP_ULE : CmpInst::ICMP_UGT;
1893 return new ICmpInst(Pred, OrOp0, OrOp1);
1894 }
1895 // More general: are all bits outside of a mask constant set or not set?
1896 // X | C == C --> (X & ~C) == 0
1897 // X | C != C --> (X & ~C) != 0
1898 if (Or->hasOneUse()) {
1899 Value *A = Builder.CreateAnd(OrOp0, ~C);
1900 return new ICmpInst(Pred, A, ConstantInt::getNullValue(OrOp0->getType()));
1901 }
Sanjay Patel50c82c42017-04-05 17:57:05 +00001902 }
1903
Craig Topper8ed1aa92017-10-03 05:31:07 +00001904 if (!Cmp.isEquality() || !C.isNullValue() || !Or->hasOneUse())
Sanjay Patela3f4f082016-08-16 17:54:36 +00001905 return nullptr;
1906
1907 Value *P, *Q;
Sanjay Patel943e92e2016-08-17 16:30:43 +00001908 if (match(Or, m_Or(m_PtrToInt(m_Value(P)), m_PtrToInt(m_Value(Q))))) {
Sanjay Patela3f4f082016-08-16 17:54:36 +00001909 // Simplify icmp eq (or (ptrtoint P), (ptrtoint Q)), 0
1910 // -> and (icmp eq P, null), (icmp eq Q, null).
Reid Klecknera871d382016-08-19 16:53:18 +00001911 Value *CmpP =
Craig Topperbb4069e2017-07-07 23:16:26 +00001912 Builder.CreateICmp(Pred, P, ConstantInt::getNullValue(P->getType()));
Reid Klecknera871d382016-08-19 16:53:18 +00001913 Value *CmpQ =
Craig Topperbb4069e2017-07-07 23:16:26 +00001914 Builder.CreateICmp(Pred, Q, ConstantInt::getNullValue(Q->getType()));
Sanjay Patel3f4db3e2017-07-14 15:09:49 +00001915 auto BOpc = Pred == CmpInst::ICMP_EQ ? Instruction::And : Instruction::Or;
1916 return BinaryOperator::Create(BOpc, CmpP, CmpQ);
1917 }
1918
1919 // Are we using xors to bitwise check for a pair of (in)equalities? Convert to
1920 // a shorter form that has more potential to be folded even further.
1921 Value *X1, *X2, *X3, *X4;
Sanjay Patel68bc5fb2019-02-06 16:43:54 +00001922 if (match(OrOp0, m_OneUse(m_Xor(m_Value(X1), m_Value(X2)))) &&
1923 match(OrOp1, m_OneUse(m_Xor(m_Value(X3), m_Value(X4))))) {
Sanjay Patel3f4db3e2017-07-14 15:09:49 +00001924 // ((X1 ^ X2) || (X3 ^ X4)) == 0 --> (X1 == X2) && (X3 == X4)
1925 // ((X1 ^ X2) || (X3 ^ X4)) != 0 --> (X1 != X2) || (X3 != X4)
1926 Value *Cmp12 = Builder.CreateICmp(Pred, X1, X2);
1927 Value *Cmp34 = Builder.CreateICmp(Pred, X3, X4);
1928 auto BOpc = Pred == CmpInst::ICMP_EQ ? Instruction::And : Instruction::Or;
1929 return BinaryOperator::Create(BOpc, Cmp12, Cmp34);
Sanjay Patela3f4f082016-08-16 17:54:36 +00001930 }
Sanjay Patel943e92e2016-08-17 16:30:43 +00001931
Sanjay Patela3f4f082016-08-16 17:54:36 +00001932 return nullptr;
1933}
1934
Sanjay Patel63478072016-08-18 15:44:44 +00001935/// Fold icmp (mul X, Y), C.
Sanjay Patelc9196c42016-08-22 21:24:29 +00001936Instruction *InstCombiner::foldICmpMulConstant(ICmpInst &Cmp,
1937 BinaryOperator *Mul,
Craig Topper8ed1aa92017-10-03 05:31:07 +00001938 const APInt &C) {
Sanjay Patel63478072016-08-18 15:44:44 +00001939 const APInt *MulC;
1940 if (!match(Mul->getOperand(1), m_APInt(MulC)))
Sanjay Patela3f4f082016-08-16 17:54:36 +00001941 return nullptr;
1942
Sanjay Patel63478072016-08-18 15:44:44 +00001943 // If this is a test of the sign bit and the multiply is sign-preserving with
1944 // a constant operand, use the multiply LHS operand instead.
1945 ICmpInst::Predicate Pred = Cmp.getPredicate();
Craig Topper8ed1aa92017-10-03 05:31:07 +00001946 if (isSignTest(Pred, C) && Mul->hasNoSignedWrap()) {
Sanjay Patel63478072016-08-18 15:44:44 +00001947 if (MulC->isNegative())
1948 Pred = ICmpInst::getSwappedPredicate(Pred);
1949 return new ICmpInst(Pred, Mul->getOperand(0),
1950 Constant::getNullValue(Mul->getType()));
1951 }
Sanjay Patela3f4f082016-08-16 17:54:36 +00001952
1953 return nullptr;
1954}
1955
Sanjay Patel98cd99d2016-08-18 21:28:30 +00001956/// Fold icmp (shl 1, Y), C.
1957static Instruction *foldICmpShlOne(ICmpInst &Cmp, Instruction *Shl,
Craig Topper8ed1aa92017-10-03 05:31:07 +00001958 const APInt &C) {
Sanjay Patel98cd99d2016-08-18 21:28:30 +00001959 Value *Y;
1960 if (!match(Shl, m_Shl(m_One(), m_Value(Y))))
1961 return nullptr;
1962
1963 Type *ShiftType = Shl->getType();
Craig Topper8ed1aa92017-10-03 05:31:07 +00001964 unsigned TypeBits = C.getBitWidth();
1965 bool CIsPowerOf2 = C.isPowerOf2();
Sanjay Patel98cd99d2016-08-18 21:28:30 +00001966 ICmpInst::Predicate Pred = Cmp.getPredicate();
1967 if (Cmp.isUnsigned()) {
1968 // (1 << Y) pred C -> Y pred Log2(C)
1969 if (!CIsPowerOf2) {
1970 // (1 << Y) < 30 -> Y <= 4
1971 // (1 << Y) <= 30 -> Y <= 4
1972 // (1 << Y) >= 30 -> Y > 4
1973 // (1 << Y) > 30 -> Y > 4
1974 if (Pred == ICmpInst::ICMP_ULT)
1975 Pred = ICmpInst::ICMP_ULE;
1976 else if (Pred == ICmpInst::ICMP_UGE)
1977 Pred = ICmpInst::ICMP_UGT;
1978 }
1979
1980 // (1 << Y) >= 2147483648 -> Y >= 31 -> Y == 31
1981 // (1 << Y) < 2147483648 -> Y < 31 -> Y != 31
Craig Topper8ed1aa92017-10-03 05:31:07 +00001982 unsigned CLog2 = C.logBase2();
Sanjay Patel98cd99d2016-08-18 21:28:30 +00001983 if (CLog2 == TypeBits - 1) {
1984 if (Pred == ICmpInst::ICMP_UGE)
1985 Pred = ICmpInst::ICMP_EQ;
1986 else if (Pred == ICmpInst::ICMP_ULT)
1987 Pred = ICmpInst::ICMP_NE;
1988 }
1989 return new ICmpInst(Pred, Y, ConstantInt::get(ShiftType, CLog2));
1990 } else if (Cmp.isSigned()) {
1991 Constant *BitWidthMinusOne = ConstantInt::get(ShiftType, TypeBits - 1);
Craig Topper8ed1aa92017-10-03 05:31:07 +00001992 if (C.isAllOnesValue()) {
Sanjay Patel98cd99d2016-08-18 21:28:30 +00001993 // (1 << Y) <= -1 -> Y == 31
1994 if (Pred == ICmpInst::ICMP_SLE)
1995 return new ICmpInst(ICmpInst::ICMP_EQ, Y, BitWidthMinusOne);
1996
1997 // (1 << Y) > -1 -> Y != 31
1998 if (Pred == ICmpInst::ICMP_SGT)
1999 return new ICmpInst(ICmpInst::ICMP_NE, Y, BitWidthMinusOne);
Craig Topper8ed1aa92017-10-03 05:31:07 +00002000 } else if (!C) {
Sanjay Patel98cd99d2016-08-18 21:28:30 +00002001 // (1 << Y) < 0 -> Y == 31
2002 // (1 << Y) <= 0 -> Y == 31
2003 if (Pred == ICmpInst::ICMP_SLT || Pred == ICmpInst::ICMP_SLE)
2004 return new ICmpInst(ICmpInst::ICMP_EQ, Y, BitWidthMinusOne);
2005
2006 // (1 << Y) >= 0 -> Y != 31
2007 // (1 << Y) > 0 -> Y != 31
2008 if (Pred == ICmpInst::ICMP_SGT || Pred == ICmpInst::ICMP_SGE)
2009 return new ICmpInst(ICmpInst::ICMP_NE, Y, BitWidthMinusOne);
2010 }
2011 } else if (Cmp.isEquality() && CIsPowerOf2) {
Craig Topper8ed1aa92017-10-03 05:31:07 +00002012 return new ICmpInst(Pred, Y, ConstantInt::get(ShiftType, C.logBase2()));
Sanjay Patel98cd99d2016-08-18 21:28:30 +00002013 }
2014
2015 return nullptr;
2016}
2017
Sanjay Patel38b75062016-08-19 17:20:37 +00002018/// Fold icmp (shl X, Y), C.
Sanjay Patelc9196c42016-08-22 21:24:29 +00002019Instruction *InstCombiner::foldICmpShlConstant(ICmpInst &Cmp,
2020 BinaryOperator *Shl,
Craig Topper8ed1aa92017-10-03 05:31:07 +00002021 const APInt &C) {
Sanjay Patel8da42cc2016-09-15 22:26:31 +00002022 const APInt *ShiftVal;
2023 if (Cmp.isEquality() && match(Shl->getOperand(0), m_APInt(ShiftVal)))
Craig Topper8ed1aa92017-10-03 05:31:07 +00002024 return foldICmpShlConstConst(Cmp, Shl->getOperand(1), C, *ShiftVal);
Sanjay Patel8da42cc2016-09-15 22:26:31 +00002025
Sanjay Patelfa7de602016-08-19 22:33:26 +00002026 const APInt *ShiftAmt;
2027 if (!match(Shl->getOperand(1), m_APInt(ShiftAmt)))
Sanjay Patel38b75062016-08-19 17:20:37 +00002028 return foldICmpShlOne(Cmp, Shl, C);
Sanjay Patela867afe2016-08-19 16:12:16 +00002029
Sanjay Patel38b75062016-08-19 17:20:37 +00002030 // Check that the shift amount is in range. If not, don't perform undefined
Sanjay Patel940c0612017-01-09 16:27:56 +00002031 // shifts. When the shift is visited, it will be simplified.
Craig Topper8ed1aa92017-10-03 05:31:07 +00002032 unsigned TypeBits = C.getBitWidth();
Sanjay Patelfa7de602016-08-19 22:33:26 +00002033 if (ShiftAmt->uge(TypeBits))
Sanjay Patela3f4f082016-08-16 17:54:36 +00002034 return nullptr;
2035
Sanjay Patele38e79c2016-08-19 17:34:05 +00002036 ICmpInst::Predicate Pred = Cmp.getPredicate();
2037 Value *X = Shl->getOperand(0);
Sanjay Patel14715b32017-01-17 21:25:16 +00002038 Type *ShType = Shl->getType();
2039
Sanjay Patel291c3d82017-01-19 16:12:10 +00002040 // NSW guarantees that we are only shifting out sign bits from the high bits,
2041 // so we can ASHR the compare constant without needing a mask and eliminate
2042 // the shift.
2043 if (Shl->hasNoSignedWrap()) {
2044 if (Pred == ICmpInst::ICMP_SGT) {
2045 // icmp Pred (shl nsw X, ShiftAmt), C --> icmp Pred X, (C >>s ShiftAmt)
Craig Topper8ed1aa92017-10-03 05:31:07 +00002046 APInt ShiftedC = C.ashr(*ShiftAmt);
Sanjay Patel291c3d82017-01-19 16:12:10 +00002047 return new ICmpInst(Pred, X, ConstantInt::get(ShType, ShiftedC));
2048 }
Sanjay Patel6fb13572018-01-09 18:56:03 +00002049 if ((Pred == ICmpInst::ICMP_EQ || Pred == ICmpInst::ICMP_NE) &&
2050 C.ashr(*ShiftAmt).shl(*ShiftAmt) == C) {
Craig Topper8ed1aa92017-10-03 05:31:07 +00002051 APInt ShiftedC = C.ashr(*ShiftAmt);
Sanjay Patel291c3d82017-01-19 16:12:10 +00002052 return new ICmpInst(Pred, X, ConstantInt::get(ShType, ShiftedC));
2053 }
2054 if (Pred == ICmpInst::ICMP_SLT) {
2055 // SLE is the same as above, but SLE is canonicalized to SLT, so convert:
2056 // (X << S) <=s C is equiv to X <=s (C >> S) for all C
2057 // (X << S) <s (C + 1) is equiv to X <s (C >> S) + 1 if C <s SMAX
2058 // (X << S) <s C is equiv to X <s ((C - 1) >> S) + 1 if C >s SMIN
Craig Topper8ed1aa92017-10-03 05:31:07 +00002059 assert(!C.isMinSignedValue() && "Unexpected icmp slt");
2060 APInt ShiftedC = (C - 1).ashr(*ShiftAmt) + 1;
Sanjay Patel291c3d82017-01-19 16:12:10 +00002061 return new ICmpInst(Pred, X, ConstantInt::get(ShType, ShiftedC));
2062 }
2063 // If this is a signed comparison to 0 and the shift is sign preserving,
2064 // use the shift LHS operand instead; isSignTest may change 'Pred', so only
2065 // do that if we're sure to not continue on in this function.
Craig Topper8ed1aa92017-10-03 05:31:07 +00002066 if (isSignTest(Pred, C))
Sanjay Patel291c3d82017-01-19 16:12:10 +00002067 return new ICmpInst(Pred, X, Constant::getNullValue(ShType));
2068 }
Sanjay Patel14715b32017-01-17 21:25:16 +00002069
Sanjay Patel291c3d82017-01-19 16:12:10 +00002070 // NUW guarantees that we are only shifting out zero bits from the high bits,
2071 // so we can LSHR the compare constant without needing a mask and eliminate
2072 // the shift.
Sanjay Patel14715b32017-01-17 21:25:16 +00002073 if (Shl->hasNoUnsignedWrap()) {
Sanjay Patelae23d652017-01-18 21:16:12 +00002074 if (Pred == ICmpInst::ICMP_UGT) {
Sanjay Patel14715b32017-01-17 21:25:16 +00002075 // icmp Pred (shl nuw X, ShiftAmt), C --> icmp Pred X, (C >>u ShiftAmt)
Craig Topper8ed1aa92017-10-03 05:31:07 +00002076 APInt ShiftedC = C.lshr(*ShiftAmt);
Sanjay Patel14715b32017-01-17 21:25:16 +00002077 return new ICmpInst(Pred, X, ConstantInt::get(ShType, ShiftedC));
2078 }
Sanjay Patel6fb13572018-01-09 18:56:03 +00002079 if ((Pred == ICmpInst::ICMP_EQ || Pred == ICmpInst::ICMP_NE) &&
2080 C.lshr(*ShiftAmt).shl(*ShiftAmt) == C) {
Craig Topper8ed1aa92017-10-03 05:31:07 +00002081 APInt ShiftedC = C.lshr(*ShiftAmt);
Sanjay Patelae23d652017-01-18 21:16:12 +00002082 return new ICmpInst(Pred, X, ConstantInt::get(ShType, ShiftedC));
2083 }
Sanjay Patel14715b32017-01-17 21:25:16 +00002084 if (Pred == ICmpInst::ICMP_ULT) {
2085 // ULE is the same as above, but ULE is canonicalized to ULT, so convert:
2086 // (X << S) <=u C is equiv to X <=u (C >> S) for all C
2087 // (X << S) <u (C + 1) is equiv to X <u (C >> S) + 1 if C <u ~0u
2088 // (X << S) <u C is equiv to X <u ((C - 1) >> S) + 1 if C >u 0
Craig Topper8ed1aa92017-10-03 05:31:07 +00002089 assert(C.ugt(0) && "ult 0 should have been eliminated");
2090 APInt ShiftedC = (C - 1).lshr(*ShiftAmt) + 1;
Sanjay Patel14715b32017-01-17 21:25:16 +00002091 return new ICmpInst(Pred, X, ConstantInt::get(ShType, ShiftedC));
2092 }
2093 }
2094
Sanjay Patel291c3d82017-01-19 16:12:10 +00002095 if (Cmp.isEquality() && Shl->hasOneUse()) {
2096 // Strength-reduce the shift into an 'and'.
2097 Constant *Mask = ConstantInt::get(
2098 ShType,
2099 APInt::getLowBitsSet(TypeBits, TypeBits - ShiftAmt->getZExtValue()));
Craig Topperbb4069e2017-07-07 23:16:26 +00002100 Value *And = Builder.CreateAnd(X, Mask, Shl->getName() + ".mask");
Craig Topper8ed1aa92017-10-03 05:31:07 +00002101 Constant *LShrC = ConstantInt::get(ShType, C.lshr(*ShiftAmt));
Sanjay Patel291c3d82017-01-19 16:12:10 +00002102 return new ICmpInst(Pred, And, LShrC);
Sanjay Patela3f4f082016-08-16 17:54:36 +00002103 }
2104
Sanjay Patela3f4f082016-08-16 17:54:36 +00002105 // Otherwise, if this is a comparison of the sign bit, simplify to and/test.
2106 bool TrueIfSigned = false;
Craig Topper8ed1aa92017-10-03 05:31:07 +00002107 if (Shl->hasOneUse() && isSignBitCheck(Pred, C, TrueIfSigned)) {
Sanjay Patel7ffcde72016-08-21 16:35:34 +00002108 // (X << 31) <s 0 --> (X & 1) != 0
Sanjay Patela3f4f082016-08-16 17:54:36 +00002109 Constant *Mask = ConstantInt::get(
Sanjay Patel14715b32017-01-17 21:25:16 +00002110 ShType,
Sanjay Patelfa7de602016-08-19 22:33:26 +00002111 APInt::getOneBitSet(TypeBits, TypeBits - ShiftAmt->getZExtValue() - 1));
Craig Topperbb4069e2017-07-07 23:16:26 +00002112 Value *And = Builder.CreateAnd(X, Mask, Shl->getName() + ".mask");
Sanjay Patela3f4f082016-08-16 17:54:36 +00002113 return new ICmpInst(TrueIfSigned ? ICmpInst::ICMP_NE : ICmpInst::ICMP_EQ,
Sanjay Patel14715b32017-01-17 21:25:16 +00002114 And, Constant::getNullValue(ShType));
Sanjay Patelc0339c72016-11-01 19:19:29 +00002115 }
2116
Huihui Zhangb90cb572019-06-25 20:44:52 +00002117 // Simplify 'shl' inequality test into 'and' equality test.
2118 if (Cmp.isUnsigned() && Shl->hasOneUse()) {
2119 // (X l<< C2) u<=/u> C1 iff C1+1 is power of two -> X & (~C1 l>> C2) ==/!= 0
2120 if ((C + 1).isPowerOf2() &&
2121 (Pred == ICmpInst::ICMP_ULE || Pred == ICmpInst::ICMP_UGT)) {
2122 Value *And = Builder.CreateAnd(X, (~C).lshr(ShiftAmt->getZExtValue()));
2123 return new ICmpInst(Pred == ICmpInst::ICMP_ULE ? ICmpInst::ICMP_EQ
2124 : ICmpInst::ICMP_NE,
2125 And, Constant::getNullValue(ShType));
2126 }
2127 // (X l<< C2) u</u>= C1 iff C1 is power of two -> X & (-C1 l>> C2) ==/!= 0
2128 if (C.isPowerOf2() &&
2129 (Pred == ICmpInst::ICMP_ULT || Pred == ICmpInst::ICMP_UGE)) {
2130 Value *And =
2131 Builder.CreateAnd(X, (~(C - 1)).lshr(ShiftAmt->getZExtValue()));
2132 return new ICmpInst(Pred == ICmpInst::ICMP_ULT ? ICmpInst::ICMP_EQ
2133 : ICmpInst::ICMP_NE,
2134 And, Constant::getNullValue(ShType));
2135 }
2136 }
2137
Sanjay Patel643d21a2016-08-21 17:10:07 +00002138 // Transform (icmp pred iM (shl iM %v, N), C)
2139 // -> (icmp pred i(M-N) (trunc %v iM to i(M-N)), (trunc (C>>N))
2140 // Transform the shl to a trunc if (trunc (C>>N)) has no loss and M-N.
Sanjay Patel940c0612017-01-09 16:27:56 +00002141 // This enables us to get rid of the shift in favor of a trunc that may be
Sanjay Patela3f4f082016-08-16 17:54:36 +00002142 // free on the target. It has the additional benefit of comparing to a
Sanjay Patel940c0612017-01-09 16:27:56 +00002143 // smaller constant that may be more target-friendly.
Sanjay Patelfa7de602016-08-19 22:33:26 +00002144 unsigned Amt = ShiftAmt->getLimitedValue(TypeBits - 1);
Craig Topper8ed1aa92017-10-03 05:31:07 +00002145 if (Shl->hasOneUse() && Amt != 0 && C.countTrailingZeros() >= Amt &&
Sanjay Patelf3dda132016-10-25 20:11:47 +00002146 DL.isLegalInteger(TypeBits - Amt)) {
Sanjay Patel643d21a2016-08-21 17:10:07 +00002147 Type *TruncTy = IntegerType::get(Cmp.getContext(), TypeBits - Amt);
Sanjay Patel14715b32017-01-17 21:25:16 +00002148 if (ShType->isVectorTy())
2149 TruncTy = VectorType::get(TruncTy, ShType->getVectorNumElements());
Sanjay Patel643d21a2016-08-21 17:10:07 +00002150 Constant *NewC =
Craig Topper8ed1aa92017-10-03 05:31:07 +00002151 ConstantInt::get(TruncTy, C.ashr(*ShiftAmt).trunc(TypeBits - Amt));
Craig Topperbb4069e2017-07-07 23:16:26 +00002152 return new ICmpInst(Pred, Builder.CreateTrunc(X, TruncTy), NewC);
Sanjay Patela3f4f082016-08-16 17:54:36 +00002153 }
2154
2155 return nullptr;
2156}
2157
Sanjay Patela3920492016-08-22 20:45:06 +00002158/// Fold icmp ({al}shr X, Y), C.
Sanjay Patelc9196c42016-08-22 21:24:29 +00002159Instruction *InstCombiner::foldICmpShrConstant(ICmpInst &Cmp,
2160 BinaryOperator *Shr,
Craig Topper8ed1aa92017-10-03 05:31:07 +00002161 const APInt &C) {
Sanjay Patela3920492016-08-22 20:45:06 +00002162 // An exact shr only shifts out zero bits, so:
2163 // icmp eq/ne (shr X, Y), 0 --> icmp eq/ne X, 0
Sanjay Pateld64e9882016-08-23 22:05:55 +00002164 Value *X = Shr->getOperand(0);
Sanjay Patelc9196c42016-08-22 21:24:29 +00002165 CmpInst::Predicate Pred = Cmp.getPredicate();
Craig Topper73ba1c82017-06-07 07:40:37 +00002166 if (Cmp.isEquality() && Shr->isExact() && Shr->hasOneUse() &&
Craig Topper8ed1aa92017-10-03 05:31:07 +00002167 C.isNullValue())
Sanjay Pateld64e9882016-08-23 22:05:55 +00002168 return new ICmpInst(Pred, X, Cmp.getOperand(1));
Sanjay Patela3920492016-08-22 20:45:06 +00002169
Sanjay Patel8da42cc2016-09-15 22:26:31 +00002170 const APInt *ShiftVal;
2171 if (Cmp.isEquality() && match(Shr->getOperand(0), m_APInt(ShiftVal)))
Craig Topper8ed1aa92017-10-03 05:31:07 +00002172 return foldICmpShrConstConst(Cmp, Shr->getOperand(1), C, *ShiftVal);
Sanjay Patel8da42cc2016-09-15 22:26:31 +00002173
Sanjay Pateld398d4a2016-08-24 22:22:06 +00002174 const APInt *ShiftAmt;
2175 if (!match(Shr->getOperand(1), m_APInt(ShiftAmt)))
Sanjay Patela3f4f082016-08-16 17:54:36 +00002176 return nullptr;
2177
Sanjay Pateld398d4a2016-08-24 22:22:06 +00002178 // Check that the shift amount is in range. If not, don't perform undefined
2179 // shifts. When the shift is visited it will be simplified.
Craig Topper8ed1aa92017-10-03 05:31:07 +00002180 unsigned TypeBits = C.getBitWidth();
Sanjay Pateld398d4a2016-08-24 22:22:06 +00002181 unsigned ShAmtVal = ShiftAmt->getLimitedValue(TypeBits);
Sanjay Pateldcac0df2016-08-23 21:25:13 +00002182 if (ShAmtVal >= TypeBits || ShAmtVal == 0)
2183 return nullptr;
2184
Sanjay Pateld64e9882016-08-23 22:05:55 +00002185 bool IsAShr = Shr->getOpcode() == Instruction::AShr;
Sanjay Patel7ac2db62017-10-05 21:11:49 +00002186 bool IsExact = Shr->isExact();
2187 Type *ShrTy = Shr->getType();
2188 // TODO: If we could guarantee that InstSimplify would handle all of the
2189 // constant-value-based preconditions in the folds below, then we could assert
2190 // those conditions rather than checking them. This is difficult because of
2191 // undef/poison (PR34838).
2192 if (IsAShr) {
2193 if (Pred == CmpInst::ICMP_SLT || (Pred == CmpInst::ICMP_SGT && IsExact)) {
2194 // icmp slt (ashr X, ShAmtC), C --> icmp slt X, (C << ShAmtC)
2195 // icmp sgt (ashr exact X, ShAmtC), C --> icmp sgt X, (C << ShAmtC)
2196 APInt ShiftedC = C.shl(ShAmtVal);
2197 if (ShiftedC.ashr(ShAmtVal) == C)
2198 return new ICmpInst(Pred, X, ConstantInt::get(ShrTy, ShiftedC));
2199 }
2200 if (Pred == CmpInst::ICMP_SGT) {
2201 // icmp sgt (ashr X, ShAmtC), C --> icmp sgt X, ((C + 1) << ShAmtC) - 1
2202 APInt ShiftedC = (C + 1).shl(ShAmtVal) - 1;
2203 if (!C.isMaxSignedValue() && !(C + 1).shl(ShAmtVal).isMinSignedValue() &&
2204 (ShiftedC + 1).ashr(ShAmtVal) == (C + 1))
2205 return new ICmpInst(Pred, X, ConstantInt::get(ShrTy, ShiftedC));
2206 }
2207 } else {
2208 if (Pred == CmpInst::ICMP_ULT || (Pred == CmpInst::ICMP_UGT && IsExact)) {
2209 // icmp ult (lshr X, ShAmtC), C --> icmp ult X, (C << ShAmtC)
2210 // icmp ugt (lshr exact X, ShAmtC), C --> icmp ugt X, (C << ShAmtC)
2211 APInt ShiftedC = C.shl(ShAmtVal);
2212 if (ShiftedC.lshr(ShAmtVal) == C)
2213 return new ICmpInst(Pred, X, ConstantInt::get(ShrTy, ShiftedC));
2214 }
2215 if (Pred == CmpInst::ICMP_UGT) {
2216 // icmp ugt (lshr X, ShAmtC), C --> icmp ugt X, ((C + 1) << ShAmtC) - 1
2217 APInt ShiftedC = (C + 1).shl(ShAmtVal) - 1;
2218 if ((ShiftedC + 1).lshr(ShAmtVal) == (C + 1))
2219 return new ICmpInst(Pred, X, ConstantInt::get(ShrTy, ShiftedC));
2220 }
Sanjay Pateldcac0df2016-08-23 21:25:13 +00002221 }
2222
Sanjay Patel7ac2db62017-10-05 21:11:49 +00002223 if (!Cmp.isEquality())
2224 return nullptr;
2225
Sanjay Pateld398d4a2016-08-24 22:22:06 +00002226 // Handle equality comparisons of shift-by-constant.
2227
Sanjay Patel8e297742016-08-24 13:55:55 +00002228 // If the comparison constant changes with the shift, the comparison cannot
2229 // succeed (bits of the comparison constant cannot match the shifted value).
2230 // This should be known by InstSimplify and already be folded to true/false.
Craig Topper8ed1aa92017-10-03 05:31:07 +00002231 assert(((IsAShr && C.shl(ShAmtVal).ashr(ShAmtVal) == C) ||
2232 (!IsAShr && C.shl(ShAmtVal).lshr(ShAmtVal) == C)) &&
Sanjay Patel8e297742016-08-24 13:55:55 +00002233 "Expected icmp+shr simplify did not occur.");
2234
Sanjay Patel934738a2017-10-15 15:39:15 +00002235 // If the bits shifted out are known zero, compare the unshifted value:
Sanjay Pateldcac0df2016-08-23 21:25:13 +00002236 // (X & 4) >> 1 == 2 --> (X & 4) == 4.
Sanjay Patel934738a2017-10-15 15:39:15 +00002237 if (Shr->isExact())
Sanjay Patel42135be2017-10-16 14:47:24 +00002238 return new ICmpInst(Pred, X, ConstantInt::get(ShrTy, C << ShAmtVal));
Sanjay Patelf11b5b42017-10-05 14:26:15 +00002239
Sanjay Patel934738a2017-10-15 15:39:15 +00002240 if (Shr->hasOneUse()) {
2241 // Canonicalize the shift into an 'and':
2242 // icmp eq/ne (shr X, ShAmt), C --> icmp eq/ne (and X, HiMask), (C << ShAmt)
Sanjay Pateld398d4a2016-08-24 22:22:06 +00002243 APInt Val(APInt::getHighBitsSet(TypeBits, TypeBits - ShAmtVal));
Sanjay Patel7ac2db62017-10-05 21:11:49 +00002244 Constant *Mask = ConstantInt::get(ShrTy, Val);
Craig Topperbb4069e2017-07-07 23:16:26 +00002245 Value *And = Builder.CreateAnd(X, Mask, Shr->getName() + ".mask");
Sanjay Patel42135be2017-10-16 14:47:24 +00002246 return new ICmpInst(Pred, And, ConstantInt::get(ShrTy, C << ShAmtVal));
Sanjay Pateldcac0df2016-08-23 21:25:13 +00002247 }
Sanjay Patela3f4f082016-08-16 17:54:36 +00002248
2249 return nullptr;
2250}
2251
Sanjay Patel12a41052016-08-18 17:37:26 +00002252/// Fold icmp (udiv X, Y), C.
2253Instruction *InstCombiner::foldICmpUDivConstant(ICmpInst &Cmp,
Sanjay Patelc9196c42016-08-22 21:24:29 +00002254 BinaryOperator *UDiv,
Craig Topper8ed1aa92017-10-03 05:31:07 +00002255 const APInt &C) {
Sanjay Patelfa5ca2b2016-08-18 17:55:59 +00002256 const APInt *C2;
2257 if (!match(UDiv->getOperand(0), m_APInt(C2)))
2258 return nullptr;
2259
Craig Topper29c282e2017-06-07 07:40:29 +00002260 assert(*C2 != 0 && "udiv 0, X should have been simplified already.");
Sanjay Patelfa5ca2b2016-08-18 17:55:59 +00002261
2262 // (icmp ugt (udiv C2, Y), C) -> (icmp ule Y, C2/(C+1))
2263 Value *Y = UDiv->getOperand(1);
2264 if (Cmp.getPredicate() == ICmpInst::ICMP_UGT) {
Craig Topper8ed1aa92017-10-03 05:31:07 +00002265 assert(!C.isMaxValue() &&
Sanjay Patelfa5ca2b2016-08-18 17:55:59 +00002266 "icmp ugt X, UINT_MAX should have been simplified already.");
2267 return new ICmpInst(ICmpInst::ICMP_ULE, Y,
Craig Topper8ed1aa92017-10-03 05:31:07 +00002268 ConstantInt::get(Y->getType(), C2->udiv(C + 1)));
Sanjay Patelfa5ca2b2016-08-18 17:55:59 +00002269 }
2270
2271 // (icmp ult (udiv C2, Y), C) -> (icmp ugt Y, C2/C)
2272 if (Cmp.getPredicate() == ICmpInst::ICMP_ULT) {
Craig Topper8ed1aa92017-10-03 05:31:07 +00002273 assert(C != 0 && "icmp ult X, 0 should have been simplified already.");
Sanjay Patelfa5ca2b2016-08-18 17:55:59 +00002274 return new ICmpInst(ICmpInst::ICMP_UGT, Y,
Craig Topper8ed1aa92017-10-03 05:31:07 +00002275 ConstantInt::get(Y->getType(), C2->udiv(C)));
Sanjay Patela3f4f082016-08-16 17:54:36 +00002276 }
2277
2278 return nullptr;
2279}
2280
Sanjay Patelf7ba0892016-08-26 15:53:01 +00002281/// Fold icmp ({su}div X, Y), C.
2282Instruction *InstCombiner::foldICmpDivConstant(ICmpInst &Cmp,
2283 BinaryOperator *Div,
Craig Topper8ed1aa92017-10-03 05:31:07 +00002284 const APInt &C) {
Sanjay Patela7cb4772016-08-30 17:10:49 +00002285 // Fold: icmp pred ([us]div X, C2), C -> range test
Sanjay Patela3f4f082016-08-16 17:54:36 +00002286 // Fold this div into the comparison, producing a range check.
2287 // Determine, based on the divide type, what the range is being
2288 // checked. If there is an overflow on the low or high side, remember
2289 // it, otherwise compute the range [low, hi) bounding the new value.
2290 // See: InsertRangeTest above for the kinds of replacements possible.
Sanjay Patela7cb4772016-08-30 17:10:49 +00002291 const APInt *C2;
2292 if (!match(Div->getOperand(1), m_APInt(C2)))
Sanjay Patel16554142016-08-24 23:03:36 +00002293 return nullptr;
2294
Sanjay Patel16554142016-08-24 23:03:36 +00002295 // FIXME: If the operand types don't match the type of the divide
2296 // then don't attempt this transform. The code below doesn't have the
2297 // logic to deal with a signed divide and an unsigned compare (and
Sanjay Patela7cb4772016-08-30 17:10:49 +00002298 // vice versa). This is because (x /s C2) <s C produces different
2299 // results than (x /s C2) <u C or (x /u C2) <s C or even
2300 // (x /u C2) <u C. Simply casting the operands and result won't
Sanjay Patel16554142016-08-24 23:03:36 +00002301 // work. :( The if statement below tests that condition and bails
2302 // if it finds it.
Sanjay Patelf7ba0892016-08-26 15:53:01 +00002303 bool DivIsSigned = Div->getOpcode() == Instruction::SDiv;
2304 if (!Cmp.isEquality() && DivIsSigned != Cmp.isSigned())
Sanjay Patel16554142016-08-24 23:03:36 +00002305 return nullptr;
Sanjay Patela7cb4772016-08-30 17:10:49 +00002306
Sanjay Pateleea2ef72016-09-05 23:38:22 +00002307 // The ProdOV computation fails on divide by 0 and divide by -1. Cases with
2308 // INT_MIN will also fail if the divisor is 1. Although folds of all these
2309 // division-by-constant cases should be present, we can not assert that they
2310 // have happened before we reach this icmp instruction.
Craig Topper73ba1c82017-06-07 07:40:37 +00002311 if (C2->isNullValue() || C2->isOneValue() ||
2312 (DivIsSigned && C2->isAllOnesValue()))
Sanjay Pateleea2ef72016-09-05 23:38:22 +00002313 return nullptr;
Sanjay Patelb3714572016-08-30 17:31:34 +00002314
Craig Topper6e025a32017-10-01 23:53:54 +00002315 // Compute Prod = C * C2. We are essentially solving an equation of
2316 // form X / C2 = C. We solve for X by multiplying C2 and C.
Sanjay Patel541aef42016-08-31 21:57:21 +00002317 // By solving for X, we can turn this into a range check instead of computing
2318 // a divide.
Craig Topper8ed1aa92017-10-03 05:31:07 +00002319 APInt Prod = C * *C2;
Sanjay Patel16554142016-08-24 23:03:36 +00002320
Sanjay Patel541aef42016-08-31 21:57:21 +00002321 // Determine if the product overflows by seeing if the product is not equal to
2322 // the divide. Make sure we do the same kind of divide as in the LHS
2323 // instruction that we're folding.
Craig Topper8ed1aa92017-10-03 05:31:07 +00002324 bool ProdOV = (DivIsSigned ? Prod.sdiv(*C2) : Prod.udiv(*C2)) != C;
Sanjay Patel16554142016-08-24 23:03:36 +00002325
Sanjay Patelf7ba0892016-08-26 15:53:01 +00002326 ICmpInst::Predicate Pred = Cmp.getPredicate();
Sanjay Patel16554142016-08-24 23:03:36 +00002327
2328 // If the division is known to be exact, then there is no remainder from the
2329 // divide, so the covered range size is unit, otherwise it is the divisor.
Craig Topper6e025a32017-10-01 23:53:54 +00002330 APInt RangeSize = Div->isExact() ? APInt(C2->getBitWidth(), 1) : *C2;
Sanjay Patel16554142016-08-24 23:03:36 +00002331
2332 // Figure out the interval that is being checked. For example, a comparison
2333 // like "X /u 5 == 0" is really checking that X is in the interval [0, 5).
2334 // Compute this interval based on the constants involved and the signedness of
2335 // the compare/divide. This computes a half-open interval, keeping track of
2336 // whether either value in the interval overflows. After analysis each
2337 // overflow variable is set to 0 if it's corresponding bound variable is valid
2338 // -1 if overflowed off the bottom end, or +1 if overflowed off the top end.
2339 int LoOverflow = 0, HiOverflow = 0;
Craig Topper6e025a32017-10-01 23:53:54 +00002340 APInt LoBound, HiBound;
Sanjay Patel16554142016-08-24 23:03:36 +00002341
2342 if (!DivIsSigned) { // udiv
2343 // e.g. X/5 op 3 --> [15, 20)
2344 LoBound = Prod;
2345 HiOverflow = LoOverflow = ProdOV;
2346 if (!HiOverflow) {
2347 // If this is not an exact divide, then many values in the range collapse
2348 // to the same result value.
Sanjay Pateld93c4c02016-09-15 18:22:25 +00002349 HiOverflow = addWithOverflow(HiBound, LoBound, RangeSize, false);
Sanjay Patel16554142016-08-24 23:03:36 +00002350 }
Sanjay Patel541aef42016-08-31 21:57:21 +00002351 } else if (C2->isStrictlyPositive()) { // Divisor is > 0.
Craig Topper8ed1aa92017-10-03 05:31:07 +00002352 if (C.isNullValue()) { // (X / pos) op 0
Sanjay Patel16554142016-08-24 23:03:36 +00002353 // Can't overflow. e.g. X/2 op 0 --> [-1, 2)
Craig Topper6e025a32017-10-01 23:53:54 +00002354 LoBound = -(RangeSize - 1);
Sanjay Patel16554142016-08-24 23:03:36 +00002355 HiBound = RangeSize;
Craig Topper8ed1aa92017-10-03 05:31:07 +00002356 } else if (C.isStrictlyPositive()) { // (X / pos) op pos
Sanjay Patel16554142016-08-24 23:03:36 +00002357 LoBound = Prod; // e.g. X/5 op 3 --> [15, 20)
2358 HiOverflow = LoOverflow = ProdOV;
2359 if (!HiOverflow)
Sanjay Pateld93c4c02016-09-15 18:22:25 +00002360 HiOverflow = addWithOverflow(HiBound, Prod, RangeSize, true);
Sanjay Patel16554142016-08-24 23:03:36 +00002361 } else { // (X / pos) op neg
2362 // e.g. X/5 op -3 --> [-15-4, -15+1) --> [-19, -14)
Craig Topper6e025a32017-10-01 23:53:54 +00002363 HiBound = Prod + 1;
Sanjay Patel16554142016-08-24 23:03:36 +00002364 LoOverflow = HiOverflow = ProdOV ? -1 : 0;
2365 if (!LoOverflow) {
Craig Topper6e025a32017-10-01 23:53:54 +00002366 APInt DivNeg = -RangeSize;
Sanjay Pateld93c4c02016-09-15 18:22:25 +00002367 LoOverflow = addWithOverflow(LoBound, HiBound, DivNeg, true) ? -1 : 0;
Sanjay Patel16554142016-08-24 23:03:36 +00002368 }
2369 }
Sanjay Patel541aef42016-08-31 21:57:21 +00002370 } else if (C2->isNegative()) { // Divisor is < 0.
Sanjay Patelf7ba0892016-08-26 15:53:01 +00002371 if (Div->isExact())
Craig Topper6e025a32017-10-01 23:53:54 +00002372 RangeSize.negate();
Craig Topper8ed1aa92017-10-03 05:31:07 +00002373 if (C.isNullValue()) { // (X / neg) op 0
Sanjay Patel16554142016-08-24 23:03:36 +00002374 // e.g. X/-5 op 0 --> [-4, 5)
Craig Topper6e025a32017-10-01 23:53:54 +00002375 LoBound = RangeSize + 1;
2376 HiBound = -RangeSize;
2377 if (HiBound == *C2) { // -INTMIN = INTMIN
Sanjay Patel16554142016-08-24 23:03:36 +00002378 HiOverflow = 1; // [INTMIN+1, overflow)
Craig Topper6e025a32017-10-01 23:53:54 +00002379 HiBound = APInt(); // e.g. X/INTMIN = 0 --> X > INTMIN
Sanjay Patel16554142016-08-24 23:03:36 +00002380 }
Craig Topper8ed1aa92017-10-03 05:31:07 +00002381 } else if (C.isStrictlyPositive()) { // (X / neg) op pos
Sanjay Patel16554142016-08-24 23:03:36 +00002382 // e.g. X/-5 op 3 --> [-19, -14)
Craig Topper6e025a32017-10-01 23:53:54 +00002383 HiBound = Prod + 1;
Sanjay Patel16554142016-08-24 23:03:36 +00002384 HiOverflow = LoOverflow = ProdOV ? -1 : 0;
2385 if (!LoOverflow)
Sanjay Pateld93c4c02016-09-15 18:22:25 +00002386 LoOverflow = addWithOverflow(LoBound, HiBound, RangeSize, true) ? -1:0;
Sanjay Patel16554142016-08-24 23:03:36 +00002387 } else { // (X / neg) op neg
2388 LoBound = Prod; // e.g. X/-5 op -3 --> [15, 20)
2389 LoOverflow = HiOverflow = ProdOV;
2390 if (!HiOverflow)
Sanjay Pateld93c4c02016-09-15 18:22:25 +00002391 HiOverflow = subWithOverflow(HiBound, Prod, RangeSize, true);
Sanjay Patel16554142016-08-24 23:03:36 +00002392 }
2393
2394 // Dividing by a negative swaps the condition. LT <-> GT
2395 Pred = ICmpInst::getSwappedPredicate(Pred);
2396 }
2397
Sanjay Patelf7ba0892016-08-26 15:53:01 +00002398 Value *X = Div->getOperand(0);
Sanjay Patel16554142016-08-24 23:03:36 +00002399 switch (Pred) {
2400 default: llvm_unreachable("Unhandled icmp opcode!");
2401 case ICmpInst::ICMP_EQ:
2402 if (LoOverflow && HiOverflow)
Craig Topperbb4069e2017-07-07 23:16:26 +00002403 return replaceInstUsesWith(Cmp, Builder.getFalse());
Sanjay Patel16554142016-08-24 23:03:36 +00002404 if (HiOverflow)
2405 return new ICmpInst(DivIsSigned ? ICmpInst::ICMP_SGE :
Craig Topper6e025a32017-10-01 23:53:54 +00002406 ICmpInst::ICMP_UGE, X,
2407 ConstantInt::get(Div->getType(), LoBound));
Sanjay Patel16554142016-08-24 23:03:36 +00002408 if (LoOverflow)
2409 return new ICmpInst(DivIsSigned ? ICmpInst::ICMP_SLT :
Craig Topper6e025a32017-10-01 23:53:54 +00002410 ICmpInst::ICMP_ULT, X,
2411 ConstantInt::get(Div->getType(), HiBound));
Sanjay Patel85d79742016-08-31 19:49:56 +00002412 return replaceInstUsesWith(
Craig Topper6e025a32017-10-01 23:53:54 +00002413 Cmp, insertRangeTest(X, LoBound, HiBound, DivIsSigned, true));
Sanjay Patel16554142016-08-24 23:03:36 +00002414 case ICmpInst::ICMP_NE:
2415 if (LoOverflow && HiOverflow)
Craig Topperbb4069e2017-07-07 23:16:26 +00002416 return replaceInstUsesWith(Cmp, Builder.getTrue());
Sanjay Patel16554142016-08-24 23:03:36 +00002417 if (HiOverflow)
2418 return new ICmpInst(DivIsSigned ? ICmpInst::ICMP_SLT :
Craig Topper6e025a32017-10-01 23:53:54 +00002419 ICmpInst::ICMP_ULT, X,
2420 ConstantInt::get(Div->getType(), LoBound));
Sanjay Patel16554142016-08-24 23:03:36 +00002421 if (LoOverflow)
2422 return new ICmpInst(DivIsSigned ? ICmpInst::ICMP_SGE :
Craig Topper6e025a32017-10-01 23:53:54 +00002423 ICmpInst::ICMP_UGE, X,
2424 ConstantInt::get(Div->getType(), HiBound));
Sanjay Patel541aef42016-08-31 21:57:21 +00002425 return replaceInstUsesWith(Cmp,
Craig Topper6e025a32017-10-01 23:53:54 +00002426 insertRangeTest(X, LoBound, HiBound,
Sanjay Patel541aef42016-08-31 21:57:21 +00002427 DivIsSigned, false));
Sanjay Patel16554142016-08-24 23:03:36 +00002428 case ICmpInst::ICMP_ULT:
2429 case ICmpInst::ICMP_SLT:
2430 if (LoOverflow == +1) // Low bound is greater than input range.
Craig Topperbb4069e2017-07-07 23:16:26 +00002431 return replaceInstUsesWith(Cmp, Builder.getTrue());
Sanjay Patel16554142016-08-24 23:03:36 +00002432 if (LoOverflow == -1) // Low bound is less than input range.
Craig Topperbb4069e2017-07-07 23:16:26 +00002433 return replaceInstUsesWith(Cmp, Builder.getFalse());
Craig Topper6e025a32017-10-01 23:53:54 +00002434 return new ICmpInst(Pred, X, ConstantInt::get(Div->getType(), LoBound));
Sanjay Patel16554142016-08-24 23:03:36 +00002435 case ICmpInst::ICMP_UGT:
2436 case ICmpInst::ICMP_SGT:
2437 if (HiOverflow == +1) // High bound greater than input range.
Craig Topperbb4069e2017-07-07 23:16:26 +00002438 return replaceInstUsesWith(Cmp, Builder.getFalse());
Sanjay Patel16554142016-08-24 23:03:36 +00002439 if (HiOverflow == -1) // High bound less than input range.
Craig Topperbb4069e2017-07-07 23:16:26 +00002440 return replaceInstUsesWith(Cmp, Builder.getTrue());
Sanjay Patel16554142016-08-24 23:03:36 +00002441 if (Pred == ICmpInst::ICMP_UGT)
Craig Topper6e025a32017-10-01 23:53:54 +00002442 return new ICmpInst(ICmpInst::ICMP_UGE, X,
2443 ConstantInt::get(Div->getType(), HiBound));
2444 return new ICmpInst(ICmpInst::ICMP_SGE, X,
2445 ConstantInt::get(Div->getType(), HiBound));
Sanjay Patel16554142016-08-24 23:03:36 +00002446 }
Sanjay Patela3f4f082016-08-16 17:54:36 +00002447
2448 return nullptr;
2449}
2450
Sanjay Patelb9aa67b2016-08-16 21:26:10 +00002451/// Fold icmp (sub X, Y), C.
Sanjay Patelc9196c42016-08-22 21:24:29 +00002452Instruction *InstCombiner::foldICmpSubConstant(ICmpInst &Cmp,
2453 BinaryOperator *Sub,
Craig Topper8ed1aa92017-10-03 05:31:07 +00002454 const APInt &C) {
Sanjay Patel886a5422016-09-15 18:05:17 +00002455 Value *X = Sub->getOperand(0), *Y = Sub->getOperand(1);
2456 ICmpInst::Predicate Pred = Cmp.getPredicate();
Luqman Aden8911c5b2019-04-04 07:08:30 +00002457 const APInt *C2;
2458 APInt SubResult;
2459
Philip Reames764b0fd2019-08-21 15:51:57 +00002460 // icmp eq/ne (sub C, Y), C -> icmp eq/ne Y, 0
2461 if (match(X, m_APInt(C2)) && *C2 == C && Cmp.isEquality())
2462 return new ICmpInst(Cmp.getPredicate(), Y,
2463 ConstantInt::get(Y->getType(), 0));
2464
Luqman Aden8911c5b2019-04-04 07:08:30 +00002465 // (icmp P (sub nuw|nsw C2, Y), C) -> (icmp swap(P) Y, C2-C)
2466 if (match(X, m_APInt(C2)) &&
2467 ((Cmp.isUnsigned() && Sub->hasNoUnsignedWrap()) ||
2468 (Cmp.isSigned() && Sub->hasNoSignedWrap())) &&
2469 !subWithOverflow(SubResult, *C2, C, Cmp.isSigned()))
2470 return new ICmpInst(Cmp.getSwappedPredicate(), Y,
2471 ConstantInt::get(Y->getType(), SubResult));
Sanjay Patel886a5422016-09-15 18:05:17 +00002472
2473 // The following transforms are only worth it if the only user of the subtract
2474 // is the icmp.
2475 if (!Sub->hasOneUse())
Sanjay Patela3f4f082016-08-16 17:54:36 +00002476 return nullptr;
2477
Sanjay Patel886a5422016-09-15 18:05:17 +00002478 if (Sub->hasNoSignedWrap()) {
2479 // (icmp sgt (sub nsw X, Y), -1) -> (icmp sge X, Y)
Craig Topper8ed1aa92017-10-03 05:31:07 +00002480 if (Pred == ICmpInst::ICMP_SGT && C.isAllOnesValue())
Sanjay Patel886a5422016-09-15 18:05:17 +00002481 return new ICmpInst(ICmpInst::ICMP_SGE, X, Y);
Sanjay Patela3f4f082016-08-16 17:54:36 +00002482
Sanjay Patel886a5422016-09-15 18:05:17 +00002483 // (icmp sgt (sub nsw X, Y), 0) -> (icmp sgt X, Y)
Craig Topper8ed1aa92017-10-03 05:31:07 +00002484 if (Pred == ICmpInst::ICMP_SGT && C.isNullValue())
Sanjay Patel886a5422016-09-15 18:05:17 +00002485 return new ICmpInst(ICmpInst::ICMP_SGT, X, Y);
2486
2487 // (icmp slt (sub nsw X, Y), 0) -> (icmp slt X, Y)
Craig Topper8ed1aa92017-10-03 05:31:07 +00002488 if (Pred == ICmpInst::ICMP_SLT && C.isNullValue())
Sanjay Patel886a5422016-09-15 18:05:17 +00002489 return new ICmpInst(ICmpInst::ICMP_SLT, X, Y);
2490
2491 // (icmp slt (sub nsw X, Y), 1) -> (icmp sle X, Y)
Craig Topper8ed1aa92017-10-03 05:31:07 +00002492 if (Pred == ICmpInst::ICMP_SLT && C.isOneValue())
Sanjay Patel886a5422016-09-15 18:05:17 +00002493 return new ICmpInst(ICmpInst::ICMP_SLE, X, Y);
2494 }
2495
Sanjay Patel886a5422016-09-15 18:05:17 +00002496 if (!match(X, m_APInt(C2)))
2497 return nullptr;
2498
2499 // C2 - Y <u C -> (Y | (C - 1)) == C2
2500 // iff (C2 & (C - 1)) == C - 1 and C is a power of 2
Craig Topper8ed1aa92017-10-03 05:31:07 +00002501 if (Pred == ICmpInst::ICMP_ULT && C.isPowerOf2() &&
2502 (*C2 & (C - 1)) == (C - 1))
2503 return new ICmpInst(ICmpInst::ICMP_EQ, Builder.CreateOr(Y, C - 1), X);
Sanjay Patel886a5422016-09-15 18:05:17 +00002504
2505 // C2 - Y >u C -> (Y | C) != C2
2506 // iff C2 & C == C and C + 1 is a power of 2
Craig Topper8ed1aa92017-10-03 05:31:07 +00002507 if (Pred == ICmpInst::ICMP_UGT && (C + 1).isPowerOf2() && (*C2 & C) == C)
2508 return new ICmpInst(ICmpInst::ICMP_NE, Builder.CreateOr(Y, C), X);
Sanjay Patela3f4f082016-08-16 17:54:36 +00002509
2510 return nullptr;
2511}
2512
Sanjay Patel60ea1b42016-08-16 22:34:42 +00002513/// Fold icmp (add X, Y), C.
Sanjay Patelc9196c42016-08-22 21:24:29 +00002514Instruction *InstCombiner::foldICmpAddConstant(ICmpInst &Cmp,
2515 BinaryOperator *Add,
Craig Topper8ed1aa92017-10-03 05:31:07 +00002516 const APInt &C) {
Sanjay Patel4f7eb2a2016-08-17 15:24:30 +00002517 Value *Y = Add->getOperand(1);
2518 const APInt *C2;
2519 if (Cmp.isEquality() || !match(Y, m_APInt(C2)))
Sanjay Patela3f4f082016-08-16 17:54:36 +00002520 return nullptr;
2521
Sanjay Patel4f7eb2a2016-08-17 15:24:30 +00002522 // Fold icmp pred (add X, C2), C.
Sanjay Patel60ea1b42016-08-16 22:34:42 +00002523 Value *X = Add->getOperand(0);
Sanjay Patel4f7eb2a2016-08-17 15:24:30 +00002524 Type *Ty = Add->getType();
Sanjay Patel6dd2eae2017-02-08 16:19:36 +00002525 CmpInst::Predicate Pred = Cmp.getPredicate();
Sanjay Patel45b7e692017-02-12 16:40:30 +00002526
Tim Northover12c1f762018-09-10 14:26:44 +00002527 if (!Add->hasOneUse())
2528 return nullptr;
2529
Sanjay Patel45b7e692017-02-12 16:40:30 +00002530 // If the add does not wrap, we can always adjust the compare by subtracting
Nicola Zaghen9588ad92018-09-04 10:29:48 +00002531 // the constants. Equality comparisons are handled elsewhere. SGE/SLE/UGE/ULE
2532 // are canonicalized to SGT/SLT/UGT/ULT.
2533 if ((Add->hasNoSignedWrap() &&
2534 (Pred == ICmpInst::ICMP_SGT || Pred == ICmpInst::ICMP_SLT)) ||
2535 (Add->hasNoUnsignedWrap() &&
2536 (Pred == ICmpInst::ICMP_UGT || Pred == ICmpInst::ICMP_ULT))) {
Sanjay Patel45b7e692017-02-12 16:40:30 +00002537 bool Overflow;
Nicola Zaghen9588ad92018-09-04 10:29:48 +00002538 APInt NewC =
2539 Cmp.isSigned() ? C.ssub_ov(*C2, Overflow) : C.usub_ov(*C2, Overflow);
Sanjay Patel45b7e692017-02-12 16:40:30 +00002540 // If there is overflow, the result must be true or false.
2541 // TODO: Can we assert there is no overflow because InstSimplify always
2542 // handles those cases?
2543 if (!Overflow)
2544 // icmp Pred (add nsw X, C2), C --> icmp Pred X, (C - C2)
2545 return new ICmpInst(Pred, X, ConstantInt::get(Ty, NewC));
2546 }
2547
Craig Topper8ed1aa92017-10-03 05:31:07 +00002548 auto CR = ConstantRange::makeExactICmpRegion(Pred, C).subtract(*C2);
Sanjay Patel60ea1b42016-08-16 22:34:42 +00002549 const APInt &Upper = CR.getUpper();
2550 const APInt &Lower = CR.getLower();
2551 if (Cmp.isSigned()) {
Craig Topperbcfd2d12017-04-20 16:56:25 +00002552 if (Lower.isSignMask())
Sanjay Patel4f7eb2a2016-08-17 15:24:30 +00002553 return new ICmpInst(ICmpInst::ICMP_SLT, X, ConstantInt::get(Ty, Upper));
Craig Topperbcfd2d12017-04-20 16:56:25 +00002554 if (Upper.isSignMask())
Sanjay Patel4f7eb2a2016-08-17 15:24:30 +00002555 return new ICmpInst(ICmpInst::ICMP_SGE, X, ConstantInt::get(Ty, Lower));
Sanjay Patel60ea1b42016-08-16 22:34:42 +00002556 } else {
2557 if (Lower.isMinValue())
Sanjay Patel4f7eb2a2016-08-17 15:24:30 +00002558 return new ICmpInst(ICmpInst::ICMP_ULT, X, ConstantInt::get(Ty, Upper));
Sanjay Patel60ea1b42016-08-16 22:34:42 +00002559 if (Upper.isMinValue())
Sanjay Patel4f7eb2a2016-08-17 15:24:30 +00002560 return new ICmpInst(ICmpInst::ICMP_UGE, X, ConstantInt::get(Ty, Lower));
Sanjay Patel60ea1b42016-08-16 22:34:42 +00002561 }
Sanjay Patela3f4f082016-08-16 17:54:36 +00002562
Sanjay Patel4f7eb2a2016-08-17 15:24:30 +00002563 // X+C <u C2 -> (X & -C2) == C
2564 // iff C & (C2-1) == 0
2565 // C2 is a power of 2
Craig Topper8ed1aa92017-10-03 05:31:07 +00002566 if (Pred == ICmpInst::ICMP_ULT && C.isPowerOf2() && (*C2 & (C - 1)) == 0)
2567 return new ICmpInst(ICmpInst::ICMP_EQ, Builder.CreateAnd(X, -C),
Sanjay Patel4f7eb2a2016-08-17 15:24:30 +00002568 ConstantExpr::getNeg(cast<Constant>(Y)));
2569
2570 // X+C >u C2 -> (X & ~C2) != C
2571 // iff C & C2 == 0
2572 // C2+1 is a power of 2
Craig Topper8ed1aa92017-10-03 05:31:07 +00002573 if (Pred == ICmpInst::ICMP_UGT && (C + 1).isPowerOf2() && (*C2 & C) == 0)
2574 return new ICmpInst(ICmpInst::ICMP_NE, Builder.CreateAnd(X, ~C),
Sanjay Patel4f7eb2a2016-08-17 15:24:30 +00002575 ConstantExpr::getNeg(cast<Constant>(Y)));
2576
Sanjay Patela3f4f082016-08-16 17:54:36 +00002577 return nullptr;
2578}
2579
Anna Thomasd67165c2017-06-23 13:41:45 +00002580bool InstCombiner::matchThreeWayIntCompare(SelectInst *SI, Value *&LHS,
2581 Value *&RHS, ConstantInt *&Less,
2582 ConstantInt *&Equal,
2583 ConstantInt *&Greater) {
2584 // TODO: Generalize this to work with other comparison idioms or ensure
2585 // they get canonicalized into this form.
2586
Roman Lebedevde19f742019-08-24 06:49:36 +00002587 // select i1 (a == b),
2588 // i32 Equal,
2589 // i32 (select i1 (a < b), i32 Less, i32 Greater)
2590 // where Equal, Less and Greater are placeholders for any three constants.
2591 ICmpInst::Predicate PredA;
2592 if (!match(SI->getCondition(), m_ICmp(PredA, m_Value(LHS), m_Value(RHS))) ||
2593 !ICmpInst::isEquality(PredA))
2594 return false;
2595 Value *EqualVal = SI->getTrueValue();
2596 Value *UnequalVal = SI->getFalseValue();
2597 // We still can get non-canonical predicate here, so canonicalize.
2598 if (PredA == ICmpInst::ICMP_NE)
2599 std::swap(EqualVal, UnequalVal);
2600 if (!match(EqualVal, m_ConstantInt(Equal)))
2601 return false;
2602 ICmpInst::Predicate PredB;
2603 Value *LHS2, *RHS2;
2604 if (!match(UnequalVal, m_Select(m_ICmp(PredB, m_Value(LHS2), m_Value(RHS2)),
2605 m_ConstantInt(Less), m_ConstantInt(Greater))))
2606 return false;
2607 // We can get predicate mismatch here, so canonicalize if possible:
2608 // First, ensure that 'LHS' match.
2609 if (LHS2 != LHS) {
2610 // x sgt y <--> y slt x
2611 std::swap(LHS2, RHS2);
2612 PredB = ICmpInst::getSwappedPredicate(PredB);
Anna Thomasd67165c2017-06-23 13:41:45 +00002613 }
Roman Lebedevde19f742019-08-24 06:49:36 +00002614 if (LHS2 != LHS)
2615 return false;
2616 // We also need to canonicalize 'RHS'.
2617 if (PredB == ICmpInst::ICMP_SGT && isa<Constant>(RHS2)) {
2618 // x sgt C-1 <--> x sge C <--> not(x slt C)
2619 auto FlippedStrictness =
2620 getFlippedStrictnessPredicateAndConstant(PredB, cast<Constant>(RHS2));
2621 if (!FlippedStrictness)
2622 return false;
2623 assert(FlippedStrictness->first == ICmpInst::ICMP_SGE && "Sanity check");
2624 RHS2 = FlippedStrictness->second;
2625 // And kind-of perform the result swap.
2626 std::swap(Less, Greater);
2627 PredB = ICmpInst::ICMP_SLT;
2628 }
2629 return PredB == ICmpInst::ICMP_SLT && RHS == RHS2;
Anna Thomasd67165c2017-06-23 13:41:45 +00002630}
2631
2632Instruction *InstCombiner::foldICmpSelectConstant(ICmpInst &Cmp,
Craig Topper524c44f2017-08-23 05:46:07 +00002633 SelectInst *Select,
Anna Thomasd67165c2017-06-23 13:41:45 +00002634 ConstantInt *C) {
2635
2636 assert(C && "Cmp RHS should be a constant int!");
2637 // If we're testing a constant value against the result of a three way
2638 // comparison, the result can be expressed directly in terms of the
2639 // original values being compared. Note: We could possibly be more
2640 // aggressive here and remove the hasOneUse test. The original select is
2641 // really likely to simplify or sink when we remove a test of the result.
2642 Value *OrigLHS, *OrigRHS;
2643 ConstantInt *C1LessThan, *C2Equal, *C3GreaterThan;
2644 if (Cmp.hasOneUse() &&
Craig Topper524c44f2017-08-23 05:46:07 +00002645 matchThreeWayIntCompare(Select, OrigLHS, OrigRHS, C1LessThan, C2Equal,
2646 C3GreaterThan)) {
Anna Thomasd67165c2017-06-23 13:41:45 +00002647 assert(C1LessThan && C2Equal && C3GreaterThan);
2648
2649 bool TrueWhenLessThan =
2650 ConstantExpr::getCompare(Cmp.getPredicate(), C1LessThan, C)
2651 ->isAllOnesValue();
2652 bool TrueWhenEqual =
2653 ConstantExpr::getCompare(Cmp.getPredicate(), C2Equal, C)
2654 ->isAllOnesValue();
2655 bool TrueWhenGreaterThan =
2656 ConstantExpr::getCompare(Cmp.getPredicate(), C3GreaterThan, C)
2657 ->isAllOnesValue();
2658
2659 // This generates the new instruction that will replace the original Cmp
2660 // Instruction. Instead of enumerating the various combinations when
2661 // TrueWhenLessThan, TrueWhenEqual and TrueWhenGreaterThan are true versus
2662 // false, we rely on chaining of ORs and future passes of InstCombine to
2663 // simplify the OR further (i.e. a s< b || a == b becomes a s<= b).
2664
2665 // When none of the three constants satisfy the predicate for the RHS (C),
2666 // the entire original Cmp can be simplified to a false.
Craig Topperbb4069e2017-07-07 23:16:26 +00002667 Value *Cond = Builder.getFalse();
Anna Thomasd67165c2017-06-23 13:41:45 +00002668 if (TrueWhenLessThan)
Sanjay Patele7f46c32019-02-07 20:54:09 +00002669 Cond = Builder.CreateOr(Cond, Builder.CreateICmp(ICmpInst::ICMP_SLT,
2670 OrigLHS, OrigRHS));
Anna Thomasd67165c2017-06-23 13:41:45 +00002671 if (TrueWhenEqual)
Sanjay Patele7f46c32019-02-07 20:54:09 +00002672 Cond = Builder.CreateOr(Cond, Builder.CreateICmp(ICmpInst::ICMP_EQ,
2673 OrigLHS, OrigRHS));
Anna Thomasd67165c2017-06-23 13:41:45 +00002674 if (TrueWhenGreaterThan)
Sanjay Patele7f46c32019-02-07 20:54:09 +00002675 Cond = Builder.CreateOr(Cond, Builder.CreateICmp(ICmpInst::ICMP_SGT,
2676 OrigLHS, OrigRHS));
Anna Thomasd67165c2017-06-23 13:41:45 +00002677
2678 return replaceInstUsesWith(Cmp, Cond);
2679 }
2680 return nullptr;
2681}
2682
Sanjay Patele7f46c32019-02-07 20:54:09 +00002683static Instruction *foldICmpBitCast(ICmpInst &Cmp,
2684 InstCombiner::BuilderTy &Builder) {
2685 auto *Bitcast = dyn_cast<BitCastInst>(Cmp.getOperand(0));
2686 if (!Bitcast)
2687 return nullptr;
2688
Sanjay Patele7f46c32019-02-07 20:54:09 +00002689 ICmpInst::Predicate Pred = Cmp.getPredicate();
2690 Value *Op1 = Cmp.getOperand(1);
2691 Value *BCSrcOp = Bitcast->getOperand(0);
Sanjay Patele7f46c32019-02-07 20:54:09 +00002692
Sanjay Patel781d8832019-02-07 21:12:01 +00002693 // Make sure the bitcast doesn't change the number of vector elements.
2694 if (Bitcast->getSrcTy()->getScalarSizeInBits() ==
2695 Bitcast->getDestTy()->getScalarSizeInBits()) {
2696 // Zero-equality and sign-bit checks are preserved through sitofp + bitcast.
2697 Value *X;
2698 if (match(BCSrcOp, m_SIToFP(m_Value(X)))) {
2699 // icmp eq (bitcast (sitofp X)), 0 --> icmp eq X, 0
2700 // icmp ne (bitcast (sitofp X)), 0 --> icmp ne X, 0
2701 // icmp slt (bitcast (sitofp X)), 0 --> icmp slt X, 0
2702 // icmp sgt (bitcast (sitofp X)), 0 --> icmp sgt X, 0
2703 if ((Pred == ICmpInst::ICMP_EQ || Pred == ICmpInst::ICMP_SLT ||
2704 Pred == ICmpInst::ICMP_NE || Pred == ICmpInst::ICMP_SGT) &&
2705 match(Op1, m_Zero()))
2706 return new ICmpInst(Pred, X, ConstantInt::getNullValue(X->getType()));
Sanjay Patele7f46c32019-02-07 20:54:09 +00002707
Sanjay Patel781d8832019-02-07 21:12:01 +00002708 // icmp slt (bitcast (sitofp X)), 1 --> icmp slt X, 1
2709 if (Pred == ICmpInst::ICMP_SLT && match(Op1, m_One()))
2710 return new ICmpInst(Pred, X, ConstantInt::get(X->getType(), 1));
2711
2712 // icmp sgt (bitcast (sitofp X)), -1 --> icmp sgt X, -1
2713 if (Pred == ICmpInst::ICMP_SGT && match(Op1, m_AllOnes()))
2714 return new ICmpInst(Pred, X,
2715 ConstantInt::getAllOnesValue(X->getType()));
2716 }
2717
2718 // Zero-equality checks are preserved through unsigned floating-point casts:
2719 // icmp eq (bitcast (uitofp X)), 0 --> icmp eq X, 0
2720 // icmp ne (bitcast (uitofp X)), 0 --> icmp ne X, 0
2721 if (match(BCSrcOp, m_UIToFP(m_Value(X))))
2722 if (Cmp.isEquality() && match(Op1, m_Zero()))
2723 return new ICmpInst(Pred, X, ConstantInt::getNullValue(X->getType()));
Sanjay Patele7f46c32019-02-07 20:54:09 +00002724 }
2725
Sanjay Patele7f46c32019-02-07 20:54:09 +00002726 // Test to see if the operands of the icmp are casted versions of other
2727 // values. If the ptr->ptr cast can be stripped off both arguments, do so.
2728 if (Bitcast->getType()->isPointerTy() &&
2729 (isa<Constant>(Op1) || isa<BitCastInst>(Op1))) {
2730 // If operand #1 is a bitcast instruction, it must also be a ptr->ptr cast
2731 // so eliminate it as well.
2732 if (auto *BC2 = dyn_cast<BitCastInst>(Op1))
2733 Op1 = BC2->getOperand(0);
2734
2735 Op1 = Builder.CreateBitCast(Op1, BCSrcOp->getType());
2736 return new ICmpInst(Pred, BCSrcOp, Op1);
2737 }
2738
Daniel Neilson901acfa2018-04-03 17:26:20 +00002739 // Folding: icmp <pred> iN X, C
2740 // where X = bitcast <M x iK> (shufflevector <M x iK> %vec, undef, SC)) to iN
2741 // and C is a splat of a K-bit pattern
2742 // and SC is a constant vector = <C', C', C', ..., C'>
2743 // Into:
2744 // %E = extractelement <M x iK> %vec, i32 C'
2745 // icmp <pred> iK %E, trunc(C)
Sanjay Patele7f46c32019-02-07 20:54:09 +00002746 const APInt *C;
2747 if (!match(Cmp.getOperand(1), m_APInt(C)) ||
2748 !Bitcast->getType()->isIntegerTy() ||
Daniel Neilson901acfa2018-04-03 17:26:20 +00002749 !Bitcast->getSrcTy()->isIntOrIntVectorTy())
2750 return nullptr;
2751
Sanjay Patele7f46c32019-02-07 20:54:09 +00002752 Value *Vec;
2753 Constant *Mask;
2754 if (match(BCSrcOp,
Daniel Neilson901acfa2018-04-03 17:26:20 +00002755 m_ShuffleVector(m_Value(Vec), m_Undef(), m_Constant(Mask)))) {
2756 // Check whether every element of Mask is the same constant
2757 if (auto *Elem = dyn_cast_or_null<ConstantInt>(Mask->getSplatValue())) {
Sanjay Patele7f46c32019-02-07 20:54:09 +00002758 auto *VecTy = cast<VectorType>(BCSrcOp->getType());
Daniel Neilson901acfa2018-04-03 17:26:20 +00002759 auto *EltTy = cast<IntegerType>(VecTy->getElementType());
Sanjay Patele7f46c32019-02-07 20:54:09 +00002760 if (C->isSplat(EltTy->getBitWidth())) {
Daniel Neilson901acfa2018-04-03 17:26:20 +00002761 // Fold the icmp based on the value of C
2762 // If C is M copies of an iK sized bit pattern,
2763 // then:
2764 // => %E = extractelement <N x iK> %vec, i32 Elem
2765 // icmp <pred> iK %SplatVal, <pattern>
2766 Value *Extract = Builder.CreateExtractElement(Vec, Elem);
Sanjay Patele7f46c32019-02-07 20:54:09 +00002767 Value *NewC = ConstantInt::get(EltTy, C->trunc(EltTy->getBitWidth()));
Daniel Neilson901acfa2018-04-03 17:26:20 +00002768 return new ICmpInst(Pred, Extract, NewC);
2769 }
2770 }
2771 }
2772 return nullptr;
2773}
2774
Sanjay Patelf58f68c2016-09-10 15:03:44 +00002775/// Try to fold integer comparisons with a constant operand: icmp Pred X, C
2776/// where X is some kind of instruction.
2777Instruction *InstCombiner::foldICmpInstWithConstant(ICmpInst &Cmp) {
Sanjay Patelc9196c42016-08-22 21:24:29 +00002778 const APInt *C;
2779 if (!match(Cmp.getOperand(1), m_APInt(C)))
Sanjay Patel1e5b2d12016-08-16 16:08:11 +00002780 return nullptr;
2781
Craig Toppera94069f2017-08-23 05:46:08 +00002782 if (auto *BO = dyn_cast<BinaryOperator>(Cmp.getOperand(0))) {
Sanjay Patelc9196c42016-08-22 21:24:29 +00002783 switch (BO->getOpcode()) {
2784 case Instruction::Xor:
Craig Topper8ed1aa92017-10-03 05:31:07 +00002785 if (Instruction *I = foldICmpXorConstant(Cmp, BO, *C))
Sanjay Patelc9196c42016-08-22 21:24:29 +00002786 return I;
2787 break;
2788 case Instruction::And:
Craig Topper8ed1aa92017-10-03 05:31:07 +00002789 if (Instruction *I = foldICmpAndConstant(Cmp, BO, *C))
Sanjay Patelc9196c42016-08-22 21:24:29 +00002790 return I;
2791 break;
2792 case Instruction::Or:
Craig Topper8ed1aa92017-10-03 05:31:07 +00002793 if (Instruction *I = foldICmpOrConstant(Cmp, BO, *C))
Sanjay Patelc9196c42016-08-22 21:24:29 +00002794 return I;
2795 break;
2796 case Instruction::Mul:
Craig Topper8ed1aa92017-10-03 05:31:07 +00002797 if (Instruction *I = foldICmpMulConstant(Cmp, BO, *C))
Sanjay Patelc9196c42016-08-22 21:24:29 +00002798 return I;
2799 break;
2800 case Instruction::Shl:
Craig Topper8ed1aa92017-10-03 05:31:07 +00002801 if (Instruction *I = foldICmpShlConstant(Cmp, BO, *C))
Sanjay Patelc9196c42016-08-22 21:24:29 +00002802 return I;
2803 break;
2804 case Instruction::LShr:
2805 case Instruction::AShr:
Craig Topper8ed1aa92017-10-03 05:31:07 +00002806 if (Instruction *I = foldICmpShrConstant(Cmp, BO, *C))
Sanjay Patelc9196c42016-08-22 21:24:29 +00002807 return I;
2808 break;
2809 case Instruction::UDiv:
Craig Topper8ed1aa92017-10-03 05:31:07 +00002810 if (Instruction *I = foldICmpUDivConstant(Cmp, BO, *C))
Sanjay Patelc9196c42016-08-22 21:24:29 +00002811 return I;
2812 LLVM_FALLTHROUGH;
2813 case Instruction::SDiv:
Craig Topper8ed1aa92017-10-03 05:31:07 +00002814 if (Instruction *I = foldICmpDivConstant(Cmp, BO, *C))
Sanjay Patelc9196c42016-08-22 21:24:29 +00002815 return I;
2816 break;
2817 case Instruction::Sub:
Craig Topper8ed1aa92017-10-03 05:31:07 +00002818 if (Instruction *I = foldICmpSubConstant(Cmp, BO, *C))
Sanjay Patelc9196c42016-08-22 21:24:29 +00002819 return I;
2820 break;
2821 case Instruction::Add:
Craig Topper8ed1aa92017-10-03 05:31:07 +00002822 if (Instruction *I = foldICmpAddConstant(Cmp, BO, *C))
Sanjay Patelc9196c42016-08-22 21:24:29 +00002823 return I;
2824 break;
2825 default:
2826 break;
2827 }
Sanjay Patelf58f68c2016-09-10 15:03:44 +00002828 // TODO: These folds could be refactored to be part of the above calls.
Craig Topper8ed1aa92017-10-03 05:31:07 +00002829 if (Instruction *I = foldICmpBinOpEqualityWithConstant(Cmp, BO, *C))
Sanjay Patelf58f68c2016-09-10 15:03:44 +00002830 return I;
Chris Lattner2188e402010-01-04 07:37:31 +00002831 }
Jim Grosbach129c52a2011-09-30 18:09:53 +00002832
Anna Thomasd67165c2017-06-23 13:41:45 +00002833 // Match against CmpInst LHS being instructions other than binary operators.
Craig Topper524c44f2017-08-23 05:46:07 +00002834
2835 if (auto *SI = dyn_cast<SelectInst>(Cmp.getOperand(0))) {
2836 // For now, we only support constant integers while folding the
2837 // ICMP(SELECT)) pattern. We can extend this to support vector of integers
2838 // similar to the cases handled by binary ops above.
2839 if (ConstantInt *ConstRHS = dyn_cast<ConstantInt>(Cmp.getOperand(1)))
2840 if (Instruction *I = foldICmpSelectConstant(Cmp, SI, ConstRHS))
Anna Thomasd67165c2017-06-23 13:41:45 +00002841 return I;
Craig Topper524c44f2017-08-23 05:46:07 +00002842 }
2843
2844 if (auto *TI = dyn_cast<TruncInst>(Cmp.getOperand(0))) {
Craig Topper8ed1aa92017-10-03 05:31:07 +00002845 if (Instruction *I = foldICmpTruncConstant(Cmp, TI, *C))
Craig Topper524c44f2017-08-23 05:46:07 +00002846 return I;
Anna Thomasd67165c2017-06-23 13:41:45 +00002847 }
Sanjay Patelc9196c42016-08-22 21:24:29 +00002848
Nikita Popov6515db22019-01-19 09:56:01 +00002849 if (auto *II = dyn_cast<IntrinsicInst>(Cmp.getOperand(0)))
2850 if (Instruction *I = foldICmpIntrinsicWithConstant(Cmp, II, *C))
2851 return I;
Sanjay Patelf58f68c2016-09-10 15:03:44 +00002852
Sanjay Patel1710e7c2016-07-21 17:15:49 +00002853 return nullptr;
2854}
Jim Grosbach129c52a2011-09-30 18:09:53 +00002855
Sanjay Patel0a3d72b2016-09-10 15:33:39 +00002856/// Fold an icmp equality instruction with binary operator LHS and constant RHS:
2857/// icmp eq/ne BO, C.
2858Instruction *InstCombiner::foldICmpBinOpEqualityWithConstant(ICmpInst &Cmp,
2859 BinaryOperator *BO,
Craig Topper8ed1aa92017-10-03 05:31:07 +00002860 const APInt &C) {
Sanjay Patel0a3d72b2016-09-10 15:33:39 +00002861 // TODO: Some of these folds could work with arbitrary constants, but this
2862 // function is limited to scalar and vector splat constants.
2863 if (!Cmp.isEquality())
Sanjay Patel1710e7c2016-07-21 17:15:49 +00002864 return nullptr;
2865
Sanjay Patel0a3d72b2016-09-10 15:33:39 +00002866 ICmpInst::Predicate Pred = Cmp.getPredicate();
2867 bool isICMP_NE = Pred == ICmpInst::ICMP_NE;
2868 Constant *RHS = cast<Constant>(Cmp.getOperand(1));
Sanjay Patel51a767c2016-08-03 17:23:08 +00002869 Value *BOp0 = BO->getOperand(0), *BOp1 = BO->getOperand(1);
Sanjay Patel1710e7c2016-07-21 17:15:49 +00002870
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002871 switch (BO->getOpcode()) {
2872 case Instruction::SRem:
2873 // If we have a signed (X % (2^c)) == 0, turn it into an unsigned one.
Craig Topper8ed1aa92017-10-03 05:31:07 +00002874 if (C.isNullValue() && BO->hasOneUse()) {
Sanjay Patel2e9675f2016-08-03 19:48:40 +00002875 const APInt *BOC;
2876 if (match(BOp1, m_APInt(BOC)) && BOC->sgt(1) && BOC->isPowerOf2()) {
Craig Topperbb4069e2017-07-07 23:16:26 +00002877 Value *NewRem = Builder.CreateURem(BOp0, BOp1, BO->getName());
Sanjay Patel0a3d72b2016-09-10 15:33:39 +00002878 return new ICmpInst(Pred, NewRem,
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002879 Constant::getNullValue(BO->getType()));
Chris Lattner2188e402010-01-04 07:37:31 +00002880 }
Sanjay Patel1710e7c2016-07-21 17:15:49 +00002881 }
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002882 break;
Sanjay Patel00a324e2016-08-03 22:08:44 +00002883 case Instruction::Add: {
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002884 // Replace ((add A, B) != C) with (A != C-B) if B & C are constants.
Sanjay Patel00a324e2016-08-03 22:08:44 +00002885 const APInt *BOC;
2886 if (match(BOp1, m_APInt(BOC))) {
2887 if (BO->hasOneUse()) {
2888 Constant *SubC = ConstantExpr::getSub(RHS, cast<Constant>(BOp1));
Sanjay Patel0a3d72b2016-09-10 15:33:39 +00002889 return new ICmpInst(Pred, BOp0, SubC);
Sanjay Patel00a324e2016-08-03 22:08:44 +00002890 }
Craig Topper8ed1aa92017-10-03 05:31:07 +00002891 } else if (C.isNullValue()) {
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002892 // Replace ((add A, B) != 0) with (A != -B) if A or B is
2893 // efficiently invertible, or if the add has just this one use.
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002894 if (Value *NegVal = dyn_castNegVal(BOp1))
Sanjay Patel0a3d72b2016-09-10 15:33:39 +00002895 return new ICmpInst(Pred, BOp0, NegVal);
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002896 if (Value *NegVal = dyn_castNegVal(BOp0))
Sanjay Patel0a3d72b2016-09-10 15:33:39 +00002897 return new ICmpInst(Pred, NegVal, BOp1);
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002898 if (BO->hasOneUse()) {
Craig Topperbb4069e2017-07-07 23:16:26 +00002899 Value *Neg = Builder.CreateNeg(BOp1);
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002900 Neg->takeName(BO);
Sanjay Patel0a3d72b2016-09-10 15:33:39 +00002901 return new ICmpInst(Pred, BOp0, Neg);
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002902 }
2903 }
2904 break;
Sanjay Patel00a324e2016-08-03 22:08:44 +00002905 }
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002906 case Instruction::Xor:
2907 if (BO->hasOneUse()) {
Sanjay Patel51a767c2016-08-03 17:23:08 +00002908 if (Constant *BOC = dyn_cast<Constant>(BOp1)) {
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002909 // For the xor case, we can xor two constants together, eliminating
2910 // the explicit xor.
Sanjay Patel0a3d72b2016-09-10 15:33:39 +00002911 return new ICmpInst(Pred, BOp0, ConstantExpr::getXor(RHS, BOC));
Craig Topper8ed1aa92017-10-03 05:31:07 +00002912 } else if (C.isNullValue()) {
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002913 // Replace ((xor A, B) != 0) with (A != B)
Sanjay Patel0a3d72b2016-09-10 15:33:39 +00002914 return new ICmpInst(Pred, BOp0, BOp1);
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002915 }
2916 }
2917 break;
2918 case Instruction::Sub:
2919 if (BO->hasOneUse()) {
Sanjay Patel9d591d12016-08-04 15:19:25 +00002920 const APInt *BOC;
2921 if (match(BOp0, m_APInt(BOC))) {
Sanjay Patel362ff5c2016-09-15 17:01:17 +00002922 // Replace ((sub BOC, B) != C) with (B != BOC-C).
Sanjay Patel9d591d12016-08-04 15:19:25 +00002923 Constant *SubC = ConstantExpr::getSub(cast<Constant>(BOp0), RHS);
Sanjay Patel0a3d72b2016-09-10 15:33:39 +00002924 return new ICmpInst(Pred, BOp1, SubC);
Craig Topper8ed1aa92017-10-03 05:31:07 +00002925 } else if (C.isNullValue()) {
Sanjay Patel362ff5c2016-09-15 17:01:17 +00002926 // Replace ((sub A, B) != 0) with (A != B).
Sanjay Patel0a3d72b2016-09-10 15:33:39 +00002927 return new ICmpInst(Pred, BOp0, BOp1);
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002928 }
2929 }
2930 break;
Sanjay Patelb3de75d2016-08-04 19:12:12 +00002931 case Instruction::Or: {
2932 const APInt *BOC;
2933 if (match(BOp1, m_APInt(BOC)) && BO->hasOneUse() && RHS->isAllOnesValue()) {
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002934 // Comparing if all bits outside of a constant mask are set?
2935 // Replace (X | C) == -1 with (X & ~C) == ~C.
2936 // This removes the -1 constant.
Sanjay Patelb3de75d2016-08-04 19:12:12 +00002937 Constant *NotBOC = ConstantExpr::getNot(cast<Constant>(BOp1));
Craig Topperbb4069e2017-07-07 23:16:26 +00002938 Value *And = Builder.CreateAnd(BOp0, NotBOC);
Sanjay Patel0a3d72b2016-09-10 15:33:39 +00002939 return new ICmpInst(Pred, And, NotBOC);
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002940 }
2941 break;
Sanjay Patelb3de75d2016-08-04 19:12:12 +00002942 }
Sanjay Pateld938e882016-08-04 20:05:02 +00002943 case Instruction::And: {
2944 const APInt *BOC;
2945 if (match(BOp1, m_APInt(BOC))) {
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002946 // If we have ((X & C) == C), turn it into ((X & C) != 0).
Craig Topper8ed1aa92017-10-03 05:31:07 +00002947 if (C == *BOC && C.isPowerOf2())
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002948 return new ICmpInst(isICMP_NE ? ICmpInst::ICMP_EQ : ICmpInst::ICMP_NE,
Sanjay Patelab50a932016-08-02 22:38:33 +00002949 BO, Constant::getNullValue(RHS->getType()));
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002950 }
2951 break;
Sanjay Pateld938e882016-08-04 20:05:02 +00002952 }
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002953 case Instruction::Mul:
Craig Topper8ed1aa92017-10-03 05:31:07 +00002954 if (C.isNullValue() && BO->hasNoSignedWrap()) {
Sanjay Patel3bade132016-08-04 22:19:27 +00002955 const APInt *BOC;
Craig Topper73ba1c82017-06-07 07:40:37 +00002956 if (match(BOp1, m_APInt(BOC)) && !BOC->isNullValue()) {
Sanjay Patel3bade132016-08-04 22:19:27 +00002957 // The trivial case (mul X, 0) is handled by InstSimplify.
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002958 // General case : (mul X, C) != 0 iff X != 0
2959 // (mul X, C) == 0 iff X == 0
Sanjay Patel0a3d72b2016-09-10 15:33:39 +00002960 return new ICmpInst(Pred, BOp0, Constant::getNullValue(RHS->getType()));
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002961 }
2962 }
2963 break;
Sanjay Patel6ebd5852016-07-23 00:28:39 +00002964 case Instruction::UDiv:
Craig Topper8ed1aa92017-10-03 05:31:07 +00002965 if (C.isNullValue()) {
Sanjay Patel6ebd5852016-07-23 00:28:39 +00002966 // (icmp eq/ne (udiv A, B), 0) -> (icmp ugt/ule i32 B, A)
Sanjay Patel0a3d72b2016-09-10 15:33:39 +00002967 auto NewPred = isICMP_NE ? ICmpInst::ICMP_ULE : ICmpInst::ICMP_UGT;
2968 return new ICmpInst(NewPred, BOp1, BOp0);
Sanjay Patel6ebd5852016-07-23 00:28:39 +00002969 }
2970 break;
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002971 default:
2972 break;
2973 }
2974 return nullptr;
2975}
2976
Nikita Popov6515db22019-01-19 09:56:01 +00002977/// Fold an equality icmp with LLVM intrinsic and constant operand.
2978Instruction *InstCombiner::foldICmpEqIntrinsicWithConstant(ICmpInst &Cmp,
2979 IntrinsicInst *II,
2980 const APInt &C) {
Sanjay Patelb51e0722017-07-02 16:05:11 +00002981 Type *Ty = II->getType();
Nikita Popov20853a72018-12-18 19:59:50 +00002982 unsigned BitWidth = C.getBitWidth();
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002983 switch (II->getIntrinsicID()) {
2984 case Intrinsic::bswap:
2985 Worklist.Add(II);
Sanjay Patel0a3d72b2016-09-10 15:33:39 +00002986 Cmp.setOperand(0, II->getArgOperand(0));
Craig Topper8ed1aa92017-10-03 05:31:07 +00002987 Cmp.setOperand(1, ConstantInt::get(Ty, C.byteSwap()));
Sanjay Patel0a3d72b2016-09-10 15:33:39 +00002988 return &Cmp;
Sanjay Patelb51e0722017-07-02 16:05:11 +00002989
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002990 case Intrinsic::ctlz:
Nikita Popov20853a72018-12-18 19:59:50 +00002991 case Intrinsic::cttz: {
Amaury Sechet6bea6742016-08-04 05:27:20 +00002992 // ctz(A) == bitwidth(A) -> A == 0 and likewise for !=
Nikita Popov20853a72018-12-18 19:59:50 +00002993 if (C == BitWidth) {
Sanjay Patel1710e7c2016-07-21 17:15:49 +00002994 Worklist.Add(II);
Sanjay Patel0a3d72b2016-09-10 15:33:39 +00002995 Cmp.setOperand(0, II->getArgOperand(0));
Sanjay Patelb51e0722017-07-02 16:05:11 +00002996 Cmp.setOperand(1, ConstantInt::getNullValue(Ty));
Sanjay Patel0a3d72b2016-09-10 15:33:39 +00002997 return &Cmp;
Chris Lattner2188e402010-01-04 07:37:31 +00002998 }
Nikita Popov20853a72018-12-18 19:59:50 +00002999
3000 // ctz(A) == C -> A & Mask1 == Mask2, where Mask2 only has bit C set
3001 // and Mask1 has bits 0..C+1 set. Similar for ctl, but for high bits.
3002 // Limit to one use to ensure we don't increase instruction count.
3003 unsigned Num = C.getLimitedValue(BitWidth);
3004 if (Num != BitWidth && II->hasOneUse()) {
3005 bool IsTrailing = II->getIntrinsicID() == Intrinsic::cttz;
3006 APInt Mask1 = IsTrailing ? APInt::getLowBitsSet(BitWidth, Num + 1)
3007 : APInt::getHighBitsSet(BitWidth, Num + 1);
3008 APInt Mask2 = IsTrailing
3009 ? APInt::getOneBitSet(BitWidth, Num)
3010 : APInt::getOneBitSet(BitWidth, BitWidth - Num - 1);
3011 Cmp.setOperand(0, Builder.CreateAnd(II->getArgOperand(0), Mask1));
3012 Cmp.setOperand(1, ConstantInt::get(Ty, Mask2));
3013 Worklist.Add(II);
3014 return &Cmp;
3015 }
Sanjay Patel18fa9d32016-07-21 23:27:36 +00003016 break;
Nikita Popov20853a72018-12-18 19:59:50 +00003017 }
Sanjay Patelb51e0722017-07-02 16:05:11 +00003018
Amaury Sechet6bea6742016-08-04 05:27:20 +00003019 case Intrinsic::ctpop: {
Sanjay Patel18fa9d32016-07-21 23:27:36 +00003020 // popcount(A) == 0 -> A == 0 and likewise for !=
Amaury Sechet6bea6742016-08-04 05:27:20 +00003021 // popcount(A) == bitwidth(A) -> A == -1 and likewise for !=
Craig Topper8ed1aa92017-10-03 05:31:07 +00003022 bool IsZero = C.isNullValue();
Nikita Popov20853a72018-12-18 19:59:50 +00003023 if (IsZero || C == BitWidth) {
Sanjay Patel18fa9d32016-07-21 23:27:36 +00003024 Worklist.Add(II);
Sanjay Patel0a3d72b2016-09-10 15:33:39 +00003025 Cmp.setOperand(0, II->getArgOperand(0));
Sanjay Patelb51e0722017-07-02 16:05:11 +00003026 auto *NewOp =
3027 IsZero ? Constant::getNullValue(Ty) : Constant::getAllOnesValue(Ty);
Sanjay Patel0a3d72b2016-09-10 15:33:39 +00003028 Cmp.setOperand(1, NewOp);
3029 return &Cmp;
Amaury Sechet6bea6742016-08-04 05:27:20 +00003030 }
Sanjay Patel18fa9d32016-07-21 23:27:36 +00003031 break;
Sanjay Patel0a3d72b2016-09-10 15:33:39 +00003032 }
Sanjay Patel18fa9d32016-07-21 23:27:36 +00003033 default:
3034 break;
Chris Lattner2188e402010-01-04 07:37:31 +00003035 }
Sanjay Patelb51e0722017-07-02 16:05:11 +00003036
Craig Topperf40110f2014-04-25 05:29:35 +00003037 return nullptr;
Chris Lattner2188e402010-01-04 07:37:31 +00003038}
3039
Nikita Popov6515db22019-01-19 09:56:01 +00003040/// Fold an icmp with LLVM intrinsic and constant operand: icmp Pred II, C.
3041Instruction *InstCombiner::foldICmpIntrinsicWithConstant(ICmpInst &Cmp,
3042 IntrinsicInst *II,
3043 const APInt &C) {
3044 if (Cmp.isEquality())
3045 return foldICmpEqIntrinsicWithConstant(Cmp, II, C);
3046
3047 Type *Ty = II->getType();
3048 unsigned BitWidth = C.getBitWidth();
3049 switch (II->getIntrinsicID()) {
3050 case Intrinsic::ctlz: {
3051 // ctlz(0bXXXXXXXX) > 3 -> 0bXXXXXXXX < 0b00010000
3052 if (Cmp.getPredicate() == ICmpInst::ICMP_UGT && C.ult(BitWidth)) {
3053 unsigned Num = C.getLimitedValue();
3054 APInt Limit = APInt::getOneBitSet(BitWidth, BitWidth - Num - 1);
3055 return CmpInst::Create(Instruction::ICmp, ICmpInst::ICMP_ULT,
3056 II->getArgOperand(0), ConstantInt::get(Ty, Limit));
3057 }
3058
3059 // ctlz(0bXXXXXXXX) < 3 -> 0bXXXXXXXX > 0b00011111
3060 if (Cmp.getPredicate() == ICmpInst::ICMP_ULT &&
3061 C.uge(1) && C.ule(BitWidth)) {
3062 unsigned Num = C.getLimitedValue();
3063 APInt Limit = APInt::getLowBitsSet(BitWidth, BitWidth - Num);
3064 return CmpInst::Create(Instruction::ICmp, ICmpInst::ICMP_UGT,
3065 II->getArgOperand(0), ConstantInt::get(Ty, Limit));
3066 }
3067 break;
3068 }
3069 case Intrinsic::cttz: {
3070 // Limit to one use to ensure we don't increase instruction count.
3071 if (!II->hasOneUse())
3072 return nullptr;
3073
3074 // cttz(0bXXXXXXXX) > 3 -> 0bXXXXXXXX & 0b00001111 == 0
3075 if (Cmp.getPredicate() == ICmpInst::ICMP_UGT && C.ult(BitWidth)) {
3076 APInt Mask = APInt::getLowBitsSet(BitWidth, C.getLimitedValue() + 1);
3077 return CmpInst::Create(Instruction::ICmp, ICmpInst::ICMP_EQ,
3078 Builder.CreateAnd(II->getArgOperand(0), Mask),
3079 ConstantInt::getNullValue(Ty));
3080 }
3081
3082 // cttz(0bXXXXXXXX) < 3 -> 0bXXXXXXXX & 0b00000111 != 0
3083 if (Cmp.getPredicate() == ICmpInst::ICMP_ULT &&
3084 C.uge(1) && C.ule(BitWidth)) {
3085 APInt Mask = APInt::getLowBitsSet(BitWidth, C.getLimitedValue());
3086 return CmpInst::Create(Instruction::ICmp, ICmpInst::ICMP_NE,
3087 Builder.CreateAnd(II->getArgOperand(0), Mask),
3088 ConstantInt::getNullValue(Ty));
3089 }
3090 break;
3091 }
3092 default:
3093 break;
3094 }
3095
3096 return nullptr;
3097}
3098
Sanjay Patel10494b22016-09-16 16:10:22 +00003099/// Handle icmp with constant (but not simple integer constant) RHS.
3100Instruction *InstCombiner::foldICmpInstWithConstantNotInt(ICmpInst &I) {
3101 Value *Op0 = I.getOperand(0), *Op1 = I.getOperand(1);
3102 Constant *RHSC = dyn_cast<Constant>(Op1);
3103 Instruction *LHSI = dyn_cast<Instruction>(Op0);
3104 if (!RHSC || !LHSI)
3105 return nullptr;
3106
3107 switch (LHSI->getOpcode()) {
3108 case Instruction::GetElementPtr:
3109 // icmp pred GEP (P, int 0, int 0, int 0), null -> icmp pred P, null
3110 if (RHSC->isNullValue() &&
3111 cast<GetElementPtrInst>(LHSI)->hasAllZeroIndices())
3112 return new ICmpInst(
3113 I.getPredicate(), LHSI->getOperand(0),
3114 Constant::getNullValue(LHSI->getOperand(0)->getType()));
3115 break;
3116 case Instruction::PHI:
3117 // Only fold icmp into the PHI if the phi and icmp are in the same
3118 // block. If in the same block, we're encouraging jump threading. If
3119 // not, we are just pessimizing the code by making an i1 phi.
3120 if (LHSI->getParent() == I.getParent())
Craig Topperfb71b7d2017-04-14 19:20:12 +00003121 if (Instruction *NV = foldOpIntoPhi(I, cast<PHINode>(LHSI)))
Sanjay Patel10494b22016-09-16 16:10:22 +00003122 return NV;
3123 break;
3124 case Instruction::Select: {
3125 // If either operand of the select is a constant, we can fold the
3126 // comparison into the select arms, which will cause one to be
3127 // constant folded and the select turned into a bitwise or.
3128 Value *Op1 = nullptr, *Op2 = nullptr;
3129 ConstantInt *CI = nullptr;
3130 if (Constant *C = dyn_cast<Constant>(LHSI->getOperand(1))) {
3131 Op1 = ConstantExpr::getICmp(I.getPredicate(), C, RHSC);
3132 CI = dyn_cast<ConstantInt>(Op1);
3133 }
3134 if (Constant *C = dyn_cast<Constant>(LHSI->getOperand(2))) {
3135 Op2 = ConstantExpr::getICmp(I.getPredicate(), C, RHSC);
3136 CI = dyn_cast<ConstantInt>(Op2);
3137 }
3138
3139 // We only want to perform this transformation if it will not lead to
3140 // additional code. This is true if either both sides of the select
3141 // fold to a constant (in which case the icmp is replaced with a select
3142 // which will usually simplify) or this is the only user of the
3143 // select (in which case we are trading a select+icmp for a simpler
3144 // select+icmp) or all uses of the select can be replaced based on
3145 // dominance information ("Global cases").
3146 bool Transform = false;
3147 if (Op1 && Op2)
3148 Transform = true;
3149 else if (Op1 || Op2) {
3150 // Local case
3151 if (LHSI->hasOneUse())
3152 Transform = true;
3153 // Global cases
3154 else if (CI && !CI->isZero())
3155 // When Op1 is constant try replacing select with second operand.
3156 // Otherwise Op2 is constant and try replacing select with first
3157 // operand.
3158 Transform =
3159 replacedSelectWithOperand(cast<SelectInst>(LHSI), &I, Op1 ? 2 : 1);
3160 }
3161 if (Transform) {
3162 if (!Op1)
Craig Topperbb4069e2017-07-07 23:16:26 +00003163 Op1 = Builder.CreateICmp(I.getPredicate(), LHSI->getOperand(1), RHSC,
3164 I.getName());
Sanjay Patel10494b22016-09-16 16:10:22 +00003165 if (!Op2)
Craig Topperbb4069e2017-07-07 23:16:26 +00003166 Op2 = Builder.CreateICmp(I.getPredicate(), LHSI->getOperand(2), RHSC,
3167 I.getName());
Sanjay Patel10494b22016-09-16 16:10:22 +00003168 return SelectInst::Create(LHSI->getOperand(0), Op1, Op2);
3169 }
3170 break;
3171 }
3172 case Instruction::IntToPtr:
3173 // icmp pred inttoptr(X), null -> icmp pred X, 0
3174 if (RHSC->isNullValue() &&
3175 DL.getIntPtrType(RHSC->getType()) == LHSI->getOperand(0)->getType())
3176 return new ICmpInst(
3177 I.getPredicate(), LHSI->getOperand(0),
3178 Constant::getNullValue(LHSI->getOperand(0)->getType()));
3179 break;
3180
3181 case Instruction::Load:
3182 // Try to optimize things like "A[i] > 4" to index computations.
3183 if (GetElementPtrInst *GEP =
3184 dyn_cast<GetElementPtrInst>(LHSI->getOperand(0))) {
3185 if (GlobalVariable *GV = dyn_cast<GlobalVariable>(GEP->getOperand(0)))
3186 if (GV->isConstant() && GV->hasDefinitiveInitializer() &&
3187 !cast<LoadInst>(LHSI)->isVolatile())
3188 if (Instruction *Res = foldCmpLoadFromIndexedGlobal(GEP, GV, I))
3189 return Res;
3190 }
3191 break;
3192 }
3193
3194 return nullptr;
3195}
3196
Roman Lebedev68d54cf2018-07-11 19:05:04 +00003197/// Some comparisons can be simplified.
3198/// In this case, we are looking for comparisons that look like
3199/// a check for a lossy truncation.
3200/// Folds:
Roman Lebedev183a4652018-09-19 13:35:27 +00003201/// icmp SrcPred (x & Mask), x to icmp DstPred x, Mask
3202/// Where Mask is some pattern that produces all-ones in low bits:
3203/// (-1 >> y)
Roman Lebedevf50023d2018-09-19 13:35:46 +00003204/// ((-1 << y) >> y) <- non-canonical, has extra uses
Roman Lebedev183a4652018-09-19 13:35:27 +00003205/// ~(-1 << y)
Roman Lebedevca2bdb02018-09-19 13:35:40 +00003206/// ((1 << y) + (-1)) <- non-canonical, has extra uses
Roman Lebedev68d54cf2018-07-11 19:05:04 +00003207/// The Mask can be a constant, too.
Roman Lebedevc7bc4c02018-07-14 20:08:52 +00003208/// For some predicates, the operands are commutative.
3209/// For others, x can only be on a specific side.
Roman Lebedev68d54cf2018-07-11 19:05:04 +00003210static Value *foldICmpWithLowBitMaskedVal(ICmpInst &I,
3211 InstCombiner::BuilderTy &Builder) {
3212 ICmpInst::Predicate SrcPred;
Roman Lebedevf50023d2018-09-19 13:35:46 +00003213 Value *X, *M, *Y;
3214 auto m_VariableMask = m_CombineOr(
3215 m_CombineOr(m_Not(m_Shl(m_AllOnes(), m_Value())),
3216 m_Add(m_Shl(m_One(), m_Value()), m_AllOnes())),
3217 m_CombineOr(m_LShr(m_AllOnes(), m_Value()),
3218 m_LShr(m_Shl(m_AllOnes(), m_Value(Y)), m_Deferred(Y))));
Roman Lebedev183a4652018-09-19 13:35:27 +00003219 auto m_Mask = m_CombineOr(m_VariableMask, m_LowBitMask());
Roman Lebedev68d54cf2018-07-11 19:05:04 +00003220 if (!match(&I, m_c_ICmp(SrcPred,
3221 m_c_And(m_CombineAnd(m_Mask, m_Value(M)), m_Value(X)),
3222 m_Deferred(X))))
3223 return nullptr;
3224
3225 ICmpInst::Predicate DstPred;
3226 switch (SrcPred) {
3227 case ICmpInst::Predicate::ICMP_EQ:
3228 // x & (-1 >> y) == x -> x u<= (-1 >> y)
3229 DstPred = ICmpInst::Predicate::ICMP_ULE;
3230 break;
Roman Lebedev74f899f2018-07-12 14:56:12 +00003231 case ICmpInst::Predicate::ICMP_NE:
3232 // x & (-1 >> y) != x -> x u> (-1 >> y)
3233 DstPred = ICmpInst::Predicate::ICMP_UGT;
3234 break;
Roman Lebedev74f611a2018-07-14 16:44:43 +00003235 case ICmpInst::Predicate::ICMP_UGT:
3236 // x u> x & (-1 >> y) -> x u> (-1 >> y)
3237 assert(X == I.getOperand(0) && "instsimplify took care of commut. variant");
3238 DstPred = ICmpInst::Predicate::ICMP_UGT;
3239 break;
Roman Lebedevfac48472018-07-14 12:20:06 +00003240 case ICmpInst::Predicate::ICMP_UGE:
3241 // x & (-1 >> y) u>= x -> x u<= (-1 >> y)
3242 assert(X == I.getOperand(1) && "instsimplify took care of commut. variant");
3243 DstPred = ICmpInst::Predicate::ICMP_ULE;
3244 break;
Roman Lebedeve3dc5872018-07-14 12:20:16 +00003245 case ICmpInst::Predicate::ICMP_ULT:
3246 // x & (-1 >> y) u< x -> x u> (-1 >> y)
3247 assert(X == I.getOperand(1) && "instsimplify took care of commut. variant");
3248 DstPred = ICmpInst::Predicate::ICMP_UGT;
3249 break;
Roman Lebedev0f5ec892018-07-14 16:44:54 +00003250 case ICmpInst::Predicate::ICMP_ULE:
3251 // x u<= x & (-1 >> y) -> x u<= (-1 >> y)
3252 assert(X == I.getOperand(0) && "instsimplify took care of commut. variant");
3253 DstPred = ICmpInst::Predicate::ICMP_ULE;
3254 break;
Roman Lebedev859e14a2018-07-14 20:08:16 +00003255 case ICmpInst::Predicate::ICMP_SGT:
3256 // x s> x & (-1 >> y) -> x s> (-1 >> y)
3257 if (X != I.getOperand(0)) // X must be on LHS of comparison!
3258 return nullptr; // Ignore the other case.
Roman Lebedevd6697582019-06-09 16:30:42 +00003259 if (!match(M, m_Constant())) // Can not do this fold with non-constant.
3260 return nullptr;
3261 if (!match(M, m_NonNegative())) // Must not have any -1 vector elements.
3262 return nullptr;
Roman Lebedev859e14a2018-07-14 20:08:16 +00003263 DstPred = ICmpInst::Predicate::ICMP_SGT;
3264 break;
Roman Lebedevf1442612018-07-14 20:08:37 +00003265 case ICmpInst::Predicate::ICMP_SGE:
3266 // x & (-1 >> y) s>= x -> x s<= (-1 >> y)
3267 if (X != I.getOperand(1)) // X must be on RHS of comparison!
3268 return nullptr; // Ignore the other case.
Roman Lebedev7bf2fed2018-12-03 20:07:58 +00003269 if (!match(M, m_Constant())) // Can not do this fold with non-constant.
3270 return nullptr;
Roman Lebedev98cb1212018-12-06 08:14:24 +00003271 if (!match(M, m_NonNegative())) // Must not have any -1 vector elements.
3272 return nullptr;
Roman Lebedevf1442612018-07-14 20:08:37 +00003273 DstPred = ICmpInst::Predicate::ICMP_SLE;
3274 break;
Roman Lebedevb972fc32018-07-14 20:08:47 +00003275 case ICmpInst::Predicate::ICMP_SLT:
3276 // x & (-1 >> y) s< x -> x s> (-1 >> y)
3277 if (X != I.getOperand(1)) // X must be on RHS of comparison!
3278 return nullptr; // Ignore the other case.
Roman Lebedev7bf2fed2018-12-03 20:07:58 +00003279 if (!match(M, m_Constant())) // Can not do this fold with non-constant.
3280 return nullptr;
Roman Lebedev98cb1212018-12-06 08:14:24 +00003281 if (!match(M, m_NonNegative())) // Must not have any -1 vector elements.
3282 return nullptr;
Roman Lebedevb972fc32018-07-14 20:08:47 +00003283 DstPred = ICmpInst::Predicate::ICMP_SGT;
3284 break;
Roman Lebedev1e61e352018-07-14 20:08:26 +00003285 case ICmpInst::Predicate::ICMP_SLE:
3286 // x s<= x & (-1 >> y) -> x s<= (-1 >> y)
3287 if (X != I.getOperand(0)) // X must be on LHS of comparison!
3288 return nullptr; // Ignore the other case.
Roman Lebedevd6697582019-06-09 16:30:42 +00003289 if (!match(M, m_Constant())) // Can not do this fold with non-constant.
3290 return nullptr;
3291 if (!match(M, m_NonNegative())) // Must not have any -1 vector elements.
3292 return nullptr;
Roman Lebedev1e61e352018-07-14 20:08:26 +00003293 DstPred = ICmpInst::Predicate::ICMP_SLE;
3294 break;
Roman Lebedev68d54cf2018-07-11 19:05:04 +00003295 default:
Roman Lebedevc7bc4c02018-07-14 20:08:52 +00003296 llvm_unreachable("All possible folds are handled.");
Roman Lebedev68d54cf2018-07-11 19:05:04 +00003297 }
3298
3299 return Builder.CreateICmp(DstPred, X, M);
3300}
3301
Roman Lebedev3cb87e92018-07-18 10:55:17 +00003302/// Some comparisons can be simplified.
3303/// In this case, we are looking for comparisons that look like
3304/// a check for a lossy signed truncation.
3305/// Folds: (MaskedBits is a constant.)
3306/// ((%x << MaskedBits) a>> MaskedBits) SrcPred %x
3307/// Into:
3308/// (add %x, (1 << (KeptBits-1))) DstPred (1 << KeptBits)
3309/// Where KeptBits = bitwidth(%x) - MaskedBits
3310static Value *
3311foldICmpWithTruncSignExtendedVal(ICmpInst &I,
3312 InstCombiner::BuilderTy &Builder) {
3313 ICmpInst::Predicate SrcPred;
3314 Value *X;
3315 const APInt *C0, *C1; // FIXME: non-splats, potentially with undef.
3316 // We are ok with 'shl' having multiple uses, but 'ashr' must be one-use.
3317 if (!match(&I, m_c_ICmp(SrcPred,
3318 m_OneUse(m_AShr(m_Shl(m_Value(X), m_APInt(C0)),
3319 m_APInt(C1))),
3320 m_Deferred(X))))
3321 return nullptr;
3322
3323 // Potential handling of non-splats: for each element:
3324 // * if both are undef, replace with constant 0.
3325 // Because (1<<0) is OK and is 1, and ((1<<0)>>1) is also OK and is 0.
3326 // * if both are not undef, and are different, bailout.
3327 // * else, only one is undef, then pick the non-undef one.
3328
3329 // The shift amount must be equal.
3330 if (*C0 != *C1)
3331 return nullptr;
3332 const APInt &MaskedBits = *C0;
3333 assert(MaskedBits != 0 && "shift by zero should be folded away already.");
3334
3335 ICmpInst::Predicate DstPred;
3336 switch (SrcPred) {
3337 case ICmpInst::Predicate::ICMP_EQ:
3338 // ((%x << MaskedBits) a>> MaskedBits) == %x
3339 // =>
3340 // (add %x, (1 << (KeptBits-1))) u< (1 << KeptBits)
3341 DstPred = ICmpInst::Predicate::ICMP_ULT;
3342 break;
3343 case ICmpInst::Predicate::ICMP_NE:
3344 // ((%x << MaskedBits) a>> MaskedBits) != %x
3345 // =>
3346 // (add %x, (1 << (KeptBits-1))) u>= (1 << KeptBits)
3347 DstPred = ICmpInst::Predicate::ICMP_UGE;
3348 break;
3349 // FIXME: are more folds possible?
3350 default:
3351 return nullptr;
3352 }
3353
3354 auto *XType = X->getType();
3355 const unsigned XBitWidth = XType->getScalarSizeInBits();
3356 const APInt BitWidth = APInt(XBitWidth, XBitWidth);
3357 assert(BitWidth.ugt(MaskedBits) && "shifts should leave some bits untouched");
3358
3359 // KeptBits = bitwidth(%x) - MaskedBits
3360 const APInt KeptBits = BitWidth - MaskedBits;
3361 assert(KeptBits.ugt(0) && KeptBits.ult(BitWidth) && "unreachable");
3362 // ICmpCst = (1 << KeptBits)
3363 const APInt ICmpCst = APInt(XBitWidth, 1).shl(KeptBits);
3364 assert(ICmpCst.isPowerOf2());
3365 // AddCst = (1 << (KeptBits-1))
3366 const APInt AddCst = ICmpCst.lshr(1);
3367 assert(AddCst.ult(ICmpCst) && AddCst.isPowerOf2());
3368
3369 // T0 = add %x, AddCst
3370 Value *T0 = Builder.CreateAdd(X, ConstantInt::get(XType, AddCst));
3371 // T1 = T0 DstPred ICmpCst
3372 Value *T1 = Builder.CreateICmp(DstPred, T0, ConstantInt::get(XType, ICmpCst));
3373
3374 return T1;
3375}
3376
Roman Lebedev72b8d412019-07-01 15:55:15 +00003377// Given pattern:
3378// icmp eq/ne (and ((x shift Q), (y oppositeshift K))), 0
3379// we should move shifts to the same hand of 'and', i.e. rewrite as
3380// icmp eq/ne (and (x shift (Q+K)), y), 0 iff (Q+K) u< bitwidth(x)
3381// We are only interested in opposite logical shifts here.
Roman Lebedevf13b0e32019-08-29 10:26:23 +00003382// One of the shifts can be truncated.
Roman Lebedev72b8d412019-07-01 15:55:15 +00003383// If we can, we want to end up creating 'lshr' shift.
3384static Value *
3385foldShiftIntoShiftInAnotherHandOfAndInICmp(ICmpInst &I, const SimplifyQuery SQ,
3386 InstCombiner::BuilderTy &Builder) {
3387 if (!I.isEquality() || !match(I.getOperand(1), m_Zero()) ||
3388 !I.getOperand(0)->hasOneUse())
3389 return nullptr;
3390
3391 auto m_AnyLogicalShift = m_LogicalShift(m_Value(), m_Value());
Roman Lebedev72b8d412019-07-01 15:55:15 +00003392
Roman Lebedev16244fc2019-08-16 15:10:41 +00003393 // Look for an 'and' of two logical shifts, one of which may be truncated.
3394 // We use m_TruncOrSelf() on the RHS to correctly handle commutative case.
3395 Instruction *XShift, *MaybeTruncation, *YShift;
3396 if (!match(
3397 I.getOperand(0),
3398 m_c_And(m_CombineAnd(m_AnyLogicalShift, m_Instruction(XShift)),
3399 m_CombineAnd(m_TruncOrSelf(m_CombineAnd(
3400 m_AnyLogicalShift, m_Instruction(YShift))),
3401 m_Instruction(MaybeTruncation)))))
Roman Lebedev72b8d412019-07-01 15:55:15 +00003402 return nullptr;
3403
Roman Lebedev16244fc2019-08-16 15:10:41 +00003404 // We potentially looked past 'trunc', but only when matching YShift,
3405 // therefore YShift must have the widest type.
Roman Lebedev9b957d32019-08-18 12:26:33 +00003406 Instruction *WidestShift = YShift;
3407 // Therefore XShift must have the shallowest type.
3408 // Or they both have identical types if there was no truncation.
3409 Instruction *NarrowestShift = XShift;
3410
3411 Type *WidestTy = WidestShift->getType();
3412 assert(NarrowestShift->getType() == I.getOperand(0)->getType() &&
Roman Lebedev16244fc2019-08-16 15:10:41 +00003413 "We did not look past any shifts while matching XShift though.");
3414 bool HadTrunc = WidestTy != I.getOperand(0)->getType();
3415
Roman Lebedev64fe8062019-08-10 19:28:44 +00003416 // If YShift is a 'lshr', swap the shifts around.
Roman Lebedev16244fc2019-08-16 15:10:41 +00003417 if (match(YShift, m_LShr(m_Value(), m_Value())))
Roman Lebedev72b8d412019-07-01 15:55:15 +00003418 std::swap(XShift, YShift);
3419
3420 // The shifts must be in opposite directions.
Roman Lebedevccdad6e2019-08-12 11:28:02 +00003421 auto XShiftOpcode = XShift->getOpcode();
3422 if (XShiftOpcode == YShift->getOpcode())
Roman Lebedev72b8d412019-07-01 15:55:15 +00003423 return nullptr; // Do not care about same-direction shifts here.
3424
3425 Value *X, *XShAmt, *Y, *YShAmt;
Roman Lebedev16244fc2019-08-16 15:10:41 +00003426 match(XShift, m_BinOp(m_Value(X), m_ZExtOrSelf(m_Value(XShAmt))));
3427 match(YShift, m_BinOp(m_Value(Y), m_ZExtOrSelf(m_Value(YShAmt))));
Roman Lebedev72b8d412019-07-01 15:55:15 +00003428
Roman Lebedeva8d20b42019-08-10 19:28:54 +00003429 // If one of the values being shifted is a constant, then we will end with
Roman Lebedev16244fc2019-08-16 15:10:41 +00003430 // and+icmp, and [zext+]shift instrs will be constant-folded. If they are not,
Roman Lebedeva8d20b42019-08-10 19:28:54 +00003431 // however, we will need to ensure that we won't increase instruction count.
3432 if (!isa<Constant>(X) && !isa<Constant>(Y)) {
3433 // At least one of the hands of the 'and' should be one-use shift.
3434 if (!match(I.getOperand(0),
3435 m_c_And(m_OneUse(m_AnyLogicalShift), m_Value())))
3436 return nullptr;
Roman Lebedev16244fc2019-08-16 15:10:41 +00003437 if (HadTrunc) {
3438 // Due to the 'trunc', we will need to widen X. For that either the old
3439 // 'trunc' or the shift amt in the non-truncated shift should be one-use.
3440 if (!MaybeTruncation->hasOneUse() &&
Roman Lebedev9b957d32019-08-18 12:26:33 +00003441 !NarrowestShift->getOperand(1)->hasOneUse())
Roman Lebedev16244fc2019-08-16 15:10:41 +00003442 return nullptr;
3443 }
Roman Lebedeva8d20b42019-08-10 19:28:54 +00003444 }
3445
Roman Lebedev16244fc2019-08-16 15:10:41 +00003446 // We have two shift amounts from two different shifts. The types of those
3447 // shift amounts may not match. If that's the case let's bailout now.
3448 if (XShAmt->getType() != YShAmt->getType())
3449 return nullptr;
3450
Roman Lebedev72b8d412019-07-01 15:55:15 +00003451 // Can we fold (XShAmt+YShAmt) ?
Roman Lebedev16244fc2019-08-16 15:10:41 +00003452 auto *NewShAmt = dyn_cast_or_null<Constant>(
3453 SimplifyAddInst(XShAmt, YShAmt, /*isNSW=*/false,
3454 /*isNUW=*/false, SQ.getWithInstruction(&I)));
Roman Lebedev72b8d412019-07-01 15:55:15 +00003455 if (!NewShAmt)
3456 return nullptr;
Roman Lebedevf13b0e32019-08-29 10:26:23 +00003457 NewShAmt = ConstantExpr::getZExtOrBitCast(NewShAmt, WidestTy);
3458 unsigned WidestBitWidth = WidestTy->getScalarSizeInBits();
3459
Roman Lebedev72b8d412019-07-01 15:55:15 +00003460 // Is the new shift amount smaller than the bit width?
3461 // FIXME: could also rely on ConstantRange.
Roman Lebedevf13b0e32019-08-29 10:26:23 +00003462 if (!match(NewShAmt,
3463 m_SpecificInt_ICMP(ICmpInst::Predicate::ICMP_ULT,
3464 APInt(WidestBitWidth, WidestBitWidth))))
Roman Lebedev72b8d412019-07-01 15:55:15 +00003465 return nullptr;
Roman Lebedevf13b0e32019-08-29 10:26:23 +00003466
3467 // An extra legality check is needed if we had trunc-of-lshr.
3468 if (HadTrunc && match(WidestShift, m_LShr(m_Value(), m_Value()))) {
3469 auto CanFold = [NewShAmt, WidestBitWidth, NarrowestShift, SQ,
3470 WidestShift]() {
3471 // It isn't obvious whether it's worth it to analyze non-constants here.
3472 // Also, let's basically give up on non-splat cases, pessimizing vectors.
3473 // If *any* of these preconditions matches we can perform the fold.
3474 Constant *NewShAmtSplat = NewShAmt->getType()->isVectorTy()
3475 ? NewShAmt->getSplatValue()
3476 : NewShAmt;
3477 // If it's edge-case shift (by 0 or by WidestBitWidth-1) we can fold.
3478 if (NewShAmtSplat &&
3479 (NewShAmtSplat->isNullValue() ||
3480 NewShAmtSplat->getUniqueInteger() == WidestBitWidth - 1))
3481 return true;
3482 // We consider *min* leading zeros so a single outlier
3483 // blocks the transform as opposed to allowing it.
3484 if (auto *C = dyn_cast<Constant>(NarrowestShift->getOperand(0))) {
3485 KnownBits Known = computeKnownBits(C, SQ.DL);
3486 unsigned MinLeadZero = Known.countMinLeadingZeros();
3487 // If the value being shifted has at most lowest bit set we can fold.
3488 unsigned MaxActiveBits = Known.getBitWidth() - MinLeadZero;
3489 if (MaxActiveBits <= 1)
3490 return true;
3491 // Precondition: NewShAmt u<= countLeadingZeros(C)
3492 if (NewShAmtSplat && NewShAmtSplat->getUniqueInteger().ule(MinLeadZero))
3493 return true;
3494 }
3495 if (auto *C = dyn_cast<Constant>(WidestShift->getOperand(0))) {
3496 KnownBits Known = computeKnownBits(C, SQ.DL);
3497 unsigned MinLeadZero = Known.countMinLeadingZeros();
3498 // If the value being shifted has at most lowest bit set we can fold.
3499 unsigned MaxActiveBits = Known.getBitWidth() - MinLeadZero;
3500 if (MaxActiveBits <= 1)
3501 return true;
3502 // Precondition: ((WidestBitWidth-1)-NewShAmt) u<= countLeadingZeros(C)
3503 if (NewShAmtSplat) {
3504 APInt AdjNewShAmt =
3505 (WidestBitWidth - 1) - NewShAmtSplat->getUniqueInteger();
3506 if (AdjNewShAmt.ule(MinLeadZero))
3507 return true;
3508 }
3509 }
3510 return false; // Can't tell if it's ok.
3511 };
3512 if (!CanFold())
3513 return nullptr;
3514 }
3515
Roman Lebedev16244fc2019-08-16 15:10:41 +00003516 // All good, we can do this fold.
Roman Lebedev16244fc2019-08-16 15:10:41 +00003517 X = Builder.CreateZExt(X, WidestTy);
Roman Lebedevf13b0e32019-08-29 10:26:23 +00003518 Y = Builder.CreateZExt(Y, WidestTy);
Roman Lebedev16244fc2019-08-16 15:10:41 +00003519 // The shift is the same that was for X.
Roman Lebedev72b8d412019-07-01 15:55:15 +00003520 Value *T0 = XShiftOpcode == Instruction::BinaryOps::LShr
3521 ? Builder.CreateLShr(X, NewShAmt)
3522 : Builder.CreateShl(X, NewShAmt);
3523 Value *T1 = Builder.CreateAnd(T0, Y);
3524 return Builder.CreateICmp(I.getPredicate(), T1,
Roman Lebedev16244fc2019-08-16 15:10:41 +00003525 Constant::getNullValue(WidestTy));
Roman Lebedev72b8d412019-07-01 15:55:15 +00003526}
3527
Roman Lebedevfb38b7a2019-08-29 12:47:08 +00003528/// Fold
3529/// (-1 u/ x) u< y
Roman Lebedev473a0632019-08-29 12:47:20 +00003530/// ((x * y) u/ x) != y
Roman Lebedevfb38b7a2019-08-29 12:47:08 +00003531/// to
3532/// @llvm.umul.with.overflow(x, y) plus extraction of overflow bit
Roman Lebedev473a0632019-08-29 12:47:20 +00003533/// Note that the comparison is commutative, while inverted (u>=, ==) predicate
Roman Lebedevfb38b7a2019-08-29 12:47:08 +00003534/// will mean that we are looking for the opposite answer.
Roman Lebedev473a0632019-08-29 12:47:20 +00003535Value *InstCombiner::foldUnsignedMultiplicationOverflowCheck(ICmpInst &I) {
Roman Lebedevfb38b7a2019-08-29 12:47:08 +00003536 ICmpInst::Predicate Pred;
3537 Value *X, *Y;
Roman Lebedev473a0632019-08-29 12:47:20 +00003538 Instruction *Mul;
Roman Lebedevfb38b7a2019-08-29 12:47:08 +00003539 bool NeedNegation;
3540 // Look for: (-1 u/ x) u</u>= y
3541 if (!I.isEquality() &&
3542 match(&I, m_c_ICmp(Pred, m_OneUse(m_UDiv(m_AllOnes(), m_Value(X))),
3543 m_Value(Y)))) {
Roman Lebedev473a0632019-08-29 12:47:20 +00003544 Mul = nullptr;
Roman Lebedevfb38b7a2019-08-29 12:47:08 +00003545 // Canonicalize as-if y was on RHS.
3546 if (I.getOperand(1) != Y)
3547 Pred = I.getSwappedPredicate();
3548
3549 // Are we checking that overflow does not happen, or does happen?
3550 switch (Pred) {
3551 case ICmpInst::Predicate::ICMP_ULT:
3552 NeedNegation = false;
3553 break; // OK
3554 case ICmpInst::Predicate::ICMP_UGE:
3555 NeedNegation = true;
3556 break; // OK
3557 default:
3558 return nullptr; // Wrong predicate.
3559 }
Roman Lebedev473a0632019-08-29 12:47:20 +00003560 } else // Look for: ((x * y) u/ x) !=/== y
3561 if (I.isEquality() &&
3562 match(&I, m_c_ICmp(Pred, m_Value(Y),
3563 m_OneUse(m_UDiv(m_CombineAnd(m_c_Mul(m_Deferred(Y),
3564 m_Value(X)),
3565 m_Instruction(Mul)),
3566 m_Deferred(X)))))) {
3567 NeedNegation = Pred == ICmpInst::Predicate::ICMP_EQ;
Roman Lebedevfb38b7a2019-08-29 12:47:08 +00003568 } else
3569 return nullptr;
3570
Roman Lebedev473a0632019-08-29 12:47:20 +00003571 BuilderTy::InsertPointGuard Guard(Builder);
3572 // If the pattern included (x * y), we'll want to insert new instructions
3573 // right before that original multiplication so that we can replace it.
3574 bool MulHadOtherUses = Mul && !Mul->hasOneUse();
3575 if (MulHadOtherUses)
3576 Builder.SetInsertPoint(Mul);
3577
Roman Lebedevfb38b7a2019-08-29 12:47:08 +00003578 Function *F = Intrinsic::getDeclaration(
3579 I.getModule(), Intrinsic::umul_with_overflow, X->getType());
3580 CallInst *Call = Builder.CreateCall(F, {X, Y}, "umul");
Roman Lebedev473a0632019-08-29 12:47:20 +00003581
3582 // If the multiplication was used elsewhere, to ensure that we don't leave
3583 // "duplicate" instructions, replace uses of that original multiplication
3584 // with the multiplication result from the with.overflow intrinsic.
3585 if (MulHadOtherUses)
3586 replaceInstUsesWith(*Mul, Builder.CreateExtractValue(Call, 0, "umul.val"));
3587
Roman Lebedevfb38b7a2019-08-29 12:47:08 +00003588 Value *Res = Builder.CreateExtractValue(Call, 1, "umul.ov");
3589 if (NeedNegation) // This technically increases instruction count.
3590 Res = Builder.CreateNot(Res, "umul.not.ov");
3591
3592 return Res;
3593}
3594
Sanjay Patel10494b22016-09-16 16:10:22 +00003595/// Try to fold icmp (binop), X or icmp X, (binop).
Sanjay Patel2df38a82017-05-08 16:21:55 +00003596/// TODO: A large part of this logic is duplicated in InstSimplify's
3597/// simplifyICmpWithBinOp(). We should be able to share that and avoid the code
3598/// duplication.
Sanjay Patel10494b22016-09-16 16:10:22 +00003599Instruction *InstCombiner::foldICmpBinOp(ICmpInst &I) {
3600 Value *Op0 = I.getOperand(0), *Op1 = I.getOperand(1);
3601
3602 // Special logic for binary operators.
3603 BinaryOperator *BO0 = dyn_cast<BinaryOperator>(Op0);
3604 BinaryOperator *BO1 = dyn_cast<BinaryOperator>(Op1);
3605 if (!BO0 && !BO1)
3606 return nullptr;
3607
Sanjay Patel2a062632017-05-08 16:33:42 +00003608 const CmpInst::Predicate Pred = I.getPredicate();
Sanjay Patel1cf07342018-09-11 22:40:20 +00003609 Value *X;
3610
3611 // Convert add-with-unsigned-overflow comparisons into a 'not' with compare.
Roman Lebedevecb7ea12019-09-05 17:40:49 +00003612 // (Op1 + X) u</u>= Op1 --> ~Op1 u</u>= X
Sanjay Patel1cf07342018-09-11 22:40:20 +00003613 if (match(Op0, m_OneUse(m_c_Add(m_Specific(Op1), m_Value(X)))) &&
Roman Lebedevecb7ea12019-09-05 17:40:49 +00003614 (Pred == ICmpInst::ICMP_ULT || Pred == ICmpInst::ICMP_UGE))
Sanjay Patel1cf07342018-09-11 22:40:20 +00003615 return new ICmpInst(Pred, Builder.CreateNot(Op1), X);
Roman Lebedevecb7ea12019-09-05 17:40:49 +00003616 // Op0 u>/u<= (Op0 + X) --> X u>/u<= ~Op0
Sanjay Patel1cf07342018-09-11 22:40:20 +00003617 if (match(Op1, m_OneUse(m_c_Add(m_Specific(Op0), m_Value(X)))) &&
Roman Lebedevecb7ea12019-09-05 17:40:49 +00003618 (Pred == ICmpInst::ICMP_UGT || Pred == ICmpInst::ICMP_ULE))
Sanjay Patel1cf07342018-09-11 22:40:20 +00003619 return new ICmpInst(Pred, X, Builder.CreateNot(Op0));
3620
Sanjay Patel10494b22016-09-16 16:10:22 +00003621 bool NoOp0WrapProblem = false, NoOp1WrapProblem = false;
3622 if (BO0 && isa<OverflowingBinaryOperator>(BO0))
3623 NoOp0WrapProblem =
3624 ICmpInst::isEquality(Pred) ||
3625 (CmpInst::isUnsigned(Pred) && BO0->hasNoUnsignedWrap()) ||
3626 (CmpInst::isSigned(Pred) && BO0->hasNoSignedWrap());
3627 if (BO1 && isa<OverflowingBinaryOperator>(BO1))
3628 NoOp1WrapProblem =
3629 ICmpInst::isEquality(Pred) ||
3630 (CmpInst::isUnsigned(Pred) && BO1->hasNoUnsignedWrap()) ||
3631 (CmpInst::isSigned(Pred) && BO1->hasNoSignedWrap());
3632
3633 // Analyze the case when either Op0 or Op1 is an add instruction.
3634 // Op0 = A + B (or A and B are null); Op1 = C + D (or C and D are null).
3635 Value *A = nullptr, *B = nullptr, *C = nullptr, *D = nullptr;
3636 if (BO0 && BO0->getOpcode() == Instruction::Add) {
3637 A = BO0->getOperand(0);
3638 B = BO0->getOperand(1);
3639 }
3640 if (BO1 && BO1->getOpcode() == Instruction::Add) {
3641 C = BO1->getOperand(0);
3642 D = BO1->getOperand(1);
3643 }
3644
Sanjay Patel10494b22016-09-16 16:10:22 +00003645 // icmp (X+Y), X -> icmp Y, 0 for equalities or if there is no overflow.
3646 if ((A == Op1 || B == Op1) && NoOp0WrapProblem)
3647 return new ICmpInst(Pred, A == Op1 ? B : A,
3648 Constant::getNullValue(Op1->getType()));
3649
3650 // icmp X, (X+Y) -> icmp 0, Y for equalities or if there is no overflow.
3651 if ((C == Op0 || D == Op0) && NoOp1WrapProblem)
3652 return new ICmpInst(Pred, Constant::getNullValue(Op0->getType()),
3653 C == Op0 ? D : C);
3654
3655 // icmp (X+Y), (X+Z) -> icmp Y, Z for equalities or if there is no overflow.
3656 if (A && C && (A == C || A == D || B == C || B == D) && NoOp0WrapProblem &&
3657 NoOp1WrapProblem &&
3658 // Try not to increase register pressure.
3659 BO0->hasOneUse() && BO1->hasOneUse()) {
3660 // Determine Y and Z in the form icmp (X+Y), (X+Z).
3661 Value *Y, *Z;
3662 if (A == C) {
3663 // C + B == C + D -> B == D
3664 Y = B;
3665 Z = D;
3666 } else if (A == D) {
3667 // D + B == C + D -> B == C
3668 Y = B;
3669 Z = C;
3670 } else if (B == C) {
3671 // A + C == C + D -> A == D
3672 Y = A;
3673 Z = D;
3674 } else {
3675 assert(B == D);
3676 // A + D == C + D -> A == C
3677 Y = A;
3678 Z = C;
3679 }
3680 return new ICmpInst(Pred, Y, Z);
3681 }
3682
3683 // icmp slt (X + -1), Y -> icmp sle X, Y
3684 if (A && NoOp0WrapProblem && Pred == CmpInst::ICMP_SLT &&
3685 match(B, m_AllOnes()))
3686 return new ICmpInst(CmpInst::ICMP_SLE, A, Op1);
3687
3688 // icmp sge (X + -1), Y -> icmp sgt X, Y
3689 if (A && NoOp0WrapProblem && Pred == CmpInst::ICMP_SGE &&
3690 match(B, m_AllOnes()))
3691 return new ICmpInst(CmpInst::ICMP_SGT, A, Op1);
3692
3693 // icmp sle (X + 1), Y -> icmp slt X, Y
3694 if (A && NoOp0WrapProblem && Pred == CmpInst::ICMP_SLE && match(B, m_One()))
3695 return new ICmpInst(CmpInst::ICMP_SLT, A, Op1);
3696
3697 // icmp sgt (X + 1), Y -> icmp sge X, Y
3698 if (A && NoOp0WrapProblem && Pred == CmpInst::ICMP_SGT && match(B, m_One()))
3699 return new ICmpInst(CmpInst::ICMP_SGE, A, Op1);
3700
3701 // icmp sgt X, (Y + -1) -> icmp sge X, Y
3702 if (C && NoOp1WrapProblem && Pred == CmpInst::ICMP_SGT &&
3703 match(D, m_AllOnes()))
3704 return new ICmpInst(CmpInst::ICMP_SGE, Op0, C);
3705
3706 // icmp sle X, (Y + -1) -> icmp slt X, Y
3707 if (C && NoOp1WrapProblem && Pred == CmpInst::ICMP_SLE &&
3708 match(D, m_AllOnes()))
3709 return new ICmpInst(CmpInst::ICMP_SLT, Op0, C);
3710
3711 // icmp sge X, (Y + 1) -> icmp sgt X, Y
3712 if (C && NoOp1WrapProblem && Pred == CmpInst::ICMP_SGE && match(D, m_One()))
3713 return new ICmpInst(CmpInst::ICMP_SGT, Op0, C);
3714
3715 // icmp slt X, (Y + 1) -> icmp sle X, Y
3716 if (C && NoOp1WrapProblem && Pred == CmpInst::ICMP_SLT && match(D, m_One()))
3717 return new ICmpInst(CmpInst::ICMP_SLE, Op0, C);
3718
Sanjay Patel40f40172017-01-13 23:25:46 +00003719 // TODO: The subtraction-related identities shown below also hold, but
3720 // canonicalization from (X -nuw 1) to (X + -1) means that the combinations
3721 // wouldn't happen even if they were implemented.
3722 //
3723 // icmp ult (X - 1), Y -> icmp ule X, Y
3724 // icmp uge (X - 1), Y -> icmp ugt X, Y
3725 // icmp ugt X, (Y - 1) -> icmp uge X, Y
3726 // icmp ule X, (Y - 1) -> icmp ult X, Y
3727
3728 // icmp ule (X + 1), Y -> icmp ult X, Y
3729 if (A && NoOp0WrapProblem && Pred == CmpInst::ICMP_ULE && match(B, m_One()))
3730 return new ICmpInst(CmpInst::ICMP_ULT, A, Op1);
3731
3732 // icmp ugt (X + 1), Y -> icmp uge X, Y
3733 if (A && NoOp0WrapProblem && Pred == CmpInst::ICMP_UGT && match(B, m_One()))
3734 return new ICmpInst(CmpInst::ICMP_UGE, A, Op1);
3735
3736 // icmp uge X, (Y + 1) -> icmp ugt X, Y
3737 if (C && NoOp1WrapProblem && Pred == CmpInst::ICMP_UGE && match(D, m_One()))
3738 return new ICmpInst(CmpInst::ICMP_UGT, Op0, C);
3739
3740 // icmp ult X, (Y + 1) -> icmp ule X, Y
3741 if (C && NoOp1WrapProblem && Pred == CmpInst::ICMP_ULT && match(D, m_One()))
3742 return new ICmpInst(CmpInst::ICMP_ULE, Op0, C);
3743
Sanjay Patel10494b22016-09-16 16:10:22 +00003744 // if C1 has greater magnitude than C2:
3745 // icmp (X + C1), (Y + C2) -> icmp (X + C3), Y
3746 // s.t. C3 = C1 - C2
3747 //
3748 // if C2 has greater magnitude than C1:
3749 // icmp (X + C1), (Y + C2) -> icmp X, (Y + C3)
3750 // s.t. C3 = C2 - C1
3751 if (A && C && NoOp0WrapProblem && NoOp1WrapProblem &&
3752 (BO0->hasOneUse() || BO1->hasOneUse()) && !I.isUnsigned())
3753 if (ConstantInt *C1 = dyn_cast<ConstantInt>(B))
3754 if (ConstantInt *C2 = dyn_cast<ConstantInt>(D)) {
3755 const APInt &AP1 = C1->getValue();
3756 const APInt &AP2 = C2->getValue();
3757 if (AP1.isNegative() == AP2.isNegative()) {
3758 APInt AP1Abs = C1->getValue().abs();
3759 APInt AP2Abs = C2->getValue().abs();
3760 if (AP1Abs.uge(AP2Abs)) {
Craig Topperbb4069e2017-07-07 23:16:26 +00003761 ConstantInt *C3 = Builder.getInt(AP1 - AP2);
3762 Value *NewAdd = Builder.CreateNSWAdd(A, C3);
Sanjay Patel10494b22016-09-16 16:10:22 +00003763 return new ICmpInst(Pred, NewAdd, C);
3764 } else {
Craig Topperbb4069e2017-07-07 23:16:26 +00003765 ConstantInt *C3 = Builder.getInt(AP2 - AP1);
3766 Value *NewAdd = Builder.CreateNSWAdd(C, C3);
Sanjay Patel10494b22016-09-16 16:10:22 +00003767 return new ICmpInst(Pred, A, NewAdd);
3768 }
3769 }
3770 }
3771
3772 // Analyze the case when either Op0 or Op1 is a sub instruction.
3773 // Op0 = A - B (or A and B are null); Op1 = C - D (or C and D are null).
3774 A = nullptr;
3775 B = nullptr;
3776 C = nullptr;
3777 D = nullptr;
3778 if (BO0 && BO0->getOpcode() == Instruction::Sub) {
3779 A = BO0->getOperand(0);
3780 B = BO0->getOperand(1);
3781 }
3782 if (BO1 && BO1->getOpcode() == Instruction::Sub) {
3783 C = BO1->getOperand(0);
3784 D = BO1->getOperand(1);
3785 }
3786
3787 // icmp (X-Y), X -> icmp 0, Y for equalities or if there is no overflow.
3788 if (A == Op1 && NoOp0WrapProblem)
3789 return new ICmpInst(Pred, Constant::getNullValue(Op1->getType()), B);
Sanjay Patel10494b22016-09-16 16:10:22 +00003790 // icmp X, (X-Y) -> icmp Y, 0 for equalities or if there is no overflow.
3791 if (C == Op0 && NoOp1WrapProblem)
3792 return new ICmpInst(Pred, D, Constant::getNullValue(Op0->getType()));
3793
Roman Lebedev8360c422019-09-05 17:41:02 +00003794 // Convert sub-with-unsigned-overflow comparisons into a comparison of args.
3795 // (A - B) u>/u<= A --> B u>/u<= A
3796 if (A == Op1 && (Pred == ICmpInst::ICMP_UGT || Pred == ICmpInst::ICMP_ULE))
3797 return new ICmpInst(Pred, B, A);
3798 // C u</u>= (C - D) --> C u</u>= D
3799 if (C == Op0 && (Pred == ICmpInst::ICMP_ULT || Pred == ICmpInst::ICMP_UGE))
3800 return new ICmpInst(Pred, C, D);
Sanjay Patelcbb04502018-04-02 20:37:40 +00003801
Sanjay Patel10494b22016-09-16 16:10:22 +00003802 // icmp (Y-X), (Z-X) -> icmp Y, Z for equalities or if there is no overflow.
3803 if (B && D && B == D && NoOp0WrapProblem && NoOp1WrapProblem &&
3804 // Try not to increase register pressure.
3805 BO0->hasOneUse() && BO1->hasOneUse())
3806 return new ICmpInst(Pred, A, C);
Sanjay Patel10494b22016-09-16 16:10:22 +00003807 // icmp (X-Y), (X-Z) -> icmp Z, Y for equalities or if there is no overflow.
3808 if (A && C && A == C && NoOp0WrapProblem && NoOp1WrapProblem &&
3809 // Try not to increase register pressure.
3810 BO0->hasOneUse() && BO1->hasOneUse())
3811 return new ICmpInst(Pred, D, B);
3812
3813 // icmp (0-X) < cst --> x > -cst
3814 if (NoOp0WrapProblem && ICmpInst::isSigned(Pred)) {
3815 Value *X;
3816 if (match(BO0, m_Neg(m_Value(X))))
Chen Zhengb9722732018-07-16 00:51:40 +00003817 if (Constant *RHSC = dyn_cast<Constant>(Op1))
3818 if (RHSC->isNotMinSignedValue())
Sanjay Patel10494b22016-09-16 16:10:22 +00003819 return new ICmpInst(I.getSwappedPredicate(), X,
3820 ConstantExpr::getNeg(RHSC));
3821 }
3822
3823 BinaryOperator *SRem = nullptr;
3824 // icmp (srem X, Y), Y
3825 if (BO0 && BO0->getOpcode() == Instruction::SRem && Op1 == BO0->getOperand(1))
3826 SRem = BO0;
3827 // icmp Y, (srem X, Y)
3828 else if (BO1 && BO1->getOpcode() == Instruction::SRem &&
3829 Op0 == BO1->getOperand(1))
3830 SRem = BO1;
3831 if (SRem) {
3832 // We don't check hasOneUse to avoid increasing register pressure because
3833 // the value we use is the same value this instruction was already using.
3834 switch (SRem == BO0 ? ICmpInst::getSwappedPredicate(Pred) : Pred) {
3835 default:
3836 break;
3837 case ICmpInst::ICMP_EQ:
3838 return replaceInstUsesWith(I, ConstantInt::getFalse(I.getType()));
3839 case ICmpInst::ICMP_NE:
3840 return replaceInstUsesWith(I, ConstantInt::getTrue(I.getType()));
3841 case ICmpInst::ICMP_SGT:
3842 case ICmpInst::ICMP_SGE:
3843 return new ICmpInst(ICmpInst::ICMP_SGT, SRem->getOperand(1),
3844 Constant::getAllOnesValue(SRem->getType()));
3845 case ICmpInst::ICMP_SLT:
3846 case ICmpInst::ICMP_SLE:
3847 return new ICmpInst(ICmpInst::ICMP_SLT, SRem->getOperand(1),
3848 Constant::getNullValue(SRem->getType()));
3849 }
3850 }
3851
3852 if (BO0 && BO1 && BO0->getOpcode() == BO1->getOpcode() && BO0->hasOneUse() &&
3853 BO1->hasOneUse() && BO0->getOperand(1) == BO1->getOperand(1)) {
3854 switch (BO0->getOpcode()) {
3855 default:
3856 break;
3857 case Instruction::Add:
3858 case Instruction::Sub:
Sanjay Pateld3106ad2017-05-23 17:29:58 +00003859 case Instruction::Xor: {
Sanjay Patel10494b22016-09-16 16:10:22 +00003860 if (I.isEquality()) // a+x icmp eq/ne b+x --> a icmp b
Sanjay Patel2a062632017-05-08 16:33:42 +00003861 return new ICmpInst(Pred, BO0->getOperand(0), BO1->getOperand(0));
Sanjay Pateld3106ad2017-05-23 17:29:58 +00003862
3863 const APInt *C;
3864 if (match(BO0->getOperand(1), m_APInt(C))) {
3865 // icmp u/s (a ^ signmask), (b ^ signmask) --> icmp s/u a, b
3866 if (C->isSignMask()) {
Sanjay Patel2a062632017-05-08 16:33:42 +00003867 ICmpInst::Predicate NewPred =
Sanjay Patel10494b22016-09-16 16:10:22 +00003868 I.isSigned() ? I.getUnsignedPredicate() : I.getSignedPredicate();
Sanjay Patel2a062632017-05-08 16:33:42 +00003869 return new ICmpInst(NewPred, BO0->getOperand(0), BO1->getOperand(0));
Sanjay Patel10494b22016-09-16 16:10:22 +00003870 }
3871
Sanjay Pateld3106ad2017-05-23 17:29:58 +00003872 // icmp u/s (a ^ maxsignval), (b ^ maxsignval) --> icmp s/u' a, b
3873 if (BO0->getOpcode() == Instruction::Xor && C->isMaxSignedValue()) {
Sanjay Patel2a062632017-05-08 16:33:42 +00003874 ICmpInst::Predicate NewPred =
Sanjay Patel10494b22016-09-16 16:10:22 +00003875 I.isSigned() ? I.getUnsignedPredicate() : I.getSignedPredicate();
Sanjay Patel2a062632017-05-08 16:33:42 +00003876 NewPred = I.getSwappedPredicate(NewPred);
3877 return new ICmpInst(NewPred, BO0->getOperand(0), BO1->getOperand(0));
Sanjay Patel10494b22016-09-16 16:10:22 +00003878 }
3879 }
3880 break;
Sanjay Pateld3106ad2017-05-23 17:29:58 +00003881 }
Sanjay Patel07b1ba52017-05-24 22:58:17 +00003882 case Instruction::Mul: {
Sanjay Patel10494b22016-09-16 16:10:22 +00003883 if (!I.isEquality())
3884 break;
3885
Sanjay Patel07b1ba52017-05-24 22:58:17 +00003886 const APInt *C;
Craig Topper73ba1c82017-06-07 07:40:37 +00003887 if (match(BO0->getOperand(1), m_APInt(C)) && !C->isNullValue() &&
3888 !C->isOneValue()) {
Sanjay Patel07b1ba52017-05-24 22:58:17 +00003889 // icmp eq/ne (X * C), (Y * C) --> icmp (X & Mask), (Y & Mask)
3890 // Mask = -1 >> count-trailing-zeros(C).
Sanjay Patel51506122017-05-25 14:13:57 +00003891 if (unsigned TZs = C->countTrailingZeros()) {
Sanjay Patel07b1ba52017-05-24 22:58:17 +00003892 Constant *Mask = ConstantInt::get(
3893 BO0->getType(),
Sanjay Patel51506122017-05-25 14:13:57 +00003894 APInt::getLowBitsSet(C->getBitWidth(), C->getBitWidth() - TZs));
Craig Topperbb4069e2017-07-07 23:16:26 +00003895 Value *And1 = Builder.CreateAnd(BO0->getOperand(0), Mask);
3896 Value *And2 = Builder.CreateAnd(BO1->getOperand(0), Mask);
Sanjay Patel2a062632017-05-08 16:33:42 +00003897 return new ICmpInst(Pred, And1, And2);
Sanjay Patel10494b22016-09-16 16:10:22 +00003898 }
Sanjay Patel51506122017-05-25 14:13:57 +00003899 // If there are no trailing zeros in the multiplier, just eliminate
3900 // the multiplies (no masking is needed):
3901 // icmp eq/ne (X * C), (Y * C) --> icmp eq/ne X, Y
3902 return new ICmpInst(Pred, BO0->getOperand(0), BO1->getOperand(0));
Sanjay Patel10494b22016-09-16 16:10:22 +00003903 }
3904 break;
Sanjay Patel07b1ba52017-05-24 22:58:17 +00003905 }
Sanjay Patel10494b22016-09-16 16:10:22 +00003906 case Instruction::UDiv:
3907 case Instruction::LShr:
Sanjay Patel878715f2017-05-15 19:27:53 +00003908 if (I.isSigned() || !BO0->isExact() || !BO1->isExact())
Sanjay Patel10494b22016-09-16 16:10:22 +00003909 break;
Sanjay Patel878715f2017-05-15 19:27:53 +00003910 return new ICmpInst(Pred, BO0->getOperand(0), BO1->getOperand(0));
3911
Sanjay Patel10494b22016-09-16 16:10:22 +00003912 case Instruction::SDiv:
Sanjay Patel878715f2017-05-15 19:27:53 +00003913 if (!I.isEquality() || !BO0->isExact() || !BO1->isExact())
3914 break;
3915 return new ICmpInst(Pred, BO0->getOperand(0), BO1->getOperand(0));
3916
Sanjay Patel10494b22016-09-16 16:10:22 +00003917 case Instruction::AShr:
3918 if (!BO0->isExact() || !BO1->isExact())
3919 break;
Sanjay Patel2a062632017-05-08 16:33:42 +00003920 return new ICmpInst(Pred, BO0->getOperand(0), BO1->getOperand(0));
Sanjay Patel878715f2017-05-15 19:27:53 +00003921
Sanjay Patel10494b22016-09-16 16:10:22 +00003922 case Instruction::Shl: {
3923 bool NUW = BO0->hasNoUnsignedWrap() && BO1->hasNoUnsignedWrap();
3924 bool NSW = BO0->hasNoSignedWrap() && BO1->hasNoSignedWrap();
3925 if (!NUW && !NSW)
3926 break;
3927 if (!NSW && I.isSigned())
3928 break;
Sanjay Patel2a062632017-05-08 16:33:42 +00003929 return new ICmpInst(Pred, BO0->getOperand(0), BO1->getOperand(0));
Sanjay Patel10494b22016-09-16 16:10:22 +00003930 }
3931 }
3932 }
3933
3934 if (BO0) {
3935 // Transform A & (L - 1) `ult` L --> L != 0
3936 auto LSubOne = m_Add(m_Specific(Op1), m_AllOnes());
Craig Topper72ee6942017-06-24 06:24:01 +00003937 auto BitwiseAnd = m_c_And(m_Value(), LSubOne);
Sanjay Patel10494b22016-09-16 16:10:22 +00003938
Sanjay Patel2a062632017-05-08 16:33:42 +00003939 if (match(BO0, BitwiseAnd) && Pred == ICmpInst::ICMP_ULT) {
Sanjay Patel10494b22016-09-16 16:10:22 +00003940 auto *Zero = Constant::getNullValue(BO0->getType());
3941 return new ICmpInst(ICmpInst::ICMP_NE, Op1, Zero);
3942 }
3943 }
3944
Roman Lebedev473a0632019-08-29 12:47:20 +00003945 if (Value *V = foldUnsignedMultiplicationOverflowCheck(I))
Roman Lebedevfb38b7a2019-08-29 12:47:08 +00003946 return replaceInstUsesWith(I, V);
3947
Roman Lebedev68d54cf2018-07-11 19:05:04 +00003948 if (Value *V = foldICmpWithLowBitMaskedVal(I, Builder))
3949 return replaceInstUsesWith(I, V);
3950
Roman Lebedev3cb87e92018-07-18 10:55:17 +00003951 if (Value *V = foldICmpWithTruncSignExtendedVal(I, Builder))
3952 return replaceInstUsesWith(I, V);
3953
Roman Lebedev72b8d412019-07-01 15:55:15 +00003954 if (Value *V = foldShiftIntoShiftInAnotherHandOfAndInICmp(I, SQ, Builder))
3955 return replaceInstUsesWith(I, V);
3956
Sanjay Patel10494b22016-09-16 16:10:22 +00003957 return nullptr;
3958}
3959
Sanjay Pateldd46b522016-12-19 17:32:37 +00003960/// Fold icmp Pred min|max(X, Y), X.
3961static Instruction *foldICmpWithMinMax(ICmpInst &Cmp) {
Sanjay Pateld6406412016-12-15 19:13:37 +00003962 ICmpInst::Predicate Pred = Cmp.getPredicate();
3963 Value *Op0 = Cmp.getOperand(0);
3964 Value *X = Cmp.getOperand(1);
3965
Sanjay Pateldd46b522016-12-19 17:32:37 +00003966 // Canonicalize minimum or maximum operand to LHS of the icmp.
Sanjay Patel8296c6c2016-12-19 16:28:53 +00003967 if (match(X, m_c_SMin(m_Specific(Op0), m_Value())) ||
Sanjay Pateldd46b522016-12-19 17:32:37 +00003968 match(X, m_c_SMax(m_Specific(Op0), m_Value())) ||
3969 match(X, m_c_UMin(m_Specific(Op0), m_Value())) ||
3970 match(X, m_c_UMax(m_Specific(Op0), m_Value()))) {
Sanjay Pateld6406412016-12-15 19:13:37 +00003971 std::swap(Op0, X);
3972 Pred = Cmp.getSwappedPredicate();
3973 }
3974
3975 Value *Y;
Sanjay Patel8296c6c2016-12-19 16:28:53 +00003976 if (match(Op0, m_c_SMin(m_Specific(X), m_Value(Y)))) {
Sanjay Pateldd46b522016-12-19 17:32:37 +00003977 // smin(X, Y) == X --> X s<= Y
3978 // smin(X, Y) s>= X --> X s<= Y
Sanjay Patel8296c6c2016-12-19 16:28:53 +00003979 if (Pred == CmpInst::ICMP_EQ || Pred == CmpInst::ICMP_SGE)
3980 return new ICmpInst(ICmpInst::ICMP_SLE, X, Y);
3981
Sanjay Pateldd46b522016-12-19 17:32:37 +00003982 // smin(X, Y) != X --> X s> Y
3983 // smin(X, Y) s< X --> X s> Y
Sanjay Patel8296c6c2016-12-19 16:28:53 +00003984 if (Pred == CmpInst::ICMP_NE || Pred == CmpInst::ICMP_SLT)
3985 return new ICmpInst(ICmpInst::ICMP_SGT, X, Y);
3986
3987 // These cases should be handled in InstSimplify:
Sanjay Pateldd46b522016-12-19 17:32:37 +00003988 // smin(X, Y) s<= X --> true
3989 // smin(X, Y) s> X --> false
Sanjay Pateld6406412016-12-15 19:13:37 +00003990 return nullptr;
Sanjay Patel8296c6c2016-12-19 16:28:53 +00003991 }
Sanjay Pateldd46b522016-12-19 17:32:37 +00003992
Sanjay Patel8296c6c2016-12-19 16:28:53 +00003993 if (match(Op0, m_c_SMax(m_Specific(X), m_Value(Y)))) {
Sanjay Pateldd46b522016-12-19 17:32:37 +00003994 // smax(X, Y) == X --> X s>= Y
3995 // smax(X, Y) s<= X --> X s>= Y
Sanjay Patel8296c6c2016-12-19 16:28:53 +00003996 if (Pred == CmpInst::ICMP_EQ || Pred == CmpInst::ICMP_SLE)
3997 return new ICmpInst(ICmpInst::ICMP_SGE, X, Y);
Sanjay Pateld6406412016-12-15 19:13:37 +00003998
Sanjay Pateldd46b522016-12-19 17:32:37 +00003999 // smax(X, Y) != X --> X s< Y
4000 // smax(X, Y) s> X --> X s< Y
Sanjay Patel8296c6c2016-12-19 16:28:53 +00004001 if (Pred == CmpInst::ICMP_NE || Pred == CmpInst::ICMP_SGT)
4002 return new ICmpInst(ICmpInst::ICMP_SLT, X, Y);
Sanjay Pateld6406412016-12-15 19:13:37 +00004003
Sanjay Patel8296c6c2016-12-19 16:28:53 +00004004 // These cases should be handled in InstSimplify:
Sanjay Pateldd46b522016-12-19 17:32:37 +00004005 // smax(X, Y) s>= X --> true
4006 // smax(X, Y) s< X --> false
4007 return nullptr;
4008 }
4009
4010 if (match(Op0, m_c_UMin(m_Specific(X), m_Value(Y)))) {
4011 // umin(X, Y) == X --> X u<= Y
4012 // umin(X, Y) u>= X --> X u<= Y
4013 if (Pred == CmpInst::ICMP_EQ || Pred == CmpInst::ICMP_UGE)
4014 return new ICmpInst(ICmpInst::ICMP_ULE, X, Y);
4015
4016 // umin(X, Y) != X --> X u> Y
4017 // umin(X, Y) u< X --> X u> Y
4018 if (Pred == CmpInst::ICMP_NE || Pred == CmpInst::ICMP_ULT)
4019 return new ICmpInst(ICmpInst::ICMP_UGT, X, Y);
4020
4021 // These cases should be handled in InstSimplify:
4022 // umin(X, Y) u<= X --> true
4023 // umin(X, Y) u> X --> false
4024 return nullptr;
4025 }
4026
4027 if (match(Op0, m_c_UMax(m_Specific(X), m_Value(Y)))) {
4028 // umax(X, Y) == X --> X u>= Y
4029 // umax(X, Y) u<= X --> X u>= Y
4030 if (Pred == CmpInst::ICMP_EQ || Pred == CmpInst::ICMP_ULE)
4031 return new ICmpInst(ICmpInst::ICMP_UGE, X, Y);
4032
4033 // umax(X, Y) != X --> X u< Y
4034 // umax(X, Y) u> X --> X u< Y
4035 if (Pred == CmpInst::ICMP_NE || Pred == CmpInst::ICMP_UGT)
4036 return new ICmpInst(ICmpInst::ICMP_ULT, X, Y);
4037
4038 // These cases should be handled in InstSimplify:
4039 // umax(X, Y) u>= X --> true
4040 // umax(X, Y) u< X --> false
Sanjay Patel8296c6c2016-12-19 16:28:53 +00004041 return nullptr;
4042 }
Sanjay Pateld6406412016-12-15 19:13:37 +00004043
Sanjay Pateld6406412016-12-15 19:13:37 +00004044 return nullptr;
4045}
4046
Sanjay Patel10494b22016-09-16 16:10:22 +00004047Instruction *InstCombiner::foldICmpEquality(ICmpInst &I) {
4048 if (!I.isEquality())
4049 return nullptr;
4050
4051 Value *Op0 = I.getOperand(0), *Op1 = I.getOperand(1);
Sanjay Patel4e96f192017-06-28 16:39:06 +00004052 const CmpInst::Predicate Pred = I.getPredicate();
Sanjay Patel10494b22016-09-16 16:10:22 +00004053 Value *A, *B, *C, *D;
4054 if (match(Op0, m_Xor(m_Value(A), m_Value(B)))) {
4055 if (A == Op1 || B == Op1) { // (A^B) == A -> B == 0
4056 Value *OtherVal = A == Op1 ? B : A;
Sanjay Patel4e96f192017-06-28 16:39:06 +00004057 return new ICmpInst(Pred, OtherVal, Constant::getNullValue(A->getType()));
Sanjay Patel10494b22016-09-16 16:10:22 +00004058 }
4059
4060 if (match(Op1, m_Xor(m_Value(C), m_Value(D)))) {
4061 // A^c1 == C^c2 --> A == C^(c1^c2)
4062 ConstantInt *C1, *C2;
4063 if (match(B, m_ConstantInt(C1)) && match(D, m_ConstantInt(C2)) &&
4064 Op1->hasOneUse()) {
Craig Topperbb4069e2017-07-07 23:16:26 +00004065 Constant *NC = Builder.getInt(C1->getValue() ^ C2->getValue());
4066 Value *Xor = Builder.CreateXor(C, NC);
Sanjay Patel4e96f192017-06-28 16:39:06 +00004067 return new ICmpInst(Pred, A, Xor);
Sanjay Patel10494b22016-09-16 16:10:22 +00004068 }
4069
4070 // A^B == A^D -> B == D
4071 if (A == C)
Sanjay Patel4e96f192017-06-28 16:39:06 +00004072 return new ICmpInst(Pred, B, D);
Sanjay Patel10494b22016-09-16 16:10:22 +00004073 if (A == D)
Sanjay Patel4e96f192017-06-28 16:39:06 +00004074 return new ICmpInst(Pred, B, C);
Sanjay Patel10494b22016-09-16 16:10:22 +00004075 if (B == C)
Sanjay Patel4e96f192017-06-28 16:39:06 +00004076 return new ICmpInst(Pred, A, D);
Sanjay Patel10494b22016-09-16 16:10:22 +00004077 if (B == D)
Sanjay Patel4e96f192017-06-28 16:39:06 +00004078 return new ICmpInst(Pred, A, C);
Sanjay Patel10494b22016-09-16 16:10:22 +00004079 }
4080 }
4081
4082 if (match(Op1, m_Xor(m_Value(A), m_Value(B))) && (A == Op0 || B == Op0)) {
4083 // A == (A^B) -> B == 0
4084 Value *OtherVal = A == Op0 ? B : A;
Sanjay Patel4e96f192017-06-28 16:39:06 +00004085 return new ICmpInst(Pred, OtherVal, Constant::getNullValue(A->getType()));
Sanjay Patel10494b22016-09-16 16:10:22 +00004086 }
4087
4088 // (X&Z) == (Y&Z) -> (X^Y) & Z == 0
4089 if (match(Op0, m_OneUse(m_And(m_Value(A), m_Value(B)))) &&
4090 match(Op1, m_OneUse(m_And(m_Value(C), m_Value(D))))) {
4091 Value *X = nullptr, *Y = nullptr, *Z = nullptr;
4092
4093 if (A == C) {
4094 X = B;
4095 Y = D;
4096 Z = A;
4097 } else if (A == D) {
4098 X = B;
4099 Y = C;
4100 Z = A;
4101 } else if (B == C) {
4102 X = A;
4103 Y = D;
4104 Z = B;
4105 } else if (B == D) {
4106 X = A;
4107 Y = C;
4108 Z = B;
4109 }
4110
4111 if (X) { // Build (X^Y) & Z
Craig Topperbb4069e2017-07-07 23:16:26 +00004112 Op1 = Builder.CreateXor(X, Y);
4113 Op1 = Builder.CreateAnd(Op1, Z);
Sanjay Patel10494b22016-09-16 16:10:22 +00004114 I.setOperand(0, Op1);
4115 I.setOperand(1, Constant::getNullValue(Op1->getType()));
4116 return &I;
4117 }
4118 }
4119
4120 // Transform (zext A) == (B & (1<<X)-1) --> A == (trunc B)
4121 // and (B & (1<<X)-1) == (zext A) --> A == (trunc B)
4122 ConstantInt *Cst1;
4123 if ((Op0->hasOneUse() && match(Op0, m_ZExt(m_Value(A))) &&
4124 match(Op1, m_And(m_Value(B), m_ConstantInt(Cst1)))) ||
4125 (Op1->hasOneUse() && match(Op0, m_And(m_Value(B), m_ConstantInt(Cst1))) &&
4126 match(Op1, m_ZExt(m_Value(A))))) {
4127 APInt Pow2 = Cst1->getValue() + 1;
4128 if (Pow2.isPowerOf2() && isa<IntegerType>(A->getType()) &&
4129 Pow2.logBase2() == cast<IntegerType>(A->getType())->getBitWidth())
Craig Topperbb4069e2017-07-07 23:16:26 +00004130 return new ICmpInst(Pred, A, Builder.CreateTrunc(B, A->getType()));
Sanjay Patel10494b22016-09-16 16:10:22 +00004131 }
4132
4133 // (A >> C) == (B >> C) --> (A^B) u< (1 << C)
4134 // For lshr and ashr pairs.
4135 if ((match(Op0, m_OneUse(m_LShr(m_Value(A), m_ConstantInt(Cst1)))) &&
4136 match(Op1, m_OneUse(m_LShr(m_Value(B), m_Specific(Cst1))))) ||
4137 (match(Op0, m_OneUse(m_AShr(m_Value(A), m_ConstantInt(Cst1)))) &&
4138 match(Op1, m_OneUse(m_AShr(m_Value(B), m_Specific(Cst1)))))) {
4139 unsigned TypeBits = Cst1->getBitWidth();
4140 unsigned ShAmt = (unsigned)Cst1->getLimitedValue(TypeBits);
4141 if (ShAmt < TypeBits && ShAmt != 0) {
Sanjay Patel4e96f192017-06-28 16:39:06 +00004142 ICmpInst::Predicate NewPred =
4143 Pred == ICmpInst::ICMP_NE ? ICmpInst::ICMP_UGE : ICmpInst::ICMP_ULT;
Craig Topperbb4069e2017-07-07 23:16:26 +00004144 Value *Xor = Builder.CreateXor(A, B, I.getName() + ".unshifted");
Sanjay Patel10494b22016-09-16 16:10:22 +00004145 APInt CmpVal = APInt::getOneBitSet(TypeBits, ShAmt);
Craig Topperbb4069e2017-07-07 23:16:26 +00004146 return new ICmpInst(NewPred, Xor, Builder.getInt(CmpVal));
Sanjay Patel10494b22016-09-16 16:10:22 +00004147 }
4148 }
4149
4150 // (A << C) == (B << C) --> ((A^B) & (~0U >> C)) == 0
4151 if (match(Op0, m_OneUse(m_Shl(m_Value(A), m_ConstantInt(Cst1)))) &&
4152 match(Op1, m_OneUse(m_Shl(m_Value(B), m_Specific(Cst1))))) {
4153 unsigned TypeBits = Cst1->getBitWidth();
4154 unsigned ShAmt = (unsigned)Cst1->getLimitedValue(TypeBits);
4155 if (ShAmt < TypeBits && ShAmt != 0) {
Craig Topperbb4069e2017-07-07 23:16:26 +00004156 Value *Xor = Builder.CreateXor(A, B, I.getName() + ".unshifted");
Sanjay Patel10494b22016-09-16 16:10:22 +00004157 APInt AndVal = APInt::getLowBitsSet(TypeBits, TypeBits - ShAmt);
Craig Topperbb4069e2017-07-07 23:16:26 +00004158 Value *And = Builder.CreateAnd(Xor, Builder.getInt(AndVal),
Sanjay Patel10494b22016-09-16 16:10:22 +00004159 I.getName() + ".mask");
Sanjay Patel4e96f192017-06-28 16:39:06 +00004160 return new ICmpInst(Pred, And, Constant::getNullValue(Cst1->getType()));
Sanjay Patel10494b22016-09-16 16:10:22 +00004161 }
4162 }
4163
4164 // Transform "icmp eq (trunc (lshr(X, cst1)), cst" to
4165 // "icmp (and X, mask), cst"
4166 uint64_t ShAmt = 0;
4167 if (Op0->hasOneUse() &&
4168 match(Op0, m_Trunc(m_OneUse(m_LShr(m_Value(A), m_ConstantInt(ShAmt))))) &&
4169 match(Op1, m_ConstantInt(Cst1)) &&
4170 // Only do this when A has multiple uses. This is most important to do
4171 // when it exposes other optimizations.
4172 !A->hasOneUse()) {
4173 unsigned ASize = cast<IntegerType>(A->getType())->getPrimitiveSizeInBits();
4174
4175 if (ShAmt < ASize) {
4176 APInt MaskV =
4177 APInt::getLowBitsSet(ASize, Op0->getType()->getPrimitiveSizeInBits());
4178 MaskV <<= ShAmt;
4179
4180 APInt CmpV = Cst1->getValue().zext(ASize);
4181 CmpV <<= ShAmt;
4182
Craig Topperbb4069e2017-07-07 23:16:26 +00004183 Value *Mask = Builder.CreateAnd(A, Builder.getInt(MaskV));
4184 return new ICmpInst(Pred, Mask, Builder.getInt(CmpV));
Sanjay Patel10494b22016-09-16 16:10:22 +00004185 }
4186 }
4187
Sanjay Patelc3d5cf02017-07-02 14:34:50 +00004188 // If both operands are byte-swapped or bit-reversed, just compare the
4189 // original values.
4190 // TODO: Move this to a function similar to foldICmpIntrinsicWithConstant()
4191 // and handle more intrinsics.
4192 if ((match(Op0, m_BSwap(m_Value(A))) && match(Op1, m_BSwap(m_Value(B)))) ||
Simon Pilgrimdf2657a2017-07-02 16:31:16 +00004193 (match(Op0, m_BitReverse(m_Value(A))) &&
4194 match(Op1, m_BitReverse(m_Value(B)))))
Sanjay Patelc3d5cf02017-07-02 14:34:50 +00004195 return new ICmpInst(Pred, A, B);
4196
Sanjay Patel63311bf2019-06-20 17:41:15 +00004197 // Canonicalize checking for a power-of-2-or-zero value:
Sanjay Patelddc1b402019-07-01 22:00:00 +00004198 // (A & (A-1)) == 0 --> ctpop(A) < 2 (two commuted variants)
4199 // ((A-1) & A) != 0 --> ctpop(A) > 1 (two commuted variants)
4200 if (!match(Op0, m_OneUse(m_c_And(m_Add(m_Value(A), m_AllOnes()),
4201 m_Deferred(A)))) ||
4202 !match(Op1, m_ZeroInt()))
4203 A = nullptr;
4204
Sanjay Patelfcfa0562019-06-25 18:51:44 +00004205 // (A & -A) == A --> ctpop(A) < 2 (four commuted variants)
4206 // (-A & A) != A --> ctpop(A) > 1 (four commuted variants)
Sanjay Patelfcfa0562019-06-25 18:51:44 +00004207 if (match(Op0, m_OneUse(m_c_And(m_Neg(m_Specific(Op1)), m_Specific(Op1)))))
Sanjay Patel63311bf2019-06-20 17:41:15 +00004208 A = Op1;
Sanjay Patelfcfa0562019-06-25 18:51:44 +00004209 else if (match(Op1,
4210 m_OneUse(m_c_And(m_Neg(m_Specific(Op0)), m_Specific(Op0)))))
Sanjay Patel63311bf2019-06-20 17:41:15 +00004211 A = Op0;
Sanjay Patelfcfa0562019-06-25 18:51:44 +00004212
Sanjay Patel63311bf2019-06-20 17:41:15 +00004213 if (A) {
4214 Type *Ty = A->getType();
Sanjay Patelfcfa0562019-06-25 18:51:44 +00004215 CallInst *CtPop = Builder.CreateUnaryIntrinsic(Intrinsic::ctpop, A);
4216 return Pred == ICmpInst::ICMP_EQ
4217 ? new ICmpInst(ICmpInst::ICMP_ULT, CtPop, ConstantInt::get(Ty, 2))
4218 : new ICmpInst(ICmpInst::ICMP_UGT, CtPop, ConstantInt::get(Ty, 1));
Sanjay Patel63311bf2019-06-20 17:41:15 +00004219 }
4220
Sanjay Patel10494b22016-09-16 16:10:22 +00004221 return nullptr;
4222}
4223
Sanjay Patele7282592019-08-21 11:56:08 +00004224static Instruction *foldICmpWithZextOrSext(ICmpInst &ICmp,
4225 InstCombiner::BuilderTy &Builder) {
Sanjay Patel292b1082019-08-20 18:15:17 +00004226 assert(isa<CastInst>(ICmp.getOperand(0)) && "Expected cast for operand 0");
4227 auto *CastOp0 = cast<CastInst>(ICmp.getOperand(0));
4228 Value *X;
4229 if (!match(CastOp0, m_ZExtOrSExt(m_Value(X))))
4230 return nullptr;
4231
4232 bool IsSignedExt = CastOp0->getOpcode() == Instruction::SExt;
4233 bool IsSignedCmp = ICmp.isSigned();
4234 if (auto *CastOp1 = dyn_cast<CastInst>(ICmp.getOperand(1))) {
4235 // If the signedness of the two casts doesn't agree (i.e. one is a sext
4236 // and the other is a zext), then we can't handle this.
Sanjay Patele7282592019-08-21 11:56:08 +00004237 // TODO: This is too strict. We can handle some predicates (equality?).
Sanjay Patel292b1082019-08-20 18:15:17 +00004238 if (CastOp0->getOpcode() != CastOp1->getOpcode())
4239 return nullptr;
4240
4241 // Not an extension from the same type?
Sanjay Patel292b1082019-08-20 18:15:17 +00004242 Value *Y = CastOp1->getOperand(0);
Sanjay Patele7282592019-08-21 11:56:08 +00004243 Type *XTy = X->getType(), *YTy = Y->getType();
4244 if (XTy != YTy) {
4245 // One of the casts must have one use because we are creating a new cast.
4246 if (!CastOp0->hasOneUse() && !CastOp1->hasOneUse())
4247 return nullptr;
4248 // Extend the narrower operand to the type of the wider operand.
4249 if (XTy->getScalarSizeInBits() < YTy->getScalarSizeInBits())
4250 X = Builder.CreateCast(CastOp0->getOpcode(), X, YTy);
4251 else if (YTy->getScalarSizeInBits() < XTy->getScalarSizeInBits())
4252 Y = Builder.CreateCast(CastOp0->getOpcode(), Y, XTy);
4253 else
4254 return nullptr;
4255 }
Sanjay Patel292b1082019-08-20 18:15:17 +00004256
4257 // (zext X) == (zext Y) --> X == Y
4258 // (sext X) == (sext Y) --> X == Y
4259 if (ICmp.isEquality())
4260 return new ICmpInst(ICmp.getPredicate(), X, Y);
4261
4262 // A signed comparison of sign extended values simplifies into a
4263 // signed comparison.
4264 if (IsSignedCmp && IsSignedExt)
4265 return new ICmpInst(ICmp.getPredicate(), X, Y);
4266
4267 // The other three cases all fold into an unsigned comparison.
4268 return new ICmpInst(ICmp.getUnsignedPredicate(), X, Y);
4269 }
4270
4271 // Below here, we are only folding a compare with constant.
4272 auto *C = dyn_cast<Constant>(ICmp.getOperand(1));
4273 if (!C)
4274 return nullptr;
4275
4276 // Compute the constant that would happen if we truncated to SrcTy then
4277 // re-extended to DestTy.
4278 Type *SrcTy = CastOp0->getSrcTy();
4279 Type *DestTy = CastOp0->getDestTy();
4280 Constant *Res1 = ConstantExpr::getTrunc(C, SrcTy);
4281 Constant *Res2 = ConstantExpr::getCast(CastOp0->getOpcode(), Res1, DestTy);
4282
4283 // If the re-extended constant didn't change...
4284 if (Res2 == C) {
4285 if (ICmp.isEquality())
4286 return new ICmpInst(ICmp.getPredicate(), X, Res1);
4287
4288 // A signed comparison of sign extended values simplifies into a
4289 // signed comparison.
4290 if (IsSignedExt && IsSignedCmp)
4291 return new ICmpInst(ICmp.getPredicate(), X, Res1);
4292
4293 // The other three cases all fold into an unsigned comparison.
4294 return new ICmpInst(ICmp.getUnsignedPredicate(), X, Res1);
4295 }
4296
4297 // The re-extended constant changed, partly changed (in the case of a vector),
4298 // or could not be determined to be equal (in the case of a constant
4299 // expression), so the constant cannot be represented in the shorter type.
4300 // All the cases that fold to true or false will have already been handled
4301 // by SimplifyICmpInst, so only deal with the tricky case.
4302 if (IsSignedCmp || !IsSignedExt || !isa<ConstantInt>(C))
4303 return nullptr;
4304
4305 // Is source op positive?
4306 // icmp ult (sext X), C --> icmp sgt X, -1
4307 if (ICmp.getPredicate() == ICmpInst::ICMP_ULT)
4308 return new ICmpInst(CmpInst::ICMP_SGT, X, Constant::getAllOnesValue(SrcTy));
4309
4310 // Is source op negative?
4311 // icmp ugt (sext X), C --> icmp slt X, 0
4312 assert(ICmp.getPredicate() == ICmpInst::ICMP_UGT && "ICmp should be folded!");
4313 return new ICmpInst(CmpInst::ICMP_SLT, X, Constant::getNullValue(SrcTy));
4314}
4315
Sanjay Patela90ee0e2019-08-20 14:56:44 +00004316/// Handle icmp (cast x), (cast or constant).
4317Instruction *InstCombiner::foldICmpWithCastOp(ICmpInst &ICmp) {
4318 auto *CastOp0 = dyn_cast<CastInst>(ICmp.getOperand(0));
4319 if (!CastOp0)
4320 return nullptr;
4321 if (!isa<Constant>(ICmp.getOperand(1)) && !isa<CastInst>(ICmp.getOperand(1)))
4322 return nullptr;
4323
4324 Value *Op0Src = CastOp0->getOperand(0);
4325 Type *SrcTy = CastOp0->getSrcTy();
4326 Type *DestTy = CastOp0->getDestTy();
Chris Lattner2188e402010-01-04 07:37:31 +00004327
Jim Grosbach129c52a2011-09-30 18:09:53 +00004328 // Turn icmp (ptrtoint x), (ptrtoint/c) into a compare of the input if the
Chris Lattner2188e402010-01-04 07:37:31 +00004329 // integer type is the same size as the pointer type.
Sanjay Patela90ee0e2019-08-20 14:56:44 +00004330 auto CompatibleSizes = [&](Type *SrcTy, Type *DestTy) {
Daniel Neilsonbdda1152018-03-05 18:05:51 +00004331 if (isa<VectorType>(SrcTy)) {
4332 SrcTy = cast<VectorType>(SrcTy)->getElementType();
4333 DestTy = cast<VectorType>(DestTy)->getElementType();
4334 }
4335 return DL.getPointerTypeSizeInBits(SrcTy) == DestTy->getIntegerBitWidth();
4336 };
Sanjay Patela90ee0e2019-08-20 14:56:44 +00004337 if (CastOp0->getOpcode() == Instruction::PtrToInt &&
Daniel Neilsonbdda1152018-03-05 18:05:51 +00004338 CompatibleSizes(SrcTy, DestTy)) {
Sanjay Patela90ee0e2019-08-20 14:56:44 +00004339 Value *NewOp1 = nullptr;
4340 if (auto *PtrToIntOp1 = dyn_cast<PtrToIntOperator>(ICmp.getOperand(1))) {
4341 Value *PtrSrc = PtrToIntOp1->getOperand(0);
4342 if (PtrSrc->getType()->getPointerAddressSpace() ==
4343 Op0Src->getType()->getPointerAddressSpace()) {
4344 NewOp1 = PtrToIntOp1->getOperand(0);
Michael Liaod266b922015-02-13 04:51:26 +00004345 // If the pointer types don't match, insert a bitcast.
Sanjay Patela90ee0e2019-08-20 14:56:44 +00004346 if (Op0Src->getType() != NewOp1->getType())
4347 NewOp1 = Builder.CreateBitCast(NewOp1, Op0Src->getType());
Michael Liaod266b922015-02-13 04:51:26 +00004348 }
Sanjay Patel6f8f47b2016-06-05 00:12:32 +00004349 } else if (auto *RHSC = dyn_cast<Constant>(ICmp.getOperand(1))) {
Sanjay Patela90ee0e2019-08-20 14:56:44 +00004350 NewOp1 = ConstantExpr::getIntToPtr(RHSC, SrcTy);
Sanjay Patel6f8f47b2016-06-05 00:12:32 +00004351 }
Chris Lattner2188e402010-01-04 07:37:31 +00004352
Sanjay Patela90ee0e2019-08-20 14:56:44 +00004353 if (NewOp1)
4354 return new ICmpInst(ICmp.getPredicate(), Op0Src, NewOp1);
Chris Lattner2188e402010-01-04 07:37:31 +00004355 }
Jim Grosbach129c52a2011-09-30 18:09:53 +00004356
Sanjay Patele7282592019-08-21 11:56:08 +00004357 return foldICmpWithZextOrSext(ICmp, Builder);
Chris Lattner2188e402010-01-04 07:37:31 +00004358}
4359
Nikita Popov39f2beb2019-05-26 11:43:37 +00004360static bool isNeutralValue(Instruction::BinaryOps BinaryOp, Value *RHS) {
4361 switch (BinaryOp) {
4362 default:
4363 llvm_unreachable("Unsupported binary op");
4364 case Instruction::Add:
4365 case Instruction::Sub:
4366 return match(RHS, m_Zero());
4367 case Instruction::Mul:
4368 return match(RHS, m_One());
4369 }
4370}
4371
4372OverflowResult InstCombiner::computeOverflow(
4373 Instruction::BinaryOps BinaryOp, bool IsSigned,
4374 Value *LHS, Value *RHS, Instruction *CxtI) const {
4375 switch (BinaryOp) {
4376 default:
4377 llvm_unreachable("Unsupported binary op");
4378 case Instruction::Add:
4379 if (IsSigned)
4380 return computeOverflowForSignedAdd(LHS, RHS, CxtI);
4381 else
4382 return computeOverflowForUnsignedAdd(LHS, RHS, CxtI);
4383 case Instruction::Sub:
4384 if (IsSigned)
4385 return computeOverflowForSignedSub(LHS, RHS, CxtI);
4386 else
4387 return computeOverflowForUnsignedSub(LHS, RHS, CxtI);
4388 case Instruction::Mul:
4389 if (IsSigned)
4390 return computeOverflowForSignedMul(LHS, RHS, CxtI);
4391 else
4392 return computeOverflowForUnsignedMul(LHS, RHS, CxtI);
4393 }
4394}
4395
Nikita Popov352f5982019-05-26 11:43:31 +00004396bool InstCombiner::OptimizeOverflowCheck(
4397 Instruction::BinaryOps BinaryOp, bool IsSigned, Value *LHS, Value *RHS,
4398 Instruction &OrigI, Value *&Result, Constant *&Overflow) {
Sanjoy Das827529e2015-08-11 21:33:55 +00004399 if (OrigI.isCommutative() && isa<Constant>(LHS) && !isa<Constant>(RHS))
4400 std::swap(LHS, RHS);
Sanjoy Dasb0984472015-04-08 04:27:22 +00004401
Sanjoy Das6f5dca72015-08-28 19:09:31 +00004402 // If the overflow check was an add followed by a compare, the insertion point
4403 // may be pointing to the compare. We want to insert the new instructions
4404 // before the add in case there are uses of the add between the add and the
4405 // compare.
Craig Topperbb4069e2017-07-07 23:16:26 +00004406 Builder.SetInsertPoint(&OrigI);
Sanjoy Das6f5dca72015-08-28 19:09:31 +00004407
Nikita Popov39f2beb2019-05-26 11:43:37 +00004408 if (isNeutralValue(BinaryOp, RHS)) {
4409 Result = LHS;
4410 Overflow = Builder.getFalse();
4411 return true;
Sanjoy Dasb0984472015-04-08 04:27:22 +00004412 }
4413
Nikita Popov39f2beb2019-05-26 11:43:37 +00004414 switch (computeOverflow(BinaryOp, IsSigned, LHS, RHS, &OrigI)) {
4415 case OverflowResult::MayOverflow:
4416 return false;
Nikita Popov332c1002019-05-28 18:08:31 +00004417 case OverflowResult::AlwaysOverflowsLow:
4418 case OverflowResult::AlwaysOverflowsHigh:
Nikita Popov39f2beb2019-05-26 11:43:37 +00004419 Result = Builder.CreateBinOp(BinaryOp, LHS, RHS);
4420 Result->takeName(&OrigI);
4421 Overflow = Builder.getTrue();
4422 return true;
4423 case OverflowResult::NeverOverflows:
4424 Result = Builder.CreateBinOp(BinaryOp, LHS, RHS);
4425 Result->takeName(&OrigI);
4426 Overflow = Builder.getFalse();
4427 if (auto *Inst = dyn_cast<Instruction>(Result)) {
4428 if (IsSigned)
4429 Inst->setHasNoSignedWrap();
4430 else
4431 Inst->setHasNoUnsignedWrap();
4432 }
4433 return true;
Sanjoy Dasb0984472015-04-08 04:27:22 +00004434 }
4435
Nikita Popov39f2beb2019-05-26 11:43:37 +00004436 llvm_unreachable("Unexpected overflow result");
Sanjoy Dasb0984472015-04-08 04:27:22 +00004437}
4438
Adrian Prantl5f8f34e42018-05-01 15:54:18 +00004439/// Recognize and process idiom involving test for multiplication
Serge Pavlov4bb54d52014-04-13 18:23:41 +00004440/// overflow.
4441///
4442/// The caller has matched a pattern of the form:
4443/// I = cmp u (mul(zext A, zext B), V
4444/// The function checks if this is a test for overflow and if so replaces
4445/// multiplication with call to 'mul.with.overflow' intrinsic.
4446///
4447/// \param I Compare instruction.
4448/// \param MulVal Result of 'mult' instruction. It is one of the arguments of
4449/// the compare instruction. Must be of integer type.
4450/// \param OtherVal The other argument of compare instruction.
4451/// \returns Instruction which must replace the compare instruction, NULL if no
4452/// replacement required.
Sanjay Pateld93c4c02016-09-15 18:22:25 +00004453static Instruction *processUMulZExtIdiom(ICmpInst &I, Value *MulVal,
Serge Pavlov4bb54d52014-04-13 18:23:41 +00004454 Value *OtherVal, InstCombiner &IC) {
Benjamin Kramerc96a7f82014-06-24 10:47:52 +00004455 // Don't bother doing this transformation for pointers, don't do it for
4456 // vectors.
4457 if (!isa<IntegerType>(MulVal->getType()))
4458 return nullptr;
4459
Serge Pavlov4bb54d52014-04-13 18:23:41 +00004460 assert(I.getOperand(0) == MulVal || I.getOperand(1) == MulVal);
4461 assert(I.getOperand(0) == OtherVal || I.getOperand(1) == OtherVal);
David Majnemerdaa24b92015-09-05 20:44:56 +00004462 auto *MulInstr = dyn_cast<Instruction>(MulVal);
4463 if (!MulInstr)
4464 return nullptr;
Serge Pavlov4bb54d52014-04-13 18:23:41 +00004465 assert(MulInstr->getOpcode() == Instruction::Mul);
4466
David Majnemer634ca232014-11-01 23:46:05 +00004467 auto *LHS = cast<ZExtOperator>(MulInstr->getOperand(0)),
4468 *RHS = cast<ZExtOperator>(MulInstr->getOperand(1));
Serge Pavlov4bb54d52014-04-13 18:23:41 +00004469 assert(LHS->getOpcode() == Instruction::ZExt);
4470 assert(RHS->getOpcode() == Instruction::ZExt);
4471 Value *A = LHS->getOperand(0), *B = RHS->getOperand(0);
4472
4473 // Calculate type and width of the result produced by mul.with.overflow.
4474 Type *TyA = A->getType(), *TyB = B->getType();
4475 unsigned WidthA = TyA->getPrimitiveSizeInBits(),
4476 WidthB = TyB->getPrimitiveSizeInBits();
4477 unsigned MulWidth;
4478 Type *MulType;
4479 if (WidthB > WidthA) {
4480 MulWidth = WidthB;
4481 MulType = TyB;
4482 } else {
4483 MulWidth = WidthA;
4484 MulType = TyA;
4485 }
4486
4487 // In order to replace the original mul with a narrower mul.with.overflow,
4488 // all uses must ignore upper bits of the product. The number of used low
4489 // bits must be not greater than the width of mul.with.overflow.
4490 if (MulVal->hasNUsesOrMore(2))
4491 for (User *U : MulVal->users()) {
4492 if (U == &I)
4493 continue;
4494 if (TruncInst *TI = dyn_cast<TruncInst>(U)) {
4495 // Check if truncation ignores bits above MulWidth.
4496 unsigned TruncWidth = TI->getType()->getPrimitiveSizeInBits();
4497 if (TruncWidth > MulWidth)
Craig Topperf40110f2014-04-25 05:29:35 +00004498 return nullptr;
Serge Pavlov4bb54d52014-04-13 18:23:41 +00004499 } else if (BinaryOperator *BO = dyn_cast<BinaryOperator>(U)) {
4500 // Check if AND ignores bits above MulWidth.
4501 if (BO->getOpcode() != Instruction::And)
Craig Topperf40110f2014-04-25 05:29:35 +00004502 return nullptr;
Serge Pavlov4bb54d52014-04-13 18:23:41 +00004503 if (ConstantInt *CI = dyn_cast<ConstantInt>(BO->getOperand(1))) {
4504 const APInt &CVal = CI->getValue();
4505 if (CVal.getBitWidth() - CVal.countLeadingZeros() > MulWidth)
Craig Topperf40110f2014-04-25 05:29:35 +00004506 return nullptr;
Davide Italiano579064e2017-07-16 18:56:30 +00004507 } else {
4508 // In this case we could have the operand of the binary operation
4509 // being defined in another block, and performing the replacement
4510 // could break the dominance relation.
4511 return nullptr;
Serge Pavlov4bb54d52014-04-13 18:23:41 +00004512 }
4513 } else {
4514 // Other uses prohibit this transformation.
Craig Topperf40110f2014-04-25 05:29:35 +00004515 return nullptr;
Serge Pavlov4bb54d52014-04-13 18:23:41 +00004516 }
4517 }
4518
4519 // Recognize patterns
4520 switch (I.getPredicate()) {
4521 case ICmpInst::ICMP_EQ:
4522 case ICmpInst::ICMP_NE:
4523 // Recognize pattern:
4524 // mulval = mul(zext A, zext B)
4525 // cmp eq/neq mulval, zext trunc mulval
4526 if (ZExtInst *Zext = dyn_cast<ZExtInst>(OtherVal))
4527 if (Zext->hasOneUse()) {
4528 Value *ZextArg = Zext->getOperand(0);
4529 if (TruncInst *Trunc = dyn_cast<TruncInst>(ZextArg))
4530 if (Trunc->getType()->getPrimitiveSizeInBits() == MulWidth)
4531 break; //Recognized
4532 }
4533
4534 // Recognize pattern:
4535 // mulval = mul(zext A, zext B)
4536 // cmp eq/neq mulval, and(mulval, mask), mask selects low MulWidth bits.
4537 ConstantInt *CI;
4538 Value *ValToMask;
4539 if (match(OtherVal, m_And(m_Value(ValToMask), m_ConstantInt(CI)))) {
4540 if (ValToMask != MulVal)
Craig Topperf40110f2014-04-25 05:29:35 +00004541 return nullptr;
Serge Pavlov4bb54d52014-04-13 18:23:41 +00004542 const APInt &CVal = CI->getValue() + 1;
4543 if (CVal.isPowerOf2()) {
4544 unsigned MaskWidth = CVal.logBase2();
4545 if (MaskWidth == MulWidth)
4546 break; // Recognized
4547 }
4548 }
Craig Topperf40110f2014-04-25 05:29:35 +00004549 return nullptr;
Serge Pavlov4bb54d52014-04-13 18:23:41 +00004550
4551 case ICmpInst::ICMP_UGT:
4552 // Recognize pattern:
4553 // mulval = mul(zext A, zext B)
4554 // cmp ugt mulval, max
4555 if (ConstantInt *CI = dyn_cast<ConstantInt>(OtherVal)) {
4556 APInt MaxVal = APInt::getMaxValue(MulWidth);
4557 MaxVal = MaxVal.zext(CI->getBitWidth());
4558 if (MaxVal.eq(CI->getValue()))
4559 break; // Recognized
4560 }
Craig Topperf40110f2014-04-25 05:29:35 +00004561 return nullptr;
Serge Pavlov4bb54d52014-04-13 18:23:41 +00004562
4563 case ICmpInst::ICMP_UGE:
4564 // Recognize pattern:
4565 // mulval = mul(zext A, zext B)
4566 // cmp uge mulval, max+1
4567 if (ConstantInt *CI = dyn_cast<ConstantInt>(OtherVal)) {
4568 APInt MaxVal = APInt::getOneBitSet(CI->getBitWidth(), MulWidth);
4569 if (MaxVal.eq(CI->getValue()))
4570 break; // Recognized
4571 }
Craig Topperf40110f2014-04-25 05:29:35 +00004572 return nullptr;
Serge Pavlov4bb54d52014-04-13 18:23:41 +00004573
4574 case ICmpInst::ICMP_ULE:
4575 // Recognize pattern:
4576 // mulval = mul(zext A, zext B)
4577 // cmp ule mulval, max
4578 if (ConstantInt *CI = dyn_cast<ConstantInt>(OtherVal)) {
4579 APInt MaxVal = APInt::getMaxValue(MulWidth);
4580 MaxVal = MaxVal.zext(CI->getBitWidth());
4581 if (MaxVal.eq(CI->getValue()))
4582 break; // Recognized
4583 }
Craig Topperf40110f2014-04-25 05:29:35 +00004584 return nullptr;
Serge Pavlov4bb54d52014-04-13 18:23:41 +00004585
4586 case ICmpInst::ICMP_ULT:
4587 // Recognize pattern:
4588 // mulval = mul(zext A, zext B)
4589 // cmp ule mulval, max + 1
4590 if (ConstantInt *CI = dyn_cast<ConstantInt>(OtherVal)) {
Serge Pavlovb5f3ddc2014-04-14 02:20:19 +00004591 APInt MaxVal = APInt::getOneBitSet(CI->getBitWidth(), MulWidth);
Serge Pavlov4bb54d52014-04-13 18:23:41 +00004592 if (MaxVal.eq(CI->getValue()))
4593 break; // Recognized
4594 }
Craig Topperf40110f2014-04-25 05:29:35 +00004595 return nullptr;
Serge Pavlov4bb54d52014-04-13 18:23:41 +00004596
4597 default:
Craig Topperf40110f2014-04-25 05:29:35 +00004598 return nullptr;
Serge Pavlov4bb54d52014-04-13 18:23:41 +00004599 }
4600
Craig Topperbb4069e2017-07-07 23:16:26 +00004601 InstCombiner::BuilderTy &Builder = IC.Builder;
4602 Builder.SetInsertPoint(MulInstr);
Serge Pavlov4bb54d52014-04-13 18:23:41 +00004603
4604 // Replace: mul(zext A, zext B) --> mul.with.overflow(A, B)
4605 Value *MulA = A, *MulB = B;
4606 if (WidthA < MulWidth)
Craig Topperbb4069e2017-07-07 23:16:26 +00004607 MulA = Builder.CreateZExt(A, MulType);
Serge Pavlov4bb54d52014-04-13 18:23:41 +00004608 if (WidthB < MulWidth)
Craig Topperbb4069e2017-07-07 23:16:26 +00004609 MulB = Builder.CreateZExt(B, MulType);
James Y Knight7976eb52019-02-01 20:43:25 +00004610 Function *F = Intrinsic::getDeclaration(
4611 I.getModule(), Intrinsic::umul_with_overflow, MulType);
Craig Topperbb4069e2017-07-07 23:16:26 +00004612 CallInst *Call = Builder.CreateCall(F, {MulA, MulB}, "umul");
Serge Pavlov4bb54d52014-04-13 18:23:41 +00004613 IC.Worklist.Add(MulInstr);
4614
4615 // If there are uses of mul result other than the comparison, we know that
4616 // they are truncation or binary AND. Change them to use result of
Serge Pavlovb5f3ddc2014-04-14 02:20:19 +00004617 // mul.with.overflow and adjust properly mask/size.
Serge Pavlov4bb54d52014-04-13 18:23:41 +00004618 if (MulVal->hasNUsesOrMore(2)) {
Craig Topperbb4069e2017-07-07 23:16:26 +00004619 Value *Mul = Builder.CreateExtractValue(Call, 0, "umul.value");
Joseph Tremoulet6f406d42018-06-15 16:52:40 +00004620 for (auto UI = MulVal->user_begin(), UE = MulVal->user_end(); UI != UE;) {
4621 User *U = *UI++;
Serge Pavlov4bb54d52014-04-13 18:23:41 +00004622 if (U == &I || U == OtherVal)
4623 continue;
4624 if (TruncInst *TI = dyn_cast<TruncInst>(U)) {
4625 if (TI->getType()->getPrimitiveSizeInBits() == MulWidth)
Sanjay Patel4b198802016-02-01 22:23:39 +00004626 IC.replaceInstUsesWith(*TI, Mul);
Serge Pavlov4bb54d52014-04-13 18:23:41 +00004627 else
4628 TI->setOperand(0, Mul);
4629 } else if (BinaryOperator *BO = dyn_cast<BinaryOperator>(U)) {
4630 assert(BO->getOpcode() == Instruction::And);
4631 // Replace (mul & mask) --> zext (mul.with.overflow & short_mask)
Davide Italiano579064e2017-07-16 18:56:30 +00004632 ConstantInt *CI = cast<ConstantInt>(BO->getOperand(1));
4633 APInt ShortMask = CI->getValue().trunc(MulWidth);
Craig Topperbb4069e2017-07-07 23:16:26 +00004634 Value *ShortAnd = Builder.CreateAnd(Mul, ShortMask);
Davide Italiano579064e2017-07-16 18:56:30 +00004635 Instruction *Zext =
4636 cast<Instruction>(Builder.CreateZExt(ShortAnd, BO->getType()));
4637 IC.Worklist.Add(Zext);
Sanjay Patel4b198802016-02-01 22:23:39 +00004638 IC.replaceInstUsesWith(*BO, Zext);
Serge Pavlov4bb54d52014-04-13 18:23:41 +00004639 } else {
4640 llvm_unreachable("Unexpected Binary operation");
4641 }
Davide Italiano579064e2017-07-16 18:56:30 +00004642 IC.Worklist.Add(cast<Instruction>(U));
Serge Pavlov4bb54d52014-04-13 18:23:41 +00004643 }
4644 }
4645 if (isa<Instruction>(OtherVal))
4646 IC.Worklist.Add(cast<Instruction>(OtherVal));
4647
4648 // The original icmp gets replaced with the overflow value, maybe inverted
4649 // depending on predicate.
4650 bool Inverse = false;
4651 switch (I.getPredicate()) {
4652 case ICmpInst::ICMP_NE:
4653 break;
4654 case ICmpInst::ICMP_EQ:
4655 Inverse = true;
4656 break;
4657 case ICmpInst::ICMP_UGT:
4658 case ICmpInst::ICMP_UGE:
4659 if (I.getOperand(0) == MulVal)
4660 break;
4661 Inverse = true;
4662 break;
4663 case ICmpInst::ICMP_ULT:
4664 case ICmpInst::ICMP_ULE:
4665 if (I.getOperand(1) == MulVal)
4666 break;
4667 Inverse = true;
4668 break;
4669 default:
4670 llvm_unreachable("Unexpected predicate");
4671 }
4672 if (Inverse) {
Craig Topperbb4069e2017-07-07 23:16:26 +00004673 Value *Res = Builder.CreateExtractValue(Call, 1);
Serge Pavlov4bb54d52014-04-13 18:23:41 +00004674 return BinaryOperator::CreateNot(Res);
4675 }
4676
4677 return ExtractValueInst::Create(Call, 1);
4678}
4679
Sanjay Patel5f0217f2016-06-05 16:46:18 +00004680/// When performing a comparison against a constant, it is possible that not all
4681/// the bits in the LHS are demanded. This helper method computes the mask that
4682/// IS demanded.
Craig Topper3edda872017-09-22 18:57:23 +00004683static APInt getDemandedBitsLHSMask(ICmpInst &I, unsigned BitWidth) {
Craig Topper18887bf2017-09-20 23:48:58 +00004684 const APInt *RHS;
4685 if (!match(I.getOperand(1), m_APInt(RHS)))
4686 return APInt::getAllOnesValue(BitWidth);
Jim Grosbach129c52a2011-09-30 18:09:53 +00004687
Craig Topper3edda872017-09-22 18:57:23 +00004688 // If this is a normal comparison, it demands all bits. If it is a sign bit
4689 // comparison, it only demands the sign bit.
4690 bool UnusedBit;
4691 if (isSignBitCheck(I.getPredicate(), *RHS, UnusedBit))
4692 return APInt::getSignMask(BitWidth);
4693
Owen Andersond490c2d2011-01-11 00:36:45 +00004694 switch (I.getPredicate()) {
Jim Grosbach129c52a2011-09-30 18:09:53 +00004695 // For a UGT comparison, we don't care about any bits that
Owen Andersond490c2d2011-01-11 00:36:45 +00004696 // correspond to the trailing ones of the comparand. The value of these
4697 // bits doesn't impact the outcome of the comparison, because any value
4698 // greater than the RHS must differ in a bit higher than these due to carry.
Craig Topper18887bf2017-09-20 23:48:58 +00004699 case ICmpInst::ICMP_UGT:
4700 return APInt::getBitsSetFrom(BitWidth, RHS->countTrailingOnes());
Jim Grosbach129c52a2011-09-30 18:09:53 +00004701
Owen Andersond490c2d2011-01-11 00:36:45 +00004702 // Similarly, for a ULT comparison, we don't care about the trailing zeros.
4703 // Any value less than the RHS must differ in a higher bit because of carries.
Craig Topper18887bf2017-09-20 23:48:58 +00004704 case ICmpInst::ICMP_ULT:
4705 return APInt::getBitsSetFrom(BitWidth, RHS->countTrailingZeros());
Jim Grosbach129c52a2011-09-30 18:09:53 +00004706
Owen Andersond490c2d2011-01-11 00:36:45 +00004707 default:
4708 return APInt::getAllOnesValue(BitWidth);
4709 }
Owen Andersond490c2d2011-01-11 00:36:45 +00004710}
Chris Lattner2188e402010-01-04 07:37:31 +00004711
Sanjay Patel4ccae1c2018-02-02 18:39:05 +00004712/// Check if the order of \p Op0 and \p Op1 as operands in an ICmpInst
Quentin Colombet5ab55552013-09-09 20:56:48 +00004713/// should be swapped.
Alp Tokercb402912014-01-24 17:20:08 +00004714/// The decision is based on how many times these two operands are reused
Quentin Colombet5ab55552013-09-09 20:56:48 +00004715/// as subtract operands and their positions in those instructions.
Sanjay Patel4ccae1c2018-02-02 18:39:05 +00004716/// The rationale is that several architectures use the same instruction for
4717/// both subtract and cmp. Thus, it is better if the order of those operands
Quentin Colombet5ab55552013-09-09 20:56:48 +00004718/// match.
4719/// \return true if Op0 and Op1 should be swapped.
Sanjay Patel4ccae1c2018-02-02 18:39:05 +00004720static bool swapMayExposeCSEOpportunities(const Value *Op0, const Value *Op1) {
4721 // Filter out pointer values as those cannot appear directly in subtract.
Quentin Colombet5ab55552013-09-09 20:56:48 +00004722 // FIXME: we may want to go through inttoptrs or bitcasts.
4723 if (Op0->getType()->isPointerTy())
4724 return false;
Sanjay Patel1ea86972018-02-02 19:08:12 +00004725 // If a subtract already has the same operands as a compare, swapping would be
4726 // bad. If a subtract has the same operands as a compare but in reverse order,
4727 // then swapping is good.
4728 int GoodToSwap = 0;
Chandler Carruthcdf47882014-03-09 03:16:01 +00004729 for (const User *U : Op0->users()) {
Sanjay Patel1ea86972018-02-02 19:08:12 +00004730 if (match(U, m_Sub(m_Specific(Op1), m_Specific(Op0))))
4731 GoodToSwap++;
4732 else if (match(U, m_Sub(m_Specific(Op0), m_Specific(Op1))))
4733 GoodToSwap--;
Quentin Colombet5ab55552013-09-09 20:56:48 +00004734 }
Sanjay Patel1ea86972018-02-02 19:08:12 +00004735 return GoodToSwap > 0;
Quentin Colombet5ab55552013-09-09 20:56:48 +00004736}
4737
Adrian Prantl5f8f34e42018-05-01 15:54:18 +00004738/// Check that one use is in the same block as the definition and all
Sanjay Patel53523312016-09-12 14:25:46 +00004739/// other uses are in blocks dominated by a given block.
Gerolf Hoflehnerec6217c2014-11-21 23:36:44 +00004740///
4741/// \param DI Definition
4742/// \param UI Use
4743/// \param DB Block that must dominate all uses of \p DI outside
4744/// the parent block
4745/// \return true when \p UI is the only use of \p DI in the parent block
4746/// and all other uses of \p DI are in blocks dominated by \p DB.
4747///
4748bool InstCombiner::dominatesAllUses(const Instruction *DI,
4749 const Instruction *UI,
4750 const BasicBlock *DB) const {
4751 assert(DI && UI && "Instruction not defined\n");
Sanjay Patel53523312016-09-12 14:25:46 +00004752 // Ignore incomplete definitions.
Gerolf Hoflehnerec6217c2014-11-21 23:36:44 +00004753 if (!DI->getParent())
4754 return false;
Sanjay Patel53523312016-09-12 14:25:46 +00004755 // DI and UI must be in the same block.
Gerolf Hoflehnerec6217c2014-11-21 23:36:44 +00004756 if (DI->getParent() != UI->getParent())
4757 return false;
Sanjay Patel53523312016-09-12 14:25:46 +00004758 // Protect from self-referencing blocks.
Gerolf Hoflehnerec6217c2014-11-21 23:36:44 +00004759 if (DI->getParent() == DB)
4760 return false;
Gerolf Hoflehnerec6217c2014-11-21 23:36:44 +00004761 for (const User *U : DI->users()) {
4762 auto *Usr = cast<Instruction>(U);
Justin Bogner99798402016-08-05 01:06:44 +00004763 if (Usr != UI && !DT.dominates(DB, Usr->getParent()))
Gerolf Hoflehnerec6217c2014-11-21 23:36:44 +00004764 return false;
4765 }
4766 return true;
4767}
4768
Sanjay Patel5f0217f2016-06-05 16:46:18 +00004769/// Return true when the instruction sequence within a block is select-cmp-br.
Gerolf Hoflehnerec6217c2014-11-21 23:36:44 +00004770static bool isChainSelectCmpBranch(const SelectInst *SI) {
4771 const BasicBlock *BB = SI->getParent();
4772 if (!BB)
4773 return false;
4774 auto *BI = dyn_cast_or_null<BranchInst>(BB->getTerminator());
4775 if (!BI || BI->getNumSuccessors() != 2)
4776 return false;
4777 auto *IC = dyn_cast<ICmpInst>(BI->getCondition());
4778 if (!IC || (IC->getOperand(0) != SI && IC->getOperand(1) != SI))
4779 return false;
4780 return true;
4781}
4782
Adrian Prantl5f8f34e42018-05-01 15:54:18 +00004783/// True when a select result is replaced by one of its operands
Gerolf Hoflehnerec6217c2014-11-21 23:36:44 +00004784/// in select-icmp sequence. This will eventually result in the elimination
4785/// of the select.
4786///
4787/// \param SI Select instruction
4788/// \param Icmp Compare instruction
4789/// \param SIOpd Operand that replaces the select
4790///
4791/// Notes:
4792/// - The replacement is global and requires dominator information
4793/// - The caller is responsible for the actual replacement
4794///
4795/// Example:
4796///
4797/// entry:
4798/// %4 = select i1 %3, %C* %0, %C* null
4799/// %5 = icmp eq %C* %4, null
4800/// br i1 %5, label %9, label %7
4801/// ...
4802/// ; <label>:7 ; preds = %entry
4803/// %8 = getelementptr inbounds %C* %4, i64 0, i32 0
4804/// ...
4805///
4806/// can be transformed to
4807///
4808/// %5 = icmp eq %C* %0, null
4809/// %6 = select i1 %3, i1 %5, i1 true
4810/// br i1 %6, label %9, label %7
4811/// ...
4812/// ; <label>:7 ; preds = %entry
4813/// %8 = getelementptr inbounds %C* %0, i64 0, i32 0 // replace by %0!
4814///
4815/// Similar when the first operand of the select is a constant or/and
4816/// the compare is for not equal rather than equal.
4817///
4818/// NOTE: The function is only called when the select and compare constants
4819/// are equal, the optimization can work only for EQ predicates. This is not a
4820/// major restriction since a NE compare should be 'normalized' to an equal
4821/// compare, which usually happens in the combiner and test case
Sanjay Patel53523312016-09-12 14:25:46 +00004822/// select-cmp-br.ll checks for it.
Gerolf Hoflehnerec6217c2014-11-21 23:36:44 +00004823bool InstCombiner::replacedSelectWithOperand(SelectInst *SI,
4824 const ICmpInst *Icmp,
4825 const unsigned SIOpd) {
David Majnemer83484fd2014-11-22 06:09:28 +00004826 assert((SIOpd == 1 || SIOpd == 2) && "Invalid select operand!");
Gerolf Hoflehnerec6217c2014-11-21 23:36:44 +00004827 if (isChainSelectCmpBranch(SI) && Icmp->getPredicate() == ICmpInst::ICMP_EQ) {
4828 BasicBlock *Succ = SI->getParent()->getTerminator()->getSuccessor(1);
Bjorn Petterssone5027cf2017-03-02 15:18:58 +00004829 // The check for the single predecessor is not the best that can be
Sanjay Patel53523312016-09-12 14:25:46 +00004830 // done. But it protects efficiently against cases like when SI's
Gerolf Hoflehnerec6217c2014-11-21 23:36:44 +00004831 // home block has two successors, Succ and Succ1, and Succ1 predecessor
4832 // of Succ. Then SI can't be replaced by SIOpd because the use that gets
4833 // replaced can be reached on either path. So the uniqueness check
4834 // guarantees that the path all uses of SI (outside SI's parent) are on
4835 // is disjoint from all other paths out of SI. But that information
4836 // is more expensive to compute, and the trade-off here is in favor
Bjorn Petterssone5027cf2017-03-02 15:18:58 +00004837 // of compile-time. It should also be noticed that we check for a single
4838 // predecessor and not only uniqueness. This to handle the situation when
4839 // Succ and Succ1 points to the same basic block.
4840 if (Succ->getSinglePredecessor() && dominatesAllUses(SI, Icmp, Succ)) {
Gerolf Hoflehnerec6217c2014-11-21 23:36:44 +00004841 NumSel++;
4842 SI->replaceUsesOutsideBlock(SI->getOperand(SIOpd), SI->getParent());
4843 return true;
4844 }
4845 }
4846 return false;
4847}
4848
Sanjay Patel3151dec2016-09-12 15:24:31 +00004849/// Try to fold the comparison based on range information we can get by checking
4850/// whether bits are known to be zero or one in the inputs.
4851Instruction *InstCombiner::foldICmpUsingKnownBits(ICmpInst &I) {
4852 Value *Op0 = I.getOperand(0), *Op1 = I.getOperand(1);
4853 Type *Ty = Op0->getType();
Sanjay Patel0531f0a2016-09-12 15:52:28 +00004854 ICmpInst::Predicate Pred = I.getPredicate();
Sanjay Patel3151dec2016-09-12 15:24:31 +00004855
4856 // Get scalar or pointer size.
4857 unsigned BitWidth = Ty->isIntOrIntVectorTy()
4858 ? Ty->getScalarSizeInBits()
Elena Demikhovsky945b7e52018-02-14 06:58:08 +00004859 : DL.getIndexTypeSizeInBits(Ty->getScalarType());
Sanjay Patel3151dec2016-09-12 15:24:31 +00004860
4861 if (!BitWidth)
4862 return nullptr;
4863
Craig Topperb45eabc2017-04-26 16:39:58 +00004864 KnownBits Op0Known(BitWidth);
4865 KnownBits Op1Known(BitWidth);
Sanjay Patel3151dec2016-09-12 15:24:31 +00004866
Craig Topper47596dd2017-03-25 06:52:52 +00004867 if (SimplifyDemandedBits(&I, 0,
Craig Topper3edda872017-09-22 18:57:23 +00004868 getDemandedBitsLHSMask(I, BitWidth),
Craig Topperb45eabc2017-04-26 16:39:58 +00004869 Op0Known, 0))
Sanjay Patel3151dec2016-09-12 15:24:31 +00004870 return &I;
4871
Craig Topper47596dd2017-03-25 06:52:52 +00004872 if (SimplifyDemandedBits(&I, 1, APInt::getAllOnesValue(BitWidth),
Craig Topperb45eabc2017-04-26 16:39:58 +00004873 Op1Known, 0))
Sanjay Patel3151dec2016-09-12 15:24:31 +00004874 return &I;
4875
4876 // Given the known and unknown bits, compute a range that the LHS could be
4877 // in. Compute the Min, Max and RHS values based on the known bits. For the
4878 // EQ and NE we use unsigned values.
4879 APInt Op0Min(BitWidth, 0), Op0Max(BitWidth, 0);
4880 APInt Op1Min(BitWidth, 0), Op1Max(BitWidth, 0);
4881 if (I.isSigned()) {
Craig Topperb45eabc2017-04-26 16:39:58 +00004882 computeSignedMinMaxValuesFromKnownBits(Op0Known, Op0Min, Op0Max);
4883 computeSignedMinMaxValuesFromKnownBits(Op1Known, Op1Min, Op1Max);
Sanjay Patel3151dec2016-09-12 15:24:31 +00004884 } else {
Craig Topperb45eabc2017-04-26 16:39:58 +00004885 computeUnsignedMinMaxValuesFromKnownBits(Op0Known, Op0Min, Op0Max);
4886 computeUnsignedMinMaxValuesFromKnownBits(Op1Known, Op1Min, Op1Max);
Sanjay Patel3151dec2016-09-12 15:24:31 +00004887 }
4888
Sanjay Patelc63f9012018-01-04 14:31:56 +00004889 // If Min and Max are known to be the same, then SimplifyDemandedBits figured
4890 // out that the LHS or RHS is a constant. Constant fold this now, so that
Sanjay Patel0531f0a2016-09-12 15:52:28 +00004891 // code below can assume that Min != Max.
Sanjay Patel3151dec2016-09-12 15:24:31 +00004892 if (!isa<Constant>(Op0) && Op0Min == Op0Max)
Sanjay Patelc63f9012018-01-04 14:31:56 +00004893 return new ICmpInst(Pred, ConstantExpr::getIntegerValue(Ty, Op0Min), Op1);
Sanjay Patel3151dec2016-09-12 15:24:31 +00004894 if (!isa<Constant>(Op1) && Op1Min == Op1Max)
Sanjay Patelc63f9012018-01-04 14:31:56 +00004895 return new ICmpInst(Pred, Op0, ConstantExpr::getIntegerValue(Ty, Op1Min));
Sanjay Patel3151dec2016-09-12 15:24:31 +00004896
4897 // Based on the range information we know about the LHS, see if we can
4898 // simplify this comparison. For example, (x&4) < 8 is always true.
Sanjay Patel0531f0a2016-09-12 15:52:28 +00004899 switch (Pred) {
Sanjay Patel3151dec2016-09-12 15:24:31 +00004900 default:
4901 llvm_unreachable("Unknown icmp opcode!");
Sanjay Patel9efb1bd2016-09-14 23:38:56 +00004902 case ICmpInst::ICMP_EQ:
Sanjay Patel3151dec2016-09-12 15:24:31 +00004903 case ICmpInst::ICMP_NE: {
Sanjay Patel9efb1bd2016-09-14 23:38:56 +00004904 if (Op0Max.ult(Op1Min) || Op0Min.ugt(Op1Max)) {
4905 return Pred == CmpInst::ICMP_EQ
4906 ? replaceInstUsesWith(I, ConstantInt::getFalse(I.getType()))
4907 : replaceInstUsesWith(I, ConstantInt::getTrue(I.getType()));
4908 }
Sanjay Patel3151dec2016-09-12 15:24:31 +00004909
Sanjay Patel0531f0a2016-09-12 15:52:28 +00004910 // If all bits are known zero except for one, then we know at most one bit
4911 // is set. If the comparison is against zero, then this is a check to see if
4912 // *that* bit is set.
Craig Topperb45eabc2017-04-26 16:39:58 +00004913 APInt Op0KnownZeroInverted = ~Op0Known.Zero;
Craig Topperf0aeee02017-05-05 17:36:09 +00004914 if (Op1Known.isZero()) {
Sanjay Patel3151dec2016-09-12 15:24:31 +00004915 // If the LHS is an AND with the same constant, look through it.
4916 Value *LHS = nullptr;
Sanjay Patel7577a3d2016-09-15 14:15:47 +00004917 const APInt *LHSC;
4918 if (!match(Op0, m_And(m_Value(LHS), m_APInt(LHSC))) ||
4919 *LHSC != Op0KnownZeroInverted)
Sanjay Patel3151dec2016-09-12 15:24:31 +00004920 LHS = Op0;
4921
Sanjay Patel9efb1bd2016-09-14 23:38:56 +00004922 Value *X;
Sanjay Patel3151dec2016-09-12 15:24:31 +00004923 if (match(LHS, m_Shl(m_One(), m_Value(X)))) {
4924 APInt ValToCheck = Op0KnownZeroInverted;
Sanjay Patel9efb1bd2016-09-14 23:38:56 +00004925 Type *XTy = X->getType();
Sanjay Patel3151dec2016-09-12 15:24:31 +00004926 if (ValToCheck.isPowerOf2()) {
Sanjay Patel9efb1bd2016-09-14 23:38:56 +00004927 // ((1 << X) & 8) == 0 -> X != 3
4928 // ((1 << X) & 8) != 0 -> X == 3
4929 auto *CmpC = ConstantInt::get(XTy, ValToCheck.countTrailingZeros());
4930 auto NewPred = ICmpInst::getInversePredicate(Pred);
4931 return new ICmpInst(NewPred, X, CmpC);
Sanjay Patel3151dec2016-09-12 15:24:31 +00004932 } else if ((++ValToCheck).isPowerOf2()) {
Sanjay Patel9efb1bd2016-09-14 23:38:56 +00004933 // ((1 << X) & 7) == 0 -> X >= 3
4934 // ((1 << X) & 7) != 0 -> X < 3
4935 auto *CmpC = ConstantInt::get(XTy, ValToCheck.countTrailingZeros());
4936 auto NewPred =
4937 Pred == CmpInst::ICMP_EQ ? CmpInst::ICMP_UGE : CmpInst::ICMP_ULT;
4938 return new ICmpInst(NewPred, X, CmpC);
Sanjay Patel3151dec2016-09-12 15:24:31 +00004939 }
4940 }
4941
Sanjay Patel9efb1bd2016-09-14 23:38:56 +00004942 // Check if the LHS is 8 >>u x and the result is a power of 2 like 1.
Sanjay Patel3151dec2016-09-12 15:24:31 +00004943 const APInt *CI;
Craig Topper73ba1c82017-06-07 07:40:37 +00004944 if (Op0KnownZeroInverted.isOneValue() &&
Sanjay Patel9efb1bd2016-09-14 23:38:56 +00004945 match(LHS, m_LShr(m_Power2(CI), m_Value(X)))) {
4946 // ((8 >>u X) & 1) == 0 -> X != 3
4947 // ((8 >>u X) & 1) != 0 -> X == 3
4948 unsigned CmpVal = CI->countTrailingZeros();
4949 auto NewPred = ICmpInst::getInversePredicate(Pred);
4950 return new ICmpInst(NewPred, X, ConstantInt::get(X->getType(), CmpVal));
4951 }
Sanjay Patel3151dec2016-09-12 15:24:31 +00004952 }
4953 break;
4954 }
4955 case ICmpInst::ICMP_ULT: {
4956 if (Op0Max.ult(Op1Min)) // A <u B -> true if max(A) < min(B)
4957 return replaceInstUsesWith(I, ConstantInt::getTrue(I.getType()));
4958 if (Op0Min.uge(Op1Max)) // A <u B -> false if min(A) >= max(B)
4959 return replaceInstUsesWith(I, ConstantInt::getFalse(I.getType()));
4960 if (Op1Min == Op0Max) // A <u B -> A != B if max(A) == min(B)
4961 return new ICmpInst(ICmpInst::ICMP_NE, Op0, Op1);
4962
Craig Topper0cd25942017-09-27 22:57:18 +00004963 const APInt *CmpC;
4964 if (match(Op1, m_APInt(CmpC))) {
Sanjay Patel3151dec2016-09-12 15:24:31 +00004965 // A <u C -> A == C-1 if min(A)+1 == C
Craig Topper0cd25942017-09-27 22:57:18 +00004966 if (*CmpC == Op0Min + 1)
Craig Topper2c9b7d72017-09-22 18:57:20 +00004967 return new ICmpInst(ICmpInst::ICMP_EQ, Op0,
Craig Topper0cd25942017-09-27 22:57:18 +00004968 ConstantInt::get(Op1->getType(), *CmpC - 1));
Craig Topper30dc9792017-09-25 21:15:00 +00004969 // X <u C --> X == 0, if the number of zero bits in the bottom of X
4970 // exceeds the log2 of C.
Craig Topper0cd25942017-09-27 22:57:18 +00004971 if (Op0Known.countMinTrailingZeros() >= CmpC->ceilLogBase2())
Craig Topper30dc9792017-09-25 21:15:00 +00004972 return new ICmpInst(ICmpInst::ICMP_EQ, Op0,
4973 Constant::getNullValue(Op1->getType()));
Sanjay Patel3151dec2016-09-12 15:24:31 +00004974 }
4975 break;
4976 }
4977 case ICmpInst::ICMP_UGT: {
4978 if (Op0Min.ugt(Op1Max)) // A >u B -> true if min(A) > max(B)
4979 return replaceInstUsesWith(I, ConstantInt::getTrue(I.getType()));
Sanjay Patel3151dec2016-09-12 15:24:31 +00004980 if (Op0Max.ule(Op1Min)) // A >u B -> false if max(A) <= max(B)
4981 return replaceInstUsesWith(I, ConstantInt::getFalse(I.getType()));
Sanjay Patel3151dec2016-09-12 15:24:31 +00004982 if (Op1Max == Op0Min) // A >u B -> A != B if min(A) == max(B)
4983 return new ICmpInst(ICmpInst::ICMP_NE, Op0, Op1);
4984
Craig Topper0cd25942017-09-27 22:57:18 +00004985 const APInt *CmpC;
4986 if (match(Op1, m_APInt(CmpC))) {
Sanjay Patel3151dec2016-09-12 15:24:31 +00004987 // A >u C -> A == C+1 if max(a)-1 == C
Craig Topper0cd25942017-09-27 22:57:18 +00004988 if (*CmpC == Op0Max - 1)
Sanjay Patel3151dec2016-09-12 15:24:31 +00004989 return new ICmpInst(ICmpInst::ICMP_EQ, Op0,
Craig Topper0cd25942017-09-27 22:57:18 +00004990 ConstantInt::get(Op1->getType(), *CmpC + 1));
Craig Topper30dc9792017-09-25 21:15:00 +00004991 // X >u C --> X != 0, if the number of zero bits in the bottom of X
4992 // exceeds the log2 of C.
Craig Topper0cd25942017-09-27 22:57:18 +00004993 if (Op0Known.countMinTrailingZeros() >= CmpC->getActiveBits())
Craig Topper30dc9792017-09-25 21:15:00 +00004994 return new ICmpInst(ICmpInst::ICMP_NE, Op0,
4995 Constant::getNullValue(Op1->getType()));
Sanjay Patel3151dec2016-09-12 15:24:31 +00004996 }
4997 break;
4998 }
Craig Topper0cd25942017-09-27 22:57:18 +00004999 case ICmpInst::ICMP_SLT: {
Sanjay Patel3151dec2016-09-12 15:24:31 +00005000 if (Op0Max.slt(Op1Min)) // A <s B -> true if max(A) < min(C)
5001 return replaceInstUsesWith(I, ConstantInt::getTrue(I.getType()));
5002 if (Op0Min.sge(Op1Max)) // A <s B -> false if min(A) >= max(C)
5003 return replaceInstUsesWith(I, ConstantInt::getFalse(I.getType()));
5004 if (Op1Min == Op0Max) // A <s B -> A != B if max(A) == min(B)
5005 return new ICmpInst(ICmpInst::ICMP_NE, Op0, Op1);
Craig Topper0cd25942017-09-27 22:57:18 +00005006 const APInt *CmpC;
5007 if (match(Op1, m_APInt(CmpC))) {
5008 if (*CmpC == Op0Min + 1) // A <s C -> A == C-1 if min(A)+1 == C
Sanjay Patel3151dec2016-09-12 15:24:31 +00005009 return new ICmpInst(ICmpInst::ICMP_EQ, Op0,
Craig Topper0cd25942017-09-27 22:57:18 +00005010 ConstantInt::get(Op1->getType(), *CmpC - 1));
Sanjay Patel3151dec2016-09-12 15:24:31 +00005011 }
5012 break;
Craig Topper0cd25942017-09-27 22:57:18 +00005013 }
5014 case ICmpInst::ICMP_SGT: {
Sanjay Patel3151dec2016-09-12 15:24:31 +00005015 if (Op0Min.sgt(Op1Max)) // A >s B -> true if min(A) > max(B)
5016 return replaceInstUsesWith(I, ConstantInt::getTrue(I.getType()));
5017 if (Op0Max.sle(Op1Min)) // A >s B -> false if max(A) <= min(B)
5018 return replaceInstUsesWith(I, ConstantInt::getFalse(I.getType()));
Sanjay Patel3151dec2016-09-12 15:24:31 +00005019 if (Op1Max == Op0Min) // A >s B -> A != B if min(A) == max(B)
5020 return new ICmpInst(ICmpInst::ICMP_NE, Op0, Op1);
Craig Topper0cd25942017-09-27 22:57:18 +00005021 const APInt *CmpC;
5022 if (match(Op1, m_APInt(CmpC))) {
5023 if (*CmpC == Op0Max - 1) // A >s C -> A == C+1 if max(A)-1 == C
Sanjay Patel3151dec2016-09-12 15:24:31 +00005024 return new ICmpInst(ICmpInst::ICMP_EQ, Op0,
Craig Topper0cd25942017-09-27 22:57:18 +00005025 ConstantInt::get(Op1->getType(), *CmpC + 1));
Sanjay Patel3151dec2016-09-12 15:24:31 +00005026 }
5027 break;
Craig Topper0cd25942017-09-27 22:57:18 +00005028 }
Sanjay Patel3151dec2016-09-12 15:24:31 +00005029 case ICmpInst::ICMP_SGE:
5030 assert(!isa<ConstantInt>(Op1) && "ICMP_SGE with ConstantInt not folded!");
5031 if (Op0Min.sge(Op1Max)) // A >=s B -> true if min(A) >= max(B)
5032 return replaceInstUsesWith(I, ConstantInt::getTrue(I.getType()));
5033 if (Op0Max.slt(Op1Min)) // A >=s B -> false if max(A) < min(B)
5034 return replaceInstUsesWith(I, ConstantInt::getFalse(I.getType()));
Craig Topperea927ba2017-09-22 21:47:22 +00005035 if (Op1Min == Op0Max) // A >=s B -> A == B if max(A) == min(B)
5036 return new ICmpInst(ICmpInst::ICMP_EQ, Op0, Op1);
Sanjay Patel3151dec2016-09-12 15:24:31 +00005037 break;
5038 case ICmpInst::ICMP_SLE:
5039 assert(!isa<ConstantInt>(Op1) && "ICMP_SLE with ConstantInt not folded!");
5040 if (Op0Max.sle(Op1Min)) // A <=s B -> true if max(A) <= min(B)
5041 return replaceInstUsesWith(I, ConstantInt::getTrue(I.getType()));
5042 if (Op0Min.sgt(Op1Max)) // A <=s B -> false if min(A) > max(B)
5043 return replaceInstUsesWith(I, ConstantInt::getFalse(I.getType()));
Craig Topperea927ba2017-09-22 21:47:22 +00005044 if (Op1Max == Op0Min) // A <=s B -> A == B if min(A) == max(B)
5045 return new ICmpInst(ICmpInst::ICMP_EQ, Op0, Op1);
Sanjay Patel3151dec2016-09-12 15:24:31 +00005046 break;
5047 case ICmpInst::ICMP_UGE:
5048 assert(!isa<ConstantInt>(Op1) && "ICMP_UGE with ConstantInt not folded!");
5049 if (Op0Min.uge(Op1Max)) // A >=u B -> true if min(A) >= max(B)
5050 return replaceInstUsesWith(I, ConstantInt::getTrue(I.getType()));
5051 if (Op0Max.ult(Op1Min)) // A >=u B -> false if max(A) < min(B)
5052 return replaceInstUsesWith(I, ConstantInt::getFalse(I.getType()));
Craig Topperea927ba2017-09-22 21:47:22 +00005053 if (Op1Min == Op0Max) // A >=u B -> A == B if max(A) == min(B)
5054 return new ICmpInst(ICmpInst::ICMP_EQ, Op0, Op1);
Sanjay Patel3151dec2016-09-12 15:24:31 +00005055 break;
5056 case ICmpInst::ICMP_ULE:
5057 assert(!isa<ConstantInt>(Op1) && "ICMP_ULE with ConstantInt not folded!");
5058 if (Op0Max.ule(Op1Min)) // A <=u B -> true if max(A) <= min(B)
5059 return replaceInstUsesWith(I, ConstantInt::getTrue(I.getType()));
5060 if (Op0Min.ugt(Op1Max)) // A <=u B -> false if min(A) > max(B)
5061 return replaceInstUsesWith(I, ConstantInt::getFalse(I.getType()));
Craig Topperea927ba2017-09-22 21:47:22 +00005062 if (Op1Max == Op0Min) // A <=u B -> A == B if min(A) == max(B)
5063 return new ICmpInst(ICmpInst::ICMP_EQ, Op0, Op1);
Sanjay Patel3151dec2016-09-12 15:24:31 +00005064 break;
5065 }
5066
5067 // Turn a signed comparison into an unsigned one if both operands are known to
5068 // have the same sign.
5069 if (I.isSigned() &&
Craig Topperb45eabc2017-04-26 16:39:58 +00005070 ((Op0Known.Zero.isNegative() && Op1Known.Zero.isNegative()) ||
5071 (Op0Known.One.isNegative() && Op1Known.One.isNegative())))
Sanjay Patel3151dec2016-09-12 15:24:31 +00005072 return new ICmpInst(I.getUnsignedPredicate(), Op0, Op1);
5073
5074 return nullptr;
5075}
5076
Roman Lebedev32f1e1a2019-08-14 09:57:20 +00005077llvm::Optional<std::pair<CmpInst::Predicate, Constant *>>
5078llvm::getFlippedStrictnessPredicateAndConstant(CmpInst::Predicate Pred,
5079 Constant *C) {
5080 assert(ICmpInst::isRelational(Pred) && ICmpInst::isIntPredicate(Pred) &&
Roman Lebedev2c75fe72019-08-24 06:49:25 +00005081 "Only for relational integer predicates.");
Sanjay Pateld5b0e542016-04-29 16:22:25 +00005082
Roman Lebedev32f1e1a2019-08-14 09:57:20 +00005083 Type *Type = C->getType();
5084 bool IsSigned = ICmpInst::isSigned(Pred);
Roman Lebedev2c75fe72019-08-24 06:49:25 +00005085
5086 CmpInst::Predicate UnsignedPred = ICmpInst::getUnsignedPredicate(Pred);
5087 bool WillIncrement =
5088 UnsignedPred == ICmpInst::ICMP_ULE || UnsignedPred == ICmpInst::ICMP_UGT;
5089
5090 // Check if the constant operand can be safely incremented/decremented
5091 // without overflowing/underflowing.
5092 auto ConstantIsOk = [WillIncrement, IsSigned](ConstantInt *C) {
5093 return WillIncrement ? !C->isMaxValue(IsSigned) : !C->isMinValue(IsSigned);
5094 };
5095
5096 // For scalars, SimplifyICmpInst should have already handled
5097 // the edge cases for us, so we just assert on them.
5098 // For vectors, we must handle the edge cases.
Simon Pilgrimef9c6a72019-08-29 09:58:47 +00005099 if (isa<ConstantInt>(C)) {
Sanjay Patele9b2c322016-05-17 00:57:57 +00005100 // A <= MAX -> TRUE ; A >= MIN -> TRUE
Simon Pilgrimef9c6a72019-08-29 09:58:47 +00005101 assert(ConstantIsOk(cast<ConstantInt>(C)));
Roman Lebedev32f1e1a2019-08-14 09:57:20 +00005102 } else if (Type->isVectorTy()) {
Sanjay Patelb79ab272016-05-13 15:10:46 +00005103 // TODO? If the edge cases for vectors were guaranteed to be handled as they
Sanjay Patele9b2c322016-05-17 00:57:57 +00005104 // are for scalar, we could remove the min/max checks. However, to do that,
5105 // we would have to use insertelement/shufflevector to replace edge values.
Roman Lebedev32f1e1a2019-08-14 09:57:20 +00005106 unsigned NumElts = Type->getVectorNumElements();
Sanjay Patele9b2c322016-05-17 00:57:57 +00005107 for (unsigned i = 0; i != NumElts; ++i) {
Roman Lebedev32f1e1a2019-08-14 09:57:20 +00005108 Constant *Elt = C->getAggregateElement(i);
Benjamin Kramerca9a0fe2016-05-17 12:08:55 +00005109 if (!Elt)
Roman Lebedev32f1e1a2019-08-14 09:57:20 +00005110 return llvm::None;
Benjamin Kramerca9a0fe2016-05-17 12:08:55 +00005111
Sanjay Patele9b2c322016-05-17 00:57:57 +00005112 if (isa<UndefValue>(Elt))
5113 continue;
Sanjay Patel06b127a2016-09-15 14:37:50 +00005114
Sanjay Patele9b2c322016-05-17 00:57:57 +00005115 // Bail out if we can't determine if this constant is min/max or if we
5116 // know that this constant is min/max.
5117 auto *CI = dyn_cast<ConstantInt>(Elt);
Roman Lebedev2c75fe72019-08-24 06:49:25 +00005118 if (!CI || !ConstantIsOk(CI))
Roman Lebedev32f1e1a2019-08-14 09:57:20 +00005119 return llvm::None;
Sanjay Patelb79ab272016-05-13 15:10:46 +00005120 }
Sanjay Patele9b2c322016-05-17 00:57:57 +00005121 } else {
5122 // ConstantExpr?
Roman Lebedev32f1e1a2019-08-14 09:57:20 +00005123 return llvm::None;
Sanjay Patelb79ab272016-05-13 15:10:46 +00005124 }
Sanjay Pateld5b0e542016-04-29 16:22:25 +00005125
Roman Lebedev32f1e1a2019-08-14 09:57:20 +00005126 CmpInst::Predicate NewPred = CmpInst::getFlippedStrictnessPredicate(Pred);
5127
5128 // Increment or decrement the constant.
Roman Lebedev2c75fe72019-08-24 06:49:25 +00005129 Constant *OneOrNegOne = ConstantInt::get(Type, WillIncrement ? 1 : -1, true);
Roman Lebedev32f1e1a2019-08-14 09:57:20 +00005130 Constant *NewC = ConstantExpr::getAdd(C, OneOrNegOne);
5131
5132 return std::make_pair(NewPred, NewC);
5133}
5134
5135/// If we have an icmp le or icmp ge instruction with a constant operand, turn
5136/// it into the appropriate icmp lt or icmp gt instruction. This transform
5137/// allows them to be folded in visitICmpInst.
5138static ICmpInst *canonicalizeCmpWithConstant(ICmpInst &I) {
5139 ICmpInst::Predicate Pred = I.getPredicate();
5140 if (ICmpInst::isEquality(Pred) || !ICmpInst::isIntPredicate(Pred) ||
5141 isCanonicalPredicate(Pred))
5142 return nullptr;
5143
5144 Value *Op0 = I.getOperand(0);
5145 Value *Op1 = I.getOperand(1);
5146 auto *Op1C = dyn_cast<Constant>(Op1);
5147 if (!Op1C)
5148 return nullptr;
5149
5150 auto FlippedStrictness = getFlippedStrictnessPredicateAndConstant(Pred, Op1C);
5151 if (!FlippedStrictness)
5152 return nullptr;
5153
5154 return new ICmpInst(FlippedStrictness->first, Op0, FlippedStrictness->second);
Sanjay Pateld5b0e542016-04-29 16:22:25 +00005155}
5156
Sanjay Patele5747e32017-05-17 22:15:07 +00005157/// Integer compare with boolean values can always be turned into bitwise ops.
5158static Instruction *canonicalizeICmpBool(ICmpInst &I,
5159 InstCombiner::BuilderTy &Builder) {
5160 Value *A = I.getOperand(0), *B = I.getOperand(1);
Craig Topperfde47232017-07-09 07:04:03 +00005161 assert(A->getType()->isIntOrIntVectorTy(1) && "Bools only");
Sanjay Patele5747e32017-05-17 22:15:07 +00005162
Sanjay Patelba212c22017-05-17 22:29:40 +00005163 // A boolean compared to true/false can be simplified to Op0/true/false in
5164 // 14 out of the 20 (10 predicates * 2 constants) possible combinations.
5165 // Cases not handled by InstSimplify are always 'not' of Op0.
5166 if (match(B, m_Zero())) {
5167 switch (I.getPredicate()) {
5168 case CmpInst::ICMP_EQ: // A == 0 -> !A
5169 case CmpInst::ICMP_ULE: // A <=u 0 -> !A
5170 case CmpInst::ICMP_SGE: // A >=s 0 -> !A
5171 return BinaryOperator::CreateNot(A);
5172 default:
5173 llvm_unreachable("ICmp i1 X, C not simplified as expected.");
5174 }
5175 } else if (match(B, m_One())) {
5176 switch (I.getPredicate()) {
5177 case CmpInst::ICMP_NE: // A != 1 -> !A
5178 case CmpInst::ICMP_ULT: // A <u 1 -> !A
5179 case CmpInst::ICMP_SGT: // A >s -1 -> !A
5180 return BinaryOperator::CreateNot(A);
5181 default:
5182 llvm_unreachable("ICmp i1 X, C not simplified as expected.");
5183 }
5184 }
5185
Sanjay Patele5747e32017-05-17 22:15:07 +00005186 switch (I.getPredicate()) {
5187 default:
5188 llvm_unreachable("Invalid icmp instruction!");
5189 case ICmpInst::ICMP_EQ:
5190 // icmp eq i1 A, B -> ~(A ^ B)
5191 return BinaryOperator::CreateNot(Builder.CreateXor(A, B));
5192
5193 case ICmpInst::ICMP_NE:
5194 // icmp ne i1 A, B -> A ^ B
5195 return BinaryOperator::CreateXor(A, B);
5196
5197 case ICmpInst::ICMP_UGT:
5198 // icmp ugt -> icmp ult
5199 std::swap(A, B);
5200 LLVM_FALLTHROUGH;
5201 case ICmpInst::ICMP_ULT:
5202 // icmp ult i1 A, B -> ~A & B
5203 return BinaryOperator::CreateAnd(Builder.CreateNot(A), B);
5204
5205 case ICmpInst::ICMP_SGT:
5206 // icmp sgt -> icmp slt
5207 std::swap(A, B);
5208 LLVM_FALLTHROUGH;
5209 case ICmpInst::ICMP_SLT:
5210 // icmp slt i1 A, B -> A & ~B
5211 return BinaryOperator::CreateAnd(Builder.CreateNot(B), A);
5212
5213 case ICmpInst::ICMP_UGE:
5214 // icmp uge -> icmp ule
5215 std::swap(A, B);
5216 LLVM_FALLTHROUGH;
5217 case ICmpInst::ICMP_ULE:
5218 // icmp ule i1 A, B -> ~A | B
5219 return BinaryOperator::CreateOr(Builder.CreateNot(A), B);
5220
5221 case ICmpInst::ICMP_SGE:
5222 // icmp sge -> icmp sle
5223 std::swap(A, B);
5224 LLVM_FALLTHROUGH;
5225 case ICmpInst::ICMP_SLE:
5226 // icmp sle i1 A, B -> A | ~B
5227 return BinaryOperator::CreateOr(Builder.CreateNot(B), A);
5228 }
5229}
5230
Roman Lebedev75404fb2018-09-12 18:19:43 +00005231// Transform pattern like:
Roman Lebedev1b7fc872018-09-15 12:04:13 +00005232// (1 << Y) u<= X or ~(-1 << Y) u< X or ((1 << Y)+(-1)) u< X
5233// (1 << Y) u> X or ~(-1 << Y) u>= X or ((1 << Y)+(-1)) u>= X
Roman Lebedev75404fb2018-09-12 18:19:43 +00005234// Into:
5235// (X l>> Y) != 0
5236// (X l>> Y) == 0
5237static Instruction *foldICmpWithHighBitMask(ICmpInst &Cmp,
5238 InstCombiner::BuilderTy &Builder) {
Roman Lebedev6dc87002018-09-13 20:33:12 +00005239 ICmpInst::Predicate Pred, NewPred;
Roman Lebedev75404fb2018-09-12 18:19:43 +00005240 Value *X, *Y;
Roman Lebedev6dc87002018-09-13 20:33:12 +00005241 if (match(&Cmp,
5242 m_c_ICmp(Pred, m_OneUse(m_Shl(m_One(), m_Value(Y))), m_Value(X)))) {
5243 // We want X to be the icmp's second operand, so swap predicate if it isn't.
5244 if (Cmp.getOperand(0) == X)
5245 Pred = Cmp.getSwappedPredicate();
Roman Lebedev75404fb2018-09-12 18:19:43 +00005246
Roman Lebedev6dc87002018-09-13 20:33:12 +00005247 switch (Pred) {
5248 case ICmpInst::ICMP_ULE:
5249 NewPred = ICmpInst::ICMP_NE;
5250 break;
5251 case ICmpInst::ICMP_UGT:
5252 NewPred = ICmpInst::ICMP_EQ;
5253 break;
5254 default:
5255 return nullptr;
5256 }
Roman Lebedev1b7fc872018-09-15 12:04:13 +00005257 } else if (match(&Cmp, m_c_ICmp(Pred,
5258 m_OneUse(m_CombineOr(
5259 m_Not(m_Shl(m_AllOnes(), m_Value(Y))),
5260 m_Add(m_Shl(m_One(), m_Value(Y)),
5261 m_AllOnes()))),
5262 m_Value(X)))) {
5263 // The variant with 'add' is not canonical, (the variant with 'not' is)
5264 // we only get it because it has extra uses, and can't be canonicalized,
5265
Roman Lebedev6dc87002018-09-13 20:33:12 +00005266 // We want X to be the icmp's second operand, so swap predicate if it isn't.
5267 if (Cmp.getOperand(0) == X)
5268 Pred = Cmp.getSwappedPredicate();
Roman Lebedev75404fb2018-09-12 18:19:43 +00005269
Roman Lebedev6dc87002018-09-13 20:33:12 +00005270 switch (Pred) {
5271 case ICmpInst::ICMP_ULT:
5272 NewPred = ICmpInst::ICMP_NE;
5273 break;
5274 case ICmpInst::ICMP_UGE:
5275 NewPred = ICmpInst::ICMP_EQ;
5276 break;
5277 default:
5278 return nullptr;
5279 }
5280 } else
Roman Lebedev75404fb2018-09-12 18:19:43 +00005281 return nullptr;
Roman Lebedev75404fb2018-09-12 18:19:43 +00005282
5283 Value *NewX = Builder.CreateLShr(X, Y, X->getName() + ".highbits");
5284 Constant *Zero = Constant::getNullValue(NewX->getType());
5285 return CmpInst::Create(Instruction::ICmp, NewPred, NewX, Zero);
5286}
5287
Sanjay Patel039f5562018-08-16 12:52:17 +00005288static Instruction *foldVectorCmp(CmpInst &Cmp,
5289 InstCombiner::BuilderTy &Builder) {
5290 // If both arguments of the cmp are shuffles that use the same mask and
5291 // shuffle within a single vector, move the shuffle after the cmp.
5292 Value *LHS = Cmp.getOperand(0), *RHS = Cmp.getOperand(1);
5293 Value *V1, *V2;
5294 Constant *M;
5295 if (match(LHS, m_ShuffleVector(m_Value(V1), m_Undef(), m_Constant(M))) &&
5296 match(RHS, m_ShuffleVector(m_Value(V2), m_Undef(), m_Specific(M))) &&
5297 V1->getType() == V2->getType() &&
5298 (LHS->hasOneUse() || RHS->hasOneUse())) {
5299 // cmp (shuffle V1, M), (shuffle V2, M) --> shuffle (cmp V1, V2), M
5300 CmpInst::Predicate P = Cmp.getPredicate();
5301 Value *NewCmp = isa<ICmpInst>(Cmp) ? Builder.CreateICmp(P, V1, V2)
5302 : Builder.CreateFCmp(P, V1, V2);
5303 return new ShuffleVectorInst(NewCmp, UndefValue::get(NewCmp->getType()), M);
5304 }
5305 return nullptr;
5306}
5307
Chris Lattner2188e402010-01-04 07:37:31 +00005308Instruction *InstCombiner::visitICmpInst(ICmpInst &I) {
5309 bool Changed = false;
Chris Lattner9306ffa2010-02-01 19:54:45 +00005310 Value *Op0 = I.getOperand(0), *Op1 = I.getOperand(1);
Quentin Colombet5ab55552013-09-09 20:56:48 +00005311 unsigned Op0Cplxity = getComplexity(Op0);
5312 unsigned Op1Cplxity = getComplexity(Op1);
Jim Grosbach129c52a2011-09-30 18:09:53 +00005313
Chris Lattner2188e402010-01-04 07:37:31 +00005314 /// Orders the operands of the compare so that they are listed from most
5315 /// complex to least complex. This puts constants before unary operators,
5316 /// before binary operators.
Quentin Colombet5ab55552013-09-09 20:56:48 +00005317 if (Op0Cplxity < Op1Cplxity ||
Sanjay Patel4c204232016-06-04 20:39:22 +00005318 (Op0Cplxity == Op1Cplxity && swapMayExposeCSEOpportunities(Op0, Op1))) {
Chris Lattner2188e402010-01-04 07:37:31 +00005319 I.swapOperands();
Chris Lattner9306ffa2010-02-01 19:54:45 +00005320 std::swap(Op0, Op1);
Chris Lattner2188e402010-01-04 07:37:31 +00005321 Changed = true;
5322 }
Jim Grosbach129c52a2011-09-30 18:09:53 +00005323
Daniel Berlin2c75c632017-04-26 20:56:07 +00005324 if (Value *V = SimplifyICmpInst(I.getPredicate(), Op0, Op1,
5325 SQ.getWithInstruction(&I)))
Sanjay Patel4b198802016-02-01 22:23:39 +00005326 return replaceInstUsesWith(I, V);
Jim Grosbach129c52a2011-09-30 18:09:53 +00005327
Uriel Korach18972232017-09-10 08:31:22 +00005328 // Comparing -val or val with non-zero is the same as just comparing val
Pete Cooperfdddc272011-12-01 19:13:26 +00005329 // ie, abs(val) != 0 -> val != 0
Sanjay Patel4c204232016-06-04 20:39:22 +00005330 if (I.getPredicate() == ICmpInst::ICMP_NE && match(Op1, m_Zero())) {
Pete Cooperfdddc272011-12-01 19:13:26 +00005331 Value *Cond, *SelectTrue, *SelectFalse;
5332 if (match(Op0, m_Select(m_Value(Cond), m_Value(SelectTrue),
Pete Cooperbc5c5242011-12-01 03:58:40 +00005333 m_Value(SelectFalse)))) {
Pete Cooperfdddc272011-12-01 19:13:26 +00005334 if (Value *V = dyn_castNegVal(SelectTrue)) {
5335 if (V == SelectFalse)
5336 return CmpInst::Create(Instruction::ICmp, I.getPredicate(), V, Op1);
5337 }
5338 else if (Value *V = dyn_castNegVal(SelectFalse)) {
5339 if (V == SelectTrue)
5340 return CmpInst::Create(Instruction::ICmp, I.getPredicate(), V, Op1);
Pete Cooperbc5c5242011-12-01 03:58:40 +00005341 }
5342 }
5343 }
5344
Craig Topperfde47232017-07-09 07:04:03 +00005345 if (Op0->getType()->isIntOrIntVectorTy(1))
Craig Topperbb4069e2017-07-07 23:16:26 +00005346 if (Instruction *Res = canonicalizeICmpBool(I, Builder))
Sanjay Patele5747e32017-05-17 22:15:07 +00005347 return Res;
Chris Lattner2188e402010-01-04 07:37:31 +00005348
Sanjay Patele9b2c322016-05-17 00:57:57 +00005349 if (ICmpInst *NewICmp = canonicalizeCmpWithConstant(I))
Sanjay Pateld5b0e542016-04-29 16:22:25 +00005350 return NewICmp;
5351
Sanjay Patel06b127a2016-09-15 14:37:50 +00005352 if (Instruction *Res = foldICmpWithConstant(I))
5353 return Res;
Chris Lattner2188e402010-01-04 07:37:31 +00005354
Sanjay Pateld23b5ed2018-12-04 17:44:24 +00005355 if (Instruction *Res = foldICmpWithDominatingICmp(I))
5356 return Res;
5357
Max Kazantsev20da7e42018-07-06 04:04:13 +00005358 if (Instruction *Res = foldICmpUsingKnownBits(I))
5359 return Res;
5360
Chris Lattner2188e402010-01-04 07:37:31 +00005361 // Test if the ICmpInst instruction is used exclusively by a select as
5362 // part of a minimum or maximum operation. If so, refrain from doing
5363 // any other folding. This helps out other analyses which understand
5364 // non-obfuscated minimum and maximum idioms, such as ScalarEvolution
5365 // and CodeGen. And in this case, at least one of the comparison
5366 // operands has at least one user besides the compare (the select),
5367 // which would often largely negate the benefit of folding anyway.
Craig Topperd3e57812017-11-12 02:28:21 +00005368 //
5369 // Do the same for the other patterns recognized by matchSelectPattern.
Chris Lattner2188e402010-01-04 07:37:31 +00005370 if (I.hasOneUse())
Craig Topperd3e57812017-11-12 02:28:21 +00005371 if (SelectInst *SI = dyn_cast<SelectInst>(I.user_back())) {
5372 Value *A, *B;
5373 SelectPatternResult SPR = matchSelectPattern(SI, A, B);
5374 if (SPR.Flavor != SPF_UNKNOWN)
Craig Topperf40110f2014-04-25 05:29:35 +00005375 return nullptr;
Craig Topperd3e57812017-11-12 02:28:21 +00005376 }
Chris Lattner2188e402010-01-04 07:37:31 +00005377
Nikolai Bozhenov0e7ebbc2017-10-16 09:19:21 +00005378 // Do this after checking for min/max to prevent infinite looping.
5379 if (Instruction *Res = foldICmpWithZero(I))
5380 return Res;
5381
Sanjay Patelfebcb9c2017-01-27 23:26:27 +00005382 // FIXME: We only do this after checking for min/max to prevent infinite
5383 // looping caused by a reverse canonicalization of these patterns for min/max.
5384 // FIXME: The organization of folds is a mess. These would naturally go into
5385 // canonicalizeCmpWithConstant(), but we can't move all of the above folds
5386 // down here after the min/max restriction.
5387 ICmpInst::Predicate Pred = I.getPredicate();
5388 const APInt *C;
5389 if (match(Op1, m_APInt(C))) {
5390 // For i32: x >u 2147483647 -> x <s 0 -> true if sign bit set
5391 if (Pred == ICmpInst::ICMP_UGT && C->isMaxSignedValue()) {
5392 Constant *Zero = Constant::getNullValue(Op0->getType());
5393 return new ICmpInst(ICmpInst::ICMP_SLT, Op0, Zero);
5394 }
5395
5396 // For i32: x <u 2147483648 -> x >s -1 -> true if sign bit clear
5397 if (Pred == ICmpInst::ICMP_ULT && C->isMinSignedValue()) {
5398 Constant *AllOnes = Constant::getAllOnesValue(Op0->getType());
5399 return new ICmpInst(ICmpInst::ICMP_SGT, Op0, AllOnes);
5400 }
5401 }
5402
Sanjay Patelf58f68c2016-09-10 15:03:44 +00005403 if (Instruction *Res = foldICmpInstWithConstant(I))
Sanjay Patel1271bf92016-07-23 13:06:49 +00005404 return Res;
5405
Sanjay Patel10494b22016-09-16 16:10:22 +00005406 if (Instruction *Res = foldICmpInstWithConstantNotInt(I))
5407 return Res;
Chris Lattner2188e402010-01-04 07:37:31 +00005408
5409 // If we can optimize a 'icmp GEP, P' or 'icmp P, GEP', do so now.
5410 if (GEPOperator *GEP = dyn_cast<GEPOperator>(Op0))
Sanjay Patel43395062016-07-21 18:07:40 +00005411 if (Instruction *NI = foldGEPICmp(GEP, Op1, I.getPredicate(), I))
Chris Lattner2188e402010-01-04 07:37:31 +00005412 return NI;
5413 if (GEPOperator *GEP = dyn_cast<GEPOperator>(Op1))
Sanjay Patel43395062016-07-21 18:07:40 +00005414 if (Instruction *NI = foldGEPICmp(GEP, Op0,
Chris Lattner2188e402010-01-04 07:37:31 +00005415 ICmpInst::getSwappedPredicate(I.getPredicate()), I))
5416 return NI;
5417
Hans Wennborgf1f36512015-10-07 00:20:07 +00005418 // Try to optimize equality comparisons against alloca-based pointers.
5419 if (Op0->getType()->isPointerTy() && I.isEquality()) {
5420 assert(Op1->getType()->isPointerTy() && "Comparing pointer with non-pointer?");
5421 if (auto *Alloca = dyn_cast<AllocaInst>(GetUnderlyingObject(Op0, DL)))
Sanjay Patel43395062016-07-21 18:07:40 +00005422 if (Instruction *New = foldAllocaCmp(I, Alloca, Op1))
Hans Wennborgf1f36512015-10-07 00:20:07 +00005423 return New;
5424 if (auto *Alloca = dyn_cast<AllocaInst>(GetUnderlyingObject(Op1, DL)))
Sanjay Patel43395062016-07-21 18:07:40 +00005425 if (Instruction *New = foldAllocaCmp(I, Alloca, Op0))
Hans Wennborgf1f36512015-10-07 00:20:07 +00005426 return New;
5427 }
5428
Sanjay Patele7f46c32019-02-07 20:54:09 +00005429 if (Instruction *Res = foldICmpBitCast(I, Builder))
5430 return Res;
Jim Grosbach129c52a2011-09-30 18:09:53 +00005431
Sanjay Patela90ee0e2019-08-20 14:56:44 +00005432 if (Instruction *R = foldICmpWithCastOp(I))
5433 return R;
Chris Lattner2188e402010-01-04 07:37:31 +00005434
Sanjay Patel10494b22016-09-16 16:10:22 +00005435 if (Instruction *Res = foldICmpBinOp(I))
5436 return Res;
Duncan Sandse5220012011-02-17 07:46:37 +00005437
Sanjay Pateldd46b522016-12-19 17:32:37 +00005438 if (Instruction *Res = foldICmpWithMinMax(I))
Sanjay Pateld6406412016-12-15 19:13:37 +00005439 return Res;
5440
Sanjay Patel10494b22016-09-16 16:10:22 +00005441 {
5442 Value *A, *B;
David Majnemer1a08acc2013-04-12 17:25:07 +00005443 // Transform (A & ~B) == 0 --> (A & B) != 0
5444 // and (A & ~B) != 0 --> (A & B) == 0
5445 // if A is a power of 2.
5446 if (match(Op0, m_And(m_Value(A), m_Not(m_Value(B)))) &&
Chandler Carruth66b31302015-01-04 12:03:27 +00005447 match(Op1, m_Zero()) &&
Craig Topperd4039f72017-05-25 21:51:12 +00005448 isKnownToBeAPowerOfTwo(A, false, 0, &I) && I.isEquality())
Craig Topperbb4069e2017-07-07 23:16:26 +00005449 return new ICmpInst(I.getInversePredicate(), Builder.CreateAnd(A, B),
David Majnemer1a08acc2013-04-12 17:25:07 +00005450 Op1);
5451
Sanjay Patel4dc85eb2017-06-02 16:11:14 +00005452 // ~X < ~Y --> Y < X
5453 // ~X < C --> X > ~C
Chris Lattnerf3c4eef2011-01-15 05:41:33 +00005454 if (match(Op0, m_Not(m_Value(A)))) {
5455 if (match(Op1, m_Not(m_Value(B))))
5456 return new ICmpInst(I.getPredicate(), B, A);
Sanjay Patel4dc85eb2017-06-02 16:11:14 +00005457
Sanjay Patelce241f42017-06-02 16:29:41 +00005458 const APInt *C;
5459 if (match(Op1, m_APInt(C)))
Sanjay Patel4dc85eb2017-06-02 16:11:14 +00005460 return new ICmpInst(I.getSwappedPredicate(), A,
Sanjay Patelce241f42017-06-02 16:29:41 +00005461 ConstantInt::get(Op1->getType(), ~(*C)));
Chris Lattnerf3c4eef2011-01-15 05:41:33 +00005462 }
Chris Lattner5e0c0c72010-12-19 19:37:52 +00005463
Sanjoy Dasb6c59142015-04-10 21:07:09 +00005464 Instruction *AddI = nullptr;
5465 if (match(&I, m_UAddWithOverflow(m_Value(A), m_Value(B),
5466 m_Instruction(AddI))) &&
5467 isa<IntegerType>(A->getType())) {
5468 Value *Result;
5469 Constant *Overflow;
Nikita Popov352f5982019-05-26 11:43:31 +00005470 if (OptimizeOverflowCheck(Instruction::Add, /*Signed*/false, A, B,
5471 *AddI, Result, Overflow)) {
Sanjay Patel4b198802016-02-01 22:23:39 +00005472 replaceInstUsesWith(*AddI, Result);
5473 return replaceInstUsesWith(I, Overflow);
Sanjoy Dasb6c59142015-04-10 21:07:09 +00005474 }
5475 }
Serge Pavlov4bb54d52014-04-13 18:23:41 +00005476
5477 // (zext a) * (zext b) --> llvm.umul.with.overflow.
5478 if (match(Op0, m_Mul(m_ZExt(m_Value(A)), m_ZExt(m_Value(B))))) {
Sanjay Pateld93c4c02016-09-15 18:22:25 +00005479 if (Instruction *R = processUMulZExtIdiom(I, Op0, Op1, *this))
Serge Pavlov4bb54d52014-04-13 18:23:41 +00005480 return R;
5481 }
5482 if (match(Op1, m_Mul(m_ZExt(m_Value(A)), m_ZExt(m_Value(B))))) {
Sanjay Pateld93c4c02016-09-15 18:22:25 +00005483 if (Instruction *R = processUMulZExtIdiom(I, Op1, Op0, *this))
Serge Pavlov4bb54d52014-04-13 18:23:41 +00005484 return R;
5485 }
Chris Lattner2188e402010-01-04 07:37:31 +00005486 }
Jim Grosbach129c52a2011-09-30 18:09:53 +00005487
Sanjay Patel10494b22016-09-16 16:10:22 +00005488 if (Instruction *Res = foldICmpEquality(I))
5489 return Res;
Jim Grosbach129c52a2011-09-30 18:09:53 +00005490
David Majnemerc1eca5a2014-11-06 23:23:30 +00005491 // The 'cmpxchg' instruction returns an aggregate containing the old value and
5492 // an i1 which indicates whether or not we successfully did the swap.
5493 //
5494 // Replace comparisons between the old value and the expected value with the
5495 // indicator that 'cmpxchg' returns.
5496 //
5497 // N.B. This transform is only valid when the 'cmpxchg' is not permitted to
5498 // spuriously fail. In those cases, the old value may equal the expected
5499 // value but it is possible for the swap to not occur.
5500 if (I.getPredicate() == ICmpInst::ICMP_EQ)
5501 if (auto *EVI = dyn_cast<ExtractValueInst>(Op0))
5502 if (auto *ACXI = dyn_cast<AtomicCmpXchgInst>(EVI->getAggregateOperand()))
5503 if (EVI->getIndices()[0] == 0 && ACXI->getCompareOperand() == Op1 &&
5504 !ACXI->isWeak())
5505 return ExtractValueInst::Create(ACXI, 1);
5506
Chris Lattner2188e402010-01-04 07:37:31 +00005507 {
Craig Topperbee74792018-08-20 23:04:25 +00005508 Value *X;
5509 const APInt *C;
Chris Lattner2188e402010-01-04 07:37:31 +00005510 // icmp X+Cst, X
Craig Topperbee74792018-08-20 23:04:25 +00005511 if (match(Op0, m_Add(m_Value(X), m_APInt(C))) && Op1 == X)
5512 return foldICmpAddOpConst(X, *C, I.getPredicate());
Chris Lattner2188e402010-01-04 07:37:31 +00005513
5514 // icmp X, X+Cst
Craig Topperbee74792018-08-20 23:04:25 +00005515 if (match(Op1, m_Add(m_Value(X), m_APInt(C))) && Op0 == X)
5516 return foldICmpAddOpConst(X, *C, I.getSwappedPredicate());
Chris Lattner2188e402010-01-04 07:37:31 +00005517 }
Roman Lebedev68d54cf2018-07-11 19:05:04 +00005518
Roman Lebedev75404fb2018-09-12 18:19:43 +00005519 if (Instruction *Res = foldICmpWithHighBitMask(I, Builder))
5520 return Res;
5521
Sanjay Patel039f5562018-08-16 12:52:17 +00005522 if (I.getType()->isVectorTy())
5523 if (Instruction *Res = foldVectorCmp(I, Builder))
5524 return Res;
5525
Craig Topperf40110f2014-04-25 05:29:35 +00005526 return Changed ? &I : nullptr;
Chris Lattner2188e402010-01-04 07:37:31 +00005527}
5528
Sanjay Patel5f0217f2016-06-05 16:46:18 +00005529/// Fold fcmp ([us]itofp x, cst) if possible.
Sanjay Patel43395062016-07-21 18:07:40 +00005530Instruction *InstCombiner::foldFCmpIntToFPConst(FCmpInst &I, Instruction *LHSI,
Chris Lattner2188e402010-01-04 07:37:31 +00005531 Constant *RHSC) {
Craig Topperf40110f2014-04-25 05:29:35 +00005532 if (!isa<ConstantFP>(RHSC)) return nullptr;
Chris Lattner2188e402010-01-04 07:37:31 +00005533 const APFloat &RHS = cast<ConstantFP>(RHSC)->getValueAPF();
Jim Grosbach129c52a2011-09-30 18:09:53 +00005534
Chris Lattner2188e402010-01-04 07:37:31 +00005535 // Get the width of the mantissa. We don't want to hack on conversions that
5536 // might lose information from the integer, e.g. "i64 -> float"
5537 int MantissaWidth = LHSI->getType()->getFPMantissaWidth();
Craig Topperf40110f2014-04-25 05:29:35 +00005538 if (MantissaWidth == -1) return nullptr; // Unknown.
Jim Grosbach129c52a2011-09-30 18:09:53 +00005539
Matt Arsenault55e73122015-01-06 15:50:59 +00005540 IntegerType *IntTy = cast<IntegerType>(LHSI->getOperand(0)->getType());
5541
Chris Lattner2188e402010-01-04 07:37:31 +00005542 bool LHSUnsigned = isa<UIToFPInst>(LHSI);
Jim Grosbach129c52a2011-09-30 18:09:53 +00005543
Matt Arsenault55e73122015-01-06 15:50:59 +00005544 if (I.isEquality()) {
5545 FCmpInst::Predicate P = I.getPredicate();
5546 bool IsExact = false;
5547 APSInt RHSCvt(IntTy->getBitWidth(), LHSUnsigned);
5548 RHS.convertToInteger(RHSCvt, APFloat::rmNearestTiesToEven, &IsExact);
5549
5550 // If the floating point constant isn't an integer value, we know if we will
5551 // ever compare equal / not equal to it.
5552 if (!IsExact) {
5553 // TODO: Can never be -0.0 and other non-representable values
5554 APFloat RHSRoundInt(RHS);
5555 RHSRoundInt.roundToIntegral(APFloat::rmNearestTiesToEven);
5556 if (RHS.compare(RHSRoundInt) != APFloat::cmpEqual) {
5557 if (P == FCmpInst::FCMP_OEQ || P == FCmpInst::FCMP_UEQ)
Craig Topperbb4069e2017-07-07 23:16:26 +00005558 return replaceInstUsesWith(I, Builder.getFalse());
Matt Arsenault55e73122015-01-06 15:50:59 +00005559
5560 assert(P == FCmpInst::FCMP_ONE || P == FCmpInst::FCMP_UNE);
Craig Topperbb4069e2017-07-07 23:16:26 +00005561 return replaceInstUsesWith(I, Builder.getTrue());
Matt Arsenault55e73122015-01-06 15:50:59 +00005562 }
5563 }
5564
5565 // TODO: If the constant is exactly representable, is it always OK to do
5566 // equality compares as integer?
5567 }
5568
Arch D. Robison8ed08542015-09-15 17:51:59 +00005569 // Check to see that the input is converted from an integer type that is small
5570 // enough that preserves all bits. TODO: check here for "known" sign bits.
5571 // This would allow us to handle (fptosi (x >>s 62) to float) if x is i64 f.e.
5572 unsigned InputSize = IntTy->getScalarSizeInBits();
Matt Arsenault55e73122015-01-06 15:50:59 +00005573
Justin Bognerc7e4fbe2016-08-05 01:09:48 +00005574 // Following test does NOT adjust InputSize downwards for signed inputs,
5575 // because the most negative value still requires all the mantissa bits
Arch D. Robison8ed08542015-09-15 17:51:59 +00005576 // to distinguish it from one less than that value.
5577 if ((int)InputSize > MantissaWidth) {
5578 // Conversion would lose accuracy. Check if loss can impact comparison.
5579 int Exp = ilogb(RHS);
5580 if (Exp == APFloat::IEK_Inf) {
5581 int MaxExponent = ilogb(APFloat::getLargest(RHS.getSemantics()));
Justin Bognerc7e4fbe2016-08-05 01:09:48 +00005582 if (MaxExponent < (int)InputSize - !LHSUnsigned)
Arch D. Robison8ed08542015-09-15 17:51:59 +00005583 // Conversion could create infinity.
5584 return nullptr;
5585 } else {
Justin Bognerc7e4fbe2016-08-05 01:09:48 +00005586 // Note that if RHS is zero or NaN, then Exp is negative
Arch D. Robison8ed08542015-09-15 17:51:59 +00005587 // and first condition is trivially false.
Justin Bognerc7e4fbe2016-08-05 01:09:48 +00005588 if (MantissaWidth <= Exp && Exp <= (int)InputSize - !LHSUnsigned)
Arch D. Robison8ed08542015-09-15 17:51:59 +00005589 // Conversion could affect comparison.
5590 return nullptr;
5591 }
5592 }
Jim Grosbach129c52a2011-09-30 18:09:53 +00005593
Chris Lattner2188e402010-01-04 07:37:31 +00005594 // Otherwise, we can potentially simplify the comparison. We know that it
5595 // will always come through as an integer value and we know the constant is
5596 // not a NAN (it would have been previously simplified).
5597 assert(!RHS.isNaN() && "NaN comparison not already folded!");
Jim Grosbach129c52a2011-09-30 18:09:53 +00005598
Chris Lattner2188e402010-01-04 07:37:31 +00005599 ICmpInst::Predicate Pred;
5600 switch (I.getPredicate()) {
5601 default: llvm_unreachable("Unexpected predicate!");
5602 case FCmpInst::FCMP_UEQ:
5603 case FCmpInst::FCMP_OEQ:
5604 Pred = ICmpInst::ICMP_EQ;
5605 break;
5606 case FCmpInst::FCMP_UGT:
5607 case FCmpInst::FCMP_OGT:
5608 Pred = LHSUnsigned ? ICmpInst::ICMP_UGT : ICmpInst::ICMP_SGT;
5609 break;
5610 case FCmpInst::FCMP_UGE:
5611 case FCmpInst::FCMP_OGE:
5612 Pred = LHSUnsigned ? ICmpInst::ICMP_UGE : ICmpInst::ICMP_SGE;
5613 break;
5614 case FCmpInst::FCMP_ULT:
5615 case FCmpInst::FCMP_OLT:
5616 Pred = LHSUnsigned ? ICmpInst::ICMP_ULT : ICmpInst::ICMP_SLT;
5617 break;
5618 case FCmpInst::FCMP_ULE:
5619 case FCmpInst::FCMP_OLE:
5620 Pred = LHSUnsigned ? ICmpInst::ICMP_ULE : ICmpInst::ICMP_SLE;
5621 break;
5622 case FCmpInst::FCMP_UNE:
5623 case FCmpInst::FCMP_ONE:
5624 Pred = ICmpInst::ICMP_NE;
5625 break;
5626 case FCmpInst::FCMP_ORD:
Craig Topperbb4069e2017-07-07 23:16:26 +00005627 return replaceInstUsesWith(I, Builder.getTrue());
Chris Lattner2188e402010-01-04 07:37:31 +00005628 case FCmpInst::FCMP_UNO:
Craig Topperbb4069e2017-07-07 23:16:26 +00005629 return replaceInstUsesWith(I, Builder.getFalse());
Chris Lattner2188e402010-01-04 07:37:31 +00005630 }
Jim Grosbach129c52a2011-09-30 18:09:53 +00005631
Chris Lattner2188e402010-01-04 07:37:31 +00005632 // Now we know that the APFloat is a normal number, zero or inf.
Jim Grosbach129c52a2011-09-30 18:09:53 +00005633
Chris Lattner2188e402010-01-04 07:37:31 +00005634 // See if the FP constant is too large for the integer. For example,
5635 // comparing an i8 to 300.0.
5636 unsigned IntWidth = IntTy->getScalarSizeInBits();
Jim Grosbach129c52a2011-09-30 18:09:53 +00005637
Chris Lattner2188e402010-01-04 07:37:31 +00005638 if (!LHSUnsigned) {
5639 // If the RHS value is > SignedMax, fold the comparison. This handles +INF
5640 // and large values.
Michael Gottesman79b09672013-06-27 21:58:19 +00005641 APFloat SMax(RHS.getSemantics());
Chris Lattner2188e402010-01-04 07:37:31 +00005642 SMax.convertFromAPInt(APInt::getSignedMaxValue(IntWidth), true,
5643 APFloat::rmNearestTiesToEven);
5644 if (SMax.compare(RHS) == APFloat::cmpLessThan) { // smax < 13123.0
5645 if (Pred == ICmpInst::ICMP_NE || Pred == ICmpInst::ICMP_SLT ||
5646 Pred == ICmpInst::ICMP_SLE)
Craig Topperbb4069e2017-07-07 23:16:26 +00005647 return replaceInstUsesWith(I, Builder.getTrue());
5648 return replaceInstUsesWith(I, Builder.getFalse());
Chris Lattner2188e402010-01-04 07:37:31 +00005649 }
5650 } else {
5651 // If the RHS value is > UnsignedMax, fold the comparison. This handles
5652 // +INF and large values.
Michael Gottesman79b09672013-06-27 21:58:19 +00005653 APFloat UMax(RHS.getSemantics());
Chris Lattner2188e402010-01-04 07:37:31 +00005654 UMax.convertFromAPInt(APInt::getMaxValue(IntWidth), false,
5655 APFloat::rmNearestTiesToEven);
5656 if (UMax.compare(RHS) == APFloat::cmpLessThan) { // umax < 13123.0
5657 if (Pred == ICmpInst::ICMP_NE || Pred == ICmpInst::ICMP_ULT ||
5658 Pred == ICmpInst::ICMP_ULE)
Craig Topperbb4069e2017-07-07 23:16:26 +00005659 return replaceInstUsesWith(I, Builder.getTrue());
5660 return replaceInstUsesWith(I, Builder.getFalse());
Chris Lattner2188e402010-01-04 07:37:31 +00005661 }
5662 }
Jim Grosbach129c52a2011-09-30 18:09:53 +00005663
Chris Lattner2188e402010-01-04 07:37:31 +00005664 if (!LHSUnsigned) {
5665 // See if the RHS value is < SignedMin.
Michael Gottesman79b09672013-06-27 21:58:19 +00005666 APFloat SMin(RHS.getSemantics());
Chris Lattner2188e402010-01-04 07:37:31 +00005667 SMin.convertFromAPInt(APInt::getSignedMinValue(IntWidth), true,
5668 APFloat::rmNearestTiesToEven);
5669 if (SMin.compare(RHS) == APFloat::cmpGreaterThan) { // smin > 12312.0
5670 if (Pred == ICmpInst::ICMP_NE || Pred == ICmpInst::ICMP_SGT ||
5671 Pred == ICmpInst::ICMP_SGE)
Craig Topperbb4069e2017-07-07 23:16:26 +00005672 return replaceInstUsesWith(I, Builder.getTrue());
5673 return replaceInstUsesWith(I, Builder.getFalse());
Chris Lattner2188e402010-01-04 07:37:31 +00005674 }
Devang Patel698452b2012-02-13 23:05:18 +00005675 } else {
5676 // See if the RHS value is < UnsignedMin.
Michael Gottesman79b09672013-06-27 21:58:19 +00005677 APFloat SMin(RHS.getSemantics());
Devang Patel698452b2012-02-13 23:05:18 +00005678 SMin.convertFromAPInt(APInt::getMinValue(IntWidth), true,
5679 APFloat::rmNearestTiesToEven);
5680 if (SMin.compare(RHS) == APFloat::cmpGreaterThan) { // umin > 12312.0
5681 if (Pred == ICmpInst::ICMP_NE || Pred == ICmpInst::ICMP_UGT ||
5682 Pred == ICmpInst::ICMP_UGE)
Craig Topperbb4069e2017-07-07 23:16:26 +00005683 return replaceInstUsesWith(I, Builder.getTrue());
5684 return replaceInstUsesWith(I, Builder.getFalse());
Devang Patel698452b2012-02-13 23:05:18 +00005685 }
Chris Lattner2188e402010-01-04 07:37:31 +00005686 }
5687
5688 // Okay, now we know that the FP constant fits in the range [SMIN, SMAX] or
5689 // [0, UMAX], but it may still be fractional. See if it is fractional by
5690 // casting the FP value to the integer value and back, checking for equality.
5691 // Don't do this for zero, because -0.0 is not fractional.
5692 Constant *RHSInt = LHSUnsigned
5693 ? ConstantExpr::getFPToUI(RHSC, IntTy)
5694 : ConstantExpr::getFPToSI(RHSC, IntTy);
5695 if (!RHS.isZero()) {
5696 bool Equal = LHSUnsigned
5697 ? ConstantExpr::getUIToFP(RHSInt, RHSC->getType()) == RHSC
5698 : ConstantExpr::getSIToFP(RHSInt, RHSC->getType()) == RHSC;
5699 if (!Equal) {
5700 // If we had a comparison against a fractional value, we have to adjust
5701 // the compare predicate and sometimes the value. RHSC is rounded towards
5702 // zero at this point.
5703 switch (Pred) {
5704 default: llvm_unreachable("Unexpected integer comparison!");
5705 case ICmpInst::ICMP_NE: // (float)int != 4.4 --> true
Craig Topperbb4069e2017-07-07 23:16:26 +00005706 return replaceInstUsesWith(I, Builder.getTrue());
Chris Lattner2188e402010-01-04 07:37:31 +00005707 case ICmpInst::ICMP_EQ: // (float)int == 4.4 --> false
Craig Topperbb4069e2017-07-07 23:16:26 +00005708 return replaceInstUsesWith(I, Builder.getFalse());
Chris Lattner2188e402010-01-04 07:37:31 +00005709 case ICmpInst::ICMP_ULE:
5710 // (float)int <= 4.4 --> int <= 4
5711 // (float)int <= -4.4 --> false
5712 if (RHS.isNegative())
Craig Topperbb4069e2017-07-07 23:16:26 +00005713 return replaceInstUsesWith(I, Builder.getFalse());
Chris Lattner2188e402010-01-04 07:37:31 +00005714 break;
5715 case ICmpInst::ICMP_SLE:
5716 // (float)int <= 4.4 --> int <= 4
5717 // (float)int <= -4.4 --> int < -4
5718 if (RHS.isNegative())
5719 Pred = ICmpInst::ICMP_SLT;
5720 break;
5721 case ICmpInst::ICMP_ULT:
5722 // (float)int < -4.4 --> false
5723 // (float)int < 4.4 --> int <= 4
5724 if (RHS.isNegative())
Craig Topperbb4069e2017-07-07 23:16:26 +00005725 return replaceInstUsesWith(I, Builder.getFalse());
Chris Lattner2188e402010-01-04 07:37:31 +00005726 Pred = ICmpInst::ICMP_ULE;
5727 break;
5728 case ICmpInst::ICMP_SLT:
5729 // (float)int < -4.4 --> int < -4
5730 // (float)int < 4.4 --> int <= 4
5731 if (!RHS.isNegative())
5732 Pred = ICmpInst::ICMP_SLE;
5733 break;
5734 case ICmpInst::ICMP_UGT:
5735 // (float)int > 4.4 --> int > 4
5736 // (float)int > -4.4 --> true
5737 if (RHS.isNegative())
Craig Topperbb4069e2017-07-07 23:16:26 +00005738 return replaceInstUsesWith(I, Builder.getTrue());
Chris Lattner2188e402010-01-04 07:37:31 +00005739 break;
5740 case ICmpInst::ICMP_SGT:
5741 // (float)int > 4.4 --> int > 4
5742 // (float)int > -4.4 --> int >= -4
5743 if (RHS.isNegative())
5744 Pred = ICmpInst::ICMP_SGE;
5745 break;
5746 case ICmpInst::ICMP_UGE:
5747 // (float)int >= -4.4 --> true
5748 // (float)int >= 4.4 --> int > 4
Bob Wilson61f3ad52012-08-07 22:35:16 +00005749 if (RHS.isNegative())
Craig Topperbb4069e2017-07-07 23:16:26 +00005750 return replaceInstUsesWith(I, Builder.getTrue());
Chris Lattner2188e402010-01-04 07:37:31 +00005751 Pred = ICmpInst::ICMP_UGT;
5752 break;
5753 case ICmpInst::ICMP_SGE:
5754 // (float)int >= -4.4 --> int >= -4
5755 // (float)int >= 4.4 --> int > 4
5756 if (!RHS.isNegative())
5757 Pred = ICmpInst::ICMP_SGT;
5758 break;
5759 }
5760 }
5761 }
5762
5763 // Lower this FP comparison into an appropriate integer version of the
5764 // comparison.
5765 return new ICmpInst(Pred, LHSI->getOperand(0), RHSInt);
5766}
5767
Sanjay Patelc3f50ff2018-09-27 15:59:24 +00005768/// Fold (C / X) < 0.0 --> X < 0.0 if possible. Swap predicate if necessary.
5769static Instruction *foldFCmpReciprocalAndZero(FCmpInst &I, Instruction *LHSI,
5770 Constant *RHSC) {
5771 // When C is not 0.0 and infinities are not allowed:
5772 // (C / X) < 0.0 is a sign-bit test of X
5773 // (C / X) < 0.0 --> X < 0.0 (if C is positive)
5774 // (C / X) < 0.0 --> X > 0.0 (if C is negative, swap the predicate)
5775 //
5776 // Proof:
5777 // Multiply (C / X) < 0.0 by X * X / C.
5778 // - X is non zero, if it is the flag 'ninf' is violated.
5779 // - C defines the sign of X * X * C. Thus it also defines whether to swap
5780 // the predicate. C is also non zero by definition.
5781 //
5782 // Thus X * X / C is non zero and the transformation is valid. [qed]
5783
5784 FCmpInst::Predicate Pred = I.getPredicate();
5785
5786 // Check that predicates are valid.
5787 if ((Pred != FCmpInst::FCMP_OGT) && (Pred != FCmpInst::FCMP_OLT) &&
5788 (Pred != FCmpInst::FCMP_OGE) && (Pred != FCmpInst::FCMP_OLE))
5789 return nullptr;
5790
5791 // Check that RHS operand is zero.
5792 if (!match(RHSC, m_AnyZeroFP()))
5793 return nullptr;
5794
5795 // Check fastmath flags ('ninf').
5796 if (!LHSI->hasNoInfs() || !I.hasNoInfs())
5797 return nullptr;
5798
5799 // Check the properties of the dividend. It must not be zero to avoid a
5800 // division by zero (see Proof).
5801 const APFloat *C;
5802 if (!match(LHSI->getOperand(0), m_APFloat(C)))
5803 return nullptr;
5804
5805 if (C->isZero())
5806 return nullptr;
5807
5808 // Get swapped predicate if necessary.
5809 if (C->isNegative())
5810 Pred = I.getSwappedPredicate();
5811
Sanjay Pateld1172a02018-11-07 00:00:42 +00005812 return new FCmpInst(Pred, LHSI->getOperand(1), RHSC, "", &I);
Sanjay Patelc3f50ff2018-09-27 15:59:24 +00005813}
5814
Sanjay Patel1c254c62018-10-31 16:34:43 +00005815/// Optimize fabs(X) compared with zero.
5816static Instruction *foldFabsWithFcmpZero(FCmpInst &I) {
5817 Value *X;
5818 if (!match(I.getOperand(0), m_Intrinsic<Intrinsic::fabs>(m_Value(X))) ||
5819 !match(I.getOperand(1), m_PosZeroFP()))
5820 return nullptr;
5821
Sanjay Patel57a08b32018-11-07 16:15:01 +00005822 auto replacePredAndOp0 = [](FCmpInst *I, FCmpInst::Predicate P, Value *X) {
5823 I->setPredicate(P);
5824 I->setOperand(0, X);
5825 return I;
5826 };
5827
Sanjay Patel1c254c62018-10-31 16:34:43 +00005828 switch (I.getPredicate()) {
5829 case FCmpInst::FCMP_UGE:
5830 case FCmpInst::FCMP_OLT:
5831 // fabs(X) >= 0.0 --> true
5832 // fabs(X) < 0.0 --> false
5833 llvm_unreachable("fcmp should have simplified");
5834
5835 case FCmpInst::FCMP_OGT:
5836 // fabs(X) > 0.0 --> X != 0.0
Sanjay Patel57a08b32018-11-07 16:15:01 +00005837 return replacePredAndOp0(&I, FCmpInst::FCMP_ONE, X);
Sanjay Patel1c254c62018-10-31 16:34:43 +00005838
Sanjay Patelfa5f1462018-11-07 15:33:03 +00005839 case FCmpInst::FCMP_UGT:
5840 // fabs(X) u> 0.0 --> X u!= 0.0
Sanjay Patel57a08b32018-11-07 16:15:01 +00005841 return replacePredAndOp0(&I, FCmpInst::FCMP_UNE, X);
Sanjay Patelfa5f1462018-11-07 15:33:03 +00005842
Sanjay Patel1c254c62018-10-31 16:34:43 +00005843 case FCmpInst::FCMP_OLE:
5844 // fabs(X) <= 0.0 --> X == 0.0
Sanjay Patel57a08b32018-11-07 16:15:01 +00005845 return replacePredAndOp0(&I, FCmpInst::FCMP_OEQ, X);
Sanjay Patel1c254c62018-10-31 16:34:43 +00005846
Sanjay Patelfa5f1462018-11-07 15:33:03 +00005847 case FCmpInst::FCMP_ULE:
5848 // fabs(X) u<= 0.0 --> X u== 0.0
Sanjay Patel57a08b32018-11-07 16:15:01 +00005849 return replacePredAndOp0(&I, FCmpInst::FCMP_UEQ, X);
Sanjay Patelfa5f1462018-11-07 15:33:03 +00005850
Sanjay Patel1c254c62018-10-31 16:34:43 +00005851 case FCmpInst::FCMP_OGE:
5852 // fabs(X) >= 0.0 --> !isnan(X)
5853 assert(!I.hasNoNaNs() && "fcmp should have simplified");
Sanjay Patel57a08b32018-11-07 16:15:01 +00005854 return replacePredAndOp0(&I, FCmpInst::FCMP_ORD, X);
Sanjay Patel1c254c62018-10-31 16:34:43 +00005855
Sanjay Patel76faf512018-11-07 15:11:32 +00005856 case FCmpInst::FCMP_ULT:
5857 // fabs(X) u< 0.0 --> isnan(X)
5858 assert(!I.hasNoNaNs() && "fcmp should have simplified");
Sanjay Patel57a08b32018-11-07 16:15:01 +00005859 return replacePredAndOp0(&I, FCmpInst::FCMP_UNO, X);
Sanjay Patel76faf512018-11-07 15:11:32 +00005860
Sanjay Patel1c254c62018-10-31 16:34:43 +00005861 case FCmpInst::FCMP_OEQ:
5862 case FCmpInst::FCMP_UEQ:
5863 case FCmpInst::FCMP_ONE:
5864 case FCmpInst::FCMP_UNE:
Sanjay Patelbb521e62018-11-07 15:44:26 +00005865 case FCmpInst::FCMP_ORD:
5866 case FCmpInst::FCMP_UNO:
5867 // Look through the fabs() because it doesn't change anything but the sign.
5868 // fabs(X) == 0.0 --> X == 0.0,
Sanjay Patel1c254c62018-10-31 16:34:43 +00005869 // fabs(X) != 0.0 --> X != 0.0
Sanjay Patelbb521e62018-11-07 15:44:26 +00005870 // isnan(fabs(X)) --> isnan(X)
5871 // !isnan(fabs(X) --> !isnan(X)
Sanjay Patel57a08b32018-11-07 16:15:01 +00005872 return replacePredAndOp0(&I, I.getPredicate(), X);
Sanjay Patel1c254c62018-10-31 16:34:43 +00005873
5874 default:
5875 return nullptr;
5876 }
5877}
5878
Chris Lattner2188e402010-01-04 07:37:31 +00005879Instruction *InstCombiner::visitFCmpInst(FCmpInst &I) {
5880 bool Changed = false;
Jim Grosbach129c52a2011-09-30 18:09:53 +00005881
Chris Lattner2188e402010-01-04 07:37:31 +00005882 /// Orders the operands of the compare so that they are listed from most
5883 /// complex to least complex. This puts constants before unary operators,
5884 /// before binary operators.
5885 if (getComplexity(I.getOperand(0)) < getComplexity(I.getOperand(1))) {
5886 I.swapOperands();
5887 Changed = true;
5888 }
5889
Sanjay Patel6b139462017-09-02 15:11:55 +00005890 const CmpInst::Predicate Pred = I.getPredicate();
Chris Lattner2188e402010-01-04 07:37:31 +00005891 Value *Op0 = I.getOperand(0), *Op1 = I.getOperand(1);
Sanjay Patel6b139462017-09-02 15:11:55 +00005892 if (Value *V = SimplifyFCmpInst(Pred, Op0, Op1, I.getFastMathFlags(),
5893 SQ.getWithInstruction(&I)))
Sanjay Patel4b198802016-02-01 22:23:39 +00005894 return replaceInstUsesWith(I, V);
Chris Lattner2188e402010-01-04 07:37:31 +00005895
5896 // Simplify 'fcmp pred X, X'
Sanjay Patela706b9a2019-04-29 19:23:44 +00005897 Type *OpType = Op0->getType();
5898 assert(OpType == Op1->getType() && "fcmp with different-typed operands?");
Chris Lattner2188e402010-01-04 07:37:31 +00005899 if (Op0 == Op1) {
Sanjay Patel6b139462017-09-02 15:11:55 +00005900 switch (Pred) {
5901 default: break;
Chris Lattner2188e402010-01-04 07:37:31 +00005902 case FCmpInst::FCMP_UNO: // True if unordered: isnan(X) | isnan(Y)
5903 case FCmpInst::FCMP_ULT: // True if unordered or less than
5904 case FCmpInst::FCMP_UGT: // True if unordered or greater than
5905 case FCmpInst::FCMP_UNE: // True if unordered or not equal
5906 // Canonicalize these to be 'fcmp uno %X, 0.0'.
5907 I.setPredicate(FCmpInst::FCMP_UNO);
Sanjay Patela706b9a2019-04-29 19:23:44 +00005908 I.setOperand(1, Constant::getNullValue(OpType));
Chris Lattner2188e402010-01-04 07:37:31 +00005909 return &I;
Jim Grosbach129c52a2011-09-30 18:09:53 +00005910
Chris Lattner2188e402010-01-04 07:37:31 +00005911 case FCmpInst::FCMP_ORD: // True if ordered (no nans)
5912 case FCmpInst::FCMP_OEQ: // True if ordered and equal
5913 case FCmpInst::FCMP_OGE: // True if ordered and greater than or equal
5914 case FCmpInst::FCMP_OLE: // True if ordered and less than or equal
5915 // Canonicalize these to be 'fcmp ord %X, 0.0'.
5916 I.setPredicate(FCmpInst::FCMP_ORD);
Sanjay Patela706b9a2019-04-29 19:23:44 +00005917 I.setOperand(1, Constant::getNullValue(OpType));
Chris Lattner2188e402010-01-04 07:37:31 +00005918 return &I;
5919 }
5920 }
Jim Grosbach129c52a2011-09-30 18:09:53 +00005921
Sanjay Patel6840c5f2017-09-05 23:13:13 +00005922 // If we're just checking for a NaN (ORD/UNO) and have a non-NaN operand,
5923 // then canonicalize the operand to 0.0.
5924 if (Pred == CmpInst::FCMP_ORD || Pred == CmpInst::FCMP_UNO) {
Matt Arsenaultd54b7f02018-08-09 22:40:08 +00005925 if (!match(Op0, m_PosZeroFP()) && isKnownNeverNaN(Op0, &TLI)) {
Sanjay Patela706b9a2019-04-29 19:23:44 +00005926 I.setOperand(0, ConstantFP::getNullValue(OpType));
Sanjay Patel6840c5f2017-09-05 23:13:13 +00005927 return &I;
5928 }
Matt Arsenaultd54b7f02018-08-09 22:40:08 +00005929 if (!match(Op1, m_PosZeroFP()) && isKnownNeverNaN(Op1, &TLI)) {
Sanjay Patela706b9a2019-04-29 19:23:44 +00005930 I.setOperand(1, ConstantFP::getNullValue(OpType));
Sanjay Patel6840c5f2017-09-05 23:13:13 +00005931 return &I;
5932 }
5933 }
5934
Sanjay Patel6a281a72019-05-07 18:58:07 +00005935 // fcmp pred (fneg X), (fneg Y) -> fcmp swap(pred) X, Y
5936 Value *X, *Y;
5937 if (match(Op0, m_FNeg(m_Value(X))) && match(Op1, m_FNeg(m_Value(Y))))
5938 return new FCmpInst(I.getSwappedPredicate(), X, Y, "", &I);
5939
James Molloy2b21a7c2015-05-20 18:41:25 +00005940 // Test if the FCmpInst instruction is used exclusively by a select as
5941 // part of a minimum or maximum operation. If so, refrain from doing
5942 // any other folding. This helps out other analyses which understand
5943 // non-obfuscated minimum and maximum idioms, such as ScalarEvolution
5944 // and CodeGen. And in this case, at least one of the comparison
5945 // operands has at least one user besides the compare (the select),
5946 // which would often largely negate the benefit of folding anyway.
5947 if (I.hasOneUse())
Craig Topperd3e57812017-11-12 02:28:21 +00005948 if (SelectInst *SI = dyn_cast<SelectInst>(I.user_back())) {
5949 Value *A, *B;
5950 SelectPatternResult SPR = matchSelectPattern(SI, A, B);
5951 if (SPR.Flavor != SPF_UNKNOWN)
James Molloy2b21a7c2015-05-20 18:41:25 +00005952 return nullptr;
Craig Topperd3e57812017-11-12 02:28:21 +00005953 }
James Molloy2b21a7c2015-05-20 18:41:25 +00005954
Sanjay Patelc26fd1e2018-11-05 17:26:42 +00005955 // The sign of 0.0 is ignored by fcmp, so canonicalize to +0.0:
5956 // fcmp Pred X, -0.0 --> fcmp Pred X, 0.0
5957 if (match(Op1, m_AnyZeroFP()) && !match(Op1, m_PosZeroFP())) {
Sanjay Patela706b9a2019-04-29 19:23:44 +00005958 I.setOperand(1, ConstantFP::getNullValue(OpType));
Sanjay Patelc26fd1e2018-11-05 17:26:42 +00005959 return &I;
5960 }
5961
Sanjay Patel4c39dfc2018-10-30 20:52:25 +00005962 // Handle fcmp with instruction LHS and constant RHS.
5963 Instruction *LHSI;
5964 Constant *RHSC;
5965 if (match(Op0, m_Instruction(LHSI)) && match(Op1, m_Constant(RHSC))) {
5966 switch (LHSI->getOpcode()) {
Sanjay Patel4c39dfc2018-10-30 20:52:25 +00005967 case Instruction::PHI:
5968 // Only fold fcmp into the PHI if the phi and fcmp are in the same
5969 // block. If in the same block, we're encouraging jump threading. If
5970 // not, we are just pessimizing the code by making an i1 phi.
5971 if (LHSI->getParent() == I.getParent())
5972 if (Instruction *NV = foldOpIntoPhi(I, cast<PHINode>(LHSI)))
Chris Lattner2188e402010-01-04 07:37:31 +00005973 return NV;
Sanjay Patel4c39dfc2018-10-30 20:52:25 +00005974 break;
5975 case Instruction::SIToFP:
5976 case Instruction::UIToFP:
5977 if (Instruction *NV = foldFCmpIntToFPConst(I, LHSI, RHSC))
5978 return NV;
5979 break;
Sanjay Patel4c39dfc2018-10-30 20:52:25 +00005980 case Instruction::FDiv:
5981 if (Instruction *NV = foldFCmpReciprocalAndZero(I, LHSI, RHSC))
5982 return NV;
5983 break;
5984 case Instruction::Load:
5985 if (auto *GEP = dyn_cast<GetElementPtrInst>(LHSI->getOperand(0)))
5986 if (auto *GV = dyn_cast<GlobalVariable>(GEP->getOperand(0)))
5987 if (GV->isConstant() && GV->hasDefinitiveInitializer() &&
5988 !cast<LoadInst>(LHSI)->isVolatile())
5989 if (Instruction *Res = foldCmpLoadFromIndexedGlobal(GEP, GV, I))
5990 return Res;
5991 break;
Sanjay Patel1c254c62018-10-31 16:34:43 +00005992 }
Chris Lattner2188e402010-01-04 07:37:31 +00005993 }
5994
Sanjay Pateld1172a02018-11-07 00:00:42 +00005995 if (Instruction *R = foldFabsWithFcmpZero(I))
5996 return R;
5997
Sanjay Patel70282a02018-11-06 15:49:45 +00005998 if (match(Op0, m_FNeg(m_Value(X)))) {
Sanjay Pateld1172a02018-11-07 00:00:42 +00005999 // fcmp pred (fneg X), C --> fcmp swap(pred) X, -C
Sanjay Patel70282a02018-11-06 15:49:45 +00006000 Constant *C;
6001 if (match(Op1, m_Constant(C))) {
Sanjay Patel70282a02018-11-06 15:49:45 +00006002 Constant *NegC = ConstantExpr::getFNeg(C);
Sanjay Pateld1172a02018-11-07 00:00:42 +00006003 return new FCmpInst(I.getSwappedPredicate(), X, NegC, "", &I);
Sanjay Patel70282a02018-11-06 15:49:45 +00006004 }
6005 }
Benjamin Kramerd159d942011-03-31 10:12:22 +00006006
Sanjay Patel7c3ee4d2018-11-06 16:37:35 +00006007 if (match(Op0, m_FPExt(m_Value(X)))) {
Sanjay Pateld1172a02018-11-07 00:00:42 +00006008 // fcmp (fpext X), (fpext Y) -> fcmp X, Y
6009 if (match(Op1, m_FPExt(m_Value(Y))) && X->getType() == Y->getType())
6010 return new FCmpInst(Pred, X, Y, "", &I);
Sanjay Patel7c3ee4d2018-11-06 16:37:35 +00006011
Sanjay Pateld1172a02018-11-07 00:00:42 +00006012 // fcmp (fpext X), C -> fcmp X, (fptrunc C) if fptrunc is lossless
Sanjay Patel724014a2018-11-06 17:20:20 +00006013 const APFloat *C;
6014 if (match(Op1, m_APFloat(C))) {
Sanjay Patel724014a2018-11-06 17:20:20 +00006015 const fltSemantics &FPSem =
6016 X->getType()->getScalarType()->getFltSemantics();
Sanjay Patel7c3ee4d2018-11-06 16:37:35 +00006017 bool Lossy;
Sanjay Patel724014a2018-11-06 17:20:20 +00006018 APFloat TruncC = *C;
6019 TruncC.convert(FPSem, APFloat::rmNearestTiesToEven, &Lossy);
Sanjay Patel7c3ee4d2018-11-06 16:37:35 +00006020
6021 // Avoid lossy conversions and denormals.
6022 // Zero is a special case that's OK to convert.
Sanjay Patel724014a2018-11-06 17:20:20 +00006023 APFloat Fabs = TruncC;
Sanjay Patel7c3ee4d2018-11-06 16:37:35 +00006024 Fabs.clearSign();
6025 if (!Lossy &&
6026 ((Fabs.compare(APFloat::getSmallestNormalized(FPSem)) !=
Sanjay Patel46bf3922018-11-06 16:45:27 +00006027 APFloat::cmpLessThan) || Fabs.isZero())) {
Sanjay Patel724014a2018-11-06 17:20:20 +00006028 Constant *NewC = ConstantFP::get(X->getType(), TruncC);
Sanjay Pateld1172a02018-11-07 00:00:42 +00006029 return new FCmpInst(Pred, X, NewC, "", &I);
Sanjay Patel46bf3922018-11-06 16:45:27 +00006030 }
Sanjay Patel7c3ee4d2018-11-06 16:37:35 +00006031 }
Sanjay Patel1b85f0022018-11-06 16:23:03 +00006032 }
Benjamin Kramer2ccfbc82011-03-31 10:11:58 +00006033
Sanjay Patel039f5562018-08-16 12:52:17 +00006034 if (I.getType()->isVectorTy())
6035 if (Instruction *Res = foldVectorCmp(I, Builder))
6036 return Res;
6037
Craig Topperf40110f2014-04-25 05:29:35 +00006038 return Changed ? &I : nullptr;
Chris Lattner2188e402010-01-04 07:37:31 +00006039}