blob: 38f1f1ac6554b0c9e41d10bd3b86f46e67215e7d [file] [log] [blame]
John Thompsond977c1e2013-03-27 18:34:38 +00001//===- extra/modularize/Modularize.cpp - Check modularized headers --------===//
John Thompson4f8ba652013-03-12 02:07:30 +00002//
3// The LLVM Compiler Infrastructure
4//
5// This file is distributed under the University of Illinois Open Source
6// License. See LICENSE.TXT for details.
7//
8//===----------------------------------------------------------------------===//
9//
John Thompson8eb8d932015-02-19 16:47:27 +000010// Introduction
11//
John Thompson4f8ba652013-03-12 02:07:30 +000012// This file implements a tool that checks whether a set of headers provides
John Thompson9cb79642015-02-18 16:14:32 +000013// the consistent definitions required to use modules. It can also check an
14// existing module map for full coverage of the headers in a directory tree.
15//
16// For example, in examining headers, it detects whether the same entity
17// (say, a NULL macro or size_t typedef) is defined in multiple headers
18// or whether a header produces different definitions under
John Thompson4f8ba652013-03-12 02:07:30 +000019// different circumstances. These conditions cause modules built from the
John Thompsonf5db45b2013-03-27 01:02:46 +000020// headers to behave poorly, and should be fixed before introducing a module
John Thompson4f8ba652013-03-12 02:07:30 +000021// map.
22//
John Thompson9cb79642015-02-18 16:14:32 +000023// Modularize takes as input either one or more module maps (by default,
24// "module.modulemap") or one or more text files contatining lists of headers
25// to check.
26//
27// In the case of a module map, the module map must be well-formed in
28// terms of syntax. Modularize will extract the header file names
29// from the map. Only normal headers are checked, assuming headers
30// marked "private", "textual", or "exclude" are not to be checked
31// as a top-level include, assuming they either are included by
32// other headers which are checked, or they are not suitable for
33// modules.
34//
35// In the case of a file list, the list is a newline-separated list of headers
36// to check with respect to each other.
John Thompsonf5db45b2013-03-27 01:02:46 +000037// Lines beginning with '#' and empty lines are ignored.
John Thompson7d0213c2013-09-04 20:46:24 +000038// Header file names followed by a colon and other space-separated
39// file names will include those extra files as dependencies.
40// The file names can be relative or full paths, but must be on the
41// same line.
42//
John Thompson9cb79642015-02-18 16:14:32 +000043// Modularize also accepts regular clang front-end arguments.
John Thompson4f8ba652013-03-12 02:07:30 +000044//
John Thompson9cb79642015-02-18 16:14:32 +000045// Usage: modularize [(modularize options)]
46// [(include-files_list)|(module map)]+ [(front-end-options) ...]
John Thompsoneaa4c732015-02-18 15:11:12 +000047//
48// Options:
49// -prefix (optional header path prefix)
50// Note that unless a "-prefix (header path)" option is specified,
51// non-absolute file paths in the header list file will be relative
52// to the header list file directory. Use -prefix to specify a
53// different directory.
54// -module-map-path (module map)
55// Skip the checks, and instead act as a module.map generation
56// assistant, generating a module map file based on the header list.
57// An optional "-root-module=(rootName)" argument can specify a root
58// module to be created in the generated module.map file. Note that
59// you will likely need to edit this file to suit the needs of your
60// headers.
61// -root-module (root module name)
62// Specifies a root module to be created in the generated module.map
63// file.
64// -block-check-header-list-only
65// Only warn if #include directives are inside extern or namespace
66// blocks if the included header is in the header list.
John Thompson8eb8d932015-02-19 16:47:27 +000067// -no-coverage-check
68// Don't do the coverage check.
69// -coverage-check-only
70// Only do the coverage check.
John Thompsona2de1082013-03-26 01:17:48 +000071//
John Thompson8eb8d932015-02-19 16:47:27 +000072// Note that because modularize does not use the clang driver,
73// you will likely need to pass in additional compiler front-end
74// arguments to match those passed in by default by the driver.
John Thompson4f8ba652013-03-12 02:07:30 +000075//
John Thompsonfd8ca382013-03-27 19:31:22 +000076// Note that by default, the underlying Clang front end assumes .h files
77// contain C source. If your .h files in the file list contain C++ source,
John Thompsonea6c8db2013-03-27 21:23:21 +000078// you should append the following to your command lines: -x c++
John Thompsonfd8ca382013-03-27 19:31:22 +000079//
John Thompson8eb8d932015-02-19 16:47:27 +000080// Modularization Issue Checks
81//
82// In the process of checking headers for modularization issues, modularize
83// will do normal parsing, reporting normal errors and warnings,
John Thompson4f8ba652013-03-12 02:07:30 +000084// but will also report special error messages like the following:
85//
John Thompson7c6e79f32013-07-29 19:07:00 +000086// error: '(symbol)' defined at multiple locations:
87// (file):(row):(column)
88// (file):(row):(column)
John Thompson4f8ba652013-03-12 02:07:30 +000089//
John Thompsondc118272013-07-29 21:59:41 +000090// error: header '(file)' has different contents depending on how it was
John Thompson7c6e79f32013-07-29 19:07:00 +000091// included
John Thompson4f8ba652013-03-12 02:07:30 +000092//
93// The latter might be followed by messages like the following:
94//
John Thompson7c6e79f32013-07-29 19:07:00 +000095// note: '(symbol)' in (file) at (row):(column) not always provided
John Thompson4f8ba652013-03-12 02:07:30 +000096//
John Thompson7c6e79f32013-07-29 19:07:00 +000097// Checks will also be performed for macro expansions, defined(macro)
98// expressions, and preprocessor conditional directives that evaluate
99// inconsistently, and can produce error messages like the following:
100//
Nico Weber8e20be22013-08-12 11:43:36 +0000101// (...)/SubHeader.h:11:5:
102// #if SYMBOL == 1
103// ^
104// error: Macro instance 'SYMBOL' has different values in this header,
105// depending on how it was included.
106// 'SYMBOL' expanded to: '1' with respect to these inclusion paths:
107// (...)/Header1.h
108// (...)/SubHeader.h
109// (...)/SubHeader.h:3:9:
110// #define SYMBOL 1
111// ^
112// Macro defined here.
113// 'SYMBOL' expanded to: '2' with respect to these inclusion paths:
114// (...)/Header2.h
115// (...)/SubHeader.h
116// (...)/SubHeader.h:7:9:
117// #define SYMBOL 2
118// ^
119// Macro defined here.
120//
John Thompson74083922013-09-18 18:19:43 +0000121// Checks will also be performed for '#include' directives that are
122// nested inside 'extern "C/C++" {}' or 'namespace (name) {}' blocks,
123// and can produce error message like the following:
124//
125// IncludeInExtern.h:2:3
126// #include "Empty.h"
127// ^
128// error: Include directive within extern "C" {}.
129// IncludeInExtern.h:1:1
130// extern "C" {
131// ^
132// The "extern "C" {}" block is here.
133//
John Thompson4fa9c2c2013-08-09 00:19:03 +0000134// See PreprocessorTracker.cpp for additional details.
John Thompsoncc2e2912013-09-03 18:44:11 +0000135//
John Thompson8eb8d932015-02-19 16:47:27 +0000136// Module Map Coverage Check
137//
138// The coverage check uses the Clang ModuleMap class to read and parse the
139// module map file. Starting at the module map file directory, or just the
140// include paths, if specified, it will collect the names of all the files it
141// considers headers (no extension, .h, or .inc--if you need more, modify the
142// isHeader function). It then compares the headers against those referenced
143// in the module map, either explicitly named, or implicitly named via an
144// umbrella directory or umbrella file, as parsed by the ModuleMap object.
145// If headers are found which are not referenced or covered by an umbrella
146// directory or file, warning messages will be produced, and this program
147// will return an error code of 1. Other errors result in an error code of 2.
148// If no problems are found, an error code of 0 is returned.
149//
150// Note that in the case of umbrella headers, this tool invokes the compiler
151// to preprocess the file, and uses a callback to collect the header files
152// included by the umbrella header or any of its nested includes. If any
153// front end options are needed for these compiler invocations, these
154// can be included on the command line after the module map file argument.
155//
156// Warning message have the form:
157//
158// warning: module.modulemap does not account for file: Level3A.h
159//
160// Note that for the case of the module map referencing a file that does
161// not exist, the module map parser in Clang will (at the time of this
162// writing) display an error message.
163//
164// Module Map Assistant - Module Map Generation
165//
John Thompson5d9862f2015-02-10 14:45:30 +0000166// Modularize also has an option ("-module-map-path=module.modulemap") that will
167// skip the checks, and instead act as a module.modulemap generation assistant,
John Thompson5ab4f112013-10-15 13:52:33 +0000168// generating a module map file based on the header list. An optional
169// "-root-module=(rootName)" argument can specify a root module to be
John Thompson5d9862f2015-02-10 14:45:30 +0000170// created in the generated module.modulemap file. Note that you will likely
John Thompson5ab4f112013-10-15 13:52:33 +0000171// need to edit this file to suit the needs of your headers.
172//
John Thompson5d9862f2015-02-10 14:45:30 +0000173// An example command line for generating a module.modulemap file:
John Thompson5ab4f112013-10-15 13:52:33 +0000174//
John Thompson5d9862f2015-02-10 14:45:30 +0000175// modularize -module-map-path=module.modulemap -root-module=myroot \
176// headerlist.txt
John Thompson5ab4f112013-10-15 13:52:33 +0000177//
178// Note that if the headers in the header list have partial paths, sub-modules
179// will be created for the subdirectires involved, assuming that the
180// subdirectories contain headers to be grouped into a module, but still with
181// individual modules for the headers in the subdirectory.
182//
183// See the ModuleAssistant.cpp file comments for additional details about the
184// implementation of the assistant mode.
185//
John Thompson74751802013-09-03 18:48:43 +0000186// Future directions:
187//
188// Basically, we want to add new checks for whatever we can check with respect
189// to checking headers for module'ability.
190//
191// Some ideas:
192//
John Thompson74083922013-09-18 18:19:43 +0000193// 1. Omit duplicate "not always provided" messages
John Thompson53a9d2d2013-09-04 18:29:36 +0000194//
John Thompson74083922013-09-18 18:19:43 +0000195// 2. Add options to disable any of the checks, in case
John Thompson74751802013-09-03 18:48:43 +0000196// there is some problem with them, or the messages get too verbose.
197//
John Thompson74083922013-09-18 18:19:43 +0000198// 3. Try to figure out the preprocessor conditional directives that
John Thompson74751802013-09-03 18:48:43 +0000199// contribute to problems and tie them to the inconsistent definitions.
200//
John Thompson74083922013-09-18 18:19:43 +0000201// 4. There are some legitimate uses of preprocessor macros that
Bob Wilsonf5999bd2013-09-04 16:48:28 +0000202// modularize will flag as errors, such as repeatedly #include'ing
203// a file and using interleaving defined/undefined macros
204// to change declarations in the included file. Is there a way
205// to address this? Maybe have modularize accept a list of macros
206// to ignore. Otherwise you can just exclude the file, after checking
207// for legitimate errors.
208//
John Thompson74083922013-09-18 18:19:43 +0000209// 5. What else?
John Thompsonce601e22013-03-14 01:41:29 +0000210//
211// General clean-up and refactoring:
212//
213// 1. The Location class seems to be something that we might
214// want to design to be applicable to a wider range of tools, and stick it
215// somewhere into Tooling/ in mainline
216//
John Thompson4f8ba652013-03-12 02:07:30 +0000217//===----------------------------------------------------------------------===//
John Thompsonf5db45b2013-03-27 01:02:46 +0000218
Chandler Carruth85e6e872014-01-07 20:05:01 +0000219#include "Modularize.h"
John Thompsond845bae2015-02-13 14:29:22 +0000220#include "ModularizeUtilities.h"
Chandler Carruth85e6e872014-01-07 20:05:01 +0000221#include "PreprocessorTracker.h"
Chandler Carruthf7e45c02014-01-07 22:15:39 +0000222#include "clang/AST/ASTConsumer.h"
John Thompsond977c1e2013-03-27 18:34:38 +0000223#include "clang/AST/ASTContext.h"
224#include "clang/AST/RecursiveASTVisitor.h"
225#include "clang/Basic/SourceManager.h"
John Thompson7d0213c2013-09-04 20:46:24 +0000226#include "clang/Driver/Options.h"
John Thompsond977c1e2013-03-27 18:34:38 +0000227#include "clang/Frontend/CompilerInstance.h"
228#include "clang/Frontend/FrontendActions.h"
229#include "clang/Lex/Preprocessor.h"
230#include "clang/Tooling/CompilationDatabase.h"
231#include "clang/Tooling/Tooling.h"
John Thompson7d0213c2013-09-04 20:46:24 +0000232#include "llvm/Option/Arg.h"
233#include "llvm/Option/ArgList.h"
234#include "llvm/Option/OptTable.h"
235#include "llvm/Option/Option.h"
John Thompsona2de1082013-03-26 01:17:48 +0000236#include "llvm/Support/CommandLine.h"
John Thompson4f8ba652013-03-12 02:07:30 +0000237#include "llvm/Support/FileSystem.h"
John Thompsonf5db45b2013-03-27 01:02:46 +0000238#include "llvm/Support/MemoryBuffer.h"
John Thompsona2de1082013-03-26 01:17:48 +0000239#include "llvm/Support/Path.h"
John Thompson4f8ba652013-03-12 02:07:30 +0000240#include <algorithm>
John Thompsond977c1e2013-03-27 18:34:38 +0000241#include <fstream>
John Thompson4f8ba652013-03-12 02:07:30 +0000242#include <iterator>
John Thompsond977c1e2013-03-27 18:34:38 +0000243#include <string>
244#include <vector>
John Thompson4f8ba652013-03-12 02:07:30 +0000245
Bob Wilsonf5999bd2013-09-04 16:48:28 +0000246using namespace clang;
John Thompson7d0213c2013-09-04 20:46:24 +0000247using namespace clang::driver;
248using namespace clang::driver::options;
249using namespace clang::tooling;
John Thompsona2de1082013-03-26 01:17:48 +0000250using namespace llvm;
John Thompson7d0213c2013-09-04 20:46:24 +0000251using namespace llvm::opt;
John Thompson94faa4d2013-07-26 23:56:42 +0000252using namespace Modularize;
John Thompson4f8ba652013-03-12 02:07:30 +0000253
John Thompsonea6c8db2013-03-27 21:23:21 +0000254// Option to specify a file name for a list of header files to check.
Benjamin Kramere7103712015-03-23 12:49:15 +0000255static cl::list<std::string>
256 ListFileNames(cl::Positional, cl::value_desc("list"),
257 cl::desc("<list of one or more header list files>"),
258 cl::CommaSeparated);
John Thompsonea6c8db2013-03-27 21:23:21 +0000259
260// Collect all other arguments, which will be passed to the front end.
Benjamin Kramere7103712015-03-23 12:49:15 +0000261static cl::list<std::string>
262 CC1Arguments(cl::ConsumeAfter,
263 cl::desc("<arguments to be passed to front end>..."));
John Thompsonea6c8db2013-03-27 21:23:21 +0000264
265// Option to specify a prefix to be prepended to the header names.
Benjamin Kramere7103712015-03-23 12:49:15 +0000266static cl::opt<std::string> HeaderPrefix(
John Thompsonea6c8db2013-03-27 21:23:21 +0000267 "prefix", cl::init(""),
268 cl::desc(
269 "Prepend header file paths with this prefix."
270 " If not specified,"
271 " the files are considered to be relative to the header list file."));
272
John Thompson5ab4f112013-10-15 13:52:33 +0000273// Option for assistant mode, telling modularize to output a module map
274// based on the headers list, and where to put it.
Benjamin Kramere7103712015-03-23 12:49:15 +0000275static cl::opt<std::string> ModuleMapPath(
John Thompson5ab4f112013-10-15 13:52:33 +0000276 "module-map-path", cl::init(""),
277 cl::desc("Turn on module map output and specify output path or file name."
278 " If no path is specified and if prefix option is specified,"
279 " use prefix for file path."));
280
281// Option for assistant mode, telling modularize to output a module map
282// based on the headers list, and where to put it.
Benjamin Kramere7103712015-03-23 12:49:15 +0000283static cl::opt<std::string>
John Thompson5ab4f112013-10-15 13:52:33 +0000284RootModule("root-module", cl::init(""),
285 cl::desc("Specify the name of the root module."));
286
John Thompsonecd3b042015-02-11 16:58:36 +0000287// Option for limiting the #include-inside-extern-or-namespace-block
288// check to only those headers explicitly listed in the header list.
289// This is a work-around for private includes that purposefully get
290// included inside blocks.
291static cl::opt<bool>
292BlockCheckHeaderListOnly("block-check-header-list-only", cl::init(false),
293cl::desc("Only warn if #include directives are inside extern or namespace"
294 " blocks if the included header is in the header list."));
295
John Thompson8eb8d932015-02-19 16:47:27 +0000296// Option for include paths for coverage check.
297static cl::list<std::string>
298IncludePaths("I", cl::desc("Include path for coverage check."),
299cl::ZeroOrMore, cl::value_desc("path"));
300
301// Option for just doing the coverage check.
302static cl::opt<bool>
303NoCoverageCheck("no-coverage-check", cl::init(false),
304cl::desc("Don't do the coverage check."));
305
306// Option for just doing the coverage check.
307static cl::opt<bool>
308CoverageCheckOnly("coverage-check-only", cl::init(false),
309cl::desc("Only do the coverage check."));
310
John Thompson5ab4f112013-10-15 13:52:33 +0000311// Save the program name for error messages.
312const char *Argv0;
313// Save the command line for comments.
314std::string CommandLine;
Bob Wilsonf5999bd2013-09-04 16:48:28 +0000315
John Thompson7d0213c2013-09-04 20:46:24 +0000316// Helper function for finding the input file in an arguments list.
Benjamin Kramere7103712015-03-23 12:49:15 +0000317static std::string findInputFile(const CommandLineArguments &CLArgs) {
Ahmed Charles6a2dc5c2014-03-09 09:24:40 +0000318 std::unique_ptr<OptTable> Opts(createDriverOptTable());
John Thompson7d0213c2013-09-04 20:46:24 +0000319 const unsigned IncludedFlagsBitmask = options::CC1Option;
320 unsigned MissingArgIndex, MissingArgCount;
321 SmallVector<const char *, 256> Argv;
322 for (CommandLineArguments::const_iterator I = CLArgs.begin(),
323 E = CLArgs.end();
324 I != E; ++I)
325 Argv.push_back(I->c_str());
Ahmed Charles6a2dc5c2014-03-09 09:24:40 +0000326 std::unique_ptr<InputArgList> Args(
John Thompson7d0213c2013-09-04 20:46:24 +0000327 Opts->ParseArgs(Argv.data(), Argv.data() + Argv.size(), MissingArgIndex,
328 MissingArgCount, IncludedFlagsBitmask));
329 std::vector<std::string> Inputs = Args->getAllArgValues(OPT_INPUT);
John Thompson3dcb3932015-02-17 20:43:47 +0000330 return ModularizeUtilities::getCanonicalPath(Inputs.back());
John Thompson7d0213c2013-09-04 20:46:24 +0000331}
332
Alexander Kornienkod3657312014-12-03 17:53:03 +0000333// This arguments adjuster inserts "-include (file)" arguments for header
John Thompson7d0213c2013-09-04 20:46:24 +0000334// dependencies.
Benjamin Kramere7103712015-03-23 12:49:15 +0000335static ArgumentsAdjuster
336getAddDependenciesAdjuster(DependencyMap &Dependencies) {
Alexander Kornienkod3657312014-12-03 17:53:03 +0000337 return [&Dependencies](const CommandLineArguments &Args) {
John Thompson7d0213c2013-09-04 20:46:24 +0000338 std::string InputFile = findInputFile(Args);
339 DependentsVector &FileDependents = Dependencies[InputFile];
John Thompson7d0213c2013-09-04 20:46:24 +0000340 CommandLineArguments NewArgs(Args);
Alexander Kornienkod3657312014-12-03 17:53:03 +0000341 if (int Count = FileDependents.size()) {
342 for (int Index = 0; Index < Count; ++Index) {
343 NewArgs.push_back("-include");
344 std::string File(std::string("\"") + FileDependents[Index] +
345 std::string("\""));
346 NewArgs.push_back(FileDependents[Index]);
347 }
John Thompson7d0213c2013-09-04 20:46:24 +0000348 }
349 return NewArgs;
Alexander Kornienkod3657312014-12-03 17:53:03 +0000350 };
351}
John Thompson7d0213c2013-09-04 20:46:24 +0000352
John Thompsonce601e22013-03-14 01:41:29 +0000353// FIXME: The Location class seems to be something that we might
354// want to design to be applicable to a wider range of tools, and stick it
355// somewhere into Tooling/ in mainline
John Thompson4f8ba652013-03-12 02:07:30 +0000356struct Location {
357 const FileEntry *File;
358 unsigned Line, Column;
John Thompsonf5db45b2013-03-27 01:02:46 +0000359
360 Location() : File(), Line(), Column() {}
361
John Thompson4f8ba652013-03-12 02:07:30 +0000362 Location(SourceManager &SM, SourceLocation Loc) : File(), Line(), Column() {
363 Loc = SM.getExpansionLoc(Loc);
364 if (Loc.isInvalid())
365 return;
John Thompsonf5db45b2013-03-27 01:02:46 +0000366
John Thompson4f8ba652013-03-12 02:07:30 +0000367 std::pair<FileID, unsigned> Decomposed = SM.getDecomposedLoc(Loc);
368 File = SM.getFileEntryForID(Decomposed.first);
369 if (!File)
370 return;
John Thompsonf5db45b2013-03-27 01:02:46 +0000371
John Thompson4f8ba652013-03-12 02:07:30 +0000372 Line = SM.getLineNumber(Decomposed.first, Decomposed.second);
373 Column = SM.getColumnNumber(Decomposed.first, Decomposed.second);
374 }
John Thompsonf5db45b2013-03-27 01:02:46 +0000375
Craig Topperf61be9c2014-06-09 02:03:06 +0000376 operator bool() const { return File != nullptr; }
John Thompsonf5db45b2013-03-27 01:02:46 +0000377
John Thompson4f8ba652013-03-12 02:07:30 +0000378 friend bool operator==(const Location &X, const Location &Y) {
379 return X.File == Y.File && X.Line == Y.Line && X.Column == Y.Column;
380 }
381
382 friend bool operator!=(const Location &X, const Location &Y) {
383 return !(X == Y);
384 }
John Thompsonf5db45b2013-03-27 01:02:46 +0000385
John Thompson4f8ba652013-03-12 02:07:30 +0000386 friend bool operator<(const Location &X, const Location &Y) {
387 if (X.File != Y.File)
388 return X.File < Y.File;
389 if (X.Line != Y.Line)
390 return X.Line < Y.Line;
391 return X.Column < Y.Column;
392 }
John Thompsonf5db45b2013-03-27 01:02:46 +0000393 friend bool operator>(const Location &X, const Location &Y) { return Y < X; }
John Thompson4f8ba652013-03-12 02:07:30 +0000394 friend bool operator<=(const Location &X, const Location &Y) {
395 return !(Y < X);
396 }
397 friend bool operator>=(const Location &X, const Location &Y) {
398 return !(X < Y);
399 }
John Thompson4f8ba652013-03-12 02:07:30 +0000400};
401
John Thompson4f8ba652013-03-12 02:07:30 +0000402struct Entry {
John Thompson52d98862013-03-28 18:38:43 +0000403 enum EntryKind {
404 EK_Tag,
405 EK_Value,
406 EK_Macro,
407
408 EK_NumberOfKinds
John Thompson4f8ba652013-03-12 02:07:30 +0000409 } Kind;
John Thompsonf5db45b2013-03-27 01:02:46 +0000410
John Thompson4f8ba652013-03-12 02:07:30 +0000411 Location Loc;
John Thompson4e4d9b32013-03-28 01:20:19 +0000412
413 StringRef getKindName() { return getKindName(Kind); }
John Thompson52d98862013-03-28 18:38:43 +0000414 static StringRef getKindName(EntryKind kind);
John Thompson4f8ba652013-03-12 02:07:30 +0000415};
416
John Thompson4e4d9b32013-03-28 01:20:19 +0000417// Return a string representing the given kind.
John Thompson52d98862013-03-28 18:38:43 +0000418StringRef Entry::getKindName(Entry::EntryKind kind) {
John Thompson4e4d9b32013-03-28 01:20:19 +0000419 switch (kind) {
John Thompson52d98862013-03-28 18:38:43 +0000420 case EK_Tag:
John Thompson4e4d9b32013-03-28 01:20:19 +0000421 return "tag";
John Thompson52d98862013-03-28 18:38:43 +0000422 case EK_Value:
John Thompson4e4d9b32013-03-28 01:20:19 +0000423 return "value";
John Thompson52d98862013-03-28 18:38:43 +0000424 case EK_Macro:
John Thompson4e4d9b32013-03-28 01:20:19 +0000425 return "macro";
John Thompson52d98862013-03-28 18:38:43 +0000426 case EK_NumberOfKinds:
John Thompson4e4d9b32013-03-28 01:20:19 +0000427 break;
John Thompson4e4d9b32013-03-28 01:20:19 +0000428 }
David Blaikiec66c07d2013-03-28 02:30:37 +0000429 llvm_unreachable("invalid Entry kind");
John Thompson4e4d9b32013-03-28 01:20:19 +0000430}
431
John Thompson4f8ba652013-03-12 02:07:30 +0000432struct HeaderEntry {
433 std::string Name;
434 Location Loc;
John Thompsonf5db45b2013-03-27 01:02:46 +0000435
John Thompson4f8ba652013-03-12 02:07:30 +0000436 friend bool operator==(const HeaderEntry &X, const HeaderEntry &Y) {
437 return X.Loc == Y.Loc && X.Name == Y.Name;
438 }
439 friend bool operator!=(const HeaderEntry &X, const HeaderEntry &Y) {
440 return !(X == Y);
441 }
442 friend bool operator<(const HeaderEntry &X, const HeaderEntry &Y) {
443 return X.Loc < Y.Loc || (X.Loc == Y.Loc && X.Name < Y.Name);
444 }
445 friend bool operator>(const HeaderEntry &X, const HeaderEntry &Y) {
446 return Y < X;
447 }
448 friend bool operator<=(const HeaderEntry &X, const HeaderEntry &Y) {
449 return !(Y < X);
450 }
451 friend bool operator>=(const HeaderEntry &X, const HeaderEntry &Y) {
452 return !(X < Y);
453 }
454};
455
456typedef std::vector<HeaderEntry> HeaderContents;
457
John Thompsonf5db45b2013-03-27 01:02:46 +0000458class EntityMap : public StringMap<SmallVector<Entry, 2> > {
John Thompson4f8ba652013-03-12 02:07:30 +0000459public:
John Thompsonf5db45b2013-03-27 01:02:46 +0000460 DenseMap<const FileEntry *, HeaderContents> HeaderContentMismatches;
461
John Thompson52d98862013-03-28 18:38:43 +0000462 void add(const std::string &Name, enum Entry::EntryKind Kind, Location Loc) {
John Thompson4f8ba652013-03-12 02:07:30 +0000463 // Record this entity in its header.
464 HeaderEntry HE = { Name, Loc };
465 CurHeaderContents[Loc.File].push_back(HE);
John Thompsonf5db45b2013-03-27 01:02:46 +0000466
John Thompson4f8ba652013-03-12 02:07:30 +0000467 // Check whether we've seen this entry before.
John Thompsonf5db45b2013-03-27 01:02:46 +0000468 SmallVector<Entry, 2> &Entries = (*this)[Name];
John Thompson4f8ba652013-03-12 02:07:30 +0000469 for (unsigned I = 0, N = Entries.size(); I != N; ++I) {
470 if (Entries[I].Kind == Kind && Entries[I].Loc == Loc)
471 return;
472 }
John Thompsonf5db45b2013-03-27 01:02:46 +0000473
John Thompson4f8ba652013-03-12 02:07:30 +0000474 // We have not seen this entry before; record it.
475 Entry E = { Kind, Loc };
476 Entries.push_back(E);
477 }
John Thompsonf5db45b2013-03-27 01:02:46 +0000478
John Thompson4f8ba652013-03-12 02:07:30 +0000479 void mergeCurHeaderContents() {
John Thompsonf5db45b2013-03-27 01:02:46 +0000480 for (DenseMap<const FileEntry *, HeaderContents>::iterator
481 H = CurHeaderContents.begin(),
482 HEnd = CurHeaderContents.end();
John Thompson4f8ba652013-03-12 02:07:30 +0000483 H != HEnd; ++H) {
484 // Sort contents.
485 std::sort(H->second.begin(), H->second.end());
486
487 // Check whether we've seen this header before.
John Thompsonf5db45b2013-03-27 01:02:46 +0000488 DenseMap<const FileEntry *, HeaderContents>::iterator KnownH =
489 AllHeaderContents.find(H->first);
John Thompson4f8ba652013-03-12 02:07:30 +0000490 if (KnownH == AllHeaderContents.end()) {
491 // We haven't seen this header before; record its contents.
492 AllHeaderContents.insert(*H);
493 continue;
494 }
John Thompsonf5db45b2013-03-27 01:02:46 +0000495
John Thompson4f8ba652013-03-12 02:07:30 +0000496 // If the header contents are the same, we're done.
497 if (H->second == KnownH->second)
498 continue;
John Thompsonf5db45b2013-03-27 01:02:46 +0000499
John Thompson4f8ba652013-03-12 02:07:30 +0000500 // Determine what changed.
John Thompsonf5db45b2013-03-27 01:02:46 +0000501 std::set_symmetric_difference(
502 H->second.begin(), H->second.end(), KnownH->second.begin(),
503 KnownH->second.end(),
504 std::back_inserter(HeaderContentMismatches[H->first]));
John Thompson4f8ba652013-03-12 02:07:30 +0000505 }
John Thompsonf5db45b2013-03-27 01:02:46 +0000506
John Thompson4f8ba652013-03-12 02:07:30 +0000507 CurHeaderContents.clear();
508 }
John Thompson161381e2013-06-27 18:52:23 +0000509
John Thompson1f67ccb2013-03-12 18:51:47 +0000510private:
John Thompsonf5db45b2013-03-27 01:02:46 +0000511 DenseMap<const FileEntry *, HeaderContents> CurHeaderContents;
512 DenseMap<const FileEntry *, HeaderContents> AllHeaderContents;
John Thompson4f8ba652013-03-12 02:07:30 +0000513};
514
John Thompson161381e2013-06-27 18:52:23 +0000515class CollectEntitiesVisitor
516 : public RecursiveASTVisitor<CollectEntitiesVisitor> {
John Thompson4f8ba652013-03-12 02:07:30 +0000517public:
John Thompson74083922013-09-18 18:19:43 +0000518 CollectEntitiesVisitor(SourceManager &SM, EntityMap &Entities,
519 Preprocessor &PP, PreprocessorTracker &PPTracker,
520 int &HadErrors)
521 : SM(SM), Entities(Entities), PP(PP), PPTracker(PPTracker),
522 HadErrors(HadErrors) {}
John Thompsonf5db45b2013-03-27 01:02:46 +0000523
John Thompson4f8ba652013-03-12 02:07:30 +0000524 bool TraverseStmt(Stmt *S) { return true; }
525 bool TraverseType(QualType T) { return true; }
526 bool TraverseTypeLoc(TypeLoc TL) { return true; }
527 bool TraverseNestedNameSpecifier(NestedNameSpecifier *NNS) { return true; }
John Thompsonf5db45b2013-03-27 01:02:46 +0000528 bool TraverseNestedNameSpecifierLoc(NestedNameSpecifierLoc NNS) {
529 return true;
530 }
531 bool TraverseDeclarationNameInfo(DeclarationNameInfo NameInfo) {
532 return true;
533 }
John Thompson4f8ba652013-03-12 02:07:30 +0000534 bool TraverseTemplateName(TemplateName Template) { return true; }
535 bool TraverseTemplateArgument(const TemplateArgument &Arg) { return true; }
John Thompsonf5db45b2013-03-27 01:02:46 +0000536 bool TraverseTemplateArgumentLoc(const TemplateArgumentLoc &ArgLoc) {
537 return true;
538 }
John Thompson4f8ba652013-03-12 02:07:30 +0000539 bool TraverseTemplateArguments(const TemplateArgument *Args,
John Thompsonf5db45b2013-03-27 01:02:46 +0000540 unsigned NumArgs) {
541 return true;
542 }
John Thompson4f8ba652013-03-12 02:07:30 +0000543 bool TraverseConstructorInitializer(CXXCtorInitializer *Init) { return true; }
Benjamin Kramer281f9d02014-05-10 16:32:07 +0000544 bool TraverseLambdaCapture(LambdaCapture C) { return true; }
John Thompsonf5db45b2013-03-27 01:02:46 +0000545
John Thompson74083922013-09-18 18:19:43 +0000546 // Check 'extern "*" {}' block for #include directives.
547 bool VisitLinkageSpecDecl(LinkageSpecDecl *D) {
548 // Bail if not a block.
549 if (!D->hasBraces())
550 return true;
551 SourceRange BlockRange = D->getSourceRange();
552 const char *LinkageLabel;
553 switch (D->getLanguage()) {
554 case LinkageSpecDecl::lang_c:
555 LinkageLabel = "extern \"C\" {}";
556 break;
557 case LinkageSpecDecl::lang_cxx:
558 LinkageLabel = "extern \"C++\" {}";
559 break;
John Thompson74083922013-09-18 18:19:43 +0000560 }
561 if (!PPTracker.checkForIncludesInBlock(PP, BlockRange, LinkageLabel,
562 errs()))
563 HadErrors = 1;
564 return true;
565 }
566
567 // Check 'namespace (name) {}' block for #include directives.
568 bool VisitNamespaceDecl(const NamespaceDecl *D) {
569 SourceRange BlockRange = D->getSourceRange();
570 std::string Label("namespace ");
571 Label += D->getName();
572 Label += " {}";
573 if (!PPTracker.checkForIncludesInBlock(PP, BlockRange, Label.c_str(),
574 errs()))
575 HadErrors = 1;
576 return true;
577 }
578
579 // Collect definition entities.
John Thompson4f8ba652013-03-12 02:07:30 +0000580 bool VisitNamedDecl(NamedDecl *ND) {
581 // We only care about file-context variables.
582 if (!ND->getDeclContext()->isFileContext())
583 return true;
John Thompsonf5db45b2013-03-27 01:02:46 +0000584
John Thompson4f8ba652013-03-12 02:07:30 +0000585 // Skip declarations that tend to be properly multiply-declared.
586 if (isa<NamespaceDecl>(ND) || isa<UsingDirectiveDecl>(ND) ||
John Thompsonf5db45b2013-03-27 01:02:46 +0000587 isa<NamespaceAliasDecl>(ND) ||
588 isa<ClassTemplateSpecializationDecl>(ND) || isa<UsingDecl>(ND) ||
John Thompson8e01c062013-08-26 15:17:23 +0000589 isa<ClassTemplateDecl>(ND) || isa<TemplateTypeParmDecl>(ND) ||
John Thompsoncc2e2912013-09-03 18:44:11 +0000590 isa<TypeAliasTemplateDecl>(ND) || isa<UsingShadowDecl>(ND) ||
591 isa<FunctionDecl>(ND) || isa<FunctionTemplateDecl>(ND) ||
John Thompson4f8ba652013-03-12 02:07:30 +0000592 (isa<TagDecl>(ND) &&
593 !cast<TagDecl>(ND)->isThisDeclarationADefinition()))
594 return true;
John Thompsonf5db45b2013-03-27 01:02:46 +0000595
John Thompson8e01c062013-08-26 15:17:23 +0000596 // Skip anonymous declarations.
597 if (!ND->getDeclName())
598 return true;
599
600 // Get the qualified name.
John Thompsoncc2e2912013-09-03 18:44:11 +0000601 std::string Name;
602 llvm::raw_string_ostream OS(Name);
603 ND->printQualifiedName(OS);
604 OS.flush();
John Thompson4f8ba652013-03-12 02:07:30 +0000605 if (Name.empty())
606 return true;
John Thompsonf5db45b2013-03-27 01:02:46 +0000607
John Thompson4f8ba652013-03-12 02:07:30 +0000608 Location Loc(SM, ND->getLocation());
609 if (!Loc)
610 return true;
John Thompsonf5db45b2013-03-27 01:02:46 +0000611
John Thompson52d98862013-03-28 18:38:43 +0000612 Entities.add(Name, isa<TagDecl>(ND) ? Entry::EK_Tag : Entry::EK_Value, Loc);
John Thompson4f8ba652013-03-12 02:07:30 +0000613 return true;
614 }
John Thompson161381e2013-06-27 18:52:23 +0000615
John Thompson1f67ccb2013-03-12 18:51:47 +0000616private:
617 SourceManager &SM;
618 EntityMap &Entities;
John Thompson74083922013-09-18 18:19:43 +0000619 Preprocessor &PP;
620 PreprocessorTracker &PPTracker;
621 int &HadErrors;
John Thompson4f8ba652013-03-12 02:07:30 +0000622};
623
624class CollectEntitiesConsumer : public ASTConsumer {
John Thompson4f8ba652013-03-12 02:07:30 +0000625public:
John Thompson94faa4d2013-07-26 23:56:42 +0000626 CollectEntitiesConsumer(EntityMap &Entities,
627 PreprocessorTracker &preprocessorTracker,
John Thompson74083922013-09-18 18:19:43 +0000628 Preprocessor &PP, StringRef InFile, int &HadErrors)
629 : Entities(Entities), PPTracker(preprocessorTracker), PP(PP),
630 HadErrors(HadErrors) {
John Thompson94faa4d2013-07-26 23:56:42 +0000631 PPTracker.handlePreprocessorEntry(PP, InFile);
632 }
633
634 ~CollectEntitiesConsumer() { PPTracker.handlePreprocessorExit(); }
John Thompsonf5db45b2013-03-27 01:02:46 +0000635
John Thompson4f8ba652013-03-12 02:07:30 +0000636 virtual void HandleTranslationUnit(ASTContext &Ctx) {
637 SourceManager &SM = Ctx.getSourceManager();
John Thompsonf5db45b2013-03-27 01:02:46 +0000638
John Thompson4f8ba652013-03-12 02:07:30 +0000639 // Collect declared entities.
John Thompson74083922013-09-18 18:19:43 +0000640 CollectEntitiesVisitor(SM, Entities, PP, PPTracker, HadErrors)
John Thompsonf5db45b2013-03-27 01:02:46 +0000641 .TraverseDecl(Ctx.getTranslationUnitDecl());
642
John Thompson4f8ba652013-03-12 02:07:30 +0000643 // Collect macro definitions.
644 for (Preprocessor::macro_iterator M = PP.macro_begin(),
John Thompsonf5db45b2013-03-27 01:02:46 +0000645 MEnd = PP.macro_end();
John Thompson4f8ba652013-03-12 02:07:30 +0000646 M != MEnd; ++M) {
647 Location Loc(SM, M->second->getLocation());
648 if (!Loc)
649 continue;
650
John Thompson52d98862013-03-28 18:38:43 +0000651 Entities.add(M->first->getName().str(), Entry::EK_Macro, Loc);
John Thompson4f8ba652013-03-12 02:07:30 +0000652 }
John Thompsonf5db45b2013-03-27 01:02:46 +0000653
John Thompson4f8ba652013-03-12 02:07:30 +0000654 // Merge header contents.
655 Entities.mergeCurHeaderContents();
656 }
John Thompson161381e2013-06-27 18:52:23 +0000657
John Thompson1f67ccb2013-03-12 18:51:47 +0000658private:
659 EntityMap &Entities;
John Thompson94faa4d2013-07-26 23:56:42 +0000660 PreprocessorTracker &PPTracker;
John Thompson1f67ccb2013-03-12 18:51:47 +0000661 Preprocessor &PP;
John Thompson74083922013-09-18 18:19:43 +0000662 int &HadErrors;
John Thompson4f8ba652013-03-12 02:07:30 +0000663};
664
665class CollectEntitiesAction : public SyntaxOnlyAction {
John Thompson1f67ccb2013-03-12 18:51:47 +0000666public:
John Thompson94faa4d2013-07-26 23:56:42 +0000667 CollectEntitiesAction(EntityMap &Entities,
John Thompson74083922013-09-18 18:19:43 +0000668 PreprocessorTracker &preprocessorTracker,
669 int &HadErrors)
670 : Entities(Entities), PPTracker(preprocessorTracker),
671 HadErrors(HadErrors) {}
John Thompson161381e2013-06-27 18:52:23 +0000672
John Thompson4f8ba652013-03-12 02:07:30 +0000673protected:
David Blaikie680c4c82014-08-10 19:56:59 +0000674 std::unique_ptr<clang::ASTConsumer>
675 CreateASTConsumer(CompilerInstance &CI, StringRef InFile) override {
676 return llvm::make_unique<CollectEntitiesConsumer>(
677 Entities, PPTracker, CI.getPreprocessor(), InFile, HadErrors);
John Thompson4f8ba652013-03-12 02:07:30 +0000678 }
John Thompson161381e2013-06-27 18:52:23 +0000679
John Thompson1f67ccb2013-03-12 18:51:47 +0000680private:
John Thompsonf5db45b2013-03-27 01:02:46 +0000681 EntityMap &Entities;
John Thompson94faa4d2013-07-26 23:56:42 +0000682 PreprocessorTracker &PPTracker;
John Thompson74083922013-09-18 18:19:43 +0000683 int &HadErrors;
John Thompson4f8ba652013-03-12 02:07:30 +0000684};
685
686class ModularizeFrontendActionFactory : public FrontendActionFactory {
John Thompson4f8ba652013-03-12 02:07:30 +0000687public:
John Thompson94faa4d2013-07-26 23:56:42 +0000688 ModularizeFrontendActionFactory(EntityMap &Entities,
John Thompson74083922013-09-18 18:19:43 +0000689 PreprocessorTracker &preprocessorTracker,
690 int &HadErrors)
691 : Entities(Entities), PPTracker(preprocessorTracker),
692 HadErrors(HadErrors) {}
John Thompson4f8ba652013-03-12 02:07:30 +0000693
694 virtual CollectEntitiesAction *create() {
John Thompson74083922013-09-18 18:19:43 +0000695 return new CollectEntitiesAction(Entities, PPTracker, HadErrors);
John Thompson4f8ba652013-03-12 02:07:30 +0000696 }
John Thompson161381e2013-06-27 18:52:23 +0000697
John Thompson1f67ccb2013-03-12 18:51:47 +0000698private:
John Thompsonf5db45b2013-03-27 01:02:46 +0000699 EntityMap &Entities;
John Thompson94faa4d2013-07-26 23:56:42 +0000700 PreprocessorTracker &PPTracker;
John Thompson74083922013-09-18 18:19:43 +0000701 int &HadErrors;
John Thompson4f8ba652013-03-12 02:07:30 +0000702};
703
John Thompsonbb0a3b02013-08-09 13:52:09 +0000704int main(int Argc, const char **Argv) {
John Thompsona2de1082013-03-26 01:17:48 +0000705
John Thompson5ab4f112013-10-15 13:52:33 +0000706 // Save program name for error messages.
707 Argv0 = Argv[0];
708
John Thompson5d9862f2015-02-10 14:45:30 +0000709 // Save program arguments for use in module.modulemap comment.
John Thompson5ab4f112013-10-15 13:52:33 +0000710 CommandLine = sys::path::stem(sys::path::filename(Argv0));
711 for (int ArgIndex = 1; ArgIndex < Argc; ArgIndex++) {
712 CommandLine.append(" ");
713 CommandLine.append(Argv[ArgIndex]);
714 }
715
John Thompsona2de1082013-03-26 01:17:48 +0000716 // This causes options to be parsed.
John Thompsonbb0a3b02013-08-09 13:52:09 +0000717 cl::ParseCommandLineOptions(Argc, Argv, "modularize.\n");
John Thompsona2de1082013-03-26 01:17:48 +0000718
719 // No go if we have no header list file.
John Thompson469bbc02015-02-12 16:22:09 +0000720 if (ListFileNames.size() == 0) {
John Thompsona2de1082013-03-26 01:17:48 +0000721 cl::PrintHelpMessage();
John Thompsonea6c8db2013-03-27 21:23:21 +0000722 return 1;
John Thompson4f8ba652013-03-12 02:07:30 +0000723 }
John Thompsona2de1082013-03-26 01:17:48 +0000724
John Thompsond845bae2015-02-13 14:29:22 +0000725 std::unique_ptr<ModularizeUtilities> ModUtil;
John Thompson8eb8d932015-02-19 16:47:27 +0000726 int HadErrors = 0;
727
John Thompsond845bae2015-02-13 14:29:22 +0000728 ModUtil.reset(
729 ModularizeUtilities::createModularizeUtilities(
730 ListFileNames, HeaderPrefix));
731
John Thompson7d0213c2013-09-04 20:46:24 +0000732 // Get header file names and dependencies.
John Thompsond845bae2015-02-13 14:29:22 +0000733 ModUtil->loadAllHeaderListsAndDependencies();
734
John Thompsona2de1082013-03-26 01:17:48 +0000735
John Thompson5ab4f112013-10-15 13:52:33 +0000736 // If we are in assistant mode, output the module map and quit.
John Thompsone744d2b2013-12-10 02:26:44 +0000737 if (ModuleMapPath.length() != 0) {
John Thompsond845bae2015-02-13 14:29:22 +0000738 if (!createModuleMap(ModuleMapPath, ModUtil->HeaderFileNames,
739 ModUtil->Dependencies, HeaderPrefix, RootModule))
John Thompson5ab4f112013-10-15 13:52:33 +0000740 return 1; // Failed.
741 return 0; // Success - Skip checks in assistant mode.
742 }
743
John Thompson8eb8d932015-02-19 16:47:27 +0000744 // If we're doing module maps.
745 if (!NoCoverageCheck && ModUtil->HasModuleMap) {
746 // Do coverage check.
747 if (ModUtil->doCoverageCheck(IncludePaths, CommandLine))
748 HadErrors = 1;
749 }
750
751 // Bail early if only doing the coverage check.
752 if (CoverageCheckOnly)
753 return HadErrors;
754
John Thompson4f8ba652013-03-12 02:07:30 +0000755 // Create the compilation database.
John Thompsona2de1082013-03-26 01:17:48 +0000756 SmallString<256> PathBuf;
John Thompsonf5db45b2013-03-27 01:02:46 +0000757 sys::fs::current_path(PathBuf);
Ahmed Charles6a2dc5c2014-03-09 09:24:40 +0000758 std::unique_ptr<CompilationDatabase> Compilations;
John Thompsonf5db45b2013-03-27 01:02:46 +0000759 Compilations.reset(
760 new FixedCompilationDatabase(Twine(PathBuf), CC1Arguments));
John Thompsona2de1082013-03-26 01:17:48 +0000761
John Thompson94faa4d2013-07-26 23:56:42 +0000762 // Create preprocessor tracker, to watch for macro and conditional problems.
John Thompsonecd3b042015-02-11 16:58:36 +0000763 std::unique_ptr<PreprocessorTracker> PPTracker(
John Thompsond845bae2015-02-13 14:29:22 +0000764 PreprocessorTracker::create(ModUtil->HeaderFileNames,
765 BlockCheckHeaderListOnly));
John Thompson94faa4d2013-07-26 23:56:42 +0000766
John Thompson4f8ba652013-03-12 02:07:30 +0000767 // Parse all of the headers, detecting duplicates.
768 EntityMap Entities;
John Thompsond845bae2015-02-13 14:29:22 +0000769 ClangTool Tool(*Compilations, ModUtil->HeaderFileNames);
770 Tool.appendArgumentsAdjuster(getAddDependenciesAdjuster(ModUtil->Dependencies));
Benjamin Kramer6e914242014-07-24 10:23:33 +0000771 ModularizeFrontendActionFactory Factory(Entities, *PPTracker, HadErrors);
772 HadErrors |= Tool.run(&Factory);
John Thompsonce601e22013-03-14 01:41:29 +0000773
John Thompson4e4d9b32013-03-28 01:20:19 +0000774 // Create a place to save duplicate entity locations, separate bins per kind.
775 typedef SmallVector<Location, 8> LocationArray;
John Thompson52d98862013-03-28 18:38:43 +0000776 typedef SmallVector<LocationArray, Entry::EK_NumberOfKinds> EntryBinArray;
John Thompson4e4d9b32013-03-28 01:20:19 +0000777 EntryBinArray EntryBins;
John Thompsonbb0a3b02013-08-09 13:52:09 +0000778 int KindIndex;
779 for (KindIndex = 0; KindIndex < Entry::EK_NumberOfKinds; ++KindIndex) {
780 LocationArray Array;
781 EntryBins.push_back(Array);
Michael Gottesman4b249212013-03-28 06:07:15 +0000782 }
John Thompson4e4d9b32013-03-28 01:20:19 +0000783
John Thompson4f8ba652013-03-12 02:07:30 +0000784 // Check for the same entity being defined in multiple places.
785 for (EntityMap::iterator E = Entities.begin(), EEnd = Entities.end();
786 E != EEnd; ++E) {
Alp Toker9a5134e2013-12-01 05:08:12 +0000787 // If only one occurrence, exit early.
John Thompson4e4d9b32013-03-28 01:20:19 +0000788 if (E->second.size() == 1)
789 continue;
790 // Clear entity locations.
791 for (EntryBinArray::iterator CI = EntryBins.begin(), CE = EntryBins.end();
792 CI != CE; ++CI) {
John Thompson52d98862013-03-28 18:38:43 +0000793 CI->clear();
John Thompson4e4d9b32013-03-28 01:20:19 +0000794 }
795 // Walk the entities of a single name, collecting the locations,
796 // separated into separate bins.
John Thompson4f8ba652013-03-12 02:07:30 +0000797 for (unsigned I = 0, N = E->second.size(); I != N; ++I) {
John Thompson52d98862013-03-28 18:38:43 +0000798 EntryBins[E->second[I].Kind].push_back(E->second[I].Loc);
John Thompson4e4d9b32013-03-28 01:20:19 +0000799 }
800 // Report any duplicate entity definition errors.
John Thompsonbb0a3b02013-08-09 13:52:09 +0000801 int KindIndex = 0;
John Thompson4e4d9b32013-03-28 01:20:19 +0000802 for (EntryBinArray::iterator DI = EntryBins.begin(), DE = EntryBins.end();
John Thompsonbb0a3b02013-08-09 13:52:09 +0000803 DI != DE; ++DI, ++KindIndex) {
804 int ECount = DI->size();
John Thompson8eb8d932015-02-19 16:47:27 +0000805 // If only 1 occurrence of this entity, skip it, we only report duplicates.
John Thompsonbb0a3b02013-08-09 13:52:09 +0000806 if (ECount <= 1)
John Thompson4f8ba652013-03-12 02:07:30 +0000807 continue;
John Thompson52d98862013-03-28 18:38:43 +0000808 LocationArray::iterator FI = DI->begin();
John Thompsonbb0a3b02013-08-09 13:52:09 +0000809 StringRef kindName = Entry::getKindName((Entry::EntryKind)KindIndex);
John Thompson4e4d9b32013-03-28 01:20:19 +0000810 errs() << "error: " << kindName << " '" << E->first()
811 << "' defined at multiple locations:\n";
John Thompson52d98862013-03-28 18:38:43 +0000812 for (LocationArray::iterator FE = DI->end(); FI != FE; ++FI) {
John Thompson4e4d9b32013-03-28 01:20:19 +0000813 errs() << " " << FI->File->getName() << ":" << FI->Line << ":"
814 << FI->Column << "\n";
John Thompson4f8ba652013-03-12 02:07:30 +0000815 }
John Thompson4f8ba652013-03-12 02:07:30 +0000816 HadErrors = 1;
817 }
818 }
John Thompsonf5db45b2013-03-27 01:02:46 +0000819
John Thompson94faa4d2013-07-26 23:56:42 +0000820 // Complain about macro instance in header files that differ based on how
821 // they are included.
822 if (PPTracker->reportInconsistentMacros(errs()))
823 HadErrors = 1;
824
825 // Complain about preprocessor conditional directives in header files that
826 // differ based on how they are included.
827 if (PPTracker->reportInconsistentConditionals(errs()))
828 HadErrors = 1;
829
John Thompson4f8ba652013-03-12 02:07:30 +0000830 // Complain about any headers that have contents that differ based on how
831 // they are included.
John Thompsonce601e22013-03-14 01:41:29 +0000832 // FIXME: Could we provide information about which preprocessor conditionals
833 // are involved?
John Thompsonf5db45b2013-03-27 01:02:46 +0000834 for (DenseMap<const FileEntry *, HeaderContents>::iterator
835 H = Entities.HeaderContentMismatches.begin(),
836 HEnd = Entities.HeaderContentMismatches.end();
John Thompson4f8ba652013-03-12 02:07:30 +0000837 H != HEnd; ++H) {
838 if (H->second.empty()) {
John Thompsonf5db45b2013-03-27 01:02:46 +0000839 errs() << "internal error: phantom header content mismatch\n";
John Thompson4f8ba652013-03-12 02:07:30 +0000840 continue;
841 }
John Thompsonf5db45b2013-03-27 01:02:46 +0000842
John Thompson4f8ba652013-03-12 02:07:30 +0000843 HadErrors = 1;
John Thompsonf5db45b2013-03-27 01:02:46 +0000844 errs() << "error: header '" << H->first->getName()
John Thompson94faa4d2013-07-26 23:56:42 +0000845 << "' has different contents depending on how it was included.\n";
John Thompson4f8ba652013-03-12 02:07:30 +0000846 for (unsigned I = 0, N = H->second.size(); I != N; ++I) {
John Thompson161381e2013-06-27 18:52:23 +0000847 errs() << "note: '" << H->second[I].Name << "' in "
848 << H->second[I].Loc.File->getName() << " at "
849 << H->second[I].Loc.Line << ":" << H->second[I].Loc.Column
850 << " not always provided\n";
John Thompson4f8ba652013-03-12 02:07:30 +0000851 }
852 }
John Thompsonf5db45b2013-03-27 01:02:46 +0000853
John Thompson4f8ba652013-03-12 02:07:30 +0000854 return HadErrors;
855}