blob: 4a8540ae582036707f6bd478d9fccf05eb57e6f7 [file] [log] [blame]
Ted Kremenek918fe842010-03-20 21:06:02 +00001//=- AnalysisBasedWarnings.cpp - Sema warnings based on libAnalysis -*- C++ -*-=//
2//
3// The LLVM Compiler Infrastructure
4//
5// This file is distributed under the University of Illinois Open Source
6// License. See LICENSE.TXT for details.
7//
8//===----------------------------------------------------------------------===//
9//
10// This file defines analysis_warnings::[Policy,Executor].
11// Together they are used by Sema to issue warnings based on inexpensive
12// static analysis algorithms in libAnalysis.
13//
14//===----------------------------------------------------------------------===//
15
Douglas Gregorc3a6ade2010-08-12 20:07:10 +000016#include "clang/Sema/AnalysisBasedWarnings.h"
John McCall28a0cf72010-08-25 07:42:41 +000017#include "clang/AST/DeclCXX.h"
Chandler Carruth3a022472012-12-04 09:13:33 +000018#include "clang/AST/DeclObjC.h"
Ted Kremenekb8d8c4e2011-04-04 20:56:00 +000019#include "clang/AST/EvaluatedExprVisitor.h"
Chandler Carruth3a022472012-12-04 09:13:33 +000020#include "clang/AST/ExprCXX.h"
21#include "clang/AST/ExprObjC.h"
Jordan Rose76831c62012-10-11 16:10:19 +000022#include "clang/AST/ParentMap.h"
Richard Smith84837d52012-05-03 18:27:39 +000023#include "clang/AST/RecursiveASTVisitor.h"
Chandler Carruth3a022472012-12-04 09:13:33 +000024#include "clang/AST/StmtCXX.h"
25#include "clang/AST/StmtObjC.h"
26#include "clang/AST/StmtVisitor.h"
27#include "clang/Analysis/Analyses/CFGReachabilityAnalysis.h"
DeLesley Hutchins48a31762013-08-12 21:20:55 +000028#include "clang/Analysis/Analyses/Consumed.h"
Chandler Carruth3a022472012-12-04 09:13:33 +000029#include "clang/Analysis/Analyses/ReachableCode.h"
30#include "clang/Analysis/Analyses/ThreadSafety.h"
31#include "clang/Analysis/Analyses/UninitializedValues.h"
George Karpenkov50657f62017-09-06 21:45:03 +000032#include "clang/Analysis/AnalysisDeclContext.h"
Ted Kremenek918fe842010-03-20 21:06:02 +000033#include "clang/Analysis/CFG.h"
Ted Kremenek3427fac2011-02-23 01:52:04 +000034#include "clang/Analysis/CFGStmtMap.h"
Chandler Carruth3a022472012-12-04 09:13:33 +000035#include "clang/Basic/SourceLocation.h"
36#include "clang/Basic/SourceManager.h"
Chandler Carruth3a022472012-12-04 09:13:33 +000037#include "clang/Lex/Preprocessor.h"
38#include "clang/Sema/ScopeInfo.h"
39#include "clang/Sema/SemaInternal.h"
Ted Kremenek918fe842010-03-20 21:06:02 +000040#include "llvm/ADT/BitVector.h"
Enea Zaffanella2f40be72013-02-15 20:09:55 +000041#include "llvm/ADT/MapVector.h"
Dmitri Gribenko6743e042012-09-29 11:40:46 +000042#include "llvm/ADT/SmallString.h"
Caitlin Sadowskiafbbd8e2011-08-23 18:46:34 +000043#include "llvm/ADT/SmallVector.h"
Caitlin Sadowski0b3501c2011-09-09 16:04:02 +000044#include "llvm/ADT/StringRef.h"
Ted Kremenek918fe842010-03-20 21:06:02 +000045#include "llvm/Support/Casting.h"
Caitlin Sadowskiafbbd8e2011-08-23 18:46:34 +000046#include <algorithm>
Chandler Carruth3a022472012-12-04 09:13:33 +000047#include <deque>
Richard Smith84837d52012-05-03 18:27:39 +000048#include <iterator>
Ted Kremenek918fe842010-03-20 21:06:02 +000049
50using namespace clang;
51
52//===----------------------------------------------------------------------===//
53// Unreachable code analysis.
54//===----------------------------------------------------------------------===//
55
56namespace {
57 class UnreachableCodeHandler : public reachable_code::Callback {
58 Sema &S;
Alex Lorenz569ad732017-01-12 10:48:03 +000059 SourceRange PreviousSilenceableCondVal;
60
Ted Kremenek918fe842010-03-20 21:06:02 +000061 public:
62 UnreachableCodeHandler(Sema &s) : S(s) {}
63
Ted Kremenek1a8641c2014-03-15 01:26:32 +000064 void HandleUnreachable(reachable_code::UnreachableKind UK,
Ted Kremenekec3bbf42014-03-29 00:35:20 +000065 SourceLocation L,
66 SourceRange SilenceableCondVal,
67 SourceRange R1,
Craig Toppere14c0f82014-03-12 04:55:44 +000068 SourceRange R2) override {
Alex Lorenz569ad732017-01-12 10:48:03 +000069 // Avoid reporting multiple unreachable code diagnostics that are
70 // triggered by the same conditional value.
71 if (PreviousSilenceableCondVal.isValid() &&
72 SilenceableCondVal.isValid() &&
73 PreviousSilenceableCondVal == SilenceableCondVal)
74 return;
75 PreviousSilenceableCondVal = SilenceableCondVal;
76
Ted Kremenek1a8641c2014-03-15 01:26:32 +000077 unsigned diag = diag::warn_unreachable;
78 switch (UK) {
79 case reachable_code::UK_Break:
80 diag = diag::warn_unreachable_break;
81 break;
Ted Kremenekf3c93bb2014-03-20 06:07:30 +000082 case reachable_code::UK_Return:
Ted Kremenekad8753c2014-03-15 05:47:06 +000083 diag = diag::warn_unreachable_return;
Ted Kremenek1a8641c2014-03-15 01:26:32 +000084 break;
Ted Kremenek14210372014-03-21 06:02:36 +000085 case reachable_code::UK_Loop_Increment:
86 diag = diag::warn_unreachable_loop_increment;
87 break;
Ted Kremenek1a8641c2014-03-15 01:26:32 +000088 case reachable_code::UK_Other:
89 break;
90 }
91
92 S.Diag(L, diag) << R1 << R2;
Ted Kremenekec3bbf42014-03-29 00:35:20 +000093
94 SourceLocation Open = SilenceableCondVal.getBegin();
95 if (Open.isValid()) {
Alp Tokerb6cc5922014-05-03 03:45:55 +000096 SourceLocation Close = SilenceableCondVal.getEnd();
97 Close = S.getLocForEndOfToken(Close);
Ted Kremenekec3bbf42014-03-29 00:35:20 +000098 if (Close.isValid()) {
99 S.Diag(Open, diag::note_unreachable_silence)
100 << FixItHint::CreateInsertion(Open, "/* DISABLES CODE */ (")
101 << FixItHint::CreateInsertion(Close, ")");
102 }
103 }
Ted Kremenek918fe842010-03-20 21:06:02 +0000104 }
105 };
Hans Wennborgdcfba332015-10-06 23:40:43 +0000106} // anonymous namespace
Ted Kremenek918fe842010-03-20 21:06:02 +0000107
108/// CheckUnreachable - Check for unreachable code.
Ted Kremenek81ce1c82011-10-24 01:32:45 +0000109static void CheckUnreachable(Sema &S, AnalysisDeclContext &AC) {
Ted Kremenekc1b28752014-02-25 22:35:37 +0000110 // As a heuristic prune all diagnostics not in the main file. Currently
111 // the majority of warnings in headers are false positives. These
112 // are largely caused by configuration state, e.g. preprocessor
113 // defined code, etc.
114 //
115 // Note that this is also a performance optimization. Analyzing
116 // headers many times can be expensive.
117 if (!S.getSourceManager().isInMainFile(AC.getDecl()->getLocStart()))
118 return;
119
Ted Kremenek918fe842010-03-20 21:06:02 +0000120 UnreachableCodeHandler UC(S);
Ted Kremenek2dd810a2014-03-09 08:13:49 +0000121 reachable_code::FindUnreachableCode(AC, S.getPreprocessor(), UC);
Ted Kremenek918fe842010-03-20 21:06:02 +0000122}
123
Benjamin Kramer3a002252015-02-16 16:53:12 +0000124namespace {
Richard Trieuf935b562014-04-05 05:17:01 +0000125/// \brief Warn on logical operator errors in CFGBuilder
126class LogicalErrorHandler : public CFGCallback {
127 Sema &S;
128
129public:
130 LogicalErrorHandler(Sema &S) : CFGCallback(), S(S) {}
131
132 static bool HasMacroID(const Expr *E) {
133 if (E->getExprLoc().isMacroID())
134 return true;
135
136 // Recurse to children.
Benjamin Kramer642f1732015-07-02 21:03:14 +0000137 for (const Stmt *SubStmt : E->children())
138 if (const Expr *SubExpr = dyn_cast_or_null<Expr>(SubStmt))
139 if (HasMacroID(SubExpr))
140 return true;
Richard Trieuf935b562014-04-05 05:17:01 +0000141
142 return false;
143 }
144
Alexander Kornienko34eb2072015-04-11 02:00:23 +0000145 void compareAlwaysTrue(const BinaryOperator *B, bool isAlwaysTrue) override {
Richard Trieuf935b562014-04-05 05:17:01 +0000146 if (HasMacroID(B))
147 return;
148
149 SourceRange DiagRange = B->getSourceRange();
150 S.Diag(B->getExprLoc(), diag::warn_tautological_overlap_comparison)
151 << DiagRange << isAlwaysTrue;
152 }
Jordan Rose7afd71e2014-05-20 17:31:11 +0000153
Alexander Kornienko34eb2072015-04-11 02:00:23 +0000154 void compareBitwiseEquality(const BinaryOperator *B,
155 bool isAlwaysTrue) override {
Jordan Rose7afd71e2014-05-20 17:31:11 +0000156 if (HasMacroID(B))
157 return;
158
159 SourceRange DiagRange = B->getSourceRange();
160 S.Diag(B->getExprLoc(), diag::warn_comparison_bitwise_always)
161 << DiagRange << isAlwaysTrue;
162 }
Richard Trieuf935b562014-04-05 05:17:01 +0000163};
Hans Wennborgdcfba332015-10-06 23:40:43 +0000164} // anonymous namespace
Richard Trieuf935b562014-04-05 05:17:01 +0000165
Ted Kremenek918fe842010-03-20 21:06:02 +0000166//===----------------------------------------------------------------------===//
Richard Trieu2f024f42013-12-21 02:33:43 +0000167// Check for infinite self-recursion in functions
168//===----------------------------------------------------------------------===//
169
Richard Trieu6995de92015-08-21 03:43:09 +0000170// Returns true if the function is called anywhere within the CFGBlock.
171// For member functions, the additional condition of being call from the
172// this pointer is required.
Duncan P. N. Exon Smithf0eafc72015-07-23 20:11:47 +0000173static bool hasRecursiveCallInPath(const FunctionDecl *FD, CFGBlock &Block) {
Richard Trieu6995de92015-08-21 03:43:09 +0000174 // Process all the Stmt's in this block to find any calls to FD.
Duncan P. N. Exon Smithf0eafc72015-07-23 20:11:47 +0000175 for (const auto &B : Block) {
176 if (B.getKind() != CFGElement::Statement)
177 continue;
178
179 const CallExpr *CE = dyn_cast<CallExpr>(B.getAs<CFGStmt>()->getStmt());
180 if (!CE || !CE->getCalleeDecl() ||
181 CE->getCalleeDecl()->getCanonicalDecl() != FD)
182 continue;
183
184 // Skip function calls which are qualified with a templated class.
185 if (const DeclRefExpr *DRE =
186 dyn_cast<DeclRefExpr>(CE->getCallee()->IgnoreParenImpCasts())) {
187 if (NestedNameSpecifier *NNS = DRE->getQualifier()) {
188 if (NNS->getKind() == NestedNameSpecifier::TypeSpec &&
189 isa<TemplateSpecializationType>(NNS->getAsType())) {
190 continue;
191 }
192 }
193 }
194
195 const CXXMemberCallExpr *MCE = dyn_cast<CXXMemberCallExpr>(CE);
196 if (!MCE || isa<CXXThisExpr>(MCE->getImplicitObjectArgument()) ||
197 !MCE->getMethodDecl()->isVirtual())
198 return true;
199 }
200 return false;
201}
202
Robert Widmann97608442018-03-22 03:16:23 +0000203// Returns true if every path from the entry block passes through a call to FD.
Richard Trieu6995de92015-08-21 03:43:09 +0000204static bool checkForRecursiveFunctionCall(const FunctionDecl *FD, CFG *cfg) {
Robert Widmann97608442018-03-22 03:16:23 +0000205 llvm::SmallPtrSet<CFGBlock *, 16> Visited;
206 llvm::SmallVector<CFGBlock *, 16> WorkList;
207 // Keep track of whether we found at least one recursive path.
208 bool foundRecursion = false;
Richard Trieu6995de92015-08-21 03:43:09 +0000209
210 const unsigned ExitID = cfg->getExit().getBlockID();
211
Robert Widmann97608442018-03-22 03:16:23 +0000212 // Seed the work list with the entry block.
213 WorkList.push_back(&cfg->getEntry());
Richard Trieu6995de92015-08-21 03:43:09 +0000214
Robert Widmann97608442018-03-22 03:16:23 +0000215 while (!WorkList.empty()) {
216 CFGBlock *Block = WorkList.pop_back_val();
Richard Trieu2f024f42013-12-21 02:33:43 +0000217
Robert Widmann97608442018-03-22 03:16:23 +0000218 for (auto I = Block->succ_begin(), E = Block->succ_end(); I != E; ++I) {
219 if (CFGBlock *SuccBlock = *I) {
220 if (!Visited.insert(SuccBlock).second)
221 continue;
Richard Trieu2f024f42013-12-21 02:33:43 +0000222
Robert Widmann97608442018-03-22 03:16:23 +0000223 // Found a path to the exit node without a recursive call.
224 if (ExitID == SuccBlock->getBlockID())
225 return false;
Duncan P. N. Exon Smithdccc30a2015-07-23 20:15:50 +0000226
Robert Widmann97608442018-03-22 03:16:23 +0000227 // If the successor block contains a recursive call, end analysis there.
228 if (hasRecursiveCallInPath(FD, *SuccBlock)) {
229 foundRecursion = true;
230 continue;
Richard Trieu6995de92015-08-21 03:43:09 +0000231 }
Richard Trieu6995de92015-08-21 03:43:09 +0000232
Robert Widmann97608442018-03-22 03:16:23 +0000233 WorkList.push_back(SuccBlock);
234 }
235 }
236 }
237 return foundRecursion;
Richard Trieu2f024f42013-12-21 02:33:43 +0000238}
239
240static void checkRecursiveFunction(Sema &S, const FunctionDecl *FD,
Richard Trieu6995de92015-08-21 03:43:09 +0000241 const Stmt *Body, AnalysisDeclContext &AC) {
Richard Trieu2f024f42013-12-21 02:33:43 +0000242 FD = FD->getCanonicalDecl();
243
244 // Only run on non-templated functions and non-templated members of
245 // templated classes.
246 if (FD->getTemplatedKind() != FunctionDecl::TK_NonTemplate &&
247 FD->getTemplatedKind() != FunctionDecl::TK_MemberSpecialization)
248 return;
249
250 CFG *cfg = AC.getCFG();
Craig Topperc3ec1492014-05-26 06:22:03 +0000251 if (!cfg) return;
Richard Trieu2f024f42013-12-21 02:33:43 +0000252
Richard Trieu6995de92015-08-21 03:43:09 +0000253 // Emit diagnostic if a recursive function call is detected for all paths.
254 if (checkForRecursiveFunctionCall(FD, cfg))
Richard Trieu2f024f42013-12-21 02:33:43 +0000255 S.Diag(Body->getLocStart(), diag::warn_infinite_recursive_function);
256}
257
258//===----------------------------------------------------------------------===//
Erich Keane89fe9c22017-06-23 20:22:19 +0000259// Check for throw in a non-throwing function.
260//===----------------------------------------------------------------------===//
Erich Keane89fe9c22017-06-23 20:22:19 +0000261
Richard Smith08482102018-02-20 02:32:30 +0000262/// Determine whether an exception thrown by E, unwinding from ThrowBlock,
263/// can reach ExitBlock.
264static bool throwEscapes(Sema &S, const CXXThrowExpr *E, CFGBlock &ThrowBlock,
265 CFG *Body) {
Erich Keane89fe9c22017-06-23 20:22:19 +0000266 SmallVector<CFGBlock *, 16> Stack;
Richard Smith08482102018-02-20 02:32:30 +0000267 llvm::BitVector Queued(Body->getNumBlockIDs());
Erich Keane89fe9c22017-06-23 20:22:19 +0000268
Richard Smith08482102018-02-20 02:32:30 +0000269 Stack.push_back(&ThrowBlock);
270 Queued[ThrowBlock.getBlockID()] = true;
271
272 while (!Stack.empty()) {
273 CFGBlock &UnwindBlock = *Stack.back();
274 Stack.pop_back();
275
276 for (auto &Succ : UnwindBlock.succs()) {
277 if (!Succ.isReachable() || Queued[Succ->getBlockID()])
Erich Keane89fe9c22017-06-23 20:22:19 +0000278 continue;
279
Richard Smith08482102018-02-20 02:32:30 +0000280 if (Succ->getBlockID() == Body->getExit().getBlockID())
281 return true;
Erich Keane89fe9c22017-06-23 20:22:19 +0000282
Richard Smith08482102018-02-20 02:32:30 +0000283 if (auto *Catch =
284 dyn_cast_or_null<CXXCatchStmt>(Succ->getLabel())) {
285 QualType Caught = Catch->getCaughtType();
286 if (Caught.isNull() || // catch (...) catches everything
287 !E->getSubExpr() || // throw; is considered cuaght by any handler
288 S.handlerCanCatch(Caught, E->getSubExpr()->getType()))
289 // Exception doesn't escape via this path.
290 break;
291 } else {
292 Stack.push_back(Succ);
293 Queued[Succ->getBlockID()] = true;
Erich Keane89fe9c22017-06-23 20:22:19 +0000294 }
Richard Smith08482102018-02-20 02:32:30 +0000295 }
Erich Keane89fe9c22017-06-23 20:22:19 +0000296 }
Richard Smith08482102018-02-20 02:32:30 +0000297
298 return false;
299}
300
301static void visitReachableThrows(
302 CFG *BodyCFG,
303 llvm::function_ref<void(const CXXThrowExpr *, CFGBlock &)> Visit) {
304 llvm::BitVector Reachable(BodyCFG->getNumBlockIDs());
305 clang::reachable_code::ScanReachableFromBlock(&BodyCFG->getEntry(), Reachable);
306 for (CFGBlock *B : *BodyCFG) {
307 if (!Reachable[B->getBlockID()])
308 continue;
309 for (CFGElement &E : *B) {
310 Optional<CFGStmt> S = E.getAs<CFGStmt>();
311 if (!S)
312 continue;
313 if (auto *Throw = dyn_cast<CXXThrowExpr>(S->getStmt()))
314 Visit(Throw, *B);
315 }
316 }
Erich Keane89fe9c22017-06-23 20:22:19 +0000317}
318
319static void EmitDiagForCXXThrowInNonThrowingFunc(Sema &S, SourceLocation OpLoc,
320 const FunctionDecl *FD) {
Erich Keane7538b352017-07-05 16:43:45 +0000321 if (!S.getSourceManager().isInSystemHeader(OpLoc) &&
322 FD->getTypeSourceInfo()) {
Erich Keane89fe9c22017-06-23 20:22:19 +0000323 S.Diag(OpLoc, diag::warn_throw_in_noexcept_func) << FD;
324 if (S.getLangOpts().CPlusPlus11 &&
325 (isa<CXXDestructorDecl>(FD) ||
326 FD->getDeclName().getCXXOverloadedOperator() == OO_Delete ||
Erich Keane7538b352017-07-05 16:43:45 +0000327 FD->getDeclName().getCXXOverloadedOperator() == OO_Array_Delete)) {
328 if (const auto *Ty = FD->getTypeSourceInfo()->getType()->
329 getAs<FunctionProtoType>())
330 S.Diag(FD->getLocation(), diag::note_throw_in_dtor)
331 << !isa<CXXDestructorDecl>(FD) << !Ty->hasExceptionSpec()
332 << FD->getExceptionSpecSourceRange();
333 } else
334 S.Diag(FD->getLocation(), diag::note_throw_in_function)
335 << FD->getExceptionSpecSourceRange();
Erich Keane89fe9c22017-06-23 20:22:19 +0000336 }
337}
338
339static void checkThrowInNonThrowingFunc(Sema &S, const FunctionDecl *FD,
340 AnalysisDeclContext &AC) {
341 CFG *BodyCFG = AC.getCFG();
342 if (!BodyCFG)
343 return;
344 if (BodyCFG->getExit().pred_empty())
345 return;
Richard Smith08482102018-02-20 02:32:30 +0000346 visitReachableThrows(BodyCFG, [&](const CXXThrowExpr *Throw, CFGBlock &Block) {
347 if (throwEscapes(S, Throw, Block, BodyCFG))
348 EmitDiagForCXXThrowInNonThrowingFunc(S, Throw->getThrowLoc(), FD);
349 });
Erich Keane89fe9c22017-06-23 20:22:19 +0000350}
351
352static bool isNoexcept(const FunctionDecl *FD) {
353 const auto *FPT = FD->getType()->castAs<FunctionProtoType>();
Erich Keane9d10bdf2017-09-26 18:20:39 +0000354 if (FPT->isNothrow(FD->getASTContext()) || FD->hasAttr<NoThrowAttr>())
Erich Keane89fe9c22017-06-23 20:22:19 +0000355 return true;
356 return false;
357}
358
359//===----------------------------------------------------------------------===//
Ted Kremenek918fe842010-03-20 21:06:02 +0000360// Check for missing return value.
361//===----------------------------------------------------------------------===//
362
John McCall5c6ec8c2010-05-16 09:34:11 +0000363enum ControlFlowKind {
364 UnknownFallThrough,
365 NeverFallThrough,
366 MaybeFallThrough,
367 AlwaysFallThrough,
368 NeverFallThroughOrReturn
369};
Ted Kremenek918fe842010-03-20 21:06:02 +0000370
371/// CheckFallThrough - Check that we don't fall off the end of a
372/// Statement that should return a value.
373///
Sylvestre Ledru33b5baf2012-09-27 10:16:10 +0000374/// \returns AlwaysFallThrough iff we always fall off the end of the statement,
375/// MaybeFallThrough iff we might or might not fall off the end,
376/// NeverFallThroughOrReturn iff we never fall off the end of the statement or
377/// return. We assume NeverFallThrough iff we never fall off the end of the
Ted Kremenek918fe842010-03-20 21:06:02 +0000378/// statement but we may return. We assume that functions not marked noreturn
379/// will return.
Ted Kremenek81ce1c82011-10-24 01:32:45 +0000380static ControlFlowKind CheckFallThrough(AnalysisDeclContext &AC) {
Ted Kremenek918fe842010-03-20 21:06:02 +0000381 CFG *cfg = AC.getCFG();
Craig Topperc3ec1492014-05-26 06:22:03 +0000382 if (!cfg) return UnknownFallThrough;
Ted Kremenek918fe842010-03-20 21:06:02 +0000383
384 // The CFG leaves in dead things, and we don't want the dead code paths to
385 // confuse us, so we mark all live things first.
Ted Kremenek918fe842010-03-20 21:06:02 +0000386 llvm::BitVector live(cfg->getNumBlockIDs());
Ted Kremenekbd913712011-08-23 23:05:11 +0000387 unsigned count = reachable_code::ScanReachableFromBlock(&cfg->getEntry(),
Ted Kremenek918fe842010-03-20 21:06:02 +0000388 live);
389
390 bool AddEHEdges = AC.getAddEHEdges();
391 if (!AddEHEdges && count != cfg->getNumBlockIDs())
392 // When there are things remaining dead, and we didn't add EH edges
393 // from CallExprs to the catch clauses, we have to go back and
394 // mark them as live.
Aaron Ballmane5195222014-05-15 20:50:47 +0000395 for (const auto *B : *cfg) {
396 if (!live[B->getBlockID()]) {
397 if (B->pred_begin() == B->pred_end()) {
398 if (B->getTerminator() && isa<CXXTryStmt>(B->getTerminator()))
Ted Kremenek918fe842010-03-20 21:06:02 +0000399 // When not adding EH edges from calls, catch clauses
400 // can otherwise seem dead. Avoid noting them as dead.
Aaron Ballmane5195222014-05-15 20:50:47 +0000401 count += reachable_code::ScanReachableFromBlock(B, live);
Ted Kremenek918fe842010-03-20 21:06:02 +0000402 continue;
403 }
404 }
405 }
406
407 // Now we know what is live, we check the live precessors of the exit block
408 // and look for fall through paths, being careful to ignore normal returns,
409 // and exceptional paths.
410 bool HasLiveReturn = false;
411 bool HasFakeEdge = false;
412 bool HasPlainEdge = false;
413 bool HasAbnormalEdge = false;
Ted Kremenek50205742010-09-09 00:06:07 +0000414
415 // Ignore default cases that aren't likely to be reachable because all
416 // enums in a switch(X) have explicit case statements.
417 CFGBlock::FilterOptions FO;
418 FO.IgnoreDefaultsWithCoveredEnums = 1;
419
420 for (CFGBlock::filtered_pred_iterator
421 I = cfg->getExit().filtered_pred_start_end(FO); I.hasMore(); ++I) {
422 const CFGBlock& B = **I;
Ted Kremenek918fe842010-03-20 21:06:02 +0000423 if (!live[B.getBlockID()])
424 continue;
Ted Kremenek5d068492011-01-26 04:49:52 +0000425
Chandler Carruth03faf782011-09-13 09:53:58 +0000426 // Skip blocks which contain an element marked as no-return. They don't
427 // represent actually viable edges into the exit block, so mark them as
428 // abnormal.
429 if (B.hasNoReturnElement()) {
430 HasAbnormalEdge = true;
431 continue;
432 }
433
Ted Kremenek5d068492011-01-26 04:49:52 +0000434 // Destructors can appear after the 'return' in the CFG. This is
435 // normal. We need to look pass the destructors for the return
436 // statement (if it exists).
437 CFGBlock::const_reverse_iterator ri = B.rbegin(), re = B.rend();
Ted Kremeneke06a55c2011-03-02 20:32:29 +0000438
Chandler Carruth03faf782011-09-13 09:53:58 +0000439 for ( ; ri != re ; ++ri)
David Blaikie2a01f5d2013-02-21 20:58:29 +0000440 if (ri->getAs<CFGStmt>())
Ted Kremenek5d068492011-01-26 04:49:52 +0000441 break;
Chandler Carruth03faf782011-09-13 09:53:58 +0000442
Ted Kremenek5d068492011-01-26 04:49:52 +0000443 // No more CFGElements in the block?
444 if (ri == re) {
Ted Kremenek918fe842010-03-20 21:06:02 +0000445 if (B.getTerminator() && isa<CXXTryStmt>(B.getTerminator())) {
446 HasAbnormalEdge = true;
447 continue;
448 }
Ted Kremenek918fe842010-03-20 21:06:02 +0000449 // A labeled empty statement, or the entry block...
450 HasPlainEdge = true;
451 continue;
452 }
Ted Kremenekebe62602011-01-25 22:50:47 +0000453
David Blaikie2a01f5d2013-02-21 20:58:29 +0000454 CFGStmt CS = ri->castAs<CFGStmt>();
Ted Kremenekadfb4452011-08-23 23:05:04 +0000455 const Stmt *S = CS.getStmt();
Eric Fiselierda8f9b52017-05-25 02:16:53 +0000456 if (isa<ReturnStmt>(S) || isa<CoreturnStmt>(S)) {
Ted Kremenek918fe842010-03-20 21:06:02 +0000457 HasLiveReturn = true;
458 continue;
459 }
460 if (isa<ObjCAtThrowStmt>(S)) {
461 HasFakeEdge = true;
462 continue;
463 }
464 if (isa<CXXThrowExpr>(S)) {
465 HasFakeEdge = true;
466 continue;
467 }
Chad Rosier32503022012-06-11 20:47:18 +0000468 if (isa<MSAsmStmt>(S)) {
469 // TODO: Verify this is correct.
470 HasFakeEdge = true;
471 HasLiveReturn = true;
472 continue;
473 }
Ted Kremenek918fe842010-03-20 21:06:02 +0000474 if (isa<CXXTryStmt>(S)) {
475 HasAbnormalEdge = true;
476 continue;
477 }
Chandler Carruth03faf782011-09-13 09:53:58 +0000478 if (std::find(B.succ_begin(), B.succ_end(), &cfg->getExit())
479 == B.succ_end()) {
480 HasAbnormalEdge = true;
481 continue;
Ted Kremenek918fe842010-03-20 21:06:02 +0000482 }
Chandler Carruth03faf782011-09-13 09:53:58 +0000483
484 HasPlainEdge = true;
Ted Kremenek918fe842010-03-20 21:06:02 +0000485 }
486 if (!HasPlainEdge) {
487 if (HasLiveReturn)
488 return NeverFallThrough;
489 return NeverFallThroughOrReturn;
490 }
491 if (HasAbnormalEdge || HasFakeEdge || HasLiveReturn)
492 return MaybeFallThrough;
493 // This says AlwaysFallThrough for calls to functions that are not marked
494 // noreturn, that don't return. If people would like this warning to be more
495 // accurate, such functions should be marked as noreturn.
496 return AlwaysFallThrough;
497}
498
Dan Gohman28ade552010-07-26 21:25:24 +0000499namespace {
500
Ted Kremenek918fe842010-03-20 21:06:02 +0000501struct CheckFallThroughDiagnostics {
502 unsigned diag_MaybeFallThrough_HasNoReturn;
503 unsigned diag_MaybeFallThrough_ReturnsNonVoid;
504 unsigned diag_AlwaysFallThrough_HasNoReturn;
505 unsigned diag_AlwaysFallThrough_ReturnsNonVoid;
506 unsigned diag_NeverFallThroughOrReturn;
Eric Fiselier709d1b32016-10-27 07:30:31 +0000507 enum { Function, Block, Lambda, Coroutine } funMode;
Argyrios Kyrtzidis1cb0de12010-12-15 18:44:22 +0000508 SourceLocation FuncLoc;
Ted Kremenek0b405322010-03-23 00:13:23 +0000509
Douglas Gregor24f27692010-04-16 23:28:44 +0000510 static CheckFallThroughDiagnostics MakeForFunction(const Decl *Func) {
Ted Kremenek918fe842010-03-20 21:06:02 +0000511 CheckFallThroughDiagnostics D;
Argyrios Kyrtzidis1cb0de12010-12-15 18:44:22 +0000512 D.FuncLoc = Func->getLocation();
Ted Kremenek918fe842010-03-20 21:06:02 +0000513 D.diag_MaybeFallThrough_HasNoReturn =
514 diag::warn_falloff_noreturn_function;
515 D.diag_MaybeFallThrough_ReturnsNonVoid =
516 diag::warn_maybe_falloff_nonvoid_function;
517 D.diag_AlwaysFallThrough_HasNoReturn =
518 diag::warn_falloff_noreturn_function;
519 D.diag_AlwaysFallThrough_ReturnsNonVoid =
520 diag::warn_falloff_nonvoid_function;
Douglas Gregor24f27692010-04-16 23:28:44 +0000521
522 // Don't suggest that virtual functions be marked "noreturn", since they
523 // might be overridden by non-noreturn functions.
524 bool isVirtualMethod = false;
525 if (const CXXMethodDecl *Method = dyn_cast<CXXMethodDecl>(Func))
526 isVirtualMethod = Method->isVirtual();
527
Douglas Gregor0de57202011-10-10 18:15:57 +0000528 // Don't suggest that template instantiations be marked "noreturn"
529 bool isTemplateInstantiation = false;
Ted Kremenek85825ae2011-12-01 00:59:17 +0000530 if (const FunctionDecl *Function = dyn_cast<FunctionDecl>(Func))
531 isTemplateInstantiation = Function->isTemplateInstantiation();
Douglas Gregor0de57202011-10-10 18:15:57 +0000532
533 if (!isVirtualMethod && !isTemplateInstantiation)
Douglas Gregor24f27692010-04-16 23:28:44 +0000534 D.diag_NeverFallThroughOrReturn =
535 diag::warn_suggest_noreturn_function;
536 else
537 D.diag_NeverFallThroughOrReturn = 0;
538
Douglas Gregorcf11eb72012-02-15 16:20:15 +0000539 D.funMode = Function;
Ted Kremenek918fe842010-03-20 21:06:02 +0000540 return D;
541 }
Ted Kremenek0b405322010-03-23 00:13:23 +0000542
Eric Fiselier709d1b32016-10-27 07:30:31 +0000543 static CheckFallThroughDiagnostics MakeForCoroutine(const Decl *Func) {
544 CheckFallThroughDiagnostics D;
545 D.FuncLoc = Func->getLocation();
546 D.diag_MaybeFallThrough_HasNoReturn = 0;
547 D.diag_MaybeFallThrough_ReturnsNonVoid =
548 diag::warn_maybe_falloff_nonvoid_coroutine;
549 D.diag_AlwaysFallThrough_HasNoReturn = 0;
550 D.diag_AlwaysFallThrough_ReturnsNonVoid =
551 diag::warn_falloff_nonvoid_coroutine;
552 D.funMode = Coroutine;
553 return D;
554 }
555
Ted Kremenek918fe842010-03-20 21:06:02 +0000556 static CheckFallThroughDiagnostics MakeForBlock() {
557 CheckFallThroughDiagnostics D;
558 D.diag_MaybeFallThrough_HasNoReturn =
559 diag::err_noreturn_block_has_return_expr;
560 D.diag_MaybeFallThrough_ReturnsNonVoid =
561 diag::err_maybe_falloff_nonvoid_block;
562 D.diag_AlwaysFallThrough_HasNoReturn =
563 diag::err_noreturn_block_has_return_expr;
564 D.diag_AlwaysFallThrough_ReturnsNonVoid =
565 diag::err_falloff_nonvoid_block;
Fariborz Jahanian5ce22792014-04-03 23:06:35 +0000566 D.diag_NeverFallThroughOrReturn = 0;
Douglas Gregorcf11eb72012-02-15 16:20:15 +0000567 D.funMode = Block;
568 return D;
569 }
570
571 static CheckFallThroughDiagnostics MakeForLambda() {
572 CheckFallThroughDiagnostics D;
573 D.diag_MaybeFallThrough_HasNoReturn =
574 diag::err_noreturn_lambda_has_return_expr;
575 D.diag_MaybeFallThrough_ReturnsNonVoid =
576 diag::warn_maybe_falloff_nonvoid_lambda;
577 D.diag_AlwaysFallThrough_HasNoReturn =
578 diag::err_noreturn_lambda_has_return_expr;
579 D.diag_AlwaysFallThrough_ReturnsNonVoid =
580 diag::warn_falloff_nonvoid_lambda;
581 D.diag_NeverFallThroughOrReturn = 0;
582 D.funMode = Lambda;
Ted Kremenek918fe842010-03-20 21:06:02 +0000583 return D;
584 }
Ted Kremenek0b405322010-03-23 00:13:23 +0000585
David Blaikie9c902b52011-09-25 23:23:43 +0000586 bool checkDiagnostics(DiagnosticsEngine &D, bool ReturnsVoid,
Ted Kremenek918fe842010-03-20 21:06:02 +0000587 bool HasNoReturn) const {
Douglas Gregorcf11eb72012-02-15 16:20:15 +0000588 if (funMode == Function) {
Argyrios Kyrtzidis1cb0de12010-12-15 18:44:22 +0000589 return (ReturnsVoid ||
Alp Tokerd4a3f0e2014-06-15 23:30:39 +0000590 D.isIgnored(diag::warn_maybe_falloff_nonvoid_function,
591 FuncLoc)) &&
592 (!HasNoReturn ||
593 D.isIgnored(diag::warn_noreturn_function_has_return_expr,
594 FuncLoc)) &&
595 (!ReturnsVoid ||
596 D.isIgnored(diag::warn_suggest_noreturn_block, FuncLoc));
Ted Kremenek918fe842010-03-20 21:06:02 +0000597 }
Eric Fiselier709d1b32016-10-27 07:30:31 +0000598 if (funMode == Coroutine) {
599 return (ReturnsVoid ||
600 D.isIgnored(diag::warn_maybe_falloff_nonvoid_function, FuncLoc) ||
601 D.isIgnored(diag::warn_maybe_falloff_nonvoid_coroutine,
602 FuncLoc)) &&
603 (!HasNoReturn);
604 }
Douglas Gregorcf11eb72012-02-15 16:20:15 +0000605 // For blocks / lambdas.
Fariborz Jahanian5ce22792014-04-03 23:06:35 +0000606 return ReturnsVoid && !HasNoReturn;
Ted Kremenek918fe842010-03-20 21:06:02 +0000607 }
608};
609
Hans Wennborgdcfba332015-10-06 23:40:43 +0000610} // anonymous namespace
Dan Gohman28ade552010-07-26 21:25:24 +0000611
Reid Kleckner87a31802018-03-12 21:43:02 +0000612/// CheckFallThroughForBody - Check that we don't fall off the end of a
Ted Kremenek918fe842010-03-20 21:06:02 +0000613/// function that should return a value. Check that we don't fall off the end
614/// of a noreturn function. We assume that functions and blocks not marked
615/// noreturn will return.
616static void CheckFallThroughForBody(Sema &S, const Decl *D, const Stmt *Body,
Ted Kremenek1767a272011-02-23 01:51:48 +0000617 const BlockExpr *blkExpr,
Reid Kleckner87a31802018-03-12 21:43:02 +0000618 const CheckFallThroughDiagnostics &CD,
619 AnalysisDeclContext &AC,
620 sema::FunctionScopeInfo *FSI) {
Ted Kremenek918fe842010-03-20 21:06:02 +0000621
622 bool ReturnsVoid = false;
623 bool HasNoReturn = false;
Reid Kleckner87a31802018-03-12 21:43:02 +0000624 bool IsCoroutine = FSI->isCoroutine();
Ted Kremenek918fe842010-03-20 21:06:02 +0000625
Eric Fiselier709d1b32016-10-27 07:30:31 +0000626 if (const auto *FD = dyn_cast<FunctionDecl>(D)) {
627 if (const auto *CBody = dyn_cast<CoroutineBodyStmt>(Body))
628 ReturnsVoid = CBody->getFallthroughHandler() != nullptr;
629 else
630 ReturnsVoid = FD->getReturnType()->isVoidType();
Richard Smith10876ef2013-01-17 01:30:42 +0000631 HasNoReturn = FD->isNoReturn();
Ted Kremenek918fe842010-03-20 21:06:02 +0000632 }
Eric Fiselier709d1b32016-10-27 07:30:31 +0000633 else if (const auto *MD = dyn_cast<ObjCMethodDecl>(D)) {
Alp Toker314cc812014-01-25 16:55:45 +0000634 ReturnsVoid = MD->getReturnType()->isVoidType();
Ted Kremenek918fe842010-03-20 21:06:02 +0000635 HasNoReturn = MD->hasAttr<NoReturnAttr>();
636 }
637 else if (isa<BlockDecl>(D)) {
Ted Kremenek1767a272011-02-23 01:51:48 +0000638 QualType BlockTy = blkExpr->getType();
Ted Kremenek0b405322010-03-23 00:13:23 +0000639 if (const FunctionType *FT =
Ted Kremenek918fe842010-03-20 21:06:02 +0000640 BlockTy->getPointeeType()->getAs<FunctionType>()) {
Alp Toker314cc812014-01-25 16:55:45 +0000641 if (FT->getReturnType()->isVoidType())
Ted Kremenek918fe842010-03-20 21:06:02 +0000642 ReturnsVoid = true;
643 if (FT->getNoReturnAttr())
644 HasNoReturn = true;
645 }
646 }
647
David Blaikie9c902b52011-09-25 23:23:43 +0000648 DiagnosticsEngine &Diags = S.getDiagnostics();
Ted Kremenek918fe842010-03-20 21:06:02 +0000649
650 // Short circuit for compilation speed.
651 if (CD.checkDiagnostics(Diags, ReturnsVoid, HasNoReturn))
652 return;
Aaron Ballmanb2e2c1b2014-10-24 13:19:19 +0000653 SourceLocation LBrace = Body->getLocStart(), RBrace = Body->getLocEnd();
Eric Fiselierda8f9b52017-05-25 02:16:53 +0000654 auto EmitDiag = [&](SourceLocation Loc, unsigned DiagID) {
655 if (IsCoroutine)
Reid Kleckner87a31802018-03-12 21:43:02 +0000656 S.Diag(Loc, DiagID) << FSI->CoroutinePromise->getType();
Eric Fiselierda8f9b52017-05-25 02:16:53 +0000657 else
658 S.Diag(Loc, DiagID);
659 };
Aaron Ballmanb2e2c1b2014-10-24 13:19:19 +0000660 // Either in a function body compound statement, or a function-try-block.
661 switch (CheckFallThrough(AC)) {
662 case UnknownFallThrough:
663 break;
John McCall5c6ec8c2010-05-16 09:34:11 +0000664
Aaron Ballmanb2e2c1b2014-10-24 13:19:19 +0000665 case MaybeFallThrough:
666 if (HasNoReturn)
Eric Fiselierda8f9b52017-05-25 02:16:53 +0000667 EmitDiag(RBrace, CD.diag_MaybeFallThrough_HasNoReturn);
Aaron Ballmanb2e2c1b2014-10-24 13:19:19 +0000668 else if (!ReturnsVoid)
Eric Fiselierda8f9b52017-05-25 02:16:53 +0000669 EmitDiag(RBrace, CD.diag_MaybeFallThrough_ReturnsNonVoid);
Aaron Ballmanb2e2c1b2014-10-24 13:19:19 +0000670 break;
671 case AlwaysFallThrough:
672 if (HasNoReturn)
Eric Fiselierda8f9b52017-05-25 02:16:53 +0000673 EmitDiag(RBrace, CD.diag_AlwaysFallThrough_HasNoReturn);
Aaron Ballmanb2e2c1b2014-10-24 13:19:19 +0000674 else if (!ReturnsVoid)
Eric Fiselierda8f9b52017-05-25 02:16:53 +0000675 EmitDiag(RBrace, CD.diag_AlwaysFallThrough_ReturnsNonVoid);
Aaron Ballmanb2e2c1b2014-10-24 13:19:19 +0000676 break;
677 case NeverFallThroughOrReturn:
678 if (ReturnsVoid && !HasNoReturn && CD.diag_NeverFallThroughOrReturn) {
679 if (const FunctionDecl *FD = dyn_cast<FunctionDecl>(D)) {
680 S.Diag(LBrace, CD.diag_NeverFallThroughOrReturn) << 0 << FD;
681 } else if (const ObjCMethodDecl *MD = dyn_cast<ObjCMethodDecl>(D)) {
682 S.Diag(LBrace, CD.diag_NeverFallThroughOrReturn) << 1 << MD;
683 } else {
684 S.Diag(LBrace, CD.diag_NeverFallThroughOrReturn);
Chandler Carruthc841b6e2011-08-31 09:01:53 +0000685 }
Aaron Ballmanb2e2c1b2014-10-24 13:19:19 +0000686 }
687 break;
688 case NeverFallThrough:
689 break;
Ted Kremenek918fe842010-03-20 21:06:02 +0000690 }
691}
692
693//===----------------------------------------------------------------------===//
Ted Kremenekb749a6d2011-01-15 02:58:47 +0000694// -Wuninitialized
695//===----------------------------------------------------------------------===//
696
Ted Kremenekb8d8c4e2011-04-04 20:56:00 +0000697namespace {
Chandler Carruth4e021822011-04-05 06:48:00 +0000698/// ContainsReference - A visitor class to search for references to
699/// a particular declaration (the needle) within any evaluated component of an
700/// expression (recursively).
Scott Douglass503fc392015-06-10 13:53:15 +0000701class ContainsReference : public ConstEvaluatedExprVisitor<ContainsReference> {
Chandler Carruth4e021822011-04-05 06:48:00 +0000702 bool FoundReference;
703 const DeclRefExpr *Needle;
704
Ted Kremenekb8d8c4e2011-04-04 20:56:00 +0000705public:
Scott Douglass503fc392015-06-10 13:53:15 +0000706 typedef ConstEvaluatedExprVisitor<ContainsReference> Inherited;
Chandler Carruth4e021822011-04-05 06:48:00 +0000707
Scott Douglass503fc392015-06-10 13:53:15 +0000708 ContainsReference(ASTContext &Context, const DeclRefExpr *Needle)
709 : Inherited(Context), FoundReference(false), Needle(Needle) {}
710
711 void VisitExpr(const Expr *E) {
Ted Kremenekb8d8c4e2011-04-04 20:56:00 +0000712 // Stop evaluating if we already have a reference.
Chandler Carruth4e021822011-04-05 06:48:00 +0000713 if (FoundReference)
Ted Kremenekb8d8c4e2011-04-04 20:56:00 +0000714 return;
Chandler Carruth4e021822011-04-05 06:48:00 +0000715
Scott Douglass503fc392015-06-10 13:53:15 +0000716 Inherited::VisitExpr(E);
Ted Kremenekb8d8c4e2011-04-04 20:56:00 +0000717 }
Chandler Carruth4e021822011-04-05 06:48:00 +0000718
Scott Douglass503fc392015-06-10 13:53:15 +0000719 void VisitDeclRefExpr(const DeclRefExpr *E) {
Chandler Carruth4e021822011-04-05 06:48:00 +0000720 if (E == Needle)
721 FoundReference = true;
722 else
Scott Douglass503fc392015-06-10 13:53:15 +0000723 Inherited::VisitDeclRefExpr(E);
Ted Kremenekb8d8c4e2011-04-04 20:56:00 +0000724 }
Chandler Carruth4e021822011-04-05 06:48:00 +0000725
726 bool doesContainReference() const { return FoundReference; }
Ted Kremenekb8d8c4e2011-04-04 20:56:00 +0000727};
Hans Wennborgdcfba332015-10-06 23:40:43 +0000728} // anonymous namespace
Ted Kremenekb8d8c4e2011-04-04 20:56:00 +0000729
David Blaikiee5f9a9e2011-09-10 05:35:08 +0000730static bool SuggestInitializationFixit(Sema &S, const VarDecl *VD) {
Fariborz Jahanian429fadb2012-03-08 00:22:50 +0000731 QualType VariableTy = VD->getType().getCanonicalType();
732 if (VariableTy->isBlockPointerType() &&
733 !VD->hasAttr<BlocksAttr>()) {
Nico Weber3c68ee92014-07-08 23:46:20 +0000734 S.Diag(VD->getLocation(), diag::note_block_var_fixit_add_initialization)
735 << VD->getDeclName()
736 << FixItHint::CreateInsertion(VD->getLocation(), "__block ");
Fariborz Jahanian429fadb2012-03-08 00:22:50 +0000737 return true;
738 }
Richard Smithf7ec86a2013-09-20 00:27:40 +0000739
David Blaikiee5f9a9e2011-09-10 05:35:08 +0000740 // Don't issue a fixit if there is already an initializer.
741 if (VD->getInit())
742 return false;
Richard Trieu2cdcf822012-05-03 01:09:59 +0000743
744 // Don't suggest a fixit inside macros.
745 if (VD->getLocEnd().isMacroID())
746 return false;
747
Alp Tokerb6cc5922014-05-03 03:45:55 +0000748 SourceLocation Loc = S.getLocForEndOfToken(VD->getLocEnd());
Richard Smithf7ec86a2013-09-20 00:27:40 +0000749
750 // Suggest possible initialization (if any).
751 std::string Init = S.getFixItZeroInitializerForType(VariableTy, Loc);
752 if (Init.empty())
753 return false;
754
Richard Smith8d06f422012-01-12 23:53:29 +0000755 S.Diag(Loc, diag::note_var_fixit_add_initialization) << VD->getDeclName()
756 << FixItHint::CreateInsertion(Loc, Init);
757 return true;
David Blaikiee5f9a9e2011-09-10 05:35:08 +0000758}
759
Richard Smith1bb8edb82012-05-26 06:20:46 +0000760/// Create a fixit to remove an if-like statement, on the assumption that its
761/// condition is CondVal.
762static void CreateIfFixit(Sema &S, const Stmt *If, const Stmt *Then,
763 const Stmt *Else, bool CondVal,
764 FixItHint &Fixit1, FixItHint &Fixit2) {
765 if (CondVal) {
766 // If condition is always true, remove all but the 'then'.
767 Fixit1 = FixItHint::CreateRemoval(
768 CharSourceRange::getCharRange(If->getLocStart(),
769 Then->getLocStart()));
770 if (Else) {
Craig Topper07fa1762015-11-15 02:31:46 +0000771 SourceLocation ElseKwLoc = S.getLocForEndOfToken(Then->getLocEnd());
Richard Smith1bb8edb82012-05-26 06:20:46 +0000772 Fixit2 = FixItHint::CreateRemoval(
773 SourceRange(ElseKwLoc, Else->getLocEnd()));
774 }
775 } else {
776 // If condition is always false, remove all but the 'else'.
777 if (Else)
778 Fixit1 = FixItHint::CreateRemoval(
779 CharSourceRange::getCharRange(If->getLocStart(),
780 Else->getLocStart()));
781 else
782 Fixit1 = FixItHint::CreateRemoval(If->getSourceRange());
783 }
784}
785
786/// DiagUninitUse -- Helper function to produce a diagnostic for an
787/// uninitialized use of a variable.
788static void DiagUninitUse(Sema &S, const VarDecl *VD, const UninitUse &Use,
789 bool IsCapturedByBlock) {
790 bool Diagnosed = false;
791
Richard Smithba8071e2013-09-12 18:49:10 +0000792 switch (Use.getKind()) {
793 case UninitUse::Always:
794 S.Diag(Use.getUser()->getLocStart(), diag::warn_uninit_var)
795 << VD->getDeclName() << IsCapturedByBlock
796 << Use.getUser()->getSourceRange();
797 return;
798
799 case UninitUse::AfterDecl:
800 case UninitUse::AfterCall:
801 S.Diag(VD->getLocation(), diag::warn_sometimes_uninit_var)
802 << VD->getDeclName() << IsCapturedByBlock
803 << (Use.getKind() == UninitUse::AfterDecl ? 4 : 5)
804 << const_cast<DeclContext*>(VD->getLexicalDeclContext())
805 << VD->getSourceRange();
806 S.Diag(Use.getUser()->getLocStart(), diag::note_uninit_var_use)
807 << IsCapturedByBlock << Use.getUser()->getSourceRange();
808 return;
809
810 case UninitUse::Maybe:
811 case UninitUse::Sometimes:
812 // Carry on to report sometimes-uninitialized branches, if possible,
813 // or a 'may be used uninitialized' diagnostic otherwise.
814 break;
815 }
816
Richard Smith1bb8edb82012-05-26 06:20:46 +0000817 // Diagnose each branch which leads to a sometimes-uninitialized use.
Richard Smith4323bf82012-05-25 02:17:09 +0000818 for (UninitUse::branch_iterator I = Use.branch_begin(), E = Use.branch_end();
819 I != E; ++I) {
Richard Smith1bb8edb82012-05-26 06:20:46 +0000820 assert(Use.getKind() == UninitUse::Sometimes);
821
822 const Expr *User = Use.getUser();
Richard Smith4323bf82012-05-25 02:17:09 +0000823 const Stmt *Term = I->Terminator;
Richard Smith1bb8edb82012-05-26 06:20:46 +0000824
825 // Information used when building the diagnostic.
Richard Smith4323bf82012-05-25 02:17:09 +0000826 unsigned DiagKind;
David Blaikie1d202a62012-10-08 01:11:04 +0000827 StringRef Str;
Richard Smith1bb8edb82012-05-26 06:20:46 +0000828 SourceRange Range;
829
Stefanus Du Toitb3318502013-03-01 21:41:22 +0000830 // FixIts to suppress the diagnostic by removing the dead condition.
Richard Smith1bb8edb82012-05-26 06:20:46 +0000831 // For all binary terminators, branch 0 is taken if the condition is true,
832 // and branch 1 is taken if the condition is false.
833 int RemoveDiagKind = -1;
834 const char *FixitStr =
835 S.getLangOpts().CPlusPlus ? (I->Output ? "true" : "false")
836 : (I->Output ? "1" : "0");
837 FixItHint Fixit1, Fixit2;
838
Richard Smithba8071e2013-09-12 18:49:10 +0000839 switch (Term ? Term->getStmtClass() : Stmt::DeclStmtClass) {
Richard Smith4323bf82012-05-25 02:17:09 +0000840 default:
Richard Smith1bb8edb82012-05-26 06:20:46 +0000841 // Don't know how to report this. Just fall back to 'may be used
Richard Smithba8071e2013-09-12 18:49:10 +0000842 // uninitialized'. FIXME: Can this happen?
Richard Smith4323bf82012-05-25 02:17:09 +0000843 continue;
844
845 // "condition is true / condition is false".
Richard Smith1bb8edb82012-05-26 06:20:46 +0000846 case Stmt::IfStmtClass: {
847 const IfStmt *IS = cast<IfStmt>(Term);
Richard Smith4323bf82012-05-25 02:17:09 +0000848 DiagKind = 0;
849 Str = "if";
Richard Smith1bb8edb82012-05-26 06:20:46 +0000850 Range = IS->getCond()->getSourceRange();
851 RemoveDiagKind = 0;
852 CreateIfFixit(S, IS, IS->getThen(), IS->getElse(),
853 I->Output, Fixit1, Fixit2);
Richard Smith4323bf82012-05-25 02:17:09 +0000854 break;
Richard Smith1bb8edb82012-05-26 06:20:46 +0000855 }
856 case Stmt::ConditionalOperatorClass: {
857 const ConditionalOperator *CO = cast<ConditionalOperator>(Term);
Richard Smith4323bf82012-05-25 02:17:09 +0000858 DiagKind = 0;
859 Str = "?:";
Richard Smith1bb8edb82012-05-26 06:20:46 +0000860 Range = CO->getCond()->getSourceRange();
861 RemoveDiagKind = 0;
862 CreateIfFixit(S, CO, CO->getTrueExpr(), CO->getFalseExpr(),
863 I->Output, Fixit1, Fixit2);
Richard Smith4323bf82012-05-25 02:17:09 +0000864 break;
Richard Smith1bb8edb82012-05-26 06:20:46 +0000865 }
Richard Smith4323bf82012-05-25 02:17:09 +0000866 case Stmt::BinaryOperatorClass: {
867 const BinaryOperator *BO = cast<BinaryOperator>(Term);
868 if (!BO->isLogicalOp())
869 continue;
870 DiagKind = 0;
871 Str = BO->getOpcodeStr();
872 Range = BO->getLHS()->getSourceRange();
Richard Smith1bb8edb82012-05-26 06:20:46 +0000873 RemoveDiagKind = 0;
874 if ((BO->getOpcode() == BO_LAnd && I->Output) ||
875 (BO->getOpcode() == BO_LOr && !I->Output))
876 // true && y -> y, false || y -> y.
877 Fixit1 = FixItHint::CreateRemoval(SourceRange(BO->getLocStart(),
878 BO->getOperatorLoc()));
879 else
880 // false && y -> false, true || y -> true.
881 Fixit1 = FixItHint::CreateReplacement(BO->getSourceRange(), FixitStr);
Richard Smith4323bf82012-05-25 02:17:09 +0000882 break;
883 }
884
885 // "loop is entered / loop is exited".
886 case Stmt::WhileStmtClass:
887 DiagKind = 1;
888 Str = "while";
889 Range = cast<WhileStmt>(Term)->getCond()->getSourceRange();
Richard Smith1bb8edb82012-05-26 06:20:46 +0000890 RemoveDiagKind = 1;
891 Fixit1 = FixItHint::CreateReplacement(Range, FixitStr);
Richard Smith4323bf82012-05-25 02:17:09 +0000892 break;
893 case Stmt::ForStmtClass:
894 DiagKind = 1;
895 Str = "for";
896 Range = cast<ForStmt>(Term)->getCond()->getSourceRange();
Richard Smith1bb8edb82012-05-26 06:20:46 +0000897 RemoveDiagKind = 1;
898 if (I->Output)
899 Fixit1 = FixItHint::CreateRemoval(Range);
900 else
901 Fixit1 = FixItHint::CreateReplacement(Range, FixitStr);
Richard Smith4323bf82012-05-25 02:17:09 +0000902 break;
Richard Smithba8071e2013-09-12 18:49:10 +0000903 case Stmt::CXXForRangeStmtClass:
904 if (I->Output == 1) {
905 // The use occurs if a range-based for loop's body never executes.
906 // That may be impossible, and there's no syntactic fix for this,
907 // so treat it as a 'may be uninitialized' case.
908 continue;
909 }
910 DiagKind = 1;
911 Str = "for";
912 Range = cast<CXXForRangeStmt>(Term)->getRangeInit()->getSourceRange();
913 break;
Richard Smith4323bf82012-05-25 02:17:09 +0000914
915 // "condition is true / loop is exited".
916 case Stmt::DoStmtClass:
917 DiagKind = 2;
918 Str = "do";
919 Range = cast<DoStmt>(Term)->getCond()->getSourceRange();
Richard Smith1bb8edb82012-05-26 06:20:46 +0000920 RemoveDiagKind = 1;
921 Fixit1 = FixItHint::CreateReplacement(Range, FixitStr);
Richard Smith4323bf82012-05-25 02:17:09 +0000922 break;
923
924 // "switch case is taken".
925 case Stmt::CaseStmtClass:
926 DiagKind = 3;
927 Str = "case";
928 Range = cast<CaseStmt>(Term)->getLHS()->getSourceRange();
929 break;
930 case Stmt::DefaultStmtClass:
931 DiagKind = 3;
932 Str = "default";
933 Range = cast<DefaultStmt>(Term)->getDefaultLoc();
934 break;
935 }
936
Richard Smith1bb8edb82012-05-26 06:20:46 +0000937 S.Diag(Range.getBegin(), diag::warn_sometimes_uninit_var)
938 << VD->getDeclName() << IsCapturedByBlock << DiagKind
939 << Str << I->Output << Range;
940 S.Diag(User->getLocStart(), diag::note_uninit_var_use)
941 << IsCapturedByBlock << User->getSourceRange();
942 if (RemoveDiagKind != -1)
943 S.Diag(Fixit1.RemoveRange.getBegin(), diag::note_uninit_fixit_remove_cond)
944 << RemoveDiagKind << Str << I->Output << Fixit1 << Fixit2;
945
946 Diagnosed = true;
Richard Smith4323bf82012-05-25 02:17:09 +0000947 }
Richard Smith1bb8edb82012-05-26 06:20:46 +0000948
949 if (!Diagnosed)
Richard Smithba8071e2013-09-12 18:49:10 +0000950 S.Diag(Use.getUser()->getLocStart(), diag::warn_maybe_uninit_var)
Richard Smith1bb8edb82012-05-26 06:20:46 +0000951 << VD->getDeclName() << IsCapturedByBlock
952 << Use.getUser()->getSourceRange();
Richard Smith4323bf82012-05-25 02:17:09 +0000953}
954
Chandler Carruthdd8f0d02011-04-05 18:27:05 +0000955/// DiagnoseUninitializedUse -- Helper function for diagnosing uses of an
956/// uninitialized variable. This manages the different forms of diagnostic
957/// emitted for particular types of uses. Returns true if the use was diagnosed
Richard Smith4323bf82012-05-25 02:17:09 +0000958/// as a warning. If a particular use is one we omit warnings for, returns
Chandler Carruthdd8f0d02011-04-05 18:27:05 +0000959/// false.
960static bool DiagnoseUninitializedUse(Sema &S, const VarDecl *VD,
Richard Smith4323bf82012-05-25 02:17:09 +0000961 const UninitUse &Use,
Ted Kremenek596fa162011-10-13 18:50:06 +0000962 bool alwaysReportSelfInit = false) {
Richard Smith4323bf82012-05-25 02:17:09 +0000963 if (const DeclRefExpr *DRE = dyn_cast<DeclRefExpr>(Use.getUser())) {
Richard Trieu43a2fc72012-05-09 21:08:22 +0000964 // Inspect the initializer of the variable declaration which is
965 // being referenced prior to its initialization. We emit
966 // specialized diagnostics for self-initialization, and we
967 // specifically avoid warning about self references which take the
968 // form of:
969 //
970 // int x = x;
971 //
972 // This is used to indicate to GCC that 'x' is intentionally left
973 // uninitialized. Proven code paths which access 'x' in
974 // an uninitialized state after this will still warn.
975 if (const Expr *Initializer = VD->getInit()) {
976 if (!alwaysReportSelfInit && DRE == Initializer->IgnoreParenImpCasts())
977 return false;
Chandler Carruth895904da2011-04-05 18:18:05 +0000978
Richard Trieu43a2fc72012-05-09 21:08:22 +0000979 ContainsReference CR(S.Context, DRE);
Scott Douglass503fc392015-06-10 13:53:15 +0000980 CR.Visit(Initializer);
Richard Trieu43a2fc72012-05-09 21:08:22 +0000981 if (CR.doesContainReference()) {
Chandler Carruth895904da2011-04-05 18:18:05 +0000982 S.Diag(DRE->getLocStart(),
983 diag::warn_uninit_self_reference_in_init)
Richard Trieu43a2fc72012-05-09 21:08:22 +0000984 << VD->getDeclName() << VD->getLocation() << DRE->getSourceRange();
985 return true;
Chandler Carruth895904da2011-04-05 18:18:05 +0000986 }
Chandler Carruth895904da2011-04-05 18:18:05 +0000987 }
Richard Trieu43a2fc72012-05-09 21:08:22 +0000988
Richard Smith1bb8edb82012-05-26 06:20:46 +0000989 DiagUninitUse(S, VD, Use, false);
Chandler Carruth895904da2011-04-05 18:18:05 +0000990 } else {
Richard Smith4323bf82012-05-25 02:17:09 +0000991 const BlockExpr *BE = cast<BlockExpr>(Use.getUser());
Richard Smith1bb8edb82012-05-26 06:20:46 +0000992 if (VD->getType()->isBlockPointerType() && !VD->hasAttr<BlocksAttr>())
993 S.Diag(BE->getLocStart(),
994 diag::warn_uninit_byref_blockvar_captured_by_block)
Fariborz Jahanian429fadb2012-03-08 00:22:50 +0000995 << VD->getDeclName();
Richard Smith1bb8edb82012-05-26 06:20:46 +0000996 else
997 DiagUninitUse(S, VD, Use, true);
Chandler Carruth895904da2011-04-05 18:18:05 +0000998 }
999
1000 // Report where the variable was declared when the use wasn't within
David Blaikiee5f9a9e2011-09-10 05:35:08 +00001001 // the initializer of that declaration & we didn't already suggest
1002 // an initialization fixit.
Richard Trieu43a2fc72012-05-09 21:08:22 +00001003 if (!SuggestInitializationFixit(S, VD))
Reid Klecknerf463a8a2016-04-29 00:37:43 +00001004 S.Diag(VD->getLocStart(), diag::note_var_declared_here)
Chandler Carruth895904da2011-04-05 18:18:05 +00001005 << VD->getDeclName();
1006
Chandler Carruthdd8f0d02011-04-05 18:27:05 +00001007 return true;
Chandler Carruth7a037202011-04-05 18:18:08 +00001008}
1009
Richard Smith84837d52012-05-03 18:27:39 +00001010namespace {
1011 class FallthroughMapper : public RecursiveASTVisitor<FallthroughMapper> {
1012 public:
1013 FallthroughMapper(Sema &S)
1014 : FoundSwitchStatements(false),
1015 S(S) {
1016 }
1017
1018 bool foundSwitchStatements() const { return FoundSwitchStatements; }
1019
1020 void markFallthroughVisited(const AttributedStmt *Stmt) {
1021 bool Found = FallthroughStmts.erase(Stmt);
1022 assert(Found);
Kaelyn Uhrain29a8eeb2012-05-03 19:46:38 +00001023 (void)Found;
Richard Smith84837d52012-05-03 18:27:39 +00001024 }
1025
1026 typedef llvm::SmallPtrSet<const AttributedStmt*, 8> AttrStmts;
1027
1028 const AttrStmts &getFallthroughStmts() const {
1029 return FallthroughStmts;
1030 }
1031
Alexander Kornienkoafed1dd2013-01-30 03:49:44 +00001032 void fillReachableBlocks(CFG *Cfg) {
1033 assert(ReachableBlocks.empty() && "ReachableBlocks already filled");
1034 std::deque<const CFGBlock *> BlockQueue;
1035
1036 ReachableBlocks.insert(&Cfg->getEntry());
1037 BlockQueue.push_back(&Cfg->getEntry());
Alexander Kornienkoc121b9b2013-02-07 02:17:19 +00001038 // Mark all case blocks reachable to avoid problems with switching on
1039 // constants, covered enums, etc.
1040 // These blocks can contain fall-through annotations, and we don't want to
1041 // issue a warn_fallthrough_attr_unreachable for them.
Aaron Ballmane5195222014-05-15 20:50:47 +00001042 for (const auto *B : *Cfg) {
Alexander Kornienkoc121b9b2013-02-07 02:17:19 +00001043 const Stmt *L = B->getLabel();
David Blaikie82e95a32014-11-19 07:49:47 +00001044 if (L && isa<SwitchCase>(L) && ReachableBlocks.insert(B).second)
Alexander Kornienkoc121b9b2013-02-07 02:17:19 +00001045 BlockQueue.push_back(B);
1046 }
1047
Alexander Kornienkoafed1dd2013-01-30 03:49:44 +00001048 while (!BlockQueue.empty()) {
1049 const CFGBlock *P = BlockQueue.front();
1050 BlockQueue.pop_front();
1051 for (CFGBlock::const_succ_iterator I = P->succ_begin(),
1052 E = P->succ_end();
1053 I != E; ++I) {
David Blaikie82e95a32014-11-19 07:49:47 +00001054 if (*I && ReachableBlocks.insert(*I).second)
Alexander Kornienkoafed1dd2013-01-30 03:49:44 +00001055 BlockQueue.push_back(*I);
1056 }
1057 }
1058 }
1059
Richard Smith7532d372017-03-22 01:49:19 +00001060 bool checkFallThroughIntoBlock(const CFGBlock &B, int &AnnotatedCnt,
1061 bool IsTemplateInstantiation) {
Alexander Kornienkoafed1dd2013-01-30 03:49:44 +00001062 assert(!ReachableBlocks.empty() && "ReachableBlocks empty");
1063
Richard Smith84837d52012-05-03 18:27:39 +00001064 int UnannotatedCnt = 0;
1065 AnnotatedCnt = 0;
1066
Aaron Ballmane5195222014-05-15 20:50:47 +00001067 std::deque<const CFGBlock*> BlockQueue(B.pred_begin(), B.pred_end());
Richard Smith84837d52012-05-03 18:27:39 +00001068 while (!BlockQueue.empty()) {
1069 const CFGBlock *P = BlockQueue.front();
1070 BlockQueue.pop_front();
Nick Lewyckycdf11082014-02-27 02:43:25 +00001071 if (!P) continue;
Richard Smith84837d52012-05-03 18:27:39 +00001072
1073 const Stmt *Term = P->getTerminator();
1074 if (Term && isa<SwitchStmt>(Term))
1075 continue; // Switch statement, good.
1076
1077 const SwitchCase *SW = dyn_cast_or_null<SwitchCase>(P->getLabel());
1078 if (SW && SW->getSubStmt() == B.getLabel() && P->begin() == P->end())
1079 continue; // Previous case label has no statements, good.
1080
Alexander Kornienko09f15f32013-01-25 20:44:56 +00001081 const LabelStmt *L = dyn_cast_or_null<LabelStmt>(P->getLabel());
1082 if (L && L->getSubStmt() == B.getLabel() && P->begin() == P->end())
1083 continue; // Case label is preceded with a normal label, good.
1084
Alexander Kornienkoafed1dd2013-01-30 03:49:44 +00001085 if (!ReachableBlocks.count(P)) {
Alexander Kornienkoc121b9b2013-02-07 02:17:19 +00001086 for (CFGBlock::const_reverse_iterator ElemIt = P->rbegin(),
1087 ElemEnd = P->rend();
1088 ElemIt != ElemEnd; ++ElemIt) {
David Blaikie00be69a2013-02-23 00:29:34 +00001089 if (Optional<CFGStmt> CS = ElemIt->getAs<CFGStmt>()) {
1090 if (const AttributedStmt *AS = asFallThroughAttr(CS->getStmt())) {
Richard Smith7532d372017-03-22 01:49:19 +00001091 // Don't issue a warning for an unreachable fallthrough
1092 // attribute in template instantiations as it may not be
1093 // unreachable in all instantiations of the template.
1094 if (!IsTemplateInstantiation)
1095 S.Diag(AS->getLocStart(),
1096 diag::warn_fallthrough_attr_unreachable);
Richard Smith84837d52012-05-03 18:27:39 +00001097 markFallthroughVisited(AS);
1098 ++AnnotatedCnt;
Alexander Kornienkoc121b9b2013-02-07 02:17:19 +00001099 break;
Richard Smith84837d52012-05-03 18:27:39 +00001100 }
1101 // Don't care about other unreachable statements.
1102 }
1103 }
1104 // If there are no unreachable statements, this may be a special
1105 // case in CFG:
1106 // case X: {
1107 // A a; // A has a destructor.
1108 // break;
1109 // }
1110 // // <<<< This place is represented by a 'hanging' CFG block.
1111 // case Y:
1112 continue;
1113 }
1114
1115 const Stmt *LastStmt = getLastStmt(*P);
1116 if (const AttributedStmt *AS = asFallThroughAttr(LastStmt)) {
1117 markFallthroughVisited(AS);
1118 ++AnnotatedCnt;
1119 continue; // Fallthrough annotation, good.
1120 }
1121
1122 if (!LastStmt) { // This block contains no executable statements.
1123 // Traverse its predecessors.
1124 std::copy(P->pred_begin(), P->pred_end(),
1125 std::back_inserter(BlockQueue));
1126 continue;
1127 }
1128
1129 ++UnannotatedCnt;
1130 }
1131 return !!UnannotatedCnt;
1132 }
1133
1134 // RecursiveASTVisitor setup.
1135 bool shouldWalkTypesOfTypeLocs() const { return false; }
1136
1137 bool VisitAttributedStmt(AttributedStmt *S) {
1138 if (asFallThroughAttr(S))
1139 FallthroughStmts.insert(S);
1140 return true;
1141 }
1142
1143 bool VisitSwitchStmt(SwitchStmt *S) {
1144 FoundSwitchStatements = true;
1145 return true;
1146 }
1147
Alexander Kornienkoa9c809f2013-04-02 15:20:32 +00001148 // We don't want to traverse local type declarations. We analyze their
1149 // methods separately.
1150 bool TraverseDecl(Decl *D) { return true; }
1151
Alexander Kornienkobf911642014-06-24 15:28:21 +00001152 // We analyze lambda bodies separately. Skip them here.
1153 bool TraverseLambdaBody(LambdaExpr *LE) { return true; }
1154
Richard Smith84837d52012-05-03 18:27:39 +00001155 private:
1156
1157 static const AttributedStmt *asFallThroughAttr(const Stmt *S) {
1158 if (const AttributedStmt *AS = dyn_cast_or_null<AttributedStmt>(S)) {
1159 if (hasSpecificAttr<FallThroughAttr>(AS->getAttrs()))
1160 return AS;
1161 }
Craig Topperc3ec1492014-05-26 06:22:03 +00001162 return nullptr;
Richard Smith84837d52012-05-03 18:27:39 +00001163 }
1164
1165 static const Stmt *getLastStmt(const CFGBlock &B) {
1166 if (const Stmt *Term = B.getTerminator())
1167 return Term;
1168 for (CFGBlock::const_reverse_iterator ElemIt = B.rbegin(),
1169 ElemEnd = B.rend();
1170 ElemIt != ElemEnd; ++ElemIt) {
David Blaikie00be69a2013-02-23 00:29:34 +00001171 if (Optional<CFGStmt> CS = ElemIt->getAs<CFGStmt>())
1172 return CS->getStmt();
Richard Smith84837d52012-05-03 18:27:39 +00001173 }
1174 // Workaround to detect a statement thrown out by CFGBuilder:
1175 // case X: {} case Y:
1176 // case X: ; case Y:
1177 if (const SwitchCase *SW = dyn_cast_or_null<SwitchCase>(B.getLabel()))
1178 if (!isa<SwitchCase>(SW->getSubStmt()))
1179 return SW->getSubStmt();
1180
Craig Topperc3ec1492014-05-26 06:22:03 +00001181 return nullptr;
Richard Smith84837d52012-05-03 18:27:39 +00001182 }
1183
1184 bool FoundSwitchStatements;
1185 AttrStmts FallthroughStmts;
1186 Sema &S;
Alexander Kornienkoafed1dd2013-01-30 03:49:44 +00001187 llvm::SmallPtrSet<const CFGBlock *, 16> ReachableBlocks;
Richard Smith84837d52012-05-03 18:27:39 +00001188 };
Hans Wennborgdcfba332015-10-06 23:40:43 +00001189} // anonymous namespace
Richard Smith84837d52012-05-03 18:27:39 +00001190
Richard Smith4f902c72016-03-08 00:32:55 +00001191static StringRef getFallthroughAttrSpelling(Preprocessor &PP,
1192 SourceLocation Loc) {
1193 TokenValue FallthroughTokens[] = {
1194 tok::l_square, tok::l_square,
1195 PP.getIdentifierInfo("fallthrough"),
1196 tok::r_square, tok::r_square
1197 };
1198
1199 TokenValue ClangFallthroughTokens[] = {
1200 tok::l_square, tok::l_square, PP.getIdentifierInfo("clang"),
1201 tok::coloncolon, PP.getIdentifierInfo("fallthrough"),
1202 tok::r_square, tok::r_square
1203 };
1204
Aaron Ballmanc351fba2017-12-04 20:27:34 +00001205 bool PreferClangAttr = !PP.getLangOpts().CPlusPlus17;
Richard Smith4f902c72016-03-08 00:32:55 +00001206
1207 StringRef MacroName;
1208 if (PreferClangAttr)
1209 MacroName = PP.getLastMacroWithSpelling(Loc, ClangFallthroughTokens);
1210 if (MacroName.empty())
1211 MacroName = PP.getLastMacroWithSpelling(Loc, FallthroughTokens);
1212 if (MacroName.empty() && !PreferClangAttr)
1213 MacroName = PP.getLastMacroWithSpelling(Loc, ClangFallthroughTokens);
1214 if (MacroName.empty())
1215 MacroName = PreferClangAttr ? "[[clang::fallthrough]]" : "[[fallthrough]]";
1216 return MacroName;
1217}
1218
Alexander Kornienko06caf7d2012-06-02 01:01:07 +00001219static void DiagnoseSwitchLabelsFallthrough(Sema &S, AnalysisDeclContext &AC,
Alexis Hunt2178f142012-06-15 21:22:05 +00001220 bool PerFunction) {
Aaron Ballman8c6b1a32017-10-18 14:33:27 +00001221 // Only perform this analysis when using [[]] attributes. There is no good
1222 // workflow for this warning when not using C++11. There is no good way to
1223 // silence the warning (no attribute is available) unless we are using
1224 // [[]] attributes. One could use pragmas to silence the warning, but as a
1225 // general solution that is gross and not in the spirit of this warning.
Ted Kremenekda5919f2012-11-12 21:20:48 +00001226 //
Aaron Ballman8c6b1a32017-10-18 14:33:27 +00001227 // NOTE: This an intermediate solution. There are on-going discussions on
Ted Kremenekda5919f2012-11-12 21:20:48 +00001228 // how to properly support this warning outside of C++11 with an annotation.
Aaron Ballman8c6b1a32017-10-18 14:33:27 +00001229 if (!AC.getASTContext().getLangOpts().DoubleSquareBracketAttributes)
Ted Kremenekda5919f2012-11-12 21:20:48 +00001230 return;
1231
Richard Smith84837d52012-05-03 18:27:39 +00001232 FallthroughMapper FM(S);
1233 FM.TraverseStmt(AC.getBody());
1234
1235 if (!FM.foundSwitchStatements())
1236 return;
1237
Alexis Hunt2178f142012-06-15 21:22:05 +00001238 if (PerFunction && FM.getFallthroughStmts().empty())
Alexander Kornienko06caf7d2012-06-02 01:01:07 +00001239 return;
1240
Richard Smith84837d52012-05-03 18:27:39 +00001241 CFG *Cfg = AC.getCFG();
1242
1243 if (!Cfg)
1244 return;
1245
Alexander Kornienkoafed1dd2013-01-30 03:49:44 +00001246 FM.fillReachableBlocks(Cfg);
Richard Smith84837d52012-05-03 18:27:39 +00001247
Pete Cooper57d3f142015-07-30 17:22:52 +00001248 for (const CFGBlock *B : llvm::reverse(*Cfg)) {
Alexander Kornienko55488792013-01-25 15:49:34 +00001249 const Stmt *Label = B->getLabel();
Richard Smith84837d52012-05-03 18:27:39 +00001250
1251 if (!Label || !isa<SwitchCase>(Label))
1252 continue;
1253
Alexander Kornienkoafed1dd2013-01-30 03:49:44 +00001254 int AnnotatedCnt;
1255
Richard Smith7532d372017-03-22 01:49:19 +00001256 bool IsTemplateInstantiation = false;
1257 if (const FunctionDecl *Function = dyn_cast<FunctionDecl>(AC.getDecl()))
1258 IsTemplateInstantiation = Function->isTemplateInstantiation();
1259 if (!FM.checkFallThroughIntoBlock(*B, AnnotatedCnt,
1260 IsTemplateInstantiation))
Richard Smith84837d52012-05-03 18:27:39 +00001261 continue;
1262
Alexander Kornienko06caf7d2012-06-02 01:01:07 +00001263 S.Diag(Label->getLocStart(),
Alexis Hunt2178f142012-06-15 21:22:05 +00001264 PerFunction ? diag::warn_unannotated_fallthrough_per_function
1265 : diag::warn_unannotated_fallthrough);
Richard Smith84837d52012-05-03 18:27:39 +00001266
1267 if (!AnnotatedCnt) {
1268 SourceLocation L = Label->getLocStart();
1269 if (L.isMacroID())
1270 continue;
Richard Smith2bf7fdb2013-01-02 11:42:31 +00001271 if (S.getLangOpts().CPlusPlus11) {
Alexander Kornienko55488792013-01-25 15:49:34 +00001272 const Stmt *Term = B->getTerminator();
1273 // Skip empty cases.
1274 while (B->empty() && !Term && B->succ_size() == 1) {
1275 B = *B->succ_begin();
1276 Term = B->getTerminator();
1277 }
1278 if (!(B->empty() && Term && isa<BreakStmt>(Term))) {
Alexander Kornienkoe61e5622012-09-28 22:24:03 +00001279 Preprocessor &PP = S.getPreprocessor();
Richard Smith4f902c72016-03-08 00:32:55 +00001280 StringRef AnnotationSpelling = getFallthroughAttrSpelling(PP, L);
Dmitri Gribenko6743e042012-09-29 11:40:46 +00001281 SmallString<64> TextToInsert(AnnotationSpelling);
1282 TextToInsert += "; ";
Alexander Kornienko246e85d2012-05-26 00:49:15 +00001283 S.Diag(L, diag::note_insert_fallthrough_fixit) <<
Alexander Kornienkoe61e5622012-09-28 22:24:03 +00001284 AnnotationSpelling <<
Dmitri Gribenko6743e042012-09-29 11:40:46 +00001285 FixItHint::CreateInsertion(L, TextToInsert);
Alexander Kornienko246e85d2012-05-26 00:49:15 +00001286 }
Richard Smith84837d52012-05-03 18:27:39 +00001287 }
1288 S.Diag(L, diag::note_insert_break_fixit) <<
1289 FixItHint::CreateInsertion(L, "break; ");
1290 }
1291 }
1292
Aaron Ballmane5195222014-05-15 20:50:47 +00001293 for (const auto *F : FM.getFallthroughStmts())
Richard Smith4f902c72016-03-08 00:32:55 +00001294 S.Diag(F->getLocStart(), diag::err_fallthrough_attr_invalid_placement);
Richard Smith84837d52012-05-03 18:27:39 +00001295}
1296
Jordan Rose25c0ea82012-10-29 17:46:47 +00001297static bool isInLoop(const ASTContext &Ctx, const ParentMap &PM,
1298 const Stmt *S) {
Jordan Rose76831c62012-10-11 16:10:19 +00001299 assert(S);
1300
1301 do {
1302 switch (S->getStmtClass()) {
Jordan Rose76831c62012-10-11 16:10:19 +00001303 case Stmt::ForStmtClass:
1304 case Stmt::WhileStmtClass:
1305 case Stmt::CXXForRangeStmtClass:
1306 case Stmt::ObjCForCollectionStmtClass:
1307 return true;
Jordan Rose25c0ea82012-10-29 17:46:47 +00001308 case Stmt::DoStmtClass: {
1309 const Expr *Cond = cast<DoStmt>(S)->getCond();
1310 llvm::APSInt Val;
1311 if (!Cond->EvaluateAsInt(Val, Ctx))
1312 return true;
1313 return Val.getBoolValue();
1314 }
Jordan Rose76831c62012-10-11 16:10:19 +00001315 default:
1316 break;
1317 }
1318 } while ((S = PM.getParent(S)));
1319
1320 return false;
1321}
1322
Jordan Rosed3934582012-09-28 22:21:30 +00001323static void diagnoseRepeatedUseOfWeak(Sema &S,
1324 const sema::FunctionScopeInfo *CurFn,
Jordan Rose76831c62012-10-11 16:10:19 +00001325 const Decl *D,
1326 const ParentMap &PM) {
Jordan Rosed3934582012-09-28 22:21:30 +00001327 typedef sema::FunctionScopeInfo::WeakObjectProfileTy WeakObjectProfileTy;
1328 typedef sema::FunctionScopeInfo::WeakObjectUseMap WeakObjectUseMap;
1329 typedef sema::FunctionScopeInfo::WeakUseVector WeakUseVector;
Benjamin Kramerbbdd7642014-03-01 14:48:57 +00001330 typedef std::pair<const Stmt *, WeakObjectUseMap::const_iterator>
1331 StmtUsesPair;
Jordan Rosed3934582012-09-28 22:21:30 +00001332
Jordan Rose25c0ea82012-10-29 17:46:47 +00001333 ASTContext &Ctx = S.getASTContext();
1334
Jordan Rosed3934582012-09-28 22:21:30 +00001335 const WeakObjectUseMap &WeakMap = CurFn->getWeakObjectUses();
1336
1337 // Extract all weak objects that are referenced more than once.
1338 SmallVector<StmtUsesPair, 8> UsesByStmt;
1339 for (WeakObjectUseMap::const_iterator I = WeakMap.begin(), E = WeakMap.end();
1340 I != E; ++I) {
1341 const WeakUseVector &Uses = I->second;
Jordan Rosed3934582012-09-28 22:21:30 +00001342
1343 // Find the first read of the weak object.
1344 WeakUseVector::const_iterator UI = Uses.begin(), UE = Uses.end();
1345 for ( ; UI != UE; ++UI) {
1346 if (UI->isUnsafe())
1347 break;
1348 }
1349
1350 // If there were only writes to this object, don't warn.
1351 if (UI == UE)
1352 continue;
1353
Jordan Rose76831c62012-10-11 16:10:19 +00001354 // If there was only one read, followed by any number of writes, and the
Jordan Rose25c0ea82012-10-29 17:46:47 +00001355 // read is not within a loop, don't warn. Additionally, don't warn in a
1356 // loop if the base object is a local variable -- local variables are often
1357 // changed in loops.
Jordan Rose76831c62012-10-11 16:10:19 +00001358 if (UI == Uses.begin()) {
1359 WeakUseVector::const_iterator UI2 = UI;
1360 for (++UI2; UI2 != UE; ++UI2)
1361 if (UI2->isUnsafe())
1362 break;
1363
Jordan Rose25c0ea82012-10-29 17:46:47 +00001364 if (UI2 == UE) {
1365 if (!isInLoop(Ctx, PM, UI->getUseExpr()))
Jordan Rose76831c62012-10-11 16:10:19 +00001366 continue;
Jordan Rose25c0ea82012-10-29 17:46:47 +00001367
1368 const WeakObjectProfileTy &Profile = I->first;
1369 if (!Profile.isExactProfile())
1370 continue;
1371
1372 const NamedDecl *Base = Profile.getBase();
1373 if (!Base)
1374 Base = Profile.getProperty();
1375 assert(Base && "A profile always has a base or property.");
1376
1377 if (const VarDecl *BaseVar = dyn_cast<VarDecl>(Base))
1378 if (BaseVar->hasLocalStorage() && !isa<ParmVarDecl>(Base))
1379 continue;
1380 }
Jordan Rose76831c62012-10-11 16:10:19 +00001381 }
1382
Jordan Rosed3934582012-09-28 22:21:30 +00001383 UsesByStmt.push_back(StmtUsesPair(UI->getUseExpr(), I));
1384 }
1385
1386 if (UsesByStmt.empty())
1387 return;
1388
1389 // Sort by first use so that we emit the warnings in a deterministic order.
Benjamin Kramerbbdd7642014-03-01 14:48:57 +00001390 SourceManager &SM = S.getSourceManager();
Jordan Rosed3934582012-09-28 22:21:30 +00001391 std::sort(UsesByStmt.begin(), UsesByStmt.end(),
Benjamin Kramerbbdd7642014-03-01 14:48:57 +00001392 [&SM](const StmtUsesPair &LHS, const StmtUsesPair &RHS) {
1393 return SM.isBeforeInTranslationUnit(LHS.first->getLocStart(),
1394 RHS.first->getLocStart());
1395 });
Jordan Rosed3934582012-09-28 22:21:30 +00001396
1397 // Classify the current code body for better warning text.
1398 // This enum should stay in sync with the cases in
1399 // warn_arc_repeated_use_of_weak and warn_arc_possible_repeated_use_of_weak.
1400 // FIXME: Should we use a common classification enum and the same set of
1401 // possibilities all throughout Sema?
1402 enum {
1403 Function,
1404 Method,
1405 Block,
1406 Lambda
1407 } FunctionKind;
1408
1409 if (isa<sema::BlockScopeInfo>(CurFn))
1410 FunctionKind = Block;
1411 else if (isa<sema::LambdaScopeInfo>(CurFn))
1412 FunctionKind = Lambda;
1413 else if (isa<ObjCMethodDecl>(D))
1414 FunctionKind = Method;
1415 else
1416 FunctionKind = Function;
1417
1418 // Iterate through the sorted problems and emit warnings for each.
Aaron Ballmane5195222014-05-15 20:50:47 +00001419 for (const auto &P : UsesByStmt) {
1420 const Stmt *FirstRead = P.first;
1421 const WeakObjectProfileTy &Key = P.second->first;
1422 const WeakUseVector &Uses = P.second->second;
Jordan Rosed3934582012-09-28 22:21:30 +00001423
Jordan Rose657b5f42012-09-28 22:21:35 +00001424 // For complicated expressions like 'a.b.c' and 'x.b.c', WeakObjectProfileTy
1425 // may not contain enough information to determine that these are different
1426 // properties. We can only be 100% sure of a repeated use in certain cases,
1427 // and we adjust the diagnostic kind accordingly so that the less certain
1428 // case can be turned off if it is too noisy.
Jordan Rosed3934582012-09-28 22:21:30 +00001429 unsigned DiagKind;
1430 if (Key.isExactProfile())
1431 DiagKind = diag::warn_arc_repeated_use_of_weak;
1432 else
1433 DiagKind = diag::warn_arc_possible_repeated_use_of_weak;
1434
Jordan Rose657b5f42012-09-28 22:21:35 +00001435 // Classify the weak object being accessed for better warning text.
1436 // This enum should stay in sync with the cases in
1437 // warn_arc_repeated_use_of_weak and warn_arc_possible_repeated_use_of_weak.
1438 enum {
1439 Variable,
1440 Property,
1441 ImplicitProperty,
1442 Ivar
1443 } ObjectKind;
1444
Bob Wilson34cc8eb2016-05-25 05:42:00 +00001445 const NamedDecl *KeyProp = Key.getProperty();
1446 if (isa<VarDecl>(KeyProp))
Jordan Rose657b5f42012-09-28 22:21:35 +00001447 ObjectKind = Variable;
Bob Wilson34cc8eb2016-05-25 05:42:00 +00001448 else if (isa<ObjCPropertyDecl>(KeyProp))
Jordan Rose657b5f42012-09-28 22:21:35 +00001449 ObjectKind = Property;
Bob Wilson34cc8eb2016-05-25 05:42:00 +00001450 else if (isa<ObjCMethodDecl>(KeyProp))
Jordan Rose657b5f42012-09-28 22:21:35 +00001451 ObjectKind = ImplicitProperty;
Bob Wilson34cc8eb2016-05-25 05:42:00 +00001452 else if (isa<ObjCIvarDecl>(KeyProp))
Jordan Rose657b5f42012-09-28 22:21:35 +00001453 ObjectKind = Ivar;
1454 else
1455 llvm_unreachable("Unexpected weak object kind!");
1456
Bob Wilsonf4f54e32016-05-25 05:41:57 +00001457 // Do not warn about IBOutlet weak property receivers being set to null
1458 // since they are typically only used from the main thread.
Bob Wilson34cc8eb2016-05-25 05:42:00 +00001459 if (const ObjCPropertyDecl *Prop = dyn_cast<ObjCPropertyDecl>(KeyProp))
Bob Wilsonf4f54e32016-05-25 05:41:57 +00001460 if (Prop->hasAttr<IBOutletAttr>())
1461 continue;
1462
Jordan Rosed3934582012-09-28 22:21:30 +00001463 // Show the first time the object was read.
1464 S.Diag(FirstRead->getLocStart(), DiagKind)
Bob Wilson34cc8eb2016-05-25 05:42:00 +00001465 << int(ObjectKind) << KeyProp << int(FunctionKind)
Jordan Rosed3934582012-09-28 22:21:30 +00001466 << FirstRead->getSourceRange();
1467
1468 // Print all the other accesses as notes.
Aaron Ballmane5195222014-05-15 20:50:47 +00001469 for (const auto &Use : Uses) {
1470 if (Use.getUseExpr() == FirstRead)
Jordan Rosed3934582012-09-28 22:21:30 +00001471 continue;
Aaron Ballmane5195222014-05-15 20:50:47 +00001472 S.Diag(Use.getUseExpr()->getLocStart(),
Jordan Rosed3934582012-09-28 22:21:30 +00001473 diag::note_arc_weak_also_accessed_here)
Aaron Ballmane5195222014-05-15 20:50:47 +00001474 << Use.getUseExpr()->getSourceRange();
Jordan Rosed3934582012-09-28 22:21:30 +00001475 }
1476 }
1477}
1478
Jordan Rosed3934582012-09-28 22:21:30 +00001479namespace {
Ted Kremenekb749a6d2011-01-15 02:58:47 +00001480class UninitValsDiagReporter : public UninitVariablesHandler {
1481 Sema &S;
Chris Lattner0e62c1c2011-07-23 10:55:15 +00001482 typedef SmallVector<UninitUse, 2> UsesVec;
Benjamin Kramereb8c4462013-06-29 17:52:13 +00001483 typedef llvm::PointerIntPair<UsesVec *, 1, bool> MappedType;
Enea Zaffanella2f40be72013-02-15 20:09:55 +00001484 // Prefer using MapVector to DenseMap, so that iteration order will be
1485 // the same as insertion order. This is needed to obtain a deterministic
1486 // order of diagnostics when calling flushDiagnostics().
1487 typedef llvm::MapVector<const VarDecl *, MappedType> UsesMap;
George Burgess IV0fc4e8b2015-12-10 19:25:21 +00001488 UsesMap uses;
Ted Kremenek39fa0562011-01-21 19:41:41 +00001489
Ted Kremenekb749a6d2011-01-15 02:58:47 +00001490public:
George Burgess IV0fc4e8b2015-12-10 19:25:21 +00001491 UninitValsDiagReporter(Sema &S) : S(S) {}
Alexander Kornienko34eb2072015-04-11 02:00:23 +00001492 ~UninitValsDiagReporter() override { flushDiagnostics(); }
Ted Kremenek596fa162011-10-13 18:50:06 +00001493
Enea Zaffanella2f40be72013-02-15 20:09:55 +00001494 MappedType &getUses(const VarDecl *vd) {
George Burgess IV0fc4e8b2015-12-10 19:25:21 +00001495 MappedType &V = uses[vd];
Benjamin Kramereb8c4462013-06-29 17:52:13 +00001496 if (!V.getPointer())
1497 V.setPointer(new UsesVec());
Ted Kremenek596fa162011-10-13 18:50:06 +00001498 return V;
1499 }
Craig Toppere14c0f82014-03-12 04:55:44 +00001500
1501 void handleUseOfUninitVariable(const VarDecl *vd,
1502 const UninitUse &use) override {
Benjamin Kramereb8c4462013-06-29 17:52:13 +00001503 getUses(vd).getPointer()->push_back(use);
Ted Kremenek596fa162011-10-13 18:50:06 +00001504 }
1505
Craig Toppere14c0f82014-03-12 04:55:44 +00001506 void handleSelfInit(const VarDecl *vd) override {
Benjamin Kramereb8c4462013-06-29 17:52:13 +00001507 getUses(vd).setInt(true);
Ted Kremenek39fa0562011-01-21 19:41:41 +00001508 }
1509
1510 void flushDiagnostics() {
George Burgess IV0fc4e8b2015-12-10 19:25:21 +00001511 for (const auto &P : uses) {
Aaron Ballmane5195222014-05-15 20:50:47 +00001512 const VarDecl *vd = P.first;
1513 const MappedType &V = P.second;
Ted Kremenekb3dbe282011-02-02 23:35:53 +00001514
Benjamin Kramereb8c4462013-06-29 17:52:13 +00001515 UsesVec *vec = V.getPointer();
1516 bool hasSelfInit = V.getInt();
Ted Kremenek596fa162011-10-13 18:50:06 +00001517
1518 // Specially handle the case where we have uses of an uninitialized
1519 // variable, but the root cause is an idiomatic self-init. We want
1520 // to report the diagnostic at the self-init since that is the root cause.
Matt Beaumont-Gay4b489fa2011-10-19 18:53:03 +00001521 if (!vec->empty() && hasSelfInit && hasAlwaysUninitializedUse(vec))
Richard Smith4323bf82012-05-25 02:17:09 +00001522 DiagnoseUninitializedUse(S, vd,
1523 UninitUse(vd->getInit()->IgnoreParenCasts(),
1524 /* isAlwaysUninit */ true),
Matt Beaumont-Gay4b489fa2011-10-19 18:53:03 +00001525 /* alwaysReportSelfInit */ true);
Ted Kremenek596fa162011-10-13 18:50:06 +00001526 else {
1527 // Sort the uses by their SourceLocations. While not strictly
1528 // guaranteed to produce them in line/column order, this will provide
1529 // a stable ordering.
Benjamin Kramerbbdd7642014-03-01 14:48:57 +00001530 std::sort(vec->begin(), vec->end(),
1531 [](const UninitUse &a, const UninitUse &b) {
1532 // Prefer a more confident report over a less confident one.
1533 if (a.getKind() != b.getKind())
1534 return a.getKind() > b.getKind();
1535 return a.getUser()->getLocStart() < b.getUser()->getLocStart();
1536 });
1537
Aaron Ballmane5195222014-05-15 20:50:47 +00001538 for (const auto &U : *vec) {
Richard Smith4323bf82012-05-25 02:17:09 +00001539 // If we have self-init, downgrade all uses to 'may be uninitialized'.
Aaron Ballmane5195222014-05-15 20:50:47 +00001540 UninitUse Use = hasSelfInit ? UninitUse(U.getUser(), false) : U;
Richard Smith4323bf82012-05-25 02:17:09 +00001541
1542 if (DiagnoseUninitializedUse(S, vd, Use))
Ted Kremenek596fa162011-10-13 18:50:06 +00001543 // Skip further diagnostics for this variable. We try to warn only
1544 // on the first point at which a variable is used uninitialized.
1545 break;
1546 }
Chandler Carruth7a037202011-04-05 18:18:08 +00001547 }
Ted Kremenek596fa162011-10-13 18:50:06 +00001548
1549 // Release the uses vector.
Ted Kremenek39fa0562011-01-21 19:41:41 +00001550 delete vec;
1551 }
George Burgess IV0fc4e8b2015-12-10 19:25:21 +00001552
1553 uses.clear();
Ted Kremenekb749a6d2011-01-15 02:58:47 +00001554 }
Matt Beaumont-Gay4b489fa2011-10-19 18:53:03 +00001555
1556private:
1557 static bool hasAlwaysUninitializedUse(const UsesVec* vec) {
Aaron Ballmane5195222014-05-15 20:50:47 +00001558 return std::any_of(vec->begin(), vec->end(), [](const UninitUse &U) {
1559 return U.getKind() == UninitUse::Always ||
1560 U.getKind() == UninitUse::AfterCall ||
1561 U.getKind() == UninitUse::AfterDecl;
1562 });
Matt Beaumont-Gay4b489fa2011-10-19 18:53:03 +00001563 }
Ted Kremenekb749a6d2011-01-15 02:58:47 +00001564};
Hans Wennborgdcfba332015-10-06 23:40:43 +00001565} // anonymous namespace
Ted Kremenekb749a6d2011-01-15 02:58:47 +00001566
Caitlin Sadowski0b3501c2011-09-09 16:04:02 +00001567namespace clang {
DeLesley Hutchins48a31762013-08-12 21:20:55 +00001568namespace {
Dmitri Gribenkof8579502013-01-12 19:30:44 +00001569typedef SmallVector<PartialDiagnosticAt, 1> OptionalNotes;
Richard Smith92286672012-02-03 04:45:26 +00001570typedef std::pair<PartialDiagnosticAt, OptionalNotes> DelayedDiag;
Benjamin Kramer40b099b2012-03-26 14:05:40 +00001571typedef std::list<DelayedDiag> DiagList;
Caitlin Sadowski0b3501c2011-09-09 16:04:02 +00001572
Caitlin Sadowski0b3501c2011-09-09 16:04:02 +00001573struct SortDiagBySourceLocation {
Benjamin Kramer40b099b2012-03-26 14:05:40 +00001574 SourceManager &SM;
1575 SortDiagBySourceLocation(SourceManager &SM) : SM(SM) {}
Caitlin Sadowski0b3501c2011-09-09 16:04:02 +00001576
1577 bool operator()(const DelayedDiag &left, const DelayedDiag &right) {
1578 // Although this call will be slow, this is only called when outputting
1579 // multiple warnings.
Benjamin Kramer40b099b2012-03-26 14:05:40 +00001580 return SM.isBeforeInTranslationUnit(left.first.first, right.first.first);
Caitlin Sadowski0b3501c2011-09-09 16:04:02 +00001581 }
1582};
Hans Wennborgdcfba332015-10-06 23:40:43 +00001583} // anonymous namespace
1584} // namespace clang
Caitlin Sadowski0b3501c2011-09-09 16:04:02 +00001585
DeLesley Hutchins48a31762013-08-12 21:20:55 +00001586//===----------------------------------------------------------------------===//
1587// -Wthread-safety
1588//===----------------------------------------------------------------------===//
1589namespace clang {
DeLesley Hutchinsea1f8332014-07-28 15:57:27 +00001590namespace threadSafety {
Benjamin Kramer539803c2015-03-19 14:23:45 +00001591namespace {
DeLesley Hutchinsea1f8332014-07-28 15:57:27 +00001592class ThreadSafetyReporter : public clang::threadSafety::ThreadSafetyHandler {
Caitlin Sadowski0b3501c2011-09-09 16:04:02 +00001593 Sema &S;
1594 DiagList Warnings;
Richard Smith92286672012-02-03 04:45:26 +00001595 SourceLocation FunLocation, FunEndLocation;
Caitlin Sadowski0b3501c2011-09-09 16:04:02 +00001596
DeLesley Hutchinseb0ea5f2014-08-14 21:40:15 +00001597 const FunctionDecl *CurrentFunction;
1598 bool Verbose;
1599
Aaron Ballman71291bc2014-08-15 12:38:17 +00001600 OptionalNotes getNotes() const {
DeLesley Hutchinseb0ea5f2014-08-14 21:40:15 +00001601 if (Verbose && CurrentFunction) {
1602 PartialDiagnosticAt FNote(CurrentFunction->getBody()->getLocStart(),
Aaron Ballman71291bc2014-08-15 12:38:17 +00001603 S.PDiag(diag::note_thread_warning_in_fun)
1604 << CurrentFunction->getNameAsString());
DeLesley Hutchinseb0ea5f2014-08-14 21:40:15 +00001605 return OptionalNotes(1, FNote);
1606 }
Aaron Ballman71291bc2014-08-15 12:38:17 +00001607 return OptionalNotes();
DeLesley Hutchinseb0ea5f2014-08-14 21:40:15 +00001608 }
1609
Aaron Ballman71291bc2014-08-15 12:38:17 +00001610 OptionalNotes getNotes(const PartialDiagnosticAt &Note) const {
DeLesley Hutchinseb0ea5f2014-08-14 21:40:15 +00001611 OptionalNotes ONS(1, Note);
1612 if (Verbose && CurrentFunction) {
1613 PartialDiagnosticAt FNote(CurrentFunction->getBody()->getLocStart(),
Aaron Ballman71291bc2014-08-15 12:38:17 +00001614 S.PDiag(diag::note_thread_warning_in_fun)
1615 << CurrentFunction->getNameAsString());
Benjamin Kramer3204b152015-05-29 19:42:19 +00001616 ONS.push_back(std::move(FNote));
DeLesley Hutchinseb0ea5f2014-08-14 21:40:15 +00001617 }
1618 return ONS;
1619 }
1620
DeLesley Hutchinsc60dc2c2014-09-18 23:02:26 +00001621 OptionalNotes getNotes(const PartialDiagnosticAt &Note1,
1622 const PartialDiagnosticAt &Note2) const {
1623 OptionalNotes ONS;
1624 ONS.push_back(Note1);
1625 ONS.push_back(Note2);
1626 if (Verbose && CurrentFunction) {
1627 PartialDiagnosticAt FNote(CurrentFunction->getBody()->getLocStart(),
1628 S.PDiag(diag::note_thread_warning_in_fun)
1629 << CurrentFunction->getNameAsString());
Benjamin Kramer3204b152015-05-29 19:42:19 +00001630 ONS.push_back(std::move(FNote));
DeLesley Hutchinsc60dc2c2014-09-18 23:02:26 +00001631 }
1632 return ONS;
1633 }
1634
Caitlin Sadowski0b3501c2011-09-09 16:04:02 +00001635 // Helper functions
Aaron Ballmane0449042014-04-01 21:43:23 +00001636 void warnLockMismatch(unsigned DiagID, StringRef Kind, Name LockName,
1637 SourceLocation Loc) {
DeLesley Hutchinsc2090512011-10-21 18:10:14 +00001638 // Gracefully handle rare cases when the analysis can't get a more
1639 // precise source location.
1640 if (!Loc.isValid())
1641 Loc = FunLocation;
Aaron Ballmane0449042014-04-01 21:43:23 +00001642 PartialDiagnosticAt Warning(Loc, S.PDiag(DiagID) << Kind << LockName);
Benjamin Kramer3204b152015-05-29 19:42:19 +00001643 Warnings.emplace_back(std::move(Warning), getNotes());
Caitlin Sadowski0b3501c2011-09-09 16:04:02 +00001644 }
1645
1646 public:
Richard Smith92286672012-02-03 04:45:26 +00001647 ThreadSafetyReporter(Sema &S, SourceLocation FL, SourceLocation FEL)
DeLesley Hutchinseb0ea5f2014-08-14 21:40:15 +00001648 : S(S), FunLocation(FL), FunEndLocation(FEL),
1649 CurrentFunction(nullptr), Verbose(false) {}
1650
1651 void setVerbose(bool b) { Verbose = b; }
Caitlin Sadowski0b3501c2011-09-09 16:04:02 +00001652
1653 /// \brief Emit all buffered diagnostics in order of sourcelocation.
1654 /// We need to output diagnostics produced while iterating through
1655 /// the lockset in deterministic order, so this function orders diagnostics
1656 /// and outputs them.
1657 void emitDiagnostics() {
Benjamin Kramer40b099b2012-03-26 14:05:40 +00001658 Warnings.sort(SortDiagBySourceLocation(S.getSourceManager()));
Aaron Ballmane5195222014-05-15 20:50:47 +00001659 for (const auto &Diag : Warnings) {
1660 S.Diag(Diag.first.first, Diag.first.second);
1661 for (const auto &Note : Diag.second)
1662 S.Diag(Note.first, Note.second);
Richard Smith92286672012-02-03 04:45:26 +00001663 }
Caitlin Sadowski0b3501c2011-09-09 16:04:02 +00001664 }
1665
Aaron Ballmane0449042014-04-01 21:43:23 +00001666 void handleInvalidLockExp(StringRef Kind, SourceLocation Loc) override {
1667 PartialDiagnosticAt Warning(Loc, S.PDiag(diag::warn_cannot_resolve_lock)
1668 << Loc);
Benjamin Kramer3204b152015-05-29 19:42:19 +00001669 Warnings.emplace_back(std::move(Warning), getNotes());
Caitlin Sadowskiff2f3f82011-09-09 16:21:55 +00001670 }
DeLesley Hutchinseb0ea5f2014-08-14 21:40:15 +00001671
Aaron Ballmane0449042014-04-01 21:43:23 +00001672 void handleUnmatchedUnlock(StringRef Kind, Name LockName,
1673 SourceLocation Loc) override {
1674 warnLockMismatch(diag::warn_unlock_but_no_lock, Kind, LockName, Loc);
Caitlin Sadowski0b3501c2011-09-09 16:04:02 +00001675 }
DeLesley Hutchinseb0ea5f2014-08-14 21:40:15 +00001676
Aaron Ballmane0449042014-04-01 21:43:23 +00001677 void handleIncorrectUnlockKind(StringRef Kind, Name LockName,
1678 LockKind Expected, LockKind Received,
Aaron Ballmandf115d92014-03-21 14:48:48 +00001679 SourceLocation Loc) override {
1680 if (Loc.isInvalid())
1681 Loc = FunLocation;
1682 PartialDiagnosticAt Warning(Loc, S.PDiag(diag::warn_unlock_kind_mismatch)
Aaron Ballmane0449042014-04-01 21:43:23 +00001683 << Kind << LockName << Received
1684 << Expected);
Benjamin Kramer3204b152015-05-29 19:42:19 +00001685 Warnings.emplace_back(std::move(Warning), getNotes());
Aaron Ballmandf115d92014-03-21 14:48:48 +00001686 }
DeLesley Hutchinseb0ea5f2014-08-14 21:40:15 +00001687
Aaron Ballmane0449042014-04-01 21:43:23 +00001688 void handleDoubleLock(StringRef Kind, Name LockName, SourceLocation Loc) override {
1689 warnLockMismatch(diag::warn_double_lock, Kind, LockName, Loc);
Caitlin Sadowski0b3501c2011-09-09 16:04:02 +00001690 }
1691
Aaron Ballmane0449042014-04-01 21:43:23 +00001692 void handleMutexHeldEndOfScope(StringRef Kind, Name LockName,
1693 SourceLocation LocLocked,
Richard Smith92286672012-02-03 04:45:26 +00001694 SourceLocation LocEndOfScope,
Craig Toppere14c0f82014-03-12 04:55:44 +00001695 LockErrorKind LEK) override {
Caitlin Sadowskiaf9b7c52011-09-15 17:25:19 +00001696 unsigned DiagID = 0;
1697 switch (LEK) {
1698 case LEK_LockedSomePredecessors:
Richard Smith92286672012-02-03 04:45:26 +00001699 DiagID = diag::warn_lock_some_predecessors;
Caitlin Sadowskiaf9b7c52011-09-15 17:25:19 +00001700 break;
1701 case LEK_LockedSomeLoopIterations:
1702 DiagID = diag::warn_expecting_lock_held_on_loop;
1703 break;
1704 case LEK_LockedAtEndOfFunction:
1705 DiagID = diag::warn_no_unlock;
1706 break;
DeLesley Hutchins6e6dbb72012-07-02 22:16:54 +00001707 case LEK_NotLockedAtEndOfFunction:
1708 DiagID = diag::warn_expecting_locked;
1709 break;
Caitlin Sadowskiaf9b7c52011-09-15 17:25:19 +00001710 }
Richard Smith92286672012-02-03 04:45:26 +00001711 if (LocEndOfScope.isInvalid())
1712 LocEndOfScope = FunEndLocation;
1713
Aaron Ballmane0449042014-04-01 21:43:23 +00001714 PartialDiagnosticAt Warning(LocEndOfScope, S.PDiag(DiagID) << Kind
1715 << LockName);
DeLesley Hutchinsfd374bb2013-04-08 20:11:11 +00001716 if (LocLocked.isValid()) {
Aaron Ballmane0449042014-04-01 21:43:23 +00001717 PartialDiagnosticAt Note(LocLocked, S.PDiag(diag::note_locked_here)
1718 << Kind);
Benjamin Kramer3204b152015-05-29 19:42:19 +00001719 Warnings.emplace_back(std::move(Warning), getNotes(Note));
DeLesley Hutchinsfd374bb2013-04-08 20:11:11 +00001720 return;
1721 }
Benjamin Kramer3204b152015-05-29 19:42:19 +00001722 Warnings.emplace_back(std::move(Warning), getNotes());
Caitlin Sadowski0b3501c2011-09-09 16:04:02 +00001723 }
1724
Aaron Ballmane0449042014-04-01 21:43:23 +00001725 void handleExclusiveAndShared(StringRef Kind, Name LockName,
1726 SourceLocation Loc1,
Craig Toppere14c0f82014-03-12 04:55:44 +00001727 SourceLocation Loc2) override {
Aaron Ballmane0449042014-04-01 21:43:23 +00001728 PartialDiagnosticAt Warning(Loc1,
1729 S.PDiag(diag::warn_lock_exclusive_and_shared)
1730 << Kind << LockName);
1731 PartialDiagnosticAt Note(Loc2, S.PDiag(diag::note_lock_exclusive_and_shared)
1732 << Kind << LockName);
Benjamin Kramer3204b152015-05-29 19:42:19 +00001733 Warnings.emplace_back(std::move(Warning), getNotes(Note));
Caitlin Sadowski0b3501c2011-09-09 16:04:02 +00001734 }
1735
Aaron Ballmane0449042014-04-01 21:43:23 +00001736 void handleNoMutexHeld(StringRef Kind, const NamedDecl *D,
1737 ProtectedOperationKind POK, AccessKind AK,
1738 SourceLocation Loc) override {
1739 assert((POK == POK_VarAccess || POK == POK_VarDereference) &&
1740 "Only works for variables");
Caitlin Sadowskie50d8c32011-09-14 20:09:09 +00001741 unsigned DiagID = POK == POK_VarAccess?
1742 diag::warn_variable_requires_any_lock:
1743 diag::warn_var_deref_requires_any_lock;
Richard Smith92286672012-02-03 04:45:26 +00001744 PartialDiagnosticAt Warning(Loc, S.PDiag(DiagID)
DeLesley Hutchinsa15e1b42012-09-19 19:18:29 +00001745 << D->getNameAsString() << getLockKindFromAccessKind(AK));
Benjamin Kramer3204b152015-05-29 19:42:19 +00001746 Warnings.emplace_back(std::move(Warning), getNotes());
Caitlin Sadowski0b3501c2011-09-09 16:04:02 +00001747 }
1748
Aaron Ballmane0449042014-04-01 21:43:23 +00001749 void handleMutexNotHeld(StringRef Kind, const NamedDecl *D,
1750 ProtectedOperationKind POK, Name LockName,
1751 LockKind LK, SourceLocation Loc,
Craig Toppere14c0f82014-03-12 04:55:44 +00001752 Name *PossibleMatch) override {
Caitlin Sadowski427f42e2011-09-13 18:01:58 +00001753 unsigned DiagID = 0;
DeLesley Hutchins5ff16442012-09-10 19:58:23 +00001754 if (PossibleMatch) {
1755 switch (POK) {
1756 case POK_VarAccess:
1757 DiagID = diag::warn_variable_requires_lock_precise;
1758 break;
1759 case POK_VarDereference:
1760 DiagID = diag::warn_var_deref_requires_lock_precise;
1761 break;
1762 case POK_FunctionCall:
1763 DiagID = diag::warn_fun_requires_lock_precise;
1764 break;
DeLesley Hutchinsc60dc2c2014-09-18 23:02:26 +00001765 case POK_PassByRef:
1766 DiagID = diag::warn_guarded_pass_by_reference;
1767 break;
1768 case POK_PtPassByRef:
1769 DiagID = diag::warn_pt_guarded_pass_by_reference;
1770 break;
DeLesley Hutchins5ff16442012-09-10 19:58:23 +00001771 }
Aaron Ballmane0449042014-04-01 21:43:23 +00001772 PartialDiagnosticAt Warning(Loc, S.PDiag(DiagID) << Kind
1773 << D->getNameAsString()
1774 << LockName << LK);
DeLesley Hutchins5ff16442012-09-10 19:58:23 +00001775 PartialDiagnosticAt Note(Loc, S.PDiag(diag::note_found_mutex_near_match)
Aaron Ballmane0449042014-04-01 21:43:23 +00001776 << *PossibleMatch);
DeLesley Hutchinsc60dc2c2014-09-18 23:02:26 +00001777 if (Verbose && POK == POK_VarAccess) {
1778 PartialDiagnosticAt VNote(D->getLocation(),
1779 S.PDiag(diag::note_guarded_by_declared_here)
1780 << D->getNameAsString());
Benjamin Kramer3204b152015-05-29 19:42:19 +00001781 Warnings.emplace_back(std::move(Warning), getNotes(Note, VNote));
DeLesley Hutchinsc60dc2c2014-09-18 23:02:26 +00001782 } else
Benjamin Kramer3204b152015-05-29 19:42:19 +00001783 Warnings.emplace_back(std::move(Warning), getNotes(Note));
DeLesley Hutchins5ff16442012-09-10 19:58:23 +00001784 } else {
1785 switch (POK) {
1786 case POK_VarAccess:
1787 DiagID = diag::warn_variable_requires_lock;
1788 break;
1789 case POK_VarDereference:
1790 DiagID = diag::warn_var_deref_requires_lock;
1791 break;
1792 case POK_FunctionCall:
1793 DiagID = diag::warn_fun_requires_lock;
1794 break;
DeLesley Hutchinsc60dc2c2014-09-18 23:02:26 +00001795 case POK_PassByRef:
1796 DiagID = diag::warn_guarded_pass_by_reference;
1797 break;
1798 case POK_PtPassByRef:
1799 DiagID = diag::warn_pt_guarded_pass_by_reference;
1800 break;
DeLesley Hutchins5ff16442012-09-10 19:58:23 +00001801 }
Aaron Ballmane0449042014-04-01 21:43:23 +00001802 PartialDiagnosticAt Warning(Loc, S.PDiag(DiagID) << Kind
1803 << D->getNameAsString()
1804 << LockName << LK);
DeLesley Hutchinseb0ea5f2014-08-14 21:40:15 +00001805 if (Verbose && POK == POK_VarAccess) {
1806 PartialDiagnosticAt Note(D->getLocation(),
Aaron Ballman71291bc2014-08-15 12:38:17 +00001807 S.PDiag(diag::note_guarded_by_declared_here)
1808 << D->getNameAsString());
Benjamin Kramer3204b152015-05-29 19:42:19 +00001809 Warnings.emplace_back(std::move(Warning), getNotes(Note));
Aaron Ballman71291bc2014-08-15 12:38:17 +00001810 } else
Benjamin Kramer3204b152015-05-29 19:42:19 +00001811 Warnings.emplace_back(std::move(Warning), getNotes());
Caitlin Sadowski0b3501c2011-09-09 16:04:02 +00001812 }
Caitlin Sadowski0b3501c2011-09-09 16:04:02 +00001813 }
1814
Alexander Kornienko34eb2072015-04-11 02:00:23 +00001815 void handleNegativeNotHeld(StringRef Kind, Name LockName, Name Neg,
1816 SourceLocation Loc) override {
DeLesley Hutchins3efd0492014-08-04 22:13:06 +00001817 PartialDiagnosticAt Warning(Loc,
1818 S.PDiag(diag::warn_acquire_requires_negative_cap)
1819 << Kind << LockName << Neg);
Benjamin Kramer3204b152015-05-29 19:42:19 +00001820 Warnings.emplace_back(std::move(Warning), getNotes());
DeLesley Hutchins3efd0492014-08-04 22:13:06 +00001821 }
1822
Aaron Ballmane0449042014-04-01 21:43:23 +00001823 void handleFunExcludesLock(StringRef Kind, Name FunName, Name LockName,
Craig Toppere14c0f82014-03-12 04:55:44 +00001824 SourceLocation Loc) override {
Aaron Ballmane0449042014-04-01 21:43:23 +00001825 PartialDiagnosticAt Warning(Loc, S.PDiag(diag::warn_fun_excludes_mutex)
1826 << Kind << FunName << LockName);
Benjamin Kramer3204b152015-05-29 19:42:19 +00001827 Warnings.emplace_back(std::move(Warning), getNotes());
DeLesley Hutchinseb0ea5f2014-08-14 21:40:15 +00001828 }
1829
Alexander Kornienko34eb2072015-04-11 02:00:23 +00001830 void handleLockAcquiredBefore(StringRef Kind, Name L1Name, Name L2Name,
1831 SourceLocation Loc) override {
DeLesley Hutchinsab1dc2d2015-02-03 22:11:04 +00001832 PartialDiagnosticAt Warning(Loc,
1833 S.PDiag(diag::warn_acquired_before) << Kind << L1Name << L2Name);
Benjamin Kramer3204b152015-05-29 19:42:19 +00001834 Warnings.emplace_back(std::move(Warning), getNotes());
DeLesley Hutchinsab1dc2d2015-02-03 22:11:04 +00001835 }
1836
Alexander Kornienko34eb2072015-04-11 02:00:23 +00001837 void handleBeforeAfterCycle(Name L1Name, SourceLocation Loc) override {
DeLesley Hutchinsab1dc2d2015-02-03 22:11:04 +00001838 PartialDiagnosticAt Warning(Loc,
1839 S.PDiag(diag::warn_acquired_before_after_cycle) << L1Name);
Benjamin Kramer3204b152015-05-29 19:42:19 +00001840 Warnings.emplace_back(std::move(Warning), getNotes());
DeLesley Hutchinsab1dc2d2015-02-03 22:11:04 +00001841 }
1842
DeLesley Hutchinseb0ea5f2014-08-14 21:40:15 +00001843 void enterFunction(const FunctionDecl* FD) override {
1844 CurrentFunction = FD;
1845 }
1846
1847 void leaveFunction(const FunctionDecl* FD) override {
Hans Wennborgdcfba332015-10-06 23:40:43 +00001848 CurrentFunction = nullptr;
Caitlin Sadowski0b3501c2011-09-09 16:04:02 +00001849 }
1850};
Hans Wennborgdcfba332015-10-06 23:40:43 +00001851} // anonymous namespace
Benjamin Kramer539803c2015-03-19 14:23:45 +00001852} // namespace threadSafety
1853} // namespace clang
Caitlin Sadowski0b3501c2011-09-09 16:04:02 +00001854
Ted Kremenekb749a6d2011-01-15 02:58:47 +00001855//===----------------------------------------------------------------------===//
DeLesley Hutchins48a31762013-08-12 21:20:55 +00001856// -Wconsumed
1857//===----------------------------------------------------------------------===//
1858
1859namespace clang {
1860namespace consumed {
1861namespace {
1862class ConsumedWarningsHandler : public ConsumedWarningsHandlerBase {
1863
1864 Sema &S;
1865 DiagList Warnings;
1866
1867public:
DeLesley Hutchinsab1dc2d2015-02-03 22:11:04 +00001868
DeLesley Hutchins48a31762013-08-12 21:20:55 +00001869 ConsumedWarningsHandler(Sema &S) : S(S) {}
Craig Toppere14c0f82014-03-12 04:55:44 +00001870
1871 void emitDiagnostics() override {
DeLesley Hutchins48a31762013-08-12 21:20:55 +00001872 Warnings.sort(SortDiagBySourceLocation(S.getSourceManager()));
Aaron Ballmane5195222014-05-15 20:50:47 +00001873 for (const auto &Diag : Warnings) {
1874 S.Diag(Diag.first.first, Diag.first.second);
1875 for (const auto &Note : Diag.second)
1876 S.Diag(Note.first, Note.second);
DeLesley Hutchins48a31762013-08-12 21:20:55 +00001877 }
1878 }
Craig Toppere14c0f82014-03-12 04:55:44 +00001879
1880 void warnLoopStateMismatch(SourceLocation Loc,
1881 StringRef VariableName) override {
DeLesley Hutchins3277a612013-10-09 18:30:24 +00001882 PartialDiagnosticAt Warning(Loc, S.PDiag(diag::warn_loop_state_mismatch) <<
1883 VariableName);
Benjamin Kramer3204b152015-05-29 19:42:19 +00001884
1885 Warnings.emplace_back(std::move(Warning), OptionalNotes());
DeLesley Hutchins3277a612013-10-09 18:30:24 +00001886 }
1887
DeLesley Hutchins36ea1dd2013-10-17 22:53:04 +00001888 void warnParamReturnTypestateMismatch(SourceLocation Loc,
1889 StringRef VariableName,
1890 StringRef ExpectedState,
Craig Toppere14c0f82014-03-12 04:55:44 +00001891 StringRef ObservedState) override {
DeLesley Hutchins36ea1dd2013-10-17 22:53:04 +00001892
1893 PartialDiagnosticAt Warning(Loc, S.PDiag(
1894 diag::warn_param_return_typestate_mismatch) << VariableName <<
1895 ExpectedState << ObservedState);
Benjamin Kramer3204b152015-05-29 19:42:19 +00001896
1897 Warnings.emplace_back(std::move(Warning), OptionalNotes());
DeLesley Hutchins36ea1dd2013-10-17 22:53:04 +00001898 }
1899
DeLesley Hutchins69391772013-10-17 23:23:53 +00001900 void warnParamTypestateMismatch(SourceLocation Loc, StringRef ExpectedState,
Craig Toppere14c0f82014-03-12 04:55:44 +00001901 StringRef ObservedState) override {
DeLesley Hutchins69391772013-10-17 23:23:53 +00001902
1903 PartialDiagnosticAt Warning(Loc, S.PDiag(
1904 diag::warn_param_typestate_mismatch) << ExpectedState << ObservedState);
Benjamin Kramer3204b152015-05-29 19:42:19 +00001905
1906 Warnings.emplace_back(std::move(Warning), OptionalNotes());
DeLesley Hutchins69391772013-10-17 23:23:53 +00001907 }
1908
DeLesley Hutchinsfc368252013-09-03 20:11:38 +00001909 void warnReturnTypestateForUnconsumableType(SourceLocation Loc,
Craig Toppere14c0f82014-03-12 04:55:44 +00001910 StringRef TypeName) override {
DeLesley Hutchinsfc368252013-09-03 20:11:38 +00001911 PartialDiagnosticAt Warning(Loc, S.PDiag(
1912 diag::warn_return_typestate_for_unconsumable_type) << TypeName);
Benjamin Kramer3204b152015-05-29 19:42:19 +00001913
1914 Warnings.emplace_back(std::move(Warning), OptionalNotes());
DeLesley Hutchinsfc368252013-09-03 20:11:38 +00001915 }
1916
1917 void warnReturnTypestateMismatch(SourceLocation Loc, StringRef ExpectedState,
Craig Toppere14c0f82014-03-12 04:55:44 +00001918 StringRef ObservedState) override {
DeLesley Hutchinsfc368252013-09-03 20:11:38 +00001919
1920 PartialDiagnosticAt Warning(Loc, S.PDiag(
1921 diag::warn_return_typestate_mismatch) << ExpectedState << ObservedState);
Benjamin Kramer3204b152015-05-29 19:42:19 +00001922
1923 Warnings.emplace_back(std::move(Warning), OptionalNotes());
DeLesley Hutchinsfc368252013-09-03 20:11:38 +00001924 }
1925
DeLesley Hutchins210791a2013-10-04 21:28:06 +00001926 void warnUseOfTempInInvalidState(StringRef MethodName, StringRef State,
Craig Toppere14c0f82014-03-12 04:55:44 +00001927 SourceLocation Loc) override {
DeLesley Hutchins48a31762013-08-12 21:20:55 +00001928
1929 PartialDiagnosticAt Warning(Loc, S.PDiag(
DeLesley Hutchins210791a2013-10-04 21:28:06 +00001930 diag::warn_use_of_temp_in_invalid_state) << MethodName << State);
Benjamin Kramer3204b152015-05-29 19:42:19 +00001931
1932 Warnings.emplace_back(std::move(Warning), OptionalNotes());
DeLesley Hutchins48a31762013-08-12 21:20:55 +00001933 }
1934
DeLesley Hutchins210791a2013-10-04 21:28:06 +00001935 void warnUseInInvalidState(StringRef MethodName, StringRef VariableName,
Craig Toppere14c0f82014-03-12 04:55:44 +00001936 StringRef State, SourceLocation Loc) override {
DeLesley Hutchins48a31762013-08-12 21:20:55 +00001937
DeLesley Hutchins210791a2013-10-04 21:28:06 +00001938 PartialDiagnosticAt Warning(Loc, S.PDiag(diag::warn_use_in_invalid_state) <<
1939 MethodName << VariableName << State);
Benjamin Kramer3204b152015-05-29 19:42:19 +00001940
1941 Warnings.emplace_back(std::move(Warning), OptionalNotes());
DeLesley Hutchins48a31762013-08-12 21:20:55 +00001942 }
1943};
Hans Wennborgdcfba332015-10-06 23:40:43 +00001944} // anonymous namespace
1945} // namespace consumed
1946} // namespace clang
DeLesley Hutchins48a31762013-08-12 21:20:55 +00001947
1948//===----------------------------------------------------------------------===//
Ted Kremenek918fe842010-03-20 21:06:02 +00001949// AnalysisBasedWarnings - Worker object used by Sema to execute analysis-based
1950// warnings on a function, method, or block.
1951//===----------------------------------------------------------------------===//
1952
Ted Kremenek0b405322010-03-23 00:13:23 +00001953clang::sema::AnalysisBasedWarnings::Policy::Policy() {
1954 enableCheckFallThrough = 1;
1955 enableCheckUnreachable = 0;
Caitlin Sadowskiafbbd8e2011-08-23 18:46:34 +00001956 enableThreadSafetyAnalysis = 0;
DeLesley Hutchins48a31762013-08-12 21:20:55 +00001957 enableConsumedAnalysis = 0;
Ted Kremenek0b405322010-03-23 00:13:23 +00001958}
1959
Ted Kremenekad8753c2014-03-15 05:47:06 +00001960static unsigned isEnabled(DiagnosticsEngine &D, unsigned diag) {
Alp Tokerd4a3f0e2014-06-15 23:30:39 +00001961 return (unsigned)!D.isIgnored(diag, SourceLocation());
Ted Kremenekad8753c2014-03-15 05:47:06 +00001962}
1963
Chandler Carruthb4836ea2011-07-06 16:21:37 +00001964clang::sema::AnalysisBasedWarnings::AnalysisBasedWarnings(Sema &s)
1965 : S(s),
1966 NumFunctionsAnalyzed(0),
Benjamin Kramer581f48f2011-07-08 20:38:53 +00001967 NumFunctionsWithBadCFGs(0),
Chandler Carruthb4836ea2011-07-06 16:21:37 +00001968 NumCFGBlocks(0),
Benjamin Kramer581f48f2011-07-08 20:38:53 +00001969 MaxCFGBlocksPerFunction(0),
1970 NumUninitAnalysisFunctions(0),
1971 NumUninitAnalysisVariables(0),
1972 MaxUninitAnalysisVariablesPerFunction(0),
1973 NumUninitAnalysisBlockVisits(0),
1974 MaxUninitAnalysisBlockVisitsPerFunction(0) {
Ted Kremenekad8753c2014-03-15 05:47:06 +00001975
1976 using namespace diag;
David Blaikie9c902b52011-09-25 23:23:43 +00001977 DiagnosticsEngine &D = S.getDiagnostics();
Ted Kremenekad8753c2014-03-15 05:47:06 +00001978
1979 DefaultPolicy.enableCheckUnreachable =
1980 isEnabled(D, warn_unreachable) ||
1981 isEnabled(D, warn_unreachable_break) ||
Ted Kremenek14210372014-03-21 06:02:36 +00001982 isEnabled(D, warn_unreachable_return) ||
1983 isEnabled(D, warn_unreachable_loop_increment);
Ted Kremenekad8753c2014-03-15 05:47:06 +00001984
1985 DefaultPolicy.enableThreadSafetyAnalysis =
1986 isEnabled(D, warn_double_lock);
1987
1988 DefaultPolicy.enableConsumedAnalysis =
1989 isEnabled(D, warn_use_in_invalid_state);
Ted Kremenek918fe842010-03-20 21:06:02 +00001990}
1991
Aaron Ballmane5195222014-05-15 20:50:47 +00001992static void flushDiagnostics(Sema &S, const sema::FunctionScopeInfo *fscope) {
1993 for (const auto &D : fscope->PossiblyUnreachableDiags)
Ted Kremenek3427fac2011-02-23 01:52:04 +00001994 S.Diag(D.Loc, D.PD);
Ted Kremenek3427fac2011-02-23 01:52:04 +00001995}
1996
Ted Kremenek0b405322010-03-23 00:13:23 +00001997void clang::sema::
1998AnalysisBasedWarnings::IssueWarnings(sema::AnalysisBasedWarnings::Policy P,
Ted Kremenekcc7f1f82011-02-23 01:51:53 +00001999 sema::FunctionScopeInfo *fscope,
Ted Kremenek1767a272011-02-23 01:51:48 +00002000 const Decl *D, const BlockExpr *blkExpr) {
Ted Kremenekb45ebee2010-03-20 21:11:09 +00002001
Ted Kremenek918fe842010-03-20 21:06:02 +00002002 // We avoid doing analysis-based warnings when there are errors for
2003 // two reasons:
2004 // (1) The CFGs often can't be constructed (if the body is invalid), so
2005 // don't bother trying.
2006 // (2) The code already has problems; running the analysis just takes more
2007 // time.
David Blaikie9c902b52011-09-25 23:23:43 +00002008 DiagnosticsEngine &Diags = S.getDiagnostics();
Ted Kremenekb8021922010-04-30 21:49:25 +00002009
Olivier Goffart270ced22017-11-23 08:15:22 +00002010 // Do not do any analysis if we are going to just ignore them.
2011 if (Diags.getIgnoreAllWarnings() ||
2012 (Diags.getSuppressSystemWarnings() &&
2013 S.SourceMgr.isInSystemHeader(D->getLocation())))
Ted Kremenek0b405322010-03-23 00:13:23 +00002014 return;
2015
John McCall1d570a72010-08-25 05:56:39 +00002016 // For code in dependent contexts, we'll do this at instantiation time.
David Blaikie0f2ae782012-01-24 04:51:48 +00002017 if (cast<DeclContext>(D)->isDependentContext())
2018 return;
Ted Kremenek918fe842010-03-20 21:06:02 +00002019
Argyrios Kyrtzidis70ec1c72016-07-13 20:35:26 +00002020 if (Diags.hasUncompilableErrorOccurred()) {
Ted Kremenek3427fac2011-02-23 01:52:04 +00002021 // Flush out any possibly unreachable diagnostics.
2022 flushDiagnostics(S, fscope);
2023 return;
2024 }
2025
Ted Kremenek918fe842010-03-20 21:06:02 +00002026 const Stmt *Body = D->getBody();
2027 assert(Body);
2028
Ted Kremenekb3a38a92013-10-14 19:11:25 +00002029 // Construct the analysis context with the specified CFG build options.
Craig Topperc3ec1492014-05-26 06:22:03 +00002030 AnalysisDeclContext AC(/* AnalysisDeclContextManager */ nullptr, D);
Ted Kremenek189ecec2011-07-21 05:22:47 +00002031
Ted Kremenek918fe842010-03-20 21:06:02 +00002032 // Don't generate EH edges for CallExprs as we'd like to avoid the n^2
Benjamin Kramer60509af2013-09-09 14:48:42 +00002033 // explosion for destructors that can result and the compile time hit.
Ted Kremenek189ecec2011-07-21 05:22:47 +00002034 AC.getCFGBuildOptions().PruneTriviallyFalseEdges = true;
2035 AC.getCFGBuildOptions().AddEHEdges = false;
2036 AC.getCFGBuildOptions().AddInitializers = true;
2037 AC.getCFGBuildOptions().AddImplicitDtors = true;
Jordan Rose91f78402012-09-05 23:11:06 +00002038 AC.getCFGBuildOptions().AddTemporaryDtors = true;
Jordan Rosec9176072014-01-13 17:59:19 +00002039 AC.getCFGBuildOptions().AddCXXNewAllocator = false;
Enrico Pertosofaed8012015-06-03 10:12:40 +00002040 AC.getCFGBuildOptions().AddCXXDefaultInitExprInCtors = true;
Jordan Rose91f78402012-09-05 23:11:06 +00002041
Ted Kremenek9e100ea2011-07-19 14:18:48 +00002042 // Force that certain expressions appear as CFGElements in the CFG. This
2043 // is used to speed up various analyses.
2044 // FIXME: This isn't the right factoring. This is here for initial
2045 // prototyping, but we need a way for analyses to say what expressions they
2046 // expect to always be CFGElements and then fill in the BuildOptions
2047 // appropriately. This is essentially a layering violation.
DeLesley Hutchins48a31762013-08-12 21:20:55 +00002048 if (P.enableCheckUnreachable || P.enableThreadSafetyAnalysis ||
2049 P.enableConsumedAnalysis) {
DeLesley Hutchinsf7faa6a2011-12-08 20:23:06 +00002050 // Unreachable code analysis and thread safety require a linearized CFG.
Ted Kremenekbd913712011-08-23 23:05:11 +00002051 AC.getCFGBuildOptions().setAllAlwaysAdd();
2052 }
2053 else {
2054 AC.getCFGBuildOptions()
2055 .setAlwaysAdd(Stmt::BinaryOperatorClass)
Richard Smithb21dd022012-07-17 01:27:33 +00002056 .setAlwaysAdd(Stmt::CompoundAssignOperatorClass)
Ted Kremenekbd913712011-08-23 23:05:11 +00002057 .setAlwaysAdd(Stmt::BlockExprClass)
2058 .setAlwaysAdd(Stmt::CStyleCastExprClass)
2059 .setAlwaysAdd(Stmt::DeclRefExprClass)
2060 .setAlwaysAdd(Stmt::ImplicitCastExprClass)
Richard Smith84837d52012-05-03 18:27:39 +00002061 .setAlwaysAdd(Stmt::UnaryOperatorClass)
2062 .setAlwaysAdd(Stmt::AttributedStmtClass);
Ted Kremenekbd913712011-08-23 23:05:11 +00002063 }
Ted Kremenek918fe842010-03-20 21:06:02 +00002064
Richard Trieue9fa2662014-04-15 00:57:50 +00002065 // Install the logical handler for -Wtautological-overlap-compare
2066 std::unique_ptr<LogicalErrorHandler> LEH;
Alp Tokerd4a3f0e2014-06-15 23:30:39 +00002067 if (!Diags.isIgnored(diag::warn_tautological_overlap_comparison,
2068 D->getLocStart())) {
Richard Trieue9fa2662014-04-15 00:57:50 +00002069 LEH.reset(new LogicalErrorHandler(S));
2070 AC.getCFGBuildOptions().Observer = LEH.get();
Richard Trieuf935b562014-04-05 05:17:01 +00002071 }
Ted Kremenekb3a38a92013-10-14 19:11:25 +00002072
Ted Kremenek3427fac2011-02-23 01:52:04 +00002073 // Emit delayed diagnostics.
David Blaikie0f2ae782012-01-24 04:51:48 +00002074 if (!fscope->PossiblyUnreachableDiags.empty()) {
Ted Kremenek3427fac2011-02-23 01:52:04 +00002075 bool analyzed = false;
Ted Kremeneka099c592011-03-10 03:50:34 +00002076
2077 // Register the expressions with the CFGBuilder.
Aaron Ballmane5195222014-05-15 20:50:47 +00002078 for (const auto &D : fscope->PossiblyUnreachableDiags) {
2079 if (D.stmt)
2080 AC.registerForcedBlockExpression(D.stmt);
Ted Kremeneka099c592011-03-10 03:50:34 +00002081 }
2082
2083 if (AC.getCFG()) {
2084 analyzed = true;
Aaron Ballmane5195222014-05-15 20:50:47 +00002085 for (const auto &D : fscope->PossiblyUnreachableDiags) {
Ted Kremeneka099c592011-03-10 03:50:34 +00002086 bool processed = false;
Aaron Ballmane5195222014-05-15 20:50:47 +00002087 if (D.stmt) {
2088 const CFGBlock *block = AC.getBlockForRegisteredExpression(D.stmt);
Eli Friedmane0afc982012-01-21 01:01:51 +00002089 CFGReverseBlockReachabilityAnalysis *cra =
2090 AC.getCFGReachablityAnalysis();
2091 // FIXME: We should be able to assert that block is non-null, but
2092 // the CFG analysis can skip potentially-evaluated expressions in
2093 // edge cases; see test/Sema/vla-2.c.
2094 if (block && cra) {
Ted Kremenek3427fac2011-02-23 01:52:04 +00002095 // Can this block be reached from the entrance?
Ted Kremeneka099c592011-03-10 03:50:34 +00002096 if (cra->isReachable(&AC.getCFG()->getEntry(), block))
Ted Kremenek3427fac2011-02-23 01:52:04 +00002097 S.Diag(D.Loc, D.PD);
Ted Kremeneka099c592011-03-10 03:50:34 +00002098 processed = true;
Ted Kremenek3427fac2011-02-23 01:52:04 +00002099 }
2100 }
Ted Kremeneka099c592011-03-10 03:50:34 +00002101 if (!processed) {
2102 // Emit the warning anyway if we cannot map to a basic block.
2103 S.Diag(D.Loc, D.PD);
2104 }
Ted Kremenek3427fac2011-02-23 01:52:04 +00002105 }
Ted Kremeneka099c592011-03-10 03:50:34 +00002106 }
Ted Kremenek3427fac2011-02-23 01:52:04 +00002107
2108 if (!analyzed)
2109 flushDiagnostics(S, fscope);
2110 }
2111
Ted Kremenek918fe842010-03-20 21:06:02 +00002112 // Warning: check missing 'return'
David Blaikie0f2ae782012-01-24 04:51:48 +00002113 if (P.enableCheckFallThrough) {
Ted Kremenek918fe842010-03-20 21:06:02 +00002114 const CheckFallThroughDiagnostics &CD =
Eric Fiselier709d1b32016-10-27 07:30:31 +00002115 (isa<BlockDecl>(D)
2116 ? CheckFallThroughDiagnostics::MakeForBlock()
2117 : (isa<CXXMethodDecl>(D) &&
2118 cast<CXXMethodDecl>(D)->getOverloadedOperator() == OO_Call &&
2119 cast<CXXMethodDecl>(D)->getParent()->isLambda())
2120 ? CheckFallThroughDiagnostics::MakeForLambda()
Eric Fiselierda8f9b52017-05-25 02:16:53 +00002121 : (fscope->isCoroutine()
Eric Fiselier709d1b32016-10-27 07:30:31 +00002122 ? CheckFallThroughDiagnostics::MakeForCoroutine(D)
2123 : CheckFallThroughDiagnostics::MakeForFunction(D)));
Reid Kleckner87a31802018-03-12 21:43:02 +00002124 CheckFallThroughForBody(S, D, Body, blkExpr, CD, AC, fscope);
Ted Kremenek918fe842010-03-20 21:06:02 +00002125 }
2126
2127 // Warning: check for unreachable code
Ted Kremenek7f770032011-11-30 21:22:09 +00002128 if (P.enableCheckUnreachable) {
2129 // Only check for unreachable code on non-template instantiations.
2130 // Different template instantiations can effectively change the control-flow
2131 // and it is very difficult to prove that a snippet of code in a template
2132 // is unreachable for all instantiations.
Ted Kremenek85825ae2011-12-01 00:59:17 +00002133 bool isTemplateInstantiation = false;
2134 if (const FunctionDecl *Function = dyn_cast<FunctionDecl>(D))
2135 isTemplateInstantiation = Function->isTemplateInstantiation();
2136 if (!isTemplateInstantiation)
Ted Kremenek7f770032011-11-30 21:22:09 +00002137 CheckUnreachable(S, AC);
2138 }
Caitlin Sadowski0b3501c2011-09-09 16:04:02 +00002139
Caitlin Sadowskiafbbd8e2011-08-23 18:46:34 +00002140 // Check for thread safety violations
David Blaikie0f2ae782012-01-24 04:51:48 +00002141 if (P.enableThreadSafetyAnalysis) {
DeLesley Hutchinsc2090512011-10-21 18:10:14 +00002142 SourceLocation FL = AC.getDecl()->getLocation();
Richard Smith92286672012-02-03 04:45:26 +00002143 SourceLocation FEL = AC.getDecl()->getLocEnd();
DeLesley Hutchinsea1f8332014-07-28 15:57:27 +00002144 threadSafety::ThreadSafetyReporter Reporter(S, FL, FEL);
Alp Tokerd4a3f0e2014-06-15 23:30:39 +00002145 if (!Diags.isIgnored(diag::warn_thread_safety_beta, D->getLocStart()))
DeLesley Hutchins8edae132012-12-05 00:06:15 +00002146 Reporter.setIssueBetaWarnings(true);
DeLesley Hutchinseb0ea5f2014-08-14 21:40:15 +00002147 if (!Diags.isIgnored(diag::warn_thread_safety_verbose, D->getLocStart()))
2148 Reporter.setVerbose(true);
DeLesley Hutchins8edae132012-12-05 00:06:15 +00002149
DeLesley Hutchinsab1dc2d2015-02-03 22:11:04 +00002150 threadSafety::runThreadSafetyAnalysis(AC, Reporter,
2151 &S.ThreadSafetyDeclCache);
Caitlin Sadowski0b3501c2011-09-09 16:04:02 +00002152 Reporter.emitDiagnostics();
2153 }
Caitlin Sadowskiafbbd8e2011-08-23 18:46:34 +00002154
DeLesley Hutchins48a31762013-08-12 21:20:55 +00002155 // Check for violations of consumed properties.
2156 if (P.enableConsumedAnalysis) {
2157 consumed::ConsumedWarningsHandler WarningHandler(S);
Reid Klecknere846dea2013-08-12 23:49:39 +00002158 consumed::ConsumedAnalyzer Analyzer(WarningHandler);
DeLesley Hutchins48a31762013-08-12 21:20:55 +00002159 Analyzer.run(AC);
2160 }
2161
Alp Tokerd4a3f0e2014-06-15 23:30:39 +00002162 if (!Diags.isIgnored(diag::warn_uninit_var, D->getLocStart()) ||
2163 !Diags.isIgnored(diag::warn_sometimes_uninit_var, D->getLocStart()) ||
2164 !Diags.isIgnored(diag::warn_maybe_uninit_var, D->getLocStart())) {
Ted Kremenek2551fbe2011-03-17 05:29:57 +00002165 if (CFG *cfg = AC.getCFG()) {
Ted Kremenekb63931e2011-01-18 21:18:58 +00002166 UninitValsDiagReporter reporter(S);
Fariborz Jahanian8809a9d2011-07-16 18:31:33 +00002167 UninitVariablesAnalysisStats stats;
Benjamin Kramere492cb42011-07-16 20:13:06 +00002168 std::memset(&stats, 0, sizeof(UninitVariablesAnalysisStats));
Ted Kremenekbcf848f2011-01-25 19:13:48 +00002169 runUninitializedVariablesAnalysis(*cast<DeclContext>(D), *cfg, AC,
Chandler Carruthb4836ea2011-07-06 16:21:37 +00002170 reporter, stats);
2171
2172 if (S.CollectStats && stats.NumVariablesAnalyzed > 0) {
2173 ++NumUninitAnalysisFunctions;
2174 NumUninitAnalysisVariables += stats.NumVariablesAnalyzed;
2175 NumUninitAnalysisBlockVisits += stats.NumBlockVisits;
2176 MaxUninitAnalysisVariablesPerFunction =
2177 std::max(MaxUninitAnalysisVariablesPerFunction,
2178 stats.NumVariablesAnalyzed);
2179 MaxUninitAnalysisBlockVisitsPerFunction =
2180 std::max(MaxUninitAnalysisBlockVisitsPerFunction,
2181 stats.NumBlockVisits);
2182 }
Ted Kremenekb749a6d2011-01-15 02:58:47 +00002183 }
2184 }
Chandler Carruthb4836ea2011-07-06 16:21:37 +00002185
Alexander Kornienko06caf7d2012-06-02 01:01:07 +00002186 bool FallThroughDiagFull =
Alp Tokerd4a3f0e2014-06-15 23:30:39 +00002187 !Diags.isIgnored(diag::warn_unannotated_fallthrough, D->getLocStart());
2188 bool FallThroughDiagPerFunction = !Diags.isIgnored(
2189 diag::warn_unannotated_fallthrough_per_function, D->getLocStart());
Richard Smith4f902c72016-03-08 00:32:55 +00002190 if (FallThroughDiagFull || FallThroughDiagPerFunction ||
2191 fscope->HasFallthroughStmt) {
Alexander Kornienko06caf7d2012-06-02 01:01:07 +00002192 DiagnoseSwitchLabelsFallthrough(S, AC, !FallThroughDiagFull);
Richard Smith84837d52012-05-03 18:27:39 +00002193 }
2194
John McCall460ce582015-10-22 18:38:17 +00002195 if (S.getLangOpts().ObjCWeak &&
Alp Tokerd4a3f0e2014-06-15 23:30:39 +00002196 !Diags.isIgnored(diag::warn_arc_repeated_use_of_weak, D->getLocStart()))
Jordan Rose76831c62012-10-11 16:10:19 +00002197 diagnoseRepeatedUseOfWeak(S, fscope, D, AC.getParentMap());
Jordan Rosed3934582012-09-28 22:21:30 +00002198
Richard Trieu2f024f42013-12-21 02:33:43 +00002199
2200 // Check for infinite self-recursion in functions
Alp Tokerd4a3f0e2014-06-15 23:30:39 +00002201 if (!Diags.isIgnored(diag::warn_infinite_recursive_function,
2202 D->getLocStart())) {
Richard Trieu2f024f42013-12-21 02:33:43 +00002203 if (const FunctionDecl *FD = dyn_cast<FunctionDecl>(D)) {
2204 checkRecursiveFunction(S, FD, Body, AC);
2205 }
2206 }
2207
Erich Keane89fe9c22017-06-23 20:22:19 +00002208 // Check for throw out of non-throwing function.
2209 if (!Diags.isIgnored(diag::warn_throw_in_noexcept_func, D->getLocStart()))
2210 if (const FunctionDecl *FD = dyn_cast<FunctionDecl>(D))
2211 if (S.getLangOpts().CPlusPlus && isNoexcept(FD))
2212 checkThrowInNonThrowingFunc(S, FD, AC);
2213
Richard Trieue9fa2662014-04-15 00:57:50 +00002214 // If none of the previous checks caused a CFG build, trigger one here
2215 // for -Wtautological-overlap-compare
Alp Tokerd4a3f0e2014-06-15 23:30:39 +00002216 if (!Diags.isIgnored(diag::warn_tautological_overlap_comparison,
Richard Trieue9fa2662014-04-15 00:57:50 +00002217 D->getLocStart())) {
2218 AC.getCFG();
2219 }
2220
Chandler Carruthb4836ea2011-07-06 16:21:37 +00002221 // Collect statistics about the CFG if it was built.
2222 if (S.CollectStats && AC.isCFGBuilt()) {
2223 ++NumFunctionsAnalyzed;
2224 if (CFG *cfg = AC.getCFG()) {
2225 // If we successfully built a CFG for this context, record some more
2226 // detail information about it.
Chandler Carruth50020d92011-07-06 22:21:45 +00002227 NumCFGBlocks += cfg->getNumBlockIDs();
Chandler Carruthb4836ea2011-07-06 16:21:37 +00002228 MaxCFGBlocksPerFunction = std::max(MaxCFGBlocksPerFunction,
Chandler Carruth50020d92011-07-06 22:21:45 +00002229 cfg->getNumBlockIDs());
Chandler Carruthb4836ea2011-07-06 16:21:37 +00002230 } else {
2231 ++NumFunctionsWithBadCFGs;
2232 }
2233 }
2234}
2235
2236void clang::sema::AnalysisBasedWarnings::PrintStats() const {
2237 llvm::errs() << "\n*** Analysis Based Warnings Stats:\n";
2238
2239 unsigned NumCFGsBuilt = NumFunctionsAnalyzed - NumFunctionsWithBadCFGs;
2240 unsigned AvgCFGBlocksPerFunction =
2241 !NumCFGsBuilt ? 0 : NumCFGBlocks/NumCFGsBuilt;
2242 llvm::errs() << NumFunctionsAnalyzed << " functions analyzed ("
2243 << NumFunctionsWithBadCFGs << " w/o CFGs).\n"
2244 << " " << NumCFGBlocks << " CFG blocks built.\n"
2245 << " " << AvgCFGBlocksPerFunction
2246 << " average CFG blocks per function.\n"
2247 << " " << MaxCFGBlocksPerFunction
2248 << " max CFG blocks per function.\n";
2249
2250 unsigned AvgUninitVariablesPerFunction = !NumUninitAnalysisFunctions ? 0
2251 : NumUninitAnalysisVariables/NumUninitAnalysisFunctions;
2252 unsigned AvgUninitBlockVisitsPerFunction = !NumUninitAnalysisFunctions ? 0
2253 : NumUninitAnalysisBlockVisits/NumUninitAnalysisFunctions;
2254 llvm::errs() << NumUninitAnalysisFunctions
2255 << " functions analyzed for uninitialiazed variables\n"
2256 << " " << NumUninitAnalysisVariables << " variables analyzed.\n"
2257 << " " << AvgUninitVariablesPerFunction
2258 << " average variables per function.\n"
2259 << " " << MaxUninitAnalysisVariablesPerFunction
2260 << " max variables per function.\n"
2261 << " " << NumUninitAnalysisBlockVisits << " block visits.\n"
2262 << " " << AvgUninitBlockVisitsPerFunction
2263 << " average block visits per function.\n"
2264 << " " << MaxUninitAnalysisBlockVisitsPerFunction
2265 << " max block visits per function.\n";
Ted Kremenek918fe842010-03-20 21:06:02 +00002266}