blob: 2911f0eb24787486a3534cb46f53dc7d338a86f1 [file] [log] [blame]
Alexander Kornienkoa48a12c2013-12-03 10:50:16 +00001//===- unittest/Format/FormatTestJS.cpp - Formatting unit tests for JS ----===//
2//
3// The LLVM Compiler Infrastructure
4//
5// This file is distributed under the University of Illinois Open Source
6// License. See LICENSE.TXT for details.
7//
8//===----------------------------------------------------------------------===//
9
Alexander Kornienkoa48a12c2013-12-03 10:50:16 +000010#include "FormatTestUtils.h"
Alexander Kornienkoa48a12c2013-12-03 10:50:16 +000011#include "clang/Format/Format.h"
12#include "llvm/Support/Debug.h"
13#include "gtest/gtest.h"
14
Chandler Carruth10346662014-04-22 03:17:02 +000015#define DEBUG_TYPE "format-test"
16
Alexander Kornienkoa48a12c2013-12-03 10:50:16 +000017namespace clang {
18namespace format {
19
20class FormatTestJS : public ::testing::Test {
21protected:
22 static std::string format(llvm::StringRef Code, unsigned Offset,
23 unsigned Length, const FormatStyle &Style) {
24 DEBUG(llvm::errs() << "---\n");
25 DEBUG(llvm::errs() << Code << "\n\n");
26 std::vector<tooling::Range> Ranges(1, tooling::Range(Offset, Length));
Daniel Jasper56691b82015-06-11 13:29:20 +000027 bool IncompleteFormat = false;
28 tooling::Replacements Replaces =
29 reformat(Style, Code, Ranges, "<stdin>", &IncompleteFormat);
30 EXPECT_FALSE(IncompleteFormat);
Alexander Kornienkoa48a12c2013-12-03 10:50:16 +000031 std::string Result = applyAllReplacements(Code, Replaces);
32 EXPECT_NE("", Result);
33 DEBUG(llvm::errs() << "\n" << Result << "\n\n");
34 return Result;
35 }
36
Daniel Jasper069e5f42014-05-20 11:14:57 +000037 static std::string format(
38 llvm::StringRef Code,
39 const FormatStyle &Style = getGoogleStyle(FormatStyle::LK_JavaScript)) {
Alexander Kornienkoa48a12c2013-12-03 10:50:16 +000040 return format(Code, 0, Code.size(), Style);
41 }
42
Alexander Kornienkoc1637f12013-12-10 11:28:13 +000043 static FormatStyle getGoogleJSStyleWithColumns(unsigned ColumnLimit) {
Nico Weber514ecc82014-02-02 20:50:45 +000044 FormatStyle Style = getGoogleStyle(FormatStyle::LK_JavaScript);
Alexander Kornienkoa48a12c2013-12-03 10:50:16 +000045 Style.ColumnLimit = ColumnLimit;
46 return Style;
47 }
48
Nico Weber514ecc82014-02-02 20:50:45 +000049 static void verifyFormat(
50 llvm::StringRef Code,
51 const FormatStyle &Style = getGoogleStyle(FormatStyle::LK_JavaScript)) {
Alexander Kornienkoa48a12c2013-12-03 10:50:16 +000052 EXPECT_EQ(Code.str(), format(test::messUp(Code), Style));
53 }
54};
55
56TEST_F(FormatTestJS, UnderstandsJavaScriptOperators) {
57 verifyFormat("a == = b;");
58 verifyFormat("a != = b;");
59
60 verifyFormat("a === b;");
Daniel Jaspere551bb72014-11-05 17:22:31 +000061 verifyFormat("aaaaaaa ===\n b;", getGoogleJSStyleWithColumns(10));
Alexander Kornienkoa48a12c2013-12-03 10:50:16 +000062 verifyFormat("a !== b;");
Daniel Jaspere551bb72014-11-05 17:22:31 +000063 verifyFormat("aaaaaaa !==\n b;", getGoogleJSStyleWithColumns(10));
64 verifyFormat("if (a + b + c +\n"
65 " d !==\n"
66 " e + f + g)\n"
Alexander Kornienkoa48a12c2013-12-03 10:50:16 +000067 " q();",
Alexander Kornienkoc1637f12013-12-10 11:28:13 +000068 getGoogleJSStyleWithColumns(20));
Alexander Kornienkoa48a12c2013-12-03 10:50:16 +000069
70 verifyFormat("a >> >= b;");
71
72 verifyFormat("a >>> b;");
Daniel Jaspere551bb72014-11-05 17:22:31 +000073 verifyFormat("aaaaaaa >>>\n b;", getGoogleJSStyleWithColumns(10));
Alexander Kornienkoa48a12c2013-12-03 10:50:16 +000074 verifyFormat("a >>>= b;");
Daniel Jaspere551bb72014-11-05 17:22:31 +000075 verifyFormat("aaaaaaa >>>=\n b;", getGoogleJSStyleWithColumns(10));
76 verifyFormat("if (a + b + c +\n"
77 " d >>>\n"
78 " e + f + g)\n"
Alexander Kornienkoa48a12c2013-12-03 10:50:16 +000079 " q();",
Alexander Kornienkoc1637f12013-12-10 11:28:13 +000080 getGoogleJSStyleWithColumns(20));
Daniel Jaspere551bb72014-11-05 17:22:31 +000081 verifyFormat("var x = aaaaaaaaaa ?\n"
82 " bbbbbb :\n"
83 " ccc;",
Alexander Kornienkoc1637f12013-12-10 11:28:13 +000084 getGoogleJSStyleWithColumns(20));
Daniel Jasper78214392014-05-19 07:27:02 +000085
86 verifyFormat("var b = a.map((x) => x + 1);");
Daniel Jasper3549ea12014-09-19 10:48:15 +000087 verifyFormat("return ('aaa') in bbbb;");
Daniel Jasper08051992015-05-26 07:18:56 +000088
89 // ES6 spread operator.
90 verifyFormat("someFunction(...a);");
91 verifyFormat("var x = [1, ...a, 2];");
Alexander Kornienkoa48a12c2013-12-03 10:50:16 +000092}
93
Daniel Jasper3a038de2014-09-05 08:53:45 +000094TEST_F(FormatTestJS, UnderstandsAmpAmp) {
95 verifyFormat("e && e.SomeFunction();");
96}
97
Daniel Jasper4db69bd2014-09-04 18:23:42 +000098TEST_F(FormatTestJS, LiteralOperatorsCanBeKeywords) {
99 verifyFormat("not.and.or.not_eq = 1;");
100}
101
Daniel Jasper0dd52912014-05-19 07:37:07 +0000102TEST_F(FormatTestJS, ES6DestructuringAssignment) {
103 verifyFormat("var [a, b, c] = [1, 2, 3];");
Daniel Jasper60948b12015-03-15 13:55:54 +0000104 verifyFormat("var {a, b} = {a: 1, b: 2};");
Daniel Jasper0dd52912014-05-19 07:37:07 +0000105}
106
Daniel Jasper17062ff2014-06-10 14:44:02 +0000107TEST_F(FormatTestJS, ContainerLiterals) {
Manuel Klimek79e06082015-05-21 12:23:34 +0000108 verifyFormat("var x = {y: function(a) { return a; }};");
Daniel Jasper17062ff2014-06-10 14:44:02 +0000109 verifyFormat("return {\n"
110 " link: function() {\n"
111 " f(); //\n"
112 " }\n"
113 "};");
114 verifyFormat("return {\n"
115 " a: a,\n"
116 " link: function() {\n"
117 " f(); //\n"
118 " }\n"
119 "};");
120 verifyFormat("return {\n"
121 " a: a,\n"
Daniel Jasper90ebc982014-09-05 09:27:38 +0000122 " link: function() {\n"
123 " f(); //\n"
124 " },\n"
125 " link: function() {\n"
126 " f(); //\n"
127 " }\n"
Daniel Jasper17062ff2014-06-10 14:44:02 +0000128 "};");
Daniel Jasper94e11d02014-09-04 14:58:30 +0000129 verifyFormat("var stuff = {\n"
130 " // comment for update\n"
131 " update: false,\n"
132 " // comment for modules\n"
133 " modules: false,\n"
134 " // comment for tasks\n"
135 " tasks: false\n"
136 "};");
Daniel Jasper97bfb7b2014-09-05 08:29:31 +0000137 verifyFormat("return {\n"
138 " 'finish':\n"
139 " //\n"
140 " a\n"
141 "};");
Daniel Jasper40874322014-11-27 15:24:48 +0000142 verifyFormat("var obj = {\n"
143 " fooooooooo: function(x) {\n"
144 " return x.zIsTooLongForOneLineWithTheDeclarationLine();\n"
145 " }\n"
146 "};");
Daniel Jasper60948b12015-03-15 13:55:54 +0000147 // Simple object literal, as opposed to enum style below.
148 verifyFormat("var obj = {a: 123};");
149 // Enum style top level assignment.
150 verifyFormat("X = {\n a: 123\n};");
151 verifyFormat("X.Y = {\n a: 123\n};");
Daniel Jasper11ca2632015-06-10 09:21:09 +0000152 // But only on the top level, otherwise its a plain object literal assignment.
153 verifyFormat("function x() {\n"
154 " y = {z: 1};\n"
155 "}");
Daniel Jasper60948b12015-03-15 13:55:54 +0000156 verifyFormat("x = foo && {a: 123};");
Manuel Klimek79e06082015-05-21 12:23:34 +0000157
158 // Arrow functions in object literals.
159 verifyFormat("var x = {y: (a) => { return a; }};");
160 verifyFormat("var x = {y: (a) => a};");
Daniel Jasper8c42d442015-05-29 06:19:49 +0000161
162 // Computed keys.
Daniel Jaspercd8d4ff2015-05-31 08:40:37 +0000163 verifyFormat("var x = {[a]: 1, b: 2, [c]: 3};");
Daniel Jasper8c42d442015-05-29 06:19:49 +0000164 verifyFormat("var x = {\n"
165 " [a]: 1,\n"
Daniel Jaspercd8d4ff2015-05-31 08:40:37 +0000166 " b: 2,\n"
167 " [c]: 3,\n"
Daniel Jasper8c42d442015-05-29 06:19:49 +0000168 "};");
Daniel Jasper17062ff2014-06-10 14:44:02 +0000169}
170
Daniel Jasperf46dec82015-03-31 14:34:15 +0000171TEST_F(FormatTestJS, MethodsInObjectLiterals) {
172 verifyFormat("var o = {\n"
173 " value: 'test',\n"
174 " get value() { // getter\n"
175 " return this.value;\n"
176 " }\n"
177 "};");
178 verifyFormat("var o = {\n"
179 " value: 'test',\n"
180 " set value(val) { // setter\n"
181 " this.value = val;\n"
182 " }\n"
183 "};");
184 verifyFormat("var o = {\n"
185 " value: 'test',\n"
186 " someMethod(val) { // method\n"
187 " doSomething(this.value + val);\n"
188 " }\n"
189 "};");
Daniel Jasper739ec532015-04-04 07:56:55 +0000190 verifyFormat("var o = {\n"
191 " someMethod(val) { // method\n"
192 " doSomething(this.value + val);\n"
193 " },\n"
194 " someOtherMethod(val) { // method\n"
195 " doSomething(this.value + val);\n"
196 " }\n"
197 "};");
Daniel Jasperf46dec82015-03-31 14:34:15 +0000198}
199
Daniel Jasperb2e10a52014-01-15 15:09:08 +0000200TEST_F(FormatTestJS, SpacesInContainerLiterals) {
201 verifyFormat("var arr = [1, 2, 3];");
Daniel Jaspera4e55f42014-12-04 16:07:17 +0000202 verifyFormat("f({a: 1, b: 2, c: 3});");
Nico Weber514ecc82014-02-02 20:50:45 +0000203
Daniel Jasper2a958322014-05-21 13:26:58 +0000204 verifyFormat("var object_literal_with_long_name = {\n"
205 " a: 'aaaaaaaaaaaaaaaaaa',\n"
206 " b: 'bbbbbbbbbbbbbbbbbb'\n"
207 "};");
208
Daniel Jaspera4e55f42014-12-04 16:07:17 +0000209 verifyFormat("f({a: 1, b: 2, c: 3});",
Nico Weber514ecc82014-02-02 20:50:45 +0000210 getChromiumStyle(FormatStyle::LK_JavaScript));
Daniel Jaspera4e55f42014-12-04 16:07:17 +0000211 verifyFormat("f({'a': [{}]});");
Daniel Jasperb2e10a52014-01-15 15:09:08 +0000212}
213
Daniel Jasper86fee2f2014-01-31 12:49:42 +0000214TEST_F(FormatTestJS, SingleQuoteStrings) {
215 verifyFormat("this.function('', true);");
216}
217
Daniel Jasper4a39c842014-05-06 13:54:10 +0000218TEST_F(FormatTestJS, GoogScopes) {
219 verifyFormat("goog.scope(function() {\n"
220 "var x = a.b;\n"
221 "var y = c.d;\n"
222 "}); // goog.scope");
Daniel Jasper02c7bca2015-03-30 09:56:50 +0000223 verifyFormat("goog.scope(function() {\n"
224 "// test\n"
225 "var x = 0;\n"
226 "// test\n"
227 "});");
Daniel Jasper4a39c842014-05-06 13:54:10 +0000228}
229
Daniel Jasper616de8642014-11-23 16:46:28 +0000230TEST_F(FormatTestJS, GoogModules) {
231 verifyFormat("goog.module('this.is.really.absurdly.long');",
232 getGoogleJSStyleWithColumns(40));
233 verifyFormat("goog.require('this.is.really.absurdly.long');",
234 getGoogleJSStyleWithColumns(40));
235 verifyFormat("goog.provide('this.is.really.absurdly.long');",
236 getGoogleJSStyleWithColumns(40));
237 verifyFormat("var long = goog.require('this.is.really.absurdly.long');",
238 getGoogleJSStyleWithColumns(40));
Daniel Jasper53c38f42014-11-27 14:46:03 +0000239
240 // These should be wrapped normally.
241 verifyFormat(
242 "var MyLongClassName =\n"
243 " goog.module.get('my.long.module.name.followedBy.MyLongClassName');");
Daniel Jasper616de8642014-11-23 16:46:28 +0000244}
245
Daniel Jasperad9eb0d2014-06-30 13:24:54 +0000246TEST_F(FormatTestJS, FormatsFreestandingFunctions) {
247 verifyFormat("function outer1(a, b) {\n"
248 " function inner1(a, b) { return a; }\n"
249 " inner1(a, b);\n"
250 "}\n"
251 "function outer2(a, b) {\n"
252 " function inner2(a, b) { return a; }\n"
253 " inner2(a, b);\n"
254 "}");
Daniel Jasper20580fd2015-06-11 13:31:45 +0000255 verifyFormat("function f() {}");
Daniel Jasperad9eb0d2014-06-30 13:24:54 +0000256}
257
Daniel Jasperf841d3a2015-05-28 07:21:50 +0000258TEST_F(FormatTestJS, ArrayLiterals) {
Daniel Jasper9970df12015-06-03 08:57:36 +0000259 verifyFormat(
260 "var aaaaa: List<SomeThing> =\n"
261 " [new SomeThingAAAAAAAAAAAA(), new SomeThingBBBBBBBBB()];");
Daniel Jasperd492b5e2015-06-02 21:57:51 +0000262 verifyFormat("return [\n"
263 " aaaaaaaaaaaaaaaaaaaaaaaaaaa,\n"
264 " bbbbbbbbbbbbbbbbbbbbbbbbbbb,\n"
265 " ccccccccccccccccccccccccccc\n"
266 "];");
Daniel Jasper5ce80de2015-06-02 13:56:43 +0000267 verifyFormat("var someVariable = SomeFuntion([\n"
268 " aaaaaaaaaaaaaaaaaaaaaaaaaaa,\n"
269 " bbbbbbbbbbbbbbbbbbbbbbbbbbb,\n"
270 " ccccccccccccccccccccccccccc\n"
271 "]);");
Daniel Jasper40432ce2015-06-02 15:04:29 +0000272 verifyFormat("var someVariable = SomeFuntion([\n"
273 " [aaaaaaaaaaaaaaaaaaaaaa, bbbbbbbbbbbbbbbbbbbbbb],\n"
Daniel Jasper199d0c92015-06-02 15:14:21 +0000274 "]);",
275 getGoogleJSStyleWithColumns(51));
Daniel Jasper4284e362015-06-02 14:20:08 +0000276 verifyFormat("var someVariable = SomeFuntion(aaaa, [\n"
277 " aaaaaaaaaaaaaaaaaaaaaaaaaaa,\n"
278 " bbbbbbbbbbbbbbbbbbbbbbbbbbb,\n"
279 " ccccccccccccccccccccccccccc\n"
280 "]);");
Daniel Jasperb2ad4d42015-06-15 09:23:17 +0000281 verifyFormat("var someVariable = SomeFuntion(aaaa,\n"
282 " [\n"
283 " aaaaaaaaaaaaaaaaaaaaaaaaaaa,\n"
284 " bbbbbbbbbbbbbbbbbbbbbbbbbbb,\n"
285 " ccccccccccccccccccccccccccc\n"
286 " ],\n"
287 " aaaa);");
Daniel Jasper1feab0f2015-06-02 15:31:37 +0000288
289 verifyFormat("someFunction([], {a: a});");
Daniel Jasperf841d3a2015-05-28 07:21:50 +0000290}
291
Daniel Jasper5217a8b2014-06-13 07:02:04 +0000292TEST_F(FormatTestJS, FunctionLiterals) {
Daniel Jasper3f69ba12014-09-05 08:42:27 +0000293 verifyFormat("doFoo(function() {});");
Daniel Jasper79dffb42014-05-07 09:48:30 +0000294 verifyFormat("doFoo(function() { return 1; });");
Daniel Jasper67f8ad22014-09-30 17:57:06 +0000295 verifyFormat("var func = function() {\n"
296 " return 1;\n"
297 "};");
Daniel Jasperc03e16a2014-05-08 09:25:39 +0000298 verifyFormat("return {\n"
299 " body: {\n"
300 " setAttribute: function(key, val) { this[key] = val; },\n"
301 " getAttribute: function(key) { return this[key]; },\n"
302 " style: {direction: ''}\n"
303 " }\n"
304 "};");
Daniel Jaspere551bb72014-11-05 17:22:31 +0000305 EXPECT_EQ("abc = xyz ?\n"
306 " function() {\n"
307 " return 1;\n"
308 " } :\n"
309 " function() {\n"
Daniel Jasper11a0ac62014-12-12 09:40:58 +0000310 " return -1;\n"
311 " };",
Daniel Jasper069e5f42014-05-20 11:14:57 +0000312 format("abc=xyz?function(){return 1;}:function(){return -1;};"));
Daniel Jasperb16b9692014-05-21 12:51:23 +0000313
314 verifyFormat("var closure = goog.bind(\n"
315 " function() { // comment\n"
316 " foo();\n"
317 " bar();\n"
318 " },\n"
319 " this, arg1IsReallyLongAndNeeedsLineBreaks,\n"
320 " arg3IsReallyLongAndNeeedsLineBreaks);");
321 verifyFormat("var closure = goog.bind(function() { // comment\n"
322 " foo();\n"
323 " bar();\n"
324 "}, this);");
Daniel Jasper58cb2ed2014-06-06 13:49:04 +0000325 verifyFormat("return {\n"
326 " a: 'E',\n"
327 " b: function() {\n"
328 " return function() {\n"
329 " f(); //\n"
330 " };\n"
331 " }\n"
332 "};");
Daniel Jasper41368e92014-11-27 15:37:42 +0000333 verifyFormat("{\n"
334 " var someVariable = function(x) {\n"
335 " return x.zIsTooLongForOneLineWithTheDeclarationLine();\n"
336 " };\n"
337 "}");
Daniel Jasper7325aee2015-05-08 08:38:52 +0000338 verifyFormat("someLooooooooongFunction(\n"
339 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa,\n"
340 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa,\n"
341 " function(aaaaaaaaaaaaaaaaaaaaaaaaaaaaa) {\n"
342 " // code\n"
343 " });");
Daniel Jasper5f3ea472014-05-22 08:36:53 +0000344
Daniel Jaspera4e55f42014-12-04 16:07:17 +0000345 verifyFormat("f({a: function() { return 1; }});",
346 getGoogleJSStyleWithColumns(33));
347 verifyFormat("f({\n"
Daniel Jasper5f3ea472014-05-22 08:36:53 +0000348 " a: function() { return 1; }\n"
Daniel Jaspera4e55f42014-12-04 16:07:17 +0000349 "});",
350 getGoogleJSStyleWithColumns(32));
Daniel Jasper5217a8b2014-06-13 07:02:04 +0000351
352 verifyFormat("return {\n"
353 " a: function SomeFunction() {\n"
354 " // ...\n"
355 " return 1;\n"
356 " }\n"
357 "};");
Daniel Jasper11a0ac62014-12-12 09:40:58 +0000358 verifyFormat("this.someObject.doSomething(aaaaaaaaaaaaaaaaaaaaaaaaaa)\n"
359 " .then(goog.bind(function(aaaaaaaaaaa) {\n"
360 " someFunction();\n"
361 " someFunction();\n"
362 " }, this), aaaaaaaaaaaaaaaaa);");
363
364 // FIXME: This is not ideal yet.
365 verifyFormat("someFunction(goog.bind(\n"
366 " function() {\n"
367 " doSomething();\n"
368 " doSomething();\n"
369 " },\n"
370 " this),\n"
371 " goog.bind(function() {\n"
372 " doSomething();\n"
373 " doSomething();\n"
374 " }, this));");
Daniel Jasper1699eca2015-06-01 09:56:32 +0000375
376 // FIXME: This is bad, we should be wrapping before "function() {".
377 verifyFormat("someFunction(function() {\n"
378 " doSomething(); // break\n"
379 "})\n"
380 " .doSomethingElse(\n"
381 " // break\n"
382 " );");
Daniel Jasper79dffb42014-05-07 09:48:30 +0000383}
384
Daniel Jasper67f8ad22014-09-30 17:57:06 +0000385TEST_F(FormatTestJS, InliningFunctionLiterals) {
386 FormatStyle Style = getGoogleStyle(FormatStyle::LK_JavaScript);
387 Style.AllowShortFunctionsOnASingleLine = FormatStyle::SFS_Inline;
388 verifyFormat("var func = function() {\n"
389 " return 1;\n"
390 "};",
391 Style);
392 verifyFormat("var func = doSomething(function() { return 1; });", Style);
393 verifyFormat("var outer = function() {\n"
394 " var inner = function() { return 1; }\n"
395 "};",
396 Style);
397 verifyFormat("function outer1(a, b) {\n"
398 " function inner1(a, b) { return a; }\n"
399 "}",
400 Style);
401
402 Style.AllowShortFunctionsOnASingleLine = FormatStyle::SFS_All;
403 verifyFormat("var func = function() { return 1; };", Style);
404 verifyFormat("var func = doSomething(function() { return 1; });", Style);
405 verifyFormat(
406 "var outer = function() { var inner = function() { return 1; } };",
407 Style);
408 verifyFormat("function outer1(a, b) {\n"
409 " function inner1(a, b) { return a; }\n"
410 "}",
411 Style);
412
413 Style.AllowShortFunctionsOnASingleLine = FormatStyle::SFS_None;
414 verifyFormat("var func = function() {\n"
415 " return 1;\n"
416 "};",
417 Style);
418 verifyFormat("var func = doSomething(function() {\n"
419 " return 1;\n"
420 "});",
421 Style);
422 verifyFormat("var outer = function() {\n"
423 " var inner = function() {\n"
424 " return 1;\n"
425 " }\n"
426 "};",
427 Style);
428 verifyFormat("function outer1(a, b) {\n"
429 " function inner1(a, b) {\n"
430 " return a;\n"
431 " }\n"
432 "}",
433 Style);
434}
435
Daniel Jasper114a2bc2014-06-03 12:02:45 +0000436TEST_F(FormatTestJS, MultipleFunctionLiterals) {
437 verifyFormat("promise.then(\n"
438 " function success() {\n"
439 " doFoo();\n"
440 " doBar();\n"
441 " },\n"
442 " function error() {\n"
443 " doFoo();\n"
444 " doBaz();\n"
445 " },\n"
446 " []);\n");
447 verifyFormat("promise.then(\n"
448 " function success() {\n"
449 " doFoo();\n"
450 " doBar();\n"
451 " },\n"
452 " [],\n"
453 " function error() {\n"
454 " doFoo();\n"
455 " doBaz();\n"
456 " });\n");
457 // FIXME: Here, we should probably break right after the "(" for consistency.
458 verifyFormat("promise.then([],\n"
459 " function success() {\n"
460 " doFoo();\n"
461 " doBar();\n"
462 " },\n"
463 " function error() {\n"
464 " doFoo();\n"
465 " doBaz();\n"
466 " });\n");
Daniel Jasper1779d432014-09-29 07:54:54 +0000467
468 verifyFormat("getSomeLongPromise()\n"
469 " .then(function(value) { body(); })\n"
Daniel Jasper11a0ac62014-12-12 09:40:58 +0000470 " .thenCatch(function(error) {\n"
471 " body();\n"
472 " body();\n"
473 " });");
Daniel Jasper1779d432014-09-29 07:54:54 +0000474 verifyFormat("getSomeLongPromise()\n"
475 " .then(function(value) {\n"
476 " body();\n"
477 " body();\n"
478 " })\n"
479 " .thenCatch(function(error) {\n"
480 " body();\n"
481 " body();\n"
482 " });");
Daniel Jasper11a0ac62014-12-12 09:40:58 +0000483
Daniel Jasperacf67e32015-04-07 08:20:35 +0000484 verifyFormat("getSomeLongPromise()\n"
485 " .then(function(value) { body(); })\n"
486 " .thenCatch(function(error) { body(); });");
Daniel Jasper114a2bc2014-06-03 12:02:45 +0000487}
488
Manuel Klimek79e06082015-05-21 12:23:34 +0000489TEST_F(FormatTestJS, ArrowFunctions) {
490 verifyFormat("var x = (a) => {\n"
491 " return a;\n"
492 "};");
493 verifyFormat("var x = (a) => {\n"
494 " function y() { return 42; }\n"
495 " return a;\n"
496 "};");
497 verifyFormat("var x = (a: type): {some: type} => {\n"
498 " return a;\n"
499 "};");
500 verifyFormat("var x = (a) => a;");
Daniel Jaspere497bed2015-06-02 22:06:07 +0000501 verifyFormat("return () => [];");
Daniel Jasper3c306e82015-06-03 17:08:40 +0000502 verifyFormat("var aaaaaaaaaaaaaaaaaaaa = {\n"
503 " aaaaaaaaaaaaaaaaaaaaaaaaaaaa:\n"
504 " (aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa,\n"
505 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa) =>\n"
Daniel Jasper3b0f3042015-06-05 08:25:37 +0000506 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa,\n"
Daniel Jasper3c306e82015-06-03 17:08:40 +0000507 "};");
Daniel Jasper3b0f3042015-06-05 08:25:37 +0000508 verifyFormat(
509 "var a = a.aaaaaaa((a: a) => aaaaaaaaaaaaaaaaaaaaa(bbbbbbbbb) &&\n"
510 " aaaaaaaaaaaaaaaaaaaaa(bbbbbbb));");
511 verifyFormat(
512 "var a = a.aaaaaaa((a: a) => aaaaaaaaaaaaaaaaaaaaa(bbbbbbbbb) ?\n"
513 " aaaaaaaaaaaaaaaaaaaaa(bbbbbbb) :\n"
514 " aaaaaaaaaaaaaaaaaaaaa(bbbbbbb));");
Daniel Jasper1699eca2015-06-01 09:56:32 +0000515
516 // FIXME: This is bad, we should be wrapping before "() => {".
517 verifyFormat("someFunction(() => {\n"
518 " doSomething(); // break\n"
519 "})\n"
520 " .doSomethingElse(\n"
521 " // break\n"
522 " );");
Manuel Klimek79e06082015-05-21 12:23:34 +0000523}
524
Daniel Jasper166c19b2014-05-06 14:12:21 +0000525TEST_F(FormatTestJS, ReturnStatements) {
Daniel Jasper67f8ad22014-09-30 17:57:06 +0000526 verifyFormat("function() {\n"
527 " return [hello, world];\n"
528 "}");
Daniel Jasper166c19b2014-05-06 14:12:21 +0000529}
530
Daniel Jasper4c0bf702015-06-12 04:58:27 +0000531TEST_F(FormatTestJS, AutomaticSemicolonInsertion) {
532 // The following statements must not wrap, as otherwise the program meaning
533 // would change due to automatic semicolon insertion.
534 // See http://www.ecma-international.org/ecma-262/5.1/#sec-7.9.1.
535 verifyFormat("return aaaaa;", getGoogleJSStyleWithColumns(10));
536 verifyFormat("continue aaaaa;", getGoogleJSStyleWithColumns(10));
537 verifyFormat("break aaaaa;", getGoogleJSStyleWithColumns(10));
538 verifyFormat("throw aaaaa;", getGoogleJSStyleWithColumns(10));
539 verifyFormat("aaaaaaaaa++;", getGoogleJSStyleWithColumns(10));
540 verifyFormat("aaaaaaaaa--;", getGoogleJSStyleWithColumns(10));
541}
542
Manuel Klimek79e06082015-05-21 12:23:34 +0000543TEST_F(FormatTestJS, ClosureStyleCasts) {
Daniel Jasper484033b2014-05-06 14:41:29 +0000544 verifyFormat("var x = /** @type {foo} */ (bar);");
545}
546
Daniel Jasper04a71a42014-05-08 11:58:24 +0000547TEST_F(FormatTestJS, TryCatch) {
548 verifyFormat("try {\n"
549 " f();\n"
550 "} catch (e) {\n"
551 " g();\n"
552 "} finally {\n"
553 " h();\n"
554 "}");
Daniel Jasper8f2e94c2014-09-04 15:03:34 +0000555
556 // But, of course, "catch" is a perfectly fine function name in JavaScript.
557 verifyFormat("someObject.catch();");
Daniel Jasper79121232014-11-27 14:55:17 +0000558 verifyFormat("someObject.new();");
559 verifyFormat("someObject.delete();");
Daniel Jasper04a71a42014-05-08 11:58:24 +0000560}
561
Daniel Jasper49802ef2014-05-22 09:10:04 +0000562TEST_F(FormatTestJS, StringLiteralConcatenation) {
563 verifyFormat("var literal = 'hello ' +\n"
564 " 'world';");
565}
566
Daniel Jasperf9ae3122014-05-08 07:01:45 +0000567TEST_F(FormatTestJS, RegexLiteralClassification) {
568 // Regex literals.
569 verifyFormat("var regex = /abc/;");
570 verifyFormat("f(/abc/);");
571 verifyFormat("f(abc, /abc/);");
572 verifyFormat("some_map[/abc/];");
573 verifyFormat("var x = a ? /abc/ : /abc/;");
574 verifyFormat("for (var i = 0; /abc/.test(s[i]); i++) {\n}");
575 verifyFormat("var x = !/abc/.test(y);");
576 verifyFormat("var x = a && /abc/.test(y);");
577 verifyFormat("var x = a || /abc/.test(y);");
578 verifyFormat("var x = a + /abc/.search(y);");
Daniel Jasperf7405c12014-05-08 07:45:18 +0000579 verifyFormat("var regexs = {/abc/, /abc/};");
580 verifyFormat("return /abc/;");
Daniel Jasperf9ae3122014-05-08 07:01:45 +0000581
582 // Not regex literals.
583 verifyFormat("var a = a / 2 + b / 3;");
584}
585
586TEST_F(FormatTestJS, RegexLiteralSpecialCharacters) {
Daniel Jasper69694b02015-05-08 07:55:13 +0000587 verifyFormat("var regex = /=/;");
Daniel Jasperf9ae3122014-05-08 07:01:45 +0000588 verifyFormat("var regex = /a*/;");
589 verifyFormat("var regex = /a+/;");
590 verifyFormat("var regex = /a?/;");
591 verifyFormat("var regex = /.a./;");
592 verifyFormat("var regex = /a\\*/;");
593 verifyFormat("var regex = /^a$/;");
594 verifyFormat("var regex = /\\/a/;");
595 verifyFormat("var regex = /(?:x)/;");
596 verifyFormat("var regex = /x(?=y)/;");
597 verifyFormat("var regex = /x(?!y)/;");
598 verifyFormat("var regex = /x|y/;");
599 verifyFormat("var regex = /a{2}/;");
600 verifyFormat("var regex = /a{1,3}/;");
601 verifyFormat("var regex = /[abc]/;");
602 verifyFormat("var regex = /[^abc]/;");
603 verifyFormat("var regex = /[\\b]/;");
604 verifyFormat("var regex = /\\b/;");
605 verifyFormat("var regex = /\\B/;");
606 verifyFormat("var regex = /\\d/;");
607 verifyFormat("var regex = /\\D/;");
608 verifyFormat("var regex = /\\f/;");
609 verifyFormat("var regex = /\\n/;");
610 verifyFormat("var regex = /\\r/;");
611 verifyFormat("var regex = /\\s/;");
612 verifyFormat("var regex = /\\S/;");
613 verifyFormat("var regex = /\\t/;");
614 verifyFormat("var regex = /\\v/;");
615 verifyFormat("var regex = /\\w/;");
616 verifyFormat("var regex = /\\W/;");
617 verifyFormat("var regex = /a(a)\\1/;");
618 verifyFormat("var regex = /\\0/;");
Daniel Jasperfb4333b2014-05-12 11:29:50 +0000619 verifyFormat("var regex = /\\\\/g;");
620 verifyFormat("var regex = /\\a\\\\/g;");
621 verifyFormat("var regex = /\a\\//g;");
Daniel Jasper23376252014-09-09 14:37:39 +0000622 verifyFormat("var regex = /a\\//;\n"
623 "var x = 0;");
Daniel Jasper49a9a282014-10-29 16:51:38 +0000624 EXPECT_EQ("var regex = /\\/*/;\n"
625 "var x = 0;",
626 format("var regex = /\\/*/;\n"
627 "var x=0;"));
Daniel Jasperf9ae3122014-05-08 07:01:45 +0000628}
629
630TEST_F(FormatTestJS, RegexLiteralModifiers) {
631 verifyFormat("var regex = /abc/g;");
632 verifyFormat("var regex = /abc/i;");
633 verifyFormat("var regex = /abc/m;");
634 verifyFormat("var regex = /abc/y;");
635}
636
637TEST_F(FormatTestJS, RegexLiteralLength) {
638 verifyFormat("var regex = /aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa/;",
639 getGoogleJSStyleWithColumns(60));
640 verifyFormat("var regex =\n"
641 " /aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa/;",
642 getGoogleJSStyleWithColumns(60));
Daniel Jasper0580ff02014-12-17 09:11:08 +0000643 verifyFormat("var regex = /\\xaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa/;",
644 getGoogleJSStyleWithColumns(50));
Daniel Jasperf9ae3122014-05-08 07:01:45 +0000645}
646
647TEST_F(FormatTestJS, RegexLiteralExamples) {
648 verifyFormat("var regex = search.match(/(?:\?|&)times=([^?&]+)/i);");
649}
650
Daniel Jasperb10bdff2015-02-18 17:09:53 +0000651TEST_F(FormatTestJS, TypeAnnotations) {
652 verifyFormat("var x: string;");
653 verifyFormat("function x(): string {\n return 'x';\n}");
Manuel Klimek79e06082015-05-21 12:23:34 +0000654 verifyFormat("function x(): {x: string} {\n return {x: 'x'};\n}");
Daniel Jasperb10bdff2015-02-18 17:09:53 +0000655 verifyFormat("function x(y: string): string {\n return 'x';\n}");
656 verifyFormat("for (var y: string in x) {\n x();\n}");
657 verifyFormat("((a: string, b: number): string => a + b);");
658 verifyFormat("var x: (y: number) => string;");
659 verifyFormat("var x: P<string, (a: number) => string>;");
Manuel Klimek79e06082015-05-21 12:23:34 +0000660 verifyFormat("var x = {y: function(): z { return 1; }};");
661 verifyFormat("var x = {y: function(): {a: number} { return 1; }};");
Daniel Jasperb10bdff2015-02-18 17:09:53 +0000662}
663
Daniel Jasper83709082015-02-18 17:14:05 +0000664TEST_F(FormatTestJS, ClassDeclarations) {
665 verifyFormat("class C {\n x: string = 12;\n}");
666 verifyFormat("class C {\n x(): string => 12;\n}");
667 verifyFormat("class C {\n ['x' + 2]: string = 12;\n}");
668 verifyFormat("class C {\n private x: string = 12;\n}");
669 verifyFormat("class C {\n private static x: string = 12;\n}");
670 verifyFormat("class C {\n static x(): string { return 'asd'; }\n}");
671 verifyFormat("class C extends P implements I {}");
Daniel Jasper6a5d38d2015-04-13 14:56:54 +0000672 verifyFormat("class C extends p.P implements i.I {}");
Daniel Jasper81dbb562015-06-03 08:43:18 +0000673
674 // ':' is not a type declaration here.
675 verifyFormat("class X {\n"
676 " subs = {\n"
677 " 'b': {\n"
678 " 'c': 1,\n"
679 " },\n"
680 " };\n"
681 "}");
Daniel Jasper83709082015-02-18 17:14:05 +0000682}
683
Daniel Jasper29647492015-05-05 08:12:50 +0000684TEST_F(FormatTestJS, InterfaceDeclarations) {
685 verifyFormat("interface I {\n"
686 " x: string;\n"
Daniel Jasper259188b2015-06-12 04:56:34 +0000687 "}\n"
688 "var y;");
Daniel Jasper29647492015-05-05 08:12:50 +0000689}
690
Daniel Jasper90cf3802015-06-17 09:44:02 +0000691TEST_F(FormatTestJS, EnumDeclarations) {
692 verifyFormat("enum Foo {\n"
693 " A = 1, // comment\n"
694 " B\n"
695 "}\n"
696 "var x = 1;");
697}
698
Daniel Jasper3c42dba2015-02-18 17:17:15 +0000699TEST_F(FormatTestJS, MetadataAnnotations) {
700 verifyFormat("@A\nclass C {\n}");
701 verifyFormat("@A({arg: 'value'})\nclass C {\n}");
702 verifyFormat("@A\n@B\nclass C {\n}");
703 verifyFormat("class C {\n @A x: string;\n}");
704 verifyFormat("class C {\n"
705 " @A\n"
706 " private x(): string {\n"
707 " return 'y';\n"
708 " }\n"
709 "}");
Daniel Jasper6fa9ec72015-02-19 16:03:16 +0000710 verifyFormat("class X {}\n"
711 "class Y {}");
Daniel Jasper3c42dba2015-02-18 17:17:15 +0000712}
713
Daniel Jasper354aa512015-02-19 16:07:32 +0000714TEST_F(FormatTestJS, Modules) {
715 verifyFormat("import SomeThing from 'some/module.js';");
716 verifyFormat("import {X, Y} from 'some/module.js';");
717 verifyFormat("import {\n"
718 " VeryLongImportsAreAnnoying,\n"
719 " VeryLongImportsAreAnnoying,\n"
720 " VeryLongImportsAreAnnoying,\n"
721 " VeryLongImportsAreAnnoying\n"
722 "} from 'some/module.js';");
723 verifyFormat("import {\n"
724 " X,\n"
725 " Y,\n"
726 "} from 'some/module.js';");
727 verifyFormat("import {\n"
728 " X,\n"
729 " Y,\n"
730 "} from 'some/long/module.js';",
731 getGoogleJSStyleWithColumns(20));
732 verifyFormat("import {X as myLocalX, Y as myLocalY} from 'some/module.js';");
733 verifyFormat("import * as lib from 'some/module.js';");
Daniel Jasper60948b12015-03-15 13:55:54 +0000734 verifyFormat("var x = {import: 1};\nx.import = 2;");
Daniel Jasperfca735c2015-02-19 16:14:18 +0000735
736 verifyFormat("export function fn() {\n"
737 " return 'fn';\n"
738 "}");
Daniel Jasper20580fd2015-06-11 13:31:45 +0000739 verifyFormat("export function A() {}\n"
740 "export default function B() {}\n"
741 "export function C() {}");
Daniel Jasper354aa512015-02-19 16:07:32 +0000742 verifyFormat("export const x = 12;");
743 verifyFormat("export default class X {}");
Daniel Jasperfca735c2015-02-19 16:14:18 +0000744 verifyFormat("export {X, Y} from 'some/module.js';");
745 verifyFormat("export {\n"
746 " X,\n"
747 " Y,\n"
748 "} from 'some/module.js';");
749 verifyFormat("export class C {\n"
750 " x: number;\n"
751 " y: string;\n"
752 "}");
753 verifyFormat("export class X { y: number; }");
754 verifyFormat("export default class X { y: number }");
755 verifyFormat("export default function() {\n return 1;\n}");
756 verifyFormat("export var x = 12;");
Daniel Jasper910807d2015-06-12 04:52:02 +0000757 verifyFormat("class C {}\n"
758 "export function f() {}\n"
759 "var v;");
Daniel Jasperfca735c2015-02-19 16:14:18 +0000760 verifyFormat("export var x: number = 12;");
761 verifyFormat("export const y = {\n"
762 " a: 1,\n"
763 " b: 2\n"
764 "};");
Daniel Jasper216c9cd2015-06-12 05:08:18 +0000765 verifyFormat("export enum Foo {\n"
766 " BAR,\n"
767 " // adsdasd\n"
768 " BAZ\n"
769 "}");
Daniel Jasper354aa512015-02-19 16:07:32 +0000770}
771
Daniel Jaspera0ef4f32015-02-20 13:47:38 +0000772TEST_F(FormatTestJS, TemplateStrings) {
773 // Keeps any whitespace/indentation within the template string.
774 EXPECT_EQ("var x = `hello\n"
775 " ${ name }\n"
776 " !`;",
777 format("var x = `hello\n"
778 " ${ name }\n"
779 " !`;"));
780
781 // FIXME: +1 / -1 offsets are to work around clang-format miscalculating
782 // widths for unknown tokens that are not whitespace (e.g. '`'). Remove when
783 // the code is corrected.
784
785 verifyFormat("var x =\n"
786 " `hello ${world}` >= some();",
787 getGoogleJSStyleWithColumns(34)); // Barely doesn't fit.
788 verifyFormat("var x = `hello ${world}` >= some();",
789 getGoogleJSStyleWithColumns(35 + 1)); // Barely fits.
790 EXPECT_EQ("var x = `hello\n"
791 " ${world}` >=\n"
792 " some();",
793 format("var x =\n"
794 " `hello\n"
795 " ${world}` >= some();",
796 getGoogleJSStyleWithColumns(21))); // Barely doesn't fit.
797 EXPECT_EQ("var x = `hello\n"
798 " ${world}` >= some();",
799 format("var x =\n"
800 " `hello\n"
801 " ${world}` >= some();",
802 getGoogleJSStyleWithColumns(22))); // Barely fits.
803
804 verifyFormat("var x =\n `h`;", getGoogleJSStyleWithColumns(13 - 1));
805 EXPECT_EQ(
806 "var x =\n `multi\n line`;",
807 format("var x = `multi\n line`;", getGoogleJSStyleWithColumns(14 - 1)));
808
Daniel Jasperf69b9222015-05-02 08:05:38 +0000809 // Make sure template strings get a proper ColumnWidth assigned, even if they
810 // are first token in line.
811 verifyFormat(
812 "var a = aaaaaaaaaaaaaaaaaaaaaaaaaaaa ||\n"
813 " `aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa`;");
814
Daniel Jaspera0ef4f32015-02-20 13:47:38 +0000815 // Two template strings.
816 verifyFormat("var x = `hello` == `hello`;");
Daniel Jasper0d6ac272015-04-16 08:20:51 +0000817
818 // Comments in template strings.
819 EXPECT_EQ("var x = `//a`;\n"
820 "var y;",
821 format("var x =\n `//a`;\n"
822 "var y ;"));
823 EXPECT_EQ("var x = `/*a`;\n"
824 "var y;",
825 format("var x =\n `/*a`;\n"
826 "var y;"));
Daniel Jasper2ebb0c52015-06-14 07:16:57 +0000827 // Unterminated string literals in a template string.
828 verifyFormat("var x = `'`; // comment with matching quote '\n"
829 "var y;");
830 verifyFormat("var x = `\"`; // comment with matching quote \"\n"
831 "var y;");
Daniel Jasper0d6ac272015-04-16 08:20:51 +0000832 // Backticks in a comment - not a template string.
833 EXPECT_EQ("var x = 1 // `/*a`;\n"
834 " ;",
835 format("var x =\n 1 // `/*a`;\n"
836 " ;"));
837 EXPECT_EQ("/* ` */ var x = 1; /* ` */",
838 format("/* ` */ var x\n= 1; /* ` */"));
839 // Comment spans multiple template strings.
840 EXPECT_EQ("var x = `/*a`;\n"
841 "var y = ` */ `;",
842 format("var x =\n `/*a`;\n"
843 "var y =\n ` */ `;"));
844 // Escaped backtick.
845 EXPECT_EQ("var x = ` \\` a`;\n"
846 "var y;",
847 format("var x = ` \\` a`;\n"
848 "var y;"));
Daniel Jaspera0ef4f32015-02-20 13:47:38 +0000849}
850
Daniel Jasperbc46b932015-03-15 13:59:51 +0000851TEST_F(FormatTestJS, CastSyntax) {
852 verifyFormat("var x = <type>foo;");
853}
854
855TEST_F(FormatTestJS, TypeArguments) {
856 verifyFormat("class X<Y> {}");
857 verifyFormat("new X<Y>();");
858 verifyFormat("foo<Y>(a);");
859 verifyFormat("var x: X<Y>[];");
860 verifyFormat("class C extends D<E> implements F<G>, H<I> {}");
Daniel Jasper20580fd2015-06-11 13:31:45 +0000861 verifyFormat("function f(a: List<any> = null) {}");
862 verifyFormat("function f(): List<any> {}");
Daniel Jasperbc46b932015-03-15 13:59:51 +0000863}
864
Daniel Jaspera74f5072015-04-13 15:01:40 +0000865TEST_F(FormatTestJS, OptionalTypes) {
Daniel Jasper20580fd2015-06-11 13:31:45 +0000866 verifyFormat("function x(a?: b, c?, d?) {}");
Daniel Jaspera74f5072015-04-13 15:01:40 +0000867 verifyFormat("class X {\n"
868 " y?: z;\n"
869 " z?;\n"
870 "}");
Daniel Jasper9326f912015-05-05 08:40:32 +0000871 verifyFormat("interface X {\n"
872 " y?(): z;\n"
873 "}");
874 verifyFormat("x ? 1 : 2;");
Daniel Jasper3e0dcc22015-05-27 05:37:40 +0000875 verifyFormat("constructor({aa}: {\n"
876 " aa?: string,\n"
877 " aaaaaaaa?: string,\n"
878 " aaaaaaaaaaaaaaa?: boolean,\n"
879 " aaaaaa?: List<string>\n"
Daniel Jasper20580fd2015-06-11 13:31:45 +0000880 "}) {}");
Daniel Jaspera74f5072015-04-13 15:01:40 +0000881}
882
Daniel Jasperd9309772015-04-13 15:03:30 +0000883TEST_F(FormatTestJS, IndexSignature) {
884 verifyFormat("var x: {[k: string]: v};");
885}
886
Alexander Kornienkoa48a12c2013-12-03 10:50:16 +0000887} // end namespace tooling
888} // end namespace clang