blob: 5ea531f350e63a4720f62479258a02a2f03f6958 [file] [log] [blame]
Daniel Jasperf7935112012-12-03 18:12:45 +00001//===- unittest/Format/FormatTest.cpp - Formatting unit tests -------------===//
2//
3// The LLVM Compiler Infrastructure
4//
5// This file is distributed under the University of Illinois Open Source
6// License. See LICENSE.TXT for details.
7//
8//===----------------------------------------------------------------------===//
9
Manuel Klimek24998102013-01-16 14:55:28 +000010#define DEBUG_TYPE "format-test"
11
Chandler Carruth320d9662012-12-04 09:45:34 +000012#include "clang/Format/Format.h"
Chandler Carruth4b417452013-01-19 08:09:44 +000013#include "clang/Lex/Lexer.h"
14#include "llvm/Support/Debug.h"
15#include "gtest/gtest.h"
Manuel Klimek24998102013-01-16 14:55:28 +000016
Daniel Jasperf7935112012-12-03 18:12:45 +000017namespace clang {
18namespace format {
19
20class FormatTest : public ::testing::Test {
21protected:
22 std::string format(llvm::StringRef Code, unsigned Offset, unsigned Length,
23 const FormatStyle &Style) {
Manuel Klimek24998102013-01-16 14:55:28 +000024 DEBUG(llvm::errs() << "---\n");
Daniel Jasperec04c0d2013-05-16 10:40:07 +000025 std::vector<tooling::Range> Ranges(1, tooling::Range(Offset, Length));
26 tooling::Replacements Replaces = reformat(Style, Code, Ranges);
27 ReplacementCount = Replaces.size();
28 std::string Result = applyAllReplacements(Code, Replaces);
29 EXPECT_NE("", Result);
30 DEBUG(llvm::errs() << "\n" << Result << "\n\n");
31 return Result;
Daniel Jasperf7935112012-12-03 18:12:45 +000032 }
33
Daniel Jasper2ec3ffb82013-02-18 11:59:17 +000034 std::string
35 format(llvm::StringRef Code, const FormatStyle &Style = getLLVMStyle()) {
Daniel Jasperf7935112012-12-03 18:12:45 +000036 return format(Code, 0, Code.size(), Style);
37 }
38
Daniel Jasper3f69a1b2012-12-18 19:56:56 +000039 std::string messUp(llvm::StringRef Code) {
40 std::string MessedUp(Code.str());
41 bool InComment = false;
Manuel Klimek52b15152013-01-09 15:25:02 +000042 bool InPreprocessorDirective = false;
Daniel Jasper3f69a1b2012-12-18 19:56:56 +000043 bool JustReplacedNewline = false;
44 for (unsigned i = 0, e = MessedUp.size() - 1; i != e; ++i) {
45 if (MessedUp[i] == '/' && MessedUp[i + 1] == '/') {
46 if (JustReplacedNewline)
47 MessedUp[i - 1] = '\n';
48 InComment = true;
Daniel Jasper39825ea2013-01-14 15:40:57 +000049 } else if (MessedUp[i] == '#' && (JustReplacedNewline || i == 0)) {
Daniel Jasper2ec3ffb82013-02-18 11:59:17 +000050 if (i != 0)
51 MessedUp[i - 1] = '\n';
Manuel Klimek52b15152013-01-09 15:25:02 +000052 InPreprocessorDirective = true;
Manuel Klimek1abf7892013-01-04 23:34:14 +000053 } else if (MessedUp[i] == '\\' && MessedUp[i + 1] == '\n') {
54 MessedUp[i] = ' ';
Manuel Klimek52b15152013-01-09 15:25:02 +000055 MessedUp[i + 1] = ' ';
Daniel Jasper3f69a1b2012-12-18 19:56:56 +000056 } else if (MessedUp[i] == '\n') {
57 if (InComment) {
58 InComment = false;
Manuel Klimek52b15152013-01-09 15:25:02 +000059 } else if (InPreprocessorDirective) {
60 InPreprocessorDirective = false;
Daniel Jasper3f69a1b2012-12-18 19:56:56 +000061 } else {
62 JustReplacedNewline = true;
63 MessedUp[i] = ' ';
64 }
Manuel Klimek1abf7892013-01-04 23:34:14 +000065 } else if (MessedUp[i] != ' ') {
66 JustReplacedNewline = false;
Daniel Jasper3f69a1b2012-12-18 19:56:56 +000067 }
Daniel Jasperf7935112012-12-03 18:12:45 +000068 }
Daniel Jasper3f69a1b2012-12-18 19:56:56 +000069 return MessedUp;
70 }
71
Manuel Klimekb69e3c62013-01-02 18:33:23 +000072 FormatStyle getLLVMStyleWithColumns(unsigned ColumnLimit) {
73 FormatStyle Style = getLLVMStyle();
74 Style.ColumnLimit = ColumnLimit;
75 return Style;
76 }
77
Daniel Jasper1b750ed2013-01-14 16:24:39 +000078 FormatStyle getGoogleStyleWithColumns(unsigned ColumnLimit) {
79 FormatStyle Style = getGoogleStyle();
80 Style.ColumnLimit = ColumnLimit;
81 return Style;
82 }
83
Manuel Klimekb69e3c62013-01-02 18:33:23 +000084 void verifyFormat(llvm::StringRef Code,
85 const FormatStyle &Style = getLLVMStyle()) {
86 EXPECT_EQ(Code.str(), format(messUp(Code), Style));
Daniel Jasperf7935112012-12-03 18:12:45 +000087 }
88
89 void verifyGoogleFormat(llvm::StringRef Code) {
Manuel Klimekb69e3c62013-01-02 18:33:23 +000090 verifyFormat(Code, getGoogleStyle());
Daniel Jasperf7935112012-12-03 18:12:45 +000091 }
Daniel Jasper5b49f472013-01-23 12:10:53 +000092
93 void verifyIndependentOfContext(llvm::StringRef text) {
94 verifyFormat(text);
95 verifyFormat(llvm::Twine("void f() { " + text + " }").str());
96 }
Daniel Jasper7b038a22013-01-30 09:46:12 +000097
98 int ReplacementCount;
Daniel Jasperf7935112012-12-03 18:12:45 +000099};
100
Manuel Klimek52b15152013-01-09 15:25:02 +0000101TEST_F(FormatTest, MessUp) {
102 EXPECT_EQ("1 2 3", messUp("1 2 3"));
103 EXPECT_EQ("1 2 3\n", messUp("1\n2\n3\n"));
104 EXPECT_EQ("a\n//b\nc", messUp("a\n//b\nc"));
105 EXPECT_EQ("a\n#b\nc", messUp("a\n#b\nc"));
106 EXPECT_EQ("a\n#b c d\ne", messUp("a\n#b\\\nc\\\nd\ne"));
107}
108
Alexander Kornienko578fdd82012-12-06 18:03:27 +0000109//===----------------------------------------------------------------------===//
110// Basic function tests.
111//===----------------------------------------------------------------------===//
112
Daniel Jasperf7935112012-12-03 18:12:45 +0000113TEST_F(FormatTest, DoesNotChangeCorrectlyFormatedCode) {
114 EXPECT_EQ(";", format(";"));
115}
116
117TEST_F(FormatTest, FormatsGlobalStatementsAt0) {
118 EXPECT_EQ("int i;", format(" int i;"));
119 EXPECT_EQ("\nint i;", format(" \n\t \r int i;"));
120 EXPECT_EQ("int i;\nint j;", format(" int i; int j;"));
121 EXPECT_EQ("int i;\nint j;", format(" int i;\n int j;"));
122}
123
124TEST_F(FormatTest, FormatsUnwrappedLinesAtFirstFormat) {
125 EXPECT_EQ("int i;", format("int\ni;"));
126}
127
128TEST_F(FormatTest, FormatsNestedBlockStatements) {
Manuel Klimeke7d10a12013-01-10 13:24:24 +0000129 EXPECT_EQ("{\n {\n {}\n }\n}", format("{{{}}}"));
Daniel Jasperf7935112012-12-03 18:12:45 +0000130}
131
Alexander Kornienko578fdd82012-12-06 18:03:27 +0000132TEST_F(FormatTest, FormatsNestedCall) {
133 verifyFormat("Method(f1, f2(f3));");
134 verifyFormat("Method(f1(f2, f3()));");
Daniel Jasper48cb3b92013-01-13 08:19:51 +0000135 verifyFormat("Method(f1(f2, (f3())));");
Alexander Kornienko578fdd82012-12-06 18:03:27 +0000136}
137
Daniel Jasper14556742013-02-07 21:08:36 +0000138TEST_F(FormatTest, NestedNameSpecifiers) {
Daniel Jasper736c14f2013-01-16 07:19:28 +0000139 verifyFormat("vector< ::Type> v;");
Daniel Jasper14556742013-02-07 21:08:36 +0000140 verifyFormat("::ns::SomeFunction(::ns::SomeOtherFunction())");
Daniel Jasper736c14f2013-01-16 07:19:28 +0000141}
142
Daniel Jasper7b038a22013-01-30 09:46:12 +0000143TEST_F(FormatTest, OnlyGeneratesNecessaryReplacements) {
144 EXPECT_EQ("if (a) {\n"
145 " f();\n"
Daniel Jasper2ec3ffb82013-02-18 11:59:17 +0000146 "}",
147 format("if(a){f();}"));
Daniel Jasper7b038a22013-01-30 09:46:12 +0000148 EXPECT_EQ(4, ReplacementCount);
149 EXPECT_EQ("if (a) {\n"
150 " f();\n"
Daniel Jasper2ec3ffb82013-02-18 11:59:17 +0000151 "}",
152 format("if (a) {\n"
153 " f();\n"
154 "}"));
Daniel Jasper7b038a22013-01-30 09:46:12 +0000155 EXPECT_EQ(0, ReplacementCount);
156}
157
Daniel Jasper24570102013-02-14 09:58:41 +0000158TEST_F(FormatTest, RemovesTrailingWhitespaceOfFormattedLine) {
159 EXPECT_EQ("int a;\nint b;", format("int a; \nint b;", 0, 0, getLLVMStyle()));
Daniel Jaspera79064a2013-03-01 18:11:39 +0000160 EXPECT_EQ("int a;", format("int a; "));
161 EXPECT_EQ("int a;\n", format("int a; \n \n \n "));
162 EXPECT_EQ("int a;\nint b; ",
163 format("int a; \nint b; ", 0, 0, getLLVMStyle()));
Daniel Jasper24570102013-02-14 09:58:41 +0000164}
165
Daniel Jasper973c9422013-03-04 13:43:19 +0000166TEST_F(FormatTest, FormatsCorrectRegionForLeadingWhitespace) {
167 EXPECT_EQ("int b;\nint a;",
168 format("int b;\n int a;", 7, 0, getLLVMStyle()));
169 EXPECT_EQ("int b;\n int a;",
170 format("int b;\n int a;", 6, 0, getLLVMStyle()));
171
172 EXPECT_EQ("#define A \\\n"
173 " int a; \\\n"
174 " int b;",
175 format("#define A \\\n"
176 " int a; \\\n"
177 " int b;",
178 26, 0, getLLVMStyleWithColumns(12)));
179 EXPECT_EQ("#define A \\\n"
180 " int a; \\\n"
181 " int b;",
182 format("#define A \\\n"
183 " int a; \\\n"
184 " int b;",
185 25, 0, getLLVMStyleWithColumns(12)));
186}
187
Daniel Jasperf71cf3b2013-03-07 20:50:00 +0000188TEST_F(FormatTest, RemovesWhitespaceWhenTriggeredOnEmptyLine) {
189 EXPECT_EQ("int a;\n\n int b;",
190 format("int a;\n \n\n int b;", 7, 0, getLLVMStyle()));
191 EXPECT_EQ("int a;\n\n int b;",
192 format("int a;\n \n\n int b;", 9, 0, getLLVMStyle()));
193}
194
Daniel Jasper55d7ba62013-02-18 13:08:03 +0000195TEST_F(FormatTest, ReformatsMovedLines) {
196 EXPECT_EQ(
197 "template <typename T> T *getFETokenInfo() const {\n"
198 " return static_cast<T *>(FETokenInfo);\n"
199 "}\n"
200 " int a; // <- Should not be formatted",
201 format(
202 "template<typename T>\n"
203 "T *getFETokenInfo() const { return static_cast<T*>(FETokenInfo); }\n"
204 " int a; // <- Should not be formatted",
205 9, 5, getLLVMStyle()));
206}
207
Alexander Kornienko578fdd82012-12-06 18:03:27 +0000208//===----------------------------------------------------------------------===//
209// Tests for control statements.
210//===----------------------------------------------------------------------===//
211
Daniel Jaspercdd06622013-05-14 10:31:09 +0000212TEST_F(FormatTest, FormatIfWithoutCompoundStatement) {
Daniel Jasper1b750ed2013-01-14 16:24:39 +0000213 verifyFormat("if (true)\n f();\ng();");
214 verifyFormat("if (a)\n if (b)\n if (c)\n g();\nh();");
Alexander Kornienko578fdd82012-12-06 18:03:27 +0000215 verifyFormat("if (a)\n if (b) {\n f();\n }\ng();");
Daniel Jasperced17f82013-01-16 15:44:34 +0000216
Daniel Jasper3a685df2013-05-16 12:12:21 +0000217 FormatStyle AllowsMergedIf = getLLVMStyle();
Daniel Jasperced17f82013-01-16 15:44:34 +0000218 AllowsMergedIf.AllowShortIfStatementsOnASingleLine = true;
219 verifyFormat("if (a)\n"
220 " // comment\n"
Daniel Jasper2ec3ffb82013-02-18 11:59:17 +0000221 " f();",
222 AllowsMergedIf);
Daniel Jasper3a685df2013-05-16 12:12:21 +0000223 verifyFormat("if (a)\n"
224 " ;",
225 AllowsMergedIf);
226 verifyFormat("if (a)\n"
227 " if (b) return;",
228 AllowsMergedIf);
Daniel Jasperced17f82013-01-16 15:44:34 +0000229
Daniel Jasper3a685df2013-05-16 12:12:21 +0000230 verifyFormat("if (a) // Can't merge this\n"
Daniel Jasper2ec3ffb82013-02-18 11:59:17 +0000231 " f();\n",
232 AllowsMergedIf);
Daniel Jasperced17f82013-01-16 15:44:34 +0000233 verifyFormat("if (a) /* still don't merge */\n"
Daniel Jasper2ec3ffb82013-02-18 11:59:17 +0000234 " f();",
235 AllowsMergedIf);
Daniel Jasper3a685df2013-05-16 12:12:21 +0000236 verifyFormat("if (a) { // Never merge this\n"
Daniel Jasperced17f82013-01-16 15:44:34 +0000237 " f();\n"
Daniel Jasper2ec3ffb82013-02-18 11:59:17 +0000238 "}",
239 AllowsMergedIf);
Daniel Jasperced17f82013-01-16 15:44:34 +0000240 verifyFormat("if (a) { /* Never merge this */\n"
241 " f();\n"
Daniel Jasper2ec3ffb82013-02-18 11:59:17 +0000242 "}",
243 AllowsMergedIf);
Daniel Jasperced17f82013-01-16 15:44:34 +0000244
Daniel Jasper12f9d8e2013-05-14 09:30:02 +0000245 EXPECT_EQ("if (a) return;", format("if(a)\nreturn;", 7, 1, AllowsMergedIf));
Daniel Jasper3a685df2013-05-16 12:12:21 +0000246 EXPECT_EQ("if (a) return; // comment",
Daniel Jaspercdd06622013-05-14 10:31:09 +0000247 format("if(a)\nreturn; // comment", 20, 1, AllowsMergedIf));
Daniel Jasper12f9d8e2013-05-14 09:30:02 +0000248
Daniel Jasperced17f82013-01-16 15:44:34 +0000249 AllowsMergedIf.ColumnLimit = 14;
250 verifyFormat("if (a) return;", AllowsMergedIf);
Daniel Jasper3e9218e2013-01-14 16:02:06 +0000251 verifyFormat("if (aaaaaaaaa)\n"
Daniel Jasper2ec3ffb82013-02-18 11:59:17 +0000252 " return;",
253 AllowsMergedIf);
Daniel Jasperced17f82013-01-16 15:44:34 +0000254
255 AllowsMergedIf.ColumnLimit = 13;
256 verifyFormat("if (a)\n return;", AllowsMergedIf);
Alexander Kornienko578fdd82012-12-06 18:03:27 +0000257}
258
Daniel Jasper3a685df2013-05-16 12:12:21 +0000259TEST_F(FormatTest, FormatLoopsWithoutCompoundStatement) {
260 FormatStyle AllowsMergedLoops = getLLVMStyle();
261 AllowsMergedLoops.AllowShortLoopsOnASingleLine = true;
262 verifyFormat("while (true) continue;", AllowsMergedLoops);
263 verifyFormat("for (;;) continue;", AllowsMergedLoops);
264 verifyFormat("for (int &v : vec) v *= 2;", AllowsMergedLoops);
265 verifyFormat("while (true)\n"
266 " ;",
267 AllowsMergedLoops);
268 verifyFormat("for (;;)\n"
269 " ;",
270 AllowsMergedLoops);
271 verifyFormat("for (;;)\n"
272 " for (;;) continue;",
273 AllowsMergedLoops);
274 verifyFormat("for (;;) // Can't merge this\n"
275 " continue;",
276 AllowsMergedLoops);
277 verifyFormat("for (;;) /* still don't merge */\n"
278 " continue;",
279 AllowsMergedLoops);
280}
281
Alexander Kornienko578fdd82012-12-06 18:03:27 +0000282TEST_F(FormatTest, ParseIfElse) {
283 verifyFormat("if (true)\n"
284 " if (true)\n"
285 " if (true)\n"
286 " f();\n"
287 " else\n"
288 " g();\n"
289 " else\n"
290 " h();\n"
291 "else\n"
292 " i();");
293 verifyFormat("if (true)\n"
294 " if (true)\n"
295 " if (true) {\n"
Daniel Jasper1b750ed2013-01-14 16:24:39 +0000296 " if (true)\n"
297 " f();\n"
Alexander Kornienko578fdd82012-12-06 18:03:27 +0000298 " } else {\n"
299 " g();\n"
300 " }\n"
301 " else\n"
302 " h();\n"
303 "else {\n"
304 " i();\n"
305 "}");
306}
307
308TEST_F(FormatTest, ElseIf) {
Manuel Klimeka4fe1c12013-01-21 16:42:44 +0000309 verifyFormat("if (a) {\n} else if (b) {\n}");
Alexander Kornienko578fdd82012-12-06 18:03:27 +0000310 verifyFormat("if (a)\n"
311 " f();\n"
312 "else if (b)\n"
313 " g();\n"
314 "else\n"
315 " h();");
316}
317
Daniel Jasperf7935112012-12-03 18:12:45 +0000318TEST_F(FormatTest, FormatsForLoop) {
319 verifyFormat(
320 "for (int VeryVeryLongLoopVariable = 0; VeryVeryLongLoopVariable < 10;\n"
Alexander Kornienko37d6c942012-12-05 15:06:06 +0000321 " ++VeryVeryLongLoopVariable)\n"
322 " ;");
323 verifyFormat("for (;;)\n"
324 " f();");
Manuel Klimeka4fe1c12013-01-21 16:42:44 +0000325 verifyFormat("for (;;) {\n}");
Alexander Kornienko37d6c942012-12-05 15:06:06 +0000326 verifyFormat("for (;;) {\n"
327 " f();\n"
328 "}");
Daniel Jasper72463d32013-05-03 14:50:50 +0000329 verifyFormat("for (int i = 0; (i < 10); ++i) {\n}");
Daniel Jasperfbde69e2012-12-21 14:37:20 +0000330
331 verifyFormat(
332 "for (std::vector<UnwrappedLine>::iterator I = UnwrappedLines.begin(),\n"
333 " E = UnwrappedLines.end();\n"
Manuel Klimeka4fe1c12013-01-21 16:42:44 +0000334 " I != E; ++I) {\n}");
Daniel Jasperfbde69e2012-12-21 14:37:20 +0000335
336 verifyFormat(
337 "for (MachineFun::iterator IIII = PrevIt, EEEE = F.end(); IIII != EEEE;\n"
Manuel Klimeka4fe1c12013-01-21 16:42:44 +0000338 " ++IIIII) {\n}");
Daniel Jaspera628c982013-04-03 13:36:17 +0000339 verifyFormat("for (aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa aaaaaaaaaaa =\n"
340 " aaaaaaaaaaaaaaaa.aaaaaaaaaaaaaaa;\n"
Daniel Jasper2ec3ffb82013-02-18 11:59:17 +0000341 " aaaaaaaaaaa != aaaaaaaaaaaaaaaaaaa; ++aaaaaaaaaaa) {\n}");
Daniel Jasper37905f72013-02-21 15:00:29 +0000342 verifyFormat("for (llvm::ArrayRef<NamedDecl *>::iterator\n"
343 " I = FD->getDeclsInPrototypeScope().begin(),\n"
344 " E = FD->getDeclsInPrototypeScope().end();\n"
345 " I != E; ++I) {\n}");
Daniel Jasper48c62f92013-01-28 17:30:17 +0000346
347 // FIXME: Not sure whether we want extra identation in line 3 here:
348 verifyFormat(
349 "for (aaaaaaaaaaaaaaaaa aaaaaaaaaaa = aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa;\n"
350 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa !=\n"
Daniel Jasperd1ae3582013-03-20 12:37:50 +0000351 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa(\n"
352 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa);\n"
Daniel Jasper48c62f92013-01-28 17:30:17 +0000353 " ++aaaaaaaaaaa) {\n}");
Daniel Jasper2cf17bf2013-02-27 09:47:53 +0000354 verifyFormat("for (int aaaaaaaaaaa = 1; aaaaaaaaaaa <= bbbbbbbbbbbbbbb;\n"
355 " aaaaaaaaaaa++, bbbbbbbbbbbbbbbbb++) {\n"
356 "}");
Daniel Jaspera628c982013-04-03 13:36:17 +0000357 verifyFormat("for (some_namespace::SomeIterator iter( // force break\n"
358 " aaaaaaaaaa);\n"
359 " iter; ++iter) {\n"
360 "}");
Daniel Jasperf7f13c02013-02-04 07:30:30 +0000361
Daniel Jasper2cf17bf2013-02-27 09:47:53 +0000362 FormatStyle NoBinPacking = getLLVMStyle();
363 NoBinPacking.BinPackParameters = false;
364 verifyFormat("for (int aaaaaaaaaaa = 1;\n"
365 " aaaaaaaaaaa <= aaaaaaaaaaaaaaaaaaaaaa(aaaaaaaaaaaaaaaa,\n"
366 " aaaaaaaaaaaaaaaa,\n"
367 " aaaaaaaaaaaaaaaa,\n"
368 " aaaaaaaaaaaaaaaa);\n"
369 " aaaaaaaaaaa++, bbbbbbbbbbbbbbbbb++) {\n"
370 "}",
371 NoBinPacking);
372 verifyFormat(
Daniel Jaspercd8599e2013-02-23 21:01:55 +0000373 "for (std::vector<UnwrappedLine>::iterator I = UnwrappedLines.begin(),\n"
374 " E = UnwrappedLines.end();\n"
375 " I != E;\n"
Daniel Jasper2cf17bf2013-02-27 09:47:53 +0000376 " ++I) {\n}",
377 NoBinPacking);
Daniel Jasperf7935112012-12-03 18:12:45 +0000378}
379
Daniel Jasper0b41cbb2013-01-28 13:21:16 +0000380TEST_F(FormatTest, RangeBasedForLoops) {
381 verifyFormat("for (auto aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa :\n"
382 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa) {\n}");
383 verifyFormat("for (auto aaaaaaaaaaaaaaaaaaaaa :\n"
384 " aaaaaaaaaaaaaaaaa(aaaaaaaaaaaaaaaa, aaaaaaaaaaaaa)) {\n}");
Daniel Jasper16b35622013-02-26 13:18:08 +0000385 verifyFormat("for (const aaaaaaaaaaaaaaaaaaaaa &aaaaaaaaa :\n"
386 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa) {\n}");
Daniel Jasper0b41cbb2013-01-28 13:21:16 +0000387}
388
Daniel Jasperf7935112012-12-03 18:12:45 +0000389TEST_F(FormatTest, FormatsWhileLoop) {
Manuel Klimeka4fe1c12013-01-21 16:42:44 +0000390 verifyFormat("while (true) {\n}");
Alexander Kornienko37d6c942012-12-05 15:06:06 +0000391 verifyFormat("while (true)\n"
392 " f();");
Manuel Klimeka4fe1c12013-01-21 16:42:44 +0000393 verifyFormat("while () {\n}");
Alexander Kornienko37d6c942012-12-05 15:06:06 +0000394 verifyFormat("while () {\n"
395 " f();\n"
396 "}");
Daniel Jasperf7935112012-12-03 18:12:45 +0000397}
398
Alexander Kornienko578fdd82012-12-06 18:03:27 +0000399TEST_F(FormatTest, FormatsDoWhile) {
400 verifyFormat("do {\n"
401 " do_something();\n"
402 "} while (something());");
403 verifyFormat("do\n"
404 " do_something();\n"
405 "while (something());");
Daniel Jasperf7935112012-12-03 18:12:45 +0000406}
407
Alexander Kornienko578fdd82012-12-06 18:03:27 +0000408TEST_F(FormatTest, FormatsSwitchStatement) {
Daniel Jasperf7935112012-12-03 18:12:45 +0000409 verifyFormat("switch (x) {\n"
410 "case 1:\n"
411 " f();\n"
412 " break;\n"
413 "case kFoo:\n"
414 "case ns::kBar:\n"
415 "case kBaz:\n"
416 " break;\n"
417 "default:\n"
418 " g();\n"
419 " break;\n"
420 "}");
421 verifyFormat("switch (x) {\n"
422 "case 1: {\n"
423 " f();\n"
424 " break;\n"
425 "}\n"
426 "}");
Nico Webera5510af2013-01-18 05:50:57 +0000427 verifyFormat("switch (x) {\n"
428 "case 1: {\n"
429 " f();\n"
430 " {\n"
431 " g();\n"
432 " h();\n"
433 " }\n"
434 " break;\n"
435 "}\n"
436 "}");
437 verifyFormat("switch (x) {\n"
438 "case 1: {\n"
439 " f();\n"
440 " if (foo) {\n"
441 " g();\n"
442 " h();\n"
443 " }\n"
444 " break;\n"
445 "}\n"
446 "}");
447 verifyFormat("switch (x) {\n"
448 "case 1: {\n"
449 " f();\n"
450 " g();\n"
451 "} break;\n"
452 "}");
Daniel Jasperf7935112012-12-03 18:12:45 +0000453 verifyFormat("switch (test)\n"
454 " ;");
Daniel Jasper18104652013-03-12 12:26:55 +0000455 verifyFormat("switch (x) {\n"
456 "default: {\n"
457 " // Do nothing.\n"
Manuel Klimek1a18c402013-04-12 14:13:36 +0000458 "}\n"
Daniel Jasper18104652013-03-12 12:26:55 +0000459 "}");
Daniel Jasper0f8ed9e2013-03-13 15:53:12 +0000460 verifyFormat("switch (x) {\n"
Daniel Jasperb67cc422013-04-09 17:46:55 +0000461 "// comment\n"
Daniel Jasper0f8ed9e2013-03-13 15:53:12 +0000462 "// if 1, do f()\n"
463 "case 1:\n"
464 " f();\n"
465 "}");
Daniel Jasper2bd32ca2013-03-19 18:33:58 +0000466 verifyFormat("switch (x) {\n"
467 "case 1:\n"
468 " // Do amazing stuff\n"
469 " {\n"
470 " f();\n"
471 " g();\n"
472 " }\n"
473 " break;\n"
474 "}");
Daniel Jaspera1275122013-03-20 10:23:53 +0000475 verifyFormat("#define A \\\n"
476 " switch (x) { \\\n"
477 " case a: \\\n"
478 " foo = b; \\\n"
479 " }", getLLVMStyleWithColumns(20));
Daniel Jasper2ec3ffb82013-02-18 11:59:17 +0000480
Alexander Kornienko578fdd82012-12-06 18:03:27 +0000481 verifyGoogleFormat("switch (x) {\n"
482 " case 1:\n"
483 " f();\n"
484 " break;\n"
485 " case kFoo:\n"
486 " case ns::kBar:\n"
487 " case kBaz:\n"
488 " break;\n"
489 " default:\n"
490 " g();\n"
491 " break;\n"
492 "}");
493 verifyGoogleFormat("switch (x) {\n"
494 " case 1: {\n"
495 " f();\n"
496 " break;\n"
497 " }\n"
498 "}");
499 verifyGoogleFormat("switch (test)\n"
500 " ;");
Daniel Jasperf7935112012-12-03 18:12:45 +0000501}
502
Alexander Kornienko578fdd82012-12-06 18:03:27 +0000503TEST_F(FormatTest, FormatsLabels) {
Daniel Jasperf7935112012-12-03 18:12:45 +0000504 verifyFormat("void f() {\n"
505 " some_code();\n"
506 "test_label:\n"
507 " some_other_code();\n"
508 " {\n"
509 " some_more_code();\n"
510 " another_label:\n"
511 " some_more_code();\n"
512 " }\n"
513 "}");
514 verifyFormat("some_code();\n"
515 "test_label:\n"
516 "some_other_code();");
517}
518
Alexander Kornienko578fdd82012-12-06 18:03:27 +0000519//===----------------------------------------------------------------------===//
520// Tests for comments.
521//===----------------------------------------------------------------------===//
522
523TEST_F(FormatTest, UnderstandsSingleLineComments) {
Daniel Jasper55213652013-03-22 10:01:29 +0000524 verifyFormat("//* */");
Daniel Jasper3f69a1b2012-12-18 19:56:56 +0000525 verifyFormat("// line 1\n"
526 "// line 2\n"
Manuel Klimeke7d10a12013-01-10 13:24:24 +0000527 "void f() {}\n");
Alexander Kornienko578fdd82012-12-06 18:03:27 +0000528
Daniel Jasper3f69a1b2012-12-18 19:56:56 +0000529 verifyFormat("void f() {\n"
530 " // Doesn't do anything\n"
531 "}");
Daniel Jasperaa701fa2013-01-18 08:44:07 +0000532 verifyFormat("void f(int i, // some comment (probably for i)\n"
533 " int j, // some comment (probably for j)\n"
Daniel Jasper942ee722013-01-13 16:10:20 +0000534 " int k); // some comment (probably for k)");
535 verifyFormat("void f(int i,\n"
536 " // some comment (probably for j)\n"
537 " int j,\n"
538 " // some comment (probably for k)\n"
539 " int k);");
Alexander Kornienko578fdd82012-12-06 18:03:27 +0000540
Daniel Jasperaa701fa2013-01-18 08:44:07 +0000541 verifyFormat("int i // This is a fancy variable\n"
542 " = 5; // with nicely aligned comment.");
543
544 verifyFormat("// Leading comment.\n"
545 "int a; // Trailing comment.");
546 verifyFormat("int a; // Trailing comment\n"
547 " // on 2\n"
548 " // or 3 lines.\n"
549 "int b;");
550 verifyFormat("int a; // Trailing comment\n"
551 "\n"
552 "// Leading comment.\n"
553 "int b;");
554 verifyFormat("int a; // Comment.\n"
555 " // More details.\n"
556 "int bbbb; // Another comment.");
557 verifyFormat(
558 "int aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa; // comment\n"
559 "int bbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbb; // comment\n"
560 "int cccccccccccccccccccccccccccccc; // comment\n"
561 "int ddd; // looooooooooooooooooooooooong comment\n"
562 "int aaaaaaaaaaaaaaaaaaaaaaa; // comment\n"
563 "int bbbbbbbbbbbbbbbbbbbbb; // comment\n"
564 "int ccccccccccccccccccc; // comment");
565
Daniel Jasper997b08c2013-01-18 09:19:33 +0000566 verifyFormat("#include \"a\" // comment\n"
567 "#include \"a/b/c\" // comment");
568 verifyFormat("#include <a> // comment\n"
569 "#include <a/b/c> // comment");
Alexander Kornienko578fdd82012-12-06 18:03:27 +0000570
Daniel Jasper3f69a1b2012-12-18 19:56:56 +0000571 verifyFormat("enum E {\n"
572 " // comment\n"
Daniel Jasper5ad1e192013-01-07 11:09:06 +0000573 " VAL_A, // comment\n"
Daniel Jasper3f69a1b2012-12-18 19:56:56 +0000574 " VAL_B\n"
575 "};");
Daniel Jaspere25509f2012-12-17 11:29:41 +0000576
577 verifyFormat(
578 "aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa =\n"
Daniel Jasper5ad1e192013-01-07 11:09:06 +0000579 " bbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbb; // Trailing comment");
Daniel Jasperd8bb2db2013-01-09 09:33:39 +0000580 verifyFormat("aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa =\n"
581 " // Comment inside a statement.\n"
582 " bbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbb;");
Daniel Jasper38396592013-02-06 15:23:09 +0000583 verifyFormat(
584 "bool aaaaaaaaaaaaa = // comment\n"
585 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaa || aaaaaaaaaaaaaaaaaaaaaaaaaaaa ||\n"
586 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa || aaaaaaaaaaaaaaaaaaaaaaaaaaaaa;");
Manuel Klimekc74d2922013-01-07 08:54:53 +0000587
Daniel Jasper525264c2013-02-13 19:25:54 +0000588 verifyFormat("int aaaa; // aaaaa\n"
Daniel Jasper2ec3ffb82013-02-18 11:59:17 +0000589 "int aa; // aaaaaaa",
590 getLLVMStyleWithColumns(20));
Daniel Jasper525264c2013-02-13 19:25:54 +0000591
Daniel Jasper304a9862013-01-21 22:49:20 +0000592 EXPECT_EQ("void f() { // This does something ..\n"
593 "}\n"
594 "int a; // This is unrelated",
595 format("void f() { // This does something ..\n"
596 " }\n"
597 "int a; // This is unrelated"));
598 EXPECT_EQ("void f() { // This does something ..\n"
599 "} // awesome..\n"
600 "\n"
601 "int a; // This is unrelated",
602 format("void f() { // This does something ..\n"
603 " } // awesome..\n"
604 " \n"
605 "int a; // This is unrelated"));
606
Daniel Jasper5ad1e192013-01-07 11:09:06 +0000607 EXPECT_EQ("int i; // single line trailing comment",
Manuel Klimekc74d2922013-01-07 08:54:53 +0000608 format("int i;\\\n// single line trailing comment"));
Daniel Jasper5ad1e192013-01-07 11:09:06 +0000609
610 verifyGoogleFormat("int a; // Trailing comment.");
Daniel Jasperddaa9be2013-01-29 19:41:55 +0000611
612 verifyFormat("someFunction(anotherFunction( // Force break.\n"
613 " parameter));");
Daniel Jaspera885dbe2013-02-05 09:34:14 +0000614
615 verifyGoogleFormat("#endif // HEADER_GUARD");
Daniel Jasperf79f9352013-02-06 22:04:05 +0000616
617 verifyFormat("const char *test[] = {\n"
618 " // A\n"
619 " \"aaaa\",\n"
620 " // B\n"
621 " \"aaaaa\",\n"
622 "};");
Daniel Jaspereef30492013-02-11 12:36:37 +0000623 verifyGoogleFormat(
624 "aaaaaaaaaaaaaaaaaaaaaaaaaa(\n"
625 " aaaaaaaaaaaaaaaaaaaaaa); // 81 cols with this comment");
Alexander Kornienkob1be9d62013-04-03 12:38:53 +0000626 EXPECT_EQ("D(a, {\n"
627 " // test\n"
628 " int a;\n"
629 "});",
630 format("D(a, {\n"
631 "// test\n"
632 "int a;\n"
633 "});"));
Daniel Jaspere25509f2012-12-17 11:29:41 +0000634}
635
Daniel Jasperbc0fa392013-03-22 16:25:51 +0000636TEST_F(FormatTest, CanFormatCommentsLocally) {
637 EXPECT_EQ("int a; // comment\n"
638 "int b; // comment",
639 format("int a; // comment\n"
640 "int b; // comment",
641 0, 0, getLLVMStyle()));
642 EXPECT_EQ("int a; // comment\n"
643 " // line 2\n"
644 "int b;",
645 format("int a; // comment\n"
646 " // line 2\n"
647 "int b;",
648 28, 0, getLLVMStyle()));
Daniel Jasper770eb7c2013-04-24 06:33:59 +0000649 EXPECT_EQ("int aaaaaa; // comment\n"
650 "int b;\n"
651 "int c; // unrelated comment",
652 format("int aaaaaa; // comment\n"
653 "int b;\n"
654 "int c; // unrelated comment",
655 31, 0, getLLVMStyle()));
Daniel Jasperbc0fa392013-03-22 16:25:51 +0000656}
657
Daniel Jasper3324cbe2013-03-01 16:45:59 +0000658TEST_F(FormatTest, RemovesTrailingWhitespaceOfComments) {
659 EXPECT_EQ("// comment", format("// comment "));
660 EXPECT_EQ("int aaaaaaa, bbbbbbb; // comment",
661 format("int aaaaaaa, bbbbbbb; // comment ",
662 getLLVMStyleWithColumns(33)));
663}
664
Daniel Jaspere25509f2012-12-17 11:29:41 +0000665TEST_F(FormatTest, UnderstandsMultiLineComments) {
Alexander Kornienko578fdd82012-12-06 18:03:27 +0000666 verifyFormat("f(/*test=*/ true);");
Daniel Jasper11cb81c2013-01-17 12:53:34 +0000667 EXPECT_EQ(
668 "f(aaaaaaaaaaaaaaaaaaaaaaaaa, /* Trailing comment for aa... */\n"
669 " bbbbbbbbbbbbbbbbbbbbbbbbb);",
Alexander Kornienko9e90b622013-04-17 17:34:05 +0000670 format("f(aaaaaaaaaaaaaaaaaaaaaaaaa , \\\n/* Trailing comment for aa... */\n"
Daniel Jasper11cb81c2013-01-17 12:53:34 +0000671 " bbbbbbbbbbbbbbbbbbbbbbbbb);"));
672 EXPECT_EQ(
673 "f(aaaaaaaaaaaaaaaaaaaaaaaaa,\n"
674 " /* Leading comment for bb... */ bbbbbbbbbbbbbbbbbbbbbbbbb);",
675 format("f(aaaaaaaaaaaaaaaaaaaaaaaaa , \n"
676 "/* Leading comment for bb... */ bbbbbbbbbbbbbbbbbbbbbbbbb);"));
Daniel Jasperddaa9be2013-01-29 19:41:55 +0000677
Daniel Jasper2cf17bf2013-02-27 09:47:53 +0000678 FormatStyle NoBinPacking = getLLVMStyle();
679 NoBinPacking.BinPackParameters = false;
680 verifyFormat("aaaaaaaa(/* parameter 1 */ aaaaaa,\n"
681 " /* parameter 2 */ aaaaaa,\n"
682 " /* parameter 3 */ aaaaaa,\n"
683 " /* parameter 4 */ aaaaaa);",
684 NoBinPacking);
Daniel Jasper11cb81c2013-01-17 12:53:34 +0000685}
686
Alexander Kornienkodd8ed852013-03-14 16:10:54 +0000687TEST_F(FormatTest, AlignsMultiLineComments) {
688 EXPECT_EQ("/*\n"
689 " * Really multi-line\n"
690 " * comment.\n"
691 " */\n"
692 "void f() {}",
693 format(" /*\n"
694 " * Really multi-line\n"
695 " * comment.\n"
696 " */\n"
697 " void f() {}"));
Alexander Kornienkodd8ed852013-03-14 16:10:54 +0000698 EXPECT_EQ("class C {\n"
699 " /*\n"
700 " * Another multi-line\n"
701 " * comment.\n"
702 " */\n"
703 " void f() {}\n"
704 "};",
705 format("class C {\n"
706 "/*\n"
707 " * Another multi-line\n"
708 " * comment.\n"
709 " */\n"
710 "void f() {}\n"
711 "};"));
Alexander Kornienko79d6c722013-03-15 13:42:02 +0000712 EXPECT_EQ("/*\n"
713 " 1. This is a comment with non-trivial formatting.\n"
714 " 1.1. We have to indent/outdent all lines equally\n"
715 " 1.1.1. to keep the formatting.\n"
716 " */",
717 format(" /*\n"
718 " 1. This is a comment with non-trivial formatting.\n"
719 " 1.1. We have to indent/outdent all lines equally\n"
720 " 1.1.1. to keep the formatting.\n"
721 " */"));
722 EXPECT_EQ("/*\n"
723 " Don't try to outdent if there's not enough inentation.\n"
724 " */",
725 format(" /*\n"
726 " Don't try to outdent if there's not enough inentation.\n"
727 " */"));
Alexander Kornienkodd8ed852013-03-14 16:10:54 +0000728}
729
Alexander Kornienkoffd6d042013-03-27 11:52:18 +0000730TEST_F(FormatTest, SplitsLongCxxComments) {
731 EXPECT_EQ("// A comment that\n"
732 "// doesn't fit on\n"
733 "// one line",
734 format("// A comment that doesn't fit on one line",
735 getLLVMStyleWithColumns(20)));
Alexander Kornienko9e90b622013-04-17 17:34:05 +0000736 EXPECT_EQ("// a b c d\n"
737 "// e f g\n"
738 "// h i j k",
739 format("// a b c d e f g h i j k",
740 getLLVMStyleWithColumns(10)));
741 EXPECT_EQ("// a b c d\n"
742 "// e f g\n"
743 "// h i j k",
744 format("\\\n// a b c d e f g h i j k",
745 getLLVMStyleWithColumns(10)));
Alexander Kornienkoffd6d042013-03-27 11:52:18 +0000746 EXPECT_EQ("if (true) // A comment that\n"
747 " // doesn't fit on\n"
748 " // one line",
749 format("if (true) // A comment that doesn't fit on one line ",
750 getLLVMStyleWithColumns(30)));
751 EXPECT_EQ("// Don't_touch_leading_whitespace",
752 format("// Don't_touch_leading_whitespace",
753 getLLVMStyleWithColumns(20)));
754 EXPECT_EQ(
755 "//Don't add leading\n"
756 "//whitespace",
757 format("//Don't add leading whitespace", getLLVMStyleWithColumns(20)));
Alexander Kornienkoefd98382013-03-28 18:40:55 +0000758 EXPECT_EQ("// A comment before\n"
759 "// a macro\n"
760 "// definition\n"
761 "#define a b",
762 format("// A comment before a macro definition\n"
763 "#define a b",
764 getLLVMStyleWithColumns(20)));
Alexander Kornienkoffd6d042013-03-27 11:52:18 +0000765}
766
Alexander Kornienkob5dad752013-04-02 13:04:06 +0000767TEST_F(FormatTest, ParsesCommentsAdjacentToPPDirectives) {
Daniel Jasperabca58c2013-05-15 14:09:55 +0000768 EXPECT_EQ("namespace {\n}\n// Test\n#define A",
Alexander Kornienkob5dad752013-04-02 13:04:06 +0000769 format("namespace {}\n // Test\n#define A"));
Daniel Jasperabca58c2013-05-15 14:09:55 +0000770 EXPECT_EQ("namespace {\n}\n/* Test */\n#define A",
Alexander Kornienkob5dad752013-04-02 13:04:06 +0000771 format("namespace {}\n /* Test */\n#define A"));
Daniel Jasperabca58c2013-05-15 14:09:55 +0000772 EXPECT_EQ("namespace {\n}\n/* Test */ #define A",
Alexander Kornienkob5dad752013-04-02 13:04:06 +0000773 format("namespace {}\n /* Test */ #define A"));
774}
775
Alexander Kornienkoafcef332013-03-19 17:41:36 +0000776TEST_F(FormatTest, SplitsLongLinesInComments) {
777 EXPECT_EQ("/* This is a long\n"
Alexander Kornienko547a9f522013-03-21 12:28:10 +0000778 " * comment that\n"
779 " * doesn't\n"
780 " * fit on one line.\n"
781 " */",
Alexander Kornienkoafcef332013-03-19 17:41:36 +0000782 format("/* "
783 "This is a long "
Alexander Kornienko547a9f522013-03-21 12:28:10 +0000784 "comment that "
785 "doesn't "
Alexander Kornienkoafcef332013-03-19 17:41:36 +0000786 "fit on one line. */",
787 getLLVMStyleWithColumns(20)));
Alexander Kornienko9e90b622013-04-17 17:34:05 +0000788 EXPECT_EQ("/* a b c d\n"
789 " * e f g\n"
790 " * h i j k\n"
791 " */",
792 format("/* a b c d e f g h i j k */",
793 getLLVMStyleWithColumns(10)));
794 EXPECT_EQ("/* a b c d\n"
795 " * e f g\n"
796 " * h i j k\n"
797 " */",
798 format("\\\n/* a b c d e f g h i j k */",
799 getLLVMStyleWithColumns(10)));
Alexander Kornienkoafcef332013-03-19 17:41:36 +0000800 EXPECT_EQ("/*\n"
801 "This is a long\n"
802 "comment that doesn't\n"
803 "fit on one line.\n"
804 "*/",
805 format("/*\n"
806 "This is a long "
807 "comment that doesn't "
808 "fit on one line. \n"
809 "*/", getLLVMStyleWithColumns(20)));
810 EXPECT_EQ("/*\n"
811 " * This is a long\n"
812 " * comment that\n"
813 " * doesn't fit on\n"
814 " * one line.\n"
815 " */",
Alexander Kornienko547a9f522013-03-21 12:28:10 +0000816 format("/* \n"
Alexander Kornienkoafcef332013-03-19 17:41:36 +0000817 " * This is a long "
818 " comment that "
819 " doesn't fit on "
820 " one line. \n"
821 " */", getLLVMStyleWithColumns(20)));
822 EXPECT_EQ("/*\n"
823 " * This_is_a_comment_with_words_that_dont_fit_on_one_line\n"
824 " * so_it_should_be_broken\n"
825 " * wherever_a_space_occurs\n"
826 " */",
827 format("/*\n"
828 " * This_is_a_comment_with_words_that_dont_fit_on_one_line "
829 " so_it_should_be_broken "
830 " wherever_a_space_occurs \n"
831 " */",
832 getLLVMStyleWithColumns(20)));
833 EXPECT_EQ("/*\n"
Alexander Kornienkoffd6d042013-03-27 11:52:18 +0000834 " * This_comment_can_not_be_broken_into_lines\n"
Alexander Kornienkoafcef332013-03-19 17:41:36 +0000835 " */",
836 format("/*\n"
Alexander Kornienkoffd6d042013-03-27 11:52:18 +0000837 " * This_comment_can_not_be_broken_into_lines\n"
Alexander Kornienkoafcef332013-03-19 17:41:36 +0000838 " */",
839 getLLVMStyleWithColumns(20)));
840 EXPECT_EQ("{\n"
841 " /*\n"
842 " This is another\n"
843 " long comment that\n"
844 " doesn't fit on one\n"
845 " line 1234567890\n"
846 " */\n"
847 "}",
848 format("{\n"
849 "/*\n"
850 "This is another "
851 " long comment that "
852 " doesn't fit on one"
853 " line 1234567890\n"
854 "*/\n"
855 "}", getLLVMStyleWithColumns(20)));
856 EXPECT_EQ("{\n"
857 " /*\n"
858 " * This i s\n"
859 " * another comment\n"
860 " * t hat doesn' t\n"
861 " * fit on one l i\n"
862 " * n e\n"
863 " */\n"
864 "}",
865 format("{\n"
866 "/*\n"
867 " * This i s"
868 " another comment"
869 " t hat doesn' t"
870 " fit on one l i"
871 " n e\n"
872 " */\n"
873 "}", getLLVMStyleWithColumns(20)));
874 EXPECT_EQ("/*\n"
875 " * This is a long\n"
876 " * comment that\n"
877 " * doesn't fit on\n"
878 " * one line\n"
879 " */",
880 format(" /*\n"
881 " * This is a long comment that doesn't fit on one line\n"
882 " */", getLLVMStyleWithColumns(20)));
Alexander Kornienko547a9f522013-03-21 12:28:10 +0000883 EXPECT_EQ("{\n"
884 " if (something) /* This is a\n"
885 "long comment */\n"
886 " ;\n"
887 "}",
888 format("{\n"
889 " if (something) /* This is a long comment */\n"
890 " ;\n"
891 "}",
892 getLLVMStyleWithColumns(30)));
Alexander Kornienkoafcef332013-03-19 17:41:36 +0000893}
894
895TEST_F(FormatTest, SplitsLongLinesInCommentsInPreprocessor) {
896 EXPECT_EQ("#define X \\\n"
Alexander Kornienko547a9f522013-03-21 12:28:10 +0000897 " /* \\\n"
898 " Test \\\n"
Alexander Kornienkoafcef332013-03-19 17:41:36 +0000899 " Macro comment \\\n"
900 " with a long \\\n"
901 " line \\\n"
Alexander Kornienkocb45bc12013-04-15 14:28:00 +0000902 " */ \\\n"
Alexander Kornienkoafcef332013-03-19 17:41:36 +0000903 " A + B",
904 format("#define X \\\n"
905 " /*\n"
Alexander Kornienko547a9f522013-03-21 12:28:10 +0000906 " Test\n"
Alexander Kornienkoafcef332013-03-19 17:41:36 +0000907 " Macro comment with a long line\n"
908 " */ \\\n"
909 " A + B",
910 getLLVMStyleWithColumns(20)));
911 EXPECT_EQ("#define X \\\n"
912 " /* Macro comment \\\n"
Alexander Kornienko547a9f522013-03-21 12:28:10 +0000913 " with a long \\\n"
Alexander Kornienkocb45bc12013-04-15 14:28:00 +0000914 " line */ \\\n"
Alexander Kornienko547a9f522013-03-21 12:28:10 +0000915 " A + B",
916 format("#define X \\\n"
917 " /* Macro comment with a long\n"
918 " line */ \\\n"
919 " A + B",
920 getLLVMStyleWithColumns(20)));
921 EXPECT_EQ("#define X \\\n"
922 " /* Macro comment \\\n"
923 " * with a long \\\n"
Alexander Kornienkocb45bc12013-04-15 14:28:00 +0000924 " * line */ \\\n"
Alexander Kornienkoafcef332013-03-19 17:41:36 +0000925 " A + B",
926 format("#define X \\\n"
927 " /* Macro comment with a long line */ \\\n"
928 " A + B",
929 getLLVMStyleWithColumns(20)));
930}
931
Daniel Jasper11cb81c2013-01-17 12:53:34 +0000932TEST_F(FormatTest, CommentsInStaticInitializers) {
933 EXPECT_EQ(
934 "static SomeType type = { aaaaaaaaaaaaaaaaaaaa, /* comment */\n"
935 " aaaaaaaaaaaaaaaaaaaa /* comment */,\n"
936 " /* comment */ aaaaaaaaaaaaaaaaaaaa,\n"
937 " aaaaaaaaaaaaaaaaaaaa, // comment\n"
938 " aaaaaaaaaaaaaaaaaaaa };",
939 format("static SomeType type = { aaaaaaaaaaaaaaaaaaaa , /* comment */\n"
940 " aaaaaaaaaaaaaaaaaaaa /* comment */ ,\n"
941 " /* comment */ aaaaaaaaaaaaaaaaaaaa ,\n"
942 " aaaaaaaaaaaaaaaaaaaa , // comment\n"
943 " aaaaaaaaaaaaaaaaaaaa };"));
944 verifyFormat("static SomeType type = { aaaaaaaaaaa, // comment for aa...\n"
945 " bbbbbbbbbbb, ccccccccccc };");
946 verifyFormat("static SomeType type = { aaaaaaaaaaa,\n"
947 " // comment for bb....\n"
948 " bbbbbbbbbbb, ccccccccccc };");
949 verifyGoogleFormat(
950 "static SomeType type = { aaaaaaaaaaa, // comment for aa...\n"
Daniel Jasper8a8ce242013-01-31 14:59:26 +0000951 " bbbbbbbbbbb, ccccccccccc };");
Daniel Jasper11cb81c2013-01-17 12:53:34 +0000952 verifyGoogleFormat("static SomeType type = { aaaaaaaaaaa,\n"
953 " // comment for bb....\n"
Daniel Jasper8a8ce242013-01-31 14:59:26 +0000954 " bbbbbbbbbbb, ccccccccccc };");
Daniel Jasper11cb81c2013-01-17 12:53:34 +0000955
Daniel Jasper8a8ce242013-01-31 14:59:26 +0000956 verifyFormat("S s = { { a, b, c }, // Group #1\n"
957 " { d, e, f }, // Group #2\n"
958 " { g, h, i } }; // Group #3");
959 verifyFormat("S s = { { // Group #1\n"
960 " a, b, c },\n"
961 " { // Group #2\n"
962 " d, e, f },\n"
963 " { // Group #3\n"
964 " g, h, i } };");
Daniel Jasperdc7d5812013-02-20 12:56:39 +0000965
966 EXPECT_EQ("S s = {\n"
967 " // Some comment\n"
Daniel Jasperfb5e2412013-02-26 13:10:34 +0000968 " a,\n"
Daniel Jasperdc7d5812013-02-20 12:56:39 +0000969 "\n"
970 " // Comment after empty line\n"
971 " b\n"
Daniel Jasperfb5e2412013-02-26 13:10:34 +0000972 "}",
973 format("S s = {\n"
974 " // Some comment\n"
975 " a,\n"
976 " \n"
977 " // Comment after empty line\n"
978 " b\n"
979 "}"));
980 EXPECT_EQ("S s = { a, b };", format("S s = {\n"
Daniel Jasper16b35622013-02-26 13:18:08 +0000981 " a,\n"
982 "\n"
983 " b\n"
984 "};"));
Daniel Jaspera400cab2013-02-28 15:04:12 +0000985 verifyFormat("const uint8_t aaaaaaaaaaaaaaaaaaaaaa[0] = {\n"
986 " 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, // comment\n"
987 " 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, // comment\n"
988 " 0x00, 0x00, 0x00, 0x00 // comment\n"
989 "};");
Alexander Kornienko578fdd82012-12-06 18:03:27 +0000990}
991
Alexander Kornienko578fdd82012-12-06 18:03:27 +0000992//===----------------------------------------------------------------------===//
993// Tests for classes, namespaces, etc.
994//===----------------------------------------------------------------------===//
995
996TEST_F(FormatTest, DoesNotBreakSemiAfterClassDecl) {
Manuel Klimeka4fe1c12013-01-21 16:42:44 +0000997 verifyFormat("class A {\n};");
Alexander Kornienko578fdd82012-12-06 18:03:27 +0000998}
999
1000TEST_F(FormatTest, UnderstandsAccessSpecifiers) {
1001 verifyFormat("class A {\n"
1002 "public:\n"
Daniel Jasperc04baae2013-04-10 09:49:49 +00001003 "public: // comment\n"
Alexander Kornienko578fdd82012-12-06 18:03:27 +00001004 "protected:\n"
1005 "private:\n"
Manuel Klimeke7d10a12013-01-10 13:24:24 +00001006 " void f() {}\n"
Alexander Kornienko578fdd82012-12-06 18:03:27 +00001007 "};");
1008 verifyGoogleFormat("class A {\n"
1009 " public:\n"
1010 " protected:\n"
1011 " private:\n"
Manuel Klimeke7d10a12013-01-10 13:24:24 +00001012 " void f() {}\n"
Alexander Kornienko578fdd82012-12-06 18:03:27 +00001013 "};");
1014}
1015
Alexander Kornienkofd433362013-03-27 17:08:02 +00001016TEST_F(FormatTest, SeparatesLogicalBlocks) {
1017 EXPECT_EQ("class A {\n"
1018 "public:\n"
1019 " void f();\n"
1020 "\n"
1021 "private:\n"
1022 " void g() {}\n"
1023 " // test\n"
1024 "protected:\n"
1025 " int h;\n"
1026 "};",
1027 format("class A {\n"
1028 "public:\n"
1029 "void f();\n"
1030 "private:\n"
1031 "void g() {}\n"
1032 "// test\n"
1033 "protected:\n"
1034 "int h;\n"
1035 "};"));
1036}
1037
Daniel Jasper83193602013-04-05 17:22:09 +00001038TEST_F(FormatTest, FormatsClasses) {
Manuel Klimeka4fe1c12013-01-21 16:42:44 +00001039 verifyFormat("class A : public B {\n};");
1040 verifyFormat("class A : public ::B {\n};");
Daniel Jaspereead02b2013-02-14 08:42:54 +00001041
1042 verifyFormat(
1043 "class AAAAAAAAAAAAAAAAAAAA : public BBBBBBBBBBBBBBBBBBBBBBBBBBBBBB,\n"
1044 " public CCCCCCCCCCCCCCCCCCCCCCCCCCCCCC {\n"
1045 "};\n");
Daniel Jaspera61aefb2013-05-06 06:45:09 +00001046 verifyFormat("class AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA\n"
1047 " : public BBBBBBBBBBBBBBBBBBBBBBBBBBBBBB,\n"
1048 " public CCCCCCCCCCCCCCCCCCCCCCCCCCCCCC {\n"
Daniel Jaspereead02b2013-02-14 08:42:54 +00001049 "};\n");
1050 verifyFormat(
1051 "class A : public B, public C, public D, public E, public F, public G {\n"
1052 "};");
1053 verifyFormat("class AAAAAAAAAAAA : public B,\n"
1054 " public C,\n"
1055 " public D,\n"
1056 " public E,\n"
1057 " public F,\n"
1058 " public G {\n"
1059 "};");
Daniel Jasper83193602013-04-05 17:22:09 +00001060
1061 verifyFormat("class\n"
1062 " ReallyReallyLongClassName {\n};",
1063 getLLVMStyleWithColumns(32));
Daniel Jasperf7935112012-12-03 18:12:45 +00001064}
1065
Manuel Klimek28cacc72013-01-07 18:10:23 +00001066TEST_F(FormatTest, FormatsVariableDeclarationsAfterStructOrClass) {
Manuel Klimeka4fe1c12013-01-21 16:42:44 +00001067 verifyFormat("class A {\n} a, b;");
1068 verifyFormat("struct A {\n} a, b;");
1069 verifyFormat("union A {\n} a;");
Manuel Klimek28cacc72013-01-07 18:10:23 +00001070}
1071
Alexander Kornienko578fdd82012-12-06 18:03:27 +00001072TEST_F(FormatTest, FormatsEnum) {
Alexander Kornienkob7076a22012-12-04 14:46:19 +00001073 verifyFormat("enum {\n"
1074 " Zero,\n"
1075 " One = 1,\n"
1076 " Two = One + 1,\n"
1077 " Three = (One + Two),\n"
1078 " Four = (Zero && (One ^ Two)) | (One << Two),\n"
1079 " Five = (One, Two, Three, Four, 5)\n"
1080 "};");
1081 verifyFormat("enum Enum {\n"
1082 "};");
1083 verifyFormat("enum {\n"
1084 "};");
Manuel Klimek2cec0192013-01-21 19:17:52 +00001085 verifyFormat("enum X E {\n} d;");
1086 verifyFormat("enum __attribute__((...)) E {\n} d;");
1087 verifyFormat("enum __declspec__((...)) E {\n} d;");
1088 verifyFormat("enum X f() {\n a();\n return 42;\n}");
Alexander Kornienkob7076a22012-12-04 14:46:19 +00001089}
1090
Nico Weber7769a902013-01-14 05:49:49 +00001091TEST_F(FormatTest, FormatsBitfields) {
1092 verifyFormat("struct Bitfields {\n"
1093 " unsigned sClass : 8;\n"
1094 " unsigned ValueKind : 2;\n"
1095 "};");
1096}
1097
Alexander Kornienko578fdd82012-12-06 18:03:27 +00001098TEST_F(FormatTest, FormatsNamespaces) {
1099 verifyFormat("namespace some_namespace {\n"
Manuel Klimeka4fe1c12013-01-21 16:42:44 +00001100 "class A {\n};\n"
Manuel Klimekf4ab9ef2013-01-11 17:54:10 +00001101 "void f() { f(); }\n"
Alexander Kornienko578fdd82012-12-06 18:03:27 +00001102 "}");
1103 verifyFormat("namespace {\n"
Manuel Klimeka4fe1c12013-01-21 16:42:44 +00001104 "class A {\n};\n"
Manuel Klimekf4ab9ef2013-01-11 17:54:10 +00001105 "void f() { f(); }\n"
Alexander Kornienko578fdd82012-12-06 18:03:27 +00001106 "}");
Dmitri Gribenko58d64e22012-12-30 21:27:25 +00001107 verifyFormat("inline namespace X {\n"
Manuel Klimeka4fe1c12013-01-21 16:42:44 +00001108 "class A {\n};\n"
Manuel Klimekf4ab9ef2013-01-11 17:54:10 +00001109 "void f() { f(); }\n"
Dmitri Gribenko58d64e22012-12-30 21:27:25 +00001110 "}");
Alexander Kornienko578fdd82012-12-06 18:03:27 +00001111 verifyFormat("using namespace some_namespace;\n"
Manuel Klimeka4fe1c12013-01-21 16:42:44 +00001112 "class A {\n};\n"
Manuel Klimekf4ab9ef2013-01-11 17:54:10 +00001113 "void f() { f(); }");
Manuel Klimek046b9302013-02-06 16:08:09 +00001114
1115 // This code is more common than we thought; if we
1116 // layout this correctly the semicolon will go into
1117 // its own line, which is undesireable.
1118 verifyFormat("namespace {\n};");
1119 verifyFormat("namespace {\n"
1120 "class A {\n"
1121 "};\n"
1122 "};");
Alexander Kornienko578fdd82012-12-06 18:03:27 +00001123}
1124
Daniel Jasper2ec3ffb82013-02-18 11:59:17 +00001125TEST_F(FormatTest, FormatsExternC) { verifyFormat("extern \"C\" {\nint a;"); }
Manuel Klimekae610d12013-01-21 14:32:05 +00001126
Daniel Jasper40aacf42013-03-14 13:45:21 +00001127TEST_F(FormatTest, FormatsInlineASM) {
1128 verifyFormat("asm(\"xyz\" : \"=a\"(a), \"=d\"(b) : \"a\"(data));");
1129 verifyFormat(
1130 "asm(\"movq\\t%%rbx, %%rsi\\n\\t\"\n"
1131 " \"cpuid\\n\\t\"\n"
1132 " \"xchgq\\t%%rbx, %%rsi\\n\\t\"\n"
Daniel Jasper5dad58e2013-05-15 07:51:51 +00001133 " : \"=a\"(*rEAX), \"=S\"(*rEBX), \"=c\"(*rECX), \"=d\"(*rEDX)\n"
Daniel Jasper40aacf42013-03-14 13:45:21 +00001134 " : \"a\"(value));");
1135}
1136
Nico Weberd5650bd2013-01-07 16:36:17 +00001137TEST_F(FormatTest, FormatTryCatch) {
Manuel Klimekf4ab9ef2013-01-11 17:54:10 +00001138 // FIXME: Handle try-catch explicitly in the UnwrappedLineParser, then we'll
1139 // also not create single-line-blocks.
Nico Weberd5650bd2013-01-07 16:36:17 +00001140 verifyFormat("try {\n"
1141 " throw a * b;\n"
1142 "}\n"
1143 "catch (int a) {\n"
1144 " // Do nothing.\n"
1145 "}\n"
1146 "catch (...) {\n"
1147 " exit(42);\n"
1148 "}");
1149
1150 // Function-level try statements.
Manuel Klimekf4ab9ef2013-01-11 17:54:10 +00001151 verifyFormat("int f() try { return 4; }\n"
Nico Weberd5650bd2013-01-07 16:36:17 +00001152 "catch (...) {\n"
1153 " return 5;\n"
1154 "}");
1155 verifyFormat("class A {\n"
1156 " int a;\n"
Manuel Klimeke7d10a12013-01-10 13:24:24 +00001157 " A() try : a(0) {}\n"
Nico Weberd5650bd2013-01-07 16:36:17 +00001158 " catch (...) {\n"
1159 " throw;\n"
1160 " }\n"
1161 "};\n");
1162}
1163
1164TEST_F(FormatTest, FormatObjCTryCatch) {
Manuel Klimek2acb7b72013-01-11 19:17:44 +00001165 verifyFormat("@try {\n"
1166 " f();\n"
1167 "}\n"
1168 "@catch (NSException e) {\n"
1169 " @throw;\n"
1170 "}\n"
1171 "@finally {\n"
1172 " exit(42);\n"
1173 "}");
Nico Weberd5650bd2013-01-07 16:36:17 +00001174}
1175
Daniel Jaspere25509f2012-12-17 11:29:41 +00001176TEST_F(FormatTest, StaticInitializers) {
1177 verifyFormat("static SomeClass SC = { 1, 'a' };");
1178
1179 // FIXME: Format like enums if the static initializer does not fit on a line.
1180 verifyFormat(
Daniel Jasper206df732013-01-07 13:08:40 +00001181 "static SomeClass WithALoooooooooooooooooooongName = {\n"
Manuel Klimek0ddd57a2013-01-10 15:58:26 +00001182 " 100000000, \"aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\"\n"
1183 "};");
1184
1185 verifyFormat(
1186 "static SomeClass = { a, b, c, d, e, f, g, h, i, j,\n"
1187 " looooooooooooooooooooooooooooooooooongname,\n"
1188 " looooooooooooooooooooooooooooooong };");
Daniel Jasper8a8ce242013-01-31 14:59:26 +00001189 // Allow bin-packing in static initializers as this would often lead to
1190 // terrible results, e.g.:
1191 verifyGoogleFormat(
1192 "static SomeClass = { a, b, c, d, e, f, g, h, i, j,\n"
1193 " looooooooooooooooooooooooooooooooooongname,\n"
1194 " looooooooooooooooooooooooooooooong };");
Daniel Jasper473c62c2013-05-17 09:35:01 +00001195 // Here, everything other than the "}" would fit on a line.
1196 verifyFormat("static int LooooooooooooooooooooooooongVariable[1] = {\n"
1197 " 100000000000000000000000\n"
1198 "};");
1199
1200 // FIXME: This would fit into the column limit if we'd fit "{ {" on the first
1201 // line. However, the formatting looks a bit off and this probably doesn't
1202 // happen often in practice.
1203 verifyFormat("static int Variable[1] = {\n"
1204 " { 1000000000000000000000000000000000000 }\n"
1205 "};",
1206 getLLVMStyleWithColumns(40));
Daniel Jaspere25509f2012-12-17 11:29:41 +00001207}
1208
Manuel Klimeka54d1a92013-01-14 16:41:43 +00001209TEST_F(FormatTest, NestedStaticInitializers) {
1210 verifyFormat("static A x = { { {} } };\n");
Daniel Jasper2ec3ffb82013-02-18 11:59:17 +00001211 verifyFormat("static A x = { { { init1, init2, init3, init4 },\n"
1212 " { init1, init2, init3, init4 } } };");
Daniel Jasper9278eb92013-01-16 14:59:02 +00001213
Daniel Jasper2ec3ffb82013-02-18 11:59:17 +00001214 verifyFormat("somes Status::global_reps[3] = {\n"
1215 " { kGlobalRef, OK_CODE, NULL, NULL, NULL },\n"
1216 " { kGlobalRef, CANCELLED_CODE, NULL, NULL, NULL },\n"
1217 " { kGlobalRef, UNKNOWN_CODE, NULL, NULL, NULL }\n"
1218 "};");
1219 verifyGoogleFormat("somes Status::global_reps[3] = {\n"
1220 " { kGlobalRef, OK_CODE, NULL, NULL, NULL },\n"
1221 " { kGlobalRef, CANCELLED_CODE, NULL, NULL, NULL },\n"
1222 " { kGlobalRef, UNKNOWN_CODE, NULL, NULL, NULL }\n"
1223 "};");
Manuel Klimeka54d1a92013-01-14 16:41:43 +00001224 verifyFormat(
1225 "CGRect cg_rect = { { rect.fLeft, rect.fTop },\n"
1226 " { rect.fRight - rect.fLeft, rect.fBottom - rect.fTop"
1227 " } };");
1228
Daniel Jasper8a8ce242013-01-31 14:59:26 +00001229 verifyFormat(
1230 "SomeArrayOfSomeType a = { { { 1, 2, 3 }, { 1, 2, 3 },\n"
1231 " { 111111111111111111111111111111,\n"
1232 " 222222222222222222222222222222,\n"
1233 " 333333333333333333333333333333 },\n"
1234 " { 1, 2, 3 }, { 1, 2, 3 } } };");
Daniel Jasper1ca05cc2013-02-03 18:07:15 +00001235 verifyFormat(
1236 "SomeArrayOfSomeType a = { { { 1, 2, 3 } }, { { 1, 2, 3 } },\n"
1237 " { { 111111111111111111111111111111,\n"
1238 " 222222222222222222222222222222,\n"
1239 " 333333333333333333333333333333 } },\n"
1240 " { { 1, 2, 3 } }, { { 1, 2, 3 } } };");
Daniel Jasper8a8ce242013-01-31 14:59:26 +00001241
Nico Weber250fe712013-01-18 02:43:57 +00001242 // FIXME: We might at some point want to handle this similar to parameter
Manuel Klimeka54d1a92013-01-14 16:41:43 +00001243 // lists, where we have an option to put each on a single line.
Daniel Jasper2ec3ffb82013-02-18 11:59:17 +00001244 verifyFormat(
1245 "struct {\n"
1246 " unsigned bit;\n"
1247 " const char *const name;\n"
1248 "} kBitsToOs[] = { { kOsMac, \"Mac\" }, { kOsWin, \"Windows\" },\n"
1249 " { kOsLinux, \"Linux\" }, { kOsCrOS, \"Chrome OS\" } };");
Manuel Klimeka54d1a92013-01-14 16:41:43 +00001250}
1251
Manuel Klimeka71e5d82013-01-02 16:30:12 +00001252TEST_F(FormatTest, FormatsSmallMacroDefinitionsInSingleLine) {
1253 verifyFormat("#define ALooooooooooooooooooooooooooooooooooooooongMacro("
1254 " \\\n"
1255 " aLoooooooooooooooooooooooongFuuuuuuuuuuuuuunctiooooooooo)");
1256}
1257
Daniel Jasperda16db32013-01-07 10:48:50 +00001258TEST_F(FormatTest, DoesNotBreakPureVirtualFunctionDefinition) {
Daniel Jaspera628c982013-04-03 13:36:17 +00001259 verifyFormat(
Daniel Jasper6728fc12013-04-11 14:29:13 +00001260 "virtual void write(ELFWriter *writerrr,\n"
1261 " OwningPtr<FileOutputBuffer> &buffer) = 0;");
Daniel Jasperda16db32013-01-07 10:48:50 +00001262}
1263
Manuel Klimek591b5802013-01-31 15:58:48 +00001264TEST_F(FormatTest, LayoutUnknownPPDirective) {
1265 EXPECT_EQ("#123 \"A string literal\"",
1266 format(" # 123 \"A string literal\""));
1267 EXPECT_EQ("#;", format("#;"));
Manuel Klimek78725712013-01-07 10:03:37 +00001268 verifyFormat("#\n;\n;\n;");
Manuel Klimeka71e5d82013-01-02 16:30:12 +00001269}
1270
1271TEST_F(FormatTest, UnescapedEndOfLineEndsPPDirective) {
1272 EXPECT_EQ("#line 42 \"test\"\n",
1273 format("# \\\n line \\\n 42 \\\n \"test\"\n"));
Daniel Jasper2ec3ffb82013-02-18 11:59:17 +00001274 EXPECT_EQ("#define A B\n", format("# \\\n define \\\n A \\\n B\n",
1275 getLLVMStyleWithColumns(12)));
Manuel Klimeka71e5d82013-01-02 16:30:12 +00001276}
1277
1278TEST_F(FormatTest, EndOfFileEndsPPDirective) {
1279 EXPECT_EQ("#line 42 \"test\"",
1280 format("# \\\n line \\\n 42 \\\n \"test\""));
Daniel Jasper2ec3ffb82013-02-18 11:59:17 +00001281 EXPECT_EQ("#define A B", format("# \\\n define \\\n A \\\n B"));
Manuel Klimeka71e5d82013-01-02 16:30:12 +00001282}
1283
Manuel Klimekb69e3c62013-01-02 18:33:23 +00001284TEST_F(FormatTest, IndentsPPDirectiveInReducedSpace) {
Daniel Jasperc22f5b42013-02-28 11:05:57 +00001285 verifyFormat("#define A(BB)", getLLVMStyleWithColumns(13));
1286 verifyFormat("#define A( \\\n BB)", getLLVMStyleWithColumns(12));
Manuel Klimekb69e3c62013-01-02 18:33:23 +00001287 verifyFormat("#define A( \\\n A, B)", getLLVMStyleWithColumns(12));
Daniel Jasperc22f5b42013-02-28 11:05:57 +00001288 // FIXME: We never break before the macro name.
1289 verifyFormat("#define AA(\\\n B)", getLLVMStyleWithColumns(12));
Daniel Jasper39825ea2013-01-14 15:40:57 +00001290
1291 verifyFormat("#define A A\n#define A A");
1292 verifyFormat("#define A(X) A\n#define A A");
1293
Daniel Jasperc22f5b42013-02-28 11:05:57 +00001294 verifyFormat("#define Something Other", getLLVMStyleWithColumns(23));
1295 verifyFormat("#define Something \\\n Other", getLLVMStyleWithColumns(22));
Manuel Klimekb69e3c62013-01-02 18:33:23 +00001296}
1297
1298TEST_F(FormatTest, HandlePreprocessorDirectiveContext) {
Alexander Kornienkoefd98382013-03-28 18:40:55 +00001299 EXPECT_EQ("// somecomment\n"
Manuel Klimek1abf7892013-01-04 23:34:14 +00001300 "#include \"a.h\"\n"
Daniel Jasperc22f5b42013-02-28 11:05:57 +00001301 "#define A( \\\n"
1302 " A, B)\n"
Manuel Klimek1abf7892013-01-04 23:34:14 +00001303 "#include \"b.h\"\n"
Alexander Kornienkoffd6d042013-03-27 11:52:18 +00001304 "// somecomment\n",
Alexander Kornienkoefd98382013-03-28 18:40:55 +00001305 format(" // somecomment\n"
Manuel Klimek1abf7892013-01-04 23:34:14 +00001306 " #include \"a.h\"\n"
1307 "#define A(A,\\\n"
1308 " B)\n"
1309 " #include \"b.h\"\n"
Alexander Kornienkoffd6d042013-03-27 11:52:18 +00001310 " // somecomment\n",
Daniel Jasper2ec3ffb82013-02-18 11:59:17 +00001311 getLLVMStyleWithColumns(13)));
Manuel Klimekb69e3c62013-01-02 18:33:23 +00001312}
1313
Daniel Jasper2ec3ffb82013-02-18 11:59:17 +00001314TEST_F(FormatTest, LayoutSingleHash) { EXPECT_EQ("#\na;", format("#\na;")); }
Manuel Klimek1abf7892013-01-04 23:34:14 +00001315
1316TEST_F(FormatTest, LayoutCodeInMacroDefinitions) {
1317 EXPECT_EQ("#define A \\\n"
1318 " c; \\\n"
1319 " e;\n"
Daniel Jasper2ec3ffb82013-02-18 11:59:17 +00001320 "f;",
1321 format("#define A c; e;\n"
1322 "f;",
1323 getLLVMStyleWithColumns(14)));
Manuel Klimek1abf7892013-01-04 23:34:14 +00001324}
1325
Daniel Jasper2ec3ffb82013-02-18 11:59:17 +00001326TEST_F(FormatTest, LayoutRemainingTokens) { EXPECT_EQ("{}", format("{}")); }
Manuel Klimek1abf7892013-01-04 23:34:14 +00001327
Daniel Jasper1cb530f2013-05-10 13:00:49 +00001328TEST_F(FormatTest, AlwaysFormatsEntireMacroDefinitions) {
1329 EXPECT_EQ("int i;\n"
1330 "#define A \\\n"
1331 " int i; \\\n"
1332 " int j\n"
1333 "int k;",
1334 format("int i;\n"
1335 "#define A \\\n"
1336 " int i ; \\\n"
1337 " int j\n"
1338 "int k;",
1339 8, 0, getGoogleStyle())); // 8: position of "#define".
1340 EXPECT_EQ("int i;\n"
1341 "#define A \\\n"
1342 " int i; \\\n"
1343 " int j\n"
1344 "int k;",
1345 format("int i;\n"
1346 "#define A \\\n"
1347 " int i ; \\\n"
1348 " int j\n"
1349 "int k;",
1350 45, 0, getGoogleStyle())); // 45: position of "j".
Manuel Klimek1abf7892013-01-04 23:34:14 +00001351}
1352
1353TEST_F(FormatTest, MacroDefinitionInsideStatement) {
Manuel Klimek52b15152013-01-09 15:25:02 +00001354 EXPECT_EQ("int x,\n"
1355 "#define A\n"
Daniel Jasper2ec3ffb82013-02-18 11:59:17 +00001356 " y;",
1357 format("int x,\n#define A\ny;"));
Manuel Klimek1abf7892013-01-04 23:34:14 +00001358}
1359
Manuel Klimek09e07972013-01-05 21:34:55 +00001360TEST_F(FormatTest, HashInMacroDefinition) {
1361 verifyFormat("#define A \\\n b #c;", getLLVMStyleWithColumns(11));
1362 verifyFormat("#define A \\\n"
1363 " { \\\n"
1364 " f(#c);\\\n"
Daniel Jasper2ec3ffb82013-02-18 11:59:17 +00001365 " }",
1366 getLLVMStyleWithColumns(11));
Daniel Jasper4f397152013-01-08 16:17:54 +00001367
1368 verifyFormat("#define A(X) \\\n"
Daniel Jasper2ec3ffb82013-02-18 11:59:17 +00001369 " void function##X()",
1370 getLLVMStyleWithColumns(22));
Daniel Jasper4f397152013-01-08 16:17:54 +00001371
1372 verifyFormat("#define A(a, b, c) \\\n"
Daniel Jasper2ec3ffb82013-02-18 11:59:17 +00001373 " void a##b##c()",
1374 getLLVMStyleWithColumns(22));
Daniel Jasper4f397152013-01-08 16:17:54 +00001375
Daniel Jasper39825ea2013-01-14 15:40:57 +00001376 verifyFormat("#define A void # ## #", getLLVMStyleWithColumns(22));
Manuel Klimek09e07972013-01-05 21:34:55 +00001377}
1378
Manuel Klimekd053c5b2013-01-23 14:37:36 +00001379TEST_F(FormatTest, RespectWhitespaceInMacroDefinitions) {
1380 verifyFormat("#define A (1)");
1381}
1382
Manuel Klimek0c137952013-02-11 12:33:24 +00001383TEST_F(FormatTest, EmptyLinesInMacroDefinitions) {
1384 EXPECT_EQ("#define A b;", format("#define A \\\n"
1385 " \\\n"
Daniel Jasper2ec3ffb82013-02-18 11:59:17 +00001386 " b;",
1387 getLLVMStyleWithColumns(25)));
Manuel Klimek0c137952013-02-11 12:33:24 +00001388 EXPECT_EQ("#define A \\\n"
1389 " \\\n"
1390 " a; \\\n"
Daniel Jasper2ec3ffb82013-02-18 11:59:17 +00001391 " b;",
1392 format("#define A \\\n"
1393 " \\\n"
1394 " a; \\\n"
1395 " b;",
1396 getLLVMStyleWithColumns(11)));
Manuel Klimek0c137952013-02-11 12:33:24 +00001397 EXPECT_EQ("#define A \\\n"
1398 " a; \\\n"
1399 " \\\n"
Daniel Jasper2ec3ffb82013-02-18 11:59:17 +00001400 " b;",
1401 format("#define A \\\n"
1402 " a; \\\n"
1403 " \\\n"
1404 " b;",
1405 getLLVMStyleWithColumns(11)));
Manuel Klimek0c137952013-02-11 12:33:24 +00001406}
1407
Daniel Jasper00475962013-02-19 17:14:38 +00001408TEST_F(FormatTest, MacroDefinitionsWithIncompleteCode) {
Daniel Jasper850677d2013-03-18 12:50:26 +00001409 verifyFormat("#define A :");
1410
Daniel Jasper00475962013-02-19 17:14:38 +00001411 // FIXME: Improve formatting of case labels in macros.
1412 verifyFormat("#define SOMECASES \\\n"
Daniel Jaspera1275122013-03-20 10:23:53 +00001413 " case 1: \\\n"
Daniel Jasper00475962013-02-19 17:14:38 +00001414 " case 2\n",
1415 getLLVMStyleWithColumns(20));
1416
1417 verifyFormat("#define A template <typename T>");
Daniel Jasper6db1b7c2013-02-19 20:05:41 +00001418 verifyFormat("#define STR(x) #x\n"
1419 "f(STR(this_is_a_string_literal{));");
Daniel Jasper00475962013-02-19 17:14:38 +00001420}
1421
Alexander Kornienkode644272013-04-08 22:16:06 +00001422TEST_F(FormatTest, MacroCallsWithoutTrailingSemicolon) {
1423 EXPECT_EQ("INITIALIZE_PASS_BEGIN(ScopDetection, \"polly-detect\")\n"
1424 "INITIALIZE_AG_DEPENDENCY(AliasAnalysis)\n"
1425 "INITIALIZE_PASS_DEPENDENCY(DominatorTree)\n"
1426 "class X {\n"
1427 "};\n"
1428 "INITIALIZE_PASS_END(ScopDetection, \"polly-detect\")\n"
1429 "int *createScopDetectionPass() { return 0; }",
1430 format(" INITIALIZE_PASS_BEGIN(ScopDetection, \"polly-detect\")\n"
1431 " INITIALIZE_AG_DEPENDENCY(AliasAnalysis)\n"
1432 " INITIALIZE_PASS_DEPENDENCY(DominatorTree)\n"
1433 " class X {};\n"
1434 " INITIALIZE_PASS_END(ScopDetection, \"polly-detect\")\n"
1435 " int *createScopDetectionPass() { return 0; }"));
Alexander Kornienkoa04e5e22013-04-09 16:15:19 +00001436 // FIXME: We could probably treat IPC_BEGIN_MESSAGE_MAP/IPC_END_MESSAGE_MAP as
1437 // braces, so that inner block is indented one level more.
1438 EXPECT_EQ("int q() {\n"
1439 " IPC_BEGIN_MESSAGE_MAP(WebKitTestController, message)\n"
1440 " IPC_MESSAGE_HANDLER(xxx, qqq)\n"
1441 " IPC_END_MESSAGE_MAP()\n"
1442 "}",
1443 format("int q() {\n"
1444 " IPC_BEGIN_MESSAGE_MAP(WebKitTestController, message)\n"
1445 " IPC_MESSAGE_HANDLER(xxx, qqq)\n"
1446 " IPC_END_MESSAGE_MAP()\n"
1447 "}"));
1448 EXPECT_EQ("int q() {\n"
1449 " f(x);\n"
1450 " f(x) {}\n"
1451 " f(x)->g();\n"
1452 " f(x)->*g();\n"
1453 " f(x).g();\n"
1454 " f(x) = x;\n"
1455 " f(x) += x;\n"
1456 " f(x) -= x;\n"
1457 " f(x) *= x;\n"
1458 " f(x) /= x;\n"
1459 " f(x) %= x;\n"
1460 " f(x) &= x;\n"
1461 " f(x) |= x;\n"
1462 " f(x) ^= x;\n"
1463 " f(x) >>= x;\n"
1464 " f(x) <<= x;\n"
1465 " f(x)[y].z();\n"
1466 " LOG(INFO) << x;\n"
1467 " ifstream(x) >> x;\n"
1468 "}\n",
1469 format("int q() {\n"
1470 " f(x)\n;\n"
1471 " f(x)\n {}\n"
1472 " f(x)\n->g();\n"
1473 " f(x)\n->*g();\n"
1474 " f(x)\n.g();\n"
1475 " f(x)\n = x;\n"
1476 " f(x)\n += x;\n"
1477 " f(x)\n -= x;\n"
1478 " f(x)\n *= x;\n"
1479 " f(x)\n /= x;\n"
1480 " f(x)\n %= x;\n"
1481 " f(x)\n &= x;\n"
1482 " f(x)\n |= x;\n"
1483 " f(x)\n ^= x;\n"
1484 " f(x)\n >>= x;\n"
1485 " f(x)\n <<= x;\n"
1486 " f(x)\n[y].z();\n"
1487 " LOG(INFO)\n << x;\n"
1488 " ifstream(x)\n >> x;\n"
1489 "}\n"));
1490 EXPECT_EQ("int q() {\n"
1491 " f(x)\n"
1492 " if (1) {\n"
1493 " }\n"
1494 " f(x)\n"
1495 " while (1) {\n"
1496 " }\n"
1497 " f(x)\n"
1498 " g(x);\n"
1499 " f(x)\n"
1500 " try {\n"
1501 " q();\n"
1502 " }\n"
1503 " catch (...) {\n"
1504 " }\n"
1505 "}\n",
1506 format("int q() {\n"
1507 "f(x)\n"
1508 "if (1) {}\n"
1509 "f(x)\n"
1510 "while (1) {}\n"
1511 "f(x)\n"
1512 "g(x);\n"
1513 "f(x)\n"
1514 "try { q(); } catch (...) {}\n"
1515 "}\n"));
1516 EXPECT_EQ("class A {\n"
1517 " A() : t(0) {}\n"
1518 " A(X x)\n" // FIXME: function-level try blocks are broken.
1519 " try : t(0) {\n"
1520 " }\n"
1521 " catch (...) {\n"
1522 " }\n"
1523 "};",
1524 format("class A {\n"
1525 " A()\n : t(0) {}\n"
1526 " A(X x)\n"
1527 " try : t(0) {} catch (...) {}\n"
1528 "};"));
Alexander Kornienkode644272013-04-08 22:16:06 +00001529}
1530
Manuel Klimekef2cfb12013-01-05 22:14:16 +00001531TEST_F(FormatTest, IndentPreprocessorDirectivesAtZero) {
1532 EXPECT_EQ("{\n {\n#define A\n }\n}", format("{{\n#define A\n}}"));
1533}
1534
Manuel Klimek52d0fd82013-01-05 22:56:06 +00001535TEST_F(FormatTest, FormatHashIfNotAtStartOfLine) {
Manuel Klimekf4ab9ef2013-01-11 17:54:10 +00001536 verifyFormat("{\n { a #c; }\n}");
Manuel Klimek52d0fd82013-01-05 22:56:06 +00001537}
1538
Manuel Klimek1058d982013-01-06 20:07:31 +00001539TEST_F(FormatTest, FormatUnbalancedStructuralElements) {
1540 EXPECT_EQ("#define A \\\n { \\\n {\nint i;",
1541 format("#define A { {\nint i;", getLLVMStyleWithColumns(11)));
1542 EXPECT_EQ("#define A \\\n } \\\n }\nint i;",
1543 format("#define A } }\nint i;", getLLVMStyleWithColumns(11)));
1544}
Manuel Klimek1abf7892013-01-04 23:34:14 +00001545
Manuel Klimekef920692013-01-07 07:56:50 +00001546TEST_F(FormatTest, EscapedNewlineAtStartOfTokenInMacroDefinition) {
Daniel Jasper8d1832e2013-01-07 13:26:07 +00001547 EXPECT_EQ(
1548 "#define A \\\n int i; \\\n int j;",
1549 format("#define A \\\nint i;\\\n int j;", getLLVMStyleWithColumns(11)));
Manuel Klimekef920692013-01-07 07:56:50 +00001550}
1551
Manuel Klimek38ba11e2013-01-07 09:24:17 +00001552TEST_F(FormatTest, CalculateSpaceOnConsecutiveLinesInMacro) {
1553 verifyFormat("#define A \\\n"
1554 " int v( \\\n"
1555 " a); \\\n"
Daniel Jasper2ec3ffb82013-02-18 11:59:17 +00001556 " int i;",
1557 getLLVMStyleWithColumns(11));
Manuel Klimek38ba11e2013-01-07 09:24:17 +00001558}
1559
Manuel Klimeka71e5d82013-01-02 16:30:12 +00001560TEST_F(FormatTest, MixingPreprocessorDirectivesAndNormalCode) {
Manuel Klimek1abf7892013-01-04 23:34:14 +00001561 EXPECT_EQ(
1562 "#define ALooooooooooooooooooooooooooooooooooooooongMacro("
1563 " \\\n"
1564 " aLoooooooooooooooooooooooongFuuuuuuuuuuuuuunctiooooooooo)\n"
1565 "\n"
1566 "AlooooooooooooooooooooooooooooooooooooooongCaaaaaaaaaal(\n"
1567 " aLooooooooooooooooooooooonPaaaaaaaaaaaaaaaaaaaaarmmmm);\n",
1568 format(" #define ALooooooooooooooooooooooooooooooooooooooongMacro("
1569 "\\\n"
1570 "aLoooooooooooooooooooooooongFuuuuuuuuuuuuuunctiooooooooo)\n"
1571 " \n"
1572 " AlooooooooooooooooooooooooooooooooooooooongCaaaaaaaaaal(\n"
1573 " aLooooooooooooooooooooooonPaaaaaaaaaaaaaaaaaaaaarmmmm);\n"));
Manuel Klimeka71e5d82013-01-02 16:30:12 +00001574}
1575
Manuel Klimek52b15152013-01-09 15:25:02 +00001576TEST_F(FormatTest, LayoutStatementsAroundPreprocessorDirectives) {
1577 EXPECT_EQ("int\n"
1578 "#define A\n"
Daniel Jasper8e357692013-05-06 08:27:33 +00001579 " a;",
Manuel Klimek52b15152013-01-09 15:25:02 +00001580 format("int\n#define A\na;"));
Daniel Jasper2ec3ffb82013-02-18 11:59:17 +00001581 verifyFormat("functionCallTo(\n"
1582 " someOtherFunction(\n"
1583 " withSomeParameters, whichInSequence,\n"
1584 " areLongerThanALine(andAnotherCall,\n"
1585 "#define A B\n"
1586 " withMoreParamters,\n"
1587 " whichStronglyInfluenceTheLayout),\n"
Daniel Jasper37905f72013-02-21 15:00:29 +00001588 " andMoreParameters),\n"
1589 " trailing);",
Daniel Jasper2ec3ffb82013-02-18 11:59:17 +00001590 getLLVMStyleWithColumns(69));
Manuel Klimek52b15152013-01-09 15:25:02 +00001591}
1592
Manuel Klimek8e07a1b2013-01-10 11:52:21 +00001593TEST_F(FormatTest, LayoutBlockInsideParens) {
1594 EXPECT_EQ("functionCall({\n"
1595 " int i;\n"
Daniel Jasper2ec3ffb82013-02-18 11:59:17 +00001596 "});",
1597 format(" functionCall ( {int i;} );"));
Manuel Klimek8e07a1b2013-01-10 11:52:21 +00001598}
1599
1600TEST_F(FormatTest, LayoutBlockInsideStatement) {
Manuel Klimekf4ab9ef2013-01-11 17:54:10 +00001601 EXPECT_EQ("SOME_MACRO { int i; }\n"
Daniel Jasper2ec3ffb82013-02-18 11:59:17 +00001602 "int i;",
1603 format(" SOME_MACRO {int i;} int i;"));
Manuel Klimek8e07a1b2013-01-10 11:52:21 +00001604}
1605
1606TEST_F(FormatTest, LayoutNestedBlocks) {
1607 verifyFormat("void AddOsStrings(unsigned bitmask) {\n"
1608 " struct s {\n"
1609 " int i;\n"
1610 " };\n"
1611 " s kBitsToOs[] = { { 10 } };\n"
1612 " for (int i = 0; i < 10; ++i)\n"
1613 " return;\n"
1614 "}");
1615}
1616
Manuel Klimeke7d10a12013-01-10 13:24:24 +00001617TEST_F(FormatTest, PutEmptyBlocksIntoOneLine) {
1618 EXPECT_EQ("{}", format("{}"));
Manuel Klimeka4fe1c12013-01-21 16:42:44 +00001619
1620 // Negative test for enum.
1621 verifyFormat("enum E {\n};");
1622
1623 // Note that when there's a missing ';', we still join...
1624 verifyFormat("enum E {}");
Manuel Klimeke7d10a12013-01-10 13:24:24 +00001625}
1626
Alexander Kornienko578fdd82012-12-06 18:03:27 +00001627//===----------------------------------------------------------------------===//
1628// Line break tests.
1629//===----------------------------------------------------------------------===//
1630
Alexander Kornienko578fdd82012-12-06 18:03:27 +00001631TEST_F(FormatTest, FormatsAwesomeMethodCall) {
1632 verifyFormat(
Daniel Jasper7b5773e92013-01-28 07:35:34 +00001633 "SomeLongMethodName(SomeReallyLongMethod(CallOtherReallyLongMethod(\n"
1634 " parameter, parameter, parameter)),\n"
Daniel Jasper6d822722012-12-24 16:43:00 +00001635 " SecondLongCall(parameter));");
Alexander Kornienko578fdd82012-12-06 18:03:27 +00001636}
1637
Daniel Jasper20b09ef2013-01-28 09:35:24 +00001638TEST_F(FormatTest, PreventConfusingIndents) {
Daniel Jasper7b5773e92013-01-28 07:35:34 +00001639 verifyFormat(
1640 "aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa(\n"
1641 " aaaaaaaaaaaaaaaaaaaaaaaa(\n"
1642 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa),\n"
1643 " aaaaaaaaaaaaaaaaaaaaaaaa);");
1644 verifyFormat(
1645 "aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa[\n"
1646 " aaaaaaaaaaaaaaaaaaaaaaaa[\n"
1647 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa],\n"
1648 " aaaaaaaaaaaaaaaaaaaaaaaa];");
1649 verifyFormat(
1650 "aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa<\n"
1651 " aaaaaaaaaaaaaaaaaaaaaaaa<\n"
1652 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa>,\n"
1653 " aaaaaaaaaaaaaaaaaaaaaaaa>;");
Daniel Jasper20b09ef2013-01-28 09:35:24 +00001654 verifyFormat("int a = bbbb && ccc && fffff(\n"
1655 "#define A Just forcing a new line\n"
1656 " ddd);");
Daniel Jasper7b5773e92013-01-28 07:35:34 +00001657}
1658
Daniel Jasperd69fc772013-05-08 14:12:04 +00001659TEST_F(FormatTest, LineBreakingInBinaryExpressions) {
1660 verifyFormat(
1661 "bool aaaaaaa =\n"
1662 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa(aaa).aaaaaaaaaaaaaaaaaaa() ||\n"
1663 " bbbbbbbb();");
1664 verifyFormat("bool aaaaaaaaaaaaaaaaaaaaa =\n"
1665 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa != bbbbbbbbbbbbbbbbbb &&\n"
1666 " ccccccccc == ddddddddddd;");
1667
1668 verifyFormat("aaaaaa = aaaaaaa(aaaaaaa, // break\n"
1669 " aaaaaa) &&\n"
1670 " bbbbbb && cccccc;");
1671 verifyFormat("Whitespaces.addUntouchableComment(\n"
1672 " SourceMgr.getSpellingColumnNumber(\n"
1673 " TheLine.Last->FormatTok.Tok.getLocation()) -\n"
1674 " 1);");
Daniel Jasper571f1af2013-05-14 20:39:56 +00001675
1676 FormatStyle OnePerLine = getLLVMStyle();
1677 OnePerLine.BinPackParameters = false;
1678 verifyFormat(
1679 "if (aaaaaaaaaaaaaaaaaaaaaaaaaaaa || aaaaaaaaaaaaaaaaaaaaaaaaaaaa ||\n"
1680 " aaaaaaaaaaaaaaaaaaaaaaaaaaaa || aaaaaaaaaaaaaaaaaaaaaaaaaaaa ||\n"
1681 " aaaaaaaaaaaaaaaaaaaaaaaaaaaa) {\n}",
1682 OnePerLine);
Daniel Jasperd69fc772013-05-08 14:12:04 +00001683}
1684
Daniel Jasper6bee6822013-04-08 20:33:42 +00001685TEST_F(FormatTest, ExpressionIndentation) {
1686 verifyFormat("bool value = aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa +\n"
1687 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa +\n"
1688 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa ==\n"
1689 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa *\n"
1690 " bbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbb +\n"
1691 " bbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbb &&\n"
1692 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa *\n"
1693 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa >\n"
1694 " ccccccccccccccccccccccccccccccccccccccccc;");
1695 verifyFormat("if (aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa *\n"
1696 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa +\n"
1697 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa ==\n"
1698 " bbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbb) {\n}");
1699 verifyFormat("if (aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa +\n"
1700 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa *\n"
1701 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa ==\n"
1702 " bbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbb) {\n}");
1703 verifyFormat("if (aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa ==\n"
1704 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa *\n"
1705 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa +\n"
1706 " bbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbb) {\n}");
1707}
1708
Daniel Jasper2af6bbe2012-12-18 21:05:13 +00001709TEST_F(FormatTest, ConstructorInitializers) {
Manuel Klimeke7d10a12013-01-10 13:24:24 +00001710 verifyFormat("Constructor() : Initializer(FitsOnTheLine) {}");
Daniel Jasper2408a8c2013-01-11 11:37:55 +00001711 verifyFormat("Constructor() : Inttializer(FitsOnTheLine) {}",
1712 getLLVMStyleWithColumns(45));
Daniel Jasper12ef4e52013-02-21 21:33:55 +00001713 verifyFormat("Constructor()\n"
1714 " : Inttializer(FitsOnTheLine) {}",
Daniel Jasper2408a8c2013-01-11 11:37:55 +00001715 getLLVMStyleWithColumns(44));
Manuel Klimeka4fe1c12013-01-21 16:42:44 +00001716 verifyFormat("Constructor()\n"
Daniel Jasper12ef4e52013-02-21 21:33:55 +00001717 " : Inttializer(FitsOnTheLine) {}",
Manuel Klimeka4fe1c12013-01-21 16:42:44 +00001718 getLLVMStyleWithColumns(43));
Daniel Jasper2af6bbe2012-12-18 21:05:13 +00001719
1720 verifyFormat(
1721 "SomeClass::Constructor()\n"
Daniel Jasper12ef4e52013-02-21 21:33:55 +00001722 " : aaaaaaaaaaaaa(aaaaaaaaaaaaaa), aaaaaaaaaaaaaaa(aaaaaaaaaaaa) {}");
Daniel Jasper2af6bbe2012-12-18 21:05:13 +00001723
1724 verifyFormat(
1725 "SomeClass::Constructor()\n"
Daniel Jasper2408a8c2013-01-11 11:37:55 +00001726 " : aaaaaaaaaaaaa(aaaaaaaaaaaaaa), aaaaaaaaaaaaa(aaaaaaaaaaaaaa),\n"
Daniel Jasper12ef4e52013-02-21 21:33:55 +00001727 " aaaaaaaaaaaaa(aaaaaaaaaaaaaa) {}");
Daniel Jasper2408a8c2013-01-11 11:37:55 +00001728 verifyFormat(
1729 "SomeClass::Constructor()\n"
Daniel Jasper2af6bbe2012-12-18 21:05:13 +00001730 " : aaaaaaaaaaaaaaaaaaaaaaaaaaaaaa(aaaaaaaaaaaaaaaaaaaaaaaaaaaaaa),\n"
Daniel Jasper12ef4e52013-02-21 21:33:55 +00001731 " aaaaaaaaaaaaaaa(aaaaaaaaaaaa) {}");
Daniel Jasper2af6bbe2012-12-18 21:05:13 +00001732
1733 verifyFormat("Constructor()\n"
1734 " : aaaaaaaaaaaaaaaaaaaaaaaa(aaaaaaaaaaaaaaaaaaaaaaaaaaa),\n"
1735 " aaaaaaaaaaaaaaaaaaaaaaaa(aaaaaaaaaaaaaaaaaaaaaaaaaaa,\n"
1736 " aaaaaaaaaaaaaaaaaaaaaaaaaaa),\n"
Daniel Jasper12ef4e52013-02-21 21:33:55 +00001737 " aaaaaaaaaaaaaaaaaaaaaaa() {}");
Daniel Jasper2af6bbe2012-12-18 21:05:13 +00001738
Daniel Jasper65585ed2013-01-28 13:31:35 +00001739 verifyFormat("Constructor()\n"
1740 " : aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa(\n"
Daniel Jasper12ef4e52013-02-21 21:33:55 +00001741 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa) {}");
Daniel Jasper65585ed2013-01-28 13:31:35 +00001742
Daniel Jasper62e68172013-02-25 15:59:54 +00001743 verifyFormat("Constructor(int Parameter = 0)\n"
1744 " : aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa(aaaaaaaaaaaaaaaaa),\n"
1745 " aaaaaaaaaaaa(aaaaaaaaaaaaaaaaa) {}");
1746
Daniel Jasper2af6bbe2012-12-18 21:05:13 +00001747 // Here a line could be saved by splitting the second initializer onto two
1748 // lines, but that is not desireable.
Daniel Jasper2cf17bf2013-02-27 09:47:53 +00001749 verifyFormat("Constructor()\n"
1750 " : aaaaaaaaaaaaaaaaaaaaaaaa(aaaaaaaaaaaaaaaaaaaaaaaa),\n"
1751 " aaaaaaaaaaa(aaaaaaaaaaa),\n"
1752 " aaaaaaaaaaaaaaaaaaaaat(aaaaaaaaaaaaaaaaaaaaaaaaaaaa) {}");
Daniel Jasper2af6bbe2012-12-18 21:05:13 +00001753
Daniel Jasper23e8e0c2013-02-15 16:49:44 +00001754 FormatStyle OnePerLine = getLLVMStyle();
1755 OnePerLine.ConstructorInitializerAllOnOneLineOrOnePerLine = true;
1756 verifyFormat("SomeClass::Constructor()\n"
1757 " : aaaaaaaaaaaaa(aaaaaaaaaaaaaa),\n"
1758 " aaaaaaaaaaaaa(aaaaaaaaaaaaaa),\n"
Daniel Jasper12ef4e52013-02-21 21:33:55 +00001759 " aaaaaaaaaaaaa(aaaaaaaaaaaaaa) {}",
Daniel Jasper2ec3ffb82013-02-18 11:59:17 +00001760 OnePerLine);
Daniel Jasper23e8e0c2013-02-15 16:49:44 +00001761 verifyFormat("SomeClass::Constructor()\n"
1762 " : aaaaaaaaaaaaa(aaaaaaaaaaaaaa), // Some comment\n"
1763 " aaaaaaaaaaaaa(aaaaaaaaaaaaaa),\n"
Daniel Jasper12ef4e52013-02-21 21:33:55 +00001764 " aaaaaaaaaaaaa(aaaaaaaaaaaaaa) {}",
Daniel Jasper2ec3ffb82013-02-18 11:59:17 +00001765 OnePerLine);
Daniel Jasper23e8e0c2013-02-15 16:49:44 +00001766 verifyFormat("MyClass::MyClass(int var)\n"
1767 " : some_var_(var), // 4 space indent\n"
1768 " some_other_var_(var + 1) { // lined up\n"
Daniel Jasper2ec3ffb82013-02-18 11:59:17 +00001769 "}",
1770 OnePerLine);
Daniel Jasperead41b62013-02-28 09:39:12 +00001771 verifyFormat("Constructor()\n"
1772 " : aaaaa(aaaaaa),\n"
1773 " aaaaa(aaaaaa),\n"
1774 " aaaaa(aaaaaa),\n"
1775 " aaaaa(aaaaaa),\n"
1776 " aaaaa(aaaaaa) {}",
1777 OnePerLine);
Daniel Jaspercc960fa2013-04-22 07:59:53 +00001778 verifyFormat("Constructor()\n"
1779 " : aaaaa(aaaaaaaaaaaaaaaaaaaaaa, aaaaaaaaaaaaaaaaaaaaaa,\n"
1780 " aaaaaaaaaaaaaaaaaaaaaa) {}",
1781 OnePerLine);
Daniel Jaspere3c0e012013-04-25 13:31:51 +00001782}
1783
1784TEST_F(FormatTest, MemoizationTests) {
1785 // This breaks if the memoization lookup does not take \c Indent and
1786 // \c LastSpace into account.
1787 verifyFormat(
1788 "extern CFRunLoopTimerRef\n"
1789 "CFRunLoopTimerCreate(CFAllocatorRef allocato, CFAbsoluteTime fireDate,\n"
1790 " CFTimeInterval interval, CFOptionFlags flags,\n"
1791 " CFIndex order, CFRunLoopTimerCallBack callout,\n"
Daniel Jasper8e357692013-05-06 08:27:33 +00001792 " CFRunLoopTimerContext *context) {}");
Daniel Jaspere3c0e012013-04-25 13:31:51 +00001793
1794 // Deep nesting somewhat works around our memoization.
1795 verifyFormat(
1796 "aaaaa(aaaaa(aaaaa(aaaaa(aaaaa(aaaaa(aaaaa(aaaaa(aaaaa(aaaaa(aaaaa(\n"
1797 " aaaaa(aaaaa(aaaaa(aaaaa(aaaaa(aaaaa(aaaaa(aaaaa(aaaaa(aaaaa(\n"
1798 " aaaaa(aaaaa(aaaaa(aaaaa(aaaaa(aaaaa(aaaaa(aaaaa(aaaaa(\n"
1799 " aaaaa(aaaaa(aaaaa(aaaaa(aaaaa(aaaaa(aaaaa(aaaaa(aaaaa(\n"
1800 " aaaaa())))))))))))))))))))))))))))))))))))))));",
1801 getLLVMStyleWithColumns(65));
Daniel Jaspercc3044c2013-05-13 09:19:24 +00001802 verifyFormat(
1803 "aaaaa(\n"
1804 " aaaaa,\n"
1805 " aaaaa(\n"
1806 " aaaaa,\n"
1807 " aaaaa(\n"
1808 " aaaaa,\n"
1809 " aaaaa(\n"
1810 " aaaaa,\n"
1811 " aaaaa(\n"
1812 " aaaaa,\n"
1813 " aaaaa(\n"
1814 " aaaaa,\n"
1815 " aaaaa(\n"
1816 " aaaaa,\n"
1817 " aaaaa(\n"
1818 " aaaaa,\n"
1819 " aaaaa(\n"
1820 " aaaaa,\n"
1821 " aaaaa(\n"
1822 " aaaaa,\n"
1823 " aaaaa(\n"
1824 " aaaaa,\n"
1825 " aaaaa(\n"
1826 " aaaaa,\n"
1827 " aaaaa))))))))))));",
1828 getLLVMStyleWithColumns(65));
Daniel Jasperf8114cf2013-05-22 05:27:42 +00001829 verifyFormat(
1830 "a(a(a(a(a(a(a(a(a(a(a(a(a(a(a(a(a(a(a(a(a(a(), a), a), a), a),\n"
1831 " a),\n"
1832 " a),\n"
1833 " a),\n"
1834 " a),\n"
1835 " a),\n"
1836 " a),\n"
1837 " a),\n"
1838 " a),\n"
1839 " a),\n"
1840 " a),\n"
1841 " a),\n"
1842 " a),\n"
1843 " a),\n"
1844 " a),\n"
1845 " a),\n"
1846 " a),\n"
1847 " a)",
1848 getLLVMStyleWithColumns(65));
Daniel Jasper7b7877a2013-01-12 07:36:22 +00001849
1850 // This test takes VERY long when memoization is broken.
Daniel Jaspere3c0e012013-04-25 13:31:51 +00001851 FormatStyle OnePerLine = getLLVMStyle();
1852 OnePerLine.ConstructorInitializerAllOnOneLineOrOnePerLine = true;
Daniel Jasper2cf17bf2013-02-27 09:47:53 +00001853 OnePerLine.BinPackParameters = false;
Daniel Jasper9278eb92013-01-16 14:59:02 +00001854 std::string input = "Constructor()\n"
Daniel Jasper7a31af12013-01-25 15:43:32 +00001855 " : aaaa(a,\n";
Daniel Jasper9278eb92013-01-16 14:59:02 +00001856 for (unsigned i = 0, e = 80; i != e; ++i) {
1857 input += " a,\n";
1858 }
Daniel Jasper12ef4e52013-02-21 21:33:55 +00001859 input += " a) {}";
Daniel Jasper2cf17bf2013-02-27 09:47:53 +00001860 verifyFormat(input, OnePerLine);
Daniel Jasper2af6bbe2012-12-18 21:05:13 +00001861}
1862
Alexander Kornienko578fdd82012-12-06 18:03:27 +00001863TEST_F(FormatTest, BreaksAsHighAsPossible) {
1864 verifyFormat(
Alexander Kornienkoa5151272013-03-12 16:28:18 +00001865 "void f() {\n"
1866 " if ((aaaaaaaaaaaaaaaaaaaaaaaaaaaaa && aaaaaaaaaaaaaaaaaaaaaaaaaa) ||\n"
1867 " (bbbbbbbbbbbbbbbbbbbbbbbbbbbbbbb && bbbbbbbbbbbbbbbbbbbbbbbbbb))\n"
1868 " f();\n"
1869 "}");
Daniel Jasper70bc8742013-02-26 13:59:14 +00001870 verifyFormat("if (Intervals[i].getRange().getFirst() <\n"
Daniel Jasper6bee6822013-04-08 20:33:42 +00001871 " Intervals[i - 1].getRange().getLast()) {\n}");
Alexander Kornienko578fdd82012-12-06 18:03:27 +00001872}
1873
Daniel Jasper6728fc12013-04-11 14:29:13 +00001874TEST_F(FormatTest, BreaksFunctionDeclarations) {
1875 // Principially, we break function declarations in a certain order:
1876 // 1) break amongst arguments.
1877 verifyFormat("Aaaaaaaaaaaaaa bbbbbbbbbbbbbb(Cccccccccccccc cccccccccccccc,\n"
1878 " Cccccccccccccc cccccccccccccc);");
1879
1880 // 2) break after return type.
Daniel Jasper8e357692013-05-06 08:27:33 +00001881 verifyFormat(
1882 "Aaaaaaaaaaaaaaaaaaaaaaaa\n"
1883 " bbbbbbbbbbbbbb(Cccccccccccccc cccccccccccccccccccccccccc);");
Daniel Jasper6728fc12013-04-11 14:29:13 +00001884
1885 // 3) break after (.
1886 verifyFormat(
1887 "Aaaaaaaaaaaaaaaaaaaaaaaa bbbbbbbbbbbbbbbbbb(\n"
1888 " Cccccccccccccccccccccccccccccc cccccccccccccccccccccccccccccccc);");
1889
1890 // 4) break before after nested name specifiers.
1891 verifyFormat(
1892 "Aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\n"
Daniel Jasper8e357692013-05-06 08:27:33 +00001893 " SomeClasssssssssssssssssssssssssssssssssssssss::\n"
1894 " bbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbb(Cccccccccccccc cccccccccc);");
Daniel Jasper6728fc12013-04-11 14:29:13 +00001895
1896 // However, there are exceptions, if a sufficient amount of lines can be
1897 // saved.
1898 // FIXME: The precise cut-offs wrt. the number of saved lines might need some
1899 // more adjusting.
1900 verifyFormat("Aaaaaaaaaaaaaaaaaa bbbbbbbbbbbbbb(Cccccccccccccc cccccccccc,\n"
1901 " Cccccccccccccc cccccccccc,\n"
1902 " Cccccccccccccc cccccccccc,\n"
1903 " Cccccccccccccc cccccccccc,\n"
1904 " Cccccccccccccc cccccccccc);");
1905 verifyFormat(
1906 "Aaaaaaaaaaaaaaaaaa\n"
Daniel Jasper8e357692013-05-06 08:27:33 +00001907 " bbbbbbbbbbb(Cccccccccccccc cccccccccc, Cccccccccccccc cccccccccc,\n"
1908 " Cccccccccccccc cccccccccc, Cccccccccccccc cccccccccc,\n"
1909 " Cccccccccccccc cccccccccc, Cccccccccccccc cccccccccc);");
Daniel Jasper6728fc12013-04-11 14:29:13 +00001910 verifyFormat(
1911 "Aaaaaaaaaa bbbbbbbbbbbbbbbbbbbbbbbbbbbbbb(Cccccccccccccc cccccccccc,\n"
1912 " Cccccccccccccc cccccccccc,\n"
1913 " Cccccccccccccc cccccccccc,\n"
1914 " Cccccccccccccc cccccccccc,\n"
1915 " Cccccccccccccc cccccccccc,\n"
1916 " Cccccccccccccc cccccccccc,\n"
1917 " Cccccccccccccc cccccccccc);");
1918 verifyFormat("Aaaaaaaaaa bbbbbbbbbbbbbbbbbbbbbbbbbbbbbb(\n"
1919 " Cccccccccccccc cccccccccc, Cccccccccccccc cccccccccc,\n"
1920 " Cccccccccccccc cccccccccc, Cccccccccccccc cccccccccc,\n"
1921 " Cccccccccccccc cccccccccc, Cccccccccccccc cccccccccc,\n"
1922 " Cccccccccccccc cccccccccc, Cccccccccccccc cccccccccc);");
Daniel Jasper1b8e76f2013-04-15 22:36:37 +00001923
1924 // Break after multi-line parameters.
1925 verifyFormat("void aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa(\n"
1926 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\n"
1927 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa,\n"
1928 " bbbb bbbb);");
Daniel Jasper6728fc12013-04-11 14:29:13 +00001929}
1930
Daniel Jasper5be31f72013-05-21 09:16:31 +00001931TEST_F(FormatTest, BreaksFunctionDeclarationsWithTrailingTokens) {
Daniel Jasper13c37b32013-05-22 08:28:26 +00001932 verifyFormat("void someLongFunction(\n"
1933 " int someLongParameter) const {}",
1934 getLLVMStyleWithColumns(46));
1935 FormatStyle Style = getGoogleStyle();
1936 Style.ColumnLimit = 47;
1937 verifyFormat("void\n"
1938 "someLongFunction(int someLongParameter) const {\n}",
1939 getLLVMStyleWithColumns(47));
1940 verifyFormat("void someLongFunction(\n"
1941 " int someLongParameter) const {}",
1942 Style);
1943 verifyFormat("LoooooongReturnType\n"
1944 "someLoooooooongFunction() const {}",
1945 getLLVMStyleWithColumns(47));
1946 verifyFormat("LoooooongReturnType someLoooooooongFunction()\n"
1947 " const {}",
1948 Style);
Daniel Jasper5be31f72013-05-21 09:16:31 +00001949
1950 verifyFormat("void aaaaaaaaaaaa(int aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa)\n"
1951 " LOCKS_EXCLUDED(aaaaaaaaaaaaa);");
1952 verifyFormat("void aaaaaaaaaaaa(int aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa) const\n"
1953 " LOCKS_EXCLUDED(aaaaaaaaaaaaa);");
1954 verifyFormat("void aaaaaaaaaaaa(int aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa) const\n"
1955 " LOCKS_EXCLUDED(aaaaaaaaaaaaa) {}");
1956
1957 verifyFormat(
1958 "void aaaaaaaaaaaaaaaaaa()\n"
1959 " __attribute__((aaaaaaaaaaaaaaaaaaaaaaaaa, aaaaaaaaaaaaaaaaaaaaaaa,\n"
1960 " aaaaaaaaaaaaaaaaaaaaaaaaa));");
1961 verifyFormat("bool aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\n"
1962 " __attribute__((unused));");
1963 verifyFormat(
1964 "bool aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\n"
1965 " GUARDED_BY(aaaaaaaaaaaa);");
1966}
1967
1968
Daniel Jasperf7935112012-12-03 18:12:45 +00001969TEST_F(FormatTest, BreaksDesireably) {
1970 verifyFormat("if (aaaaaaaaaaaaaaaaaaa(aaaaaaaaaaaaaaa) ||\n"
1971 " aaaaaaaaaaaaaaaaaaa(aaaaaaaaaaaaaaa) ||\n"
Manuel Klimeka4fe1c12013-01-21 16:42:44 +00001972 " aaaaaaaaaaaaaaaaaaa(aaaaaaaaaaaaaaa)) {\n}");
Daniel Jasper39e27382013-01-23 20:41:06 +00001973 verifyFormat("if (aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa(\n"
1974 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa)) {\n"
1975 "}");
Daniel Jasperf7935112012-12-03 18:12:45 +00001976
1977 verifyFormat(
1978 "aaaaaaaaaaaaaaaaaaaaa(aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa,\n"
Daniel Jasper12ef4e52013-02-21 21:33:55 +00001979 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa) {}");
Daniel Jasperf7935112012-12-03 18:12:45 +00001980
1981 verifyFormat("aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa(\n"
1982 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa(\n"
1983 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa));");
Daniel Jasper9b155472012-12-04 10:50:12 +00001984
1985 verifyFormat(
1986 "aaaaaaaa(aaaaaaaaaaaaa, aaaaaaaaaaaaaaa(aaaaaaaaaaaaaaaaaaaaaaaaaaaaa(\n"
1987 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa)),\n"
1988 " aaaaaaaa(aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa(\n"
1989 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa)));");
Daniel Jasperaa1c9202012-12-05 14:57:28 +00001990
1991 verifyFormat("aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa ||\n"
1992 " (aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa);");
1993
Daniel Jasper3d0c75c2013-01-02 14:40:02 +00001994 verifyFormat(
Alexander Kornienkoa5151272013-03-12 16:28:18 +00001995 "void f() {\n"
1996 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaa(aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa &&\n"
1997 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa);\n"
1998 "}");
Daniel Jasper7a31af12013-01-25 15:43:32 +00001999 verifyFormat(
2000 "aaaaaa(new Aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa(\n"
2001 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaa));");
2002 verifyFormat(
2003 "aaaaaa(aaa, new Aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa(\n"
2004 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaa));");
Daniel Jasperaab220f2013-03-20 13:53:11 +00002005 verifyFormat(
2006 "aaaaaaaaaaaaaaaaa(\n"
2007 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaa + aaaaaaaaaaaaaaaaaaaaaaaaaaaaaa,\n"
2008 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaa);");
Daniel Jasper3d0c75c2013-01-02 14:40:02 +00002009
Daniel Jasperaa1c9202012-12-05 14:57:28 +00002010 // This test case breaks on an incorrect memoization, i.e. an optimization not
2011 // taking into account the StopAt value.
2012 verifyFormat(
2013 "return aaaaaaaaaaaaaaaaaaaaaaaa || aaaaaaaaaaaaaaaaaaaaaaa ||\n"
Daniel Jasper2eda23e2012-12-24 13:43:52 +00002014 " aaaaaaaaaaa(aaaaaaaaa) || aaaaaaaaaaaaaaaaaaaaaaa ||\n"
2015 " aaaaaaaaaaaaaaaaaaaaaaaaa || aaaaaaaaaaaaaaaaaaaaaaa ||\n"
2016 " (aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa);");
Daniel Jasper6d822722012-12-24 16:43:00 +00002017
Daniel Jasper8d1832e2013-01-07 13:26:07 +00002018 verifyFormat("{\n {\n {\n"
2019 " Annotation.SpaceRequiredBefore =\n"
2020 " Line.Tokens[i - 1].Tok.isNot(tok::l_paren) &&\n"
2021 " Line.Tokens[i - 1].Tok.isNot(tok::l_square);\n"
2022 " }\n }\n}");
Daniel Jasperf7935112012-12-03 18:12:45 +00002023}
2024
Daniel Jasper9278eb92013-01-16 14:59:02 +00002025TEST_F(FormatTest, FormatsOneParameterPerLineIfNecessary) {
Daniel Jaspera628c982013-04-03 13:36:17 +00002026 FormatStyle NoBinPacking = getGoogleStyle();
Daniel Jasper2cf17bf2013-02-27 09:47:53 +00002027 NoBinPacking.BinPackParameters = false;
2028 verifyFormat("f(aaaaaaaaaaaaaaaaaaaa,\n"
2029 " aaaaaaaaaaaaaaaaaaaa,\n"
2030 " aaaaaaaaaaaaaaaaaaaa + aaaaaaaaaaaaaaaaaaaa);",
2031 NoBinPacking);
2032 verifyFormat("aaaaaaa(aaaaaaaaaaaaa,\n"
2033 " aaaaaaaaaaaaa,\n"
2034 " aaaaaaaaaaaaa(aaaaaaaaaaaaaaaaa, aaaaaaaaaaaaaaaa));",
2035 NoBinPacking);
2036 verifyFormat(
Daniel Jasper9278eb92013-01-16 14:59:02 +00002037 "aaaaaaaa(aaaaaaaaaaaaa,\n"
2038 " aaaaaaaaaaaaaaa(aaaaaaaaaaaaaaaaaaaaaaaaaaaaa(\n"
2039 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa)),\n"
2040 " aaaaaaaa(aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa(\n"
Daniel Jasper2cf17bf2013-02-27 09:47:53 +00002041 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa)));",
2042 NoBinPacking);
2043 verifyFormat("aaaaaaaaaaaaaaa(aaaaaaaaa, aaaaaaaaa, aaaaaaaaaaaaaaaaaaaaa)\n"
2044 " .aaaaaaaaaaaaaaaaaa();",
2045 NoBinPacking);
2046 verifyFormat("aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa(\n"
2047 " aaaaaaaaaa, aaaaaaaaaa, aaaaaaaaaa, aaaaaaaaaaa);",
2048 NoBinPacking);
Daniel Jasper2ec3ffb82013-02-18 11:59:17 +00002049
Daniel Jasper2cf17bf2013-02-27 09:47:53 +00002050 verifyFormat(
Daniel Jaspere941b162013-01-23 10:08:28 +00002051 "aaaaaaaaaaaa(aaaaaaaaaaaaaaaaaaaaaaaaaaaa + aaaaaaaaaaaaaaaaaaaaaaaaa,\n"
2052 " aaaaaaaaaaaa,\n"
Daniel Jasper2cf17bf2013-02-27 09:47:53 +00002053 " aaaaaaaaaaaa);",
2054 NoBinPacking);
2055 verifyFormat(
Daniel Jasper9278eb92013-01-16 14:59:02 +00002056 "somefunction(someotherFunction(ddddddddddddddddddddddddddddddddddd,\n"
2057 " ddddddddddddddddddddddddddddd),\n"
Daniel Jasper2cf17bf2013-02-27 09:47:53 +00002058 " test);",
2059 NoBinPacking);
Daniel Jasper9278eb92013-01-16 14:59:02 +00002060
Daniel Jasper2cf17bf2013-02-27 09:47:53 +00002061 verifyFormat("std::vector<aaaaaaaaaaaaaaaaaaaaaaa,\n"
2062 " aaaaaaaaaaaaaaaaaaaaaaa,\n"
2063 " aaaaaaaaaaaaaaaaaaaaaaa> aaaaaaaaaaaaaaaaaa;",
2064 NoBinPacking);
2065 verifyFormat("a(\"a\"\n"
2066 " \"a\",\n"
2067 " a);");
Daniel Jaspere941b162013-01-23 10:08:28 +00002068
Daniel Jasper2cf17bf2013-02-27 09:47:53 +00002069 NoBinPacking.AllowAllParametersOfDeclarationOnNextLine = false;
Daniel Jasperf7db4332013-01-29 16:03:49 +00002070 verifyFormat("void aaaaaaaaaa(aaaaaaaaa,\n"
Daniel Jaspere941b162013-01-23 10:08:28 +00002071 " aaaaaaaaa,\n"
Daniel Jasperf7db4332013-01-29 16:03:49 +00002072 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa);",
Daniel Jasper2cf17bf2013-02-27 09:47:53 +00002073 NoBinPacking);
Daniel Jasper687af3b2013-02-14 14:26:07 +00002074 verifyFormat(
2075 "void f() {\n"
2076 " aaaaaaaaaaaaaaaaaaaaaaa(aaaaaaaaa, aaaaaaaaa, aaaaaaaaaaaaaaaaaaaaa)\n"
2077 " .aaaaaaa();\n"
Daniel Jasper2ec3ffb82013-02-18 11:59:17 +00002078 "}",
Daniel Jasper2cf17bf2013-02-27 09:47:53 +00002079 NoBinPacking);
Daniel Jasper53e8d852013-05-22 08:55:55 +00002080 verifyFormat(
2081 "template <class SomeType, class SomeOtherType>\n"
2082 "SomeType SomeFunction(SomeType Type, SomeOtherType OtherType) {}",
2083 NoBinPacking);
Daniel Jasper9278eb92013-01-16 14:59:02 +00002084}
2085
Daniel Jasper04468962013-01-18 10:56:38 +00002086TEST_F(FormatTest, FormatsBuilderPattern) {
2087 verifyFormat(
2088 "return llvm::StringSwitch<Reference::Kind>(name)\n"
Daniel Jaspere7de2a32013-04-08 10:45:44 +00002089 " .StartsWith(\".eh_frame_hdr\", ORDER_EH_FRAMEHDR)\n"
2090 " .StartsWith(\".eh_frame\", ORDER_EH_FRAME).StartsWith(\".init\", ORDER_INIT)\n"
2091 " .StartsWith(\".fini\", ORDER_FINI).StartsWith(\".hash\", ORDER_HASH)\n"
2092 " .Default(ORDER_TEXT);\n");
Daniel Jasperc6fbc212013-05-15 09:35:08 +00002093
Daniel Jaspereb50c672013-02-15 20:33:06 +00002094 verifyFormat("return aaaaaaaaaaaaaaaaa->aaaaa().aaaaaaaaaaaaa().aaaaaa() <\n"
Daniel Jasper6bee6822013-04-08 20:33:42 +00002095 " aaaaaaaaaaaaaaa->aaaaa().aaaaaaaaaaaaa().aaaaaa();");
Daniel Jasper9ed9ade2013-02-18 13:24:21 +00002096 verifyFormat(
2097 "aaaaaaa->aaaaaaa\n"
2098 " ->aaaaaaaaaaaaaaaa(aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa)\n"
2099 " ->aaaaaaaa(aaaaaaaaaaaaaaa);");
Daniel Jaspere53beb22013-02-18 13:52:06 +00002100 verifyFormat(
2101 "aaaaaaaaaaaaaaaaaaa()->aaaaaa(bbbbb)->aaaaaaaaaaaaaaaaaaa( // break\n"
Daniel Jasperf9a84b52013-03-01 16:48:32 +00002102 " aaaaaaaaaaaaaa);");
Daniel Jaspere53beb22013-02-18 13:52:06 +00002103 verifyFormat(
2104 "aaaaaaaaaaaaaaaaaaaaaaa *aaaaaaaaa = aaaaaa->aaaaaaaaaaaa()\n"
2105 " ->aaaaaaaaaaaaaaaa(\n"
Daniel Jasper66e4f832013-05-10 13:37:16 +00002106 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa)\n"
Daniel Jaspere53beb22013-02-18 13:52:06 +00002107 " ->aaaaaaaaaaaaaaaaa();");
Daniel Jasper04468962013-01-18 10:56:38 +00002108}
2109
Daniel Jasperde5c2072012-12-24 00:13:23 +00002110TEST_F(FormatTest, BreaksAccordingToOperatorPrecedence) {
2111 verifyFormat(
2112 "if (aaaaaaaaaaaaaaaaaaaaaaaaa ||\n"
Manuel Klimeka4fe1c12013-01-21 16:42:44 +00002113 " bbbbbbbbbbbbbbbbbbbbbbbbb && ccccccccccccccccccccccccc) {\n}");
Daniel Jasper8d1832e2013-01-07 13:26:07 +00002114 verifyFormat("if (aaaaaaaaaaaaaaaaaaaaaaaaa && bbbbbbbbbbbbbbbbbbbbbbbbb ||\n"
Manuel Klimeka4fe1c12013-01-21 16:42:44 +00002115 " ccccccccccccccccccccccccc) {\n}");
Daniel Jasper8d1832e2013-01-07 13:26:07 +00002116 verifyFormat("if (aaaaaaaaaaaaaaaaaaaaaaaaa || bbbbbbbbbbbbbbbbbbbbbbbbb ||\n"
Manuel Klimeka4fe1c12013-01-21 16:42:44 +00002117 " ccccccccccccccccccccccccc) {\n}");
Daniel Jasperde5c2072012-12-24 00:13:23 +00002118 verifyFormat(
2119 "if ((aaaaaaaaaaaaaaaaaaaaaaaaa || bbbbbbbbbbbbbbbbbbbbbbbbb) &&\n"
Manuel Klimeka4fe1c12013-01-21 16:42:44 +00002120 " ccccccccccccccccccccccccc) {\n}");
Daniel Jasper400adc62013-02-08 15:28:42 +00002121 verifyFormat("return aaaa & AAAAAAAAAAAAAAAAAAAAAAAAAAAAA ||\n"
2122 " bbbb & BBBBBBBBBBBBBBBBBBBBBBBBBBBBB ||\n"
2123 " cccc & CCCCCCCCCCCCCCCCCCCCCCCCCC ||\n"
2124 " dddd & DDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDD;");
2125 verifyFormat("if ((aaaaaaaaaa != aaaaaaaaaaaaaaa ||\n"
2126 " aaaaaaaaaaaaaaaaaaaaaaaa() >= aaaaaaaaaaaaaaaaaaaa) &&\n"
2127 " aaaaaaaaaaaaaaa != aa) {\n}");
Daniel Jasperde5c2072012-12-24 00:13:23 +00002128}
2129
Daniel Jasper43b65482013-01-23 12:27:43 +00002130TEST_F(FormatTest, BreaksAfterAssignments) {
Daniel Jasper206df732013-01-07 13:08:40 +00002131 verifyFormat(
Daniel Jasper43b65482013-01-23 12:27:43 +00002132 "unsigned Cost =\n"
2133 " TTI.getMemoryOpCost(I->getOpcode(), VectorTy, SI->getAlignment(),\n"
2134 " SI->getPointerAddressSpaceee());\n");
Daniel Jasper206df732013-01-07 13:08:40 +00002135 verifyFormat(
Daniel Jasper1565eb32013-01-23 15:55:19 +00002136 "CharSourceRange LineRange = CharSourceRange::getTokenRange(\n"
2137 " Line.Tokens.front().Tok.getLo(), Line.Tokens.back().Tok.getLoc());");
Daniel Jaspera836b902013-01-23 16:58:21 +00002138
2139 verifyFormat(
2140 "aaaaaaaaaaaaaaaaaaaaaaaaaa aaaa = aaaaaaaaaaaaaa(0).aaaa()\n"
2141 " .aaaaaaaaaaaa(aaaaaaaaaaaaaaaaaaa::aaaaaaaaaaaaaaaaaaaaa);");
Daniel Jasper206df732013-01-07 13:08:40 +00002142}
2143
Daniel Jasper2eda23e2012-12-24 13:43:52 +00002144TEST_F(FormatTest, AlignsAfterAssignments) {
2145 verifyFormat(
2146 "int Result = aaaaaaaaaaaaaaaaaaaaaaaaa + aaaaaaaaaaaaaaaaaaaaaaaaa +\n"
Daniel Jasper206df732013-01-07 13:08:40 +00002147 " aaaaaaaaaaaaaaaaaaaaaaaaa;");
Daniel Jasper2eda23e2012-12-24 13:43:52 +00002148 verifyFormat(
2149 "Result += aaaaaaaaaaaaaaaaaaaaaaaaa + aaaaaaaaaaaaaaaaaaaaaaaaa +\n"
Daniel Jasper206df732013-01-07 13:08:40 +00002150 " aaaaaaaaaaaaaaaaaaaaaaaaa;");
Daniel Jasper2eda23e2012-12-24 13:43:52 +00002151 verifyFormat(
2152 "Result >>= aaaaaaaaaaaaaaaaaaaaaaaaa + aaaaaaaaaaaaaaaaaaaaaaaaa +\n"
Daniel Jasper206df732013-01-07 13:08:40 +00002153 " aaaaaaaaaaaaaaaaaaaaaaaaa;");
Daniel Jasper2eda23e2012-12-24 13:43:52 +00002154 verifyFormat(
2155 "int Result = (aaaaaaaaaaaaaaaaaaaaaaaaa + aaaaaaaaaaaaaaaaaaaaaaaaa +\n"
Daniel Jasper206df732013-01-07 13:08:40 +00002156 " aaaaaaaaaaaaaaaaaaaaaaaaa);");
Daniel Jasper2ec3ffb82013-02-18 11:59:17 +00002157 verifyFormat("double LooooooooooooooooooooooooongResult =\n"
2158 " aaaaaaaaaaaaaaaaaaaaaaaa + aaaaaaaaaaaaaaaaaaaaaaaa +\n"
2159 " aaaaaaaaaaaaaaaaaaaaaaaa;");
Daniel Jasper2eda23e2012-12-24 13:43:52 +00002160}
2161
2162TEST_F(FormatTest, AlignsAfterReturn) {
2163 verifyFormat(
2164 "return aaaaaaaaaaaaaaaaaaaaaaaaa + aaaaaaaaaaaaaaaaaaaaaaaaa +\n"
2165 " aaaaaaaaaaaaaaaaaaaaaaaaa;");
2166 verifyFormat(
2167 "return (aaaaaaaaaaaaaaaaaaaaaaaaa + aaaaaaaaaaaaaaaaaaaaaaaaa +\n"
2168 " aaaaaaaaaaaaaaaaaaaaaaaaa);");
Daniel Jasperc238c872013-04-02 14:33:13 +00002169 verifyFormat(
2170 "return aaaaaaaaaaaaaaaaaaaaaa + aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa >=\n"
Daniel Jasper6bee6822013-04-08 20:33:42 +00002171 " aaaaaaaaaaaaaaaaaaaaaa();");
Daniel Jasperc238c872013-04-02 14:33:13 +00002172 verifyFormat(
2173 "return (aaaaaaaaaaaaaaaaaaaaaa + aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa >=\n"
Daniel Jasper6bee6822013-04-08 20:33:42 +00002174 " aaaaaaaaaaaaaaaaaaaaaa());");
2175 verifyFormat("return aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa(\n"
2176 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa);");
2177 verifyFormat("return aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa(\n"
2178 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa) &&\n"
2179 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa;");
Daniel Jasper2eda23e2012-12-24 13:43:52 +00002180}
2181
Daniel Jasper399d24b2013-01-09 07:06:56 +00002182TEST_F(FormatTest, BreaksConditionalExpressions) {
2183 verifyFormat(
2184 "aaaa(aaaaaaaaaaaaaaaaaaaa,\n"
Daniel Jasperca6623b2013-01-28 12:45:14 +00002185 " aaaaaaaaaaaaaaaaaaaaaaaaaa ? aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\n"
2186 " : aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa);");
Daniel Jasper8c5fba92013-01-16 16:23:19 +00002187 verifyFormat(
Daniel Jasperca6623b2013-01-28 12:45:14 +00002188 "aaaa(aaaaaaaaaaaaaaaaaaaa, aaaaaaa ? aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\n"
2189 " : aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa);");
2190 verifyFormat(
2191 "aaaaaaaaaaaaaaaaaaaaaaaaaaaaaa(aaaaaaaaaaaaaaaaaaaa ? aaaa(aaaaaa)\n"
2192 " : aaaaaaaaaaaaa);");
2193 verifyFormat(
2194 "aaaaaaaaaaaaaaaaaa(aaaaaaaaaaaaaaaaaaaaaaaaa,\n"
Daniel Jasperaab220f2013-03-20 13:53:11 +00002195 " aaaaaaaaaaaaaaaa ? aaaaaaaaaaaaaaaaaaaaaaaaaaaaa\n"
Daniel Jasperca6623b2013-01-28 12:45:14 +00002196 " : aaaaaaaaaaaaaaaaaaaaaaaaaaaa,\n"
2197 " aaaaaaaaaaaaa);");
2198 verifyFormat("aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\n"
2199 " ? aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa(\n"
2200 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa)\n"
2201 " : aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa(\n"
2202 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa);");
2203 verifyFormat("aaaaaa(aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa,\n"
2204 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\n"
2205 " ? aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa(\n"
2206 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa)\n"
2207 " : aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa(\n"
2208 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa),\n"
2209 " aaaaaaaaaaaaaaaaaaaaaaaaaaa);");
Daniel Jasper54a86022013-02-15 11:07:25 +00002210
2211 verifyFormat("aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\n"
2212 " ? aaaaaaaaaaaaaaaaaaaaaaaaaaa\n"
2213 " : aaaaaaaaaaaaaaaaaaaaaaaaaaa;");
Daniel Jasperc238c872013-04-02 14:33:13 +00002214 verifyFormat("aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa aaaaaa =\n"
2215 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\n"
2216 " ? aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\n"
2217 " : aaaaaaaaaaaaaaaa;");
Daniel Jaspercd8599e2013-02-23 21:01:55 +00002218 verifyFormat(
2219 "aaaaaaaaaaaaaaaaaaaaaaaaaaaaaa == aaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\n"
2220 " ? aaaaaaaaaaaaaaa\n"
2221 " : aaaaaaaaaaaaaaa;");
2222 verifyFormat("f(aaaaaaaaaaaaaaaa == // force break\n"
Daniel Jasper6bee6822013-04-08 20:33:42 +00002223 " aaaaaaaaa\n"
Daniel Jaspere7de2a32013-04-08 10:45:44 +00002224 " ? b\n"
2225 " : c);");
Daniel Jasper8360a862013-02-08 16:49:27 +00002226 verifyFormat(
Daniel Jasper54a86022013-02-15 11:07:25 +00002227 "unsigned Indent =\n"
2228 " format(TheLine.First, IndentForLevel[TheLine.Level] >= 0\n"
2229 " ? IndentForLevel[TheLine.Level]\n"
Daniel Jasper37905f72013-02-21 15:00:29 +00002230 " : TheLine * 2,\n"
2231 " TheLine.InPPDirective, PreviousEndOfLineColumn);",
Daniel Jasper2ec3ffb82013-02-18 11:59:17 +00002232 getLLVMStyleWithColumns(70));
Daniel Jasper54a86022013-02-15 11:07:25 +00002233
Daniel Jasper2cf17bf2013-02-27 09:47:53 +00002234 FormatStyle NoBinPacking = getLLVMStyle();
2235 NoBinPacking.BinPackParameters = false;
2236 verifyFormat(
Daniel Jaspercd8599e2013-02-23 21:01:55 +00002237 "void f() {\n"
2238 " g(aaa,\n"
2239 " aaaaaaaaaa == aaaaaaaaaa ? aaaa : aaaaa,\n"
2240 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaa == aaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\n"
2241 " ? aaaaaaaaaaaaaaa\n"
2242 " : aaaaaaaaaaaaaaa);\n"
Daniel Jasper2cf17bf2013-02-27 09:47:53 +00002243 "}",
2244 NoBinPacking);
Daniel Jasper399d24b2013-01-09 07:06:56 +00002245}
2246
Daniel Jasper38c11ce2013-01-29 11:21:01 +00002247TEST_F(FormatTest, DeclarationsOfMultipleVariables) {
2248 verifyFormat("bool aaaaaaaaaaaaaaaaa = aaaaaa->aaaaaaaaaaaaaaaaa(),\n"
2249 " aaaaaaaaaaa = aaaaaa->aaaaaaaaaaa();");
2250 verifyFormat("bool a = true, b = false;");
2251
Daniel Jasper38c11ce2013-01-29 11:21:01 +00002252 verifyFormat("bool aaaaaaaaaaaaaaaaaaaaaaaaa =\n"
Daniel Jaspera628c982013-04-03 13:36:17 +00002253 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa(aaaaaaaaaaaaaaaa),\n"
Daniel Jasper38c11ce2013-01-29 11:21:01 +00002254 " bbbbbbbbbbbbbbbbbbbbbbbbb =\n"
Daniel Jasperc238c872013-04-02 14:33:13 +00002255 " bbbbbbbbbbbbbbbbbbbbbbbbbbbbbbb(bbbbbbbbbbbbbbbb);");
Daniel Jasper38c11ce2013-01-29 11:21:01 +00002256 verifyFormat(
Daniel Jasper37905f72013-02-21 15:00:29 +00002257 "bool aaaaaaaaaaaaaaaaaaaaa =\n"
Daniel Jaspera628c982013-04-03 13:36:17 +00002258 " bbbbbbbbbbbbbbbbbbbbbbbbbbbb && cccccccccccccccccccccccccccc,\n"
Daniel Jasper37905f72013-02-21 15:00:29 +00002259 " d = e && f;");
Daniel Jasper31c96b92013-04-05 09:38:50 +00002260 verifyFormat("aaaaaaaaa a = aaaaaaaaaaaaaaaaaaaa, b = bbbbbbbbbbbbbbbbbbbb,\n"
2261 " c = cccccccccccccccccccc, d = dddddddddddddddddddd;");
2262 verifyFormat("aaaaaaaaa *a = aaaaaaaaaaaaaaaaaaa, *b = bbbbbbbbbbbbbbbbbbb,\n"
2263 " *c = ccccccccccccccccccc, *d = ddddddddddddddddddd;");
2264 verifyFormat("aaaaaaaaa ***a = aaaaaaaaaaaaaaaaaaa, ***b = bbbbbbbbbbbbbbb,\n"
2265 " ***c = ccccccccccccccccccc, ***d = ddddddddddddddd;");
2266 // FIXME: If multiple variables are defined, the "*" needs to move to the new
2267 // line. Also fix indent for breaking after the type, this looks bad.
2268 verifyFormat("aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa *\n"
Daniel Jasper8e357692013-05-06 08:27:33 +00002269 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaa = aaaaaaaaaaaaaaaaaaa,\n"
2270 " *b = bbbbbbbbbbbbbbbbbbb;");
Daniel Jasper38c11ce2013-01-29 11:21:01 +00002271
Daniel Jasper31c96b92013-04-05 09:38:50 +00002272 // Not ideal, but pointer-with-type does not allow much here.
2273 verifyGoogleFormat(
2274 "aaaaaaaaa* a = aaaaaaaaaaaaaaaaaaa, *b = bbbbbbbbbbbbbbbbbbb,\n"
2275 " *b = bbbbbbbbbbbbbbbbbbb, *d = ddddddddddddddddddd;");
Daniel Jasper38c11ce2013-01-29 11:21:01 +00002276}
2277
Nico Weber4a5030c2013-01-12 01:28:06 +00002278TEST_F(FormatTest, ConditionalExpressionsInBrackets) {
2279 verifyFormat("arr[foo ? bar : baz];");
2280 verifyFormat("f()[foo ? bar : baz];");
2281 verifyFormat("(a + b)[foo ? bar : baz];");
2282 verifyFormat("arr[foo ? (4 > 5 ? 4 : 5) : 5 < 5 ? 5 : 7];");
2283}
2284
Daniel Jasperf7935112012-12-03 18:12:45 +00002285TEST_F(FormatTest, AlignsStringLiterals) {
2286 verifyFormat("loooooooooooooooooooooooooongFunction(\"short literal \"\n"
2287 " \"short literal\");");
2288 verifyFormat(
2289 "looooooooooooooooooooooooongFunction(\n"
2290 " \"short literal\"\n"
2291 " \"looooooooooooooooooooooooooooooooooooooooooooooooong literal\");");
Daniel Jasper2ec3ffb82013-02-18 11:59:17 +00002292 verifyFormat("someFunction(\"Always break between multi-line\"\n"
2293 " \" string literals\",\n"
2294 " and, other, parameters);");
Manuel Klimek02f640a2013-02-20 15:25:48 +00002295 EXPECT_EQ("fun + \"1243\" /* comment */\n"
2296 " \"5678\";",
2297 format("fun + \"1243\" /* comment */\n"
2298 " \"5678\";",
2299 getLLVMStyleWithColumns(28)));
2300 EXPECT_EQ(
2301 "aaaaaa = \"aaaaaaaaaaaaaaaaaaaaaaaaaa aaaaaaaaaaaaaaaaaaaaaaaaaaaa \"\n"
2302 " \"aaaaaaaaaaaaaaaaaaaaa\"\n"
2303 " \"aaaaaaaaaaaaaaaa\";",
2304 format("aaaaaa ="
2305 "\"aaaaaaaaaaaaaaaaaaaaaaaaaa aaaaaaaaaaaaaaaaaaaaaaaaaaaa "
2306 "aaaaaaaaaaaaaaaaaaaaa\" "
2307 "\"aaaaaaaaaaaaaaaa\";"));
Manuel Klimek0c915712013-02-20 15:32:58 +00002308 verifyFormat("a = a + \"a\"\n"
2309 " \"a\"\n"
2310 " \"a\";");
Daniel Jasper7dd22c51b2013-05-16 04:26:02 +00002311 verifyFormat("f(\"a\", \"b\"\n"
2312 " \"c\");");
Daniel Jasperaf5ba0e2013-02-23 07:46:38 +00002313
2314 verifyFormat(
2315 "#define LL_FORMAT \"ll\"\n"
2316 "printf(\"aaaaa: %d, bbbbbb: %\" LL_FORMAT \"d, cccccccc: %\" LL_FORMAT\n"
2317 " \"d, ddddddddd: %\" LL_FORMAT \"d\");");
Daniel Jasper47a04442013-05-13 20:50:15 +00002318
2319 verifyFormat("#define A(X) \\\n"
2320 " \"aaaaa\" #X \"bbbbbb\" \\\n"
2321 " \"ccccc\"",
2322 getLLVMStyleWithColumns(23));
2323 verifyFormat("#define A \"def\"\n"
2324 "f(\"abc\" A \"ghi\"\n"
2325 " \"jkl\");");
Daniel Jasperf7935112012-12-03 18:12:45 +00002326}
2327
Alexander Kornienko578fdd82012-12-06 18:03:27 +00002328TEST_F(FormatTest, AlignsPipes) {
2329 verifyFormat(
2330 "aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\n"
2331 " << aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\n"
2332 " << aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa;");
2333 verifyFormat(
2334 "aaaaaaaaaaaaaaaaaaaa << aaaaaaaaaaaaaaaaaaaa << aaaaaaaaaaaaaaaaaaaa\n"
2335 " << aaaaaaaaaaaaaaaaaaaa;");
2336 verifyFormat(
2337 "aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa << aaaaaaaaaaaaaaaaaaaaaaaaaaaa\n"
2338 " << aaaaaaaaaaaaaaaaaaaaaaaaaaaa;");
2339 verifyFormat(
2340 "llvm::outs() << \"aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\"\n"
2341 " \"bbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbb\"\n"
2342 " << \"ccccccccccccccccccccccccccccccccccccccccccccccccc\";");
2343 verifyFormat(
2344 "aaaaaaaa << (aaaaaaaaaaaaaaaaaaa << aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\n"
2345 " << aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa)\n"
2346 " << aaaaaaaaaaaaaaaaaaaaaaaaaaaaa;");
Daniel Jasper2603ee02013-02-04 07:34:48 +00002347
2348 verifyFormat("return out << \"somepacket = {\\n\"\n"
2349 " << \" aaaaaa = \" << pkt.aaaaaa << \"\\n\"\n"
2350 " << \" bbbb = \" << pkt.bbbb << \"\\n\"\n"
2351 " << \" cccccc = \" << pkt.cccccc << \"\\n\"\n"
2352 " << \" ddd = [\" << pkt.ddd << \"]\\n\"\n"
2353 " << \"}\";");
Daniel Jasperba9ddb62013-02-06 21:04:05 +00002354
2355 verifyFormat(
2356 "llvm::outs() << \"aaaaaaaaaaaaaaaaa = \" << aaaaaaaaaaaaaaaaa\n"
2357 " << \"bbbbbbbbbbbbbbbbb = \" << bbbbbbbbbbbbbbbbb\n"
2358 " << \"ccccccccccccccccc = \" << ccccccccccccccccc\n"
2359 " << \"ddddddddddddddddd = \" << ddddddddddddddddd\n"
2360 " << \"eeeeeeeeeeeeeeeee = \" << eeeeeeeeeeeeeeeee;");
Daniel Jasperf38a0ac2013-03-14 14:00:17 +00002361 verifyFormat("llvm::outs() << aaaaaaaaaaaaaaaaaaaaaaaa << \"=\"\n"
2362 " << bbbbbbbbbbbbbbbbbbbbbbbbbbbbbbb;");
Daniel Jaspera4c571c2013-05-22 09:13:26 +00002363 verifyFormat("llvm::outs() << \"aaaaaaaaaaaaaaaaaaaaaaaa: \"\n"
2364 " << aaaaaaaaaaaaa(aaaaaaaaaaaaaaaaaaaaaaaaaaaa);");
Daniel Jasperc238c872013-04-02 14:33:13 +00002365
2366 verifyFormat(
2367 "llvm::errs() << aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\n"
2368 " .aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa();");
Alexander Kornienko578fdd82012-12-06 18:03:27 +00002369}
2370
Daniel Jasperf7935112012-12-03 18:12:45 +00002371TEST_F(FormatTest, UnderstandsEquals) {
2372 verifyFormat(
2373 "aaaaaaaaaaaaaaaaa =\n"
2374 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa;");
2375 verifyFormat(
2376 "if (aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa =\n"
Manuel Klimeka4fe1c12013-01-21 16:42:44 +00002377 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa) {\n}");
Daniel Jasperf7935112012-12-03 18:12:45 +00002378 verifyFormat(
2379 "if (a) {\n"
Manuel Klimeke7d10a12013-01-10 13:24:24 +00002380 " f();\n"
Daniel Jasperf7935112012-12-03 18:12:45 +00002381 "} else if (aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa =\n"
Manuel Klimeka4fe1c12013-01-21 16:42:44 +00002382 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa) {\n"
2383 "}");
Daniel Jasperf7935112012-12-03 18:12:45 +00002384
Daniel Jasper2ec3ffb82013-02-18 11:59:17 +00002385 verifyFormat("if (int aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa =\n"
2386 " 100000000 + 10000000) {\n}");
Daniel Jasperf7935112012-12-03 18:12:45 +00002387}
2388
Daniel Jasper5485d0c2012-12-17 14:34:14 +00002389TEST_F(FormatTest, WrapsAtFunctionCallsIfNecessary) {
Daniel Jasper2af6bbe2012-12-18 21:05:13 +00002390 verifyFormat("LoooooooooooooooooooooooooooooooooooooongObject\n"
2391 " .looooooooooooooooooooooooooooooooooooooongFunction();");
Daniel Jasper5485d0c2012-12-17 14:34:14 +00002392
Daniel Jasper2af6bbe2012-12-18 21:05:13 +00002393 verifyFormat("LoooooooooooooooooooooooooooooooooooooongObject\n"
2394 " ->looooooooooooooooooooooooooooooooooooooongFunction();");
Daniel Jasper5485d0c2012-12-17 14:34:14 +00002395
2396 verifyFormat(
2397 "LooooooooooooooooooooooooooooooooongObject->shortFunction(Parameter1,\n"
2398 " Parameter2);");
2399
2400 verifyFormat(
2401 "ShortObject->shortFunction(\n"
2402 " LooooooooooooooooooooooooooooooooooooooooooooooongParameter1,\n"
2403 " LooooooooooooooooooooooooooooooooooooooooooooooongParameter2);");
2404
2405 verifyFormat("loooooooooooooongFunction(\n"
2406 " LoooooooooooooongObject->looooooooooooooooongFunction());");
2407
2408 verifyFormat(
2409 "function(LoooooooooooooooooooooooooooooooooooongObject\n"
2410 " ->loooooooooooooooooooooooooooooooooooooooongFunction());");
2411
Daniel Jasper687af3b2013-02-14 14:26:07 +00002412 verifyFormat("EXPECT_CALL(SomeObject, SomeFunction(Parameter))\n"
2413 " .WillRepeatedly(Return(SomeValue));");
2414 verifyFormat("SomeMap[std::pair(aaaaaaaaaaaa, bbbbbbbbbbbbbbb)]\n"
2415 " .insert(ccccccccccccccccccccccc);");
Daniel Jasper9b334242013-03-15 14:57:30 +00002416 verifyFormat(
2417 "aaaaa(aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa,\n"
2418 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa)\n"
2419 " .aaaaaaaaaaaaaaa(\n"
Daniel Jasper66e4f832013-05-10 13:37:16 +00002420 " aa(aaaaaaaaaaaaaaaaaaaaaaaaaaa, aaaaaaaaaaaaaaaaaaaaaaaaaaa,\n"
2421 " aaaaaaaaaaaaaaaaaaaaaaaaaaa));");
Daniel Jasperc238c872013-04-02 14:33:13 +00002422 verifyFormat("if (aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\n"
2423 " .aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\n"
2424 " .aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\n"
2425 " .aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa()) {\n"
2426 "}");
Daniel Jasper687af3b2013-02-14 14:26:07 +00002427
Daniel Jasperc7345cc2013-01-07 07:13:20 +00002428 // Here, it is not necessary to wrap at "." or "->".
Daniel Jasper2af6bbe2012-12-18 21:05:13 +00002429 verifyFormat("if (aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa(aaaaaaaaaaaa) ||\n"
Manuel Klimeka4fe1c12013-01-21 16:42:44 +00002430 " aaaa.aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa) {\n}");
Daniel Jasperc7345cc2013-01-07 07:13:20 +00002431 verifyFormat(
2432 "aaaaaaaaaaa->aaaaaaaaa(\n"
2433 " aaaaaaaaaaaaaaaaaaaaaaaaa,\n"
2434 " aaaaaaaaaaaaaaaaaa->aaaaaaaaa(aaaaaaaaaaaaaaaaaaaaaaaaa));\n");
Daniel Jaspere11095a2013-02-14 15:01:34 +00002435
2436 verifyFormat(
2437 "aaaaaaaaaaaaaaaaaaaaaaaaa(\n"
2438 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa().aaaaaaaaaaaaaaaaa());");
Daniel Jasper8f6ae192013-03-13 15:37:48 +00002439 verifyFormat("a->aaaaaa()->aaaaaaaaaaa(aaaaaaaa()->aaaaaa()->aaaaa() *\n"
2440 " aaaaaaaaa()->aaaaaa()->aaaaa());");
2441 verifyFormat("a->aaaaaa()->aaaaaaaaaaa(aaaaaaaa()->aaaaaa()->aaaaa() ||\n"
2442 " aaaaaaaaa()->aaaaaa()->aaaaa());");
Daniel Jasper2cf17bf2013-02-27 09:47:53 +00002443
Daniel Jasper9b334242013-03-15 14:57:30 +00002444 // FIXME: Should we break before .a()?
2445 verifyFormat("aaaaa(aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa,\n"
2446 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa).a();");
2447
Daniel Jasper2cf17bf2013-02-27 09:47:53 +00002448 FormatStyle NoBinPacking = getLLVMStyle();
2449 NoBinPacking.BinPackParameters = false;
2450 verifyFormat("aaaaaaaaaaaaaaaaaaaaaa(aaaaaaaaaaaaaaaaaaaaa)\n"
2451 " .aaaaaaaaaaaaaaaaa(aaaaaaaaaaaaaaaaaaaaa)\n"
2452 " .aaaaaaaaaaaaaaaaaaa(aaaaaaaaaaaaaaaaaaa,\n"
2453 " aaaaaaaaaaaaaaaaaaa,\n"
2454 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa);",
2455 NoBinPacking);
Daniel Jasper5485d0c2012-12-17 14:34:14 +00002456}
2457
Daniel Jasperac5c1c22013-01-02 15:08:56 +00002458TEST_F(FormatTest, WrapsTemplateDeclarations) {
2459 verifyFormat("template <typename T>\n"
2460 "virtual void loooooooooooongFunction(int Param1, int Param2);");
2461 verifyFormat(
Daniel Jasper04468962013-01-18 10:56:38 +00002462 "template <typename T>\n"
Daniel Jasper400adc62013-02-08 15:28:42 +00002463 "using comment_to_xml_conversion = comment_to_xml_conversion<T, int>;");
Daniel Jasper2ec3ffb82013-02-18 11:59:17 +00002464 verifyFormat("template <typename T>\n"
2465 "void f(int Paaaaaaaaaaaaaaaaaaaaaaaaaaaaaaram1,\n"
2466 " int Paaaaaaaaaaaaaaaaaaaaaaaaaaaaaaram2);");
Daniel Jasperac5c1c22013-01-02 15:08:56 +00002467 verifyFormat(
2468 "template <typename T>\n"
2469 "void looooooooooooooooooooongFunction(int Paaaaaaaaaaaaaaaaaaaaram1,\n"
2470 " int Paaaaaaaaaaaaaaaaaaaaram2);");
Daniel Jasper90e51fd2013-01-02 18:30:06 +00002471 verifyFormat(
2472 "template <typename T>\n"
2473 "aaaaaaaaaaaaaaaaaaa(aaaaaaaaaaaaaaaaaa,\n"
2474 " aaaaaaaaaaaaaaaaaaaaaaaaaa<T>::aaaaaaaaaa,\n"
2475 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa);");
Daniel Jasper89058942013-01-09 09:50:48 +00002476 verifyFormat("template <typename T>\n"
2477 "void aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa(\n"
Daniel Jaspera628c982013-04-03 13:36:17 +00002478 " int aaaaaaaaaaaaaaaaaaaaaa);");
Daniel Jasperbcab4302013-01-09 10:40:23 +00002479 verifyFormat(
2480 "template <typename T1, typename T2 = char, typename T3 = char,\n"
2481 " typename T4 = char>\n"
2482 "void f();");
Daniel Jasper7a31af12013-01-25 15:43:32 +00002483 verifyFormat(
2484 "aaaaaaaaaaaaaaaaaaaaaaaa<aaaaaaaaaaaaaaaaa, aaaaaaaaaaaaaaaaa>(\n"
2485 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa);");
Daniel Jasper3a9370c2013-02-04 07:21:18 +00002486
Daniel Jasper2ec3ffb82013-02-18 11:59:17 +00002487 verifyFormat("a<aaaaaaaaaaaaaaaaaaaaa, aaaaaaaaaaaaaaaaaaa>(\n"
2488 " a(aaaaaaaaaaaaaaaaaa, aaaaaaaaaaaaaaaa));");
Daniel Jasperac5c1c22013-01-02 15:08:56 +00002489}
2490
Daniel Jasper45797022013-01-25 10:57:27 +00002491TEST_F(FormatTest, WrapsAtNestedNameSpecifiers) {
2492 verifyFormat(
2493 "aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa::\n"
2494 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa();");
2495 verifyFormat(
2496 "aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa::\n"
2497 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa(\n"
2498 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa());");
2499
Daniel Jasper0f0234e2013-05-08 10:00:18 +00002500 // FIXME: Should we have the extra indent after the second break?
Daniel Jasper45797022013-01-25 10:57:27 +00002501 verifyFormat(
2502 "aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa::\n"
2503 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa::\n"
Daniel Jasper0f0234e2013-05-08 10:00:18 +00002504 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa();");
Daniel Jasper45797022013-01-25 10:57:27 +00002505
2506 // FIXME: Look into whether we should indent 4 from the start or 4 from
2507 // "bbbbb..." here instead of what we are doing now.
2508 verifyFormat(
2509 "aaaaaaaaaaaaaaa(bbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbb::\n"
Daniel Jasper4ad42352013-01-28 07:43:15 +00002510 " cccccccccccccccccccccccccccccccccccccccccccccc());");
Daniel Jasper45797022013-01-25 10:57:27 +00002511
2512 // Breaking at nested name specifiers is generally not desirable.
2513 verifyFormat(
2514 "aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa::aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa(\n"
2515 " aaaaaaaaaaaaaaaaaaaaaaa);");
Daniel Jasperca6623b2013-01-28 12:45:14 +00002516
2517 verifyFormat(
2518 "aaaaaaaaaaaaaaaaaa(aaaaaaaa, aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa::\n"
2519 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa,\n"
2520 " aaaaaaaaaaaaaaaaaaaaa);",
2521 getLLVMStyleWithColumns(74));
Daniel Jasperc238c872013-04-02 14:33:13 +00002522
2523 verifyFormat("aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa::\n"
2524 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\n"
2525 " .aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa();");
Daniel Jasper45797022013-01-25 10:57:27 +00002526}
2527
Daniel Jasperf7935112012-12-03 18:12:45 +00002528TEST_F(FormatTest, UnderstandsTemplateParameters) {
2529 verifyFormat("A<int> a;");
2530 verifyFormat("A<A<A<int> > > a;");
2531 verifyFormat("A<A<A<int, 2>, 3>, 4> a;");
2532 verifyFormat("bool x = a < 1 || 2 > a;");
2533 verifyFormat("bool x = 5 < f<int>();");
2534 verifyFormat("bool x = f<int>() > 5;");
2535 verifyFormat("bool x = 5 < a<int>::x;");
2536 verifyFormat("bool x = a < 4 ? a > 2 : false;");
2537 verifyFormat("bool x = f() ? a < 2 : a > 2;");
2538
2539 verifyGoogleFormat("A<A<int>> a;");
2540 verifyGoogleFormat("A<A<A<int>>> a;");
2541 verifyGoogleFormat("A<A<A<A<int>>>> a;");
Daniel Jasper7fce3ab2013-02-06 14:22:40 +00002542 verifyGoogleFormat("A<A<int> > a;");
2543 verifyGoogleFormat("A<A<A<int> > > a;");
2544 verifyGoogleFormat("A<A<A<A<int> > > > a;");
2545 EXPECT_EQ("A<A<A<A>>> a;", format("A<A<A<A> >> a;", getGoogleStyle()));
2546 EXPECT_EQ("A<A<A<A>>> a;", format("A<A<A<A>> > a;", getGoogleStyle()));
Daniel Jasperf7935112012-12-03 18:12:45 +00002547
2548 verifyFormat("test >> a >> b;");
2549 verifyFormat("test << a >> b;");
2550
2551 verifyFormat("f<int>();");
Manuel Klimeke7d10a12013-01-10 13:24:24 +00002552 verifyFormat("template <typename T> void f() {}");
Daniel Jasperf7935112012-12-03 18:12:45 +00002553}
2554
Daniel Jasperd8ffcfa2013-02-28 09:21:10 +00002555TEST_F(FormatTest, UnderstandsBinaryOperators) {
2556 verifyFormat("COMPARE(a, ==, b);");
Alexander Kornienko674be0a2013-03-20 16:41:56 +00002557}
2558
2559TEST_F(FormatTest, UnderstandsPointersToMembers) {
2560 verifyFormat("int A::*x;");
Daniel Jaspercfda5172013-05-08 14:58:20 +00002561 verifyFormat("int (S::*func)(void *);");
Daniel Jasper2f34cac2013-05-08 15:06:58 +00002562 verifyFormat("typedef bool *(Class::*Member)() const;");
Daniel Jaspercfda5172013-05-08 14:58:20 +00002563 verifyFormat("void f() {\n"
2564 " (a->*f)();\n"
2565 " a->*x;\n"
2566 " (a.*f)();\n"
2567 " ((*a).*f)();\n"
2568 " a.*x;\n"
2569 "}");
Daniel Jasper2f34cac2013-05-08 15:06:58 +00002570 FormatStyle Style = getLLVMStyle();
2571 Style.PointerBindsToType = true;
2572 verifyFormat("typedef bool* (Class::*Member)() const;", Style);
Daniel Jasperd8ffcfa2013-02-28 09:21:10 +00002573}
2574
Daniel Jasper8dd40472012-12-21 09:41:31 +00002575TEST_F(FormatTest, UnderstandsUnaryOperators) {
Daniel Jasperf7935112012-12-03 18:12:45 +00002576 verifyFormat("int a = -2;");
Daniel Jasper8b529712012-12-04 13:02:32 +00002577 verifyFormat("f(-1, -2, -3);");
2578 verifyFormat("a[-1] = 5;");
2579 verifyFormat("int a = 5 + -2;");
Manuel Klimeka4fe1c12013-01-21 16:42:44 +00002580 verifyFormat("if (i == -1) {\n}");
2581 verifyFormat("if (i != -1) {\n}");
2582 verifyFormat("if (i > -1) {\n}");
2583 verifyFormat("if (i < -1) {\n}");
Daniel Jasper26333c32012-12-06 13:16:39 +00002584 verifyFormat("++(a->f());");
2585 verifyFormat("--(a->f());");
Daniel Jasper13f23e12013-01-14 12:18:19 +00002586 verifyFormat("(a->f())++;");
2587 verifyFormat("a[42]++;");
Manuel Klimeka4fe1c12013-01-21 16:42:44 +00002588 verifyFormat("if (!(a->f())) {\n}");
Daniel Jasper8dd40472012-12-21 09:41:31 +00002589
2590 verifyFormat("a-- > b;");
2591 verifyFormat("b ? -a : c;");
2592 verifyFormat("n * sizeof char16;");
Daniel Jasper3c0431c2013-01-02 17:21:36 +00002593 verifyFormat("n * alignof char16;");
Daniel Jasper8dd40472012-12-21 09:41:31 +00002594 verifyFormat("sizeof(char);");
Daniel Jasper3c0431c2013-01-02 17:21:36 +00002595 verifyFormat("alignof(char);");
Daniel Jasperda1c68a2013-01-02 15:26:16 +00002596
2597 verifyFormat("return -1;");
2598 verifyFormat("switch (a) {\n"
2599 "case -1:\n"
2600 " break;\n"
2601 "}");
Daniel Jasper399d1ee2013-03-22 10:44:43 +00002602 verifyFormat("#define X -1");
2603 verifyFormat("#define X -kConstant");
Nico Weber63a54eb2013-01-12 05:41:23 +00002604
2605 verifyFormat("const NSPoint kBrowserFrameViewPatternOffset = { -5, +3 };");
2606 verifyFormat("const NSPoint kBrowserFrameViewPatternOffset = { +5, -3 };");
Daniel Jasper71945272013-01-15 14:27:39 +00002607
2608 verifyFormat("int a = /* confusing comment */ -1;");
2609 // FIXME: The space after 'i' is wrong, but hopefully, this is a rare case.
2610 verifyFormat("int a = i /* confusing comment */++;");
Daniel Jasperf7935112012-12-03 18:12:45 +00002611}
2612
2613TEST_F(FormatTest, UndestandsOverloadedOperators) {
Daniel Jasper537a2962012-12-24 10:56:04 +00002614 verifyFormat("bool operator<();");
2615 verifyFormat("bool operator>();");
2616 verifyFormat("bool operator=();");
2617 verifyFormat("bool operator==();");
2618 verifyFormat("bool operator!=();");
2619 verifyFormat("int operator+();");
2620 verifyFormat("int operator++();");
2621 verifyFormat("bool operator();");
2622 verifyFormat("bool operator()();");
2623 verifyFormat("bool operator[]();");
2624 verifyFormat("operator bool();");
Daniel Jasper35d2dc72013-02-11 08:01:18 +00002625 verifyFormat("operator int();");
2626 verifyFormat("operator void *();");
Daniel Jasper537a2962012-12-24 10:56:04 +00002627 verifyFormat("operator SomeType<int>();");
Daniel Jasper35d2dc72013-02-11 08:01:18 +00002628 verifyFormat("operator SomeType<int, int>();");
2629 verifyFormat("operator SomeType<SomeType<int> >();");
Daniel Jasper537a2962012-12-24 10:56:04 +00002630 verifyFormat("void *operator new(std::size_t size);");
2631 verifyFormat("void *operator new[](std::size_t size);");
2632 verifyFormat("void operator delete(void *ptr);");
2633 verifyFormat("void operator delete[](void *ptr);");
Daniel Jasper8f9624b2013-05-10 07:59:58 +00002634 verifyFormat("template <typename AAAAAAA, typename BBBBBBB>\n"
2635 "AAAAAAA operator/(const AAAAAAA &a, BBBBBBB &b);");
Daniel Jasper35d2dc72013-02-11 08:01:18 +00002636
Daniel Jasper0af92eb2013-02-15 19:24:08 +00002637 verifyFormat(
2638 "ostream &operator<<(ostream &OutputStream,\n"
2639 " SomeReallyLongType WithSomeReallyLongValue);");
Daniel Jasper54ac8202013-04-05 17:21:59 +00002640 verifyFormat("bool operator<(const aaaaaaaaaaaaaaaaaaaaa &left,\n"
2641 " const aaaaaaaaaaaaaaaaaaaaa &right) {\n"
2642 " return left.group < right.group;\n"
2643 "}");
Daniel Jasper6e8f4ed2013-04-11 08:48:20 +00002644 verifyFormat("SomeType &operator=(const SomeType &S);");
Daniel Jasper0af92eb2013-02-15 19:24:08 +00002645
Daniel Jasper35d2dc72013-02-11 08:01:18 +00002646 verifyGoogleFormat("operator void*();");
2647 verifyGoogleFormat("operator SomeType<SomeType<int>>();");
Daniel Jasperf7935112012-12-03 18:12:45 +00002648}
2649
Daniel Jasperd6a947f2013-01-11 16:09:04 +00002650TEST_F(FormatTest, UnderstandsNewAndDelete) {
Daniel Jasperba0bda92013-02-23 08:07:18 +00002651 verifyFormat("void f() {\n"
2652 " A *a = new A;\n"
2653 " A *a = new (placement) A;\n"
2654 " delete a;\n"
2655 " delete (A *)a;\n"
2656 "}");
Daniel Jasperd6a947f2013-01-11 16:09:04 +00002657}
2658
Daniel Jasper22bcf8a2013-01-02 08:57:10 +00002659TEST_F(FormatTest, UnderstandsUsesOfStarAndAmp) {
Manuel Klimeke7d10a12013-01-10 13:24:24 +00002660 verifyFormat("int *f(int *a) {}");
Manuel Klimeke7d10a12013-01-10 13:24:24 +00002661 verifyFormat("int main(int argc, char **argv) {}");
Daniel Jasper5065bc42013-02-18 12:44:35 +00002662 verifyFormat("Test::Test(int b) : a(b * b) {}");
Daniel Jasper5b49f472013-01-23 12:10:53 +00002663 verifyIndependentOfContext("f(a, *a);");
Daniel Jasper8eb371b2013-03-01 17:13:29 +00002664 verifyFormat("void g() { f(*a); }");
Daniel Jasper5b49f472013-01-23 12:10:53 +00002665 verifyIndependentOfContext("int a = b * 10;");
2666 verifyIndependentOfContext("int a = 10 * b;");
2667 verifyIndependentOfContext("int a = b * c;");
2668 verifyIndependentOfContext("int a += b * c;");
2669 verifyIndependentOfContext("int a -= b * c;");
2670 verifyIndependentOfContext("int a *= b * c;");
2671 verifyIndependentOfContext("int a /= b * c;");
2672 verifyIndependentOfContext("int a = *b;");
2673 verifyIndependentOfContext("int a = *b * c;");
2674 verifyIndependentOfContext("int a = b * *c;");
2675 verifyIndependentOfContext("return 10 * b;");
2676 verifyIndependentOfContext("return *b * *c;");
2677 verifyIndependentOfContext("return a & ~b;");
2678 verifyIndependentOfContext("f(b ? *c : *d);");
2679 verifyIndependentOfContext("int a = b ? *c : *d;");
2680 verifyIndependentOfContext("*b = a;");
2681 verifyIndependentOfContext("a * ~b;");
2682 verifyIndependentOfContext("a * !b;");
2683 verifyIndependentOfContext("a * +b;");
2684 verifyIndependentOfContext("a * -b;");
2685 verifyIndependentOfContext("a * ++b;");
2686 verifyIndependentOfContext("a * --b;");
2687 verifyIndependentOfContext("a[4] * b;");
Daniel Jasper8e559272013-02-27 11:43:50 +00002688 verifyIndependentOfContext("a[a * a] = 1;");
Daniel Jasper5b49f472013-01-23 12:10:53 +00002689 verifyIndependentOfContext("f() * b;");
2690 verifyIndependentOfContext("a * [self dostuff];");
Daniel Jasper6e42b1e2013-04-01 17:13:26 +00002691 verifyIndependentOfContext("int x = a * (a + b);");
Daniel Jasper5b49f472013-01-23 12:10:53 +00002692 verifyIndependentOfContext("(a *)(a + b);");
2693 verifyIndependentOfContext("int *pa = (int *)&a;");
Nico Weber44449172013-02-12 16:17:07 +00002694 verifyIndependentOfContext("return sizeof(int **);");
2695 verifyIndependentOfContext("return sizeof(int ******);");
2696 verifyIndependentOfContext("return (int **&)a;");
Daniel Jasper8eb371b2013-03-01 17:13:29 +00002697 verifyFormat("void f(Type (*parameter)[10]) {}");
Nico Weber44449172013-02-12 16:17:07 +00002698 verifyGoogleFormat("return sizeof(int**);");
2699 verifyIndependentOfContext("Type **A = static_cast<Type **>(P);");
2700 verifyGoogleFormat("Type** A = static_cast<Type**>(P);");
2701 // FIXME: The newline is wrong.
2702 verifyFormat("auto a = [](int **&, int ***) {}\n;");
Daniel Jasper27234032012-12-07 09:52:15 +00002703
Daniel Jasper5b49f472013-01-23 12:10:53 +00002704 verifyIndependentOfContext("InvalidRegions[*R] = 0;");
Daniel Jasper3c2557d2013-01-04 20:46:38 +00002705
Daniel Jasper5b49f472013-01-23 12:10:53 +00002706 verifyIndependentOfContext("A<int *> a;");
2707 verifyIndependentOfContext("A<int **> a;");
2708 verifyIndependentOfContext("A<int *, int *> a;");
Daniel Jasperc697ad22013-02-06 10:05:46 +00002709 verifyIndependentOfContext(
2710 "const char *const p = reinterpret_cast<const char *const>(q);");
Daniel Jasper5b49f472013-01-23 12:10:53 +00002711 verifyIndependentOfContext("A<int **, int **> a;");
Daniel Jasper8035b0a2013-02-06 10:57:42 +00002712 verifyIndependentOfContext("void f(int *a = d * e, int *b = c * d);");
Daniel Jasperae907642013-03-14 10:50:25 +00002713 verifyFormat("for (char **a = b; *a; ++a) {\n}");
Daniel Jasperc37de302013-05-03 14:41:24 +00002714 verifyFormat("for (; a && b;) {\n}");
Daniel Jaspera4396862012-12-10 18:59:13 +00002715
Daniel Jasper66dcb1c2013-01-08 20:03:18 +00002716 verifyFormat(
2717 "aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa(\n"
2718 " aaaaaaaaaaaaaaaaaaaaaaaaaaaa, *aaaaaaaaaaaaaaaaaaaaaaaaaaaaa);");
2719
Manuel Klimeke7d10a12013-01-10 13:24:24 +00002720 verifyGoogleFormat("int main(int argc, char** argv) {}");
Daniel Jaspera4396862012-12-10 18:59:13 +00002721 verifyGoogleFormat("A<int*> a;");
2722 verifyGoogleFormat("A<int**> a;");
2723 verifyGoogleFormat("A<int*, int*> a;");
2724 verifyGoogleFormat("A<int**, int**> a;");
Daniel Jasper22bcf8a2013-01-02 08:57:10 +00002725 verifyGoogleFormat("f(b ? *c : *d);");
2726 verifyGoogleFormat("int a = b ? *c : *d;");
Daniel Jaspera1dc93a2013-01-16 16:04:06 +00002727 verifyGoogleFormat("Type* t = **x;");
2728 verifyGoogleFormat("Type* t = *++*x;");
2729 verifyGoogleFormat("*++*x;");
2730 verifyGoogleFormat("Type* t = const_cast<T*>(&*x);");
2731 verifyGoogleFormat("Type* t = x++ * y;");
Daniel Jasperc697ad22013-02-06 10:05:46 +00002732 verifyGoogleFormat(
2733 "const char* const p = reinterpret_cast<const char* const>(q);");
Manuel Klimek557811f2013-01-14 10:58:01 +00002734
Daniel Jasper5b49f472013-01-23 12:10:53 +00002735 verifyIndependentOfContext("a = *(x + y);");
2736 verifyIndependentOfContext("a = &(x + y);");
2737 verifyIndependentOfContext("*(x + y).call();");
2738 verifyIndependentOfContext("&(x + y)->call();");
Daniel Jasper8eb371b2013-03-01 17:13:29 +00002739 verifyFormat("void f() { &(*I).first; }");
Daniel Jasper71945272013-01-15 14:27:39 +00002740
Daniel Jasper5b49f472013-01-23 12:10:53 +00002741 verifyIndependentOfContext("f(b * /* confusing comment */ ++c);");
Daniel Jasper71945272013-01-15 14:27:39 +00002742 verifyFormat(
2743 "int *MyValues = {\n"
2744 " *A, // Operator detection might be confused by the '{'\n"
2745 " *BB // Operator detection might be confused by previous comment\n"
2746 "};");
Nico Weber80a82762013-01-17 17:17:19 +00002747
Daniel Jasper5b49f472013-01-23 12:10:53 +00002748 verifyIndependentOfContext("if (int *a = &b)");
2749 verifyIndependentOfContext("if (int &a = *b)");
2750 verifyIndependentOfContext("if (a & b[i])");
2751 verifyIndependentOfContext("if (a::b::c::d & b[i])");
2752 verifyIndependentOfContext("if (*b[i])");
2753 verifyIndependentOfContext("if (int *a = (&b))");
2754 verifyIndependentOfContext("while (int *a = &b)");
Daniel Jasper420d7d32013-01-23 12:58:14 +00002755 verifyFormat("void f() {\n"
2756 " for (const int &v : Values) {\n"
2757 " }\n"
2758 "}");
Daniel Jasper5065bc42013-02-18 12:44:35 +00002759 verifyFormat("for (int i = a * a; i < 10; ++i) {\n}");
2760 verifyFormat("for (int i = 0; i < a * a; ++i) {\n}");
Daniel Jasper0b820602013-01-22 11:46:26 +00002761
Daniel Jasperb910bbb2013-05-13 07:14:40 +00002762 verifyFormat("#define MACRO \\\n"
2763 " int *i = a * b; \\\n"
2764 " void f(a *b);",
2765 getLLVMStyleWithColumns(19));
2766
Daniel Jasper97b89482013-03-13 07:49:51 +00002767 verifyIndependentOfContext("A = new SomeType *[Length];");
Daniel Jasper5b49f472013-01-23 12:10:53 +00002768 verifyIndependentOfContext("A = new SomeType *[Length]();");
Daniel Jasper0b820602013-01-22 11:46:26 +00002769 verifyGoogleFormat("A = new SomeType* [Length]();");
Daniel Jasper97b89482013-03-13 07:49:51 +00002770 verifyGoogleFormat("A = new SomeType* [Length];");
Daniel Jasperb910bbb2013-05-13 07:14:40 +00002771
Daniel Jasper990ff972013-05-07 14:17:18 +00002772 FormatStyle PointerLeft = getLLVMStyle();
2773 PointerLeft.PointerBindsToType = true;
2774 verifyFormat("delete *x;", PointerLeft);
Daniel Jasper8eb371b2013-03-01 17:13:29 +00002775}
Daniel Jasper7fce3ab2013-02-06 14:22:40 +00002776
Daniel Jasper10cd5812013-05-06 06:35:44 +00002777TEST_F(FormatTest, UnderstandsEllipsis) {
2778 verifyFormat("int printf(const char *fmt, ...);");
2779 verifyFormat("template <class... Ts> void Foo(Ts... ts) { Foo(ts...); }");
2780}
2781
Daniel Jasper8eb371b2013-03-01 17:13:29 +00002782TEST_F(FormatTest, AdaptivelyFormatsPointersAndReferences) {
Daniel Jasper7fce3ab2013-02-06 14:22:40 +00002783 EXPECT_EQ("int *a;\n"
2784 "int *a;\n"
Daniel Jasper2ec3ffb82013-02-18 11:59:17 +00002785 "int *a;",
2786 format("int *a;\n"
2787 "int* a;\n"
2788 "int *a;",
2789 getGoogleStyle()));
Daniel Jasper7fce3ab2013-02-06 14:22:40 +00002790 EXPECT_EQ("int* a;\n"
2791 "int* a;\n"
Daniel Jasper2ec3ffb82013-02-18 11:59:17 +00002792 "int* a;",
2793 format("int* a;\n"
2794 "int* a;\n"
2795 "int *a;",
2796 getGoogleStyle()));
Daniel Jasper7fce3ab2013-02-06 14:22:40 +00002797 EXPECT_EQ("int *a;\n"
2798 "int *a;\n"
Daniel Jasper2ec3ffb82013-02-18 11:59:17 +00002799 "int *a;",
2800 format("int *a;\n"
2801 "int * a;\n"
2802 "int * a;",
2803 getGoogleStyle()));
Daniel Jasperf7935112012-12-03 18:12:45 +00002804}
2805
Alexander Kornienkoa5151272013-03-12 16:28:18 +00002806TEST_F(FormatTest, UnderstandsRvalueReferences) {
2807 verifyFormat("int f(int &&a) {}");
2808 verifyFormat("int f(int a, char &&b) {}");
2809 verifyFormat("void f() { int &&a = b; }");
2810 verifyGoogleFormat("int f(int a, char&& b) {}");
2811 verifyGoogleFormat("void f() { int&& a = b; }");
2812
2813 // FIXME: These require somewhat deeper changes in template arguments
2814 // formatting.
2815 // verifyIndependentOfContext("A<int &&> a;");
2816 // verifyIndependentOfContext("A<int &&, int &&> a;");
2817 // verifyGoogleFormat("A<int&&> a;");
2818 // verifyGoogleFormat("A<int&&, int&&> a;");
2819}
2820
Manuel Klimekc1237a82013-01-23 14:08:21 +00002821TEST_F(FormatTest, FormatsBinaryOperatorsPrecedingEquals) {
2822 verifyFormat("void f() {\n"
2823 " x[aaaaaaaaa -\n"
Daniel Jasper6bee6822013-04-08 20:33:42 +00002824 " b] = 23;\n"
Daniel Jasper2ec3ffb82013-02-18 11:59:17 +00002825 "}",
2826 getLLVMStyleWithColumns(15));
Manuel Klimekc1237a82013-01-23 14:08:21 +00002827}
2828
Daniel Jasperef906a92013-01-13 08:01:36 +00002829TEST_F(FormatTest, FormatsCasts) {
2830 verifyFormat("Type *A = static_cast<Type *>(P);");
2831 verifyFormat("Type *A = (Type *)P;");
2832 verifyFormat("Type *A = (vector<Type *, int *>)P;");
2833 verifyFormat("int a = (int)(2.0f);");
2834
2835 // FIXME: These also need to be identified.
2836 verifyFormat("int a = (int) 2.0f;");
2837 verifyFormat("int a = (int) * b;");
2838
2839 // These are not casts.
2840 verifyFormat("void f(int *) {}");
Nico Weber4401b2a2013-02-13 04:32:57 +00002841 verifyFormat("f(foo)->b;");
2842 verifyFormat("f(foo).b;");
2843 verifyFormat("f(foo)(b);");
2844 verifyFormat("f(foo)[b];");
2845 verifyFormat("[](foo) { return 4; }(bar)];");
2846 verifyFormat("(*funptr)(foo)[4];");
2847 verifyFormat("funptrs[4](foo)[4];");
Daniel Jasperef906a92013-01-13 08:01:36 +00002848 verifyFormat("void f(int *);");
2849 verifyFormat("void f(int *) = 0;");
2850 verifyFormat("void f(SmallVector<int>) {}");
2851 verifyFormat("void f(SmallVector<int>);");
2852 verifyFormat("void f(SmallVector<int>) = 0;");
Nico Weber06fcec12013-02-09 18:02:07 +00002853 verifyFormat("void f(int i = (kValue) * kMask) {}");
2854 verifyFormat("void f(int i = (kA * kB) & kMask) {}");
Nico Weber4401b2a2013-02-13 04:32:57 +00002855 verifyFormat("int a = sizeof(int) * b;");
2856 verifyFormat("int a = alignof(int) * b;");
Daniel Jasper2cf17bf2013-02-27 09:47:53 +00002857
Daniel Jasperba0bda92013-02-23 08:07:18 +00002858 // These are not casts, but at some point were confused with casts.
2859 verifyFormat("virtual void foo(int *) override;");
2860 verifyFormat("virtual void foo(char &) const;");
2861 verifyFormat("virtual void foo(int *a, char *) const;");
Daniel Jasper8a68b952013-03-13 17:13:53 +00002862 verifyFormat("int a = sizeof(int *) + b;");
2863 verifyFormat("int a = alignof(int *) + b;");
Daniel Jasperef906a92013-01-13 08:01:36 +00002864}
2865
Daniel Jasperc1fa2812013-01-10 13:08:12 +00002866TEST_F(FormatTest, FormatsFunctionTypes) {
Daniel Jasperc1fa2812013-01-10 13:08:12 +00002867 verifyFormat("A<bool()> a;");
2868 verifyFormat("A<SomeType()> a;");
2869 verifyFormat("A<void(*)(int, std::string)> a;");
Daniel Jasperb8914dd2013-03-20 09:53:18 +00002870 verifyFormat("A<void *(int)>;");
Daniel Jasper6e42b1e2013-04-01 17:13:26 +00002871 verifyFormat("void *(*a)(int *, SomeType *);");
Daniel Jasperc1fa2812013-01-10 13:08:12 +00002872
Daniel Jasper8eb371b2013-03-01 17:13:29 +00002873 // FIXME: Inconsistent.
2874 verifyFormat("int (*func)(void *);");
2875 verifyFormat("void f() { int(*func)(void *); }");
Daniel Jasperb8914dd2013-03-20 09:53:18 +00002876
Daniel Jasper6e42b1e2013-04-01 17:13:26 +00002877 verifyGoogleFormat("A<void*(int*, SomeType*)>;");
2878 verifyGoogleFormat("void* (*a)(int);");
Daniel Jasperabc34212013-05-14 08:34:47 +00002879
Daniel Jasper5dad58e2013-05-15 07:51:51 +00002880 // Other constructs can look somewhat like function types:
Daniel Jasperabc34212013-05-14 08:34:47 +00002881 verifyFormat("A<sizeof(*x)> a;");
Daniel Jasper5dad58e2013-05-15 07:51:51 +00002882 verifyFormat("#define DEREF_AND_CALL_F(x) f(*x)");
Daniel Jasperc1fa2812013-01-10 13:08:12 +00002883}
2884
Daniel Jasper26d1b1d2013-02-24 18:54:32 +00002885TEST_F(FormatTest, BreaksLongDeclarations) {
Daniel Jasper8e357692013-05-06 08:27:33 +00002886 verifyFormat("typedef LoooooooooooooooooooooooooooooooooooooooongType\n"
2887 " AnotherNameForTheLongType;");
2888 verifyFormat("LoooooooooooooooooooooooooooooooooooooooongType\n"
2889 " LoooooooooooooooooooooooooooooooooooooooongVariable;");
2890 verifyFormat("LoooooooooooooooooooooooooooooooooooooooongReturnType\n"
2891 " LoooooooooooooooooooooooooooooooongFunctionDeclaration();");
2892 verifyFormat("LoooooooooooooooooooooooooooooooooooooooongReturnType\n"
2893 "LooooooooooooooooooooooooooooooooooongFunctionDefinition() {}");
2894
2895 // FIXME: Without the comment, this breaks after "(".
2896 verifyFormat("LoooooooooooooooooooooooooooooooooooooooongType // break\n"
2897 " (*LoooooooooooooooooooooooooooongFunctionTypeVarialbe)();");
2898
Daniel Jasperd2639ef2013-01-28 15:16:31 +00002899 verifyFormat("int *someFunction(int LoooooooooooooooooooongParam1,\n"
Daniel Jasper12ef4e52013-02-21 21:33:55 +00002900 " int LoooooooooooooooooooongParam2) {}");
Daniel Jasperd1926a32013-01-02 08:44:14 +00002901 verifyFormat(
Daniel Jasper6728fc12013-04-11 14:29:13 +00002902 "TypeSpecDecl *TypeSpecDecl::Create(ASTContext &C, DeclContext *DC,\n"
2903 " SourceLocation L, IdentifierIn *II,\n"
2904 " Type *T) {}");
Daniel Jasper26d1b1d2013-02-24 18:54:32 +00002905 verifyFormat("ReallyLongReturnType<TemplateParam1, TemplateParam2>\n"
2906 "ReallyReallyLongFunctionName(\n"
2907 " const std::string &SomeParameter,\n"
2908 " const SomeType<string, SomeOtherTemplateParameter> &\n"
2909 " ReallyReallyLongParameterName,\n"
2910 " const SomeType<string, SomeOtherTemplateParameter> &\n"
2911 " AnotherLongParameterName) {}");
Daniel Jasperc6fbc212013-05-15 09:35:08 +00002912 verifyFormat("template <typename A>\n"
2913 "SomeLoooooooooooooooooooooongType<\n"
2914 " typename some_namespace::SomeOtherType<A>::Type>\n"
2915 "Function() {}");
Daniel Jasper26d1b1d2013-02-24 18:54:32 +00002916 verifyFormat(
2917 "aaaaaaaaaaaaaaaa::aaaaaaaaaaaaaaaa<aaaaaaaaaaaaa, aaaaaaaaaaaa>\n"
Daniel Jasper8e357692013-05-06 08:27:33 +00002918 " aaaaaaaaaaaaaaaaaaaaaaa;");
Daniel Jasper26d1b1d2013-02-24 18:54:32 +00002919
Daniel Jasperd36ef5e2013-01-28 15:40:20 +00002920 verifyGoogleFormat(
Daniel Jasper2cf17bf2013-02-27 09:47:53 +00002921 "TypeSpecDecl* TypeSpecDecl::Create(ASTContext& C, DeclContext* DC,\n"
2922 " SourceLocation L) {}");
Daniel Jasperb9caeac2013-02-13 20:33:44 +00002923 verifyGoogleFormat(
2924 "some_namespace::LongReturnType\n"
2925 "long_namespace::SomeVeryLongClass::SomeVeryLongFunction(\n"
Daniel Jasper12ef4e52013-02-21 21:33:55 +00002926 " int first_long_parameter, int second_parameter) {}");
Daniel Jasperb9caeac2013-02-13 20:33:44 +00002927
2928 verifyGoogleFormat("template <typename T>\n"
2929 "aaaaaaaa::aaaaa::aaaaaa<T, aaaaaaaaaaaaaaaaaaaaaaaaa>\n"
Daniel Jasper12ef4e52013-02-21 21:33:55 +00002930 "aaaaaaaaaaaaaaaaaaaaaaaa<T>::aaaaaaa() {}");
Daniel Jasper57d4a582013-02-28 10:06:05 +00002931 verifyGoogleFormat("A<A<A>> aaaaaaaaaa(int aaaaaaaaaaaaaaaaaaaaaaaaaaa,\n"
2932 " int aaaaaaaaaaaaaaaaaaaaaaa);");
Daniel Jasperd1926a32013-01-02 08:44:14 +00002933}
2934
Daniel Jaspere9de2602012-12-06 09:56:08 +00002935TEST_F(FormatTest, LineStartsWithSpecialCharacter) {
2936 verifyFormat("(a)->b();");
2937 verifyFormat("--a;");
2938}
2939
Daniel Jasper8b529712012-12-04 13:02:32 +00002940TEST_F(FormatTest, HandlesIncludeDirectives) {
Daniel Jasper2ab0d012013-01-14 15:52:06 +00002941 verifyFormat("#include <string>\n"
2942 "#include <a/b/c.h>\n"
2943 "#include \"a/b/string\"\n"
2944 "#include \"string.h\"\n"
2945 "#include \"string.h\"\n"
Manuel Klimek99c7baa2013-01-15 15:50:27 +00002946 "#include <a-a>\n"
Daniel Jasperaf5ba0e2013-02-23 07:46:38 +00002947 "#include < path with space >\n"
Daniel Jasper4a4be012013-05-06 10:24:51 +00002948 "#include \"abc.h\" // this is included for ABC\n"
Daniel Jasper8bb99e82013-05-16 12:59:13 +00002949 "#include \"some long include\" // with a comment\n"
Daniel Jasperaf5ba0e2013-02-23 07:46:38 +00002950 "#include \"some very long include paaaaaaaaaaaaaaaaaaaaaaath\"",
2951 getLLVMStyleWithColumns(35));
Nico Weber8f83ee42012-12-21 18:21:56 +00002952
Daniel Jasper5ef433f2013-01-13 08:12:18 +00002953 verifyFormat("#import <string>");
2954 verifyFormat("#import <a/b/c.h>");
2955 verifyFormat("#import \"a/b/string\"");
2956 verifyFormat("#import \"string.h\"");
2957 verifyFormat("#import \"string.h\"");
Daniel Jasper8b529712012-12-04 13:02:32 +00002958}
2959
Alexander Kornienko578fdd82012-12-06 18:03:27 +00002960//===----------------------------------------------------------------------===//
2961// Error recovery tests.
2962//===----------------------------------------------------------------------===//
2963
Daniel Jasper66e9dee2013-02-14 09:19:04 +00002964TEST_F(FormatTest, IncompleteParameterLists) {
Daniel Jasper2cf17bf2013-02-27 09:47:53 +00002965 FormatStyle NoBinPacking = getLLVMStyle();
2966 NoBinPacking.BinPackParameters = false;
2967 verifyFormat("void aaaaaaaaaaaaaaaaaa(int level,\n"
2968 " double *min_x,\n"
2969 " double *max_x,\n"
2970 " double *min_y,\n"
2971 " double *max_y,\n"
2972 " double *min_z,\n"
2973 " double *max_z, ) {}",
2974 NoBinPacking);
Daniel Jasper66e9dee2013-02-14 09:19:04 +00002975}
2976
Daniel Jasper83a54d22013-01-10 09:26:47 +00002977TEST_F(FormatTest, IncorrectCodeTrailingStuff) {
Alexander Kornienkoae6e53c2013-01-16 11:45:16 +00002978 verifyFormat("void f() { return; }\n42");
2979 verifyFormat("void f() {\n"
2980 " if (0)\n"
2981 " return;\n"
2982 "}\n"
2983 "42");
Alexander Kornienko1231e062013-01-16 11:43:46 +00002984 verifyFormat("void f() { return }\n42");
2985 verifyFormat("void f() {\n"
2986 " if (0)\n"
2987 " return\n"
2988 "}\n"
2989 "42");
2990}
2991
2992TEST_F(FormatTest, IncorrectCodeMissingSemicolon) {
2993 EXPECT_EQ("void f() { return }", format("void f ( ) { return }"));
2994 EXPECT_EQ("void f() {\n"
2995 " if (a)\n"
2996 " return\n"
Daniel Jasper2ec3ffb82013-02-18 11:59:17 +00002997 "}",
2998 format("void f ( ) { if ( a ) return }"));
Daniel Jasperabca58c2013-05-15 14:09:55 +00002999 EXPECT_EQ("namespace N {\n"
3000 "void f()\n"
3001 "}",
3002 format("namespace N { void f() }"));
Alexander Kornienko1231e062013-01-16 11:43:46 +00003003 EXPECT_EQ("namespace N {\n"
3004 "void f() {}\n"
3005 "void g()\n"
Daniel Jasper2ec3ffb82013-02-18 11:59:17 +00003006 "}",
3007 format("namespace N { void f( ) { } void g( ) }"));
Daniel Jasper83a54d22013-01-10 09:26:47 +00003008}
3009
Daniel Jasper2df93312013-01-09 10:16:05 +00003010TEST_F(FormatTest, IndentationWithinColumnLimitNotPossible) {
3011 verifyFormat("int aaaaaaaa =\n"
Alexander Kornienkoffd6d042013-03-27 11:52:18 +00003012 " // Overlylongcomment\n"
Daniel Jasper2ec3ffb82013-02-18 11:59:17 +00003013 " b;",
3014 getLLVMStyleWithColumns(20));
Daniel Jasper2df93312013-01-09 10:16:05 +00003015 verifyFormat("function(\n"
3016 " ShortArgument,\n"
Daniel Jasper2ec3ffb82013-02-18 11:59:17 +00003017 " LoooooooooooongArgument);\n",
3018 getLLVMStyleWithColumns(20));
Daniel Jasper2df93312013-01-09 10:16:05 +00003019}
3020
Alexander Kornienko2ca766f2012-12-10 16:34:48 +00003021TEST_F(FormatTest, IncorrectAccessSpecifier) {
3022 verifyFormat("public:");
3023 verifyFormat("class A {\n"
3024 "public\n"
Manuel Klimeke7d10a12013-01-10 13:24:24 +00003025 " void f() {}\n"
Alexander Kornienko2ca766f2012-12-10 16:34:48 +00003026 "};");
3027 verifyFormat("public\n"
3028 "int qwerty;");
3029 verifyFormat("public\n"
Manuel Klimeke7d10a12013-01-10 13:24:24 +00003030 "B {}");
Alexander Kornienko2ca766f2012-12-10 16:34:48 +00003031 verifyFormat("public\n"
Manuel Klimeke7d10a12013-01-10 13:24:24 +00003032 "{}");
Alexander Kornienko2ca766f2012-12-10 16:34:48 +00003033 verifyFormat("public\n"
Manuel Klimekf4ab9ef2013-01-11 17:54:10 +00003034 "B { int x; }");
Alexander Kornienko2ca766f2012-12-10 16:34:48 +00003035}
Daniel Jasperf7935112012-12-03 18:12:45 +00003036
Daniel Jasper291f9362013-03-20 15:58:10 +00003037TEST_F(FormatTest, IncorrectCodeUnbalancedBraces) {
3038 verifyFormat("{");
3039 verifyFormat("#})");
3040}
Alexander Kornienko0ea8e102012-12-04 15:40:36 +00003041
3042TEST_F(FormatTest, IncorrectCodeDoNoWhile) {
Manuel Klimeka4fe1c12013-01-21 16:42:44 +00003043 verifyFormat("do {\n}");
3044 verifyFormat("do {\n}\n"
Alexander Kornienko0ea8e102012-12-04 15:40:36 +00003045 "f();");
Manuel Klimeka4fe1c12013-01-21 16:42:44 +00003046 verifyFormat("do {\n}\n"
Alexander Kornienko0ea8e102012-12-04 15:40:36 +00003047 "wheeee(fun);");
3048 verifyFormat("do {\n"
3049 " f();\n"
Manuel Klimek28cacc72013-01-07 18:10:23 +00003050 "}");
Alexander Kornienko0ea8e102012-12-04 15:40:36 +00003051}
3052
Manuel Klimek9fa8d552013-01-11 19:23:05 +00003053TEST_F(FormatTest, IncorrectCodeMissingParens) {
Manuel Klimekadededf2013-01-11 18:28:36 +00003054 verifyFormat("if {\n foo;\n foo();\n}");
Manuel Klimek9fa8d552013-01-11 19:23:05 +00003055 verifyFormat("switch {\n foo;\n foo();\n}");
3056 verifyFormat("for {\n foo;\n foo();\n}");
3057 verifyFormat("while {\n foo;\n foo();\n}");
3058 verifyFormat("do {\n foo;\n foo();\n} while;");
Manuel Klimekadededf2013-01-11 18:28:36 +00003059}
3060
Daniel Jasperc0880a92013-01-04 18:52:56 +00003061TEST_F(FormatTest, DoesNotTouchUnwrappedLinesWithErrors) {
3062 verifyFormat("namespace {\n"
Manuel Klimek1abf7892013-01-04 23:34:14 +00003063 "class Foo { Foo ( }; } // comment");
Daniel Jasperc0880a92013-01-04 18:52:56 +00003064}
3065
Alexander Kornienko870f9eb2012-12-04 17:27:50 +00003066TEST_F(FormatTest, IncorrectCodeErrorDetection) {
Manuel Klimeke7d10a12013-01-10 13:24:24 +00003067 EXPECT_EQ("{\n{}\n", format("{\n{\n}\n"));
3068 EXPECT_EQ("{\n {}\n", format("{\n {\n}\n"));
3069 EXPECT_EQ("{\n {}\n", format("{\n {\n }\n"));
3070 EXPECT_EQ("{\n {}\n }\n}\n", format("{\n {\n }\n }\n}\n"));
Alexander Kornienko870f9eb2012-12-04 17:27:50 +00003071
Alexander Kornienko870f9eb2012-12-04 17:27:50 +00003072 EXPECT_EQ("{\n"
3073 " {\n"
3074 " breakme(\n"
3075 " qwe);\n"
Daniel Jasper2ec3ffb82013-02-18 11:59:17 +00003076 "}\n",
3077 format("{\n"
3078 " {\n"
3079 " breakme(qwe);\n"
3080 "}\n",
3081 getLLVMStyleWithColumns(10)));
Alexander Kornienko870f9eb2012-12-04 17:27:50 +00003082}
3083
Manuel Klimek73a2fdf2013-01-10 14:36:46 +00003084TEST_F(FormatTest, LayoutCallsInsideBraceInitializers) {
Daniel Jasper2ec3ffb82013-02-18 11:59:17 +00003085 verifyFormat("int x = {\n"
3086 " avariable,\n"
3087 " b(alongervariable)\n"
3088 "};",
3089 getLLVMStyleWithColumns(25));
Manuel Klimek73a2fdf2013-01-10 14:36:46 +00003090}
3091
Manuel Klimek762dd182013-01-21 10:07:49 +00003092TEST_F(FormatTest, LayoutBraceInitializersInReturnStatement) {
3093 verifyFormat("return (a)(b) { 1, 2, 3 };");
3094}
3095
Manuel Klimek73a2fdf2013-01-10 14:36:46 +00003096TEST_F(FormatTest, LayoutTokensFollowingBlockInParentheses) {
Daniel Jasper37905f72013-02-21 15:00:29 +00003097 // FIXME: This is bad, find a better and more generic solution.
Manuel Klimek73a2fdf2013-01-10 14:36:46 +00003098 verifyFormat(
3099 "Aaa({\n"
3100 " int i;\n"
Daniel Jasper37905f72013-02-21 15:00:29 +00003101 "},\n"
3102 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa(bbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbb,\n"
3103 " ccccccccccccccccc));");
Manuel Klimek73a2fdf2013-01-10 14:36:46 +00003104}
3105
Manuel Klimekf4ab9ef2013-01-11 17:54:10 +00003106TEST_F(FormatTest, PullTrivialFunctionDefinitionsIntoSingleLine) {
3107 verifyFormat("void f() { return 42; }");
3108 verifyFormat("void f() {\n"
3109 " // Comment\n"
3110 "}");
3111 verifyFormat("{\n"
3112 "#error {\n"
3113 " int a;\n"
3114 "}");
3115 verifyFormat("{\n"
3116 " int a;\n"
3117 "#error {\n"
3118 "}");
Daniel Jasperf9eb9b12013-05-16 10:17:39 +00003119 verifyFormat("void f() {} // comment");
3120 verifyFormat("void f() { int a; } // comment");
Daniel Jasper92716502013-05-16 16:54:34 +00003121 verifyFormat("void f() {\n"
3122 "} // comment",
3123 getLLVMStyleWithColumns(15));
Manuel Klimeka4fe1c12013-01-21 16:42:44 +00003124
3125 verifyFormat("void f() { return 42; }", getLLVMStyleWithColumns(23));
3126 verifyFormat("void f() {\n return 42;\n}", getLLVMStyleWithColumns(22));
3127
3128 verifyFormat("void f() {}", getLLVMStyleWithColumns(11));
3129 verifyFormat("void f() {\n}", getLLVMStyleWithColumns(10));
Manuel Klimekf4ab9ef2013-01-11 17:54:10 +00003130}
3131
Manuel Klimeke01bab52013-01-15 13:38:33 +00003132TEST_F(FormatTest, UnderstandContextOfRecordTypeKeywords) {
3133 // Elaborate type variable declarations.
Manuel Klimekd5e5f8f2013-01-11 18:13:04 +00003134 verifyFormat("struct foo a = { bar };\nint n;");
Manuel Klimeke01bab52013-01-15 13:38:33 +00003135 verifyFormat("class foo a = { bar };\nint n;");
3136 verifyFormat("union foo a = { bar };\nint n;");
3137
3138 // Elaborate types inside function definitions.
3139 verifyFormat("struct foo f() {}\nint n;");
3140 verifyFormat("class foo f() {}\nint n;");
3141 verifyFormat("union foo f() {}\nint n;");
3142
3143 // Templates.
3144 verifyFormat("template <class X> void f() {}\nint n;");
3145 verifyFormat("template <struct X> void f() {}\nint n;");
3146 verifyFormat("template <union X> void f() {}\nint n;");
3147
3148 // Actual definitions...
Manuel Klimeka4fe1c12013-01-21 16:42:44 +00003149 verifyFormat("struct {\n} n;");
3150 verifyFormat(
3151 "template <template <class T, class Y>, class Z> class X {\n} n;");
Manuel Klimeke01bab52013-01-15 13:38:33 +00003152 verifyFormat("union Z {\n int n;\n} x;");
Manuel Klimeka4fe1c12013-01-21 16:42:44 +00003153 verifyFormat("class MACRO Z {\n} n;");
3154 verifyFormat("class MACRO(X) Z {\n} n;");
3155 verifyFormat("class __attribute__(X) Z {\n} n;");
3156 verifyFormat("class __declspec(X) Z {\n} n;");
Manuel Klimekd2650902013-02-06 15:57:54 +00003157 verifyFormat("class A##B##C {\n} n;");
Manuel Klimeke01bab52013-01-15 13:38:33 +00003158
Manuel Klimek3c6b7c72013-01-21 10:17:14 +00003159 // Redefinition from nested context:
Manuel Klimeka4fe1c12013-01-21 16:42:44 +00003160 verifyFormat("class A::B::C {\n} n;");
Manuel Klimek3c6b7c72013-01-21 10:17:14 +00003161
Manuel Klimekcdee74d2013-01-21 13:58:54 +00003162 // Template definitions.
Daniel Jasper6f05e592013-05-15 13:46:48 +00003163 verifyFormat(
3164 "template <typename F>\n"
3165 "Matcher(const Matcher<F> &Other,\n"
3166 " typename enable_if_c<is_base_of<F, T>::value &&\n"
3167 " !is_same<F, T>::value>::type * = 0)\n"
3168 " : Implementation(new ImplicitCastMatcher<F>(Other)) {}");
3169
Manuel Klimekcdee74d2013-01-21 13:58:54 +00003170 // FIXME: This is still incorrectly handled at the formatter side.
Manuel Klimeka4fe1c12013-01-21 16:42:44 +00003171 verifyFormat("template <> struct X < 15, i < 3 && 42 < 50 && 33<28> {\n};");
Manuel Klimekcdee74d2013-01-21 13:58:54 +00003172
3173 // FIXME:
3174 // This now gets parsed incorrectly as class definition.
Manuel Klimeka4fe1c12013-01-21 16:42:44 +00003175 // verifyFormat("class A<int> f() {\n}\nint n;");
Manuel Klimekcdee74d2013-01-21 13:58:54 +00003176
Manuel Klimeke01bab52013-01-15 13:38:33 +00003177 // Elaborate types where incorrectly parsing the structural element would
3178 // break the indent.
3179 verifyFormat("if (true)\n"
3180 " class X x;\n"
3181 "else\n"
3182 " f();\n");
Daniel Jasper1a32a612013-03-20 15:12:38 +00003183
3184 // This is simply incomplete. Formatting is not important, but must not crash.
3185 verifyFormat("class A:");
Manuel Klimekd5e5f8f2013-01-11 18:13:04 +00003186}
3187
Manuel Klimek99c7baa2013-01-15 15:50:27 +00003188TEST_F(FormatTest, DoNotInterfereWithErrorAndWarning) {
3189 verifyFormat("#error Leave all white!!!!! space* alone!\n");
3190 verifyFormat("#warning Leave all white!!!!! space* alone!\n");
3191 EXPECT_EQ("#error 1", format(" # error 1"));
3192 EXPECT_EQ("#warning 1", format(" # warning 1"));
3193}
3194
Daniel Jasper4431aa92013-04-23 13:54:04 +00003195TEST_F(FormatTest, FormatHashIfExpressions) {
3196 // FIXME: Come up with a better indentation for #elif.
3197 verifyFormat(
3198 "#if !defined(AAAAAAA) && (defined CCCCCC || defined DDDDDD) && \\\n"
3199 " defined(BBBBBBBB)\n"
3200 "#elif !defined(AAAAAA) && (defined CCCCC || defined DDDDDD) && \\\n"
3201 " defined(BBBBBBBB)\n"
3202 "#endif",
3203 getLLVMStyleWithColumns(65));
3204}
3205
Manuel Klimekd3b92fa2013-01-18 14:04:34 +00003206TEST_F(FormatTest, MergeHandlingInTheFaceOfPreprocessorDirectives) {
3207 FormatStyle AllowsMergedIf = getGoogleStyle();
3208 AllowsMergedIf.AllowShortIfStatementsOnASingleLine = true;
3209 verifyFormat("void f() { f(); }\n#error E", AllowsMergedIf);
3210 verifyFormat("if (true) return 42;\n#error E", AllowsMergedIf);
Manuel Klimekda087612013-01-18 14:46:43 +00003211 verifyFormat("if (true)\n#error E\n return 42;", AllowsMergedIf);
3212 EXPECT_EQ("if (true) return 42;",
3213 format("if (true)\nreturn 42;", AllowsMergedIf));
3214 FormatStyle ShortMergedIf = AllowsMergedIf;
3215 ShortMergedIf.ColumnLimit = 25;
Daniel Jasper6fe2f002013-04-25 08:56:26 +00003216 verifyFormat("#define A \\\n"
Daniel Jasper2ec3ffb82013-02-18 11:59:17 +00003217 " if (true) return 42;",
3218 ShortMergedIf);
Daniel Jasper6fe2f002013-04-25 08:56:26 +00003219 verifyFormat("#define A \\\n"
3220 " f(); \\\n"
Manuel Klimekda087612013-01-18 14:46:43 +00003221 " if (true)\n"
Daniel Jasper2ec3ffb82013-02-18 11:59:17 +00003222 "#define B",
3223 ShortMergedIf);
Daniel Jasper6fe2f002013-04-25 08:56:26 +00003224 verifyFormat("#define A \\\n"
3225 " f(); \\\n"
Manuel Klimekda087612013-01-18 14:46:43 +00003226 " if (true)\n"
Daniel Jasper2ec3ffb82013-02-18 11:59:17 +00003227 "g();",
3228 ShortMergedIf);
Manuel Klimekd5e782b2013-01-21 14:16:56 +00003229 verifyFormat("{\n"
3230 "#ifdef A\n"
3231 " // Comment\n"
3232 " if (true) continue;\n"
3233 "#endif\n"
3234 " // Comment\n"
Daniel Jasper2ec3ffb82013-02-18 11:59:17 +00003235 " if (true) continue;",
3236 ShortMergedIf);
Manuel Klimekd3b92fa2013-01-18 14:04:34 +00003237}
3238
Manuel Klimekf92f7bc2013-01-22 16:31:55 +00003239TEST_F(FormatTest, BlockCommentsInControlLoops) {
3240 verifyFormat("if (0) /* a comment in a strange place */ {\n"
3241 " f();\n"
3242 "}");
3243 verifyFormat("if (0) /* a comment in a strange place */ {\n"
3244 " f();\n"
3245 "} /* another comment */ else /* comment #3 */ {\n"
3246 " g();\n"
3247 "}");
3248 verifyFormat("while (0) /* a comment in a strange place */ {\n"
3249 " f();\n"
3250 "}");
3251 verifyFormat("for (;;) /* a comment in a strange place */ {\n"
3252 " f();\n"
3253 "}");
3254 verifyFormat("do /* a comment in a strange place */ {\n"
3255 " f();\n"
3256 "} /* another comment */ while (0);");
3257}
3258
3259TEST_F(FormatTest, BlockComments) {
3260 EXPECT_EQ("/* */ /* */ /* */\n/* */ /* */ /* */",
3261 format("/* *//* */ /* */\n/* *//* */ /* */"));
Daniel Jasper2ec3ffb82013-02-18 11:59:17 +00003262 EXPECT_EQ("/* */ a /* */ b;", format(" /* */ a/* */ b;"));
Alexander Kornienko547a9f522013-03-21 12:28:10 +00003263 EXPECT_EQ("#define A /*123*/\\\n"
Manuel Klimekf92f7bc2013-01-22 16:31:55 +00003264 " b\n"
3265 "/* */\n"
3266 "someCall(\n"
3267 " parameter);",
Alexander Kornienko547a9f522013-03-21 12:28:10 +00003268 format("#define A /*123*/ b\n"
Manuel Klimekf92f7bc2013-01-22 16:31:55 +00003269 "/* */\n"
Daniel Jasper2ec3ffb82013-02-18 11:59:17 +00003270 "someCall(parameter);",
3271 getLLVMStyleWithColumns(15)));
Manuel Klimekf92f7bc2013-01-22 16:31:55 +00003272
3273 EXPECT_EQ("#define A\n"
3274 "/* */ someCall(\n"
3275 " parameter);",
3276 format("#define A\n"
Daniel Jasper2ec3ffb82013-02-18 11:59:17 +00003277 "/* */someCall(parameter);",
3278 getLLVMStyleWithColumns(15)));
Daniel Jasper1f140982013-02-04 07:32:14 +00003279
Daniel Jasper2cf17bf2013-02-27 09:47:53 +00003280 FormatStyle NoBinPacking = getLLVMStyle();
3281 NoBinPacking.BinPackParameters = false;
Daniel Jasper1f140982013-02-04 07:32:14 +00003282 EXPECT_EQ("someFunction(1, /* comment 1 */\n"
3283 " 2, /* comment 2 */\n"
3284 " 3, /* comment 3 */\n"
Daniel Jasper14e40ec2013-02-04 08:34:57 +00003285 " aaaa,\n"
3286 " bbbb);",
Daniel Jasper1f140982013-02-04 07:32:14 +00003287 format("someFunction (1, /* comment 1 */\n"
3288 " 2, /* comment 2 */ \n"
3289 " 3, /* comment 3 */\n"
Daniel Jasper2ec3ffb82013-02-18 11:59:17 +00003290 "aaaa, bbbb );",
Daniel Jasper2cf17bf2013-02-27 09:47:53 +00003291 NoBinPacking));
Daniel Jasper38396592013-02-06 15:23:09 +00003292 verifyFormat(
3293 "bool aaaaaaaaaaaaa = /* comment: */ aaaaaaaaaaaaaaaaaaaaaaaaaaaaaa ||\n"
3294 " aaaaaaaaaaaaaaaaaaaaaaaaaaaa;");
3295 EXPECT_EQ(
3296 "bool aaaaaaaaaaaaa = /* trailing comment */\n"
3297 " aaaaaaaaaaaaaaaaaaaaaaaaaaa || aaaaaaaaaaaaaaaaaaaaaaaaa ||\n"
3298 " aaaaaaaaaaaaaaaaaaaaaaaaaaaa || aaaaaaaaaaaaaaaaaaaaaaaaaa;",
3299 format(
3300 "bool aaaaaaaaaaaaa = /* trailing comment */\n"
3301 " aaaaaaaaaaaaaaaaaaaaaaaaaaa||aaaaaaaaaaaaaaaaaaaaaaaaa ||\n"
3302 " aaaaaaaaaaaaaaaaaaaaaaaaaaaa || aaaaaaaaaaaaaaaaaaaaaaaaaa;"));
Daniel Jasper94f0e132013-02-06 20:07:35 +00003303 EXPECT_EQ(
3304 "int aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa; /* comment */\n"
3305 "int bbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbb; /* comment */\n"
3306 "int cccccccccccccccccccccccccccccc; /* comment */\n",
3307 format("int aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa; /* comment */\n"
3308 "int bbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbb; /* comment */\n"
3309 "int cccccccccccccccccccccccccccccc; /* comment */\n"));
Manuel Klimekf92f7bc2013-01-22 16:31:55 +00003310}
3311
Manuel Klimek82b836a2013-02-06 16:40:56 +00003312TEST_F(FormatTest, BlockCommentsInMacros) {
3313 EXPECT_EQ("#define A \\\n"
3314 " { \\\n"
3315 " /* one line */ \\\n"
3316 " someCall();",
3317 format("#define A { \\\n"
3318 " /* one line */ \\\n"
Daniel Jasper2ec3ffb82013-02-18 11:59:17 +00003319 " someCall();",
3320 getLLVMStyleWithColumns(20)));
Manuel Klimek82b836a2013-02-06 16:40:56 +00003321 EXPECT_EQ("#define A \\\n"
3322 " { \\\n"
3323 " /* previous */ \\\n"
3324 " /* one line */ \\\n"
3325 " someCall();",
3326 format("#define A { \\\n"
3327 " /* previous */ \\\n"
3328 " /* one line */ \\\n"
Daniel Jasper2ec3ffb82013-02-18 11:59:17 +00003329 " someCall();",
3330 getLLVMStyleWithColumns(20)));
Manuel Klimek82b836a2013-02-06 16:40:56 +00003331}
3332
3333TEST_F(FormatTest, IndentLineCommentsInStartOfBlockAtEndOfFile) {
3334 // FIXME: This is not what we want...
3335 verifyFormat("{\n"
3336 "// a"
3337 "// b");
3338}
3339
Manuel Klimekd33516e2013-01-23 10:09:28 +00003340TEST_F(FormatTest, FormatStarDependingOnContext) {
Manuel Klimek0a3a3c92013-01-23 09:32:48 +00003341 verifyFormat("void f(int *a);");
3342 verifyFormat("void f() { f(fint * b); }");
Manuel Klimek39080572013-01-23 11:03:04 +00003343 verifyFormat("class A {\n void f(int *a);\n};");
3344 verifyFormat("class A {\n int *a;\n};");
3345 verifyFormat("namespace a {\n"
3346 "namespace b {\n"
3347 "class A {\n"
3348 " void f() {}\n"
3349 " int *a;\n"
3350 "};\n"
3351 "}\n"
3352 "}");
Manuel Klimek0a3a3c92013-01-23 09:32:48 +00003353}
3354
Manuel Klimekd33516e2013-01-23 10:09:28 +00003355TEST_F(FormatTest, SpecialTokensAtEndOfLine) {
3356 verifyFormat("while");
3357 verifyFormat("operator");
3358}
3359
Nico Weber7e6a7a12013-01-08 17:56:31 +00003360//===----------------------------------------------------------------------===//
3361// Objective-C tests.
3362//===----------------------------------------------------------------------===//
3363
Fariborz Jahanian68a542a2012-12-20 19:54:13 +00003364TEST_F(FormatTest, FormatForObjectiveCMethodDecls) {
3365 verifyFormat("- (void)sendAction:(SEL)aSelector to:(BOOL)anObject;");
3366 EXPECT_EQ("- (NSUInteger)indexOfObject:(id)anObject;",
3367 format("-(NSUInteger)indexOfObject:(id)anObject;"));
Daniel Jasper8d1832e2013-01-07 13:26:07 +00003368 EXPECT_EQ("- (NSInteger)Mthod1;", format("-(NSInteger)Mthod1;"));
Fariborz Jahanian68a542a2012-12-20 19:54:13 +00003369 EXPECT_EQ("+ (id)Mthod2;", format("+(id)Mthod2;"));
3370 EXPECT_EQ("- (NSInteger)Method3:(id)anObject;",
3371 format("-(NSInteger)Method3:(id)anObject;"));
3372 EXPECT_EQ("- (NSInteger)Method4:(id)anObject;",
3373 format("-(NSInteger)Method4:(id)anObject;"));
3374 EXPECT_EQ("- (NSInteger)Method5:(id)anObject:(id)AnotherObject;",
3375 format("-(NSInteger)Method5:(id)anObject:(id)AnotherObject;"));
3376 EXPECT_EQ("- (id)Method6:(id)A:(id)B:(id)C:(id)D;",
3377 format("- (id)Method6:(id)A:(id)B:(id)C:(id)D;"));
Daniel Jasper8d1832e2013-01-07 13:26:07 +00003378 EXPECT_EQ(
3379 "- (void)sendAction:(SEL)aSelector to:(id)anObject forAllCells:(BOOL)flag;",
Daniel Jasper2ec3ffb82013-02-18 11:59:17 +00003380 format(
3381 "- (void)sendAction:(SEL)aSelector to:(id)anObject forAllCells:(BOOL)flag;"));
Fariborz Jahanian9017ec32012-12-21 22:51:18 +00003382
3383 // Very long objectiveC method declaration.
Daniel Jasper1ac3e052013-02-05 10:07:47 +00003384 verifyFormat("- (NSUInteger)indexOfObject:(id)anObject\n"
3385 " inRange:(NSRange)range\n"
3386 " outRange:(NSRange)out_range\n"
3387 " outRange1:(NSRange)out_range1\n"
3388 " outRange2:(NSRange)out_range2\n"
3389 " outRange3:(NSRange)out_range3\n"
3390 " outRange4:(NSRange)out_range4\n"
3391 " outRange5:(NSRange)out_range5\n"
3392 " outRange6:(NSRange)out_range6\n"
3393 " outRange7:(NSRange)out_range7\n"
3394 " outRange8:(NSRange)out_range8\n"
3395 " outRange9:(NSRange)out_range9;");
Nico Weberd6f962f2013-01-10 20:18:33 +00003396
3397 verifyFormat("- (int)sum:(vector<int>)numbers;");
Nico Weber772fbfd2013-01-17 06:14:50 +00003398 verifyGoogleFormat("- (void)setDelegate:(id<Protocol>)delegate;");
Nico Weberd6f962f2013-01-10 20:18:33 +00003399 // FIXME: In LLVM style, there should be a space in front of a '<' for ObjC
3400 // protocol lists (but not for template classes):
3401 //verifyFormat("- (void)setDelegate:(id <Protocol>)delegate;");
Nico Weber9efe2912013-01-10 23:11:41 +00003402
3403 verifyFormat("- (int(*)())foo:(int(*)())f;");
Nico Weber772fbfd2013-01-17 06:14:50 +00003404 verifyGoogleFormat("- (int(*)())foo:(int(*)())foo;");
Nico Weber9efe2912013-01-10 23:11:41 +00003405
3406 // If there's no return type (very rare in practice!), LLVM and Google style
3407 // agree.
Daniel Jasperdd9276e2013-03-22 16:55:40 +00003408 verifyFormat("- foo;");
Nico Weber9efe2912013-01-10 23:11:41 +00003409 verifyFormat("- foo:(int)f;");
3410 verifyGoogleFormat("- foo:(int)foo;");
Fariborz Jahanian68a542a2012-12-20 19:54:13 +00003411}
3412
Daniel Jasperfb3f2482013-01-09 08:36:49 +00003413TEST_F(FormatTest, FormatObjCBlocks) {
Daniel Jasperc1fa2812013-01-10 13:08:12 +00003414 verifyFormat("int (^Block)(int, int);");
3415 verifyFormat("int (^Block1)(int, int) = ^(int i, int j)");
Daniel Jasperfb3f2482013-01-09 08:36:49 +00003416}
3417
Nico Weber7eecf4b2013-01-09 20:25:35 +00003418TEST_F(FormatTest, FormatObjCInterface) {
Nico Webera6087752013-01-10 20:12:55 +00003419 verifyFormat("@interface Foo : NSObject <NSSomeDelegate> {\n"
Nico Weber7eecf4b2013-01-09 20:25:35 +00003420 "@public\n"
3421 " int field1;\n"
3422 "@protected\n"
3423 " int field2;\n"
3424 "@private\n"
3425 " int field3;\n"
3426 "@package\n"
3427 " int field4;\n"
3428 "}\n"
3429 "+ (id)init;\n"
3430 "@end");
3431
Nico Weber7eecf4b2013-01-09 20:25:35 +00003432 verifyGoogleFormat("@interface Foo : NSObject<NSSomeDelegate> {\n"
3433 " @public\n"
3434 " int field1;\n"
3435 " @protected\n"
3436 " int field2;\n"
3437 " @private\n"
3438 " int field3;\n"
3439 " @package\n"
3440 " int field4;\n"
3441 "}\n"
Nico Weber772fbfd2013-01-17 06:14:50 +00003442 "+ (id)init;\n"
Nico Weber7eecf4b2013-01-09 20:25:35 +00003443 "@end");
3444
Nico Weber6029d4f2013-01-22 16:53:59 +00003445 verifyFormat("@interface /* wait for it */ Foo\n"
Nico Weber7eecf4b2013-01-09 20:25:35 +00003446 "+ (id)init;\n"
3447 "// Look, a comment!\n"
3448 "- (int)answerWith:(int)i;\n"
3449 "@end");
3450
3451 verifyFormat("@interface Foo\n"
Nico Weberd8ffe752013-01-09 21:42:32 +00003452 "@end\n"
3453 "@interface Bar\n"
Nico Weber7eecf4b2013-01-09 20:25:35 +00003454 "@end");
3455
3456 verifyFormat("@interface Foo : Bar\n"
3457 "+ (id)init;\n"
3458 "@end");
3459
Nico Weber6029d4f2013-01-22 16:53:59 +00003460 verifyFormat("@interface Foo : /**/ Bar /**/ <Baz, /**/ Quux>\n"
Nico Weber7eecf4b2013-01-09 20:25:35 +00003461 "+ (id)init;\n"
3462 "@end");
3463
Nico Webera6087752013-01-10 20:12:55 +00003464 verifyGoogleFormat("@interface Foo : Bar<Baz, Quux>\n"
Nico Weber772fbfd2013-01-17 06:14:50 +00003465 "+ (id)init;\n"
Nico Webera6087752013-01-10 20:12:55 +00003466 "@end");
3467
Nico Weber2bb00742013-01-10 19:19:14 +00003468 verifyFormat("@interface Foo (HackStuff)\n"
Nico Weber7eecf4b2013-01-09 20:25:35 +00003469 "+ (id)init;\n"
3470 "@end");
3471
Nico Weber2bb00742013-01-10 19:19:14 +00003472 verifyFormat("@interface Foo ()\n"
Nico Weber7eecf4b2013-01-09 20:25:35 +00003473 "+ (id)init;\n"
3474 "@end");
3475
Nico Webera6087752013-01-10 20:12:55 +00003476 verifyFormat("@interface Foo (HackStuff) <MyProtocol>\n"
Nico Weber7eecf4b2013-01-09 20:25:35 +00003477 "+ (id)init;\n"
3478 "@end");
3479
Nico Webera6087752013-01-10 20:12:55 +00003480 verifyGoogleFormat("@interface Foo (HackStuff)<MyProtocol>\n"
Nico Weber772fbfd2013-01-17 06:14:50 +00003481 "+ (id)init;\n"
Nico Webera6087752013-01-10 20:12:55 +00003482 "@end");
3483
Manuel Klimek2acb7b72013-01-11 19:17:44 +00003484 verifyFormat("@interface Foo {\n"
3485 " int _i;\n"
3486 "}\n"
Nico Weber7eecf4b2013-01-09 20:25:35 +00003487 "+ (id)init;\n"
3488 "@end");
3489
Manuel Klimek2acb7b72013-01-11 19:17:44 +00003490 verifyFormat("@interface Foo : Bar {\n"
3491 " int _i;\n"
3492 "}\n"
Nico Weber7eecf4b2013-01-09 20:25:35 +00003493 "+ (id)init;\n"
3494 "@end");
3495
Manuel Klimek2acb7b72013-01-11 19:17:44 +00003496 verifyFormat("@interface Foo : Bar <Baz, Quux> {\n"
3497 " int _i;\n"
3498 "}\n"
Nico Weber7eecf4b2013-01-09 20:25:35 +00003499 "+ (id)init;\n"
3500 "@end");
3501
Manuel Klimek2acb7b72013-01-11 19:17:44 +00003502 verifyFormat("@interface Foo (HackStuff) {\n"
3503 " int _i;\n"
3504 "}\n"
Nico Weber7eecf4b2013-01-09 20:25:35 +00003505 "+ (id)init;\n"
3506 "@end");
3507
Manuel Klimek2acb7b72013-01-11 19:17:44 +00003508 verifyFormat("@interface Foo () {\n"
3509 " int _i;\n"
3510 "}\n"
Nico Weber7eecf4b2013-01-09 20:25:35 +00003511 "+ (id)init;\n"
3512 "@end");
3513
Manuel Klimek2acb7b72013-01-11 19:17:44 +00003514 verifyFormat("@interface Foo (HackStuff) <MyProtocol> {\n"
3515 " int _i;\n"
3516 "}\n"
Nico Weber7eecf4b2013-01-09 20:25:35 +00003517 "+ (id)init;\n"
3518 "@end");
3519}
3520
Nico Weber2ce0ac52013-01-09 23:25:37 +00003521TEST_F(FormatTest, FormatObjCImplementation) {
3522 verifyFormat("@implementation Foo : NSObject {\n"
3523 "@public\n"
3524 " int field1;\n"
3525 "@protected\n"
3526 " int field2;\n"
3527 "@private\n"
3528 " int field3;\n"
3529 "@package\n"
3530 " int field4;\n"
3531 "}\n"
Manuel Klimeka4fe1c12013-01-21 16:42:44 +00003532 "+ (id)init {\n}\n"
Nico Weber2ce0ac52013-01-09 23:25:37 +00003533 "@end");
3534
3535 verifyGoogleFormat("@implementation Foo : NSObject {\n"
3536 " @public\n"
3537 " int field1;\n"
3538 " @protected\n"
3539 " int field2;\n"
3540 " @private\n"
3541 " int field3;\n"
3542 " @package\n"
3543 " int field4;\n"
3544 "}\n"
Manuel Klimeka4fe1c12013-01-21 16:42:44 +00003545 "+ (id)init {\n}\n"
Nico Weber2ce0ac52013-01-09 23:25:37 +00003546 "@end");
3547
3548 verifyFormat("@implementation Foo\n"
3549 "+ (id)init {\n"
Daniel Jasper1b750ed2013-01-14 16:24:39 +00003550 " if (true)\n"
3551 " return nil;\n"
Nico Weber2ce0ac52013-01-09 23:25:37 +00003552 "}\n"
3553 "// Look, a comment!\n"
Manuel Klimek2acb7b72013-01-11 19:17:44 +00003554 "- (int)answerWith:(int)i {\n"
3555 " return i;\n"
3556 "}\n"
Nico Webera21aaae2013-01-11 21:14:08 +00003557 "+ (int)answerWith:(int)i {\n"
3558 " return i;\n"
3559 "}\n"
Nico Weber2ce0ac52013-01-09 23:25:37 +00003560 "@end");
3561
3562 verifyFormat("@implementation Foo\n"
3563 "@end\n"
3564 "@implementation Bar\n"
3565 "@end");
3566
3567 verifyFormat("@implementation Foo : Bar\n"
Manuel Klimeka4fe1c12013-01-21 16:42:44 +00003568 "+ (id)init {\n}\n"
3569 "- (void)foo {\n}\n"
Nico Weber2ce0ac52013-01-09 23:25:37 +00003570 "@end");
3571
Manuel Klimek2acb7b72013-01-11 19:17:44 +00003572 verifyFormat("@implementation Foo {\n"
3573 " int _i;\n"
3574 "}\n"
Manuel Klimeka4fe1c12013-01-21 16:42:44 +00003575 "+ (id)init {\n}\n"
Nico Weber2ce0ac52013-01-09 23:25:37 +00003576 "@end");
3577
Manuel Klimek2acb7b72013-01-11 19:17:44 +00003578 verifyFormat("@implementation Foo : Bar {\n"
3579 " int _i;\n"
3580 "}\n"
Manuel Klimeka4fe1c12013-01-21 16:42:44 +00003581 "+ (id)init {\n}\n"
Nico Weber2ce0ac52013-01-09 23:25:37 +00003582 "@end");
3583
Nico Weber2bb00742013-01-10 19:19:14 +00003584 verifyFormat("@implementation Foo (HackStuff)\n"
Manuel Klimeka4fe1c12013-01-21 16:42:44 +00003585 "+ (id)init {\n}\n"
Nico Weber2ce0ac52013-01-09 23:25:37 +00003586 "@end");
3587}
3588
Nico Weber8696a8d2013-01-09 21:15:03 +00003589TEST_F(FormatTest, FormatObjCProtocol) {
3590 verifyFormat("@protocol Foo\n"
3591 "@property(weak) id delegate;\n"
3592 "- (NSUInteger)numberOfThings;\n"
3593 "@end");
3594
Nico Webera6087752013-01-10 20:12:55 +00003595 verifyFormat("@protocol MyProtocol <NSObject>\n"
Nico Weber8696a8d2013-01-09 21:15:03 +00003596 "- (NSUInteger)numberOfThings;\n"
3597 "@end");
3598
Nico Webera6087752013-01-10 20:12:55 +00003599 verifyGoogleFormat("@protocol MyProtocol<NSObject>\n"
Nico Weber772fbfd2013-01-17 06:14:50 +00003600 "- (NSUInteger)numberOfThings;\n"
Nico Webera6087752013-01-10 20:12:55 +00003601 "@end");
3602
Nico Weber8696a8d2013-01-09 21:15:03 +00003603 verifyFormat("@protocol Foo;\n"
3604 "@protocol Bar;\n");
Nico Weberd8ffe752013-01-09 21:42:32 +00003605
3606 verifyFormat("@protocol Foo\n"
3607 "@end\n"
3608 "@protocol Bar\n"
3609 "@end");
Nico Weber51306d22013-01-10 00:25:19 +00003610
3611 verifyFormat("@protocol myProtocol\n"
3612 "- (void)mandatoryWithInt:(int)i;\n"
3613 "@optional\n"
3614 "- (void)optional;\n"
3615 "@required\n"
3616 "- (void)required;\n"
Nico Weberbbe28b32013-01-10 00:42:07 +00003617 "@optional\n"
3618 "@property(assign) int madProp;\n"
Nico Weber51306d22013-01-10 00:25:19 +00003619 "@end\n");
Nico Weber8696a8d2013-01-09 21:15:03 +00003620}
3621
Daniel Jasper1ac3e052013-02-05 10:07:47 +00003622TEST_F(FormatTest, FormatObjCMethodDeclarations) {
3623 verifyFormat("- (void)doSomethingWith:(GTMFoo *)theFoo\n"
3624 " rect:(NSRect)theRect\n"
3625 " interval:(float)theInterval {\n"
3626 "}");
3627 verifyFormat("- (void)shortf:(GTMFoo *)theFoo\n"
3628 " longKeyword:(NSRect)theRect\n"
3629 " evenLongerKeyword:(float)theInterval\n"
3630 " error:(NSError **)theError {\n"
3631 "}");
3632}
3633
Nico Webera7252d82013-01-12 06:18:40 +00003634TEST_F(FormatTest, FormatObjCMethodExpr) {
3635 verifyFormat("[foo bar:baz];");
3636 verifyFormat("return [foo bar:baz];");
3637 verifyFormat("f([foo bar:baz]);");
3638 verifyFormat("f(2, [foo bar:baz]);");
3639 verifyFormat("f(2, a ? b : c);");
3640 verifyFormat("[[self initWithInt:4] bar:[baz quux:arrrr]];");
3641
Nico Weberb76de882013-02-05 16:21:00 +00003642 // Unary operators.
3643 verifyFormat("int a = +[foo bar:baz];");
3644 verifyFormat("int a = -[foo bar:baz];");
3645 verifyFormat("int a = ![foo bar:baz];");
3646 verifyFormat("int a = ~[foo bar:baz];");
3647 verifyFormat("int a = ++[foo bar:baz];");
3648 verifyFormat("int a = --[foo bar:baz];");
3649 verifyFormat("int a = sizeof [foo bar:baz];");
3650 verifyFormat("int a = alignof [foo bar:baz];");
Nico Weber5d2624e2013-02-06 06:20:11 +00003651 verifyFormat("int a = &[foo bar:baz];");
3652 verifyFormat("int a = *[foo bar:baz];");
Nico Weberb76de882013-02-05 16:21:00 +00003653 // FIXME: Make casts work, without breaking f()[4].
Nico Webera7892392013-02-13 03:48:27 +00003654 //verifyFormat("int a = (int)[foo bar:baz];");
Nico Weber71800c42013-02-13 04:40:03 +00003655 //verifyFormat("return (int)[foo bar:baz];");
3656 //verifyFormat("(void)[foo bar:baz];");
Nico Webera7892392013-02-13 03:48:27 +00003657 verifyFormat("return (MyType *)[self.tableView cellForRowAtIndexPath:cell];");
Nico Weberb76de882013-02-05 16:21:00 +00003658
3659 // Binary operators.
Nico Webera7252d82013-01-12 06:18:40 +00003660 verifyFormat("[foo bar:baz], [foo bar:baz];");
3661 verifyFormat("[foo bar:baz] = [foo bar:baz];");
3662 verifyFormat("[foo bar:baz] *= [foo bar:baz];");
3663 verifyFormat("[foo bar:baz] /= [foo bar:baz];");
3664 verifyFormat("[foo bar:baz] %= [foo bar:baz];");
3665 verifyFormat("[foo bar:baz] += [foo bar:baz];");
3666 verifyFormat("[foo bar:baz] -= [foo bar:baz];");
3667 verifyFormat("[foo bar:baz] <<= [foo bar:baz];");
3668 verifyFormat("[foo bar:baz] >>= [foo bar:baz];");
3669 verifyFormat("[foo bar:baz] &= [foo bar:baz];");
3670 verifyFormat("[foo bar:baz] ^= [foo bar:baz];");
3671 verifyFormat("[foo bar:baz] |= [foo bar:baz];");
3672 verifyFormat("[foo bar:baz] ? [foo bar:baz] : [foo bar:baz];");
3673 verifyFormat("[foo bar:baz] || [foo bar:baz];");
3674 verifyFormat("[foo bar:baz] && [foo bar:baz];");
3675 verifyFormat("[foo bar:baz] | [foo bar:baz];");
3676 verifyFormat("[foo bar:baz] ^ [foo bar:baz];");
3677 verifyFormat("[foo bar:baz] & [foo bar:baz];");
3678 verifyFormat("[foo bar:baz] == [foo bar:baz];");
3679 verifyFormat("[foo bar:baz] != [foo bar:baz];");
3680 verifyFormat("[foo bar:baz] >= [foo bar:baz];");
3681 verifyFormat("[foo bar:baz] <= [foo bar:baz];");
3682 verifyFormat("[foo bar:baz] > [foo bar:baz];");
3683 verifyFormat("[foo bar:baz] < [foo bar:baz];");
3684 verifyFormat("[foo bar:baz] >> [foo bar:baz];");
3685 verifyFormat("[foo bar:baz] << [foo bar:baz];");
3686 verifyFormat("[foo bar:baz] - [foo bar:baz];");
3687 verifyFormat("[foo bar:baz] + [foo bar:baz];");
3688 verifyFormat("[foo bar:baz] * [foo bar:baz];");
3689 verifyFormat("[foo bar:baz] / [foo bar:baz];");
3690 verifyFormat("[foo bar:baz] % [foo bar:baz];");
3691 // Whew!
3692
Nico Weber29f9dea2013-02-11 15:32:15 +00003693 verifyFormat("return in[42];");
3694 verifyFormat("for (id foo in [self getStuffFor:bla]) {\n"
3695 "}");
3696
Nico Webera7252d82013-01-12 06:18:40 +00003697 verifyFormat("[self stuffWithInt:(4 + 2) float:4.5];");
3698 verifyFormat("[self stuffWithInt:a ? b : c float:4.5];");
3699 verifyFormat("[self stuffWithInt:a ? [self foo:bar] : c];");
3700 verifyFormat("[self stuffWithInt:a ? (e ? f : g) : c];");
3701 verifyFormat("[cond ? obj1 : obj2 methodWithParam:param]");
Nico Weber5c8709b2013-01-12 23:41:33 +00003702 verifyFormat("[button setAction:@selector(zoomOut:)];");
Nico Weber2827a7e2013-01-12 23:48:49 +00003703 verifyFormat("[color getRed:&r green:&g blue:&b alpha:&a];");
Daniel Jasper1ac3e052013-02-05 10:07:47 +00003704
Nico Webera7252d82013-01-12 06:18:40 +00003705 verifyFormat("arr[[self indexForFoo:a]];");
3706 verifyFormat("throw [self errorFor:a];");
3707 verifyFormat("@throw [self errorFor:a];");
3708
Nico Weberc9d73612013-01-12 22:48:47 +00003709 // This tests that the formatter doesn't break after "backing" but before ":",
3710 // which would be at 80 columns.
Nico Webera7252d82013-01-12 06:18:40 +00003711 verifyFormat(
3712 "void f() {\n"
Daniel Jasper1ac3e052013-02-05 10:07:47 +00003713 " if ((self = [super initWithContentRect:contentRect\n"
3714 " styleMask:styleMask\n"
3715 " backing:NSBackingStoreBuffered\n"
3716 " defer:YES]))");
3717
Daniel Jasperc697ad22013-02-06 10:05:46 +00003718 verifyFormat(
3719 "[foo checkThatBreakingAfterColonWorksOk:\n"
3720 " [bar ifItDoes:reduceOverallLineLengthLikeInThisCase]];");
Daniel Jasper1ac3e052013-02-05 10:07:47 +00003721
3722 verifyFormat("[myObj short:arg1 // Force line break\n"
3723 " longKeyword:arg2\n"
3724 " evenLongerKeyword:arg3\n"
3725 " error:arg4];");
3726 verifyFormat(
3727 "void f() {\n"
3728 " popup_window_.reset([[RenderWidgetPopupWindow alloc]\n"
3729 " initWithContentRect:NSMakeRect(origin_global.x, origin_global.y,\n"
3730 " pos.width(), pos.height())\n"
3731 " styleMask:NSBorderlessWindowMask\n"
3732 " backing:NSBackingStoreBuffered\n"
3733 " defer:NO]);\n"
3734 "}");
Daniel Jasperc697ad22013-02-06 10:05:46 +00003735 verifyFormat("[contentsContainer replaceSubview:[subviews objectAtIndex:0]\n"
3736 " with:contentsNativeView];");
3737
3738 verifyFormat(
3739 "[pboard addTypes:[NSArray arrayWithObject:kBookmarkButtonDragType]\n"
3740 " owner:nillllll];");
3741
Daniel Jasperc697ad22013-02-06 10:05:46 +00003742 verifyFormat(
Daniel Jasperacc33662013-02-08 08:22:00 +00003743 "[pboard setData:[NSData dataWithBytes:&button length:sizeof(button)]\n"
Daniel Jasperc697ad22013-02-06 10:05:46 +00003744 " forType:kBookmarkButtonDragType];");
3745
3746 verifyFormat("[defaultCenter addObserver:self\n"
3747 " selector:@selector(willEnterFullscreen)\n"
3748 " name:kWillEnterFullscreenNotification\n"
3749 " object:nil];");
Daniel Jasperc485b4e2013-02-06 16:00:26 +00003750 verifyFormat("[image_rep drawInRect:drawRect\n"
3751 " fromRect:NSZeroRect\n"
3752 " operation:NSCompositeCopy\n"
3753 " fraction:1.0\n"
3754 " respectFlipped:NO\n"
3755 " hints:nil];");
Nico Weberac9bde22013-02-06 16:54:35 +00003756
3757 verifyFormat(
3758 "scoped_nsobject<NSTextField> message(\n"
3759 " // The frame will be fixed up when |-setMessageText:| is called.\n"
3760 " [[NSTextField alloc] initWithFrame:NSMakeRect(0, 0, 0, 0)]);");
Nico Webera7252d82013-01-12 06:18:40 +00003761}
3762
Nico Weber12d5bab2013-01-07 15:56:25 +00003763TEST_F(FormatTest, ObjCAt) {
Nico Weber803d61d2013-01-07 16:07:07 +00003764 verifyFormat("@autoreleasepool");
Nico Webere89c42f2013-01-07 16:14:28 +00003765 verifyFormat("@catch");
3766 verifyFormat("@class");
Nico Weber803d61d2013-01-07 16:07:07 +00003767 verifyFormat("@compatibility_alias");
3768 verifyFormat("@defs");
Nico Webera8876502013-01-07 15:17:23 +00003769 verifyFormat("@dynamic");
Nico Weber803d61d2013-01-07 16:07:07 +00003770 verifyFormat("@encode");
3771 verifyFormat("@end");
3772 verifyFormat("@finally");
3773 verifyFormat("@implementation");
3774 verifyFormat("@import");
3775 verifyFormat("@interface");
3776 verifyFormat("@optional");
3777 verifyFormat("@package");
Nico Webere89c42f2013-01-07 16:14:28 +00003778 verifyFormat("@private");
Nico Weber803d61d2013-01-07 16:07:07 +00003779 verifyFormat("@property");
Nico Webere89c42f2013-01-07 16:14:28 +00003780 verifyFormat("@protected");
Nico Weber803d61d2013-01-07 16:07:07 +00003781 verifyFormat("@protocol");
Nico Webere89c42f2013-01-07 16:14:28 +00003782 verifyFormat("@public");
Nico Weber803d61d2013-01-07 16:07:07 +00003783 verifyFormat("@required");
3784 verifyFormat("@selector");
3785 verifyFormat("@synchronized");
3786 verifyFormat("@synthesize");
Nico Webere89c42f2013-01-07 16:14:28 +00003787 verifyFormat("@throw");
3788 verifyFormat("@try");
Nico Weber803d61d2013-01-07 16:07:07 +00003789
Nico Weber12d5bab2013-01-07 15:56:25 +00003790 EXPECT_EQ("@interface", format("@ interface"));
3791
3792 // The precise formatting of this doesn't matter, nobody writes code like
3793 // this.
3794 verifyFormat("@ /*foo*/ interface");
Nico Webera8876502013-01-07 15:17:23 +00003795}
3796
Nico Weberd8cdb532013-01-08 19:15:23 +00003797TEST_F(FormatTest, ObjCSnippets) {
Manuel Klimek2acb7b72013-01-11 19:17:44 +00003798 verifyFormat("@autoreleasepool {\n"
3799 " foo();\n"
3800 "}");
Nico Weber7e6a7a12013-01-08 17:56:31 +00003801 verifyFormat("@class Foo, Bar;");
Nico Weberd8cdb532013-01-08 19:15:23 +00003802 verifyFormat("@compatibility_alias AliasName ExistingClass;");
Nico Weber7e6a7a12013-01-08 17:56:31 +00003803 verifyFormat("@dynamic textColor;");
Nico Webere3025672013-01-18 05:11:47 +00003804 verifyFormat("char *buf1 = @encode(int *);");
3805 verifyFormat("char *buf1 = @encode(typeof(4 * 5));");
Nico Weber44449172013-02-12 16:17:07 +00003806 verifyFormat("char *buf1 = @encode(int **);");
Nico Weber4cc98742013-01-08 20:16:23 +00003807 verifyFormat("Protocol *proto = @protocol(p1);");
Nico Weber250fe712013-01-18 02:43:57 +00003808 verifyFormat("SEL s = @selector(foo:);");
Manuel Klimek2acb7b72013-01-11 19:17:44 +00003809 verifyFormat("@synchronized(self) {\n"
3810 " f();\n"
3811 "}");
Nico Weber7e6a7a12013-01-08 17:56:31 +00003812
Nico Webera2a84952013-01-10 21:30:42 +00003813 verifyFormat("@synthesize dropArrowPosition = dropArrowPosition_;");
3814 verifyGoogleFormat("@synthesize dropArrowPosition = dropArrowPosition_;");
3815
Nico Weber7e6a7a12013-01-08 17:56:31 +00003816 verifyFormat("@property(assign, nonatomic) CGFloat hoverAlpha;");
Nico Webera2a84952013-01-10 21:30:42 +00003817 verifyFormat("@property(assign, getter=isEditable) BOOL editable;");
3818 verifyGoogleFormat("@property(assign, getter=isEditable) BOOL editable;");
Nico Weber7e6a7a12013-01-08 17:56:31 +00003819}
3820
Nico Weber0588b502013-02-07 00:19:29 +00003821TEST_F(FormatTest, ObjCLiterals) {
3822 verifyFormat("@\"String\"");
3823 verifyFormat("@1");
3824 verifyFormat("@+4.8");
3825 verifyFormat("@-4");
3826 verifyFormat("@1LL");
3827 verifyFormat("@.5");
3828 verifyFormat("@'c'");
3829 verifyFormat("@true");
3830
3831 verifyFormat("NSNumber *smallestInt = @(-INT_MAX - 1);");
3832 verifyFormat("NSNumber *piOverTwo = @(M_PI / 2);");
3833 verifyFormat("NSNumber *favoriteColor = @(Green);");
3834 verifyFormat("NSString *path = @(getenv(\"PATH\"));");
3835
Nico Weber0588b502013-02-07 00:19:29 +00003836 verifyFormat("@[");
Nico Weber2a726b62013-02-10 02:08:05 +00003837 verifyFormat("@[]");
3838 verifyFormat(
3839 "NSArray *array = @[ @\" Hey \", NSApp, [NSNumber numberWithInt:42] ];");
3840 verifyFormat("return @[ @3, @[], @[ @4, @5 ] ];");
3841
Nico Weber0588b502013-02-07 00:19:29 +00003842 verifyFormat("@{");
Nico Weber372d8dc2013-02-10 20:35:35 +00003843 verifyFormat("@{}");
3844 verifyFormat("@{ @\"one\" : @1 }");
3845 verifyFormat("return @{ @\"one\" : @1 };");
3846 verifyFormat("@{ @\"one\" : @1, }");
Manuel Klimek1a18c402013-04-12 14:13:36 +00003847
3848 // FIXME: Breaking in cases where we think there's a structural error
3849 // showed that we're incorrectly parsing this code. We need to fix the
3850 // parsing here.
3851 verifyFormat("@{ @\"one\" : @\n"
3852 "{ @2 : @1 }\n"
3853 "}");
3854 verifyFormat("@{ @\"one\" : @\n"
3855 "{ @2 : @1 }\n"
3856 ",\n"
3857 "}");
3858
Nico Weber372d8dc2013-02-10 20:35:35 +00003859 verifyFormat("@{ 1 > 2 ? @\"one\" : @\"two\" : 1 > 2 ? @1 : @2 }");
3860 verifyFormat("[self setDict:@{}");
3861 verifyFormat("[self setDict:@{ @1 : @2 }");
3862 verifyFormat("NSLog(@\"%@\", @{ @1 : @2, @2 : @3 }[@1]);");
3863 verifyFormat(
3864 "NSDictionary *masses = @{ @\"H\" : @1.0078, @\"He\" : @4.0026 };");
Nico Weber33c68e92013-02-10 20:39:05 +00003865 verifyFormat(
3866 "NSDictionary *settings = @{ AVEncoderKey : @(AVAudioQualityMax) };");
Daniel Jasper2ec3ffb82013-02-18 11:59:17 +00003867
Nico Weber372d8dc2013-02-10 20:35:35 +00003868 // FIXME: Nested and multi-line array and dictionary literals need more work.
Nico Weber0448b4d2013-02-10 20:48:24 +00003869 verifyFormat(
3870 "NSDictionary *d = @{ @\"nam\" : NSUserNam(), @\"dte\" : [NSDate date],\n"
3871 " @\"processInfo\" : [NSProcessInfo processInfo] };");
Nico Weber0588b502013-02-07 00:19:29 +00003872}
3873
Manuel Klimekb95f5452013-02-08 17:38:27 +00003874TEST_F(FormatTest, ReformatRegionAdjustsIndent) {
3875 EXPECT_EQ("{\n"
3876 "{\n"
3877 "a;\n"
3878 "b;\n"
3879 "}\n"
Daniel Jasper2ec3ffb82013-02-18 11:59:17 +00003880 "}",
3881 format("{\n"
3882 "{\n"
3883 "a;\n"
3884 " b;\n"
3885 "}\n"
3886 "}",
3887 13, 2, getLLVMStyle()));
Manuel Klimekb95f5452013-02-08 17:38:27 +00003888 EXPECT_EQ("{\n"
3889 "{\n"
3890 " a;\n"
3891 "b;\n"
3892 "}\n"
Daniel Jasper2ec3ffb82013-02-18 11:59:17 +00003893 "}",
3894 format("{\n"
3895 "{\n"
3896 " a;\n"
3897 "b;\n"
3898 "}\n"
3899 "}",
3900 9, 2, getLLVMStyle()));
Manuel Klimekb95f5452013-02-08 17:38:27 +00003901 EXPECT_EQ("{\n"
3902 "{\n"
3903 "public:\n"
3904 " b;\n"
3905 "}\n"
Daniel Jasper2ec3ffb82013-02-18 11:59:17 +00003906 "}",
3907 format("{\n"
3908 "{\n"
3909 "public:\n"
3910 " b;\n"
3911 "}\n"
3912 "}",
3913 17, 2, getLLVMStyle()));
Manuel Klimekb95f5452013-02-08 17:38:27 +00003914 EXPECT_EQ("{\n"
3915 "{\n"
3916 "a;\n"
3917 "}\n"
3918 "{\n"
Daniel Jasper12f9d8e2013-05-14 09:30:02 +00003919 " b; //\n"
Manuel Klimekb95f5452013-02-08 17:38:27 +00003920 "}\n"
Daniel Jasper2ec3ffb82013-02-18 11:59:17 +00003921 "}",
3922 format("{\n"
3923 "{\n"
3924 "a;\n"
3925 "}\n"
3926 "{\n"
Daniel Jasper12f9d8e2013-05-14 09:30:02 +00003927 " b; //\n"
Daniel Jasper2ec3ffb82013-02-18 11:59:17 +00003928 "}\n"
3929 "}",
3930 22, 2, getLLVMStyle()));
Manuel Klimekd076dcd2013-02-08 19:53:32 +00003931 EXPECT_EQ(" {\n"
Daniel Jasper12f9d8e2013-05-14 09:30:02 +00003932 " a; //\n"
Daniel Jasper2ec3ffb82013-02-18 11:59:17 +00003933 " }",
3934 format(" {\n"
Daniel Jasper12f9d8e2013-05-14 09:30:02 +00003935 "a; //\n"
Daniel Jasper2ec3ffb82013-02-18 11:59:17 +00003936 " }",
3937 4, 2, getLLVMStyle()));
Daniel Jasper22045622013-02-12 16:51:23 +00003938 EXPECT_EQ("void f() {}\n"
Daniel Jasper2ec3ffb82013-02-18 11:59:17 +00003939 "void g() {}",
3940 format("void f() {}\n"
3941 "void g() {}",
3942 13, 0, getLLVMStyle()));
Daniel Jasper66dc2ec2013-03-20 14:31:47 +00003943 EXPECT_EQ("int a; // comment\n"
3944 " // line 2\n"
3945 "int b;",
3946 format("int a; // comment\n"
3947 " // line 2\n"
3948 " int b;",
3949 35, 0, getLLVMStyle()));
Manuel Klimekd076dcd2013-02-08 19:53:32 +00003950}
Manuel Klimekb95f5452013-02-08 17:38:27 +00003951
Manuel Klimek1998ea22013-02-20 10:15:13 +00003952TEST_F(FormatTest, BreakStringLiterals) {
3953 EXPECT_EQ("\"some text \"\n"
3954 "\"other\";",
3955 format("\"some text other\";", getLLVMStyleWithColumns(12)));
Alexander Kornienko9e90b622013-04-17 17:34:05 +00003956 EXPECT_EQ("\"some text \"\n"
3957 "\"other\";",
3958 format("\\\n\"some text other\";", getLLVMStyleWithColumns(12)));
Manuel Klimek1998ea22013-02-20 10:15:13 +00003959 EXPECT_EQ(
3960 "#define A \\\n"
3961 " \"some \" \\\n"
3962 " \"text \" \\\n"
3963 " \"other\";",
3964 format("#define A \"some text other\";", getLLVMStyleWithColumns(12)));
3965 EXPECT_EQ(
3966 "#define A \\\n"
3967 " \"so \" \\\n"
3968 " \"text \" \\\n"
3969 " \"other\";",
3970 format("#define A \"so text other\";", getLLVMStyleWithColumns(12)));
3971
3972 EXPECT_EQ("\"some text\"",
3973 format("\"some text\"", getLLVMStyleWithColumns(1)));
3974 EXPECT_EQ("\"some text\"",
3975 format("\"some text\"", getLLVMStyleWithColumns(11)));
3976 EXPECT_EQ("\"some \"\n"
3977 "\"text\"",
3978 format("\"some text\"", getLLVMStyleWithColumns(10)));
3979 EXPECT_EQ("\"some \"\n"
3980 "\"text\"",
3981 format("\"some text\"", getLLVMStyleWithColumns(7)));
Manuel Klimekb176cff2013-03-01 13:14:08 +00003982 EXPECT_EQ("\"some\"\n"
Alexander Kornienkocb45bc12013-04-15 14:28:00 +00003983 "\" tex\"\n"
3984 "\"t\"",
Manuel Klimek1998ea22013-02-20 10:15:13 +00003985 format("\"some text\"", getLLVMStyleWithColumns(6)));
Manuel Klimekabf6e032013-03-04 20:03:38 +00003986 EXPECT_EQ("\"some\"\n"
3987 "\" tex\"\n"
3988 "\" and\"",
3989 format("\"some tex and\"", getLLVMStyleWithColumns(6)));
3990 EXPECT_EQ("\"some\"\n"
3991 "\"/tex\"\n"
3992 "\"/and\"",
3993 format("\"some/tex/and\"", getLLVMStyleWithColumns(6)));
Manuel Klimek1998ea22013-02-20 10:15:13 +00003994
3995 EXPECT_EQ("variable =\n"
3996 " \"long string \"\n"
3997 " \"literal\";",
3998 format("variable = \"long string literal\";",
3999 getLLVMStyleWithColumns(20)));
4000
4001 EXPECT_EQ("variable = f(\n"
4002 " \"long string \"\n"
Daniel Jasper2cf17bf2013-02-27 09:47:53 +00004003 " \"literal\",\n"
4004 " short,\n"
Manuel Klimek1998ea22013-02-20 10:15:13 +00004005 " loooooooooooooooooooong);",
4006 format("variable = f(\"long string literal\", short, "
4007 "loooooooooooooooooooong);",
4008 getLLVMStyleWithColumns(20)));
4009 EXPECT_EQ(
4010 "f(\"one two\".split(\n"
4011 " variable));",
4012 format("f(\"one two\".split(variable));", getLLVMStyleWithColumns(20)));
4013 EXPECT_EQ("f(\"one two three four five six \"\n"
4014 " \"seven\".split(\n"
4015 " really_looooong_variable));",
4016 format("f(\"one two three four five six seven\"."
4017 "split(really_looooong_variable));",
4018 getLLVMStyleWithColumns(33)));
4019
4020 EXPECT_EQ("f(\"some \"\n"
4021 " \"text\",\n"
4022 " other);",
4023 format("f(\"some text\", other);", getLLVMStyleWithColumns(10)));
Daniel Jasper5497fce2013-02-26 12:52:34 +00004024
4025 // Only break as a last resort.
4026 verifyFormat(
4027 "aaaaaaaaaaaaaaaaaaaa(\n"
4028 " aaaaaaaaaaaaaaaaaaaa,\n"
4029 " aaaaaa(\"aaa aaaaa aaa aaa aaaaa aaa aaaaa aaa aaa aaaaaa\"));");
Manuel Klimekb176cff2013-03-01 13:14:08 +00004030
4031 EXPECT_EQ(
4032 "\"splitmea\"\n"
Manuel Klimeke317d1b2013-03-01 13:29:19 +00004033 "\"trandomp\"\n"
4034 "\"oint\"",
Manuel Klimekb176cff2013-03-01 13:14:08 +00004035 format("\"splitmeatrandompoint\"", getLLVMStyleWithColumns(10)));
Manuel Klimeke317d1b2013-03-01 13:29:19 +00004036
4037 EXPECT_EQ(
4038 "\"split/\"\n"
4039 "\"pathat/\"\n"
4040 "\"slashes\"",
4041 format("\"split/pathat/slashes\"", getLLVMStyleWithColumns(10)));
Daniel Jasper6fe2f002013-04-25 08:56:26 +00004042
4043 FormatStyle AlignLeft = getLLVMStyleWithColumns(12);
4044 AlignLeft.AlignEscapedNewlinesLeft = true;
4045 EXPECT_EQ(
4046 "#define A \\\n"
4047 " \"some \" \\\n"
4048 " \"text \" \\\n"
4049 " \"other\";",
4050 format("#define A \"some text other\";", AlignLeft));
Manuel Klimek1998ea22013-02-20 10:15:13 +00004051}
4052
Manuel Klimek5ecb5fd2013-05-14 09:04:24 +00004053TEST_F(FormatTest, BreakStringLiteralsBeforeUnbreakableTokenSequence) {
4054 EXPECT_EQ("someFunction(\"aaabbbcccd\"\n"
4055 " \"ddeeefff\");",
4056 format("someFunction(\"aaabbbcccdddeeefff\");",
4057 getLLVMStyleWithColumns(25)));
4058 EXPECT_EQ("someFunction1234567890(\n"
4059 " \"aaabbbcccdddeeefff\");",
4060 format("someFunction1234567890(\"aaabbbcccdddeeefff\");",
4061 getLLVMStyleWithColumns(26)));
4062 EXPECT_EQ("someFunction1234567890(\n"
4063 " \"aaabbbcccdddeeeff\"\n"
4064 " \"f\");",
4065 format("someFunction1234567890(\"aaabbbcccdddeeefff\");",
4066 getLLVMStyleWithColumns(25)));
4067 EXPECT_EQ("someFunction1234567890(\n"
4068 " \"aaabbbcccdddeeeff\"\n"
4069 " \"f\");",
4070 format("someFunction1234567890(\"aaabbbcccdddeeefff\");",
4071 getLLVMStyleWithColumns(24)));
4072 EXPECT_EQ("someFunction(\n"
4073 " \"aaabbbcc \"\n"
4074 " \"dddeeefff\");",
4075 format("someFunction(\"aaabbbcc dddeeefff\");",
4076 getLLVMStyleWithColumns(25)));
4077 EXPECT_EQ("someFunction(\"aaabbbccc \"\n"
4078 " \"ddeeefff\");",
4079 format("someFunction(\"aaabbbccc ddeeefff\");",
4080 getLLVMStyleWithColumns(25)));
4081 EXPECT_EQ("someFunction1234567890(\n"
4082 " \"aaabb \"\n"
4083 " \"cccdddeeefff\");",
4084 format("someFunction1234567890(\"aaabb cccdddeeefff\");",
4085 getLLVMStyleWithColumns(25)));
4086 EXPECT_EQ("#define A \\\n"
4087 " string s = \\\n"
4088 " \"123456789\" \\\n"
4089 " \"0\"; \\\n"
4090 " int i;",
4091 format("#define A string s = \"1234567890\"; int i;",
4092 getLLVMStyleWithColumns(20)));
4093}
4094
Manuel Klimek5085d9b2013-03-08 18:59:48 +00004095TEST_F(FormatTest, DoNotBreakStringLiteralsInEscapeSequence) {
4096 EXPECT_EQ("\"\\a\"",
4097 format("\"\\a\"", getLLVMStyleWithColumns(3)));
4098 EXPECT_EQ("\"\\\"",
4099 format("\"\\\"", getLLVMStyleWithColumns(2)));
4100 EXPECT_EQ("\"test\"\n"
4101 "\"\\n\"",
4102 format("\"test\\n\"", getLLVMStyleWithColumns(7)));
4103 EXPECT_EQ("\"tes\\\\\"\n"
4104 "\"n\"",
4105 format("\"tes\\\\n\"", getLLVMStyleWithColumns(7)));
4106 EXPECT_EQ("\"\\\\\\\\\"\n"
4107 "\"\\n\"",
4108 format("\"\\\\\\\\\\n\"", getLLVMStyleWithColumns(7)));
4109 EXPECT_EQ("\"\\uff01\"",
4110 format("\"\\uff01\"", getLLVMStyleWithColumns(7)));
4111 EXPECT_EQ("\"\\uff01\"\n"
4112 "\"test\"",
4113 format("\"\\uff01test\"", getLLVMStyleWithColumns(8)));
4114 EXPECT_EQ("\"\\Uff01ff02\"",
4115 format("\"\\Uff01ff02\"", getLLVMStyleWithColumns(11)));
4116 EXPECT_EQ("\"\\x000000000001\"\n"
4117 "\"next\"",
4118 format("\"\\x000000000001next\"", getLLVMStyleWithColumns(16)));
4119 EXPECT_EQ("\"\\x000000000001next\"",
4120 format("\"\\x000000000001next\"", getLLVMStyleWithColumns(15)));
4121 EXPECT_EQ("\"\\x000000000001\"",
4122 format("\"\\x000000000001\"", getLLVMStyleWithColumns(7)));
4123 EXPECT_EQ("\"test\"\n"
4124 "\"\\000000\"\n"
4125 "\"000001\"",
4126 format("\"test\\000000000001\"", getLLVMStyleWithColumns(9)));
4127 EXPECT_EQ("\"test\\000\"\n"
Alexander Kornienkocb45bc12013-04-15 14:28:00 +00004128 "\"00000000\"\n"
4129 "\"1\"",
Manuel Klimek5085d9b2013-03-08 18:59:48 +00004130 format("\"test\\000000000001\"", getLLVMStyleWithColumns(10)));
4131 EXPECT_EQ("R\"(\\x\\x00)\"\n",
4132 format("R\"(\\x\\x00)\"\n", getLLVMStyleWithColumns(7)));
4133}
4134
Manuel Klimeka3ff45e2013-04-10 09:52:05 +00004135TEST_F(FormatTest, DoNotCreateUnreasonableUnwrappedLines) {
4136 verifyFormat("void f() {\n"
4137 " return g() {}\n"
4138 " void h() {}");
4139 verifyFormat("if (foo)\n"
4140 " return { forgot_closing_brace();\n"
4141 "test();");
4142 verifyFormat("int a[] = { void forgot_closing_brace()\n"
4143 "{\n"
4144 " f();\n"
4145 " g();\n"
4146 "}");
4147}
4148
Manuel Klimek13b97d82013-05-13 08:42:42 +00004149TEST_F(FormatTest, FormatsClosingBracesInEmptyNestedBlocks) {
4150 verifyFormat("class X {\n"
4151 " void f() {\n"
4152 " }\n"
4153 "};",
4154 getLLVMStyleWithColumns(12));
4155}
4156
4157TEST_F(FormatTest, ConfigurableIndentWidth) {
4158 FormatStyle EightIndent = getLLVMStyleWithColumns(18);
4159 EightIndent.IndentWidth = 8;
4160 verifyFormat("void f() {\n"
4161 " someFunction();\n"
4162 " if (true) {\n"
4163 " f();\n"
4164 " }\n"
4165 "}",
4166 EightIndent);
4167 verifyFormat("class X {\n"
4168 " void f() {\n"
4169 " }\n"
4170 "};",
4171 EightIndent);
4172 verifyFormat("int x[] = {\n"
4173 " call(),\n"
4174 " call(),\n"
4175 "};",
4176 EightIndent);
4177}
4178
Manuel Klimekb9eae4c2013-05-13 09:22:11 +00004179TEST_F(FormatTest, ConfigurableUseOfTab) {
4180 FormatStyle Tab = getLLVMStyleWithColumns(42);
4181 Tab.IndentWidth = 8;
4182 Tab.UseTab = true;
4183 Tab.AlignEscapedNewlinesLeft = true;
4184 verifyFormat("class X {\n"
4185 "\tvoid f() {\n"
4186 "\t\tsomeFunction(parameter1,\n"
4187 "\t\t\t parameter2);\n"
4188 "\t}\n"
4189 "};",
4190 Tab);
4191 verifyFormat("#define A \\\n"
4192 "\tvoid f() { \\\n"
4193 "\t\tsomeFunction( \\\n"
4194 "\t\t parameter1, \\\n"
4195 "\t\t parameter2); \\\n"
4196 "\t}",
4197 Tab);
4198}
4199
Manuel Klimeka8eb9142013-05-13 12:51:40 +00004200TEST_F(FormatTest, LinuxBraceBreaking) {
4201 FormatStyle BreakBeforeBrace = getLLVMStyle();
4202 BreakBeforeBrace.BreakBeforeBraces = FormatStyle::BS_Linux;
4203 verifyFormat("namespace a\n"
4204 "{\n"
4205 "class A\n"
4206 "{\n"
4207 " void f()\n"
4208 " {\n"
4209 " if (true) {\n"
4210 " a();\n"
4211 " b();\n"
4212 " }\n"
4213 " }\n"
Daniel Jasper00aca702013-05-15 08:30:06 +00004214 " void g()\n"
4215 " {\n"
4216 " return;\n"
4217 " }\n"
Manuel Klimeka8eb9142013-05-13 12:51:40 +00004218 "}\n"
4219 "}",
4220 BreakBeforeBrace);
4221}
4222
4223TEST_F(FormatTest, StroustrupBraceBreaking) {
4224 FormatStyle BreakBeforeBrace = getLLVMStyle();
4225 BreakBeforeBrace.BreakBeforeBraces = FormatStyle::BS_Stroustrup;
4226 verifyFormat("namespace a {\n"
4227 "class A {\n"
4228 " void f()\n"
4229 " {\n"
4230 " if (true) {\n"
4231 " a();\n"
4232 " b();\n"
4233 " }\n"
4234 " }\n"
Daniel Jasper00aca702013-05-15 08:30:06 +00004235 " void g()\n"
4236 " {\n"
4237 " return;\n"
4238 " }\n"
Manuel Klimeka8eb9142013-05-13 12:51:40 +00004239 "}\n"
4240 "}",
4241 BreakBeforeBrace);
4242}
4243
Alexander Kornienkod6538332013-05-07 15:32:14 +00004244bool allStylesEqual(ArrayRef<FormatStyle> Styles) {
4245 for (size_t i = 1; i < Styles.size(); ++i)
4246 if (!(Styles[0] == Styles[i]))
4247 return false;
4248 return true;
4249}
4250
4251TEST_F(FormatTest, GetsPredefinedStyleByName) {
Alexander Kornienko006b5c82013-05-19 00:53:30 +00004252 FormatStyle Styles[3];
Alexander Kornienkod6538332013-05-07 15:32:14 +00004253
Alexander Kornienko006b5c82013-05-19 00:53:30 +00004254 Styles[0] = getLLVMStyle();
4255 EXPECT_TRUE(getPredefinedStyle("LLVM", &Styles[1]));
4256 EXPECT_TRUE(getPredefinedStyle("lLvM", &Styles[2]));
4257 EXPECT_TRUE(allStylesEqual(Styles));
Alexander Kornienkod6538332013-05-07 15:32:14 +00004258
Alexander Kornienko006b5c82013-05-19 00:53:30 +00004259 Styles[0] = getGoogleStyle();
4260 EXPECT_TRUE(getPredefinedStyle("Google", &Styles[1]));
4261 EXPECT_TRUE(getPredefinedStyle("gOOgle", &Styles[2]));
4262 EXPECT_TRUE(allStylesEqual(Styles));
Alexander Kornienkod6538332013-05-07 15:32:14 +00004263
Alexander Kornienko006b5c82013-05-19 00:53:30 +00004264 Styles[0] = getChromiumStyle();
4265 EXPECT_TRUE(getPredefinedStyle("Chromium", &Styles[1]));
4266 EXPECT_TRUE(getPredefinedStyle("cHRoMiUM", &Styles[2]));
4267 EXPECT_TRUE(allStylesEqual(Styles));
4268
4269 Styles[0] = getMozillaStyle();
4270 EXPECT_TRUE(getPredefinedStyle("Mozilla", &Styles[1]));
4271 EXPECT_TRUE(getPredefinedStyle("moZILla", &Styles[2]));
4272 EXPECT_TRUE(allStylesEqual(Styles));
4273
4274 EXPECT_FALSE(getPredefinedStyle("qwerty", &Styles[0]));
Alexander Kornienkod6538332013-05-07 15:32:14 +00004275}
4276
4277TEST_F(FormatTest, ParsesConfiguration) {
4278 FormatStyle Style = {};
4279#define CHECK_PARSE(TEXT, FIELD, VALUE) \
4280 EXPECT_NE(VALUE, Style.FIELD); \
4281 EXPECT_EQ(0, parseConfiguration(TEXT, &Style).value()); \
4282 EXPECT_EQ(VALUE, Style.FIELD)
4283
4284#define CHECK_PARSE_BOOL(FIELD) \
4285 Style.FIELD = false; \
4286 EXPECT_EQ(0, parseConfiguration(#FIELD ": true", &Style).value()); \
Alexander Kornienko006b5c82013-05-19 00:53:30 +00004287 EXPECT_TRUE(Style.FIELD); \
Alexander Kornienkod6538332013-05-07 15:32:14 +00004288 EXPECT_EQ(0, parseConfiguration(#FIELD ": false", &Style).value()); \
Patrik Hagglund76aca642013-05-14 07:53:53 +00004289 EXPECT_FALSE(Style.FIELD);
Alexander Kornienkod6538332013-05-07 15:32:14 +00004290
4291 CHECK_PARSE_BOOL(AlignEscapedNewlinesLeft);
4292 CHECK_PARSE_BOOL(AllowAllParametersOfDeclarationOnNextLine);
4293 CHECK_PARSE_BOOL(AllowShortIfStatementsOnASingleLine);
Daniel Jasper997af662013-05-16 12:16:23 +00004294 CHECK_PARSE_BOOL(AllowShortLoopsOnASingleLine);
Alexander Kornienkod6538332013-05-07 15:32:14 +00004295 CHECK_PARSE_BOOL(BinPackParameters);
4296 CHECK_PARSE_BOOL(ConstructorInitializerAllOnOneLineOrOnePerLine);
4297 CHECK_PARSE_BOOL(DerivePointerBinding);
4298 CHECK_PARSE_BOOL(IndentCaseLabels);
4299 CHECK_PARSE_BOOL(ObjCSpaceBeforeProtocolList);
4300 CHECK_PARSE_BOOL(PointerBindsToType);
Manuel Klimekb9eae4c2013-05-13 09:22:11 +00004301 CHECK_PARSE_BOOL(UseTab);
Alexander Kornienkod6538332013-05-07 15:32:14 +00004302
4303 CHECK_PARSE("AccessModifierOffset: -1234", AccessModifierOffset, -1234);
4304 CHECK_PARSE("ColumnLimit: 1234", ColumnLimit, 1234u);
4305 CHECK_PARSE("MaxEmptyLinesToKeep: 1234", MaxEmptyLinesToKeep, 1234u);
4306 CHECK_PARSE("PenaltyExcessCharacter: 1234", PenaltyExcessCharacter, 1234u);
4307 CHECK_PARSE("PenaltyReturnTypeOnItsOwnLine: 1234",
4308 PenaltyReturnTypeOnItsOwnLine, 1234u);
4309 CHECK_PARSE("SpacesBeforeTrailingComments: 1234",
4310 SpacesBeforeTrailingComments, 1234u);
Manuel Klimek13b97d82013-05-13 08:42:42 +00004311 CHECK_PARSE("IndentWidth: 32", IndentWidth, 32u);
Alexander Kornienkod6538332013-05-07 15:32:14 +00004312
4313 Style.Standard = FormatStyle::LS_Auto;
4314 CHECK_PARSE("Standard: C++03", Standard, FormatStyle::LS_Cpp03);
4315 CHECK_PARSE("Standard: C++11", Standard, FormatStyle::LS_Cpp11);
4316 CHECK_PARSE("Standard: Auto", Standard, FormatStyle::LS_Auto);
4317
4318 Style.ColumnLimit = 123;
4319 FormatStyle BaseStyle = getLLVMStyle();
4320 CHECK_PARSE("BasedOnStyle: LLVM", ColumnLimit, BaseStyle.ColumnLimit);
4321 CHECK_PARSE("BasedOnStyle: LLVM\nColumnLimit: 1234", ColumnLimit, 1234u);
4322
Manuel Klimeka8eb9142013-05-13 12:51:40 +00004323 Style.BreakBeforeBraces = FormatStyle::BS_Stroustrup;
4324 CHECK_PARSE("BreakBeforeBraces: Attach", BreakBeforeBraces,
4325 FormatStyle::BS_Attach);
4326 CHECK_PARSE("BreakBeforeBraces: Linux", BreakBeforeBraces,
4327 FormatStyle::BS_Linux);
4328 CHECK_PARSE("BreakBeforeBraces: Stroustrup", BreakBeforeBraces,
4329 FormatStyle::BS_Stroustrup);
4330
Alexander Kornienkod6538332013-05-07 15:32:14 +00004331#undef CHECK_PARSE
4332#undef CHECK_PARSE_BOOL
4333}
4334
4335TEST_F(FormatTest, ConfigurationRoundTripTest) {
4336 FormatStyle Style = getLLVMStyle();
4337 std::string YAML = configurationAsText(Style);
4338 FormatStyle ParsedStyle = {};
4339 EXPECT_EQ(0, parseConfiguration(YAML, &ParsedStyle).value());
4340 EXPECT_EQ(Style, ParsedStyle);
4341}
4342
Daniel Jasper8d1832e2013-01-07 13:26:07 +00004343} // end namespace tooling
4344} // end namespace clang