blob: 224e3321926b8926ca9d6ac9fd4f4cb01d00196e [file] [log] [blame]
Chris Lattnera65e2f72010-01-05 05:57:49 +00001//===- InstCombineLoadStoreAlloca.cpp -------------------------------------===//
2//
3// The LLVM Compiler Infrastructure
4//
5// This file is distributed under the University of Illinois Open Source
6// License. See LICENSE.TXT for details.
7//
8//===----------------------------------------------------------------------===//
9//
10// This file implements the visit functions for load, store and alloca.
11//
12//===----------------------------------------------------------------------===//
13
Chandler Carrutha9174582015-01-22 05:25:13 +000014#include "InstCombineInternal.h"
Chandler Carruthed0881b2012-12-03 16:50:05 +000015#include "llvm/ADT/Statistic.h"
Dan Gohman826bdf82010-05-28 16:19:17 +000016#include "llvm/Analysis/Loads.h"
Chandler Carruth9fb823b2013-01-02 11:36:10 +000017#include "llvm/IR/DataLayout.h"
Chandler Carruthbc6378d2014-10-19 10:46:46 +000018#include "llvm/IR/LLVMContext.h"
Chandler Carruth9fb823b2013-01-02 11:36:10 +000019#include "llvm/IR/IntrinsicInst.h"
Charles Davis33d1dc02015-02-25 05:10:25 +000020#include "llvm/IR/MDBuilder.h"
Chris Lattnera65e2f72010-01-05 05:57:49 +000021#include "llvm/Transforms/Utils/BasicBlockUtils.h"
22#include "llvm/Transforms/Utils/Local.h"
Chris Lattnera65e2f72010-01-05 05:57:49 +000023using namespace llvm;
24
Chandler Carruth964daaa2014-04-22 02:55:47 +000025#define DEBUG_TYPE "instcombine"
26
Chandler Carruthc908ca12012-08-21 08:39:44 +000027STATISTIC(NumDeadStore, "Number of dead stores eliminated");
28STATISTIC(NumGlobalCopies, "Number of allocas copied from constant global");
29
30/// pointsToConstantGlobal - Return true if V (possibly indirectly) points to
31/// some part of a constant global variable. This intentionally only accepts
32/// constant expressions because we can't rewrite arbitrary instructions.
33static bool pointsToConstantGlobal(Value *V) {
34 if (GlobalVariable *GV = dyn_cast<GlobalVariable>(V))
35 return GV->isConstant();
Matt Arsenault607281772014-04-24 00:01:09 +000036
37 if (ConstantExpr *CE = dyn_cast<ConstantExpr>(V)) {
Chandler Carruthc908ca12012-08-21 08:39:44 +000038 if (CE->getOpcode() == Instruction::BitCast ||
Matt Arsenault607281772014-04-24 00:01:09 +000039 CE->getOpcode() == Instruction::AddrSpaceCast ||
Chandler Carruthc908ca12012-08-21 08:39:44 +000040 CE->getOpcode() == Instruction::GetElementPtr)
41 return pointsToConstantGlobal(CE->getOperand(0));
Matt Arsenault607281772014-04-24 00:01:09 +000042 }
Chandler Carruthc908ca12012-08-21 08:39:44 +000043 return false;
44}
45
46/// isOnlyCopiedFromConstantGlobal - Recursively walk the uses of a (derived)
47/// pointer to an alloca. Ignore any reads of the pointer, return false if we
48/// see any stores or other unknown uses. If we see pointer arithmetic, keep
49/// track of whether it moves the pointer (with IsOffset) but otherwise traverse
50/// the uses. If we see a memcpy/memmove that targets an unoffseted pointer to
51/// the alloca, and if the source pointer is a pointer to a constant global, we
52/// can optimize this.
53static bool
54isOnlyCopiedFromConstantGlobal(Value *V, MemTransferInst *&TheCopy,
Reid Kleckner813dab22014-07-01 21:36:20 +000055 SmallVectorImpl<Instruction *> &ToDelete) {
Chandler Carruthc908ca12012-08-21 08:39:44 +000056 // We track lifetime intrinsics as we encounter them. If we decide to go
57 // ahead and replace the value with the global, this lets the caller quickly
58 // eliminate the markers.
59
Reid Kleckner813dab22014-07-01 21:36:20 +000060 SmallVector<std::pair<Value *, bool>, 35> ValuesToInspect;
61 ValuesToInspect.push_back(std::make_pair(V, false));
62 while (!ValuesToInspect.empty()) {
63 auto ValuePair = ValuesToInspect.pop_back_val();
64 const bool IsOffset = ValuePair.second;
65 for (auto &U : ValuePair.first->uses()) {
66 Instruction *I = cast<Instruction>(U.getUser());
Chandler Carruthc908ca12012-08-21 08:39:44 +000067
Reid Kleckner813dab22014-07-01 21:36:20 +000068 if (LoadInst *LI = dyn_cast<LoadInst>(I)) {
69 // Ignore non-volatile loads, they are always ok.
70 if (!LI->isSimple()) return false;
Chandler Carruthc908ca12012-08-21 08:39:44 +000071 continue;
72 }
Reid Kleckner813dab22014-07-01 21:36:20 +000073
74 if (isa<BitCastInst>(I) || isa<AddrSpaceCastInst>(I)) {
75 // If uses of the bitcast are ok, we are ok.
76 ValuesToInspect.push_back(std::make_pair(I, IsOffset));
77 continue;
78 }
79 if (GetElementPtrInst *GEP = dyn_cast<GetElementPtrInst>(I)) {
80 // If the GEP has all zero indices, it doesn't offset the pointer. If it
81 // doesn't, it does.
82 ValuesToInspect.push_back(
83 std::make_pair(I, IsOffset || !GEP->hasAllZeroIndices()));
84 continue;
85 }
86
Benjamin Kramer3a09ef62015-04-10 14:50:08 +000087 if (auto CS = CallSite(I)) {
Reid Kleckner813dab22014-07-01 21:36:20 +000088 // If this is the function being called then we treat it like a load and
89 // ignore it.
90 if (CS.isCallee(&U))
91 continue;
92
93 // Inalloca arguments are clobbered by the call.
94 unsigned ArgNo = CS.getArgumentNo(&U);
95 if (CS.isInAllocaArgument(ArgNo))
96 return false;
97
98 // If this is a readonly/readnone call site, then we know it is just a
99 // load (but one that potentially returns the value itself), so we can
100 // ignore it if we know that the value isn't captured.
101 if (CS.onlyReadsMemory() &&
102 (CS.getInstruction()->use_empty() || CS.doesNotCapture(ArgNo)))
103 continue;
104
105 // If this is being passed as a byval argument, the caller is making a
106 // copy, so it is only a read of the alloca.
107 if (CS.isByValArgument(ArgNo))
108 continue;
109 }
110
111 // Lifetime intrinsics can be handled by the caller.
112 if (IntrinsicInst *II = dyn_cast<IntrinsicInst>(I)) {
113 if (II->getIntrinsicID() == Intrinsic::lifetime_start ||
114 II->getIntrinsicID() == Intrinsic::lifetime_end) {
115 assert(II->use_empty() && "Lifetime markers have no result to use!");
116 ToDelete.push_back(II);
117 continue;
118 }
119 }
120
121 // If this is isn't our memcpy/memmove, reject it as something we can't
122 // handle.
123 MemTransferInst *MI = dyn_cast<MemTransferInst>(I);
124 if (!MI)
125 return false;
126
127 // If the transfer is using the alloca as a source of the transfer, then
128 // ignore it since it is a load (unless the transfer is volatile).
129 if (U.getOperandNo() == 1) {
130 if (MI->isVolatile()) return false;
131 continue;
132 }
133
134 // If we already have seen a copy, reject the second one.
135 if (TheCopy) return false;
136
137 // If the pointer has been offset from the start of the alloca, we can't
138 // safely handle this.
139 if (IsOffset) return false;
140
141 // If the memintrinsic isn't using the alloca as the dest, reject it.
142 if (U.getOperandNo() != 0) return false;
143
144 // If the source of the memcpy/move is not a constant global, reject it.
145 if (!pointsToConstantGlobal(MI->getSource()))
146 return false;
147
148 // Otherwise, the transform is safe. Remember the copy instruction.
149 TheCopy = MI;
Chandler Carruthc908ca12012-08-21 08:39:44 +0000150 }
Chandler Carruthc908ca12012-08-21 08:39:44 +0000151 }
152 return true;
153}
154
155/// isOnlyCopiedFromConstantGlobal - Return true if the specified alloca is only
156/// modified by a copy from a constant global. If we can prove this, we can
157/// replace any uses of the alloca with uses of the global directly.
158static MemTransferInst *
159isOnlyCopiedFromConstantGlobal(AllocaInst *AI,
160 SmallVectorImpl<Instruction *> &ToDelete) {
Craig Topperf40110f2014-04-25 05:29:35 +0000161 MemTransferInst *TheCopy = nullptr;
Chandler Carruthc908ca12012-08-21 08:39:44 +0000162 if (isOnlyCopiedFromConstantGlobal(AI, TheCopy, ToDelete))
163 return TheCopy;
Craig Topperf40110f2014-04-25 05:29:35 +0000164 return nullptr;
Chandler Carruthc908ca12012-08-21 08:39:44 +0000165}
166
Duncan P. N. Exon Smithc6820ec2015-03-13 19:22:03 +0000167static Instruction *simplifyAllocaArraySize(InstCombiner &IC, AllocaInst &AI) {
Duncan P. N. Exon Smith720762e2015-03-13 19:30:44 +0000168 // Check for array size of 1 (scalar allocation).
Duncan P. N. Exon Smithbe95b4a2015-03-13 19:42:09 +0000169 if (!AI.isArrayAllocation()) {
170 // i32 1 is the canonical array size for scalar allocations.
171 if (AI.getArraySize()->getType()->isIntegerTy(32))
172 return nullptr;
173
174 // Canonicalize it.
175 Value *V = IC.Builder->getInt32(1);
176 AI.setOperand(0, V);
177 return &AI;
178 }
Duncan P. N. Exon Smith720762e2015-03-13 19:30:44 +0000179
Chris Lattnera65e2f72010-01-05 05:57:49 +0000180 // Convert: alloca Ty, C - where C is a constant != 1 into: alloca [C x Ty], 1
Duncan P. N. Exon Smithbb730132015-03-13 19:26:33 +0000181 if (const ConstantInt *C = dyn_cast<ConstantInt>(AI.getArraySize())) {
182 Type *NewTy = ArrayType::get(AI.getAllocatedType(), C->getZExtValue());
183 AllocaInst *New = IC.Builder->CreateAlloca(NewTy, nullptr, AI.getName());
184 New->setAlignment(AI.getAlignment());
Chris Lattnera65e2f72010-01-05 05:57:49 +0000185
Duncan P. N. Exon Smithbb730132015-03-13 19:26:33 +0000186 // Scan to the end of the allocation instructions, to skip over a block of
187 // allocas if possible...also skip interleaved debug info
188 //
189 BasicBlock::iterator It = New;
190 while (isa<AllocaInst>(*It) || isa<DbgInfoIntrinsic>(*It))
191 ++It;
Chris Lattnera65e2f72010-01-05 05:57:49 +0000192
Duncan P. N. Exon Smithbb730132015-03-13 19:26:33 +0000193 // Now that I is pointing to the first non-allocation-inst in the block,
194 // insert our getelementptr instruction...
195 //
196 Type *IdxTy = IC.getDataLayout().getIntPtrType(AI.getType());
197 Value *NullIdx = Constant::getNullValue(IdxTy);
198 Value *Idx[2] = {NullIdx, NullIdx};
199 Instruction *GEP =
Matt Arsenault640ff9d2013-08-14 00:24:05 +0000200 GetElementPtrInst::CreateInBounds(New, Idx, New->getName() + ".sub");
Duncan P. N. Exon Smithbb730132015-03-13 19:26:33 +0000201 IC.InsertNewInstBefore(GEP, *It);
Chris Lattnera65e2f72010-01-05 05:57:49 +0000202
Duncan P. N. Exon Smithbb730132015-03-13 19:26:33 +0000203 // Now make everything use the getelementptr instead of the original
204 // allocation.
205 return IC.ReplaceInstUsesWith(AI, GEP);
Chris Lattnera65e2f72010-01-05 05:57:49 +0000206 }
207
Duncan P. N. Exon Smithbb730132015-03-13 19:26:33 +0000208 if (isa<UndefValue>(AI.getArraySize()))
209 return IC.ReplaceInstUsesWith(AI, Constant::getNullValue(AI.getType()));
210
Duncan P. N. Exon Smith07ff9b02015-03-13 19:34:55 +0000211 // Ensure that the alloca array size argument has type intptr_t, so that
212 // any casting is exposed early.
213 Type *IntPtrTy = IC.getDataLayout().getIntPtrType(AI.getType());
214 if (AI.getArraySize()->getType() != IntPtrTy) {
215 Value *V = IC.Builder->CreateIntCast(AI.getArraySize(), IntPtrTy, false);
216 AI.setOperand(0, V);
217 return &AI;
218 }
219
Duncan P. N. Exon Smithc6820ec2015-03-13 19:22:03 +0000220 return nullptr;
221}
222
223Instruction *InstCombiner::visitAllocaInst(AllocaInst &AI) {
224 if (auto *I = simplifyAllocaArraySize(*this, AI))
225 return I;
226
Mehdi Aminia28d91d2015-03-10 02:37:25 +0000227 if (AI.getAllocatedType()->isSized()) {
Chris Lattnera65e2f72010-01-05 05:57:49 +0000228 // If the alignment is 0 (unspecified), assign it the preferred alignment.
229 if (AI.getAlignment() == 0)
Mehdi Aminia28d91d2015-03-10 02:37:25 +0000230 AI.setAlignment(DL.getPrefTypeAlignment(AI.getAllocatedType()));
Duncan Sands8bc764a2012-06-26 13:39:21 +0000231
232 // Move all alloca's of zero byte objects to the entry block and merge them
233 // together. Note that we only do this for alloca's, because malloc should
234 // allocate and return a unique pointer, even for a zero byte allocation.
Mehdi Aminia28d91d2015-03-10 02:37:25 +0000235 if (DL.getTypeAllocSize(AI.getAllocatedType()) == 0) {
Duncan Sands8bc764a2012-06-26 13:39:21 +0000236 // For a zero sized alloca there is no point in doing an array allocation.
237 // This is helpful if the array size is a complicated expression not used
238 // elsewhere.
239 if (AI.isArrayAllocation()) {
240 AI.setOperand(0, ConstantInt::get(AI.getArraySize()->getType(), 1));
241 return &AI;
242 }
243
244 // Get the first instruction in the entry block.
245 BasicBlock &EntryBlock = AI.getParent()->getParent()->getEntryBlock();
246 Instruction *FirstInst = EntryBlock.getFirstNonPHIOrDbg();
247 if (FirstInst != &AI) {
248 // If the entry block doesn't start with a zero-size alloca then move
249 // this one to the start of the entry block. There is no problem with
250 // dominance as the array size was forced to a constant earlier already.
251 AllocaInst *EntryAI = dyn_cast<AllocaInst>(FirstInst);
252 if (!EntryAI || !EntryAI->getAllocatedType()->isSized() ||
Mehdi Aminia28d91d2015-03-10 02:37:25 +0000253 DL.getTypeAllocSize(EntryAI->getAllocatedType()) != 0) {
Duncan Sands8bc764a2012-06-26 13:39:21 +0000254 AI.moveBefore(FirstInst);
255 return &AI;
256 }
257
Richard Osborneb68053e2012-09-18 09:31:44 +0000258 // If the alignment of the entry block alloca is 0 (unspecified),
259 // assign it the preferred alignment.
260 if (EntryAI->getAlignment() == 0)
261 EntryAI->setAlignment(
Mehdi Aminia28d91d2015-03-10 02:37:25 +0000262 DL.getPrefTypeAlignment(EntryAI->getAllocatedType()));
Duncan Sands8bc764a2012-06-26 13:39:21 +0000263 // Replace this zero-sized alloca with the one at the start of the entry
264 // block after ensuring that the address will be aligned enough for both
265 // types.
Richard Osborneb68053e2012-09-18 09:31:44 +0000266 unsigned MaxAlign = std::max(EntryAI->getAlignment(),
267 AI.getAlignment());
Duncan Sands8bc764a2012-06-26 13:39:21 +0000268 EntryAI->setAlignment(MaxAlign);
269 if (AI.getType() != EntryAI->getType())
270 return new BitCastInst(EntryAI, AI.getType());
271 return ReplaceInstUsesWith(AI, EntryAI);
272 }
273 }
Chris Lattnera65e2f72010-01-05 05:57:49 +0000274 }
275
Eli Friedmanb14873c2012-11-26 23:04:53 +0000276 if (AI.getAlignment()) {
Richard Osborne2fd29bf2012-09-24 17:10:03 +0000277 // Check to see if this allocation is only modified by a memcpy/memmove from
278 // a constant global whose alignment is equal to or exceeds that of the
279 // allocation. If this is the case, we can change all users to use
280 // the constant global instead. This is commonly produced by the CFE by
281 // constructs like "void foo() { int A[] = {1,2,3,4,5,6,7,8,9...}; }" if 'A'
282 // is only subsequently read.
283 SmallVector<Instruction *, 4> ToDelete;
284 if (MemTransferInst *Copy = isOnlyCopiedFromConstantGlobal(&AI, ToDelete)) {
Chandler Carruth66b31302015-01-04 12:03:27 +0000285 unsigned SourceAlign = getOrEnforceKnownAlignment(
Mehdi Aminia28d91d2015-03-10 02:37:25 +0000286 Copy->getSource(), AI.getAlignment(), DL, &AI, AC, DT);
Eli Friedmanb14873c2012-11-26 23:04:53 +0000287 if (AI.getAlignment() <= SourceAlign) {
Richard Osborne2fd29bf2012-09-24 17:10:03 +0000288 DEBUG(dbgs() << "Found alloca equal to global: " << AI << '\n');
289 DEBUG(dbgs() << " memcpy = " << *Copy << '\n');
290 for (unsigned i = 0, e = ToDelete.size(); i != e; ++i)
291 EraseInstFromFunction(*ToDelete[i]);
292 Constant *TheSrc = cast<Constant>(Copy->getSource());
Matt Arsenaultbbf18c62013-12-07 02:58:45 +0000293 Constant *Cast
294 = ConstantExpr::getPointerBitCastOrAddrSpaceCast(TheSrc, AI.getType());
295 Instruction *NewI = ReplaceInstUsesWith(AI, Cast);
Richard Osborne2fd29bf2012-09-24 17:10:03 +0000296 EraseInstFromFunction(*Copy);
297 ++NumGlobalCopies;
298 return NewI;
299 }
Chandler Carruthc908ca12012-08-21 08:39:44 +0000300 }
301 }
302
Nuno Lopes95cc4f32012-07-09 18:38:20 +0000303 // At last, use the generic allocation site handler to aggressively remove
304 // unused allocas.
305 return visitAllocSite(AI);
Chris Lattnera65e2f72010-01-05 05:57:49 +0000306}
307
Chandler Carruthbc6378d2014-10-19 10:46:46 +0000308/// \brief Helper to combine a load to a new type.
309///
310/// This just does the work of combining a load to a new type. It handles
311/// metadata, etc., and returns the new instruction. The \c NewTy should be the
312/// loaded *value* type. This will convert it to a pointer, cast the operand to
313/// that pointer type, load it, etc.
314///
315/// Note that this will create all of the instructions with whatever insert
316/// point the \c InstCombiner currently is using.
Mehdi Amini2668a482015-05-07 05:52:40 +0000317static LoadInst *combineLoadToNewType(InstCombiner &IC, LoadInst &LI, Type *NewTy,
318 const Twine &Suffix = "") {
Chandler Carruthbc6378d2014-10-19 10:46:46 +0000319 Value *Ptr = LI.getPointerOperand();
320 unsigned AS = LI.getPointerAddressSpace();
Duncan P. N. Exon Smithde36e802014-11-11 21:30:22 +0000321 SmallVector<std::pair<unsigned, MDNode *>, 8> MD;
Chandler Carruthbc6378d2014-10-19 10:46:46 +0000322 LI.getAllMetadata(MD);
323
324 LoadInst *NewLoad = IC.Builder->CreateAlignedLoad(
325 IC.Builder->CreateBitCast(Ptr, NewTy->getPointerTo(AS)),
Mehdi Amini2668a482015-05-07 05:52:40 +0000326 LI.getAlignment(), LI.getName() + Suffix);
Charles Davis33d1dc02015-02-25 05:10:25 +0000327 MDBuilder MDB(NewLoad->getContext());
Chandler Carruthbc6378d2014-10-19 10:46:46 +0000328 for (const auto &MDPair : MD) {
329 unsigned ID = MDPair.first;
Duncan P. N. Exon Smithde36e802014-11-11 21:30:22 +0000330 MDNode *N = MDPair.second;
Chandler Carruthbc6378d2014-10-19 10:46:46 +0000331 // Note, essentially every kind of metadata should be preserved here! This
332 // routine is supposed to clone a load instruction changing *only its type*.
333 // The only metadata it makes sense to drop is metadata which is invalidated
334 // when the pointer type changes. This should essentially never be the case
335 // in LLVM, but we explicitly switch over only known metadata to be
336 // conservatively correct. If you are adding metadata to LLVM which pertains
337 // to loads, you almost certainly want to add it here.
338 switch (ID) {
339 case LLVMContext::MD_dbg:
340 case LLVMContext::MD_tbaa:
341 case LLVMContext::MD_prof:
342 case LLVMContext::MD_fpmath:
343 case LLVMContext::MD_tbaa_struct:
344 case LLVMContext::MD_invariant_load:
345 case LLVMContext::MD_alias_scope:
346 case LLVMContext::MD_noalias:
Philip Reames5a3f5f72014-10-21 00:13:20 +0000347 case LLVMContext::MD_nontemporal:
348 case LLVMContext::MD_mem_parallel_loop_access:
Chandler Carruthbc6378d2014-10-19 10:46:46 +0000349 // All of these directly apply.
350 NewLoad->setMetadata(ID, N);
351 break;
352
Chandler Carruth87fdafc2015-02-13 02:30:01 +0000353 case LLVMContext::MD_nonnull:
Charles Davis33d1dc02015-02-25 05:10:25 +0000354 // This only directly applies if the new type is also a pointer.
355 if (NewTy->isPointerTy()) {
Chandler Carruth87fdafc2015-02-13 02:30:01 +0000356 NewLoad->setMetadata(ID, N);
Charles Davis33d1dc02015-02-25 05:10:25 +0000357 break;
358 }
359 // If it's integral now, translate it to !range metadata.
360 if (NewTy->isIntegerTy()) {
361 auto *ITy = cast<IntegerType>(NewTy);
362 auto *NullInt = ConstantExpr::getPtrToInt(
363 ConstantPointerNull::get(cast<PointerType>(Ptr->getType())), ITy);
364 auto *NonNullInt =
365 ConstantExpr::getAdd(NullInt, ConstantInt::get(ITy, 1));
366 NewLoad->setMetadata(LLVMContext::MD_range,
367 MDB.createRange(NonNullInt, NullInt));
368 }
Chandler Carruth87fdafc2015-02-13 02:30:01 +0000369 break;
370
Chandler Carruthbc6378d2014-10-19 10:46:46 +0000371 case LLVMContext::MD_range:
372 // FIXME: It would be nice to propagate this in some way, but the type
Charles Davis33d1dc02015-02-25 05:10:25 +0000373 // conversions make it hard. If the new type is a pointer, we could
374 // translate it to !nonnull metadata.
Chandler Carruthbc6378d2014-10-19 10:46:46 +0000375 break;
376 }
377 }
Chandler Carruthbc6378d2014-10-19 10:46:46 +0000378 return NewLoad;
379}
380
Chandler Carruthfa11d832015-01-22 03:34:54 +0000381/// \brief Combine a store to a new type.
382///
383/// Returns the newly created store instruction.
384static StoreInst *combineStoreToNewValue(InstCombiner &IC, StoreInst &SI, Value *V) {
385 Value *Ptr = SI.getPointerOperand();
386 unsigned AS = SI.getPointerAddressSpace();
387 SmallVector<std::pair<unsigned, MDNode *>, 8> MD;
388 SI.getAllMetadata(MD);
389
390 StoreInst *NewStore = IC.Builder->CreateAlignedStore(
391 V, IC.Builder->CreateBitCast(Ptr, V->getType()->getPointerTo(AS)),
392 SI.getAlignment());
393 for (const auto &MDPair : MD) {
394 unsigned ID = MDPair.first;
395 MDNode *N = MDPair.second;
396 // Note, essentially every kind of metadata should be preserved here! This
397 // routine is supposed to clone a store instruction changing *only its
398 // type*. The only metadata it makes sense to drop is metadata which is
399 // invalidated when the pointer type changes. This should essentially
400 // never be the case in LLVM, but we explicitly switch over only known
401 // metadata to be conservatively correct. If you are adding metadata to
402 // LLVM which pertains to stores, you almost certainly want to add it
403 // here.
404 switch (ID) {
405 case LLVMContext::MD_dbg:
406 case LLVMContext::MD_tbaa:
407 case LLVMContext::MD_prof:
408 case LLVMContext::MD_fpmath:
409 case LLVMContext::MD_tbaa_struct:
410 case LLVMContext::MD_alias_scope:
411 case LLVMContext::MD_noalias:
412 case LLVMContext::MD_nontemporal:
413 case LLVMContext::MD_mem_parallel_loop_access:
Chandler Carruthfa11d832015-01-22 03:34:54 +0000414 // All of these directly apply.
415 NewStore->setMetadata(ID, N);
416 break;
417
418 case LLVMContext::MD_invariant_load:
Chandler Carruth87fdafc2015-02-13 02:30:01 +0000419 case LLVMContext::MD_nonnull:
Chandler Carruthfa11d832015-01-22 03:34:54 +0000420 case LLVMContext::MD_range:
Chandler Carruth87fdafc2015-02-13 02:30:01 +0000421 // These don't apply for stores.
Chandler Carruthfa11d832015-01-22 03:34:54 +0000422 break;
423 }
424 }
425
426 return NewStore;
427}
428
Chandler Carruth2f75fcf2014-10-18 06:36:22 +0000429/// \brief Combine loads to match the type of value their uses after looking
430/// through intervening bitcasts.
431///
432/// The core idea here is that if the result of a load is used in an operation,
433/// we should load the type most conducive to that operation. For example, when
434/// loading an integer and converting that immediately to a pointer, we should
435/// instead directly load a pointer.
436///
437/// However, this routine must never change the width of a load or the number of
438/// loads as that would introduce a semantic change. This combine is expected to
439/// be a semantic no-op which just allows loads to more closely model the types
440/// of their consuming operations.
441///
442/// Currently, we also refuse to change the precise type used for an atomic load
443/// or a volatile load. This is debatable, and might be reasonable to change
444/// later. However, it is risky in case some backend or other part of LLVM is
445/// relying on the exact type loaded to select appropriate atomic operations.
446static Instruction *combineLoadToOperationType(InstCombiner &IC, LoadInst &LI) {
447 // FIXME: We could probably with some care handle both volatile and atomic
448 // loads here but it isn't clear that this is important.
449 if (!LI.isSimple())
450 return nullptr;
Chris Lattnera65e2f72010-01-05 05:57:49 +0000451
Chandler Carruth2f75fcf2014-10-18 06:36:22 +0000452 if (LI.use_empty())
453 return nullptr;
Chris Lattnera65e2f72010-01-05 05:57:49 +0000454
Chandler Carruthcd8522e2015-01-22 05:08:12 +0000455 Type *Ty = LI.getType();
Mehdi Aminia28d91d2015-03-10 02:37:25 +0000456 const DataLayout &DL = IC.getDataLayout();
Chandler Carruthcd8522e2015-01-22 05:08:12 +0000457
458 // Try to canonicalize loads which are only ever stored to operate over
459 // integers instead of any other type. We only do this when the loaded type
460 // is sized and has a size exactly the same as its store size and the store
461 // size is a legal integer type.
Mehdi Aminia28d91d2015-03-10 02:37:25 +0000462 if (!Ty->isIntegerTy() && Ty->isSized() &&
463 DL.isLegalInteger(DL.getTypeStoreSizeInBits(Ty)) &&
464 DL.getTypeStoreSizeInBits(Ty) == DL.getTypeSizeInBits(Ty)) {
Chandler Carruthcd8522e2015-01-22 05:08:12 +0000465 if (std::all_of(LI.user_begin(), LI.user_end(), [&LI](User *U) {
466 auto *SI = dyn_cast<StoreInst>(U);
467 return SI && SI->getPointerOperand() != &LI;
468 })) {
469 LoadInst *NewLoad = combineLoadToNewType(
470 IC, LI,
Mehdi Aminia28d91d2015-03-10 02:37:25 +0000471 Type::getIntNTy(LI.getContext(), DL.getTypeStoreSizeInBits(Ty)));
Chandler Carruthcd8522e2015-01-22 05:08:12 +0000472 // Replace all the stores with stores of the newly loaded value.
473 for (auto UI = LI.user_begin(), UE = LI.user_end(); UI != UE;) {
474 auto *SI = cast<StoreInst>(*UI++);
475 IC.Builder->SetInsertPoint(SI);
476 combineStoreToNewValue(IC, *SI, NewLoad);
477 IC.EraseInstFromFunction(*SI);
478 }
479 assert(LI.use_empty() && "Failed to remove all users of the load!");
480 // Return the old load so the combiner can delete it safely.
481 return &LI;
482 }
483 }
Chris Lattnera65e2f72010-01-05 05:57:49 +0000484
Chandler Carruth2f75fcf2014-10-18 06:36:22 +0000485 // Fold away bit casts of the loaded value by loading the desired type.
David Majnemerdd043522015-05-28 18:39:17 +0000486 // We can do this for BitCastInsts as well as casts from and to pointer types,
487 // as long as those are noops (i.e., the source or dest type have the same
488 // bitwidth as the target's pointers).
Chandler Carruth2f75fcf2014-10-18 06:36:22 +0000489 if (LI.hasOneUse())
David Majnemerdd043522015-05-28 18:39:17 +0000490 if (auto* CI = dyn_cast<CastInst>(LI.user_back())) {
491 if (CI->isNoopCast(DL)) {
492 LoadInst *NewLoad = combineLoadToNewType(IC, LI, CI->getDestTy());
493 CI->replaceAllUsesWith(NewLoad);
494 IC.EraseInstFromFunction(*CI);
495 return &LI;
496 }
Chris Lattnera65e2f72010-01-05 05:57:49 +0000497 }
Chandler Carruth2f75fcf2014-10-18 06:36:22 +0000498
Chandler Carrutha7f247e2014-12-09 19:21:16 +0000499 // FIXME: We should also canonicalize loads of vectors when their elements are
500 // cast to other types.
Craig Topperf40110f2014-04-25 05:29:35 +0000501 return nullptr;
Chris Lattnera65e2f72010-01-05 05:57:49 +0000502}
503
Mehdi Amini2668a482015-05-07 05:52:40 +0000504static Instruction *unpackLoadToAggregate(InstCombiner &IC, LoadInst &LI) {
505 // FIXME: We could probably with some care handle both volatile and atomic
506 // stores here but it isn't clear that this is important.
507 if (!LI.isSimple())
508 return nullptr;
509
510 Type *T = LI.getType();
511 if (!T->isAggregateType())
512 return nullptr;
513
514 assert(LI.getAlignment() && "Alignement must be set at this point");
515
516 if (auto *ST = dyn_cast<StructType>(T)) {
517 // If the struct only have one element, we unpack.
518 if (ST->getNumElements() == 1) {
519 LoadInst *NewLoad = combineLoadToNewType(IC, LI, ST->getTypeAtIndex(0U),
520 ".unpack");
521 return IC.ReplaceInstUsesWith(LI, IC.Builder->CreateInsertValue(
522 UndefValue::get(T), NewLoad, 0, LI.getName()));
523 }
524 }
525
David Majnemer58fb0382015-05-11 05:04:22 +0000526 if (auto *AT = dyn_cast<ArrayType>(T)) {
527 // If the array only have one element, we unpack.
528 if (AT->getNumElements() == 1) {
529 LoadInst *NewLoad = combineLoadToNewType(IC, LI, AT->getElementType(),
530 ".unpack");
531 return IC.ReplaceInstUsesWith(LI, IC.Builder->CreateInsertValue(
532 UndefValue::get(T), NewLoad, 0, LI.getName()));
533 }
534 }
535
Mehdi Amini2668a482015-05-07 05:52:40 +0000536 return nullptr;
537}
538
Hal Finkel847e05f2015-02-20 03:05:53 +0000539// If we can determine that all possible objects pointed to by the provided
540// pointer value are, not only dereferenceable, but also definitively less than
541// or equal to the provided maximum size, then return true. Otherwise, return
542// false (constant global values and allocas fall into this category).
543//
544// FIXME: This should probably live in ValueTracking (or similar).
545static bool isObjectSizeLessThanOrEq(Value *V, uint64_t MaxSize,
Mehdi Aminia28d91d2015-03-10 02:37:25 +0000546 const DataLayout &DL) {
Hal Finkel847e05f2015-02-20 03:05:53 +0000547 SmallPtrSet<Value *, 4> Visited;
548 SmallVector<Value *, 4> Worklist(1, V);
549
550 do {
551 Value *P = Worklist.pop_back_val();
552 P = P->stripPointerCasts();
553
554 if (!Visited.insert(P).second)
555 continue;
556
557 if (SelectInst *SI = dyn_cast<SelectInst>(P)) {
558 Worklist.push_back(SI->getTrueValue());
559 Worklist.push_back(SI->getFalseValue());
560 continue;
561 }
562
563 if (PHINode *PN = dyn_cast<PHINode>(P)) {
Pete Cooper833f34d2015-05-12 20:05:31 +0000564 for (Value *IncValue : PN->incoming_values())
565 Worklist.push_back(IncValue);
Hal Finkel847e05f2015-02-20 03:05:53 +0000566 continue;
567 }
568
569 if (GlobalAlias *GA = dyn_cast<GlobalAlias>(P)) {
570 if (GA->mayBeOverridden())
571 return false;
572 Worklist.push_back(GA->getAliasee());
573 continue;
574 }
575
576 // If we know how big this object is, and it is less than MaxSize, continue
577 // searching. Otherwise, return false.
578 if (AllocaInst *AI = dyn_cast<AllocaInst>(P)) {
579 if (!AI->getAllocatedType()->isSized())
580 return false;
581
582 ConstantInt *CS = dyn_cast<ConstantInt>(AI->getArraySize());
583 if (!CS)
584 return false;
585
Mehdi Aminia28d91d2015-03-10 02:37:25 +0000586 uint64_t TypeSize = DL.getTypeAllocSize(AI->getAllocatedType());
Hal Finkel847e05f2015-02-20 03:05:53 +0000587 // Make sure that, even if the multiplication below would wrap as an
588 // uint64_t, we still do the right thing.
589 if ((CS->getValue().zextOrSelf(128)*APInt(128, TypeSize)).ugt(MaxSize))
590 return false;
591 continue;
592 }
593
594 if (GlobalVariable *GV = dyn_cast<GlobalVariable>(P)) {
595 if (!GV->hasDefinitiveInitializer() || !GV->isConstant())
596 return false;
597
Mehdi Aminia28d91d2015-03-10 02:37:25 +0000598 uint64_t InitSize = DL.getTypeAllocSize(GV->getType()->getElementType());
Hal Finkel847e05f2015-02-20 03:05:53 +0000599 if (InitSize > MaxSize)
600 return false;
601 continue;
602 }
603
604 return false;
605 } while (!Worklist.empty());
606
607 return true;
608}
609
610// If we're indexing into an object of a known size, and the outer index is
611// not a constant, but having any value but zero would lead to undefined
612// behavior, replace it with zero.
613//
614// For example, if we have:
615// @f.a = private unnamed_addr constant [1 x i32] [i32 12], align 4
616// ...
617// %arrayidx = getelementptr inbounds [1 x i32]* @f.a, i64 0, i64 %x
618// ... = load i32* %arrayidx, align 4
619// Then we know that we can replace %x in the GEP with i64 0.
620//
621// FIXME: We could fold any GEP index to zero that would cause UB if it were
622// not zero. Currently, we only handle the first such index. Also, we could
623// also search through non-zero constant indices if we kept track of the
624// offsets those indices implied.
625static bool canReplaceGEPIdxWithZero(InstCombiner &IC, GetElementPtrInst *GEPI,
626 Instruction *MemI, unsigned &Idx) {
Mehdi Aminia28d91d2015-03-10 02:37:25 +0000627 if (GEPI->getNumOperands() < 2)
Hal Finkel847e05f2015-02-20 03:05:53 +0000628 return false;
629
630 // Find the first non-zero index of a GEP. If all indices are zero, return
631 // one past the last index.
632 auto FirstNZIdx = [](const GetElementPtrInst *GEPI) {
633 unsigned I = 1;
634 for (unsigned IE = GEPI->getNumOperands(); I != IE; ++I) {
635 Value *V = GEPI->getOperand(I);
636 if (const ConstantInt *CI = dyn_cast<ConstantInt>(V))
637 if (CI->isZero())
638 continue;
639
640 break;
641 }
642
643 return I;
644 };
645
646 // Skip through initial 'zero' indices, and find the corresponding pointer
647 // type. See if the next index is not a constant.
648 Idx = FirstNZIdx(GEPI);
649 if (Idx == GEPI->getNumOperands())
650 return false;
651 if (isa<Constant>(GEPI->getOperand(Idx)))
652 return false;
653
654 SmallVector<Value *, 4> Ops(GEPI->idx_begin(), GEPI->idx_begin() + Idx);
David Blaikied288fb82015-03-30 21:41:43 +0000655 Type *AllocTy = GetElementPtrInst::getIndexedType(
656 cast<PointerType>(GEPI->getOperand(0)->getType()->getScalarType())
657 ->getElementType(),
658 Ops);
Hal Finkel847e05f2015-02-20 03:05:53 +0000659 if (!AllocTy || !AllocTy->isSized())
660 return false;
Mehdi Aminia28d91d2015-03-10 02:37:25 +0000661 const DataLayout &DL = IC.getDataLayout();
662 uint64_t TyAllocSize = DL.getTypeAllocSize(AllocTy);
Hal Finkel847e05f2015-02-20 03:05:53 +0000663
664 // If there are more indices after the one we might replace with a zero, make
665 // sure they're all non-negative. If any of them are negative, the overall
666 // address being computed might be before the base address determined by the
667 // first non-zero index.
668 auto IsAllNonNegative = [&]() {
669 for (unsigned i = Idx+1, e = GEPI->getNumOperands(); i != e; ++i) {
670 bool KnownNonNegative, KnownNegative;
671 IC.ComputeSignBit(GEPI->getOperand(i), KnownNonNegative,
672 KnownNegative, 0, MemI);
673 if (KnownNonNegative)
674 continue;
675 return false;
676 }
677
678 return true;
679 };
680
681 // FIXME: If the GEP is not inbounds, and there are extra indices after the
682 // one we'll replace, those could cause the address computation to wrap
683 // (rendering the IsAllNonNegative() check below insufficient). We can do
684 // better, ignoring zero indicies (and other indicies we can prove small
685 // enough not to wrap).
686 if (Idx+1 != GEPI->getNumOperands() && !GEPI->isInBounds())
687 return false;
688
689 // Note that isObjectSizeLessThanOrEq will return true only if the pointer is
690 // also known to be dereferenceable.
691 return isObjectSizeLessThanOrEq(GEPI->getOperand(0), TyAllocSize, DL) &&
692 IsAllNonNegative();
693}
694
695// If we're indexing into an object with a variable index for the memory
696// access, but the object has only one element, we can assume that the index
697// will always be zero. If we replace the GEP, return it.
698template <typename T>
699static Instruction *replaceGEPIdxWithZero(InstCombiner &IC, Value *Ptr,
700 T &MemI) {
701 if (GetElementPtrInst *GEPI = dyn_cast<GetElementPtrInst>(Ptr)) {
702 unsigned Idx;
703 if (canReplaceGEPIdxWithZero(IC, GEPI, &MemI, Idx)) {
704 Instruction *NewGEPI = GEPI->clone();
705 NewGEPI->setOperand(Idx,
706 ConstantInt::get(GEPI->getOperand(Idx)->getType(), 0));
707 NewGEPI->insertBefore(GEPI);
708 MemI.setOperand(MemI.getPointerOperandIndex(), NewGEPI);
709 return NewGEPI;
710 }
711 }
712
713 return nullptr;
714}
715
Chris Lattnera65e2f72010-01-05 05:57:49 +0000716Instruction *InstCombiner::visitLoadInst(LoadInst &LI) {
717 Value *Op = LI.getOperand(0);
718
Chandler Carruth2f75fcf2014-10-18 06:36:22 +0000719 // Try to canonicalize the loaded type.
720 if (Instruction *Res = combineLoadToOperationType(*this, LI))
721 return Res;
722
Chris Lattnera65e2f72010-01-05 05:57:49 +0000723 // Attempt to improve the alignment.
Mehdi Aminia28d91d2015-03-10 02:37:25 +0000724 unsigned KnownAlign = getOrEnforceKnownAlignment(
725 Op, DL.getPrefTypeAlignment(LI.getType()), DL, &LI, AC, DT);
726 unsigned LoadAlign = LI.getAlignment();
727 unsigned EffectiveLoadAlign =
728 LoadAlign != 0 ? LoadAlign : DL.getABITypeAlignment(LI.getType());
Dan Gohman36196602010-08-03 18:20:32 +0000729
Mehdi Aminia28d91d2015-03-10 02:37:25 +0000730 if (KnownAlign > EffectiveLoadAlign)
731 LI.setAlignment(KnownAlign);
732 else if (LoadAlign == 0)
733 LI.setAlignment(EffectiveLoadAlign);
Chris Lattnera65e2f72010-01-05 05:57:49 +0000734
Hal Finkel847e05f2015-02-20 03:05:53 +0000735 // Replace GEP indices if possible.
736 if (Instruction *NewGEPI = replaceGEPIdxWithZero(*this, Op, LI)) {
737 Worklist.Add(NewGEPI);
738 return &LI;
739 }
740
Eli Friedman8bc586e2011-08-15 22:09:40 +0000741 // None of the following transforms are legal for volatile/atomic loads.
742 // FIXME: Some of it is okay for atomic loads; needs refactoring.
Craig Topperf40110f2014-04-25 05:29:35 +0000743 if (!LI.isSimple()) return nullptr;
Jim Grosbachbdbd7342013-04-05 21:20:12 +0000744
Mehdi Amini2668a482015-05-07 05:52:40 +0000745 if (Instruction *Res = unpackLoadToAggregate(*this, LI))
746 return Res;
747
Chris Lattnera65e2f72010-01-05 05:57:49 +0000748 // Do really simple store-to-load forwarding and load CSE, to catch cases
Duncan Sands75b5d272011-02-15 09:23:02 +0000749 // where there are several consecutive memory accesses to the same location,
Chris Lattnera65e2f72010-01-05 05:57:49 +0000750 // separated by a few arithmetic operations.
751 BasicBlock::iterator BBI = &LI;
Bjorn Steinbrinka91fd092015-07-10 06:55:44 +0000752 AAMDNodes AATags;
753 if (Value *AvailableVal = FindAvailableLoadedValue(Op, LI.getParent(), BBI,
754 6, nullptr, &AATags)) {
755 if (LoadInst *NLI = dyn_cast<LoadInst>(AvailableVal)) {
756 unsigned KnownIDs[] = {
757 LLVMContext::MD_tbaa,
758 LLVMContext::MD_alias_scope,
759 LLVMContext::MD_noalias,
760 LLVMContext::MD_range,
761 LLVMContext::MD_invariant_load,
762 LLVMContext::MD_nonnull,
763 };
764 combineMetadata(NLI, &LI, KnownIDs);
765 if (AATags)
766 NLI->setAAMetadata(AATags);
767 };
768
Chandler Carrutheeec35a2014-10-20 00:24:14 +0000769 return ReplaceInstUsesWith(
Chandler Carruth1a3c2c42014-11-25 08:20:27 +0000770 LI, Builder->CreateBitOrPointerCast(AvailableVal, LI.getType(),
771 LI.getName() + ".cast"));
Bjorn Steinbrinka91fd092015-07-10 06:55:44 +0000772 }
Chris Lattnera65e2f72010-01-05 05:57:49 +0000773
774 // load(gep null, ...) -> unreachable
775 if (GetElementPtrInst *GEPI = dyn_cast<GetElementPtrInst>(Op)) {
776 const Value *GEPI0 = GEPI->getOperand(0);
777 // TODO: Consider a target hook for valid address spaces for this xform.
778 if (isa<ConstantPointerNull>(GEPI0) && GEPI->getPointerAddressSpace() == 0){
779 // Insert a new store to null instruction before the load to indicate
780 // that this code is not reachable. We do this instead of inserting
781 // an unreachable instruction directly because we cannot modify the
782 // CFG.
783 new StoreInst(UndefValue::get(LI.getType()),
784 Constant::getNullValue(Op->getType()), &LI);
785 return ReplaceInstUsesWith(LI, UndefValue::get(LI.getType()));
786 }
Jim Grosbachbdbd7342013-04-05 21:20:12 +0000787 }
Chris Lattnera65e2f72010-01-05 05:57:49 +0000788
789 // load null/undef -> unreachable
790 // TODO: Consider a target hook for valid address spaces for this xform.
791 if (isa<UndefValue>(Op) ||
792 (isa<ConstantPointerNull>(Op) && LI.getPointerAddressSpace() == 0)) {
793 // Insert a new store to null instruction before the load to indicate that
794 // this code is not reachable. We do this instead of inserting an
795 // unreachable instruction directly because we cannot modify the CFG.
796 new StoreInst(UndefValue::get(LI.getType()),
797 Constant::getNullValue(Op->getType()), &LI);
798 return ReplaceInstUsesWith(LI, UndefValue::get(LI.getType()));
799 }
800
Chris Lattnera65e2f72010-01-05 05:57:49 +0000801 if (Op->hasOneUse()) {
802 // Change select and PHI nodes to select values instead of addresses: this
803 // helps alias analysis out a lot, allows many others simplifications, and
804 // exposes redundancy in the code.
805 //
806 // Note that we cannot do the transformation unless we know that the
807 // introduced loads cannot trap! Something like this is valid as long as
808 // the condition is always false: load (select bool %C, int* null, int* %G),
809 // but it would not be valid if we transformed it to load from null
810 // unconditionally.
811 //
812 if (SelectInst *SI = dyn_cast<SelectInst>(Op)) {
813 // load (select (Cond, &V1, &V2)) --> select(Cond, load &V1, load &V2).
Bob Wilson56600a12010-01-30 04:42:39 +0000814 unsigned Align = LI.getAlignment();
Mehdi Aminia28d91d2015-03-10 02:37:25 +0000815 if (isSafeToLoadUnconditionally(SI->getOperand(1), SI, Align) &&
816 isSafeToLoadUnconditionally(SI->getOperand(2), SI, Align)) {
Bob Wilson4b71b6c2010-01-30 00:41:10 +0000817 LoadInst *V1 = Builder->CreateLoad(SI->getOperand(1),
Bob Wilson56600a12010-01-30 04:42:39 +0000818 SI->getOperand(1)->getName()+".val");
Bob Wilson4b71b6c2010-01-30 00:41:10 +0000819 LoadInst *V2 = Builder->CreateLoad(SI->getOperand(2),
Bob Wilson56600a12010-01-30 04:42:39 +0000820 SI->getOperand(2)->getName()+".val");
821 V1->setAlignment(Align);
822 V2->setAlignment(Align);
Chris Lattnera65e2f72010-01-05 05:57:49 +0000823 return SelectInst::Create(SI->getCondition(), V1, V2);
824 }
825
826 // load (select (cond, null, P)) -> load P
Philip Reames5ad26c32014-12-29 22:46:21 +0000827 if (isa<ConstantPointerNull>(SI->getOperand(1)) &&
828 LI.getPointerAddressSpace() == 0) {
829 LI.setOperand(0, SI->getOperand(2));
830 return &LI;
831 }
Chris Lattnera65e2f72010-01-05 05:57:49 +0000832
833 // load (select (cond, P, null)) -> load P
Philip Reames5ad26c32014-12-29 22:46:21 +0000834 if (isa<ConstantPointerNull>(SI->getOperand(2)) &&
835 LI.getPointerAddressSpace() == 0) {
836 LI.setOperand(0, SI->getOperand(1));
837 return &LI;
838 }
Chris Lattnera65e2f72010-01-05 05:57:49 +0000839 }
840 }
Craig Topperf40110f2014-04-25 05:29:35 +0000841 return nullptr;
Chris Lattnera65e2f72010-01-05 05:57:49 +0000842}
843
Chandler Carruth816d26f2014-11-25 10:09:51 +0000844/// \brief Combine stores to match the type of value being stored.
845///
846/// The core idea here is that the memory does not have any intrinsic type and
847/// where we can we should match the type of a store to the type of value being
848/// stored.
849///
850/// However, this routine must never change the width of a store or the number of
851/// stores as that would introduce a semantic change. This combine is expected to
852/// be a semantic no-op which just allows stores to more closely model the types
853/// of their incoming values.
854///
855/// Currently, we also refuse to change the precise type used for an atomic or
856/// volatile store. This is debatable, and might be reasonable to change later.
857/// However, it is risky in case some backend or other part of LLVM is relying
858/// on the exact type stored to select appropriate atomic operations.
859///
860/// \returns true if the store was successfully combined away. This indicates
861/// the caller must erase the store instruction. We have to let the caller erase
862/// the store instruction sas otherwise there is no way to signal whether it was
863/// combined or not: IC.EraseInstFromFunction returns a null pointer.
864static bool combineStoreToValueType(InstCombiner &IC, StoreInst &SI) {
865 // FIXME: We could probably with some care handle both volatile and atomic
866 // stores here but it isn't clear that this is important.
867 if (!SI.isSimple())
868 return false;
Chris Lattnera65e2f72010-01-05 05:57:49 +0000869
Chandler Carruth816d26f2014-11-25 10:09:51 +0000870 Value *V = SI.getValueOperand();
Jim Grosbachbdbd7342013-04-05 21:20:12 +0000871
Chandler Carruth816d26f2014-11-25 10:09:51 +0000872 // Fold away bit casts of the stored value by storing the original type.
873 if (auto *BC = dyn_cast<BitCastInst>(V)) {
Chandler Carrutha7f247e2014-12-09 19:21:16 +0000874 V = BC->getOperand(0);
Chandler Carruth2135b972015-01-21 23:45:01 +0000875 combineStoreToNewValue(IC, SI, V);
Chandler Carruth816d26f2014-11-25 10:09:51 +0000876 return true;
Chris Lattnera65e2f72010-01-05 05:57:49 +0000877 }
878
Chandler Carruth816d26f2014-11-25 10:09:51 +0000879 // FIXME: We should also canonicalize loads of vectors when their elements are
880 // cast to other types.
881 return false;
Chris Lattnera65e2f72010-01-05 05:57:49 +0000882}
883
Mehdi Aminib344ac92015-03-14 22:19:33 +0000884static bool unpackStoreToAggregate(InstCombiner &IC, StoreInst &SI) {
885 // FIXME: We could probably with some care handle both volatile and atomic
886 // stores here but it isn't clear that this is important.
887 if (!SI.isSimple())
888 return false;
889
890 Value *V = SI.getValueOperand();
891 Type *T = V->getType();
892
893 if (!T->isAggregateType())
894 return false;
895
Mehdi Amini2668a482015-05-07 05:52:40 +0000896 if (auto *ST = dyn_cast<StructType>(T)) {
Mehdi Aminib344ac92015-03-14 22:19:33 +0000897 // If the struct only have one element, we unpack.
898 if (ST->getNumElements() == 1) {
899 V = IC.Builder->CreateExtractValue(V, 0);
900 combineStoreToNewValue(IC, SI, V);
901 return true;
902 }
903 }
904
David Majnemer75364602015-05-11 05:04:27 +0000905 if (auto *AT = dyn_cast<ArrayType>(T)) {
906 // If the array only have one element, we unpack.
907 if (AT->getNumElements() == 1) {
908 V = IC.Builder->CreateExtractValue(V, 0);
909 combineStoreToNewValue(IC, SI, V);
910 return true;
911 }
912 }
913
Mehdi Aminib344ac92015-03-14 22:19:33 +0000914 return false;
915}
916
Chris Lattnera65e2f72010-01-05 05:57:49 +0000917/// equivalentAddressValues - Test if A and B will obviously have the same
918/// value. This includes recognizing that %t0 and %t1 will have the same
919/// value in code like this:
920/// %t0 = getelementptr \@a, 0, 3
921/// store i32 0, i32* %t0
922/// %t1 = getelementptr \@a, 0, 3
923/// %t2 = load i32* %t1
924///
925static bool equivalentAddressValues(Value *A, Value *B) {
926 // Test if the values are trivially equivalent.
927 if (A == B) return true;
Jim Grosbachbdbd7342013-04-05 21:20:12 +0000928
Chris Lattnera65e2f72010-01-05 05:57:49 +0000929 // Test if the values come form identical arithmetic instructions.
930 // This uses isIdenticalToWhenDefined instead of isIdenticalTo because
931 // its only used to compare two uses within the same basic block, which
932 // means that they'll always either have the same value or one of them
933 // will have an undefined value.
934 if (isa<BinaryOperator>(A) ||
935 isa<CastInst>(A) ||
936 isa<PHINode>(A) ||
937 isa<GetElementPtrInst>(A))
938 if (Instruction *BI = dyn_cast<Instruction>(B))
939 if (cast<Instruction>(A)->isIdenticalToWhenDefined(BI))
940 return true;
Jim Grosbachbdbd7342013-04-05 21:20:12 +0000941
Chris Lattnera65e2f72010-01-05 05:57:49 +0000942 // Otherwise they may not be equivalent.
943 return false;
944}
945
Chris Lattnera65e2f72010-01-05 05:57:49 +0000946Instruction *InstCombiner::visitStoreInst(StoreInst &SI) {
947 Value *Val = SI.getOperand(0);
948 Value *Ptr = SI.getOperand(1);
949
Chandler Carruth816d26f2014-11-25 10:09:51 +0000950 // Try to canonicalize the stored type.
951 if (combineStoreToValueType(*this, SI))
952 return EraseInstFromFunction(SI);
953
Chris Lattnera65e2f72010-01-05 05:57:49 +0000954 // Attempt to improve the alignment.
Mehdi Aminia28d91d2015-03-10 02:37:25 +0000955 unsigned KnownAlign = getOrEnforceKnownAlignment(
956 Ptr, DL.getPrefTypeAlignment(Val->getType()), DL, &SI, AC, DT);
957 unsigned StoreAlign = SI.getAlignment();
958 unsigned EffectiveStoreAlign =
959 StoreAlign != 0 ? StoreAlign : DL.getABITypeAlignment(Val->getType());
Dan Gohman36196602010-08-03 18:20:32 +0000960
Mehdi Aminia28d91d2015-03-10 02:37:25 +0000961 if (KnownAlign > EffectiveStoreAlign)
962 SI.setAlignment(KnownAlign);
963 else if (StoreAlign == 0)
964 SI.setAlignment(EffectiveStoreAlign);
Chris Lattnera65e2f72010-01-05 05:57:49 +0000965
Mehdi Aminib344ac92015-03-14 22:19:33 +0000966 // Try to canonicalize the stored type.
967 if (unpackStoreToAggregate(*this, SI))
968 return EraseInstFromFunction(SI);
969
Hal Finkel847e05f2015-02-20 03:05:53 +0000970 // Replace GEP indices if possible.
971 if (Instruction *NewGEPI = replaceGEPIdxWithZero(*this, Ptr, SI)) {
972 Worklist.Add(NewGEPI);
973 return &SI;
974 }
975
Eli Friedman8bc586e2011-08-15 22:09:40 +0000976 // Don't hack volatile/atomic stores.
977 // FIXME: Some bits are legal for atomic stores; needs refactoring.
Craig Topperf40110f2014-04-25 05:29:35 +0000978 if (!SI.isSimple()) return nullptr;
Eli Friedman8bc586e2011-08-15 22:09:40 +0000979
980 // If the RHS is an alloca with a single use, zapify the store, making the
981 // alloca dead.
982 if (Ptr->hasOneUse()) {
Jim Grosbachbdbd7342013-04-05 21:20:12 +0000983 if (isa<AllocaInst>(Ptr))
Eli Friedman8bc586e2011-08-15 22:09:40 +0000984 return EraseInstFromFunction(SI);
985 if (GetElementPtrInst *GEP = dyn_cast<GetElementPtrInst>(Ptr)) {
986 if (isa<AllocaInst>(GEP->getOperand(0))) {
987 if (GEP->getOperand(0)->hasOneUse())
988 return EraseInstFromFunction(SI);
989 }
990 }
991 }
992
Chris Lattnera65e2f72010-01-05 05:57:49 +0000993 // Do really simple DSE, to catch cases where there are several consecutive
994 // stores to the same location, separated by a few arithmetic operations. This
995 // situation often occurs with bitfield accesses.
996 BasicBlock::iterator BBI = &SI;
997 for (unsigned ScanInsts = 6; BBI != SI.getParent()->begin() && ScanInsts;
998 --ScanInsts) {
999 --BBI;
Victor Hernandez5f8c8c02010-01-22 19:05:05 +00001000 // Don't count debug info directives, lest they affect codegen,
1001 // and we skip pointer-to-pointer bitcasts, which are NOPs.
1002 if (isa<DbgInfoIntrinsic>(BBI) ||
Duncan Sands19d0b472010-02-16 11:11:14 +00001003 (isa<BitCastInst>(BBI) && BBI->getType()->isPointerTy())) {
Chris Lattnera65e2f72010-01-05 05:57:49 +00001004 ScanInsts++;
1005 continue;
Jim Grosbachbdbd7342013-04-05 21:20:12 +00001006 }
1007
Chris Lattnera65e2f72010-01-05 05:57:49 +00001008 if (StoreInst *PrevSI = dyn_cast<StoreInst>(BBI)) {
1009 // Prev store isn't volatile, and stores to the same location?
Eli Friedman8bc586e2011-08-15 22:09:40 +00001010 if (PrevSI->isSimple() && equivalentAddressValues(PrevSI->getOperand(1),
1011 SI.getOperand(1))) {
Chris Lattnera65e2f72010-01-05 05:57:49 +00001012 ++NumDeadStore;
1013 ++BBI;
1014 EraseInstFromFunction(*PrevSI);
1015 continue;
1016 }
1017 break;
1018 }
Jim Grosbachbdbd7342013-04-05 21:20:12 +00001019
Chris Lattnera65e2f72010-01-05 05:57:49 +00001020 // If this is a load, we have to stop. However, if the loaded value is from
1021 // the pointer we're loading and is producing the pointer we're storing,
1022 // then *this* store is dead (X = load P; store X -> P).
1023 if (LoadInst *LI = dyn_cast<LoadInst>(BBI)) {
Jin-Gu Kangb452db02011-03-14 01:21:00 +00001024 if (LI == Val && equivalentAddressValues(LI->getOperand(0), Ptr) &&
Eli Friedman8bc586e2011-08-15 22:09:40 +00001025 LI->isSimple())
Jin-Gu Kangb452db02011-03-14 01:21:00 +00001026 return EraseInstFromFunction(SI);
Jim Grosbachbdbd7342013-04-05 21:20:12 +00001027
Chris Lattnera65e2f72010-01-05 05:57:49 +00001028 // Otherwise, this is a load from some other location. Stores before it
1029 // may not be dead.
1030 break;
1031 }
Jim Grosbachbdbd7342013-04-05 21:20:12 +00001032
Chris Lattnera65e2f72010-01-05 05:57:49 +00001033 // Don't skip over loads or things that can modify memory.
1034 if (BBI->mayWriteToMemory() || BBI->mayReadFromMemory())
1035 break;
1036 }
Chris Lattnera65e2f72010-01-05 05:57:49 +00001037
1038 // store X, null -> turns into 'unreachable' in SimplifyCFG
1039 if (isa<ConstantPointerNull>(Ptr) && SI.getPointerAddressSpace() == 0) {
1040 if (!isa<UndefValue>(Val)) {
1041 SI.setOperand(0, UndefValue::get(Val->getType()));
1042 if (Instruction *U = dyn_cast<Instruction>(Val))
1043 Worklist.Add(U); // Dropped a use.
1044 }
Craig Topperf40110f2014-04-25 05:29:35 +00001045 return nullptr; // Do not modify these!
Chris Lattnera65e2f72010-01-05 05:57:49 +00001046 }
1047
1048 // store undef, Ptr -> noop
1049 if (isa<UndefValue>(Val))
1050 return EraseInstFromFunction(SI);
1051
Chris Lattnera65e2f72010-01-05 05:57:49 +00001052 // If this store is the last instruction in the basic block (possibly
Victor Hernandez5f5abd52010-01-21 23:07:15 +00001053 // excepting debug info instructions), and if the block ends with an
1054 // unconditional branch, try to move it to the successor block.
Jim Grosbachbdbd7342013-04-05 21:20:12 +00001055 BBI = &SI;
Chris Lattnera65e2f72010-01-05 05:57:49 +00001056 do {
1057 ++BBI;
Victor Hernandez5f8c8c02010-01-22 19:05:05 +00001058 } while (isa<DbgInfoIntrinsic>(BBI) ||
Duncan Sands19d0b472010-02-16 11:11:14 +00001059 (isa<BitCastInst>(BBI) && BBI->getType()->isPointerTy()));
Chris Lattnera65e2f72010-01-05 05:57:49 +00001060 if (BranchInst *BI = dyn_cast<BranchInst>(BBI))
1061 if (BI->isUnconditional())
1062 if (SimplifyStoreAtEndOfBlock(SI))
Craig Topperf40110f2014-04-25 05:29:35 +00001063 return nullptr; // xform done!
Jim Grosbachbdbd7342013-04-05 21:20:12 +00001064
Craig Topperf40110f2014-04-25 05:29:35 +00001065 return nullptr;
Chris Lattnera65e2f72010-01-05 05:57:49 +00001066}
1067
1068/// SimplifyStoreAtEndOfBlock - Turn things like:
1069/// if () { *P = v1; } else { *P = v2 }
1070/// into a phi node with a store in the successor.
1071///
1072/// Simplify things like:
1073/// *P = v1; if () { *P = v2; }
1074/// into a phi node with a store in the successor.
1075///
1076bool InstCombiner::SimplifyStoreAtEndOfBlock(StoreInst &SI) {
1077 BasicBlock *StoreBB = SI.getParent();
Jim Grosbachbdbd7342013-04-05 21:20:12 +00001078
Chris Lattnera65e2f72010-01-05 05:57:49 +00001079 // Check to see if the successor block has exactly two incoming edges. If
1080 // so, see if the other predecessor contains a store to the same location.
1081 // if so, insert a PHI node (if needed) and move the stores down.
1082 BasicBlock *DestBB = StoreBB->getTerminator()->getSuccessor(0);
Jim Grosbachbdbd7342013-04-05 21:20:12 +00001083
Chris Lattnera65e2f72010-01-05 05:57:49 +00001084 // Determine whether Dest has exactly two predecessors and, if so, compute
1085 // the other predecessor.
1086 pred_iterator PI = pred_begin(DestBB);
Gabor Greif1b787df2010-07-12 15:48:26 +00001087 BasicBlock *P = *PI;
Craig Topperf40110f2014-04-25 05:29:35 +00001088 BasicBlock *OtherBB = nullptr;
Gabor Greif1b787df2010-07-12 15:48:26 +00001089
1090 if (P != StoreBB)
1091 OtherBB = P;
1092
1093 if (++PI == pred_end(DestBB))
Chris Lattnera65e2f72010-01-05 05:57:49 +00001094 return false;
Jim Grosbachbdbd7342013-04-05 21:20:12 +00001095
Gabor Greif1b787df2010-07-12 15:48:26 +00001096 P = *PI;
1097 if (P != StoreBB) {
Chris Lattnera65e2f72010-01-05 05:57:49 +00001098 if (OtherBB)
1099 return false;
Gabor Greif1b787df2010-07-12 15:48:26 +00001100 OtherBB = P;
Chris Lattnera65e2f72010-01-05 05:57:49 +00001101 }
1102 if (++PI != pred_end(DestBB))
1103 return false;
1104
1105 // Bail out if all the relevant blocks aren't distinct (this can happen,
1106 // for example, if SI is in an infinite loop)
1107 if (StoreBB == DestBB || OtherBB == DestBB)
1108 return false;
1109
1110 // Verify that the other block ends in a branch and is not otherwise empty.
1111 BasicBlock::iterator BBI = OtherBB->getTerminator();
1112 BranchInst *OtherBr = dyn_cast<BranchInst>(BBI);
1113 if (!OtherBr || BBI == OtherBB->begin())
1114 return false;
Jim Grosbachbdbd7342013-04-05 21:20:12 +00001115
Chris Lattnera65e2f72010-01-05 05:57:49 +00001116 // If the other block ends in an unconditional branch, check for the 'if then
1117 // else' case. there is an instruction before the branch.
Craig Topperf40110f2014-04-25 05:29:35 +00001118 StoreInst *OtherStore = nullptr;
Chris Lattnera65e2f72010-01-05 05:57:49 +00001119 if (OtherBr->isUnconditional()) {
1120 --BBI;
1121 // Skip over debugging info.
Victor Hernandez5f8c8c02010-01-22 19:05:05 +00001122 while (isa<DbgInfoIntrinsic>(BBI) ||
Duncan Sands19d0b472010-02-16 11:11:14 +00001123 (isa<BitCastInst>(BBI) && BBI->getType()->isPointerTy())) {
Chris Lattnera65e2f72010-01-05 05:57:49 +00001124 if (BBI==OtherBB->begin())
1125 return false;
1126 --BBI;
1127 }
Eli Friedman8bc586e2011-08-15 22:09:40 +00001128 // If this isn't a store, isn't a store to the same location, or is not the
1129 // right kind of store, bail out.
Chris Lattnera65e2f72010-01-05 05:57:49 +00001130 OtherStore = dyn_cast<StoreInst>(BBI);
1131 if (!OtherStore || OtherStore->getOperand(1) != SI.getOperand(1) ||
Eli Friedman8bc586e2011-08-15 22:09:40 +00001132 !SI.isSameOperationAs(OtherStore))
Chris Lattnera65e2f72010-01-05 05:57:49 +00001133 return false;
1134 } else {
1135 // Otherwise, the other block ended with a conditional branch. If one of the
1136 // destinations is StoreBB, then we have the if/then case.
Jim Grosbachbdbd7342013-04-05 21:20:12 +00001137 if (OtherBr->getSuccessor(0) != StoreBB &&
Chris Lattnera65e2f72010-01-05 05:57:49 +00001138 OtherBr->getSuccessor(1) != StoreBB)
1139 return false;
Jim Grosbachbdbd7342013-04-05 21:20:12 +00001140
Chris Lattnera65e2f72010-01-05 05:57:49 +00001141 // Okay, we know that OtherBr now goes to Dest and StoreBB, so this is an
1142 // if/then triangle. See if there is a store to the same ptr as SI that
1143 // lives in OtherBB.
1144 for (;; --BBI) {
1145 // Check to see if we find the matching store.
1146 if ((OtherStore = dyn_cast<StoreInst>(BBI))) {
1147 if (OtherStore->getOperand(1) != SI.getOperand(1) ||
Eli Friedman8bc586e2011-08-15 22:09:40 +00001148 !SI.isSameOperationAs(OtherStore))
Chris Lattnera65e2f72010-01-05 05:57:49 +00001149 return false;
1150 break;
1151 }
1152 // If we find something that may be using or overwriting the stored
1153 // value, or if we run out of instructions, we can't do the xform.
1154 if (BBI->mayReadFromMemory() || BBI->mayWriteToMemory() ||
1155 BBI == OtherBB->begin())
1156 return false;
1157 }
Jim Grosbachbdbd7342013-04-05 21:20:12 +00001158
Chris Lattnera65e2f72010-01-05 05:57:49 +00001159 // In order to eliminate the store in OtherBr, we have to
1160 // make sure nothing reads or overwrites the stored value in
1161 // StoreBB.
1162 for (BasicBlock::iterator I = StoreBB->begin(); &*I != &SI; ++I) {
1163 // FIXME: This should really be AA driven.
1164 if (I->mayReadFromMemory() || I->mayWriteToMemory())
1165 return false;
1166 }
1167 }
Jim Grosbachbdbd7342013-04-05 21:20:12 +00001168
Chris Lattnera65e2f72010-01-05 05:57:49 +00001169 // Insert a PHI node now if we need it.
1170 Value *MergedVal = OtherStore->getOperand(0);
1171 if (MergedVal != SI.getOperand(0)) {
Jay Foad52131342011-03-30 11:28:46 +00001172 PHINode *PN = PHINode::Create(MergedVal->getType(), 2, "storemerge");
Chris Lattnera65e2f72010-01-05 05:57:49 +00001173 PN->addIncoming(SI.getOperand(0), SI.getParent());
1174 PN->addIncoming(OtherStore->getOperand(0), OtherBB);
1175 MergedVal = InsertNewInstBefore(PN, DestBB->front());
1176 }
Jim Grosbachbdbd7342013-04-05 21:20:12 +00001177
Chris Lattnera65e2f72010-01-05 05:57:49 +00001178 // Advance to a place where it is safe to insert the new store and
1179 // insert it.
Bill Wendling8ddfc092011-08-16 20:45:24 +00001180 BBI = DestBB->getFirstInsertionPt();
Eli Friedman35211c62011-05-27 00:19:40 +00001181 StoreInst *NewSI = new StoreInst(MergedVal, SI.getOperand(1),
Eli Friedman8bc586e2011-08-15 22:09:40 +00001182 SI.isVolatile(),
1183 SI.getAlignment(),
1184 SI.getOrdering(),
1185 SI.getSynchScope());
Eli Friedman35211c62011-05-27 00:19:40 +00001186 InsertNewInstBefore(NewSI, *BBI);
Jim Grosbachbdbd7342013-04-05 21:20:12 +00001187 NewSI->setDebugLoc(OtherStore->getDebugLoc());
Eli Friedman35211c62011-05-27 00:19:40 +00001188
Hal Finkelcc39b672014-07-24 12:16:19 +00001189 // If the two stores had AA tags, merge them.
1190 AAMDNodes AATags;
1191 SI.getAAMetadata(AATags);
1192 if (AATags) {
1193 OtherStore->getAAMetadata(AATags, /* Merge = */ true);
1194 NewSI->setAAMetadata(AATags);
1195 }
Jim Grosbachbdbd7342013-04-05 21:20:12 +00001196
Chris Lattnera65e2f72010-01-05 05:57:49 +00001197 // Nuke the old stores.
1198 EraseInstFromFunction(SI);
1199 EraseInstFromFunction(*OtherStore);
1200 return true;
1201}