blob: 715d0cb17e3722626ac6c209a7470f2cc1bac621 [file] [log] [blame]
Alexander Kornienkoa48a12c2013-12-03 10:50:16 +00001//===- unittest/Format/FormatTestJS.cpp - Formatting unit tests for JS ----===//
2//
3// The LLVM Compiler Infrastructure
4//
5// This file is distributed under the University of Illinois Open Source
6// License. See LICENSE.TXT for details.
7//
8//===----------------------------------------------------------------------===//
9
Alexander Kornienkoa48a12c2013-12-03 10:50:16 +000010#include "FormatTestUtils.h"
Alexander Kornienkoa48a12c2013-12-03 10:50:16 +000011#include "clang/Format/Format.h"
12#include "llvm/Support/Debug.h"
13#include "gtest/gtest.h"
14
Chandler Carruth10346662014-04-22 03:17:02 +000015#define DEBUG_TYPE "format-test"
16
Alexander Kornienkoa48a12c2013-12-03 10:50:16 +000017namespace clang {
18namespace format {
19
20class FormatTestJS : public ::testing::Test {
21protected:
22 static std::string format(llvm::StringRef Code, unsigned Offset,
23 unsigned Length, const FormatStyle &Style) {
24 DEBUG(llvm::errs() << "---\n");
25 DEBUG(llvm::errs() << Code << "\n\n");
26 std::vector<tooling::Range> Ranges(1, tooling::Range(Offset, Length));
Daniel Jasper56691b82015-06-11 13:29:20 +000027 bool IncompleteFormat = false;
28 tooling::Replacements Replaces =
29 reformat(Style, Code, Ranges, "<stdin>", &IncompleteFormat);
30 EXPECT_FALSE(IncompleteFormat);
Alexander Kornienkoa48a12c2013-12-03 10:50:16 +000031 std::string Result = applyAllReplacements(Code, Replaces);
32 EXPECT_NE("", Result);
33 DEBUG(llvm::errs() << "\n" << Result << "\n\n");
34 return Result;
35 }
36
Daniel Jasper069e5f42014-05-20 11:14:57 +000037 static std::string format(
38 llvm::StringRef Code,
39 const FormatStyle &Style = getGoogleStyle(FormatStyle::LK_JavaScript)) {
Alexander Kornienkoa48a12c2013-12-03 10:50:16 +000040 return format(Code, 0, Code.size(), Style);
41 }
42
Alexander Kornienkoc1637f12013-12-10 11:28:13 +000043 static FormatStyle getGoogleJSStyleWithColumns(unsigned ColumnLimit) {
Nico Weber514ecc82014-02-02 20:50:45 +000044 FormatStyle Style = getGoogleStyle(FormatStyle::LK_JavaScript);
Alexander Kornienkoa48a12c2013-12-03 10:50:16 +000045 Style.ColumnLimit = ColumnLimit;
46 return Style;
47 }
48
Nico Weber514ecc82014-02-02 20:50:45 +000049 static void verifyFormat(
50 llvm::StringRef Code,
51 const FormatStyle &Style = getGoogleStyle(FormatStyle::LK_JavaScript)) {
Alexander Kornienkoa48a12c2013-12-03 10:50:16 +000052 EXPECT_EQ(Code.str(), format(test::messUp(Code), Style));
53 }
54};
55
56TEST_F(FormatTestJS, UnderstandsJavaScriptOperators) {
57 verifyFormat("a == = b;");
58 verifyFormat("a != = b;");
59
60 verifyFormat("a === b;");
Daniel Jaspere551bb72014-11-05 17:22:31 +000061 verifyFormat("aaaaaaa ===\n b;", getGoogleJSStyleWithColumns(10));
Alexander Kornienkoa48a12c2013-12-03 10:50:16 +000062 verifyFormat("a !== b;");
Daniel Jaspere551bb72014-11-05 17:22:31 +000063 verifyFormat("aaaaaaa !==\n b;", getGoogleJSStyleWithColumns(10));
64 verifyFormat("if (a + b + c +\n"
65 " d !==\n"
66 " e + f + g)\n"
Alexander Kornienkoa48a12c2013-12-03 10:50:16 +000067 " q();",
Alexander Kornienkoc1637f12013-12-10 11:28:13 +000068 getGoogleJSStyleWithColumns(20));
Alexander Kornienkoa48a12c2013-12-03 10:50:16 +000069
70 verifyFormat("a >> >= b;");
71
72 verifyFormat("a >>> b;");
Daniel Jaspere551bb72014-11-05 17:22:31 +000073 verifyFormat("aaaaaaa >>>\n b;", getGoogleJSStyleWithColumns(10));
Alexander Kornienkoa48a12c2013-12-03 10:50:16 +000074 verifyFormat("a >>>= b;");
Daniel Jaspere551bb72014-11-05 17:22:31 +000075 verifyFormat("aaaaaaa >>>=\n b;", getGoogleJSStyleWithColumns(10));
76 verifyFormat("if (a + b + c +\n"
77 " d >>>\n"
78 " e + f + g)\n"
Alexander Kornienkoa48a12c2013-12-03 10:50:16 +000079 " q();",
Alexander Kornienkoc1637f12013-12-10 11:28:13 +000080 getGoogleJSStyleWithColumns(20));
Daniel Jaspere551bb72014-11-05 17:22:31 +000081 verifyFormat("var x = aaaaaaaaaa ?\n"
82 " bbbbbb :\n"
83 " ccc;",
Alexander Kornienkoc1637f12013-12-10 11:28:13 +000084 getGoogleJSStyleWithColumns(20));
Daniel Jasper78214392014-05-19 07:27:02 +000085
86 verifyFormat("var b = a.map((x) => x + 1);");
Daniel Jasper3549ea12014-09-19 10:48:15 +000087 verifyFormat("return ('aaa') in bbbb;");
Daniel Jasper08051992015-05-26 07:18:56 +000088
89 // ES6 spread operator.
90 verifyFormat("someFunction(...a);");
91 verifyFormat("var x = [1, ...a, 2];");
Alexander Kornienkoa48a12c2013-12-03 10:50:16 +000092}
93
Daniel Jasper3a038de2014-09-05 08:53:45 +000094TEST_F(FormatTestJS, UnderstandsAmpAmp) {
95 verifyFormat("e && e.SomeFunction();");
96}
97
Daniel Jasper4db69bd2014-09-04 18:23:42 +000098TEST_F(FormatTestJS, LiteralOperatorsCanBeKeywords) {
99 verifyFormat("not.and.or.not_eq = 1;");
100}
101
Daniel Jasper0dd52912014-05-19 07:37:07 +0000102TEST_F(FormatTestJS, ES6DestructuringAssignment) {
103 verifyFormat("var [a, b, c] = [1, 2, 3];");
Daniel Jasper60948b12015-03-15 13:55:54 +0000104 verifyFormat("var {a, b} = {a: 1, b: 2};");
Daniel Jasper0dd52912014-05-19 07:37:07 +0000105}
106
Daniel Jasper17062ff2014-06-10 14:44:02 +0000107TEST_F(FormatTestJS, ContainerLiterals) {
Manuel Klimek79e06082015-05-21 12:23:34 +0000108 verifyFormat("var x = {y: function(a) { return a; }};");
Daniel Jasper17062ff2014-06-10 14:44:02 +0000109 verifyFormat("return {\n"
110 " link: function() {\n"
111 " f(); //\n"
112 " }\n"
113 "};");
114 verifyFormat("return {\n"
115 " a: a,\n"
116 " link: function() {\n"
117 " f(); //\n"
118 " }\n"
119 "};");
120 verifyFormat("return {\n"
121 " a: a,\n"
Daniel Jasper90ebc982014-09-05 09:27:38 +0000122 " link: function() {\n"
123 " f(); //\n"
124 " },\n"
125 " link: function() {\n"
126 " f(); //\n"
127 " }\n"
Daniel Jasper17062ff2014-06-10 14:44:02 +0000128 "};");
Daniel Jasper94e11d02014-09-04 14:58:30 +0000129 verifyFormat("var stuff = {\n"
130 " // comment for update\n"
131 " update: false,\n"
132 " // comment for modules\n"
133 " modules: false,\n"
134 " // comment for tasks\n"
135 " tasks: false\n"
136 "};");
Daniel Jasper97bfb7b2014-09-05 08:29:31 +0000137 verifyFormat("return {\n"
138 " 'finish':\n"
139 " //\n"
140 " a\n"
141 "};");
Daniel Jasper40874322014-11-27 15:24:48 +0000142 verifyFormat("var obj = {\n"
143 " fooooooooo: function(x) {\n"
144 " return x.zIsTooLongForOneLineWithTheDeclarationLine();\n"
145 " }\n"
146 "};");
Daniel Jasper60948b12015-03-15 13:55:54 +0000147 // Simple object literal, as opposed to enum style below.
148 verifyFormat("var obj = {a: 123};");
149 // Enum style top level assignment.
150 verifyFormat("X = {\n a: 123\n};");
151 verifyFormat("X.Y = {\n a: 123\n};");
Daniel Jasper11ca2632015-06-10 09:21:09 +0000152 // But only on the top level, otherwise its a plain object literal assignment.
153 verifyFormat("function x() {\n"
154 " y = {z: 1};\n"
155 "}");
Daniel Jasper60948b12015-03-15 13:55:54 +0000156 verifyFormat("x = foo && {a: 123};");
Manuel Klimek79e06082015-05-21 12:23:34 +0000157
158 // Arrow functions in object literals.
159 verifyFormat("var x = {y: (a) => { return a; }};");
160 verifyFormat("var x = {y: (a) => a};");
Daniel Jasper8c42d442015-05-29 06:19:49 +0000161
162 // Computed keys.
Daniel Jaspercd8d4ff2015-05-31 08:40:37 +0000163 verifyFormat("var x = {[a]: 1, b: 2, [c]: 3};");
Daniel Jasper8c42d442015-05-29 06:19:49 +0000164 verifyFormat("var x = {\n"
165 " [a]: 1,\n"
Daniel Jaspercd8d4ff2015-05-31 08:40:37 +0000166 " b: 2,\n"
167 " [c]: 3,\n"
Daniel Jasper8c42d442015-05-29 06:19:49 +0000168 "};");
Daniel Jasper17062ff2014-06-10 14:44:02 +0000169}
170
Daniel Jasperf46dec82015-03-31 14:34:15 +0000171TEST_F(FormatTestJS, MethodsInObjectLiterals) {
172 verifyFormat("var o = {\n"
173 " value: 'test',\n"
174 " get value() { // getter\n"
175 " return this.value;\n"
176 " }\n"
177 "};");
178 verifyFormat("var o = {\n"
179 " value: 'test',\n"
180 " set value(val) { // setter\n"
181 " this.value = val;\n"
182 " }\n"
183 "};");
184 verifyFormat("var o = {\n"
185 " value: 'test',\n"
186 " someMethod(val) { // method\n"
187 " doSomething(this.value + val);\n"
188 " }\n"
189 "};");
Daniel Jasper739ec532015-04-04 07:56:55 +0000190 verifyFormat("var o = {\n"
191 " someMethod(val) { // method\n"
192 " doSomething(this.value + val);\n"
193 " },\n"
194 " someOtherMethod(val) { // method\n"
195 " doSomething(this.value + val);\n"
196 " }\n"
197 "};");
Daniel Jasperf46dec82015-03-31 14:34:15 +0000198}
199
Daniel Jasperb2e10a52014-01-15 15:09:08 +0000200TEST_F(FormatTestJS, SpacesInContainerLiterals) {
201 verifyFormat("var arr = [1, 2, 3];");
Daniel Jaspera4e55f42014-12-04 16:07:17 +0000202 verifyFormat("f({a: 1, b: 2, c: 3});");
Nico Weber514ecc82014-02-02 20:50:45 +0000203
Daniel Jasper2a958322014-05-21 13:26:58 +0000204 verifyFormat("var object_literal_with_long_name = {\n"
205 " a: 'aaaaaaaaaaaaaaaaaa',\n"
206 " b: 'bbbbbbbbbbbbbbbbbb'\n"
207 "};");
208
Daniel Jaspera4e55f42014-12-04 16:07:17 +0000209 verifyFormat("f({a: 1, b: 2, c: 3});",
Nico Weber514ecc82014-02-02 20:50:45 +0000210 getChromiumStyle(FormatStyle::LK_JavaScript));
Daniel Jaspera4e55f42014-12-04 16:07:17 +0000211 verifyFormat("f({'a': [{}]});");
Daniel Jasperb2e10a52014-01-15 15:09:08 +0000212}
213
Daniel Jasper86fee2f2014-01-31 12:49:42 +0000214TEST_F(FormatTestJS, SingleQuoteStrings) {
215 verifyFormat("this.function('', true);");
216}
217
Daniel Jasper4a39c842014-05-06 13:54:10 +0000218TEST_F(FormatTestJS, GoogScopes) {
219 verifyFormat("goog.scope(function() {\n"
220 "var x = a.b;\n"
221 "var y = c.d;\n"
222 "}); // goog.scope");
Daniel Jasper02c7bca2015-03-30 09:56:50 +0000223 verifyFormat("goog.scope(function() {\n"
224 "// test\n"
225 "var x = 0;\n"
226 "// test\n"
227 "});");
Daniel Jasper4a39c842014-05-06 13:54:10 +0000228}
229
Daniel Jasper616de8642014-11-23 16:46:28 +0000230TEST_F(FormatTestJS, GoogModules) {
231 verifyFormat("goog.module('this.is.really.absurdly.long');",
232 getGoogleJSStyleWithColumns(40));
233 verifyFormat("goog.require('this.is.really.absurdly.long');",
234 getGoogleJSStyleWithColumns(40));
235 verifyFormat("goog.provide('this.is.really.absurdly.long');",
236 getGoogleJSStyleWithColumns(40));
237 verifyFormat("var long = goog.require('this.is.really.absurdly.long');",
238 getGoogleJSStyleWithColumns(40));
Daniel Jasper53c38f42014-11-27 14:46:03 +0000239
240 // These should be wrapped normally.
241 verifyFormat(
242 "var MyLongClassName =\n"
243 " goog.module.get('my.long.module.name.followedBy.MyLongClassName');");
Daniel Jasper616de8642014-11-23 16:46:28 +0000244}
245
Daniel Jasperad9eb0d2014-06-30 13:24:54 +0000246TEST_F(FormatTestJS, FormatsFreestandingFunctions) {
247 verifyFormat("function outer1(a, b) {\n"
248 " function inner1(a, b) { return a; }\n"
249 " inner1(a, b);\n"
250 "}\n"
251 "function outer2(a, b) {\n"
252 " function inner2(a, b) { return a; }\n"
253 " inner2(a, b);\n"
254 "}");
Daniel Jasper20580fd2015-06-11 13:31:45 +0000255 verifyFormat("function f() {}");
Daniel Jasperad9eb0d2014-06-30 13:24:54 +0000256}
257
Daniel Jasperf841d3a2015-05-28 07:21:50 +0000258TEST_F(FormatTestJS, ArrayLiterals) {
Daniel Jaspere6fcf7d2015-06-17 13:08:06 +0000259 verifyFormat("var aaaaa: List<SomeThing> =\n"
260 " [new SomeThingAAAAAAAAAAAA(), new SomeThingBBBBBBBBB()];");
Daniel Jasperd492b5e2015-06-02 21:57:51 +0000261 verifyFormat("return [\n"
262 " aaaaaaaaaaaaaaaaaaaaaaaaaaa,\n"
263 " bbbbbbbbbbbbbbbbbbbbbbbbbbb,\n"
264 " ccccccccccccccccccccccccccc\n"
265 "];");
Daniel Jasper5ce80de2015-06-02 13:56:43 +0000266 verifyFormat("var someVariable = SomeFuntion([\n"
267 " aaaaaaaaaaaaaaaaaaaaaaaaaaa,\n"
268 " bbbbbbbbbbbbbbbbbbbbbbbbbbb,\n"
269 " ccccccccccccccccccccccccccc\n"
270 "]);");
Daniel Jasper40432ce2015-06-02 15:04:29 +0000271 verifyFormat("var someVariable = SomeFuntion([\n"
272 " [aaaaaaaaaaaaaaaaaaaaaa, bbbbbbbbbbbbbbbbbbbbbb],\n"
Daniel Jasper199d0c92015-06-02 15:14:21 +0000273 "]);",
274 getGoogleJSStyleWithColumns(51));
Daniel Jasper4284e362015-06-02 14:20:08 +0000275 verifyFormat("var someVariable = SomeFuntion(aaaa, [\n"
276 " aaaaaaaaaaaaaaaaaaaaaaaaaaa,\n"
277 " bbbbbbbbbbbbbbbbbbbbbbbbbbb,\n"
278 " ccccccccccccccccccccccccccc\n"
279 "]);");
Daniel Jasperb2ad4d42015-06-15 09:23:17 +0000280 verifyFormat("var someVariable = SomeFuntion(aaaa,\n"
281 " [\n"
282 " aaaaaaaaaaaaaaaaaaaaaaaaaaa,\n"
283 " bbbbbbbbbbbbbbbbbbbbbbbbbbb,\n"
284 " ccccccccccccccccccccccccccc\n"
285 " ],\n"
286 " aaaa);");
Daniel Jasper1feab0f2015-06-02 15:31:37 +0000287
288 verifyFormat("someFunction([], {a: a});");
Daniel Jasperf841d3a2015-05-28 07:21:50 +0000289}
290
Daniel Jasper5217a8b2014-06-13 07:02:04 +0000291TEST_F(FormatTestJS, FunctionLiterals) {
Daniel Jasper3f69ba12014-09-05 08:42:27 +0000292 verifyFormat("doFoo(function() {});");
Daniel Jasper79dffb42014-05-07 09:48:30 +0000293 verifyFormat("doFoo(function() { return 1; });");
Daniel Jasper67f8ad22014-09-30 17:57:06 +0000294 verifyFormat("var func = function() {\n"
295 " return 1;\n"
296 "};");
Daniel Jaspered3f3952015-06-18 12:32:59 +0000297 verifyFormat("var func = //\n"
298 " function() {\n"
299 " return 1;\n"
300 "};");
Daniel Jasperc03e16a2014-05-08 09:25:39 +0000301 verifyFormat("return {\n"
302 " body: {\n"
303 " setAttribute: function(key, val) { this[key] = val; },\n"
304 " getAttribute: function(key) { return this[key]; },\n"
305 " style: {direction: ''}\n"
306 " }\n"
307 "};");
Daniel Jaspere551bb72014-11-05 17:22:31 +0000308 EXPECT_EQ("abc = xyz ?\n"
309 " function() {\n"
310 " return 1;\n"
311 " } :\n"
312 " function() {\n"
Daniel Jasper11a0ac62014-12-12 09:40:58 +0000313 " return -1;\n"
314 " };",
Daniel Jasper069e5f42014-05-20 11:14:57 +0000315 format("abc=xyz?function(){return 1;}:function(){return -1;};"));
Daniel Jasperb16b9692014-05-21 12:51:23 +0000316
317 verifyFormat("var closure = goog.bind(\n"
318 " function() { // comment\n"
319 " foo();\n"
320 " bar();\n"
321 " },\n"
322 " this, arg1IsReallyLongAndNeeedsLineBreaks,\n"
323 " arg3IsReallyLongAndNeeedsLineBreaks);");
324 verifyFormat("var closure = goog.bind(function() { // comment\n"
325 " foo();\n"
326 " bar();\n"
327 "}, this);");
Daniel Jasper58cb2ed2014-06-06 13:49:04 +0000328 verifyFormat("return {\n"
329 " a: 'E',\n"
330 " b: function() {\n"
331 " return function() {\n"
332 " f(); //\n"
333 " };\n"
334 " }\n"
335 "};");
Daniel Jasper41368e92014-11-27 15:37:42 +0000336 verifyFormat("{\n"
337 " var someVariable = function(x) {\n"
338 " return x.zIsTooLongForOneLineWithTheDeclarationLine();\n"
339 " };\n"
340 "}");
Daniel Jasper7325aee2015-05-08 08:38:52 +0000341 verifyFormat("someLooooooooongFunction(\n"
342 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa,\n"
343 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa,\n"
344 " function(aaaaaaaaaaaaaaaaaaaaaaaaaaaaa) {\n"
345 " // code\n"
346 " });");
Daniel Jasper5f3ea472014-05-22 08:36:53 +0000347
Daniel Jaspera4e55f42014-12-04 16:07:17 +0000348 verifyFormat("f({a: function() { return 1; }});",
349 getGoogleJSStyleWithColumns(33));
350 verifyFormat("f({\n"
Daniel Jasper5f3ea472014-05-22 08:36:53 +0000351 " a: function() { return 1; }\n"
Daniel Jaspera4e55f42014-12-04 16:07:17 +0000352 "});",
353 getGoogleJSStyleWithColumns(32));
Daniel Jasper5217a8b2014-06-13 07:02:04 +0000354
355 verifyFormat("return {\n"
356 " a: function SomeFunction() {\n"
357 " // ...\n"
358 " return 1;\n"
359 " }\n"
360 "};");
Daniel Jasper11a0ac62014-12-12 09:40:58 +0000361 verifyFormat("this.someObject.doSomething(aaaaaaaaaaaaaaaaaaaaaaaaaa)\n"
362 " .then(goog.bind(function(aaaaaaaaaaa) {\n"
363 " someFunction();\n"
364 " someFunction();\n"
365 " }, this), aaaaaaaaaaaaaaaaa);");
366
367 // FIXME: This is not ideal yet.
368 verifyFormat("someFunction(goog.bind(\n"
369 " function() {\n"
370 " doSomething();\n"
371 " doSomething();\n"
372 " },\n"
373 " this),\n"
374 " goog.bind(function() {\n"
375 " doSomething();\n"
376 " doSomething();\n"
377 " }, this));");
Daniel Jasper1699eca2015-06-01 09:56:32 +0000378
379 // FIXME: This is bad, we should be wrapping before "function() {".
380 verifyFormat("someFunction(function() {\n"
381 " doSomething(); // break\n"
382 "})\n"
383 " .doSomethingElse(\n"
384 " // break\n"
385 " );");
Daniel Jasper79dffb42014-05-07 09:48:30 +0000386}
387
Daniel Jasper67f8ad22014-09-30 17:57:06 +0000388TEST_F(FormatTestJS, InliningFunctionLiterals) {
389 FormatStyle Style = getGoogleStyle(FormatStyle::LK_JavaScript);
390 Style.AllowShortFunctionsOnASingleLine = FormatStyle::SFS_Inline;
391 verifyFormat("var func = function() {\n"
392 " return 1;\n"
393 "};",
394 Style);
395 verifyFormat("var func = doSomething(function() { return 1; });", Style);
396 verifyFormat("var outer = function() {\n"
397 " var inner = function() { return 1; }\n"
398 "};",
399 Style);
400 verifyFormat("function outer1(a, b) {\n"
401 " function inner1(a, b) { return a; }\n"
402 "}",
403 Style);
404
405 Style.AllowShortFunctionsOnASingleLine = FormatStyle::SFS_All;
406 verifyFormat("var func = function() { return 1; };", Style);
407 verifyFormat("var func = doSomething(function() { return 1; });", Style);
408 verifyFormat(
409 "var outer = function() { var inner = function() { return 1; } };",
410 Style);
411 verifyFormat("function outer1(a, b) {\n"
412 " function inner1(a, b) { return a; }\n"
413 "}",
414 Style);
415
416 Style.AllowShortFunctionsOnASingleLine = FormatStyle::SFS_None;
417 verifyFormat("var func = function() {\n"
418 " return 1;\n"
419 "};",
420 Style);
421 verifyFormat("var func = doSomething(function() {\n"
422 " return 1;\n"
423 "});",
424 Style);
425 verifyFormat("var outer = function() {\n"
426 " var inner = function() {\n"
427 " return 1;\n"
428 " }\n"
429 "};",
430 Style);
431 verifyFormat("function outer1(a, b) {\n"
432 " function inner1(a, b) {\n"
433 " return a;\n"
434 " }\n"
435 "}",
436 Style);
437}
438
Daniel Jasper114a2bc2014-06-03 12:02:45 +0000439TEST_F(FormatTestJS, MultipleFunctionLiterals) {
440 verifyFormat("promise.then(\n"
441 " function success() {\n"
442 " doFoo();\n"
443 " doBar();\n"
444 " },\n"
445 " function error() {\n"
446 " doFoo();\n"
447 " doBaz();\n"
448 " },\n"
449 " []);\n");
450 verifyFormat("promise.then(\n"
451 " function success() {\n"
452 " doFoo();\n"
453 " doBar();\n"
454 " },\n"
455 " [],\n"
456 " function error() {\n"
457 " doFoo();\n"
458 " doBaz();\n"
459 " });\n");
460 // FIXME: Here, we should probably break right after the "(" for consistency.
461 verifyFormat("promise.then([],\n"
462 " function success() {\n"
463 " doFoo();\n"
464 " doBar();\n"
465 " },\n"
466 " function error() {\n"
467 " doFoo();\n"
468 " doBaz();\n"
469 " });\n");
Daniel Jasper1779d432014-09-29 07:54:54 +0000470
471 verifyFormat("getSomeLongPromise()\n"
472 " .then(function(value) { body(); })\n"
Daniel Jasper11a0ac62014-12-12 09:40:58 +0000473 " .thenCatch(function(error) {\n"
474 " body();\n"
475 " body();\n"
476 " });");
Daniel Jasper1779d432014-09-29 07:54:54 +0000477 verifyFormat("getSomeLongPromise()\n"
478 " .then(function(value) {\n"
479 " body();\n"
480 " body();\n"
481 " })\n"
482 " .thenCatch(function(error) {\n"
483 " body();\n"
484 " body();\n"
485 " });");
Daniel Jasper11a0ac62014-12-12 09:40:58 +0000486
Daniel Jasperacf67e32015-04-07 08:20:35 +0000487 verifyFormat("getSomeLongPromise()\n"
488 " .then(function(value) { body(); })\n"
489 " .thenCatch(function(error) { body(); });");
Daniel Jasper114a2bc2014-06-03 12:02:45 +0000490}
491
Manuel Klimek79e06082015-05-21 12:23:34 +0000492TEST_F(FormatTestJS, ArrowFunctions) {
493 verifyFormat("var x = (a) => {\n"
494 " return a;\n"
495 "};");
496 verifyFormat("var x = (a) => {\n"
497 " function y() { return 42; }\n"
498 " return a;\n"
499 "};");
500 verifyFormat("var x = (a: type): {some: type} => {\n"
501 " return a;\n"
502 "};");
503 verifyFormat("var x = (a) => a;");
Daniel Jaspere497bed2015-06-02 22:06:07 +0000504 verifyFormat("return () => [];");
Daniel Jasper3c306e82015-06-03 17:08:40 +0000505 verifyFormat("var aaaaaaaaaaaaaaaaaaaa = {\n"
506 " aaaaaaaaaaaaaaaaaaaaaaaaaaaa:\n"
507 " (aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa,\n"
508 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa) =>\n"
Daniel Jasper3b0f3042015-06-05 08:25:37 +0000509 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa,\n"
Daniel Jasper3c306e82015-06-03 17:08:40 +0000510 "};");
Daniel Jasper3b0f3042015-06-05 08:25:37 +0000511 verifyFormat(
512 "var a = a.aaaaaaa((a: a) => aaaaaaaaaaaaaaaaaaaaa(bbbbbbbbb) &&\n"
513 " aaaaaaaaaaaaaaaaaaaaa(bbbbbbb));");
514 verifyFormat(
515 "var a = a.aaaaaaa((a: a) => aaaaaaaaaaaaaaaaaaaaa(bbbbbbbbb) ?\n"
516 " aaaaaaaaaaaaaaaaaaaaa(bbbbbbb) :\n"
517 " aaaaaaaaaaaaaaaaaaaaa(bbbbbbb));");
Daniel Jasper1699eca2015-06-01 09:56:32 +0000518
519 // FIXME: This is bad, we should be wrapping before "() => {".
520 verifyFormat("someFunction(() => {\n"
521 " doSomething(); // break\n"
522 "})\n"
523 " .doSomethingElse(\n"
524 " // break\n"
525 " );");
Manuel Klimek79e06082015-05-21 12:23:34 +0000526}
527
Daniel Jasper166c19b2014-05-06 14:12:21 +0000528TEST_F(FormatTestJS, ReturnStatements) {
Daniel Jasper67f8ad22014-09-30 17:57:06 +0000529 verifyFormat("function() {\n"
530 " return [hello, world];\n"
531 "}");
Daniel Jasper166c19b2014-05-06 14:12:21 +0000532}
533
Daniel Jasper4c0bf702015-06-12 04:58:27 +0000534TEST_F(FormatTestJS, AutomaticSemicolonInsertion) {
535 // The following statements must not wrap, as otherwise the program meaning
536 // would change due to automatic semicolon insertion.
537 // See http://www.ecma-international.org/ecma-262/5.1/#sec-7.9.1.
538 verifyFormat("return aaaaa;", getGoogleJSStyleWithColumns(10));
539 verifyFormat("continue aaaaa;", getGoogleJSStyleWithColumns(10));
540 verifyFormat("break aaaaa;", getGoogleJSStyleWithColumns(10));
541 verifyFormat("throw aaaaa;", getGoogleJSStyleWithColumns(10));
542 verifyFormat("aaaaaaaaa++;", getGoogleJSStyleWithColumns(10));
543 verifyFormat("aaaaaaaaa--;", getGoogleJSStyleWithColumns(10));
544}
545
Manuel Klimek79e06082015-05-21 12:23:34 +0000546TEST_F(FormatTestJS, ClosureStyleCasts) {
Daniel Jasper484033b2014-05-06 14:41:29 +0000547 verifyFormat("var x = /** @type {foo} */ (bar);");
548}
549
Daniel Jasper04a71a42014-05-08 11:58:24 +0000550TEST_F(FormatTestJS, TryCatch) {
551 verifyFormat("try {\n"
552 " f();\n"
553 "} catch (e) {\n"
554 " g();\n"
555 "} finally {\n"
556 " h();\n"
557 "}");
Daniel Jasper8f2e94c2014-09-04 15:03:34 +0000558
559 // But, of course, "catch" is a perfectly fine function name in JavaScript.
560 verifyFormat("someObject.catch();");
Daniel Jasper79121232014-11-27 14:55:17 +0000561 verifyFormat("someObject.new();");
562 verifyFormat("someObject.delete();");
Daniel Jasper04a71a42014-05-08 11:58:24 +0000563}
564
Daniel Jasper49802ef2014-05-22 09:10:04 +0000565TEST_F(FormatTestJS, StringLiteralConcatenation) {
566 verifyFormat("var literal = 'hello ' +\n"
567 " 'world';");
568}
569
Daniel Jasperf9ae3122014-05-08 07:01:45 +0000570TEST_F(FormatTestJS, RegexLiteralClassification) {
571 // Regex literals.
572 verifyFormat("var regex = /abc/;");
573 verifyFormat("f(/abc/);");
574 verifyFormat("f(abc, /abc/);");
575 verifyFormat("some_map[/abc/];");
576 verifyFormat("var x = a ? /abc/ : /abc/;");
577 verifyFormat("for (var i = 0; /abc/.test(s[i]); i++) {\n}");
578 verifyFormat("var x = !/abc/.test(y);");
579 verifyFormat("var x = a && /abc/.test(y);");
580 verifyFormat("var x = a || /abc/.test(y);");
581 verifyFormat("var x = a + /abc/.search(y);");
Daniel Jasperf7405c12014-05-08 07:45:18 +0000582 verifyFormat("var regexs = {/abc/, /abc/};");
583 verifyFormat("return /abc/;");
Daniel Jasperf9ae3122014-05-08 07:01:45 +0000584
585 // Not regex literals.
586 verifyFormat("var a = a / 2 + b / 3;");
587}
588
589TEST_F(FormatTestJS, RegexLiteralSpecialCharacters) {
Daniel Jasper69694b02015-05-08 07:55:13 +0000590 verifyFormat("var regex = /=/;");
Daniel Jasperf9ae3122014-05-08 07:01:45 +0000591 verifyFormat("var regex = /a*/;");
592 verifyFormat("var regex = /a+/;");
593 verifyFormat("var regex = /a?/;");
594 verifyFormat("var regex = /.a./;");
595 verifyFormat("var regex = /a\\*/;");
596 verifyFormat("var regex = /^a$/;");
597 verifyFormat("var regex = /\\/a/;");
598 verifyFormat("var regex = /(?:x)/;");
599 verifyFormat("var regex = /x(?=y)/;");
600 verifyFormat("var regex = /x(?!y)/;");
601 verifyFormat("var regex = /x|y/;");
602 verifyFormat("var regex = /a{2}/;");
603 verifyFormat("var regex = /a{1,3}/;");
604 verifyFormat("var regex = /[abc]/;");
605 verifyFormat("var regex = /[^abc]/;");
606 verifyFormat("var regex = /[\\b]/;");
607 verifyFormat("var regex = /\\b/;");
608 verifyFormat("var regex = /\\B/;");
609 verifyFormat("var regex = /\\d/;");
610 verifyFormat("var regex = /\\D/;");
611 verifyFormat("var regex = /\\f/;");
612 verifyFormat("var regex = /\\n/;");
613 verifyFormat("var regex = /\\r/;");
614 verifyFormat("var regex = /\\s/;");
615 verifyFormat("var regex = /\\S/;");
616 verifyFormat("var regex = /\\t/;");
617 verifyFormat("var regex = /\\v/;");
618 verifyFormat("var regex = /\\w/;");
619 verifyFormat("var regex = /\\W/;");
620 verifyFormat("var regex = /a(a)\\1/;");
621 verifyFormat("var regex = /\\0/;");
Daniel Jasperfb4333b2014-05-12 11:29:50 +0000622 verifyFormat("var regex = /\\\\/g;");
623 verifyFormat("var regex = /\\a\\\\/g;");
624 verifyFormat("var regex = /\a\\//g;");
Daniel Jasper23376252014-09-09 14:37:39 +0000625 verifyFormat("var regex = /a\\//;\n"
626 "var x = 0;");
Daniel Jasper49a9a282014-10-29 16:51:38 +0000627 EXPECT_EQ("var regex = /\\/*/;\n"
628 "var x = 0;",
629 format("var regex = /\\/*/;\n"
630 "var x=0;"));
Daniel Jasperf9ae3122014-05-08 07:01:45 +0000631}
632
633TEST_F(FormatTestJS, RegexLiteralModifiers) {
634 verifyFormat("var regex = /abc/g;");
635 verifyFormat("var regex = /abc/i;");
636 verifyFormat("var regex = /abc/m;");
637 verifyFormat("var regex = /abc/y;");
638}
639
640TEST_F(FormatTestJS, RegexLiteralLength) {
641 verifyFormat("var regex = /aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa/;",
642 getGoogleJSStyleWithColumns(60));
643 verifyFormat("var regex =\n"
644 " /aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa/;",
645 getGoogleJSStyleWithColumns(60));
Daniel Jasper0580ff02014-12-17 09:11:08 +0000646 verifyFormat("var regex = /\\xaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa/;",
647 getGoogleJSStyleWithColumns(50));
Daniel Jasperf9ae3122014-05-08 07:01:45 +0000648}
649
650TEST_F(FormatTestJS, RegexLiteralExamples) {
651 verifyFormat("var regex = search.match(/(?:\?|&)times=([^?&]+)/i);");
652}
653
Daniel Jasperb10bdff2015-02-18 17:09:53 +0000654TEST_F(FormatTestJS, TypeAnnotations) {
655 verifyFormat("var x: string;");
656 verifyFormat("function x(): string {\n return 'x';\n}");
Manuel Klimek79e06082015-05-21 12:23:34 +0000657 verifyFormat("function x(): {x: string} {\n return {x: 'x'};\n}");
Daniel Jasperb10bdff2015-02-18 17:09:53 +0000658 verifyFormat("function x(y: string): string {\n return 'x';\n}");
659 verifyFormat("for (var y: string in x) {\n x();\n}");
660 verifyFormat("((a: string, b: number): string => a + b);");
661 verifyFormat("var x: (y: number) => string;");
662 verifyFormat("var x: P<string, (a: number) => string>;");
Manuel Klimek79e06082015-05-21 12:23:34 +0000663 verifyFormat("var x = {y: function(): z { return 1; }};");
664 verifyFormat("var x = {y: function(): {a: number} { return 1; }};");
Daniel Jasperb10bdff2015-02-18 17:09:53 +0000665}
666
Daniel Jasper83709082015-02-18 17:14:05 +0000667TEST_F(FormatTestJS, ClassDeclarations) {
668 verifyFormat("class C {\n x: string = 12;\n}");
669 verifyFormat("class C {\n x(): string => 12;\n}");
670 verifyFormat("class C {\n ['x' + 2]: string = 12;\n}");
671 verifyFormat("class C {\n private x: string = 12;\n}");
672 verifyFormat("class C {\n private static x: string = 12;\n}");
673 verifyFormat("class C {\n static x(): string { return 'asd'; }\n}");
674 verifyFormat("class C extends P implements I {}");
Daniel Jasper6a5d38d2015-04-13 14:56:54 +0000675 verifyFormat("class C extends p.P implements i.I {}");
Daniel Jasper81dbb562015-06-03 08:43:18 +0000676
677 // ':' is not a type declaration here.
678 verifyFormat("class X {\n"
679 " subs = {\n"
680 " 'b': {\n"
681 " 'c': 1,\n"
682 " },\n"
683 " };\n"
684 "}");
Daniel Jasper83709082015-02-18 17:14:05 +0000685}
686
Daniel Jasper29647492015-05-05 08:12:50 +0000687TEST_F(FormatTestJS, InterfaceDeclarations) {
688 verifyFormat("interface I {\n"
689 " x: string;\n"
Daniel Jasper259188b2015-06-12 04:56:34 +0000690 "}\n"
691 "var y;");
Daniel Jasper29647492015-05-05 08:12:50 +0000692}
693
Daniel Jasper90cf3802015-06-17 09:44:02 +0000694TEST_F(FormatTestJS, EnumDeclarations) {
695 verifyFormat("enum Foo {\n"
Daniel Jasper9f4ec152015-06-17 09:44:07 +0000696 " A = 1,\n"
697 " B\n"
698 "}");
699 verifyFormat("export /* somecomment*/ enum Foo {\n"
700 " A = 1,\n"
701 " B\n"
702 "}");
703 verifyFormat("enum Foo {\n"
Daniel Jasper90cf3802015-06-17 09:44:02 +0000704 " A = 1, // comment\n"
705 " B\n"
706 "}\n"
707 "var x = 1;");
708}
709
Daniel Jasper3c42dba2015-02-18 17:17:15 +0000710TEST_F(FormatTestJS, MetadataAnnotations) {
711 verifyFormat("@A\nclass C {\n}");
712 verifyFormat("@A({arg: 'value'})\nclass C {\n}");
713 verifyFormat("@A\n@B\nclass C {\n}");
714 verifyFormat("class C {\n @A x: string;\n}");
715 verifyFormat("class C {\n"
716 " @A\n"
717 " private x(): string {\n"
718 " return 'y';\n"
719 " }\n"
720 "}");
Daniel Jasper6fa9ec72015-02-19 16:03:16 +0000721 verifyFormat("class X {}\n"
722 "class Y {}");
Daniel Jasper3c42dba2015-02-18 17:17:15 +0000723}
724
Daniel Jasper354aa512015-02-19 16:07:32 +0000725TEST_F(FormatTestJS, Modules) {
726 verifyFormat("import SomeThing from 'some/module.js';");
727 verifyFormat("import {X, Y} from 'some/module.js';");
728 verifyFormat("import {\n"
729 " VeryLongImportsAreAnnoying,\n"
730 " VeryLongImportsAreAnnoying,\n"
731 " VeryLongImportsAreAnnoying,\n"
732 " VeryLongImportsAreAnnoying\n"
733 "} from 'some/module.js';");
734 verifyFormat("import {\n"
735 " X,\n"
736 " Y,\n"
737 "} from 'some/module.js';");
738 verifyFormat("import {\n"
739 " X,\n"
740 " Y,\n"
741 "} from 'some/long/module.js';",
742 getGoogleJSStyleWithColumns(20));
743 verifyFormat("import {X as myLocalX, Y as myLocalY} from 'some/module.js';");
744 verifyFormat("import * as lib from 'some/module.js';");
Daniel Jasper60948b12015-03-15 13:55:54 +0000745 verifyFormat("var x = {import: 1};\nx.import = 2;");
Daniel Jasperfca735c2015-02-19 16:14:18 +0000746
747 verifyFormat("export function fn() {\n"
748 " return 'fn';\n"
749 "}");
Daniel Jasper20580fd2015-06-11 13:31:45 +0000750 verifyFormat("export function A() {}\n"
751 "export default function B() {}\n"
752 "export function C() {}");
Daniel Jasper354aa512015-02-19 16:07:32 +0000753 verifyFormat("export const x = 12;");
754 verifyFormat("export default class X {}");
Daniel Jasperfca735c2015-02-19 16:14:18 +0000755 verifyFormat("export {X, Y} from 'some/module.js';");
756 verifyFormat("export {\n"
757 " X,\n"
758 " Y,\n"
759 "} from 'some/module.js';");
760 verifyFormat("export class C {\n"
761 " x: number;\n"
762 " y: string;\n"
763 "}");
764 verifyFormat("export class X { y: number; }");
765 verifyFormat("export default class X { y: number }");
766 verifyFormat("export default function() {\n return 1;\n}");
767 verifyFormat("export var x = 12;");
Daniel Jasper910807d2015-06-12 04:52:02 +0000768 verifyFormat("class C {}\n"
769 "export function f() {}\n"
770 "var v;");
Daniel Jasperfca735c2015-02-19 16:14:18 +0000771 verifyFormat("export var x: number = 12;");
772 verifyFormat("export const y = {\n"
773 " a: 1,\n"
774 " b: 2\n"
775 "};");
Daniel Jasper216c9cd2015-06-12 05:08:18 +0000776 verifyFormat("export enum Foo {\n"
777 " BAR,\n"
778 " // adsdasd\n"
779 " BAZ\n"
780 "}");
Daniel Jasper354aa512015-02-19 16:07:32 +0000781}
782
Daniel Jaspera0ef4f32015-02-20 13:47:38 +0000783TEST_F(FormatTestJS, TemplateStrings) {
784 // Keeps any whitespace/indentation within the template string.
785 EXPECT_EQ("var x = `hello\n"
786 " ${ name }\n"
787 " !`;",
788 format("var x = `hello\n"
789 " ${ name }\n"
790 " !`;"));
791
792 // FIXME: +1 / -1 offsets are to work around clang-format miscalculating
793 // widths for unknown tokens that are not whitespace (e.g. '`'). Remove when
794 // the code is corrected.
795
796 verifyFormat("var x =\n"
797 " `hello ${world}` >= some();",
798 getGoogleJSStyleWithColumns(34)); // Barely doesn't fit.
799 verifyFormat("var x = `hello ${world}` >= some();",
800 getGoogleJSStyleWithColumns(35 + 1)); // Barely fits.
801 EXPECT_EQ("var x = `hello\n"
802 " ${world}` >=\n"
803 " some();",
804 format("var x =\n"
805 " `hello\n"
806 " ${world}` >= some();",
807 getGoogleJSStyleWithColumns(21))); // Barely doesn't fit.
808 EXPECT_EQ("var x = `hello\n"
809 " ${world}` >= some();",
810 format("var x =\n"
811 " `hello\n"
812 " ${world}` >= some();",
813 getGoogleJSStyleWithColumns(22))); // Barely fits.
814
815 verifyFormat("var x =\n `h`;", getGoogleJSStyleWithColumns(13 - 1));
816 EXPECT_EQ(
817 "var x =\n `multi\n line`;",
818 format("var x = `multi\n line`;", getGoogleJSStyleWithColumns(14 - 1)));
819
Daniel Jasperf69b9222015-05-02 08:05:38 +0000820 // Make sure template strings get a proper ColumnWidth assigned, even if they
821 // are first token in line.
822 verifyFormat(
823 "var a = aaaaaaaaaaaaaaaaaaaaaaaaaaaa ||\n"
824 " `aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa`;");
825
Daniel Jaspera0ef4f32015-02-20 13:47:38 +0000826 // Two template strings.
827 verifyFormat("var x = `hello` == `hello`;");
Daniel Jasper0d6ac272015-04-16 08:20:51 +0000828
829 // Comments in template strings.
830 EXPECT_EQ("var x = `//a`;\n"
831 "var y;",
832 format("var x =\n `//a`;\n"
833 "var y ;"));
834 EXPECT_EQ("var x = `/*a`;\n"
835 "var y;",
836 format("var x =\n `/*a`;\n"
837 "var y;"));
Daniel Jasper2ebb0c52015-06-14 07:16:57 +0000838 // Unterminated string literals in a template string.
839 verifyFormat("var x = `'`; // comment with matching quote '\n"
840 "var y;");
841 verifyFormat("var x = `\"`; // comment with matching quote \"\n"
842 "var y;");
Daniel Jasper0d6ac272015-04-16 08:20:51 +0000843 // Backticks in a comment - not a template string.
844 EXPECT_EQ("var x = 1 // `/*a`;\n"
845 " ;",
846 format("var x =\n 1 // `/*a`;\n"
847 " ;"));
848 EXPECT_EQ("/* ` */ var x = 1; /* ` */",
849 format("/* ` */ var x\n= 1; /* ` */"));
850 // Comment spans multiple template strings.
851 EXPECT_EQ("var x = `/*a`;\n"
852 "var y = ` */ `;",
853 format("var x =\n `/*a`;\n"
854 "var y =\n ` */ `;"));
855 // Escaped backtick.
856 EXPECT_EQ("var x = ` \\` a`;\n"
857 "var y;",
858 format("var x = ` \\` a`;\n"
859 "var y;"));
Daniel Jaspera0ef4f32015-02-20 13:47:38 +0000860}
861
Daniel Jaspere6fcf7d2015-06-17 13:08:06 +0000862TEST_F(FormatTestJS, CastSyntax) { verifyFormat("var x = <type>foo;"); }
Daniel Jasperbc46b932015-03-15 13:59:51 +0000863
864TEST_F(FormatTestJS, TypeArguments) {
865 verifyFormat("class X<Y> {}");
866 verifyFormat("new X<Y>();");
867 verifyFormat("foo<Y>(a);");
868 verifyFormat("var x: X<Y>[];");
869 verifyFormat("class C extends D<E> implements F<G>, H<I> {}");
Daniel Jasper20580fd2015-06-11 13:31:45 +0000870 verifyFormat("function f(a: List<any> = null) {}");
871 verifyFormat("function f(): List<any> {}");
Daniel Jasperbc46b932015-03-15 13:59:51 +0000872}
873
Daniel Jaspera74f5072015-04-13 15:01:40 +0000874TEST_F(FormatTestJS, OptionalTypes) {
Daniel Jasper20580fd2015-06-11 13:31:45 +0000875 verifyFormat("function x(a?: b, c?, d?) {}");
Daniel Jaspera74f5072015-04-13 15:01:40 +0000876 verifyFormat("class X {\n"
877 " y?: z;\n"
878 " z?;\n"
879 "}");
Daniel Jasper9326f912015-05-05 08:40:32 +0000880 verifyFormat("interface X {\n"
881 " y?(): z;\n"
882 "}");
883 verifyFormat("x ? 1 : 2;");
Daniel Jasper3e0dcc22015-05-27 05:37:40 +0000884 verifyFormat("constructor({aa}: {\n"
885 " aa?: string,\n"
886 " aaaaaaaa?: string,\n"
887 " aaaaaaaaaaaaaaa?: boolean,\n"
888 " aaaaaa?: List<string>\n"
Daniel Jasper20580fd2015-06-11 13:31:45 +0000889 "}) {}");
Daniel Jaspera74f5072015-04-13 15:01:40 +0000890}
891
Daniel Jasperd9309772015-04-13 15:03:30 +0000892TEST_F(FormatTestJS, IndexSignature) {
893 verifyFormat("var x: {[k: string]: v};");
894}
895
Alexander Kornienko3d9d9292015-06-22 09:47:44 +0000896} // namespace format
Alexander Kornienkoa48a12c2013-12-03 10:50:16 +0000897} // end namespace clang