blob: d0b299877e0f297bb984fce1317fb33b08c7b1f4 [file] [log] [blame]
Chris Lattnerda463fe2007-12-12 07:09:47 +00001//===--- SemaDeclObjC.cpp - Semantic Analysis for ObjC Declarations -------===//
2//
3// The LLVM Compiler Infrastructure
4//
Chris Lattner5b12ab82007-12-29 19:59:25 +00005// This file is distributed under the University of Illinois Open Source
6// License. See LICENSE.TXT for details.
Chris Lattnerda463fe2007-12-12 07:09:47 +00007//
8//===----------------------------------------------------------------------===//
9//
10// This file implements semantic analysis for Objective C declarations.
11//
12//===----------------------------------------------------------------------===//
13
John McCall83024632010-08-25 22:03:47 +000014#include "clang/Sema/SemaInternal.h"
John McCall31168b02011-06-15 23:02:42 +000015#include "clang/AST/ASTConsumer.h"
Chandler Carruth3a022472012-12-04 09:13:33 +000016#include "clang/AST/ASTContext.h"
17#include "clang/AST/ASTMutationListener.h"
Argyrios Kyrtzidis2080d902014-01-03 18:32:18 +000018#include "clang/AST/DataRecursiveASTVisitor.h"
Chandler Carruth3a022472012-12-04 09:13:33 +000019#include "clang/AST/DeclObjC.h"
Steve Naroff157599f2009-03-03 14:49:36 +000020#include "clang/AST/Expr.h"
John McCall31168b02011-06-15 23:02:42 +000021#include "clang/AST/ExprObjC.h"
John McCall31168b02011-06-15 23:02:42 +000022#include "clang/Basic/SourceManager.h"
Chandler Carruth3a022472012-12-04 09:13:33 +000023#include "clang/Sema/DeclSpec.h"
24#include "clang/Sema/ExternalSemaSource.h"
25#include "clang/Sema/Lookup.h"
26#include "clang/Sema/Scope.h"
27#include "clang/Sema/ScopeInfo.h"
John McCalla1e130b2010-08-25 07:03:20 +000028#include "llvm/ADT/DenseSet.h"
29
Chris Lattnerda463fe2007-12-12 07:09:47 +000030using namespace clang;
31
John McCall31168b02011-06-15 23:02:42 +000032/// Check whether the given method, which must be in the 'init'
33/// family, is a valid member of that family.
34///
35/// \param receiverTypeIfCall - if null, check this as if declaring it;
36/// if non-null, check this as if making a call to it with the given
37/// receiver type
38///
39/// \return true to indicate that there was an error and appropriate
40/// actions were taken
41bool Sema::checkInitMethod(ObjCMethodDecl *method,
42 QualType receiverTypeIfCall) {
43 if (method->isInvalidDecl()) return true;
44
45 // This castAs is safe: methods that don't return an object
46 // pointer won't be inferred as inits and will reject an explicit
47 // objc_method_family(init).
48
49 // We ignore protocols here. Should we? What about Class?
50
Alp Toker314cc812014-01-25 16:55:45 +000051 const ObjCObjectType *result =
52 method->getReturnType()->castAs<ObjCObjectPointerType>()->getObjectType();
John McCall31168b02011-06-15 23:02:42 +000053
54 if (result->isObjCId()) {
55 return false;
56 } else if (result->isObjCClass()) {
57 // fall through: always an error
58 } else {
59 ObjCInterfaceDecl *resultClass = result->getInterface();
60 assert(resultClass && "unexpected object type!");
61
62 // It's okay for the result type to still be a forward declaration
63 // if we're checking an interface declaration.
Douglas Gregordc9166c2011-12-15 20:29:51 +000064 if (!resultClass->hasDefinition()) {
John McCall31168b02011-06-15 23:02:42 +000065 if (receiverTypeIfCall.isNull() &&
66 !isa<ObjCImplementationDecl>(method->getDeclContext()))
67 return false;
68
69 // Otherwise, we try to compare class types.
70 } else {
71 // If this method was declared in a protocol, we can't check
72 // anything unless we have a receiver type that's an interface.
Craig Topperc3ec1492014-05-26 06:22:03 +000073 const ObjCInterfaceDecl *receiverClass = nullptr;
John McCall31168b02011-06-15 23:02:42 +000074 if (isa<ObjCProtocolDecl>(method->getDeclContext())) {
75 if (receiverTypeIfCall.isNull())
76 return false;
77
78 receiverClass = receiverTypeIfCall->castAs<ObjCObjectPointerType>()
79 ->getInterfaceDecl();
80
81 // This can be null for calls to e.g. id<Foo>.
82 if (!receiverClass) return false;
83 } else {
84 receiverClass = method->getClassInterface();
85 assert(receiverClass && "method not associated with a class!");
86 }
87
88 // If either class is a subclass of the other, it's fine.
89 if (receiverClass->isSuperClassOf(resultClass) ||
90 resultClass->isSuperClassOf(receiverClass))
91 return false;
92 }
93 }
94
95 SourceLocation loc = method->getLocation();
96
97 // If we're in a system header, and this is not a call, just make
98 // the method unusable.
99 if (receiverTypeIfCall.isNull() && getSourceManager().isInSystemHeader(loc)) {
Aaron Ballman36a53502014-01-16 13:03:14 +0000100 method->addAttr(UnavailableAttr::CreateImplicit(Context,
101 "init method returns a type unrelated to its receiver type",
102 loc));
John McCall31168b02011-06-15 23:02:42 +0000103 return true;
104 }
105
106 // Otherwise, it's an error.
107 Diag(loc, diag::err_arc_init_method_unrelated_result_type);
108 method->setInvalidDecl();
109 return true;
110}
111
Fariborz Jahanianac8dbf02011-09-27 22:35:36 +0000112void Sema::CheckObjCMethodOverride(ObjCMethodDecl *NewMethod,
Douglas Gregor66a8ca02013-01-15 22:43:08 +0000113 const ObjCMethodDecl *Overridden) {
Douglas Gregor33823722011-06-11 01:09:30 +0000114 if (Overridden->hasRelatedResultType() &&
115 !NewMethod->hasRelatedResultType()) {
116 // This can only happen when the method follows a naming convention that
117 // implies a related result type, and the original (overridden) method has
118 // a suitable return type, but the new (overriding) method does not have
119 // a suitable return type.
Alp Toker314cc812014-01-25 16:55:45 +0000120 QualType ResultType = NewMethod->getReturnType();
Aaron Ballman41b10ac2014-08-01 13:20:09 +0000121 SourceRange ResultTypeRange = NewMethod->getReturnTypeSourceRange();
Douglas Gregor33823722011-06-11 01:09:30 +0000122
123 // Figure out which class this method is part of, if any.
124 ObjCInterfaceDecl *CurrentClass
125 = dyn_cast<ObjCInterfaceDecl>(NewMethod->getDeclContext());
126 if (!CurrentClass) {
127 DeclContext *DC = NewMethod->getDeclContext();
128 if (ObjCCategoryDecl *Cat = dyn_cast<ObjCCategoryDecl>(DC))
129 CurrentClass = Cat->getClassInterface();
130 else if (ObjCImplDecl *Impl = dyn_cast<ObjCImplDecl>(DC))
131 CurrentClass = Impl->getClassInterface();
132 else if (ObjCCategoryImplDecl *CatImpl
133 = dyn_cast<ObjCCategoryImplDecl>(DC))
134 CurrentClass = CatImpl->getClassInterface();
135 }
136
137 if (CurrentClass) {
138 Diag(NewMethod->getLocation(),
139 diag::warn_related_result_type_compatibility_class)
140 << Context.getObjCInterfaceType(CurrentClass)
141 << ResultType
142 << ResultTypeRange;
143 } else {
144 Diag(NewMethod->getLocation(),
145 diag::warn_related_result_type_compatibility_protocol)
146 << ResultType
147 << ResultTypeRange;
148 }
149
Douglas Gregorbab8a962011-09-08 01:46:34 +0000150 if (ObjCMethodFamily Family = Overridden->getMethodFamily())
151 Diag(Overridden->getLocation(),
John McCall5ec7e7d2013-03-19 07:04:25 +0000152 diag::note_related_result_type_family)
153 << /*overridden method*/ 0
Douglas Gregorbab8a962011-09-08 01:46:34 +0000154 << Family;
155 else
156 Diag(Overridden->getLocation(),
157 diag::note_related_result_type_overridden);
Douglas Gregor33823722011-06-11 01:09:30 +0000158 }
David Blaikiebbafb8a2012-03-11 07:00:24 +0000159 if (getLangOpts().ObjCAutoRefCount) {
Fariborz Jahanianac8dbf02011-09-27 22:35:36 +0000160 if ((NewMethod->hasAttr<NSReturnsRetainedAttr>() !=
161 Overridden->hasAttr<NSReturnsRetainedAttr>())) {
162 Diag(NewMethod->getLocation(),
163 diag::err_nsreturns_retained_attribute_mismatch) << 1;
164 Diag(Overridden->getLocation(), diag::note_previous_decl)
165 << "method";
166 }
167 if ((NewMethod->hasAttr<NSReturnsNotRetainedAttr>() !=
168 Overridden->hasAttr<NSReturnsNotRetainedAttr>())) {
169 Diag(NewMethod->getLocation(),
170 diag::err_nsreturns_retained_attribute_mismatch) << 0;
171 Diag(Overridden->getLocation(), diag::note_previous_decl)
172 << "method";
173 }
Douglas Gregor0bf70f42012-05-17 23:13:29 +0000174 ObjCMethodDecl::param_const_iterator oi = Overridden->param_begin(),
175 oe = Overridden->param_end();
Argyrios Kyrtzidisb8c3aaf2011-10-03 06:37:04 +0000176 for (ObjCMethodDecl::param_iterator
177 ni = NewMethod->param_begin(), ne = NewMethod->param_end();
Douglas Gregor0bf70f42012-05-17 23:13:29 +0000178 ni != ne && oi != oe; ++ni, ++oi) {
Argyrios Kyrtzidisb8c3aaf2011-10-03 06:37:04 +0000179 const ParmVarDecl *oldDecl = (*oi);
Fariborz Jahanianac8dbf02011-09-27 22:35:36 +0000180 ParmVarDecl *newDecl = (*ni);
181 if (newDecl->hasAttr<NSConsumedAttr>() !=
182 oldDecl->hasAttr<NSConsumedAttr>()) {
183 Diag(newDecl->getLocation(),
184 diag::err_nsconsumed_attribute_mismatch);
185 Diag(oldDecl->getLocation(), diag::note_previous_decl)
186 << "parameter";
187 }
188 }
189 }
Douglas Gregor33823722011-06-11 01:09:30 +0000190}
191
John McCall31168b02011-06-15 23:02:42 +0000192/// \brief Check a method declaration for compatibility with the Objective-C
193/// ARC conventions.
John McCalle48f3892013-04-04 01:38:37 +0000194bool Sema::CheckARCMethodDecl(ObjCMethodDecl *method) {
John McCall31168b02011-06-15 23:02:42 +0000195 ObjCMethodFamily family = method->getMethodFamily();
196 switch (family) {
197 case OMF_None:
Nico Weber1fb82662011-08-28 22:35:17 +0000198 case OMF_finalize:
John McCall31168b02011-06-15 23:02:42 +0000199 case OMF_retain:
200 case OMF_release:
201 case OMF_autorelease:
202 case OMF_retainCount:
203 case OMF_self:
Fariborz Jahanian78e9deb2014-08-22 16:57:26 +0000204 case OMF_initialize:
John McCalld2930c22011-07-22 02:45:48 +0000205 case OMF_performSelector:
John McCall31168b02011-06-15 23:02:42 +0000206 return false;
207
Fariborz Jahanianb7f03c12012-07-30 20:52:48 +0000208 case OMF_dealloc:
Alp Toker314cc812014-01-25 16:55:45 +0000209 if (!Context.hasSameType(method->getReturnType(), Context.VoidTy)) {
Aaron Ballman41b10ac2014-08-01 13:20:09 +0000210 SourceRange ResultTypeRange = method->getReturnTypeSourceRange();
Fariborz Jahanianb7f03c12012-07-30 20:52:48 +0000211 if (ResultTypeRange.isInvalid())
Alp Toker314cc812014-01-25 16:55:45 +0000212 Diag(method->getLocation(), diag::error_dealloc_bad_result_type)
213 << method->getReturnType()
214 << FixItHint::CreateInsertion(method->getSelectorLoc(0), "(void)");
Fariborz Jahanianb7f03c12012-07-30 20:52:48 +0000215 else
Alp Toker314cc812014-01-25 16:55:45 +0000216 Diag(method->getLocation(), diag::error_dealloc_bad_result_type)
217 << method->getReturnType()
218 << FixItHint::CreateReplacement(ResultTypeRange, "void");
Fariborz Jahanianb7f03c12012-07-30 20:52:48 +0000219 return true;
220 }
221 return false;
222
John McCall31168b02011-06-15 23:02:42 +0000223 case OMF_init:
224 // If the method doesn't obey the init rules, don't bother annotating it.
John McCalle48f3892013-04-04 01:38:37 +0000225 if (checkInitMethod(method, QualType()))
John McCall31168b02011-06-15 23:02:42 +0000226 return true;
227
Aaron Ballman36a53502014-01-16 13:03:14 +0000228 method->addAttr(NSConsumesSelfAttr::CreateImplicit(Context));
John McCall31168b02011-06-15 23:02:42 +0000229
230 // Don't add a second copy of this attribute, but otherwise don't
231 // let it be suppressed.
232 if (method->hasAttr<NSReturnsRetainedAttr>())
233 return false;
234 break;
235
236 case OMF_alloc:
237 case OMF_copy:
238 case OMF_mutableCopy:
239 case OMF_new:
240 if (method->hasAttr<NSReturnsRetainedAttr>() ||
241 method->hasAttr<NSReturnsNotRetainedAttr>() ||
242 method->hasAttr<NSReturnsAutoreleasedAttr>())
243 return false;
244 break;
245 }
246
Aaron Ballman36a53502014-01-16 13:03:14 +0000247 method->addAttr(NSReturnsRetainedAttr::CreateImplicit(Context));
John McCall31168b02011-06-15 23:02:42 +0000248 return false;
249}
250
Fariborz Jahaniand724a102011-02-15 17:49:58 +0000251static void DiagnoseObjCImplementedDeprecations(Sema &S,
252 NamedDecl *ND,
253 SourceLocation ImplLoc,
254 int select) {
Douglas Gregor20b2ebd2011-03-23 00:50:03 +0000255 if (ND && ND->isDeprecated()) {
Fariborz Jahanian6fd94352011-02-16 00:30:31 +0000256 S.Diag(ImplLoc, diag::warn_deprecated_def) << select;
Fariborz Jahaniand724a102011-02-15 17:49:58 +0000257 if (select == 0)
Ted Kremenek59b10db2012-02-27 22:55:11 +0000258 S.Diag(ND->getLocation(), diag::note_method_declared_at)
259 << ND->getDeclName();
Fariborz Jahaniand724a102011-02-15 17:49:58 +0000260 else
261 S.Diag(ND->getLocation(), diag::note_previous_decl) << "class";
262 }
263}
264
Fariborz Jahanianbd0642f2011-08-31 17:37:55 +0000265/// AddAnyMethodToGlobalPool - Add any method, instance or factory to global
266/// pool.
267void Sema::AddAnyMethodToGlobalPool(Decl *D) {
268 ObjCMethodDecl *MDecl = dyn_cast_or_null<ObjCMethodDecl>(D);
269
270 // If we don't have a valid method decl, simply return.
271 if (!MDecl)
272 return;
273 if (MDecl->isInstanceMethod())
274 AddInstanceMethodToGlobalPool(MDecl, true);
275 else
276 AddFactoryMethodToGlobalPool(MDecl, true);
277}
278
Fariborz Jahanian1dfeace2012-09-13 18:53:14 +0000279/// HasExplicitOwnershipAttr - returns true when pointer to ObjC pointer
280/// has explicit ownership attribute; false otherwise.
281static bool
282HasExplicitOwnershipAttr(Sema &S, ParmVarDecl *Param) {
283 QualType T = Param->getType();
284
Fariborz Jahanian1dfeace2012-09-13 18:53:14 +0000285 if (const PointerType *PT = T->getAs<PointerType>()) {
286 T = PT->getPointeeType();
287 } else if (const ReferenceType *RT = T->getAs<ReferenceType>()) {
288 T = RT->getPointeeType();
289 } else {
290 return true;
291 }
292
293 // If we have a lifetime qualifier, but it's local, we must have
294 // inferred it. So, it is implicit.
295 return !T.getLocalQualifiers().hasObjCLifetime();
296}
297
Fariborz Jahanian18d0a5d2012-08-08 23:41:08 +0000298/// ActOnStartOfObjCMethodDef - This routine sets up parameters; invisible
299/// and user declared, in the method definition's AST.
300void Sema::ActOnStartOfObjCMethodDef(Scope *FnBodyScope, Decl *D) {
Craig Topperc3ec1492014-05-26 06:22:03 +0000301 assert((getCurMethodDecl() == nullptr) && "Methodparsing confused");
John McCall48871652010-08-21 09:40:31 +0000302 ObjCMethodDecl *MDecl = dyn_cast_or_null<ObjCMethodDecl>(D);
Fariborz Jahanian577574a2012-07-02 23:37:09 +0000303
Steve Naroff542cd5d2008-07-25 17:57:26 +0000304 // If we don't have a valid method decl, simply return.
305 if (!MDecl)
306 return;
Steve Naroff1d2538c2007-12-18 01:30:32 +0000307
Chris Lattnerda463fe2007-12-12 07:09:47 +0000308 // Allow all of Sema to see that we are entering a method definition.
Douglas Gregor91f84212008-12-11 16:49:14 +0000309 PushDeclContext(FnBodyScope, MDecl);
Douglas Gregor9a28e842010-03-01 23:15:13 +0000310 PushFunctionScope();
311
Chris Lattnerda463fe2007-12-12 07:09:47 +0000312 // Create Decl objects for each parameter, entrring them in the scope for
313 // binding to their use.
Chris Lattnerda463fe2007-12-12 07:09:47 +0000314
315 // Insert the invisible arguments, self and _cmd!
Fariborz Jahanian3d8552a2008-12-09 20:23:04 +0000316 MDecl->createImplicitParams(Context, MDecl->getClassInterface());
Mike Stump11289f42009-09-09 15:08:12 +0000317
Daniel Dunbar279d1cc2008-08-26 06:07:48 +0000318 PushOnScopeChains(MDecl->getSelfDecl(), FnBodyScope);
319 PushOnScopeChains(MDecl->getCmdDecl(), FnBodyScope);
Chris Lattneraa9c7ae2008-04-08 04:40:51 +0000320
Reid Kleckner5a115802013-06-24 14:38:26 +0000321 // The ObjC parser requires parameter names so there's no need to check.
322 CheckParmsForFunctionDef(MDecl->param_begin(), MDecl->param_end(),
323 /*CheckParameterNames=*/false);
324
Chris Lattner58258242008-04-10 02:22:51 +0000325 // Introduce all of the other parameters into this scope.
Aaron Ballman43b68be2014-03-07 17:50:17 +0000326 for (auto *Param : MDecl->params()) {
Fariborz Jahanianb3e87122010-09-17 22:07:07 +0000327 if (!Param->isInvalidDecl() &&
Fariborz Jahanian1dfeace2012-09-13 18:53:14 +0000328 getLangOpts().ObjCAutoRefCount &&
329 !HasExplicitOwnershipAttr(*this, Param))
330 Diag(Param->getLocation(), diag::warn_arc_strong_pointer_objc_pointer) <<
331 Param->getType();
Fariborz Jahaniancd278ff2012-08-30 23:56:02 +0000332
Aaron Ballman43b68be2014-03-07 17:50:17 +0000333 if (Param->getIdentifier())
334 PushOnScopeChains(Param, FnBodyScope);
Fariborz Jahanianb3e87122010-09-17 22:07:07 +0000335 }
John McCall31168b02011-06-15 23:02:42 +0000336
337 // In ARC, disallow definition of retain/release/autorelease/retainCount
David Blaikiebbafb8a2012-03-11 07:00:24 +0000338 if (getLangOpts().ObjCAutoRefCount) {
John McCall31168b02011-06-15 23:02:42 +0000339 switch (MDecl->getMethodFamily()) {
340 case OMF_retain:
341 case OMF_retainCount:
342 case OMF_release:
343 case OMF_autorelease:
344 Diag(MDecl->getLocation(), diag::err_arc_illegal_method_def)
Fariborz Jahanian39d1c422013-05-16 19:08:44 +0000345 << 0 << MDecl->getSelector();
John McCall31168b02011-06-15 23:02:42 +0000346 break;
347
348 case OMF_None:
349 case OMF_dealloc:
Nico Weber1fb82662011-08-28 22:35:17 +0000350 case OMF_finalize:
John McCall31168b02011-06-15 23:02:42 +0000351 case OMF_alloc:
352 case OMF_init:
353 case OMF_mutableCopy:
354 case OMF_copy:
355 case OMF_new:
356 case OMF_self:
Fariborz Jahanian78e9deb2014-08-22 16:57:26 +0000357 case OMF_initialize:
Fariborz Jahanianb7a77362011-07-05 22:38:59 +0000358 case OMF_performSelector:
John McCall31168b02011-06-15 23:02:42 +0000359 break;
360 }
361 }
362
Nico Weber715abaf2011-08-22 17:25:57 +0000363 // Warn on deprecated methods under -Wdeprecated-implementations,
364 // and prepare for warning on missing super calls.
365 if (ObjCInterfaceDecl *IC = MDecl->getClassInterface()) {
Fariborz Jahanian566fff02012-09-07 23:46:23 +0000366 ObjCMethodDecl *IMD =
367 IC->lookupMethod(MDecl->getSelector(), MDecl->isInstanceMethod());
368
Fariborz Jahaniand91d21c2012-11-17 20:53:53 +0000369 if (IMD) {
370 ObjCImplDecl *ImplDeclOfMethodDef =
371 dyn_cast<ObjCImplDecl>(MDecl->getDeclContext());
372 ObjCContainerDecl *ContDeclOfMethodDecl =
373 dyn_cast<ObjCContainerDecl>(IMD->getDeclContext());
Craig Topperc3ec1492014-05-26 06:22:03 +0000374 ObjCImplDecl *ImplDeclOfMethodDecl = nullptr;
Fariborz Jahaniand91d21c2012-11-17 20:53:53 +0000375 if (ObjCInterfaceDecl *OID = dyn_cast<ObjCInterfaceDecl>(ContDeclOfMethodDecl))
376 ImplDeclOfMethodDecl = OID->getImplementation();
Fariborz Jahanianed39e7c2014-03-18 16:25:22 +0000377 else if (ObjCCategoryDecl *CD = dyn_cast<ObjCCategoryDecl>(ContDeclOfMethodDecl)) {
378 if (CD->IsClassExtension()) {
379 if (ObjCInterfaceDecl *OID = CD->getClassInterface())
380 ImplDeclOfMethodDecl = OID->getImplementation();
381 } else
382 ImplDeclOfMethodDecl = CD->getImplementation();
Fariborz Jahanian19a08bb2014-03-18 00:10:37 +0000383 }
Fariborz Jahaniand91d21c2012-11-17 20:53:53 +0000384 // No need to issue deprecated warning if deprecated mehod in class/category
385 // is being implemented in its own implementation (no overriding is involved).
Fariborz Jahanianed39e7c2014-03-18 16:25:22 +0000386 if (!ImplDeclOfMethodDecl || ImplDeclOfMethodDecl != ImplDeclOfMethodDef)
Fariborz Jahaniand91d21c2012-11-17 20:53:53 +0000387 DiagnoseObjCImplementedDeprecations(*this,
Fariborz Jahaniand724a102011-02-15 17:49:58 +0000388 dyn_cast<NamedDecl>(IMD),
389 MDecl->getLocation(), 0);
Fariborz Jahaniand91d21c2012-11-17 20:53:53 +0000390 }
Nico Weber715abaf2011-08-22 17:25:57 +0000391
Argyrios Kyrtzidisb66d3cf2013-12-03 21:11:49 +0000392 if (MDecl->getMethodFamily() == OMF_init) {
393 if (MDecl->isDesignatedInitializerForTheInterface()) {
394 getCurFunction()->ObjCIsDesignatedInit = true;
Fariborz Jahaniane3b5c992014-03-14 23:30:18 +0000395 getCurFunction()->ObjCWarnForNoDesignatedInitChain =
Craig Topperc3ec1492014-05-26 06:22:03 +0000396 IC->getSuperClass() != nullptr;
Argyrios Kyrtzidisb66d3cf2013-12-03 21:11:49 +0000397 } else if (IC->hasDesignatedInitializers()) {
398 getCurFunction()->ObjCIsSecondaryInit = true;
Fariborz Jahaniane3b5c992014-03-14 23:30:18 +0000399 getCurFunction()->ObjCWarnForNoInitDelegation = true;
Argyrios Kyrtzidisb66d3cf2013-12-03 21:11:49 +0000400 }
401 }
Argyrios Kyrtzidis22bfa2c2013-12-03 21:11:36 +0000402
Nico Weber1fb82662011-08-28 22:35:17 +0000403 // If this is "dealloc" or "finalize", set some bit here.
Nico Weber715abaf2011-08-22 17:25:57 +0000404 // Then in ActOnSuperMessage() (SemaExprObjC), set it back to false.
405 // Finally, in ActOnFinishFunctionBody() (SemaDecl), warn if flag is set.
406 // Only do this if the current class actually has a superclass.
Jordan Rosed03d99d2013-03-05 01:27:54 +0000407 if (const ObjCInterfaceDecl *SuperClass = IC->getSuperClass()) {
Jordan Rose2afd6612012-10-19 16:05:26 +0000408 ObjCMethodFamily Family = MDecl->getMethodFamily();
409 if (Family == OMF_dealloc) {
410 if (!(getLangOpts().ObjCAutoRefCount ||
411 getLangOpts().getGC() == LangOptions::GCOnly))
412 getCurFunction()->ObjCShouldCallSuper = true;
413
414 } else if (Family == OMF_finalize) {
415 if (Context.getLangOpts().getGC() != LangOptions::NonGC)
416 getCurFunction()->ObjCShouldCallSuper = true;
417
Fariborz Jahaniance4bbb22013-11-05 00:28:21 +0000418 } else {
Jordan Rose2afd6612012-10-19 16:05:26 +0000419 const ObjCMethodDecl *SuperMethod =
Jordan Rosed03d99d2013-03-05 01:27:54 +0000420 SuperClass->lookupMethod(MDecl->getSelector(),
421 MDecl->isInstanceMethod());
Jordan Rose2afd6612012-10-19 16:05:26 +0000422 getCurFunction()->ObjCShouldCallSuper =
423 (SuperMethod && SuperMethod->hasAttr<ObjCRequiresSuperAttr>());
Fariborz Jahaniand6876b22012-09-10 18:04:25 +0000424 }
Nico Weber1fb82662011-08-28 22:35:17 +0000425 }
Nico Weber715abaf2011-08-22 17:25:57 +0000426 }
Chris Lattnerda463fe2007-12-12 07:09:47 +0000427}
428
Kaelyn Uhraine31b8882012-01-13 01:32:50 +0000429namespace {
430
431// Callback to only accept typo corrections that are Objective-C classes.
432// If an ObjCInterfaceDecl* is given to the constructor, then the validation
433// function will reject corrections to that class.
434class ObjCInterfaceValidatorCCC : public CorrectionCandidateCallback {
435 public:
Craig Topperc3ec1492014-05-26 06:22:03 +0000436 ObjCInterfaceValidatorCCC() : CurrentIDecl(nullptr) {}
Kaelyn Uhraine31b8882012-01-13 01:32:50 +0000437 explicit ObjCInterfaceValidatorCCC(ObjCInterfaceDecl *IDecl)
438 : CurrentIDecl(IDecl) {}
439
Craig Toppere14c0f82014-03-12 04:55:44 +0000440 bool ValidateCandidate(const TypoCorrection &candidate) override {
Kaelyn Uhraine31b8882012-01-13 01:32:50 +0000441 ObjCInterfaceDecl *ID = candidate.getCorrectionDeclAs<ObjCInterfaceDecl>();
442 return ID && !declaresSameEntity(ID, CurrentIDecl);
443 }
444
445 private:
446 ObjCInterfaceDecl *CurrentIDecl;
447};
448
Alexander Kornienkoab9db512015-06-22 23:07:51 +0000449}
Kaelyn Uhraine31b8882012-01-13 01:32:50 +0000450
Argyrios Kyrtzidis4ecdd2c2015-04-19 20:15:55 +0000451static void diagnoseUseOfProtocols(Sema &TheSema,
452 ObjCContainerDecl *CD,
453 ObjCProtocolDecl *const *ProtoRefs,
454 unsigned NumProtoRefs,
455 const SourceLocation *ProtoLocs) {
456 assert(ProtoRefs);
457 // Diagnose availability in the context of the ObjC container.
458 Sema::ContextRAII SavedContext(TheSema, CD);
459 for (unsigned i = 0; i < NumProtoRefs; ++i) {
460 (void)TheSema.DiagnoseUseOfDecl(ProtoRefs[i], ProtoLocs[i]);
461 }
462}
463
John McCall48871652010-08-21 09:40:31 +0000464Decl *Sema::
Chris Lattnerd7352d62008-07-21 22:17:28 +0000465ActOnStartClassInterface(SourceLocation AtInterfaceLoc,
466 IdentifierInfo *ClassName, SourceLocation ClassLoc,
467 IdentifierInfo *SuperName, SourceLocation SuperLoc,
John McCall48871652010-08-21 09:40:31 +0000468 Decl * const *ProtoRefs, unsigned NumProtoRefs,
Douglas Gregor002b6712010-01-16 15:02:53 +0000469 const SourceLocation *ProtoLocs,
Chris Lattnerd7352d62008-07-21 22:17:28 +0000470 SourceLocation EndProtoLoc, AttributeList *AttrList) {
Chris Lattnerda463fe2007-12-12 07:09:47 +0000471 assert(ClassName && "Missing class identifier");
Mike Stump11289f42009-09-09 15:08:12 +0000472
Chris Lattnerda463fe2007-12-12 07:09:47 +0000473 // Check for another declaration kind with the same name.
Douglas Gregorb2ccf012010-04-15 22:33:43 +0000474 NamedDecl *PrevDecl = LookupSingleName(TUScope, ClassName, ClassLoc,
Douglas Gregorb8eaf292010-04-15 23:40:53 +0000475 LookupOrdinaryName, ForRedeclaration);
Douglas Gregor5101c242008-12-05 18:15:24 +0000476
Ted Kremenek1b0ea822008-01-07 19:49:32 +0000477 if (PrevDecl && !isa<ObjCInterfaceDecl>(PrevDecl)) {
Chris Lattner4bd8dd82008-11-19 08:23:25 +0000478 Diag(ClassLoc, diag::err_redefinition_different_kind) << ClassName;
Chris Lattner0369c572008-11-23 23:12:31 +0000479 Diag(PrevDecl->getLocation(), diag::note_previous_definition);
Chris Lattnerda463fe2007-12-12 07:09:47 +0000480 }
Mike Stump11289f42009-09-09 15:08:12 +0000481
Douglas Gregordc9166c2011-12-15 20:29:51 +0000482 // Create a declaration to describe this @interface.
Douglas Gregorab1ec82e2011-12-16 03:12:41 +0000483 ObjCInterfaceDecl* PrevIDecl = dyn_cast_or_null<ObjCInterfaceDecl>(PrevDecl);
Argyrios Kyrtzidisdd710632013-06-18 21:26:33 +0000484
485 if (PrevIDecl && PrevIDecl->getIdentifier() != ClassName) {
486 // A previous decl with a different name is because of
487 // @compatibility_alias, for example:
488 // \code
489 // @class NewImage;
490 // @compatibility_alias OldImage NewImage;
491 // \endcode
492 // A lookup for 'OldImage' will return the 'NewImage' decl.
493 //
494 // In such a case use the real declaration name, instead of the alias one,
495 // otherwise we will break IdentifierResolver and redecls-chain invariants.
496 // FIXME: If necessary, add a bit to indicate that this ObjCInterfaceDecl
497 // has been aliased.
498 ClassName = PrevIDecl->getIdentifier();
499 }
500
Douglas Gregordc9166c2011-12-15 20:29:51 +0000501 ObjCInterfaceDecl *IDecl
502 = ObjCInterfaceDecl::Create(Context, CurContext, AtInterfaceLoc, ClassName,
Douglas Gregorab1ec82e2011-12-16 03:12:41 +0000503 PrevIDecl, ClassLoc);
Douglas Gregordc9166c2011-12-15 20:29:51 +0000504
Douglas Gregordc9166c2011-12-15 20:29:51 +0000505 if (PrevIDecl) {
506 // Class already seen. Was it a definition?
507 if (ObjCInterfaceDecl *Def = PrevIDecl->getDefinition()) {
508 Diag(AtInterfaceLoc, diag::err_duplicate_class_def)
509 << PrevIDecl->getDeclName();
Douglas Gregorc0ac7d62011-12-15 05:27:12 +0000510 Diag(Def->getLocation(), diag::note_previous_definition);
Douglas Gregordc9166c2011-12-15 20:29:51 +0000511 IDecl->setInvalidDecl();
Chris Lattnerda463fe2007-12-12 07:09:47 +0000512 }
Chris Lattnerda463fe2007-12-12 07:09:47 +0000513 }
Douglas Gregordc9166c2011-12-15 20:29:51 +0000514
515 if (AttrList)
516 ProcessDeclAttributeList(TUScope, IDecl, AttrList);
517 PushOnScopeChains(IDecl, TUScope);
Mike Stump11289f42009-09-09 15:08:12 +0000518
Douglas Gregordc9166c2011-12-15 20:29:51 +0000519 // Start the definition of this class. If we're in a redefinition case, there
520 // may already be a definition, so we'll end up adding to it.
Douglas Gregorc0ac7d62011-12-15 05:27:12 +0000521 if (!IDecl->hasDefinition())
522 IDecl->startDefinition();
523
Chris Lattnerda463fe2007-12-12 07:09:47 +0000524 if (SuperName) {
Chris Lattnerda463fe2007-12-12 07:09:47 +0000525 // Check if a different kind of symbol declared in this scope.
Douglas Gregorb2ccf012010-04-15 22:33:43 +0000526 PrevDecl = LookupSingleName(TUScope, SuperName, SuperLoc,
527 LookupOrdinaryName);
Douglas Gregor35b0bac2010-01-03 18:01:57 +0000528
529 if (!PrevDecl) {
Kaelyn Uhraine31b8882012-01-13 01:32:50 +0000530 // Try to correct for a typo in the superclass name without correcting
531 // to the class we're defining.
Kaelyn Takata89c881b2014-10-27 18:07:29 +0000532 if (TypoCorrection Corrected =
533 CorrectTypo(DeclarationNameInfo(SuperName, SuperLoc),
534 LookupOrdinaryName, TUScope, nullptr,
535 llvm::make_unique<ObjCInterfaceValidatorCCC>(IDecl),
536 CTK_ErrorRecovery)) {
Richard Smithf9b15102013-08-17 00:46:16 +0000537 diagnoseTypo(Corrected, PDiag(diag::err_undef_superclass_suggest)
538 << SuperName << ClassName);
Kaelyn Uhraine31b8882012-01-13 01:32:50 +0000539 PrevDecl = Corrected.getCorrectionDeclAs<ObjCInterfaceDecl>();
Douglas Gregor35b0bac2010-01-03 18:01:57 +0000540 }
541 }
542
Douglas Gregor0b144e12011-12-15 00:29:59 +0000543 if (declaresSameEntity(PrevDecl, IDecl)) {
Fariborz Jahanian5582f232009-07-09 22:08:26 +0000544 Diag(SuperLoc, diag::err_recursive_superclass)
545 << SuperName << ClassName << SourceRange(AtInterfaceLoc, ClassLoc);
Douglas Gregor16408322011-12-15 22:34:59 +0000546 IDecl->setEndOfDefinitionLoc(ClassLoc);
Mike Stump12b8ce12009-08-04 21:02:39 +0000547 } else {
Mike Stump11289f42009-09-09 15:08:12 +0000548 ObjCInterfaceDecl *SuperClassDecl =
Fariborz Jahanian5582f232009-07-09 22:08:26 +0000549 dyn_cast_or_null<ObjCInterfaceDecl>(PrevDecl);
Chris Lattner4bd8dd82008-11-19 08:23:25 +0000550
Argyrios Kyrtzidis4ecdd2c2015-04-19 20:15:55 +0000551 // Diagnose availability in the context of the @interface.
552 ContextRAII SavedContext(*this, IDecl);
Fariborz Jahanian5582f232009-07-09 22:08:26 +0000553 // Diagnose classes that inherit from deprecated classes.
554 if (SuperClassDecl)
555 (void)DiagnoseUseOfDecl(SuperClassDecl, SuperLoc);
Mike Stump11289f42009-09-09 15:08:12 +0000556
Craig Topperc3ec1492014-05-26 06:22:03 +0000557 if (PrevDecl && !SuperClassDecl) {
Fariborz Jahanian5582f232009-07-09 22:08:26 +0000558 // The previous declaration was not a class decl. Check if we have a
559 // typedef. If we do, get the underlying class type.
Richard Smithdda56e42011-04-15 14:24:37 +0000560 if (const TypedefNameDecl *TDecl =
561 dyn_cast_or_null<TypedefNameDecl>(PrevDecl)) {
Fariborz Jahanian5582f232009-07-09 22:08:26 +0000562 QualType T = TDecl->getUnderlyingType();
John McCall8b07ec22010-05-15 11:32:37 +0000563 if (T->isObjCObjectType()) {
Fariborz Jahanian83f1be12013-04-04 18:45:52 +0000564 if (NamedDecl *IDecl = T->getAs<ObjCObjectType>()->getInterface()) {
Douglas Gregor1c283312010-08-11 12:19:30 +0000565 SuperClassDecl = dyn_cast<ObjCInterfaceDecl>(IDecl);
Fariborz Jahanian83f1be12013-04-04 18:45:52 +0000566 // This handles the following case:
567 // @interface NewI @end
568 // typedef NewI DeprI __attribute__((deprecated("blah")))
569 // @interface SI : DeprI /* warn here */ @end
570 (void)DiagnoseUseOfDecl(const_cast<TypedefNameDecl*>(TDecl), SuperLoc);
571 }
Fariborz Jahanian5582f232009-07-09 22:08:26 +0000572 }
573 }
Mike Stump11289f42009-09-09 15:08:12 +0000574
Fariborz Jahanian5582f232009-07-09 22:08:26 +0000575 // This handles the following case:
576 //
577 // typedef int SuperClass;
578 // @interface MyClass : SuperClass {} @end
579 //
580 if (!SuperClassDecl) {
581 Diag(SuperLoc, diag::err_redefinition_different_kind) << SuperName;
582 Diag(PrevDecl->getLocation(), diag::note_previous_definition);
Steve Naroff189d41f2009-02-04 17:14:05 +0000583 }
584 }
Mike Stump11289f42009-09-09 15:08:12 +0000585
Richard Smithdda56e42011-04-15 14:24:37 +0000586 if (!dyn_cast_or_null<TypedefNameDecl>(PrevDecl)) {
Fariborz Jahanian5582f232009-07-09 22:08:26 +0000587 if (!SuperClassDecl)
588 Diag(SuperLoc, diag::err_undef_superclass)
589 << SuperName << ClassName << SourceRange(AtInterfaceLoc, ClassLoc);
Douglas Gregor4123a862011-11-14 22:10:01 +0000590 else if (RequireCompleteType(SuperLoc,
Douglas Gregor7bfb2d02012-05-04 16:32:21 +0000591 Context.getObjCInterfaceType(SuperClassDecl),
592 diag::err_forward_superclass,
593 SuperClassDecl->getDeclName(),
594 ClassName,
595 SourceRange(AtInterfaceLoc, ClassLoc))) {
Craig Topperc3ec1492014-05-26 06:22:03 +0000596 SuperClassDecl = nullptr;
Fariborz Jahanian3ee91fa2011-06-23 23:16:19 +0000597 }
Steve Naroff189d41f2009-02-04 17:14:05 +0000598 }
Fariborz Jahanian5582f232009-07-09 22:08:26 +0000599 IDecl->setSuperClass(SuperClassDecl);
600 IDecl->setSuperClassLoc(SuperLoc);
Douglas Gregor16408322011-12-15 22:34:59 +0000601 IDecl->setEndOfDefinitionLoc(SuperLoc);
Steve Naroff189d41f2009-02-04 17:14:05 +0000602 }
Chris Lattnerda463fe2007-12-12 07:09:47 +0000603 } else { // we have a root class.
Douglas Gregor16408322011-12-15 22:34:59 +0000604 IDecl->setEndOfDefinitionLoc(ClassLoc);
Chris Lattnerda463fe2007-12-12 07:09:47 +0000605 }
Mike Stump11289f42009-09-09 15:08:12 +0000606
Sebastian Redle7c1fe62010-08-13 00:28:03 +0000607 // Check then save referenced protocols.
Chris Lattnerdf59f5a2008-07-26 04:13:19 +0000608 if (NumProtoRefs) {
Argyrios Kyrtzidis4ecdd2c2015-04-19 20:15:55 +0000609 diagnoseUseOfProtocols(*this, IDecl, (ObjCProtocolDecl*const*)ProtoRefs,
610 NumProtoRefs, ProtoLocs);
Roman Divackye6377112012-09-06 15:59:27 +0000611 IDecl->setProtocolList((ObjCProtocolDecl*const*)ProtoRefs, NumProtoRefs,
Douglas Gregor002b6712010-01-16 15:02:53 +0000612 ProtoLocs, Context);
Douglas Gregor16408322011-12-15 22:34:59 +0000613 IDecl->setEndOfDefinitionLoc(EndProtoLoc);
Chris Lattnerda463fe2007-12-12 07:09:47 +0000614 }
Mike Stump11289f42009-09-09 15:08:12 +0000615
Anders Carlssona6b508a2008-11-04 16:57:32 +0000616 CheckObjCDeclScope(IDecl);
Argyrios Kyrtzidis9321ad32011-10-06 23:23:20 +0000617 return ActOnObjCContainerStartDefinition(IDecl);
Chris Lattnerda463fe2007-12-12 07:09:47 +0000618}
619
Fariborz Jahanianb7c5f742013-09-25 19:36:32 +0000620/// ActOnTypedefedProtocols - this action finds protocol list as part of the
621/// typedef'ed use for a qualified super class and adds them to the list
622/// of the protocols.
623void Sema::ActOnTypedefedProtocols(SmallVectorImpl<Decl *> &ProtocolRefs,
624 IdentifierInfo *SuperName,
625 SourceLocation SuperLoc) {
626 if (!SuperName)
627 return;
628 NamedDecl* IDecl = LookupSingleName(TUScope, SuperName, SuperLoc,
629 LookupOrdinaryName);
630 if (!IDecl)
631 return;
632
633 if (const TypedefNameDecl *TDecl = dyn_cast_or_null<TypedefNameDecl>(IDecl)) {
634 QualType T = TDecl->getUnderlyingType();
635 if (T->isObjCObjectType())
636 if (const ObjCObjectType *OPT = T->getAs<ObjCObjectType>())
Benjamin Kramerf9890422015-02-17 16:48:30 +0000637 ProtocolRefs.append(OPT->qual_begin(), OPT->qual_end());
Fariborz Jahanianb7c5f742013-09-25 19:36:32 +0000638 }
639}
640
Richard Smithac4e36d2012-08-08 23:32:13 +0000641/// ActOnCompatibilityAlias - this action is called after complete parsing of
James Dennett634962f2012-06-14 21:40:34 +0000642/// a \@compatibility_alias declaration. It sets up the alias relationships.
Richard Smithac4e36d2012-08-08 23:32:13 +0000643Decl *Sema::ActOnCompatibilityAlias(SourceLocation AtLoc,
644 IdentifierInfo *AliasName,
645 SourceLocation AliasLocation,
646 IdentifierInfo *ClassName,
647 SourceLocation ClassLocation) {
Chris Lattnerda463fe2007-12-12 07:09:47 +0000648 // Look for previous declaration of alias name
Douglas Gregorb2ccf012010-04-15 22:33:43 +0000649 NamedDecl *ADecl = LookupSingleName(TUScope, AliasName, AliasLocation,
Douglas Gregorb8eaf292010-04-15 23:40:53 +0000650 LookupOrdinaryName, ForRedeclaration);
Chris Lattnerda463fe2007-12-12 07:09:47 +0000651 if (ADecl) {
Eli Friedmanfd6b3f82013-06-21 01:49:53 +0000652 Diag(AliasLocation, diag::err_conflicting_aliasing_type) << AliasName;
Chris Lattnerd0685032008-11-23 23:20:13 +0000653 Diag(ADecl->getLocation(), diag::note_previous_declaration);
Craig Topperc3ec1492014-05-26 06:22:03 +0000654 return nullptr;
Chris Lattnerda463fe2007-12-12 07:09:47 +0000655 }
656 // Check for class declaration
Douglas Gregorb2ccf012010-04-15 22:33:43 +0000657 NamedDecl *CDeclU = LookupSingleName(TUScope, ClassName, ClassLocation,
Douglas Gregorb8eaf292010-04-15 23:40:53 +0000658 LookupOrdinaryName, ForRedeclaration);
Richard Smithdda56e42011-04-15 14:24:37 +0000659 if (const TypedefNameDecl *TDecl =
660 dyn_cast_or_null<TypedefNameDecl>(CDeclU)) {
Fariborz Jahanian17290c32009-01-08 01:10:55 +0000661 QualType T = TDecl->getUnderlyingType();
John McCall8b07ec22010-05-15 11:32:37 +0000662 if (T->isObjCObjectType()) {
663 if (NamedDecl *IDecl = T->getAs<ObjCObjectType>()->getInterface()) {
Fariborz Jahanian17290c32009-01-08 01:10:55 +0000664 ClassName = IDecl->getIdentifier();
Douglas Gregorb2ccf012010-04-15 22:33:43 +0000665 CDeclU = LookupSingleName(TUScope, ClassName, ClassLocation,
Douglas Gregorb8eaf292010-04-15 23:40:53 +0000666 LookupOrdinaryName, ForRedeclaration);
Fariborz Jahanian17290c32009-01-08 01:10:55 +0000667 }
668 }
669 }
Chris Lattner219b3e92008-03-16 21:17:37 +0000670 ObjCInterfaceDecl *CDecl = dyn_cast_or_null<ObjCInterfaceDecl>(CDeclU);
Craig Topperc3ec1492014-05-26 06:22:03 +0000671 if (!CDecl) {
Chris Lattner4bd8dd82008-11-19 08:23:25 +0000672 Diag(ClassLocation, diag::warn_undef_interface) << ClassName;
Chris Lattner219b3e92008-03-16 21:17:37 +0000673 if (CDeclU)
Chris Lattnerd0685032008-11-23 23:20:13 +0000674 Diag(CDeclU->getLocation(), diag::note_previous_declaration);
Craig Topperc3ec1492014-05-26 06:22:03 +0000675 return nullptr;
Chris Lattnerda463fe2007-12-12 07:09:47 +0000676 }
Mike Stump11289f42009-09-09 15:08:12 +0000677
Chris Lattner219b3e92008-03-16 21:17:37 +0000678 // Everything checked out, instantiate a new alias declaration AST.
Mike Stump11289f42009-09-09 15:08:12 +0000679 ObjCCompatibleAliasDecl *AliasDecl =
Douglas Gregorc25d7a72009-01-09 00:49:46 +0000680 ObjCCompatibleAliasDecl::Create(Context, CurContext, AtLoc, AliasName, CDecl);
Mike Stump11289f42009-09-09 15:08:12 +0000681
Anders Carlssona6b508a2008-11-04 16:57:32 +0000682 if (!CheckObjCDeclScope(AliasDecl))
Douglas Gregor38feed82009-04-24 02:57:34 +0000683 PushOnScopeChains(AliasDecl, TUScope);
Douglas Gregorc25d7a72009-01-09 00:49:46 +0000684
John McCall48871652010-08-21 09:40:31 +0000685 return AliasDecl;
Chris Lattnerda463fe2007-12-12 07:09:47 +0000686}
687
Fariborz Jahanian7d622732011-05-13 18:02:08 +0000688bool Sema::CheckForwardProtocolDeclarationForCircularDependency(
Steve Naroff41d09ad2009-03-05 15:22:01 +0000689 IdentifierInfo *PName,
690 SourceLocation &Ploc, SourceLocation PrevLoc,
Fariborz Jahanian7d622732011-05-13 18:02:08 +0000691 const ObjCList<ObjCProtocolDecl> &PList) {
692
693 bool res = false;
Steve Naroff41d09ad2009-03-05 15:22:01 +0000694 for (ObjCList<ObjCProtocolDecl>::iterator I = PList.begin(),
695 E = PList.end(); I != E; ++I) {
Douglas Gregorb2ccf012010-04-15 22:33:43 +0000696 if (ObjCProtocolDecl *PDecl = LookupProtocol((*I)->getIdentifier(),
697 Ploc)) {
Steve Naroff41d09ad2009-03-05 15:22:01 +0000698 if (PDecl->getIdentifier() == PName) {
699 Diag(Ploc, diag::err_protocol_has_circular_dependency);
700 Diag(PrevLoc, diag::note_previous_definition);
Fariborz Jahanian7d622732011-05-13 18:02:08 +0000701 res = true;
Steve Naroff41d09ad2009-03-05 15:22:01 +0000702 }
Douglas Gregore6e48b12012-01-01 19:29:29 +0000703
704 if (!PDecl->hasDefinition())
705 continue;
706
Fariborz Jahanian7d622732011-05-13 18:02:08 +0000707 if (CheckForwardProtocolDeclarationForCircularDependency(PName, Ploc,
708 PDecl->getLocation(), PDecl->getReferencedProtocols()))
709 res = true;
Steve Naroff41d09ad2009-03-05 15:22:01 +0000710 }
711 }
Fariborz Jahanian7d622732011-05-13 18:02:08 +0000712 return res;
Steve Naroff41d09ad2009-03-05 15:22:01 +0000713}
714
John McCall48871652010-08-21 09:40:31 +0000715Decl *
Chris Lattner3bbae002008-07-26 04:03:38 +0000716Sema::ActOnStartProtocolInterface(SourceLocation AtProtoInterfaceLoc,
717 IdentifierInfo *ProtocolName,
718 SourceLocation ProtocolLoc,
John McCall48871652010-08-21 09:40:31 +0000719 Decl * const *ProtoRefs,
Chris Lattner3bbae002008-07-26 04:03:38 +0000720 unsigned NumProtoRefs,
Douglas Gregor002b6712010-01-16 15:02:53 +0000721 const SourceLocation *ProtoLocs,
Daniel Dunbar26e2ab42008-09-26 04:48:09 +0000722 SourceLocation EndProtoLoc,
723 AttributeList *AttrList) {
Fariborz Jahaniancadf7c52011-05-12 22:04:39 +0000724 bool err = false;
Daniel Dunbar26e2ab42008-09-26 04:48:09 +0000725 // FIXME: Deal with AttrList.
Chris Lattnerda463fe2007-12-12 07:09:47 +0000726 assert(ProtocolName && "Missing protocol identifier");
Douglas Gregor32c17572012-01-01 20:30:41 +0000727 ObjCProtocolDecl *PrevDecl = LookupProtocol(ProtocolName, ProtocolLoc,
728 ForRedeclaration);
Craig Topperc3ec1492014-05-26 06:22:03 +0000729 ObjCProtocolDecl *PDecl = nullptr;
730 if (ObjCProtocolDecl *Def = PrevDecl? PrevDecl->getDefinition() : nullptr) {
Douglas Gregor32c17572012-01-01 20:30:41 +0000731 // If we already have a definition, complain.
732 Diag(ProtocolLoc, diag::warn_duplicate_protocol_def) << ProtocolName;
733 Diag(Def->getLocation(), diag::note_previous_definition);
Mike Stump11289f42009-09-09 15:08:12 +0000734
Douglas Gregor32c17572012-01-01 20:30:41 +0000735 // Create a new protocol that is completely distinct from previous
736 // declarations, and do not make this protocol available for name lookup.
737 // That way, we'll end up completely ignoring the duplicate.
738 // FIXME: Can we turn this into an error?
739 PDecl = ObjCProtocolDecl::Create(Context, CurContext, ProtocolName,
740 ProtocolLoc, AtProtoInterfaceLoc,
Craig Topperc3ec1492014-05-26 06:22:03 +0000741 /*PrevDecl=*/nullptr);
Douglas Gregor32c17572012-01-01 20:30:41 +0000742 PDecl->startDefinition();
743 } else {
744 if (PrevDecl) {
745 // Check for circular dependencies among protocol declarations. This can
746 // only happen if this protocol was forward-declared.
Argyrios Kyrtzidis95dfc122011-11-13 22:08:30 +0000747 ObjCList<ObjCProtocolDecl> PList;
748 PList.set((ObjCProtocolDecl *const*)ProtoRefs, NumProtoRefs, Context);
749 err = CheckForwardProtocolDeclarationForCircularDependency(
Douglas Gregor32c17572012-01-01 20:30:41 +0000750 ProtocolName, ProtocolLoc, PrevDecl->getLocation(), PList);
Argyrios Kyrtzidis95dfc122011-11-13 22:08:30 +0000751 }
Douglas Gregor32c17572012-01-01 20:30:41 +0000752
753 // Create the new declaration.
Argyrios Kyrtzidis52f53fb2011-10-04 04:48:02 +0000754 PDecl = ObjCProtocolDecl::Create(Context, CurContext, ProtocolName,
Argyrios Kyrtzidis1f4bee52011-10-17 19:48:06 +0000755 ProtocolLoc, AtProtoInterfaceLoc,
Douglas Gregor05a1f4d2012-01-01 22:06:18 +0000756 /*PrevDecl=*/PrevDecl);
Douglas Gregor32c17572012-01-01 20:30:41 +0000757
Douglas Gregorde9f17e2009-04-23 23:18:26 +0000758 PushOnScopeChains(PDecl, TUScope);
Douglas Gregore6e48b12012-01-01 19:29:29 +0000759 PDecl->startDefinition();
Chris Lattnerf87ca0a2008-03-16 01:23:04 +0000760 }
Douglas Gregore6e48b12012-01-01 19:29:29 +0000761
Fariborz Jahanian1470e932008-12-17 01:07:27 +0000762 if (AttrList)
Douglas Gregor758a8692009-06-17 21:51:59 +0000763 ProcessDeclAttributeList(TUScope, PDecl, AttrList);
Douglas Gregor32c17572012-01-01 20:30:41 +0000764
765 // Merge attributes from previous declarations.
766 if (PrevDecl)
767 mergeDeclAttributes(PDecl, PrevDecl);
768
Fariborz Jahaniancadf7c52011-05-12 22:04:39 +0000769 if (!err && NumProtoRefs ) {
Chris Lattneracc04a92008-03-16 20:19:15 +0000770 /// Check then save referenced protocols.
Argyrios Kyrtzidis4ecdd2c2015-04-19 20:15:55 +0000771 diagnoseUseOfProtocols(*this, PDecl, (ObjCProtocolDecl*const*)ProtoRefs,
772 NumProtoRefs, ProtoLocs);
Roman Divackye6377112012-09-06 15:59:27 +0000773 PDecl->setProtocolList((ObjCProtocolDecl*const*)ProtoRefs, NumProtoRefs,
Douglas Gregor002b6712010-01-16 15:02:53 +0000774 ProtoLocs, Context);
Chris Lattnerda463fe2007-12-12 07:09:47 +0000775 }
Mike Stump11289f42009-09-09 15:08:12 +0000776
777 CheckObjCDeclScope(PDecl);
Argyrios Kyrtzidis9321ad32011-10-06 23:23:20 +0000778 return ActOnObjCContainerStartDefinition(PDecl);
Chris Lattnerda463fe2007-12-12 07:09:47 +0000779}
780
Fariborz Jahanianbf678e82014-03-11 17:10:51 +0000781static bool NestedProtocolHasNoDefinition(ObjCProtocolDecl *PDecl,
782 ObjCProtocolDecl *&UndefinedProtocol) {
783 if (!PDecl->hasDefinition() || PDecl->getDefinition()->isHidden()) {
784 UndefinedProtocol = PDecl;
785 return true;
786 }
787
Aaron Ballman0f6e64d2014-03-13 22:58:06 +0000788 for (auto *PI : PDecl->protocols())
789 if (NestedProtocolHasNoDefinition(PI, UndefinedProtocol)) {
790 UndefinedProtocol = PI;
Fariborz Jahanianbf678e82014-03-11 17:10:51 +0000791 return true;
792 }
793 return false;
794}
795
Chris Lattnerda463fe2007-12-12 07:09:47 +0000796/// FindProtocolDeclaration - This routine looks up protocols and
Daniel Dunbarc7dfbfd2008-09-04 20:01:15 +0000797/// issues an error if they are not declared. It returns list of
798/// protocol declarations in its 'Protocols' argument.
Chris Lattnerda463fe2007-12-12 07:09:47 +0000799void
Argyrios Kyrtzidis4ecdd2c2015-04-19 20:15:55 +0000800Sema::FindProtocolDeclaration(bool WarnOnDeclarations, bool ForObjCContainer,
Chris Lattnerd7352d62008-07-21 22:17:28 +0000801 const IdentifierLocPair *ProtocolId,
Chris Lattnerda463fe2007-12-12 07:09:47 +0000802 unsigned NumProtocols,
Chris Lattner0e62c1c2011-07-23 10:55:15 +0000803 SmallVectorImpl<Decl *> &Protocols) {
Chris Lattnerda463fe2007-12-12 07:09:47 +0000804 for (unsigned i = 0; i != NumProtocols; ++i) {
Douglas Gregorb2ccf012010-04-15 22:33:43 +0000805 ObjCProtocolDecl *PDecl = LookupProtocol(ProtocolId[i].first,
806 ProtocolId[i].second);
Chris Lattner9c1842b2008-07-26 03:47:43 +0000807 if (!PDecl) {
Douglas Gregorc2fa1692011-06-28 16:20:02 +0000808 TypoCorrection Corrected = CorrectTypo(
809 DeclarationNameInfo(ProtocolId[i].first, ProtocolId[i].second),
Kaelyn Takata89c881b2014-10-27 18:07:29 +0000810 LookupObjCProtocolName, TUScope, nullptr,
811 llvm::make_unique<DeclFilterCCC<ObjCProtocolDecl>>(),
Craig Topperc3ec1492014-05-26 06:22:03 +0000812 CTK_ErrorRecovery);
Richard Smithf9b15102013-08-17 00:46:16 +0000813 if ((PDecl = Corrected.getCorrectionDeclAs<ObjCProtocolDecl>()))
814 diagnoseTypo(Corrected, PDiag(diag::err_undeclared_protocol_suggest)
815 << ProtocolId[i].first);
Douglas Gregor35b0bac2010-01-03 18:01:57 +0000816 }
817
818 if (!PDecl) {
Chris Lattner3b054132008-11-19 05:08:23 +0000819 Diag(ProtocolId[i].second, diag::err_undeclared_protocol)
Chris Lattner4bd8dd82008-11-19 08:23:25 +0000820 << ProtocolId[i].first;
Chris Lattner9c1842b2008-07-26 03:47:43 +0000821 continue;
822 }
Fariborz Jahanianada44a22013-04-09 17:52:29 +0000823 // If this is a forward protocol declaration, get its definition.
824 if (!PDecl->isThisDeclarationADefinition() && PDecl->getDefinition())
825 PDecl = PDecl->getDefinition();
Argyrios Kyrtzidis4ecdd2c2015-04-19 20:15:55 +0000826
827 // For an objc container, delay protocol reference checking until after we
828 // can set the objc decl as the availability context, otherwise check now.
829 if (!ForObjCContainer) {
830 (void)DiagnoseUseOfDecl(PDecl, ProtocolId[i].second);
831 }
Chris Lattner9c1842b2008-07-26 03:47:43 +0000832
833 // If this is a forward declaration and we are supposed to warn in this
834 // case, do it.
Douglas Gregoreed49792013-01-17 00:38:46 +0000835 // FIXME: Recover nicely in the hidden case.
Fariborz Jahanianbf678e82014-03-11 17:10:51 +0000836 ObjCProtocolDecl *UndefinedProtocol;
837
Douglas Gregoreed49792013-01-17 00:38:46 +0000838 if (WarnOnDeclarations &&
Fariborz Jahanianbf678e82014-03-11 17:10:51 +0000839 NestedProtocolHasNoDefinition(PDecl, UndefinedProtocol)) {
Chris Lattner3b054132008-11-19 05:08:23 +0000840 Diag(ProtocolId[i].second, diag::warn_undef_protocolref)
Chris Lattner4bd8dd82008-11-19 08:23:25 +0000841 << ProtocolId[i].first;
Fariborz Jahanianbf678e82014-03-11 17:10:51 +0000842 Diag(UndefinedProtocol->getLocation(), diag::note_protocol_decl_undefined)
843 << UndefinedProtocol;
844 }
John McCall48871652010-08-21 09:40:31 +0000845 Protocols.push_back(PDecl);
Chris Lattnerda463fe2007-12-12 07:09:47 +0000846 }
847}
848
Fariborz Jahanianabf63e7b2009-03-02 19:06:08 +0000849/// DiagnoseClassExtensionDupMethods - Check for duplicate declaration of
Fariborz Jahanian33afd772009-03-02 19:05:07 +0000850/// a class method in its extension.
851///
Mike Stump11289f42009-09-09 15:08:12 +0000852void Sema::DiagnoseClassExtensionDupMethods(ObjCCategoryDecl *CAT,
Fariborz Jahanian33afd772009-03-02 19:05:07 +0000853 ObjCInterfaceDecl *ID) {
854 if (!ID)
855 return; // Possibly due to previous error
856
857 llvm::DenseMap<Selector, const ObjCMethodDecl*> MethodMap;
Aaron Ballmanaff18c02014-03-13 19:03:34 +0000858 for (auto *MD : ID->methods())
Fariborz Jahanian33afd772009-03-02 19:05:07 +0000859 MethodMap[MD->getSelector()] = MD;
Fariborz Jahanian33afd772009-03-02 19:05:07 +0000860
861 if (MethodMap.empty())
862 return;
Aaron Ballmanaff18c02014-03-13 19:03:34 +0000863 for (const auto *Method : CAT->methods()) {
Fariborz Jahanian33afd772009-03-02 19:05:07 +0000864 const ObjCMethodDecl *&PrevMethod = MethodMap[Method->getSelector()];
Fariborz Jahanian83d674e2014-03-17 17:46:10 +0000865 if (PrevMethod &&
866 (PrevMethod->isInstanceMethod() == Method->isInstanceMethod()) &&
867 !MatchTwoMethodDeclarations(Method, PrevMethod)) {
Fariborz Jahanian33afd772009-03-02 19:05:07 +0000868 Diag(Method->getLocation(), diag::err_duplicate_method_decl)
869 << Method->getDeclName();
870 Diag(PrevMethod->getLocation(), diag::note_previous_declaration);
871 }
872 }
873}
874
James Dennett634962f2012-06-14 21:40:34 +0000875/// ActOnForwardProtocolDeclaration - Handle \@protocol foo;
Douglas Gregorf6102672012-01-01 21:23:57 +0000876Sema::DeclGroupPtrTy
Chris Lattnerda463fe2007-12-12 07:09:47 +0000877Sema::ActOnForwardProtocolDeclaration(SourceLocation AtProtocolLoc,
Chris Lattnerd7352d62008-07-21 22:17:28 +0000878 const IdentifierLocPair *IdentList,
Fariborz Jahanian1470e932008-12-17 01:07:27 +0000879 unsigned NumElts,
880 AttributeList *attrList) {
Douglas Gregorf6102672012-01-01 21:23:57 +0000881 SmallVector<Decl *, 8> DeclsInGroup;
Chris Lattnerda463fe2007-12-12 07:09:47 +0000882 for (unsigned i = 0; i != NumElts; ++i) {
Chris Lattnerd7352d62008-07-21 22:17:28 +0000883 IdentifierInfo *Ident = IdentList[i].first;
Douglas Gregor32c17572012-01-01 20:30:41 +0000884 ObjCProtocolDecl *PrevDecl = LookupProtocol(Ident, IdentList[i].second,
885 ForRedeclaration);
886 ObjCProtocolDecl *PDecl
887 = ObjCProtocolDecl::Create(Context, CurContext, Ident,
888 IdentList[i].second, AtProtocolLoc,
Douglas Gregor05a1f4d2012-01-01 22:06:18 +0000889 PrevDecl);
Douglas Gregor32c17572012-01-01 20:30:41 +0000890
891 PushOnScopeChains(PDecl, TUScope);
Douglas Gregorf6102672012-01-01 21:23:57 +0000892 CheckObjCDeclScope(PDecl);
Douglas Gregor32c17572012-01-01 20:30:41 +0000893
Douglas Gregor42ff1bb2012-01-01 20:33:24 +0000894 if (attrList)
Douglas Gregor758a8692009-06-17 21:51:59 +0000895 ProcessDeclAttributeList(TUScope, PDecl, attrList);
Douglas Gregor32c17572012-01-01 20:30:41 +0000896
897 if (PrevDecl)
898 mergeDeclAttributes(PDecl, PrevDecl);
899
Douglas Gregorf6102672012-01-01 21:23:57 +0000900 DeclsInGroup.push_back(PDecl);
Chris Lattnerda463fe2007-12-12 07:09:47 +0000901 }
Mike Stump11289f42009-09-09 15:08:12 +0000902
Rafael Espindolaab417692013-07-09 12:05:01 +0000903 return BuildDeclaratorGroup(DeclsInGroup, false);
Chris Lattnerda463fe2007-12-12 07:09:47 +0000904}
905
John McCall48871652010-08-21 09:40:31 +0000906Decl *Sema::
Chris Lattnerd7352d62008-07-21 22:17:28 +0000907ActOnStartCategoryInterface(SourceLocation AtInterfaceLoc,
908 IdentifierInfo *ClassName, SourceLocation ClassLoc,
909 IdentifierInfo *CategoryName,
910 SourceLocation CategoryLoc,
John McCall48871652010-08-21 09:40:31 +0000911 Decl * const *ProtoRefs,
Chris Lattnerd7352d62008-07-21 22:17:28 +0000912 unsigned NumProtoRefs,
Douglas Gregor002b6712010-01-16 15:02:53 +0000913 const SourceLocation *ProtoLocs,
Chris Lattnerd7352d62008-07-21 22:17:28 +0000914 SourceLocation EndProtoLoc) {
Fariborz Jahanian3bf0ded2010-06-22 23:20:40 +0000915 ObjCCategoryDecl *CDecl;
Douglas Gregorb2ccf012010-04-15 22:33:43 +0000916 ObjCInterfaceDecl *IDecl = getObjCInterfaceDecl(ClassName, ClassLoc, true);
Ted Kremenek514ff702010-02-23 19:39:46 +0000917
918 /// Check that class of this category is already completely declared.
Douglas Gregor4123a862011-11-14 22:10:01 +0000919
920 if (!IDecl
921 || RequireCompleteType(ClassLoc, Context.getObjCInterfaceType(IDecl),
Douglas Gregor7bfb2d02012-05-04 16:32:21 +0000922 diag::err_category_forward_interface,
Craig Topperc3ec1492014-05-26 06:22:03 +0000923 CategoryName == nullptr)) {
Ted Kremenek514ff702010-02-23 19:39:46 +0000924 // Create an invalid ObjCCategoryDecl to serve as context for
925 // the enclosing method declarations. We mark the decl invalid
926 // to make it clear that this isn't a valid AST.
927 CDecl = ObjCCategoryDecl::Create(Context, CurContext, AtInterfaceLoc,
Argyrios Kyrtzidis3a5094b2011-08-30 19:43:26 +0000928 ClassLoc, CategoryLoc, CategoryName,IDecl);
Ted Kremenek514ff702010-02-23 19:39:46 +0000929 CDecl->setInvalidDecl();
Argyrios Kyrtzidisb15def22012-03-12 18:34:26 +0000930 CurContext->addDecl(CDecl);
Douglas Gregor4123a862011-11-14 22:10:01 +0000931
932 if (!IDecl)
933 Diag(ClassLoc, diag::err_undef_interface) << ClassName;
Argyrios Kyrtzidis9321ad32011-10-06 23:23:20 +0000934 return ActOnObjCContainerStartDefinition(CDecl);
Ted Kremenek514ff702010-02-23 19:39:46 +0000935 }
936
Fariborz Jahanian3bf0ded2010-06-22 23:20:40 +0000937 if (!CategoryName && IDecl->getImplementation()) {
938 Diag(ClassLoc, diag::err_class_extension_after_impl) << ClassName;
939 Diag(IDecl->getImplementation()->getLocation(),
940 diag::note_implementation_declared);
Ted Kremenek514ff702010-02-23 19:39:46 +0000941 }
942
Fariborz Jahanian30a42922010-02-15 21:55:26 +0000943 if (CategoryName) {
944 /// Check for duplicate interface declaration for this category
Douglas Gregor048fbfa2013-01-16 23:00:23 +0000945 if (ObjCCategoryDecl *Previous
946 = IDecl->FindCategoryDeclaration(CategoryName)) {
947 // Class extensions can be declared multiple times, categories cannot.
948 Diag(CategoryLoc, diag::warn_dup_category_def)
949 << ClassName << CategoryName;
950 Diag(Previous->getLocation(), diag::note_previous_definition);
Chris Lattner9018ca82009-02-16 21:26:43 +0000951 }
952 }
Chris Lattner9018ca82009-02-16 21:26:43 +0000953
Argyrios Kyrtzidis3a5094b2011-08-30 19:43:26 +0000954 CDecl = ObjCCategoryDecl::Create(Context, CurContext, AtInterfaceLoc,
955 ClassLoc, CategoryLoc, CategoryName, IDecl);
956 // FIXME: PushOnScopeChains?
957 CurContext->addDecl(CDecl);
958
Chris Lattnerda463fe2007-12-12 07:09:47 +0000959 if (NumProtoRefs) {
Argyrios Kyrtzidis4ecdd2c2015-04-19 20:15:55 +0000960 diagnoseUseOfProtocols(*this, CDecl, (ObjCProtocolDecl*const*)ProtoRefs,
961 NumProtoRefs, ProtoLocs);
962 CDecl->setProtocolList((ObjCProtocolDecl*const*)ProtoRefs, NumProtoRefs,
Douglas Gregor002b6712010-01-16 15:02:53 +0000963 ProtoLocs, Context);
Fariborz Jahanian092cd6e2009-10-05 20:41:32 +0000964 // Protocols in the class extension belong to the class.
Fariborz Jahanian30a42922010-02-15 21:55:26 +0000965 if (CDecl->IsClassExtension())
Roman Divackye6377112012-09-06 15:59:27 +0000966 IDecl->mergeClassExtensionProtocolList((ObjCProtocolDecl*const*)ProtoRefs,
Ted Kremenek0ef508d2010-09-01 01:21:15 +0000967 NumProtoRefs, Context);
Chris Lattnerda463fe2007-12-12 07:09:47 +0000968 }
Mike Stump11289f42009-09-09 15:08:12 +0000969
Anders Carlssona6b508a2008-11-04 16:57:32 +0000970 CheckObjCDeclScope(CDecl);
Argyrios Kyrtzidis9321ad32011-10-06 23:23:20 +0000971 return ActOnObjCContainerStartDefinition(CDecl);
Chris Lattnerda463fe2007-12-12 07:09:47 +0000972}
973
974/// ActOnStartCategoryImplementation - Perform semantic checks on the
Ted Kremenek1b0ea822008-01-07 19:49:32 +0000975/// category implementation declaration and build an ObjCCategoryImplDecl
Chris Lattnerda463fe2007-12-12 07:09:47 +0000976/// object.
John McCall48871652010-08-21 09:40:31 +0000977Decl *Sema::ActOnStartCategoryImplementation(
Chris Lattnerda463fe2007-12-12 07:09:47 +0000978 SourceLocation AtCatImplLoc,
979 IdentifierInfo *ClassName, SourceLocation ClassLoc,
980 IdentifierInfo *CatName, SourceLocation CatLoc) {
Douglas Gregorb2ccf012010-04-15 22:33:43 +0000981 ObjCInterfaceDecl *IDecl = getObjCInterfaceDecl(ClassName, ClassLoc, true);
Craig Topperc3ec1492014-05-26 06:22:03 +0000982 ObjCCategoryDecl *CatIDecl = nullptr;
Argyrios Kyrtzidis4af2cb32012-03-02 19:14:29 +0000983 if (IDecl && IDecl->hasDefinition()) {
Argyrios Kyrtzidis6d9fab72009-07-21 00:05:53 +0000984 CatIDecl = IDecl->FindCategoryDeclaration(CatName);
985 if (!CatIDecl) {
986 // Category @implementation with no corresponding @interface.
987 // Create and install one.
Argyrios Kyrtzidis41fc05c2011-11-23 20:27:26 +0000988 CatIDecl = ObjCCategoryDecl::Create(Context, CurContext, AtCatImplLoc,
989 ClassLoc, CatLoc,
Argyrios Kyrtzidis3a5094b2011-08-30 19:43:26 +0000990 CatName, IDecl);
Argyrios Kyrtzidis41fc05c2011-11-23 20:27:26 +0000991 CatIDecl->setImplicit();
Argyrios Kyrtzidis6d9fab72009-07-21 00:05:53 +0000992 }
993 }
994
Mike Stump11289f42009-09-09 15:08:12 +0000995 ObjCCategoryImplDecl *CDecl =
Argyrios Kyrtzidis52f53fb2011-10-04 04:48:02 +0000996 ObjCCategoryImplDecl::Create(Context, CurContext, CatName, IDecl,
Argyrios Kyrtzidis4996f5f2011-12-09 00:31:40 +0000997 ClassLoc, AtCatImplLoc, CatLoc);
Chris Lattnerda463fe2007-12-12 07:09:47 +0000998 /// Check that class of this category is already completely declared.
Douglas Gregor4123a862011-11-14 22:10:01 +0000999 if (!IDecl) {
Chris Lattner4bd8dd82008-11-19 08:23:25 +00001000 Diag(ClassLoc, diag::err_undef_interface) << ClassName;
John McCalld2930c22011-07-22 02:45:48 +00001001 CDecl->setInvalidDecl();
Douglas Gregor4123a862011-11-14 22:10:01 +00001002 } else if (RequireCompleteType(ClassLoc, Context.getObjCInterfaceType(IDecl),
1003 diag::err_undef_interface)) {
1004 CDecl->setInvalidDecl();
John McCalld2930c22011-07-22 02:45:48 +00001005 }
Chris Lattnerda463fe2007-12-12 07:09:47 +00001006
Douglas Gregorc25d7a72009-01-09 00:49:46 +00001007 // FIXME: PushOnScopeChains?
Argyrios Kyrtzidiscfbfe782009-06-30 02:36:12 +00001008 CurContext->addDecl(CDecl);
Douglas Gregorc25d7a72009-01-09 00:49:46 +00001009
Argyrios Kyrtzidisc281c962011-10-06 23:23:27 +00001010 // If the interface is deprecated/unavailable, warn/error about it.
1011 if (IDecl)
1012 DiagnoseUseOfDecl(IDecl, ClassLoc);
1013
Argyrios Kyrtzidis6d9fab72009-07-21 00:05:53 +00001014 /// Check that CatName, category name, is not used in another implementation.
1015 if (CatIDecl) {
1016 if (CatIDecl->getImplementation()) {
1017 Diag(ClassLoc, diag::err_dup_implementation_category) << ClassName
1018 << CatName;
1019 Diag(CatIDecl->getImplementation()->getLocation(),
1020 diag::note_previous_definition);
Argyrios Kyrtzidis0f6d5ca2013-05-30 18:53:21 +00001021 CDecl->setInvalidDecl();
Fariborz Jahaniand33ab8c2011-02-15 00:59:30 +00001022 } else {
Argyrios Kyrtzidis6d9fab72009-07-21 00:05:53 +00001023 CatIDecl->setImplementation(CDecl);
Fariborz Jahaniand33ab8c2011-02-15 00:59:30 +00001024 // Warn on implementating category of deprecated class under
1025 // -Wdeprecated-implementations flag.
Fariborz Jahaniand724a102011-02-15 17:49:58 +00001026 DiagnoseObjCImplementedDeprecations(*this,
1027 dyn_cast<NamedDecl>(IDecl),
1028 CDecl->getLocation(), 2);
Fariborz Jahaniand33ab8c2011-02-15 00:59:30 +00001029 }
Argyrios Kyrtzidis6d9fab72009-07-21 00:05:53 +00001030 }
Mike Stump11289f42009-09-09 15:08:12 +00001031
Anders Carlssona6b508a2008-11-04 16:57:32 +00001032 CheckObjCDeclScope(CDecl);
Argyrios Kyrtzidis9321ad32011-10-06 23:23:20 +00001033 return ActOnObjCContainerStartDefinition(CDecl);
Chris Lattnerda463fe2007-12-12 07:09:47 +00001034}
1035
John McCall48871652010-08-21 09:40:31 +00001036Decl *Sema::ActOnStartClassImplementation(
Chris Lattnerda463fe2007-12-12 07:09:47 +00001037 SourceLocation AtClassImplLoc,
1038 IdentifierInfo *ClassName, SourceLocation ClassLoc,
Mike Stump11289f42009-09-09 15:08:12 +00001039 IdentifierInfo *SuperClassname,
Chris Lattnerda463fe2007-12-12 07:09:47 +00001040 SourceLocation SuperClassLoc) {
Craig Topperc3ec1492014-05-26 06:22:03 +00001041 ObjCInterfaceDecl *IDecl = nullptr;
Chris Lattnerda463fe2007-12-12 07:09:47 +00001042 // Check for another declaration kind with the same name.
John McCall9f3059a2009-10-09 21:13:30 +00001043 NamedDecl *PrevDecl
Douglas Gregorb8eaf292010-04-15 23:40:53 +00001044 = LookupSingleName(TUScope, ClassName, ClassLoc, LookupOrdinaryName,
1045 ForRedeclaration);
Ted Kremenek1b0ea822008-01-07 19:49:32 +00001046 if (PrevDecl && !isa<ObjCInterfaceDecl>(PrevDecl)) {
Chris Lattner4bd8dd82008-11-19 08:23:25 +00001047 Diag(ClassLoc, diag::err_redefinition_different_kind) << ClassName;
Chris Lattner0369c572008-11-23 23:12:31 +00001048 Diag(PrevDecl->getLocation(), diag::note_previous_definition);
Douglas Gregor1c283312010-08-11 12:19:30 +00001049 } else if ((IDecl = dyn_cast_or_null<ObjCInterfaceDecl>(PrevDecl))) {
Douglas Gregorab1ec82e2011-12-16 03:12:41 +00001050 RequireCompleteType(ClassLoc, Context.getObjCInterfaceType(IDecl),
1051 diag::warn_undef_interface);
Douglas Gregor40f7a002010-01-04 17:27:12 +00001052 } else {
Richard Smithf9b15102013-08-17 00:46:16 +00001053 // We did not find anything with the name ClassName; try to correct for
Douglas Gregor40f7a002010-01-04 17:27:12 +00001054 // typos in the class name.
Kaelyn Takata89c881b2014-10-27 18:07:29 +00001055 TypoCorrection Corrected = CorrectTypo(
1056 DeclarationNameInfo(ClassName, ClassLoc), LookupOrdinaryName, TUScope,
1057 nullptr, llvm::make_unique<ObjCInterfaceValidatorCCC>(), CTK_NonError);
Richard Smithf9b15102013-08-17 00:46:16 +00001058 if (Corrected.getCorrectionDeclAs<ObjCInterfaceDecl>()) {
1059 // Suggest the (potentially) correct interface name. Don't provide a
1060 // code-modification hint or use the typo name for recovery, because
1061 // this is just a warning. The program may actually be correct.
1062 diagnoseTypo(Corrected,
1063 PDiag(diag::warn_undef_interface_suggest) << ClassName,
1064 /*ErrorRecovery*/false);
Douglas Gregor40f7a002010-01-04 17:27:12 +00001065 } else {
1066 Diag(ClassLoc, diag::warn_undef_interface) << ClassName;
1067 }
Chris Lattnerda463fe2007-12-12 07:09:47 +00001068 }
Mike Stump11289f42009-09-09 15:08:12 +00001069
Chris Lattnerda463fe2007-12-12 07:09:47 +00001070 // Check that super class name is valid class name
Craig Topperc3ec1492014-05-26 06:22:03 +00001071 ObjCInterfaceDecl *SDecl = nullptr;
Chris Lattnerda463fe2007-12-12 07:09:47 +00001072 if (SuperClassname) {
1073 // Check if a different kind of symbol declared in this scope.
Douglas Gregorb2ccf012010-04-15 22:33:43 +00001074 PrevDecl = LookupSingleName(TUScope, SuperClassname, SuperClassLoc,
1075 LookupOrdinaryName);
Ted Kremenek1b0ea822008-01-07 19:49:32 +00001076 if (PrevDecl && !isa<ObjCInterfaceDecl>(PrevDecl)) {
Chris Lattner4bd8dd82008-11-19 08:23:25 +00001077 Diag(SuperClassLoc, diag::err_redefinition_different_kind)
1078 << SuperClassname;
Chris Lattner0369c572008-11-23 23:12:31 +00001079 Diag(PrevDecl->getLocation(), diag::note_previous_definition);
Chris Lattner4bd8dd82008-11-19 08:23:25 +00001080 } else {
Mike Stump11289f42009-09-09 15:08:12 +00001081 SDecl = dyn_cast_or_null<ObjCInterfaceDecl>(PrevDecl);
Argyrios Kyrtzidis3b60cff2012-03-13 01:09:36 +00001082 if (SDecl && !SDecl->hasDefinition())
Craig Topperc3ec1492014-05-26 06:22:03 +00001083 SDecl = nullptr;
Chris Lattnerda463fe2007-12-12 07:09:47 +00001084 if (!SDecl)
Chris Lattner4bd8dd82008-11-19 08:23:25 +00001085 Diag(SuperClassLoc, diag::err_undef_superclass)
1086 << SuperClassname << ClassName;
Douglas Gregor0b144e12011-12-15 00:29:59 +00001087 else if (IDecl && !declaresSameEntity(IDecl->getSuperClass(), SDecl)) {
Chris Lattnerda463fe2007-12-12 07:09:47 +00001088 // This implementation and its interface do not have the same
1089 // super class.
Chris Lattner4bd8dd82008-11-19 08:23:25 +00001090 Diag(SuperClassLoc, diag::err_conflicting_super_class)
Chris Lattnere3d20d92008-11-23 21:45:46 +00001091 << SDecl->getDeclName();
Chris Lattner0369c572008-11-23 23:12:31 +00001092 Diag(SDecl->getLocation(), diag::note_previous_definition);
Chris Lattnerda463fe2007-12-12 07:09:47 +00001093 }
1094 }
1095 }
Mike Stump11289f42009-09-09 15:08:12 +00001096
Chris Lattnerda463fe2007-12-12 07:09:47 +00001097 if (!IDecl) {
1098 // Legacy case of @implementation with no corresponding @interface.
1099 // Build, chain & install the interface decl into the identifier.
Daniel Dunbar73a73f52008-08-20 18:02:42 +00001100
Mike Stump87c57ac2009-05-16 07:39:55 +00001101 // FIXME: Do we support attributes on the @implementation? If so we should
1102 // copy them over.
Mike Stump11289f42009-09-09 15:08:12 +00001103 IDecl = ObjCInterfaceDecl::Create(Context, CurContext, AtClassImplLoc,
Craig Topperc3ec1492014-05-26 06:22:03 +00001104 ClassName, /*PrevDecl=*/nullptr, ClassLoc,
Douglas Gregorab1ec82e2011-12-16 03:12:41 +00001105 true);
Douglas Gregorc0ac7d62011-12-15 05:27:12 +00001106 IDecl->startDefinition();
Douglas Gregor16408322011-12-15 22:34:59 +00001107 if (SDecl) {
1108 IDecl->setSuperClass(SDecl);
1109 IDecl->setSuperClassLoc(SuperClassLoc);
1110 IDecl->setEndOfDefinitionLoc(SuperClassLoc);
1111 } else {
1112 IDecl->setEndOfDefinitionLoc(ClassLoc);
1113 }
1114
Douglas Gregorac345a32009-04-24 00:16:12 +00001115 PushOnScopeChains(IDecl, TUScope);
Douglas Gregor1c283312010-08-11 12:19:30 +00001116 } else {
1117 // Mark the interface as being completed, even if it was just as
1118 // @class ....;
1119 // declaration; the user cannot reopen it.
Douglas Gregorc0ac7d62011-12-15 05:27:12 +00001120 if (!IDecl->hasDefinition())
1121 IDecl->startDefinition();
Chris Lattnerda463fe2007-12-12 07:09:47 +00001122 }
Mike Stump11289f42009-09-09 15:08:12 +00001123
1124 ObjCImplementationDecl* IMPDecl =
Argyrios Kyrtzidis52f53fb2011-10-04 04:48:02 +00001125 ObjCImplementationDecl::Create(Context, CurContext, IDecl, SDecl,
Argyrios Kyrtzidisfac31622013-05-03 18:05:44 +00001126 ClassLoc, AtClassImplLoc, SuperClassLoc);
Mike Stump11289f42009-09-09 15:08:12 +00001127
Anders Carlssona6b508a2008-11-04 16:57:32 +00001128 if (CheckObjCDeclScope(IMPDecl))
Argyrios Kyrtzidis9321ad32011-10-06 23:23:20 +00001129 return ActOnObjCContainerStartDefinition(IMPDecl);
Mike Stump11289f42009-09-09 15:08:12 +00001130
Chris Lattnerda463fe2007-12-12 07:09:47 +00001131 // Check that there is no duplicate implementation of this class.
Douglas Gregor1c283312010-08-11 12:19:30 +00001132 if (IDecl->getImplementation()) {
1133 // FIXME: Don't leak everything!
Chris Lattner4bd8dd82008-11-19 08:23:25 +00001134 Diag(ClassLoc, diag::err_dup_implementation_class) << ClassName;
Argyrios Kyrtzidis43cee9352009-07-21 00:06:04 +00001135 Diag(IDecl->getImplementation()->getLocation(),
1136 diag::note_previous_definition);
Argyrios Kyrtzidis0f6d5ca2013-05-30 18:53:21 +00001137 IMPDecl->setInvalidDecl();
Douglas Gregor1c283312010-08-11 12:19:30 +00001138 } else { // add it to the list.
Argyrios Kyrtzidis6d9fab72009-07-21 00:05:53 +00001139 IDecl->setImplementation(IMPDecl);
Douglas Gregor79947a22009-04-24 00:11:27 +00001140 PushOnScopeChains(IMPDecl, TUScope);
Fariborz Jahaniand33ab8c2011-02-15 00:59:30 +00001141 // Warn on implementating deprecated class under
1142 // -Wdeprecated-implementations flag.
Fariborz Jahaniand724a102011-02-15 17:49:58 +00001143 DiagnoseObjCImplementedDeprecations(*this,
1144 dyn_cast<NamedDecl>(IDecl),
1145 IMPDecl->getLocation(), 1);
Argyrios Kyrtzidis6d9fab72009-07-21 00:05:53 +00001146 }
Argyrios Kyrtzidis9321ad32011-10-06 23:23:20 +00001147 return ActOnObjCContainerStartDefinition(IMPDecl);
Chris Lattnerda463fe2007-12-12 07:09:47 +00001148}
1149
Argyrios Kyrtzidis2e85c5f2012-02-23 21:11:20 +00001150Sema::DeclGroupPtrTy
1151Sema::ActOnFinishObjCImplementation(Decl *ObjCImpDecl, ArrayRef<Decl *> Decls) {
1152 SmallVector<Decl *, 64> DeclsInGroup;
1153 DeclsInGroup.reserve(Decls.size() + 1);
1154
1155 for (unsigned i = 0, e = Decls.size(); i != e; ++i) {
1156 Decl *Dcl = Decls[i];
1157 if (!Dcl)
1158 continue;
1159 if (Dcl->getDeclContext()->isFileContext())
1160 Dcl->setTopLevelDeclInObjCContainer();
1161 DeclsInGroup.push_back(Dcl);
1162 }
1163
1164 DeclsInGroup.push_back(ObjCImpDecl);
1165
Rafael Espindolaab417692013-07-09 12:05:01 +00001166 return BuildDeclaratorGroup(DeclsInGroup, false);
Argyrios Kyrtzidis2e85c5f2012-02-23 21:11:20 +00001167}
1168
Ted Kremenek1b0ea822008-01-07 19:49:32 +00001169void Sema::CheckImplementationIvars(ObjCImplementationDecl *ImpDecl,
1170 ObjCIvarDecl **ivars, unsigned numIvars,
Chris Lattnerda463fe2007-12-12 07:09:47 +00001171 SourceLocation RBrace) {
1172 assert(ImpDecl && "missing implementation decl");
Douglas Gregor6e6ad602009-01-20 01:17:11 +00001173 ObjCInterfaceDecl* IDecl = ImpDecl->getClassInterface();
Chris Lattnerda463fe2007-12-12 07:09:47 +00001174 if (!IDecl)
1175 return;
James Dennett634962f2012-06-14 21:40:34 +00001176 /// Check case of non-existing \@interface decl.
1177 /// (legacy objective-c \@implementation decl without an \@interface decl).
Chris Lattnerda463fe2007-12-12 07:09:47 +00001178 /// Add implementations's ivar to the synthesize class's ivar list.
Steve Naroffaac654a2009-04-20 20:09:33 +00001179 if (IDecl->isImplicitInterfaceDecl()) {
Douglas Gregor16408322011-12-15 22:34:59 +00001180 IDecl->setEndOfDefinitionLoc(RBrace);
Fariborz Jahanian20912d62010-02-17 17:00:07 +00001181 // Add ivar's to class's DeclContext.
1182 for (unsigned i = 0, e = numIvars; i != e; ++i) {
Fariborz Jahanianc0309cd2010-02-17 18:10:54 +00001183 ivars[i]->setLexicalDeclContext(ImpDecl);
Richard Smith05afe5e2012-03-13 03:12:56 +00001184 IDecl->makeDeclVisibleInContext(ivars[i]);
Fariborz Jahanianaef66222010-02-19 00:31:17 +00001185 ImpDecl->addDecl(ivars[i]);
Fariborz Jahanian20912d62010-02-17 17:00:07 +00001186 }
1187
Chris Lattnerda463fe2007-12-12 07:09:47 +00001188 return;
1189 }
1190 // If implementation has empty ivar list, just return.
1191 if (numIvars == 0)
1192 return;
Mike Stump11289f42009-09-09 15:08:12 +00001193
Chris Lattnerda463fe2007-12-12 07:09:47 +00001194 assert(ivars && "missing @implementation ivars");
John McCall5fb5df92012-06-20 06:18:46 +00001195 if (LangOpts.ObjCRuntime.isNonFragile()) {
Fariborz Jahanian34e3cef2010-02-19 20:58:54 +00001196 if (ImpDecl->getSuperClass())
1197 Diag(ImpDecl->getLocation(), diag::warn_on_superclass_use);
1198 for (unsigned i = 0; i < numIvars; i++) {
1199 ObjCIvarDecl* ImplIvar = ivars[i];
1200 if (const ObjCIvarDecl *ClsIvar =
1201 IDecl->getIvarDecl(ImplIvar->getIdentifier())) {
1202 Diag(ImplIvar->getLocation(), diag::err_duplicate_ivar_declaration);
1203 Diag(ClsIvar->getLocation(), diag::note_previous_definition);
1204 continue;
1205 }
Fariborz Jahaniane23f26b2013-06-26 22:10:27 +00001206 // Check class extensions (unnamed categories) for duplicate ivars.
Aaron Ballmanf53d8dd2014-03-13 21:47:07 +00001207 for (const auto *CDecl : IDecl->visible_extensions()) {
Fariborz Jahaniane23f26b2013-06-26 22:10:27 +00001208 if (const ObjCIvarDecl *ClsExtIvar =
1209 CDecl->getIvarDecl(ImplIvar->getIdentifier())) {
1210 Diag(ImplIvar->getLocation(), diag::err_duplicate_ivar_declaration);
1211 Diag(ClsExtIvar->getLocation(), diag::note_previous_definition);
1212 continue;
1213 }
1214 }
Fariborz Jahanian34e3cef2010-02-19 20:58:54 +00001215 // Instance ivar to Implementation's DeclContext.
1216 ImplIvar->setLexicalDeclContext(ImpDecl);
Richard Smith05afe5e2012-03-13 03:12:56 +00001217 IDecl->makeDeclVisibleInContext(ImplIvar);
Fariborz Jahanian34e3cef2010-02-19 20:58:54 +00001218 ImpDecl->addDecl(ImplIvar);
1219 }
1220 return;
1221 }
Chris Lattnerda463fe2007-12-12 07:09:47 +00001222 // Check interface's Ivar list against those in the implementation.
1223 // names and types must match.
1224 //
Chris Lattnerda463fe2007-12-12 07:09:47 +00001225 unsigned j = 0;
Mike Stump11289f42009-09-09 15:08:12 +00001226 ObjCInterfaceDecl::ivar_iterator
Chris Lattner061227a2007-12-12 17:58:05 +00001227 IVI = IDecl->ivar_begin(), IVE = IDecl->ivar_end();
1228 for (; numIvars > 0 && IVI != IVE; ++IVI) {
Ted Kremenek1b0ea822008-01-07 19:49:32 +00001229 ObjCIvarDecl* ImplIvar = ivars[j++];
David Blaikie40ed2972012-06-06 20:45:41 +00001230 ObjCIvarDecl* ClsIvar = *IVI;
Chris Lattnerda463fe2007-12-12 07:09:47 +00001231 assert (ImplIvar && "missing implementation ivar");
1232 assert (ClsIvar && "missing class ivar");
Mike Stump11289f42009-09-09 15:08:12 +00001233
Steve Naroff157599f2009-03-03 14:49:36 +00001234 // First, make sure the types match.
Richard Smithcaf33902011-10-10 18:28:20 +00001235 if (!Context.hasSameType(ImplIvar->getType(), ClsIvar->getType())) {
Chris Lattner3b054132008-11-19 05:08:23 +00001236 Diag(ImplIvar->getLocation(), diag::err_conflicting_ivar_type)
Chris Lattnere3d20d92008-11-23 21:45:46 +00001237 << ImplIvar->getIdentifier()
1238 << ImplIvar->getType() << ClsIvar->getType();
Chris Lattner0369c572008-11-23 23:12:31 +00001239 Diag(ClsIvar->getLocation(), diag::note_previous_definition);
Richard Smithcaf33902011-10-10 18:28:20 +00001240 } else if (ImplIvar->isBitField() && ClsIvar->isBitField() &&
1241 ImplIvar->getBitWidthValue(Context) !=
1242 ClsIvar->getBitWidthValue(Context)) {
1243 Diag(ImplIvar->getBitWidth()->getLocStart(),
1244 diag::err_conflicting_ivar_bitwidth) << ImplIvar->getIdentifier();
1245 Diag(ClsIvar->getBitWidth()->getLocStart(),
1246 diag::note_previous_definition);
Mike Stump11289f42009-09-09 15:08:12 +00001247 }
Steve Naroff157599f2009-03-03 14:49:36 +00001248 // Make sure the names are identical.
1249 if (ImplIvar->getIdentifier() != ClsIvar->getIdentifier()) {
Chris Lattner3b054132008-11-19 05:08:23 +00001250 Diag(ImplIvar->getLocation(), diag::err_conflicting_ivar_name)
Chris Lattnere3d20d92008-11-23 21:45:46 +00001251 << ImplIvar->getIdentifier() << ClsIvar->getIdentifier();
Chris Lattner0369c572008-11-23 23:12:31 +00001252 Diag(ClsIvar->getLocation(), diag::note_previous_definition);
Chris Lattnerda463fe2007-12-12 07:09:47 +00001253 }
1254 --numIvars;
Chris Lattnerda463fe2007-12-12 07:09:47 +00001255 }
Mike Stump11289f42009-09-09 15:08:12 +00001256
Chris Lattner0f29d982007-12-12 18:11:49 +00001257 if (numIvars > 0)
Alp Tokerfff06742013-12-02 03:50:21 +00001258 Diag(ivars[j]->getLocation(), diag::err_inconsistent_ivar_count);
Chris Lattner0f29d982007-12-12 18:11:49 +00001259 else if (IVI != IVE)
Alp Tokerfff06742013-12-02 03:50:21 +00001260 Diag(IVI->getLocation(), diag::err_inconsistent_ivar_count);
Chris Lattnerda463fe2007-12-12 07:09:47 +00001261}
1262
Ted Kremenekf87decd2013-12-13 05:58:44 +00001263static void WarnUndefinedMethod(Sema &S, SourceLocation ImpLoc,
1264 ObjCMethodDecl *method,
1265 bool &IncompleteImpl,
Ted Kremenek2ccf19e2013-12-13 05:58:51 +00001266 unsigned DiagID,
Craig Topperc3ec1492014-05-26 06:22:03 +00001267 NamedDecl *NeededFor = nullptr) {
Fariborz Jahanian9fc39c42011-06-24 20:31:37 +00001268 // No point warning no definition of method which is 'unavailable'.
Douglas Gregorc2e3d5c2012-12-11 18:53:07 +00001269 switch (method->getAvailability()) {
1270 case AR_Available:
1271 case AR_Deprecated:
1272 break;
1273
1274 // Don't warn about unavailable or not-yet-introduced methods.
1275 case AR_NotYetIntroduced:
1276 case AR_Unavailable:
Fariborz Jahanian9fc39c42011-06-24 20:31:37 +00001277 return;
Douglas Gregorc2e3d5c2012-12-11 18:53:07 +00001278 }
1279
Ted Kremenek65d63572013-03-27 00:02:21 +00001280 // FIXME: For now ignore 'IncompleteImpl'.
1281 // Previously we grouped all unimplemented methods under a single
1282 // warning, but some users strongly voiced that they would prefer
1283 // separate warnings. We will give that approach a try, as that
1284 // matches what we do with protocols.
Ted Kremenek2ccf19e2013-12-13 05:58:51 +00001285 {
1286 const Sema::SemaDiagnosticBuilder &B = S.Diag(ImpLoc, DiagID);
1287 B << method;
1288 if (NeededFor)
1289 B << NeededFor;
1290 }
Ted Kremenek65d63572013-03-27 00:02:21 +00001291
1292 // Issue a note to the original declaration.
1293 SourceLocation MethodLoc = method->getLocStart();
1294 if (MethodLoc.isValid())
Ted Kremenekf87decd2013-12-13 05:58:44 +00001295 S.Diag(MethodLoc, diag::note_method_declared_at) << method;
Steve Naroff15833ed2008-02-10 21:38:56 +00001296}
1297
David Chisnallb62d15c2010-10-25 17:23:52 +00001298/// Determines if type B can be substituted for type A. Returns true if we can
1299/// guarantee that anything that the user will do to an object of type A can
1300/// also be done to an object of type B. This is trivially true if the two
1301/// types are the same, or if B is a subclass of A. It becomes more complex
1302/// in cases where protocols are involved.
1303///
1304/// Object types in Objective-C describe the minimum requirements for an
1305/// object, rather than providing a complete description of a type. For
1306/// example, if A is a subclass of B, then B* may refer to an instance of A.
1307/// The principle of substitutability means that we may use an instance of A
1308/// anywhere that we may use an instance of B - it will implement all of the
1309/// ivars of B and all of the methods of B.
1310///
1311/// This substitutability is important when type checking methods, because
1312/// the implementation may have stricter type definitions than the interface.
1313/// The interface specifies minimum requirements, but the implementation may
1314/// have more accurate ones. For example, a method may privately accept
1315/// instances of B, but only publish that it accepts instances of A. Any
1316/// object passed to it will be type checked against B, and so will implicitly
1317/// by a valid A*. Similarly, a method may return a subclass of the class that
1318/// it is declared as returning.
1319///
1320/// This is most important when considering subclassing. A method in a
1321/// subclass must accept any object as an argument that its superclass's
1322/// implementation accepts. It may, however, accept a more general type
1323/// without breaking substitutability (i.e. you can still use the subclass
1324/// anywhere that you can use the superclass, but not vice versa). The
1325/// converse requirement applies to return types: the return type for a
1326/// subclass method must be a valid object of the kind that the superclass
1327/// advertises, but it may be specified more accurately. This avoids the need
1328/// for explicit down-casting by callers.
1329///
1330/// Note: This is a stricter requirement than for assignment.
John McCall071df462010-10-28 02:34:38 +00001331static bool isObjCTypeSubstitutable(ASTContext &Context,
1332 const ObjCObjectPointerType *A,
1333 const ObjCObjectPointerType *B,
1334 bool rejectId) {
1335 // Reject a protocol-unqualified id.
1336 if (rejectId && B->isObjCIdType()) return false;
David Chisnallb62d15c2010-10-25 17:23:52 +00001337
1338 // If B is a qualified id, then A must also be a qualified id and it must
1339 // implement all of the protocols in B. It may not be a qualified class.
1340 // For example, MyClass<A> can be assigned to id<A>, but MyClass<A> is a
1341 // stricter definition so it is not substitutable for id<A>.
1342 if (B->isObjCQualifiedIdType()) {
1343 return A->isObjCQualifiedIdType() &&
John McCall071df462010-10-28 02:34:38 +00001344 Context.ObjCQualifiedIdTypesAreCompatible(QualType(A, 0),
1345 QualType(B,0),
1346 false);
David Chisnallb62d15c2010-10-25 17:23:52 +00001347 }
1348
1349 /*
1350 // id is a special type that bypasses type checking completely. We want a
1351 // warning when it is used in one place but not another.
1352 if (C.isObjCIdType(A) || C.isObjCIdType(B)) return false;
1353
1354
1355 // If B is a qualified id, then A must also be a qualified id (which it isn't
1356 // if we've got this far)
1357 if (B->isObjCQualifiedIdType()) return false;
1358 */
1359
1360 // Now we know that A and B are (potentially-qualified) class types. The
1361 // normal rules for assignment apply.
John McCall071df462010-10-28 02:34:38 +00001362 return Context.canAssignObjCInterfaces(A, B);
David Chisnallb62d15c2010-10-25 17:23:52 +00001363}
1364
John McCall071df462010-10-28 02:34:38 +00001365static SourceRange getTypeRange(TypeSourceInfo *TSI) {
1366 return (TSI ? TSI->getTypeLoc().getSourceRange() : SourceRange());
1367}
1368
Douglas Gregor813a0662015-06-19 18:14:38 +00001369/// Determine whether two set of Objective-C declaration qualifiers conflict.
1370static bool objcModifiersConflict(Decl::ObjCDeclQualifier x,
1371 Decl::ObjCDeclQualifier y) {
1372 return (x & ~Decl::OBJC_TQ_CSNullability) !=
1373 (y & ~Decl::OBJC_TQ_CSNullability);
1374}
1375
Fariborz Jahanian9f8b19e2011-07-28 23:19:50 +00001376static bool CheckMethodOverrideReturn(Sema &S,
John McCall071df462010-10-28 02:34:38 +00001377 ObjCMethodDecl *MethodImpl,
Fariborz Jahaniand7b0cb52011-02-21 23:49:15 +00001378 ObjCMethodDecl *MethodDecl,
Fariborz Jahanian4ceec3f2011-07-24 20:53:26 +00001379 bool IsProtocolMethodDecl,
Fariborz Jahanian3c12dd72011-08-10 17:16:30 +00001380 bool IsOverridingMode,
Fariborz Jahanian9f8b19e2011-07-28 23:19:50 +00001381 bool Warn) {
Fariborz Jahaniand7b0cb52011-02-21 23:49:15 +00001382 if (IsProtocolMethodDecl &&
Douglas Gregor813a0662015-06-19 18:14:38 +00001383 objcModifiersConflict(MethodDecl->getObjCDeclQualifier(),
1384 MethodImpl->getObjCDeclQualifier())) {
Fariborz Jahanian9f8b19e2011-07-28 23:19:50 +00001385 if (Warn) {
Alp Toker314cc812014-01-25 16:55:45 +00001386 S.Diag(MethodImpl->getLocation(),
1387 (IsOverridingMode
1388 ? diag::warn_conflicting_overriding_ret_type_modifiers
1389 : diag::warn_conflicting_ret_type_modifiers))
Fariborz Jahanian3c12dd72011-08-10 17:16:30 +00001390 << MethodImpl->getDeclName()
Aaron Ballman41b10ac2014-08-01 13:20:09 +00001391 << MethodImpl->getReturnTypeSourceRange();
Alp Toker314cc812014-01-25 16:55:45 +00001392 S.Diag(MethodDecl->getLocation(), diag::note_previous_declaration)
Aaron Ballman41b10ac2014-08-01 13:20:09 +00001393 << MethodDecl->getReturnTypeSourceRange();
Fariborz Jahanian9f8b19e2011-07-28 23:19:50 +00001394 }
1395 else
1396 return false;
Fariborz Jahaniand7b0cb52011-02-21 23:49:15 +00001397 }
Douglas Gregor813a0662015-06-19 18:14:38 +00001398 if (Warn && IsOverridingMode &&
1399 !isa<ObjCImplementationDecl>(MethodImpl->getDeclContext()) &&
1400 !S.Context.hasSameNullabilityTypeQualifier(MethodImpl->getReturnType(),
1401 MethodDecl->getReturnType(),
1402 false)) {
Douglas Gregoraea7afd2015-06-24 22:02:08 +00001403 auto nullabilityMethodImpl =
1404 *MethodImpl->getReturnType()->getNullability(S.Context);
1405 auto nullabilityMethodDecl =
1406 *MethodDecl->getReturnType()->getNullability(S.Context);
Douglas Gregor813a0662015-06-19 18:14:38 +00001407 S.Diag(MethodImpl->getLocation(),
1408 diag::warn_conflicting_nullability_attr_overriding_ret_types)
Douglas Gregoraea7afd2015-06-24 22:02:08 +00001409 << DiagNullabilityKind(
1410 nullabilityMethodImpl,
1411 ((MethodImpl->getObjCDeclQualifier() & Decl::OBJC_TQ_CSNullability)
1412 != 0))
1413 << DiagNullabilityKind(
1414 nullabilityMethodDecl,
1415 ((MethodDecl->getObjCDeclQualifier() & Decl::OBJC_TQ_CSNullability)
1416 != 0));
Douglas Gregor813a0662015-06-19 18:14:38 +00001417 S.Diag(MethodDecl->getLocation(), diag::note_previous_declaration);
1418 }
1419
Alp Toker314cc812014-01-25 16:55:45 +00001420 if (S.Context.hasSameUnqualifiedType(MethodImpl->getReturnType(),
1421 MethodDecl->getReturnType()))
Fariborz Jahanian9f8b19e2011-07-28 23:19:50 +00001422 return true;
1423 if (!Warn)
1424 return false;
John McCall071df462010-10-28 02:34:38 +00001425
Fariborz Jahanian3c12dd72011-08-10 17:16:30 +00001426 unsigned DiagID =
1427 IsOverridingMode ? diag::warn_conflicting_overriding_ret_types
1428 : diag::warn_conflicting_ret_types;
John McCall071df462010-10-28 02:34:38 +00001429
1430 // Mismatches between ObjC pointers go into a different warning
1431 // category, and sometimes they're even completely whitelisted.
1432 if (const ObjCObjectPointerType *ImplPtrTy =
Alp Toker314cc812014-01-25 16:55:45 +00001433 MethodImpl->getReturnType()->getAs<ObjCObjectPointerType>()) {
John McCall071df462010-10-28 02:34:38 +00001434 if (const ObjCObjectPointerType *IfacePtrTy =
Alp Toker314cc812014-01-25 16:55:45 +00001435 MethodDecl->getReturnType()->getAs<ObjCObjectPointerType>()) {
John McCall071df462010-10-28 02:34:38 +00001436 // Allow non-matching return types as long as they don't violate
1437 // the principle of substitutability. Specifically, we permit
1438 // return types that are subclasses of the declared return type,
1439 // or that are more-qualified versions of the declared type.
1440 if (isObjCTypeSubstitutable(S.Context, IfacePtrTy, ImplPtrTy, false))
Fariborz Jahanian9f8b19e2011-07-28 23:19:50 +00001441 return false;
John McCall071df462010-10-28 02:34:38 +00001442
Fariborz Jahanian3c12dd72011-08-10 17:16:30 +00001443 DiagID =
1444 IsOverridingMode ? diag::warn_non_covariant_overriding_ret_types
1445 : diag::warn_non_covariant_ret_types;
John McCall071df462010-10-28 02:34:38 +00001446 }
1447 }
1448
1449 S.Diag(MethodImpl->getLocation(), DiagID)
Alp Toker314cc812014-01-25 16:55:45 +00001450 << MethodImpl->getDeclName() << MethodDecl->getReturnType()
1451 << MethodImpl->getReturnType()
Aaron Ballman41b10ac2014-08-01 13:20:09 +00001452 << MethodImpl->getReturnTypeSourceRange();
Alp Toker314cc812014-01-25 16:55:45 +00001453 S.Diag(MethodDecl->getLocation(), IsOverridingMode
1454 ? diag::note_previous_declaration
1455 : diag::note_previous_definition)
Aaron Ballman41b10ac2014-08-01 13:20:09 +00001456 << MethodDecl->getReturnTypeSourceRange();
Fariborz Jahanian9f8b19e2011-07-28 23:19:50 +00001457 return false;
John McCall071df462010-10-28 02:34:38 +00001458}
1459
Fariborz Jahanian9f8b19e2011-07-28 23:19:50 +00001460static bool CheckMethodOverrideParam(Sema &S,
John McCall071df462010-10-28 02:34:38 +00001461 ObjCMethodDecl *MethodImpl,
Fariborz Jahaniand7b0cb52011-02-21 23:49:15 +00001462 ObjCMethodDecl *MethodDecl,
John McCall071df462010-10-28 02:34:38 +00001463 ParmVarDecl *ImplVar,
Fariborz Jahaniand7b0cb52011-02-21 23:49:15 +00001464 ParmVarDecl *IfaceVar,
Fariborz Jahanian4ceec3f2011-07-24 20:53:26 +00001465 bool IsProtocolMethodDecl,
Fariborz Jahanian3c12dd72011-08-10 17:16:30 +00001466 bool IsOverridingMode,
Fariborz Jahanian9f8b19e2011-07-28 23:19:50 +00001467 bool Warn) {
Fariborz Jahaniand7b0cb52011-02-21 23:49:15 +00001468 if (IsProtocolMethodDecl &&
Douglas Gregor813a0662015-06-19 18:14:38 +00001469 objcModifiersConflict(ImplVar->getObjCDeclQualifier(),
1470 IfaceVar->getObjCDeclQualifier())) {
Fariborz Jahanian9f8b19e2011-07-28 23:19:50 +00001471 if (Warn) {
Fariborz Jahanian3c12dd72011-08-10 17:16:30 +00001472 if (IsOverridingMode)
1473 S.Diag(ImplVar->getLocation(),
1474 diag::warn_conflicting_overriding_param_modifiers)
1475 << getTypeRange(ImplVar->getTypeSourceInfo())
1476 << MethodImpl->getDeclName();
1477 else S.Diag(ImplVar->getLocation(),
Fariborz Jahanian9f8b19e2011-07-28 23:19:50 +00001478 diag::warn_conflicting_param_modifiers)
1479 << getTypeRange(ImplVar->getTypeSourceInfo())
Fariborz Jahanian3c12dd72011-08-10 17:16:30 +00001480 << MethodImpl->getDeclName();
Fariborz Jahanian9f8b19e2011-07-28 23:19:50 +00001481 S.Diag(IfaceVar->getLocation(), diag::note_previous_declaration)
1482 << getTypeRange(IfaceVar->getTypeSourceInfo());
1483 }
1484 else
1485 return false;
Fariborz Jahaniand7b0cb52011-02-21 23:49:15 +00001486 }
1487
John McCall071df462010-10-28 02:34:38 +00001488 QualType ImplTy = ImplVar->getType();
1489 QualType IfaceTy = IfaceVar->getType();
Douglas Gregor813a0662015-06-19 18:14:38 +00001490 if (Warn && IsOverridingMode &&
1491 !isa<ObjCImplementationDecl>(MethodImpl->getDeclContext()) &&
1492 !S.Context.hasSameNullabilityTypeQualifier(ImplTy, IfaceTy, true)) {
Douglas Gregor813a0662015-06-19 18:14:38 +00001493 S.Diag(ImplVar->getLocation(),
1494 diag::warn_conflicting_nullability_attr_overriding_param_types)
Douglas Gregoraea7afd2015-06-24 22:02:08 +00001495 << DiagNullabilityKind(
1496 *ImplTy->getNullability(S.Context),
1497 ((ImplVar->getObjCDeclQualifier() & Decl::OBJC_TQ_CSNullability)
1498 != 0))
1499 << DiagNullabilityKind(
1500 *IfaceTy->getNullability(S.Context),
1501 ((IfaceVar->getObjCDeclQualifier() & Decl::OBJC_TQ_CSNullability)
1502 != 0));
1503 S.Diag(IfaceVar->getLocation(), diag::note_previous_declaration);
Douglas Gregor813a0662015-06-19 18:14:38 +00001504 }
John McCall071df462010-10-28 02:34:38 +00001505 if (S.Context.hasSameUnqualifiedType(ImplTy, IfaceTy))
Fariborz Jahanian9f8b19e2011-07-28 23:19:50 +00001506 return true;
1507
1508 if (!Warn)
1509 return false;
Fariborz Jahanian3c12dd72011-08-10 17:16:30 +00001510 unsigned DiagID =
1511 IsOverridingMode ? diag::warn_conflicting_overriding_param_types
1512 : diag::warn_conflicting_param_types;
John McCall071df462010-10-28 02:34:38 +00001513
1514 // Mismatches between ObjC pointers go into a different warning
1515 // category, and sometimes they're even completely whitelisted.
1516 if (const ObjCObjectPointerType *ImplPtrTy =
1517 ImplTy->getAs<ObjCObjectPointerType>()) {
1518 if (const ObjCObjectPointerType *IfacePtrTy =
1519 IfaceTy->getAs<ObjCObjectPointerType>()) {
1520 // Allow non-matching argument types as long as they don't
1521 // violate the principle of substitutability. Specifically, the
1522 // implementation must accept any objects that the superclass
1523 // accepts, however it may also accept others.
1524 if (isObjCTypeSubstitutable(S.Context, ImplPtrTy, IfacePtrTy, true))
Fariborz Jahanian9f8b19e2011-07-28 23:19:50 +00001525 return false;
John McCall071df462010-10-28 02:34:38 +00001526
Fariborz Jahanian3c12dd72011-08-10 17:16:30 +00001527 DiagID =
1528 IsOverridingMode ? diag::warn_non_contravariant_overriding_param_types
1529 : diag::warn_non_contravariant_param_types;
John McCall071df462010-10-28 02:34:38 +00001530 }
1531 }
1532
1533 S.Diag(ImplVar->getLocation(), DiagID)
1534 << getTypeRange(ImplVar->getTypeSourceInfo())
Fariborz Jahanian3c12dd72011-08-10 17:16:30 +00001535 << MethodImpl->getDeclName() << IfaceTy << ImplTy;
1536 S.Diag(IfaceVar->getLocation(),
1537 (IsOverridingMode ? diag::note_previous_declaration
1538 : diag::note_previous_definition))
John McCall071df462010-10-28 02:34:38 +00001539 << getTypeRange(IfaceVar->getTypeSourceInfo());
Fariborz Jahanian9f8b19e2011-07-28 23:19:50 +00001540 return false;
John McCall071df462010-10-28 02:34:38 +00001541}
John McCall31168b02011-06-15 23:02:42 +00001542
1543/// In ARC, check whether the conventional meanings of the two methods
1544/// match. If they don't, it's a hard error.
1545static bool checkMethodFamilyMismatch(Sema &S, ObjCMethodDecl *impl,
1546 ObjCMethodDecl *decl) {
1547 ObjCMethodFamily implFamily = impl->getMethodFamily();
1548 ObjCMethodFamily declFamily = decl->getMethodFamily();
1549 if (implFamily == declFamily) return false;
1550
1551 // Since conventions are sorted by selector, the only possibility is
1552 // that the types differ enough to cause one selector or the other
1553 // to fall out of the family.
1554 assert(implFamily == OMF_None || declFamily == OMF_None);
1555
1556 // No further diagnostics required on invalid declarations.
1557 if (impl->isInvalidDecl() || decl->isInvalidDecl()) return true;
1558
1559 const ObjCMethodDecl *unmatched = impl;
1560 ObjCMethodFamily family = declFamily;
1561 unsigned errorID = diag::err_arc_lost_method_convention;
1562 unsigned noteID = diag::note_arc_lost_method_convention;
1563 if (declFamily == OMF_None) {
1564 unmatched = decl;
1565 family = implFamily;
1566 errorID = diag::err_arc_gained_method_convention;
1567 noteID = diag::note_arc_gained_method_convention;
1568 }
1569
1570 // Indexes into a %select clause in the diagnostic.
1571 enum FamilySelector {
1572 F_alloc, F_copy, F_mutableCopy = F_copy, F_init, F_new
1573 };
1574 FamilySelector familySelector = FamilySelector();
1575
1576 switch (family) {
1577 case OMF_None: llvm_unreachable("logic error, no method convention");
1578 case OMF_retain:
1579 case OMF_release:
1580 case OMF_autorelease:
1581 case OMF_dealloc:
Nico Weber1fb82662011-08-28 22:35:17 +00001582 case OMF_finalize:
John McCall31168b02011-06-15 23:02:42 +00001583 case OMF_retainCount:
1584 case OMF_self:
Fariborz Jahanian78e9deb2014-08-22 16:57:26 +00001585 case OMF_initialize:
Fariborz Jahanianb7a77362011-07-05 22:38:59 +00001586 case OMF_performSelector:
John McCall31168b02011-06-15 23:02:42 +00001587 // Mismatches for these methods don't change ownership
1588 // conventions, so we don't care.
1589 return false;
1590
1591 case OMF_init: familySelector = F_init; break;
1592 case OMF_alloc: familySelector = F_alloc; break;
1593 case OMF_copy: familySelector = F_copy; break;
1594 case OMF_mutableCopy: familySelector = F_mutableCopy; break;
1595 case OMF_new: familySelector = F_new; break;
1596 }
1597
1598 enum ReasonSelector { R_NonObjectReturn, R_UnrelatedReturn };
1599 ReasonSelector reasonSelector;
1600
1601 // The only reason these methods don't fall within their families is
1602 // due to unusual result types.
Alp Toker314cc812014-01-25 16:55:45 +00001603 if (unmatched->getReturnType()->isObjCObjectPointerType()) {
John McCall31168b02011-06-15 23:02:42 +00001604 reasonSelector = R_UnrelatedReturn;
1605 } else {
1606 reasonSelector = R_NonObjectReturn;
1607 }
1608
Joerg Sonnenbergerffc6d492013-06-26 21:31:47 +00001609 S.Diag(impl->getLocation(), errorID) << int(familySelector) << int(reasonSelector);
1610 S.Diag(decl->getLocation(), noteID) << int(familySelector) << int(reasonSelector);
John McCall31168b02011-06-15 23:02:42 +00001611
1612 return true;
1613}
John McCall071df462010-10-28 02:34:38 +00001614
Fariborz Jahanian7988d7d2008-12-05 18:18:52 +00001615void Sema::WarnConflictingTypedMethods(ObjCMethodDecl *ImpMethodDecl,
Fariborz Jahaniand7b0cb52011-02-21 23:49:15 +00001616 ObjCMethodDecl *MethodDecl,
Fariborz Jahanian9a81f842011-10-10 17:53:29 +00001617 bool IsProtocolMethodDecl) {
David Blaikiebbafb8a2012-03-11 07:00:24 +00001618 if (getLangOpts().ObjCAutoRefCount &&
John McCall31168b02011-06-15 23:02:42 +00001619 checkMethodFamilyMismatch(*this, ImpMethodDecl, MethodDecl))
1620 return;
1621
Fariborz Jahaniand7b0cb52011-02-21 23:49:15 +00001622 CheckMethodOverrideReturn(*this, ImpMethodDecl, MethodDecl,
Fariborz Jahanian9a81f842011-10-10 17:53:29 +00001623 IsProtocolMethodDecl, false,
Fariborz Jahanian3c12dd72011-08-10 17:16:30 +00001624 true);
Mike Stump11289f42009-09-09 15:08:12 +00001625
Chris Lattner67f35b02009-04-11 19:58:42 +00001626 for (ObjCMethodDecl::param_iterator IM = ImpMethodDecl->param_begin(),
Douglas Gregor0bf70f42012-05-17 23:13:29 +00001627 IF = MethodDecl->param_begin(), EM = ImpMethodDecl->param_end(),
1628 EF = MethodDecl->param_end();
1629 IM != EM && IF != EF; ++IM, ++IF) {
Fariborz Jahanian3c12dd72011-08-10 17:16:30 +00001630 CheckMethodOverrideParam(*this, ImpMethodDecl, MethodDecl, *IM, *IF,
Fariborz Jahanian9a81f842011-10-10 17:53:29 +00001631 IsProtocolMethodDecl, false, true);
Fariborz Jahanian5ac085a2011-08-08 18:03:17 +00001632 }
Fariborz Jahanian3c12dd72011-08-10 17:16:30 +00001633
Fariborz Jahanian5ac085a2011-08-08 18:03:17 +00001634 if (ImpMethodDecl->isVariadic() != MethodDecl->isVariadic()) {
Fariborz Jahanian9a81f842011-10-10 17:53:29 +00001635 Diag(ImpMethodDecl->getLocation(),
1636 diag::warn_conflicting_variadic);
Fariborz Jahanian5ac085a2011-08-08 18:03:17 +00001637 Diag(MethodDecl->getLocation(), diag::note_previous_declaration);
Fariborz Jahanian5ac085a2011-08-08 18:03:17 +00001638 }
Fariborz Jahanian5ac085a2011-08-08 18:03:17 +00001639}
1640
Fariborz Jahanian9a81f842011-10-10 17:53:29 +00001641void Sema::CheckConflictingOverridingMethod(ObjCMethodDecl *Method,
1642 ObjCMethodDecl *Overridden,
1643 bool IsProtocolMethodDecl) {
1644
1645 CheckMethodOverrideReturn(*this, Method, Overridden,
1646 IsProtocolMethodDecl, true,
1647 true);
1648
1649 for (ObjCMethodDecl::param_iterator IM = Method->param_begin(),
Douglas Gregor0bf70f42012-05-17 23:13:29 +00001650 IF = Overridden->param_begin(), EM = Method->param_end(),
1651 EF = Overridden->param_end();
1652 IM != EM && IF != EF; ++IM, ++IF) {
Fariborz Jahanian9a81f842011-10-10 17:53:29 +00001653 CheckMethodOverrideParam(*this, Method, Overridden, *IM, *IF,
1654 IsProtocolMethodDecl, true, true);
1655 }
1656
1657 if (Method->isVariadic() != Overridden->isVariadic()) {
1658 Diag(Method->getLocation(),
1659 diag::warn_conflicting_overriding_variadic);
1660 Diag(Overridden->getLocation(), diag::note_previous_declaration);
1661 }
1662}
1663
Fariborz Jahanian9f8b19e2011-07-28 23:19:50 +00001664/// WarnExactTypedMethods - This routine issues a warning if method
1665/// implementation declaration matches exactly that of its declaration.
1666void Sema::WarnExactTypedMethods(ObjCMethodDecl *ImpMethodDecl,
1667 ObjCMethodDecl *MethodDecl,
1668 bool IsProtocolMethodDecl) {
1669 // don't issue warning when protocol method is optional because primary
1670 // class is not required to implement it and it is safe for protocol
1671 // to implement it.
1672 if (MethodDecl->getImplementationControl() == ObjCMethodDecl::Optional)
1673 return;
1674 // don't issue warning when primary class's method is
1675 // depecated/unavailable.
1676 if (MethodDecl->hasAttr<UnavailableAttr>() ||
1677 MethodDecl->hasAttr<DeprecatedAttr>())
1678 return;
1679
1680 bool match = CheckMethodOverrideReturn(*this, ImpMethodDecl, MethodDecl,
1681 IsProtocolMethodDecl, false, false);
1682 if (match)
1683 for (ObjCMethodDecl::param_iterator IM = ImpMethodDecl->param_begin(),
Douglas Gregor0bf70f42012-05-17 23:13:29 +00001684 IF = MethodDecl->param_begin(), EM = ImpMethodDecl->param_end(),
1685 EF = MethodDecl->param_end();
1686 IM != EM && IF != EF; ++IM, ++IF) {
Fariborz Jahanian9f8b19e2011-07-28 23:19:50 +00001687 match = CheckMethodOverrideParam(*this, ImpMethodDecl, MethodDecl,
1688 *IM, *IF,
1689 IsProtocolMethodDecl, false, false);
1690 if (!match)
1691 break;
1692 }
1693 if (match)
1694 match = (ImpMethodDecl->isVariadic() == MethodDecl->isVariadic());
David Chisnall92918512011-08-08 17:32:19 +00001695 if (match)
1696 match = !(MethodDecl->isClassMethod() &&
1697 MethodDecl->getSelector() == GetNullarySelector("load", Context));
Fariborz Jahanian9f8b19e2011-07-28 23:19:50 +00001698
1699 if (match) {
1700 Diag(ImpMethodDecl->getLocation(),
1701 diag::warn_category_method_impl_match);
Ted Kremenek59b10db2012-02-27 22:55:11 +00001702 Diag(MethodDecl->getLocation(), diag::note_method_declared_at)
1703 << MethodDecl->getDeclName();
Fariborz Jahanian9f8b19e2011-07-28 23:19:50 +00001704 }
1705}
1706
Mike Stump87c57ac2009-05-16 07:39:55 +00001707/// FIXME: Type hierarchies in Objective-C can be deep. We could most likely
1708/// improve the efficiency of selector lookups and type checking by associating
1709/// with each protocol / interface / category the flattened instance tables. If
1710/// we used an immutable set to keep the table then it wouldn't add significant
1711/// memory cost and it would be handy for lookups.
Daniel Dunbar4684f372008-08-27 05:40:03 +00001712
Ted Kremenek4b3c66e2014-03-05 08:13:08 +00001713typedef llvm::DenseSet<IdentifierInfo*> ProtocolNameSet;
Ahmed Charlesaf94d562014-03-09 11:34:25 +00001714typedef std::unique_ptr<ProtocolNameSet> LazyProtocolNameSet;
Ted Kremenek760a2ac2014-03-05 23:18:22 +00001715
1716static void findProtocolsWithExplicitImpls(const ObjCProtocolDecl *PDecl,
1717 ProtocolNameSet &PNS) {
1718 if (PDecl->hasAttr<ObjCExplicitProtocolImplAttr>())
1719 PNS.insert(PDecl->getIdentifier());
Aaron Ballman0f6e64d2014-03-13 22:58:06 +00001720 for (const auto *PI : PDecl->protocols())
1721 findProtocolsWithExplicitImpls(PI, PNS);
Ted Kremenek760a2ac2014-03-05 23:18:22 +00001722}
1723
Ted Kremenek4b3c66e2014-03-05 08:13:08 +00001724/// Recursively populates a set with all conformed protocols in a class
1725/// hierarchy that have the 'objc_protocol_requires_explicit_implementation'
1726/// attribute.
1727static void findProtocolsWithExplicitImpls(const ObjCInterfaceDecl *Super,
1728 ProtocolNameSet &PNS) {
1729 if (!Super)
1730 return;
1731
Aaron Ballmana9f49e32014-03-13 20:55:22 +00001732 for (const auto *I : Super->all_referenced_protocols())
1733 findProtocolsWithExplicitImpls(I, PNS);
Ted Kremenek760a2ac2014-03-05 23:18:22 +00001734
1735 findProtocolsWithExplicitImpls(Super->getSuperClass(), PNS);
Ted Kremenek4b3c66e2014-03-05 08:13:08 +00001736}
1737
Steve Naroffa36992242008-02-08 22:06:17 +00001738/// CheckProtocolMethodDefs - This routine checks unimplemented methods
Chris Lattnerda463fe2007-12-12 07:09:47 +00001739/// Declared in protocol, and those referenced by it.
Ted Kremenek285ee852013-12-13 06:26:10 +00001740static void CheckProtocolMethodDefs(Sema &S,
1741 SourceLocation ImpLoc,
1742 ObjCProtocolDecl *PDecl,
1743 bool& IncompleteImpl,
1744 const Sema::SelectorSet &InsMap,
1745 const Sema::SelectorSet &ClsMap,
Ted Kremenek33e430f2013-12-13 06:26:14 +00001746 ObjCContainerDecl *CDecl,
Ted Kremenek4b3c66e2014-03-05 08:13:08 +00001747 LazyProtocolNameSet &ProtocolsExplictImpl) {
Fariborz Jahanian29082a52012-02-09 21:30:24 +00001748 ObjCCategoryDecl *C = dyn_cast<ObjCCategoryDecl>(CDecl);
1749 ObjCInterfaceDecl *IDecl = C ? C->getClassInterface()
1750 : dyn_cast<ObjCInterfaceDecl>(CDecl);
Fariborz Jahanian2e8074b2010-03-27 21:10:05 +00001751 assert (IDecl && "CheckProtocolMethodDefs - IDecl is null");
1752
Daniel Dunbarc7dfbfd2008-09-04 20:01:15 +00001753 ObjCInterfaceDecl *Super = IDecl->getSuperClass();
Craig Topperc3ec1492014-05-26 06:22:03 +00001754 ObjCInterfaceDecl *NSIDecl = nullptr;
Ted Kremenek4b3c66e2014-03-05 08:13:08 +00001755
1756 // If this protocol is marked 'objc_protocol_requires_explicit_implementation'
1757 // then we should check if any class in the super class hierarchy also
1758 // conforms to this protocol, either directly or via protocol inheritance.
1759 // If so, we can skip checking this protocol completely because we
1760 // know that a parent class already satisfies this protocol.
1761 //
1762 // Note: we could generalize this logic for all protocols, and merely
1763 // add the limit on looking at the super class chain for just
1764 // specially marked protocols. This may be a good optimization. This
1765 // change is restricted to 'objc_protocol_requires_explicit_implementation'
1766 // protocols for now for controlled evaluation.
1767 if (PDecl->hasAttr<ObjCExplicitProtocolImplAttr>()) {
Ahmed Charlesaf94d562014-03-09 11:34:25 +00001768 if (!ProtocolsExplictImpl) {
Ted Kremenek4b3c66e2014-03-05 08:13:08 +00001769 ProtocolsExplictImpl.reset(new ProtocolNameSet);
1770 findProtocolsWithExplicitImpls(Super, *ProtocolsExplictImpl);
1771 }
1772 if (ProtocolsExplictImpl->find(PDecl->getIdentifier()) !=
1773 ProtocolsExplictImpl->end())
1774 return;
1775
1776 // If no super class conforms to the protocol, we should not search
1777 // for methods in the super class to implicitly satisfy the protocol.
Craig Topperc3ec1492014-05-26 06:22:03 +00001778 Super = nullptr;
Ted Kremenek4b3c66e2014-03-05 08:13:08 +00001779 }
1780
Ted Kremenek285ee852013-12-13 06:26:10 +00001781 if (S.getLangOpts().ObjCRuntime.isNeXTFamily()) {
Mike Stump11289f42009-09-09 15:08:12 +00001782 // check to see if class implements forwardInvocation method and objects
1783 // of this class are derived from 'NSProxy' so that to forward requests
Fariborz Jahaniandb3a4c12009-05-22 17:12:32 +00001784 // from one object to another.
Mike Stump11289f42009-09-09 15:08:12 +00001785 // Under such conditions, which means that every method possible is
1786 // implemented in the class, we should not issue "Method definition not
Fariborz Jahaniandb3a4c12009-05-22 17:12:32 +00001787 // found" warnings.
1788 // FIXME: Use a general GetUnarySelector method for this.
Ted Kremenek285ee852013-12-13 06:26:10 +00001789 IdentifierInfo* II = &S.Context.Idents.get("forwardInvocation");
1790 Selector fISelector = S.Context.Selectors.getSelector(1, &II);
Fariborz Jahaniandb3a4c12009-05-22 17:12:32 +00001791 if (InsMap.count(fISelector))
1792 // Is IDecl derived from 'NSProxy'? If so, no instance methods
1793 // need be implemented in the implementation.
Ted Kremenek285ee852013-12-13 06:26:10 +00001794 NSIDecl = IDecl->lookupInheritedClass(&S.Context.Idents.get("NSProxy"));
Fariborz Jahaniandb3a4c12009-05-22 17:12:32 +00001795 }
Mike Stump11289f42009-09-09 15:08:12 +00001796
Fariborz Jahanianc41cf052013-01-07 19:21:03 +00001797 // If this is a forward protocol declaration, get its definition.
1798 if (!PDecl->isThisDeclarationADefinition() &&
1799 PDecl->getDefinition())
1800 PDecl = PDecl->getDefinition();
1801
Daniel Dunbarc7dfbfd2008-09-04 20:01:15 +00001802 // If a method lookup fails locally we still need to look and see if
1803 // the method was implemented by a base class or an inherited
1804 // protocol. This lookup is slow, but occurs rarely in correct code
1805 // and otherwise would terminate in a warning.
1806
Chris Lattnerda463fe2007-12-12 07:09:47 +00001807 // check unimplemented instance methods.
Fariborz Jahaniandb3a4c12009-05-22 17:12:32 +00001808 if (!NSIDecl)
Aaron Ballmanf26acce2014-03-13 19:50:17 +00001809 for (auto *method : PDecl->instance_methods()) {
Mike Stump11289f42009-09-09 15:08:12 +00001810 if (method->getImplementationControl() != ObjCMethodDecl::Optional &&
Jordan Rosed01e83a2012-10-10 16:42:25 +00001811 !method->isPropertyAccessor() &&
1812 !InsMap.count(method->getSelector()) &&
Ted Kremenek00781502013-11-23 01:01:29 +00001813 (!Super || !Super->lookupMethod(method->getSelector(),
1814 true /* instance */,
1815 false /* shallowCategory */,
Ted Kremenek28eace62013-11-23 01:01:34 +00001816 true /* followsSuper */,
Craig Topperc3ec1492014-05-26 06:22:03 +00001817 nullptr /* category */))) {
Fariborz Jahanian29082a52012-02-09 21:30:24 +00001818 // If a method is not implemented in the category implementation but
1819 // has been declared in its primary class, superclass,
1820 // or in one of their protocols, no need to issue the warning.
1821 // This is because method will be implemented in the primary class
1822 // or one of its super class implementation.
1823
Fariborz Jahaniandb3a4c12009-05-22 17:12:32 +00001824 // Ugly, but necessary. Method declared in protcol might have
1825 // have been synthesized due to a property declared in the class which
1826 // uses the protocol.
Fariborz Jahanian29082a52012-02-09 21:30:24 +00001827 if (ObjCMethodDecl *MethodInClass =
Ted Kremenek00781502013-11-23 01:01:29 +00001828 IDecl->lookupMethod(method->getSelector(),
1829 true /* instance */,
1830 true /* shallowCategoryLookup */,
1831 false /* followSuper */))
Jordan Rosed01e83a2012-10-10 16:42:25 +00001832 if (C || MethodInClass->isPropertyAccessor())
Fariborz Jahanian29082a52012-02-09 21:30:24 +00001833 continue;
1834 unsigned DIAG = diag::warn_unimplemented_protocol_method;
Alp Tokerd4a3f0e2014-06-15 23:30:39 +00001835 if (!S.Diags.isIgnored(DIAG, ImpLoc)) {
Ted Kremenek285ee852013-12-13 06:26:10 +00001836 WarnUndefinedMethod(S, ImpLoc, method, IncompleteImpl, DIAG,
Ted Kremenek2ccf19e2013-12-13 05:58:51 +00001837 PDecl);
Fariborz Jahanian97752f72010-03-27 19:02:17 +00001838 }
Fariborz Jahaniandb3a4c12009-05-22 17:12:32 +00001839 }
1840 }
Chris Lattnerda463fe2007-12-12 07:09:47 +00001841 // check unimplemented class methods
Aaron Ballmane8a7dc92014-03-13 20:11:06 +00001842 for (auto *method : PDecl->class_methods()) {
Daniel Dunbarc7dfbfd2008-09-04 20:01:15 +00001843 if (method->getImplementationControl() != ObjCMethodDecl::Optional &&
1844 !ClsMap.count(method->getSelector()) &&
Ted Kremenek00781502013-11-23 01:01:29 +00001845 (!Super || !Super->lookupMethod(method->getSelector(),
1846 false /* class method */,
1847 false /* shallowCategoryLookup */,
Ted Kremenek28eace62013-11-23 01:01:34 +00001848 true /* followSuper */,
Craig Topperc3ec1492014-05-26 06:22:03 +00001849 nullptr /* category */))) {
Fariborz Jahanian29082a52012-02-09 21:30:24 +00001850 // See above comment for instance method lookups.
Ted Kremenek00781502013-11-23 01:01:29 +00001851 if (C && IDecl->lookupMethod(method->getSelector(),
1852 false /* class */,
1853 true /* shallowCategoryLookup */,
1854 false /* followSuper */))
Fariborz Jahanian29082a52012-02-09 21:30:24 +00001855 continue;
Ted Kremenek00781502013-11-23 01:01:29 +00001856
Fariborz Jahanianc1fb8622010-03-31 18:23:33 +00001857 unsigned DIAG = diag::warn_unimplemented_protocol_method;
Alp Tokerd4a3f0e2014-06-15 23:30:39 +00001858 if (!S.Diags.isIgnored(DIAG, ImpLoc)) {
Ted Kremenek285ee852013-12-13 06:26:10 +00001859 WarnUndefinedMethod(S, ImpLoc, method, IncompleteImpl, DIAG, PDecl);
Fariborz Jahanianc1fb8622010-03-31 18:23:33 +00001860 }
Fariborz Jahanian97752f72010-03-27 19:02:17 +00001861 }
Steve Naroff3ce37a62007-12-14 23:37:57 +00001862 }
Chris Lattner390d39a2008-07-21 21:32:27 +00001863 // Check on this protocols's referenced protocols, recursively.
Aaron Ballman0f6e64d2014-03-13 22:58:06 +00001864 for (auto *PI : PDecl->protocols())
1865 CheckProtocolMethodDefs(S, ImpLoc, PI, IncompleteImpl, InsMap, ClsMap,
Ted Kremenek4b3c66e2014-03-05 08:13:08 +00001866 CDecl, ProtocolsExplictImpl);
Chris Lattnerda463fe2007-12-12 07:09:47 +00001867}
1868
Fariborz Jahanianf9ae68a2011-07-16 00:08:33 +00001869/// MatchAllMethodDeclarations - Check methods declared in interface
Fariborz Jahanian07b71652009-05-01 20:07:12 +00001870/// or protocol against those declared in their implementations.
1871///
Benjamin Kramerb33ffee2012-05-27 13:28:52 +00001872void Sema::MatchAllMethodDeclarations(const SelectorSet &InsMap,
1873 const SelectorSet &ClsMap,
1874 SelectorSet &InsMapSeen,
1875 SelectorSet &ClsMapSeen,
Fariborz Jahanian07b71652009-05-01 20:07:12 +00001876 ObjCImplDecl* IMPDecl,
1877 ObjCContainerDecl* CDecl,
1878 bool &IncompleteImpl,
Fariborz Jahanian9f8b19e2011-07-28 23:19:50 +00001879 bool ImmediateClass,
Fariborz Jahanian29082a52012-02-09 21:30:24 +00001880 bool WarnCategoryMethodImpl) {
Fariborz Jahanian07b71652009-05-01 20:07:12 +00001881 // Check and see if instance methods in class interface have been
1882 // implemented in the implementation class. If so, their types match.
Aaron Ballmanf26acce2014-03-13 19:50:17 +00001883 for (auto *I : CDecl->instance_methods()) {
David Blaikie82e95a32014-11-19 07:49:47 +00001884 if (!InsMapSeen.insert(I->getSelector()).second)
Benjamin Kramer9f8e2d72013-10-14 15:16:10 +00001885 continue;
Aaron Ballmanf26acce2014-03-13 19:50:17 +00001886 if (!I->isPropertyAccessor() &&
1887 !InsMap.count(I->getSelector())) {
Fariborz Jahanian07b71652009-05-01 20:07:12 +00001888 if (ImmediateClass)
Aaron Ballmanf26acce2014-03-13 19:50:17 +00001889 WarnUndefinedMethod(*this, IMPDecl->getLocation(), I, IncompleteImpl,
Ted Kremenek65d63572013-03-27 00:02:21 +00001890 diag::warn_undef_method_impl);
Fariborz Jahanian07b71652009-05-01 20:07:12 +00001891 continue;
Mike Stump12b8ce12009-08-04 21:02:39 +00001892 } else {
Mike Stump11289f42009-09-09 15:08:12 +00001893 ObjCMethodDecl *ImpMethodDecl =
Aaron Ballmanf26acce2014-03-13 19:50:17 +00001894 IMPDecl->getInstanceMethod(I->getSelector());
1895 assert(CDecl->getInstanceMethod(I->getSelector()) &&
Argyrios Kyrtzidis342e08f2011-08-30 19:43:21 +00001896 "Expected to find the method through lookup as well");
Fariborz Jahanian07b71652009-05-01 20:07:12 +00001897 // ImpMethodDecl may be null as in a @dynamic property.
Fariborz Jahanian9f8b19e2011-07-28 23:19:50 +00001898 if (ImpMethodDecl) {
Fariborz Jahanian29082a52012-02-09 21:30:24 +00001899 if (!WarnCategoryMethodImpl)
Aaron Ballmanf26acce2014-03-13 19:50:17 +00001900 WarnConflictingTypedMethods(ImpMethodDecl, I,
Fariborz Jahanian9f8b19e2011-07-28 23:19:50 +00001901 isa<ObjCProtocolDecl>(CDecl));
Aaron Ballmanf26acce2014-03-13 19:50:17 +00001902 else if (!I->isPropertyAccessor())
1903 WarnExactTypedMethods(ImpMethodDecl, I, isa<ObjCProtocolDecl>(CDecl));
Fariborz Jahanian9f8b19e2011-07-28 23:19:50 +00001904 }
Fariborz Jahanian07b71652009-05-01 20:07:12 +00001905 }
1906 }
Mike Stump11289f42009-09-09 15:08:12 +00001907
Fariborz Jahanian07b71652009-05-01 20:07:12 +00001908 // Check and see if class methods in class interface have been
1909 // implemented in the implementation class. If so, their types match.
Aaron Ballmane8a7dc92014-03-13 20:11:06 +00001910 for (auto *I : CDecl->class_methods()) {
David Blaikie82e95a32014-11-19 07:49:47 +00001911 if (!ClsMapSeen.insert(I->getSelector()).second)
Benjamin Kramer9f8e2d72013-10-14 15:16:10 +00001912 continue;
Aaron Ballmane8a7dc92014-03-13 20:11:06 +00001913 if (!ClsMap.count(I->getSelector())) {
Fariborz Jahanian07b71652009-05-01 20:07:12 +00001914 if (ImmediateClass)
Aaron Ballmane8a7dc92014-03-13 20:11:06 +00001915 WarnUndefinedMethod(*this, IMPDecl->getLocation(), I, IncompleteImpl,
Ted Kremenek65d63572013-03-27 00:02:21 +00001916 diag::warn_undef_method_impl);
Mike Stump12b8ce12009-08-04 21:02:39 +00001917 } else {
Argyrios Kyrtzidiscfbfe782009-06-30 02:36:12 +00001918 ObjCMethodDecl *ImpMethodDecl =
Aaron Ballmane8a7dc92014-03-13 20:11:06 +00001919 IMPDecl->getClassMethod(I->getSelector());
1920 assert(CDecl->getClassMethod(I->getSelector()) &&
Argyrios Kyrtzidis342e08f2011-08-30 19:43:21 +00001921 "Expected to find the method through lookup as well");
Fariborz Jahanian29082a52012-02-09 21:30:24 +00001922 if (!WarnCategoryMethodImpl)
Aaron Ballmane8a7dc92014-03-13 20:11:06 +00001923 WarnConflictingTypedMethods(ImpMethodDecl, I,
Fariborz Jahanian9f8b19e2011-07-28 23:19:50 +00001924 isa<ObjCProtocolDecl>(CDecl));
1925 else
Aaron Ballmane8a7dc92014-03-13 20:11:06 +00001926 WarnExactTypedMethods(ImpMethodDecl, I,
Fariborz Jahanian29082a52012-02-09 21:30:24 +00001927 isa<ObjCProtocolDecl>(CDecl));
Fariborz Jahanian07b71652009-05-01 20:07:12 +00001928 }
1929 }
Fariborz Jahanian73853e52010-10-08 22:59:25 +00001930
Fariborz Jahanian8181caa2013-08-14 23:58:55 +00001931 if (ObjCProtocolDecl *PD = dyn_cast<ObjCProtocolDecl> (CDecl)) {
1932 // Also, check for methods declared in protocols inherited by
1933 // this protocol.
Aaron Ballman0f6e64d2014-03-13 22:58:06 +00001934 for (auto *PI : PD->protocols())
Fariborz Jahanian8181caa2013-08-14 23:58:55 +00001935 MatchAllMethodDeclarations(InsMap, ClsMap, InsMapSeen, ClsMapSeen,
Aaron Ballman0f6e64d2014-03-13 22:58:06 +00001936 IMPDecl, PI, IncompleteImpl, false,
Fariborz Jahanian8181caa2013-08-14 23:58:55 +00001937 WarnCategoryMethodImpl);
1938 }
1939
Fariborz Jahanian07b71652009-05-01 20:07:12 +00001940 if (ObjCInterfaceDecl *I = dyn_cast<ObjCInterfaceDecl> (CDecl)) {
Fariborz Jahanian6f5309c2012-10-23 23:06:22 +00001941 // when checking that methods in implementation match their declaration,
1942 // i.e. when WarnCategoryMethodImpl is false, check declarations in class
1943 // extension; as well as those in categories.
Douglas Gregor048fbfa2013-01-16 23:00:23 +00001944 if (!WarnCategoryMethodImpl) {
Aaron Ballmanf53d8dd2014-03-13 21:47:07 +00001945 for (auto *Cat : I->visible_categories())
Fariborz Jahanian6f5309c2012-10-23 23:06:22 +00001946 MatchAllMethodDeclarations(InsMap, ClsMap, InsMapSeen, ClsMapSeen,
Aaron Ballman3fe486a2014-03-13 21:23:55 +00001947 IMPDecl, Cat, IncompleteImpl, false,
Fariborz Jahanian6f5309c2012-10-23 23:06:22 +00001948 WarnCategoryMethodImpl);
Douglas Gregor048fbfa2013-01-16 23:00:23 +00001949 } else {
Fariborz Jahanian6f5309c2012-10-23 23:06:22 +00001950 // Also methods in class extensions need be looked at next.
Aaron Ballmanf53d8dd2014-03-13 21:47:07 +00001951 for (auto *Ext : I->visible_extensions())
Fariborz Jahanian6f5309c2012-10-23 23:06:22 +00001952 MatchAllMethodDeclarations(InsMap, ClsMap, InsMapSeen, ClsMapSeen,
Aaron Ballmanf53d8dd2014-03-13 21:47:07 +00001953 IMPDecl, Ext, IncompleteImpl, false,
Fariborz Jahanian6f5309c2012-10-23 23:06:22 +00001954 WarnCategoryMethodImpl);
Douglas Gregor048fbfa2013-01-16 23:00:23 +00001955 }
1956
Fariborz Jahanian07b71652009-05-01 20:07:12 +00001957 // Check for any implementation of a methods declared in protocol.
Aaron Ballmana9f49e32014-03-13 20:55:22 +00001958 for (auto *PI : I->all_referenced_protocols())
Mike Stump11289f42009-09-09 15:08:12 +00001959 MatchAllMethodDeclarations(InsMap, ClsMap, InsMapSeen, ClsMapSeen,
Aaron Ballmana9f49e32014-03-13 20:55:22 +00001960 IMPDecl, PI, IncompleteImpl, false,
Fariborz Jahanian29082a52012-02-09 21:30:24 +00001961 WarnCategoryMethodImpl);
Aaron Ballmana9f49e32014-03-13 20:55:22 +00001962
Fariborz Jahanian9f8b19e2011-07-28 23:19:50 +00001963 // FIXME. For now, we are not checking for extact match of methods
1964 // in category implementation and its primary class's super class.
Fariborz Jahanian29082a52012-02-09 21:30:24 +00001965 if (!WarnCategoryMethodImpl && I->getSuperClass())
Fariborz Jahanian07b71652009-05-01 20:07:12 +00001966 MatchAllMethodDeclarations(InsMap, ClsMap, InsMapSeen, ClsMapSeen,
Mike Stump11289f42009-09-09 15:08:12 +00001967 IMPDecl,
Fariborz Jahanian07b71652009-05-01 20:07:12 +00001968 I->getSuperClass(), IncompleteImpl, false);
1969 }
1970}
1971
Fariborz Jahanian9f8b19e2011-07-28 23:19:50 +00001972/// CheckCategoryVsClassMethodMatches - Checks that methods implemented in
1973/// category matches with those implemented in its primary class and
1974/// warns each time an exact match is found.
1975void Sema::CheckCategoryVsClassMethodMatches(
1976 ObjCCategoryImplDecl *CatIMPDecl) {
Fariborz Jahanian9f8b19e2011-07-28 23:19:50 +00001977 // Get category's primary class.
1978 ObjCCategoryDecl *CatDecl = CatIMPDecl->getCategoryDecl();
1979 if (!CatDecl)
1980 return;
1981 ObjCInterfaceDecl *IDecl = CatDecl->getClassInterface();
1982 if (!IDecl)
1983 return;
Fariborz Jahanianf3077a22013-12-05 20:52:31 +00001984 ObjCInterfaceDecl *SuperIDecl = IDecl->getSuperClass();
1985 SelectorSet InsMap, ClsMap;
1986
Aaron Ballmanf26acce2014-03-13 19:50:17 +00001987 for (const auto *I : CatIMPDecl->instance_methods()) {
1988 Selector Sel = I->getSelector();
Fariborz Jahanianf3077a22013-12-05 20:52:31 +00001989 // When checking for methods implemented in the category, skip over
1990 // those declared in category class's super class. This is because
1991 // the super class must implement the method.
1992 if (SuperIDecl && SuperIDecl->lookupMethod(Sel, true))
1993 continue;
1994 InsMap.insert(Sel);
1995 }
1996
Aaron Ballmane8a7dc92014-03-13 20:11:06 +00001997 for (const auto *I : CatIMPDecl->class_methods()) {
1998 Selector Sel = I->getSelector();
Fariborz Jahanianf3077a22013-12-05 20:52:31 +00001999 if (SuperIDecl && SuperIDecl->lookupMethod(Sel, false))
2000 continue;
2001 ClsMap.insert(Sel);
2002 }
2003 if (InsMap.empty() && ClsMap.empty())
2004 return;
2005
Benjamin Kramerb33ffee2012-05-27 13:28:52 +00002006 SelectorSet InsMapSeen, ClsMapSeen;
Fariborz Jahanian9f8b19e2011-07-28 23:19:50 +00002007 bool IncompleteImpl = false;
2008 MatchAllMethodDeclarations(InsMap, ClsMap, InsMapSeen, ClsMapSeen,
2009 CatIMPDecl, IDecl,
Fariborz Jahanian29082a52012-02-09 21:30:24 +00002010 IncompleteImpl, false,
2011 true /*WarnCategoryMethodImpl*/);
Fariborz Jahanian9f8b19e2011-07-28 23:19:50 +00002012}
Fariborz Jahanian4ceec3f2011-07-24 20:53:26 +00002013
Fariborz Jahanian25491a22010-05-05 21:52:17 +00002014void Sema::ImplMethodsVsClassMethods(Scope *S, ObjCImplDecl* IMPDecl,
Mike Stump11289f42009-09-09 15:08:12 +00002015 ObjCContainerDecl* CDecl,
Chris Lattner9ef10f42009-03-01 00:56:52 +00002016 bool IncompleteImpl) {
Benjamin Kramerb33ffee2012-05-27 13:28:52 +00002017 SelectorSet InsMap;
Chris Lattnerda463fe2007-12-12 07:09:47 +00002018 // Check and see if instance methods in class interface have been
2019 // implemented in the implementation class.
Aaron Ballmanf26acce2014-03-13 19:50:17 +00002020 for (const auto *I : IMPDecl->instance_methods())
2021 InsMap.insert(I->getSelector());
Mike Stump11289f42009-09-09 15:08:12 +00002022
Fariborz Jahanian6c6aea92009-04-14 23:15:21 +00002023 // Check and see if properties declared in the interface have either 1)
2024 // an implementation or 2) there is a @synthesize/@dynamic implementation
2025 // of the property in the @implementation.
Ted Kremenek348e88c2014-02-21 19:41:34 +00002026 if (const ObjCInterfaceDecl *IDecl = dyn_cast<ObjCInterfaceDecl>(CDecl)) {
2027 bool SynthesizeProperties = LangOpts.ObjCDefaultSynthProperties &&
2028 LangOpts.ObjCRuntime.isNonFragile() &&
2029 !IDecl->isObjCRequiresPropertyDefs();
2030 DiagnoseUnimplementedProperties(S, IMPDecl, CDecl, SynthesizeProperties);
2031 }
2032
Douglas Gregor849ebc22015-06-19 18:14:46 +00002033 // Diagnose null-resettable synthesized setters.
2034 diagnoseNullResettableSynthesizedSetters(IMPDecl);
2035
Benjamin Kramerb33ffee2012-05-27 13:28:52 +00002036 SelectorSet ClsMap;
Aaron Ballmane8a7dc92014-03-13 20:11:06 +00002037 for (const auto *I : IMPDecl->class_methods())
2038 ClsMap.insert(I->getSelector());
Mike Stump11289f42009-09-09 15:08:12 +00002039
Fariborz Jahanian07b71652009-05-01 20:07:12 +00002040 // Check for type conflict of methods declared in a class/protocol and
2041 // its implementation; if any.
Benjamin Kramerb33ffee2012-05-27 13:28:52 +00002042 SelectorSet InsMapSeen, ClsMapSeen;
Mike Stump11289f42009-09-09 15:08:12 +00002043 MatchAllMethodDeclarations(InsMap, ClsMap, InsMapSeen, ClsMapSeen,
2044 IMPDecl, CDecl,
Fariborz Jahanian07b71652009-05-01 20:07:12 +00002045 IncompleteImpl, true);
Fariborz Jahanian2bda1b62011-08-03 18:21:12 +00002046
Fariborz Jahanian9f8b19e2011-07-28 23:19:50 +00002047 // check all methods implemented in category against those declared
2048 // in its primary class.
2049 if (ObjCCategoryImplDecl *CatDecl =
2050 dyn_cast<ObjCCategoryImplDecl>(IMPDecl))
2051 CheckCategoryVsClassMethodMatches(CatDecl);
Mike Stump11289f42009-09-09 15:08:12 +00002052
Chris Lattnerda463fe2007-12-12 07:09:47 +00002053 // Check the protocol list for unimplemented methods in the @implementation
2054 // class.
Fariborz Jahanian07b71652009-05-01 20:07:12 +00002055 // Check and see if class methods in class interface have been
2056 // implemented in the implementation class.
Mike Stump11289f42009-09-09 15:08:12 +00002057
Ted Kremenek4b3c66e2014-03-05 08:13:08 +00002058 LazyProtocolNameSet ExplicitImplProtocols;
2059
Chris Lattner9ef10f42009-03-01 00:56:52 +00002060 if (ObjCInterfaceDecl *I = dyn_cast<ObjCInterfaceDecl> (CDecl)) {
Aaron Ballmana9f49e32014-03-13 20:55:22 +00002061 for (auto *PI : I->all_referenced_protocols())
2062 CheckProtocolMethodDefs(*this, IMPDecl->getLocation(), PI, IncompleteImpl,
2063 InsMap, ClsMap, I, ExplicitImplProtocols);
Chris Lattner9ef10f42009-03-01 00:56:52 +00002064 // Check class extensions (unnamed categories)
Aaron Ballmanf53d8dd2014-03-13 21:47:07 +00002065 for (auto *Ext : I->visible_extensions())
2066 ImplMethodsVsClassMethods(S, IMPDecl, Ext, IncompleteImpl);
Chris Lattner9ef10f42009-03-01 00:56:52 +00002067 } else if (ObjCCategoryDecl *C = dyn_cast<ObjCCategoryDecl>(CDecl)) {
Fariborz Jahanian8764c742009-10-05 21:32:49 +00002068 // For extended class, unimplemented methods in its protocols will
2069 // be reported in the primary class.
Fariborz Jahanian30a42922010-02-15 21:55:26 +00002070 if (!C->IsClassExtension()) {
Aaron Ballman19a41762014-03-14 12:55:57 +00002071 for (auto *P : C->protocols())
2072 CheckProtocolMethodDefs(*this, IMPDecl->getLocation(), P,
Ted Kremenek4b3c66e2014-03-05 08:13:08 +00002073 IncompleteImpl, InsMap, ClsMap, CDecl,
2074 ExplicitImplProtocols);
Ted Kremenek348e88c2014-02-21 19:41:34 +00002075 DiagnoseUnimplementedProperties(S, IMPDecl, CDecl,
Nico Weber2e0c8f72014-12-27 03:58:08 +00002076 /*SynthesizeProperties=*/false);
Fariborz Jahanian4f8a5712010-01-20 19:36:21 +00002077 }
Chris Lattner9ef10f42009-03-01 00:56:52 +00002078 } else
David Blaikie83d382b2011-09-23 05:06:16 +00002079 llvm_unreachable("invalid ObjCContainerDecl type.");
Chris Lattnerda463fe2007-12-12 07:09:47 +00002080}
2081
Fariborz Jahanian3a039e32011-08-27 20:50:59 +00002082Sema::DeclGroupPtrTy
Chris Lattnerda463fe2007-12-12 07:09:47 +00002083Sema::ActOnForwardClassDeclaration(SourceLocation AtClassLoc,
Chris Lattner99a83312009-02-16 19:25:52 +00002084 IdentifierInfo **IdentList,
Ted Kremeneka26da852009-11-17 23:12:20 +00002085 SourceLocation *IdentLocs,
Chris Lattner99a83312009-02-16 19:25:52 +00002086 unsigned NumElts) {
Fariborz Jahanian3a039e32011-08-27 20:50:59 +00002087 SmallVector<Decl *, 8> DeclsInGroup;
Chris Lattnerda463fe2007-12-12 07:09:47 +00002088 for (unsigned i = 0; i != NumElts; ++i) {
2089 // Check for another declaration kind with the same name.
John McCall9f3059a2009-10-09 21:13:30 +00002090 NamedDecl *PrevDecl
Douglas Gregorb2ccf012010-04-15 22:33:43 +00002091 = LookupSingleName(TUScope, IdentList[i], IdentLocs[i],
Douglas Gregorb8eaf292010-04-15 23:40:53 +00002092 LookupOrdinaryName, ForRedeclaration);
Ted Kremenek1b0ea822008-01-07 19:49:32 +00002093 if (PrevDecl && !isa<ObjCInterfaceDecl>(PrevDecl)) {
Steve Naroff946166f2008-06-05 22:57:10 +00002094 // GCC apparently allows the following idiom:
2095 //
2096 // typedef NSObject < XCElementTogglerP > XCElementToggler;
2097 // @class XCElementToggler;
2098 //
Fariborz Jahanian04c44552012-01-24 00:40:15 +00002099 // Here we have chosen to ignore the forward class declaration
2100 // with a warning. Since this is the implied behavior.
Richard Smithdda56e42011-04-15 14:24:37 +00002101 TypedefNameDecl *TDD = dyn_cast<TypedefNameDecl>(PrevDecl);
John McCall8b07ec22010-05-15 11:32:37 +00002102 if (!TDD || !TDD->getUnderlyingType()->isObjCObjectType()) {
Chris Lattner4bd8dd82008-11-19 08:23:25 +00002103 Diag(AtClassLoc, diag::err_redefinition_different_kind) << IdentList[i];
Chris Lattner0369c572008-11-23 23:12:31 +00002104 Diag(PrevDecl->getLocation(), diag::note_previous_definition);
John McCall8b07ec22010-05-15 11:32:37 +00002105 } else {
Mike Stump12b8ce12009-08-04 21:02:39 +00002106 // a forward class declaration matching a typedef name of a class refers
Fariborz Jahanian04c44552012-01-24 00:40:15 +00002107 // to the underlying class. Just ignore the forward class with a warning
Nico Weber2e0c8f72014-12-27 03:58:08 +00002108 // as this will force the intended behavior which is to lookup the
2109 // typedef name.
Fariborz Jahanian04c44552012-01-24 00:40:15 +00002110 if (isa<ObjCObjectType>(TDD->getUnderlyingType())) {
Nico Weber2e0c8f72014-12-27 03:58:08 +00002111 Diag(AtClassLoc, diag::warn_forward_class_redefinition)
2112 << IdentList[i];
Fariborz Jahanian04c44552012-01-24 00:40:15 +00002113 Diag(PrevDecl->getLocation(), diag::note_previous_definition);
2114 continue;
2115 }
Fariborz Jahanian0d451812009-05-07 21:49:26 +00002116 }
Chris Lattnerda463fe2007-12-12 07:09:47 +00002117 }
Douglas Gregordc9166c2011-12-15 20:29:51 +00002118
2119 // Create a declaration to describe this forward declaration.
Douglas Gregorab1ec82e2011-12-16 03:12:41 +00002120 ObjCInterfaceDecl *PrevIDecl
2121 = dyn_cast_or_null<ObjCInterfaceDecl>(PrevDecl);
Argyrios Kyrtzidisdd710632013-06-18 21:26:33 +00002122
2123 IdentifierInfo *ClassName = IdentList[i];
2124 if (PrevIDecl && PrevIDecl->getIdentifier() != ClassName) {
2125 // A previous decl with a different name is because of
2126 // @compatibility_alias, for example:
2127 // \code
2128 // @class NewImage;
2129 // @compatibility_alias OldImage NewImage;
2130 // \endcode
2131 // A lookup for 'OldImage' will return the 'NewImage' decl.
2132 //
2133 // In such a case use the real declaration name, instead of the alias one,
2134 // otherwise we will break IdentifierResolver and redecls-chain invariants.
2135 // FIXME: If necessary, add a bit to indicate that this ObjCInterfaceDecl
2136 // has been aliased.
2137 ClassName = PrevIDecl->getIdentifier();
2138 }
2139
Douglas Gregordc9166c2011-12-15 20:29:51 +00002140 ObjCInterfaceDecl *IDecl
2141 = ObjCInterfaceDecl::Create(Context, CurContext, AtClassLoc,
Argyrios Kyrtzidisdd710632013-06-18 21:26:33 +00002142 ClassName, PrevIDecl, IdentLocs[i]);
Douglas Gregordc9166c2011-12-15 20:29:51 +00002143 IDecl->setAtEndRange(IdentLocs[i]);
Douglas Gregordc9166c2011-12-15 20:29:51 +00002144
Douglas Gregordc9166c2011-12-15 20:29:51 +00002145 PushOnScopeChains(IDecl, TUScope);
Douglas Gregordeafd0b2011-12-27 22:43:10 +00002146 CheckObjCDeclScope(IDecl);
2147 DeclsInGroup.push_back(IDecl);
Chris Lattnerda463fe2007-12-12 07:09:47 +00002148 }
Rafael Espindolaab417692013-07-09 12:05:01 +00002149
2150 return BuildDeclaratorGroup(DeclsInGroup, false);
Chris Lattnerda463fe2007-12-12 07:09:47 +00002151}
2152
John McCall54507ab2011-06-16 01:15:19 +00002153static bool tryMatchRecordTypes(ASTContext &Context,
2154 Sema::MethodMatchStrategy strategy,
2155 const Type *left, const Type *right);
2156
John McCall31168b02011-06-15 23:02:42 +00002157static bool matchTypes(ASTContext &Context, Sema::MethodMatchStrategy strategy,
2158 QualType leftQT, QualType rightQT) {
2159 const Type *left =
2160 Context.getCanonicalType(leftQT).getUnqualifiedType().getTypePtr();
2161 const Type *right =
2162 Context.getCanonicalType(rightQT).getUnqualifiedType().getTypePtr();
2163
2164 if (left == right) return true;
2165
2166 // If we're doing a strict match, the types have to match exactly.
2167 if (strategy == Sema::MMS_strict) return false;
2168
2169 if (left->isIncompleteType() || right->isIncompleteType()) return false;
2170
2171 // Otherwise, use this absurdly complicated algorithm to try to
2172 // validate the basic, low-level compatibility of the two types.
2173
2174 // As a minimum, require the sizes and alignments to match.
David Majnemer34b57492014-07-30 01:30:47 +00002175 TypeInfo LeftTI = Context.getTypeInfo(left);
2176 TypeInfo RightTI = Context.getTypeInfo(right);
2177 if (LeftTI.Width != RightTI.Width)
2178 return false;
2179
2180 if (LeftTI.Align != RightTI.Align)
John McCall31168b02011-06-15 23:02:42 +00002181 return false;
2182
2183 // Consider all the kinds of non-dependent canonical types:
2184 // - functions and arrays aren't possible as return and parameter types
2185
2186 // - vector types of equal size can be arbitrarily mixed
2187 if (isa<VectorType>(left)) return isa<VectorType>(right);
2188 if (isa<VectorType>(right)) return false;
2189
2190 // - references should only match references of identical type
John McCall54507ab2011-06-16 01:15:19 +00002191 // - structs, unions, and Objective-C objects must match more-or-less
2192 // exactly
John McCall31168b02011-06-15 23:02:42 +00002193 // - everything else should be a scalar
2194 if (!left->isScalarType() || !right->isScalarType())
John McCall54507ab2011-06-16 01:15:19 +00002195 return tryMatchRecordTypes(Context, strategy, left, right);
John McCall31168b02011-06-15 23:02:42 +00002196
John McCall9320b872011-09-09 05:25:32 +00002197 // Make scalars agree in kind, except count bools as chars, and group
2198 // all non-member pointers together.
John McCall31168b02011-06-15 23:02:42 +00002199 Type::ScalarTypeKind leftSK = left->getScalarTypeKind();
2200 Type::ScalarTypeKind rightSK = right->getScalarTypeKind();
2201 if (leftSK == Type::STK_Bool) leftSK = Type::STK_Integral;
2202 if (rightSK == Type::STK_Bool) rightSK = Type::STK_Integral;
John McCall9320b872011-09-09 05:25:32 +00002203 if (leftSK == Type::STK_CPointer || leftSK == Type::STK_BlockPointer)
2204 leftSK = Type::STK_ObjCObjectPointer;
2205 if (rightSK == Type::STK_CPointer || rightSK == Type::STK_BlockPointer)
2206 rightSK = Type::STK_ObjCObjectPointer;
John McCall31168b02011-06-15 23:02:42 +00002207
2208 // Note that data member pointers and function member pointers don't
2209 // intermix because of the size differences.
2210
2211 return (leftSK == rightSK);
2212}
Chris Lattnerda463fe2007-12-12 07:09:47 +00002213
John McCall54507ab2011-06-16 01:15:19 +00002214static bool tryMatchRecordTypes(ASTContext &Context,
2215 Sema::MethodMatchStrategy strategy,
2216 const Type *lt, const Type *rt) {
2217 assert(lt && rt && lt != rt);
2218
2219 if (!isa<RecordType>(lt) || !isa<RecordType>(rt)) return false;
2220 RecordDecl *left = cast<RecordType>(lt)->getDecl();
2221 RecordDecl *right = cast<RecordType>(rt)->getDecl();
2222
2223 // Require union-hood to match.
2224 if (left->isUnion() != right->isUnion()) return false;
2225
2226 // Require an exact match if either is non-POD.
2227 if ((isa<CXXRecordDecl>(left) && !cast<CXXRecordDecl>(left)->isPOD()) ||
2228 (isa<CXXRecordDecl>(right) && !cast<CXXRecordDecl>(right)->isPOD()))
2229 return false;
2230
2231 // Require size and alignment to match.
David Majnemer34b57492014-07-30 01:30:47 +00002232 TypeInfo LeftTI = Context.getTypeInfo(lt);
2233 TypeInfo RightTI = Context.getTypeInfo(rt);
2234 if (LeftTI.Width != RightTI.Width)
2235 return false;
2236
2237 if (LeftTI.Align != RightTI.Align)
2238 return false;
John McCall54507ab2011-06-16 01:15:19 +00002239
2240 // Require fields to match.
2241 RecordDecl::field_iterator li = left->field_begin(), le = left->field_end();
2242 RecordDecl::field_iterator ri = right->field_begin(), re = right->field_end();
2243 for (; li != le && ri != re; ++li, ++ri) {
2244 if (!matchTypes(Context, strategy, li->getType(), ri->getType()))
2245 return false;
2246 }
2247 return (li == le && ri == re);
2248}
2249
Chris Lattnerda463fe2007-12-12 07:09:47 +00002250/// MatchTwoMethodDeclarations - Checks that two methods have matching type and
2251/// returns true, or false, accordingly.
2252/// TODO: Handle protocol list; such as id<p1,p2> in type comparisons
John McCall31168b02011-06-15 23:02:42 +00002253bool Sema::MatchTwoMethodDeclarations(const ObjCMethodDecl *left,
2254 const ObjCMethodDecl *right,
2255 MethodMatchStrategy strategy) {
Alp Toker314cc812014-01-25 16:55:45 +00002256 if (!matchTypes(Context, strategy, left->getReturnType(),
2257 right->getReturnType()))
John McCall31168b02011-06-15 23:02:42 +00002258 return false;
Mike Stump11289f42009-09-09 15:08:12 +00002259
Douglas Gregor560b7fa2013-02-07 19:13:24 +00002260 // If either is hidden, it is not considered to match.
2261 if (left->isHidden() || right->isHidden())
2262 return false;
2263
David Blaikiebbafb8a2012-03-11 07:00:24 +00002264 if (getLangOpts().ObjCAutoRefCount &&
John McCall31168b02011-06-15 23:02:42 +00002265 (left->hasAttr<NSReturnsRetainedAttr>()
2266 != right->hasAttr<NSReturnsRetainedAttr>() ||
2267 left->hasAttr<NSConsumesSelfAttr>()
2268 != right->hasAttr<NSConsumesSelfAttr>()))
2269 return false;
Mike Stump11289f42009-09-09 15:08:12 +00002270
Argyrios Kyrtzidisb8c3aaf2011-10-03 06:37:04 +00002271 ObjCMethodDecl::param_const_iterator
Douglas Gregor0bf70f42012-05-17 23:13:29 +00002272 li = left->param_begin(), le = left->param_end(), ri = right->param_begin(),
2273 re = right->param_end();
Mike Stump11289f42009-09-09 15:08:12 +00002274
Douglas Gregor0bf70f42012-05-17 23:13:29 +00002275 for (; li != le && ri != re; ++li, ++ri) {
John McCall31168b02011-06-15 23:02:42 +00002276 assert(ri != right->param_end() && "Param mismatch");
Argyrios Kyrtzidisb8c3aaf2011-10-03 06:37:04 +00002277 const ParmVarDecl *lparm = *li, *rparm = *ri;
John McCall31168b02011-06-15 23:02:42 +00002278
2279 if (!matchTypes(Context, strategy, lparm->getType(), rparm->getType()))
2280 return false;
2281
David Blaikiebbafb8a2012-03-11 07:00:24 +00002282 if (getLangOpts().ObjCAutoRefCount &&
John McCall31168b02011-06-15 23:02:42 +00002283 lparm->hasAttr<NSConsumedAttr>() != rparm->hasAttr<NSConsumedAttr>())
2284 return false;
Chris Lattnerda463fe2007-12-12 07:09:47 +00002285 }
2286 return true;
2287}
2288
Nico Weber2e0c8f72014-12-27 03:58:08 +00002289void Sema::addMethodToGlobalList(ObjCMethodList *List,
2290 ObjCMethodDecl *Method) {
Argyrios Kyrtzidisd3da6e02013-04-17 00:08:58 +00002291 // Record at the head of the list whether there were 0, 1, or >= 2 methods
2292 // inside categories.
Nico Weber2e0c8f72014-12-27 03:58:08 +00002293 if (ObjCCategoryDecl *CD =
2294 dyn_cast<ObjCCategoryDecl>(Method->getDeclContext()))
Argyrios Kyrtzidis04703a62013-04-27 00:10:12 +00002295 if (!CD->IsClassExtension() && List->getBits() < 2)
Nico Weber2e0c8f72014-12-27 03:58:08 +00002296 List->setBits(List->getBits() + 1);
Argyrios Kyrtzidisd3da6e02013-04-17 00:08:58 +00002297
Douglas Gregorc454afe2012-01-25 00:19:56 +00002298 // If the list is empty, make it a singleton list.
Nico Weber2e0c8f72014-12-27 03:58:08 +00002299 if (List->getMethod() == nullptr) {
2300 List->setMethod(Method);
Craig Topperc3ec1492014-05-26 06:22:03 +00002301 List->setNext(nullptr);
Douglas Gregor0e6fc1a2012-05-01 23:37:00 +00002302 return;
Douglas Gregorc454afe2012-01-25 00:19:56 +00002303 }
Nico Weber2e0c8f72014-12-27 03:58:08 +00002304
Douglas Gregorc454afe2012-01-25 00:19:56 +00002305 // We've seen a method with this name, see if we have already seen this type
2306 // signature.
2307 ObjCMethodList *Previous = List;
Argyrios Kyrtzidisd3da6e02013-04-17 00:08:58 +00002308 for (; List; Previous = List, List = List->getNext()) {
Douglas Gregor600a2f52013-06-21 00:20:25 +00002309 // If we are building a module, keep all of the methods.
2310 if (getLangOpts().Modules && !getLangOpts().CurrentModule.empty())
2311 continue;
2312
Fariborz Jahaniand436b2a2015-04-07 16:56:27 +00002313 if (!MatchTwoMethodDeclarations(Method, List->getMethod())) {
2314 // Even if two method types do not match, we would like to say
2315 // there is more than one declaration so unavailability/deprecated
2316 // warning is not too noisy.
2317 if (!Method->isDefined())
2318 List->setHasMoreThanOneDecl(true);
Douglas Gregorc454afe2012-01-25 00:19:56 +00002319 continue;
Fariborz Jahaniand436b2a2015-04-07 16:56:27 +00002320 }
Nico Weber2e0c8f72014-12-27 03:58:08 +00002321
2322 ObjCMethodDecl *PrevObjCMethod = List->getMethod();
Douglas Gregorc454afe2012-01-25 00:19:56 +00002323
2324 // Propagate the 'defined' bit.
2325 if (Method->isDefined())
2326 PrevObjCMethod->setDefined(true);
Nico Webere3b11042014-12-27 07:09:37 +00002327 else {
Nico Weber2e0c8f72014-12-27 03:58:08 +00002328 // Objective-C doesn't allow an @interface for a class after its
2329 // @implementation. So if Method is not defined and there already is
2330 // an entry for this type signature, Method has to be for a different
2331 // class than PrevObjCMethod.
2332 List->setHasMoreThanOneDecl(true);
2333 }
2334
Douglas Gregorc454afe2012-01-25 00:19:56 +00002335 // If a method is deprecated, push it in the global pool.
2336 // This is used for better diagnostics.
2337 if (Method->isDeprecated()) {
2338 if (!PrevObjCMethod->isDeprecated())
Nico Weber2e0c8f72014-12-27 03:58:08 +00002339 List->setMethod(Method);
Douglas Gregorc454afe2012-01-25 00:19:56 +00002340 }
Nico Weber2e0c8f72014-12-27 03:58:08 +00002341 // If the new method is unavailable, push it into global pool
Douglas Gregorc454afe2012-01-25 00:19:56 +00002342 // unless previous one is deprecated.
2343 if (Method->isUnavailable()) {
2344 if (PrevObjCMethod->getAvailability() < AR_Deprecated)
Nico Weber2e0c8f72014-12-27 03:58:08 +00002345 List->setMethod(Method);
Douglas Gregorc454afe2012-01-25 00:19:56 +00002346 }
Nico Weber2e0c8f72014-12-27 03:58:08 +00002347
Douglas Gregor0e6fc1a2012-05-01 23:37:00 +00002348 return;
Douglas Gregorc454afe2012-01-25 00:19:56 +00002349 }
Nico Weber2e0c8f72014-12-27 03:58:08 +00002350
Douglas Gregorc454afe2012-01-25 00:19:56 +00002351 // We have a new signature for an existing method - add it.
2352 // This is extremely rare. Only 1% of Cocoa selectors are "overloaded".
Douglas Gregore1716012012-01-25 00:49:42 +00002353 ObjCMethodList *Mem = BumpAlloc.Allocate<ObjCMethodList>();
Nico Weber2e0c8f72014-12-27 03:58:08 +00002354 Previous->setNext(new (Mem) ObjCMethodList(Method));
Douglas Gregorc454afe2012-01-25 00:19:56 +00002355}
2356
Sebastian Redl75d8a322010-08-02 23:18:59 +00002357/// \brief Read the contents of the method pool for a given selector from
2358/// external storage.
Douglas Gregore1716012012-01-25 00:49:42 +00002359void Sema::ReadMethodPool(Selector Sel) {
Douglas Gregorc78d3462009-04-24 21:10:55 +00002360 assert(ExternalSource && "We need an external AST source");
Douglas Gregore1716012012-01-25 00:49:42 +00002361 ExternalSource->ReadMethodPool(Sel);
Douglas Gregorc78d3462009-04-24 21:10:55 +00002362}
2363
Douglas Gregor0e6fc1a2012-05-01 23:37:00 +00002364void Sema::AddMethodToGlobalPool(ObjCMethodDecl *Method, bool impl,
Sebastian Redl75d8a322010-08-02 23:18:59 +00002365 bool instance) {
Argyrios Kyrtzidisb15def22012-03-12 18:34:26 +00002366 // Ignore methods of invalid containers.
2367 if (cast<Decl>(Method->getDeclContext())->isInvalidDecl())
Douglas Gregor0e6fc1a2012-05-01 23:37:00 +00002368 return;
Argyrios Kyrtzidisb15def22012-03-12 18:34:26 +00002369
Douglas Gregor70f449b2012-01-25 00:59:09 +00002370 if (ExternalSource)
2371 ReadMethodPool(Method->getSelector());
2372
Sebastian Redl75d8a322010-08-02 23:18:59 +00002373 GlobalMethodPool::iterator Pos = MethodPool.find(Method->getSelector());
Douglas Gregor70f449b2012-01-25 00:59:09 +00002374 if (Pos == MethodPool.end())
2375 Pos = MethodPool.insert(std::make_pair(Method->getSelector(),
2376 GlobalMethods())).first;
Nico Weber2e0c8f72014-12-27 03:58:08 +00002377
Fariborz Jahanian6e7e8cc2010-07-22 18:24:20 +00002378 Method->setDefined(impl);
Douglas Gregorc454afe2012-01-25 00:19:56 +00002379
Sebastian Redl75d8a322010-08-02 23:18:59 +00002380 ObjCMethodList &Entry = instance ? Pos->second.first : Pos->second.second;
Douglas Gregor0e6fc1a2012-05-01 23:37:00 +00002381 addMethodToGlobalList(&Entry, Method);
Chris Lattnerda463fe2007-12-12 07:09:47 +00002382}
2383
John McCall31168b02011-06-15 23:02:42 +00002384/// Determines if this is an "acceptable" loose mismatch in the global
2385/// method pool. This exists mostly as a hack to get around certain
2386/// global mismatches which we can't afford to make warnings / errors.
2387/// Really, what we want is a way to take a method out of the global
2388/// method pool.
2389static bool isAcceptableMethodMismatch(ObjCMethodDecl *chosen,
2390 ObjCMethodDecl *other) {
2391 if (!chosen->isInstanceMethod())
2392 return false;
2393
2394 Selector sel = chosen->getSelector();
2395 if (!sel.isUnarySelector() || sel.getNameForSlot(0) != "length")
2396 return false;
2397
2398 // Don't complain about mismatches for -length if the method we
2399 // chose has an integral result type.
Alp Toker314cc812014-01-25 16:55:45 +00002400 return (chosen->getReturnType()->isIntegerType());
John McCall31168b02011-06-15 23:02:42 +00002401}
2402
Nico Weber2e0c8f72014-12-27 03:58:08 +00002403bool Sema::CollectMultipleMethodsInGlobalPool(
2404 Selector Sel, SmallVectorImpl<ObjCMethodDecl *> &Methods, bool instance) {
Fariborz Jahanian30ae8d42014-08-13 21:07:35 +00002405 if (ExternalSource)
2406 ReadMethodPool(Sel);
2407
2408 GlobalMethodPool::iterator Pos = MethodPool.find(Sel);
2409 if (Pos == MethodPool.end())
2410 return false;
2411 // Gather the non-hidden methods.
2412 ObjCMethodList &MethList = instance ? Pos->second.first : Pos->second.second;
2413 for (ObjCMethodList *M = &MethList; M; M = M->getNext())
Nico Weber2e0c8f72014-12-27 03:58:08 +00002414 if (M->getMethod() && !M->getMethod()->isHidden())
2415 Methods.push_back(M->getMethod());
2416 return Methods.size() > 1;
Fariborz Jahanian30ae8d42014-08-13 21:07:35 +00002417}
2418
Fariborz Jahanian890803f2015-04-15 17:26:21 +00002419bool Sema::AreMultipleMethodsInGlobalPool(Selector Sel, ObjCMethodDecl *BestMethod,
2420 SourceRange R,
2421 bool receiverIdOrClass) {
Fariborz Jahanianc62d16f2014-11-13 22:27:05 +00002422 GlobalMethodPool::iterator Pos = MethodPool.find(Sel);
Nico Weber2e0c8f72014-12-27 03:58:08 +00002423 // Test for no method in the pool which should not trigger any warning by
2424 // caller.
Fariborz Jahanianc62d16f2014-11-13 22:27:05 +00002425 if (Pos == MethodPool.end())
2426 return true;
Fariborz Jahanian890803f2015-04-15 17:26:21 +00002427 ObjCMethodList &MethList =
2428 BestMethod->isInstanceMethod() ? Pos->second.first : Pos->second.second;
2429
2430 // Diagnose finding more than one method in global pool
2431 SmallVector<ObjCMethodDecl *, 4> Methods;
2432 Methods.push_back(BestMethod);
Jonathan Roelofs74411362015-04-28 18:04:44 +00002433 for (ObjCMethodList *ML = &MethList; ML; ML = ML->getNext())
2434 if (ObjCMethodDecl *M = ML->getMethod())
2435 if (!M->isHidden() && M != BestMethod && !M->hasAttr<UnavailableAttr>())
2436 Methods.push_back(M);
Fariborz Jahanian890803f2015-04-15 17:26:21 +00002437 if (Methods.size() > 1)
2438 DiagnoseMultipleMethodInGlobalPool(Methods, Sel, R, receiverIdOrClass);
2439
Nico Weber2e0c8f72014-12-27 03:58:08 +00002440 return MethList.hasMoreThanOneDecl();
Fariborz Jahanianc62d16f2014-11-13 22:27:05 +00002441}
2442
Sebastian Redl75d8a322010-08-02 23:18:59 +00002443ObjCMethodDecl *Sema::LookupMethodInGlobalPool(Selector Sel, SourceRange R,
Fariborz Jahanian3337b2e2010-08-09 23:27:58 +00002444 bool receiverIdOrClass,
Fariborz Jahanian890803f2015-04-15 17:26:21 +00002445 bool instance) {
Douglas Gregor70f449b2012-01-25 00:59:09 +00002446 if (ExternalSource)
2447 ReadMethodPool(Sel);
2448
Sebastian Redl75d8a322010-08-02 23:18:59 +00002449 GlobalMethodPool::iterator Pos = MethodPool.find(Sel);
Douglas Gregor70f449b2012-01-25 00:59:09 +00002450 if (Pos == MethodPool.end())
Craig Topperc3ec1492014-05-26 06:22:03 +00002451 return nullptr;
Douglas Gregorc78d3462009-04-24 21:10:55 +00002452
Douglas Gregor77f49a42013-01-16 18:47:38 +00002453 // Gather the non-hidden methods.
Sebastian Redl75d8a322010-08-02 23:18:59 +00002454 ObjCMethodList &MethList = instance ? Pos->second.first : Pos->second.second;
Robert Wilhelmb869a8f2013-08-10 12:33:24 +00002455 SmallVector<ObjCMethodDecl *, 4> Methods;
Argyrios Kyrtzidisd3da6e02013-04-17 00:08:58 +00002456 for (ObjCMethodList *M = &MethList; M; M = M->getNext()) {
Fariborz Jahanian890803f2015-04-15 17:26:21 +00002457 if (M->getMethod() && !M->getMethod()->isHidden())
2458 return M->getMethod();
Douglas Gregorc78d3462009-04-24 21:10:55 +00002459 }
Fariborz Jahanian890803f2015-04-15 17:26:21 +00002460 return nullptr;
2461}
Douglas Gregor77f49a42013-01-16 18:47:38 +00002462
Fariborz Jahanian890803f2015-04-15 17:26:21 +00002463void Sema::DiagnoseMultipleMethodInGlobalPool(SmallVectorImpl<ObjCMethodDecl*> &Methods,
2464 Selector Sel, SourceRange R,
2465 bool receiverIdOrClass) {
Douglas Gregor77f49a42013-01-16 18:47:38 +00002466 // We found multiple methods, so we may have to complain.
2467 bool issueDiagnostic = false, issueError = false;
Jonathan Roelofs74411362015-04-28 18:04:44 +00002468
Douglas Gregor77f49a42013-01-16 18:47:38 +00002469 // We support a warning which complains about *any* difference in
2470 // method signature.
2471 bool strictSelectorMatch =
Fariborz Jahanian890803f2015-04-15 17:26:21 +00002472 receiverIdOrClass &&
2473 !Diags.isIgnored(diag::warn_strict_multiple_method_decl, R.getBegin());
Douglas Gregor77f49a42013-01-16 18:47:38 +00002474 if (strictSelectorMatch) {
2475 for (unsigned I = 1, N = Methods.size(); I != N; ++I) {
2476 if (!MatchTwoMethodDeclarations(Methods[0], Methods[I], MMS_strict)) {
2477 issueDiagnostic = true;
2478 break;
2479 }
2480 }
2481 }
Jonathan Roelofs74411362015-04-28 18:04:44 +00002482
Douglas Gregor77f49a42013-01-16 18:47:38 +00002483 // If we didn't see any strict differences, we won't see any loose
2484 // differences. In ARC, however, we also need to check for loose
2485 // mismatches, because most of them are errors.
2486 if (!strictSelectorMatch ||
2487 (issueDiagnostic && getLangOpts().ObjCAutoRefCount))
2488 for (unsigned I = 1, N = Methods.size(); I != N; ++I) {
2489 // This checks if the methods differ in type mismatch.
2490 if (!MatchTwoMethodDeclarations(Methods[0], Methods[I], MMS_loose) &&
2491 !isAcceptableMethodMismatch(Methods[0], Methods[I])) {
2492 issueDiagnostic = true;
2493 if (getLangOpts().ObjCAutoRefCount)
2494 issueError = true;
2495 break;
2496 }
2497 }
Fariborz Jahanian890803f2015-04-15 17:26:21 +00002498
Douglas Gregor77f49a42013-01-16 18:47:38 +00002499 if (issueDiagnostic) {
2500 if (issueError)
2501 Diag(R.getBegin(), diag::err_arc_multiple_method_decl) << Sel << R;
2502 else if (strictSelectorMatch)
2503 Diag(R.getBegin(), diag::warn_strict_multiple_method_decl) << Sel << R;
2504 else
2505 Diag(R.getBegin(), diag::warn_multiple_method_decl) << Sel << R;
Fariborz Jahanian890803f2015-04-15 17:26:21 +00002506
Douglas Gregor77f49a42013-01-16 18:47:38 +00002507 Diag(Methods[0]->getLocStart(),
2508 issueError ? diag::note_possibility : diag::note_using)
Fariborz Jahanian890803f2015-04-15 17:26:21 +00002509 << Methods[0]->getSourceRange();
Douglas Gregor77f49a42013-01-16 18:47:38 +00002510 for (unsigned I = 1, N = Methods.size(); I != N; ++I) {
2511 Diag(Methods[I]->getLocStart(), diag::note_also_found)
Fariborz Jahanian890803f2015-04-15 17:26:21 +00002512 << Methods[I]->getSourceRange();
2513 }
Douglas Gregor77f49a42013-01-16 18:47:38 +00002514 }
Douglas Gregorc78d3462009-04-24 21:10:55 +00002515}
2516
Fariborz Jahanian6e7e8cc2010-07-22 18:24:20 +00002517ObjCMethodDecl *Sema::LookupImplementedMethodInGlobalPool(Selector Sel) {
Sebastian Redl75d8a322010-08-02 23:18:59 +00002518 GlobalMethodPool::iterator Pos = MethodPool.find(Sel);
2519 if (Pos == MethodPool.end())
Craig Topperc3ec1492014-05-26 06:22:03 +00002520 return nullptr;
Sebastian Redl75d8a322010-08-02 23:18:59 +00002521
2522 GlobalMethods &Methods = Pos->second;
Fariborz Jahanianec762bd2014-03-26 20:59:26 +00002523 for (const ObjCMethodList *Method = &Methods.first; Method;
2524 Method = Method->getNext())
Fariborz Jahanian4019c7f2015-02-19 21:52:41 +00002525 if (Method->getMethod() &&
2526 (Method->getMethod()->isDefined() ||
2527 Method->getMethod()->isPropertyAccessor()))
Nico Weber2e0c8f72014-12-27 03:58:08 +00002528 return Method->getMethod();
Fariborz Jahanianec762bd2014-03-26 20:59:26 +00002529
2530 for (const ObjCMethodList *Method = &Methods.second; Method;
2531 Method = Method->getNext())
Fariborz Jahanian4019c7f2015-02-19 21:52:41 +00002532 if (Method->getMethod() &&
2533 (Method->getMethod()->isDefined() ||
2534 Method->getMethod()->isPropertyAccessor()))
Nico Weber2e0c8f72014-12-27 03:58:08 +00002535 return Method->getMethod();
Craig Topperc3ec1492014-05-26 06:22:03 +00002536 return nullptr;
Fariborz Jahanian6e7e8cc2010-07-22 18:24:20 +00002537}
2538
Fariborz Jahanian42f89382013-05-30 21:48:58 +00002539static void
Fariborz Jahanian0c0fc9e2013-06-05 18:46:14 +00002540HelperSelectorsForTypoCorrection(
2541 SmallVectorImpl<const ObjCMethodDecl *> &BestMethod,
2542 StringRef Typo, const ObjCMethodDecl * Method) {
2543 const unsigned MaxEditDistance = 1;
2544 unsigned BestEditDistance = MaxEditDistance + 1;
Richard Trieuea8d3702013-06-06 02:22:29 +00002545 std::string MethodName = Method->getSelector().getAsString();
Fariborz Jahanian0c0fc9e2013-06-05 18:46:14 +00002546
2547 unsigned MinPossibleEditDistance = abs((int)MethodName.size() - (int)Typo.size());
2548 if (MinPossibleEditDistance > 0 &&
2549 Typo.size() / MinPossibleEditDistance < 1)
2550 return;
2551 unsigned EditDistance = Typo.edit_distance(MethodName, true, MaxEditDistance);
2552 if (EditDistance > MaxEditDistance)
2553 return;
2554 if (EditDistance == BestEditDistance)
2555 BestMethod.push_back(Method);
2556 else if (EditDistance < BestEditDistance) {
2557 BestMethod.clear();
2558 BestMethod.push_back(Method);
Fariborz Jahanian0c0fc9e2013-06-05 18:46:14 +00002559 }
2560}
2561
Fariborz Jahanian75481672013-06-17 17:10:54 +00002562static bool HelperIsMethodInObjCType(Sema &S, Selector Sel,
2563 QualType ObjectType) {
2564 if (ObjectType.isNull())
2565 return true;
2566 if (S.LookupMethodInObjectType(Sel, ObjectType, true/*Instance method*/))
2567 return true;
Craig Topperc3ec1492014-05-26 06:22:03 +00002568 return S.LookupMethodInObjectType(Sel, ObjectType, false/*Class method*/) !=
2569 nullptr;
Fariborz Jahanian75481672013-06-17 17:10:54 +00002570}
2571
Fariborz Jahanian0c0fc9e2013-06-05 18:46:14 +00002572const ObjCMethodDecl *
Fariborz Jahanian75481672013-06-17 17:10:54 +00002573Sema::SelectorsForTypoCorrection(Selector Sel,
2574 QualType ObjectType) {
Fariborz Jahanian0c0fc9e2013-06-05 18:46:14 +00002575 unsigned NumArgs = Sel.getNumArgs();
2576 SmallVector<const ObjCMethodDecl *, 8> Methods;
Fariborz Jahanian4cc55522013-06-18 15:31:36 +00002577 bool ObjectIsId = true, ObjectIsClass = true;
2578 if (ObjectType.isNull())
2579 ObjectIsId = ObjectIsClass = false;
2580 else if (!ObjectType->isObjCObjectPointerType())
Craig Topperc3ec1492014-05-26 06:22:03 +00002581 return nullptr;
Fariborz Jahanian4cc55522013-06-18 15:31:36 +00002582 else if (const ObjCObjectPointerType *ObjCPtr =
2583 ObjectType->getAsObjCInterfacePointerType()) {
2584 ObjectType = QualType(ObjCPtr->getInterfaceType(), 0);
2585 ObjectIsId = ObjectIsClass = false;
2586 }
2587 else if (ObjectType->isObjCIdType() || ObjectType->isObjCQualifiedIdType())
2588 ObjectIsClass = false;
2589 else if (ObjectType->isObjCClassType() || ObjectType->isObjCQualifiedClassType())
2590 ObjectIsId = false;
2591 else
Craig Topperc3ec1492014-05-26 06:22:03 +00002592 return nullptr;
2593
Fariborz Jahanian0c0fc9e2013-06-05 18:46:14 +00002594 for (GlobalMethodPool::iterator b = MethodPool.begin(),
2595 e = MethodPool.end(); b != e; b++) {
2596 // instance methods
2597 for (ObjCMethodList *M = &b->second.first; M; M=M->getNext())
Nico Weber2e0c8f72014-12-27 03:58:08 +00002598 if (M->getMethod() &&
2599 (M->getMethod()->getSelector().getNumArgs() == NumArgs) &&
2600 (M->getMethod()->getSelector() != Sel)) {
Fariborz Jahanian4cc55522013-06-18 15:31:36 +00002601 if (ObjectIsId)
Nico Weber2e0c8f72014-12-27 03:58:08 +00002602 Methods.push_back(M->getMethod());
Fariborz Jahanian4cc55522013-06-18 15:31:36 +00002603 else if (!ObjectIsClass &&
Nico Weber2e0c8f72014-12-27 03:58:08 +00002604 HelperIsMethodInObjCType(*this, M->getMethod()->getSelector(),
2605 ObjectType))
2606 Methods.push_back(M->getMethod());
Fariborz Jahanian4cc55522013-06-18 15:31:36 +00002607 }
Fariborz Jahanian0c0fc9e2013-06-05 18:46:14 +00002608 // class methods
2609 for (ObjCMethodList *M = &b->second.second; M; M=M->getNext())
Nico Weber2e0c8f72014-12-27 03:58:08 +00002610 if (M->getMethod() &&
2611 (M->getMethod()->getSelector().getNumArgs() == NumArgs) &&
2612 (M->getMethod()->getSelector() != Sel)) {
Fariborz Jahanian4cc55522013-06-18 15:31:36 +00002613 if (ObjectIsClass)
Nico Weber2e0c8f72014-12-27 03:58:08 +00002614 Methods.push_back(M->getMethod());
Fariborz Jahanian4cc55522013-06-18 15:31:36 +00002615 else if (!ObjectIsId &&
Nico Weber2e0c8f72014-12-27 03:58:08 +00002616 HelperIsMethodInObjCType(*this, M->getMethod()->getSelector(),
2617 ObjectType))
2618 Methods.push_back(M->getMethod());
Fariborz Jahanian4cc55522013-06-18 15:31:36 +00002619 }
Fariborz Jahanian0c0fc9e2013-06-05 18:46:14 +00002620 }
2621
2622 SmallVector<const ObjCMethodDecl *, 8> SelectedMethods;
2623 for (unsigned i = 0, e = Methods.size(); i < e; i++) {
2624 HelperSelectorsForTypoCorrection(SelectedMethods,
2625 Sel.getAsString(), Methods[i]);
2626 }
Craig Topperc3ec1492014-05-26 06:22:03 +00002627 return (SelectedMethods.size() == 1) ? SelectedMethods[0] : nullptr;
Fariborz Jahanian0c0fc9e2013-06-05 18:46:14 +00002628}
2629
Fariborz Jahanian42f89382013-05-30 21:48:58 +00002630/// DiagnoseDuplicateIvars -
Fariborz Jahanian545643c2010-02-23 23:41:11 +00002631/// Check for duplicate ivars in the entire class at the start of
James Dennett634962f2012-06-14 21:40:34 +00002632/// \@implementation. This becomes necesssary because class extension can
Fariborz Jahanian545643c2010-02-23 23:41:11 +00002633/// add ivars to a class in random order which will not be known until
James Dennett634962f2012-06-14 21:40:34 +00002634/// class's \@implementation is seen.
Fariborz Jahanian545643c2010-02-23 23:41:11 +00002635void Sema::DiagnoseDuplicateIvars(ObjCInterfaceDecl *ID,
2636 ObjCInterfaceDecl *SID) {
Aaron Ballman59abbd42014-03-13 21:09:43 +00002637 for (auto *Ivar : ID->ivars()) {
Fariborz Jahanian545643c2010-02-23 23:41:11 +00002638 if (Ivar->isInvalidDecl())
2639 continue;
2640 if (IdentifierInfo *II = Ivar->getIdentifier()) {
2641 ObjCIvarDecl* prevIvar = SID->lookupInstanceVariable(II);
2642 if (prevIvar) {
2643 Diag(Ivar->getLocation(), diag::err_duplicate_member) << II;
2644 Diag(prevIvar->getLocation(), diag::note_previous_declaration);
2645 Ivar->setInvalidDecl();
2646 }
2647 }
2648 }
2649}
2650
Erik Verbruggenc6c8d932011-12-06 09:25:23 +00002651Sema::ObjCContainerKind Sema::getObjCContainerKind() const {
2652 switch (CurContext->getDeclKind()) {
2653 case Decl::ObjCInterface:
2654 return Sema::OCK_Interface;
2655 case Decl::ObjCProtocol:
2656 return Sema::OCK_Protocol;
2657 case Decl::ObjCCategory:
Benjamin Kramera008d3a2015-04-10 11:37:55 +00002658 if (cast<ObjCCategoryDecl>(CurContext)->IsClassExtension())
Erik Verbruggenc6c8d932011-12-06 09:25:23 +00002659 return Sema::OCK_ClassExtension;
Benjamin Kramera008d3a2015-04-10 11:37:55 +00002660 return Sema::OCK_Category;
Erik Verbruggenc6c8d932011-12-06 09:25:23 +00002661 case Decl::ObjCImplementation:
2662 return Sema::OCK_Implementation;
2663 case Decl::ObjCCategoryImpl:
2664 return Sema::OCK_CategoryImplementation;
2665
2666 default:
2667 return Sema::OCK_None;
2668 }
2669}
2670
Fariborz Jahanian0080fb52013-07-16 15:33:19 +00002671// Note: For class/category implementations, allMethods is always null.
Robert Wilhelm57c67112013-07-17 21:14:35 +00002672Decl *Sema::ActOnAtEnd(Scope *S, SourceRange AtEnd, ArrayRef<Decl *> allMethods,
Fariborz Jahaniandfb76872013-07-17 00:05:08 +00002673 ArrayRef<DeclGroupPtrTy> allTUVars) {
Erik Verbruggenc6c8d932011-12-06 09:25:23 +00002674 if (getObjCContainerKind() == Sema::OCK_None)
Craig Topperc3ec1492014-05-26 06:22:03 +00002675 return nullptr;
Erik Verbruggenc6c8d932011-12-06 09:25:23 +00002676
2677 assert(AtEnd.isValid() && "Invalid location for '@end'");
2678
Fariborz Jahanian8d382dc2011-08-22 15:54:49 +00002679 ObjCContainerDecl *OCD = dyn_cast<ObjCContainerDecl>(CurContext);
2680 Decl *ClassDecl = cast<Decl>(OCD);
Fariborz Jahanian9290ede2009-11-16 18:57:01 +00002681
Mike Stump11289f42009-09-09 15:08:12 +00002682 bool isInterfaceDeclKind =
Chris Lattner219b3e92008-03-16 21:17:37 +00002683 isa<ObjCInterfaceDecl>(ClassDecl) || isa<ObjCCategoryDecl>(ClassDecl)
2684 || isa<ObjCProtocolDecl>(ClassDecl);
Ted Kremenek1b0ea822008-01-07 19:49:32 +00002685 bool checkIdenticalMethods = isa<ObjCImplementationDecl>(ClassDecl);
Steve Naroffb3a87982009-01-09 15:36:25 +00002686
Steve Naroff35c62ae2009-01-08 17:28:14 +00002687 // FIXME: Remove these and use the ObjCContainerDecl/DeclContext.
2688 llvm::DenseMap<Selector, const ObjCMethodDecl*> InsMap;
2689 llvm::DenseMap<Selector, const ObjCMethodDecl*> ClsMap;
2690
Fariborz Jahanian0080fb52013-07-16 15:33:19 +00002691 for (unsigned i = 0, e = allMethods.size(); i != e; i++ ) {
Ted Kremenek1b0ea822008-01-07 19:49:32 +00002692 ObjCMethodDecl *Method =
John McCall48871652010-08-21 09:40:31 +00002693 cast_or_null<ObjCMethodDecl>(allMethods[i]);
Chris Lattnerda463fe2007-12-12 07:09:47 +00002694
2695 if (!Method) continue; // Already issued a diagnostic.
Douglas Gregorffca3a22009-01-09 17:18:27 +00002696 if (Method->isInstanceMethod()) {
Chris Lattnerda463fe2007-12-12 07:09:47 +00002697 /// Check for instance method of the same name with incompatible types
Ted Kremenek1b0ea822008-01-07 19:49:32 +00002698 const ObjCMethodDecl *&PrevMethod = InsMap[Method->getSelector()];
Mike Stump11289f42009-09-09 15:08:12 +00002699 bool match = PrevMethod ? MatchTwoMethodDeclarations(Method, PrevMethod)
Chris Lattnerda463fe2007-12-12 07:09:47 +00002700 : false;
Mike Stump11289f42009-09-09 15:08:12 +00002701 if ((isInterfaceDeclKind && PrevMethod && !match)
Eli Friedman42b1e9e2008-12-16 20:15:50 +00002702 || (checkIdenticalMethods && match)) {
Chris Lattner0369c572008-11-23 23:12:31 +00002703 Diag(Method->getLocation(), diag::err_duplicate_method_decl)
Chris Lattnere4b95692008-11-24 03:33:13 +00002704 << Method->getDeclName();
Chris Lattner0369c572008-11-23 23:12:31 +00002705 Diag(PrevMethod->getLocation(), diag::note_previous_declaration);
Douglas Gregor87e92752010-12-21 17:34:17 +00002706 Method->setInvalidDecl();
Chris Lattnerda463fe2007-12-12 07:09:47 +00002707 } else {
Fariborz Jahanianc17c86b2011-12-13 19:40:34 +00002708 if (PrevMethod) {
Argyrios Kyrtzidisdcaaa212011-10-14 08:02:31 +00002709 Method->setAsRedeclaration(PrevMethod);
Fariborz Jahanianc17c86b2011-12-13 19:40:34 +00002710 if (!Context.getSourceManager().isInSystemHeader(
2711 Method->getLocation()))
2712 Diag(Method->getLocation(), diag::warn_duplicate_method_decl)
2713 << Method->getDeclName();
2714 Diag(PrevMethod->getLocation(), diag::note_previous_declaration);
2715 }
Chris Lattnerda463fe2007-12-12 07:09:47 +00002716 InsMap[Method->getSelector()] = Method;
2717 /// The following allows us to typecheck messages to "id".
Douglas Gregor0e6fc1a2012-05-01 23:37:00 +00002718 AddInstanceMethodToGlobalPool(Method);
Chris Lattnerda463fe2007-12-12 07:09:47 +00002719 }
Mike Stump12b8ce12009-08-04 21:02:39 +00002720 } else {
Chris Lattnerda463fe2007-12-12 07:09:47 +00002721 /// Check for class method of the same name with incompatible types
Ted Kremenek1b0ea822008-01-07 19:49:32 +00002722 const ObjCMethodDecl *&PrevMethod = ClsMap[Method->getSelector()];
Mike Stump11289f42009-09-09 15:08:12 +00002723 bool match = PrevMethod ? MatchTwoMethodDeclarations(Method, PrevMethod)
Chris Lattnerda463fe2007-12-12 07:09:47 +00002724 : false;
Mike Stump11289f42009-09-09 15:08:12 +00002725 if ((isInterfaceDeclKind && PrevMethod && !match)
Eli Friedman42b1e9e2008-12-16 20:15:50 +00002726 || (checkIdenticalMethods && match)) {
Chris Lattner0369c572008-11-23 23:12:31 +00002727 Diag(Method->getLocation(), diag::err_duplicate_method_decl)
Chris Lattnere4b95692008-11-24 03:33:13 +00002728 << Method->getDeclName();
Chris Lattner0369c572008-11-23 23:12:31 +00002729 Diag(PrevMethod->getLocation(), diag::note_previous_declaration);
Douglas Gregor87e92752010-12-21 17:34:17 +00002730 Method->setInvalidDecl();
Chris Lattnerda463fe2007-12-12 07:09:47 +00002731 } else {
Fariborz Jahanianc17c86b2011-12-13 19:40:34 +00002732 if (PrevMethod) {
Argyrios Kyrtzidisdcaaa212011-10-14 08:02:31 +00002733 Method->setAsRedeclaration(PrevMethod);
Fariborz Jahanianc17c86b2011-12-13 19:40:34 +00002734 if (!Context.getSourceManager().isInSystemHeader(
2735 Method->getLocation()))
2736 Diag(Method->getLocation(), diag::warn_duplicate_method_decl)
2737 << Method->getDeclName();
2738 Diag(PrevMethod->getLocation(), diag::note_previous_declaration);
2739 }
Chris Lattnerda463fe2007-12-12 07:09:47 +00002740 ClsMap[Method->getSelector()] = Method;
Douglas Gregor0e6fc1a2012-05-01 23:37:00 +00002741 AddFactoryMethodToGlobalPool(Method);
Chris Lattnerda463fe2007-12-12 07:09:47 +00002742 }
2743 }
2744 }
Douglas Gregorb8982092013-01-21 19:42:21 +00002745 if (isa<ObjCInterfaceDecl>(ClassDecl)) {
2746 // Nothing to do here.
Steve Naroffb3a87982009-01-09 15:36:25 +00002747 } else if (ObjCCategoryDecl *C = dyn_cast<ObjCCategoryDecl>(ClassDecl)) {
Fariborz Jahanian62293f42008-12-06 19:59:02 +00002748 // Categories are used to extend the class by declaring new methods.
Mike Stump11289f42009-09-09 15:08:12 +00002749 // By the same token, they are also used to add new properties. No
Fariborz Jahanian62293f42008-12-06 19:59:02 +00002750 // need to compare the added property to those in the class.
Daniel Dunbar4684f372008-08-27 05:40:03 +00002751
Fariborz Jahanianc21f5432010-12-10 23:36:33 +00002752 if (C->IsClassExtension()) {
2753 ObjCInterfaceDecl *CCPrimary = C->getClassInterface();
2754 DiagnoseClassExtensionDupMethods(C, CCPrimary);
Fariborz Jahanianc21f5432010-12-10 23:36:33 +00002755 }
Chris Lattnerda463fe2007-12-12 07:09:47 +00002756 }
Steve Naroffb3a87982009-01-09 15:36:25 +00002757 if (ObjCContainerDecl *CDecl = dyn_cast<ObjCContainerDecl>(ClassDecl)) {
Fariborz Jahanian30a42922010-02-15 21:55:26 +00002758 if (CDecl->getIdentifier())
2759 // ProcessPropertyDecl is responsible for diagnosing conflicts with any
2760 // user-defined setter/getter. It also synthesizes setter/getter methods
2761 // and adds them to the DeclContext and global method pools.
Aaron Ballmand174edf2014-03-13 19:11:50 +00002762 for (auto *I : CDecl->properties())
Aaron Ballmandc4bea42014-03-13 18:47:37 +00002763 ProcessPropertyDecl(I, CDecl);
Ted Kremenekc7c64312010-01-07 01:20:12 +00002764 CDecl->setAtEndRange(AtEnd);
Steve Naroffb3a87982009-01-09 15:36:25 +00002765 }
2766 if (ObjCImplementationDecl *IC=dyn_cast<ObjCImplementationDecl>(ClassDecl)) {
Ted Kremenekc7c64312010-01-07 01:20:12 +00002767 IC->setAtEndRange(AtEnd);
Fariborz Jahanian13e0c902009-11-11 22:40:11 +00002768 if (ObjCInterfaceDecl* IDecl = IC->getClassInterface()) {
Fariborz Jahanian5d7e9162010-12-11 18:39:37 +00002769 // Any property declared in a class extension might have user
2770 // declared setter or getter in current class extension or one
2771 // of the other class extensions. Mark them as synthesized as
2772 // property will be synthesized when property with same name is
2773 // seen in the @implementation.
Aaron Ballmanf53d8dd2014-03-13 21:47:07 +00002774 for (const auto *Ext : IDecl->visible_extensions()) {
Aaron Ballmand174edf2014-03-13 19:11:50 +00002775 for (const auto *Property : Ext->properties()) {
Fariborz Jahanian5d7e9162010-12-11 18:39:37 +00002776 // Skip over properties declared @dynamic
2777 if (const ObjCPropertyImplDecl *PIDecl
2778 = IC->FindPropertyImplDecl(Property->getIdentifier()))
2779 if (PIDecl->getPropertyImplementation()
2780 == ObjCPropertyImplDecl::Dynamic)
2781 continue;
Douglas Gregor048fbfa2013-01-16 23:00:23 +00002782
Aaron Ballmanf53d8dd2014-03-13 21:47:07 +00002783 for (const auto *Ext : IDecl->visible_extensions()) {
Douglas Gregor048fbfa2013-01-16 23:00:23 +00002784 if (ObjCMethodDecl *GetterMethod
2785 = Ext->getInstanceMethod(Property->getGetterName()))
Jordan Rosed01e83a2012-10-10 16:42:25 +00002786 GetterMethod->setPropertyAccessor(true);
Fariborz Jahanian5d7e9162010-12-11 18:39:37 +00002787 if (!Property->isReadOnly())
Douglas Gregor048fbfa2013-01-16 23:00:23 +00002788 if (ObjCMethodDecl *SetterMethod
2789 = Ext->getInstanceMethod(Property->getSetterName()))
Jordan Rosed01e83a2012-10-10 16:42:25 +00002790 SetterMethod->setPropertyAccessor(true);
Douglas Gregor048fbfa2013-01-16 23:00:23 +00002791 }
Fariborz Jahanian5d7e9162010-12-11 18:39:37 +00002792 }
2793 }
Fariborz Jahanian25491a22010-05-05 21:52:17 +00002794 ImplMethodsVsClassMethods(S, IC, IDecl);
Fariborz Jahanian13e0c902009-11-11 22:40:11 +00002795 AtomicPropertySetterGetterRules(IC, IDecl);
John McCall31168b02011-06-15 23:02:42 +00002796 DiagnoseOwningPropertyGetterSynthesis(IC);
Argyrios Kyrtzidis2080d902014-01-03 18:32:18 +00002797 DiagnoseUnusedBackingIvarInAccessor(S, IC);
Fariborz Jahanian20cfff32015-03-11 16:59:48 +00002798 if (IDecl->hasDesignatedInitializers())
2799 DiagnoseMissingDesignatedInitOverrides(IC, IDecl);
Argyrios Kyrtzidisdb5ce0f2013-12-03 21:11:54 +00002800
Patrick Beardacfbe9e2012-04-06 18:12:22 +00002801 bool HasRootClassAttr = IDecl->hasAttr<ObjCRootClassAttr>();
Craig Topperc3ec1492014-05-26 06:22:03 +00002802 if (IDecl->getSuperClass() == nullptr) {
Patrick Beardacfbe9e2012-04-06 18:12:22 +00002803 // This class has no superclass, so check that it has been marked with
2804 // __attribute((objc_root_class)).
2805 if (!HasRootClassAttr) {
2806 SourceLocation DeclLoc(IDecl->getLocation());
Alp Tokerb6cc5922014-05-03 03:45:55 +00002807 SourceLocation SuperClassLoc(getLocForEndOfToken(DeclLoc));
Patrick Beardacfbe9e2012-04-06 18:12:22 +00002808 Diag(DeclLoc, diag::warn_objc_root_class_missing)
2809 << IDecl->getIdentifier();
2810 // See if NSObject is in the current scope, and if it is, suggest
2811 // adding " : NSObject " to the class declaration.
2812 NamedDecl *IF = LookupSingleName(TUScope,
2813 NSAPIObj->getNSClassId(NSAPI::ClassId_NSObject),
2814 DeclLoc, LookupOrdinaryName);
2815 ObjCInterfaceDecl *NSObjectDecl = dyn_cast_or_null<ObjCInterfaceDecl>(IF);
2816 if (NSObjectDecl && NSObjectDecl->getDefinition()) {
2817 Diag(SuperClassLoc, diag::note_objc_needs_superclass)
2818 << FixItHint::CreateInsertion(SuperClassLoc, " : NSObject ");
2819 } else {
2820 Diag(SuperClassLoc, diag::note_objc_needs_superclass);
2821 }
2822 }
2823 } else if (HasRootClassAttr) {
2824 // Complain that only root classes may have this attribute.
2825 Diag(IDecl->getLocation(), diag::err_objc_root_class_subclass);
2826 }
2827
John McCall5fb5df92012-06-20 06:18:46 +00002828 if (LangOpts.ObjCRuntime.isNonFragile()) {
Fariborz Jahanian545643c2010-02-23 23:41:11 +00002829 while (IDecl->getSuperClass()) {
2830 DiagnoseDuplicateIvars(IDecl, IDecl->getSuperClass());
2831 IDecl = IDecl->getSuperClass();
2832 }
Patrick Beardacfbe9e2012-04-06 18:12:22 +00002833 }
Fariborz Jahanian13e0c902009-11-11 22:40:11 +00002834 }
Fariborz Jahanianc83726e2010-04-28 16:11:27 +00002835 SetIvarInitializers(IC);
Mike Stump11289f42009-09-09 15:08:12 +00002836 } else if (ObjCCategoryImplDecl* CatImplClass =
Steve Naroffb3a87982009-01-09 15:36:25 +00002837 dyn_cast<ObjCCategoryImplDecl>(ClassDecl)) {
Ted Kremenekc7c64312010-01-07 01:20:12 +00002838 CatImplClass->setAtEndRange(AtEnd);
Mike Stump11289f42009-09-09 15:08:12 +00002839
Chris Lattnerda463fe2007-12-12 07:09:47 +00002840 // Find category interface decl and then check that all methods declared
Daniel Dunbar4684f372008-08-27 05:40:03 +00002841 // in this interface are implemented in the category @implementation.
Chris Lattner41fd42e2009-02-16 18:32:47 +00002842 if (ObjCInterfaceDecl* IDecl = CatImplClass->getClassInterface()) {
Douglas Gregor048fbfa2013-01-16 23:00:23 +00002843 if (ObjCCategoryDecl *Cat
2844 = IDecl->FindCategoryDeclaration(CatImplClass->getIdentifier())) {
2845 ImplMethodsVsClassMethods(S, CatImplClass, Cat);
Chris Lattnerda463fe2007-12-12 07:09:47 +00002846 }
2847 }
2848 }
Chris Lattner5bbb3c82009-03-29 16:50:03 +00002849 if (isInterfaceDeclKind) {
2850 // Reject invalid vardecls.
Fariborz Jahanian0080fb52013-07-16 15:33:19 +00002851 for (unsigned i = 0, e = allTUVars.size(); i != e; i++) {
Serge Pavlov9ddb76e2013-08-27 13:15:56 +00002852 DeclGroupRef DG = allTUVars[i].get();
Chris Lattner5bbb3c82009-03-29 16:50:03 +00002853 for (DeclGroupRef::iterator I = DG.begin(), E = DG.end(); I != E; ++I)
2854 if (VarDecl *VDecl = dyn_cast<VarDecl>(*I)) {
Daniel Dunbar0ca16602009-04-14 02:25:56 +00002855 if (!VDecl->hasExternalStorage())
Steve Naroff42959b22009-04-13 17:58:46 +00002856 Diag(VDecl->getLocation(), diag::err_objc_var_decl_inclass);
Fariborz Jahanian629aed92009-03-21 18:06:45 +00002857 }
Chris Lattner5bbb3c82009-03-29 16:50:03 +00002858 }
Fariborz Jahanian3654e652009-03-18 22:33:24 +00002859 }
Fariborz Jahanian4327b322011-08-29 17:33:12 +00002860 ActOnObjCContainerFinishDefinition();
Argyrios Kyrtzidisbd8b1502011-10-17 19:48:13 +00002861
Fariborz Jahanian0080fb52013-07-16 15:33:19 +00002862 for (unsigned i = 0, e = allTUVars.size(); i != e; i++) {
Serge Pavlov9ddb76e2013-08-27 13:15:56 +00002863 DeclGroupRef DG = allTUVars[i].get();
Argyrios Kyrtzidis8ad3bab2011-11-23 20:27:36 +00002864 for (DeclGroupRef::iterator I = DG.begin(), E = DG.end(); I != E; ++I)
2865 (*I)->setTopLevelDeclInObjCContainer();
Argyrios Kyrtzidisbd8b1502011-10-17 19:48:13 +00002866 Consumer.HandleTopLevelDeclInObjCContainer(DG);
2867 }
Erik Verbruggenc6c8d932011-12-06 09:25:23 +00002868
Dmitri Gribenkoe7bb9442012-07-13 01:06:46 +00002869 ActOnDocumentableDecl(ClassDecl);
Erik Verbruggenc6c8d932011-12-06 09:25:23 +00002870 return ClassDecl;
Chris Lattnerda463fe2007-12-12 07:09:47 +00002871}
2872
2873
2874/// CvtQTToAstBitMask - utility routine to produce an AST bitmask for
2875/// objective-c's type qualifier from the parser version of the same info.
Mike Stump11289f42009-09-09 15:08:12 +00002876static Decl::ObjCDeclQualifier
Ted Kremenek1b0ea822008-01-07 19:49:32 +00002877CvtQTToAstBitMask(ObjCDeclSpec::ObjCDeclQualifier PQTVal) {
John McCallca872902011-05-01 03:04:29 +00002878 return (Decl::ObjCDeclQualifier) (unsigned) PQTVal;
Chris Lattnerda463fe2007-12-12 07:09:47 +00002879}
2880
Douglas Gregor33823722011-06-11 01:09:30 +00002881/// \brief Check whether the declared result type of the given Objective-C
2882/// method declaration is compatible with the method's class.
2883///
Argyrios Kyrtzidis08f96a92012-05-09 16:12:57 +00002884static Sema::ResultTypeCompatibilityKind
Douglas Gregor33823722011-06-11 01:09:30 +00002885CheckRelatedResultTypeCompatibility(Sema &S, ObjCMethodDecl *Method,
2886 ObjCInterfaceDecl *CurrentClass) {
Alp Toker314cc812014-01-25 16:55:45 +00002887 QualType ResultType = Method->getReturnType();
2888
Douglas Gregor33823722011-06-11 01:09:30 +00002889 // If an Objective-C method inherits its related result type, then its
2890 // declared result type must be compatible with its own class type. The
2891 // declared result type is compatible if:
2892 if (const ObjCObjectPointerType *ResultObjectType
2893 = ResultType->getAs<ObjCObjectPointerType>()) {
2894 // - it is id or qualified id, or
2895 if (ResultObjectType->isObjCIdType() ||
2896 ResultObjectType->isObjCQualifiedIdType())
Argyrios Kyrtzidis08f96a92012-05-09 16:12:57 +00002897 return Sema::RTC_Compatible;
Douglas Gregor33823722011-06-11 01:09:30 +00002898
2899 if (CurrentClass) {
2900 if (ObjCInterfaceDecl *ResultClass
2901 = ResultObjectType->getInterfaceDecl()) {
2902 // - it is the same as the method's class type, or
Douglas Gregor0b144e12011-12-15 00:29:59 +00002903 if (declaresSameEntity(CurrentClass, ResultClass))
Argyrios Kyrtzidis08f96a92012-05-09 16:12:57 +00002904 return Sema::RTC_Compatible;
Douglas Gregor33823722011-06-11 01:09:30 +00002905
2906 // - it is a superclass of the method's class type
2907 if (ResultClass->isSuperClassOf(CurrentClass))
Argyrios Kyrtzidis08f96a92012-05-09 16:12:57 +00002908 return Sema::RTC_Compatible;
Douglas Gregor33823722011-06-11 01:09:30 +00002909 }
Douglas Gregorbab8a962011-09-08 01:46:34 +00002910 } else {
2911 // Any Objective-C pointer type might be acceptable for a protocol
2912 // method; we just don't know.
Argyrios Kyrtzidis08f96a92012-05-09 16:12:57 +00002913 return Sema::RTC_Unknown;
Douglas Gregor33823722011-06-11 01:09:30 +00002914 }
2915 }
2916
Argyrios Kyrtzidis08f96a92012-05-09 16:12:57 +00002917 return Sema::RTC_Incompatible;
Douglas Gregor33823722011-06-11 01:09:30 +00002918}
2919
John McCalld2930c22011-07-22 02:45:48 +00002920namespace {
2921/// A helper class for searching for methods which a particular method
2922/// overrides.
2923class OverrideSearch {
Daniel Dunbard6d74c32012-02-29 03:04:05 +00002924public:
John McCalld2930c22011-07-22 02:45:48 +00002925 Sema &S;
2926 ObjCMethodDecl *Method;
Daniel Dunbard6d74c32012-02-29 03:04:05 +00002927 llvm::SmallPtrSet<ObjCMethodDecl*, 4> Overridden;
John McCalld2930c22011-07-22 02:45:48 +00002928 bool Recursive;
2929
2930public:
2931 OverrideSearch(Sema &S, ObjCMethodDecl *method) : S(S), Method(method) {
2932 Selector selector = method->getSelector();
2933
2934 // Bypass this search if we've never seen an instance/class method
2935 // with this selector before.
2936 Sema::GlobalMethodPool::iterator it = S.MethodPool.find(selector);
2937 if (it == S.MethodPool.end()) {
Axel Naumanndd433f02012-10-18 19:05:02 +00002938 if (!S.getExternalSource()) return;
Douglas Gregore1716012012-01-25 00:49:42 +00002939 S.ReadMethodPool(selector);
2940
2941 it = S.MethodPool.find(selector);
2942 if (it == S.MethodPool.end())
2943 return;
John McCalld2930c22011-07-22 02:45:48 +00002944 }
2945 ObjCMethodList &list =
2946 method->isInstanceMethod() ? it->second.first : it->second.second;
Nico Weber2e0c8f72014-12-27 03:58:08 +00002947 if (!list.getMethod()) return;
John McCalld2930c22011-07-22 02:45:48 +00002948
2949 ObjCContainerDecl *container
2950 = cast<ObjCContainerDecl>(method->getDeclContext());
2951
2952 // Prevent the search from reaching this container again. This is
2953 // important with categories, which override methods from the
2954 // interface and each other.
Douglas Gregorcf4ac442012-05-03 21:25:24 +00002955 if (ObjCCategoryDecl *Category = dyn_cast<ObjCCategoryDecl>(container)) {
2956 searchFromContainer(container);
Douglas Gregorc5928af2012-05-17 22:39:14 +00002957 if (ObjCInterfaceDecl *Interface = Category->getClassInterface())
2958 searchFromContainer(Interface);
Douglas Gregorcf4ac442012-05-03 21:25:24 +00002959 } else {
2960 searchFromContainer(container);
2961 }
Douglas Gregor33823722011-06-11 01:09:30 +00002962 }
John McCalld2930c22011-07-22 02:45:48 +00002963
Daniel Dunbard6d74c32012-02-29 03:04:05 +00002964 typedef llvm::SmallPtrSet<ObjCMethodDecl*, 128>::iterator iterator;
John McCalld2930c22011-07-22 02:45:48 +00002965 iterator begin() const { return Overridden.begin(); }
2966 iterator end() const { return Overridden.end(); }
2967
2968private:
2969 void searchFromContainer(ObjCContainerDecl *container) {
2970 if (container->isInvalidDecl()) return;
2971
2972 switch (container->getDeclKind()) {
2973#define OBJCCONTAINER(type, base) \
2974 case Decl::type: \
2975 searchFrom(cast<type##Decl>(container)); \
2976 break;
2977#define ABSTRACT_DECL(expansion)
2978#define DECL(type, base) \
2979 case Decl::type:
2980#include "clang/AST/DeclNodes.inc"
2981 llvm_unreachable("not an ObjC container!");
2982 }
2983 }
2984
2985 void searchFrom(ObjCProtocolDecl *protocol) {
Douglas Gregore6e48b12012-01-01 19:29:29 +00002986 if (!protocol->hasDefinition())
2987 return;
2988
John McCalld2930c22011-07-22 02:45:48 +00002989 // A method in a protocol declaration overrides declarations from
2990 // referenced ("parent") protocols.
2991 search(protocol->getReferencedProtocols());
2992 }
2993
2994 void searchFrom(ObjCCategoryDecl *category) {
2995 // A method in a category declaration overrides declarations from
2996 // the main class and from protocols the category references.
Douglas Gregorcf4ac442012-05-03 21:25:24 +00002997 // The main class is handled in the constructor.
John McCalld2930c22011-07-22 02:45:48 +00002998 search(category->getReferencedProtocols());
2999 }
3000
3001 void searchFrom(ObjCCategoryImplDecl *impl) {
3002 // A method in a category definition that has a category
3003 // declaration overrides declarations from the category
3004 // declaration.
3005 if (ObjCCategoryDecl *category = impl->getCategoryDecl()) {
3006 search(category);
Douglas Gregorc5928af2012-05-17 22:39:14 +00003007 if (ObjCInterfaceDecl *Interface = category->getClassInterface())
3008 search(Interface);
John McCalld2930c22011-07-22 02:45:48 +00003009
3010 // Otherwise it overrides declarations from the class.
Douglas Gregorc5928af2012-05-17 22:39:14 +00003011 } else if (ObjCInterfaceDecl *Interface = impl->getClassInterface()) {
3012 search(Interface);
John McCalld2930c22011-07-22 02:45:48 +00003013 }
3014 }
3015
3016 void searchFrom(ObjCInterfaceDecl *iface) {
3017 // A method in a class declaration overrides declarations from
Douglas Gregorc0ac7d62011-12-15 05:27:12 +00003018 if (!iface->hasDefinition())
3019 return;
3020
John McCalld2930c22011-07-22 02:45:48 +00003021 // - categories,
Aaron Ballman15063e12014-03-13 21:35:02 +00003022 for (auto *Cat : iface->known_categories())
3023 search(Cat);
John McCalld2930c22011-07-22 02:45:48 +00003024
3025 // - the super class, and
3026 if (ObjCInterfaceDecl *super = iface->getSuperClass())
3027 search(super);
3028
3029 // - any referenced protocols.
3030 search(iface->getReferencedProtocols());
3031 }
3032
3033 void searchFrom(ObjCImplementationDecl *impl) {
3034 // A method in a class implementation overrides declarations from
3035 // the class interface.
Douglas Gregorc5928af2012-05-17 22:39:14 +00003036 if (ObjCInterfaceDecl *Interface = impl->getClassInterface())
3037 search(Interface);
John McCalld2930c22011-07-22 02:45:48 +00003038 }
3039
3040
3041 void search(const ObjCProtocolList &protocols) {
3042 for (ObjCProtocolList::iterator i = protocols.begin(), e = protocols.end();
3043 i != e; ++i)
3044 search(*i);
3045 }
3046
3047 void search(ObjCContainerDecl *container) {
John McCalld2930c22011-07-22 02:45:48 +00003048 // Check for a method in this container which matches this selector.
3049 ObjCMethodDecl *meth = container->getMethod(Method->getSelector(),
Argyrios Kyrtzidisbd8cd3e2013-03-29 21:51:48 +00003050 Method->isInstanceMethod(),
3051 /*AllowHidden=*/true);
John McCalld2930c22011-07-22 02:45:48 +00003052
3053 // If we find one, record it and bail out.
3054 if (meth) {
3055 Overridden.insert(meth);
3056 return;
3057 }
3058
3059 // Otherwise, search for methods that a hypothetical method here
3060 // would have overridden.
3061
3062 // Note that we're now in a recursive case.
3063 Recursive = true;
3064
3065 searchFromContainer(container);
3066 }
3067};
Alexander Kornienkoab9db512015-06-22 23:07:51 +00003068}
Douglas Gregor33823722011-06-11 01:09:30 +00003069
Argyrios Kyrtzidis08f96a92012-05-09 16:12:57 +00003070void Sema::CheckObjCMethodOverrides(ObjCMethodDecl *ObjCMethod,
3071 ObjCInterfaceDecl *CurrentClass,
3072 ResultTypeCompatibilityKind RTC) {
3073 // Search for overridden methods and merge information down from them.
3074 OverrideSearch overrides(*this, ObjCMethod);
3075 // Keep track if the method overrides any method in the class's base classes,
3076 // its protocols, or its categories' protocols; we will keep that info
3077 // in the ObjCMethodDecl.
3078 // For this info, a method in an implementation is not considered as
3079 // overriding the same method in the interface or its categories.
3080 bool hasOverriddenMethodsInBaseOrProtocol = false;
3081 for (OverrideSearch::iterator
3082 i = overrides.begin(), e = overrides.end(); i != e; ++i) {
3083 ObjCMethodDecl *overridden = *i;
3084
Argyrios Kyrtzidisc2091d52013-04-17 00:09:08 +00003085 if (!hasOverriddenMethodsInBaseOrProtocol) {
3086 if (isa<ObjCProtocolDecl>(overridden->getDeclContext()) ||
3087 CurrentClass != overridden->getClassInterface() ||
3088 overridden->isOverriding()) {
3089 hasOverriddenMethodsInBaseOrProtocol = true;
3090
3091 } else if (isa<ObjCImplDecl>(ObjCMethod->getDeclContext())) {
3092 // OverrideSearch will return as "overridden" the same method in the
3093 // interface. For hasOverriddenMethodsInBaseOrProtocol, we need to
3094 // check whether a category of a base class introduced a method with the
3095 // same selector, after the interface method declaration.
3096 // To avoid unnecessary lookups in the majority of cases, we use the
3097 // extra info bits in GlobalMethodPool to check whether there were any
3098 // category methods with this selector.
3099 GlobalMethodPool::iterator It =
3100 MethodPool.find(ObjCMethod->getSelector());
3101 if (It != MethodPool.end()) {
3102 ObjCMethodList &List =
3103 ObjCMethod->isInstanceMethod()? It->second.first: It->second.second;
3104 unsigned CategCount = List.getBits();
3105 if (CategCount > 0) {
3106 // If the method is in a category we'll do lookup if there were at
3107 // least 2 category methods recorded, otherwise only one will do.
3108 if (CategCount > 1 ||
3109 !isa<ObjCCategoryImplDecl>(overridden->getDeclContext())) {
3110 OverrideSearch overrides(*this, overridden);
3111 for (OverrideSearch::iterator
3112 OI= overrides.begin(), OE= overrides.end(); OI!=OE; ++OI) {
3113 ObjCMethodDecl *SuperOverridden = *OI;
Argyrios Kyrtzidis04703a62013-04-27 00:10:12 +00003114 if (isa<ObjCProtocolDecl>(SuperOverridden->getDeclContext()) ||
3115 CurrentClass != SuperOverridden->getClassInterface()) {
Argyrios Kyrtzidisc2091d52013-04-17 00:09:08 +00003116 hasOverriddenMethodsInBaseOrProtocol = true;
3117 overridden->setOverriding(true);
3118 break;
3119 }
3120 }
3121 }
3122 }
3123 }
3124 }
3125 }
Argyrios Kyrtzidis08f96a92012-05-09 16:12:57 +00003126
3127 // Propagate down the 'related result type' bit from overridden methods.
3128 if (RTC != Sema::RTC_Incompatible && overridden->hasRelatedResultType())
3129 ObjCMethod->SetRelatedResultType();
3130
3131 // Then merge the declarations.
3132 mergeObjCMethodDecls(ObjCMethod, overridden);
3133
3134 if (ObjCMethod->isImplicit() && overridden->isImplicit())
3135 continue; // Conflicting properties are detected elsewhere.
3136
3137 // Check for overriding methods
3138 if (isa<ObjCInterfaceDecl>(ObjCMethod->getDeclContext()) ||
3139 isa<ObjCImplementationDecl>(ObjCMethod->getDeclContext()))
3140 CheckConflictingOverridingMethod(ObjCMethod, overridden,
3141 isa<ObjCProtocolDecl>(overridden->getDeclContext()));
3142
3143 if (CurrentClass && overridden->getDeclContext() != CurrentClass &&
Fariborz Jahanian31a25682012-07-05 22:26:07 +00003144 isa<ObjCInterfaceDecl>(overridden->getDeclContext()) &&
3145 !overridden->isImplicit() /* not meant for properties */) {
Argyrios Kyrtzidis08f96a92012-05-09 16:12:57 +00003146 ObjCMethodDecl::param_iterator ParamI = ObjCMethod->param_begin(),
3147 E = ObjCMethod->param_end();
Douglas Gregor0bf70f42012-05-17 23:13:29 +00003148 ObjCMethodDecl::param_iterator PrevI = overridden->param_begin(),
3149 PrevE = overridden->param_end();
3150 for (; ParamI != E && PrevI != PrevE; ++ParamI, ++PrevI) {
Argyrios Kyrtzidis08f96a92012-05-09 16:12:57 +00003151 assert(PrevI != overridden->param_end() && "Param mismatch");
3152 QualType T1 = Context.getCanonicalType((*ParamI)->getType());
3153 QualType T2 = Context.getCanonicalType((*PrevI)->getType());
3154 // If type of argument of method in this class does not match its
3155 // respective argument type in the super class method, issue warning;
3156 if (!Context.typesAreCompatible(T1, T2)) {
3157 Diag((*ParamI)->getLocation(), diag::ext_typecheck_base_super)
3158 << T1 << T2;
3159 Diag(overridden->getLocation(), diag::note_previous_declaration);
3160 break;
3161 }
3162 }
3163 }
3164 }
3165
3166 ObjCMethod->setOverriding(hasOverriddenMethodsInBaseOrProtocol);
3167}
3168
Douglas Gregor813a0662015-06-19 18:14:38 +00003169/// Merge type nullability from for a redeclaration of the same entity,
3170/// producing the updated type of the redeclared entity.
3171static QualType mergeTypeNullabilityForRedecl(Sema &S, SourceLocation loc,
3172 QualType type,
3173 bool usesCSKeyword,
3174 SourceLocation prevLoc,
3175 QualType prevType,
3176 bool prevUsesCSKeyword) {
3177 // Determine the nullability of both types.
3178 auto nullability = type->getNullability(S.Context);
3179 auto prevNullability = prevType->getNullability(S.Context);
3180
3181 // Easy case: both have nullability.
3182 if (nullability.hasValue() == prevNullability.hasValue()) {
3183 // Neither has nullability; continue.
3184 if (!nullability)
3185 return type;
3186
3187 // The nullabilities are equivalent; do nothing.
3188 if (*nullability == *prevNullability)
3189 return type;
3190
3191 // Complain about mismatched nullability.
3192 S.Diag(loc, diag::err_nullability_conflicting)
Douglas Gregoraea7afd2015-06-24 22:02:08 +00003193 << DiagNullabilityKind(*nullability, usesCSKeyword)
3194 << DiagNullabilityKind(*prevNullability, prevUsesCSKeyword);
Douglas Gregor813a0662015-06-19 18:14:38 +00003195 return type;
3196 }
3197
3198 // If it's the redeclaration that has nullability, don't change anything.
3199 if (nullability)
3200 return type;
3201
3202 // Otherwise, provide the result with the same nullability.
3203 return S.Context.getAttributedType(
3204 AttributedType::getNullabilityAttrKind(*prevNullability),
3205 type, type);
3206}
3207
NAKAMURA Takumi2df5c3c2015-06-20 03:52:52 +00003208/// Merge information from the declaration of a method in the \@interface
Douglas Gregor813a0662015-06-19 18:14:38 +00003209/// (or a category/extension) into the corresponding method in the
3210/// @implementation (for a class or category).
3211static void mergeInterfaceMethodToImpl(Sema &S,
3212 ObjCMethodDecl *method,
3213 ObjCMethodDecl *prevMethod) {
3214 // Merge the objc_requires_super attribute.
3215 if (prevMethod->hasAttr<ObjCRequiresSuperAttr>() &&
3216 !method->hasAttr<ObjCRequiresSuperAttr>()) {
3217 // merge the attribute into implementation.
3218 method->addAttr(
3219 ObjCRequiresSuperAttr::CreateImplicit(S.Context,
3220 method->getLocation()));
3221 }
3222
3223 // Merge nullability of the result type.
3224 QualType newReturnType
3225 = mergeTypeNullabilityForRedecl(
3226 S, method->getReturnTypeSourceRange().getBegin(),
3227 method->getReturnType(),
3228 method->getObjCDeclQualifier() & Decl::OBJC_TQ_CSNullability,
3229 prevMethod->getReturnTypeSourceRange().getBegin(),
3230 prevMethod->getReturnType(),
3231 prevMethod->getObjCDeclQualifier() & Decl::OBJC_TQ_CSNullability);
3232 method->setReturnType(newReturnType);
3233
3234 // Handle each of the parameters.
3235 unsigned numParams = method->param_size();
3236 unsigned numPrevParams = prevMethod->param_size();
3237 for (unsigned i = 0, n = std::min(numParams, numPrevParams); i != n; ++i) {
3238 ParmVarDecl *param = method->param_begin()[i];
3239 ParmVarDecl *prevParam = prevMethod->param_begin()[i];
3240
3241 // Merge nullability.
3242 QualType newParamType
3243 = mergeTypeNullabilityForRedecl(
3244 S, param->getLocation(), param->getType(),
3245 param->getObjCDeclQualifier() & Decl::OBJC_TQ_CSNullability,
3246 prevParam->getLocation(), prevParam->getType(),
3247 prevParam->getObjCDeclQualifier() & Decl::OBJC_TQ_CSNullability);
3248 param->setType(newParamType);
3249 }
3250}
3251
John McCall48871652010-08-21 09:40:31 +00003252Decl *Sema::ActOnMethodDeclaration(
Fariborz Jahanianca3566f2011-02-09 22:20:01 +00003253 Scope *S,
Chris Lattnerda463fe2007-12-12 07:09:47 +00003254 SourceLocation MethodLoc, SourceLocation EndLoc,
Fariborz Jahanian8d382dc2011-08-22 15:54:49 +00003255 tok::TokenKind MethodType,
John McCallba7bf592010-08-24 05:47:05 +00003256 ObjCDeclSpec &ReturnQT, ParsedType ReturnType,
Argyrios Kyrtzidisdfd65702011-10-03 06:36:36 +00003257 ArrayRef<SourceLocation> SelectorLocs,
Chris Lattnerda463fe2007-12-12 07:09:47 +00003258 Selector Sel,
3259 // optional arguments. The number of types/arguments is obtained
3260 // from the Sel.getNumArgs().
Chris Lattnerd8626fd2009-04-11 18:57:04 +00003261 ObjCArgInfo *ArgInfo,
Fariborz Jahanian60462092010-04-08 00:30:06 +00003262 DeclaratorChunk::ParamInfo *CParamInfo, unsigned CNumArgs, // c-style args
Chris Lattnerda463fe2007-12-12 07:09:47 +00003263 AttributeList *AttrList, tok::ObjCKeywordKind MethodDeclKind,
Fariborz Jahanianc677f692011-03-12 18:54:30 +00003264 bool isVariadic, bool MethodDefinition) {
Steve Naroff83777fe2008-02-29 21:48:07 +00003265 // Make sure we can establish a context for the method.
Fariborz Jahanian8d382dc2011-08-22 15:54:49 +00003266 if (!CurContext->isObjCContainer()) {
Steve Naroff83777fe2008-02-29 21:48:07 +00003267 Diag(MethodLoc, diag::error_missing_method_context);
Craig Topperc3ec1492014-05-26 06:22:03 +00003268 return nullptr;
Steve Naroff83777fe2008-02-29 21:48:07 +00003269 }
Fariborz Jahanian8d382dc2011-08-22 15:54:49 +00003270 ObjCContainerDecl *OCD = dyn_cast<ObjCContainerDecl>(CurContext);
3271 Decl *ClassDecl = cast<Decl>(OCD);
Chris Lattnerda463fe2007-12-12 07:09:47 +00003272 QualType resultDeclType;
Mike Stump11289f42009-09-09 15:08:12 +00003273
Douglas Gregorbab8a962011-09-08 01:46:34 +00003274 bool HasRelatedResultType = false;
Craig Topperc3ec1492014-05-26 06:22:03 +00003275 TypeSourceInfo *ReturnTInfo = nullptr;
Steve Naroff32606412009-02-20 22:59:16 +00003276 if (ReturnType) {
Alp Toker314cc812014-01-25 16:55:45 +00003277 resultDeclType = GetTypeFromParser(ReturnType, &ReturnTInfo);
Mike Stump11289f42009-09-09 15:08:12 +00003278
Eli Friedman31a5bcc2013-06-14 21:14:10 +00003279 if (CheckFunctionReturnType(resultDeclType, MethodLoc))
Craig Topperc3ec1492014-05-26 06:22:03 +00003280 return nullptr;
Eli Friedman31a5bcc2013-06-14 21:14:10 +00003281
Douglas Gregor813a0662015-06-19 18:14:38 +00003282 QualType bareResultType = resultDeclType;
3283 (void)AttributedType::stripOuterNullability(bareResultType);
3284 HasRelatedResultType = (bareResultType == Context.getObjCInstanceType());
Fariborz Jahanianb5a52ca2011-07-21 17:00:47 +00003285 } else { // get the type for "id".
Ted Kremenek1b0ea822008-01-07 19:49:32 +00003286 resultDeclType = Context.getObjCIdType();
Fariborz Jahanianb21138f2011-07-21 17:38:14 +00003287 Diag(MethodLoc, diag::warn_missing_method_return_type)
Argyrios Kyrtzidisdfd65702011-10-03 06:36:36 +00003288 << FixItHint::CreateInsertion(SelectorLocs.front(), "(id)");
Fariborz Jahanianb5a52ca2011-07-21 17:00:47 +00003289 }
Mike Stump11289f42009-09-09 15:08:12 +00003290
Alp Toker314cc812014-01-25 16:55:45 +00003291 ObjCMethodDecl *ObjCMethod = ObjCMethodDecl::Create(
3292 Context, MethodLoc, EndLoc, Sel, resultDeclType, ReturnTInfo, CurContext,
3293 MethodType == tok::minus, isVariadic,
3294 /*isPropertyAccessor=*/false,
3295 /*isImplicitlyDeclared=*/false, /*isDefined=*/false,
3296 MethodDeclKind == tok::objc_optional ? ObjCMethodDecl::Optional
3297 : ObjCMethodDecl::Required,
3298 HasRelatedResultType);
Mike Stump11289f42009-09-09 15:08:12 +00003299
Chris Lattner0e62c1c2011-07-23 10:55:15 +00003300 SmallVector<ParmVarDecl*, 16> Params;
Mike Stump11289f42009-09-09 15:08:12 +00003301
Chris Lattner23b0faf2009-04-11 19:42:43 +00003302 for (unsigned i = 0, e = Sel.getNumArgs(); i != e; ++i) {
John McCall856bbea2009-10-23 21:48:59 +00003303 QualType ArgType;
John McCallbcd03502009-12-07 02:54:59 +00003304 TypeSourceInfo *DI;
Mike Stump11289f42009-09-09 15:08:12 +00003305
David Blaikie7d170102013-05-15 07:37:26 +00003306 if (!ArgInfo[i].Type) {
John McCall856bbea2009-10-23 21:48:59 +00003307 ArgType = Context.getObjCIdType();
Craig Topperc3ec1492014-05-26 06:22:03 +00003308 DI = nullptr;
Chris Lattnerd8626fd2009-04-11 18:57:04 +00003309 } else {
John McCall856bbea2009-10-23 21:48:59 +00003310 ArgType = GetTypeFromParser(ArgInfo[i].Type, &DI);
Chris Lattnerd8626fd2009-04-11 18:57:04 +00003311 }
Mike Stump11289f42009-09-09 15:08:12 +00003312
Fariborz Jahanianca3566f2011-02-09 22:20:01 +00003313 LookupResult R(*this, ArgInfo[i].Name, ArgInfo[i].NameLoc,
3314 LookupOrdinaryName, ForRedeclaration);
3315 LookupName(R, S);
3316 if (R.isSingleResult()) {
3317 NamedDecl *PrevDecl = R.getFoundDecl();
3318 if (S->isDeclScope(PrevDecl)) {
Fariborz Jahanianc677f692011-03-12 18:54:30 +00003319 Diag(ArgInfo[i].NameLoc,
3320 (MethodDefinition ? diag::warn_method_param_redefinition
3321 : diag::warn_method_param_declaration))
Fariborz Jahanianca3566f2011-02-09 22:20:01 +00003322 << ArgInfo[i].Name;
3323 Diag(PrevDecl->getLocation(),
3324 diag::note_previous_declaration);
3325 }
3326 }
3327
Abramo Bagnaradff19302011-03-08 08:55:46 +00003328 SourceLocation StartLoc = DI
3329 ? DI->getTypeLoc().getBeginLoc()
3330 : ArgInfo[i].NameLoc;
3331
John McCalld44f4d72011-04-23 02:46:06 +00003332 ParmVarDecl* Param = CheckParameter(ObjCMethod, StartLoc,
3333 ArgInfo[i].NameLoc, ArgInfo[i].Name,
Rafael Espindola6ae7e502013-04-03 19:27:57 +00003334 ArgType, DI, SC_None);
Mike Stump11289f42009-09-09 15:08:12 +00003335
John McCall82490832011-05-02 00:30:12 +00003336 Param->setObjCMethodScopeInfo(i);
3337
Chris Lattnerc5ffed42008-04-04 06:12:32 +00003338 Param->setObjCDeclQualifier(
Chris Lattnerd8626fd2009-04-11 18:57:04 +00003339 CvtQTToAstBitMask(ArgInfo[i].DeclSpec.getObjCDeclQualifier()));
Mike Stump11289f42009-09-09 15:08:12 +00003340
Chris Lattner9713a1c2009-04-11 19:34:56 +00003341 // Apply the attributes to the parameter.
Douglas Gregor758a8692009-06-17 21:51:59 +00003342 ProcessDeclAttributeList(TUScope, Param, ArgInfo[i].ArgAttrs);
Mike Stump11289f42009-09-09 15:08:12 +00003343
Fariborz Jahanian52d02f62012-01-14 18:44:35 +00003344 if (Param->hasAttr<BlocksAttr>()) {
3345 Diag(Param->getLocation(), diag::err_block_on_nonlocal);
3346 Param->setInvalidDecl();
3347 }
Fariborz Jahanianca3566f2011-02-09 22:20:01 +00003348 S->AddDecl(Param);
3349 IdResolver.AddDecl(Param);
3350
Chris Lattnerc5ffed42008-04-04 06:12:32 +00003351 Params.push_back(Param);
3352 }
Fariborz Jahanianca3566f2011-02-09 22:20:01 +00003353
Fariborz Jahanian60462092010-04-08 00:30:06 +00003354 for (unsigned i = 0, e = CNumArgs; i != e; ++i) {
John McCall48871652010-08-21 09:40:31 +00003355 ParmVarDecl *Param = cast<ParmVarDecl>(CParamInfo[i].Param);
Fariborz Jahanian60462092010-04-08 00:30:06 +00003356 QualType ArgType = Param->getType();
3357 if (ArgType.isNull())
3358 ArgType = Context.getObjCIdType();
3359 else
3360 // Perform the default array/function conversions (C99 6.7.5.3p[7,8]).
Douglas Gregor84280642011-07-12 04:42:08 +00003361 ArgType = Context.getAdjustedParameterType(ArgType);
Eli Friedman31a5bcc2013-06-14 21:14:10 +00003362
Fariborz Jahanian60462092010-04-08 00:30:06 +00003363 Param->setDeclContext(ObjCMethod);
Fariborz Jahanian60462092010-04-08 00:30:06 +00003364 Params.push_back(Param);
3365 }
3366
Argyrios Kyrtzidisb8c3aaf2011-10-03 06:37:04 +00003367 ObjCMethod->setMethodParams(Context, Params, SelectorLocs);
Ted Kremenek1b0ea822008-01-07 19:49:32 +00003368 ObjCMethod->setObjCDeclQualifier(
3369 CvtQTToAstBitMask(ReturnQT.getObjCDeclQualifier()));
Daniel Dunbarc136e0c2008-09-26 04:12:28 +00003370
3371 if (AttrList)
Douglas Gregor758a8692009-06-17 21:51:59 +00003372 ProcessDeclAttributeList(TUScope, ObjCMethod, AttrList);
Mike Stump11289f42009-09-09 15:08:12 +00003373
Douglas Gregor87e92752010-12-21 17:34:17 +00003374 // Add the method now.
Craig Topperc3ec1492014-05-26 06:22:03 +00003375 const ObjCMethodDecl *PrevMethod = nullptr;
John McCalld2930c22011-07-22 02:45:48 +00003376 if (ObjCImplDecl *ImpDecl = dyn_cast<ObjCImplDecl>(ClassDecl)) {
Chris Lattnerda463fe2007-12-12 07:09:47 +00003377 if (MethodType == tok::minus) {
Argyrios Kyrtzidiscfbfe782009-06-30 02:36:12 +00003378 PrevMethod = ImpDecl->getInstanceMethod(Sel);
3379 ImpDecl->addInstanceMethod(ObjCMethod);
Chris Lattnerda463fe2007-12-12 07:09:47 +00003380 } else {
Argyrios Kyrtzidiscfbfe782009-06-30 02:36:12 +00003381 PrevMethod = ImpDecl->getClassMethod(Sel);
3382 ImpDecl->addClassMethod(ObjCMethod);
Chris Lattnerda463fe2007-12-12 07:09:47 +00003383 }
Douglas Gregor33823722011-06-11 01:09:30 +00003384
Douglas Gregor813a0662015-06-19 18:14:38 +00003385 // Merge information from the @interface declaration into the
3386 // @implementation.
3387 if (ObjCInterfaceDecl *IDecl = ImpDecl->getClassInterface()) {
3388 if (auto *IMD = IDecl->lookupMethod(ObjCMethod->getSelector(),
3389 ObjCMethod->isInstanceMethod())) {
3390 mergeInterfaceMethodToImpl(*this, ObjCMethod, IMD);
3391
3392 // Warn about defining -dealloc in a category.
3393 if (isa<ObjCCategoryImplDecl>(ImpDecl) && IMD->isOverriding() &&
3394 ObjCMethod->getSelector().getMethodFamily() == OMF_dealloc) {
3395 Diag(ObjCMethod->getLocation(), diag::warn_dealloc_in_category)
3396 << ObjCMethod->getDeclName();
3397 }
3398 }
Fariborz Jahanian7e350d22013-12-17 22:44:28 +00003399 }
Douglas Gregor87e92752010-12-21 17:34:17 +00003400 } else {
3401 cast<DeclContext>(ClassDecl)->addDecl(ObjCMethod);
Chris Lattnerda463fe2007-12-12 07:09:47 +00003402 }
John McCalld2930c22011-07-22 02:45:48 +00003403
Chris Lattnerda463fe2007-12-12 07:09:47 +00003404 if (PrevMethod) {
3405 // You can never have two method definitions with the same name.
Chris Lattner0369c572008-11-23 23:12:31 +00003406 Diag(ObjCMethod->getLocation(), diag::err_duplicate_method_decl)
Chris Lattnere4b95692008-11-24 03:33:13 +00003407 << ObjCMethod->getDeclName();
Chris Lattner0369c572008-11-23 23:12:31 +00003408 Diag(PrevMethod->getLocation(), diag::note_previous_declaration);
Fariborz Jahanian096f7c12013-05-13 17:27:00 +00003409 ObjCMethod->setInvalidDecl();
3410 return ObjCMethod;
Mike Stump11289f42009-09-09 15:08:12 +00003411 }
John McCall28a6aea2009-11-04 02:18:39 +00003412
Douglas Gregor33823722011-06-11 01:09:30 +00003413 // If this Objective-C method does not have a related result type, but we
3414 // are allowed to infer related result types, try to do so based on the
3415 // method family.
3416 ObjCInterfaceDecl *CurrentClass = dyn_cast<ObjCInterfaceDecl>(ClassDecl);
3417 if (!CurrentClass) {
3418 if (ObjCCategoryDecl *Cat = dyn_cast<ObjCCategoryDecl>(ClassDecl))
3419 CurrentClass = Cat->getClassInterface();
3420 else if (ObjCImplDecl *Impl = dyn_cast<ObjCImplDecl>(ClassDecl))
3421 CurrentClass = Impl->getClassInterface();
3422 else if (ObjCCategoryImplDecl *CatImpl
3423 = dyn_cast<ObjCCategoryImplDecl>(ClassDecl))
3424 CurrentClass = CatImpl->getClassInterface();
3425 }
John McCalld2930c22011-07-22 02:45:48 +00003426
Douglas Gregorbab8a962011-09-08 01:46:34 +00003427 ResultTypeCompatibilityKind RTC
3428 = CheckRelatedResultTypeCompatibility(*this, ObjCMethod, CurrentClass);
John McCalld2930c22011-07-22 02:45:48 +00003429
Argyrios Kyrtzidis08f96a92012-05-09 16:12:57 +00003430 CheckObjCMethodOverrides(ObjCMethod, CurrentClass, RTC);
John McCalld2930c22011-07-22 02:45:48 +00003431
John McCall31168b02011-06-15 23:02:42 +00003432 bool ARCError = false;
David Blaikiebbafb8a2012-03-11 07:00:24 +00003433 if (getLangOpts().ObjCAutoRefCount)
John McCalle48f3892013-04-04 01:38:37 +00003434 ARCError = CheckARCMethodDecl(ObjCMethod);
John McCall31168b02011-06-15 23:02:42 +00003435
Douglas Gregorbab8a962011-09-08 01:46:34 +00003436 // Infer the related result type when possible.
Argyrios Kyrtzidis08f96a92012-05-09 16:12:57 +00003437 if (!ARCError && RTC == Sema::RTC_Compatible &&
Douglas Gregorbab8a962011-09-08 01:46:34 +00003438 !ObjCMethod->hasRelatedResultType() &&
3439 LangOpts.ObjCInferRelatedResultType) {
Douglas Gregor33823722011-06-11 01:09:30 +00003440 bool InferRelatedResultType = false;
3441 switch (ObjCMethod->getMethodFamily()) {
3442 case OMF_None:
3443 case OMF_copy:
3444 case OMF_dealloc:
Nico Weber1fb82662011-08-28 22:35:17 +00003445 case OMF_finalize:
Douglas Gregor33823722011-06-11 01:09:30 +00003446 case OMF_mutableCopy:
3447 case OMF_release:
3448 case OMF_retainCount:
Fariborz Jahanian78e9deb2014-08-22 16:57:26 +00003449 case OMF_initialize:
Fariborz Jahanianb7a77362011-07-05 22:38:59 +00003450 case OMF_performSelector:
Douglas Gregor33823722011-06-11 01:09:30 +00003451 break;
3452
3453 case OMF_alloc:
3454 case OMF_new:
Fariborz Jahanian7a60b6d2015-04-16 18:38:44 +00003455 InferRelatedResultType = ObjCMethod->isClassMethod();
Douglas Gregor33823722011-06-11 01:09:30 +00003456 break;
3457
3458 case OMF_init:
3459 case OMF_autorelease:
3460 case OMF_retain:
3461 case OMF_self:
3462 InferRelatedResultType = ObjCMethod->isInstanceMethod();
3463 break;
3464 }
3465
Fariborz Jahanian7a60b6d2015-04-16 18:38:44 +00003466 if (InferRelatedResultType &&
3467 !ObjCMethod->getReturnType()->isObjCIndependentClassType())
Douglas Gregor33823722011-06-11 01:09:30 +00003468 ObjCMethod->SetRelatedResultType();
Douglas Gregor33823722011-06-11 01:09:30 +00003469 }
Dmitri Gribenkof26054f2012-07-11 21:38:39 +00003470
3471 ActOnDocumentableDecl(ObjCMethod);
3472
John McCall48871652010-08-21 09:40:31 +00003473 return ObjCMethod;
Chris Lattnerda463fe2007-12-12 07:09:47 +00003474}
3475
Chris Lattner438e5012008-12-17 07:13:27 +00003476bool Sema::CheckObjCDeclScope(Decl *D) {
Fariborz Jahanianf36734d2011-08-22 18:34:22 +00003477 // Following is also an error. But it is caused by a missing @end
3478 // and diagnostic is issued elsewhere.
Argyrios Kyrtzidis822c4332012-03-23 23:24:23 +00003479 if (isa<ObjCContainerDecl>(CurContext->getRedeclContext()))
Fariborz Jahanian8d382dc2011-08-22 15:54:49 +00003480 return false;
Argyrios Kyrtzidis822c4332012-03-23 23:24:23 +00003481
3482 // If we switched context to translation unit while we are still lexically in
3483 // an objc container, it means the parser missed emitting an error.
3484 if (isa<TranslationUnitDecl>(getCurLexicalContext()->getRedeclContext()))
3485 return false;
Fariborz Jahanian8d382dc2011-08-22 15:54:49 +00003486
Anders Carlssona6b508a2008-11-04 16:57:32 +00003487 Diag(D->getLocation(), diag::err_objc_decls_may_only_appear_in_global_scope);
3488 D->setInvalidDecl();
Mike Stump11289f42009-09-09 15:08:12 +00003489
Anders Carlssona6b508a2008-11-04 16:57:32 +00003490 return true;
3491}
Chris Lattner438e5012008-12-17 07:13:27 +00003492
James Dennett634962f2012-06-14 21:40:34 +00003493/// Called whenever \@defs(ClassName) is encountered in the source. Inserts the
Chris Lattner438e5012008-12-17 07:13:27 +00003494/// instance variables of ClassName into Decls.
John McCall48871652010-08-21 09:40:31 +00003495void Sema::ActOnDefs(Scope *S, Decl *TagD, SourceLocation DeclStart,
Chris Lattner438e5012008-12-17 07:13:27 +00003496 IdentifierInfo *ClassName,
Chris Lattner0e62c1c2011-07-23 10:55:15 +00003497 SmallVectorImpl<Decl*> &Decls) {
Chris Lattner438e5012008-12-17 07:13:27 +00003498 // Check that ClassName is a valid class
Douglas Gregorb2ccf012010-04-15 22:33:43 +00003499 ObjCInterfaceDecl *Class = getObjCInterfaceDecl(ClassName, DeclStart);
Chris Lattner438e5012008-12-17 07:13:27 +00003500 if (!Class) {
3501 Diag(DeclStart, diag::err_undef_interface) << ClassName;
3502 return;
3503 }
John McCall5fb5df92012-06-20 06:18:46 +00003504 if (LangOpts.ObjCRuntime.isNonFragile()) {
Fariborz Jahanianece1b2b2009-04-21 20:28:41 +00003505 Diag(DeclStart, diag::err_atdef_nonfragile_interface);
3506 return;
3507 }
Mike Stump11289f42009-09-09 15:08:12 +00003508
Chris Lattner438e5012008-12-17 07:13:27 +00003509 // Collect the instance variables
Jordy Rosea91768e2011-07-22 02:08:32 +00003510 SmallVector<const ObjCIvarDecl*, 32> Ivars;
Fariborz Jahaniana50b3a22010-08-20 21:21:08 +00003511 Context.DeepCollectObjCIvars(Class, true, Ivars);
Fariborz Jahanian7dae1142009-06-04 17:08:55 +00003512 // For each ivar, create a fresh ObjCAtDefsFieldDecl.
Fariborz Jahaniana50b3a22010-08-20 21:21:08 +00003513 for (unsigned i = 0; i < Ivars.size(); i++) {
Jordy Rosea91768e2011-07-22 02:08:32 +00003514 const FieldDecl* ID = cast<FieldDecl>(Ivars[i]);
John McCall48871652010-08-21 09:40:31 +00003515 RecordDecl *Record = dyn_cast<RecordDecl>(TagD);
Abramo Bagnaradff19302011-03-08 08:55:46 +00003516 Decl *FD = ObjCAtDefsFieldDecl::Create(Context, Record,
3517 /*FIXME: StartL=*/ID->getLocation(),
3518 ID->getLocation(),
Fariborz Jahanian7dae1142009-06-04 17:08:55 +00003519 ID->getIdentifier(), ID->getType(),
3520 ID->getBitWidth());
John McCall48871652010-08-21 09:40:31 +00003521 Decls.push_back(FD);
Fariborz Jahanian7dae1142009-06-04 17:08:55 +00003522 }
Mike Stump11289f42009-09-09 15:08:12 +00003523
Chris Lattner438e5012008-12-17 07:13:27 +00003524 // Introduce all of these fields into the appropriate scope.
Chris Lattner0e62c1c2011-07-23 10:55:15 +00003525 for (SmallVectorImpl<Decl*>::iterator D = Decls.begin();
Chris Lattner438e5012008-12-17 07:13:27 +00003526 D != Decls.end(); ++D) {
John McCall48871652010-08-21 09:40:31 +00003527 FieldDecl *FD = cast<FieldDecl>(*D);
David Blaikiebbafb8a2012-03-11 07:00:24 +00003528 if (getLangOpts().CPlusPlus)
Chris Lattner438e5012008-12-17 07:13:27 +00003529 PushOnScopeChains(cast<FieldDecl>(FD), S);
John McCall48871652010-08-21 09:40:31 +00003530 else if (RecordDecl *Record = dyn_cast<RecordDecl>(TagD))
Argyrios Kyrtzidiscfbfe782009-06-30 02:36:12 +00003531 Record->addDecl(FD);
Chris Lattner438e5012008-12-17 07:13:27 +00003532 }
3533}
3534
Douglas Gregorf3564192010-04-26 17:32:49 +00003535/// \brief Build a type-check a new Objective-C exception variable declaration.
Abramo Bagnaradff19302011-03-08 08:55:46 +00003536VarDecl *Sema::BuildObjCExceptionDecl(TypeSourceInfo *TInfo, QualType T,
3537 SourceLocation StartLoc,
3538 SourceLocation IdLoc,
3539 IdentifierInfo *Id,
Douglas Gregorf3564192010-04-26 17:32:49 +00003540 bool Invalid) {
3541 // ISO/IEC TR 18037 S6.7.3: "The type of an object with automatic storage
3542 // duration shall not be qualified by an address-space qualifier."
3543 // Since all parameters have automatic store duration, they can not have
3544 // an address space.
3545 if (T.getAddressSpace() != 0) {
Abramo Bagnaradff19302011-03-08 08:55:46 +00003546 Diag(IdLoc, diag::err_arg_with_address_space);
Douglas Gregorf3564192010-04-26 17:32:49 +00003547 Invalid = true;
3548 }
3549
3550 // An @catch parameter must be an unqualified object pointer type;
3551 // FIXME: Recover from "NSObject foo" by inserting the * in "NSObject *foo"?
3552 if (Invalid) {
3553 // Don't do any further checking.
Douglas Gregorf4e837f2010-04-26 17:57:08 +00003554 } else if (T->isDependentType()) {
3555 // Okay: we don't know what this type will instantiate to.
Douglas Gregorf3564192010-04-26 17:32:49 +00003556 } else if (!T->isObjCObjectPointerType()) {
3557 Invalid = true;
Abramo Bagnaradff19302011-03-08 08:55:46 +00003558 Diag(IdLoc ,diag::err_catch_param_not_objc_type);
Douglas Gregorf3564192010-04-26 17:32:49 +00003559 } else if (T->isObjCQualifiedIdType()) {
3560 Invalid = true;
Abramo Bagnaradff19302011-03-08 08:55:46 +00003561 Diag(IdLoc, diag::err_illegal_qualifiers_on_catch_parm);
Douglas Gregorf3564192010-04-26 17:32:49 +00003562 }
3563
Abramo Bagnaradff19302011-03-08 08:55:46 +00003564 VarDecl *New = VarDecl::Create(Context, CurContext, StartLoc, IdLoc, Id,
Rafael Espindola6ae7e502013-04-03 19:27:57 +00003565 T, TInfo, SC_None);
Douglas Gregor3f324d562010-05-03 18:51:14 +00003566 New->setExceptionVariable(true);
3567
Douglas Gregor8ca0c642011-12-10 01:22:52 +00003568 // In ARC, infer 'retaining' for variables of retainable type.
David Blaikiebbafb8a2012-03-11 07:00:24 +00003569 if (getLangOpts().ObjCAutoRefCount && inferObjCARCLifetime(New))
Douglas Gregor8ca0c642011-12-10 01:22:52 +00003570 Invalid = true;
3571
Douglas Gregorf3564192010-04-26 17:32:49 +00003572 if (Invalid)
3573 New->setInvalidDecl();
3574 return New;
3575}
3576
John McCall48871652010-08-21 09:40:31 +00003577Decl *Sema::ActOnObjCExceptionDecl(Scope *S, Declarator &D) {
Douglas Gregorf3564192010-04-26 17:32:49 +00003578 const DeclSpec &DS = D.getDeclSpec();
3579
3580 // We allow the "register" storage class on exception variables because
3581 // GCC did, but we drop it completely. Any other storage class is an error.
3582 if (DS.getStorageClassSpec() == DeclSpec::SCS_register) {
3583 Diag(DS.getStorageClassSpecLoc(), diag::warn_register_objc_catch_parm)
3584 << FixItHint::CreateRemoval(SourceRange(DS.getStorageClassSpecLoc()));
Richard Smithb4a9e862013-04-12 22:46:28 +00003585 } else if (DeclSpec::SCS SCS = DS.getStorageClassSpec()) {
Douglas Gregorf3564192010-04-26 17:32:49 +00003586 Diag(DS.getStorageClassSpecLoc(), diag::err_storage_spec_on_catch_parm)
Richard Smithb4a9e862013-04-12 22:46:28 +00003587 << DeclSpec::getSpecifierName(SCS);
3588 }
3589 if (DeclSpec::TSCS TSCS = D.getDeclSpec().getThreadStorageClassSpec())
3590 Diag(D.getDeclSpec().getThreadStorageClassSpecLoc(),
3591 diag::err_invalid_thread)
3592 << DeclSpec::getSpecifierName(TSCS);
Douglas Gregorf3564192010-04-26 17:32:49 +00003593 D.getMutableDeclSpec().ClearStorageClassSpecs();
3594
Richard Smithb1402ae2013-03-18 22:52:47 +00003595 DiagnoseFunctionSpecifiers(D.getDeclSpec());
Douglas Gregorf3564192010-04-26 17:32:49 +00003596
3597 // Check that there are no default arguments inside the type of this
3598 // exception object (C++ only).
David Blaikiebbafb8a2012-03-11 07:00:24 +00003599 if (getLangOpts().CPlusPlus)
Douglas Gregorf3564192010-04-26 17:32:49 +00003600 CheckExtraCXXDefaultArguments(D);
3601
Argyrios Kyrtzidisef7022f2011-06-28 03:01:15 +00003602 TypeSourceInfo *TInfo = GetTypeForDeclarator(D, S);
John McCall8cb7bdf2010-06-04 23:28:52 +00003603 QualType ExceptionType = TInfo->getType();
Douglas Gregorf3564192010-04-26 17:32:49 +00003604
Abramo Bagnaradff19302011-03-08 08:55:46 +00003605 VarDecl *New = BuildObjCExceptionDecl(TInfo, ExceptionType,
3606 D.getSourceRange().getBegin(),
3607 D.getIdentifierLoc(),
3608 D.getIdentifier(),
Douglas Gregorf3564192010-04-26 17:32:49 +00003609 D.isInvalidType());
3610
3611 // Parameter declarators cannot be qualified (C++ [dcl.meaning]p1).
3612 if (D.getCXXScopeSpec().isSet()) {
3613 Diag(D.getIdentifierLoc(), diag::err_qualified_objc_catch_parm)
3614 << D.getCXXScopeSpec().getRange();
3615 New->setInvalidDecl();
3616 }
3617
3618 // Add the parameter declaration into this scope.
John McCall48871652010-08-21 09:40:31 +00003619 S->AddDecl(New);
Douglas Gregorf3564192010-04-26 17:32:49 +00003620 if (D.getIdentifier())
3621 IdResolver.AddDecl(New);
3622
3623 ProcessDeclAttributes(S, New, D);
3624
3625 if (New->hasAttr<BlocksAttr>())
3626 Diag(New->getLocation(), diag::err_block_on_nonlocal);
John McCall48871652010-08-21 09:40:31 +00003627 return New;
Douglas Gregore11ee112010-04-23 23:01:43 +00003628}
Fariborz Jahanian38b77a92010-04-27 17:18:58 +00003629
3630/// CollectIvarsToConstructOrDestruct - Collect those ivars which require
Fariborz Jahanianc83726e2010-04-28 16:11:27 +00003631/// initialization.
Fariborz Jahaniana50b3a22010-08-20 21:21:08 +00003632void Sema::CollectIvarsToConstructOrDestruct(ObjCInterfaceDecl *OI,
Chris Lattner0e62c1c2011-07-23 10:55:15 +00003633 SmallVectorImpl<ObjCIvarDecl*> &Ivars) {
Fariborz Jahaniana50b3a22010-08-20 21:21:08 +00003634 for (ObjCIvarDecl *Iv = OI->all_declared_ivar_begin(); Iv;
3635 Iv= Iv->getNextIvar()) {
Fariborz Jahanian38b77a92010-04-27 17:18:58 +00003636 QualType QT = Context.getBaseElementType(Iv->getType());
Douglas Gregor527786e2010-05-20 02:24:22 +00003637 if (QT->isRecordType())
Fariborz Jahaniana50b3a22010-08-20 21:21:08 +00003638 Ivars.push_back(Iv);
Fariborz Jahanian38b77a92010-04-27 17:18:58 +00003639 }
3640}
Fariborz Jahanianc83726e2010-04-28 16:11:27 +00003641
Fariborz Jahanian6e7e8cc2010-07-22 18:24:20 +00003642void Sema::DiagnoseUseOfUnimplementedSelectors() {
Douglas Gregor72e357f2011-07-28 14:54:22 +00003643 // Load referenced selectors from the external source.
3644 if (ExternalSource) {
3645 SmallVector<std::pair<Selector, SourceLocation>, 4> Sels;
3646 ExternalSource->ReadReferencedSelectors(Sels);
3647 for (unsigned I = 0, N = Sels.size(); I != N; ++I)
3648 ReferencedSelectors[Sels[I].first] = Sels[I].second;
3649 }
3650
Fariborz Jahanianc9b7c202011-02-04 23:19:27 +00003651 // Warning will be issued only when selector table is
3652 // generated (which means there is at lease one implementation
3653 // in the TU). This is to match gcc's behavior.
3654 if (ReferencedSelectors.empty() ||
3655 !Context.AnyObjCImplementation())
Fariborz Jahanian6e7e8cc2010-07-22 18:24:20 +00003656 return;
Chandler Carruth12c8f652015-03-27 00:55:05 +00003657 for (auto &SelectorAndLocation : ReferencedSelectors) {
3658 Selector Sel = SelectorAndLocation.first;
3659 SourceLocation Loc = SelectorAndLocation.second;
Fariborz Jahanian6e7e8cc2010-07-22 18:24:20 +00003660 if (!LookupImplementedMethodInGlobalPool(Sel))
Chandler Carruth12c8f652015-03-27 00:55:05 +00003661 Diag(Loc, diag::warn_unimplemented_selector) << Sel;
Fariborz Jahanian6e7e8cc2010-07-22 18:24:20 +00003662 }
3663 return;
3664}
Fariborz Jahanian5e3429c2013-10-25 21:44:50 +00003665
3666ObjCIvarDecl *
3667Sema::GetIvarBackingPropertyAccessor(const ObjCMethodDecl *Method,
3668 const ObjCPropertyDecl *&PDecl) const {
Fariborz Jahanian1cc7ae12014-01-02 17:24:32 +00003669 if (Method->isClassMethod())
Craig Topperc3ec1492014-05-26 06:22:03 +00003670 return nullptr;
Fariborz Jahanian5e3429c2013-10-25 21:44:50 +00003671 const ObjCInterfaceDecl *IDecl = Method->getClassInterface();
3672 if (!IDecl)
Craig Topperc3ec1492014-05-26 06:22:03 +00003673 return nullptr;
Argyrios Kyrtzidis2080d902014-01-03 18:32:18 +00003674 Method = IDecl->lookupMethod(Method->getSelector(), /*isInstance=*/true,
3675 /*shallowCategoryLookup=*/false,
3676 /*followSuper=*/false);
Fariborz Jahanian5e3429c2013-10-25 21:44:50 +00003677 if (!Method || !Method->isPropertyAccessor())
Craig Topperc3ec1492014-05-26 06:22:03 +00003678 return nullptr;
Argyrios Kyrtzidis2080d902014-01-03 18:32:18 +00003679 if ((PDecl = Method->findPropertyDecl()))
Fariborz Jahanian122d94f2014-01-27 22:27:43 +00003680 if (ObjCIvarDecl *IV = PDecl->getPropertyIvarDecl()) {
3681 // property backing ivar must belong to property's class
3682 // or be a private ivar in class's implementation.
3683 // FIXME. fix the const-ness issue.
3684 IV = const_cast<ObjCInterfaceDecl *>(IDecl)->lookupInstanceVariable(
3685 IV->getIdentifier());
3686 return IV;
3687 }
Craig Topperc3ec1492014-05-26 06:22:03 +00003688 return nullptr;
Fariborz Jahanian5e3429c2013-10-25 21:44:50 +00003689}
3690
Argyrios Kyrtzidis2080d902014-01-03 18:32:18 +00003691namespace {
3692 /// Used by Sema::DiagnoseUnusedBackingIvarInAccessor to check if a property
3693 /// accessor references the backing ivar.
Argyrios Kyrtzidis98045c12014-01-03 19:53:09 +00003694 class UnusedBackingIvarChecker :
3695 public DataRecursiveASTVisitor<UnusedBackingIvarChecker> {
Argyrios Kyrtzidis2080d902014-01-03 18:32:18 +00003696 public:
3697 Sema &S;
3698 const ObjCMethodDecl *Method;
3699 const ObjCIvarDecl *IvarD;
3700 bool AccessedIvar;
3701 bool InvokedSelfMethod;
3702
3703 UnusedBackingIvarChecker(Sema &S, const ObjCMethodDecl *Method,
3704 const ObjCIvarDecl *IvarD)
3705 : S(S), Method(Method), IvarD(IvarD),
3706 AccessedIvar(false), InvokedSelfMethod(false) {
3707 assert(IvarD);
3708 }
3709
3710 bool VisitObjCIvarRefExpr(ObjCIvarRefExpr *E) {
3711 if (E->getDecl() == IvarD) {
3712 AccessedIvar = true;
3713 return false;
3714 }
3715 return true;
3716 }
3717
3718 bool VisitObjCMessageExpr(ObjCMessageExpr *E) {
3719 if (E->getReceiverKind() == ObjCMessageExpr::Instance &&
3720 S.isSelfExpr(E->getInstanceReceiver(), Method)) {
3721 InvokedSelfMethod = true;
3722 }
3723 return true;
3724 }
3725 };
Alexander Kornienkoab9db512015-06-22 23:07:51 +00003726}
Argyrios Kyrtzidis2080d902014-01-03 18:32:18 +00003727
3728void Sema::DiagnoseUnusedBackingIvarInAccessor(Scope *S,
3729 const ObjCImplementationDecl *ImplD) {
3730 if (S->hasUnrecoverableErrorOccurred())
Fariborz Jahanian5e3429c2013-10-25 21:44:50 +00003731 return;
Argyrios Kyrtzidis2080d902014-01-03 18:32:18 +00003732
Aaron Ballmanf26acce2014-03-13 19:50:17 +00003733 for (const auto *CurMethod : ImplD->instance_methods()) {
Argyrios Kyrtzidis2080d902014-01-03 18:32:18 +00003734 unsigned DIAG = diag::warn_unused_property_backing_ivar;
3735 SourceLocation Loc = CurMethod->getLocation();
Alp Tokerd4a3f0e2014-06-15 23:30:39 +00003736 if (Diags.isIgnored(DIAG, Loc))
Argyrios Kyrtzidis2080d902014-01-03 18:32:18 +00003737 continue;
3738
3739 const ObjCPropertyDecl *PDecl;
3740 const ObjCIvarDecl *IV = GetIvarBackingPropertyAccessor(CurMethod, PDecl);
3741 if (!IV)
3742 continue;
3743
3744 UnusedBackingIvarChecker Checker(*this, CurMethod, IV);
3745 Checker.TraverseStmt(CurMethod->getBody());
3746 if (Checker.AccessedIvar)
3747 continue;
3748
Fariborz Jahanian5b3105d2014-01-02 22:42:09 +00003749 // Do not issue this warning if backing ivar is used somewhere and accessor
Argyrios Kyrtzidis2080d902014-01-03 18:32:18 +00003750 // implementation makes a self call. This is to prevent false positive in
3751 // cases where the ivar is accessed by another method that the accessor
3752 // delegates to.
3753 if (!IV->isReferenced() || !Checker.InvokedSelfMethod) {
Argyrios Kyrtzidisd8a35322014-01-03 19:39:23 +00003754 Diag(Loc, DIAG) << IV;
Fariborz Jahanian5b3105d2014-01-02 22:42:09 +00003755 Diag(PDecl->getLocation(), diag::note_property_declare);
3756 }
Fariborz Jahanian5e3429c2013-10-25 21:44:50 +00003757 }
3758}