Nick Lewycky | c8a1569 | 2011-02-20 08:38:20 +0000 | [diff] [blame] | 1 | //===- Local.cpp - Unit tests for Local -----------------------------------===// |
| 2 | // |
Chandler Carruth | 2946cd7 | 2019-01-19 08:50:56 +0000 | [diff] [blame] | 3 | // Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. |
| 4 | // See https://llvm.org/LICENSE.txt for license information. |
| 5 | // SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception |
Nick Lewycky | c8a1569 | 2011-02-20 08:38:20 +0000 | [diff] [blame] | 6 | // |
| 7 | //===----------------------------------------------------------------------===// |
| 8 | |
David Blaikie | 31b98d2 | 2018-06-04 21:23:21 +0000 | [diff] [blame] | 9 | #include "llvm/Transforms/Utils/Local.h" |
Richard Trieu | 5f436fc | 2019-02-06 02:52:52 +0000 | [diff] [blame] | 10 | #include "llvm/Analysis/DomTreeUpdater.h" |
Chijun Sima | 21a8b60 | 2018-08-03 05:08:17 +0000 | [diff] [blame] | 11 | #include "llvm/Analysis/PostDominators.h" |
Reid Kleckner | 0fe506b | 2017-09-21 19:52:03 +0000 | [diff] [blame] | 12 | #include "llvm/AsmParser/Parser.h" |
Chandler Carruth | 9fb823b | 2013-01-02 11:36:10 +0000 | [diff] [blame] | 13 | #include "llvm/IR/BasicBlock.h" |
Reid Kleckner | 0fe506b | 2017-09-21 19:52:03 +0000 | [diff] [blame] | 14 | #include "llvm/IR/DIBuilder.h" |
Chandler Carruth | 9fb823b | 2013-01-02 11:36:10 +0000 | [diff] [blame] | 15 | #include "llvm/IR/IRBuilder.h" |
| 16 | #include "llvm/IR/Instructions.h" |
Reid Kleckner | 0fe506b | 2017-09-21 19:52:03 +0000 | [diff] [blame] | 17 | #include "llvm/IR/IntrinsicInst.h" |
Chandler Carruth | 9fb823b | 2013-01-02 11:36:10 +0000 | [diff] [blame] | 18 | #include "llvm/IR/LLVMContext.h" |
Vedant Kumar | 6379a62 | 2018-07-06 17:32:39 +0000 | [diff] [blame] | 19 | #include "llvm/IR/Verifier.h" |
Reid Kleckner | 0fe506b | 2017-09-21 19:52:03 +0000 | [diff] [blame] | 20 | #include "llvm/Support/SourceMgr.h" |
Chandler Carruth | aafe091 | 2012-06-29 12:38:19 +0000 | [diff] [blame] | 21 | #include "gtest/gtest.h" |
| 22 | |
Nick Lewycky | c8a1569 | 2011-02-20 08:38:20 +0000 | [diff] [blame] | 23 | using namespace llvm; |
| 24 | |
| 25 | TEST(Local, RecursivelyDeleteDeadPHINodes) { |
Mehdi Amini | 03b42e4 | 2016-04-14 21:59:01 +0000 | [diff] [blame] | 26 | LLVMContext C; |
Nick Lewycky | c8a1569 | 2011-02-20 08:38:20 +0000 | [diff] [blame] | 27 | |
| 28 | IRBuilder<> builder(C); |
| 29 | |
| 30 | // Make blocks |
| 31 | BasicBlock *bb0 = BasicBlock::Create(C); |
| 32 | BasicBlock *bb1 = BasicBlock::Create(C); |
| 33 | |
| 34 | builder.SetInsertPoint(bb0); |
Jay Foad | 5213134 | 2011-03-30 11:28:46 +0000 | [diff] [blame] | 35 | PHINode *phi = builder.CreatePHI(Type::getInt32Ty(C), 2); |
Nick Lewycky | c8a1569 | 2011-02-20 08:38:20 +0000 | [diff] [blame] | 36 | BranchInst *br0 = builder.CreateCondBr(builder.getTrue(), bb0, bb1); |
| 37 | |
| 38 | builder.SetInsertPoint(bb1); |
| 39 | BranchInst *br1 = builder.CreateBr(bb0); |
| 40 | |
| 41 | phi->addIncoming(phi, bb0); |
| 42 | phi->addIncoming(phi, bb1); |
| 43 | |
| 44 | // The PHI will be removed |
| 45 | EXPECT_TRUE(RecursivelyDeleteDeadPHINode(phi)); |
| 46 | |
| 47 | // Make sure the blocks only contain the branches |
| 48 | EXPECT_EQ(&bb0->front(), br0); |
| 49 | EXPECT_EQ(&bb1->front(), br1); |
| 50 | |
Nick Lewycky | 183c24c | 2011-02-20 18:05:56 +0000 | [diff] [blame] | 51 | builder.SetInsertPoint(bb0); |
Jay Foad | 5213134 | 2011-03-30 11:28:46 +0000 | [diff] [blame] | 52 | phi = builder.CreatePHI(Type::getInt32Ty(C), 0); |
Nick Lewycky | 183c24c | 2011-02-20 18:05:56 +0000 | [diff] [blame] | 53 | |
| 54 | EXPECT_TRUE(RecursivelyDeleteDeadPHINode(phi)); |
| 55 | |
Duncan Sands | 6dcd49b | 2011-02-21 16:27:36 +0000 | [diff] [blame] | 56 | builder.SetInsertPoint(bb0); |
Jay Foad | 5213134 | 2011-03-30 11:28:46 +0000 | [diff] [blame] | 57 | phi = builder.CreatePHI(Type::getInt32Ty(C), 0); |
Duncan Sands | 6dcd49b | 2011-02-21 16:27:36 +0000 | [diff] [blame] | 58 | builder.CreateAdd(phi, phi); |
| 59 | |
| 60 | EXPECT_TRUE(RecursivelyDeleteDeadPHINode(phi)); |
| 61 | |
Nick Lewycky | c8a1569 | 2011-02-20 08:38:20 +0000 | [diff] [blame] | 62 | bb0->dropAllReferences(); |
| 63 | bb1->dropAllReferences(); |
| 64 | delete bb0; |
| 65 | delete bb1; |
| 66 | } |
Benjamin Kramer | f175e04 | 2015-09-02 19:52:23 +0000 | [diff] [blame] | 67 | |
| 68 | TEST(Local, RemoveDuplicatePHINodes) { |
Mehdi Amini | 03b42e4 | 2016-04-14 21:59:01 +0000 | [diff] [blame] | 69 | LLVMContext C; |
Benjamin Kramer | f175e04 | 2015-09-02 19:52:23 +0000 | [diff] [blame] | 70 | IRBuilder<> B(C); |
| 71 | |
| 72 | std::unique_ptr<Function> F( |
| 73 | Function::Create(FunctionType::get(B.getVoidTy(), false), |
| 74 | GlobalValue::ExternalLinkage, "F")); |
| 75 | BasicBlock *Entry(BasicBlock::Create(C, "", F.get())); |
| 76 | BasicBlock *BB(BasicBlock::Create(C, "", F.get())); |
| 77 | BranchInst::Create(BB, Entry); |
| 78 | |
| 79 | B.SetInsertPoint(BB); |
| 80 | |
| 81 | AssertingVH<PHINode> P1 = B.CreatePHI(Type::getInt32Ty(C), 2); |
| 82 | P1->addIncoming(B.getInt32(42), Entry); |
| 83 | |
| 84 | PHINode *P2 = B.CreatePHI(Type::getInt32Ty(C), 2); |
| 85 | P2->addIncoming(B.getInt32(42), Entry); |
| 86 | |
| 87 | AssertingVH<PHINode> P3 = B.CreatePHI(Type::getInt32Ty(C), 2); |
| 88 | P3->addIncoming(B.getInt32(42), Entry); |
| 89 | P3->addIncoming(B.getInt32(23), BB); |
| 90 | |
| 91 | PHINode *P4 = B.CreatePHI(Type::getInt32Ty(C), 2); |
| 92 | P4->addIncoming(B.getInt32(42), Entry); |
| 93 | P4->addIncoming(B.getInt32(23), BB); |
| 94 | |
| 95 | P1->addIncoming(P3, BB); |
| 96 | P2->addIncoming(P4, BB); |
| 97 | BranchInst::Create(BB, BB); |
| 98 | |
| 99 | // Verify that we can eliminate PHIs that become duplicates after chaning PHIs |
| 100 | // downstream. |
| 101 | EXPECT_TRUE(EliminateDuplicatePHINodes(BB)); |
| 102 | EXPECT_EQ(3U, BB->size()); |
| 103 | } |
Reid Kleckner | 0fe506b | 2017-09-21 19:52:03 +0000 | [diff] [blame] | 104 | |
Matt Arsenault | 06dfbb5 | 2018-01-31 22:54:37 +0000 | [diff] [blame] | 105 | static std::unique_ptr<Module> parseIR(LLVMContext &C, const char *IR) { |
Reid Kleckner | 0fe506b | 2017-09-21 19:52:03 +0000 | [diff] [blame] | 106 | SMDiagnostic Err; |
| 107 | std::unique_ptr<Module> Mod = parseAssemblyString(IR, Err, C); |
| 108 | if (!Mod) |
| 109 | Err.print("UtilsTests", errs()); |
| 110 | return Mod; |
| 111 | } |
| 112 | |
| 113 | TEST(Local, ReplaceDbgDeclare) { |
| 114 | LLVMContext C; |
| 115 | |
| 116 | // Original C source to get debug info for a local variable: |
| 117 | // void f() { int x; } |
Vedant Kumar | 1425e04 | 2018-03-02 21:36:33 +0000 | [diff] [blame] | 118 | std::unique_ptr<Module> M = parseIR(C, |
| 119 | R"( |
| 120 | define void @f() !dbg !8 { |
| 121 | entry: |
| 122 | %x = alloca i32, align 4 |
| 123 | call void @llvm.dbg.declare(metadata i32* %x, metadata !11, metadata !DIExpression()), !dbg !13 |
| 124 | call void @llvm.dbg.declare(metadata i32* %x, metadata !11, metadata !DIExpression()), !dbg !13 |
| 125 | ret void, !dbg !14 |
| 126 | } |
| 127 | declare void @llvm.dbg.declare(metadata, metadata, metadata) |
| 128 | !llvm.dbg.cu = !{!0} |
| 129 | !llvm.module.flags = !{!3, !4} |
| 130 | !0 = distinct !DICompileUnit(language: DW_LANG_C99, file: !1, producer: "clang version 6.0.0", isOptimized: false, runtimeVersion: 0, emissionKind: FullDebug, enums: !2) |
| 131 | !1 = !DIFile(filename: "t2.c", directory: "foo") |
| 132 | !2 = !{} |
| 133 | !3 = !{i32 2, !"Dwarf Version", i32 4} |
| 134 | !4 = !{i32 2, !"Debug Info Version", i32 3} |
Shiva Chen | 2c86455 | 2018-05-09 02:40:45 +0000 | [diff] [blame] | 135 | !8 = distinct !DISubprogram(name: "f", scope: !1, file: !1, line: 1, type: !9, isLocal: false, isDefinition: true, scopeLine: 1, isOptimized: false, unit: !0, retainedNodes: !2) |
Vedant Kumar | 1425e04 | 2018-03-02 21:36:33 +0000 | [diff] [blame] | 136 | !9 = !DISubroutineType(types: !10) |
| 137 | !10 = !{null} |
| 138 | !11 = !DILocalVariable(name: "x", scope: !8, file: !1, line: 2, type: !12) |
| 139 | !12 = !DIBasicType(name: "int", size: 32, encoding: DW_ATE_signed) |
| 140 | !13 = !DILocation(line: 2, column: 7, scope: !8) |
| 141 | !14 = !DILocation(line: 3, column: 1, scope: !8) |
| 142 | )"); |
Reid Kleckner | 0fe506b | 2017-09-21 19:52:03 +0000 | [diff] [blame] | 143 | auto *GV = M->getNamedValue("f"); |
| 144 | ASSERT_TRUE(GV); |
| 145 | auto *F = dyn_cast<Function>(GV); |
| 146 | ASSERT_TRUE(F); |
| 147 | Instruction *Inst = &F->front().front(); |
| 148 | auto *AI = dyn_cast<AllocaInst>(Inst); |
| 149 | ASSERT_TRUE(AI); |
| 150 | Inst = Inst->getNextNode()->getNextNode(); |
| 151 | ASSERT_TRUE(Inst); |
| 152 | auto *DII = dyn_cast<DbgDeclareInst>(Inst); |
| 153 | ASSERT_TRUE(DII); |
| 154 | Value *NewBase = Constant::getNullValue(Type::getInt32PtrTy(C)); |
| 155 | DIBuilder DIB(*M); |
Adrian Prantl | d131701 | 2017-12-08 21:58:18 +0000 | [diff] [blame] | 156 | replaceDbgDeclare(AI, NewBase, DII, DIB, DIExpression::NoDeref, 0, |
| 157 | DIExpression::NoDeref); |
Reid Kleckner | 0fe506b | 2017-09-21 19:52:03 +0000 | [diff] [blame] | 158 | |
| 159 | // There should be exactly two dbg.declares. |
| 160 | int Declares = 0; |
| 161 | for (const Instruction &I : F->front()) |
| 162 | if (isa<DbgDeclareInst>(I)) |
| 163 | Declares++; |
| 164 | EXPECT_EQ(2, Declares); |
| 165 | } |
Balaram Makam | 9ee942f | 2017-10-26 15:04:53 +0000 | [diff] [blame] | 166 | |
| 167 | /// Build the dominator tree for the function and run the Test. |
| 168 | static void runWithDomTree( |
| 169 | Module &M, StringRef FuncName, |
| 170 | function_ref<void(Function &F, DominatorTree *DT)> Test) { |
| 171 | auto *F = M.getFunction(FuncName); |
| 172 | ASSERT_NE(F, nullptr) << "Could not find " << FuncName; |
| 173 | // Compute the dominator tree for the function. |
| 174 | DominatorTree DT(*F); |
| 175 | Test(*F, &DT); |
| 176 | } |
| 177 | |
| 178 | TEST(Local, MergeBasicBlockIntoOnlyPred) { |
| 179 | LLVMContext C; |
Chijun Sima | 21a8b60 | 2018-08-03 05:08:17 +0000 | [diff] [blame] | 180 | std::unique_ptr<Module> M; |
| 181 | auto resetIR = [&]() { |
| 182 | M = parseIR(C, |
| 183 | R"( |
Vedant Kumar | 1425e04 | 2018-03-02 21:36:33 +0000 | [diff] [blame] | 184 | define i32 @f(i8* %str) { |
| 185 | entry: |
| 186 | br label %bb2.i |
| 187 | bb2.i: ; preds = %bb4.i, %entry |
| 188 | br i1 false, label %bb4.i, label %base2flt.exit204 |
| 189 | bb4.i: ; preds = %bb2.i |
| 190 | br i1 false, label %base2flt.exit204, label %bb2.i |
| 191 | bb10.i196.bb7.i197_crit_edge: ; No predecessors! |
| 192 | br label %bb7.i197 |
| 193 | bb7.i197: ; preds = %bb10.i196.bb7.i197_crit_edge |
| 194 | %.reg2mem.0 = phi i32 [ %.reg2mem.0, %bb10.i196.bb7.i197_crit_edge ] |
| 195 | br i1 undef, label %base2flt.exit204, label %base2flt.exit204 |
| 196 | base2flt.exit204: ; preds = %bb7.i197, %bb7.i197, %bb2.i, %bb4.i |
| 197 | ret i32 0 |
| 198 | } |
| 199 | )"); |
Chijun Sima | 21a8b60 | 2018-08-03 05:08:17 +0000 | [diff] [blame] | 200 | }; |
| 201 | |
| 202 | auto resetIRReplaceEntry = [&]() { |
| 203 | M = parseIR(C, |
| 204 | R"( |
| 205 | define i32 @f() { |
| 206 | entry: |
| 207 | br label %bb2.i |
| 208 | bb2.i: ; preds = %entry |
| 209 | ret i32 0 |
| 210 | } |
| 211 | )"); |
| 212 | }; |
| 213 | |
| 214 | auto Test = [&](Function &F, DomTreeUpdater &DTU) { |
| 215 | for (Function::iterator I = F.begin(), E = F.end(); I != E;) { |
| 216 | BasicBlock *BB = &*I++; |
| 217 | BasicBlock *SinglePred = BB->getSinglePredecessor(); |
| 218 | if (!SinglePred || SinglePred == BB || BB->hasAddressTaken()) |
| 219 | continue; |
| 220 | BranchInst *Term = dyn_cast<BranchInst>(SinglePred->getTerminator()); |
| 221 | if (Term && !Term->isConditional()) |
| 222 | MergeBasicBlockIntoOnlyPred(BB, &DTU); |
| 223 | } |
Simon Pilgrim | 5ea1b32 | 2018-09-16 12:30:41 +0000 | [diff] [blame] | 224 | if (DTU.hasDomTree()) { |
Chijun Sima | 21a8b60 | 2018-08-03 05:08:17 +0000 | [diff] [blame] | 225 | EXPECT_TRUE(DTU.getDomTree().verify()); |
Simon Pilgrim | 5ea1b32 | 2018-09-16 12:30:41 +0000 | [diff] [blame] | 226 | } |
| 227 | if (DTU.hasPostDomTree()) { |
Chijun Sima | 21a8b60 | 2018-08-03 05:08:17 +0000 | [diff] [blame] | 228 | EXPECT_TRUE(DTU.getPostDomTree().verify()); |
Simon Pilgrim | 5ea1b32 | 2018-09-16 12:30:41 +0000 | [diff] [blame] | 229 | } |
Chijun Sima | 21a8b60 | 2018-08-03 05:08:17 +0000 | [diff] [blame] | 230 | }; |
| 231 | |
| 232 | // Test MergeBasicBlockIntoOnlyPred working under Eager UpdateStrategy with |
| 233 | // both DT and PDT. |
| 234 | resetIR(); |
| 235 | runWithDomTree(*M, "f", [&](Function &F, DominatorTree *DT) { |
| 236 | PostDominatorTree PDT = PostDominatorTree(F); |
| 237 | DomTreeUpdater DTU(*DT, PDT, DomTreeUpdater::UpdateStrategy::Eager); |
| 238 | Test(F, DTU); |
| 239 | }); |
| 240 | |
| 241 | // Test MergeBasicBlockIntoOnlyPred working under Eager UpdateStrategy with |
| 242 | // DT. |
| 243 | resetIR(); |
| 244 | runWithDomTree(*M, "f", [&](Function &F, DominatorTree *DT) { |
| 245 | DomTreeUpdater DTU(*DT, DomTreeUpdater::UpdateStrategy::Eager); |
| 246 | Test(F, DTU); |
| 247 | }); |
| 248 | |
| 249 | // Test MergeBasicBlockIntoOnlyPred working under Eager UpdateStrategy with |
| 250 | // PDT. |
| 251 | resetIR(); |
| 252 | runWithDomTree(*M, "f", [&](Function &F, DominatorTree *DT) { |
| 253 | PostDominatorTree PDT = PostDominatorTree(F); |
| 254 | DomTreeUpdater DTU(PDT, DomTreeUpdater::UpdateStrategy::Eager); |
| 255 | Test(F, DTU); |
| 256 | }); |
| 257 | |
| 258 | // Test MergeBasicBlockIntoOnlyPred working under Lazy UpdateStrategy with |
| 259 | // both DT and PDT. |
| 260 | resetIR(); |
| 261 | runWithDomTree(*M, "f", [&](Function &F, DominatorTree *DT) { |
| 262 | PostDominatorTree PDT = PostDominatorTree(F); |
| 263 | DomTreeUpdater DTU(*DT, PDT, DomTreeUpdater::UpdateStrategy::Lazy); |
| 264 | Test(F, DTU); |
| 265 | }); |
| 266 | |
| 267 | // Test MergeBasicBlockIntoOnlyPred working under Lazy UpdateStrategy with |
| 268 | // PDT. |
| 269 | resetIR(); |
| 270 | runWithDomTree(*M, "f", [&](Function &F, DominatorTree *DT) { |
| 271 | PostDominatorTree PDT = PostDominatorTree(F); |
| 272 | DomTreeUpdater DTU(PDT, DomTreeUpdater::UpdateStrategy::Lazy); |
| 273 | Test(F, DTU); |
| 274 | }); |
| 275 | |
| 276 | // Test MergeBasicBlockIntoOnlyPred working under Lazy UpdateStrategy with DT. |
| 277 | resetIR(); |
| 278 | runWithDomTree(*M, "f", [&](Function &F, DominatorTree *DT) { |
| 279 | DomTreeUpdater DTU(*DT, DomTreeUpdater::UpdateStrategy::Lazy); |
| 280 | Test(F, DTU); |
| 281 | }); |
| 282 | |
| 283 | // Test MergeBasicBlockIntoOnlyPred working under Eager UpdateStrategy with |
| 284 | // both DT and PDT. |
| 285 | resetIRReplaceEntry(); |
| 286 | runWithDomTree(*M, "f", [&](Function &F, DominatorTree *DT) { |
| 287 | PostDominatorTree PDT = PostDominatorTree(F); |
| 288 | DomTreeUpdater DTU(*DT, PDT, DomTreeUpdater::UpdateStrategy::Eager); |
| 289 | Test(F, DTU); |
| 290 | }); |
| 291 | |
| 292 | // Test MergeBasicBlockIntoOnlyPred working under Eager UpdateStrategy with |
| 293 | // DT. |
| 294 | resetIRReplaceEntry(); |
| 295 | runWithDomTree(*M, "f", [&](Function &F, DominatorTree *DT) { |
| 296 | DomTreeUpdater DTU(*DT, DomTreeUpdater::UpdateStrategy::Eager); |
| 297 | Test(F, DTU); |
| 298 | }); |
| 299 | |
| 300 | // Test MergeBasicBlockIntoOnlyPred working under Eager UpdateStrategy with |
| 301 | // PDT. |
| 302 | resetIRReplaceEntry(); |
| 303 | runWithDomTree(*M, "f", [&](Function &F, DominatorTree *DT) { |
| 304 | PostDominatorTree PDT = PostDominatorTree(F); |
| 305 | DomTreeUpdater DTU(PDT, DomTreeUpdater::UpdateStrategy::Eager); |
| 306 | Test(F, DTU); |
| 307 | }); |
| 308 | |
| 309 | // Test MergeBasicBlockIntoOnlyPred working under Lazy UpdateStrategy with |
| 310 | // both DT and PDT. |
| 311 | resetIRReplaceEntry(); |
| 312 | runWithDomTree(*M, "f", [&](Function &F, DominatorTree *DT) { |
| 313 | PostDominatorTree PDT = PostDominatorTree(F); |
| 314 | DomTreeUpdater DTU(*DT, PDT, DomTreeUpdater::UpdateStrategy::Lazy); |
| 315 | Test(F, DTU); |
| 316 | }); |
| 317 | |
| 318 | // Test MergeBasicBlockIntoOnlyPred working under Lazy UpdateStrategy with |
| 319 | // PDT. |
| 320 | resetIRReplaceEntry(); |
| 321 | runWithDomTree(*M, "f", [&](Function &F, DominatorTree *DT) { |
| 322 | PostDominatorTree PDT = PostDominatorTree(F); |
| 323 | DomTreeUpdater DTU(PDT, DomTreeUpdater::UpdateStrategy::Lazy); |
| 324 | Test(F, DTU); |
| 325 | }); |
| 326 | |
| 327 | // Test MergeBasicBlockIntoOnlyPred working under Lazy UpdateStrategy with DT. |
| 328 | resetIRReplaceEntry(); |
| 329 | runWithDomTree(*M, "f", [&](Function &F, DominatorTree *DT) { |
| 330 | DomTreeUpdater DTU(*DT, DomTreeUpdater::UpdateStrategy::Lazy); |
| 331 | Test(F, DTU); |
| 332 | }); |
Balaram Makam | 9ee942f | 2017-10-26 15:04:53 +0000 | [diff] [blame] | 333 | } |
Matt Arsenault | 0cfebd9 | 2018-01-17 16:27:17 +0000 | [diff] [blame] | 334 | |
| 335 | TEST(Local, ConstantFoldTerminator) { |
| 336 | LLVMContext C; |
| 337 | |
Vedant Kumar | 1425e04 | 2018-03-02 21:36:33 +0000 | [diff] [blame] | 338 | std::unique_ptr<Module> M = parseIR(C, |
| 339 | R"( |
| 340 | define void @br_same_dest() { |
| 341 | entry: |
| 342 | br i1 false, label %bb0, label %bb0 |
| 343 | bb0: |
| 344 | ret void |
| 345 | } |
| 346 | |
| 347 | define void @br_different_dest() { |
| 348 | entry: |
| 349 | br i1 true, label %bb0, label %bb1 |
| 350 | bb0: |
| 351 | br label %exit |
| 352 | bb1: |
| 353 | br label %exit |
| 354 | exit: |
| 355 | ret void |
| 356 | } |
| 357 | |
| 358 | define void @switch_2_different_dest() { |
| 359 | entry: |
| 360 | switch i32 0, label %default [ i32 0, label %bb0 ] |
| 361 | default: |
| 362 | ret void |
| 363 | bb0: |
| 364 | ret void |
| 365 | } |
| 366 | define void @switch_2_different_dest_default() { |
| 367 | entry: |
| 368 | switch i32 1, label %default [ i32 0, label %bb0 ] |
| 369 | default: |
| 370 | ret void |
| 371 | bb0: |
| 372 | ret void |
| 373 | } |
| 374 | define void @switch_3_different_dest() { |
| 375 | entry: |
| 376 | switch i32 0, label %default [ i32 0, label %bb0 |
| 377 | i32 1, label %bb1 ] |
| 378 | default: |
| 379 | ret void |
| 380 | bb0: |
| 381 | ret void |
| 382 | bb1: |
| 383 | ret void |
| 384 | } |
| 385 | |
| 386 | define void @switch_variable_2_default_dest(i32 %arg) { |
| 387 | entry: |
| 388 | switch i32 %arg, label %default [ i32 0, label %default ] |
| 389 | default: |
| 390 | ret void |
| 391 | } |
| 392 | |
| 393 | define void @switch_constant_2_default_dest() { |
| 394 | entry: |
| 395 | switch i32 1, label %default [ i32 0, label %default ] |
| 396 | default: |
| 397 | ret void |
| 398 | } |
| 399 | |
| 400 | define void @switch_constant_3_repeated_dest() { |
| 401 | entry: |
| 402 | switch i32 0, label %default [ i32 0, label %bb0 |
| 403 | i32 1, label %bb0 ] |
| 404 | bb0: |
| 405 | ret void |
| 406 | default: |
| 407 | ret void |
| 408 | } |
| 409 | |
| 410 | define void @indirectbr() { |
| 411 | entry: |
| 412 | indirectbr i8* blockaddress(@indirectbr, %bb0), [label %bb0, label %bb1] |
| 413 | bb0: |
| 414 | ret void |
| 415 | bb1: |
| 416 | ret void |
| 417 | } |
| 418 | |
| 419 | define void @indirectbr_repeated() { |
| 420 | entry: |
| 421 | indirectbr i8* blockaddress(@indirectbr_repeated, %bb0), [label %bb0, label %bb0] |
| 422 | bb0: |
| 423 | ret void |
| 424 | } |
| 425 | |
| 426 | define void @indirectbr_unreachable() { |
| 427 | entry: |
| 428 | indirectbr i8* blockaddress(@indirectbr_unreachable, %bb0), [label %bb1] |
| 429 | bb0: |
| 430 | ret void |
| 431 | bb1: |
| 432 | ret void |
| 433 | } |
| 434 | )"); |
Matt Arsenault | 0cfebd9 | 2018-01-17 16:27:17 +0000 | [diff] [blame] | 435 | |
Chijun Sima | 21a8b60 | 2018-08-03 05:08:17 +0000 | [diff] [blame] | 436 | auto CFAllTerminatorsEager = [&](Function &F, DominatorTree *DT) { |
| 437 | PostDominatorTree PDT = PostDominatorTree(F); |
| 438 | DomTreeUpdater DTU(*DT, PDT, DomTreeUpdater::UpdateStrategy::Eager); |
Matt Arsenault | 0cfebd9 | 2018-01-17 16:27:17 +0000 | [diff] [blame] | 439 | for (Function::iterator I = F.begin(), E = F.end(); I != E;) { |
| 440 | BasicBlock *BB = &*I++; |
Chijun Sima | 21a8b60 | 2018-08-03 05:08:17 +0000 | [diff] [blame] | 441 | ConstantFoldTerminator(BB, true, nullptr, &DTU); |
Matt Arsenault | 0cfebd9 | 2018-01-17 16:27:17 +0000 | [diff] [blame] | 442 | } |
| 443 | |
Chijun Sima | 21a8b60 | 2018-08-03 05:08:17 +0000 | [diff] [blame] | 444 | EXPECT_TRUE(DTU.getDomTree().verify()); |
| 445 | EXPECT_TRUE(DTU.getPostDomTree().verify()); |
Matt Arsenault | 0cfebd9 | 2018-01-17 16:27:17 +0000 | [diff] [blame] | 446 | }; |
| 447 | |
Chijun Sima | 21a8b60 | 2018-08-03 05:08:17 +0000 | [diff] [blame] | 448 | auto CFAllTerminatorsLazy = [&](Function &F, DominatorTree *DT) { |
| 449 | PostDominatorTree PDT = PostDominatorTree(F); |
| 450 | DomTreeUpdater DTU(*DT, PDT, DomTreeUpdater::UpdateStrategy::Lazy); |
| 451 | for (Function::iterator I = F.begin(), E = F.end(); I != E;) { |
| 452 | BasicBlock *BB = &*I++; |
| 453 | ConstantFoldTerminator(BB, true, nullptr, &DTU); |
| 454 | } |
| 455 | |
| 456 | EXPECT_TRUE(DTU.getDomTree().verify()); |
| 457 | EXPECT_TRUE(DTU.getPostDomTree().verify()); |
| 458 | }; |
| 459 | |
| 460 | // Test ConstantFoldTerminator under Eager UpdateStrategy. |
| 461 | runWithDomTree(*M, "br_same_dest", CFAllTerminatorsEager); |
| 462 | runWithDomTree(*M, "br_different_dest", CFAllTerminatorsEager); |
| 463 | runWithDomTree(*M, "switch_2_different_dest", CFAllTerminatorsEager); |
| 464 | runWithDomTree(*M, "switch_2_different_dest_default", CFAllTerminatorsEager); |
| 465 | runWithDomTree(*M, "switch_3_different_dest", CFAllTerminatorsEager); |
| 466 | runWithDomTree(*M, "switch_variable_2_default_dest", CFAllTerminatorsEager); |
| 467 | runWithDomTree(*M, "switch_constant_2_default_dest", CFAllTerminatorsEager); |
| 468 | runWithDomTree(*M, "switch_constant_3_repeated_dest", CFAllTerminatorsEager); |
| 469 | runWithDomTree(*M, "indirectbr", CFAllTerminatorsEager); |
| 470 | runWithDomTree(*M, "indirectbr_repeated", CFAllTerminatorsEager); |
| 471 | runWithDomTree(*M, "indirectbr_unreachable", CFAllTerminatorsEager); |
| 472 | |
| 473 | // Test ConstantFoldTerminator under Lazy UpdateStrategy. |
| 474 | runWithDomTree(*M, "br_same_dest", CFAllTerminatorsLazy); |
| 475 | runWithDomTree(*M, "br_different_dest", CFAllTerminatorsLazy); |
| 476 | runWithDomTree(*M, "switch_2_different_dest", CFAllTerminatorsLazy); |
| 477 | runWithDomTree(*M, "switch_2_different_dest_default", CFAllTerminatorsLazy); |
| 478 | runWithDomTree(*M, "switch_3_different_dest", CFAllTerminatorsLazy); |
| 479 | runWithDomTree(*M, "switch_variable_2_default_dest", CFAllTerminatorsLazy); |
| 480 | runWithDomTree(*M, "switch_constant_2_default_dest", CFAllTerminatorsLazy); |
| 481 | runWithDomTree(*M, "switch_constant_3_repeated_dest", CFAllTerminatorsLazy); |
| 482 | runWithDomTree(*M, "indirectbr", CFAllTerminatorsLazy); |
| 483 | runWithDomTree(*M, "indirectbr_repeated", CFAllTerminatorsLazy); |
| 484 | runWithDomTree(*M, "indirectbr_unreachable", CFAllTerminatorsLazy); |
Matt Arsenault | 0cfebd9 | 2018-01-17 16:27:17 +0000 | [diff] [blame] | 485 | } |
Vedant Kumar | 334fa57 | 2018-03-02 21:36:35 +0000 | [diff] [blame] | 486 | |
Vedant Kumar | f69baf6 | 2018-03-02 22:46:48 +0000 | [diff] [blame] | 487 | struct SalvageDebugInfoTest : ::testing::Test { |
Vedant Kumar | 334fa57 | 2018-03-02 21:36:35 +0000 | [diff] [blame] | 488 | LLVMContext C; |
Vedant Kumar | f69baf6 | 2018-03-02 22:46:48 +0000 | [diff] [blame] | 489 | std::unique_ptr<Module> M; |
| 490 | Function *F = nullptr; |
Vedant Kumar | 334fa57 | 2018-03-02 21:36:35 +0000 | [diff] [blame] | 491 | |
Vedant Kumar | f69baf6 | 2018-03-02 22:46:48 +0000 | [diff] [blame] | 492 | void SetUp() { |
| 493 | M = parseIR(C, |
| 494 | R"( |
Vedant Kumar | 334fa57 | 2018-03-02 21:36:35 +0000 | [diff] [blame] | 495 | define void @f() !dbg !8 { |
| 496 | entry: |
| 497 | %x = add i32 0, 1 |
| 498 | %y = add i32 %x, 2 |
| 499 | call void @llvm.dbg.value(metadata i32 %x, metadata !11, metadata !DIExpression()), !dbg !13 |
| 500 | call void @llvm.dbg.value(metadata i32 %y, metadata !11, metadata !DIExpression()), !dbg !13 |
| 501 | ret void, !dbg !14 |
| 502 | } |
| 503 | declare void @llvm.dbg.value(metadata, metadata, metadata) |
| 504 | !llvm.dbg.cu = !{!0} |
| 505 | !llvm.module.flags = !{!3, !4} |
| 506 | !0 = distinct !DICompileUnit(language: DW_LANG_C99, file: !1, producer: "clang version 6.0.0", isOptimized: false, runtimeVersion: 0, emissionKind: FullDebug, enums: !2) |
| 507 | !1 = !DIFile(filename: "t2.c", directory: "foo") |
| 508 | !2 = !{} |
| 509 | !3 = !{i32 2, !"Dwarf Version", i32 4} |
| 510 | !4 = !{i32 2, !"Debug Info Version", i32 3} |
Shiva Chen | 2c86455 | 2018-05-09 02:40:45 +0000 | [diff] [blame] | 511 | !8 = distinct !DISubprogram(name: "f", scope: !1, file: !1, line: 1, type: !9, isLocal: false, isDefinition: true, scopeLine: 1, isOptimized: false, unit: !0, retainedNodes: !2) |
Vedant Kumar | 334fa57 | 2018-03-02 21:36:35 +0000 | [diff] [blame] | 512 | !9 = !DISubroutineType(types: !10) |
| 513 | !10 = !{null} |
| 514 | !11 = !DILocalVariable(name: "x", scope: !8, file: !1, line: 2, type: !12) |
| 515 | !12 = !DIBasicType(name: "int", size: 32, encoding: DW_ATE_signed) |
| 516 | !13 = !DILocation(line: 2, column: 7, scope: !8) |
| 517 | !14 = !DILocation(line: 3, column: 1, scope: !8) |
| 518 | )"); |
Vedant Kumar | f69baf6 | 2018-03-02 22:46:48 +0000 | [diff] [blame] | 519 | |
| 520 | auto *GV = M->getNamedValue("f"); |
| 521 | ASSERT_TRUE(GV); |
| 522 | F = dyn_cast<Function>(GV); |
| 523 | ASSERT_TRUE(F); |
| 524 | } |
| 525 | |
| 526 | bool doesDebugValueDescribeX(const DbgValueInst &DI) { |
| 527 | const auto &CI = *cast<ConstantInt>(DI.getValue()); |
| 528 | if (CI.isZero()) |
| 529 | return DI.getExpression()->getElements().equals( |
| 530 | {dwarf::DW_OP_plus_uconst, 1, dwarf::DW_OP_stack_value}); |
| 531 | else if (CI.isOneValue()) |
| 532 | return DI.getExpression()->getElements().empty(); |
| 533 | return false; |
| 534 | } |
| 535 | |
| 536 | bool doesDebugValueDescribeY(const DbgValueInst &DI) { |
| 537 | const auto &CI = *cast<ConstantInt>(DI.getValue()); |
| 538 | if (CI.isZero()) |
| 539 | return DI.getExpression()->getElements().equals( |
| 540 | {dwarf::DW_OP_plus_uconst, 1, dwarf::DW_OP_plus_uconst, 2, |
| 541 | dwarf::DW_OP_stack_value}); |
| 542 | else if (CI.isOneValue()) |
| 543 | return DI.getExpression()->getElements().equals( |
| 544 | {dwarf::DW_OP_plus_uconst, 2, dwarf::DW_OP_stack_value}); |
| 545 | return false; |
| 546 | } |
| 547 | |
| 548 | void verifyDebugValuesAreSalvaged() { |
| 549 | // Check that the debug values for %x and %y are preserved. |
| 550 | bool FoundX = false; |
| 551 | bool FoundY = false; |
| 552 | for (const Instruction &I : F->front()) { |
| 553 | auto DI = dyn_cast<DbgValueInst>(&I); |
| 554 | if (!DI) { |
| 555 | // The function should only contain debug values and a terminator. |
Chandler Carruth | 9ae926b | 2018-08-26 09:51:22 +0000 | [diff] [blame] | 556 | ASSERT_TRUE(I.isTerminator()); |
Vedant Kumar | f69baf6 | 2018-03-02 22:46:48 +0000 | [diff] [blame] | 557 | continue; |
| 558 | } |
| 559 | EXPECT_EQ(DI->getVariable()->getName(), "x"); |
| 560 | FoundX |= doesDebugValueDescribeX(*DI); |
| 561 | FoundY |= doesDebugValueDescribeY(*DI); |
| 562 | } |
| 563 | ASSERT_TRUE(FoundX); |
| 564 | ASSERT_TRUE(FoundY); |
| 565 | } |
| 566 | }; |
| 567 | |
| 568 | TEST_F(SalvageDebugInfoTest, RecursiveInstDeletion) { |
Vedant Kumar | 334fa57 | 2018-03-02 21:36:35 +0000 | [diff] [blame] | 569 | Instruction *Inst = &F->front().front(); |
Vedant Kumar | f69baf6 | 2018-03-02 22:46:48 +0000 | [diff] [blame] | 570 | Inst = Inst->getNextNode(); // Get %y = add ... |
Vedant Kumar | 334fa57 | 2018-03-02 21:36:35 +0000 | [diff] [blame] | 571 | ASSERT_TRUE(Inst); |
| 572 | bool Deleted = RecursivelyDeleteTriviallyDeadInstructions(Inst); |
| 573 | ASSERT_TRUE(Deleted); |
Vedant Kumar | f69baf6 | 2018-03-02 22:46:48 +0000 | [diff] [blame] | 574 | verifyDebugValuesAreSalvaged(); |
| 575 | } |
Vedant Kumar | 334fa57 | 2018-03-02 21:36:35 +0000 | [diff] [blame] | 576 | |
Vedant Kumar | f69baf6 | 2018-03-02 22:46:48 +0000 | [diff] [blame] | 577 | TEST_F(SalvageDebugInfoTest, RecursiveBlockSimplification) { |
| 578 | BasicBlock *BB = &F->front(); |
| 579 | ASSERT_TRUE(BB); |
| 580 | bool Deleted = SimplifyInstructionsInBlock(BB); |
| 581 | ASSERT_TRUE(Deleted); |
| 582 | verifyDebugValuesAreSalvaged(); |
Vedant Kumar | 334fa57 | 2018-03-02 21:36:35 +0000 | [diff] [blame] | 583 | } |
Vedant Kumar | 6379a62 | 2018-07-06 17:32:39 +0000 | [diff] [blame] | 584 | |
Anastasis Grammenos | 52d5283 | 2018-08-07 20:21:56 +0000 | [diff] [blame] | 585 | TEST(Local, ChangeToUnreachable) { |
| 586 | LLVMContext Ctx; |
| 587 | |
| 588 | std::unique_ptr<Module> M = parseIR(Ctx, |
| 589 | R"( |
| 590 | define internal void @foo() !dbg !6 { |
| 591 | entry: |
| 592 | ret void, !dbg !8 |
| 593 | } |
| 594 | |
| 595 | !llvm.dbg.cu = !{!0} |
| 596 | !llvm.debugify = !{!3, !4} |
| 597 | !llvm.module.flags = !{!5} |
| 598 | |
| 599 | !0 = distinct !DICompileUnit(language: DW_LANG_C, file: !1, producer: "debugify", isOptimized: true, runtimeVersion: 0, emissionKind: FullDebug, enums: !2) |
| 600 | !1 = !DIFile(filename: "test.ll", directory: "/") |
| 601 | !2 = !{} |
| 602 | !3 = !{i32 1} |
| 603 | !4 = !{i32 0} |
| 604 | !5 = !{i32 2, !"Debug Info Version", i32 3} |
| 605 | !6 = distinct !DISubprogram(name: "foo", linkageName: "foo", scope: null, file: !1, line: 1, type: !7, isLocal: true, isDefinition: true, scopeLine: 1, isOptimized: true, unit: !0, retainedNodes: !2) |
| 606 | !7 = !DISubroutineType(types: !2) |
| 607 | !8 = !DILocation(line: 1, column: 1, scope: !6) |
| 608 | )"); |
| 609 | |
| 610 | bool BrokenDebugInfo = true; |
| 611 | verifyModule(*M, &errs(), &BrokenDebugInfo); |
| 612 | ASSERT_FALSE(BrokenDebugInfo); |
| 613 | |
| 614 | Function &F = *cast<Function>(M->getNamedValue("foo")); |
| 615 | |
| 616 | BasicBlock &BB = F.front(); |
| 617 | Instruction &A = BB.front(); |
| 618 | DebugLoc DLA = A.getDebugLoc(); |
| 619 | |
| 620 | ASSERT_TRUE(isa<ReturnInst>(&A)); |
| 621 | // One instruction should be affected. |
| 622 | EXPECT_EQ(changeToUnreachable(&A, /*UseLLVMTrap*/false), 1U); |
| 623 | |
| 624 | Instruction &B = BB.front(); |
| 625 | |
| 626 | // There should be an uncreachable instruction. |
| 627 | ASSERT_TRUE(isa<UnreachableInst>(&B)); |
| 628 | |
| 629 | DebugLoc DLB = B.getDebugLoc(); |
| 630 | EXPECT_EQ(DLA, DLB); |
| 631 | } |
| 632 | |
Vedant Kumar | 6379a62 | 2018-07-06 17:32:39 +0000 | [diff] [blame] | 633 | TEST(Local, ReplaceAllDbgUsesWith) { |
| 634 | using namespace llvm::dwarf; |
| 635 | |
| 636 | LLVMContext Ctx; |
| 637 | |
| 638 | // Note: The datalayout simulates Darwin/x86_64. |
| 639 | std::unique_ptr<Module> M = parseIR(Ctx, |
| 640 | R"( |
| 641 | target datalayout = "e-m:o-i63:64-f80:128-n8:16:32:64-S128" |
| 642 | |
| 643 | declare i32 @escape(i32) |
| 644 | |
| 645 | define void @f() !dbg !6 { |
| 646 | entry: |
| 647 | %a = add i32 0, 1, !dbg !15 |
| 648 | call void @llvm.dbg.value(metadata i32 %a, metadata !9, metadata !DIExpression()), !dbg !15 |
| 649 | |
| 650 | %b = add i64 0, 1, !dbg !16 |
| 651 | call void @llvm.dbg.value(metadata i64 %b, metadata !11, metadata !DIExpression()), !dbg !16 |
| 652 | call void @llvm.dbg.value(metadata i64 %b, metadata !11, metadata !DIExpression(DW_OP_lit0, DW_OP_mul)), !dbg !16 |
| 653 | call void @llvm.dbg.value(metadata i64 %b, metadata !11, metadata !DIExpression(DW_OP_lit0, DW_OP_mul, DW_OP_stack_value)), !dbg !16 |
| 654 | call void @llvm.dbg.value(metadata i64 %b, metadata !11, metadata !DIExpression(DW_OP_LLVM_fragment, 0, 8)), !dbg !16 |
| 655 | call void @llvm.dbg.value(metadata i64 %b, metadata !11, metadata !DIExpression(DW_OP_lit0, DW_OP_mul, DW_OP_LLVM_fragment, 0, 8)), !dbg !16 |
| 656 | call void @llvm.dbg.value(metadata i64 %b, metadata !11, metadata !DIExpression(DW_OP_lit0, DW_OP_mul, DW_OP_stack_value, DW_OP_LLVM_fragment, 0, 8)), !dbg !16 |
| 657 | |
| 658 | %c = inttoptr i64 0 to i64*, !dbg !17 |
| 659 | call void @llvm.dbg.declare(metadata i64* %c, metadata !13, metadata !DIExpression()), !dbg !17 |
| 660 | |
| 661 | %d = inttoptr i64 0 to i32*, !dbg !18 |
| 662 | call void @llvm.dbg.addr(metadata i32* %d, metadata !20, metadata !DIExpression()), !dbg !18 |
| 663 | |
| 664 | %e = add <2 x i16> zeroinitializer, zeroinitializer |
| 665 | call void @llvm.dbg.value(metadata <2 x i16> %e, metadata !14, metadata !DIExpression()), !dbg !18 |
| 666 | |
| 667 | %f = call i32 @escape(i32 0) |
| 668 | call void @llvm.dbg.value(metadata i32 %f, metadata !9, metadata !DIExpression()), !dbg !15 |
| 669 | |
| 670 | %barrier = call i32 @escape(i32 0) |
| 671 | |
| 672 | %g = call i32 @escape(i32 %f) |
| 673 | call void @llvm.dbg.value(metadata i32 %g, metadata !9, metadata !DIExpression()), !dbg !15 |
| 674 | |
| 675 | ret void, !dbg !19 |
| 676 | } |
| 677 | |
| 678 | declare void @llvm.dbg.addr(metadata, metadata, metadata) |
| 679 | declare void @llvm.dbg.declare(metadata, metadata, metadata) |
| 680 | declare void @llvm.dbg.value(metadata, metadata, metadata) |
| 681 | |
| 682 | !llvm.dbg.cu = !{!0} |
| 683 | !llvm.module.flags = !{!5} |
| 684 | |
| 685 | !0 = distinct !DICompileUnit(language: DW_LANG_C, file: !1, producer: "debugify", isOptimized: true, runtimeVersion: 0, emissionKind: FullDebug, enums: !2) |
| 686 | !1 = !DIFile(filename: "/Users/vsk/Desktop/foo.ll", directory: "/") |
| 687 | !2 = !{} |
| 688 | !5 = !{i32 2, !"Debug Info Version", i32 3} |
| 689 | !6 = distinct !DISubprogram(name: "f", linkageName: "f", scope: null, file: !1, line: 1, type: !7, isLocal: false, isDefinition: true, scopeLine: 1, isOptimized: true, unit: !0, retainedNodes: !8) |
| 690 | !7 = !DISubroutineType(types: !2) |
| 691 | !8 = !{!9, !11, !13, !14} |
| 692 | !9 = !DILocalVariable(name: "1", scope: !6, file: !1, line: 1, type: !10) |
| 693 | !10 = !DIBasicType(name: "ty32", size: 32, encoding: DW_ATE_signed) |
| 694 | !11 = !DILocalVariable(name: "2", scope: !6, file: !1, line: 2, type: !12) |
| 695 | !12 = !DIBasicType(name: "ty64", size: 64, encoding: DW_ATE_signed) |
| 696 | !13 = !DILocalVariable(name: "3", scope: !6, file: !1, line: 3, type: !12) |
| 697 | !14 = !DILocalVariable(name: "4", scope: !6, file: !1, line: 4, type: !10) |
| 698 | !15 = !DILocation(line: 1, column: 1, scope: !6) |
| 699 | !16 = !DILocation(line: 2, column: 1, scope: !6) |
| 700 | !17 = !DILocation(line: 3, column: 1, scope: !6) |
| 701 | !18 = !DILocation(line: 4, column: 1, scope: !6) |
| 702 | !19 = !DILocation(line: 5, column: 1, scope: !6) |
| 703 | !20 = !DILocalVariable(name: "5", scope: !6, file: !1, line: 5, type: !10) |
| 704 | )"); |
| 705 | |
| 706 | bool BrokenDebugInfo = true; |
| 707 | verifyModule(*M, &errs(), &BrokenDebugInfo); |
| 708 | ASSERT_FALSE(BrokenDebugInfo); |
| 709 | |
| 710 | Function &F = *cast<Function>(M->getNamedValue("f")); |
| 711 | DominatorTree DT{F}; |
| 712 | |
| 713 | BasicBlock &BB = F.front(); |
| 714 | Instruction &A = BB.front(); |
| 715 | Instruction &B = *A.getNextNonDebugInstruction(); |
| 716 | Instruction &C = *B.getNextNonDebugInstruction(); |
| 717 | Instruction &D = *C.getNextNonDebugInstruction(); |
| 718 | Instruction &E = *D.getNextNonDebugInstruction(); |
| 719 | Instruction &F_ = *E.getNextNonDebugInstruction(); |
| 720 | Instruction &Barrier = *F_.getNextNonDebugInstruction(); |
| 721 | Instruction &G = *Barrier.getNextNonDebugInstruction(); |
| 722 | |
| 723 | // Simulate i32 <-> i64* conversion. Expect no updates: the datalayout says |
| 724 | // pointers are 64 bits, so the conversion would be lossy. |
| 725 | EXPECT_FALSE(replaceAllDbgUsesWith(A, C, C, DT)); |
| 726 | EXPECT_FALSE(replaceAllDbgUsesWith(C, A, A, DT)); |
| 727 | |
| 728 | // Simulate i32 <-> <2 x i16> conversion. This is unsupported. |
| 729 | EXPECT_FALSE(replaceAllDbgUsesWith(E, A, A, DT)); |
| 730 | EXPECT_FALSE(replaceAllDbgUsesWith(A, E, E, DT)); |
| 731 | |
| 732 | // Simulate i32* <-> i64* conversion. |
| 733 | EXPECT_TRUE(replaceAllDbgUsesWith(D, C, C, DT)); |
| 734 | |
Hsiangkai Wang | ef72e48 | 2018-08-06 03:59:47 +0000 | [diff] [blame] | 735 | SmallVector<DbgVariableIntrinsic *, 2> CDbgVals; |
Vedant Kumar | 6379a62 | 2018-07-06 17:32:39 +0000 | [diff] [blame] | 736 | findDbgUsers(CDbgVals, &C); |
| 737 | EXPECT_EQ(2U, CDbgVals.size()); |
Hsiangkai Wang | ef72e48 | 2018-08-06 03:59:47 +0000 | [diff] [blame] | 738 | EXPECT_TRUE(any_of(CDbgVals, [](DbgVariableIntrinsic *DII) { |
Vedant Kumar | 6379a62 | 2018-07-06 17:32:39 +0000 | [diff] [blame] | 739 | return isa<DbgAddrIntrinsic>(DII); |
| 740 | })); |
Hsiangkai Wang | ef72e48 | 2018-08-06 03:59:47 +0000 | [diff] [blame] | 741 | EXPECT_TRUE(any_of(CDbgVals, [](DbgVariableIntrinsic *DII) { |
Vedant Kumar | 6379a62 | 2018-07-06 17:32:39 +0000 | [diff] [blame] | 742 | return isa<DbgDeclareInst>(DII); |
| 743 | })); |
| 744 | |
| 745 | EXPECT_TRUE(replaceAllDbgUsesWith(C, D, D, DT)); |
| 746 | |
Hsiangkai Wang | ef72e48 | 2018-08-06 03:59:47 +0000 | [diff] [blame] | 747 | SmallVector<DbgVariableIntrinsic *, 2> DDbgVals; |
Vedant Kumar | 6379a62 | 2018-07-06 17:32:39 +0000 | [diff] [blame] | 748 | findDbgUsers(DDbgVals, &D); |
| 749 | EXPECT_EQ(2U, DDbgVals.size()); |
Hsiangkai Wang | ef72e48 | 2018-08-06 03:59:47 +0000 | [diff] [blame] | 750 | EXPECT_TRUE(any_of(DDbgVals, [](DbgVariableIntrinsic *DII) { |
Vedant Kumar | 6379a62 | 2018-07-06 17:32:39 +0000 | [diff] [blame] | 751 | return isa<DbgAddrIntrinsic>(DII); |
| 752 | })); |
Hsiangkai Wang | ef72e48 | 2018-08-06 03:59:47 +0000 | [diff] [blame] | 753 | EXPECT_TRUE(any_of(DDbgVals, [](DbgVariableIntrinsic *DII) { |
Vedant Kumar | 6379a62 | 2018-07-06 17:32:39 +0000 | [diff] [blame] | 754 | return isa<DbgDeclareInst>(DII); |
| 755 | })); |
| 756 | |
| 757 | // Introduce a use-before-def. Check that the dbg.value for %a is salvaged. |
| 758 | EXPECT_TRUE(replaceAllDbgUsesWith(A, F_, F_, DT)); |
| 759 | |
| 760 | auto *ADbgVal = cast<DbgValueInst>(A.getNextNode()); |
| 761 | EXPECT_EQ(ConstantInt::get(A.getType(), 0), ADbgVal->getVariableLocation()); |
| 762 | |
| 763 | // Introduce a use-before-def. Check that the dbg.values for %f are deleted. |
| 764 | EXPECT_TRUE(replaceAllDbgUsesWith(F_, G, G, DT)); |
| 765 | |
| 766 | SmallVector<DbgValueInst *, 1> FDbgVals; |
| 767 | findDbgValues(FDbgVals, &F); |
| 768 | EXPECT_EQ(0U, FDbgVals.size()); |
| 769 | |
| 770 | // Simulate i32 -> i64 conversion to test sign-extension. Here are some |
| 771 | // interesting cases to handle: |
| 772 | // 1) debug user has empty DIExpression |
| 773 | // 2) debug user has non-empty, non-stack-value'd DIExpression |
| 774 | // 3) debug user has non-empty, stack-value'd DIExpression |
| 775 | // 4-6) like (1-3), but with a fragment |
| 776 | EXPECT_TRUE(replaceAllDbgUsesWith(B, A, A, DT)); |
| 777 | |
| 778 | SmallVector<DbgValueInst *, 8> ADbgVals; |
| 779 | findDbgValues(ADbgVals, &A); |
| 780 | EXPECT_EQ(6U, ADbgVals.size()); |
| 781 | |
| 782 | // Check that %a has a dbg.value with a DIExpression matching \p Ops. |
| 783 | auto hasADbgVal = [&](ArrayRef<uint64_t> Ops) { |
| 784 | return any_of(ADbgVals, [&](DbgValueInst *DVI) { |
| 785 | assert(DVI->getVariable()->getName() == "2"); |
| 786 | return DVI->getExpression()->getElements() == Ops; |
| 787 | }); |
| 788 | }; |
| 789 | |
| 790 | // Case 1: The original expr is empty, so no deref is needed. |
Markus Lavin | ad78768 | 2019-03-19 09:17:28 +0000 | [diff] [blame] | 791 | EXPECT_TRUE(hasADbgVal({DW_OP_dup, DW_OP_constu, 31, DW_OP_shr, DW_OP_lit0, |
| 792 | DW_OP_not, DW_OP_mul, DW_OP_or, DW_OP_stack_value})); |
Vedant Kumar | 6379a62 | 2018-07-06 17:32:39 +0000 | [diff] [blame] | 793 | |
| 794 | // Case 2: Perform an address calculation with the original expr, deref it, |
| 795 | // then sign-extend the result. |
Markus Lavin | ad78768 | 2019-03-19 09:17:28 +0000 | [diff] [blame] | 796 | EXPECT_TRUE(hasADbgVal({DW_OP_lit0, DW_OP_mul, DW_OP_deref, DW_OP_dup, |
| 797 | DW_OP_constu, 31, DW_OP_shr, DW_OP_lit0, DW_OP_not, |
| 798 | DW_OP_mul, DW_OP_or, DW_OP_stack_value})); |
Vedant Kumar | 6379a62 | 2018-07-06 17:32:39 +0000 | [diff] [blame] | 799 | |
| 800 | // Case 3: Insert the sign-extension logic before the DW_OP_stack_value. |
Markus Lavin | ad78768 | 2019-03-19 09:17:28 +0000 | [diff] [blame] | 801 | EXPECT_TRUE(hasADbgVal({DW_OP_lit0, DW_OP_mul, DW_OP_dup, DW_OP_constu, 31, |
| 802 | DW_OP_shr, DW_OP_lit0, DW_OP_not, DW_OP_mul, DW_OP_or, |
| 803 | DW_OP_stack_value})); |
Vedant Kumar | 6379a62 | 2018-07-06 17:32:39 +0000 | [diff] [blame] | 804 | |
| 805 | // Cases 4-6: Just like cases 1-3, but preserve the fragment at the end. |
Markus Lavin | ad78768 | 2019-03-19 09:17:28 +0000 | [diff] [blame] | 806 | EXPECT_TRUE(hasADbgVal({DW_OP_dup, DW_OP_constu, 31, DW_OP_shr, DW_OP_lit0, |
| 807 | DW_OP_not, DW_OP_mul, DW_OP_or, DW_OP_stack_value, |
| 808 | DW_OP_LLVM_fragment, 0, 8})); |
| 809 | EXPECT_TRUE( |
| 810 | hasADbgVal({DW_OP_lit0, DW_OP_mul, DW_OP_deref, DW_OP_dup, DW_OP_constu, |
| 811 | 31, DW_OP_shr, DW_OP_lit0, DW_OP_not, DW_OP_mul, DW_OP_or, |
| 812 | DW_OP_stack_value, DW_OP_LLVM_fragment, 0, 8})); |
| 813 | EXPECT_TRUE(hasADbgVal({DW_OP_lit0, DW_OP_mul, DW_OP_dup, DW_OP_constu, 31, |
| 814 | DW_OP_shr, DW_OP_lit0, DW_OP_not, DW_OP_mul, DW_OP_or, |
| 815 | DW_OP_stack_value, DW_OP_LLVM_fragment, 0, 8})); |
Vedant Kumar | 6379a62 | 2018-07-06 17:32:39 +0000 | [diff] [blame] | 816 | |
| 817 | verifyModule(*M, &errs(), &BrokenDebugInfo); |
| 818 | ASSERT_FALSE(BrokenDebugInfo); |
| 819 | } |
Chijun Sima | 21a8b60 | 2018-08-03 05:08:17 +0000 | [diff] [blame] | 820 | |
| 821 | TEST(Local, RemoveUnreachableBlocks) { |
| 822 | LLVMContext C; |
| 823 | |
| 824 | std::unique_ptr<Module> M = parseIR(C, |
| 825 | R"( |
| 826 | define void @br_simple() { |
| 827 | entry: |
| 828 | br label %bb0 |
| 829 | bb0: |
| 830 | ret void |
| 831 | bb1: |
| 832 | ret void |
| 833 | } |
| 834 | |
| 835 | define void @br_self_loop() { |
| 836 | entry: |
| 837 | br label %bb0 |
| 838 | bb0: |
| 839 | br i1 true, label %bb1, label %bb0 |
| 840 | bb1: |
| 841 | br i1 true, label %bb0, label %bb2 |
| 842 | bb2: |
| 843 | br label %bb2 |
| 844 | } |
| 845 | |
| 846 | define void @br_constant() { |
| 847 | entry: |
| 848 | br label %bb0 |
| 849 | bb0: |
| 850 | br i1 true, label %bb1, label %bb2 |
| 851 | bb1: |
| 852 | br i1 true, label %bb0, label %bb2 |
| 853 | bb2: |
| 854 | br label %bb2 |
| 855 | } |
| 856 | |
| 857 | define void @br_loop() { |
| 858 | entry: |
| 859 | br label %bb0 |
| 860 | bb0: |
| 861 | br label %bb0 |
| 862 | bb1: |
| 863 | br label %bb2 |
| 864 | bb2: |
| 865 | br label %bb1 |
| 866 | } |
| 867 | )"); |
| 868 | |
| 869 | auto runEager = [&](Function &F, DominatorTree *DT) { |
| 870 | PostDominatorTree PDT = PostDominatorTree(F); |
| 871 | DomTreeUpdater DTU(*DT, PDT, DomTreeUpdater::UpdateStrategy::Eager); |
| 872 | removeUnreachableBlocks(F, nullptr, &DTU); |
| 873 | EXPECT_TRUE(DTU.getDomTree().verify()); |
| 874 | EXPECT_TRUE(DTU.getPostDomTree().verify()); |
| 875 | }; |
| 876 | |
| 877 | auto runLazy = [&](Function &F, DominatorTree *DT) { |
| 878 | PostDominatorTree PDT = PostDominatorTree(F); |
| 879 | DomTreeUpdater DTU(*DT, PDT, DomTreeUpdater::UpdateStrategy::Lazy); |
| 880 | removeUnreachableBlocks(F, nullptr, &DTU); |
| 881 | EXPECT_TRUE(DTU.getDomTree().verify()); |
| 882 | EXPECT_TRUE(DTU.getPostDomTree().verify()); |
| 883 | }; |
| 884 | |
| 885 | // Test removeUnreachableBlocks under Eager UpdateStrategy. |
| 886 | runWithDomTree(*M, "br_simple", runEager); |
| 887 | runWithDomTree(*M, "br_self_loop", runEager); |
| 888 | runWithDomTree(*M, "br_constant", runEager); |
| 889 | runWithDomTree(*M, "br_loop", runEager); |
| 890 | |
| 891 | // Test removeUnreachableBlocks under Lazy UpdateStrategy. |
| 892 | runWithDomTree(*M, "br_simple", runLazy); |
| 893 | runWithDomTree(*M, "br_self_loop", runLazy); |
| 894 | runWithDomTree(*M, "br_constant", runLazy); |
| 895 | runWithDomTree(*M, "br_loop", runLazy); |
Chijun Sima | 5304843 | 2018-08-03 12:45:29 +0000 | [diff] [blame] | 896 | |
| 897 | M = parseIR(C, |
| 898 | R"( |
| 899 | define void @f() { |
| 900 | entry: |
| 901 | ret void |
| 902 | bb0: |
| 903 | ret void |
| 904 | } |
| 905 | )"); |
| 906 | |
| 907 | auto checkRUBlocksRetVal = [&](Function &F, DominatorTree *DT) { |
| 908 | DomTreeUpdater DTU(DT, DomTreeUpdater::UpdateStrategy::Lazy); |
| 909 | EXPECT_TRUE(removeUnreachableBlocks(F, nullptr, &DTU)); |
| 910 | EXPECT_FALSE(removeUnreachableBlocks(F, nullptr, &DTU)); |
| 911 | EXPECT_TRUE(DTU.getDomTree().verify()); |
| 912 | }; |
| 913 | |
| 914 | runWithDomTree(*M, "f", checkRUBlocksRetVal); |
Anastasis Grammenos | 52d5283 | 2018-08-07 20:21:56 +0000 | [diff] [blame] | 915 | } |