blob: 639b588766a148a1b045cbd954413cf138d5576b [file] [log] [blame]
Eugene Zelenko5df3d892017-08-24 21:21:39 +00001//===- MachineBlockPlacement.cpp - Basic Block Code Layout optimization ---===//
Chandler Carruth10281422011-10-21 06:46:38 +00002//
Chandler Carruth2946cd72019-01-19 08:50:56 +00003// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
4// See https://llvm.org/LICENSE.txt for license information.
5// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
Chandler Carruth10281422011-10-21 06:46:38 +00006//
7//===----------------------------------------------------------------------===//
8//
Chandler Carruthbd1be4d2011-10-23 09:18:45 +00009// This file implements basic block placement transformations using the CFG
10// structure and branch probability estimates.
Chandler Carruth10281422011-10-21 06:46:38 +000011//
Chandler Carruthbd1be4d2011-10-23 09:18:45 +000012// The pass strives to preserve the structure of the CFG (that is, retain
Benjamin Kramerbde91762012-06-02 10:20:22 +000013// a topological ordering of basic blocks) in the absence of a *strong* signal
Chandler Carruthbd1be4d2011-10-23 09:18:45 +000014// to the contrary from probabilities. However, within the CFG structure, it
15// attempts to choose an ordering which favors placing more likely sequences of
16// blocks adjacent to each other.
17//
18// The algorithm works from the inner-most loop within a function outward, and
19// at each stage walks through the basic blocks, trying to coalesce them into
20// sequential chains where allowed by the CFG (or demanded by heavy
21// probabilities). Finally, it walks the blocks in topological order, and the
22// first time it reaches a chain of basic blocks, it schedules them in the
23// function in-order.
Chandler Carruth10281422011-10-21 06:46:38 +000024//
25//===----------------------------------------------------------------------===//
26
Haicheng Wu5b458cc2016-06-09 15:24:29 +000027#include "BranchFolding.h"
Eugene Zelenko5df3d892017-08-24 21:21:39 +000028#include "llvm/ADT/ArrayRef.h"
Chandler Carruthed0881b2012-12-03 16:50:05 +000029#include "llvm/ADT/DenseMap.h"
Eugene Zelenko5df3d892017-08-24 21:21:39 +000030#include "llvm/ADT/STLExtras.h"
31#include "llvm/ADT/SetVector.h"
Chandler Carruthed0881b2012-12-03 16:50:05 +000032#include "llvm/ADT/SmallPtrSet.h"
33#include "llvm/ADT/SmallVector.h"
34#include "llvm/ADT/Statistic.h"
Xinliang David Lifd3f6452017-01-29 01:57:02 +000035#include "llvm/Analysis/BlockFrequencyInfoImpl.h"
Chandler Carruth8b9737c2011-10-21 08:57:37 +000036#include "llvm/CodeGen/MachineBasicBlock.h"
Chandler Carruth10281422011-10-21 06:46:38 +000037#include "llvm/CodeGen/MachineBlockFrequencyInfo.h"
38#include "llvm/CodeGen/MachineBranchProbabilityInfo.h"
39#include "llvm/CodeGen/MachineFunction.h"
Chandler Carruth10281422011-10-21 06:46:38 +000040#include "llvm/CodeGen/MachineFunctionPass.h"
Chandler Carruth8b9737c2011-10-21 08:57:37 +000041#include "llvm/CodeGen/MachineLoopInfo.h"
42#include "llvm/CodeGen/MachineModuleInfo.h"
Kyle Buttb15c0662017-01-31 23:48:32 +000043#include "llvm/CodeGen/MachinePostDominators.h"
Kyle Butt0846e562016-10-11 20:36:43 +000044#include "llvm/CodeGen/TailDuplicator.h"
David Blaikie3f833ed2017-11-08 01:01:31 +000045#include "llvm/CodeGen/TargetInstrInfo.h"
David Blaikieb3bde2e2017-11-17 01:07:10 +000046#include "llvm/CodeGen/TargetLowering.h"
Chandler Carruth6bda14b2017-06-06 11:49:48 +000047#include "llvm/CodeGen/TargetPassConfig.h"
David Blaikieb3bde2e2017-11-17 01:07:10 +000048#include "llvm/CodeGen/TargetSubtargetInfo.h"
Eugene Zelenko5df3d892017-08-24 21:21:39 +000049#include "llvm/IR/DebugLoc.h"
50#include "llvm/IR/Function.h"
51#include "llvm/Pass.h"
Chandler Carruth10281422011-10-21 06:46:38 +000052#include "llvm/Support/Allocator.h"
Eugene Zelenko5df3d892017-08-24 21:21:39 +000053#include "llvm/Support/BlockFrequency.h"
54#include "llvm/Support/BranchProbability.h"
55#include "llvm/Support/CodeGen.h"
Nadav Rotemc3b0f502013-04-12 00:48:32 +000056#include "llvm/Support/CommandLine.h"
Eugene Zelenko5df3d892017-08-24 21:21:39 +000057#include "llvm/Support/Compiler.h"
Chandler Carruthbd1be4d2011-10-23 09:18:45 +000058#include "llvm/Support/Debug.h"
Benjamin Kramer799003b2015-03-23 19:32:43 +000059#include "llvm/Support/raw_ostream.h"
Eugene Zelenko5df3d892017-08-24 21:21:39 +000060#include "llvm/Target/TargetMachine.h"
Chandler Carruth10281422011-10-21 06:46:38 +000061#include <algorithm>
Eugene Zelenko5df3d892017-08-24 21:21:39 +000062#include <cassert>
63#include <cstdint>
64#include <iterator>
65#include <memory>
66#include <string>
67#include <tuple>
Kyle Buttb15c0662017-01-31 23:48:32 +000068#include <utility>
Eugene Zelenko5df3d892017-08-24 21:21:39 +000069#include <vector>
70
Chandler Carruth10281422011-10-21 06:46:38 +000071using namespace llvm;
72
Chandler Carruthd0dced52015-03-05 02:28:25 +000073#define DEBUG_TYPE "block-placement"
Chandler Carruth1b9dde02014-04-22 02:02:50 +000074
Chandler Carruthae4e8002011-11-02 07:17:12 +000075STATISTIC(NumCondBranches, "Number of conditional branches");
Craig Topper77ec0772015-09-16 03:52:32 +000076STATISTIC(NumUncondBranches, "Number of unconditional branches");
Chandler Carruthae4e8002011-11-02 07:17:12 +000077STATISTIC(CondBranchTakenFreq,
78 "Potential frequency of taking conditional branches");
79STATISTIC(UncondBranchTakenFreq,
80 "Potential frequency of taking unconditional branches");
81
Nadav Rotemc3b0f502013-04-12 00:48:32 +000082static cl::opt<unsigned> AlignAllBlock("align-all-blocks",
83 cl::desc("Force the alignment of all "
84 "blocks in the function."),
85 cl::init(0), cl::Hidden);
86
Geoff Berry10494ac2016-01-21 17:25:52 +000087static cl::opt<unsigned> AlignAllNonFallThruBlocks(
88 "align-all-nofallthru-blocks",
89 cl::desc("Force the alignment of all "
90 "blocks that have no fall-through predecessors (i.e. don't add "
91 "nops that are executed)."),
92 cl::init(0), cl::Hidden);
93
Benjamin Kramerc8160d62013-11-20 19:08:44 +000094// FIXME: Find a good default for this flag and remove the flag.
Chandler Carruth2fc3fe12015-03-05 02:35:31 +000095static cl::opt<unsigned> ExitBlockBias(
96 "block-placement-exit-block-bias",
97 cl::desc("Block frequency percentage a loop exit block needs "
98 "over the original exit to be considered the new exit."),
99 cl::init(0), cl::Hidden);
Benjamin Kramerc8160d62013-11-20 19:08:44 +0000100
Sjoerd Meijer5e11a182016-07-27 08:49:23 +0000101// Definition:
102// - Outlining: placement of a basic block outside the chain or hot path.
103
Cong Houb90b9e02015-11-02 21:24:00 +0000104static cl::opt<unsigned> LoopToColdBlockRatio(
105 "loop-to-cold-block-ratio",
106 cl::desc("Outline loop blocks from loop chain if (frequency of loop) / "
107 "(frequency of block) is greater than this ratio"),
108 cl::init(5), cl::Hidden);
109
Kyle Butt74f61dd2017-08-04 21:13:41 +0000110static cl::opt<bool> ForceLoopColdBlock(
111 "force-loop-cold-block",
112 cl::desc("Force outlining cold blocks from loops."),
113 cl::init(false), cl::Hidden);
114
Cong Hou7745dbc2015-10-19 23:16:40 +0000115static cl::opt<bool>
116 PreciseRotationCost("precise-rotation-cost",
117 cl::desc("Model the cost of loop rotation more "
118 "precisely by using profile data."),
119 cl::init(false), cl::Hidden);
Eugene Zelenko5df3d892017-08-24 21:21:39 +0000120
Xinliang David Lif0ab6df2016-05-12 02:04:41 +0000121static cl::opt<bool>
122 ForcePreciseRotationCost("force-precise-rotation-cost",
Xinliang David Lib840bb82016-05-12 16:39:02 +0000123 cl::desc("Force the use of precise cost "
124 "loop rotation strategy."),
Xinliang David Lif0ab6df2016-05-12 02:04:41 +0000125 cl::init(false), cl::Hidden);
Cong Hou7745dbc2015-10-19 23:16:40 +0000126
127static cl::opt<unsigned> MisfetchCost(
128 "misfetch-cost",
Sjoerd Meijerfd0ad4e2016-07-15 18:41:56 +0000129 cl::desc("Cost that models the probabilistic risk of an instruction "
Cong Hou7745dbc2015-10-19 23:16:40 +0000130 "misfetch due to a jump comparing to falling through, whose cost "
131 "is zero."),
132 cl::init(1), cl::Hidden);
133
134static cl::opt<unsigned> JumpInstCost("jump-inst-cost",
135 cl::desc("Cost of jump instructions."),
136 cl::init(1), cl::Hidden);
Kyle Butt0846e562016-10-11 20:36:43 +0000137static cl::opt<bool>
138TailDupPlacement("tail-dup-placement",
139 cl::desc("Perform tail duplication during placement. "
140 "Creates more fallthrough opportunites in "
141 "outline branches."),
142 cl::init(true), cl::Hidden);
Cong Hou7745dbc2015-10-19 23:16:40 +0000143
Haicheng Wu5b458cc2016-06-09 15:24:29 +0000144static cl::opt<bool>
145BranchFoldPlacement("branch-fold-placement",
146 cl::desc("Perform branch folding during placement. "
147 "Reduces code size."),
148 cl::init(true), cl::Hidden);
149
Kyle Butt0846e562016-10-11 20:36:43 +0000150// Heuristic for tail duplication.
Kyle Buttb15c0662017-01-31 23:48:32 +0000151static cl::opt<unsigned> TailDupPlacementThreshold(
Kyle Butt0846e562016-10-11 20:36:43 +0000152 "tail-dup-placement-threshold",
153 cl::desc("Instruction cutoff for tail duplication during layout. "
154 "Tail merging during layout is forced to have a threshold "
155 "that won't conflict."), cl::init(2),
156 cl::Hidden);
157
Kyle Butt7d531da2017-05-15 17:30:47 +0000158// Heuristic for aggressive tail duplication.
159static cl::opt<unsigned> TailDupPlacementAggressiveThreshold(
160 "tail-dup-placement-aggressive-threshold",
161 cl::desc("Instruction cutoff for aggressive tail duplication during "
162 "layout. Used at -O3. Tail merging during layout is forced to "
Richard Smithc0541df2017-08-17 23:38:41 +0000163 "have a threshold that won't conflict."), cl::init(4),
Kyle Butt7d531da2017-05-15 17:30:47 +0000164 cl::Hidden);
165
Kyle Buttb15c0662017-01-31 23:48:32 +0000166// Heuristic for tail duplication.
167static cl::opt<unsigned> TailDupPlacementPenalty(
168 "tail-dup-placement-penalty",
169 cl::desc("Cost penalty for blocks that can avoid breaking CFG by copying. "
170 "Copying can increase fallthrough, but it also increases icache "
171 "pressure. This parameter controls the penalty to account for that. "
172 "Percent as integer."),
173 cl::init(2),
174 cl::Hidden);
175
Kyle Butt1fa60302017-03-03 01:00:22 +0000176// Heuristic for triangle chains.
177static cl::opt<unsigned> TriangleChainCount(
178 "triangle-chain-count",
179 cl::desc("Number of triangle-shaped-CFG's that need to be in a row for the "
180 "triangle tail duplication heuristic to kick in. 0 to disable."),
Kyle Butt08655992017-03-16 01:32:29 +0000181 cl::init(2),
Kyle Butt1fa60302017-03-03 01:00:22 +0000182 cl::Hidden);
183
Xinliang David Liff287372016-06-03 23:48:36 +0000184extern cl::opt<unsigned> StaticLikelyProb;
Dehao Chen9f2bdfb2016-06-14 22:27:17 +0000185extern cl::opt<unsigned> ProfileLikelyProb;
Xinliang David Liff287372016-06-03 23:48:36 +0000186
Xinliang David Li58fcc9b2017-02-02 21:29:17 +0000187// Internal option used to control BFI display only after MBP pass.
188// Defined in CodeGen/MachineBlockFrequencyInfo.cpp:
189// -view-block-layout-with-bfi=
Xinliang David Lifd3f6452017-01-29 01:57:02 +0000190extern cl::opt<GVDAGType> ViewBlockLayoutWithBFI;
Xinliang David Li58fcc9b2017-02-02 21:29:17 +0000191
192// Command line option to specify the name of the function for CFG dump
193// Defined in Analysis/BlockFrequencyInfo.cpp: -view-bfi-func-name=
Xinliang David Lifd3f6452017-01-29 01:57:02 +0000194extern cl::opt<std::string> ViewBlockFreqFuncName;
Xinliang David Lifd3f6452017-01-29 01:57:02 +0000195
Chandler Carruth10281422011-10-21 06:46:38 +0000196namespace {
Chandler Carruth10281422011-10-21 06:46:38 +0000197
Eugene Zelenko5df3d892017-08-24 21:21:39 +0000198class BlockChain;
199
Adrian Prantl5f8f34e42018-05-01 15:54:18 +0000200/// Type for our function-wide basic block -> block chain mapping.
Eugene Zelenko5df3d892017-08-24 21:21:39 +0000201using BlockToChainMapType = DenseMap<const MachineBasicBlock *, BlockChain *>;
202
Adrian Prantl5f8f34e42018-05-01 15:54:18 +0000203/// A chain of blocks which will be laid out contiguously.
Chandler Carruth10281422011-10-21 06:46:38 +0000204///
205/// This is the datastructure representing a chain of consecutive blocks that
206/// are profitable to layout together in order to maximize fallthrough
Chandler Carruth9139f442012-06-26 05:16:37 +0000207/// probabilities and code locality. We also can use a block chain to represent
208/// a sequence of basic blocks which have some external (correctness)
209/// requirement for sequential layout.
Chandler Carruth10281422011-10-21 06:46:38 +0000210///
Chandler Carruth9139f442012-06-26 05:16:37 +0000211/// Chains can be built around a single basic block and can be merged to grow
212/// them. They participate in a block-to-chain mapping, which is updated
213/// automatically as chains are merged together.
Chandler Carruthbd1be4d2011-10-23 09:18:45 +0000214class BlockChain {
Adrian Prantl5f8f34e42018-05-01 15:54:18 +0000215 /// The sequence of blocks belonging to this chain.
Chandler Carruth10281422011-10-21 06:46:38 +0000216 ///
Chandler Carruthbd1be4d2011-10-23 09:18:45 +0000217 /// This is the sequence of blocks for a particular chain. These will be laid
218 /// out in-order within the function.
219 SmallVector<MachineBasicBlock *, 4> Blocks;
Chandler Carruth10281422011-10-21 06:46:38 +0000220
Adrian Prantl5f8f34e42018-05-01 15:54:18 +0000221 /// A handle to the function-wide basic block to block chain mapping.
Chandler Carruth10281422011-10-21 06:46:38 +0000222 ///
223 /// This is retained in each block chain to simplify the computation of child
224 /// block chains for SCC-formation and iteration. We store the edges to child
225 /// basic blocks, and map them back to their associated chains using this
226 /// structure.
227 BlockToChainMapType &BlockToChain;
228
Chandler Carruthbd1be4d2011-10-23 09:18:45 +0000229public:
Adrian Prantl5f8f34e42018-05-01 15:54:18 +0000230 /// Construct a new BlockChain.
Chandler Carruth10281422011-10-21 06:46:38 +0000231 ///
232 /// This builds a new block chain representing a single basic block in the
233 /// function. It also registers itself as the chain that block participates
234 /// in with the BlockToChain mapping.
235 BlockChain(BlockToChainMapType &BlockToChain, MachineBasicBlock *BB)
Eugene Zelenko5df3d892017-08-24 21:21:39 +0000236 : Blocks(1, BB), BlockToChain(BlockToChain) {
Chandler Carruth10281422011-10-21 06:46:38 +0000237 assert(BB && "Cannot create a chain with a null basic block");
238 BlockToChain[BB] = this;
239 }
240
Adrian Prantl5f8f34e42018-05-01 15:54:18 +0000241 /// Iterator over blocks within the chain.
Eugene Zelenko5df3d892017-08-24 21:21:39 +0000242 using iterator = SmallVectorImpl<MachineBasicBlock *>::iterator;
243 using const_iterator = SmallVectorImpl<MachineBasicBlock *>::const_iterator;
Chandler Carruthbd1be4d2011-10-23 09:18:45 +0000244
Adrian Prantl5f8f34e42018-05-01 15:54:18 +0000245 /// Beginning of blocks within the chain.
Chandler Carruthccc7e422012-04-16 01:12:56 +0000246 iterator begin() { return Blocks.begin(); }
Kyle Butte9425c4f2017-02-04 02:26:32 +0000247 const_iterator begin() const { return Blocks.begin(); }
Chandler Carruthbd1be4d2011-10-23 09:18:45 +0000248
Adrian Prantl5f8f34e42018-05-01 15:54:18 +0000249 /// End of blocks within the chain.
Chandler Carruthccc7e422012-04-16 01:12:56 +0000250 iterator end() { return Blocks.end(); }
Kyle Butte9425c4f2017-02-04 02:26:32 +0000251 const_iterator end() const { return Blocks.end(); }
Chandler Carruthbd1be4d2011-10-23 09:18:45 +0000252
Kyle Butt0846e562016-10-11 20:36:43 +0000253 bool remove(MachineBasicBlock* BB) {
254 for(iterator i = begin(); i != end(); ++i) {
255 if (*i == BB) {
256 Blocks.erase(i);
257 return true;
258 }
259 }
260 return false;
261 }
262
Adrian Prantl5f8f34e42018-05-01 15:54:18 +0000263 /// Merge a block chain into this one.
Chandler Carruth10281422011-10-21 06:46:38 +0000264 ///
265 /// This routine merges a block chain into this one. It takes care of forming
266 /// a contiguous sequence of basic blocks, updating the edge list, and
267 /// updating the block -> chain mapping. It does not free or tear down the
268 /// old chain, but the old chain's block list is no longer valid.
Jakub Staszak90616162011-12-21 23:02:08 +0000269 void merge(MachineBasicBlock *BB, BlockChain *Chain) {
Kyle Butt0cf5b2f2017-05-17 23:44:41 +0000270 assert(BB && "Can't merge a null block.");
271 assert(!Blocks.empty() && "Can't merge into an empty chain.");
Chandler Carruth10281422011-10-21 06:46:38 +0000272
Chandler Carruthbd1be4d2011-10-23 09:18:45 +0000273 // Fast path in case we don't have a chain already.
274 if (!Chain) {
Kyle Butt0cf5b2f2017-05-17 23:44:41 +0000275 assert(!BlockToChain[BB] &&
276 "Passed chain is null, but BB has entry in BlockToChain.");
Chandler Carruthbd1be4d2011-10-23 09:18:45 +0000277 Blocks.push_back(BB);
278 BlockToChain[BB] = this;
279 return;
Chandler Carruth10281422011-10-21 06:46:38 +0000280 }
281
Kyle Butt0cf5b2f2017-05-17 23:44:41 +0000282 assert(BB == *Chain->begin() && "Passed BB is not head of Chain.");
Chandler Carruthbd1be4d2011-10-23 09:18:45 +0000283 assert(Chain->begin() != Chain->end());
Chandler Carruth10281422011-10-21 06:46:38 +0000284
Chandler Carruthbd1be4d2011-10-23 09:18:45 +0000285 // Update the incoming blocks to point to this chain, and add them to the
286 // chain structure.
Chandler Carruth7a715da2015-03-05 03:19:05 +0000287 for (MachineBasicBlock *ChainBB : *Chain) {
288 Blocks.push_back(ChainBB);
Kyle Butt0cf5b2f2017-05-17 23:44:41 +0000289 assert(BlockToChain[ChainBB] == Chain && "Incoming blocks not in chain.");
Chandler Carruth7a715da2015-03-05 03:19:05 +0000290 BlockToChain[ChainBB] = this;
Chandler Carruthbd1be4d2011-10-23 09:18:45 +0000291 }
Chandler Carruth10281422011-10-21 06:46:38 +0000292 }
Chandler Carruth8d150782011-11-13 11:20:44 +0000293
Chandler Carruth49158902012-04-08 14:37:01 +0000294#ifndef NDEBUG
Adrian Prantl5f8f34e42018-05-01 15:54:18 +0000295 /// Dump the blocks in this chain.
Nico Weber7408c702014-01-03 22:53:37 +0000296 LLVM_DUMP_METHOD void dump() {
Chandler Carruth7a715da2015-03-05 03:19:05 +0000297 for (MachineBasicBlock *MBB : *this)
298 MBB->dump();
Chandler Carruth49158902012-04-08 14:37:01 +0000299 }
300#endif // NDEBUG
301
Adrian Prantl5f8f34e42018-05-01 15:54:18 +0000302 /// Count of predecessors of any block within the chain which have not
Philip Reamesae27b232016-03-03 00:58:43 +0000303 /// yet been scheduled. In general, we will delay scheduling this chain
304 /// until those predecessors are scheduled (or we find a sufficiently good
305 /// reason to override this heuristic.) Note that when forming loop chains,
306 /// blocks outside the loop are ignored and treated as if they were already
307 /// scheduled.
Chandler Carruth8d150782011-11-13 11:20:44 +0000308 ///
Philip Reamesae27b232016-03-03 00:58:43 +0000309 /// Note: This field is reinitialized multiple times - once for each loop,
310 /// and then once for the function as a whole.
Eugene Zelenko5df3d892017-08-24 21:21:39 +0000311 unsigned UnscheduledPredecessors = 0;
Chandler Carruth10281422011-10-21 06:46:38 +0000312};
Chandler Carruth10281422011-10-21 06:46:38 +0000313
Chandler Carruth10281422011-10-21 06:46:38 +0000314class MachineBlockPlacement : public MachineFunctionPass {
Adrian Prantl5f8f34e42018-05-01 15:54:18 +0000315 /// A type for a block filter set.
Eugene Zelenko5df3d892017-08-24 21:21:39 +0000316 using BlockFilterSet = SmallSetVector<const MachineBasicBlock *, 16>;
Chandler Carruthbd1be4d2011-10-23 09:18:45 +0000317
Hiroshi Inouedad8c6a2019-01-09 05:11:10 +0000318 /// Pair struct containing basic block and taildup profitability
Kyle Buttb15c0662017-01-31 23:48:32 +0000319 struct BlockAndTailDupResult {
Kyle Butt7fbec9b2017-02-15 19:49:14 +0000320 MachineBasicBlock *BB;
Kyle Buttb15c0662017-01-31 23:48:32 +0000321 bool ShouldTailDup;
322 };
323
Kyle Butt7fbec9b2017-02-15 19:49:14 +0000324 /// Triple struct containing edge weight and the edge.
325 struct WeightedEdge {
326 BlockFrequency Weight;
327 MachineBasicBlock *Src;
328 MachineBasicBlock *Dest;
329 };
330
Adrian Prantl5f8f34e42018-05-01 15:54:18 +0000331 /// work lists of blocks that are ready to be laid out
Xinliang David Li93926ac2016-07-01 05:46:48 +0000332 SmallVector<MachineBasicBlock *, 16> BlockWorkList;
333 SmallVector<MachineBasicBlock *, 16> EHPadWorkList;
334
Kyle Buttebe6cc42017-02-23 21:22:24 +0000335 /// Edges that have already been computed as optimal.
336 DenseMap<const MachineBasicBlock *, BlockAndTailDupResult> ComputedEdges;
Kyle Butt7fbec9b2017-02-15 19:49:14 +0000337
Adrian Prantl5f8f34e42018-05-01 15:54:18 +0000338 /// Machine Function
Xinliang David Li52530a72016-06-13 22:23:44 +0000339 MachineFunction *F;
340
Adrian Prantl5f8f34e42018-05-01 15:54:18 +0000341 /// A handle to the branch probability pass.
Chandler Carruth10281422011-10-21 06:46:38 +0000342 const MachineBranchProbabilityInfo *MBPI;
343
Adrian Prantl5f8f34e42018-05-01 15:54:18 +0000344 /// A handle to the function-wide block frequency pass.
Haicheng Wu5b458cc2016-06-09 15:24:29 +0000345 std::unique_ptr<BranchFolder::MBFIWrapper> MBFI;
Chandler Carruth10281422011-10-21 06:46:38 +0000346
Adrian Prantl5f8f34e42018-05-01 15:54:18 +0000347 /// A handle to the loop info.
Haicheng Wu5b458cc2016-06-09 15:24:29 +0000348 MachineLoopInfo *MLI;
Chandler Carruth8b9737c2011-10-21 08:57:37 +0000349
Adrian Prantl5f8f34e42018-05-01 15:54:18 +0000350 /// Preferred loop exit.
Kyle Buttab9cca72016-10-27 21:37:20 +0000351 /// Member variable for convenience. It may be removed by duplication deep
352 /// in the call stack.
353 MachineBasicBlock *PreferredLoopExit;
354
Adrian Prantl5f8f34e42018-05-01 15:54:18 +0000355 /// A handle to the target's instruction info.
Chandler Carruth10281422011-10-21 06:46:38 +0000356 const TargetInstrInfo *TII;
357
Adrian Prantl5f8f34e42018-05-01 15:54:18 +0000358 /// A handle to the target's lowering info.
Benjamin Kramer56b31bd2013-01-11 20:05:37 +0000359 const TargetLoweringBase *TLI;
Chandler Carruth8b9737c2011-10-21 08:57:37 +0000360
Adrian Prantl5f8f34e42018-05-01 15:54:18 +0000361 /// A handle to the post dominator tree.
Kyle Buttb15c0662017-01-31 23:48:32 +0000362 MachinePostDominatorTree *MPDT;
363
Adrian Prantl5f8f34e42018-05-01 15:54:18 +0000364 /// Duplicator used to duplicate tails during placement.
Kyle Butt0846e562016-10-11 20:36:43 +0000365 ///
366 /// Placement decisions can open up new tail duplication opportunities, but
367 /// since tail duplication affects placement decisions of later blocks, it
368 /// must be done inline.
369 TailDuplicator TailDup;
370
Adrian Prantl5f8f34e42018-05-01 15:54:18 +0000371 /// Allocator and owner of BlockChain structures.
Chandler Carruth10281422011-10-21 06:46:38 +0000372 ///
Chandler Carruth9139f442012-06-26 05:16:37 +0000373 /// We build BlockChains lazily while processing the loop structure of
374 /// a function. To reduce malloc traffic, we allocate them using this
375 /// slab-like allocator, and destroy them after the pass completes. An
376 /// important guarantee is that this allocator produces stable pointers to
377 /// the chains.
Chandler Carruth10281422011-10-21 06:46:38 +0000378 SpecificBumpPtrAllocator<BlockChain> ChainAllocator;
379
Adrian Prantl5f8f34e42018-05-01 15:54:18 +0000380 /// Function wide BasicBlock to BlockChain mapping.
Chandler Carruth10281422011-10-21 06:46:38 +0000381 ///
382 /// This mapping allows efficiently moving from any given basic block to the
383 /// BlockChain it participates in, if any. We use it to, among other things,
384 /// allow implicitly defining edges between chains as the existing edges
385 /// between basic blocks.
Kyle Butte9425c4f2017-02-04 02:26:32 +0000386 DenseMap<const MachineBasicBlock *, BlockChain *> BlockToChain;
Chandler Carruth10281422011-10-21 06:46:38 +0000387
Sanjoy Dasd7389d62016-12-15 05:08:57 +0000388#ifndef NDEBUG
389 /// The set of basic blocks that have terminators that cannot be fully
390 /// analyzed. These basic blocks cannot be re-ordered safely by
391 /// MachineBlockPlacement, and we must preserve physical layout of these
392 /// blocks and their successors through the pass.
393 SmallPtrSet<MachineBasicBlock *, 4> BlocksWithUnanalyzableExits;
394#endif
395
Kyle Butt0846e562016-10-11 20:36:43 +0000396 /// Decrease the UnscheduledPredecessors count for all blocks in chain, and
397 /// if the count goes to 0, add them to the appropriate work list.
Kyle Butte9425c4f2017-02-04 02:26:32 +0000398 void markChainSuccessors(
399 const BlockChain &Chain, const MachineBasicBlock *LoopHeaderBB,
400 const BlockFilterSet *BlockFilter = nullptr);
Kyle Butt0846e562016-10-11 20:36:43 +0000401
402 /// Decrease the UnscheduledPredecessors count for a single block, and
403 /// if the count goes to 0, add them to the appropriate work list.
404 void markBlockSuccessors(
Kyle Butte9425c4f2017-02-04 02:26:32 +0000405 const BlockChain &Chain, const MachineBasicBlock *BB,
406 const MachineBasicBlock *LoopHeaderBB,
Kyle Butt0846e562016-10-11 20:36:43 +0000407 const BlockFilterSet *BlockFilter = nullptr);
408
Xinliang David Li594ffa32016-06-11 18:35:40 +0000409 BranchProbability
Kyle Butte9425c4f2017-02-04 02:26:32 +0000410 collectViableSuccessors(
411 const MachineBasicBlock *BB, const BlockChain &Chain,
412 const BlockFilterSet *BlockFilter,
413 SmallVector<MachineBasicBlock *, 4> &Successors);
414 bool shouldPredBlockBeOutlined(
415 const MachineBasicBlock *BB, const MachineBasicBlock *Succ,
416 const BlockChain &Chain, const BlockFilterSet *BlockFilter,
417 BranchProbability SuccProb, BranchProbability HotProb);
Kyle Butt0846e562016-10-11 20:36:43 +0000418 bool repeatedlyTailDuplicateBlock(
419 MachineBasicBlock *BB, MachineBasicBlock *&LPred,
Kyle Butte9425c4f2017-02-04 02:26:32 +0000420 const MachineBasicBlock *LoopHeaderBB,
Kyle Butt0846e562016-10-11 20:36:43 +0000421 BlockChain &Chain, BlockFilterSet *BlockFilter,
422 MachineFunction::iterator &PrevUnplacedBlockIt);
Kyle Butte9425c4f2017-02-04 02:26:32 +0000423 bool maybeTailDuplicateBlock(
424 MachineBasicBlock *BB, MachineBasicBlock *LPred,
425 BlockChain &Chain, BlockFilterSet *BlockFilter,
426 MachineFunction::iterator &PrevUnplacedBlockIt,
Fangrui Songcb0bab82018-07-16 18:51:40 +0000427 bool &DuplicatedToLPred);
Kyle Butte9425c4f2017-02-04 02:26:32 +0000428 bool hasBetterLayoutPredecessor(
429 const MachineBasicBlock *BB, const MachineBasicBlock *Succ,
430 const BlockChain &SuccChain, BranchProbability SuccProb,
431 BranchProbability RealSuccProb, const BlockChain &Chain,
432 const BlockFilterSet *BlockFilter);
433 BlockAndTailDupResult selectBestSuccessor(
434 const MachineBasicBlock *BB, const BlockChain &Chain,
435 const BlockFilterSet *BlockFilter);
436 MachineBasicBlock *selectBestCandidateBlock(
437 const BlockChain &Chain, SmallVectorImpl<MachineBasicBlock *> &WorkList);
438 MachineBasicBlock *getFirstUnplacedBlock(
439 const BlockChain &PlacedChain,
440 MachineFunction::iterator &PrevUnplacedBlockIt,
441 const BlockFilterSet *BlockFilter);
Amaury Secheteae09c22016-03-14 21:24:11 +0000442
Adrian Prantl5f8f34e42018-05-01 15:54:18 +0000443 /// Add a basic block to the work list if it is appropriate.
Amaury Secheteae09c22016-03-14 21:24:11 +0000444 ///
445 /// If the optional parameter BlockFilter is provided, only MBB
446 /// present in the set will be added to the worklist. If nullptr
447 /// is provided, no filtering occurs.
Kyle Butte9425c4f2017-02-04 02:26:32 +0000448 void fillWorkLists(const MachineBasicBlock *MBB,
Amaury Secheteae09c22016-03-14 21:24:11 +0000449 SmallPtrSetImpl<BlockChain *> &UpdatedPreds,
Amaury Secheteae09c22016-03-14 21:24:11 +0000450 const BlockFilterSet *BlockFilter);
Eugene Zelenko5df3d892017-08-24 21:21:39 +0000451
Kyle Butte9425c4f2017-02-04 02:26:32 +0000452 void buildChain(const MachineBasicBlock *BB, BlockChain &Chain,
Kyle Butt0846e562016-10-11 20:36:43 +0000453 BlockFilterSet *BlockFilter = nullptr);
Guozhi Wei81f3fd42019-01-25 19:45:13 +0000454 bool canMoveBottomBlockToTop(const MachineBasicBlock *BottomBlock,
455 const MachineBasicBlock *OldTop);
Guozhi Wei4c8e4802019-02-22 18:04:37 +0000456 bool hasViableTopFallthrough(const MachineBasicBlock *Top,
457 const BlockFilterSet &LoopBlockSet);
Guozhi Weid2210af2019-06-14 23:08:59 +0000458 BlockFrequency TopFallThroughFreq(const MachineBasicBlock *Top,
459 const BlockFilterSet &LoopBlockSet);
460 BlockFrequency FallThroughGains(const MachineBasicBlock *NewTop,
461 const MachineBasicBlock *OldTop,
462 const MachineBasicBlock *ExitBB,
463 const BlockFilterSet &LoopBlockSet);
464 MachineBasicBlock *findBestLoopTopHelper(MachineBasicBlock *OldTop,
465 const MachineLoop &L, const BlockFilterSet &LoopBlockSet);
Kyle Butte9425c4f2017-02-04 02:26:32 +0000466 MachineBasicBlock *findBestLoopTop(
467 const MachineLoop &L, const BlockFilterSet &LoopBlockSet);
468 MachineBasicBlock *findBestLoopExit(
Guozhi Weid2210af2019-06-14 23:08:59 +0000469 const MachineLoop &L, const BlockFilterSet &LoopBlockSet,
470 BlockFrequency &ExitFreq);
Kyle Butte9425c4f2017-02-04 02:26:32 +0000471 BlockFilterSet collectLoopBlockSet(const MachineLoop &L);
472 void buildLoopChains(const MachineLoop &L);
473 void rotateLoop(
474 BlockChain &LoopChain, const MachineBasicBlock *ExitingBB,
Guozhi Weid2210af2019-06-14 23:08:59 +0000475 BlockFrequency ExitFreq, const BlockFilterSet &LoopBlockSet);
Kyle Butte9425c4f2017-02-04 02:26:32 +0000476 void rotateLoopWithProfile(
477 BlockChain &LoopChain, const MachineLoop &L,
478 const BlockFilterSet &LoopBlockSet);
Xinliang David Li52530a72016-06-13 22:23:44 +0000479 void buildCFGChains();
480 void optimizeBranches();
481 void alignBlocks();
Kyle Butt7fbec9b2017-02-15 19:49:14 +0000482 /// Returns true if a block should be tail-duplicated to increase fallthrough
483 /// opportunities.
Kyle Buttb15c0662017-01-31 23:48:32 +0000484 bool shouldTailDuplicate(MachineBasicBlock *BB);
485 /// Check the edge frequencies to see if tail duplication will increase
486 /// fallthroughs.
487 bool isProfitableToTailDup(
Kyle Butte9425c4f2017-02-04 02:26:32 +0000488 const MachineBasicBlock *BB, const MachineBasicBlock *Succ,
Fangrui Songcb0bab82018-07-16 18:51:40 +0000489 BranchProbability QProb,
Kyle Butte9425c4f2017-02-04 02:26:32 +0000490 const BlockChain &Chain, const BlockFilterSet *BlockFilter);
Eugene Zelenko5df3d892017-08-24 21:21:39 +0000491
Kyle Butt7fbec9b2017-02-15 19:49:14 +0000492 /// Check for a trellis layout.
493 bool isTrellis(const MachineBasicBlock *BB,
494 const SmallVectorImpl<MachineBasicBlock *> &ViableSuccs,
495 const BlockChain &Chain, const BlockFilterSet *BlockFilter);
Eugene Zelenko5df3d892017-08-24 21:21:39 +0000496
Kyle Butt7fbec9b2017-02-15 19:49:14 +0000497 /// Get the best successor given a trellis layout.
498 BlockAndTailDupResult getBestTrellisSuccessor(
499 const MachineBasicBlock *BB,
500 const SmallVectorImpl<MachineBasicBlock *> &ViableSuccs,
501 BranchProbability AdjustedSumProb, const BlockChain &Chain,
502 const BlockFilterSet *BlockFilter);
Eugene Zelenko5df3d892017-08-24 21:21:39 +0000503
Kyle Butt7fbec9b2017-02-15 19:49:14 +0000504 /// Get the best pair of non-conflicting edges.
505 static std::pair<WeightedEdge, WeightedEdge> getBestNonConflictingEdges(
506 const MachineBasicBlock *BB,
Benjamin Kramerd71461c2017-04-12 13:26:28 +0000507 MutableArrayRef<SmallVector<WeightedEdge, 8>> Edges);
Eugene Zelenko5df3d892017-08-24 21:21:39 +0000508
Kyle Buttb15c0662017-01-31 23:48:32 +0000509 /// Returns true if a block can tail duplicate into all unplaced
510 /// predecessors. Filters based on loop.
511 bool canTailDuplicateUnplacedPreds(
Kyle Butte9425c4f2017-02-04 02:26:32 +0000512 const MachineBasicBlock *BB, MachineBasicBlock *Succ,
513 const BlockChain &Chain, const BlockFilterSet *BlockFilter);
Eugene Zelenko5df3d892017-08-24 21:21:39 +0000514
Kyle Butt1fa60302017-03-03 01:00:22 +0000515 /// Find chains of triangles to tail-duplicate where a global analysis works,
516 /// but a local analysis would not find them.
517 void precomputeTriangleChains();
Chandler Carruth10281422011-10-21 06:46:38 +0000518
519public:
520 static char ID; // Pass identification, replacement for typeid
Eugene Zelenko5df3d892017-08-24 21:21:39 +0000521
Chandler Carruth10281422011-10-21 06:46:38 +0000522 MachineBlockPlacement() : MachineFunctionPass(ID) {
523 initializeMachineBlockPlacementPass(*PassRegistry::getPassRegistry());
524 }
525
Craig Topper4584cd52014-03-07 09:26:03 +0000526 bool runOnMachineFunction(MachineFunction &F) override;
Chandler Carruth10281422011-10-21 06:46:38 +0000527
Tim Shen1a8c6772018-03-30 17:51:00 +0000528 bool allowTailDupPlacement() const {
529 assert(F);
530 return TailDupPlacement && !F->getTarget().requiresStructuredCFG();
531 }
532
Craig Topper4584cd52014-03-07 09:26:03 +0000533 void getAnalysisUsage(AnalysisUsage &AU) const override {
Chandler Carruth10281422011-10-21 06:46:38 +0000534 AU.addRequired<MachineBranchProbabilityInfo>();
535 AU.addRequired<MachineBlockFrequencyInfo>();
Kyle Buttb15c0662017-01-31 23:48:32 +0000536 if (TailDupPlacement)
537 AU.addRequired<MachinePostDominatorTree>();
Chandler Carruth8b9737c2011-10-21 08:57:37 +0000538 AU.addRequired<MachineLoopInfo>();
Haicheng Wu5b458cc2016-06-09 15:24:29 +0000539 AU.addRequired<TargetPassConfig>();
Chandler Carruth10281422011-10-21 06:46:38 +0000540 MachineFunctionPass::getAnalysisUsage(AU);
541 }
Chandler Carruth10281422011-10-21 06:46:38 +0000542};
Eugene Zelenko5df3d892017-08-24 21:21:39 +0000543
544} // end anonymous namespace
Chandler Carruth10281422011-10-21 06:46:38 +0000545
546char MachineBlockPlacement::ID = 0;
Eugene Zelenko5df3d892017-08-24 21:21:39 +0000547
Andrew Trick1fa5bcb2012-02-08 21:23:13 +0000548char &llvm::MachineBlockPlacementID = MachineBlockPlacement::ID;
Eugene Zelenko5df3d892017-08-24 21:21:39 +0000549
Matthias Braun1527baa2017-05-25 21:26:32 +0000550INITIALIZE_PASS_BEGIN(MachineBlockPlacement, DEBUG_TYPE,
Chandler Carruth10281422011-10-21 06:46:38 +0000551 "Branch Probability Basic Block Placement", false, false)
552INITIALIZE_PASS_DEPENDENCY(MachineBranchProbabilityInfo)
553INITIALIZE_PASS_DEPENDENCY(MachineBlockFrequencyInfo)
Kyle Buttb15c0662017-01-31 23:48:32 +0000554INITIALIZE_PASS_DEPENDENCY(MachinePostDominatorTree)
Chandler Carruth8b9737c2011-10-21 08:57:37 +0000555INITIALIZE_PASS_DEPENDENCY(MachineLoopInfo)
Matthias Braun1527baa2017-05-25 21:26:32 +0000556INITIALIZE_PASS_END(MachineBlockPlacement, DEBUG_TYPE,
Chandler Carruth10281422011-10-21 06:46:38 +0000557 "Branch Probability Basic Block Placement", false, false)
558
Chandler Carruthbd1be4d2011-10-23 09:18:45 +0000559#ifndef NDEBUG
Adrian Prantl5f8f34e42018-05-01 15:54:18 +0000560/// Helper to print the name of a MBB.
Chandler Carruthbd1be4d2011-10-23 09:18:45 +0000561///
562/// Only used by debug logging.
Kyle Butte9425c4f2017-02-04 02:26:32 +0000563static std::string getBlockName(const MachineBasicBlock *BB) {
Alp Tokere69170a2014-06-26 22:52:05 +0000564 std::string Result;
565 raw_string_ostream OS(Result);
Francis Visoiu Mistrih25528d62017-12-04 17:18:51 +0000566 OS << printMBBReference(*BB);
Philip Reamesb9688f42016-03-02 21:45:13 +0000567 OS << " ('" << BB->getName() << "')";
Alp Tokere69170a2014-06-26 22:52:05 +0000568 OS.flush();
569 return Result;
Chandler Carruthbd1be4d2011-10-23 09:18:45 +0000570}
571#endif
572
Adrian Prantl5f8f34e42018-05-01 15:54:18 +0000573/// Mark a chain's successors as having one fewer preds.
Chandler Carrutheb4ec3a2011-11-13 11:34:55 +0000574///
575/// When a chain is being merged into the "placed" chain, this routine will
576/// quickly walk the successors of each block in the chain and mark them as
577/// having one fewer active predecessor. It also adds any successors of this
Kyle Butt0846e562016-10-11 20:36:43 +0000578/// chain which reach the zero-predecessor state to the appropriate worklist.
Chandler Carruth8d150782011-11-13 11:20:44 +0000579void MachineBlockPlacement::markChainSuccessors(
Kyle Butte9425c4f2017-02-04 02:26:32 +0000580 const BlockChain &Chain, const MachineBasicBlock *LoopHeaderBB,
Jakub Staszak90616162011-12-21 23:02:08 +0000581 const BlockFilterSet *BlockFilter) {
Chandler Carruth8d150782011-11-13 11:20:44 +0000582 // Walk all the blocks in this chain, marking their successors as having
583 // a predecessor placed.
Chandler Carruth7a715da2015-03-05 03:19:05 +0000584 for (MachineBasicBlock *MBB : Chain) {
Kyle Butt0846e562016-10-11 20:36:43 +0000585 markBlockSuccessors(Chain, MBB, LoopHeaderBB, BlockFilter);
586 }
587}
Chandler Carruth10281422011-10-21 06:46:38 +0000588
Adrian Prantl5f8f34e42018-05-01 15:54:18 +0000589/// Mark a single block's successors as having one fewer preds.
Kyle Butt0846e562016-10-11 20:36:43 +0000590///
591/// Under normal circumstances, this is only called by markChainSuccessors,
592/// but if a block that was to be placed is completely tail-duplicated away,
593/// and was duplicated into the chain end, we need to redo markBlockSuccessors
594/// for just that block.
595void MachineBlockPlacement::markBlockSuccessors(
Kyle Butte9425c4f2017-02-04 02:26:32 +0000596 const BlockChain &Chain, const MachineBasicBlock *MBB,
597 const MachineBasicBlock *LoopHeaderBB, const BlockFilterSet *BlockFilter) {
Kyle Butt0846e562016-10-11 20:36:43 +0000598 // Add any successors for which this is the only un-placed in-loop
599 // predecessor to the worklist as a viable candidate for CFG-neutral
600 // placement. No subsequent placement of this block will violate the CFG
601 // shape, so we get to use heuristics to choose a favorable placement.
602 for (MachineBasicBlock *Succ : MBB->successors()) {
603 if (BlockFilter && !BlockFilter->count(Succ))
604 continue;
605 BlockChain &SuccChain = *BlockToChain[Succ];
606 // Disregard edges within a fixed chain, or edges to the loop header.
607 if (&Chain == &SuccChain || Succ == LoopHeaderBB)
608 continue;
Amaury Sechetc53ad4f2016-04-07 21:29:39 +0000609
Kyle Butt0846e562016-10-11 20:36:43 +0000610 // This is a cross-chain edge that is within the loop, so decrement the
611 // loop predecessor count of the destination chain.
612 if (SuccChain.UnscheduledPredecessors == 0 ||
613 --SuccChain.UnscheduledPredecessors > 0)
614 continue;
615
616 auto *NewBB = *SuccChain.begin();
617 if (NewBB->isEHPad())
618 EHPadWorkList.push_back(NewBB);
619 else
620 BlockWorkList.push_back(NewBB);
Chandler Carruth10281422011-10-21 06:46:38 +0000621 }
Chandler Carruth8d150782011-11-13 11:20:44 +0000622}
Chandler Carruthbd1be4d2011-10-23 09:18:45 +0000623
Xinliang David Li594ffa32016-06-11 18:35:40 +0000624/// This helper function collects the set of successors of block
625/// \p BB that are allowed to be its layout successors, and return
626/// the total branch probability of edges from \p BB to those
627/// blocks.
628BranchProbability MachineBlockPlacement::collectViableSuccessors(
Kyle Butte9425c4f2017-02-04 02:26:32 +0000629 const MachineBasicBlock *BB, const BlockChain &Chain,
630 const BlockFilterSet *BlockFilter,
Xinliang David Li594ffa32016-06-11 18:35:40 +0000631 SmallVector<MachineBasicBlock *, 4> &Successors) {
Cong Houd97c1002015-12-01 05:29:22 +0000632 // Adjust edge probabilities by excluding edges pointing to blocks that is
633 // either not in BlockFilter or is already in the current chain. Consider the
634 // following CFG:
Cong Hou41cf1a52015-11-18 00:52:52 +0000635 //
636 // --->A
637 // | / \
638 // | B C
639 // | \ / \
640 // ----D E
641 //
642 // Assume A->C is very hot (>90%), and C->D has a 50% probability, then after
643 // A->C is chosen as a fall-through, D won't be selected as a successor of C
644 // due to CFG constraint (the probability of C->D is not greater than
Hiroshi Inoue3c358f82017-06-16 12:23:04 +0000645 // HotProb to break topo-order). If we exclude E that is not in BlockFilter
646 // when calculating the probability of C->D, D will be selected and we
Xinliang David Li594ffa32016-06-11 18:35:40 +0000647 // will get A C D B as the layout of this loop.
Cong Houd97c1002015-12-01 05:29:22 +0000648 auto AdjustedSumProb = BranchProbability::getOne();
Cong Hou41cf1a52015-11-18 00:52:52 +0000649 for (MachineBasicBlock *Succ : BB->successors()) {
650 bool SkipSucc = false;
Amaury Sechetc53ad4f2016-04-07 21:29:39 +0000651 if (Succ->isEHPad() || (BlockFilter && !BlockFilter->count(Succ))) {
Cong Hou41cf1a52015-11-18 00:52:52 +0000652 SkipSucc = true;
653 } else {
654 BlockChain *SuccChain = BlockToChain[Succ];
655 if (SuccChain == &Chain) {
Cong Hou41cf1a52015-11-18 00:52:52 +0000656 SkipSucc = true;
657 } else if (Succ != *SuccChain->begin()) {
Nicola Zaghend34e60c2018-05-14 12:53:11 +0000658 LLVM_DEBUG(dbgs() << " " << getBlockName(Succ)
659 << " -> Mid chain!\n");
Cong Hou41cf1a52015-11-18 00:52:52 +0000660 continue;
661 }
662 }
663 if (SkipSucc)
Cong Houd97c1002015-12-01 05:29:22 +0000664 AdjustedSumProb -= MBPI->getEdgeProbability(BB, Succ);
Cong Hou41cf1a52015-11-18 00:52:52 +0000665 else
666 Successors.push_back(Succ);
667 }
668
Xinliang David Li594ffa32016-06-11 18:35:40 +0000669 return AdjustedSumProb;
670}
671
672/// The helper function returns the branch probability that is adjusted
673/// or normalized over the new total \p AdjustedSumProb.
Xinliang David Li594ffa32016-06-11 18:35:40 +0000674static BranchProbability
675getAdjustedProbability(BranchProbability OrigProb,
676 BranchProbability AdjustedSumProb) {
677 BranchProbability SuccProb;
678 uint32_t SuccProbN = OrigProb.getNumerator();
679 uint32_t SuccProbD = AdjustedSumProb.getNumerator();
680 if (SuccProbN >= SuccProbD)
681 SuccProb = BranchProbability::getOne();
682 else
683 SuccProb = BranchProbability(SuccProbN, SuccProbD);
684
685 return SuccProb;
686}
687
Kyle Butt7fbec9b2017-02-15 19:49:14 +0000688/// Check if \p BB has exactly the successors in \p Successors.
689static bool
690hasSameSuccessors(MachineBasicBlock &BB,
691 SmallPtrSetImpl<const MachineBasicBlock *> &Successors) {
692 if (BB.succ_size() != Successors.size())
693 return false;
694 // We don't want to count self-loops
695 if (Successors.count(&BB))
696 return false;
697 for (MachineBasicBlock *Succ : BB.successors())
698 if (!Successors.count(Succ))
699 return false;
700 return true;
701}
702
703/// Check if a block should be tail duplicated to increase fallthrough
704/// opportunities.
Kyle Buttb15c0662017-01-31 23:48:32 +0000705/// \p BB Block to check.
706bool MachineBlockPlacement::shouldTailDuplicate(MachineBasicBlock *BB) {
707 // Blocks with single successors don't create additional fallthrough
708 // opportunities. Don't duplicate them. TODO: When conditional exits are
709 // analyzable, allow them to be duplicated.
710 bool IsSimple = TailDup.isSimpleBB(BB);
711
712 if (BB->succ_size() == 1)
713 return false;
714 return TailDup.shouldTailDuplicate(IsSimple, *BB);
715}
716
717/// Compare 2 BlockFrequency's with a small penalty for \p A.
718/// In order to be conservative, we apply a X% penalty to account for
719/// increased icache pressure and static heuristics. For small frequencies
720/// we use only the numerators to improve accuracy. For simplicity, we assume the
721/// penalty is less than 100%
722/// TODO(iteratee): Use 64-bit fixed point edge frequencies everywhere.
723static bool greaterWithBias(BlockFrequency A, BlockFrequency B,
724 uint64_t EntryFreq) {
725 BranchProbability ThresholdProb(TailDupPlacementPenalty, 100);
726 BlockFrequency Gain = A - B;
727 return (Gain / ThresholdProb).getFrequency() >= EntryFreq;
728}
729
730/// Check the edge frequencies to see if tail duplication will increase
731/// fallthroughs. It only makes sense to call this function when
732/// \p Succ would not be chosen otherwise. Tail duplication of \p Succ is
733/// always locally profitable if we would have picked \p Succ without
734/// considering duplication.
735bool MachineBlockPlacement::isProfitableToTailDup(
Kyle Butte9425c4f2017-02-04 02:26:32 +0000736 const MachineBasicBlock *BB, const MachineBasicBlock *Succ,
Kyle Buttb15c0662017-01-31 23:48:32 +0000737 BranchProbability QProb,
Kyle Butte9425c4f2017-02-04 02:26:32 +0000738 const BlockChain &Chain, const BlockFilterSet *BlockFilter) {
Kyle Buttb15c0662017-01-31 23:48:32 +0000739 // We need to do a probability calculation to make sure this is profitable.
740 // First: does succ have a successor that post-dominates? This affects the
741 // calculation. The 2 relevant cases are:
742 // BB BB
743 // | \Qout | \Qout
744 // P| C |P C
745 // = C' = C'
746 // | /Qin | /Qin
747 // | / | /
748 // Succ Succ
749 // / \ | \ V
750 // U/ =V |U \
751 // / \ = D
752 // D E | /
753 // | /
754 // |/
755 // PDom
756 // '=' : Branch taken for that CFG edge
757 // In the second case, Placing Succ while duplicating it into C prevents the
758 // fallthrough of Succ into either D or PDom, because they now have C as an
759 // unplaced predecessor
760
761 // Start by figuring out which case we fall into
762 MachineBasicBlock *PDom = nullptr;
763 SmallVector<MachineBasicBlock *, 4> SuccSuccs;
764 // Only scan the relevant successors
765 auto AdjustedSuccSumProb =
766 collectViableSuccessors(Succ, Chain, BlockFilter, SuccSuccs);
767 BranchProbability PProb = MBPI->getEdgeProbability(BB, Succ);
768 auto BBFreq = MBFI->getBlockFreq(BB);
769 auto SuccFreq = MBFI->getBlockFreq(Succ);
770 BlockFrequency P = BBFreq * PProb;
771 BlockFrequency Qout = BBFreq * QProb;
772 uint64_t EntryFreq = MBFI->getEntryFreq();
773 // If there are no more successors, it is profitable to copy, as it strictly
774 // increases fallthrough.
775 if (SuccSuccs.size() == 0)
776 return greaterWithBias(P, Qout, EntryFreq);
777
778 auto BestSuccSucc = BranchProbability::getZero();
779 // Find the PDom or the best Succ if no PDom exists.
780 for (MachineBasicBlock *SuccSucc : SuccSuccs) {
781 auto Prob = MBPI->getEdgeProbability(Succ, SuccSucc);
782 if (Prob > BestSuccSucc)
783 BestSuccSucc = Prob;
784 if (PDom == nullptr)
785 if (MPDT->dominates(SuccSucc, Succ)) {
786 PDom = SuccSucc;
787 break;
788 }
789 }
790 // For the comparisons, we need to know Succ's best incoming edge that isn't
791 // from BB.
792 auto SuccBestPred = BlockFrequency(0);
793 for (MachineBasicBlock *SuccPred : Succ->predecessors()) {
794 if (SuccPred == Succ || SuccPred == BB
795 || BlockToChain[SuccPred] == &Chain
796 || (BlockFilter && !BlockFilter->count(SuccPred)))
797 continue;
798 auto Freq = MBFI->getBlockFreq(SuccPred)
799 * MBPI->getEdgeProbability(SuccPred, Succ);
800 if (Freq > SuccBestPred)
801 SuccBestPred = Freq;
802 }
803 // Qin is Succ's best unplaced incoming edge that isn't BB
804 BlockFrequency Qin = SuccBestPred;
805 // If it doesn't have a post-dominating successor, here is the calculation:
806 // BB BB
807 // | \Qout | \
808 // P| C | =
809 // = C' | C
810 // | /Qin | |
811 // | / | C' (+Succ)
812 // Succ Succ /|
813 // / \ | \/ |
Kyle Butt7fbec9b2017-02-15 19:49:14 +0000814 // U/ =V | == |
Kyle Buttb15c0662017-01-31 23:48:32 +0000815 // / \ | / \|
816 // D E D E
817 // '=' : Branch taken for that CFG edge
818 // Cost in the first case is: P + V
819 // For this calculation, we always assume P > Qout. If Qout > P
820 // The result of this function will be ignored at the caller.
Kyle Buttee51a202017-04-10 22:28:18 +0000821 // Let F = SuccFreq - Qin
822 // Cost in the second case is: Qout + min(Qin, F) * U + max(Qin, F) * V
Kyle Buttb15c0662017-01-31 23:48:32 +0000823
824 if (PDom == nullptr || !Succ->isSuccessor(PDom)) {
825 BranchProbability UProb = BestSuccSucc;
826 BranchProbability VProb = AdjustedSuccSumProb - UProb;
Kyle Buttee51a202017-04-10 22:28:18 +0000827 BlockFrequency F = SuccFreq - Qin;
Kyle Buttb15c0662017-01-31 23:48:32 +0000828 BlockFrequency V = SuccFreq * VProb;
Kyle Buttee51a202017-04-10 22:28:18 +0000829 BlockFrequency QinU = std::min(Qin, F) * UProb;
Kyle Buttb15c0662017-01-31 23:48:32 +0000830 BlockFrequency BaseCost = P + V;
Kyle Buttee51a202017-04-10 22:28:18 +0000831 BlockFrequency DupCost = Qout + QinU + std::max(Qin, F) * VProb;
Kyle Buttb15c0662017-01-31 23:48:32 +0000832 return greaterWithBias(BaseCost, DupCost, EntryFreq);
833 }
834 BranchProbability UProb = MBPI->getEdgeProbability(Succ, PDom);
835 BranchProbability VProb = AdjustedSuccSumProb - UProb;
836 BlockFrequency U = SuccFreq * UProb;
837 BlockFrequency V = SuccFreq * VProb;
Kyle Buttee51a202017-04-10 22:28:18 +0000838 BlockFrequency F = SuccFreq - Qin;
Kyle Buttb15c0662017-01-31 23:48:32 +0000839 // If there is a post-dominating successor, here is the calculation:
840 // BB BB BB BB
Kyle Buttee51a202017-04-10 22:28:18 +0000841 // | \Qout | \ | \Qout | \
842 // |P C | = |P C | =
843 // = C' |P C = C' |P C
844 // | /Qin | | | /Qin | |
845 // | / | C' (+Succ) | / | C' (+Succ)
846 // Succ Succ /| Succ Succ /|
847 // | \ V | \/ | | \ V | \/ |
848 // |U \ |U /\ =? |U = |U /\ |
849 // = D = = =?| | D | = =|
850 // | / |/ D | / |/ D
851 // | / | / | = | /
852 // |/ | / |/ | =
853 // Dom Dom Dom Dom
Kyle Buttb15c0662017-01-31 23:48:32 +0000854 // '=' : Branch taken for that CFG edge
855 // The cost for taken branches in the first case is P + U
Kyle Buttee51a202017-04-10 22:28:18 +0000856 // Let F = SuccFreq - Qin
Kyle Buttb15c0662017-01-31 23:48:32 +0000857 // The cost in the second case (assuming independence), given the layout:
Kyle Buttee51a202017-04-10 22:28:18 +0000858 // BB, Succ, (C+Succ), D, Dom or the layout:
859 // BB, Succ, D, Dom, (C+Succ)
860 // is Qout + max(F, Qin) * U + min(F, Qin)
Kyle Butt7fbec9b2017-02-15 19:49:14 +0000861 // compare P + U vs Qout + P * U + Qin.
Kyle Buttb15c0662017-01-31 23:48:32 +0000862 //
863 // The 3rd and 4th cases cover when Dom would be chosen to follow Succ.
864 //
865 // For the 3rd case, the cost is P + 2 * V
Kyle Buttee51a202017-04-10 22:28:18 +0000866 // For the 4th case, the cost is Qout + min(Qin, F) * U + max(Qin, F) * V + V
867 // We choose 4 over 3 when (P + V) > Qout + min(Qin, F) * U + max(Qin, F) * V
Kyle Butt7fbec9b2017-02-15 19:49:14 +0000868 if (UProb > AdjustedSuccSumProb / 2 &&
869 !hasBetterLayoutPredecessor(Succ, PDom, *BlockToChain[PDom], UProb, UProb,
870 Chain, BlockFilter))
Kyle Buttb15c0662017-01-31 23:48:32 +0000871 // Cases 3 & 4
Kyle Buttee51a202017-04-10 22:28:18 +0000872 return greaterWithBias(
873 (P + V), (Qout + std::max(Qin, F) * VProb + std::min(Qin, F) * UProb),
874 EntryFreq);
Kyle Buttb15c0662017-01-31 23:48:32 +0000875 // Cases 1 & 2
Kyle Buttee51a202017-04-10 22:28:18 +0000876 return greaterWithBias((P + U),
877 (Qout + std::min(Qin, F) * AdjustedSuccSumProb +
878 std::max(Qin, F) * UProb),
879 EntryFreq);
Kyle Buttb15c0662017-01-31 23:48:32 +0000880}
881
Kyle Butt7fbec9b2017-02-15 19:49:14 +0000882/// Check for a trellis layout. \p BB is the upper part of a trellis if its
883/// successors form the lower part of a trellis. A successor set S forms the
884/// lower part of a trellis if all of the predecessors of S are either in S or
885/// have all of S as successors. We ignore trellises where BB doesn't have 2
886/// successors because for fewer than 2, it's trivial, and for 3 or greater they
887/// are very uncommon and complex to compute optimally. Allowing edges within S
888/// is not strictly a trellis, but the same algorithm works, so we allow it.
889bool MachineBlockPlacement::isTrellis(
890 const MachineBasicBlock *BB,
891 const SmallVectorImpl<MachineBasicBlock *> &ViableSuccs,
892 const BlockChain &Chain, const BlockFilterSet *BlockFilter) {
893 // Technically BB could form a trellis with branching factor higher than 2.
894 // But that's extremely uncommon.
895 if (BB->succ_size() != 2 || ViableSuccs.size() != 2)
896 return false;
897
898 SmallPtrSet<const MachineBasicBlock *, 2> Successors(BB->succ_begin(),
899 BB->succ_end());
900 // To avoid reviewing the same predecessors twice.
901 SmallPtrSet<const MachineBasicBlock *, 8> SeenPreds;
902
903 for (MachineBasicBlock *Succ : ViableSuccs) {
904 int PredCount = 0;
905 for (auto SuccPred : Succ->predecessors()) {
906 // Allow triangle successors, but don't count them.
Dehao Chenb197d5b2017-03-23 23:28:09 +0000907 if (Successors.count(SuccPred)) {
908 // Make sure that it is actually a triangle.
909 for (MachineBasicBlock *CheckSucc : SuccPred->successors())
910 if (!Successors.count(CheckSucc))
911 return false;
Kyle Butt7fbec9b2017-02-15 19:49:14 +0000912 continue;
Dehao Chenb197d5b2017-03-23 23:28:09 +0000913 }
Kyle Butt7fbec9b2017-02-15 19:49:14 +0000914 const BlockChain *PredChain = BlockToChain[SuccPred];
915 if (SuccPred == BB || (BlockFilter && !BlockFilter->count(SuccPred)) ||
916 PredChain == &Chain || PredChain == BlockToChain[Succ])
917 continue;
918 ++PredCount;
919 // Perform the successor check only once.
920 if (!SeenPreds.insert(SuccPred).second)
921 continue;
922 if (!hasSameSuccessors(*SuccPred, Successors))
923 return false;
924 }
925 // If one of the successors has only BB as a predecessor, it is not a
926 // trellis.
927 if (PredCount < 1)
928 return false;
929 }
930 return true;
931}
932
933/// Pick the highest total weight pair of edges that can both be laid out.
934/// The edges in \p Edges[0] are assumed to have a different destination than
935/// the edges in \p Edges[1]. Simple counting shows that the best pair is either
936/// the individual highest weight edges to the 2 different destinations, or in
937/// case of a conflict, one of them should be replaced with a 2nd best edge.
938std::pair<MachineBlockPlacement::WeightedEdge,
939 MachineBlockPlacement::WeightedEdge>
940MachineBlockPlacement::getBestNonConflictingEdges(
941 const MachineBasicBlock *BB,
Benjamin Kramerd71461c2017-04-12 13:26:28 +0000942 MutableArrayRef<SmallVector<MachineBlockPlacement::WeightedEdge, 8>>
943 Edges) {
Kyle Butt7fbec9b2017-02-15 19:49:14 +0000944 // Sort the edges, and then for each successor, find the best incoming
945 // predecessor. If the best incoming predecessors aren't the same,
946 // then that is clearly the best layout. If there is a conflict, one of the
947 // successors will have to fallthrough from the second best predecessor. We
948 // compare which combination is better overall.
949
950 // Sort for highest frequency.
951 auto Cmp = [](WeightedEdge A, WeightedEdge B) { return A.Weight > B.Weight; };
952
Fangrui Songefd94c52019-04-23 14:51:27 +0000953 llvm::stable_sort(Edges[0], Cmp);
954 llvm::stable_sort(Edges[1], Cmp);
Kyle Butt7fbec9b2017-02-15 19:49:14 +0000955 auto BestA = Edges[0].begin();
956 auto BestB = Edges[1].begin();
957 // Arrange for the correct answer to be in BestA and BestB
958 // If the 2 best edges don't conflict, the answer is already there.
959 if (BestA->Src == BestB->Src) {
960 // Compare the total fallthrough of (Best + Second Best) for both pairs
961 auto SecondBestA = std::next(BestA);
962 auto SecondBestB = std::next(BestB);
963 BlockFrequency BestAScore = BestA->Weight + SecondBestB->Weight;
964 BlockFrequency BestBScore = BestB->Weight + SecondBestA->Weight;
965 if (BestAScore < BestBScore)
966 BestA = SecondBestA;
967 else
968 BestB = SecondBestB;
969 }
970 // Arrange for the BB edge to be in BestA if it exists.
971 if (BestB->Src == BB)
972 std::swap(BestA, BestB);
973 return std::make_pair(*BestA, *BestB);
974}
975
976/// Get the best successor from \p BB based on \p BB being part of a trellis.
977/// We only handle trellises with 2 successors, so the algorithm is
978/// straightforward: Find the best pair of edges that don't conflict. We find
979/// the best incoming edge for each successor in the trellis. If those conflict,
980/// we consider which of them should be replaced with the second best.
981/// Upon return the two best edges will be in \p BestEdges. If one of the edges
982/// comes from \p BB, it will be in \p BestEdges[0]
983MachineBlockPlacement::BlockAndTailDupResult
984MachineBlockPlacement::getBestTrellisSuccessor(
985 const MachineBasicBlock *BB,
986 const SmallVectorImpl<MachineBasicBlock *> &ViableSuccs,
987 BranchProbability AdjustedSumProb, const BlockChain &Chain,
988 const BlockFilterSet *BlockFilter) {
989
990 BlockAndTailDupResult Result = {nullptr, false};
991 SmallPtrSet<const MachineBasicBlock *, 4> Successors(BB->succ_begin(),
992 BB->succ_end());
993
994 // We assume size 2 because it's common. For general n, we would have to do
995 // the Hungarian algorithm, but it's not worth the complexity because more
996 // than 2 successors is fairly uncommon, and a trellis even more so.
997 if (Successors.size() != 2 || ViableSuccs.size() != 2)
998 return Result;
999
1000 // Collect the edge frequencies of all edges that form the trellis.
Benjamin Kramerd71461c2017-04-12 13:26:28 +00001001 SmallVector<WeightedEdge, 8> Edges[2];
Kyle Butt7fbec9b2017-02-15 19:49:14 +00001002 int SuccIndex = 0;
1003 for (auto Succ : ViableSuccs) {
1004 for (MachineBasicBlock *SuccPred : Succ->predecessors()) {
1005 // Skip any placed predecessors that are not BB
1006 if (SuccPred != BB)
1007 if ((BlockFilter && !BlockFilter->count(SuccPred)) ||
1008 BlockToChain[SuccPred] == &Chain ||
1009 BlockToChain[SuccPred] == BlockToChain[Succ])
1010 continue;
1011 BlockFrequency EdgeFreq = MBFI->getBlockFreq(SuccPred) *
1012 MBPI->getEdgeProbability(SuccPred, Succ);
1013 Edges[SuccIndex].push_back({EdgeFreq, SuccPred, Succ});
1014 }
1015 ++SuccIndex;
1016 }
1017
1018 // Pick the best combination of 2 edges from all the edges in the trellis.
1019 WeightedEdge BestA, BestB;
1020 std::tie(BestA, BestB) = getBestNonConflictingEdges(BB, Edges);
1021
1022 if (BestA.Src != BB) {
1023 // If we have a trellis, and BB doesn't have the best fallthrough edges,
1024 // we shouldn't choose any successor. We've already looked and there's a
1025 // better fallthrough edge for all the successors.
Nicola Zaghend34e60c2018-05-14 12:53:11 +00001026 LLVM_DEBUG(dbgs() << "Trellis, but not one of the chosen edges.\n");
Kyle Butt7fbec9b2017-02-15 19:49:14 +00001027 return Result;
1028 }
1029
1030 // Did we pick the triangle edge? If tail-duplication is profitable, do
1031 // that instead. Otherwise merge the triangle edge now while we know it is
1032 // optimal.
1033 if (BestA.Dest == BestB.Src) {
1034 // The edges are BB->Succ1->Succ2, and we're looking to see if BB->Succ2
1035 // would be better.
1036 MachineBasicBlock *Succ1 = BestA.Dest;
1037 MachineBasicBlock *Succ2 = BestB.Dest;
1038 // Check to see if tail-duplication would be profitable.
Tim Shen1a8c6772018-03-30 17:51:00 +00001039 if (allowTailDupPlacement() && shouldTailDuplicate(Succ2) &&
Kyle Butt7fbec9b2017-02-15 19:49:14 +00001040 canTailDuplicateUnplacedPreds(BB, Succ2, Chain, BlockFilter) &&
1041 isProfitableToTailDup(BB, Succ2, MBPI->getEdgeProbability(BB, Succ1),
1042 Chain, BlockFilter)) {
Nicola Zaghend34e60c2018-05-14 12:53:11 +00001043 LLVM_DEBUG(BranchProbability Succ2Prob = getAdjustedProbability(
1044 MBPI->getEdgeProbability(BB, Succ2), AdjustedSumProb);
1045 dbgs() << " Selected: " << getBlockName(Succ2)
1046 << ", probability: " << Succ2Prob
1047 << " (Tail Duplicate)\n");
Kyle Butt7fbec9b2017-02-15 19:49:14 +00001048 Result.BB = Succ2;
1049 Result.ShouldTailDup = true;
1050 return Result;
1051 }
1052 }
1053 // We have already computed the optimal edge for the other side of the
1054 // trellis.
Kyle Buttebe6cc42017-02-23 21:22:24 +00001055 ComputedEdges[BestB.Src] = { BestB.Dest, false };
Kyle Butt7fbec9b2017-02-15 19:49:14 +00001056
1057 auto TrellisSucc = BestA.Dest;
Nicola Zaghend34e60c2018-05-14 12:53:11 +00001058 LLVM_DEBUG(BranchProbability SuccProb = getAdjustedProbability(
1059 MBPI->getEdgeProbability(BB, TrellisSucc), AdjustedSumProb);
1060 dbgs() << " Selected: " << getBlockName(TrellisSucc)
1061 << ", probability: " << SuccProb << " (Trellis)\n");
Kyle Butt7fbec9b2017-02-15 19:49:14 +00001062 Result.BB = TrellisSucc;
1063 return Result;
1064}
Kyle Buttb15c0662017-01-31 23:48:32 +00001065
Tim Shen1a8c6772018-03-30 17:51:00 +00001066/// When the option allowTailDupPlacement() is on, this method checks if the
Kyle Buttb15c0662017-01-31 23:48:32 +00001067/// fallthrough candidate block \p Succ (of block \p BB) can be tail-duplicated
1068/// into all of its unplaced, unfiltered predecessors, that are not BB.
1069bool MachineBlockPlacement::canTailDuplicateUnplacedPreds(
Kyle Butte9425c4f2017-02-04 02:26:32 +00001070 const MachineBasicBlock *BB, MachineBasicBlock *Succ,
1071 const BlockChain &Chain, const BlockFilterSet *BlockFilter) {
Kyle Buttb15c0662017-01-31 23:48:32 +00001072 if (!shouldTailDuplicate(Succ))
1073 return false;
1074
Kyle Butt7fbec9b2017-02-15 19:49:14 +00001075 // For CFG checking.
1076 SmallPtrSet<const MachineBasicBlock *, 4> Successors(BB->succ_begin(),
1077 BB->succ_end());
Kyle Buttb15c0662017-01-31 23:48:32 +00001078 for (MachineBasicBlock *Pred : Succ->predecessors()) {
1079 // Make sure all unplaced and unfiltered predecessors can be
1080 // tail-duplicated into.
Kyle Butte9425c4f2017-02-04 02:26:32 +00001081 // Skip any blocks that are already placed or not in this loop.
Kyle Buttb15c0662017-01-31 23:48:32 +00001082 if (Pred == BB || (BlockFilter && !BlockFilter->count(Pred))
1083 || BlockToChain[Pred] == &Chain)
1084 continue;
Kyle Butt7fbec9b2017-02-15 19:49:14 +00001085 if (!TailDup.canTailDuplicate(Succ, Pred)) {
1086 if (Successors.size() > 1 && hasSameSuccessors(*Pred, Successors))
1087 // This will result in a trellis after tail duplication, so we don't
1088 // need to copy Succ into this predecessor. In the presence
1089 // of a trellis tail duplication can continue to be profitable.
1090 // For example:
1091 // A A
1092 // |\ |\
1093 // | \ | \
1094 // | C | C+BB
1095 // | / | |
1096 // |/ | |
1097 // BB => BB |
1098 // |\ |\/|
1099 // | \ |/\|
1100 // | D | D
1101 // | / | /
1102 // |/ |/
1103 // Succ Succ
1104 //
1105 // After BB was duplicated into C, the layout looks like the one on the
1106 // right. BB and C now have the same successors. When considering
1107 // whether Succ can be duplicated into all its unplaced predecessors, we
1108 // ignore C.
1109 // We can do this because C already has a profitable fallthrough, namely
1110 // D. TODO(iteratee): ignore sufficiently cold predecessors for
1111 // duplication and for this test.
1112 //
1113 // This allows trellises to be laid out in 2 separate chains
1114 // (A,B,Succ,...) and later (C,D,...) This is a reasonable heuristic
1115 // because it allows the creation of 2 fallthrough paths with links
1116 // between them, and we correctly identify the best layout for these
1117 // CFGs. We want to extend trellises that the user created in addition
1118 // to trellises created by tail-duplication, so we just look for the
1119 // CFG.
1120 continue;
Kyle Buttb15c0662017-01-31 23:48:32 +00001121 return false;
Kyle Butt7fbec9b2017-02-15 19:49:14 +00001122 }
Kyle Buttb15c0662017-01-31 23:48:32 +00001123 }
1124 return true;
1125}
1126
Kyle Butt1fa60302017-03-03 01:00:22 +00001127/// Find chains of triangles where we believe it would be profitable to
1128/// tail-duplicate them all, but a local analysis would not find them.
1129/// There are 3 ways this can be profitable:
1130/// 1) The post-dominators marked 50% are actually taken 55% (This shrinks with
1131/// longer chains)
1132/// 2) The chains are statically correlated. Branch probabilities have a very
1133/// U-shaped distribution.
1134/// [http://nrs.harvard.edu/urn-3:HUL.InstRepos:24015805]
1135/// If the branches in a chain are likely to be from the same side of the
1136/// distribution as their predecessor, but are independent at runtime, this
1137/// transformation is profitable. (Because the cost of being wrong is a small
1138/// fixed cost, unlike the standard triangle layout where the cost of being
1139/// wrong scales with the # of triangles.)
1140/// 3) The chains are dynamically correlated. If the probability that a previous
1141/// branch was taken positively influences whether the next branch will be
1142/// taken
1143/// We believe that 2 and 3 are common enough to justify the small margin in 1.
1144void MachineBlockPlacement::precomputeTriangleChains() {
1145 struct TriangleChain {
Benjamin Kramerd71461c2017-04-12 13:26:28 +00001146 std::vector<MachineBasicBlock *> Edges;
Eugene Zelenko5df3d892017-08-24 21:21:39 +00001147
Benjamin Kramerd71461c2017-04-12 13:26:28 +00001148 TriangleChain(MachineBasicBlock *src, MachineBasicBlock *dst)
1149 : Edges({src, dst}) {}
Kyle Butt1fa60302017-03-03 01:00:22 +00001150
1151 void append(MachineBasicBlock *dst) {
Benjamin Kramerd71461c2017-04-12 13:26:28 +00001152 assert(getKey()->isSuccessor(dst) &&
Kyle Butt1fa60302017-03-03 01:00:22 +00001153 "Attempting to append a block that is not a successor.");
Benjamin Kramerd71461c2017-04-12 13:26:28 +00001154 Edges.push_back(dst);
Kyle Butt1fa60302017-03-03 01:00:22 +00001155 }
1156
Benjamin Kramerd71461c2017-04-12 13:26:28 +00001157 unsigned count() const { return Edges.size() - 1; }
1158
1159 MachineBasicBlock *getKey() const {
1160 return Edges.back();
Kyle Butt1fa60302017-03-03 01:00:22 +00001161 }
1162 };
1163
1164 if (TriangleChainCount == 0)
1165 return;
1166
Nicola Zaghend34e60c2018-05-14 12:53:11 +00001167 LLVM_DEBUG(dbgs() << "Pre-computing triangle chains.\n");
Kyle Butt1fa60302017-03-03 01:00:22 +00001168 // Map from last block to the chain that contains it. This allows us to extend
1169 // chains as we find new triangles.
1170 DenseMap<const MachineBasicBlock *, TriangleChain> TriangleChainMap;
1171 for (MachineBasicBlock &BB : *F) {
1172 // If BB doesn't have 2 successors, it doesn't start a triangle.
1173 if (BB.succ_size() != 2)
1174 continue;
1175 MachineBasicBlock *PDom = nullptr;
1176 for (MachineBasicBlock *Succ : BB.successors()) {
1177 if (!MPDT->dominates(Succ, &BB))
1178 continue;
1179 PDom = Succ;
1180 break;
1181 }
1182 // If BB doesn't have a post-dominating successor, it doesn't form a
1183 // triangle.
1184 if (PDom == nullptr)
1185 continue;
1186 // If PDom has a hint that it is low probability, skip this triangle.
1187 if (MBPI->getEdgeProbability(&BB, PDom) < BranchProbability(50, 100))
1188 continue;
1189 // If PDom isn't eligible for duplication, this isn't the kind of triangle
1190 // we're looking for.
1191 if (!shouldTailDuplicate(PDom))
1192 continue;
1193 bool CanTailDuplicate = true;
1194 // If PDom can't tail-duplicate into it's non-BB predecessors, then this
1195 // isn't the kind of triangle we're looking for.
1196 for (MachineBasicBlock* Pred : PDom->predecessors()) {
1197 if (Pred == &BB)
1198 continue;
1199 if (!TailDup.canTailDuplicate(PDom, Pred)) {
1200 CanTailDuplicate = false;
1201 break;
1202 }
1203 }
1204 // If we can't tail-duplicate PDom to its predecessors, then skip this
1205 // triangle.
1206 if (!CanTailDuplicate)
1207 continue;
1208
1209 // Now we have an interesting triangle. Insert it if it's not part of an
Hiroshi Inoue3c358f82017-06-16 12:23:04 +00001210 // existing chain.
Kyle Butt1fa60302017-03-03 01:00:22 +00001211 // Note: This cannot be replaced with a call insert() or emplace() because
1212 // the find key is BB, but the insert/emplace key is PDom.
1213 auto Found = TriangleChainMap.find(&BB);
1214 // If it is, remove the chain from the map, grow it, and put it back in the
1215 // map with the end as the new key.
1216 if (Found != TriangleChainMap.end()) {
1217 TriangleChain Chain = std::move(Found->second);
1218 TriangleChainMap.erase(Found);
1219 Chain.append(PDom);
1220 TriangleChainMap.insert(std::make_pair(Chain.getKey(), std::move(Chain)));
1221 } else {
1222 auto InsertResult = TriangleChainMap.try_emplace(PDom, &BB, PDom);
Benjamin Kramer33580692017-04-12 13:26:31 +00001223 assert(InsertResult.second && "Block seen twice.");
1224 (void)InsertResult;
Kyle Butt1fa60302017-03-03 01:00:22 +00001225 }
1226 }
1227
Kyle Butt336c78f2017-04-12 18:30:32 +00001228 // Iterating over a DenseMap is safe here, because the only thing in the body
1229 // of the loop is inserting into another DenseMap (ComputedEdges).
1230 // ComputedEdges is never iterated, so this doesn't lead to non-determinism.
Kyle Butt1fa60302017-03-03 01:00:22 +00001231 for (auto &ChainPair : TriangleChainMap) {
1232 TriangleChain &Chain = ChainPair.second;
1233 // Benchmarking has shown that due to branch correlation duplicating 2 or
1234 // more triangles is profitable, despite the calculations assuming
1235 // independence.
Benjamin Kramerd71461c2017-04-12 13:26:28 +00001236 if (Chain.count() < TriangleChainCount)
Kyle Butt1fa60302017-03-03 01:00:22 +00001237 continue;
Benjamin Kramerd71461c2017-04-12 13:26:28 +00001238 MachineBasicBlock *dst = Chain.Edges.back();
1239 Chain.Edges.pop_back();
1240 for (MachineBasicBlock *src : reverse(Chain.Edges)) {
Nicola Zaghend34e60c2018-05-14 12:53:11 +00001241 LLVM_DEBUG(dbgs() << "Marking edge: " << getBlockName(src) << "->"
1242 << getBlockName(dst)
1243 << " as pre-computed based on triangles.\n");
Benjamin Kramer33580692017-04-12 13:26:31 +00001244
1245 auto InsertResult = ComputedEdges.insert({src, {dst, true}});
1246 assert(InsertResult.second && "Block seen twice.");
1247 (void)InsertResult;
1248
Kyle Butt1fa60302017-03-03 01:00:22 +00001249 dst = src;
1250 }
1251 }
1252}
1253
Dehao Chen9f2bdfb2016-06-14 22:27:17 +00001254// When profile is not present, return the StaticLikelyProb.
1255// When profile is available, we need to handle the triangle-shape CFG.
1256static BranchProbability getLayoutSuccessorProbThreshold(
Kyle Butte9425c4f2017-02-04 02:26:32 +00001257 const MachineBasicBlock *BB) {
Easwaran Ramana17f2202017-12-22 01:33:52 +00001258 if (!BB->getParent()->getFunction().hasProfileData())
Dehao Chen9f2bdfb2016-06-14 22:27:17 +00001259 return BranchProbability(StaticLikelyProb, 100);
1260 if (BB->succ_size() == 2) {
1261 const MachineBasicBlock *Succ1 = *BB->succ_begin();
1262 const MachineBasicBlock *Succ2 = *(BB->succ_begin() + 1);
Xinliang David Lie34ed832016-06-15 03:03:30 +00001263 if (Succ1->isSuccessor(Succ2) || Succ2->isSuccessor(Succ1)) {
1264 /* See case 1 below for the cost analysis. For BB->Succ to
1265 * be taken with smaller cost, the following needs to hold:
Kyle Buttb15c0662017-01-31 23:48:32 +00001266 * Prob(BB->Succ) > 2 * Prob(BB->Pred)
1267 * So the threshold T in the calculation below
1268 * (1-T) * Prob(BB->Succ) > T * Prob(BB->Pred)
1269 * So T / (1 - T) = 2, Yielding T = 2/3
1270 * Also adding user specified branch bias, we have
Xinliang David Lie34ed832016-06-15 03:03:30 +00001271 * T = (2/3)*(ProfileLikelyProb/50)
1272 * = (2*ProfileLikelyProb)/150)
1273 */
1274 return BranchProbability(2 * ProfileLikelyProb, 150);
1275 }
Dehao Chen9f2bdfb2016-06-14 22:27:17 +00001276 }
1277 return BranchProbability(ProfileLikelyProb, 100);
Xinliang David Licbf12142016-06-13 20:24:19 +00001278}
1279
1280/// Checks to see if the layout candidate block \p Succ has a better layout
1281/// predecessor than \c BB. If yes, returns true.
Kyle Buttb15c0662017-01-31 23:48:32 +00001282/// \p SuccProb: The probability adjusted for only remaining blocks.
1283/// Only used for logging
1284/// \p RealSuccProb: The un-adjusted probability.
1285/// \p Chain: The chain that BB belongs to and Succ is being considered for.
1286/// \p BlockFilter: if non-null, the set of blocks that make up the loop being
1287/// considered
Xinliang David Licbf12142016-06-13 20:24:19 +00001288bool MachineBlockPlacement::hasBetterLayoutPredecessor(
Kyle Butte9425c4f2017-02-04 02:26:32 +00001289 const MachineBasicBlock *BB, const MachineBasicBlock *Succ,
1290 const BlockChain &SuccChain, BranchProbability SuccProb,
1291 BranchProbability RealSuccProb, const BlockChain &Chain,
1292 const BlockFilterSet *BlockFilter) {
Xinliang David Licbf12142016-06-13 20:24:19 +00001293
Sjoerd Meijerfd0ad4e2016-07-15 18:41:56 +00001294 // There isn't a better layout when there are no unscheduled predecessors.
Xinliang David Licbf12142016-06-13 20:24:19 +00001295 if (SuccChain.UnscheduledPredecessors == 0)
1296 return false;
1297
1298 // There are two basic scenarios here:
1299 // -------------------------------------
Sjoerd Meijerfd0ad4e2016-07-15 18:41:56 +00001300 // Case 1: triangular shape CFG (if-then):
Xinliang David Licbf12142016-06-13 20:24:19 +00001301 // BB
1302 // | \
1303 // | \
1304 // | Pred
1305 // | /
1306 // Succ
1307 // In this case, we are evaluating whether to select edge -> Succ, e.g.
1308 // set Succ as the layout successor of BB. Picking Succ as BB's
Sjoerd Meijerfd0ad4e2016-07-15 18:41:56 +00001309 // successor breaks the CFG constraints (FIXME: define these constraints).
1310 // With this layout, Pred BB
Xinliang David Licbf12142016-06-13 20:24:19 +00001311 // is forced to be outlined, so the overall cost will be cost of the
1312 // branch taken from BB to Pred, plus the cost of back taken branch
Sjoerd Meijerfd0ad4e2016-07-15 18:41:56 +00001313 // from Pred to Succ, as well as the additional cost associated
Xinliang David Licbf12142016-06-13 20:24:19 +00001314 // with the needed unconditional jump instruction from Pred To Succ.
Sjoerd Meijerfd0ad4e2016-07-15 18:41:56 +00001315
Xinliang David Licbf12142016-06-13 20:24:19 +00001316 // The cost of the topological order layout is the taken branch cost
1317 // from BB to Succ, so to make BB->Succ a viable candidate, the following
1318 // must hold:
1319 // 2 * freq(BB->Pred) * taken_branch_cost + unconditional_jump_cost
1320 // < freq(BB->Succ) * taken_branch_cost.
1321 // Ignoring unconditional jump cost, we get
1322 // freq(BB->Succ) > 2 * freq(BB->Pred), i.e.,
1323 // prob(BB->Succ) > 2 * prob(BB->Pred)
1324 //
Sjoerd Meijerfd0ad4e2016-07-15 18:41:56 +00001325 // When real profile data is available, we can precisely compute the
1326 // probability threshold that is needed for edge BB->Succ to be considered.
1327 // Without profile data, the heuristic requires the branch bias to be
Xinliang David Licbf12142016-06-13 20:24:19 +00001328 // a lot larger to make sure the signal is very strong (e.g. 80% default).
1329 // -----------------------------------------------------------------
Sjoerd Meijerfd0ad4e2016-07-15 18:41:56 +00001330 // Case 2: diamond like CFG (if-then-else):
Xinliang David Licbf12142016-06-13 20:24:19 +00001331 // S
1332 // / \
1333 // | \
1334 // BB Pred
1335 // \ /
1336 // Succ
1337 // ..
Sjoerd Meijerfd0ad4e2016-07-15 18:41:56 +00001338 //
1339 // The current block is BB and edge BB->Succ is now being evaluated.
1340 // Note that edge S->BB was previously already selected because
1341 // prob(S->BB) > prob(S->Pred).
1342 // At this point, 2 blocks can be placed after BB: Pred or Succ. If we
1343 // choose Pred, we will have a topological ordering as shown on the left
1344 // in the picture below. If we choose Succ, we have the solution as shown
1345 // on the right:
1346 //
1347 // topo-order:
1348 //
1349 // S----- ---S
1350 // | | | |
1351 // ---BB | | BB
1352 // | | | |
Hiroshi Inoue3c358f82017-06-16 12:23:04 +00001353 // | Pred-- | Succ--
Sjoerd Meijerfd0ad4e2016-07-15 18:41:56 +00001354 // | | | |
Hiroshi Inoue3c358f82017-06-16 12:23:04 +00001355 // ---Succ ---Pred--
Sjoerd Meijerfd0ad4e2016-07-15 18:41:56 +00001356 //
1357 // cost = freq(S->Pred) + freq(BB->Succ) cost = 2 * freq (S->Pred)
1358 // = freq(S->Pred) + freq(S->BB)
1359 //
1360 // If we have profile data (i.e, branch probabilities can be trusted), the
1361 // cost (number of taken branches) with layout S->BB->Succ->Pred is 2 *
1362 // freq(S->Pred) while the cost of topo order is freq(S->Pred) + freq(S->BB).
1363 // We know Prob(S->BB) > Prob(S->Pred), so freq(S->BB) > freq(S->Pred), which
1364 // means the cost of topological order is greater.
Xinliang David Licbf12142016-06-13 20:24:19 +00001365 // When profile data is not available, however, we need to be more
1366 // conservative. If the branch prediction is wrong, breaking the topo-order
1367 // will actually yield a layout with large cost. For this reason, we need
Sjoerd Meijerfd0ad4e2016-07-15 18:41:56 +00001368 // strong biased branch at block S with Prob(S->BB) in order to select
1369 // BB->Succ. This is equivalent to looking the CFG backward with backward
Xinliang David Licbf12142016-06-13 20:24:19 +00001370 // edge: Prob(Succ->BB) needs to >= HotProb in order to be selected (without
1371 // profile data).
Kyle Butt02d8d052016-07-29 18:09:28 +00001372 // --------------------------------------------------------------------------
1373 // Case 3: forked diamond
1374 // S
1375 // / \
1376 // / \
1377 // BB Pred
1378 // | \ / |
1379 // | \ / |
1380 // | X |
1381 // | / \ |
1382 // | / \ |
1383 // S1 S2
1384 //
1385 // The current block is BB and edge BB->S1 is now being evaluated.
1386 // As above S->BB was already selected because
1387 // prob(S->BB) > prob(S->Pred). Assume that prob(BB->S1) >= prob(BB->S2).
1388 //
1389 // topo-order:
1390 //
1391 // S-------| ---S
1392 // | | | |
1393 // ---BB | | BB
1394 // | | | |
1395 // | Pred----| | S1----
1396 // | | | |
1397 // --(S1 or S2) ---Pred--
Kyle Butt7fbec9b2017-02-15 19:49:14 +00001398 // |
1399 // S2
Kyle Butt02d8d052016-07-29 18:09:28 +00001400 //
1401 // topo-cost = freq(S->Pred) + freq(BB->S1) + freq(BB->S2)
1402 // + min(freq(Pred->S1), freq(Pred->S2))
1403 // Non-topo-order cost:
Kyle Butt02d8d052016-07-29 18:09:28 +00001404 // non-topo-cost = 2 * freq(S->Pred) + freq(BB->S2).
1405 // To be conservative, we can assume that min(freq(Pred->S1), freq(Pred->S2))
1406 // is 0. Then the non topo layout is better when
1407 // freq(S->Pred) < freq(BB->S1).
1408 // This is exactly what is checked below.
1409 // Note there are other shapes that apply (Pred may not be a single block,
1410 // but they all fit this general pattern.)
Dehao Chen9f2bdfb2016-06-14 22:27:17 +00001411 BranchProbability HotProb = getLayoutSuccessorProbThreshold(BB);
Xinliang David Licbf12142016-06-13 20:24:19 +00001412
Xinliang David Licbf12142016-06-13 20:24:19 +00001413 // Make sure that a hot successor doesn't have a globally more
1414 // important predecessor.
1415 BlockFrequency CandidateEdgeFreq = MBFI->getBlockFreq(BB) * RealSuccProb;
1416 bool BadCFGConflict = false;
1417
1418 for (MachineBasicBlock *Pred : Succ->predecessors()) {
1419 if (Pred == Succ || BlockToChain[Pred] == &SuccChain ||
1420 (BlockFilter && !BlockFilter->count(Pred)) ||
Kyle Buttb15c0662017-01-31 23:48:32 +00001421 BlockToChain[Pred] == &Chain ||
1422 // This check is redundant except for look ahead. This function is
1423 // called for lookahead by isProfitableToTailDup when BB hasn't been
1424 // placed yet.
1425 (Pred == BB))
Xinliang David Licbf12142016-06-13 20:24:19 +00001426 continue;
Kyle Butt02d8d052016-07-29 18:09:28 +00001427 // Do backward checking.
1428 // For all cases above, we need a backward checking to filter out edges that
Kyle Buttb15c0662017-01-31 23:48:32 +00001429 // are not 'strongly' biased.
Xinliang David Licbf12142016-06-13 20:24:19 +00001430 // BB Pred
1431 // \ /
1432 // Succ
Sjoerd Meijerfd0ad4e2016-07-15 18:41:56 +00001433 // We select edge BB->Succ if
Xinliang David Licbf12142016-06-13 20:24:19 +00001434 // freq(BB->Succ) > freq(Succ) * HotProb
1435 // i.e. freq(BB->Succ) > freq(BB->Succ) * HotProb + freq(Pred->Succ) *
1436 // HotProb
1437 // i.e. freq((BB->Succ) * (1 - HotProb) > freq(Pred->Succ) * HotProb
Kyle Butt02d8d052016-07-29 18:09:28 +00001438 // Case 1 is covered too, because the first equation reduces to:
1439 // prob(BB->Succ) > HotProb. (freq(Succ) = freq(BB) for a triangle)
Xinliang David Licbf12142016-06-13 20:24:19 +00001440 BlockFrequency PredEdgeFreq =
1441 MBFI->getBlockFreq(Pred) * MBPI->getEdgeProbability(Pred, Succ);
1442 if (PredEdgeFreq * HotProb >= CandidateEdgeFreq * HotProb.getCompl()) {
1443 BadCFGConflict = true;
1444 break;
1445 }
1446 }
1447
1448 if (BadCFGConflict) {
Nicola Zaghend34e60c2018-05-14 12:53:11 +00001449 LLVM_DEBUG(dbgs() << " Not a candidate: " << getBlockName(Succ) << " -> "
1450 << SuccProb << " (prob) (non-cold CFG conflict)\n");
Xinliang David Licbf12142016-06-13 20:24:19 +00001451 return true;
1452 }
1453
1454 return false;
1455}
1456
Adrian Prantl5f8f34e42018-05-01 15:54:18 +00001457/// Select the best successor for a block.
Xinliang David Li594ffa32016-06-11 18:35:40 +00001458///
1459/// This looks across all successors of a particular block and attempts to
1460/// select the "best" one to be the layout successor. It only considers direct
1461/// successors which also pass the block filter. It will attempt to avoid
1462/// breaking CFG structure, but cave and break such structures in the case of
1463/// very hot successor edges.
1464///
Kyle Buttb15c0662017-01-31 23:48:32 +00001465/// \returns The best successor block found, or null if none are viable, along
1466/// with a boolean indicating if tail duplication is necessary.
1467MachineBlockPlacement::BlockAndTailDupResult
Kyle Butte9425c4f2017-02-04 02:26:32 +00001468MachineBlockPlacement::selectBestSuccessor(
1469 const MachineBasicBlock *BB, const BlockChain &Chain,
1470 const BlockFilterSet *BlockFilter) {
Xinliang David Li594ffa32016-06-11 18:35:40 +00001471 const BranchProbability HotProb(StaticLikelyProb, 100);
1472
Kyle Buttb15c0662017-01-31 23:48:32 +00001473 BlockAndTailDupResult BestSucc = { nullptr, false };
Xinliang David Li594ffa32016-06-11 18:35:40 +00001474 auto BestProb = BranchProbability::getZero();
1475
1476 SmallVector<MachineBasicBlock *, 4> Successors;
1477 auto AdjustedSumProb =
1478 collectViableSuccessors(BB, Chain, BlockFilter, Successors);
1479
Nicola Zaghend34e60c2018-05-14 12:53:11 +00001480 LLVM_DEBUG(dbgs() << "Selecting best successor for: " << getBlockName(BB)
1481 << "\n");
Kyle Buttb15c0662017-01-31 23:48:32 +00001482
Kyle Buttebe6cc42017-02-23 21:22:24 +00001483 // if we already precomputed the best successor for BB, return that if still
1484 // applicable.
1485 auto FoundEdge = ComputedEdges.find(BB);
1486 if (FoundEdge != ComputedEdges.end()) {
1487 MachineBasicBlock *Succ = FoundEdge->second.BB;
1488 ComputedEdges.erase(FoundEdge);
Kyle Butt7fbec9b2017-02-15 19:49:14 +00001489 BlockChain *SuccChain = BlockToChain[Succ];
1490 if (BB->isSuccessor(Succ) && (!BlockFilter || BlockFilter->count(Succ)) &&
Kyle Buttebe6cc42017-02-23 21:22:24 +00001491 SuccChain != &Chain && Succ == *SuccChain->begin())
1492 return FoundEdge->second;
Kyle Butt7fbec9b2017-02-15 19:49:14 +00001493 }
1494
1495 // if BB is part of a trellis, Use the trellis to determine the optimal
1496 // fallthrough edges
1497 if (isTrellis(BB, Successors, Chain, BlockFilter))
1498 return getBestTrellisSuccessor(BB, Successors, AdjustedSumProb, Chain,
1499 BlockFilter);
1500
Kyle Buttb15c0662017-01-31 23:48:32 +00001501 // For blocks with CFG violations, we may be able to lay them out anyway with
1502 // tail-duplication. We keep this vector so we can perform the probability
1503 // calculations the minimum number of times.
1504 SmallVector<std::tuple<BranchProbability, MachineBasicBlock *>, 4>
1505 DupCandidates;
Cong Hou41cf1a52015-11-18 00:52:52 +00001506 for (MachineBasicBlock *Succ : Successors) {
Xinliang David Li594ffa32016-06-11 18:35:40 +00001507 auto RealSuccProb = MBPI->getEdgeProbability(BB, Succ);
1508 BranchProbability SuccProb =
1509 getAdjustedProbability(RealSuccProb, AdjustedSumProb);
Chandler Carruthb3361722011-11-13 11:34:53 +00001510
Cong Hou41cf1a52015-11-18 00:52:52 +00001511 BlockChain &SuccChain = *BlockToChain[Succ];
Xinliang David Licbf12142016-06-13 20:24:19 +00001512 // Skip the edge \c BB->Succ if block \c Succ has a better layout
1513 // predecessor that yields lower global cost.
1514 if (hasBetterLayoutPredecessor(BB, Succ, SuccChain, SuccProb, RealSuccProb,
Kyle Buttb15c0662017-01-31 23:48:32 +00001515 Chain, BlockFilter)) {
1516 // If tail duplication would make Succ profitable, place it.
Tim Shen1a8c6772018-03-30 17:51:00 +00001517 if (allowTailDupPlacement() && shouldTailDuplicate(Succ))
Kyle Buttb15c0662017-01-31 23:48:32 +00001518 DupCandidates.push_back(std::make_tuple(SuccProb, Succ));
Xinliang David Licbf12142016-06-13 20:24:19 +00001519 continue;
Kyle Buttb15c0662017-01-31 23:48:32 +00001520 }
Chandler Carruth18dfac32011-11-20 11:22:06 +00001521
Nicola Zaghend34e60c2018-05-14 12:53:11 +00001522 LLVM_DEBUG(
1523 dbgs() << " Candidate: " << getBlockName(Succ)
1524 << ", probability: " << SuccProb
Xinliang David Licbf12142016-06-13 20:24:19 +00001525 << (SuccChain.UnscheduledPredecessors != 0 ? " (CFG break)" : "")
1526 << "\n");
Sjoerd Meijer5e11a182016-07-27 08:49:23 +00001527
Kyle Buttb15c0662017-01-31 23:48:32 +00001528 if (BestSucc.BB && BestProb >= SuccProb) {
Nicola Zaghend34e60c2018-05-14 12:53:11 +00001529 LLVM_DEBUG(dbgs() << " Not the best candidate, continuing\n");
Chandler Carruthb3361722011-11-13 11:34:53 +00001530 continue;
Sjoerd Meijer5e11a182016-07-27 08:49:23 +00001531 }
1532
Nicola Zaghend34e60c2018-05-14 12:53:11 +00001533 LLVM_DEBUG(dbgs() << " Setting it as best candidate\n");
Kyle Buttb15c0662017-01-31 23:48:32 +00001534 BestSucc.BB = Succ;
Cong Houd97c1002015-12-01 05:29:22 +00001535 BestProb = SuccProb;
Chandler Carruthb3361722011-11-13 11:34:53 +00001536 }
Kyle Buttb15c0662017-01-31 23:48:32 +00001537 // Handle the tail duplication candidates in order of decreasing probability.
1538 // Stop at the first one that is profitable. Also stop if they are less
1539 // profitable than BestSucc. Position is important because we preserve it and
1540 // prefer first best match. Here we aren't comparing in order, so we capture
1541 // the position instead.
Fangrui Songefd94c52019-04-23 14:51:27 +00001542 llvm::stable_sort(DupCandidates,
1543 [](std::tuple<BranchProbability, MachineBasicBlock *> L,
1544 std::tuple<BranchProbability, MachineBasicBlock *> R) {
1545 return std::get<0>(L) > std::get<0>(R);
1546 });
1547 for (auto &Tup : DupCandidates) {
Kyle Buttb15c0662017-01-31 23:48:32 +00001548 BranchProbability DupProb;
1549 MachineBasicBlock *Succ;
1550 std::tie(DupProb, Succ) = Tup;
1551 if (DupProb < BestProb)
1552 break;
1553 if (canTailDuplicateUnplacedPreds(BB, Succ, Chain, BlockFilter)
Kyle Butt7e8be282017-04-10 22:28:22 +00001554 && (isProfitableToTailDup(BB, Succ, BestProb, Chain, BlockFilter))) {
Nicola Zaghend34e60c2018-05-14 12:53:11 +00001555 LLVM_DEBUG(dbgs() << " Candidate: " << getBlockName(Succ)
1556 << ", probability: " << DupProb
1557 << " (Tail Duplicate)\n");
Kyle Buttb15c0662017-01-31 23:48:32 +00001558 BestSucc.BB = Succ;
1559 BestSucc.ShouldTailDup = true;
1560 break;
1561 }
1562 }
1563
1564 if (BestSucc.BB)
Nicola Zaghend34e60c2018-05-14 12:53:11 +00001565 LLVM_DEBUG(dbgs() << " Selected: " << getBlockName(BestSucc.BB) << "\n");
Sjoerd Meijer5e11a182016-07-27 08:49:23 +00001566
Chandler Carruthb3361722011-11-13 11:34:53 +00001567 return BestSucc;
1568}
1569
Adrian Prantl5f8f34e42018-05-01 15:54:18 +00001570/// Select the best block from a worklist.
Chandler Carruthf9213fe2011-11-13 11:42:26 +00001571///
1572/// This looks through the provided worklist as a list of candidate basic
1573/// blocks and select the most profitable one to place. The definition of
1574/// profitable only really makes sense in the context of a loop. This returns
1575/// the most frequently visited block in the worklist, which in the case of
1576/// a loop, is the one most desirable to be physically close to the rest of the
Sjoerd Meijerfd0ad4e2016-07-15 18:41:56 +00001577/// loop body in order to improve i-cache behavior.
Chandler Carruthf9213fe2011-11-13 11:42:26 +00001578///
1579/// \returns The best block found, or null if none are viable.
1580MachineBasicBlock *MachineBlockPlacement::selectBestCandidateBlock(
Kyle Butte9425c4f2017-02-04 02:26:32 +00001581 const BlockChain &Chain, SmallVectorImpl<MachineBasicBlock *> &WorkList) {
Chandler Carruth0af6a0b2011-11-14 09:46:33 +00001582 // Once we need to walk the worklist looking for a candidate, cleanup the
1583 // worklist of already placed entries.
1584 // FIXME: If this shows up on profiles, it could be folded (at the cost of
1585 // some code complexity) into the loop below.
Eugene Zelenko5df3d892017-08-24 21:21:39 +00001586 WorkList.erase(llvm::remove_if(WorkList,
1587 [&](MachineBasicBlock *BB) {
1588 return BlockToChain.lookup(BB) == &Chain;
1589 }),
Chandler Carruth0af6a0b2011-11-14 09:46:33 +00001590 WorkList.end());
1591
Amaury Sechetc53ad4f2016-04-07 21:29:39 +00001592 if (WorkList.empty())
1593 return nullptr;
1594
1595 bool IsEHPad = WorkList[0]->isEHPad();
1596
Craig Topperc0196b12014-04-14 00:51:57 +00001597 MachineBasicBlock *BestBlock = nullptr;
Chandler Carruthf9213fe2011-11-13 11:42:26 +00001598 BlockFrequency BestFreq;
Chandler Carruth7a715da2015-03-05 03:19:05 +00001599 for (MachineBasicBlock *MBB : WorkList) {
Kyle Butt0cf5b2f2017-05-17 23:44:41 +00001600 assert(MBB->isEHPad() == IsEHPad &&
1601 "EHPad mismatch between block and work list.");
Amaury Sechetc53ad4f2016-04-07 21:29:39 +00001602
Chandler Carruth7a715da2015-03-05 03:19:05 +00001603 BlockChain &SuccChain = *BlockToChain[MBB];
Philip Reames02e11322016-03-02 22:40:51 +00001604 if (&SuccChain == &Chain)
Chandler Carruthf9213fe2011-11-13 11:42:26 +00001605 continue;
Junmo Park4ba6cf62016-03-11 05:07:07 +00001606
Kyle Butt0cf5b2f2017-05-17 23:44:41 +00001607 assert(SuccChain.UnscheduledPredecessors == 0 &&
1608 "Found CFG-violating block");
Chandler Carruthf9213fe2011-11-13 11:42:26 +00001609
Chandler Carruth7a715da2015-03-05 03:19:05 +00001610 BlockFrequency CandidateFreq = MBFI->getBlockFreq(MBB);
Nicola Zaghend34e60c2018-05-14 12:53:11 +00001611 LLVM_DEBUG(dbgs() << " " << getBlockName(MBB) << " -> ";
1612 MBFI->printBlockFreq(dbgs(), CandidateFreq) << " (freq)\n");
Amaury Sechetc53ad4f2016-04-07 21:29:39 +00001613
1614 // For ehpad, we layout the least probable first as to avoid jumping back
1615 // from least probable landingpads to more probable ones.
1616 //
1617 // FIXME: Using probability is probably (!) not the best way to achieve
1618 // this. We should probably have a more principled approach to layout
1619 // cleanup code.
1620 //
1621 // The goal is to get:
1622 //
1623 // +--------------------------+
1624 // | V
1625 // InnerLp -> InnerCleanup OuterLp -> OuterCleanup -> Resume
1626 //
1627 // Rather than:
1628 //
1629 // +-------------------------------------+
1630 // V |
1631 // OuterLp -> OuterCleanup -> Resume InnerLp -> InnerCleanup
1632 if (BestBlock && (IsEHPad ^ (BestFreq >= CandidateFreq)))
Chandler Carruthf9213fe2011-11-13 11:42:26 +00001633 continue;
Amaury Sechetc53ad4f2016-04-07 21:29:39 +00001634
Chandler Carruth7a715da2015-03-05 03:19:05 +00001635 BestBlock = MBB;
Chandler Carruthf9213fe2011-11-13 11:42:26 +00001636 BestFreq = CandidateFreq;
1637 }
Amaury Sechetc53ad4f2016-04-07 21:29:39 +00001638
Chandler Carruthf9213fe2011-11-13 11:42:26 +00001639 return BestBlock;
1640}
1641
Adrian Prantl5f8f34e42018-05-01 15:54:18 +00001642/// Retrieve the first unplaced basic block.
Chandler Carruth1071cfa2011-11-14 00:00:35 +00001643///
1644/// This routine is called when we are unable to use the CFG to walk through
1645/// all of the basic blocks and form a chain due to unnatural loops in the CFG.
Chandler Carruth9b548a7f2011-11-15 06:26:43 +00001646/// We walk through the function's blocks in order, starting from the
1647/// LastUnplacedBlockIt. We update this iterator on each call to avoid
1648/// re-scanning the entire sequence on repeated calls to this routine.
Chandler Carruth1071cfa2011-11-14 00:00:35 +00001649MachineBasicBlock *MachineBlockPlacement::getFirstUnplacedBlock(
Xinliang David Li52530a72016-06-13 22:23:44 +00001650 const BlockChain &PlacedChain,
Chandler Carruth9b548a7f2011-11-15 06:26:43 +00001651 MachineFunction::iterator &PrevUnplacedBlockIt,
Jakub Staszak90616162011-12-21 23:02:08 +00001652 const BlockFilterSet *BlockFilter) {
Xinliang David Li52530a72016-06-13 22:23:44 +00001653 for (MachineFunction::iterator I = PrevUnplacedBlockIt, E = F->end(); I != E;
Chandler Carruth9b548a7f2011-11-15 06:26:43 +00001654 ++I) {
Duncan P. N. Exon Smith6ac07fd2015-10-09 19:36:12 +00001655 if (BlockFilter && !BlockFilter->count(&*I))
Chandler Carruth9b548a7f2011-11-15 06:26:43 +00001656 continue;
Duncan P. N. Exon Smith6ac07fd2015-10-09 19:36:12 +00001657 if (BlockToChain[&*I] != &PlacedChain) {
Chandler Carruth9b548a7f2011-11-15 06:26:43 +00001658 PrevUnplacedBlockIt = I;
Chandler Carruth4a87aa02011-11-23 03:03:21 +00001659 // Now select the head of the chain to which the unplaced block belongs
1660 // as the block to place. This will force the entire chain to be placed,
1661 // and satisfies the requirements of merging chains.
Duncan P. N. Exon Smith6ac07fd2015-10-09 19:36:12 +00001662 return *BlockToChain[&*I]->begin();
Chandler Carruth1071cfa2011-11-14 00:00:35 +00001663 }
1664 }
Craig Topperc0196b12014-04-14 00:51:57 +00001665 return nullptr;
Chandler Carruth1071cfa2011-11-14 00:00:35 +00001666}
1667
Amaury Secheteae09c22016-03-14 21:24:11 +00001668void MachineBlockPlacement::fillWorkLists(
Kyle Butte9425c4f2017-02-04 02:26:32 +00001669 const MachineBasicBlock *MBB,
Amaury Secheteae09c22016-03-14 21:24:11 +00001670 SmallPtrSetImpl<BlockChain *> &UpdatedPreds,
Amaury Secheteae09c22016-03-14 21:24:11 +00001671 const BlockFilterSet *BlockFilter = nullptr) {
1672 BlockChain &Chain = *BlockToChain[MBB];
1673 if (!UpdatedPreds.insert(&Chain).second)
1674 return;
1675
Kyle Butt0cf5b2f2017-05-17 23:44:41 +00001676 assert(
1677 Chain.UnscheduledPredecessors == 0 &&
1678 "Attempting to place block with unscheduled predecessors in worklist.");
Amaury Secheteae09c22016-03-14 21:24:11 +00001679 for (MachineBasicBlock *ChainBB : Chain) {
Kyle Butt0cf5b2f2017-05-17 23:44:41 +00001680 assert(BlockToChain[ChainBB] == &Chain &&
1681 "Block in chain doesn't match BlockToChain map.");
Amaury Secheteae09c22016-03-14 21:24:11 +00001682 for (MachineBasicBlock *Pred : ChainBB->predecessors()) {
1683 if (BlockFilter && !BlockFilter->count(Pred))
1684 continue;
1685 if (BlockToChain[Pred] == &Chain)
1686 continue;
1687 ++Chain.UnscheduledPredecessors;
1688 }
1689 }
1690
Amaury Sechetc53ad4f2016-04-07 21:29:39 +00001691 if (Chain.UnscheduledPredecessors != 0)
1692 return;
1693
Kyle Butte9425c4f2017-02-04 02:26:32 +00001694 MachineBasicBlock *BB = *Chain.begin();
1695 if (BB->isEHPad())
1696 EHPadWorkList.push_back(BB);
Amaury Sechetc53ad4f2016-04-07 21:29:39 +00001697 else
Kyle Butte9425c4f2017-02-04 02:26:32 +00001698 BlockWorkList.push_back(BB);
Amaury Secheteae09c22016-03-14 21:24:11 +00001699}
1700
Chandler Carruth8d150782011-11-13 11:20:44 +00001701void MachineBlockPlacement::buildChain(
Kyle Butte9425c4f2017-02-04 02:26:32 +00001702 const MachineBasicBlock *HeadBB, BlockChain &Chain,
Kyle Butt0846e562016-10-11 20:36:43 +00001703 BlockFilterSet *BlockFilter) {
Kyle Butte9425c4f2017-02-04 02:26:32 +00001704 assert(HeadBB && "BB must not be null.\n");
1705 assert(BlockToChain[HeadBB] == &Chain && "BlockToChainMap mis-match.\n");
Xinliang David Li52530a72016-06-13 22:23:44 +00001706 MachineFunction::iterator PrevUnplacedBlockIt = F->begin();
Chandler Carruth1071cfa2011-11-14 00:00:35 +00001707
Kyle Butte9425c4f2017-02-04 02:26:32 +00001708 const MachineBasicBlock *LoopHeaderBB = HeadBB;
Xinliang David Li93926ac2016-07-01 05:46:48 +00001709 markChainSuccessors(Chain, LoopHeaderBB, BlockFilter);
Kyle Butte9425c4f2017-02-04 02:26:32 +00001710 MachineBasicBlock *BB = *std::prev(Chain.end());
Eugene Zelenko5df3d892017-08-24 21:21:39 +00001711 while (true) {
Kyle Butt82c22902016-06-28 22:50:54 +00001712 assert(BB && "null block found at end of chain in loop.");
1713 assert(BlockToChain[BB] == &Chain && "BlockToChainMap mis-match in loop.");
1714 assert(*std::prev(Chain.end()) == BB && "BB Not found at end of chain.");
1715
Chandler Carruthbd1be4d2011-10-23 09:18:45 +00001716
Chandler Carruthf3dc9ef2011-11-19 10:26:02 +00001717 // Look for the best viable successor if there is one to place immediately
1718 // after this block.
Kyle Buttb15c0662017-01-31 23:48:32 +00001719 auto Result = selectBestSuccessor(BB, Chain, BlockFilter);
1720 MachineBasicBlock* BestSucc = Result.BB;
1721 bool ShouldTailDup = Result.ShouldTailDup;
Tim Shen1a8c6772018-03-30 17:51:00 +00001722 if (allowTailDupPlacement())
Kyle Buttb15c0662017-01-31 23:48:32 +00001723 ShouldTailDup |= (BestSucc && shouldTailDuplicate(BestSucc));
Chandler Carruth8d150782011-11-13 11:20:44 +00001724
1725 // If an immediate successor isn't available, look for the best viable
1726 // block among those we've identified as not violating the loop's CFG at
1727 // this point. This won't be a fallthrough, but it will increase locality.
Chandler Carruthf9213fe2011-11-13 11:42:26 +00001728 if (!BestSucc)
Amaury Sechet9ee4ddd2016-04-07 06:34:47 +00001729 BestSucc = selectBestCandidateBlock(Chain, BlockWorkList);
Amaury Sechetc53ad4f2016-04-07 21:29:39 +00001730 if (!BestSucc)
1731 BestSucc = selectBestCandidateBlock(Chain, EHPadWorkList);
Chandler Carruth8d150782011-11-13 11:20:44 +00001732
Chandler Carruth8d150782011-11-13 11:20:44 +00001733 if (!BestSucc) {
Xinliang David Li52530a72016-06-13 22:23:44 +00001734 BestSucc = getFirstUnplacedBlock(Chain, PrevUnplacedBlockIt, BlockFilter);
Chandler Carruth1071cfa2011-11-14 00:00:35 +00001735 if (!BestSucc)
1736 break;
1737
Nicola Zaghend34e60c2018-05-14 12:53:11 +00001738 LLVM_DEBUG(dbgs() << "Unnatural loop CFG detected, forcibly merging the "
1739 "layout successor until the CFG reduces\n");
Chandler Carruth8d150782011-11-13 11:20:44 +00001740 }
Chandler Carruthbd1be4d2011-10-23 09:18:45 +00001741
Kyle Butt0846e562016-10-11 20:36:43 +00001742 // Placement may have changed tail duplication opportunities.
1743 // Check for that now.
Tim Shen1a8c6772018-03-30 17:51:00 +00001744 if (allowTailDupPlacement() && BestSucc && ShouldTailDup) {
Kyle Butt0846e562016-10-11 20:36:43 +00001745 // If the chosen successor was duplicated into all its predecessors,
1746 // don't bother laying it out, just go round the loop again with BB as
1747 // the chain end.
1748 if (repeatedlyTailDuplicateBlock(BestSucc, BB, LoopHeaderBB, Chain,
1749 BlockFilter, PrevUnplacedBlockIt))
1750 continue;
1751 }
1752
Chandler Carruth8d150782011-11-13 11:20:44 +00001753 // Place this block, updating the datastructures to reflect its placement.
Jakub Staszak90616162011-12-21 23:02:08 +00001754 BlockChain &SuccChain = *BlockToChain[BestSucc];
Philip Reamesae27b232016-03-03 00:58:43 +00001755 // Zero out UnscheduledPredecessors for the successor we're about to merge in case
Chandler Carruth1071cfa2011-11-14 00:00:35 +00001756 // we selected a successor that didn't fit naturally into the CFG.
Philip Reamesae27b232016-03-03 00:58:43 +00001757 SuccChain.UnscheduledPredecessors = 0;
Nicola Zaghend34e60c2018-05-14 12:53:11 +00001758 LLVM_DEBUG(dbgs() << "Merging from " << getBlockName(BB) << " to "
1759 << getBlockName(BestSucc) << "\n");
Xinliang David Li93926ac2016-07-01 05:46:48 +00001760 markChainSuccessors(SuccChain, LoopHeaderBB, BlockFilter);
Chandler Carruth8d150782011-11-13 11:20:44 +00001761 Chain.merge(BestSucc, &SuccChain);
Benjamin Kramerb6d0bd42014-03-02 12:27:27 +00001762 BB = *std::prev(Chain.end());
Jakub Staszak190c7122011-12-07 19:46:10 +00001763 }
Chandler Carruth1071cfa2011-11-14 00:00:35 +00001764
Nicola Zaghend34e60c2018-05-14 12:53:11 +00001765 LLVM_DEBUG(dbgs() << "Finished forming chain for header block "
1766 << getBlockName(*Chain.begin()) << "\n");
Chandler Carruth10281422011-10-21 06:46:38 +00001767}
1768
Guozhi Wei81f3fd42019-01-25 19:45:13 +00001769// If bottom of block BB has only one successor OldTop, in most cases it is
1770// profitable to move it before OldTop, except the following case:
1771//
1772// -->OldTop<-
1773// | . |
1774// | . |
1775// | . |
1776// ---Pred |
1777// | |
1778// BB-----
1779//
1780// If BB is moved before OldTop, Pred needs a taken branch to BB, and it can't
1781// layout the other successor below it, so it can't reduce taken branch.
1782// In this case we keep its original layout.
1783bool
1784MachineBlockPlacement::canMoveBottomBlockToTop(
1785 const MachineBasicBlock *BottomBlock,
1786 const MachineBasicBlock *OldTop) {
1787 if (BottomBlock->pred_size() != 1)
1788 return true;
1789 MachineBasicBlock *Pred = *BottomBlock->pred_begin();
1790 if (Pred->succ_size() != 2)
1791 return true;
1792
1793 MachineBasicBlock *OtherBB = *Pred->succ_begin();
1794 if (OtherBB == BottomBlock)
1795 OtherBB = *Pred->succ_rbegin();
1796 if (OtherBB == OldTop)
1797 return false;
1798
1799 return true;
1800}
1801
Guozhi Weid2210af2019-06-14 23:08:59 +00001802// Find out the possible fall through frequence to the top of a loop.
1803BlockFrequency
1804MachineBlockPlacement::TopFallThroughFreq(
1805 const MachineBasicBlock *Top,
1806 const BlockFilterSet &LoopBlockSet) {
1807 BlockFrequency MaxFreq = 0;
1808 for (MachineBasicBlock *Pred : Top->predecessors()) {
1809 BlockChain *PredChain = BlockToChain[Pred];
1810 if (!LoopBlockSet.count(Pred) &&
1811 (!PredChain || Pred == *std::prev(PredChain->end()))) {
1812 // Found a Pred block can be placed before Top.
1813 // Check if Top is the best successor of Pred.
1814 auto TopProb = MBPI->getEdgeProbability(Pred, Top);
1815 bool TopOK = true;
1816 for (MachineBasicBlock *Succ : Pred->successors()) {
1817 auto SuccProb = MBPI->getEdgeProbability(Pred, Succ);
1818 BlockChain *SuccChain = BlockToChain[Succ];
1819 // Check if Succ can be placed after Pred.
1820 // Succ should not be in any chain, or it is the head of some chain.
1821 if (!LoopBlockSet.count(Succ) && (SuccProb > TopProb) &&
1822 (!SuccChain || Succ == *SuccChain->begin())) {
1823 TopOK = false;
1824 break;
1825 }
1826 }
1827 if (TopOK) {
1828 BlockFrequency EdgeFreq = MBFI->getBlockFreq(Pred) *
1829 MBPI->getEdgeProbability(Pred, Top);
1830 if (EdgeFreq > MaxFreq)
1831 MaxFreq = EdgeFreq;
1832 }
1833 }
1834 }
1835 return MaxFreq;
1836}
1837
1838// Compute the fall through gains when move NewTop before OldTop.
1839//
1840// In following diagram, edges marked as "-" are reduced fallthrough, edges
1841// marked as "+" are increased fallthrough, this function computes
1842//
1843// SUM(increased fallthrough) - SUM(decreased fallthrough)
1844//
1845// |
1846// | -
1847// V
1848// --->OldTop
1849// | .
1850// | .
1851// +| . +
1852// | Pred --->
1853// | |-
1854// | V
1855// --- NewTop <---
1856// |-
1857// V
1858//
1859BlockFrequency
1860MachineBlockPlacement::FallThroughGains(
1861 const MachineBasicBlock *NewTop,
1862 const MachineBasicBlock *OldTop,
1863 const MachineBasicBlock *ExitBB,
1864 const BlockFilterSet &LoopBlockSet) {
1865 BlockFrequency FallThrough2Top = TopFallThroughFreq(OldTop, LoopBlockSet);
1866 BlockFrequency FallThrough2Exit = 0;
1867 if (ExitBB)
1868 FallThrough2Exit = MBFI->getBlockFreq(NewTop) *
1869 MBPI->getEdgeProbability(NewTop, ExitBB);
1870 BlockFrequency BackEdgeFreq = MBFI->getBlockFreq(NewTop) *
1871 MBPI->getEdgeProbability(NewTop, OldTop);
1872
1873 // Find the best Pred of NewTop.
1874 MachineBasicBlock *BestPred = nullptr;
1875 BlockFrequency FallThroughFromPred = 0;
1876 for (MachineBasicBlock *Pred : NewTop->predecessors()) {
1877 if (!LoopBlockSet.count(Pred))
1878 continue;
1879 BlockChain *PredChain = BlockToChain[Pred];
1880 if (!PredChain || Pred == *std::prev(PredChain->end())) {
1881 BlockFrequency EdgeFreq = MBFI->getBlockFreq(Pred) *
1882 MBPI->getEdgeProbability(Pred, NewTop);
1883 if (EdgeFreq > FallThroughFromPred) {
1884 FallThroughFromPred = EdgeFreq;
1885 BestPred = Pred;
1886 }
1887 }
1888 }
1889
1890 // If NewTop is not placed after Pred, another successor can be placed
1891 // after Pred.
1892 BlockFrequency NewFreq = 0;
1893 if (BestPred) {
1894 for (MachineBasicBlock *Succ : BestPred->successors()) {
1895 if ((Succ == NewTop) || (Succ == BestPred) || !LoopBlockSet.count(Succ))
1896 continue;
1897 if (ComputedEdges.find(Succ) != ComputedEdges.end())
1898 continue;
1899 BlockChain *SuccChain = BlockToChain[Succ];
1900 if ((SuccChain && (Succ != *SuccChain->begin())) ||
1901 (SuccChain == BlockToChain[BestPred]))
1902 continue;
1903 BlockFrequency EdgeFreq = MBFI->getBlockFreq(BestPred) *
1904 MBPI->getEdgeProbability(BestPred, Succ);
1905 if (EdgeFreq > NewFreq)
1906 NewFreq = EdgeFreq;
1907 }
1908 BlockFrequency OrigEdgeFreq = MBFI->getBlockFreq(BestPred) *
1909 MBPI->getEdgeProbability(BestPred, NewTop);
1910 if (NewFreq > OrigEdgeFreq) {
1911 // If NewTop is not the best successor of Pred, then Pred doesn't
1912 // fallthrough to NewTop. So there is no FallThroughFromPred and
1913 // NewFreq.
1914 NewFreq = 0;
1915 FallThroughFromPred = 0;
1916 }
1917 }
1918
1919 BlockFrequency Result = 0;
1920 BlockFrequency Gains = BackEdgeFreq + NewFreq;
1921 BlockFrequency Lost = FallThrough2Top + FallThrough2Exit +
1922 FallThroughFromPred;
1923 if (Gains > Lost)
1924 Result = Gains - Lost;
1925 return Result;
1926}
1927
1928/// Helper function of findBestLoopTop. Find the best loop top block
1929/// from predecessors of old top.
1930///
1931/// Look for a block which is strictly better than the old top for laying
1932/// out before the old top of the loop. This looks for only two patterns:
1933///
1934/// 1. a block has only one successor, the old loop top
1935///
1936/// Because such a block will always result in an unconditional jump,
1937/// rotating it in front of the old top is always profitable.
1938///
1939/// 2. a block has two successors, one is old top, another is exit
1940/// and it has more than one predecessors
1941///
1942/// If it is below one of its predecessors P, only P can fall through to
1943/// it, all other predecessors need a jump to it, and another conditional
1944/// jump to loop header. If it is moved before loop header, all its
1945/// predecessors jump to it, then fall through to loop header. So all its
1946/// predecessors except P can reduce one taken branch.
1947/// At the same time, move it before old top increases the taken branch
1948/// to loop exit block, so the reduced taken branch will be compared with
1949/// the increased taken branch to the loop exit block.
1950MachineBasicBlock *
1951MachineBlockPlacement::findBestLoopTopHelper(
1952 MachineBasicBlock *OldTop,
1953 const MachineLoop &L,
1954 const BlockFilterSet &LoopBlockSet) {
1955 // Check that the header hasn't been fused with a preheader block due to
1956 // crazy branches. If it has, we need to start with the header at the top to
1957 // prevent pulling the preheader into the loop body.
1958 BlockChain &HeaderChain = *BlockToChain[OldTop];
1959 if (!LoopBlockSet.count(*HeaderChain.begin()))
1960 return OldTop;
1961
1962 LLVM_DEBUG(dbgs() << "Finding best loop top for: " << getBlockName(OldTop)
1963 << "\n");
1964
1965 BlockFrequency BestGains = 0;
1966 MachineBasicBlock *BestPred = nullptr;
1967 for (MachineBasicBlock *Pred : OldTop->predecessors()) {
1968 if (!LoopBlockSet.count(Pred))
1969 continue;
1970 if (Pred == L.getHeader())
1971 continue;
1972 LLVM_DEBUG(dbgs() << " old top pred: " << getBlockName(Pred) << ", has "
1973 << Pred->succ_size() << " successors, ";
1974 MBFI->printBlockFreq(dbgs(), Pred) << " freq\n");
1975 if (Pred->succ_size() > 2)
1976 continue;
1977
1978 MachineBasicBlock *OtherBB = nullptr;
1979 if (Pred->succ_size() == 2) {
1980 OtherBB = *Pred->succ_begin();
1981 if (OtherBB == OldTop)
1982 OtherBB = *Pred->succ_rbegin();
1983 }
1984
1985 if (!canMoveBottomBlockToTop(Pred, OldTop))
1986 continue;
1987
1988 BlockFrequency Gains = FallThroughGains(Pred, OldTop, OtherBB,
1989 LoopBlockSet);
1990 if ((Gains > 0) && (Gains > BestGains ||
1991 ((Gains == BestGains) && Pred->isLayoutSuccessor(OldTop)))) {
1992 BestPred = Pred;
1993 BestGains = Gains;
1994 }
1995 }
1996
1997 // If no direct predecessor is fine, just use the loop header.
1998 if (!BestPred) {
1999 LLVM_DEBUG(dbgs() << " final top unchanged\n");
2000 return OldTop;
2001 }
2002
2003 // Walk backwards through any straight line of predecessors.
2004 while (BestPred->pred_size() == 1 &&
2005 (*BestPred->pred_begin())->succ_size() == 1 &&
2006 *BestPred->pred_begin() != L.getHeader())
2007 BestPred = *BestPred->pred_begin();
2008
2009 LLVM_DEBUG(dbgs() << " final top: " << getBlockName(BestPred) << "\n");
2010 return BestPred;
2011}
2012
Adrian Prantl5f8f34e42018-05-01 15:54:18 +00002013/// Find the best loop top block for layout.
Chandler Carruth9ffb97e2011-11-27 00:38:03 +00002014///
Guozhi Weid2210af2019-06-14 23:08:59 +00002015/// This function iteratively calls findBestLoopTopHelper, until no new better
2016/// BB can be found.
Chandler Carruth8c0b41d2012-04-16 13:33:36 +00002017MachineBasicBlock *
Kyle Butte9425c4f2017-02-04 02:26:32 +00002018MachineBlockPlacement::findBestLoopTop(const MachineLoop &L,
Chandler Carruth8c0b41d2012-04-16 13:33:36 +00002019 const BlockFilterSet &LoopBlockSet) {
Sjoerd Meijer15c81b02016-08-16 19:50:33 +00002020 // Placing the latch block before the header may introduce an extra branch
2021 // that skips this block the first time the loop is executed, which we want
2022 // to avoid when optimising for size.
2023 // FIXME: in theory there is a case that does not introduce a new branch,
2024 // i.e. when the layout predecessor does not fallthrough to the loop header.
2025 // In practice this never happens though: there always seems to be a preheader
2026 // that can fallthrough and that is also placed before the header.
Evandro Menezes85bd3972019-04-04 22:40:06 +00002027 if (F->getFunction().hasOptSize())
Sjoerd Meijer15c81b02016-08-16 19:50:33 +00002028 return L.getHeader();
2029
Guozhi Weid2210af2019-06-14 23:08:59 +00002030 MachineBasicBlock *OldTop = nullptr;
2031 MachineBasicBlock *NewTop = L.getHeader();
2032 while (NewTop != OldTop) {
2033 OldTop = NewTop;
2034 NewTop = findBestLoopTopHelper(OldTop, L, LoopBlockSet);
2035 if (NewTop != OldTop)
2036 ComputedEdges[NewTop] = { OldTop, false };
Chandler Carruth8c0b41d2012-04-16 13:33:36 +00002037 }
Guozhi Weid2210af2019-06-14 23:08:59 +00002038 return NewTop;
Chandler Carruth8c0b41d2012-04-16 13:33:36 +00002039}
2040
Adrian Prantl5f8f34e42018-05-01 15:54:18 +00002041/// Find the best loop exiting block for layout.
Chandler Carruth8c0b41d2012-04-16 13:33:36 +00002042///
Chandler Carruth03adbd42011-11-27 13:34:33 +00002043/// This routine implements the logic to analyze the loop looking for the best
2044/// block to layout at the top of the loop. Typically this is done to maximize
2045/// fallthrough opportunities.
2046MachineBasicBlock *
Kyle Butte9425c4f2017-02-04 02:26:32 +00002047MachineBlockPlacement::findBestLoopExit(const MachineLoop &L,
Guozhi Weid2210af2019-06-14 23:08:59 +00002048 const BlockFilterSet &LoopBlockSet,
2049 BlockFrequency &ExitFreq) {
Chandler Carruth68062612012-04-10 13:35:57 +00002050 // We don't want to layout the loop linearly in all cases. If the loop header
2051 // is just a normal basic block in the loop, we want to look for what block
2052 // within the loop is the best one to layout at the top. However, if the loop
2053 // header has be pre-merged into a chain due to predecessors not having
2054 // analyzable branches, *and* the predecessor it is merged with is *not* part
2055 // of the loop, rotating the header into the middle of the loop will create
2056 // a non-contiguous range of blocks which is Very Bad. So start with the
2057 // header and only rotate if safe.
2058 BlockChain &HeaderChain = *BlockToChain[L.getHeader()];
2059 if (!LoopBlockSet.count(*HeaderChain.begin()))
Craig Topperc0196b12014-04-14 00:51:57 +00002060 return nullptr;
Chandler Carruth68062612012-04-10 13:35:57 +00002061
Chandler Carruth03adbd42011-11-27 13:34:33 +00002062 BlockFrequency BestExitEdgeFreq;
Chandler Carruthccc7e422012-04-16 01:12:56 +00002063 unsigned BestExitLoopDepth = 0;
Craig Topperc0196b12014-04-14 00:51:57 +00002064 MachineBasicBlock *ExitingBB = nullptr;
Chandler Carruth4f567202011-11-27 20:18:00 +00002065 // If there are exits to outer loops, loop rotation can severely limit
Sjoerd Meijerfd0ad4e2016-07-15 18:41:56 +00002066 // fallthrough opportunities unless it selects such an exit. Keep a set of
Chandler Carruth4f567202011-11-27 20:18:00 +00002067 // blocks where rotating to exit with that block will reach an outer loop.
2068 SmallPtrSet<MachineBasicBlock *, 4> BlocksExitingToOuterLoop;
2069
Nicola Zaghend34e60c2018-05-14 12:53:11 +00002070 LLVM_DEBUG(dbgs() << "Finding best loop exit for: "
2071 << getBlockName(L.getHeader()) << "\n");
Chandler Carruth7a715da2015-03-05 03:19:05 +00002072 for (MachineBasicBlock *MBB : L.getBlocks()) {
2073 BlockChain &Chain = *BlockToChain[MBB];
Chandler Carruth03adbd42011-11-27 13:34:33 +00002074 // Ensure that this block is at the end of a chain; otherwise it could be
Chandler Carruth9a512a42015-04-15 13:19:54 +00002075 // mid-way through an inner loop or a successor of an unanalyzable branch.
Chandler Carruth7a715da2015-03-05 03:19:05 +00002076 if (MBB != *std::prev(Chain.end()))
Chandler Carruth9ffb97e2011-11-27 00:38:03 +00002077 continue;
Chandler Carruth9ffb97e2011-11-27 00:38:03 +00002078
Chandler Carruth03adbd42011-11-27 13:34:33 +00002079 // Now walk the successors. We need to establish whether this has a viable
2080 // exiting successor and whether it has a viable non-exiting successor.
2081 // We store the old exiting state and restore it if a viable looping
2082 // successor isn't found.
2083 MachineBasicBlock *OldExitingBB = ExitingBB;
2084 BlockFrequency OldBestExitEdgeFreq = BestExitEdgeFreq;
Chandler Carruthccc7e422012-04-16 01:12:56 +00002085 bool HasLoopingSucc = false;
Chandler Carruth7a715da2015-03-05 03:19:05 +00002086 for (MachineBasicBlock *Succ : MBB->successors()) {
Reid Kleckner0e288232015-08-27 23:27:47 +00002087 if (Succ->isEHPad())
Chandler Carruth03adbd42011-11-27 13:34:33 +00002088 continue;
Chandler Carruth7a715da2015-03-05 03:19:05 +00002089 if (Succ == MBB)
Chandler Carruth03adbd42011-11-27 13:34:33 +00002090 continue;
Chandler Carruth7a715da2015-03-05 03:19:05 +00002091 BlockChain &SuccChain = *BlockToChain[Succ];
Chandler Carruth03adbd42011-11-27 13:34:33 +00002092 // Don't split chains, either this chain or the successor's chain.
Chandler Carruthccc7e422012-04-16 01:12:56 +00002093 if (&Chain == &SuccChain) {
Nicola Zaghend34e60c2018-05-14 12:53:11 +00002094 LLVM_DEBUG(dbgs() << " exiting: " << getBlockName(MBB) << " -> "
2095 << getBlockName(Succ) << " (chain conflict)\n");
Chandler Carruth03adbd42011-11-27 13:34:33 +00002096 continue;
2097 }
2098
Cong Houd97c1002015-12-01 05:29:22 +00002099 auto SuccProb = MBPI->getEdgeProbability(MBB, Succ);
Chandler Carruth7a715da2015-03-05 03:19:05 +00002100 if (LoopBlockSet.count(Succ)) {
Nicola Zaghend34e60c2018-05-14 12:53:11 +00002101 LLVM_DEBUG(dbgs() << " looping: " << getBlockName(MBB) << " -> "
2102 << getBlockName(Succ) << " (" << SuccProb << ")\n");
Chandler Carruthccc7e422012-04-16 01:12:56 +00002103 HasLoopingSucc = true;
Chandler Carruth03adbd42011-11-27 13:34:33 +00002104 continue;
2105 }
2106
Chandler Carruthccc7e422012-04-16 01:12:56 +00002107 unsigned SuccLoopDepth = 0;
Chandler Carruth7a715da2015-03-05 03:19:05 +00002108 if (MachineLoop *ExitLoop = MLI->getLoopFor(Succ)) {
Chandler Carruthccc7e422012-04-16 01:12:56 +00002109 SuccLoopDepth = ExitLoop->getLoopDepth();
2110 if (ExitLoop->contains(&L))
Chandler Carruth7a715da2015-03-05 03:19:05 +00002111 BlocksExitingToOuterLoop.insert(MBB);
Chandler Carruthccc7e422012-04-16 01:12:56 +00002112 }
2113
Chandler Carruth7a715da2015-03-05 03:19:05 +00002114 BlockFrequency ExitEdgeFreq = MBFI->getBlockFreq(MBB) * SuccProb;
Nicola Zaghend34e60c2018-05-14 12:53:11 +00002115 LLVM_DEBUG(dbgs() << " exiting: " << getBlockName(MBB) << " -> "
2116 << getBlockName(Succ) << " [L:" << SuccLoopDepth
2117 << "] (";
2118 MBFI->printBlockFreq(dbgs(), ExitEdgeFreq) << ")\n");
Benjamin Kramerc8160d62013-11-20 19:08:44 +00002119 // Note that we bias this toward an existing layout successor to retain
2120 // incoming order in the absence of better information. The exit must have
2121 // a frequency higher than the current exit before we consider breaking
2122 // the layout.
2123 BranchProbability Bias(100 - ExitBlockBias, 100);
Chandler Carruth26d30172015-04-15 13:39:42 +00002124 if (!ExitingBB || SuccLoopDepth > BestExitLoopDepth ||
Chandler Carruthccc7e422012-04-16 01:12:56 +00002125 ExitEdgeFreq > BestExitEdgeFreq ||
Chandler Carruth7a715da2015-03-05 03:19:05 +00002126 (MBB->isLayoutSuccessor(Succ) &&
Benjamin Kramerc8160d62013-11-20 19:08:44 +00002127 !(ExitEdgeFreq < BestExitEdgeFreq * Bias))) {
Chandler Carruth03adbd42011-11-27 13:34:33 +00002128 BestExitEdgeFreq = ExitEdgeFreq;
Chandler Carruth7a715da2015-03-05 03:19:05 +00002129 ExitingBB = MBB;
Chandler Carrutha0545802011-11-27 09:22:53 +00002130 }
Chandler Carruth9ffb97e2011-11-27 00:38:03 +00002131 }
Chandler Carruth03adbd42011-11-27 13:34:33 +00002132
Chandler Carruthccc7e422012-04-16 01:12:56 +00002133 if (!HasLoopingSucc) {
Chandler Carruthcfb2b9d2015-04-15 13:26:41 +00002134 // Restore the old exiting state, no viable looping successor was found.
Chandler Carruth03adbd42011-11-27 13:34:33 +00002135 ExitingBB = OldExitingBB;
2136 BestExitEdgeFreq = OldBestExitEdgeFreq;
Chandler Carruth03adbd42011-11-27 13:34:33 +00002137 }
Chandler Carruth9ffb97e2011-11-27 00:38:03 +00002138 }
Chandler Carruthccc7e422012-04-16 01:12:56 +00002139 // Without a candidate exiting block or with only a single block in the
Chandler Carruth03adbd42011-11-27 13:34:33 +00002140 // loop, just use the loop header to layout the loop.
Sjoerd Meijer5e11a182016-07-27 08:49:23 +00002141 if (!ExitingBB) {
Nicola Zaghend34e60c2018-05-14 12:53:11 +00002142 LLVM_DEBUG(
2143 dbgs() << " No other candidate exit blocks, using loop header\n");
Craig Topperc0196b12014-04-14 00:51:57 +00002144 return nullptr;
Sjoerd Meijer5e11a182016-07-27 08:49:23 +00002145 }
2146 if (L.getNumBlocks() == 1) {
Nicola Zaghend34e60c2018-05-14 12:53:11 +00002147 LLVM_DEBUG(dbgs() << " Loop has 1 block, using loop header as exit\n");
Sjoerd Meijer5e11a182016-07-27 08:49:23 +00002148 return nullptr;
2149 }
Chandler Carruth9ffb97e2011-11-27 00:38:03 +00002150
Chandler Carruth4f567202011-11-27 20:18:00 +00002151 // Also, if we have exit blocks which lead to outer loops but didn't select
2152 // one of them as the exiting block we are rotating toward, disable loop
2153 // rotation altogether.
2154 if (!BlocksExitingToOuterLoop.empty() &&
2155 !BlocksExitingToOuterLoop.count(ExitingBB))
Craig Topperc0196b12014-04-14 00:51:57 +00002156 return nullptr;
Chandler Carruth4f567202011-11-27 20:18:00 +00002157
Nicola Zaghend34e60c2018-05-14 12:53:11 +00002158 LLVM_DEBUG(dbgs() << " Best exiting block: " << getBlockName(ExitingBB)
2159 << "\n");
Guozhi Weid2210af2019-06-14 23:08:59 +00002160 ExitFreq = BestExitEdgeFreq;
Chandler Carruthccc7e422012-04-16 01:12:56 +00002161 return ExitingBB;
Chandler Carruth9ffb97e2011-11-27 00:38:03 +00002162}
2163
Guozhi Wei4c8e4802019-02-22 18:04:37 +00002164/// Check if there is a fallthrough to loop header Top.
2165///
2166/// 1. Look for a Pred that can be layout before Top.
2167/// 2. Check if Top is the most possible successor of Pred.
2168bool
2169MachineBlockPlacement::hasViableTopFallthrough(
2170 const MachineBasicBlock *Top,
2171 const BlockFilterSet &LoopBlockSet) {
2172 for (MachineBasicBlock *Pred : Top->predecessors()) {
2173 BlockChain *PredChain = BlockToChain[Pred];
2174 if (!LoopBlockSet.count(Pred) &&
2175 (!PredChain || Pred == *std::prev(PredChain->end()))) {
2176 // Found a Pred block can be placed before Top.
2177 // Check if Top is the best successor of Pred.
2178 auto TopProb = MBPI->getEdgeProbability(Pred, Top);
2179 bool TopOK = true;
2180 for (MachineBasicBlock *Succ : Pred->successors()) {
2181 auto SuccProb = MBPI->getEdgeProbability(Pred, Succ);
2182 BlockChain *SuccChain = BlockToChain[Succ];
2183 // Check if Succ can be placed after Pred.
2184 // Succ should not be in any chain, or it is the head of some chain.
2185 if ((!SuccChain || Succ == *SuccChain->begin()) && SuccProb > TopProb) {
2186 TopOK = false;
2187 break;
2188 }
2189 }
2190 if (TopOK)
2191 return true;
2192 }
2193 }
2194 return false;
2195}
2196
Adrian Prantl5f8f34e42018-05-01 15:54:18 +00002197/// Attempt to rotate an exiting block to the bottom of the loop.
Chandler Carruth8c74c7b2012-04-16 09:31:23 +00002198///
2199/// Once we have built a chain, try to rotate it to line up the hot exit block
2200/// with fallthrough out of the loop if doing so doesn't introduce unnecessary
2201/// branches. For example, if the loop has fallthrough into its header and out
2202/// of its bottom already, don't rotate it.
2203void MachineBlockPlacement::rotateLoop(BlockChain &LoopChain,
Kyle Butte9425c4f2017-02-04 02:26:32 +00002204 const MachineBasicBlock *ExitingBB,
Guozhi Weid2210af2019-06-14 23:08:59 +00002205 BlockFrequency ExitFreq,
Chandler Carruth8c74c7b2012-04-16 09:31:23 +00002206 const BlockFilterSet &LoopBlockSet) {
2207 if (!ExitingBB)
2208 return;
2209
2210 MachineBasicBlock *Top = *LoopChain.begin();
Serguei Katkov0e831c92017-07-11 08:34:58 +00002211 MachineBasicBlock *Bottom = *std::prev(LoopChain.end());
2212
2213 // If ExitingBB is already the last one in a chain then nothing to do.
2214 if (Bottom == ExitingBB)
2215 return;
2216
Guozhi Wei4c8e4802019-02-22 18:04:37 +00002217 bool ViableTopFallthrough = hasViableTopFallthrough(Top, LoopBlockSet);
Chandler Carruth8c74c7b2012-04-16 09:31:23 +00002218
2219 // If the header has viable fallthrough, check whether the current loop
2220 // bottom is a viable exiting block. If so, bail out as rotating will
2221 // introduce an unnecessary branch.
2222 if (ViableTopFallthrough) {
Chandler Carruth7a715da2015-03-05 03:19:05 +00002223 for (MachineBasicBlock *Succ : Bottom->successors()) {
2224 BlockChain *SuccChain = BlockToChain[Succ];
2225 if (!LoopBlockSet.count(Succ) &&
2226 (!SuccChain || Succ == *SuccChain->begin()))
Chandler Carruth8c74c7b2012-04-16 09:31:23 +00002227 return;
2228 }
Guozhi Weid2210af2019-06-14 23:08:59 +00002229
2230 // Rotate will destroy the top fallthrough, we need to ensure the new exit
2231 // frequency is larger than top fallthrough.
2232 BlockFrequency FallThrough2Top = TopFallThroughFreq(Top, LoopBlockSet);
2233 if (FallThrough2Top >= ExitFreq)
2234 return;
Chandler Carruth8c74c7b2012-04-16 09:31:23 +00002235 }
2236
Eugene Zelenko5df3d892017-08-24 21:21:39 +00002237 BlockChain::iterator ExitIt = llvm::find(LoopChain, ExitingBB);
Chandler Carruth8c74c7b2012-04-16 09:31:23 +00002238 if (ExitIt == LoopChain.end())
2239 return;
2240
Serguei Katkov0e831c92017-07-11 08:34:58 +00002241 // Rotating a loop exit to the bottom when there is a fallthrough to top
2242 // trades the entry fallthrough for an exit fallthrough.
2243 // If there is no bottom->top edge, but the chosen exit block does have
2244 // a fallthrough, we break that fallthrough for nothing in return.
2245
2246 // Let's consider an example. We have a built chain of basic blocks
2247 // B1, B2, ..., Bn, where Bk is a ExitingBB - chosen exit block.
2248 // By doing a rotation we get
2249 // Bk+1, ..., Bn, B1, ..., Bk
2250 // Break of fallthrough to B1 is compensated by a fallthrough from Bk.
2251 // If we had a fallthrough Bk -> Bk+1 it is broken now.
2252 // It might be compensated by fallthrough Bn -> B1.
2253 // So we have a condition to avoid creation of extra branch by loop rotation.
2254 // All below must be true to avoid loop rotation:
2255 // If there is a fallthrough to top (B1)
2256 // There was fallthrough from chosen exit block (Bk) to next one (Bk+1)
2257 // There is no fallthrough from bottom (Bn) to top (B1).
2258 // Please note that there is no exit fallthrough from Bn because we checked it
2259 // above.
2260 if (ViableTopFallthrough) {
2261 assert(std::next(ExitIt) != LoopChain.end() &&
2262 "Exit should not be last BB");
2263 MachineBasicBlock *NextBlockInChain = *std::next(ExitIt);
2264 if (ExitingBB->isSuccessor(NextBlockInChain))
2265 if (!Bottom->isSuccessor(Top))
2266 return;
2267 }
2268
Nicola Zaghend34e60c2018-05-14 12:53:11 +00002269 LLVM_DEBUG(dbgs() << "Rotating loop to put exit " << getBlockName(ExitingBB)
2270 << " at bottom\n");
Benjamin Kramerb6d0bd42014-03-02 12:27:27 +00002271 std::rotate(LoopChain.begin(), std::next(ExitIt), LoopChain.end());
Chandler Carruth8c74c7b2012-04-16 09:31:23 +00002272}
2273
Adrian Prantl5f8f34e42018-05-01 15:54:18 +00002274/// Attempt to rotate a loop based on profile data to reduce branch cost.
Cong Hou7745dbc2015-10-19 23:16:40 +00002275///
2276/// With profile data, we can determine the cost in terms of missed fall through
2277/// opportunities when rotating a loop chain and select the best rotation.
2278/// Basically, there are three kinds of cost to consider for each rotation:
2279/// 1. The possibly missed fall through edge (if it exists) from BB out of
2280/// the loop to the loop header.
2281/// 2. The possibly missed fall through edges (if they exist) from the loop
2282/// exits to BB out of the loop.
2283/// 3. The missed fall through edge (if it exists) from the last BB to the
2284/// first BB in the loop chain.
2285/// Therefore, the cost for a given rotation is the sum of costs listed above.
2286/// We select the best rotation with the smallest cost.
2287void MachineBlockPlacement::rotateLoopWithProfile(
Kyle Butte9425c4f2017-02-04 02:26:32 +00002288 BlockChain &LoopChain, const MachineLoop &L,
2289 const BlockFilterSet &LoopBlockSet) {
Cong Hou7745dbc2015-10-19 23:16:40 +00002290 auto RotationPos = LoopChain.end();
2291
2292 BlockFrequency SmallestRotationCost = BlockFrequency::getMaxFrequency();
2293
2294 // A utility lambda that scales up a block frequency by dividing it by a
2295 // branch probability which is the reciprocal of the scale.
2296 auto ScaleBlockFrequency = [](BlockFrequency Freq,
2297 unsigned Scale) -> BlockFrequency {
2298 if (Scale == 0)
2299 return 0;
2300 // Use operator / between BlockFrequency and BranchProbability to implement
2301 // saturating multiplication.
2302 return Freq / BranchProbability(1, Scale);
2303 };
2304
2305 // Compute the cost of the missed fall-through edge to the loop header if the
2306 // chain head is not the loop header. As we only consider natural loops with
2307 // single header, this computation can be done only once.
2308 BlockFrequency HeaderFallThroughCost(0);
Guozhi Weid2210af2019-06-14 23:08:59 +00002309 MachineBasicBlock *ChainHeaderBB = *LoopChain.begin();
2310 for (auto *Pred : ChainHeaderBB->predecessors()) {
Cong Hou7745dbc2015-10-19 23:16:40 +00002311 BlockChain *PredChain = BlockToChain[Pred];
2312 if (!LoopBlockSet.count(Pred) &&
2313 (!PredChain || Pred == *std::prev(PredChain->end()))) {
Guozhi Weid2210af2019-06-14 23:08:59 +00002314 auto EdgeFreq = MBFI->getBlockFreq(Pred) *
2315 MBPI->getEdgeProbability(Pred, ChainHeaderBB);
Cong Hou7745dbc2015-10-19 23:16:40 +00002316 auto FallThruCost = ScaleBlockFrequency(EdgeFreq, MisfetchCost);
2317 // If the predecessor has only an unconditional jump to the header, we
2318 // need to consider the cost of this jump.
2319 if (Pred->succ_size() == 1)
2320 FallThruCost += ScaleBlockFrequency(EdgeFreq, JumpInstCost);
2321 HeaderFallThroughCost = std::max(HeaderFallThroughCost, FallThruCost);
2322 }
2323 }
2324
2325 // Here we collect all exit blocks in the loop, and for each exit we find out
2326 // its hottest exit edge. For each loop rotation, we define the loop exit cost
2327 // as the sum of frequencies of exit edges we collect here, excluding the exit
2328 // edge from the tail of the loop chain.
2329 SmallVector<std::pair<MachineBasicBlock *, BlockFrequency>, 4> ExitsWithFreq;
2330 for (auto BB : LoopChain) {
Cong Houd97c1002015-12-01 05:29:22 +00002331 auto LargestExitEdgeProb = BranchProbability::getZero();
Cong Hou7745dbc2015-10-19 23:16:40 +00002332 for (auto *Succ : BB->successors()) {
2333 BlockChain *SuccChain = BlockToChain[Succ];
2334 if (!LoopBlockSet.count(Succ) &&
2335 (!SuccChain || Succ == *SuccChain->begin())) {
Cong Houd97c1002015-12-01 05:29:22 +00002336 auto SuccProb = MBPI->getEdgeProbability(BB, Succ);
2337 LargestExitEdgeProb = std::max(LargestExitEdgeProb, SuccProb);
Cong Hou7745dbc2015-10-19 23:16:40 +00002338 }
2339 }
Cong Houd97c1002015-12-01 05:29:22 +00002340 if (LargestExitEdgeProb > BranchProbability::getZero()) {
2341 auto ExitFreq = MBFI->getBlockFreq(BB) * LargestExitEdgeProb;
Cong Hou7745dbc2015-10-19 23:16:40 +00002342 ExitsWithFreq.emplace_back(BB, ExitFreq);
2343 }
2344 }
2345
2346 // In this loop we iterate every block in the loop chain and calculate the
2347 // cost assuming the block is the head of the loop chain. When the loop ends,
2348 // we should have found the best candidate as the loop chain's head.
2349 for (auto Iter = LoopChain.begin(), TailIter = std::prev(LoopChain.end()),
2350 EndIter = LoopChain.end();
2351 Iter != EndIter; Iter++, TailIter++) {
2352 // TailIter is used to track the tail of the loop chain if the block we are
2353 // checking (pointed by Iter) is the head of the chain.
2354 if (TailIter == LoopChain.end())
2355 TailIter = LoopChain.begin();
2356
2357 auto TailBB = *TailIter;
2358
2359 // Calculate the cost by putting this BB to the top.
2360 BlockFrequency Cost = 0;
2361
2362 // If the current BB is the loop header, we need to take into account the
2363 // cost of the missed fall through edge from outside of the loop to the
2364 // header.
Guozhi Weid2210af2019-06-14 23:08:59 +00002365 if (Iter != LoopChain.begin())
Cong Hou7745dbc2015-10-19 23:16:40 +00002366 Cost += HeaderFallThroughCost;
2367
2368 // Collect the loop exit cost by summing up frequencies of all exit edges
2369 // except the one from the chain tail.
2370 for (auto &ExitWithFreq : ExitsWithFreq)
2371 if (TailBB != ExitWithFreq.first)
2372 Cost += ExitWithFreq.second;
2373
2374 // The cost of breaking the once fall-through edge from the tail to the top
2375 // of the loop chain. Here we need to consider three cases:
2376 // 1. If the tail node has only one successor, then we will get an
2377 // additional jmp instruction. So the cost here is (MisfetchCost +
2378 // JumpInstCost) * tail node frequency.
2379 // 2. If the tail node has two successors, then we may still get an
2380 // additional jmp instruction if the layout successor after the loop
2381 // chain is not its CFG successor. Note that the more frequently executed
2382 // jmp instruction will be put ahead of the other one. Assume the
2383 // frequency of those two branches are x and y, where x is the frequency
2384 // of the edge to the chain head, then the cost will be
2385 // (x * MisfetechCost + min(x, y) * JumpInstCost) * tail node frequency.
2386 // 3. If the tail node has more than two successors (this rarely happens),
2387 // we won't consider any additional cost.
2388 if (TailBB->isSuccessor(*Iter)) {
2389 auto TailBBFreq = MBFI->getBlockFreq(TailBB);
2390 if (TailBB->succ_size() == 1)
2391 Cost += ScaleBlockFrequency(TailBBFreq.getFrequency(),
2392 MisfetchCost + JumpInstCost);
2393 else if (TailBB->succ_size() == 2) {
2394 auto TailToHeadProb = MBPI->getEdgeProbability(TailBB, *Iter);
2395 auto TailToHeadFreq = TailBBFreq * TailToHeadProb;
2396 auto ColderEdgeFreq = TailToHeadProb > BranchProbability(1, 2)
2397 ? TailBBFreq * TailToHeadProb.getCompl()
2398 : TailToHeadFreq;
2399 Cost += ScaleBlockFrequency(TailToHeadFreq, MisfetchCost) +
2400 ScaleBlockFrequency(ColderEdgeFreq, JumpInstCost);
2401 }
2402 }
2403
Nicola Zaghend34e60c2018-05-14 12:53:11 +00002404 LLVM_DEBUG(dbgs() << "The cost of loop rotation by making "
2405 << getBlockName(*Iter)
2406 << " to the top: " << Cost.getFrequency() << "\n");
Cong Hou7745dbc2015-10-19 23:16:40 +00002407
2408 if (Cost < SmallestRotationCost) {
2409 SmallestRotationCost = Cost;
2410 RotationPos = Iter;
2411 }
2412 }
2413
2414 if (RotationPos != LoopChain.end()) {
Nicola Zaghend34e60c2018-05-14 12:53:11 +00002415 LLVM_DEBUG(dbgs() << "Rotate loop by making " << getBlockName(*RotationPos)
2416 << " to the top\n");
Cong Hou7745dbc2015-10-19 23:16:40 +00002417 std::rotate(LoopChain.begin(), RotationPos, LoopChain.end());
2418 }
2419}
2420
Adrian Prantl5f8f34e42018-05-01 15:54:18 +00002421/// Collect blocks in the given loop that are to be placed.
Cong Houb90b9e02015-11-02 21:24:00 +00002422///
2423/// When profile data is available, exclude cold blocks from the returned set;
2424/// otherwise, collect all blocks in the loop.
2425MachineBlockPlacement::BlockFilterSet
Kyle Butte9425c4f2017-02-04 02:26:32 +00002426MachineBlockPlacement::collectLoopBlockSet(const MachineLoop &L) {
Cong Houb90b9e02015-11-02 21:24:00 +00002427 BlockFilterSet LoopBlockSet;
2428
2429 // Filter cold blocks off from LoopBlockSet when profile data is available.
2430 // Collect the sum of frequencies of incoming edges to the loop header from
2431 // outside. If we treat the loop as a super block, this is the frequency of
2432 // the loop. Then for each block in the loop, we calculate the ratio between
2433 // its frequency and the frequency of the loop block. When it is too small,
2434 // don't add it to the loop chain. If there are outer loops, then this block
2435 // will be merged into the first outer loop chain for which this block is not
2436 // cold anymore. This needs precise profile data and we only do this when
2437 // profile data is available.
Easwaran Ramana17f2202017-12-22 01:33:52 +00002438 if (F->getFunction().hasProfileData() || ForceLoopColdBlock) {
Cong Houb90b9e02015-11-02 21:24:00 +00002439 BlockFrequency LoopFreq(0);
2440 for (auto LoopPred : L.getHeader()->predecessors())
2441 if (!L.contains(LoopPred))
2442 LoopFreq += MBFI->getBlockFreq(LoopPred) *
2443 MBPI->getEdgeProbability(LoopPred, L.getHeader());
2444
2445 for (MachineBasicBlock *LoopBB : L.getBlocks()) {
2446 auto Freq = MBFI->getBlockFreq(LoopBB).getFrequency();
2447 if (Freq == 0 || LoopFreq.getFrequency() / Freq > LoopToColdBlockRatio)
2448 continue;
2449 LoopBlockSet.insert(LoopBB);
2450 }
2451 } else
2452 LoopBlockSet.insert(L.block_begin(), L.block_end());
2453
2454 return LoopBlockSet;
2455}
2456
Adrian Prantl5f8f34e42018-05-01 15:54:18 +00002457/// Forms basic block chains from the natural loop structures.
Chandler Carruth10281422011-10-21 06:46:38 +00002458///
Chandler Carruthbd1be4d2011-10-23 09:18:45 +00002459/// These chains are designed to preserve the existing *structure* of the code
2460/// as much as possible. We can then stitch the chains together in a way which
2461/// both preserves the topological structure and minimizes taken conditional
2462/// branches.
Kyle Butte9425c4f2017-02-04 02:26:32 +00002463void MachineBlockPlacement::buildLoopChains(const MachineLoop &L) {
Chandler Carruthbd1be4d2011-10-23 09:18:45 +00002464 // First recurse through any nested loops, building chains for those inner
2465 // loops.
Kyle Butte9425c4f2017-02-04 02:26:32 +00002466 for (const MachineLoop *InnerLoop : L)
Xinliang David Li52530a72016-06-13 22:23:44 +00002467 buildLoopChains(*InnerLoop);
Chandler Carruth10281422011-10-21 06:46:38 +00002468
Kyle Butt0cf5b2f2017-05-17 23:44:41 +00002469 assert(BlockWorkList.empty() &&
2470 "BlockWorkList not empty when starting to build loop chains.");
2471 assert(EHPadWorkList.empty() &&
2472 "EHPadWorkList not empty when starting to build loop chains.");
Xinliang David Li52530a72016-06-13 22:23:44 +00002473 BlockFilterSet LoopBlockSet = collectLoopBlockSet(L);
Chandler Carruth03adbd42011-11-27 13:34:33 +00002474
Cong Hou7745dbc2015-10-19 23:16:40 +00002475 // Check if we have profile data for this function. If yes, we will rotate
2476 // this loop by modeling costs more precisely which requires the profile data
2477 // for better layout.
2478 bool RotateLoopWithProfile =
Xinliang David Lif0ab6df2016-05-12 02:04:41 +00002479 ForcePreciseRotationCost ||
Easwaran Ramana17f2202017-12-22 01:33:52 +00002480 (PreciseRotationCost && F->getFunction().hasProfileData());
Cong Hou7745dbc2015-10-19 23:16:40 +00002481
Chandler Carruth8c0b41d2012-04-16 13:33:36 +00002482 // First check to see if there is an obviously preferable top block for the
2483 // loop. This will default to the header, but may end up as one of the
2484 // predecessors to the header if there is one which will result in strictly
2485 // fewer branches in the loop body.
Guozhi Weid2210af2019-06-14 23:08:59 +00002486 MachineBasicBlock *LoopTop = findBestLoopTop(L, LoopBlockSet);
Chandler Carruth8c0b41d2012-04-16 13:33:36 +00002487
2488 // If we selected just the header for the loop top, look for a potentially
2489 // profitable exit block in the event that rotating the loop can eliminate
2490 // branches by placing an exit edge at the bottom.
Xin Tongd8d97972017-10-04 21:39:25 +00002491 //
2492 // Loops are processed innermost to uttermost, make sure we clear
2493 // PreferredLoopExit before processing a new loop.
2494 PreferredLoopExit = nullptr;
Guozhi Weid2210af2019-06-14 23:08:59 +00002495 BlockFrequency ExitFreq;
Cong Hou7745dbc2015-10-19 23:16:40 +00002496 if (!RotateLoopWithProfile && LoopTop == L.getHeader())
Guozhi Weid2210af2019-06-14 23:08:59 +00002497 PreferredLoopExit = findBestLoopExit(L, LoopBlockSet, ExitFreq);
Chandler Carruth8c0b41d2012-04-16 13:33:36 +00002498
2499 BlockChain &LoopChain = *BlockToChain[LoopTop];
Chandler Carruth10281422011-10-21 06:46:38 +00002500
Chandler Carruth8d150782011-11-13 11:20:44 +00002501 // FIXME: This is a really lame way of walking the chains in the loop: we
2502 // walk the blocks, and use a set to prevent visiting a particular chain
2503 // twice.
Jakub Staszak90616162011-12-21 23:02:08 +00002504 SmallPtrSet<BlockChain *, 4> UpdatedPreds;
Kyle Butt0cf5b2f2017-05-17 23:44:41 +00002505 assert(LoopChain.UnscheduledPredecessors == 0 &&
2506 "LoopChain should not have unscheduled predecessors.");
Jakub Staszak190c7122011-12-07 19:46:10 +00002507 UpdatedPreds.insert(&LoopChain);
Cong Houb90b9e02015-11-02 21:24:00 +00002508
Kyle Butte9425c4f2017-02-04 02:26:32 +00002509 for (const MachineBasicBlock *LoopBB : LoopBlockSet)
Xinliang David Li93926ac2016-07-01 05:46:48 +00002510 fillWorkLists(LoopBB, UpdatedPreds, &LoopBlockSet);
Chandler Carruth8d150782011-11-13 11:20:44 +00002511
Xinliang David Li93926ac2016-07-01 05:46:48 +00002512 buildChain(LoopTop, LoopChain, &LoopBlockSet);
Cong Hou7745dbc2015-10-19 23:16:40 +00002513
2514 if (RotateLoopWithProfile)
2515 rotateLoopWithProfile(LoopChain, L, LoopBlockSet);
2516 else
Guozhi Weid2210af2019-06-14 23:08:59 +00002517 rotateLoop(LoopChain, PreferredLoopExit, ExitFreq, LoopBlockSet);
Chandler Carruth8d150782011-11-13 11:20:44 +00002518
Nicola Zaghend34e60c2018-05-14 12:53:11 +00002519 LLVM_DEBUG({
Chandler Carruth8e1d9062011-11-13 21:39:51 +00002520 // Crash at the end so we get all of the debugging output first.
2521 bool BadLoop = false;
Philip Reamesae27b232016-03-03 00:58:43 +00002522 if (LoopChain.UnscheduledPredecessors) {
Chandler Carruth8e1d9062011-11-13 21:39:51 +00002523 BadLoop = true;
Chandler Carruth8d150782011-11-13 11:20:44 +00002524 dbgs() << "Loop chain contains a block without its preds placed!\n"
2525 << " Loop header: " << getBlockName(*L.block_begin()) << "\n"
2526 << " Chain header: " << getBlockName(*LoopChain.begin()) << "\n";
Chandler Carruth8e1d9062011-11-13 21:39:51 +00002527 }
Chandler Carruth7a715da2015-03-05 03:19:05 +00002528 for (MachineBasicBlock *ChainBB : LoopChain) {
2529 dbgs() << " ... " << getBlockName(ChainBB) << "\n";
Rong Xu66827422016-11-16 20:50:06 +00002530 if (!LoopBlockSet.remove(ChainBB)) {
Chandler Carruth0a31d142011-11-14 10:55:53 +00002531 // We don't mark the loop as bad here because there are real situations
2532 // where this can occur. For example, with an unanalyzable fallthrough
Chandler Carruth99fe42f2011-11-23 10:35:36 +00002533 // from a loop block to a non-loop block or vice versa.
Chandler Carruth8d150782011-11-13 11:20:44 +00002534 dbgs() << "Loop chain contains a block not contained by the loop!\n"
2535 << " Loop header: " << getBlockName(*L.block_begin()) << "\n"
2536 << " Chain header: " << getBlockName(*LoopChain.begin()) << "\n"
Chandler Carruth7a715da2015-03-05 03:19:05 +00002537 << " Bad block: " << getBlockName(ChainBB) << "\n";
Chandler Carruth8e1d9062011-11-13 21:39:51 +00002538 }
Chandler Carruthccc7e422012-04-16 01:12:56 +00002539 }
Chandler Carruth8d150782011-11-13 11:20:44 +00002540
Chandler Carruth8e1d9062011-11-13 21:39:51 +00002541 if (!LoopBlockSet.empty()) {
2542 BadLoop = true;
Kyle Butte9425c4f2017-02-04 02:26:32 +00002543 for (const MachineBasicBlock *LoopBB : LoopBlockSet)
Chandler Carruth8d150782011-11-13 11:20:44 +00002544 dbgs() << "Loop contains blocks never placed into a chain!\n"
2545 << " Loop header: " << getBlockName(*L.block_begin()) << "\n"
2546 << " Chain header: " << getBlockName(*LoopChain.begin()) << "\n"
Chandler Carruth7a715da2015-03-05 03:19:05 +00002547 << " Bad block: " << getBlockName(LoopBB) << "\n";
Chandler Carruth8e1d9062011-11-13 21:39:51 +00002548 }
2549 assert(!BadLoop && "Detected problems with the placement of this loop.");
Chandler Carruth8d150782011-11-13 11:20:44 +00002550 });
Xinliang David Li93926ac2016-07-01 05:46:48 +00002551
2552 BlockWorkList.clear();
2553 EHPadWorkList.clear();
Chandler Carruth10281422011-10-21 06:46:38 +00002554}
2555
Xinliang David Li52530a72016-06-13 22:23:44 +00002556void MachineBlockPlacement::buildCFGChains() {
Chandler Carruth8d150782011-11-13 11:20:44 +00002557 // Ensure that every BB in the function has an associated chain to simplify
2558 // the assumptions of the remaining algorithm.
Chandler Carruthf3dc9ef2011-11-19 10:26:02 +00002559 SmallVector<MachineOperand, 4> Cond; // For AnalyzeBranch.
Xinliang David Li52530a72016-06-13 22:23:44 +00002560 for (MachineFunction::iterator FI = F->begin(), FE = F->end(); FI != FE;
2561 ++FI) {
Duncan P. N. Exon Smith6ac07fd2015-10-09 19:36:12 +00002562 MachineBasicBlock *BB = &*FI;
Chandler Carruth2fc3fe12015-03-05 02:35:31 +00002563 BlockChain *Chain =
2564 new (ChainAllocator.Allocate()) BlockChain(BlockToChain, BB);
Chandler Carruthf3dc9ef2011-11-19 10:26:02 +00002565 // Also, merge any blocks which we cannot reason about and must preserve
2566 // the exact fallthrough behavior for.
Eugene Zelenko5df3d892017-08-24 21:21:39 +00002567 while (true) {
Chandler Carruthf3dc9ef2011-11-19 10:26:02 +00002568 Cond.clear();
Craig Topperc0196b12014-04-14 00:51:57 +00002569 MachineBasicBlock *TBB = nullptr, *FBB = nullptr; // For AnalyzeBranch.
Jacques Pienaar71c30a12016-07-15 14:41:04 +00002570 if (!TII->analyzeBranch(*BB, TBB, FBB, Cond) || !FI->canFallThrough())
Chandler Carruthf3dc9ef2011-11-19 10:26:02 +00002571 break;
2572
Duncan P. N. Exon Smith6ac07fd2015-10-09 19:36:12 +00002573 MachineFunction::iterator NextFI = std::next(FI);
2574 MachineBasicBlock *NextBB = &*NextFI;
Chandler Carruthf3dc9ef2011-11-19 10:26:02 +00002575 // Ensure that the layout successor is a viable block, as we know that
2576 // fallthrough is a possibility.
2577 assert(NextFI != FE && "Can't fallthrough past the last block.");
Nicola Zaghend34e60c2018-05-14 12:53:11 +00002578 LLVM_DEBUG(dbgs() << "Pre-merging due to unanalyzable fallthrough: "
2579 << getBlockName(BB) << " -> " << getBlockName(NextBB)
2580 << "\n");
Craig Topperc0196b12014-04-14 00:51:57 +00002581 Chain->merge(NextBB, nullptr);
Hal Finkel34f9d6a2016-12-15 05:33:19 +00002582#ifndef NDEBUG
Sanjoy Dasd7389d62016-12-15 05:08:57 +00002583 BlocksWithUnanalyzableExits.insert(&*BB);
Hal Finkel34f9d6a2016-12-15 05:33:19 +00002584#endif
Chandler Carruthf3dc9ef2011-11-19 10:26:02 +00002585 FI = NextFI;
2586 BB = NextBB;
2587 }
2588 }
Chandler Carruth8d150782011-11-13 11:20:44 +00002589
2590 // Build any loop-based chains.
Sam McCall2a36eee2016-11-01 22:02:14 +00002591 PreferredLoopExit = nullptr;
Chandler Carruth7a715da2015-03-05 03:19:05 +00002592 for (MachineLoop *L : *MLI)
Xinliang David Li52530a72016-06-13 22:23:44 +00002593 buildLoopChains(*L);
Chandler Carruthbd1be4d2011-10-23 09:18:45 +00002594
Kyle Butt0cf5b2f2017-05-17 23:44:41 +00002595 assert(BlockWorkList.empty() &&
2596 "BlockWorkList should be empty before building final chain.");
2597 assert(EHPadWorkList.empty() &&
2598 "EHPadWorkList should be empty before building final chain.");
Chandler Carruthbd1be4d2011-10-23 09:18:45 +00002599
Chandler Carruth8d150782011-11-13 11:20:44 +00002600 SmallPtrSet<BlockChain *, 4> UpdatedPreds;
Xinliang David Li52530a72016-06-13 22:23:44 +00002601 for (MachineBasicBlock &MBB : *F)
Xinliang David Li93926ac2016-07-01 05:46:48 +00002602 fillWorkLists(&MBB, UpdatedPreds);
Chandler Carruth8d150782011-11-13 11:20:44 +00002603
Xinliang David Li52530a72016-06-13 22:23:44 +00002604 BlockChain &FunctionChain = *BlockToChain[&F->front()];
Xinliang David Li93926ac2016-07-01 05:46:48 +00002605 buildChain(&F->front(), FunctionChain);
Chandler Carruth8d150782011-11-13 11:20:44 +00002606
Matt Arsenault0f5f0152013-12-10 18:55:37 +00002607#ifndef NDEBUG
Eugene Zelenko5df3d892017-08-24 21:21:39 +00002608 using FunctionBlockSetType = SmallPtrSet<MachineBasicBlock *, 16>;
Matt Arsenault0f5f0152013-12-10 18:55:37 +00002609#endif
Nicola Zaghend34e60c2018-05-14 12:53:11 +00002610 LLVM_DEBUG({
Chandler Carruth8e1d9062011-11-13 21:39:51 +00002611 // Crash at the end so we get all of the debugging output first.
2612 bool BadFunc = false;
Chandler Carruth8d150782011-11-13 11:20:44 +00002613 FunctionBlockSetType FunctionBlockSet;
Xinliang David Li52530a72016-06-13 22:23:44 +00002614 for (MachineBasicBlock &MBB : *F)
Chandler Carruth7a715da2015-03-05 03:19:05 +00002615 FunctionBlockSet.insert(&MBB);
Chandler Carruth8d150782011-11-13 11:20:44 +00002616
Chandler Carruth7a715da2015-03-05 03:19:05 +00002617 for (MachineBasicBlock *ChainBB : FunctionChain)
2618 if (!FunctionBlockSet.erase(ChainBB)) {
Chandler Carruth8e1d9062011-11-13 21:39:51 +00002619 BadFunc = true;
Chandler Carruth8d150782011-11-13 11:20:44 +00002620 dbgs() << "Function chain contains a block not in the function!\n"
Chandler Carruth7a715da2015-03-05 03:19:05 +00002621 << " Bad block: " << getBlockName(ChainBB) << "\n";
Chandler Carruth8e1d9062011-11-13 21:39:51 +00002622 }
Chandler Carruth8d150782011-11-13 11:20:44 +00002623
Chandler Carruth8e1d9062011-11-13 21:39:51 +00002624 if (!FunctionBlockSet.empty()) {
2625 BadFunc = true;
Chandler Carruth7a715da2015-03-05 03:19:05 +00002626 for (MachineBasicBlock *RemainingBB : FunctionBlockSet)
Chandler Carruth8d150782011-11-13 11:20:44 +00002627 dbgs() << "Function contains blocks never placed into a chain!\n"
Chandler Carruth7a715da2015-03-05 03:19:05 +00002628 << " Bad block: " << getBlockName(RemainingBB) << "\n";
Chandler Carruth8e1d9062011-11-13 21:39:51 +00002629 }
2630 assert(!BadFunc && "Detected problems with the block placement.");
Chandler Carruth8d150782011-11-13 11:20:44 +00002631 });
2632
2633 // Splice the blocks into place.
Xinliang David Li52530a72016-06-13 22:23:44 +00002634 MachineFunction::iterator InsertPos = F->begin();
Nicola Zaghend34e60c2018-05-14 12:53:11 +00002635 LLVM_DEBUG(dbgs() << "[MBP] Function: " << F->getName() << "\n");
Chandler Carruth7a715da2015-03-05 03:19:05 +00002636 for (MachineBasicBlock *ChainBB : FunctionChain) {
Nicola Zaghend34e60c2018-05-14 12:53:11 +00002637 LLVM_DEBUG(dbgs() << (ChainBB == *FunctionChain.begin() ? "Placing chain "
2638 : " ... ")
2639 << getBlockName(ChainBB) << "\n");
Chandler Carruth7a715da2015-03-05 03:19:05 +00002640 if (InsertPos != MachineFunction::iterator(ChainBB))
Xinliang David Li52530a72016-06-13 22:23:44 +00002641 F->splice(InsertPos, ChainBB);
Chandler Carruth8d150782011-11-13 11:20:44 +00002642 else
2643 ++InsertPos;
2644
2645 // Update the terminator of the previous block.
Chandler Carruth7a715da2015-03-05 03:19:05 +00002646 if (ChainBB == *FunctionChain.begin())
Chandler Carruth8d150782011-11-13 11:20:44 +00002647 continue;
Duncan P. N. Exon Smith6ac07fd2015-10-09 19:36:12 +00002648 MachineBasicBlock *PrevBB = &*std::prev(MachineFunction::iterator(ChainBB));
Chandler Carruth8d150782011-11-13 11:20:44 +00002649
Chandler Carruth10281422011-10-21 06:46:38 +00002650 // FIXME: It would be awesome of updateTerminator would just return rather
2651 // than assert when the branch cannot be analyzed in order to remove this
2652 // boiler plate.
2653 Cond.clear();
Craig Topperc0196b12014-04-14 00:51:57 +00002654 MachineBasicBlock *TBB = nullptr, *FBB = nullptr; // For AnalyzeBranch.
Shuxin Yang8b8fd212013-06-04 01:00:57 +00002655
Sanjoy Dasd7389d62016-12-15 05:08:57 +00002656#ifndef NDEBUG
2657 if (!BlocksWithUnanalyzableExits.count(PrevBB)) {
2658 // Given the exact block placement we chose, we may actually not _need_ to
2659 // be able to edit PrevBB's terminator sequence, but not being _able_ to
2660 // do that at this point is a bug.
2661 assert((!TII->analyzeBranch(*PrevBB, TBB, FBB, Cond) ||
2662 !PrevBB->canFallThrough()) &&
2663 "Unexpected block with un-analyzable fallthrough!");
2664 Cond.clear();
2665 TBB = FBB = nullptr;
2666 }
2667#endif
2668
Haicheng Wu90a55652016-05-24 22:16:14 +00002669 // The "PrevBB" is not yet updated to reflect current code layout, so,
Sjoerd Meijerfd0ad4e2016-07-15 18:41:56 +00002670 // o. it may fall-through to a block without explicit "goto" instruction
Haicheng Wu90a55652016-05-24 22:16:14 +00002671 // before layout, and no longer fall-through it after layout; or
2672 // o. just opposite.
2673 //
Jacques Pienaar71c30a12016-07-15 14:41:04 +00002674 // analyzeBranch() may return erroneous value for FBB when these two
Haicheng Wu90a55652016-05-24 22:16:14 +00002675 // situations take place. For the first scenario FBB is mistakenly set NULL;
2676 // for the 2nd scenario, the FBB, which is expected to be NULL, is
2677 // mistakenly pointing to "*BI".
2678 // Thus, if the future change needs to use FBB before the layout is set, it
2679 // has to correct FBB first by using the code similar to the following:
2680 //
2681 // if (!Cond.empty() && (!FBB || FBB == ChainBB)) {
2682 // PrevBB->updateTerminator();
2683 // Cond.clear();
2684 // TBB = FBB = nullptr;
Jacques Pienaar71c30a12016-07-15 14:41:04 +00002685 // if (TII->analyzeBranch(*PrevBB, TBB, FBB, Cond)) {
Haicheng Wu90a55652016-05-24 22:16:14 +00002686 // // FIXME: This should never take place.
2687 // TBB = FBB = nullptr;
2688 // }
2689 // }
Jacques Pienaar71c30a12016-07-15 14:41:04 +00002690 if (!TII->analyzeBranch(*PrevBB, TBB, FBB, Cond))
Haicheng Wu90a55652016-05-24 22:16:14 +00002691 PrevBB->updateTerminator();
Chandler Carruth10281422011-10-21 06:46:38 +00002692 }
Chandler Carruth8d150782011-11-13 11:20:44 +00002693
2694 // Fixup the last block.
2695 Cond.clear();
Craig Topperc0196b12014-04-14 00:51:57 +00002696 MachineBasicBlock *TBB = nullptr, *FBB = nullptr; // For AnalyzeBranch.
Jacques Pienaar71c30a12016-07-15 14:41:04 +00002697 if (!TII->analyzeBranch(F->back(), TBB, FBB, Cond))
Xinliang David Li52530a72016-06-13 22:23:44 +00002698 F->back().updateTerminator();
Xinliang David Li93926ac2016-07-01 05:46:48 +00002699
2700 BlockWorkList.clear();
2701 EHPadWorkList.clear();
Haicheng Wu90a55652016-05-24 22:16:14 +00002702}
2703
Xinliang David Li52530a72016-06-13 22:23:44 +00002704void MachineBlockPlacement::optimizeBranches() {
2705 BlockChain &FunctionChain = *BlockToChain[&F->front()];
Haicheng Wu90a55652016-05-24 22:16:14 +00002706 SmallVector<MachineOperand, 4> Cond; // For AnalyzeBranch.
Quentin Colombet776e6de2016-05-02 22:58:59 +00002707
2708 // Now that all the basic blocks in the chain have the proper layout,
2709 // make a final call to AnalyzeBranch with AllowModify set.
2710 // Indeed, the target may be able to optimize the branches in a way we
2711 // cannot because all branches may not be analyzable.
2712 // E.g., the target may be able to remove an unconditional branch to
2713 // a fallthrough when it occurs after predicated terminators.
2714 for (MachineBasicBlock *ChainBB : FunctionChain) {
2715 Cond.clear();
Haicheng Wu90a55652016-05-24 22:16:14 +00002716 MachineBasicBlock *TBB = nullptr, *FBB = nullptr; // For AnalyzeBranch.
Jacques Pienaar71c30a12016-07-15 14:41:04 +00002717 if (!TII->analyzeBranch(*ChainBB, TBB, FBB, Cond, /*AllowModify*/ true)) {
Haicheng Wu90a55652016-05-24 22:16:14 +00002718 // If PrevBB has a two-way branch, try to re-order the branches
2719 // such that we branch to the successor with higher probability first.
2720 if (TBB && !Cond.empty() && FBB &&
2721 MBPI->getEdgeProbability(ChainBB, FBB) >
2722 MBPI->getEdgeProbability(ChainBB, TBB) &&
Matt Arsenault1b9fc8e2016-09-14 20:43:16 +00002723 !TII->reverseBranchCondition(Cond)) {
Nicola Zaghend34e60c2018-05-14 12:53:11 +00002724 LLVM_DEBUG(dbgs() << "Reverse order of the two branches: "
2725 << getBlockName(ChainBB) << "\n");
2726 LLVM_DEBUG(dbgs() << " Edge probability: "
2727 << MBPI->getEdgeProbability(ChainBB, FBB) << " vs "
2728 << MBPI->getEdgeProbability(ChainBB, TBB) << "\n");
Haicheng Wu90a55652016-05-24 22:16:14 +00002729 DebugLoc dl; // FIXME: this is nowhere
Matt Arsenault1b9fc8e2016-09-14 20:43:16 +00002730 TII->removeBranch(*ChainBB);
Matt Arsenaulte8e0f5c2016-09-14 17:24:15 +00002731 TII->insertBranch(*ChainBB, FBB, TBB, Cond, dl);
Haicheng Wu90a55652016-05-24 22:16:14 +00002732 ChainBB->updateTerminator();
2733 }
2734 }
Quentin Colombet776e6de2016-05-02 22:58:59 +00002735 }
Haicheng Wue749ce52016-04-29 17:06:44 +00002736}
Chandler Carruth10281422011-10-21 06:46:38 +00002737
Xinliang David Li52530a72016-06-13 22:23:44 +00002738void MachineBlockPlacement::alignBlocks() {
Chandler Carruthccc7e422012-04-16 01:12:56 +00002739 // Walk through the backedges of the function now that we have fully laid out
2740 // the basic blocks and align the destination of each backedge. We don't rely
Chandler Carruth881d0a72012-08-07 09:45:24 +00002741 // exclusively on the loop info here so that we can align backedges in
2742 // unnatural CFGs and backedges that were introduced purely because of the
2743 // loop rotations done during this layout pass.
Evandro Menezes85bd3972019-04-04 22:40:06 +00002744 if (F->getFunction().hasMinSize() ||
2745 (F->getFunction().hasOptSize() && !TLI->alignLoopsWithOptSize()))
Chandler Carruth8b9737c2011-10-21 08:57:37 +00002746 return;
Xinliang David Li52530a72016-06-13 22:23:44 +00002747 BlockChain &FunctionChain = *BlockToChain[&F->front()];
Chandler Carruth881d0a72012-08-07 09:45:24 +00002748 if (FunctionChain.begin() == FunctionChain.end())
Chandler Carruth2fc3fe12015-03-05 02:35:31 +00002749 return; // Empty chain.
Chandler Carruth8b9737c2011-10-21 08:57:37 +00002750
Chandler Carruth881d0a72012-08-07 09:45:24 +00002751 const BranchProbability ColdProb(1, 5); // 20%
Xinliang David Li52530a72016-06-13 22:23:44 +00002752 BlockFrequency EntryFreq = MBFI->getBlockFreq(&F->front());
Chandler Carruth881d0a72012-08-07 09:45:24 +00002753 BlockFrequency WeightedEntryFreq = EntryFreq * ColdProb;
Chandler Carruth7a715da2015-03-05 03:19:05 +00002754 for (MachineBasicBlock *ChainBB : FunctionChain) {
2755 if (ChainBB == *FunctionChain.begin())
2756 continue;
2757
Chandler Carruth881d0a72012-08-07 09:45:24 +00002758 // Don't align non-looping basic blocks. These are unlikely to execute
2759 // enough times to matter in practice. Note that we'll still handle
2760 // unnatural CFGs inside of a natural outer loop (the common case) and
2761 // rotated loops.
Chandler Carruth7a715da2015-03-05 03:19:05 +00002762 MachineLoop *L = MLI->getLoopFor(ChainBB);
Chandler Carruth881d0a72012-08-07 09:45:24 +00002763 if (!L)
2764 continue;
2765
Hal Finkel57725662015-01-03 17:58:24 +00002766 unsigned Align = TLI->getPrefLoopAlignment(L);
2767 if (!Align)
Chandler Carruth2fc3fe12015-03-05 02:35:31 +00002768 continue; // Don't care about loop alignment.
Hal Finkel57725662015-01-03 17:58:24 +00002769
Chandler Carruth881d0a72012-08-07 09:45:24 +00002770 // If the block is cold relative to the function entry don't waste space
2771 // aligning it.
Chandler Carruth7a715da2015-03-05 03:19:05 +00002772 BlockFrequency Freq = MBFI->getBlockFreq(ChainBB);
Chandler Carruth881d0a72012-08-07 09:45:24 +00002773 if (Freq < WeightedEntryFreq)
2774 continue;
2775
2776 // If the block is cold relative to its loop header, don't align it
2777 // regardless of what edges into the block exist.
2778 MachineBasicBlock *LoopHeader = L->getHeader();
2779 BlockFrequency LoopHeaderFreq = MBFI->getBlockFreq(LoopHeader);
2780 if (Freq < (LoopHeaderFreq * ColdProb))
2781 continue;
2782
2783 // Check for the existence of a non-layout predecessor which would benefit
2784 // from aligning this block.
Chandler Carruth7a715da2015-03-05 03:19:05 +00002785 MachineBasicBlock *LayoutPred =
2786 &*std::prev(MachineFunction::iterator(ChainBB));
Chandler Carruth881d0a72012-08-07 09:45:24 +00002787
2788 // Force alignment if all the predecessors are jumps. We already checked
2789 // that the block isn't cold above.
Chandler Carruth7a715da2015-03-05 03:19:05 +00002790 if (!LayoutPred->isSuccessor(ChainBB)) {
2791 ChainBB->setAlignment(Align);
Chandler Carruth881d0a72012-08-07 09:45:24 +00002792 continue;
2793 }
2794
2795 // Align this block if the layout predecessor's edge into this block is
Nadav Rotem6036f582013-03-29 16:34:23 +00002796 // cold relative to the block. When this is true, other predecessors make up
Chandler Carruth881d0a72012-08-07 09:45:24 +00002797 // all of the hot entries into the block and thus alignment is likely to be
2798 // important.
Chandler Carruth7a715da2015-03-05 03:19:05 +00002799 BranchProbability LayoutProb =
2800 MBPI->getEdgeProbability(LayoutPred, ChainBB);
Chandler Carruth881d0a72012-08-07 09:45:24 +00002801 BlockFrequency LayoutEdgeFreq = MBFI->getBlockFreq(LayoutPred) * LayoutProb;
2802 if (LayoutEdgeFreq <= (Freq * ColdProb))
Chandler Carruth7a715da2015-03-05 03:19:05 +00002803 ChainBB->setAlignment(Align);
Chandler Carruthccc7e422012-04-16 01:12:56 +00002804 }
Chandler Carruth8b9737c2011-10-21 08:57:37 +00002805}
2806
Kyle Butt0846e562016-10-11 20:36:43 +00002807/// Tail duplicate \p BB into (some) predecessors if profitable, repeating if
2808/// it was duplicated into its chain predecessor and removed.
2809/// \p BB - Basic block that may be duplicated.
2810///
2811/// \p LPred - Chosen layout predecessor of \p BB.
2812/// Updated to be the chain end if LPred is removed.
2813/// \p Chain - Chain to which \p LPred belongs, and \p BB will belong.
2814/// \p BlockFilter - Set of blocks that belong to the loop being laid out.
2815/// Used to identify which blocks to update predecessor
2816/// counts.
2817/// \p PrevUnplacedBlockIt - Iterator pointing to the last block that was
2818/// chosen in the given order due to unnatural CFG
2819/// only needed if \p BB is removed and
2820/// \p PrevUnplacedBlockIt pointed to \p BB.
2821/// @return true if \p BB was removed.
2822bool MachineBlockPlacement::repeatedlyTailDuplicateBlock(
2823 MachineBasicBlock *BB, MachineBasicBlock *&LPred,
Kyle Butte9425c4f2017-02-04 02:26:32 +00002824 const MachineBasicBlock *LoopHeaderBB,
Kyle Butt0846e562016-10-11 20:36:43 +00002825 BlockChain &Chain, BlockFilterSet *BlockFilter,
2826 MachineFunction::iterator &PrevUnplacedBlockIt) {
2827 bool Removed, DuplicatedToLPred;
2828 bool DuplicatedToOriginalLPred;
2829 Removed = maybeTailDuplicateBlock(BB, LPred, Chain, BlockFilter,
2830 PrevUnplacedBlockIt,
2831 DuplicatedToLPred);
2832 if (!Removed)
2833 return false;
2834 DuplicatedToOriginalLPred = DuplicatedToLPred;
2835 // Iteratively try to duplicate again. It can happen that a block that is
2836 // duplicated into is still small enough to be duplicated again.
2837 // No need to call markBlockSuccessors in this case, as the blocks being
2838 // duplicated from here on are already scheduled.
2839 // Note that DuplicatedToLPred always implies Removed.
2840 while (DuplicatedToLPred) {
Eugene Zelenko5df3d892017-08-24 21:21:39 +00002841 assert(Removed && "Block must have been removed to be duplicated into its "
2842 "layout predecessor.");
Kyle Butt0846e562016-10-11 20:36:43 +00002843 MachineBasicBlock *DupBB, *DupPred;
2844 // The removal callback causes Chain.end() to be updated when a block is
2845 // removed. On the first pass through the loop, the chain end should be the
2846 // same as it was on function entry. On subsequent passes, because we are
2847 // duplicating the block at the end of the chain, if it is removed the
2848 // chain will have shrunk by one block.
2849 BlockChain::iterator ChainEnd = Chain.end();
2850 DupBB = *(--ChainEnd);
2851 // Now try to duplicate again.
2852 if (ChainEnd == Chain.begin())
2853 break;
2854 DupPred = *std::prev(ChainEnd);
2855 Removed = maybeTailDuplicateBlock(DupBB, DupPred, Chain, BlockFilter,
2856 PrevUnplacedBlockIt,
2857 DuplicatedToLPred);
2858 }
2859 // If BB was duplicated into LPred, it is now scheduled. But because it was
2860 // removed, markChainSuccessors won't be called for its chain. Instead we
2861 // call markBlockSuccessors for LPred to achieve the same effect. This must go
2862 // at the end because repeating the tail duplication can increase the number
2863 // of unscheduled predecessors.
2864 LPred = *std::prev(Chain.end());
2865 if (DuplicatedToOriginalLPred)
2866 markBlockSuccessors(Chain, LPred, LoopHeaderBB, BlockFilter);
2867 return true;
2868}
2869
2870/// Tail duplicate \p BB into (some) predecessors if profitable.
2871/// \p BB - Basic block that may be duplicated
2872/// \p LPred - Chosen layout predecessor of \p BB
2873/// \p Chain - Chain to which \p LPred belongs, and \p BB will belong.
2874/// \p BlockFilter - Set of blocks that belong to the loop being laid out.
2875/// Used to identify which blocks to update predecessor
2876/// counts.
2877/// \p PrevUnplacedBlockIt - Iterator pointing to the last block that was
2878/// chosen in the given order due to unnatural CFG
2879/// only needed if \p BB is removed and
2880/// \p PrevUnplacedBlockIt pointed to \p BB.
2881/// \p DuplicatedToLPred - True if the block was duplicated into LPred. Will
2882/// only be true if the block was removed.
2883/// \return - True if the block was duplicated into all preds and removed.
2884bool MachineBlockPlacement::maybeTailDuplicateBlock(
2885 MachineBasicBlock *BB, MachineBasicBlock *LPred,
Kyle Butte9425c4f2017-02-04 02:26:32 +00002886 BlockChain &Chain, BlockFilterSet *BlockFilter,
Kyle Butt0846e562016-10-11 20:36:43 +00002887 MachineFunction::iterator &PrevUnplacedBlockIt,
2888 bool &DuplicatedToLPred) {
Kyle Butt0846e562016-10-11 20:36:43 +00002889 DuplicatedToLPred = false;
Kyle Buttc7d67eef2017-02-04 02:26:34 +00002890 if (!shouldTailDuplicate(BB))
2891 return false;
2892
Nicola Zaghend34e60c2018-05-14 12:53:11 +00002893 LLVM_DEBUG(dbgs() << "Redoing tail duplication for Succ#" << BB->getNumber()
2894 << "\n");
Kyle Buttb15c0662017-01-31 23:48:32 +00002895
Kyle Butt0846e562016-10-11 20:36:43 +00002896 // This has to be a callback because none of it can be done after
2897 // BB is deleted.
2898 bool Removed = false;
2899 auto RemovalCallback =
2900 [&](MachineBasicBlock *RemBB) {
2901 // Signal to outer function
2902 Removed = true;
2903
2904 // Conservative default.
2905 bool InWorkList = true;
2906 // Remove from the Chain and Chain Map
2907 if (BlockToChain.count(RemBB)) {
2908 BlockChain *Chain = BlockToChain[RemBB];
2909 InWorkList = Chain->UnscheduledPredecessors == 0;
2910 Chain->remove(RemBB);
2911 BlockToChain.erase(RemBB);
2912 }
2913
2914 // Handle the unplaced block iterator
2915 if (&(*PrevUnplacedBlockIt) == RemBB) {
2916 PrevUnplacedBlockIt++;
2917 }
2918
2919 // Handle the Work Lists
2920 if (InWorkList) {
2921 SmallVectorImpl<MachineBasicBlock *> &RemoveList = BlockWorkList;
2922 if (RemBB->isEHPad())
2923 RemoveList = EHPadWorkList;
2924 RemoveList.erase(
Eugene Zelenko5df3d892017-08-24 21:21:39 +00002925 llvm::remove_if(RemoveList,
2926 [RemBB](MachineBasicBlock *BB) {
2927 return BB == RemBB;
2928 }),
Kyle Butt0846e562016-10-11 20:36:43 +00002929 RemoveList.end());
2930 }
2931
2932 // Handle the filter set
2933 if (BlockFilter) {
Rong Xu66827422016-11-16 20:50:06 +00002934 BlockFilter->remove(RemBB);
Kyle Butt0846e562016-10-11 20:36:43 +00002935 }
2936
2937 // Remove the block from loop info.
2938 MLI->removeBlock(RemBB);
Kyle Buttab9cca72016-10-27 21:37:20 +00002939 if (RemBB == PreferredLoopExit)
2940 PreferredLoopExit = nullptr;
Kyle Butt0846e562016-10-11 20:36:43 +00002941
Nicola Zaghend34e60c2018-05-14 12:53:11 +00002942 LLVM_DEBUG(dbgs() << "TailDuplicator deleted block: "
2943 << getBlockName(RemBB) << "\n");
Kyle Butt0846e562016-10-11 20:36:43 +00002944 };
2945 auto RemovalCallbackRef =
Eugene Zelenko5df3d892017-08-24 21:21:39 +00002946 function_ref<void(MachineBasicBlock*)>(RemovalCallback);
Kyle Butt0846e562016-10-11 20:36:43 +00002947
2948 SmallVector<MachineBasicBlock *, 8> DuplicatedPreds;
Kyle Buttb15c0662017-01-31 23:48:32 +00002949 bool IsSimple = TailDup.isSimpleBB(BB);
Kyle Butt0846e562016-10-11 20:36:43 +00002950 TailDup.tailDuplicateAndUpdate(IsSimple, BB, LPred,
2951 &DuplicatedPreds, &RemovalCallbackRef);
2952
2953 // Update UnscheduledPredecessors to reflect tail-duplication.
2954 DuplicatedToLPred = false;
2955 for (MachineBasicBlock *Pred : DuplicatedPreds) {
2956 // We're only looking for unscheduled predecessors that match the filter.
2957 BlockChain* PredChain = BlockToChain[Pred];
2958 if (Pred == LPred)
2959 DuplicatedToLPred = true;
2960 if (Pred == LPred || (BlockFilter && !BlockFilter->count(Pred))
2961 || PredChain == &Chain)
2962 continue;
2963 for (MachineBasicBlock *NewSucc : Pred->successors()) {
2964 if (BlockFilter && !BlockFilter->count(NewSucc))
2965 continue;
2966 BlockChain *NewChain = BlockToChain[NewSucc];
2967 if (NewChain != &Chain && NewChain != PredChain)
2968 NewChain->UnscheduledPredecessors++;
2969 }
2970 }
2971 return Removed;
2972}
2973
Xinliang David Li52530a72016-06-13 22:23:44 +00002974bool MachineBlockPlacement::runOnMachineFunction(MachineFunction &MF) {
Matthias Braunf1caa282017-12-15 22:22:58 +00002975 if (skipFunction(MF.getFunction()))
Andrew Kaylor50271f72016-05-03 22:32:30 +00002976 return false;
2977
Chandler Carruth10281422011-10-21 06:46:38 +00002978 // Check for single-block functions and skip them.
Xinliang David Li52530a72016-06-13 22:23:44 +00002979 if (std::next(MF.begin()) == MF.end())
Chandler Carruth10281422011-10-21 06:46:38 +00002980 return false;
2981
Xinliang David Li52530a72016-06-13 22:23:44 +00002982 F = &MF;
Chandler Carruth10281422011-10-21 06:46:38 +00002983 MBPI = &getAnalysis<MachineBranchProbabilityInfo>();
Haicheng Wu5b458cc2016-06-09 15:24:29 +00002984 MBFI = llvm::make_unique<BranchFolder::MBFIWrapper>(
2985 getAnalysis<MachineBlockFrequencyInfo>());
Chandler Carruth8b9737c2011-10-21 08:57:37 +00002986 MLI = &getAnalysis<MachineLoopInfo>();
Xinliang David Li52530a72016-06-13 22:23:44 +00002987 TII = MF.getSubtarget().getInstrInfo();
2988 TLI = MF.getSubtarget().getTargetLowering();
Kyle Buttb15c0662017-01-31 23:48:32 +00002989 MPDT = nullptr;
Eric Christopher690f8e52016-11-01 22:15:50 +00002990
2991 // Initialize PreferredLoopExit to nullptr here since it may never be set if
2992 // there are no MachineLoops.
2993 PreferredLoopExit = nullptr;
2994
Kyle Butt0cf5b2f2017-05-17 23:44:41 +00002995 assert(BlockToChain.empty() &&
2996 "BlockToChain map should be empty before starting placement.");
2997 assert(ComputedEdges.empty() &&
2998 "Computed Edge map should be empty before starting placement.");
Kyle Butt04300b032017-04-12 03:18:20 +00002999
Kyle Butt7d531da2017-05-15 17:30:47 +00003000 unsigned TailDupSize = TailDupPlacementThreshold;
3001 // If only the aggressive threshold is explicitly set, use it.
3002 if (TailDupPlacementAggressiveThreshold.getNumOccurrences() != 0 &&
3003 TailDupPlacementThreshold.getNumOccurrences() == 0)
3004 TailDupSize = TailDupPlacementAggressiveThreshold;
3005
3006 TargetPassConfig *PassConfig = &getAnalysis<TargetPassConfig>();
Hiroshi Inouec73b6d62018-06-20 05:29:26 +00003007 // For aggressive optimization, we can adjust some thresholds to be less
Kyle Butt7d531da2017-05-15 17:30:47 +00003008 // conservative.
3009 if (PassConfig->getOptLevel() >= CodeGenOpt::Aggressive) {
3010 // At O3 we should be more willing to copy blocks for tail duplication. This
3011 // increases size pressure, so we only do it at O3
3012 // Do this unless only the regular threshold is explicitly set.
3013 if (TailDupPlacementThreshold.getNumOccurrences() == 0 ||
3014 TailDupPlacementAggressiveThreshold.getNumOccurrences() != 0)
3015 TailDupSize = TailDupPlacementAggressiveThreshold;
3016 }
3017
Tim Shen1a8c6772018-03-30 17:51:00 +00003018 if (allowTailDupPlacement()) {
Kyle Buttb15c0662017-01-31 23:48:32 +00003019 MPDT = &getAnalysis<MachinePostDominatorTree>();
Evandro Menezes85bd3972019-04-04 22:40:06 +00003020 if (MF.getFunction().hasOptSize())
Kyle Butt0846e562016-10-11 20:36:43 +00003021 TailDupSize = 1;
Matthias Braun8426d132017-08-23 03:17:59 +00003022 bool PreRegAlloc = false;
3023 TailDup.initMF(MF, PreRegAlloc, MBPI, /* LayoutMode */ true, TailDupSize);
Kyle Butt1fa60302017-03-03 01:00:22 +00003024 precomputeTriangleChains();
Kyle Butt0846e562016-10-11 20:36:43 +00003025 }
3026
Xinliang David Li52530a72016-06-13 22:23:44 +00003027 buildCFGChains();
Haicheng Wu5b458cc2016-06-09 15:24:29 +00003028
3029 // Changing the layout can create new tail merging opportunities.
Haicheng Wu5b458cc2016-06-09 15:24:29 +00003030 // TailMerge can create jump into if branches that make CFG irreducible for
Sjoerd Meijerfd0ad4e2016-07-15 18:41:56 +00003031 // HW that requires structured CFG.
Xinliang David Li52530a72016-06-13 22:23:44 +00003032 bool EnableTailMerge = !MF.getTarget().requiresStructuredCFG() &&
Haicheng Wu5b458cc2016-06-09 15:24:29 +00003033 PassConfig->getEnableTailMerge() &&
3034 BranchFoldPlacement;
3035 // No tail merging opportunities if the block number is less than four.
Xinliang David Li52530a72016-06-13 22:23:44 +00003036 if (MF.size() > 3 && EnableTailMerge) {
Kyle Butt7d531da2017-05-15 17:30:47 +00003037 unsigned TailMergeSize = TailDupSize + 1;
Haicheng Wu5b458cc2016-06-09 15:24:29 +00003038 BranchFolder BF(/*EnableTailMerge=*/true, /*CommonHoist=*/false, *MBFI,
Kyle Butt64e42812016-08-18 18:57:29 +00003039 *MBPI, TailMergeSize);
Haicheng Wu5b458cc2016-06-09 15:24:29 +00003040
Xinliang David Li52530a72016-06-13 22:23:44 +00003041 if (BF.OptimizeFunction(MF, TII, MF.getSubtarget().getRegisterInfo(),
Haicheng Wu5b458cc2016-06-09 15:24:29 +00003042 getAnalysisIfAvailable<MachineModuleInfo>(), MLI,
Rui Ueyama49a3ad22019-07-16 04:46:31 +00003043 /*AfterPlacement=*/true)) {
Haicheng Wu5b458cc2016-06-09 15:24:29 +00003044 // Redo the layout if tail merging creates/removes/moves blocks.
3045 BlockToChain.clear();
Kyle Butt04300b032017-04-12 03:18:20 +00003046 ComputedEdges.clear();
Kyle Butt13937612017-03-02 21:44:24 +00003047 // Must redo the post-dominator tree if blocks were changed.
Kyle Buttb15c0662017-01-31 23:48:32 +00003048 if (MPDT)
3049 MPDT->runOnMachineFunction(MF);
Haicheng Wu5b458cc2016-06-09 15:24:29 +00003050 ChainAllocator.DestroyAll();
Xinliang David Li52530a72016-06-13 22:23:44 +00003051 buildCFGChains();
Haicheng Wu5b458cc2016-06-09 15:24:29 +00003052 }
3053 }
3054
Xinliang David Li52530a72016-06-13 22:23:44 +00003055 optimizeBranches();
3056 alignBlocks();
Chandler Carruth10281422011-10-21 06:46:38 +00003057
Chandler Carruth10281422011-10-21 06:46:38 +00003058 BlockToChain.clear();
Kyle Butt04300b032017-04-12 03:18:20 +00003059 ComputedEdges.clear();
Chandler Carruthfd9b4d92011-11-14 10:57:23 +00003060 ChainAllocator.DestroyAll();
Chandler Carruth10281422011-10-21 06:46:38 +00003061
Nadav Rotemc0adc9f2013-04-12 01:24:16 +00003062 if (AlignAllBlock)
3063 // Align all of the blocks in the function to a specific alignment.
Xinliang David Li52530a72016-06-13 22:23:44 +00003064 for (MachineBasicBlock &MBB : MF)
Chandler Carruth7a715da2015-03-05 03:19:05 +00003065 MBB.setAlignment(AlignAllBlock);
Geoff Berry10494ac2016-01-21 17:25:52 +00003066 else if (AlignAllNonFallThruBlocks) {
3067 // Align all of the blocks that have no fall-through predecessors to a
3068 // specific alignment.
Xinliang David Li52530a72016-06-13 22:23:44 +00003069 for (auto MBI = std::next(MF.begin()), MBE = MF.end(); MBI != MBE; ++MBI) {
Geoff Berry10494ac2016-01-21 17:25:52 +00003070 auto LayoutPred = std::prev(MBI);
3071 if (!LayoutPred->isSuccessor(&*MBI))
3072 MBI->setAlignment(AlignAllNonFallThruBlocks);
3073 }
3074 }
Xinliang David Lifd3f6452017-01-29 01:57:02 +00003075 if (ViewBlockLayoutWithBFI != GVDT_None &&
3076 (ViewBlockFreqFuncName.empty() ||
Matthias Braunf1caa282017-12-15 22:22:58 +00003077 F->getFunction().getName().equals(ViewBlockFreqFuncName))) {
Xinliang David Li538d6662017-02-15 19:21:04 +00003078 MBFI->view("MBP." + MF.getName(), false);
Xinliang David Lifd3f6452017-01-29 01:57:02 +00003079 }
Xinliang David Lifd3f6452017-01-29 01:57:02 +00003080
Nadav Rotemc0adc9f2013-04-12 01:24:16 +00003081
Chandler Carruth10281422011-10-21 06:46:38 +00003082 // We always return true as we have no way to track whether the final order
3083 // differs from the original order.
3084 return true;
3085}
Chandler Carruthae4e8002011-11-02 07:17:12 +00003086
3087namespace {
Eugene Zelenko5df3d892017-08-24 21:21:39 +00003088
Adrian Prantl5f8f34e42018-05-01 15:54:18 +00003089/// A pass to compute block placement statistics.
Chandler Carruthae4e8002011-11-02 07:17:12 +00003090///
3091/// A separate pass to compute interesting statistics for evaluating block
3092/// placement. This is separate from the actual placement pass so that they can
Benjamin Kramerbde91762012-06-02 10:20:22 +00003093/// be computed in the absence of any placement transformations or when using
Chandler Carruthae4e8002011-11-02 07:17:12 +00003094/// alternative placement strategies.
3095class MachineBlockPlacementStats : public MachineFunctionPass {
Adrian Prantl5f8f34e42018-05-01 15:54:18 +00003096 /// A handle to the branch probability pass.
Chandler Carruthae4e8002011-11-02 07:17:12 +00003097 const MachineBranchProbabilityInfo *MBPI;
3098
Adrian Prantl5f8f34e42018-05-01 15:54:18 +00003099 /// A handle to the function-wide block frequency pass.
Chandler Carruthae4e8002011-11-02 07:17:12 +00003100 const MachineBlockFrequencyInfo *MBFI;
3101
3102public:
3103 static char ID; // Pass identification, replacement for typeid
Eugene Zelenko5df3d892017-08-24 21:21:39 +00003104
Chandler Carruthae4e8002011-11-02 07:17:12 +00003105 MachineBlockPlacementStats() : MachineFunctionPass(ID) {
3106 initializeMachineBlockPlacementStatsPass(*PassRegistry::getPassRegistry());
3107 }
3108
Craig Topper4584cd52014-03-07 09:26:03 +00003109 bool runOnMachineFunction(MachineFunction &F) override;
Chandler Carruthae4e8002011-11-02 07:17:12 +00003110
Craig Topper4584cd52014-03-07 09:26:03 +00003111 void getAnalysisUsage(AnalysisUsage &AU) const override {
Chandler Carruthae4e8002011-11-02 07:17:12 +00003112 AU.addRequired<MachineBranchProbabilityInfo>();
3113 AU.addRequired<MachineBlockFrequencyInfo>();
3114 AU.setPreservesAll();
3115 MachineFunctionPass::getAnalysisUsage(AU);
3116 }
Chandler Carruthae4e8002011-11-02 07:17:12 +00003117};
Eugene Zelenko5df3d892017-08-24 21:21:39 +00003118
3119} // end anonymous namespace
Chandler Carruthae4e8002011-11-02 07:17:12 +00003120
3121char MachineBlockPlacementStats::ID = 0;
Eugene Zelenko5df3d892017-08-24 21:21:39 +00003122
Andrew Trick1fa5bcb2012-02-08 21:23:13 +00003123char &llvm::MachineBlockPlacementStatsID = MachineBlockPlacementStats::ID;
Eugene Zelenko5df3d892017-08-24 21:21:39 +00003124
Chandler Carruthae4e8002011-11-02 07:17:12 +00003125INITIALIZE_PASS_BEGIN(MachineBlockPlacementStats, "block-placement-stats",
3126 "Basic Block Placement Stats", false, false)
3127INITIALIZE_PASS_DEPENDENCY(MachineBranchProbabilityInfo)
3128INITIALIZE_PASS_DEPENDENCY(MachineBlockFrequencyInfo)
3129INITIALIZE_PASS_END(MachineBlockPlacementStats, "block-placement-stats",
3130 "Basic Block Placement Stats", false, false)
3131
Chandler Carruthae4e8002011-11-02 07:17:12 +00003132bool MachineBlockPlacementStats::runOnMachineFunction(MachineFunction &F) {
3133 // Check for single-block functions and skip them.
Benjamin Kramerb6d0bd42014-03-02 12:27:27 +00003134 if (std::next(F.begin()) == F.end())
Chandler Carruthae4e8002011-11-02 07:17:12 +00003135 return false;
3136
3137 MBPI = &getAnalysis<MachineBranchProbabilityInfo>();
3138 MBFI = &getAnalysis<MachineBlockFrequencyInfo>();
3139
Chandler Carruth7a715da2015-03-05 03:19:05 +00003140 for (MachineBasicBlock &MBB : F) {
3141 BlockFrequency BlockFreq = MBFI->getBlockFreq(&MBB);
Chandler Carruth2fc3fe12015-03-05 02:35:31 +00003142 Statistic &NumBranches =
Chandler Carruth7a715da2015-03-05 03:19:05 +00003143 (MBB.succ_size() > 1) ? NumCondBranches : NumUncondBranches;
Chandler Carruth2fc3fe12015-03-05 02:35:31 +00003144 Statistic &BranchTakenFreq =
Chandler Carruth7a715da2015-03-05 03:19:05 +00003145 (MBB.succ_size() > 1) ? CondBranchTakenFreq : UncondBranchTakenFreq;
3146 for (MachineBasicBlock *Succ : MBB.successors()) {
Chandler Carruthae4e8002011-11-02 07:17:12 +00003147 // Skip if this successor is a fallthrough.
Chandler Carruth7a715da2015-03-05 03:19:05 +00003148 if (MBB.isLayoutSuccessor(Succ))
Chandler Carruthae4e8002011-11-02 07:17:12 +00003149 continue;
3150
Chandler Carruth7a715da2015-03-05 03:19:05 +00003151 BlockFrequency EdgeFreq =
3152 BlockFreq * MBPI->getEdgeProbability(&MBB, Succ);
Chandler Carruthae4e8002011-11-02 07:17:12 +00003153 ++NumBranches;
3154 BranchTakenFreq += EdgeFreq.getFrequency();
3155 }
3156 }
3157
3158 return false;
3159}