blob: e2729516b4099b0af62c6de9d2ee9098cb30da4e [file] [log] [blame]
Chris Lattner2188e402010-01-04 07:37:31 +00001//===- InstCombineCompares.cpp --------------------------------------------===//
2//
3// The LLVM Compiler Infrastructure
4//
5// This file is distributed under the University of Illinois Open Source
6// License. See LICENSE.TXT for details.
7//
8//===----------------------------------------------------------------------===//
9//
10// This file implements the visitICmp and visitFCmp functions.
11//
12//===----------------------------------------------------------------------===//
13
Chandler Carrutha9174582015-01-22 05:25:13 +000014#include "InstCombineInternal.h"
Matt Arsenault55e73122015-01-06 15:50:59 +000015#include "llvm/ADT/APSInt.h"
Silviu Barangaf29dfd32016-01-15 15:52:05 +000016#include "llvm/ADT/SetVector.h"
Gerolf Hoflehnerec6217c2014-11-21 23:36:44 +000017#include "llvm/ADT/Statistic.h"
Eli Friedman911e12f2011-07-20 21:57:23 +000018#include "llvm/Analysis/ConstantFolding.h"
Chris Lattner2188e402010-01-04 07:37:31 +000019#include "llvm/Analysis/InstructionSimplify.h"
20#include "llvm/Analysis/MemoryBuiltins.h"
Mehdi Aminib550cb12016-04-18 09:17:29 +000021#include "llvm/Analysis/TargetLibraryInfo.h"
22#include "llvm/Analysis/VectorUtils.h"
Chandler Carruth8cd041e2014-03-04 12:24:34 +000023#include "llvm/IR/ConstantRange.h"
Chandler Carruth9fb823b2013-01-02 11:36:10 +000024#include "llvm/IR/DataLayout.h"
Chandler Carruth03eb0de2014-03-04 10:40:04 +000025#include "llvm/IR/GetElementPtrTypeIterator.h"
Chandler Carruth9fb823b2013-01-02 11:36:10 +000026#include "llvm/IR/IntrinsicInst.h"
Chandler Carruth820a9082014-03-04 11:08:18 +000027#include "llvm/IR/PatternMatch.h"
Gerolf Hoflehnerec6217c2014-11-21 23:36:44 +000028#include "llvm/Support/Debug.h"
Craig Topperb45eabc2017-04-26 16:39:58 +000029#include "llvm/Support/KnownBits.h"
Gerolf Hoflehnerec6217c2014-11-21 23:36:44 +000030
Chris Lattner2188e402010-01-04 07:37:31 +000031using namespace llvm;
32using namespace PatternMatch;
33
Chandler Carruth964daaa2014-04-22 02:55:47 +000034#define DEBUG_TYPE "instcombine"
35
Gerolf Hoflehnerec6217c2014-11-21 23:36:44 +000036// How many times is a select replaced by one of its operands?
37STATISTIC(NumSel, "Number of select opts");
38
Chris Lattner98457102011-02-10 05:23:05 +000039
Sanjay Pateld93c4c02016-09-15 18:22:25 +000040static ConstantInt *extractElement(Constant *V, Constant *Idx) {
Chris Lattner2188e402010-01-04 07:37:31 +000041 return cast<ConstantInt>(ConstantExpr::getExtractElement(V, Idx));
42}
43
Sanjay Pateld93c4c02016-09-15 18:22:25 +000044static bool hasAddOverflow(ConstantInt *Result,
Chris Lattner2188e402010-01-04 07:37:31 +000045 ConstantInt *In1, ConstantInt *In2,
46 bool IsSigned) {
Chris Lattnerb1a15122011-07-15 06:08:15 +000047 if (!IsSigned)
Chris Lattner2188e402010-01-04 07:37:31 +000048 return Result->getValue().ult(In1->getValue());
Chris Lattnerb1a15122011-07-15 06:08:15 +000049
50 if (In2->isNegative())
51 return Result->getValue().sgt(In1->getValue());
52 return Result->getValue().slt(In1->getValue());
Chris Lattner2188e402010-01-04 07:37:31 +000053}
54
Sanjay Patel5f0217f2016-06-05 16:46:18 +000055/// Compute Result = In1+In2, returning true if the result overflowed for this
56/// type.
Sanjay Pateld93c4c02016-09-15 18:22:25 +000057static bool addWithOverflow(Constant *&Result, Constant *In1,
Chris Lattner2188e402010-01-04 07:37:31 +000058 Constant *In2, bool IsSigned = false) {
59 Result = ConstantExpr::getAdd(In1, In2);
60
Chris Lattner229907c2011-07-18 04:54:35 +000061 if (VectorType *VTy = dyn_cast<VectorType>(In1->getType())) {
Chris Lattner2188e402010-01-04 07:37:31 +000062 for (unsigned i = 0, e = VTy->getNumElements(); i != e; ++i) {
63 Constant *Idx = ConstantInt::get(Type::getInt32Ty(In1->getContext()), i);
Sanjay Pateld93c4c02016-09-15 18:22:25 +000064 if (hasAddOverflow(extractElement(Result, Idx),
65 extractElement(In1, Idx),
66 extractElement(In2, Idx),
Chris Lattner2188e402010-01-04 07:37:31 +000067 IsSigned))
68 return true;
69 }
70 return false;
71 }
72
Sanjay Pateld93c4c02016-09-15 18:22:25 +000073 return hasAddOverflow(cast<ConstantInt>(Result),
Chris Lattner2188e402010-01-04 07:37:31 +000074 cast<ConstantInt>(In1), cast<ConstantInt>(In2),
75 IsSigned);
76}
77
Sanjay Pateld93c4c02016-09-15 18:22:25 +000078static bool hasSubOverflow(ConstantInt *Result,
Chris Lattner2188e402010-01-04 07:37:31 +000079 ConstantInt *In1, ConstantInt *In2,
80 bool IsSigned) {
Chris Lattnerb1a15122011-07-15 06:08:15 +000081 if (!IsSigned)
Chris Lattner2188e402010-01-04 07:37:31 +000082 return Result->getValue().ugt(In1->getValue());
Jim Grosbach129c52a2011-09-30 18:09:53 +000083
Chris Lattnerb1a15122011-07-15 06:08:15 +000084 if (In2->isNegative())
85 return Result->getValue().slt(In1->getValue());
86
87 return Result->getValue().sgt(In1->getValue());
Chris Lattner2188e402010-01-04 07:37:31 +000088}
89
Sanjay Patel5f0217f2016-06-05 16:46:18 +000090/// Compute Result = In1-In2, returning true if the result overflowed for this
91/// type.
Sanjay Pateld93c4c02016-09-15 18:22:25 +000092static bool subWithOverflow(Constant *&Result, Constant *In1,
Chris Lattner2188e402010-01-04 07:37:31 +000093 Constant *In2, bool IsSigned = false) {
94 Result = ConstantExpr::getSub(In1, In2);
95
Chris Lattner229907c2011-07-18 04:54:35 +000096 if (VectorType *VTy = dyn_cast<VectorType>(In1->getType())) {
Chris Lattner2188e402010-01-04 07:37:31 +000097 for (unsigned i = 0, e = VTy->getNumElements(); i != e; ++i) {
98 Constant *Idx = ConstantInt::get(Type::getInt32Ty(In1->getContext()), i);
Sanjay Pateld93c4c02016-09-15 18:22:25 +000099 if (hasSubOverflow(extractElement(Result, Idx),
100 extractElement(In1, Idx),
101 extractElement(In2, Idx),
Chris Lattner2188e402010-01-04 07:37:31 +0000102 IsSigned))
103 return true;
104 }
105 return false;
106 }
107
Sanjay Pateld93c4c02016-09-15 18:22:25 +0000108 return hasSubOverflow(cast<ConstantInt>(Result),
Chris Lattner2188e402010-01-04 07:37:31 +0000109 cast<ConstantInt>(In1), cast<ConstantInt>(In2),
110 IsSigned);
111}
112
Balaram Makam569eaec2016-05-04 21:32:14 +0000113/// Given an icmp instruction, return true if any use of this comparison is a
114/// branch on sign bit comparison.
115static bool isBranchOnSignBitCheck(ICmpInst &I, bool isSignBit) {
116 for (auto *U : I.users())
117 if (isa<BranchInst>(U))
118 return isSignBit;
119 return false;
120}
121
Sanjay Patel5f0217f2016-06-05 16:46:18 +0000122/// Given an exploded icmp instruction, return true if the comparison only
123/// checks the sign bit. If it only checks the sign bit, set TrueIfSigned if the
124/// result of the comparison is true when the input value is signed.
Sanjay Patel79263662016-08-21 15:07:45 +0000125static bool isSignBitCheck(ICmpInst::Predicate Pred, const APInt &RHS,
Chris Lattner2188e402010-01-04 07:37:31 +0000126 bool &TrueIfSigned) {
Sanjay Patel5f0217f2016-06-05 16:46:18 +0000127 switch (Pred) {
Chris Lattner2188e402010-01-04 07:37:31 +0000128 case ICmpInst::ICMP_SLT: // True if LHS s< 0
129 TrueIfSigned = true;
Sanjay Patel79263662016-08-21 15:07:45 +0000130 return RHS == 0;
Chris Lattner2188e402010-01-04 07:37:31 +0000131 case ICmpInst::ICMP_SLE: // True if LHS s<= RHS and RHS == -1
132 TrueIfSigned = true;
Sanjay Patel79263662016-08-21 15:07:45 +0000133 return RHS.isAllOnesValue();
Chris Lattner2188e402010-01-04 07:37:31 +0000134 case ICmpInst::ICMP_SGT: // True if LHS s> -1
135 TrueIfSigned = false;
Sanjay Patel79263662016-08-21 15:07:45 +0000136 return RHS.isAllOnesValue();
Chris Lattner2188e402010-01-04 07:37:31 +0000137 case ICmpInst::ICMP_UGT:
138 // True if LHS u> RHS and RHS == high-bit-mask - 1
139 TrueIfSigned = true;
Sanjay Patel79263662016-08-21 15:07:45 +0000140 return RHS.isMaxSignedValue();
Jim Grosbach129c52a2011-09-30 18:09:53 +0000141 case ICmpInst::ICMP_UGE:
Chris Lattner2188e402010-01-04 07:37:31 +0000142 // True if LHS u>= RHS and RHS == high-bit-mask (2^7, 2^15, 2^31, etc)
143 TrueIfSigned = true;
Craig Topperbcfd2d12017-04-20 16:56:25 +0000144 return RHS.isSignMask();
Chris Lattner2188e402010-01-04 07:37:31 +0000145 default:
146 return false;
147 }
148}
149
Arnaud A. de Grandmaison3ee88e82013-03-25 11:47:38 +0000150/// Returns true if the exploded icmp can be expressed as a signed comparison
151/// to zero and updates the predicate accordingly.
152/// The signedness of the comparison is preserved.
Sanjay Patel5b112842016-08-18 14:59:14 +0000153/// TODO: Refactor with decomposeBitTestICmp()?
154static bool isSignTest(ICmpInst::Predicate &Pred, const APInt &C) {
Sanjay Patel5f0217f2016-06-05 16:46:18 +0000155 if (!ICmpInst::isSigned(Pred))
Arnaud A. de Grandmaison9c383d62013-03-25 09:48:49 +0000156 return false;
157
Sanjay Patel5b112842016-08-18 14:59:14 +0000158 if (C == 0)
Sanjay Patel5f0217f2016-06-05 16:46:18 +0000159 return ICmpInst::isRelational(Pred);
Arnaud A. de Grandmaison9c383d62013-03-25 09:48:49 +0000160
Sanjay Patel5b112842016-08-18 14:59:14 +0000161 if (C == 1) {
Sanjay Patel5f0217f2016-06-05 16:46:18 +0000162 if (Pred == ICmpInst::ICMP_SLT) {
163 Pred = ICmpInst::ICMP_SLE;
Arnaud A. de Grandmaison9c383d62013-03-25 09:48:49 +0000164 return true;
Arnaud A. de Grandmaison9c383d62013-03-25 09:48:49 +0000165 }
Sanjay Patel5b112842016-08-18 14:59:14 +0000166 } else if (C.isAllOnesValue()) {
Sanjay Patel5f0217f2016-06-05 16:46:18 +0000167 if (Pred == ICmpInst::ICMP_SGT) {
168 Pred = ICmpInst::ICMP_SGE;
Arnaud A. de Grandmaison9c383d62013-03-25 09:48:49 +0000169 return true;
Arnaud A. de Grandmaison9c383d62013-03-25 09:48:49 +0000170 }
Arnaud A. de Grandmaison3ee88e82013-03-25 11:47:38 +0000171 }
Arnaud A. de Grandmaison9c383d62013-03-25 09:48:49 +0000172
173 return false;
174}
175
Sanjay Patel5f0217f2016-06-05 16:46:18 +0000176/// Given a signed integer type and a set of known zero and one bits, compute
177/// the maximum and minimum values that could have the specified known zero and
178/// known one bits, returning them in Min/Max.
Craig Topperb45eabc2017-04-26 16:39:58 +0000179/// TODO: Move to method on KnownBits struct?
180static void computeSignedMinMaxValuesFromKnownBits(const KnownBits &Known,
Sanjay Patel5f0217f2016-06-05 16:46:18 +0000181 APInt &Min, APInt &Max) {
Craig Topperb45eabc2017-04-26 16:39:58 +0000182 assert(Known.getBitWidth() == Min.getBitWidth() &&
183 Known.getBitWidth() == Max.getBitWidth() &&
Chris Lattner2188e402010-01-04 07:37:31 +0000184 "KnownZero, KnownOne and Min, Max must have equal bitwidth.");
Craig Topperb45eabc2017-04-26 16:39:58 +0000185 APInt UnknownBits = ~(Known.Zero|Known.One);
Chris Lattner2188e402010-01-04 07:37:31 +0000186
187 // The minimum value is when all unknown bits are zeros, EXCEPT for the sign
188 // bit if it is unknown.
Craig Topperb45eabc2017-04-26 16:39:58 +0000189 Min = Known.One;
190 Max = Known.One|UnknownBits;
Jim Grosbach129c52a2011-09-30 18:09:53 +0000191
Chris Lattner2188e402010-01-04 07:37:31 +0000192 if (UnknownBits.isNegative()) { // Sign bit is unknown
Craig Topper24db6b82017-04-28 16:58:05 +0000193 Min.setSignBit();
194 Max.clearSignBit();
Chris Lattner2188e402010-01-04 07:37:31 +0000195 }
196}
197
Sanjay Patel5f0217f2016-06-05 16:46:18 +0000198/// Given an unsigned integer type and a set of known zero and one bits, compute
199/// the maximum and minimum values that could have the specified known zero and
200/// known one bits, returning them in Min/Max.
Craig Topperb45eabc2017-04-26 16:39:58 +0000201/// TODO: Move to method on KnownBits struct?
202static void computeUnsignedMinMaxValuesFromKnownBits(const KnownBits &Known,
Chris Lattner2188e402010-01-04 07:37:31 +0000203 APInt &Min, APInt &Max) {
Craig Topperb45eabc2017-04-26 16:39:58 +0000204 assert(Known.getBitWidth() == Min.getBitWidth() &&
205 Known.getBitWidth() == Max.getBitWidth() &&
Chris Lattner2188e402010-01-04 07:37:31 +0000206 "Ty, KnownZero, KnownOne and Min, Max must have equal bitwidth.");
Craig Topperb45eabc2017-04-26 16:39:58 +0000207 APInt UnknownBits = ~(Known.Zero|Known.One);
Jim Grosbach129c52a2011-09-30 18:09:53 +0000208
Chris Lattner2188e402010-01-04 07:37:31 +0000209 // The minimum value is when the unknown bits are all zeros.
Craig Topperb45eabc2017-04-26 16:39:58 +0000210 Min = Known.One;
Chris Lattner2188e402010-01-04 07:37:31 +0000211 // The maximum value is when the unknown bits are all ones.
Craig Topperb45eabc2017-04-26 16:39:58 +0000212 Max = Known.One|UnknownBits;
Chris Lattner2188e402010-01-04 07:37:31 +0000213}
214
Sanjay Patel5f0217f2016-06-05 16:46:18 +0000215/// This is called when we see this pattern:
Chris Lattner2188e402010-01-04 07:37:31 +0000216/// cmp pred (load (gep GV, ...)), cmpcst
Sanjay Patel5f0217f2016-06-05 16:46:18 +0000217/// where GV is a global variable with a constant initializer. Try to simplify
218/// this into some simple computation that does not need the load. For example
Chris Lattner2188e402010-01-04 07:37:31 +0000219/// we can optimize "icmp eq (load (gep "foo", 0, i)), 0" into "icmp eq i, 3".
220///
221/// If AndCst is non-null, then the loaded value is masked with that constant
Sanjay Patel5f0217f2016-06-05 16:46:18 +0000222/// before doing the comparison. This handles cases like "A[i]&4 == 0".
Sanjay Patel43395062016-07-21 18:07:40 +0000223Instruction *InstCombiner::foldCmpLoadFromIndexedGlobal(GetElementPtrInst *GEP,
224 GlobalVariable *GV,
225 CmpInst &ICI,
226 ConstantInt *AndCst) {
Chris Lattnerfe741762012-01-31 02:55:06 +0000227 Constant *Init = GV->getInitializer();
228 if (!isa<ConstantArray>(Init) && !isa<ConstantDataArray>(Init))
Craig Topperf40110f2014-04-25 05:29:35 +0000229 return nullptr;
Jim Grosbachbdbd7342013-04-05 21:20:12 +0000230
Chris Lattnerfe741762012-01-31 02:55:06 +0000231 uint64_t ArrayElementCount = Init->getType()->getArrayNumElements();
Davide Italiano2133bf52017-02-07 17:56:50 +0000232 // Don't blow up on huge arrays.
233 if (ArrayElementCount > MaxArraySizeForCombine)
234 return nullptr;
Jim Grosbach129c52a2011-09-30 18:09:53 +0000235
Chris Lattner2188e402010-01-04 07:37:31 +0000236 // There are many forms of this optimization we can handle, for now, just do
237 // the simple index into a single-dimensional array.
238 //
239 // Require: GEP GV, 0, i {{, constant indices}}
240 if (GEP->getNumOperands() < 3 ||
241 !isa<ConstantInt>(GEP->getOperand(1)) ||
242 !cast<ConstantInt>(GEP->getOperand(1))->isZero() ||
243 isa<Constant>(GEP->getOperand(2)))
Craig Topperf40110f2014-04-25 05:29:35 +0000244 return nullptr;
Chris Lattner2188e402010-01-04 07:37:31 +0000245
246 // Check that indices after the variable are constants and in-range for the
247 // type they index. Collect the indices. This is typically for arrays of
248 // structs.
249 SmallVector<unsigned, 4> LaterIndices;
Jim Grosbach129c52a2011-09-30 18:09:53 +0000250
Chris Lattnerfe741762012-01-31 02:55:06 +0000251 Type *EltTy = Init->getType()->getArrayElementType();
Chris Lattner2188e402010-01-04 07:37:31 +0000252 for (unsigned i = 3, e = GEP->getNumOperands(); i != e; ++i) {
253 ConstantInt *Idx = dyn_cast<ConstantInt>(GEP->getOperand(i));
Craig Topperf40110f2014-04-25 05:29:35 +0000254 if (!Idx) return nullptr; // Variable index.
Jim Grosbach129c52a2011-09-30 18:09:53 +0000255
Chris Lattner2188e402010-01-04 07:37:31 +0000256 uint64_t IdxVal = Idx->getZExtValue();
Craig Topperf40110f2014-04-25 05:29:35 +0000257 if ((unsigned)IdxVal != IdxVal) return nullptr; // Too large array index.
Jim Grosbach129c52a2011-09-30 18:09:53 +0000258
Chris Lattner229907c2011-07-18 04:54:35 +0000259 if (StructType *STy = dyn_cast<StructType>(EltTy))
Chris Lattner2188e402010-01-04 07:37:31 +0000260 EltTy = STy->getElementType(IdxVal);
Chris Lattner229907c2011-07-18 04:54:35 +0000261 else if (ArrayType *ATy = dyn_cast<ArrayType>(EltTy)) {
Craig Topperf40110f2014-04-25 05:29:35 +0000262 if (IdxVal >= ATy->getNumElements()) return nullptr;
Chris Lattner2188e402010-01-04 07:37:31 +0000263 EltTy = ATy->getElementType();
264 } else {
Craig Topperf40110f2014-04-25 05:29:35 +0000265 return nullptr; // Unknown type.
Chris Lattner2188e402010-01-04 07:37:31 +0000266 }
Jim Grosbach129c52a2011-09-30 18:09:53 +0000267
Chris Lattner2188e402010-01-04 07:37:31 +0000268 LaterIndices.push_back(IdxVal);
269 }
Jim Grosbach129c52a2011-09-30 18:09:53 +0000270
Chris Lattner2188e402010-01-04 07:37:31 +0000271 enum { Overdefined = -3, Undefined = -2 };
272
273 // Variables for our state machines.
Jim Grosbach129c52a2011-09-30 18:09:53 +0000274
Chris Lattner2188e402010-01-04 07:37:31 +0000275 // FirstTrueElement/SecondTrueElement - Used to emit a comparison of the form
276 // "i == 47 | i == 87", where 47 is the first index the condition is true for,
277 // and 87 is the second (and last) index. FirstTrueElement is -2 when
278 // undefined, otherwise set to the first true element. SecondTrueElement is
279 // -2 when undefined, -3 when overdefined and >= 0 when that index is true.
280 int FirstTrueElement = Undefined, SecondTrueElement = Undefined;
281
282 // FirstFalseElement/SecondFalseElement - Used to emit a comparison of the
283 // form "i != 47 & i != 87". Same state transitions as for true elements.
284 int FirstFalseElement = Undefined, SecondFalseElement = Undefined;
Jim Grosbach129c52a2011-09-30 18:09:53 +0000285
Chris Lattner2188e402010-01-04 07:37:31 +0000286 /// TrueRangeEnd/FalseRangeEnd - In conjunction with First*Element, these
287 /// define a state machine that triggers for ranges of values that the index
288 /// is true or false for. This triggers on things like "abbbbc"[i] == 'b'.
289 /// This is -2 when undefined, -3 when overdefined, and otherwise the last
290 /// index in the range (inclusive). We use -2 for undefined here because we
291 /// use relative comparisons and don't want 0-1 to match -1.
292 int TrueRangeEnd = Undefined, FalseRangeEnd = Undefined;
Jim Grosbach129c52a2011-09-30 18:09:53 +0000293
Chris Lattner2188e402010-01-04 07:37:31 +0000294 // MagicBitvector - This is a magic bitvector where we set a bit if the
295 // comparison is true for element 'i'. If there are 64 elements or less in
296 // the array, this will fully represent all the comparison results.
297 uint64_t MagicBitvector = 0;
Jim Grosbach129c52a2011-09-30 18:09:53 +0000298
Chris Lattner2188e402010-01-04 07:37:31 +0000299 // Scan the array and see if one of our patterns matches.
300 Constant *CompareRHS = cast<Constant>(ICI.getOperand(1));
Chris Lattnerfe741762012-01-31 02:55:06 +0000301 for (unsigned i = 0, e = ArrayElementCount; i != e; ++i) {
302 Constant *Elt = Init->getAggregateElement(i);
Craig Topperf40110f2014-04-25 05:29:35 +0000303 if (!Elt) return nullptr;
Jim Grosbach129c52a2011-09-30 18:09:53 +0000304
Chris Lattner2188e402010-01-04 07:37:31 +0000305 // If this is indexing an array of structures, get the structure element.
306 if (!LaterIndices.empty())
Jay Foad57aa6362011-07-13 10:26:04 +0000307 Elt = ConstantExpr::getExtractValue(Elt, LaterIndices);
Jim Grosbach129c52a2011-09-30 18:09:53 +0000308
Chris Lattner2188e402010-01-04 07:37:31 +0000309 // If the element is masked, handle it.
310 if (AndCst) Elt = ConstantExpr::getAnd(Elt, AndCst);
Jim Grosbach129c52a2011-09-30 18:09:53 +0000311
Chris Lattner2188e402010-01-04 07:37:31 +0000312 // Find out if the comparison would be true or false for the i'th element.
313 Constant *C = ConstantFoldCompareInstOperands(ICI.getPredicate(), Elt,
Justin Bogner99798402016-08-05 01:06:44 +0000314 CompareRHS, DL, &TLI);
Chris Lattner2188e402010-01-04 07:37:31 +0000315 // If the result is undef for this element, ignore it.
316 if (isa<UndefValue>(C)) {
317 // Extend range state machines to cover this element in case there is an
318 // undef in the middle of the range.
319 if (TrueRangeEnd == (int)i-1)
320 TrueRangeEnd = i;
321 if (FalseRangeEnd == (int)i-1)
322 FalseRangeEnd = i;
323 continue;
324 }
Jim Grosbach129c52a2011-09-30 18:09:53 +0000325
Chris Lattner2188e402010-01-04 07:37:31 +0000326 // If we can't compute the result for any of the elements, we have to give
327 // up evaluating the entire conditional.
Craig Topperf40110f2014-04-25 05:29:35 +0000328 if (!isa<ConstantInt>(C)) return nullptr;
Jim Grosbach129c52a2011-09-30 18:09:53 +0000329
Chris Lattner2188e402010-01-04 07:37:31 +0000330 // Otherwise, we know if the comparison is true or false for this element,
331 // update our state machines.
332 bool IsTrueForElt = !cast<ConstantInt>(C)->isZero();
Jim Grosbach129c52a2011-09-30 18:09:53 +0000333
Chris Lattner2188e402010-01-04 07:37:31 +0000334 // State machine for single/double/range index comparison.
335 if (IsTrueForElt) {
336 // Update the TrueElement state machine.
337 if (FirstTrueElement == Undefined)
338 FirstTrueElement = TrueRangeEnd = i; // First true element.
339 else {
340 // Update double-compare state machine.
341 if (SecondTrueElement == Undefined)
342 SecondTrueElement = i;
343 else
344 SecondTrueElement = Overdefined;
Jim Grosbach129c52a2011-09-30 18:09:53 +0000345
Chris Lattner2188e402010-01-04 07:37:31 +0000346 // Update range state machine.
347 if (TrueRangeEnd == (int)i-1)
348 TrueRangeEnd = i;
349 else
350 TrueRangeEnd = Overdefined;
351 }
352 } else {
353 // Update the FalseElement state machine.
354 if (FirstFalseElement == Undefined)
355 FirstFalseElement = FalseRangeEnd = i; // First false element.
356 else {
357 // Update double-compare state machine.
358 if (SecondFalseElement == Undefined)
359 SecondFalseElement = i;
360 else
361 SecondFalseElement = Overdefined;
Jim Grosbach129c52a2011-09-30 18:09:53 +0000362
Chris Lattner2188e402010-01-04 07:37:31 +0000363 // Update range state machine.
364 if (FalseRangeEnd == (int)i-1)
365 FalseRangeEnd = i;
366 else
367 FalseRangeEnd = Overdefined;
368 }
369 }
Jim Grosbach129c52a2011-09-30 18:09:53 +0000370
Chris Lattner2188e402010-01-04 07:37:31 +0000371 // If this element is in range, update our magic bitvector.
372 if (i < 64 && IsTrueForElt)
373 MagicBitvector |= 1ULL << i;
Jim Grosbach129c52a2011-09-30 18:09:53 +0000374
Chris Lattner2188e402010-01-04 07:37:31 +0000375 // If all of our states become overdefined, bail out early. Since the
376 // predicate is expensive, only check it every 8 elements. This is only
377 // really useful for really huge arrays.
378 if ((i & 8) == 0 && i >= 64 && SecondTrueElement == Overdefined &&
379 SecondFalseElement == Overdefined && TrueRangeEnd == Overdefined &&
380 FalseRangeEnd == Overdefined)
Craig Topperf40110f2014-04-25 05:29:35 +0000381 return nullptr;
Chris Lattner2188e402010-01-04 07:37:31 +0000382 }
383
384 // Now that we've scanned the entire array, emit our new comparison(s). We
385 // order the state machines in complexity of the generated code.
386 Value *Idx = GEP->getOperand(2);
387
Matt Arsenault5aeae182013-08-19 21:40:31 +0000388 // If the index is larger than the pointer size of the target, truncate the
389 // index down like the GEP would do implicitly. We don't have to do this for
390 // an inbounds GEP because the index can't be out of range.
Matt Arsenault84680622013-09-30 21:11:01 +0000391 if (!GEP->isInBounds()) {
Mehdi Aminia28d91d2015-03-10 02:37:25 +0000392 Type *IntPtrTy = DL.getIntPtrType(GEP->getType());
Matt Arsenault84680622013-09-30 21:11:01 +0000393 unsigned PtrSize = IntPtrTy->getIntegerBitWidth();
394 if (Idx->getType()->getPrimitiveSizeInBits() > PtrSize)
395 Idx = Builder->CreateTrunc(Idx, IntPtrTy);
396 }
Matt Arsenault5aeae182013-08-19 21:40:31 +0000397
Chris Lattner2188e402010-01-04 07:37:31 +0000398 // If the comparison is only true for one or two elements, emit direct
399 // comparisons.
400 if (SecondTrueElement != Overdefined) {
401 // None true -> false.
402 if (FirstTrueElement == Undefined)
Sanjay Patel4b198802016-02-01 22:23:39 +0000403 return replaceInstUsesWith(ICI, Builder->getFalse());
Jim Grosbach129c52a2011-09-30 18:09:53 +0000404
Chris Lattner2188e402010-01-04 07:37:31 +0000405 Value *FirstTrueIdx = ConstantInt::get(Idx->getType(), FirstTrueElement);
Jim Grosbach129c52a2011-09-30 18:09:53 +0000406
Chris Lattner2188e402010-01-04 07:37:31 +0000407 // True for one element -> 'i == 47'.
408 if (SecondTrueElement == Undefined)
409 return new ICmpInst(ICmpInst::ICMP_EQ, Idx, FirstTrueIdx);
Jim Grosbach129c52a2011-09-30 18:09:53 +0000410
Chris Lattner2188e402010-01-04 07:37:31 +0000411 // True for two elements -> 'i == 47 | i == 72'.
412 Value *C1 = Builder->CreateICmpEQ(Idx, FirstTrueIdx);
413 Value *SecondTrueIdx = ConstantInt::get(Idx->getType(), SecondTrueElement);
414 Value *C2 = Builder->CreateICmpEQ(Idx, SecondTrueIdx);
415 return BinaryOperator::CreateOr(C1, C2);
416 }
417
418 // If the comparison is only false for one or two elements, emit direct
419 // comparisons.
420 if (SecondFalseElement != Overdefined) {
421 // None false -> true.
422 if (FirstFalseElement == Undefined)
Sanjay Patel4b198802016-02-01 22:23:39 +0000423 return replaceInstUsesWith(ICI, Builder->getTrue());
Jim Grosbach129c52a2011-09-30 18:09:53 +0000424
Chris Lattner2188e402010-01-04 07:37:31 +0000425 Value *FirstFalseIdx = ConstantInt::get(Idx->getType(), FirstFalseElement);
426
427 // False for one element -> 'i != 47'.
428 if (SecondFalseElement == Undefined)
429 return new ICmpInst(ICmpInst::ICMP_NE, Idx, FirstFalseIdx);
Jim Grosbach129c52a2011-09-30 18:09:53 +0000430
Chris Lattner2188e402010-01-04 07:37:31 +0000431 // False for two elements -> 'i != 47 & i != 72'.
432 Value *C1 = Builder->CreateICmpNE(Idx, FirstFalseIdx);
433 Value *SecondFalseIdx = ConstantInt::get(Idx->getType(),SecondFalseElement);
434 Value *C2 = Builder->CreateICmpNE(Idx, SecondFalseIdx);
435 return BinaryOperator::CreateAnd(C1, C2);
436 }
Jim Grosbach129c52a2011-09-30 18:09:53 +0000437
Chris Lattner2188e402010-01-04 07:37:31 +0000438 // If the comparison can be replaced with a range comparison for the elements
439 // where it is true, emit the range check.
440 if (TrueRangeEnd != Overdefined) {
441 assert(TrueRangeEnd != FirstTrueElement && "Should emit single compare");
Jim Grosbach129c52a2011-09-30 18:09:53 +0000442
Chris Lattner2188e402010-01-04 07:37:31 +0000443 // Generate (i-FirstTrue) <u (TrueRangeEnd-FirstTrue+1).
444 if (FirstTrueElement) {
445 Value *Offs = ConstantInt::get(Idx->getType(), -FirstTrueElement);
446 Idx = Builder->CreateAdd(Idx, Offs);
447 }
Jim Grosbach129c52a2011-09-30 18:09:53 +0000448
Chris Lattner2188e402010-01-04 07:37:31 +0000449 Value *End = ConstantInt::get(Idx->getType(),
450 TrueRangeEnd-FirstTrueElement+1);
451 return new ICmpInst(ICmpInst::ICMP_ULT, Idx, End);
452 }
Jim Grosbach129c52a2011-09-30 18:09:53 +0000453
Chris Lattner2188e402010-01-04 07:37:31 +0000454 // False range check.
455 if (FalseRangeEnd != Overdefined) {
456 assert(FalseRangeEnd != FirstFalseElement && "Should emit single compare");
457 // Generate (i-FirstFalse) >u (FalseRangeEnd-FirstFalse).
458 if (FirstFalseElement) {
459 Value *Offs = ConstantInt::get(Idx->getType(), -FirstFalseElement);
460 Idx = Builder->CreateAdd(Idx, Offs);
461 }
Jim Grosbach129c52a2011-09-30 18:09:53 +0000462
Chris Lattner2188e402010-01-04 07:37:31 +0000463 Value *End = ConstantInt::get(Idx->getType(),
464 FalseRangeEnd-FirstFalseElement);
465 return new ICmpInst(ICmpInst::ICMP_UGT, Idx, End);
466 }
Jim Grosbach129c52a2011-09-30 18:09:53 +0000467
Arnaud A. de Grandmaisonf364bc62013-03-22 08:25:01 +0000468 // If a magic bitvector captures the entire comparison state
Chris Lattner2188e402010-01-04 07:37:31 +0000469 // of this load, replace it with computation that does:
470 // ((magic_cst >> i) & 1) != 0
Arnaud A. de Grandmaisonf364bc62013-03-22 08:25:01 +0000471 {
Craig Topperf40110f2014-04-25 05:29:35 +0000472 Type *Ty = nullptr;
Arnaud A. de Grandmaisonf364bc62013-03-22 08:25:01 +0000473
474 // Look for an appropriate type:
475 // - The type of Idx if the magic fits
476 // - The smallest fitting legal type if we have a DataLayout
477 // - Default to i32
478 if (ArrayElementCount <= Idx->getType()->getIntegerBitWidth())
479 Ty = Idx->getType();
Mehdi Aminia28d91d2015-03-10 02:37:25 +0000480 else
481 Ty = DL.getSmallestLegalIntType(Init->getContext(), ArrayElementCount);
Arnaud A. de Grandmaisonf364bc62013-03-22 08:25:01 +0000482
Craig Topperf40110f2014-04-25 05:29:35 +0000483 if (Ty) {
Arnaud A. de Grandmaisonf364bc62013-03-22 08:25:01 +0000484 Value *V = Builder->CreateIntCast(Idx, Ty, false);
485 V = Builder->CreateLShr(ConstantInt::get(Ty, MagicBitvector), V);
486 V = Builder->CreateAnd(ConstantInt::get(Ty, 1), V);
487 return new ICmpInst(ICmpInst::ICMP_NE, V, ConstantInt::get(Ty, 0));
488 }
Chris Lattner2188e402010-01-04 07:37:31 +0000489 }
Jim Grosbach129c52a2011-09-30 18:09:53 +0000490
Craig Topperf40110f2014-04-25 05:29:35 +0000491 return nullptr;
Chris Lattner2188e402010-01-04 07:37:31 +0000492}
493
Sanjay Patel5f0217f2016-06-05 16:46:18 +0000494/// Return a value that can be used to compare the *offset* implied by a GEP to
495/// zero. For example, if we have &A[i], we want to return 'i' for
496/// "icmp ne i, 0". Note that, in general, indices can be complex, and scales
497/// are involved. The above expression would also be legal to codegen as
498/// "icmp ne (i*4), 0" (assuming A is a pointer to i32).
499/// This latter form is less amenable to optimization though, and we are allowed
Chris Lattner2188e402010-01-04 07:37:31 +0000500/// to generate the first by knowing that pointer arithmetic doesn't overflow.
501///
502/// If we can't emit an optimized form for this expression, this returns null.
Jim Grosbach129c52a2011-09-30 18:09:53 +0000503///
Sanjay Pateld93c4c02016-09-15 18:22:25 +0000504static Value *evaluateGEPOffsetExpression(User *GEP, InstCombiner &IC,
Mehdi Aminia28d91d2015-03-10 02:37:25 +0000505 const DataLayout &DL) {
Chris Lattner2188e402010-01-04 07:37:31 +0000506 gep_type_iterator GTI = gep_type_begin(GEP);
Jim Grosbach129c52a2011-09-30 18:09:53 +0000507
Chris Lattner2188e402010-01-04 07:37:31 +0000508 // Check to see if this gep only has a single variable index. If so, and if
509 // any constant indices are a multiple of its scale, then we can compute this
510 // in terms of the scale of the variable index. For example, if the GEP
511 // implies an offset of "12 + i*4", then we can codegen this as "3 + i",
512 // because the expression will cross zero at the same point.
513 unsigned i, e = GEP->getNumOperands();
514 int64_t Offset = 0;
515 for (i = 1; i != e; ++i, ++GTI) {
516 if (ConstantInt *CI = dyn_cast<ConstantInt>(GEP->getOperand(i))) {
517 // Compute the aggregate offset of constant indices.
518 if (CI->isZero()) continue;
Jim Grosbach129c52a2011-09-30 18:09:53 +0000519
Chris Lattner2188e402010-01-04 07:37:31 +0000520 // Handle a struct index, which adds its field offset to the pointer.
Peter Collingbourneab85225b2016-12-02 02:24:42 +0000521 if (StructType *STy = GTI.getStructTypeOrNull()) {
Rafael Espindola37dc9e12014-02-21 00:06:31 +0000522 Offset += DL.getStructLayout(STy)->getElementOffset(CI->getZExtValue());
Chris Lattner2188e402010-01-04 07:37:31 +0000523 } else {
Rafael Espindola37dc9e12014-02-21 00:06:31 +0000524 uint64_t Size = DL.getTypeAllocSize(GTI.getIndexedType());
Chris Lattner2188e402010-01-04 07:37:31 +0000525 Offset += Size*CI->getSExtValue();
526 }
527 } else {
528 // Found our variable index.
529 break;
530 }
531 }
Jim Grosbach129c52a2011-09-30 18:09:53 +0000532
Chris Lattner2188e402010-01-04 07:37:31 +0000533 // If there are no variable indices, we must have a constant offset, just
534 // evaluate it the general way.
Craig Topperf40110f2014-04-25 05:29:35 +0000535 if (i == e) return nullptr;
Jim Grosbach129c52a2011-09-30 18:09:53 +0000536
Chris Lattner2188e402010-01-04 07:37:31 +0000537 Value *VariableIdx = GEP->getOperand(i);
538 // Determine the scale factor of the variable element. For example, this is
539 // 4 if the variable index is into an array of i32.
Rafael Espindola37dc9e12014-02-21 00:06:31 +0000540 uint64_t VariableScale = DL.getTypeAllocSize(GTI.getIndexedType());
Jim Grosbach129c52a2011-09-30 18:09:53 +0000541
Chris Lattner2188e402010-01-04 07:37:31 +0000542 // Verify that there are no other variable indices. If so, emit the hard way.
543 for (++i, ++GTI; i != e; ++i, ++GTI) {
544 ConstantInt *CI = dyn_cast<ConstantInt>(GEP->getOperand(i));
Craig Topperf40110f2014-04-25 05:29:35 +0000545 if (!CI) return nullptr;
Jim Grosbach129c52a2011-09-30 18:09:53 +0000546
Chris Lattner2188e402010-01-04 07:37:31 +0000547 // Compute the aggregate offset of constant indices.
548 if (CI->isZero()) continue;
Jim Grosbach129c52a2011-09-30 18:09:53 +0000549
Chris Lattner2188e402010-01-04 07:37:31 +0000550 // Handle a struct index, which adds its field offset to the pointer.
Peter Collingbourneab85225b2016-12-02 02:24:42 +0000551 if (StructType *STy = GTI.getStructTypeOrNull()) {
Rafael Espindola37dc9e12014-02-21 00:06:31 +0000552 Offset += DL.getStructLayout(STy)->getElementOffset(CI->getZExtValue());
Chris Lattner2188e402010-01-04 07:37:31 +0000553 } else {
Rafael Espindola37dc9e12014-02-21 00:06:31 +0000554 uint64_t Size = DL.getTypeAllocSize(GTI.getIndexedType());
Chris Lattner2188e402010-01-04 07:37:31 +0000555 Offset += Size*CI->getSExtValue();
556 }
557 }
Jim Grosbach129c52a2011-09-30 18:09:53 +0000558
Chris Lattner2188e402010-01-04 07:37:31 +0000559 // Okay, we know we have a single variable index, which must be a
560 // pointer/array/vector index. If there is no offset, life is simple, return
561 // the index.
Rafael Espindola37dc9e12014-02-21 00:06:31 +0000562 Type *IntPtrTy = DL.getIntPtrType(GEP->getOperand(0)->getType());
Matt Arsenault745101d2013-08-21 19:53:10 +0000563 unsigned IntPtrWidth = IntPtrTy->getIntegerBitWidth();
Chris Lattner2188e402010-01-04 07:37:31 +0000564 if (Offset == 0) {
565 // Cast to intptrty in case a truncation occurs. If an extension is needed,
566 // we don't need to bother extending: the extension won't affect where the
567 // computation crosses zero.
Eli Friedman1754a252011-05-18 23:11:30 +0000568 if (VariableIdx->getType()->getPrimitiveSizeInBits() > IntPtrWidth) {
Eli Friedman1754a252011-05-18 23:11:30 +0000569 VariableIdx = IC.Builder->CreateTrunc(VariableIdx, IntPtrTy);
570 }
Chris Lattner2188e402010-01-04 07:37:31 +0000571 return VariableIdx;
572 }
Jim Grosbach129c52a2011-09-30 18:09:53 +0000573
Chris Lattner2188e402010-01-04 07:37:31 +0000574 // Otherwise, there is an index. The computation we will do will be modulo
575 // the pointer size, so get it.
576 uint64_t PtrSizeMask = ~0ULL >> (64-IntPtrWidth);
Jim Grosbach129c52a2011-09-30 18:09:53 +0000577
Chris Lattner2188e402010-01-04 07:37:31 +0000578 Offset &= PtrSizeMask;
579 VariableScale &= PtrSizeMask;
Jim Grosbach129c52a2011-09-30 18:09:53 +0000580
Chris Lattner2188e402010-01-04 07:37:31 +0000581 // To do this transformation, any constant index must be a multiple of the
582 // variable scale factor. For example, we can evaluate "12 + 4*i" as "3 + i",
583 // but we can't evaluate "10 + 3*i" in terms of i. Check that the offset is a
584 // multiple of the variable scale.
585 int64_t NewOffs = Offset / (int64_t)VariableScale;
586 if (Offset != NewOffs*(int64_t)VariableScale)
Craig Topperf40110f2014-04-25 05:29:35 +0000587 return nullptr;
Jim Grosbach129c52a2011-09-30 18:09:53 +0000588
Chris Lattner2188e402010-01-04 07:37:31 +0000589 // Okay, we can do this evaluation. Start by converting the index to intptr.
Chris Lattner2188e402010-01-04 07:37:31 +0000590 if (VariableIdx->getType() != IntPtrTy)
Eli Friedman1754a252011-05-18 23:11:30 +0000591 VariableIdx = IC.Builder->CreateIntCast(VariableIdx, IntPtrTy,
592 true /*Signed*/);
Chris Lattner2188e402010-01-04 07:37:31 +0000593 Constant *OffsetVal = ConstantInt::get(IntPtrTy, NewOffs);
Eli Friedman1754a252011-05-18 23:11:30 +0000594 return IC.Builder->CreateAdd(VariableIdx, OffsetVal, "offset");
Chris Lattner2188e402010-01-04 07:37:31 +0000595}
596
Silviu Barangaf29dfd32016-01-15 15:52:05 +0000597/// Returns true if we can rewrite Start as a GEP with pointer Base
598/// and some integer offset. The nodes that need to be re-written
599/// for this transformation will be added to Explored.
600static bool canRewriteGEPAsOffset(Value *Start, Value *Base,
601 const DataLayout &DL,
602 SetVector<Value *> &Explored) {
603 SmallVector<Value *, 16> WorkList(1, Start);
604 Explored.insert(Base);
605
606 // The following traversal gives us an order which can be used
607 // when doing the final transformation. Since in the final
608 // transformation we create the PHI replacement instructions first,
609 // we don't have to get them in any particular order.
610 //
611 // However, for other instructions we will have to traverse the
612 // operands of an instruction first, which means that we have to
613 // do a post-order traversal.
614 while (!WorkList.empty()) {
615 SetVector<PHINode *> PHIs;
616
617 while (!WorkList.empty()) {
618 if (Explored.size() >= 100)
619 return false;
620
621 Value *V = WorkList.back();
622
623 if (Explored.count(V) != 0) {
624 WorkList.pop_back();
625 continue;
626 }
627
628 if (!isa<IntToPtrInst>(V) && !isa<PtrToIntInst>(V) &&
David Majnemer8b16da82016-09-15 20:10:09 +0000629 !isa<GetElementPtrInst>(V) && !isa<PHINode>(V))
Silviu Barangaf29dfd32016-01-15 15:52:05 +0000630 // We've found some value that we can't explore which is different from
631 // the base. Therefore we can't do this transformation.
632 return false;
633
634 if (isa<IntToPtrInst>(V) || isa<PtrToIntInst>(V)) {
635 auto *CI = dyn_cast<CastInst>(V);
636 if (!CI->isNoopCast(DL))
637 return false;
638
639 if (Explored.count(CI->getOperand(0)) == 0)
640 WorkList.push_back(CI->getOperand(0));
641 }
642
643 if (auto *GEP = dyn_cast<GEPOperator>(V)) {
644 // We're limiting the GEP to having one index. This will preserve
645 // the original pointer type. We could handle more cases in the
646 // future.
647 if (GEP->getNumIndices() != 1 || !GEP->isInBounds() ||
648 GEP->getType() != Start->getType())
649 return false;
650
651 if (Explored.count(GEP->getOperand(0)) == 0)
652 WorkList.push_back(GEP->getOperand(0));
653 }
654
655 if (WorkList.back() == V) {
656 WorkList.pop_back();
657 // We've finished visiting this node, mark it as such.
658 Explored.insert(V);
659 }
660
661 if (auto *PN = dyn_cast<PHINode>(V)) {
David Majnemercdf28732016-03-19 04:39:52 +0000662 // We cannot transform PHIs on unsplittable basic blocks.
663 if (isa<CatchSwitchInst>(PN->getParent()->getTerminator()))
664 return false;
Silviu Barangaf29dfd32016-01-15 15:52:05 +0000665 Explored.insert(PN);
666 PHIs.insert(PN);
667 }
668 }
669
670 // Explore the PHI nodes further.
671 for (auto *PN : PHIs)
672 for (Value *Op : PN->incoming_values())
673 if (Explored.count(Op) == 0)
674 WorkList.push_back(Op);
675 }
676
677 // Make sure that we can do this. Since we can't insert GEPs in a basic
678 // block before a PHI node, we can't easily do this transformation if
679 // we have PHI node users of transformed instructions.
680 for (Value *Val : Explored) {
681 for (Value *Use : Val->uses()) {
682
683 auto *PHI = dyn_cast<PHINode>(Use);
684 auto *Inst = dyn_cast<Instruction>(Val);
685
686 if (Inst == Base || Inst == PHI || !Inst || !PHI ||
687 Explored.count(PHI) == 0)
688 continue;
689
690 if (PHI->getParent() == Inst->getParent())
691 return false;
692 }
693 }
694 return true;
695}
696
697// Sets the appropriate insert point on Builder where we can add
698// a replacement Instruction for V (if that is possible).
699static void setInsertionPoint(IRBuilder<> &Builder, Value *V,
700 bool Before = true) {
701 if (auto *PHI = dyn_cast<PHINode>(V)) {
702 Builder.SetInsertPoint(&*PHI->getParent()->getFirstInsertionPt());
703 return;
704 }
705 if (auto *I = dyn_cast<Instruction>(V)) {
706 if (!Before)
707 I = &*std::next(I->getIterator());
708 Builder.SetInsertPoint(I);
709 return;
710 }
711 if (auto *A = dyn_cast<Argument>(V)) {
712 // Set the insertion point in the entry block.
713 BasicBlock &Entry = A->getParent()->getEntryBlock();
714 Builder.SetInsertPoint(&*Entry.getFirstInsertionPt());
715 return;
716 }
717 // Otherwise, this is a constant and we don't need to set a new
718 // insertion point.
719 assert(isa<Constant>(V) && "Setting insertion point for unknown value!");
720}
721
722/// Returns a re-written value of Start as an indexed GEP using Base as a
723/// pointer.
724static Value *rewriteGEPAsOffset(Value *Start, Value *Base,
725 const DataLayout &DL,
726 SetVector<Value *> &Explored) {
727 // Perform all the substitutions. This is a bit tricky because we can
728 // have cycles in our use-def chains.
729 // 1. Create the PHI nodes without any incoming values.
730 // 2. Create all the other values.
731 // 3. Add the edges for the PHI nodes.
732 // 4. Emit GEPs to get the original pointers.
733 // 5. Remove the original instructions.
734 Type *IndexType = IntegerType::get(
735 Base->getContext(), DL.getPointerTypeSizeInBits(Start->getType()));
736
737 DenseMap<Value *, Value *> NewInsts;
738 NewInsts[Base] = ConstantInt::getNullValue(IndexType);
739
740 // Create the new PHI nodes, without adding any incoming values.
741 for (Value *Val : Explored) {
742 if (Val == Base)
743 continue;
744 // Create empty phi nodes. This avoids cyclic dependencies when creating
745 // the remaining instructions.
746 if (auto *PHI = dyn_cast<PHINode>(Val))
747 NewInsts[PHI] = PHINode::Create(IndexType, PHI->getNumIncomingValues(),
748 PHI->getName() + ".idx", PHI);
749 }
750 IRBuilder<> Builder(Base->getContext());
751
752 // Create all the other instructions.
753 for (Value *Val : Explored) {
754
755 if (NewInsts.find(Val) != NewInsts.end())
756 continue;
757
758 if (auto *CI = dyn_cast<CastInst>(Val)) {
759 NewInsts[CI] = NewInsts[CI->getOperand(0)];
760 continue;
761 }
762 if (auto *GEP = dyn_cast<GEPOperator>(Val)) {
763 Value *Index = NewInsts[GEP->getOperand(1)] ? NewInsts[GEP->getOperand(1)]
764 : GEP->getOperand(1);
765 setInsertionPoint(Builder, GEP);
766 // Indices might need to be sign extended. GEPs will magically do
767 // this, but we need to do it ourselves here.
768 if (Index->getType()->getScalarSizeInBits() !=
769 NewInsts[GEP->getOperand(0)]->getType()->getScalarSizeInBits()) {
770 Index = Builder.CreateSExtOrTrunc(
771 Index, NewInsts[GEP->getOperand(0)]->getType(),
772 GEP->getOperand(0)->getName() + ".sext");
773 }
774
775 auto *Op = NewInsts[GEP->getOperand(0)];
776 if (isa<ConstantInt>(Op) && dyn_cast<ConstantInt>(Op)->isZero())
777 NewInsts[GEP] = Index;
778 else
779 NewInsts[GEP] = Builder.CreateNSWAdd(
780 Op, Index, GEP->getOperand(0)->getName() + ".add");
781 continue;
782 }
783 if (isa<PHINode>(Val))
784 continue;
785
786 llvm_unreachable("Unexpected instruction type");
787 }
788
789 // Add the incoming values to the PHI nodes.
790 for (Value *Val : Explored) {
791 if (Val == Base)
792 continue;
793 // All the instructions have been created, we can now add edges to the
794 // phi nodes.
795 if (auto *PHI = dyn_cast<PHINode>(Val)) {
796 PHINode *NewPhi = static_cast<PHINode *>(NewInsts[PHI]);
797 for (unsigned I = 0, E = PHI->getNumIncomingValues(); I < E; ++I) {
798 Value *NewIncoming = PHI->getIncomingValue(I);
799
800 if (NewInsts.find(NewIncoming) != NewInsts.end())
801 NewIncoming = NewInsts[NewIncoming];
802
803 NewPhi->addIncoming(NewIncoming, PHI->getIncomingBlock(I));
804 }
805 }
806 }
807
808 for (Value *Val : Explored) {
809 if (Val == Base)
810 continue;
811
812 // Depending on the type, for external users we have to emit
813 // a GEP or a GEP + ptrtoint.
814 setInsertionPoint(Builder, Val, false);
815
816 // If required, create an inttoptr instruction for Base.
817 Value *NewBase = Base;
818 if (!Base->getType()->isPointerTy())
819 NewBase = Builder.CreateBitOrPointerCast(Base, Start->getType(),
820 Start->getName() + "to.ptr");
821
822 Value *GEP = Builder.CreateInBoundsGEP(
823 Start->getType()->getPointerElementType(), NewBase,
824 makeArrayRef(NewInsts[Val]), Val->getName() + ".ptr");
825
826 if (!Val->getType()->isPointerTy()) {
827 Value *Cast = Builder.CreatePointerCast(GEP, Val->getType(),
828 Val->getName() + ".conv");
829 GEP = Cast;
830 }
831 Val->replaceAllUsesWith(GEP);
832 }
833
834 return NewInsts[Start];
835}
836
837/// Looks through GEPs, IntToPtrInsts and PtrToIntInsts in order to express
838/// the input Value as a constant indexed GEP. Returns a pair containing
839/// the GEPs Pointer and Index.
840static std::pair<Value *, Value *>
841getAsConstantIndexedAddress(Value *V, const DataLayout &DL) {
842 Type *IndexType = IntegerType::get(V->getContext(),
843 DL.getPointerTypeSizeInBits(V->getType()));
844
845 Constant *Index = ConstantInt::getNullValue(IndexType);
846 while (true) {
847 if (GEPOperator *GEP = dyn_cast<GEPOperator>(V)) {
848 // We accept only inbouds GEPs here to exclude the possibility of
849 // overflow.
850 if (!GEP->isInBounds())
851 break;
852 if (GEP->hasAllConstantIndices() && GEP->getNumIndices() == 1 &&
853 GEP->getType() == V->getType()) {
854 V = GEP->getOperand(0);
855 Constant *GEPIndex = static_cast<Constant *>(GEP->getOperand(1));
856 Index = ConstantExpr::getAdd(
857 Index, ConstantExpr::getSExtOrBitCast(GEPIndex, IndexType));
858 continue;
859 }
860 break;
861 }
862 if (auto *CI = dyn_cast<IntToPtrInst>(V)) {
863 if (!CI->isNoopCast(DL))
864 break;
865 V = CI->getOperand(0);
866 continue;
867 }
868 if (auto *CI = dyn_cast<PtrToIntInst>(V)) {
869 if (!CI->isNoopCast(DL))
870 break;
871 V = CI->getOperand(0);
872 continue;
873 }
874 break;
875 }
876 return {V, Index};
877}
878
Sanjay Patel5f0217f2016-06-05 16:46:18 +0000879/// Converts (CMP GEPLHS, RHS) if this change would make RHS a constant.
880/// We can look through PHIs, GEPs and casts in order to determine a common base
881/// between GEPLHS and RHS.
Silviu Barangaf29dfd32016-01-15 15:52:05 +0000882static Instruction *transformToIndexedCompare(GEPOperator *GEPLHS, Value *RHS,
883 ICmpInst::Predicate Cond,
884 const DataLayout &DL) {
885 if (!GEPLHS->hasAllConstantIndices())
886 return nullptr;
887
Silviu Barangac6d21eb2017-01-31 14:04:15 +0000888 // Make sure the pointers have the same type.
889 if (GEPLHS->getType() != RHS->getType())
890 return nullptr;
891
Silviu Barangaf29dfd32016-01-15 15:52:05 +0000892 Value *PtrBase, *Index;
893 std::tie(PtrBase, Index) = getAsConstantIndexedAddress(GEPLHS, DL);
894
895 // The set of nodes that will take part in this transformation.
896 SetVector<Value *> Nodes;
897
898 if (!canRewriteGEPAsOffset(RHS, PtrBase, DL, Nodes))
899 return nullptr;
900
901 // We know we can re-write this as
902 // ((gep Ptr, OFFSET1) cmp (gep Ptr, OFFSET2)
903 // Since we've only looked through inbouds GEPs we know that we
904 // can't have overflow on either side. We can therefore re-write
905 // this as:
906 // OFFSET1 cmp OFFSET2
907 Value *NewRHS = rewriteGEPAsOffset(RHS, PtrBase, DL, Nodes);
908
909 // RewriteGEPAsOffset has replaced RHS and all of its uses with a re-written
910 // GEP having PtrBase as the pointer base, and has returned in NewRHS the
911 // offset. Since Index is the offset of LHS to the base pointer, we will now
912 // compare the offsets instead of comparing the pointers.
913 return new ICmpInst(ICmpInst::getSignedPredicate(Cond), Index, NewRHS);
914}
915
Sanjay Patel5f0217f2016-06-05 16:46:18 +0000916/// Fold comparisons between a GEP instruction and something else. At this point
917/// we know that the GEP is on the LHS of the comparison.
Sanjay Patel43395062016-07-21 18:07:40 +0000918Instruction *InstCombiner::foldGEPICmp(GEPOperator *GEPLHS, Value *RHS,
Chris Lattner2188e402010-01-04 07:37:31 +0000919 ICmpInst::Predicate Cond,
920 Instruction &I) {
Benjamin Kramer6ee86902012-02-21 13:31:09 +0000921 // Don't transform signed compares of GEPs into index compares. Even if the
922 // GEP is inbounds, the final add of the base pointer can have signed overflow
923 // and would change the result of the icmp.
924 // e.g. "&foo[0] <s &foo[1]" can't be folded to "true" because "foo" could be
Benjamin Kramerc7a22fe2012-02-21 13:40:06 +0000925 // the maximum signed value for the pointer type.
Benjamin Kramer6ee86902012-02-21 13:31:09 +0000926 if (ICmpInst::isSigned(Cond))
Craig Topperf40110f2014-04-25 05:29:35 +0000927 return nullptr;
Benjamin Kramer6ee86902012-02-21 13:31:09 +0000928
Matt Arsenault44f60d02014-06-09 19:20:29 +0000929 // Look through bitcasts and addrspacecasts. We do not however want to remove
930 // 0 GEPs.
931 if (!isa<GetElementPtrInst>(RHS))
932 RHS = RHS->stripPointerCasts();
Chris Lattner2188e402010-01-04 07:37:31 +0000933
934 Value *PtrBase = GEPLHS->getOperand(0);
Mehdi Aminia28d91d2015-03-10 02:37:25 +0000935 if (PtrBase == RHS && GEPLHS->isInBounds()) {
Chris Lattner2188e402010-01-04 07:37:31 +0000936 // ((gep Ptr, OFFSET) cmp Ptr) ---> (OFFSET cmp 0).
937 // This transformation (ignoring the base and scales) is valid because we
938 // know pointers can't overflow since the gep is inbounds. See if we can
939 // output an optimized form.
Sanjay Pateld93c4c02016-09-15 18:22:25 +0000940 Value *Offset = evaluateGEPOffsetExpression(GEPLHS, *this, DL);
Jim Grosbach129c52a2011-09-30 18:09:53 +0000941
Chris Lattner2188e402010-01-04 07:37:31 +0000942 // If not, synthesize the offset the hard way.
Craig Topperf40110f2014-04-25 05:29:35 +0000943 if (!Offset)
Chris Lattner2188e402010-01-04 07:37:31 +0000944 Offset = EmitGEPOffset(GEPLHS);
945 return new ICmpInst(ICmpInst::getSignedPredicate(Cond), Offset,
946 Constant::getNullValue(Offset->getType()));
947 } else if (GEPOperator *GEPRHS = dyn_cast<GEPOperator>(RHS)) {
948 // If the base pointers are different, but the indices are the same, just
949 // compare the base pointer.
950 if (PtrBase != GEPRHS->getOperand(0)) {
951 bool IndicesTheSame = GEPLHS->getNumOperands()==GEPRHS->getNumOperands();
952 IndicesTheSame &= GEPLHS->getOperand(0)->getType() ==
953 GEPRHS->getOperand(0)->getType();
954 if (IndicesTheSame)
955 for (unsigned i = 1, e = GEPLHS->getNumOperands(); i != e; ++i)
956 if (GEPLHS->getOperand(i) != GEPRHS->getOperand(i)) {
957 IndicesTheSame = false;
958 break;
959 }
960
961 // If all indices are the same, just compare the base pointers.
962 if (IndicesTheSame)
David Majnemer5953d372013-06-29 10:28:04 +0000963 return new ICmpInst(Cond, GEPLHS->getOperand(0), GEPRHS->getOperand(0));
Chris Lattner2188e402010-01-04 07:37:31 +0000964
Benjamin Kramer7adb1892012-02-20 15:07:47 +0000965 // If we're comparing GEPs with two base pointers that only differ in type
966 // and both GEPs have only constant indices or just one use, then fold
967 // the compare with the adjusted indices.
Mehdi Aminia28d91d2015-03-10 02:37:25 +0000968 if (GEPLHS->isInBounds() && GEPRHS->isInBounds() &&
Benjamin Kramer7adb1892012-02-20 15:07:47 +0000969 (GEPLHS->hasAllConstantIndices() || GEPLHS->hasOneUse()) &&
970 (GEPRHS->hasAllConstantIndices() || GEPRHS->hasOneUse()) &&
971 PtrBase->stripPointerCasts() ==
Mehdi Aminia28d91d2015-03-10 02:37:25 +0000972 GEPRHS->getOperand(0)->stripPointerCasts()) {
Matt Arsenault44f60d02014-06-09 19:20:29 +0000973 Value *LOffset = EmitGEPOffset(GEPLHS);
974 Value *ROffset = EmitGEPOffset(GEPRHS);
975
976 // If we looked through an addrspacecast between different sized address
977 // spaces, the LHS and RHS pointers are different sized
978 // integers. Truncate to the smaller one.
979 Type *LHSIndexTy = LOffset->getType();
980 Type *RHSIndexTy = ROffset->getType();
981 if (LHSIndexTy != RHSIndexTy) {
982 if (LHSIndexTy->getPrimitiveSizeInBits() <
983 RHSIndexTy->getPrimitiveSizeInBits()) {
984 ROffset = Builder->CreateTrunc(ROffset, LHSIndexTy);
985 } else
986 LOffset = Builder->CreateTrunc(LOffset, RHSIndexTy);
987 }
988
Benjamin Kramer7adb1892012-02-20 15:07:47 +0000989 Value *Cmp = Builder->CreateICmp(ICmpInst::getSignedPredicate(Cond),
Matt Arsenault44f60d02014-06-09 19:20:29 +0000990 LOffset, ROffset);
Sanjay Patel4b198802016-02-01 22:23:39 +0000991 return replaceInstUsesWith(I, Cmp);
Benjamin Kramer7adb1892012-02-20 15:07:47 +0000992 }
993
Chris Lattner2188e402010-01-04 07:37:31 +0000994 // Otherwise, the base pointers are different and the indices are
Silviu Barangaf29dfd32016-01-15 15:52:05 +0000995 // different. Try convert this to an indexed compare by looking through
996 // PHIs/casts.
997 return transformToIndexedCompare(GEPLHS, RHS, Cond, DL);
Chris Lattner2188e402010-01-04 07:37:31 +0000998 }
999
1000 // If one of the GEPs has all zero indices, recurse.
Benjamin Kramerd0993e02014-07-07 11:01:16 +00001001 if (GEPLHS->hasAllZeroIndices())
Sanjay Patel43395062016-07-21 18:07:40 +00001002 return foldGEPICmp(GEPRHS, GEPLHS->getOperand(0),
David Majnemer92a8a7d2013-06-29 09:45:35 +00001003 ICmpInst::getSwappedPredicate(Cond), I);
Chris Lattner2188e402010-01-04 07:37:31 +00001004
1005 // If the other GEP has all zero indices, recurse.
Benjamin Kramerd0993e02014-07-07 11:01:16 +00001006 if (GEPRHS->hasAllZeroIndices())
Sanjay Patel43395062016-07-21 18:07:40 +00001007 return foldGEPICmp(GEPLHS, GEPRHS->getOperand(0), Cond, I);
Chris Lattner2188e402010-01-04 07:37:31 +00001008
Stuart Hastings66a82b92011-05-14 05:55:10 +00001009 bool GEPsInBounds = GEPLHS->isInBounds() && GEPRHS->isInBounds();
Chris Lattner2188e402010-01-04 07:37:31 +00001010 if (GEPLHS->getNumOperands() == GEPRHS->getNumOperands()) {
1011 // If the GEPs only differ by one index, compare it.
1012 unsigned NumDifferences = 0; // Keep track of # differences.
1013 unsigned DiffOperand = 0; // The operand that differs.
1014 for (unsigned i = 1, e = GEPRHS->getNumOperands(); i != e; ++i)
1015 if (GEPLHS->getOperand(i) != GEPRHS->getOperand(i)) {
1016 if (GEPLHS->getOperand(i)->getType()->getPrimitiveSizeInBits() !=
1017 GEPRHS->getOperand(i)->getType()->getPrimitiveSizeInBits()) {
1018 // Irreconcilable differences.
1019 NumDifferences = 2;
1020 break;
1021 } else {
1022 if (NumDifferences++) break;
1023 DiffOperand = i;
1024 }
1025 }
1026
Rafael Espindolaa7bbc0b2013-06-06 17:03:05 +00001027 if (NumDifferences == 0) // SAME GEP?
Sanjay Patel4b198802016-02-01 22:23:39 +00001028 return replaceInstUsesWith(I, // No comparison is needed here.
Jakub Staszakbddea112013-06-06 20:18:46 +00001029 Builder->getInt1(ICmpInst::isTrueWhenEqual(Cond)));
Chris Lattner2188e402010-01-04 07:37:31 +00001030
Stuart Hastings66a82b92011-05-14 05:55:10 +00001031 else if (NumDifferences == 1 && GEPsInBounds) {
Chris Lattner2188e402010-01-04 07:37:31 +00001032 Value *LHSV = GEPLHS->getOperand(DiffOperand);
1033 Value *RHSV = GEPRHS->getOperand(DiffOperand);
1034 // Make sure we do a signed comparison here.
1035 return new ICmpInst(ICmpInst::getSignedPredicate(Cond), LHSV, RHSV);
1036 }
1037 }
1038
1039 // Only lower this if the icmp is the only user of the GEP or if we expect
1040 // the result to fold to a constant!
Mehdi Aminia28d91d2015-03-10 02:37:25 +00001041 if (GEPsInBounds && (isa<ConstantExpr>(GEPLHS) || GEPLHS->hasOneUse()) &&
Chris Lattner2188e402010-01-04 07:37:31 +00001042 (isa<ConstantExpr>(GEPRHS) || GEPRHS->hasOneUse())) {
1043 // ((gep Ptr, OFFSET1) cmp (gep Ptr, OFFSET2) ---> (OFFSET1 cmp OFFSET2)
1044 Value *L = EmitGEPOffset(GEPLHS);
1045 Value *R = EmitGEPOffset(GEPRHS);
1046 return new ICmpInst(ICmpInst::getSignedPredicate(Cond), L, R);
1047 }
1048 }
Silviu Barangaf29dfd32016-01-15 15:52:05 +00001049
1050 // Try convert this to an indexed compare by looking through PHIs/casts as a
1051 // last resort.
1052 return transformToIndexedCompare(GEPLHS, RHS, Cond, DL);
Chris Lattner2188e402010-01-04 07:37:31 +00001053}
1054
Pete Cooper980a9352016-08-12 17:13:28 +00001055Instruction *InstCombiner::foldAllocaCmp(ICmpInst &ICI,
1056 const AllocaInst *Alloca,
1057 const Value *Other) {
Hans Wennborgf1f36512015-10-07 00:20:07 +00001058 assert(ICI.isEquality() && "Cannot fold non-equality comparison.");
1059
1060 // It would be tempting to fold away comparisons between allocas and any
1061 // pointer not based on that alloca (e.g. an argument). However, even
1062 // though such pointers cannot alias, they can still compare equal.
1063 //
1064 // But LLVM doesn't specify where allocas get their memory, so if the alloca
1065 // doesn't escape we can argue that it's impossible to guess its value, and we
1066 // can therefore act as if any such guesses are wrong.
1067 //
1068 // The code below checks that the alloca doesn't escape, and that it's only
1069 // used in a comparison once (the current instruction). The
1070 // single-comparison-use condition ensures that we're trivially folding all
1071 // comparisons against the alloca consistently, and avoids the risk of
1072 // erroneously folding a comparison of the pointer with itself.
1073
1074 unsigned MaxIter = 32; // Break cycles and bound to constant-time.
1075
Pete Cooper980a9352016-08-12 17:13:28 +00001076 SmallVector<const Use *, 32> Worklist;
1077 for (const Use &U : Alloca->uses()) {
Hans Wennborgf1f36512015-10-07 00:20:07 +00001078 if (Worklist.size() >= MaxIter)
1079 return nullptr;
1080 Worklist.push_back(&U);
1081 }
1082
1083 unsigned NumCmps = 0;
1084 while (!Worklist.empty()) {
1085 assert(Worklist.size() <= MaxIter);
Pete Cooper980a9352016-08-12 17:13:28 +00001086 const Use *U = Worklist.pop_back_val();
1087 const Value *V = U->getUser();
Hans Wennborgf1f36512015-10-07 00:20:07 +00001088 --MaxIter;
1089
1090 if (isa<BitCastInst>(V) || isa<GetElementPtrInst>(V) || isa<PHINode>(V) ||
1091 isa<SelectInst>(V)) {
1092 // Track the uses.
1093 } else if (isa<LoadInst>(V)) {
1094 // Loading from the pointer doesn't escape it.
1095 continue;
Pete Cooper980a9352016-08-12 17:13:28 +00001096 } else if (const auto *SI = dyn_cast<StoreInst>(V)) {
Hans Wennborgf1f36512015-10-07 00:20:07 +00001097 // Storing *to* the pointer is fine, but storing the pointer escapes it.
1098 if (SI->getValueOperand() == U->get())
1099 return nullptr;
1100 continue;
1101 } else if (isa<ICmpInst>(V)) {
1102 if (NumCmps++)
1103 return nullptr; // Found more than one cmp.
1104 continue;
Pete Cooper980a9352016-08-12 17:13:28 +00001105 } else if (const auto *Intrin = dyn_cast<IntrinsicInst>(V)) {
Hans Wennborgf1f36512015-10-07 00:20:07 +00001106 switch (Intrin->getIntrinsicID()) {
1107 // These intrinsics don't escape or compare the pointer. Memset is safe
1108 // because we don't allow ptrtoint. Memcpy and memmove are safe because
1109 // we don't allow stores, so src cannot point to V.
1110 case Intrinsic::lifetime_start: case Intrinsic::lifetime_end:
1111 case Intrinsic::dbg_declare: case Intrinsic::dbg_value:
1112 case Intrinsic::memcpy: case Intrinsic::memmove: case Intrinsic::memset:
1113 continue;
1114 default:
1115 return nullptr;
1116 }
1117 } else {
1118 return nullptr;
1119 }
Pete Cooper980a9352016-08-12 17:13:28 +00001120 for (const Use &U : V->uses()) {
Hans Wennborgf1f36512015-10-07 00:20:07 +00001121 if (Worklist.size() >= MaxIter)
1122 return nullptr;
1123 Worklist.push_back(&U);
1124 }
1125 }
1126
1127 Type *CmpTy = CmpInst::makeCmpResultType(Other->getType());
Sanjay Patel4b198802016-02-01 22:23:39 +00001128 return replaceInstUsesWith(
Hans Wennborgf1f36512015-10-07 00:20:07 +00001129 ICI,
1130 ConstantInt::get(CmpTy, !CmpInst::isTrueWhenEqual(ICI.getPredicate())));
1131}
1132
Sanjay Patel5f0217f2016-06-05 16:46:18 +00001133/// Fold "icmp pred (X+CI), X".
Sanjay Patel43395062016-07-21 18:07:40 +00001134Instruction *InstCombiner::foldICmpAddOpConst(Instruction &ICI,
1135 Value *X, ConstantInt *CI,
1136 ICmpInst::Predicate Pred) {
Chris Lattner2188e402010-01-04 07:37:31 +00001137 // From this point on, we know that (X+C <= X) --> (X+C < X) because C != 0,
Chris Lattner0ab5e2c2011-04-15 05:18:47 +00001138 // so the values can never be equal. Similarly for all other "or equals"
Chris Lattner2188e402010-01-04 07:37:31 +00001139 // operators.
Jim Grosbach129c52a2011-09-30 18:09:53 +00001140
Chris Lattner8c92b572010-01-08 17:48:19 +00001141 // (X+1) <u X --> X >u (MAXUINT-1) --> X == 255
Chris Lattner2188e402010-01-04 07:37:31 +00001142 // (X+2) <u X --> X >u (MAXUINT-2) --> X > 253
1143 // (X+MAXUINT) <u X --> X >u (MAXUINT-MAXUINT) --> X != 0
1144 if (Pred == ICmpInst::ICMP_ULT || Pred == ICmpInst::ICMP_ULE) {
Jim Grosbach129c52a2011-09-30 18:09:53 +00001145 Value *R =
Chris Lattner8c92b572010-01-08 17:48:19 +00001146 ConstantExpr::getSub(ConstantInt::getAllOnesValue(CI->getType()), CI);
Chris Lattner2188e402010-01-04 07:37:31 +00001147 return new ICmpInst(ICmpInst::ICMP_UGT, X, R);
1148 }
Jim Grosbach129c52a2011-09-30 18:09:53 +00001149
Chris Lattner2188e402010-01-04 07:37:31 +00001150 // (X+1) >u X --> X <u (0-1) --> X != 255
1151 // (X+2) >u X --> X <u (0-2) --> X <u 254
1152 // (X+MAXUINT) >u X --> X <u (0-MAXUINT) --> X <u 1 --> X == 0
Duncan Sandse5220012011-02-17 07:46:37 +00001153 if (Pred == ICmpInst::ICMP_UGT || Pred == ICmpInst::ICMP_UGE)
Chris Lattner2188e402010-01-04 07:37:31 +00001154 return new ICmpInst(ICmpInst::ICMP_ULT, X, ConstantExpr::getNeg(CI));
Jim Grosbach129c52a2011-09-30 18:09:53 +00001155
Chris Lattner2188e402010-01-04 07:37:31 +00001156 unsigned BitWidth = CI->getType()->getPrimitiveSizeInBits();
1157 ConstantInt *SMax = ConstantInt::get(X->getContext(),
1158 APInt::getSignedMaxValue(BitWidth));
1159
1160 // (X+ 1) <s X --> X >s (MAXSINT-1) --> X == 127
1161 // (X+ 2) <s X --> X >s (MAXSINT-2) --> X >s 125
1162 // (X+MAXSINT) <s X --> X >s (MAXSINT-MAXSINT) --> X >s 0
1163 // (X+MINSINT) <s X --> X >s (MAXSINT-MINSINT) --> X >s -1
1164 // (X+ -2) <s X --> X >s (MAXSINT- -2) --> X >s 126
1165 // (X+ -1) <s X --> X >s (MAXSINT- -1) --> X != 127
Duncan Sandse5220012011-02-17 07:46:37 +00001166 if (Pred == ICmpInst::ICMP_SLT || Pred == ICmpInst::ICMP_SLE)
Chris Lattner2188e402010-01-04 07:37:31 +00001167 return new ICmpInst(ICmpInst::ICMP_SGT, X, ConstantExpr::getSub(SMax, CI));
Jim Grosbach129c52a2011-09-30 18:09:53 +00001168
Chris Lattner2188e402010-01-04 07:37:31 +00001169 // (X+ 1) >s X --> X <s (MAXSINT-(1-1)) --> X != 127
1170 // (X+ 2) >s X --> X <s (MAXSINT-(2-1)) --> X <s 126
1171 // (X+MAXSINT) >s X --> X <s (MAXSINT-(MAXSINT-1)) --> X <s 1
1172 // (X+MINSINT) >s X --> X <s (MAXSINT-(MINSINT-1)) --> X <s -2
1173 // (X+ -2) >s X --> X <s (MAXSINT-(-2-1)) --> X <s -126
1174 // (X+ -1) >s X --> X <s (MAXSINT-(-1-1)) --> X == -128
Jim Grosbach129c52a2011-09-30 18:09:53 +00001175
Chris Lattner2188e402010-01-04 07:37:31 +00001176 assert(Pred == ICmpInst::ICMP_SGT || Pred == ICmpInst::ICMP_SGE);
Jakub Staszakbddea112013-06-06 20:18:46 +00001177 Constant *C = Builder->getInt(CI->getValue()-1);
Chris Lattner2188e402010-01-04 07:37:31 +00001178 return new ICmpInst(ICmpInst::ICMP_SLT, X, ConstantExpr::getSub(SMax, C));
1179}
1180
Sanjay Patel8da42cc2016-09-15 22:26:31 +00001181/// Handle "(icmp eq/ne (ashr/lshr AP2, A), AP1)" ->
1182/// (icmp eq/ne A, Log2(AP2/AP1)) ->
1183/// (icmp eq/ne A, Log2(AP2) - Log2(AP1)).
1184Instruction *InstCombiner::foldICmpShrConstConst(ICmpInst &I, Value *A,
1185 const APInt &AP1,
1186 const APInt &AP2) {
Suyog Sarda3a8c2c12014-07-22 19:19:36 +00001187 assert(I.isEquality() && "Cannot fold icmp gt/lt");
1188
Suyog Sarda3a8c2c12014-07-22 19:19:36 +00001189 auto getICmp = [&I](CmpInst::Predicate Pred, Value *LHS, Value *RHS) {
1190 if (I.getPredicate() == I.ICMP_NE)
1191 Pred = CmpInst::getInversePredicate(Pred);
1192 return new ICmpInst(Pred, LHS, RHS);
1193 };
1194
David Majnemer2abb8182014-10-25 07:13:13 +00001195 // Don't bother doing any work for cases which InstSimplify handles.
1196 if (AP2 == 0)
1197 return nullptr;
Sanjay Patel8da42cc2016-09-15 22:26:31 +00001198
1199 bool IsAShr = isa<AShrOperator>(I.getOperand(0));
David Majnemer2abb8182014-10-25 07:13:13 +00001200 if (IsAShr) {
1201 if (AP2.isAllOnesValue())
1202 return nullptr;
1203 if (AP2.isNegative() != AP1.isNegative())
1204 return nullptr;
1205 if (AP2.sgt(AP1))
1206 return nullptr;
1207 }
Suyog Sarda3a8c2c12014-07-22 19:19:36 +00001208
David Majnemerd2056022014-10-21 19:51:55 +00001209 if (!AP1)
Suyog Sarda3a8c2c12014-07-22 19:19:36 +00001210 // 'A' must be large enough to shift out the highest set bit.
1211 return getICmp(I.ICMP_UGT, A,
1212 ConstantInt::get(A->getType(), AP2.logBase2()));
Suyog Sarda3a8c2c12014-07-22 19:19:36 +00001213
David Majnemerd2056022014-10-21 19:51:55 +00001214 if (AP1 == AP2)
1215 return getICmp(I.ICMP_EQ, A, ConstantInt::getNullValue(A->getType()));
Suyog Sarda3a8c2c12014-07-22 19:19:36 +00001216
Andrea Di Biagio5b92b492014-09-17 11:32:31 +00001217 int Shift;
David Majnemerd2056022014-10-21 19:51:55 +00001218 if (IsAShr && AP1.isNegative())
David Majnemere5977eb2015-09-19 00:48:26 +00001219 Shift = AP1.countLeadingOnes() - AP2.countLeadingOnes();
Andrea Di Biagio5b92b492014-09-17 11:32:31 +00001220 else
David Majnemere5977eb2015-09-19 00:48:26 +00001221 Shift = AP1.countLeadingZeros() - AP2.countLeadingZeros();
Suyog Sarda3a8c2c12014-07-22 19:19:36 +00001222
David Majnemerd2056022014-10-21 19:51:55 +00001223 if (Shift > 0) {
David Majnemere5977eb2015-09-19 00:48:26 +00001224 if (IsAShr && AP1 == AP2.ashr(Shift)) {
1225 // There are multiple solutions if we are comparing against -1 and the LHS
David Majnemer47ce0b82015-09-19 00:48:31 +00001226 // of the ashr is not a power of two.
David Majnemere5977eb2015-09-19 00:48:26 +00001227 if (AP1.isAllOnesValue() && !AP2.isPowerOf2())
1228 return getICmp(I.ICMP_UGE, A, ConstantInt::get(A->getType(), Shift));
David Majnemerd2056022014-10-21 19:51:55 +00001229 return getICmp(I.ICMP_EQ, A, ConstantInt::get(A->getType(), Shift));
David Majnemere5977eb2015-09-19 00:48:26 +00001230 } else if (AP1 == AP2.lshr(Shift)) {
1231 return getICmp(I.ICMP_EQ, A, ConstantInt::get(A->getType(), Shift));
1232 }
David Majnemerd2056022014-10-21 19:51:55 +00001233 }
Sanjay Patel524fcdf2016-09-15 19:04:55 +00001234
Suyog Sarda3a8c2c12014-07-22 19:19:36 +00001235 // Shifting const2 will never be equal to const1.
Sanjay Patel524fcdf2016-09-15 19:04:55 +00001236 // FIXME: This should always be handled by InstSimplify?
1237 auto *TorF = ConstantInt::get(I.getType(), I.getPredicate() == I.ICMP_NE);
1238 return replaceInstUsesWith(I, TorF);
Suyog Sarda3a8c2c12014-07-22 19:19:36 +00001239}
Chris Lattner2188e402010-01-04 07:37:31 +00001240
Sanjay Patel8da42cc2016-09-15 22:26:31 +00001241/// Handle "(icmp eq/ne (shl AP2, A), AP1)" ->
1242/// (icmp eq/ne A, TrailingZeros(AP1) - TrailingZeros(AP2)).
1243Instruction *InstCombiner::foldICmpShlConstConst(ICmpInst &I, Value *A,
1244 const APInt &AP1,
1245 const APInt &AP2) {
David Majnemer59939ac2014-10-19 08:23:08 +00001246 assert(I.isEquality() && "Cannot fold icmp gt/lt");
1247
David Majnemer59939ac2014-10-19 08:23:08 +00001248 auto getICmp = [&I](CmpInst::Predicate Pred, Value *LHS, Value *RHS) {
1249 if (I.getPredicate() == I.ICMP_NE)
1250 Pred = CmpInst::getInversePredicate(Pred);
1251 return new ICmpInst(Pred, LHS, RHS);
1252 };
1253
David Majnemer2abb8182014-10-25 07:13:13 +00001254 // Don't bother doing any work for cases which InstSimplify handles.
1255 if (AP2 == 0)
1256 return nullptr;
David Majnemer59939ac2014-10-19 08:23:08 +00001257
1258 unsigned AP2TrailingZeros = AP2.countTrailingZeros();
1259
1260 if (!AP1 && AP2TrailingZeros != 0)
Sanjay Patelaf91d1f2016-09-15 21:35:30 +00001261 return getICmp(
1262 I.ICMP_UGE, A,
1263 ConstantInt::get(A->getType(), AP2.getBitWidth() - AP2TrailingZeros));
David Majnemer59939ac2014-10-19 08:23:08 +00001264
1265 if (AP1 == AP2)
1266 return getICmp(I.ICMP_EQ, A, ConstantInt::getNullValue(A->getType()));
1267
1268 // Get the distance between the lowest bits that are set.
1269 int Shift = AP1.countTrailingZeros() - AP2TrailingZeros;
1270
1271 if (Shift > 0 && AP2.shl(Shift) == AP1)
1272 return getICmp(I.ICMP_EQ, A, ConstantInt::get(A->getType(), Shift));
1273
1274 // Shifting const2 will never be equal to const1.
Sanjay Patel524fcdf2016-09-15 19:04:55 +00001275 // FIXME: This should always be handled by InstSimplify?
1276 auto *TorF = ConstantInt::get(I.getType(), I.getPredicate() == I.ICMP_NE);
1277 return replaceInstUsesWith(I, TorF);
David Majnemer59939ac2014-10-19 08:23:08 +00001278}
1279
Sanjay Patel06b127a2016-09-15 14:37:50 +00001280/// The caller has matched a pattern of the form:
1281/// I = icmp ugt (add (add A, B), CI2), CI1
1282/// If this is of the form:
1283/// sum = a + b
1284/// if (sum+128 >u 255)
1285/// Then replace it with llvm.sadd.with.overflow.i8.
1286///
Sanjay Pateld93c4c02016-09-15 18:22:25 +00001287static Instruction *processUGT_ADDCST_ADD(ICmpInst &I, Value *A, Value *B,
Sanjay Patel06b127a2016-09-15 14:37:50 +00001288 ConstantInt *CI2, ConstantInt *CI1,
1289 InstCombiner &IC) {
1290 // The transformation we're trying to do here is to transform this into an
1291 // llvm.sadd.with.overflow. To do this, we have to replace the original add
1292 // with a narrower add, and discard the add-with-constant that is part of the
1293 // range check (if we can't eliminate it, this isn't profitable).
1294
1295 // In order to eliminate the add-with-constant, the compare can be its only
1296 // use.
1297 Instruction *AddWithCst = cast<Instruction>(I.getOperand(0));
1298 if (!AddWithCst->hasOneUse())
1299 return nullptr;
1300
1301 // If CI2 is 2^7, 2^15, 2^31, then it might be an sadd.with.overflow.
1302 if (!CI2->getValue().isPowerOf2())
1303 return nullptr;
1304 unsigned NewWidth = CI2->getValue().countTrailingZeros();
1305 if (NewWidth != 7 && NewWidth != 15 && NewWidth != 31)
1306 return nullptr;
1307
1308 // The width of the new add formed is 1 more than the bias.
1309 ++NewWidth;
1310
1311 // Check to see that CI1 is an all-ones value with NewWidth bits.
1312 if (CI1->getBitWidth() == NewWidth ||
1313 CI1->getValue() != APInt::getLowBitsSet(CI1->getBitWidth(), NewWidth))
1314 return nullptr;
1315
1316 // This is only really a signed overflow check if the inputs have been
1317 // sign-extended; check for that condition. For example, if CI2 is 2^31 and
1318 // the operands of the add are 64 bits wide, we need at least 33 sign bits.
1319 unsigned NeededSignBits = CI1->getBitWidth() - NewWidth + 1;
1320 if (IC.ComputeNumSignBits(A, 0, &I) < NeededSignBits ||
1321 IC.ComputeNumSignBits(B, 0, &I) < NeededSignBits)
1322 return nullptr;
1323
1324 // In order to replace the original add with a narrower
1325 // llvm.sadd.with.overflow, the only uses allowed are the add-with-constant
1326 // and truncates that discard the high bits of the add. Verify that this is
1327 // the case.
1328 Instruction *OrigAdd = cast<Instruction>(AddWithCst->getOperand(0));
1329 for (User *U : OrigAdd->users()) {
1330 if (U == AddWithCst)
1331 continue;
1332
1333 // Only accept truncates for now. We would really like a nice recursive
1334 // predicate like SimplifyDemandedBits, but which goes downwards the use-def
1335 // chain to see which bits of a value are actually demanded. If the
1336 // original add had another add which was then immediately truncated, we
1337 // could still do the transformation.
1338 TruncInst *TI = dyn_cast<TruncInst>(U);
1339 if (!TI || TI->getType()->getPrimitiveSizeInBits() > NewWidth)
1340 return nullptr;
1341 }
1342
1343 // If the pattern matches, truncate the inputs to the narrower type and
1344 // use the sadd_with_overflow intrinsic to efficiently compute both the
1345 // result and the overflow bit.
1346 Type *NewType = IntegerType::get(OrigAdd->getContext(), NewWidth);
1347 Value *F = Intrinsic::getDeclaration(I.getModule(),
1348 Intrinsic::sadd_with_overflow, NewType);
1349
1350 InstCombiner::BuilderTy *Builder = IC.Builder;
1351
1352 // Put the new code above the original add, in case there are any uses of the
1353 // add between the add and the compare.
1354 Builder->SetInsertPoint(OrigAdd);
1355
1356 Value *TruncA = Builder->CreateTrunc(A, NewType, A->getName() + ".trunc");
1357 Value *TruncB = Builder->CreateTrunc(B, NewType, B->getName() + ".trunc");
1358 CallInst *Call = Builder->CreateCall(F, {TruncA, TruncB}, "sadd");
1359 Value *Add = Builder->CreateExtractValue(Call, 0, "sadd.result");
1360 Value *ZExt = Builder->CreateZExt(Add, OrigAdd->getType());
1361
1362 // The inner add was the result of the narrow add, zero extended to the
1363 // wider type. Replace it with the result computed by the intrinsic.
1364 IC.replaceInstUsesWith(*OrigAdd, ZExt);
1365
1366 // The original icmp gets replaced with the overflow value.
1367 return ExtractValueInst::Create(Call, 1, "sadd.overflow");
1368}
1369
1370// Fold icmp Pred X, C.
Sanjay Patel97459832016-09-15 15:11:12 +00001371Instruction *InstCombiner::foldICmpWithConstant(ICmpInst &Cmp) {
1372 CmpInst::Predicate Pred = Cmp.getPredicate();
Sanjay Patel40c53ea2016-09-15 16:23:20 +00001373 Value *X = Cmp.getOperand(0);
Sanjay Patel06b127a2016-09-15 14:37:50 +00001374
Sanjay Patel40c53ea2016-09-15 16:23:20 +00001375 const APInt *C;
1376 if (!match(Cmp.getOperand(1), m_APInt(C)))
Sanjay Patel97459832016-09-15 15:11:12 +00001377 return nullptr;
Sanjay Patel06b127a2016-09-15 14:37:50 +00001378
Sanjay Patel97459832016-09-15 15:11:12 +00001379 Value *A = nullptr, *B = nullptr;
Sanjay Patel06b127a2016-09-15 14:37:50 +00001380
Sanjay Patel97459832016-09-15 15:11:12 +00001381 // Match the following pattern, which is a common idiom when writing
1382 // overflow-safe integer arithmetic functions. The source performs an addition
1383 // in wider type and explicitly checks for overflow using comparisons against
1384 // INT_MIN and INT_MAX. Simplify by using the sadd_with_overflow intrinsic.
1385 //
1386 // TODO: This could probably be generalized to handle other overflow-safe
1387 // operations if we worked out the formulas to compute the appropriate magic
1388 // constants.
1389 //
1390 // sum = a + b
1391 // if (sum+128 >u 255) ... -> llvm.sadd.with.overflow.i8
1392 {
1393 ConstantInt *CI2; // I = icmp ugt (add (add A, B), CI2), CI
1394 if (Pred == ICmpInst::ICMP_UGT &&
1395 match(X, m_Add(m_Add(m_Value(A), m_Value(B)), m_ConstantInt(CI2))))
Sanjay Pateld93c4c02016-09-15 18:22:25 +00001396 if (Instruction *Res = processUGT_ADDCST_ADD(
Sanjay Patel40c53ea2016-09-15 16:23:20 +00001397 Cmp, A, B, CI2, cast<ConstantInt>(Cmp.getOperand(1)), *this))
Sanjay Patel97459832016-09-15 15:11:12 +00001398 return Res;
1399 }
Sanjay Patel06b127a2016-09-15 14:37:50 +00001400
Sanjay Patel97459832016-09-15 15:11:12 +00001401 // (icmp sgt smin(PosA, B) 0) -> (icmp sgt B 0)
Sanjay Patel40c53ea2016-09-15 16:23:20 +00001402 if (*C == 0 && Pred == ICmpInst::ICMP_SGT) {
1403 SelectPatternResult SPR = matchSelectPattern(X, A, B);
1404 if (SPR.Flavor == SPF_SMIN) {
1405 if (isKnownPositive(A, DL))
1406 return new ICmpInst(Pred, B, Cmp.getOperand(1));
1407 if (isKnownPositive(B, DL))
1408 return new ICmpInst(Pred, A, Cmp.getOperand(1));
Sanjay Patel06b127a2016-09-15 14:37:50 +00001409 }
Sanjay Patel40c53ea2016-09-15 16:23:20 +00001410 }
1411
1412 // FIXME: Use m_APInt to allow folds for splat constants.
1413 ConstantInt *CI = dyn_cast<ConstantInt>(Cmp.getOperand(1));
1414 if (!CI)
1415 return nullptr;
Sanjay Patel06b127a2016-09-15 14:37:50 +00001416
Sanjay Patel97459832016-09-15 15:11:12 +00001417 // Canonicalize icmp instructions based on dominating conditions.
1418 BasicBlock *Parent = Cmp.getParent();
1419 BasicBlock *Dom = Parent->getSinglePredecessor();
1420 auto *BI = Dom ? dyn_cast<BranchInst>(Dom->getTerminator()) : nullptr;
1421 ICmpInst::Predicate Pred2;
1422 BasicBlock *TrueBB, *FalseBB;
1423 ConstantInt *CI2;
1424 if (BI && match(BI, m_Br(m_ICmp(Pred2, m_Specific(X), m_ConstantInt(CI2)),
1425 TrueBB, FalseBB)) &&
1426 TrueBB != FalseBB) {
1427 ConstantRange CR =
1428 ConstantRange::makeAllowedICmpRegion(Pred, CI->getValue());
1429 ConstantRange DominatingCR =
1430 (Parent == TrueBB)
1431 ? ConstantRange::makeExactICmpRegion(Pred2, CI2->getValue())
1432 : ConstantRange::makeExactICmpRegion(
1433 CmpInst::getInversePredicate(Pred2), CI2->getValue());
1434 ConstantRange Intersection = DominatingCR.intersectWith(CR);
1435 ConstantRange Difference = DominatingCR.difference(CR);
1436 if (Intersection.isEmptySet())
1437 return replaceInstUsesWith(Cmp, Builder->getFalse());
1438 if (Difference.isEmptySet())
1439 return replaceInstUsesWith(Cmp, Builder->getTrue());
Sanjay Patel06b127a2016-09-15 14:37:50 +00001440
Sanjay Patel97459832016-09-15 15:11:12 +00001441 // If this is a normal comparison, it demands all bits. If it is a sign
1442 // bit comparison, it only demands the sign bit.
1443 bool UnusedBit;
1444 bool IsSignBit = isSignBitCheck(Pred, CI->getValue(), UnusedBit);
1445
1446 // Canonicalizing a sign bit comparison that gets used in a branch,
1447 // pessimizes codegen by generating branch on zero instruction instead
1448 // of a test and branch. So we avoid canonicalizing in such situations
1449 // because test and branch instruction has better branch displacement
1450 // than compare and branch instruction.
1451 if (!isBranchOnSignBitCheck(Cmp, IsSignBit) && !Cmp.isEquality()) {
1452 if (auto *AI = Intersection.getSingleElement())
1453 return new ICmpInst(ICmpInst::ICMP_EQ, X, Builder->getInt(*AI));
1454 if (auto *AD = Difference.getSingleElement())
1455 return new ICmpInst(ICmpInst::ICMP_NE, X, Builder->getInt(*AD));
Sanjay Patel06b127a2016-09-15 14:37:50 +00001456 }
1457 }
1458
1459 return nullptr;
1460}
1461
Sanjay Patel5f4ce4e2016-08-18 20:25:16 +00001462/// Fold icmp (trunc X, Y), C.
1463Instruction *InstCombiner::foldICmpTruncConstant(ICmpInst &Cmp,
1464 Instruction *Trunc,
1465 const APInt *C) {
Sanjay Patel5f4ce4e2016-08-18 20:25:16 +00001466 ICmpInst::Predicate Pred = Cmp.getPredicate();
1467 Value *X = Trunc->getOperand(0);
Sanjay Patel40e8ca42016-08-18 20:28:54 +00001468 if (*C == 1 && C->getBitWidth() > 1) {
Sanjay Patela3f4f082016-08-16 17:54:36 +00001469 // icmp slt trunc(signum(V)) 1 --> icmp slt V, 1
1470 Value *V = nullptr;
Sanjay Patel5f4ce4e2016-08-18 20:25:16 +00001471 if (Pred == ICmpInst::ICMP_SLT && match(X, m_Signum(m_Value(V))))
Sanjay Patela3f4f082016-08-16 17:54:36 +00001472 return new ICmpInst(ICmpInst::ICMP_SLT, V,
1473 ConstantInt::get(V->getType(), 1));
1474 }
Sanjay Patel5f4ce4e2016-08-18 20:25:16 +00001475
1476 if (Cmp.isEquality() && Trunc->hasOneUse()) {
Sanjay Patela3f4f082016-08-16 17:54:36 +00001477 // Simplify icmp eq (trunc x to i8), 42 -> icmp eq x, 42|highbits if all
1478 // of the high bits truncated out of x are known.
Sanjay Patel40e8ca42016-08-18 20:28:54 +00001479 unsigned DstBits = Trunc->getType()->getScalarSizeInBits(),
1480 SrcBits = X->getType()->getScalarSizeInBits();
Craig Topperb45eabc2017-04-26 16:39:58 +00001481 KnownBits Known(SrcBits);
1482 computeKnownBits(X, Known, 0, &Cmp);
Sanjay Patela3f4f082016-08-16 17:54:36 +00001483
1484 // If all the high bits are known, we can do this xform.
Craig Topperb45eabc2017-04-26 16:39:58 +00001485 if ((Known.Zero | Known.One).countLeadingOnes() >= SrcBits - DstBits) {
Sanjay Patela3f4f082016-08-16 17:54:36 +00001486 // Pull in the high bits from known-ones set.
Sanjay Patel5f4ce4e2016-08-18 20:25:16 +00001487 APInt NewRHS = C->zext(SrcBits);
Craig Topperb45eabc2017-04-26 16:39:58 +00001488 NewRHS |= Known.One & APInt::getHighBitsSet(SrcBits, SrcBits - DstBits);
Sanjay Patel40e8ca42016-08-18 20:28:54 +00001489 return new ICmpInst(Pred, X, ConstantInt::get(X->getType(), NewRHS));
Sanjay Patela3f4f082016-08-16 17:54:36 +00001490 }
1491 }
Sanjay Patel5f4ce4e2016-08-18 20:25:16 +00001492
Sanjay Patela3f4f082016-08-16 17:54:36 +00001493 return nullptr;
1494}
1495
Sanjay Patel6d5f4482016-08-17 19:23:42 +00001496/// Fold icmp (xor X, Y), C.
Sanjay Patelc9196c42016-08-22 21:24:29 +00001497Instruction *InstCombiner::foldICmpXorConstant(ICmpInst &Cmp,
1498 BinaryOperator *Xor,
Sanjay Patel6d5f4482016-08-17 19:23:42 +00001499 const APInt *C) {
Sanjay Patel4c5e60d2016-08-18 14:10:48 +00001500 Value *X = Xor->getOperand(0);
1501 Value *Y = Xor->getOperand(1);
Sanjay Pateldaffec912016-08-17 19:45:18 +00001502 const APInt *XorC;
Sanjay Patel4c5e60d2016-08-18 14:10:48 +00001503 if (!match(Y, m_APInt(XorC)))
Sanjay Patel6d5f4482016-08-17 19:23:42 +00001504 return nullptr;
Sanjay Patela3f4f082016-08-16 17:54:36 +00001505
Sanjay Patel6d5f4482016-08-17 19:23:42 +00001506 // If this is a comparison that tests the signbit (X < 0) or (x > -1),
1507 // fold the xor.
1508 ICmpInst::Predicate Pred = Cmp.getPredicate();
1509 if ((Pred == ICmpInst::ICMP_SLT && *C == 0) ||
1510 (Pred == ICmpInst::ICMP_SGT && C->isAllOnesValue())) {
Sanjay Patela3f4f082016-08-16 17:54:36 +00001511
Sanjay Patel6d5f4482016-08-17 19:23:42 +00001512 // If the sign bit of the XorCst is not set, there is no change to
1513 // the operation, just stop using the Xor.
Sanjay Pateldaffec912016-08-17 19:45:18 +00001514 if (!XorC->isNegative()) {
1515 Cmp.setOperand(0, X);
Sanjay Patel6d5f4482016-08-17 19:23:42 +00001516 Worklist.Add(Xor);
1517 return &Cmp;
Sanjay Patela3f4f082016-08-16 17:54:36 +00001518 }
1519
Sanjay Patel6d5f4482016-08-17 19:23:42 +00001520 // Was the old condition true if the operand is positive?
1521 bool isTrueIfPositive = Pred == ICmpInst::ICMP_SGT;
Sanjay Patela3f4f082016-08-16 17:54:36 +00001522
Sanjay Patel6d5f4482016-08-17 19:23:42 +00001523 // If so, the new one isn't.
1524 isTrueIfPositive ^= true;
Sanjay Patela3f4f082016-08-16 17:54:36 +00001525
Sanjay Patel4c5e60d2016-08-18 14:10:48 +00001526 Constant *CmpConstant = cast<Constant>(Cmp.getOperand(1));
Sanjay Patel6d5f4482016-08-17 19:23:42 +00001527 if (isTrueIfPositive)
Sanjay Patel4c5e60d2016-08-18 14:10:48 +00001528 return new ICmpInst(ICmpInst::ICMP_SGT, X, SubOne(CmpConstant));
Sanjay Patel6d5f4482016-08-17 19:23:42 +00001529 else
Sanjay Patel4c5e60d2016-08-18 14:10:48 +00001530 return new ICmpInst(ICmpInst::ICMP_SLT, X, AddOne(CmpConstant));
Sanjay Patela3f4f082016-08-16 17:54:36 +00001531 }
Sanjay Patel6d5f4482016-08-17 19:23:42 +00001532
1533 if (Xor->hasOneUse()) {
Craig Topperbcfd2d12017-04-20 16:56:25 +00001534 // (icmp u/s (xor X SignMask), C) -> (icmp s/u X, (xor C SignMask))
1535 if (!Cmp.isEquality() && XorC->isSignMask()) {
Sanjay Pateldaffec912016-08-17 19:45:18 +00001536 Pred = Cmp.isSigned() ? Cmp.getUnsignedPredicate()
1537 : Cmp.getSignedPredicate();
Sanjay Patel4c5e60d2016-08-18 14:10:48 +00001538 return new ICmpInst(Pred, X, ConstantInt::get(X->getType(), *C ^ *XorC));
Sanjay Patel6d5f4482016-08-17 19:23:42 +00001539 }
1540
Craig Topperbcfd2d12017-04-20 16:56:25 +00001541 // (icmp u/s (xor X ~SignMask), C) -> (icmp s/u X, (xor C ~SignMask))
Sanjay Pateldaffec912016-08-17 19:45:18 +00001542 if (!Cmp.isEquality() && XorC->isMaxSignedValue()) {
1543 Pred = Cmp.isSigned() ? Cmp.getUnsignedPredicate()
1544 : Cmp.getSignedPredicate();
Sanjay Patel6d5f4482016-08-17 19:23:42 +00001545 Pred = Cmp.getSwappedPredicate(Pred);
Sanjay Patel4c5e60d2016-08-18 14:10:48 +00001546 return new ICmpInst(Pred, X, ConstantInt::get(X->getType(), *C ^ *XorC));
Sanjay Patel6d5f4482016-08-17 19:23:42 +00001547 }
1548 }
1549
1550 // (icmp ugt (xor X, C), ~C) -> (icmp ult X, C)
1551 // iff -C is a power of 2
Sanjay Pateldaffec912016-08-17 19:45:18 +00001552 if (Pred == ICmpInst::ICMP_UGT && *XorC == ~(*C) && (*C + 1).isPowerOf2())
Sanjay Patel4c5e60d2016-08-18 14:10:48 +00001553 return new ICmpInst(ICmpInst::ICMP_ULT, X, Y);
Sanjay Patel6d5f4482016-08-17 19:23:42 +00001554
1555 // (icmp ult (xor X, C), -C) -> (icmp uge X, C)
1556 // iff -C is a power of 2
Sanjay Pateldaffec912016-08-17 19:45:18 +00001557 if (Pred == ICmpInst::ICMP_ULT && *XorC == -(*C) && C->isPowerOf2())
Sanjay Patel4c5e60d2016-08-18 14:10:48 +00001558 return new ICmpInst(ICmpInst::ICMP_UGE, X, Y);
Sanjay Patel6d5f4482016-08-17 19:23:42 +00001559
Sanjay Patela3f4f082016-08-16 17:54:36 +00001560 return nullptr;
1561}
1562
Sanjay Patel14e0e182016-08-26 18:28:46 +00001563/// Fold icmp (and (sh X, Y), C2), C1.
1564Instruction *InstCombiner::foldICmpAndShift(ICmpInst &Cmp, BinaryOperator *And,
Sanjay Patel9b40f982016-09-07 22:33:03 +00001565 const APInt *C1, const APInt *C2) {
1566 BinaryOperator *Shift = dyn_cast<BinaryOperator>(And->getOperand(0));
1567 if (!Shift || !Shift->isShift())
Sanjay Patelda9c5622016-08-26 17:15:22 +00001568 return nullptr;
Sanjay Patela3f4f082016-08-16 17:54:36 +00001569
Sanjay Patelda9c5622016-08-26 17:15:22 +00001570 // If this is: (X >> C3) & C2 != C1 (where any shift and any compare could
1571 // exist), turn it into (X & (C2 << C3)) != (C1 << C3). This happens a LOT in
1572 // code produced by the clang front-end, for bitfield access.
Sanjay Patelda9c5622016-08-26 17:15:22 +00001573 // This seemingly simple opportunity to fold away a shift turns out to be
1574 // rather complicated. See PR17827 for details.
Sanjay Patel9b40f982016-09-07 22:33:03 +00001575 unsigned ShiftOpcode = Shift->getOpcode();
1576 bool IsShl = ShiftOpcode == Instruction::Shl;
1577 const APInt *C3;
1578 if (match(Shift->getOperand(1), m_APInt(C3))) {
Sanjay Patelda9c5622016-08-26 17:15:22 +00001579 bool CanFold = false;
Sanjay Patelda9c5622016-08-26 17:15:22 +00001580 if (ShiftOpcode == Instruction::AShr) {
1581 // There may be some constraints that make this possible, but nothing
1582 // simple has been discovered yet.
1583 CanFold = false;
1584 } else if (ShiftOpcode == Instruction::Shl) {
1585 // For a left shift, we can fold if the comparison is not signed. We can
1586 // also fold a signed comparison if the mask value and comparison value
1587 // are not negative. These constraints may not be obvious, but we can
1588 // prove that they are correct using an SMT solver.
Sanjay Patel9b40f982016-09-07 22:33:03 +00001589 if (!Cmp.isSigned() || (!C2->isNegative() && !C1->isNegative()))
Sanjay Patelda9c5622016-08-26 17:15:22 +00001590 CanFold = true;
1591 } else if (ShiftOpcode == Instruction::LShr) {
1592 // For a logical right shift, we can fold if the comparison is not signed.
1593 // We can also fold a signed comparison if the shifted mask value and the
1594 // shifted comparison value are not negative. These constraints may not be
1595 // obvious, but we can prove that they are correct using an SMT solver.
Sanjay Patel9b40f982016-09-07 22:33:03 +00001596 if (!Cmp.isSigned() ||
1597 (!C2->shl(*C3).isNegative() && !C1->shl(*C3).isNegative()))
Sanjay Patelda9c5622016-08-26 17:15:22 +00001598 CanFold = true;
Sanjay Patela3f4f082016-08-16 17:54:36 +00001599 }
1600
Sanjay Patelda9c5622016-08-26 17:15:22 +00001601 if (CanFold) {
Sanjay Patel9b40f982016-09-07 22:33:03 +00001602 APInt NewCst = IsShl ? C1->lshr(*C3) : C1->shl(*C3);
1603 APInt SameAsC1 = IsShl ? NewCst.shl(*C3) : NewCst.lshr(*C3);
Sanjay Patelda9c5622016-08-26 17:15:22 +00001604 // Check to see if we are shifting out any of the bits being compared.
Sanjay Patel9b40f982016-09-07 22:33:03 +00001605 if (SameAsC1 != *C1) {
Sanjay Patelda9c5622016-08-26 17:15:22 +00001606 // If we shifted bits out, the fold is not going to work out. As a
1607 // special case, check to see if this means that the result is always
1608 // true or false now.
1609 if (Cmp.getPredicate() == ICmpInst::ICMP_EQ)
Sanjay Patel1c608f42016-09-08 16:54:02 +00001610 return replaceInstUsesWith(Cmp, ConstantInt::getFalse(Cmp.getType()));
Sanjay Patelda9c5622016-08-26 17:15:22 +00001611 if (Cmp.getPredicate() == ICmpInst::ICMP_NE)
Sanjay Patel1c608f42016-09-08 16:54:02 +00001612 return replaceInstUsesWith(Cmp, ConstantInt::getTrue(Cmp.getType()));
Sanjay Patela3f4f082016-08-16 17:54:36 +00001613 } else {
Sanjay Patel9b40f982016-09-07 22:33:03 +00001614 Cmp.setOperand(1, ConstantInt::get(And->getType(), NewCst));
1615 APInt NewAndCst = IsShl ? C2->lshr(*C3) : C2->shl(*C3);
1616 And->setOperand(1, ConstantInt::get(And->getType(), NewAndCst));
Sanjay Patelda9c5622016-08-26 17:15:22 +00001617 And->setOperand(0, Shift->getOperand(0));
1618 Worklist.Add(Shift); // Shift is dead.
1619 return &Cmp;
Sanjay Patela3f4f082016-08-16 17:54:36 +00001620 }
Sanjay Patelda9c5622016-08-26 17:15:22 +00001621 }
1622 }
Sanjay Patela3f4f082016-08-16 17:54:36 +00001623
Sanjay Patelda9c5622016-08-26 17:15:22 +00001624 // Turn ((X >> Y) & C2) == 0 into (X & (C2 << Y)) == 0. The latter is
1625 // preferable because it allows the C2 << Y expression to be hoisted out of a
1626 // loop if Y is invariant and X is not.
Sanjay Patel14e0e182016-08-26 18:28:46 +00001627 if (Shift->hasOneUse() && *C1 == 0 && Cmp.isEquality() &&
Sanjay Patelda9c5622016-08-26 17:15:22 +00001628 !Shift->isArithmeticShift() && !isa<Constant>(Shift->getOperand(0))) {
1629 // Compute C2 << Y.
Sanjay Patel9b40f982016-09-07 22:33:03 +00001630 Value *NewShift =
1631 IsShl ? Builder->CreateLShr(And->getOperand(1), Shift->getOperand(1))
1632 : Builder->CreateShl(And->getOperand(1), Shift->getOperand(1));
Sanjay Patela3f4f082016-08-16 17:54:36 +00001633
Sanjay Patelda9c5622016-08-26 17:15:22 +00001634 // Compute X & (C2 << Y).
Sanjay Patel9b40f982016-09-07 22:33:03 +00001635 Value *NewAnd = Builder->CreateAnd(Shift->getOperand(0), NewShift);
Sanjay Patelda9c5622016-08-26 17:15:22 +00001636 Cmp.setOperand(0, NewAnd);
1637 return &Cmp;
1638 }
1639
Sanjay Patel14e0e182016-08-26 18:28:46 +00001640 return nullptr;
1641}
1642
1643/// Fold icmp (and X, C2), C1.
1644Instruction *InstCombiner::foldICmpAndConstConst(ICmpInst &Cmp,
1645 BinaryOperator *And,
1646 const APInt *C1) {
Sanjay Patel6b490972016-09-04 14:32:15 +00001647 const APInt *C2;
1648 if (!match(And->getOperand(1), m_APInt(C2)))
Sanjay Patel14e0e182016-08-26 18:28:46 +00001649 return nullptr;
1650
1651 if (!And->hasOneUse() || !And->getOperand(0)->hasOneUse())
1652 return nullptr;
1653
Sanjay Patel6b490972016-09-04 14:32:15 +00001654 // If the LHS is an 'and' of a truncate and we can widen the and/compare to
1655 // the input width without changing the value produced, eliminate the cast:
1656 //
1657 // icmp (and (trunc W), C2), C1 -> icmp (and W, C2'), C1'
1658 //
1659 // We can do this transformation if the constants do not have their sign bits
1660 // set or if it is an equality comparison. Extending a relational comparison
1661 // when we're checking the sign bit would not work.
1662 Value *W;
1663 if (match(And->getOperand(0), m_Trunc(m_Value(W))) &&
1664 (Cmp.isEquality() || (!C1->isNegative() && !C2->isNegative()))) {
1665 // TODO: Is this a good transform for vectors? Wider types may reduce
1666 // throughput. Should this transform be limited (even for scalars) by using
Sanjay Patel2217f752017-01-31 17:25:42 +00001667 // shouldChangeType()?
Sanjay Patel6b490972016-09-04 14:32:15 +00001668 if (!Cmp.getType()->isVectorTy()) {
1669 Type *WideType = W->getType();
1670 unsigned WideScalarBits = WideType->getScalarSizeInBits();
1671 Constant *ZextC1 = ConstantInt::get(WideType, C1->zext(WideScalarBits));
1672 Constant *ZextC2 = ConstantInt::get(WideType, C2->zext(WideScalarBits));
1673 Value *NewAnd = Builder->CreateAnd(W, ZextC2, And->getName());
1674 return new ICmpInst(Cmp.getPredicate(), NewAnd, ZextC1);
Sanjay Patel14e0e182016-08-26 18:28:46 +00001675 }
1676 }
1677
Sanjay Patel9b40f982016-09-07 22:33:03 +00001678 if (Instruction *I = foldICmpAndShift(Cmp, And, C1, C2))
Sanjay Patel14e0e182016-08-26 18:28:46 +00001679 return I;
1680
Sanjay Patelda9c5622016-08-26 17:15:22 +00001681 // (icmp pred (and (or (lshr A, B), A), 1), 0) -->
Sanjay Patel6b490972016-09-04 14:32:15 +00001682 // (icmp pred (and A, (or (shl 1, B), 1), 0))
Sanjay Patelda9c5622016-08-26 17:15:22 +00001683 //
1684 // iff pred isn't signed
Sanjay Pateldef931e2016-09-07 20:50:44 +00001685 if (!Cmp.isSigned() && *C1 == 0 && match(And->getOperand(1), m_One())) {
1686 Constant *One = cast<Constant>(And->getOperand(1));
1687 Value *Or = And->getOperand(0);
Sanjay Patelda9c5622016-08-26 17:15:22 +00001688 Value *A, *B, *LShr;
Sanjay Pateldef931e2016-09-07 20:50:44 +00001689 if (match(Or, m_Or(m_Value(LShr), m_Value(A))) &&
1690 match(LShr, m_LShr(m_Specific(A), m_Value(B)))) {
1691 unsigned UsesRemoved = 0;
1692 if (And->hasOneUse())
1693 ++UsesRemoved;
1694 if (Or->hasOneUse())
1695 ++UsesRemoved;
1696 if (LShr->hasOneUse())
1697 ++UsesRemoved;
1698
1699 // Compute A & ((1 << B) | 1)
1700 Value *NewOr = nullptr;
1701 if (auto *C = dyn_cast<Constant>(B)) {
1702 if (UsesRemoved >= 1)
1703 NewOr = ConstantExpr::getOr(ConstantExpr::getNUWShl(One, C), One);
1704 } else {
1705 if (UsesRemoved >= 3)
1706 NewOr = Builder->CreateOr(Builder->CreateShl(One, B, LShr->getName(),
Sanjay Patelda9c5622016-08-26 17:15:22 +00001707 /*HasNUW=*/true),
1708 One, Or->getName());
Sanjay Pateldef931e2016-09-07 20:50:44 +00001709 }
1710 if (NewOr) {
1711 Value *NewAnd = Builder->CreateAnd(A, NewOr, And->getName());
1712 Cmp.setOperand(0, NewAnd);
1713 return &Cmp;
Sanjay Patela3f4f082016-08-16 17:54:36 +00001714 }
1715 }
Sanjay Patela3f4f082016-08-16 17:54:36 +00001716 }
Sanjay Patelda9c5622016-08-26 17:15:22 +00001717
Sanjay Pateldef931e2016-09-07 20:50:44 +00001718 // (X & C2) > C1 --> (X & C2) != 0, if any bit set in (X & C2) will produce a
1719 // result greater than C1.
1720 unsigned NumTZ = C2->countTrailingZeros();
1721 if (Cmp.getPredicate() == ICmpInst::ICMP_UGT && NumTZ < C2->getBitWidth() &&
1722 APInt::getOneBitSet(C2->getBitWidth(), NumTZ).ugt(*C1)) {
1723 Constant *Zero = Constant::getNullValue(And->getType());
1724 return new ICmpInst(ICmpInst::ICMP_NE, And, Zero);
Sanjay Patelda9c5622016-08-26 17:15:22 +00001725 }
1726
Sanjay Pateld3c7bb282016-08-26 16:42:33 +00001727 return nullptr;
1728}
1729
1730/// Fold icmp (and X, Y), C.
1731Instruction *InstCombiner::foldICmpAndConstant(ICmpInst &Cmp,
1732 BinaryOperator *And,
1733 const APInt *C) {
1734 if (Instruction *I = foldICmpAndConstConst(Cmp, And, C))
1735 return I;
1736
Sanjay Patel5c5311f2016-08-28 18:18:00 +00001737 // TODO: These all require that Y is constant too, so refactor with the above.
Sanjay Patela3f4f082016-08-16 17:54:36 +00001738
Sanjay Patel5c5311f2016-08-28 18:18:00 +00001739 // Try to optimize things like "A[i] & 42 == 0" to index computations.
1740 Value *X = And->getOperand(0);
1741 Value *Y = And->getOperand(1);
1742 if (auto *LI = dyn_cast<LoadInst>(X))
1743 if (auto *GEP = dyn_cast<GetElementPtrInst>(LI->getOperand(0)))
1744 if (auto *GV = dyn_cast<GlobalVariable>(GEP->getOperand(0)))
Sanjay Patela3f4f082016-08-16 17:54:36 +00001745 if (GV->isConstant() && GV->hasDefinitiveInitializer() &&
Sanjay Patel5c5311f2016-08-28 18:18:00 +00001746 !LI->isVolatile() && isa<ConstantInt>(Y)) {
1747 ConstantInt *C2 = cast<ConstantInt>(Y);
1748 if (Instruction *Res = foldCmpLoadFromIndexedGlobal(GEP, GV, Cmp, C2))
Sanjay Patela3f4f082016-08-16 17:54:36 +00001749 return Res;
1750 }
Sanjay Patel5c5311f2016-08-28 18:18:00 +00001751
1752 if (!Cmp.isEquality())
1753 return nullptr;
Sanjay Patela3f4f082016-08-16 17:54:36 +00001754
1755 // X & -C == -C -> X > u ~C
1756 // X & -C != -C -> X <= u ~C
1757 // iff C is a power of 2
Sanjay Patel5c5311f2016-08-28 18:18:00 +00001758 if (Cmp.getOperand(1) == Y && (-(*C)).isPowerOf2()) {
1759 auto NewPred = Cmp.getPredicate() == CmpInst::ICMP_EQ ? CmpInst::ICMP_UGT
1760 : CmpInst::ICMP_ULE;
1761 return new ICmpInst(NewPred, X, SubOne(cast<Constant>(Cmp.getOperand(1))));
1762 }
Sanjay Patela3f4f082016-08-16 17:54:36 +00001763
Sanjay Patel5c5311f2016-08-28 18:18:00 +00001764 // (X & C2) == 0 -> (trunc X) >= 0
1765 // (X & C2) != 0 -> (trunc X) < 0
1766 // iff C2 is a power of 2 and it masks the sign bit of a legal integer type.
1767 const APInt *C2;
1768 if (And->hasOneUse() && *C == 0 && match(Y, m_APInt(C2))) {
1769 int32_t ExactLogBase2 = C2->exactLogBase2();
1770 if (ExactLogBase2 != -1 && DL.isLegalInteger(ExactLogBase2 + 1)) {
1771 Type *NTy = IntegerType::get(Cmp.getContext(), ExactLogBase2 + 1);
1772 if (And->getType()->isVectorTy())
1773 NTy = VectorType::get(NTy, And->getType()->getVectorNumElements());
1774 Value *Trunc = Builder->CreateTrunc(X, NTy);
1775 auto NewPred = Cmp.getPredicate() == CmpInst::ICMP_EQ ? CmpInst::ICMP_SGE
1776 : CmpInst::ICMP_SLT;
1777 return new ICmpInst(NewPred, Trunc, Constant::getNullValue(NTy));
Sanjay Patela3f4f082016-08-16 17:54:36 +00001778 }
1779 }
Sanjay Patel5c5311f2016-08-28 18:18:00 +00001780
Sanjay Patela3f4f082016-08-16 17:54:36 +00001781 return nullptr;
1782}
1783
Sanjay Patel943e92e2016-08-17 16:30:43 +00001784/// Fold icmp (or X, Y), C.
Sanjay Patelc9196c42016-08-22 21:24:29 +00001785Instruction *InstCombiner::foldICmpOrConstant(ICmpInst &Cmp, BinaryOperator *Or,
Sanjay Patel943e92e2016-08-17 16:30:43 +00001786 const APInt *C) {
Sanjay Patel943e92e2016-08-17 16:30:43 +00001787 ICmpInst::Predicate Pred = Cmp.getPredicate();
1788 if (*C == 1) {
Sanjay Patela3f4f082016-08-16 17:54:36 +00001789 // icmp slt signum(V) 1 --> icmp slt V, 1
1790 Value *V = nullptr;
Sanjay Patel943e92e2016-08-17 16:30:43 +00001791 if (Pred == ICmpInst::ICMP_SLT && match(Or, m_Signum(m_Value(V))))
Sanjay Patela3f4f082016-08-16 17:54:36 +00001792 return new ICmpInst(ICmpInst::ICMP_SLT, V,
1793 ConstantInt::get(V->getType(), 1));
1794 }
1795
Sanjay Patel50c82c42017-04-05 17:57:05 +00001796 // X | C == C --> X <=u C
1797 // X | C != C --> X >u C
1798 // iff C+1 is a power of 2 (C is a bitmask of the low bits)
1799 if (Cmp.isEquality() && Cmp.getOperand(1) == Or->getOperand(1) &&
1800 (*C + 1).isPowerOf2()) {
1801 Pred = (Pred == CmpInst::ICMP_EQ) ? CmpInst::ICMP_ULE : CmpInst::ICMP_UGT;
1802 return new ICmpInst(Pred, Or->getOperand(0), Or->getOperand(1));
1803 }
1804
Sanjay Patel943e92e2016-08-17 16:30:43 +00001805 if (!Cmp.isEquality() || *C != 0 || !Or->hasOneUse())
Sanjay Patela3f4f082016-08-16 17:54:36 +00001806 return nullptr;
1807
1808 Value *P, *Q;
Sanjay Patel943e92e2016-08-17 16:30:43 +00001809 if (match(Or, m_Or(m_PtrToInt(m_Value(P)), m_PtrToInt(m_Value(Q))))) {
Sanjay Patela3f4f082016-08-16 17:54:36 +00001810 // Simplify icmp eq (or (ptrtoint P), (ptrtoint Q)), 0
1811 // -> and (icmp eq P, null), (icmp eq Q, null).
Reid Klecknera871d382016-08-19 16:53:18 +00001812 Value *CmpP =
1813 Builder->CreateICmp(Pred, P, ConstantInt::getNullValue(P->getType()));
1814 Value *CmpQ =
1815 Builder->CreateICmp(Pred, Q, ConstantInt::getNullValue(Q->getType()));
Sanjay Patel943e92e2016-08-17 16:30:43 +00001816 auto LogicOpc = Pred == ICmpInst::Predicate::ICMP_EQ ? Instruction::And
1817 : Instruction::Or;
1818 return BinaryOperator::Create(LogicOpc, CmpP, CmpQ);
Sanjay Patela3f4f082016-08-16 17:54:36 +00001819 }
Sanjay Patel943e92e2016-08-17 16:30:43 +00001820
Sanjay Patela3f4f082016-08-16 17:54:36 +00001821 return nullptr;
1822}
1823
Sanjay Patel63478072016-08-18 15:44:44 +00001824/// Fold icmp (mul X, Y), C.
Sanjay Patelc9196c42016-08-22 21:24:29 +00001825Instruction *InstCombiner::foldICmpMulConstant(ICmpInst &Cmp,
1826 BinaryOperator *Mul,
Sanjay Patel63478072016-08-18 15:44:44 +00001827 const APInt *C) {
1828 const APInt *MulC;
1829 if (!match(Mul->getOperand(1), m_APInt(MulC)))
Sanjay Patela3f4f082016-08-16 17:54:36 +00001830 return nullptr;
1831
Sanjay Patel63478072016-08-18 15:44:44 +00001832 // If this is a test of the sign bit and the multiply is sign-preserving with
1833 // a constant operand, use the multiply LHS operand instead.
1834 ICmpInst::Predicate Pred = Cmp.getPredicate();
Sanjay Patelc9196c42016-08-22 21:24:29 +00001835 if (isSignTest(Pred, *C) && Mul->hasNoSignedWrap()) {
Sanjay Patel63478072016-08-18 15:44:44 +00001836 if (MulC->isNegative())
1837 Pred = ICmpInst::getSwappedPredicate(Pred);
1838 return new ICmpInst(Pred, Mul->getOperand(0),
1839 Constant::getNullValue(Mul->getType()));
1840 }
Sanjay Patela3f4f082016-08-16 17:54:36 +00001841
1842 return nullptr;
1843}
1844
Sanjay Patel98cd99d2016-08-18 21:28:30 +00001845/// Fold icmp (shl 1, Y), C.
1846static Instruction *foldICmpShlOne(ICmpInst &Cmp, Instruction *Shl,
1847 const APInt *C) {
1848 Value *Y;
1849 if (!match(Shl, m_Shl(m_One(), m_Value(Y))))
1850 return nullptr;
1851
1852 Type *ShiftType = Shl->getType();
1853 uint32_t TypeBits = C->getBitWidth();
1854 bool CIsPowerOf2 = C->isPowerOf2();
1855 ICmpInst::Predicate Pred = Cmp.getPredicate();
1856 if (Cmp.isUnsigned()) {
1857 // (1 << Y) pred C -> Y pred Log2(C)
1858 if (!CIsPowerOf2) {
1859 // (1 << Y) < 30 -> Y <= 4
1860 // (1 << Y) <= 30 -> Y <= 4
1861 // (1 << Y) >= 30 -> Y > 4
1862 // (1 << Y) > 30 -> Y > 4
1863 if (Pred == ICmpInst::ICMP_ULT)
1864 Pred = ICmpInst::ICMP_ULE;
1865 else if (Pred == ICmpInst::ICMP_UGE)
1866 Pred = ICmpInst::ICMP_UGT;
1867 }
1868
1869 // (1 << Y) >= 2147483648 -> Y >= 31 -> Y == 31
1870 // (1 << Y) < 2147483648 -> Y < 31 -> Y != 31
1871 unsigned CLog2 = C->logBase2();
1872 if (CLog2 == TypeBits - 1) {
1873 if (Pred == ICmpInst::ICMP_UGE)
1874 Pred = ICmpInst::ICMP_EQ;
1875 else if (Pred == ICmpInst::ICMP_ULT)
1876 Pred = ICmpInst::ICMP_NE;
1877 }
1878 return new ICmpInst(Pred, Y, ConstantInt::get(ShiftType, CLog2));
1879 } else if (Cmp.isSigned()) {
1880 Constant *BitWidthMinusOne = ConstantInt::get(ShiftType, TypeBits - 1);
1881 if (C->isAllOnesValue()) {
1882 // (1 << Y) <= -1 -> Y == 31
1883 if (Pred == ICmpInst::ICMP_SLE)
1884 return new ICmpInst(ICmpInst::ICMP_EQ, Y, BitWidthMinusOne);
1885
1886 // (1 << Y) > -1 -> Y != 31
1887 if (Pred == ICmpInst::ICMP_SGT)
1888 return new ICmpInst(ICmpInst::ICMP_NE, Y, BitWidthMinusOne);
1889 } else if (!(*C)) {
1890 // (1 << Y) < 0 -> Y == 31
1891 // (1 << Y) <= 0 -> Y == 31
1892 if (Pred == ICmpInst::ICMP_SLT || Pred == ICmpInst::ICMP_SLE)
1893 return new ICmpInst(ICmpInst::ICMP_EQ, Y, BitWidthMinusOne);
1894
1895 // (1 << Y) >= 0 -> Y != 31
1896 // (1 << Y) > 0 -> Y != 31
1897 if (Pred == ICmpInst::ICMP_SGT || Pred == ICmpInst::ICMP_SGE)
1898 return new ICmpInst(ICmpInst::ICMP_NE, Y, BitWidthMinusOne);
1899 }
1900 } else if (Cmp.isEquality() && CIsPowerOf2) {
1901 return new ICmpInst(Pred, Y, ConstantInt::get(ShiftType, C->logBase2()));
1902 }
1903
1904 return nullptr;
1905}
1906
Sanjay Patel38b75062016-08-19 17:20:37 +00001907/// Fold icmp (shl X, Y), C.
Sanjay Patelc9196c42016-08-22 21:24:29 +00001908Instruction *InstCombiner::foldICmpShlConstant(ICmpInst &Cmp,
1909 BinaryOperator *Shl,
Sanjay Patel38b75062016-08-19 17:20:37 +00001910 const APInt *C) {
Sanjay Patel8da42cc2016-09-15 22:26:31 +00001911 const APInt *ShiftVal;
1912 if (Cmp.isEquality() && match(Shl->getOperand(0), m_APInt(ShiftVal)))
1913 return foldICmpShlConstConst(Cmp, Shl->getOperand(1), *C, *ShiftVal);
1914
Sanjay Patelfa7de602016-08-19 22:33:26 +00001915 const APInt *ShiftAmt;
1916 if (!match(Shl->getOperand(1), m_APInt(ShiftAmt)))
Sanjay Patel38b75062016-08-19 17:20:37 +00001917 return foldICmpShlOne(Cmp, Shl, C);
Sanjay Patela867afe2016-08-19 16:12:16 +00001918
Sanjay Patel38b75062016-08-19 17:20:37 +00001919 // Check that the shift amount is in range. If not, don't perform undefined
Sanjay Patel940c0612017-01-09 16:27:56 +00001920 // shifts. When the shift is visited, it will be simplified.
Sanjay Patel38b75062016-08-19 17:20:37 +00001921 unsigned TypeBits = C->getBitWidth();
Sanjay Patelfa7de602016-08-19 22:33:26 +00001922 if (ShiftAmt->uge(TypeBits))
Sanjay Patela3f4f082016-08-16 17:54:36 +00001923 return nullptr;
1924
Sanjay Patele38e79c2016-08-19 17:34:05 +00001925 ICmpInst::Predicate Pred = Cmp.getPredicate();
1926 Value *X = Shl->getOperand(0);
Sanjay Patel14715b32017-01-17 21:25:16 +00001927 Type *ShType = Shl->getType();
1928
Sanjay Patel291c3d82017-01-19 16:12:10 +00001929 // NSW guarantees that we are only shifting out sign bits from the high bits,
1930 // so we can ASHR the compare constant without needing a mask and eliminate
1931 // the shift.
1932 if (Shl->hasNoSignedWrap()) {
1933 if (Pred == ICmpInst::ICMP_SGT) {
1934 // icmp Pred (shl nsw X, ShiftAmt), C --> icmp Pred X, (C >>s ShiftAmt)
1935 APInt ShiftedC = C->ashr(*ShiftAmt);
1936 return new ICmpInst(Pred, X, ConstantInt::get(ShType, ShiftedC));
1937 }
1938 if (Pred == ICmpInst::ICMP_EQ || Pred == ICmpInst::ICMP_NE) {
1939 // This is the same code as the SGT case, but assert the pre-condition
1940 // that is needed for this to work with equality predicates.
1941 assert(C->ashr(*ShiftAmt).shl(*ShiftAmt) == *C &&
1942 "Compare known true or false was not folded");
1943 APInt ShiftedC = C->ashr(*ShiftAmt);
1944 return new ICmpInst(Pred, X, ConstantInt::get(ShType, ShiftedC));
1945 }
1946 if (Pred == ICmpInst::ICMP_SLT) {
1947 // SLE is the same as above, but SLE is canonicalized to SLT, so convert:
1948 // (X << S) <=s C is equiv to X <=s (C >> S) for all C
1949 // (X << S) <s (C + 1) is equiv to X <s (C >> S) + 1 if C <s SMAX
1950 // (X << S) <s C is equiv to X <s ((C - 1) >> S) + 1 if C >s SMIN
1951 assert(!C->isMinSignedValue() && "Unexpected icmp slt");
1952 APInt ShiftedC = (*C - 1).ashr(*ShiftAmt) + 1;
1953 return new ICmpInst(Pred, X, ConstantInt::get(ShType, ShiftedC));
1954 }
1955 // If this is a signed comparison to 0 and the shift is sign preserving,
1956 // use the shift LHS operand instead; isSignTest may change 'Pred', so only
1957 // do that if we're sure to not continue on in this function.
1958 if (isSignTest(Pred, *C))
1959 return new ICmpInst(Pred, X, Constant::getNullValue(ShType));
1960 }
Sanjay Patel14715b32017-01-17 21:25:16 +00001961
Sanjay Patel291c3d82017-01-19 16:12:10 +00001962 // NUW guarantees that we are only shifting out zero bits from the high bits,
1963 // so we can LSHR the compare constant without needing a mask and eliminate
1964 // the shift.
Sanjay Patel14715b32017-01-17 21:25:16 +00001965 if (Shl->hasNoUnsignedWrap()) {
Sanjay Patelae23d652017-01-18 21:16:12 +00001966 if (Pred == ICmpInst::ICMP_UGT) {
Sanjay Patel14715b32017-01-17 21:25:16 +00001967 // icmp Pred (shl nuw X, ShiftAmt), C --> icmp Pred X, (C >>u ShiftAmt)
1968 APInt ShiftedC = C->lshr(*ShiftAmt);
1969 return new ICmpInst(Pred, X, ConstantInt::get(ShType, ShiftedC));
1970 }
Sanjay Patelae23d652017-01-18 21:16:12 +00001971 if (Pred == ICmpInst::ICMP_EQ || Pred == ICmpInst::ICMP_NE) {
1972 // This is the same code as the UGT case, but assert the pre-condition
1973 // that is needed for this to work with equality predicates.
1974 assert(C->lshr(*ShiftAmt).shl(*ShiftAmt) == *C &&
1975 "Compare known true or false was not folded");
1976 APInt ShiftedC = C->lshr(*ShiftAmt);
1977 return new ICmpInst(Pred, X, ConstantInt::get(ShType, ShiftedC));
1978 }
Sanjay Patel14715b32017-01-17 21:25:16 +00001979 if (Pred == ICmpInst::ICMP_ULT) {
1980 // ULE is the same as above, but ULE is canonicalized to ULT, so convert:
1981 // (X << S) <=u C is equiv to X <=u (C >> S) for all C
1982 // (X << S) <u (C + 1) is equiv to X <u (C >> S) + 1 if C <u ~0u
1983 // (X << S) <u C is equiv to X <u ((C - 1) >> S) + 1 if C >u 0
1984 assert(C->ugt(0) && "ult 0 should have been eliminated");
1985 APInt ShiftedC = (*C - 1).lshr(*ShiftAmt) + 1;
1986 return new ICmpInst(Pred, X, ConstantInt::get(ShType, ShiftedC));
1987 }
1988 }
1989
Sanjay Patel291c3d82017-01-19 16:12:10 +00001990 if (Cmp.isEquality() && Shl->hasOneUse()) {
1991 // Strength-reduce the shift into an 'and'.
1992 Constant *Mask = ConstantInt::get(
1993 ShType,
1994 APInt::getLowBitsSet(TypeBits, TypeBits - ShiftAmt->getZExtValue()));
1995 Value *And = Builder->CreateAnd(X, Mask, Shl->getName() + ".mask");
Sanjay Patel14715b32017-01-17 21:25:16 +00001996 Constant *LShrC = ConstantInt::get(ShType, C->lshr(*ShiftAmt));
Sanjay Patel291c3d82017-01-19 16:12:10 +00001997 return new ICmpInst(Pred, And, LShrC);
Sanjay Patela3f4f082016-08-16 17:54:36 +00001998 }
1999
Sanjay Patela3f4f082016-08-16 17:54:36 +00002000 // Otherwise, if this is a comparison of the sign bit, simplify to and/test.
2001 bool TrueIfSigned = false;
Sanjay Patel79263662016-08-21 15:07:45 +00002002 if (Shl->hasOneUse() && isSignBitCheck(Pred, *C, TrueIfSigned)) {
Sanjay Patel7ffcde72016-08-21 16:35:34 +00002003 // (X << 31) <s 0 --> (X & 1) != 0
Sanjay Patela3f4f082016-08-16 17:54:36 +00002004 Constant *Mask = ConstantInt::get(
Sanjay Patel14715b32017-01-17 21:25:16 +00002005 ShType,
Sanjay Patelfa7de602016-08-19 22:33:26 +00002006 APInt::getOneBitSet(TypeBits, TypeBits - ShiftAmt->getZExtValue() - 1));
Sanjay Patele38e79c2016-08-19 17:34:05 +00002007 Value *And = Builder->CreateAnd(X, Mask, Shl->getName() + ".mask");
Sanjay Patela3f4f082016-08-16 17:54:36 +00002008 return new ICmpInst(TrueIfSigned ? ICmpInst::ICMP_NE : ICmpInst::ICMP_EQ,
Sanjay Patel14715b32017-01-17 21:25:16 +00002009 And, Constant::getNullValue(ShType));
Sanjay Patelc0339c72016-11-01 19:19:29 +00002010 }
2011
Sanjay Patel643d21a2016-08-21 17:10:07 +00002012 // Transform (icmp pred iM (shl iM %v, N), C)
2013 // -> (icmp pred i(M-N) (trunc %v iM to i(M-N)), (trunc (C>>N))
2014 // Transform the shl to a trunc if (trunc (C>>N)) has no loss and M-N.
Sanjay Patel940c0612017-01-09 16:27:56 +00002015 // This enables us to get rid of the shift in favor of a trunc that may be
Sanjay Patela3f4f082016-08-16 17:54:36 +00002016 // free on the target. It has the additional benefit of comparing to a
Sanjay Patel940c0612017-01-09 16:27:56 +00002017 // smaller constant that may be more target-friendly.
Sanjay Patelfa7de602016-08-19 22:33:26 +00002018 unsigned Amt = ShiftAmt->getLimitedValue(TypeBits - 1);
Sanjay Patelf3dda132016-10-25 20:11:47 +00002019 if (Shl->hasOneUse() && Amt != 0 && C->countTrailingZeros() >= Amt &&
2020 DL.isLegalInteger(TypeBits - Amt)) {
Sanjay Patel643d21a2016-08-21 17:10:07 +00002021 Type *TruncTy = IntegerType::get(Cmp.getContext(), TypeBits - Amt);
Sanjay Patel14715b32017-01-17 21:25:16 +00002022 if (ShType->isVectorTy())
2023 TruncTy = VectorType::get(TruncTy, ShType->getVectorNumElements());
Sanjay Patel643d21a2016-08-21 17:10:07 +00002024 Constant *NewC =
2025 ConstantInt::get(TruncTy, C->ashr(*ShiftAmt).trunc(TypeBits - Amt));
2026 return new ICmpInst(Pred, Builder->CreateTrunc(X, TruncTy), NewC);
Sanjay Patela3f4f082016-08-16 17:54:36 +00002027 }
2028
2029 return nullptr;
2030}
2031
Sanjay Patela3920492016-08-22 20:45:06 +00002032/// Fold icmp ({al}shr X, Y), C.
Sanjay Patelc9196c42016-08-22 21:24:29 +00002033Instruction *InstCombiner::foldICmpShrConstant(ICmpInst &Cmp,
2034 BinaryOperator *Shr,
2035 const APInt *C) {
Sanjay Patela3920492016-08-22 20:45:06 +00002036 // An exact shr only shifts out zero bits, so:
2037 // icmp eq/ne (shr X, Y), 0 --> icmp eq/ne X, 0
Sanjay Pateld64e9882016-08-23 22:05:55 +00002038 Value *X = Shr->getOperand(0);
Sanjay Patelc9196c42016-08-22 21:24:29 +00002039 CmpInst::Predicate Pred = Cmp.getPredicate();
2040 if (Cmp.isEquality() && Shr->isExact() && Shr->hasOneUse() && *C == 0)
Sanjay Pateld64e9882016-08-23 22:05:55 +00002041 return new ICmpInst(Pred, X, Cmp.getOperand(1));
Sanjay Patela3920492016-08-22 20:45:06 +00002042
Sanjay Patel8da42cc2016-09-15 22:26:31 +00002043 const APInt *ShiftVal;
2044 if (Cmp.isEquality() && match(Shr->getOperand(0), m_APInt(ShiftVal)))
2045 return foldICmpShrConstConst(Cmp, Shr->getOperand(1), *C, *ShiftVal);
2046
Sanjay Pateld398d4a2016-08-24 22:22:06 +00002047 const APInt *ShiftAmt;
2048 if (!match(Shr->getOperand(1), m_APInt(ShiftAmt)))
Sanjay Patela3f4f082016-08-16 17:54:36 +00002049 return nullptr;
2050
Sanjay Pateld398d4a2016-08-24 22:22:06 +00002051 // Check that the shift amount is in range. If not, don't perform undefined
2052 // shifts. When the shift is visited it will be simplified.
2053 unsigned TypeBits = C->getBitWidth();
2054 unsigned ShAmtVal = ShiftAmt->getLimitedValue(TypeBits);
Sanjay Pateldcac0df2016-08-23 21:25:13 +00002055 if (ShAmtVal >= TypeBits || ShAmtVal == 0)
2056 return nullptr;
2057
Sanjay Pateld64e9882016-08-23 22:05:55 +00002058 bool IsAShr = Shr->getOpcode() == Instruction::AShr;
Sanjay Pateldcac0df2016-08-23 21:25:13 +00002059 if (!Cmp.isEquality()) {
2060 // If we have an unsigned comparison and an ashr, we can't simplify this.
2061 // Similarly for signed comparisons with lshr.
Sanjay Pateld64e9882016-08-23 22:05:55 +00002062 if (Cmp.isSigned() != IsAShr)
Sanjay Pateldcac0df2016-08-23 21:25:13 +00002063 return nullptr;
2064
2065 // Otherwise, all lshr and most exact ashr's are equivalent to a udiv/sdiv
2066 // by a power of 2. Since we already have logic to simplify these,
2067 // transform to div and then simplify the resultant comparison.
Sanjay Pateld64e9882016-08-23 22:05:55 +00002068 if (IsAShr && (!Shr->isExact() || ShAmtVal == TypeBits - 1))
Sanjay Pateldcac0df2016-08-23 21:25:13 +00002069 return nullptr;
2070
2071 // Revisit the shift (to delete it).
2072 Worklist.Add(Shr);
2073
2074 Constant *DivCst = ConstantInt::get(
2075 Shr->getType(), APInt::getOneBitSet(TypeBits, ShAmtVal));
2076
Sanjay Pateld64e9882016-08-23 22:05:55 +00002077 Value *Tmp = IsAShr ? Builder->CreateSDiv(X, DivCst, "", Shr->isExact())
2078 : Builder->CreateUDiv(X, DivCst, "", Shr->isExact());
Sanjay Pateldcac0df2016-08-23 21:25:13 +00002079
2080 Cmp.setOperand(0, Tmp);
2081
2082 // If the builder folded the binop, just return it.
2083 BinaryOperator *TheDiv = dyn_cast<BinaryOperator>(Tmp);
2084 if (!TheDiv)
2085 return &Cmp;
2086
2087 // Otherwise, fold this div/compare.
2088 assert(TheDiv->getOpcode() == Instruction::SDiv ||
2089 TheDiv->getOpcode() == Instruction::UDiv);
2090
Sanjay Patelf7ba0892016-08-26 15:53:01 +00002091 Instruction *Res = foldICmpDivConstant(Cmp, TheDiv, C);
Sanjay Pateldcac0df2016-08-23 21:25:13 +00002092 assert(Res && "This div/cst should have folded!");
Sanjay Patela3920492016-08-22 20:45:06 +00002093 return Res;
Sanjay Pateldcac0df2016-08-23 21:25:13 +00002094 }
2095
Sanjay Pateld398d4a2016-08-24 22:22:06 +00002096 // Handle equality comparisons of shift-by-constant.
2097
Sanjay Patel8e297742016-08-24 13:55:55 +00002098 // If the comparison constant changes with the shift, the comparison cannot
2099 // succeed (bits of the comparison constant cannot match the shifted value).
2100 // This should be known by InstSimplify and already be folded to true/false.
2101 assert(((IsAShr && C->shl(ShAmtVal).ashr(ShAmtVal) == *C) ||
2102 (!IsAShr && C->shl(ShAmtVal).lshr(ShAmtVal) == *C)) &&
2103 "Expected icmp+shr simplify did not occur.");
2104
Sanjay Pateldcac0df2016-08-23 21:25:13 +00002105 // Check if the bits shifted out are known to be zero. If so, we can compare
2106 // against the unshifted value:
2107 // (X & 4) >> 1 == 2 --> (X & 4) == 4.
Sanjay Pateld398d4a2016-08-24 22:22:06 +00002108 Constant *ShiftedCmpRHS = ConstantInt::get(Shr->getType(), *C << ShAmtVal);
Sanjay Pateldcac0df2016-08-23 21:25:13 +00002109 if (Shr->hasOneUse()) {
Sanjay Pateld398d4a2016-08-24 22:22:06 +00002110 if (Shr->isExact())
2111 return new ICmpInst(Pred, X, ShiftedCmpRHS);
Sanjay Pateldcac0df2016-08-23 21:25:13 +00002112
Sanjay Pateld398d4a2016-08-24 22:22:06 +00002113 // Otherwise strength reduce the shift into an 'and'.
2114 APInt Val(APInt::getHighBitsSet(TypeBits, TypeBits - ShAmtVal));
2115 Constant *Mask = ConstantInt::get(Shr->getType(), Val);
Sanjay Pateld64e9882016-08-23 22:05:55 +00002116 Value *And = Builder->CreateAnd(X, Mask, Shr->getName() + ".mask");
Sanjay Pateldcac0df2016-08-23 21:25:13 +00002117 return new ICmpInst(Pred, And, ShiftedCmpRHS);
2118 }
Sanjay Patela3f4f082016-08-16 17:54:36 +00002119
2120 return nullptr;
2121}
2122
Sanjay Patel12a41052016-08-18 17:37:26 +00002123/// Fold icmp (udiv X, Y), C.
2124Instruction *InstCombiner::foldICmpUDivConstant(ICmpInst &Cmp,
Sanjay Patelc9196c42016-08-22 21:24:29 +00002125 BinaryOperator *UDiv,
Sanjay Patel12a41052016-08-18 17:37:26 +00002126 const APInt *C) {
Sanjay Patelfa5ca2b2016-08-18 17:55:59 +00002127 const APInt *C2;
2128 if (!match(UDiv->getOperand(0), m_APInt(C2)))
2129 return nullptr;
2130
2131 assert(C2 != 0 && "udiv 0, X should have been simplified already.");
2132
2133 // (icmp ugt (udiv C2, Y), C) -> (icmp ule Y, C2/(C+1))
2134 Value *Y = UDiv->getOperand(1);
2135 if (Cmp.getPredicate() == ICmpInst::ICMP_UGT) {
2136 assert(!C->isMaxValue() &&
2137 "icmp ugt X, UINT_MAX should have been simplified already.");
2138 return new ICmpInst(ICmpInst::ICMP_ULE, Y,
2139 ConstantInt::get(Y->getType(), C2->udiv(*C + 1)));
2140 }
2141
2142 // (icmp ult (udiv C2, Y), C) -> (icmp ugt Y, C2/C)
2143 if (Cmp.getPredicate() == ICmpInst::ICMP_ULT) {
2144 assert(C != 0 && "icmp ult X, 0 should have been simplified already.");
2145 return new ICmpInst(ICmpInst::ICMP_UGT, Y,
2146 ConstantInt::get(Y->getType(), C2->udiv(*C)));
Sanjay Patela3f4f082016-08-16 17:54:36 +00002147 }
2148
2149 return nullptr;
2150}
2151
Sanjay Patelf7ba0892016-08-26 15:53:01 +00002152/// Fold icmp ({su}div X, Y), C.
2153Instruction *InstCombiner::foldICmpDivConstant(ICmpInst &Cmp,
2154 BinaryOperator *Div,
2155 const APInt *C) {
Sanjay Patela7cb4772016-08-30 17:10:49 +00002156 // Fold: icmp pred ([us]div X, C2), C -> range test
Sanjay Patela3f4f082016-08-16 17:54:36 +00002157 // Fold this div into the comparison, producing a range check.
2158 // Determine, based on the divide type, what the range is being
2159 // checked. If there is an overflow on the low or high side, remember
2160 // it, otherwise compute the range [low, hi) bounding the new value.
2161 // See: InsertRangeTest above for the kinds of replacements possible.
Sanjay Patela7cb4772016-08-30 17:10:49 +00002162 const APInt *C2;
2163 if (!match(Div->getOperand(1), m_APInt(C2)))
Sanjay Patel16554142016-08-24 23:03:36 +00002164 return nullptr;
2165
Sanjay Patel16554142016-08-24 23:03:36 +00002166 // FIXME: If the operand types don't match the type of the divide
2167 // then don't attempt this transform. The code below doesn't have the
2168 // logic to deal with a signed divide and an unsigned compare (and
Sanjay Patela7cb4772016-08-30 17:10:49 +00002169 // vice versa). This is because (x /s C2) <s C produces different
2170 // results than (x /s C2) <u C or (x /u C2) <s C or even
2171 // (x /u C2) <u C. Simply casting the operands and result won't
Sanjay Patel16554142016-08-24 23:03:36 +00002172 // work. :( The if statement below tests that condition and bails
2173 // if it finds it.
Sanjay Patelf7ba0892016-08-26 15:53:01 +00002174 bool DivIsSigned = Div->getOpcode() == Instruction::SDiv;
2175 if (!Cmp.isEquality() && DivIsSigned != Cmp.isSigned())
Sanjay Patel16554142016-08-24 23:03:36 +00002176 return nullptr;
Sanjay Patela7cb4772016-08-30 17:10:49 +00002177
Sanjay Pateleea2ef72016-09-05 23:38:22 +00002178 // The ProdOV computation fails on divide by 0 and divide by -1. Cases with
2179 // INT_MIN will also fail if the divisor is 1. Although folds of all these
2180 // division-by-constant cases should be present, we can not assert that they
2181 // have happened before we reach this icmp instruction.
2182 if (*C2 == 0 || *C2 == 1 || (DivIsSigned && C2->isAllOnesValue()))
2183 return nullptr;
Sanjay Patelb3714572016-08-30 17:31:34 +00002184
Sanjay Patel541aef42016-08-31 21:57:21 +00002185 // TODO: We could do all of the computations below using APInt.
2186 Constant *CmpRHS = cast<Constant>(Cmp.getOperand(1));
2187 Constant *DivRHS = cast<Constant>(Div->getOperand(1));
Sanjay Patelb3714572016-08-30 17:31:34 +00002188
Sanjay Patel541aef42016-08-31 21:57:21 +00002189 // Compute Prod = CmpRHS * DivRHS. We are essentially solving an equation of
2190 // form X / C2 = C. We solve for X by multiplying C2 (DivRHS) and C (CmpRHS).
2191 // By solving for X, we can turn this into a range check instead of computing
2192 // a divide.
2193 Constant *Prod = ConstantExpr::getMul(CmpRHS, DivRHS);
Sanjay Patel16554142016-08-24 23:03:36 +00002194
Sanjay Patel541aef42016-08-31 21:57:21 +00002195 // Determine if the product overflows by seeing if the product is not equal to
2196 // the divide. Make sure we do the same kind of divide as in the LHS
2197 // instruction that we're folding.
2198 bool ProdOV = (DivIsSigned ? ConstantExpr::getSDiv(Prod, DivRHS)
2199 : ConstantExpr::getUDiv(Prod, DivRHS)) != CmpRHS;
Sanjay Patel16554142016-08-24 23:03:36 +00002200
Sanjay Patelf7ba0892016-08-26 15:53:01 +00002201 ICmpInst::Predicate Pred = Cmp.getPredicate();
Sanjay Patel16554142016-08-24 23:03:36 +00002202
2203 // If the division is known to be exact, then there is no remainder from the
2204 // divide, so the covered range size is unit, otherwise it is the divisor.
Sanjay Patel541aef42016-08-31 21:57:21 +00002205 Constant *RangeSize =
2206 Div->isExact() ? ConstantInt::get(Div->getType(), 1) : DivRHS;
Sanjay Patel16554142016-08-24 23:03:36 +00002207
2208 // Figure out the interval that is being checked. For example, a comparison
2209 // like "X /u 5 == 0" is really checking that X is in the interval [0, 5).
2210 // Compute this interval based on the constants involved and the signedness of
2211 // the compare/divide. This computes a half-open interval, keeping track of
2212 // whether either value in the interval overflows. After analysis each
2213 // overflow variable is set to 0 if it's corresponding bound variable is valid
2214 // -1 if overflowed off the bottom end, or +1 if overflowed off the top end.
2215 int LoOverflow = 0, HiOverflow = 0;
2216 Constant *LoBound = nullptr, *HiBound = nullptr;
2217
2218 if (!DivIsSigned) { // udiv
2219 // e.g. X/5 op 3 --> [15, 20)
2220 LoBound = Prod;
2221 HiOverflow = LoOverflow = ProdOV;
2222 if (!HiOverflow) {
2223 // If this is not an exact divide, then many values in the range collapse
2224 // to the same result value.
Sanjay Pateld93c4c02016-09-15 18:22:25 +00002225 HiOverflow = addWithOverflow(HiBound, LoBound, RangeSize, false);
Sanjay Patel16554142016-08-24 23:03:36 +00002226 }
Sanjay Patel541aef42016-08-31 21:57:21 +00002227 } else if (C2->isStrictlyPositive()) { // Divisor is > 0.
Sanjay Patelf7ba0892016-08-26 15:53:01 +00002228 if (*C == 0) { // (X / pos) op 0
Sanjay Patel16554142016-08-24 23:03:36 +00002229 // Can't overflow. e.g. X/2 op 0 --> [-1, 2)
2230 LoBound = ConstantExpr::getNeg(SubOne(RangeSize));
2231 HiBound = RangeSize;
Sanjay Patelf7ba0892016-08-26 15:53:01 +00002232 } else if (C->isStrictlyPositive()) { // (X / pos) op pos
Sanjay Patel16554142016-08-24 23:03:36 +00002233 LoBound = Prod; // e.g. X/5 op 3 --> [15, 20)
2234 HiOverflow = LoOverflow = ProdOV;
2235 if (!HiOverflow)
Sanjay Pateld93c4c02016-09-15 18:22:25 +00002236 HiOverflow = addWithOverflow(HiBound, Prod, RangeSize, true);
Sanjay Patel16554142016-08-24 23:03:36 +00002237 } else { // (X / pos) op neg
2238 // e.g. X/5 op -3 --> [-15-4, -15+1) --> [-19, -14)
2239 HiBound = AddOne(Prod);
2240 LoOverflow = HiOverflow = ProdOV ? -1 : 0;
2241 if (!LoOverflow) {
Sanjay Patel541aef42016-08-31 21:57:21 +00002242 Constant *DivNeg = ConstantExpr::getNeg(RangeSize);
Sanjay Pateld93c4c02016-09-15 18:22:25 +00002243 LoOverflow = addWithOverflow(LoBound, HiBound, DivNeg, true) ? -1 : 0;
Sanjay Patel16554142016-08-24 23:03:36 +00002244 }
2245 }
Sanjay Patel541aef42016-08-31 21:57:21 +00002246 } else if (C2->isNegative()) { // Divisor is < 0.
Sanjay Patelf7ba0892016-08-26 15:53:01 +00002247 if (Div->isExact())
Sanjay Patel541aef42016-08-31 21:57:21 +00002248 RangeSize = ConstantExpr::getNeg(RangeSize);
Sanjay Patelf7ba0892016-08-26 15:53:01 +00002249 if (*C == 0) { // (X / neg) op 0
Sanjay Patel16554142016-08-24 23:03:36 +00002250 // e.g. X/-5 op 0 --> [-4, 5)
2251 LoBound = AddOne(RangeSize);
Sanjay Patel541aef42016-08-31 21:57:21 +00002252 HiBound = ConstantExpr::getNeg(RangeSize);
Sanjay Patel16554142016-08-24 23:03:36 +00002253 if (HiBound == DivRHS) { // -INTMIN = INTMIN
2254 HiOverflow = 1; // [INTMIN+1, overflow)
2255 HiBound = nullptr; // e.g. X/INTMIN = 0 --> X > INTMIN
2256 }
Sanjay Patelf7ba0892016-08-26 15:53:01 +00002257 } else if (C->isStrictlyPositive()) { // (X / neg) op pos
Sanjay Patel16554142016-08-24 23:03:36 +00002258 // e.g. X/-5 op 3 --> [-19, -14)
2259 HiBound = AddOne(Prod);
2260 HiOverflow = LoOverflow = ProdOV ? -1 : 0;
2261 if (!LoOverflow)
Sanjay Pateld93c4c02016-09-15 18:22:25 +00002262 LoOverflow = addWithOverflow(LoBound, HiBound, RangeSize, true) ? -1:0;
Sanjay Patel16554142016-08-24 23:03:36 +00002263 } else { // (X / neg) op neg
2264 LoBound = Prod; // e.g. X/-5 op -3 --> [15, 20)
2265 LoOverflow = HiOverflow = ProdOV;
2266 if (!HiOverflow)
Sanjay Pateld93c4c02016-09-15 18:22:25 +00002267 HiOverflow = subWithOverflow(HiBound, Prod, RangeSize, true);
Sanjay Patel16554142016-08-24 23:03:36 +00002268 }
2269
2270 // Dividing by a negative swaps the condition. LT <-> GT
2271 Pred = ICmpInst::getSwappedPredicate(Pred);
2272 }
2273
Sanjay Patelf7ba0892016-08-26 15:53:01 +00002274 Value *X = Div->getOperand(0);
Sanjay Patel16554142016-08-24 23:03:36 +00002275 switch (Pred) {
2276 default: llvm_unreachable("Unhandled icmp opcode!");
2277 case ICmpInst::ICMP_EQ:
2278 if (LoOverflow && HiOverflow)
Sanjay Patelf7ba0892016-08-26 15:53:01 +00002279 return replaceInstUsesWith(Cmp, Builder->getFalse());
Sanjay Patel16554142016-08-24 23:03:36 +00002280 if (HiOverflow)
2281 return new ICmpInst(DivIsSigned ? ICmpInst::ICMP_SGE :
2282 ICmpInst::ICMP_UGE, X, LoBound);
2283 if (LoOverflow)
2284 return new ICmpInst(DivIsSigned ? ICmpInst::ICMP_SLT :
2285 ICmpInst::ICMP_ULT, X, HiBound);
Sanjay Patel85d79742016-08-31 19:49:56 +00002286 return replaceInstUsesWith(
Sanjay Patel541aef42016-08-31 21:57:21 +00002287 Cmp, insertRangeTest(X, LoBound->getUniqueInteger(),
2288 HiBound->getUniqueInteger(), DivIsSigned, true));
Sanjay Patel16554142016-08-24 23:03:36 +00002289 case ICmpInst::ICMP_NE:
2290 if (LoOverflow && HiOverflow)
Sanjay Patelf7ba0892016-08-26 15:53:01 +00002291 return replaceInstUsesWith(Cmp, Builder->getTrue());
Sanjay Patel16554142016-08-24 23:03:36 +00002292 if (HiOverflow)
2293 return new ICmpInst(DivIsSigned ? ICmpInst::ICMP_SLT :
2294 ICmpInst::ICMP_ULT, X, LoBound);
2295 if (LoOverflow)
2296 return new ICmpInst(DivIsSigned ? ICmpInst::ICMP_SGE :
2297 ICmpInst::ICMP_UGE, X, HiBound);
Sanjay Patel541aef42016-08-31 21:57:21 +00002298 return replaceInstUsesWith(Cmp,
2299 insertRangeTest(X, LoBound->getUniqueInteger(),
2300 HiBound->getUniqueInteger(),
2301 DivIsSigned, false));
Sanjay Patel16554142016-08-24 23:03:36 +00002302 case ICmpInst::ICMP_ULT:
2303 case ICmpInst::ICMP_SLT:
2304 if (LoOverflow == +1) // Low bound is greater than input range.
Sanjay Patelf7ba0892016-08-26 15:53:01 +00002305 return replaceInstUsesWith(Cmp, Builder->getTrue());
Sanjay Patel16554142016-08-24 23:03:36 +00002306 if (LoOverflow == -1) // Low bound is less than input range.
Sanjay Patelf7ba0892016-08-26 15:53:01 +00002307 return replaceInstUsesWith(Cmp, Builder->getFalse());
Sanjay Patel16554142016-08-24 23:03:36 +00002308 return new ICmpInst(Pred, X, LoBound);
2309 case ICmpInst::ICMP_UGT:
2310 case ICmpInst::ICMP_SGT:
2311 if (HiOverflow == +1) // High bound greater than input range.
Sanjay Patelf7ba0892016-08-26 15:53:01 +00002312 return replaceInstUsesWith(Cmp, Builder->getFalse());
Sanjay Patel16554142016-08-24 23:03:36 +00002313 if (HiOverflow == -1) // High bound less than input range.
Sanjay Patelf7ba0892016-08-26 15:53:01 +00002314 return replaceInstUsesWith(Cmp, Builder->getTrue());
Sanjay Patel16554142016-08-24 23:03:36 +00002315 if (Pred == ICmpInst::ICMP_UGT)
2316 return new ICmpInst(ICmpInst::ICMP_UGE, X, HiBound);
2317 return new ICmpInst(ICmpInst::ICMP_SGE, X, HiBound);
2318 }
Sanjay Patela3f4f082016-08-16 17:54:36 +00002319
2320 return nullptr;
2321}
2322
Sanjay Patelb9aa67b2016-08-16 21:26:10 +00002323/// Fold icmp (sub X, Y), C.
Sanjay Patelc9196c42016-08-22 21:24:29 +00002324Instruction *InstCombiner::foldICmpSubConstant(ICmpInst &Cmp,
2325 BinaryOperator *Sub,
Sanjay Patelb9aa67b2016-08-16 21:26:10 +00002326 const APInt *C) {
Sanjay Patel886a5422016-09-15 18:05:17 +00002327 Value *X = Sub->getOperand(0), *Y = Sub->getOperand(1);
2328 ICmpInst::Predicate Pred = Cmp.getPredicate();
2329
2330 // The following transforms are only worth it if the only user of the subtract
2331 // is the icmp.
2332 if (!Sub->hasOneUse())
Sanjay Patela3f4f082016-08-16 17:54:36 +00002333 return nullptr;
2334
Sanjay Patel886a5422016-09-15 18:05:17 +00002335 if (Sub->hasNoSignedWrap()) {
2336 // (icmp sgt (sub nsw X, Y), -1) -> (icmp sge X, Y)
2337 if (Pred == ICmpInst::ICMP_SGT && C->isAllOnesValue())
2338 return new ICmpInst(ICmpInst::ICMP_SGE, X, Y);
Sanjay Patela3f4f082016-08-16 17:54:36 +00002339
Sanjay Patel886a5422016-09-15 18:05:17 +00002340 // (icmp sgt (sub nsw X, Y), 0) -> (icmp sgt X, Y)
2341 if (Pred == ICmpInst::ICMP_SGT && *C == 0)
2342 return new ICmpInst(ICmpInst::ICMP_SGT, X, Y);
2343
2344 // (icmp slt (sub nsw X, Y), 0) -> (icmp slt X, Y)
2345 if (Pred == ICmpInst::ICMP_SLT && *C == 0)
2346 return new ICmpInst(ICmpInst::ICMP_SLT, X, Y);
2347
2348 // (icmp slt (sub nsw X, Y), 1) -> (icmp sle X, Y)
2349 if (Pred == ICmpInst::ICMP_SLT && *C == 1)
2350 return new ICmpInst(ICmpInst::ICMP_SLE, X, Y);
2351 }
2352
2353 const APInt *C2;
2354 if (!match(X, m_APInt(C2)))
2355 return nullptr;
2356
2357 // C2 - Y <u C -> (Y | (C - 1)) == C2
2358 // iff (C2 & (C - 1)) == C - 1 and C is a power of 2
2359 if (Pred == ICmpInst::ICMP_ULT && C->isPowerOf2() &&
2360 (*C2 & (*C - 1)) == (*C - 1))
2361 return new ICmpInst(ICmpInst::ICMP_EQ, Builder->CreateOr(Y, *C - 1), X);
2362
2363 // C2 - Y >u C -> (Y | C) != C2
2364 // iff C2 & C == C and C + 1 is a power of 2
2365 if (Pred == ICmpInst::ICMP_UGT && (*C + 1).isPowerOf2() && (*C2 & *C) == *C)
2366 return new ICmpInst(ICmpInst::ICMP_NE, Builder->CreateOr(Y, *C), X);
Sanjay Patela3f4f082016-08-16 17:54:36 +00002367
2368 return nullptr;
2369}
2370
Sanjay Patel60ea1b42016-08-16 22:34:42 +00002371/// Fold icmp (add X, Y), C.
Sanjay Patelc9196c42016-08-22 21:24:29 +00002372Instruction *InstCombiner::foldICmpAddConstant(ICmpInst &Cmp,
2373 BinaryOperator *Add,
Sanjay Patel60ea1b42016-08-16 22:34:42 +00002374 const APInt *C) {
Sanjay Patel4f7eb2a2016-08-17 15:24:30 +00002375 Value *Y = Add->getOperand(1);
2376 const APInt *C2;
2377 if (Cmp.isEquality() || !match(Y, m_APInt(C2)))
Sanjay Patela3f4f082016-08-16 17:54:36 +00002378 return nullptr;
2379
Sanjay Patel4f7eb2a2016-08-17 15:24:30 +00002380 // Fold icmp pred (add X, C2), C.
Sanjay Patel60ea1b42016-08-16 22:34:42 +00002381 Value *X = Add->getOperand(0);
Sanjay Patel4f7eb2a2016-08-17 15:24:30 +00002382 Type *Ty = Add->getType();
Sanjay Patel6dd2eae2017-02-08 16:19:36 +00002383 CmpInst::Predicate Pred = Cmp.getPredicate();
Sanjay Patel45b7e692017-02-12 16:40:30 +00002384
2385 // If the add does not wrap, we can always adjust the compare by subtracting
2386 // the constants. Equality comparisons are handled elsewhere. SGE/SLE are
2387 // canonicalized to SGT/SLT.
2388 if (Add->hasNoSignedWrap() &&
2389 (Pred == ICmpInst::ICMP_SGT || Pred == ICmpInst::ICMP_SLT)) {
2390 bool Overflow;
2391 APInt NewC = C->ssub_ov(*C2, Overflow);
2392 // If there is overflow, the result must be true or false.
2393 // TODO: Can we assert there is no overflow because InstSimplify always
2394 // handles those cases?
2395 if (!Overflow)
2396 // icmp Pred (add nsw X, C2), C --> icmp Pred X, (C - C2)
2397 return new ICmpInst(Pred, X, ConstantInt::get(Ty, NewC));
2398 }
2399
Sanjay Patel6dd2eae2017-02-08 16:19:36 +00002400 auto CR = ConstantRange::makeExactICmpRegion(Pred, *C).subtract(*C2);
Sanjay Patel60ea1b42016-08-16 22:34:42 +00002401 const APInt &Upper = CR.getUpper();
2402 const APInt &Lower = CR.getLower();
2403 if (Cmp.isSigned()) {
Craig Topperbcfd2d12017-04-20 16:56:25 +00002404 if (Lower.isSignMask())
Sanjay Patel4f7eb2a2016-08-17 15:24:30 +00002405 return new ICmpInst(ICmpInst::ICMP_SLT, X, ConstantInt::get(Ty, Upper));
Craig Topperbcfd2d12017-04-20 16:56:25 +00002406 if (Upper.isSignMask())
Sanjay Patel4f7eb2a2016-08-17 15:24:30 +00002407 return new ICmpInst(ICmpInst::ICMP_SGE, X, ConstantInt::get(Ty, Lower));
Sanjay Patel60ea1b42016-08-16 22:34:42 +00002408 } else {
2409 if (Lower.isMinValue())
Sanjay Patel4f7eb2a2016-08-17 15:24:30 +00002410 return new ICmpInst(ICmpInst::ICMP_ULT, X, ConstantInt::get(Ty, Upper));
Sanjay Patel60ea1b42016-08-16 22:34:42 +00002411 if (Upper.isMinValue())
Sanjay Patel4f7eb2a2016-08-17 15:24:30 +00002412 return new ICmpInst(ICmpInst::ICMP_UGE, X, ConstantInt::get(Ty, Lower));
Sanjay Patel60ea1b42016-08-16 22:34:42 +00002413 }
Sanjay Patela3f4f082016-08-16 17:54:36 +00002414
Sanjay Patel4f7eb2a2016-08-17 15:24:30 +00002415 if (!Add->hasOneUse())
2416 return nullptr;
Sanjay Patela3f4f082016-08-16 17:54:36 +00002417
Sanjay Patel4f7eb2a2016-08-17 15:24:30 +00002418 // X+C <u C2 -> (X & -C2) == C
2419 // iff C & (C2-1) == 0
2420 // C2 is a power of 2
Sanjay Patel6dd2eae2017-02-08 16:19:36 +00002421 if (Pred == ICmpInst::ICMP_ULT && C->isPowerOf2() && (*C2 & (*C - 1)) == 0)
Sanjay Patel4f7eb2a2016-08-17 15:24:30 +00002422 return new ICmpInst(ICmpInst::ICMP_EQ, Builder->CreateAnd(X, -(*C)),
2423 ConstantExpr::getNeg(cast<Constant>(Y)));
2424
2425 // X+C >u C2 -> (X & ~C2) != C
2426 // iff C & C2 == 0
2427 // C2+1 is a power of 2
Sanjay Patel6dd2eae2017-02-08 16:19:36 +00002428 if (Pred == ICmpInst::ICMP_UGT && (*C + 1).isPowerOf2() && (*C2 & *C) == 0)
Sanjay Patel4f7eb2a2016-08-17 15:24:30 +00002429 return new ICmpInst(ICmpInst::ICMP_NE, Builder->CreateAnd(X, ~(*C)),
2430 ConstantExpr::getNeg(cast<Constant>(Y)));
2431
Sanjay Patela3f4f082016-08-16 17:54:36 +00002432 return nullptr;
2433}
2434
Sanjay Patelf58f68c2016-09-10 15:03:44 +00002435/// Try to fold integer comparisons with a constant operand: icmp Pred X, C
2436/// where X is some kind of instruction.
2437Instruction *InstCombiner::foldICmpInstWithConstant(ICmpInst &Cmp) {
Sanjay Patelc9196c42016-08-22 21:24:29 +00002438 const APInt *C;
2439 if (!match(Cmp.getOperand(1), m_APInt(C)))
Sanjay Patel1e5b2d12016-08-16 16:08:11 +00002440 return nullptr;
2441
Sanjay Patelc9196c42016-08-22 21:24:29 +00002442 BinaryOperator *BO;
2443 if (match(Cmp.getOperand(0), m_BinOp(BO))) {
2444 switch (BO->getOpcode()) {
2445 case Instruction::Xor:
2446 if (Instruction *I = foldICmpXorConstant(Cmp, BO, C))
2447 return I;
2448 break;
2449 case Instruction::And:
2450 if (Instruction *I = foldICmpAndConstant(Cmp, BO, C))
2451 return I;
2452 break;
2453 case Instruction::Or:
2454 if (Instruction *I = foldICmpOrConstant(Cmp, BO, C))
2455 return I;
2456 break;
2457 case Instruction::Mul:
2458 if (Instruction *I = foldICmpMulConstant(Cmp, BO, C))
2459 return I;
2460 break;
2461 case Instruction::Shl:
2462 if (Instruction *I = foldICmpShlConstant(Cmp, BO, C))
2463 return I;
2464 break;
2465 case Instruction::LShr:
2466 case Instruction::AShr:
2467 if (Instruction *I = foldICmpShrConstant(Cmp, BO, C))
2468 return I;
2469 break;
2470 case Instruction::UDiv:
2471 if (Instruction *I = foldICmpUDivConstant(Cmp, BO, C))
2472 return I;
2473 LLVM_FALLTHROUGH;
2474 case Instruction::SDiv:
2475 if (Instruction *I = foldICmpDivConstant(Cmp, BO, C))
2476 return I;
2477 break;
2478 case Instruction::Sub:
2479 if (Instruction *I = foldICmpSubConstant(Cmp, BO, C))
2480 return I;
2481 break;
2482 case Instruction::Add:
2483 if (Instruction *I = foldICmpAddConstant(Cmp, BO, C))
2484 return I;
2485 break;
2486 default:
2487 break;
2488 }
Sanjay Patelf58f68c2016-09-10 15:03:44 +00002489 // TODO: These folds could be refactored to be part of the above calls.
2490 if (Instruction *I = foldICmpBinOpEqualityWithConstant(Cmp, BO, C))
2491 return I;
Chris Lattner2188e402010-01-04 07:37:31 +00002492 }
Jim Grosbach129c52a2011-09-30 18:09:53 +00002493
Sanjay Patelc9196c42016-08-22 21:24:29 +00002494 Instruction *LHSI;
2495 if (match(Cmp.getOperand(0), m_Instruction(LHSI)) &&
2496 LHSI->getOpcode() == Instruction::Trunc)
2497 if (Instruction *I = foldICmpTruncConstant(Cmp, LHSI, C))
2498 return I;
2499
Sanjay Patelf58f68c2016-09-10 15:03:44 +00002500 if (Instruction *I = foldICmpIntrinsicWithConstant(Cmp, C))
2501 return I;
2502
Sanjay Patel1710e7c2016-07-21 17:15:49 +00002503 return nullptr;
2504}
Jim Grosbach129c52a2011-09-30 18:09:53 +00002505
Sanjay Patel0a3d72b2016-09-10 15:33:39 +00002506/// Fold an icmp equality instruction with binary operator LHS and constant RHS:
2507/// icmp eq/ne BO, C.
2508Instruction *InstCombiner::foldICmpBinOpEqualityWithConstant(ICmpInst &Cmp,
2509 BinaryOperator *BO,
2510 const APInt *C) {
2511 // TODO: Some of these folds could work with arbitrary constants, but this
2512 // function is limited to scalar and vector splat constants.
2513 if (!Cmp.isEquality())
Sanjay Patel1710e7c2016-07-21 17:15:49 +00002514 return nullptr;
2515
Sanjay Patel0a3d72b2016-09-10 15:33:39 +00002516 ICmpInst::Predicate Pred = Cmp.getPredicate();
2517 bool isICMP_NE = Pred == ICmpInst::ICMP_NE;
2518 Constant *RHS = cast<Constant>(Cmp.getOperand(1));
Sanjay Patel51a767c2016-08-03 17:23:08 +00002519 Value *BOp0 = BO->getOperand(0), *BOp1 = BO->getOperand(1);
Sanjay Patel1710e7c2016-07-21 17:15:49 +00002520
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002521 switch (BO->getOpcode()) {
2522 case Instruction::SRem:
2523 // If we have a signed (X % (2^c)) == 0, turn it into an unsigned one.
Sanjay Patel0a3d72b2016-09-10 15:33:39 +00002524 if (*C == 0 && BO->hasOneUse()) {
Sanjay Patel2e9675f2016-08-03 19:48:40 +00002525 const APInt *BOC;
2526 if (match(BOp1, m_APInt(BOC)) && BOC->sgt(1) && BOC->isPowerOf2()) {
Sanjay Patel51a767c2016-08-03 17:23:08 +00002527 Value *NewRem = Builder->CreateURem(BOp0, BOp1, BO->getName());
Sanjay Patel0a3d72b2016-09-10 15:33:39 +00002528 return new ICmpInst(Pred, NewRem,
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002529 Constant::getNullValue(BO->getType()));
Chris Lattner2188e402010-01-04 07:37:31 +00002530 }
Sanjay Patel1710e7c2016-07-21 17:15:49 +00002531 }
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002532 break;
Sanjay Patel00a324e2016-08-03 22:08:44 +00002533 case Instruction::Add: {
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002534 // Replace ((add A, B) != C) with (A != C-B) if B & C are constants.
Sanjay Patel00a324e2016-08-03 22:08:44 +00002535 const APInt *BOC;
2536 if (match(BOp1, m_APInt(BOC))) {
2537 if (BO->hasOneUse()) {
2538 Constant *SubC = ConstantExpr::getSub(RHS, cast<Constant>(BOp1));
Sanjay Patel0a3d72b2016-09-10 15:33:39 +00002539 return new ICmpInst(Pred, BOp0, SubC);
Sanjay Patel00a324e2016-08-03 22:08:44 +00002540 }
Sanjay Patel0a3d72b2016-09-10 15:33:39 +00002541 } else if (*C == 0) {
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002542 // Replace ((add A, B) != 0) with (A != -B) if A or B is
2543 // efficiently invertible, or if the add has just this one use.
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002544 if (Value *NegVal = dyn_castNegVal(BOp1))
Sanjay Patel0a3d72b2016-09-10 15:33:39 +00002545 return new ICmpInst(Pred, BOp0, NegVal);
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002546 if (Value *NegVal = dyn_castNegVal(BOp0))
Sanjay Patel0a3d72b2016-09-10 15:33:39 +00002547 return new ICmpInst(Pred, NegVal, BOp1);
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002548 if (BO->hasOneUse()) {
2549 Value *Neg = Builder->CreateNeg(BOp1);
2550 Neg->takeName(BO);
Sanjay Patel0a3d72b2016-09-10 15:33:39 +00002551 return new ICmpInst(Pred, BOp0, Neg);
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002552 }
2553 }
2554 break;
Sanjay Patel00a324e2016-08-03 22:08:44 +00002555 }
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002556 case Instruction::Xor:
2557 if (BO->hasOneUse()) {
Sanjay Patel51a767c2016-08-03 17:23:08 +00002558 if (Constant *BOC = dyn_cast<Constant>(BOp1)) {
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002559 // For the xor case, we can xor two constants together, eliminating
2560 // the explicit xor.
Sanjay Patel0a3d72b2016-09-10 15:33:39 +00002561 return new ICmpInst(Pred, BOp0, ConstantExpr::getXor(RHS, BOC));
2562 } else if (*C == 0) {
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002563 // Replace ((xor A, B) != 0) with (A != B)
Sanjay Patel0a3d72b2016-09-10 15:33:39 +00002564 return new ICmpInst(Pred, BOp0, BOp1);
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002565 }
2566 }
2567 break;
2568 case Instruction::Sub:
2569 if (BO->hasOneUse()) {
Sanjay Patel9d591d12016-08-04 15:19:25 +00002570 const APInt *BOC;
2571 if (match(BOp0, m_APInt(BOC))) {
Sanjay Patel362ff5c2016-09-15 17:01:17 +00002572 // Replace ((sub BOC, B) != C) with (B != BOC-C).
Sanjay Patel9d591d12016-08-04 15:19:25 +00002573 Constant *SubC = ConstantExpr::getSub(cast<Constant>(BOp0), RHS);
Sanjay Patel0a3d72b2016-09-10 15:33:39 +00002574 return new ICmpInst(Pred, BOp1, SubC);
2575 } else if (*C == 0) {
Sanjay Patel362ff5c2016-09-15 17:01:17 +00002576 // Replace ((sub A, B) != 0) with (A != B).
Sanjay Patel0a3d72b2016-09-10 15:33:39 +00002577 return new ICmpInst(Pred, BOp0, BOp1);
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002578 }
2579 }
2580 break;
Sanjay Patelb3de75d2016-08-04 19:12:12 +00002581 case Instruction::Or: {
2582 const APInt *BOC;
2583 if (match(BOp1, m_APInt(BOC)) && BO->hasOneUse() && RHS->isAllOnesValue()) {
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002584 // Comparing if all bits outside of a constant mask are set?
2585 // Replace (X | C) == -1 with (X & ~C) == ~C.
2586 // This removes the -1 constant.
Sanjay Patelb3de75d2016-08-04 19:12:12 +00002587 Constant *NotBOC = ConstantExpr::getNot(cast<Constant>(BOp1));
2588 Value *And = Builder->CreateAnd(BOp0, NotBOC);
Sanjay Patel0a3d72b2016-09-10 15:33:39 +00002589 return new ICmpInst(Pred, And, NotBOC);
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002590 }
2591 break;
Sanjay Patelb3de75d2016-08-04 19:12:12 +00002592 }
Sanjay Pateld938e882016-08-04 20:05:02 +00002593 case Instruction::And: {
2594 const APInt *BOC;
2595 if (match(BOp1, m_APInt(BOC))) {
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002596 // If we have ((X & C) == C), turn it into ((X & C) != 0).
Sanjay Patel0a3d72b2016-09-10 15:33:39 +00002597 if (C == BOC && C->isPowerOf2())
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002598 return new ICmpInst(isICMP_NE ? ICmpInst::ICMP_EQ : ICmpInst::ICMP_NE,
Sanjay Patelab50a932016-08-02 22:38:33 +00002599 BO, Constant::getNullValue(RHS->getType()));
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002600
2601 // Don't perform the following transforms if the AND has multiple uses
2602 if (!BO->hasOneUse())
2603 break;
2604
2605 // Replace (and X, (1 << size(X)-1) != 0) with x s< 0
Craig Topperbcfd2d12017-04-20 16:56:25 +00002606 if (BOC->isSignMask()) {
Sanjay Patel51a767c2016-08-03 17:23:08 +00002607 Constant *Zero = Constant::getNullValue(BOp0->getType());
Sanjay Patel0a3d72b2016-09-10 15:33:39 +00002608 auto NewPred = isICMP_NE ? ICmpInst::ICMP_SLT : ICmpInst::ICMP_SGE;
2609 return new ICmpInst(NewPred, BOp0, Zero);
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002610 }
2611
2612 // ((X & ~7) == 0) --> X < 8
Sanjay Patel0a3d72b2016-09-10 15:33:39 +00002613 if (*C == 0 && (~(*BOC) + 1).isPowerOf2()) {
Sanjay Pateld938e882016-08-04 20:05:02 +00002614 Constant *NegBOC = ConstantExpr::getNeg(cast<Constant>(BOp1));
Sanjay Patel0a3d72b2016-09-10 15:33:39 +00002615 auto NewPred = isICMP_NE ? ICmpInst::ICMP_UGE : ICmpInst::ICMP_ULT;
2616 return new ICmpInst(NewPred, BOp0, NegBOC);
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002617 }
2618 }
2619 break;
Sanjay Pateld938e882016-08-04 20:05:02 +00002620 }
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002621 case Instruction::Mul:
Sanjay Patel0a3d72b2016-09-10 15:33:39 +00002622 if (*C == 0 && BO->hasNoSignedWrap()) {
Sanjay Patel3bade132016-08-04 22:19:27 +00002623 const APInt *BOC;
2624 if (match(BOp1, m_APInt(BOC)) && *BOC != 0) {
2625 // The trivial case (mul X, 0) is handled by InstSimplify.
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002626 // General case : (mul X, C) != 0 iff X != 0
2627 // (mul X, C) == 0 iff X == 0
Sanjay Patel0a3d72b2016-09-10 15:33:39 +00002628 return new ICmpInst(Pred, BOp0, Constant::getNullValue(RHS->getType()));
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002629 }
2630 }
2631 break;
Sanjay Patel6ebd5852016-07-23 00:28:39 +00002632 case Instruction::UDiv:
Sanjay Patel0a3d72b2016-09-10 15:33:39 +00002633 if (*C == 0) {
Sanjay Patel6ebd5852016-07-23 00:28:39 +00002634 // (icmp eq/ne (udiv A, B), 0) -> (icmp ugt/ule i32 B, A)
Sanjay Patel0a3d72b2016-09-10 15:33:39 +00002635 auto NewPred = isICMP_NE ? ICmpInst::ICMP_ULE : ICmpInst::ICMP_UGT;
2636 return new ICmpInst(NewPred, BOp1, BOp0);
Sanjay Patel6ebd5852016-07-23 00:28:39 +00002637 }
2638 break;
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002639 default:
2640 break;
2641 }
2642 return nullptr;
2643}
2644
Sanjay Patel0a3d72b2016-09-10 15:33:39 +00002645/// Fold an icmp with LLVM intrinsic and constant operand: icmp Pred II, C.
2646Instruction *InstCombiner::foldICmpIntrinsicWithConstant(ICmpInst &Cmp,
2647 const APInt *C) {
2648 IntrinsicInst *II = dyn_cast<IntrinsicInst>(Cmp.getOperand(0));
2649 if (!II || !Cmp.isEquality())
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002650 return nullptr;
2651
2652 // Handle icmp {eq|ne} <intrinsic>, intcst.
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002653 switch (II->getIntrinsicID()) {
2654 case Intrinsic::bswap:
2655 Worklist.Add(II);
Sanjay Patel0a3d72b2016-09-10 15:33:39 +00002656 Cmp.setOperand(0, II->getArgOperand(0));
2657 Cmp.setOperand(1, Builder->getInt(C->byteSwap()));
2658 return &Cmp;
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002659 case Intrinsic::ctlz:
2660 case Intrinsic::cttz:
Amaury Sechet6bea6742016-08-04 05:27:20 +00002661 // ctz(A) == bitwidth(A) -> A == 0 and likewise for !=
Sanjay Patel0a3d72b2016-09-10 15:33:39 +00002662 if (*C == C->getBitWidth()) {
Sanjay Patel1710e7c2016-07-21 17:15:49 +00002663 Worklist.Add(II);
Sanjay Patel0a3d72b2016-09-10 15:33:39 +00002664 Cmp.setOperand(0, II->getArgOperand(0));
2665 Cmp.setOperand(1, ConstantInt::getNullValue(II->getType()));
2666 return &Cmp;
Chris Lattner2188e402010-01-04 07:37:31 +00002667 }
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002668 break;
Amaury Sechet6bea6742016-08-04 05:27:20 +00002669 case Intrinsic::ctpop: {
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002670 // popcount(A) == 0 -> A == 0 and likewise for !=
Amaury Sechet6bea6742016-08-04 05:27:20 +00002671 // popcount(A) == bitwidth(A) -> A == -1 and likewise for !=
Sanjay Patel0a3d72b2016-09-10 15:33:39 +00002672 bool IsZero = *C == 0;
2673 if (IsZero || *C == C->getBitWidth()) {
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002674 Worklist.Add(II);
Sanjay Patel0a3d72b2016-09-10 15:33:39 +00002675 Cmp.setOperand(0, II->getArgOperand(0));
2676 auto *NewOp = IsZero ? Constant::getNullValue(II->getType())
2677 : Constant::getAllOnesValue(II->getType());
2678 Cmp.setOperand(1, NewOp);
2679 return &Cmp;
Amaury Sechet6bea6742016-08-04 05:27:20 +00002680 }
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002681 break;
Sanjay Patel0a3d72b2016-09-10 15:33:39 +00002682 }
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002683 default:
2684 break;
Chris Lattner2188e402010-01-04 07:37:31 +00002685 }
Craig Topperf40110f2014-04-25 05:29:35 +00002686 return nullptr;
Chris Lattner2188e402010-01-04 07:37:31 +00002687}
2688
Sanjay Patel10494b22016-09-16 16:10:22 +00002689/// Handle icmp with constant (but not simple integer constant) RHS.
2690Instruction *InstCombiner::foldICmpInstWithConstantNotInt(ICmpInst &I) {
2691 Value *Op0 = I.getOperand(0), *Op1 = I.getOperand(1);
2692 Constant *RHSC = dyn_cast<Constant>(Op1);
2693 Instruction *LHSI = dyn_cast<Instruction>(Op0);
2694 if (!RHSC || !LHSI)
2695 return nullptr;
2696
2697 switch (LHSI->getOpcode()) {
2698 case Instruction::GetElementPtr:
2699 // icmp pred GEP (P, int 0, int 0, int 0), null -> icmp pred P, null
2700 if (RHSC->isNullValue() &&
2701 cast<GetElementPtrInst>(LHSI)->hasAllZeroIndices())
2702 return new ICmpInst(
2703 I.getPredicate(), LHSI->getOperand(0),
2704 Constant::getNullValue(LHSI->getOperand(0)->getType()));
2705 break;
2706 case Instruction::PHI:
2707 // Only fold icmp into the PHI if the phi and icmp are in the same
2708 // block. If in the same block, we're encouraging jump threading. If
2709 // not, we are just pessimizing the code by making an i1 phi.
2710 if (LHSI->getParent() == I.getParent())
Craig Topperfb71b7d2017-04-14 19:20:12 +00002711 if (Instruction *NV = foldOpIntoPhi(I, cast<PHINode>(LHSI)))
Sanjay Patel10494b22016-09-16 16:10:22 +00002712 return NV;
2713 break;
2714 case Instruction::Select: {
2715 // If either operand of the select is a constant, we can fold the
2716 // comparison into the select arms, which will cause one to be
2717 // constant folded and the select turned into a bitwise or.
2718 Value *Op1 = nullptr, *Op2 = nullptr;
2719 ConstantInt *CI = nullptr;
2720 if (Constant *C = dyn_cast<Constant>(LHSI->getOperand(1))) {
2721 Op1 = ConstantExpr::getICmp(I.getPredicate(), C, RHSC);
2722 CI = dyn_cast<ConstantInt>(Op1);
2723 }
2724 if (Constant *C = dyn_cast<Constant>(LHSI->getOperand(2))) {
2725 Op2 = ConstantExpr::getICmp(I.getPredicate(), C, RHSC);
2726 CI = dyn_cast<ConstantInt>(Op2);
2727 }
2728
2729 // We only want to perform this transformation if it will not lead to
2730 // additional code. This is true if either both sides of the select
2731 // fold to a constant (in which case the icmp is replaced with a select
2732 // which will usually simplify) or this is the only user of the
2733 // select (in which case we are trading a select+icmp for a simpler
2734 // select+icmp) or all uses of the select can be replaced based on
2735 // dominance information ("Global cases").
2736 bool Transform = false;
2737 if (Op1 && Op2)
2738 Transform = true;
2739 else if (Op1 || Op2) {
2740 // Local case
2741 if (LHSI->hasOneUse())
2742 Transform = true;
2743 // Global cases
2744 else if (CI && !CI->isZero())
2745 // When Op1 is constant try replacing select with second operand.
2746 // Otherwise Op2 is constant and try replacing select with first
2747 // operand.
2748 Transform =
2749 replacedSelectWithOperand(cast<SelectInst>(LHSI), &I, Op1 ? 2 : 1);
2750 }
2751 if (Transform) {
2752 if (!Op1)
2753 Op1 = Builder->CreateICmp(I.getPredicate(), LHSI->getOperand(1), RHSC,
2754 I.getName());
2755 if (!Op2)
2756 Op2 = Builder->CreateICmp(I.getPredicate(), LHSI->getOperand(2), RHSC,
2757 I.getName());
2758 return SelectInst::Create(LHSI->getOperand(0), Op1, Op2);
2759 }
2760 break;
2761 }
2762 case Instruction::IntToPtr:
2763 // icmp pred inttoptr(X), null -> icmp pred X, 0
2764 if (RHSC->isNullValue() &&
2765 DL.getIntPtrType(RHSC->getType()) == LHSI->getOperand(0)->getType())
2766 return new ICmpInst(
2767 I.getPredicate(), LHSI->getOperand(0),
2768 Constant::getNullValue(LHSI->getOperand(0)->getType()));
2769 break;
2770
2771 case Instruction::Load:
2772 // Try to optimize things like "A[i] > 4" to index computations.
2773 if (GetElementPtrInst *GEP =
2774 dyn_cast<GetElementPtrInst>(LHSI->getOperand(0))) {
2775 if (GlobalVariable *GV = dyn_cast<GlobalVariable>(GEP->getOperand(0)))
2776 if (GV->isConstant() && GV->hasDefinitiveInitializer() &&
2777 !cast<LoadInst>(LHSI)->isVolatile())
2778 if (Instruction *Res = foldCmpLoadFromIndexedGlobal(GEP, GV, I))
2779 return Res;
2780 }
2781 break;
2782 }
2783
2784 return nullptr;
2785}
2786
2787/// Try to fold icmp (binop), X or icmp X, (binop).
Sanjay Patel2df38a82017-05-08 16:21:55 +00002788/// TODO: A large part of this logic is duplicated in InstSimplify's
2789/// simplifyICmpWithBinOp(). We should be able to share that and avoid the code
2790/// duplication.
Sanjay Patel10494b22016-09-16 16:10:22 +00002791Instruction *InstCombiner::foldICmpBinOp(ICmpInst &I) {
2792 Value *Op0 = I.getOperand(0), *Op1 = I.getOperand(1);
2793
2794 // Special logic for binary operators.
2795 BinaryOperator *BO0 = dyn_cast<BinaryOperator>(Op0);
2796 BinaryOperator *BO1 = dyn_cast<BinaryOperator>(Op1);
2797 if (!BO0 && !BO1)
2798 return nullptr;
2799
Sanjay Patel2a062632017-05-08 16:33:42 +00002800 const CmpInst::Predicate Pred = I.getPredicate();
Sanjay Patel10494b22016-09-16 16:10:22 +00002801 bool NoOp0WrapProblem = false, NoOp1WrapProblem = false;
2802 if (BO0 && isa<OverflowingBinaryOperator>(BO0))
2803 NoOp0WrapProblem =
2804 ICmpInst::isEquality(Pred) ||
2805 (CmpInst::isUnsigned(Pred) && BO0->hasNoUnsignedWrap()) ||
2806 (CmpInst::isSigned(Pred) && BO0->hasNoSignedWrap());
2807 if (BO1 && isa<OverflowingBinaryOperator>(BO1))
2808 NoOp1WrapProblem =
2809 ICmpInst::isEquality(Pred) ||
2810 (CmpInst::isUnsigned(Pred) && BO1->hasNoUnsignedWrap()) ||
2811 (CmpInst::isSigned(Pred) && BO1->hasNoSignedWrap());
2812
2813 // Analyze the case when either Op0 or Op1 is an add instruction.
2814 // Op0 = A + B (or A and B are null); Op1 = C + D (or C and D are null).
2815 Value *A = nullptr, *B = nullptr, *C = nullptr, *D = nullptr;
2816 if (BO0 && BO0->getOpcode() == Instruction::Add) {
2817 A = BO0->getOperand(0);
2818 B = BO0->getOperand(1);
2819 }
2820 if (BO1 && BO1->getOpcode() == Instruction::Add) {
2821 C = BO1->getOperand(0);
2822 D = BO1->getOperand(1);
2823 }
2824
Sanjay Patel10494b22016-09-16 16:10:22 +00002825 // icmp (X+Y), X -> icmp Y, 0 for equalities or if there is no overflow.
2826 if ((A == Op1 || B == Op1) && NoOp0WrapProblem)
2827 return new ICmpInst(Pred, A == Op1 ? B : A,
2828 Constant::getNullValue(Op1->getType()));
2829
2830 // icmp X, (X+Y) -> icmp 0, Y for equalities or if there is no overflow.
2831 if ((C == Op0 || D == Op0) && NoOp1WrapProblem)
2832 return new ICmpInst(Pred, Constant::getNullValue(Op0->getType()),
2833 C == Op0 ? D : C);
2834
2835 // icmp (X+Y), (X+Z) -> icmp Y, Z for equalities or if there is no overflow.
2836 if (A && C && (A == C || A == D || B == C || B == D) && NoOp0WrapProblem &&
2837 NoOp1WrapProblem &&
2838 // Try not to increase register pressure.
2839 BO0->hasOneUse() && BO1->hasOneUse()) {
2840 // Determine Y and Z in the form icmp (X+Y), (X+Z).
2841 Value *Y, *Z;
2842 if (A == C) {
2843 // C + B == C + D -> B == D
2844 Y = B;
2845 Z = D;
2846 } else if (A == D) {
2847 // D + B == C + D -> B == C
2848 Y = B;
2849 Z = C;
2850 } else if (B == C) {
2851 // A + C == C + D -> A == D
2852 Y = A;
2853 Z = D;
2854 } else {
2855 assert(B == D);
2856 // A + D == C + D -> A == C
2857 Y = A;
2858 Z = C;
2859 }
2860 return new ICmpInst(Pred, Y, Z);
2861 }
2862
2863 // icmp slt (X + -1), Y -> icmp sle X, Y
2864 if (A && NoOp0WrapProblem && Pred == CmpInst::ICMP_SLT &&
2865 match(B, m_AllOnes()))
2866 return new ICmpInst(CmpInst::ICMP_SLE, A, Op1);
2867
2868 // icmp sge (X + -1), Y -> icmp sgt X, Y
2869 if (A && NoOp0WrapProblem && Pred == CmpInst::ICMP_SGE &&
2870 match(B, m_AllOnes()))
2871 return new ICmpInst(CmpInst::ICMP_SGT, A, Op1);
2872
2873 // icmp sle (X + 1), Y -> icmp slt X, Y
2874 if (A && NoOp0WrapProblem && Pred == CmpInst::ICMP_SLE && match(B, m_One()))
2875 return new ICmpInst(CmpInst::ICMP_SLT, A, Op1);
2876
2877 // icmp sgt (X + 1), Y -> icmp sge X, Y
2878 if (A && NoOp0WrapProblem && Pred == CmpInst::ICMP_SGT && match(B, m_One()))
2879 return new ICmpInst(CmpInst::ICMP_SGE, A, Op1);
2880
2881 // icmp sgt X, (Y + -1) -> icmp sge X, Y
2882 if (C && NoOp1WrapProblem && Pred == CmpInst::ICMP_SGT &&
2883 match(D, m_AllOnes()))
2884 return new ICmpInst(CmpInst::ICMP_SGE, Op0, C);
2885
2886 // icmp sle X, (Y + -1) -> icmp slt X, Y
2887 if (C && NoOp1WrapProblem && Pred == CmpInst::ICMP_SLE &&
2888 match(D, m_AllOnes()))
2889 return new ICmpInst(CmpInst::ICMP_SLT, Op0, C);
2890
2891 // icmp sge X, (Y + 1) -> icmp sgt X, Y
2892 if (C && NoOp1WrapProblem && Pred == CmpInst::ICMP_SGE && match(D, m_One()))
2893 return new ICmpInst(CmpInst::ICMP_SGT, Op0, C);
2894
2895 // icmp slt X, (Y + 1) -> icmp sle X, Y
2896 if (C && NoOp1WrapProblem && Pred == CmpInst::ICMP_SLT && match(D, m_One()))
2897 return new ICmpInst(CmpInst::ICMP_SLE, Op0, C);
2898
Sanjay Patel40f40172017-01-13 23:25:46 +00002899 // TODO: The subtraction-related identities shown below also hold, but
2900 // canonicalization from (X -nuw 1) to (X + -1) means that the combinations
2901 // wouldn't happen even if they were implemented.
2902 //
2903 // icmp ult (X - 1), Y -> icmp ule X, Y
2904 // icmp uge (X - 1), Y -> icmp ugt X, Y
2905 // icmp ugt X, (Y - 1) -> icmp uge X, Y
2906 // icmp ule X, (Y - 1) -> icmp ult X, Y
2907
2908 // icmp ule (X + 1), Y -> icmp ult X, Y
2909 if (A && NoOp0WrapProblem && Pred == CmpInst::ICMP_ULE && match(B, m_One()))
2910 return new ICmpInst(CmpInst::ICMP_ULT, A, Op1);
2911
2912 // icmp ugt (X + 1), Y -> icmp uge X, Y
2913 if (A && NoOp0WrapProblem && Pred == CmpInst::ICMP_UGT && match(B, m_One()))
2914 return new ICmpInst(CmpInst::ICMP_UGE, A, Op1);
2915
2916 // icmp uge X, (Y + 1) -> icmp ugt X, Y
2917 if (C && NoOp1WrapProblem && Pred == CmpInst::ICMP_UGE && match(D, m_One()))
2918 return new ICmpInst(CmpInst::ICMP_UGT, Op0, C);
2919
2920 // icmp ult X, (Y + 1) -> icmp ule X, Y
2921 if (C && NoOp1WrapProblem && Pred == CmpInst::ICMP_ULT && match(D, m_One()))
2922 return new ICmpInst(CmpInst::ICMP_ULE, Op0, C);
2923
Sanjay Patel10494b22016-09-16 16:10:22 +00002924 // if C1 has greater magnitude than C2:
2925 // icmp (X + C1), (Y + C2) -> icmp (X + C3), Y
2926 // s.t. C3 = C1 - C2
2927 //
2928 // if C2 has greater magnitude than C1:
2929 // icmp (X + C1), (Y + C2) -> icmp X, (Y + C3)
2930 // s.t. C3 = C2 - C1
2931 if (A && C && NoOp0WrapProblem && NoOp1WrapProblem &&
2932 (BO0->hasOneUse() || BO1->hasOneUse()) && !I.isUnsigned())
2933 if (ConstantInt *C1 = dyn_cast<ConstantInt>(B))
2934 if (ConstantInt *C2 = dyn_cast<ConstantInt>(D)) {
2935 const APInt &AP1 = C1->getValue();
2936 const APInt &AP2 = C2->getValue();
2937 if (AP1.isNegative() == AP2.isNegative()) {
2938 APInt AP1Abs = C1->getValue().abs();
2939 APInt AP2Abs = C2->getValue().abs();
2940 if (AP1Abs.uge(AP2Abs)) {
2941 ConstantInt *C3 = Builder->getInt(AP1 - AP2);
2942 Value *NewAdd = Builder->CreateNSWAdd(A, C3);
2943 return new ICmpInst(Pred, NewAdd, C);
2944 } else {
2945 ConstantInt *C3 = Builder->getInt(AP2 - AP1);
2946 Value *NewAdd = Builder->CreateNSWAdd(C, C3);
2947 return new ICmpInst(Pred, A, NewAdd);
2948 }
2949 }
2950 }
2951
2952 // Analyze the case when either Op0 or Op1 is a sub instruction.
2953 // Op0 = A - B (or A and B are null); Op1 = C - D (or C and D are null).
2954 A = nullptr;
2955 B = nullptr;
2956 C = nullptr;
2957 D = nullptr;
2958 if (BO0 && BO0->getOpcode() == Instruction::Sub) {
2959 A = BO0->getOperand(0);
2960 B = BO0->getOperand(1);
2961 }
2962 if (BO1 && BO1->getOpcode() == Instruction::Sub) {
2963 C = BO1->getOperand(0);
2964 D = BO1->getOperand(1);
2965 }
2966
2967 // icmp (X-Y), X -> icmp 0, Y for equalities or if there is no overflow.
2968 if (A == Op1 && NoOp0WrapProblem)
2969 return new ICmpInst(Pred, Constant::getNullValue(Op1->getType()), B);
2970
2971 // icmp X, (X-Y) -> icmp Y, 0 for equalities or if there is no overflow.
2972 if (C == Op0 && NoOp1WrapProblem)
2973 return new ICmpInst(Pred, D, Constant::getNullValue(Op0->getType()));
2974
2975 // icmp (Y-X), (Z-X) -> icmp Y, Z for equalities or if there is no overflow.
2976 if (B && D && B == D && NoOp0WrapProblem && NoOp1WrapProblem &&
2977 // Try not to increase register pressure.
2978 BO0->hasOneUse() && BO1->hasOneUse())
2979 return new ICmpInst(Pred, A, C);
2980
2981 // icmp (X-Y), (X-Z) -> icmp Z, Y for equalities or if there is no overflow.
2982 if (A && C && A == C && NoOp0WrapProblem && NoOp1WrapProblem &&
2983 // Try not to increase register pressure.
2984 BO0->hasOneUse() && BO1->hasOneUse())
2985 return new ICmpInst(Pred, D, B);
2986
2987 // icmp (0-X) < cst --> x > -cst
2988 if (NoOp0WrapProblem && ICmpInst::isSigned(Pred)) {
2989 Value *X;
2990 if (match(BO0, m_Neg(m_Value(X))))
2991 if (ConstantInt *RHSC = dyn_cast<ConstantInt>(Op1))
2992 if (!RHSC->isMinValue(/*isSigned=*/true))
2993 return new ICmpInst(I.getSwappedPredicate(), X,
2994 ConstantExpr::getNeg(RHSC));
2995 }
2996
2997 BinaryOperator *SRem = nullptr;
2998 // icmp (srem X, Y), Y
2999 if (BO0 && BO0->getOpcode() == Instruction::SRem && Op1 == BO0->getOperand(1))
3000 SRem = BO0;
3001 // icmp Y, (srem X, Y)
3002 else if (BO1 && BO1->getOpcode() == Instruction::SRem &&
3003 Op0 == BO1->getOperand(1))
3004 SRem = BO1;
3005 if (SRem) {
3006 // We don't check hasOneUse to avoid increasing register pressure because
3007 // the value we use is the same value this instruction was already using.
3008 switch (SRem == BO0 ? ICmpInst::getSwappedPredicate(Pred) : Pred) {
3009 default:
3010 break;
3011 case ICmpInst::ICMP_EQ:
3012 return replaceInstUsesWith(I, ConstantInt::getFalse(I.getType()));
3013 case ICmpInst::ICMP_NE:
3014 return replaceInstUsesWith(I, ConstantInt::getTrue(I.getType()));
3015 case ICmpInst::ICMP_SGT:
3016 case ICmpInst::ICMP_SGE:
3017 return new ICmpInst(ICmpInst::ICMP_SGT, SRem->getOperand(1),
3018 Constant::getAllOnesValue(SRem->getType()));
3019 case ICmpInst::ICMP_SLT:
3020 case ICmpInst::ICMP_SLE:
3021 return new ICmpInst(ICmpInst::ICMP_SLT, SRem->getOperand(1),
3022 Constant::getNullValue(SRem->getType()));
3023 }
3024 }
3025
3026 if (BO0 && BO1 && BO0->getOpcode() == BO1->getOpcode() && BO0->hasOneUse() &&
3027 BO1->hasOneUse() && BO0->getOperand(1) == BO1->getOperand(1)) {
3028 switch (BO0->getOpcode()) {
3029 default:
3030 break;
3031 case Instruction::Add:
3032 case Instruction::Sub:
3033 case Instruction::Xor:
3034 if (I.isEquality()) // a+x icmp eq/ne b+x --> a icmp b
Sanjay Patel2a062632017-05-08 16:33:42 +00003035 return new ICmpInst(Pred, BO0->getOperand(0), BO1->getOperand(0));
Craig Topperbcfd2d12017-04-20 16:56:25 +00003036 // icmp u/s (a ^ signmask), (b ^ signmask) --> icmp s/u a, b
Sanjay Patel10494b22016-09-16 16:10:22 +00003037 if (ConstantInt *CI = dyn_cast<ConstantInt>(BO0->getOperand(1))) {
Craig Topperbcfd2d12017-04-20 16:56:25 +00003038 if (CI->getValue().isSignMask()) {
Sanjay Patel2a062632017-05-08 16:33:42 +00003039 ICmpInst::Predicate NewPred =
Sanjay Patel10494b22016-09-16 16:10:22 +00003040 I.isSigned() ? I.getUnsignedPredicate() : I.getSignedPredicate();
Sanjay Patel2a062632017-05-08 16:33:42 +00003041 return new ICmpInst(NewPred, BO0->getOperand(0), BO1->getOperand(0));
Sanjay Patel10494b22016-09-16 16:10:22 +00003042 }
3043
3044 if (BO0->getOpcode() == Instruction::Xor && CI->isMaxValue(true)) {
Sanjay Patel2a062632017-05-08 16:33:42 +00003045 ICmpInst::Predicate NewPred =
Sanjay Patel10494b22016-09-16 16:10:22 +00003046 I.isSigned() ? I.getUnsignedPredicate() : I.getSignedPredicate();
Sanjay Patel2a062632017-05-08 16:33:42 +00003047 NewPred = I.getSwappedPredicate(NewPred);
3048 return new ICmpInst(NewPred, BO0->getOperand(0), BO1->getOperand(0));
Sanjay Patel10494b22016-09-16 16:10:22 +00003049 }
3050 }
3051 break;
3052 case Instruction::Mul:
3053 if (!I.isEquality())
3054 break;
3055
3056 if (ConstantInt *CI = dyn_cast<ConstantInt>(BO0->getOperand(1))) {
3057 // a * Cst icmp eq/ne b * Cst --> a & Mask icmp b & Mask
3058 // Mask = -1 >> count-trailing-zeros(Cst).
3059 if (!CI->isZero() && !CI->isOne()) {
3060 const APInt &AP = CI->getValue();
3061 ConstantInt *Mask = ConstantInt::get(
3062 I.getContext(),
3063 APInt::getLowBitsSet(AP.getBitWidth(),
3064 AP.getBitWidth() - AP.countTrailingZeros()));
3065 Value *And1 = Builder->CreateAnd(BO0->getOperand(0), Mask);
3066 Value *And2 = Builder->CreateAnd(BO1->getOperand(0), Mask);
Sanjay Patel2a062632017-05-08 16:33:42 +00003067 return new ICmpInst(Pred, And1, And2);
Sanjay Patel10494b22016-09-16 16:10:22 +00003068 }
3069 }
3070 break;
Sanjay Patel878715f2017-05-15 19:27:53 +00003071
Sanjay Patel10494b22016-09-16 16:10:22 +00003072 case Instruction::UDiv:
3073 case Instruction::LShr:
Sanjay Patel878715f2017-05-15 19:27:53 +00003074 if (I.isSigned() || !BO0->isExact() || !BO1->isExact())
Sanjay Patel10494b22016-09-16 16:10:22 +00003075 break;
Sanjay Patel878715f2017-05-15 19:27:53 +00003076 return new ICmpInst(Pred, BO0->getOperand(0), BO1->getOperand(0));
3077
Sanjay Patel10494b22016-09-16 16:10:22 +00003078 case Instruction::SDiv:
Sanjay Patel878715f2017-05-15 19:27:53 +00003079 if (!I.isEquality() || !BO0->isExact() || !BO1->isExact())
3080 break;
3081 return new ICmpInst(Pred, BO0->getOperand(0), BO1->getOperand(0));
3082
Sanjay Patel10494b22016-09-16 16:10:22 +00003083 case Instruction::AShr:
3084 if (!BO0->isExact() || !BO1->isExact())
3085 break;
Sanjay Patel2a062632017-05-08 16:33:42 +00003086 return new ICmpInst(Pred, BO0->getOperand(0), BO1->getOperand(0));
Sanjay Patel878715f2017-05-15 19:27:53 +00003087
Sanjay Patel10494b22016-09-16 16:10:22 +00003088 case Instruction::Shl: {
3089 bool NUW = BO0->hasNoUnsignedWrap() && BO1->hasNoUnsignedWrap();
3090 bool NSW = BO0->hasNoSignedWrap() && BO1->hasNoSignedWrap();
3091 if (!NUW && !NSW)
3092 break;
3093 if (!NSW && I.isSigned())
3094 break;
Sanjay Patel2a062632017-05-08 16:33:42 +00003095 return new ICmpInst(Pred, BO0->getOperand(0), BO1->getOperand(0));
Sanjay Patel10494b22016-09-16 16:10:22 +00003096 }
3097 }
3098 }
3099
3100 if (BO0) {
3101 // Transform A & (L - 1) `ult` L --> L != 0
3102 auto LSubOne = m_Add(m_Specific(Op1), m_AllOnes());
3103 auto BitwiseAnd =
3104 m_CombineOr(m_And(m_Value(), LSubOne), m_And(LSubOne, m_Value()));
3105
Sanjay Patel2a062632017-05-08 16:33:42 +00003106 if (match(BO0, BitwiseAnd) && Pred == ICmpInst::ICMP_ULT) {
Sanjay Patel10494b22016-09-16 16:10:22 +00003107 auto *Zero = Constant::getNullValue(BO0->getType());
3108 return new ICmpInst(ICmpInst::ICMP_NE, Op1, Zero);
3109 }
3110 }
3111
3112 return nullptr;
3113}
3114
Sanjay Pateldd46b522016-12-19 17:32:37 +00003115/// Fold icmp Pred min|max(X, Y), X.
3116static Instruction *foldICmpWithMinMax(ICmpInst &Cmp) {
Sanjay Pateld6406412016-12-15 19:13:37 +00003117 ICmpInst::Predicate Pred = Cmp.getPredicate();
3118 Value *Op0 = Cmp.getOperand(0);
3119 Value *X = Cmp.getOperand(1);
3120
Sanjay Pateldd46b522016-12-19 17:32:37 +00003121 // Canonicalize minimum or maximum operand to LHS of the icmp.
Sanjay Patel8296c6c2016-12-19 16:28:53 +00003122 if (match(X, m_c_SMin(m_Specific(Op0), m_Value())) ||
Sanjay Pateldd46b522016-12-19 17:32:37 +00003123 match(X, m_c_SMax(m_Specific(Op0), m_Value())) ||
3124 match(X, m_c_UMin(m_Specific(Op0), m_Value())) ||
3125 match(X, m_c_UMax(m_Specific(Op0), m_Value()))) {
Sanjay Pateld6406412016-12-15 19:13:37 +00003126 std::swap(Op0, X);
3127 Pred = Cmp.getSwappedPredicate();
3128 }
3129
3130 Value *Y;
Sanjay Patel8296c6c2016-12-19 16:28:53 +00003131 if (match(Op0, m_c_SMin(m_Specific(X), m_Value(Y)))) {
Sanjay Pateldd46b522016-12-19 17:32:37 +00003132 // smin(X, Y) == X --> X s<= Y
3133 // smin(X, Y) s>= X --> X s<= Y
Sanjay Patel8296c6c2016-12-19 16:28:53 +00003134 if (Pred == CmpInst::ICMP_EQ || Pred == CmpInst::ICMP_SGE)
3135 return new ICmpInst(ICmpInst::ICMP_SLE, X, Y);
3136
Sanjay Pateldd46b522016-12-19 17:32:37 +00003137 // smin(X, Y) != X --> X s> Y
3138 // smin(X, Y) s< X --> X s> Y
Sanjay Patel8296c6c2016-12-19 16:28:53 +00003139 if (Pred == CmpInst::ICMP_NE || Pred == CmpInst::ICMP_SLT)
3140 return new ICmpInst(ICmpInst::ICMP_SGT, X, Y);
3141
3142 // These cases should be handled in InstSimplify:
Sanjay Pateldd46b522016-12-19 17:32:37 +00003143 // smin(X, Y) s<= X --> true
3144 // smin(X, Y) s> X --> false
Sanjay Pateld6406412016-12-15 19:13:37 +00003145 return nullptr;
Sanjay Patel8296c6c2016-12-19 16:28:53 +00003146 }
Sanjay Pateldd46b522016-12-19 17:32:37 +00003147
Sanjay Patel8296c6c2016-12-19 16:28:53 +00003148 if (match(Op0, m_c_SMax(m_Specific(X), m_Value(Y)))) {
Sanjay Pateldd46b522016-12-19 17:32:37 +00003149 // smax(X, Y) == X --> X s>= Y
3150 // smax(X, Y) s<= X --> X s>= Y
Sanjay Patel8296c6c2016-12-19 16:28:53 +00003151 if (Pred == CmpInst::ICMP_EQ || Pred == CmpInst::ICMP_SLE)
3152 return new ICmpInst(ICmpInst::ICMP_SGE, X, Y);
Sanjay Pateld6406412016-12-15 19:13:37 +00003153
Sanjay Pateldd46b522016-12-19 17:32:37 +00003154 // smax(X, Y) != X --> X s< Y
3155 // smax(X, Y) s> X --> X s< Y
Sanjay Patel8296c6c2016-12-19 16:28:53 +00003156 if (Pred == CmpInst::ICMP_NE || Pred == CmpInst::ICMP_SGT)
3157 return new ICmpInst(ICmpInst::ICMP_SLT, X, Y);
Sanjay Pateld6406412016-12-15 19:13:37 +00003158
Sanjay Patel8296c6c2016-12-19 16:28:53 +00003159 // These cases should be handled in InstSimplify:
Sanjay Pateldd46b522016-12-19 17:32:37 +00003160 // smax(X, Y) s>= X --> true
3161 // smax(X, Y) s< X --> false
3162 return nullptr;
3163 }
3164
3165 if (match(Op0, m_c_UMin(m_Specific(X), m_Value(Y)))) {
3166 // umin(X, Y) == X --> X u<= Y
3167 // umin(X, Y) u>= X --> X u<= Y
3168 if (Pred == CmpInst::ICMP_EQ || Pred == CmpInst::ICMP_UGE)
3169 return new ICmpInst(ICmpInst::ICMP_ULE, X, Y);
3170
3171 // umin(X, Y) != X --> X u> Y
3172 // umin(X, Y) u< X --> X u> Y
3173 if (Pred == CmpInst::ICMP_NE || Pred == CmpInst::ICMP_ULT)
3174 return new ICmpInst(ICmpInst::ICMP_UGT, X, Y);
3175
3176 // These cases should be handled in InstSimplify:
3177 // umin(X, Y) u<= X --> true
3178 // umin(X, Y) u> X --> false
3179 return nullptr;
3180 }
3181
3182 if (match(Op0, m_c_UMax(m_Specific(X), m_Value(Y)))) {
3183 // umax(X, Y) == X --> X u>= Y
3184 // umax(X, Y) u<= X --> X u>= Y
3185 if (Pred == CmpInst::ICMP_EQ || Pred == CmpInst::ICMP_ULE)
3186 return new ICmpInst(ICmpInst::ICMP_UGE, X, Y);
3187
3188 // umax(X, Y) != X --> X u< Y
3189 // umax(X, Y) u> X --> X u< Y
3190 if (Pred == CmpInst::ICMP_NE || Pred == CmpInst::ICMP_UGT)
3191 return new ICmpInst(ICmpInst::ICMP_ULT, X, Y);
3192
3193 // These cases should be handled in InstSimplify:
3194 // umax(X, Y) u>= X --> true
3195 // umax(X, Y) u< X --> false
Sanjay Patel8296c6c2016-12-19 16:28:53 +00003196 return nullptr;
3197 }
Sanjay Pateld6406412016-12-15 19:13:37 +00003198
Sanjay Pateld6406412016-12-15 19:13:37 +00003199 return nullptr;
3200}
3201
Sanjay Patel10494b22016-09-16 16:10:22 +00003202Instruction *InstCombiner::foldICmpEquality(ICmpInst &I) {
3203 if (!I.isEquality())
3204 return nullptr;
3205
3206 Value *Op0 = I.getOperand(0), *Op1 = I.getOperand(1);
3207 Value *A, *B, *C, *D;
3208 if (match(Op0, m_Xor(m_Value(A), m_Value(B)))) {
3209 if (A == Op1 || B == Op1) { // (A^B) == A -> B == 0
3210 Value *OtherVal = A == Op1 ? B : A;
3211 return new ICmpInst(I.getPredicate(), OtherVal,
3212 Constant::getNullValue(A->getType()));
3213 }
3214
3215 if (match(Op1, m_Xor(m_Value(C), m_Value(D)))) {
3216 // A^c1 == C^c2 --> A == C^(c1^c2)
3217 ConstantInt *C1, *C2;
3218 if (match(B, m_ConstantInt(C1)) && match(D, m_ConstantInt(C2)) &&
3219 Op1->hasOneUse()) {
3220 Constant *NC = Builder->getInt(C1->getValue() ^ C2->getValue());
3221 Value *Xor = Builder->CreateXor(C, NC);
3222 return new ICmpInst(I.getPredicate(), A, Xor);
3223 }
3224
3225 // A^B == A^D -> B == D
3226 if (A == C)
3227 return new ICmpInst(I.getPredicate(), B, D);
3228 if (A == D)
3229 return new ICmpInst(I.getPredicate(), B, C);
3230 if (B == C)
3231 return new ICmpInst(I.getPredicate(), A, D);
3232 if (B == D)
3233 return new ICmpInst(I.getPredicate(), A, C);
3234 }
3235 }
3236
3237 if (match(Op1, m_Xor(m_Value(A), m_Value(B))) && (A == Op0 || B == Op0)) {
3238 // A == (A^B) -> B == 0
3239 Value *OtherVal = A == Op0 ? B : A;
3240 return new ICmpInst(I.getPredicate(), OtherVal,
3241 Constant::getNullValue(A->getType()));
3242 }
3243
3244 // (X&Z) == (Y&Z) -> (X^Y) & Z == 0
3245 if (match(Op0, m_OneUse(m_And(m_Value(A), m_Value(B)))) &&
3246 match(Op1, m_OneUse(m_And(m_Value(C), m_Value(D))))) {
3247 Value *X = nullptr, *Y = nullptr, *Z = nullptr;
3248
3249 if (A == C) {
3250 X = B;
3251 Y = D;
3252 Z = A;
3253 } else if (A == D) {
3254 X = B;
3255 Y = C;
3256 Z = A;
3257 } else if (B == C) {
3258 X = A;
3259 Y = D;
3260 Z = B;
3261 } else if (B == D) {
3262 X = A;
3263 Y = C;
3264 Z = B;
3265 }
3266
3267 if (X) { // Build (X^Y) & Z
3268 Op1 = Builder->CreateXor(X, Y);
3269 Op1 = Builder->CreateAnd(Op1, Z);
3270 I.setOperand(0, Op1);
3271 I.setOperand(1, Constant::getNullValue(Op1->getType()));
3272 return &I;
3273 }
3274 }
3275
3276 // Transform (zext A) == (B & (1<<X)-1) --> A == (trunc B)
3277 // and (B & (1<<X)-1) == (zext A) --> A == (trunc B)
3278 ConstantInt *Cst1;
3279 if ((Op0->hasOneUse() && match(Op0, m_ZExt(m_Value(A))) &&
3280 match(Op1, m_And(m_Value(B), m_ConstantInt(Cst1)))) ||
3281 (Op1->hasOneUse() && match(Op0, m_And(m_Value(B), m_ConstantInt(Cst1))) &&
3282 match(Op1, m_ZExt(m_Value(A))))) {
3283 APInt Pow2 = Cst1->getValue() + 1;
3284 if (Pow2.isPowerOf2() && isa<IntegerType>(A->getType()) &&
3285 Pow2.logBase2() == cast<IntegerType>(A->getType())->getBitWidth())
3286 return new ICmpInst(I.getPredicate(), A,
3287 Builder->CreateTrunc(B, A->getType()));
3288 }
3289
3290 // (A >> C) == (B >> C) --> (A^B) u< (1 << C)
3291 // For lshr and ashr pairs.
3292 if ((match(Op0, m_OneUse(m_LShr(m_Value(A), m_ConstantInt(Cst1)))) &&
3293 match(Op1, m_OneUse(m_LShr(m_Value(B), m_Specific(Cst1))))) ||
3294 (match(Op0, m_OneUse(m_AShr(m_Value(A), m_ConstantInt(Cst1)))) &&
3295 match(Op1, m_OneUse(m_AShr(m_Value(B), m_Specific(Cst1)))))) {
3296 unsigned TypeBits = Cst1->getBitWidth();
3297 unsigned ShAmt = (unsigned)Cst1->getLimitedValue(TypeBits);
3298 if (ShAmt < TypeBits && ShAmt != 0) {
3299 ICmpInst::Predicate Pred = I.getPredicate() == ICmpInst::ICMP_NE
3300 ? ICmpInst::ICMP_UGE
3301 : ICmpInst::ICMP_ULT;
3302 Value *Xor = Builder->CreateXor(A, B, I.getName() + ".unshifted");
3303 APInt CmpVal = APInt::getOneBitSet(TypeBits, ShAmt);
3304 return new ICmpInst(Pred, Xor, Builder->getInt(CmpVal));
3305 }
3306 }
3307
3308 // (A << C) == (B << C) --> ((A^B) & (~0U >> C)) == 0
3309 if (match(Op0, m_OneUse(m_Shl(m_Value(A), m_ConstantInt(Cst1)))) &&
3310 match(Op1, m_OneUse(m_Shl(m_Value(B), m_Specific(Cst1))))) {
3311 unsigned TypeBits = Cst1->getBitWidth();
3312 unsigned ShAmt = (unsigned)Cst1->getLimitedValue(TypeBits);
3313 if (ShAmt < TypeBits && ShAmt != 0) {
3314 Value *Xor = Builder->CreateXor(A, B, I.getName() + ".unshifted");
3315 APInt AndVal = APInt::getLowBitsSet(TypeBits, TypeBits - ShAmt);
3316 Value *And = Builder->CreateAnd(Xor, Builder->getInt(AndVal),
3317 I.getName() + ".mask");
3318 return new ICmpInst(I.getPredicate(), And,
3319 Constant::getNullValue(Cst1->getType()));
3320 }
3321 }
3322
3323 // Transform "icmp eq (trunc (lshr(X, cst1)), cst" to
3324 // "icmp (and X, mask), cst"
3325 uint64_t ShAmt = 0;
3326 if (Op0->hasOneUse() &&
3327 match(Op0, m_Trunc(m_OneUse(m_LShr(m_Value(A), m_ConstantInt(ShAmt))))) &&
3328 match(Op1, m_ConstantInt(Cst1)) &&
3329 // Only do this when A has multiple uses. This is most important to do
3330 // when it exposes other optimizations.
3331 !A->hasOneUse()) {
3332 unsigned ASize = cast<IntegerType>(A->getType())->getPrimitiveSizeInBits();
3333
3334 if (ShAmt < ASize) {
3335 APInt MaskV =
3336 APInt::getLowBitsSet(ASize, Op0->getType()->getPrimitiveSizeInBits());
3337 MaskV <<= ShAmt;
3338
3339 APInt CmpV = Cst1->getValue().zext(ASize);
3340 CmpV <<= ShAmt;
3341
3342 Value *Mask = Builder->CreateAnd(A, Builder->getInt(MaskV));
3343 return new ICmpInst(I.getPredicate(), Mask, Builder->getInt(CmpV));
3344 }
3345 }
3346
3347 return nullptr;
3348}
3349
Sanjay Patel6f8f47b2016-06-05 00:12:32 +00003350/// Handle icmp (cast x to y), (cast/cst). We only handle extending casts so
3351/// far.
Sanjay Patel43395062016-07-21 18:07:40 +00003352Instruction *InstCombiner::foldICmpWithCastAndCast(ICmpInst &ICmp) {
Sanjay Patel6f8f47b2016-06-05 00:12:32 +00003353 const CastInst *LHSCI = cast<CastInst>(ICmp.getOperand(0));
Chris Lattner2188e402010-01-04 07:37:31 +00003354 Value *LHSCIOp = LHSCI->getOperand(0);
Chris Lattner229907c2011-07-18 04:54:35 +00003355 Type *SrcTy = LHSCIOp->getType();
3356 Type *DestTy = LHSCI->getType();
Chris Lattner2188e402010-01-04 07:37:31 +00003357 Value *RHSCIOp;
3358
Jim Grosbach129c52a2011-09-30 18:09:53 +00003359 // Turn icmp (ptrtoint x), (ptrtoint/c) into a compare of the input if the
Chris Lattner2188e402010-01-04 07:37:31 +00003360 // integer type is the same size as the pointer type.
Mehdi Aminia28d91d2015-03-10 02:37:25 +00003361 if (LHSCI->getOpcode() == Instruction::PtrToInt &&
3362 DL.getPointerTypeSizeInBits(SrcTy) == DestTy->getIntegerBitWidth()) {
Craig Topperf40110f2014-04-25 05:29:35 +00003363 Value *RHSOp = nullptr;
Sanjay Patel6f8f47b2016-06-05 00:12:32 +00003364 if (auto *RHSC = dyn_cast<PtrToIntOperator>(ICmp.getOperand(1))) {
Michael Liaod266b922015-02-13 04:51:26 +00003365 Value *RHSCIOp = RHSC->getOperand(0);
3366 if (RHSCIOp->getType()->getPointerAddressSpace() ==
3367 LHSCIOp->getType()->getPointerAddressSpace()) {
3368 RHSOp = RHSC->getOperand(0);
3369 // If the pointer types don't match, insert a bitcast.
3370 if (LHSCIOp->getType() != RHSOp->getType())
3371 RHSOp = Builder->CreateBitCast(RHSOp, LHSCIOp->getType());
3372 }
Sanjay Patel6f8f47b2016-06-05 00:12:32 +00003373 } else if (auto *RHSC = dyn_cast<Constant>(ICmp.getOperand(1))) {
Chris Lattner2188e402010-01-04 07:37:31 +00003374 RHSOp = ConstantExpr::getIntToPtr(RHSC, SrcTy);
Sanjay Patel6f8f47b2016-06-05 00:12:32 +00003375 }
Chris Lattner2188e402010-01-04 07:37:31 +00003376
3377 if (RHSOp)
Sanjay Patel6f8f47b2016-06-05 00:12:32 +00003378 return new ICmpInst(ICmp.getPredicate(), LHSCIOp, RHSOp);
Chris Lattner2188e402010-01-04 07:37:31 +00003379 }
Jim Grosbach129c52a2011-09-30 18:09:53 +00003380
Chris Lattner2188e402010-01-04 07:37:31 +00003381 // The code below only handles extension cast instructions, so far.
3382 // Enforce this.
3383 if (LHSCI->getOpcode() != Instruction::ZExt &&
3384 LHSCI->getOpcode() != Instruction::SExt)
Craig Topperf40110f2014-04-25 05:29:35 +00003385 return nullptr;
Chris Lattner2188e402010-01-04 07:37:31 +00003386
3387 bool isSignedExt = LHSCI->getOpcode() == Instruction::SExt;
Sanjay Patel6f8f47b2016-06-05 00:12:32 +00003388 bool isSignedCmp = ICmp.isSigned();
Chris Lattner2188e402010-01-04 07:37:31 +00003389
Sanjay Patel6f8f47b2016-06-05 00:12:32 +00003390 if (auto *CI = dyn_cast<CastInst>(ICmp.getOperand(1))) {
Chris Lattner2188e402010-01-04 07:37:31 +00003391 // Not an extension from the same type?
3392 RHSCIOp = CI->getOperand(0);
Jim Grosbach129c52a2011-09-30 18:09:53 +00003393 if (RHSCIOp->getType() != LHSCIOp->getType())
Craig Topperf40110f2014-04-25 05:29:35 +00003394 return nullptr;
Jim Grosbach129c52a2011-09-30 18:09:53 +00003395
Chris Lattner2188e402010-01-04 07:37:31 +00003396 // If the signedness of the two casts doesn't agree (i.e. one is a sext
3397 // and the other is a zext), then we can't handle this.
3398 if (CI->getOpcode() != LHSCI->getOpcode())
Craig Topperf40110f2014-04-25 05:29:35 +00003399 return nullptr;
Chris Lattner2188e402010-01-04 07:37:31 +00003400
3401 // Deal with equality cases early.
Sanjay Patel6f8f47b2016-06-05 00:12:32 +00003402 if (ICmp.isEquality())
3403 return new ICmpInst(ICmp.getPredicate(), LHSCIOp, RHSCIOp);
Chris Lattner2188e402010-01-04 07:37:31 +00003404
3405 // A signed comparison of sign extended values simplifies into a
3406 // signed comparison.
3407 if (isSignedCmp && isSignedExt)
Sanjay Patel6f8f47b2016-06-05 00:12:32 +00003408 return new ICmpInst(ICmp.getPredicate(), LHSCIOp, RHSCIOp);
Chris Lattner2188e402010-01-04 07:37:31 +00003409
3410 // The other three cases all fold into an unsigned comparison.
Sanjay Patel6f8f47b2016-06-05 00:12:32 +00003411 return new ICmpInst(ICmp.getUnsignedPredicate(), LHSCIOp, RHSCIOp);
Chris Lattner2188e402010-01-04 07:37:31 +00003412 }
3413
Sanjay Patel4c204232016-06-04 20:39:22 +00003414 // If we aren't dealing with a constant on the RHS, exit early.
Sanjay Patel6f8f47b2016-06-05 00:12:32 +00003415 auto *C = dyn_cast<Constant>(ICmp.getOperand(1));
3416 if (!C)
Craig Topperf40110f2014-04-25 05:29:35 +00003417 return nullptr;
Chris Lattner2188e402010-01-04 07:37:31 +00003418
3419 // Compute the constant that would happen if we truncated to SrcTy then
Sanjay Patelc774f8c2016-06-04 21:20:44 +00003420 // re-extended to DestTy.
Sanjay Patel6f8f47b2016-06-05 00:12:32 +00003421 Constant *Res1 = ConstantExpr::getTrunc(C, SrcTy);
Sanjay Patelc774f8c2016-06-04 21:20:44 +00003422 Constant *Res2 = ConstantExpr::getCast(LHSCI->getOpcode(), Res1, DestTy);
Chris Lattner2188e402010-01-04 07:37:31 +00003423
3424 // If the re-extended constant didn't change...
Sanjay Patel6f8f47b2016-06-05 00:12:32 +00003425 if (Res2 == C) {
Chris Lattner2188e402010-01-04 07:37:31 +00003426 // Deal with equality cases early.
Sanjay Patel6f8f47b2016-06-05 00:12:32 +00003427 if (ICmp.isEquality())
3428 return new ICmpInst(ICmp.getPredicate(), LHSCIOp, Res1);
Chris Lattner2188e402010-01-04 07:37:31 +00003429
3430 // A signed comparison of sign extended values simplifies into a
3431 // signed comparison.
3432 if (isSignedExt && isSignedCmp)
Sanjay Patel6f8f47b2016-06-05 00:12:32 +00003433 return new ICmpInst(ICmp.getPredicate(), LHSCIOp, Res1);
Chris Lattner2188e402010-01-04 07:37:31 +00003434
3435 // The other three cases all fold into an unsigned comparison.
Sanjay Patel6f8f47b2016-06-05 00:12:32 +00003436 return new ICmpInst(ICmp.getUnsignedPredicate(), LHSCIOp, Res1);
Chris Lattner2188e402010-01-04 07:37:31 +00003437 }
3438
Sanjay Patel6a333c32016-06-06 16:56:57 +00003439 // The re-extended constant changed, partly changed (in the case of a vector),
3440 // or could not be determined to be equal (in the case of a constant
3441 // expression), so the constant cannot be represented in the shorter type.
3442 // Consequently, we cannot emit a simple comparison.
Duncan Sands8fb2c382011-01-20 13:21:55 +00003443 // All the cases that fold to true or false will have already been handled
3444 // by SimplifyICmpInst, so only deal with the tricky case.
Chris Lattner2188e402010-01-04 07:37:31 +00003445
Sanjay Patel6a333c32016-06-06 16:56:57 +00003446 if (isSignedCmp || !isSignedExt || !isa<ConstantInt>(C))
Craig Topperf40110f2014-04-25 05:29:35 +00003447 return nullptr;
Chris Lattner2188e402010-01-04 07:37:31 +00003448
3449 // Evaluate the comparison for LT (we invert for GT below). LE and GE cases
3450 // should have been folded away previously and not enter in here.
Duncan Sands8fb2c382011-01-20 13:21:55 +00003451
3452 // We're performing an unsigned comp with a sign extended value.
3453 // This is true if the input is >= 0. [aka >s -1]
3454 Constant *NegOne = Constant::getAllOnesValue(SrcTy);
Sanjay Patel6f8f47b2016-06-05 00:12:32 +00003455 Value *Result = Builder->CreateICmpSGT(LHSCIOp, NegOne, ICmp.getName());
Chris Lattner2188e402010-01-04 07:37:31 +00003456
3457 // Finally, return the value computed.
Sanjay Patel6f8f47b2016-06-05 00:12:32 +00003458 if (ICmp.getPredicate() == ICmpInst::ICMP_ULT)
3459 return replaceInstUsesWith(ICmp, Result);
Chris Lattner2188e402010-01-04 07:37:31 +00003460
Sanjay Patel6f8f47b2016-06-05 00:12:32 +00003461 assert(ICmp.getPredicate() == ICmpInst::ICMP_UGT && "ICmp should be folded!");
Chris Lattner2188e402010-01-04 07:37:31 +00003462 return BinaryOperator::CreateNot(Result);
3463}
3464
Sanjoy Dasb0984472015-04-08 04:27:22 +00003465bool InstCombiner::OptimizeOverflowCheck(OverflowCheckFlavor OCF, Value *LHS,
3466 Value *RHS, Instruction &OrigI,
3467 Value *&Result, Constant *&Overflow) {
Sanjoy Das827529e2015-08-11 21:33:55 +00003468 if (OrigI.isCommutative() && isa<Constant>(LHS) && !isa<Constant>(RHS))
3469 std::swap(LHS, RHS);
Sanjoy Dasb0984472015-04-08 04:27:22 +00003470
3471 auto SetResult = [&](Value *OpResult, Constant *OverflowVal, bool ReuseName) {
3472 Result = OpResult;
3473 Overflow = OverflowVal;
3474 if (ReuseName)
3475 Result->takeName(&OrigI);
3476 return true;
3477 };
3478
Sanjoy Das6f5dca72015-08-28 19:09:31 +00003479 // If the overflow check was an add followed by a compare, the insertion point
3480 // may be pointing to the compare. We want to insert the new instructions
3481 // before the add in case there are uses of the add between the add and the
3482 // compare.
3483 Builder->SetInsertPoint(&OrigI);
3484
Sanjoy Dasb0984472015-04-08 04:27:22 +00003485 switch (OCF) {
3486 case OCF_INVALID:
3487 llvm_unreachable("bad overflow check kind!");
3488
3489 case OCF_UNSIGNED_ADD: {
3490 OverflowResult OR = computeOverflowForUnsignedAdd(LHS, RHS, &OrigI);
3491 if (OR == OverflowResult::NeverOverflows)
3492 return SetResult(Builder->CreateNUWAdd(LHS, RHS), Builder->getFalse(),
3493 true);
3494
3495 if (OR == OverflowResult::AlwaysOverflows)
3496 return SetResult(Builder->CreateAdd(LHS, RHS), Builder->getTrue(), true);
Justin Bognercd1d5aa2016-08-17 20:30:52 +00003497
3498 // Fall through uadd into sadd
3499 LLVM_FALLTHROUGH;
Sanjoy Dasb0984472015-04-08 04:27:22 +00003500 }
Sanjoy Dasb0984472015-04-08 04:27:22 +00003501 case OCF_SIGNED_ADD: {
David Majnemer27e89ba2015-05-21 23:04:21 +00003502 // X + 0 -> {X, false}
3503 if (match(RHS, m_Zero()))
3504 return SetResult(LHS, Builder->getFalse(), false);
Sanjoy Dasb0984472015-04-08 04:27:22 +00003505
3506 // We can strength reduce this signed add into a regular add if we can prove
3507 // that it will never overflow.
3508 if (OCF == OCF_SIGNED_ADD)
3509 if (WillNotOverflowSignedAdd(LHS, RHS, OrigI))
3510 return SetResult(Builder->CreateNSWAdd(LHS, RHS), Builder->getFalse(),
3511 true);
Sanjoy Das72cb5e12015-06-05 18:04:42 +00003512 break;
Sanjoy Dasb0984472015-04-08 04:27:22 +00003513 }
3514
3515 case OCF_UNSIGNED_SUB:
3516 case OCF_SIGNED_SUB: {
David Majnemer27e89ba2015-05-21 23:04:21 +00003517 // X - 0 -> {X, false}
3518 if (match(RHS, m_Zero()))
3519 return SetResult(LHS, Builder->getFalse(), false);
Sanjoy Dasb0984472015-04-08 04:27:22 +00003520
3521 if (OCF == OCF_SIGNED_SUB) {
3522 if (WillNotOverflowSignedSub(LHS, RHS, OrigI))
3523 return SetResult(Builder->CreateNSWSub(LHS, RHS), Builder->getFalse(),
3524 true);
3525 } else {
3526 if (WillNotOverflowUnsignedSub(LHS, RHS, OrigI))
3527 return SetResult(Builder->CreateNUWSub(LHS, RHS), Builder->getFalse(),
3528 true);
3529 }
3530 break;
3531 }
3532
3533 case OCF_UNSIGNED_MUL: {
3534 OverflowResult OR = computeOverflowForUnsignedMul(LHS, RHS, &OrigI);
3535 if (OR == OverflowResult::NeverOverflows)
3536 return SetResult(Builder->CreateNUWMul(LHS, RHS), Builder->getFalse(),
3537 true);
3538 if (OR == OverflowResult::AlwaysOverflows)
3539 return SetResult(Builder->CreateMul(LHS, RHS), Builder->getTrue(), true);
Justin Bognercd1d5aa2016-08-17 20:30:52 +00003540 LLVM_FALLTHROUGH;
3541 }
Sanjoy Dasb0984472015-04-08 04:27:22 +00003542 case OCF_SIGNED_MUL:
3543 // X * undef -> undef
3544 if (isa<UndefValue>(RHS))
David Majnemer27e89ba2015-05-21 23:04:21 +00003545 return SetResult(RHS, UndefValue::get(Builder->getInt1Ty()), false);
Sanjoy Dasb0984472015-04-08 04:27:22 +00003546
David Majnemer27e89ba2015-05-21 23:04:21 +00003547 // X * 0 -> {0, false}
3548 if (match(RHS, m_Zero()))
3549 return SetResult(RHS, Builder->getFalse(), false);
Sanjoy Dasb0984472015-04-08 04:27:22 +00003550
David Majnemer27e89ba2015-05-21 23:04:21 +00003551 // X * 1 -> {X, false}
3552 if (match(RHS, m_One()))
3553 return SetResult(LHS, Builder->getFalse(), false);
Sanjoy Dasb0984472015-04-08 04:27:22 +00003554
3555 if (OCF == OCF_SIGNED_MUL)
3556 if (WillNotOverflowSignedMul(LHS, RHS, OrigI))
3557 return SetResult(Builder->CreateNSWMul(LHS, RHS), Builder->getFalse(),
3558 true);
Sanjoy Dasc80dad62015-06-05 18:04:46 +00003559 break;
Sanjoy Dasb0984472015-04-08 04:27:22 +00003560 }
3561
3562 return false;
3563}
3564
Serge Pavlov4bb54d52014-04-13 18:23:41 +00003565/// \brief Recognize and process idiom involving test for multiplication
3566/// overflow.
3567///
3568/// The caller has matched a pattern of the form:
3569/// I = cmp u (mul(zext A, zext B), V
3570/// The function checks if this is a test for overflow and if so replaces
3571/// multiplication with call to 'mul.with.overflow' intrinsic.
3572///
3573/// \param I Compare instruction.
3574/// \param MulVal Result of 'mult' instruction. It is one of the arguments of
3575/// the compare instruction. Must be of integer type.
3576/// \param OtherVal The other argument of compare instruction.
3577/// \returns Instruction which must replace the compare instruction, NULL if no
3578/// replacement required.
Sanjay Pateld93c4c02016-09-15 18:22:25 +00003579static Instruction *processUMulZExtIdiom(ICmpInst &I, Value *MulVal,
Serge Pavlov4bb54d52014-04-13 18:23:41 +00003580 Value *OtherVal, InstCombiner &IC) {
Benjamin Kramerc96a7f82014-06-24 10:47:52 +00003581 // Don't bother doing this transformation for pointers, don't do it for
3582 // vectors.
3583 if (!isa<IntegerType>(MulVal->getType()))
3584 return nullptr;
3585
Serge Pavlov4bb54d52014-04-13 18:23:41 +00003586 assert(I.getOperand(0) == MulVal || I.getOperand(1) == MulVal);
3587 assert(I.getOperand(0) == OtherVal || I.getOperand(1) == OtherVal);
David Majnemerdaa24b92015-09-05 20:44:56 +00003588 auto *MulInstr = dyn_cast<Instruction>(MulVal);
3589 if (!MulInstr)
3590 return nullptr;
Serge Pavlov4bb54d52014-04-13 18:23:41 +00003591 assert(MulInstr->getOpcode() == Instruction::Mul);
3592
David Majnemer634ca232014-11-01 23:46:05 +00003593 auto *LHS = cast<ZExtOperator>(MulInstr->getOperand(0)),
3594 *RHS = cast<ZExtOperator>(MulInstr->getOperand(1));
Serge Pavlov4bb54d52014-04-13 18:23:41 +00003595 assert(LHS->getOpcode() == Instruction::ZExt);
3596 assert(RHS->getOpcode() == Instruction::ZExt);
3597 Value *A = LHS->getOperand(0), *B = RHS->getOperand(0);
3598
3599 // Calculate type and width of the result produced by mul.with.overflow.
3600 Type *TyA = A->getType(), *TyB = B->getType();
3601 unsigned WidthA = TyA->getPrimitiveSizeInBits(),
3602 WidthB = TyB->getPrimitiveSizeInBits();
3603 unsigned MulWidth;
3604 Type *MulType;
3605 if (WidthB > WidthA) {
3606 MulWidth = WidthB;
3607 MulType = TyB;
3608 } else {
3609 MulWidth = WidthA;
3610 MulType = TyA;
3611 }
3612
3613 // In order to replace the original mul with a narrower mul.with.overflow,
3614 // all uses must ignore upper bits of the product. The number of used low
3615 // bits must be not greater than the width of mul.with.overflow.
3616 if (MulVal->hasNUsesOrMore(2))
3617 for (User *U : MulVal->users()) {
3618 if (U == &I)
3619 continue;
3620 if (TruncInst *TI = dyn_cast<TruncInst>(U)) {
3621 // Check if truncation ignores bits above MulWidth.
3622 unsigned TruncWidth = TI->getType()->getPrimitiveSizeInBits();
3623 if (TruncWidth > MulWidth)
Craig Topperf40110f2014-04-25 05:29:35 +00003624 return nullptr;
Serge Pavlov4bb54d52014-04-13 18:23:41 +00003625 } else if (BinaryOperator *BO = dyn_cast<BinaryOperator>(U)) {
3626 // Check if AND ignores bits above MulWidth.
3627 if (BO->getOpcode() != Instruction::And)
Craig Topperf40110f2014-04-25 05:29:35 +00003628 return nullptr;
Serge Pavlov4bb54d52014-04-13 18:23:41 +00003629 if (ConstantInt *CI = dyn_cast<ConstantInt>(BO->getOperand(1))) {
3630 const APInt &CVal = CI->getValue();
3631 if (CVal.getBitWidth() - CVal.countLeadingZeros() > MulWidth)
Craig Topperf40110f2014-04-25 05:29:35 +00003632 return nullptr;
Serge Pavlov4bb54d52014-04-13 18:23:41 +00003633 }
3634 } else {
3635 // Other uses prohibit this transformation.
Craig Topperf40110f2014-04-25 05:29:35 +00003636 return nullptr;
Serge Pavlov4bb54d52014-04-13 18:23:41 +00003637 }
3638 }
3639
3640 // Recognize patterns
3641 switch (I.getPredicate()) {
3642 case ICmpInst::ICMP_EQ:
3643 case ICmpInst::ICMP_NE:
3644 // Recognize pattern:
3645 // mulval = mul(zext A, zext B)
3646 // cmp eq/neq mulval, zext trunc mulval
3647 if (ZExtInst *Zext = dyn_cast<ZExtInst>(OtherVal))
3648 if (Zext->hasOneUse()) {
3649 Value *ZextArg = Zext->getOperand(0);
3650 if (TruncInst *Trunc = dyn_cast<TruncInst>(ZextArg))
3651 if (Trunc->getType()->getPrimitiveSizeInBits() == MulWidth)
3652 break; //Recognized
3653 }
3654
3655 // Recognize pattern:
3656 // mulval = mul(zext A, zext B)
3657 // cmp eq/neq mulval, and(mulval, mask), mask selects low MulWidth bits.
3658 ConstantInt *CI;
3659 Value *ValToMask;
3660 if (match(OtherVal, m_And(m_Value(ValToMask), m_ConstantInt(CI)))) {
3661 if (ValToMask != MulVal)
Craig Topperf40110f2014-04-25 05:29:35 +00003662 return nullptr;
Serge Pavlov4bb54d52014-04-13 18:23:41 +00003663 const APInt &CVal = CI->getValue() + 1;
3664 if (CVal.isPowerOf2()) {
3665 unsigned MaskWidth = CVal.logBase2();
3666 if (MaskWidth == MulWidth)
3667 break; // Recognized
3668 }
3669 }
Craig Topperf40110f2014-04-25 05:29:35 +00003670 return nullptr;
Serge Pavlov4bb54d52014-04-13 18:23:41 +00003671
3672 case ICmpInst::ICMP_UGT:
3673 // Recognize pattern:
3674 // mulval = mul(zext A, zext B)
3675 // cmp ugt mulval, max
3676 if (ConstantInt *CI = dyn_cast<ConstantInt>(OtherVal)) {
3677 APInt MaxVal = APInt::getMaxValue(MulWidth);
3678 MaxVal = MaxVal.zext(CI->getBitWidth());
3679 if (MaxVal.eq(CI->getValue()))
3680 break; // Recognized
3681 }
Craig Topperf40110f2014-04-25 05:29:35 +00003682 return nullptr;
Serge Pavlov4bb54d52014-04-13 18:23:41 +00003683
3684 case ICmpInst::ICMP_UGE:
3685 // Recognize pattern:
3686 // mulval = mul(zext A, zext B)
3687 // cmp uge mulval, max+1
3688 if (ConstantInt *CI = dyn_cast<ConstantInt>(OtherVal)) {
3689 APInt MaxVal = APInt::getOneBitSet(CI->getBitWidth(), MulWidth);
3690 if (MaxVal.eq(CI->getValue()))
3691 break; // Recognized
3692 }
Craig Topperf40110f2014-04-25 05:29:35 +00003693 return nullptr;
Serge Pavlov4bb54d52014-04-13 18:23:41 +00003694
3695 case ICmpInst::ICMP_ULE:
3696 // Recognize pattern:
3697 // mulval = mul(zext A, zext B)
3698 // cmp ule mulval, max
3699 if (ConstantInt *CI = dyn_cast<ConstantInt>(OtherVal)) {
3700 APInt MaxVal = APInt::getMaxValue(MulWidth);
3701 MaxVal = MaxVal.zext(CI->getBitWidth());
3702 if (MaxVal.eq(CI->getValue()))
3703 break; // Recognized
3704 }
Craig Topperf40110f2014-04-25 05:29:35 +00003705 return nullptr;
Serge Pavlov4bb54d52014-04-13 18:23:41 +00003706
3707 case ICmpInst::ICMP_ULT:
3708 // Recognize pattern:
3709 // mulval = mul(zext A, zext B)
3710 // cmp ule mulval, max + 1
3711 if (ConstantInt *CI = dyn_cast<ConstantInt>(OtherVal)) {
Serge Pavlovb5f3ddc2014-04-14 02:20:19 +00003712 APInt MaxVal = APInt::getOneBitSet(CI->getBitWidth(), MulWidth);
Serge Pavlov4bb54d52014-04-13 18:23:41 +00003713 if (MaxVal.eq(CI->getValue()))
3714 break; // Recognized
3715 }
Craig Topperf40110f2014-04-25 05:29:35 +00003716 return nullptr;
Serge Pavlov4bb54d52014-04-13 18:23:41 +00003717
3718 default:
Craig Topperf40110f2014-04-25 05:29:35 +00003719 return nullptr;
Serge Pavlov4bb54d52014-04-13 18:23:41 +00003720 }
3721
3722 InstCombiner::BuilderTy *Builder = IC.Builder;
3723 Builder->SetInsertPoint(MulInstr);
Serge Pavlov4bb54d52014-04-13 18:23:41 +00003724
3725 // Replace: mul(zext A, zext B) --> mul.with.overflow(A, B)
3726 Value *MulA = A, *MulB = B;
3727 if (WidthA < MulWidth)
3728 MulA = Builder->CreateZExt(A, MulType);
3729 if (WidthB < MulWidth)
3730 MulB = Builder->CreateZExt(B, MulType);
Sanjay Patelaf674fb2015-12-14 17:24:23 +00003731 Value *F = Intrinsic::getDeclaration(I.getModule(),
3732 Intrinsic::umul_with_overflow, MulType);
David Blaikieff6409d2015-05-18 22:13:54 +00003733 CallInst *Call = Builder->CreateCall(F, {MulA, MulB}, "umul");
Serge Pavlov4bb54d52014-04-13 18:23:41 +00003734 IC.Worklist.Add(MulInstr);
3735
3736 // If there are uses of mul result other than the comparison, we know that
3737 // they are truncation or binary AND. Change them to use result of
Serge Pavlovb5f3ddc2014-04-14 02:20:19 +00003738 // mul.with.overflow and adjust properly mask/size.
Serge Pavlov4bb54d52014-04-13 18:23:41 +00003739 if (MulVal->hasNUsesOrMore(2)) {
3740 Value *Mul = Builder->CreateExtractValue(Call, 0, "umul.value");
3741 for (User *U : MulVal->users()) {
3742 if (U == &I || U == OtherVal)
3743 continue;
3744 if (TruncInst *TI = dyn_cast<TruncInst>(U)) {
3745 if (TI->getType()->getPrimitiveSizeInBits() == MulWidth)
Sanjay Patel4b198802016-02-01 22:23:39 +00003746 IC.replaceInstUsesWith(*TI, Mul);
Serge Pavlov4bb54d52014-04-13 18:23:41 +00003747 else
3748 TI->setOperand(0, Mul);
3749 } else if (BinaryOperator *BO = dyn_cast<BinaryOperator>(U)) {
3750 assert(BO->getOpcode() == Instruction::And);
3751 // Replace (mul & mask) --> zext (mul.with.overflow & short_mask)
3752 ConstantInt *CI = cast<ConstantInt>(BO->getOperand(1));
3753 APInt ShortMask = CI->getValue().trunc(MulWidth);
3754 Value *ShortAnd = Builder->CreateAnd(Mul, ShortMask);
3755 Instruction *Zext =
3756 cast<Instruction>(Builder->CreateZExt(ShortAnd, BO->getType()));
3757 IC.Worklist.Add(Zext);
Sanjay Patel4b198802016-02-01 22:23:39 +00003758 IC.replaceInstUsesWith(*BO, Zext);
Serge Pavlov4bb54d52014-04-13 18:23:41 +00003759 } else {
3760 llvm_unreachable("Unexpected Binary operation");
3761 }
3762 IC.Worklist.Add(cast<Instruction>(U));
3763 }
3764 }
3765 if (isa<Instruction>(OtherVal))
3766 IC.Worklist.Add(cast<Instruction>(OtherVal));
3767
3768 // The original icmp gets replaced with the overflow value, maybe inverted
3769 // depending on predicate.
3770 bool Inverse = false;
3771 switch (I.getPredicate()) {
3772 case ICmpInst::ICMP_NE:
3773 break;
3774 case ICmpInst::ICMP_EQ:
3775 Inverse = true;
3776 break;
3777 case ICmpInst::ICMP_UGT:
3778 case ICmpInst::ICMP_UGE:
3779 if (I.getOperand(0) == MulVal)
3780 break;
3781 Inverse = true;
3782 break;
3783 case ICmpInst::ICMP_ULT:
3784 case ICmpInst::ICMP_ULE:
3785 if (I.getOperand(1) == MulVal)
3786 break;
3787 Inverse = true;
3788 break;
3789 default:
3790 llvm_unreachable("Unexpected predicate");
3791 }
3792 if (Inverse) {
3793 Value *Res = Builder->CreateExtractValue(Call, 1);
3794 return BinaryOperator::CreateNot(Res);
3795 }
3796
3797 return ExtractValueInst::Create(Call, 1);
3798}
3799
Sanjay Patel5f0217f2016-06-05 16:46:18 +00003800/// When performing a comparison against a constant, it is possible that not all
3801/// the bits in the LHS are demanded. This helper method computes the mask that
3802/// IS demanded.
Sanjay Pateld93c4c02016-09-15 18:22:25 +00003803static APInt getDemandedBitsLHSMask(ICmpInst &I, unsigned BitWidth,
3804 bool isSignCheck) {
Owen Andersond490c2d2011-01-11 00:36:45 +00003805 if (isSignCheck)
Craig Topperbcfd2d12017-04-20 16:56:25 +00003806 return APInt::getSignMask(BitWidth);
Jim Grosbach129c52a2011-09-30 18:09:53 +00003807
Owen Andersond490c2d2011-01-11 00:36:45 +00003808 ConstantInt *CI = dyn_cast<ConstantInt>(I.getOperand(1));
3809 if (!CI) return APInt::getAllOnesValue(BitWidth);
Owen Anderson0022a4b2011-01-11 18:26:37 +00003810 const APInt &RHS = CI->getValue();
Jim Grosbach129c52a2011-09-30 18:09:53 +00003811
Owen Andersond490c2d2011-01-11 00:36:45 +00003812 switch (I.getPredicate()) {
Jim Grosbach129c52a2011-09-30 18:09:53 +00003813 // For a UGT comparison, we don't care about any bits that
Owen Andersond490c2d2011-01-11 00:36:45 +00003814 // correspond to the trailing ones of the comparand. The value of these
3815 // bits doesn't impact the outcome of the comparison, because any value
3816 // greater than the RHS must differ in a bit higher than these due to carry.
3817 case ICmpInst::ICMP_UGT: {
3818 unsigned trailingOnes = RHS.countTrailingOnes();
Craig Toppere7563f82017-04-13 21:49:48 +00003819 return APInt::getBitsSetFrom(BitWidth, trailingOnes);
Owen Andersond490c2d2011-01-11 00:36:45 +00003820 }
Jim Grosbach129c52a2011-09-30 18:09:53 +00003821
Owen Andersond490c2d2011-01-11 00:36:45 +00003822 // Similarly, for a ULT comparison, we don't care about the trailing zeros.
3823 // Any value less than the RHS must differ in a higher bit because of carries.
3824 case ICmpInst::ICMP_ULT: {
3825 unsigned trailingZeros = RHS.countTrailingZeros();
Craig Toppere7563f82017-04-13 21:49:48 +00003826 return APInt::getBitsSetFrom(BitWidth, trailingZeros);
Owen Andersond490c2d2011-01-11 00:36:45 +00003827 }
Jim Grosbach129c52a2011-09-30 18:09:53 +00003828
Owen Andersond490c2d2011-01-11 00:36:45 +00003829 default:
3830 return APInt::getAllOnesValue(BitWidth);
3831 }
Owen Andersond490c2d2011-01-11 00:36:45 +00003832}
Chris Lattner2188e402010-01-04 07:37:31 +00003833
Quentin Colombet5ab55552013-09-09 20:56:48 +00003834/// \brief Check if the order of \p Op0 and \p Op1 as operand in an ICmpInst
3835/// should be swapped.
Alp Tokercb402912014-01-24 17:20:08 +00003836/// The decision is based on how many times these two operands are reused
Quentin Colombet5ab55552013-09-09 20:56:48 +00003837/// as subtract operands and their positions in those instructions.
3838/// The rational is that several architectures use the same instruction for
3839/// both subtract and cmp, thus it is better if the order of those operands
3840/// match.
3841/// \return true if Op0 and Op1 should be swapped.
3842static bool swapMayExposeCSEOpportunities(const Value * Op0,
3843 const Value * Op1) {
3844 // Filter out pointer value as those cannot appears directly in subtract.
3845 // FIXME: we may want to go through inttoptrs or bitcasts.
3846 if (Op0->getType()->isPointerTy())
3847 return false;
3848 // Count every uses of both Op0 and Op1 in a subtract.
3849 // Each time Op0 is the first operand, count -1: swapping is bad, the
3850 // subtract has already the same layout as the compare.
3851 // Each time Op0 is the second operand, count +1: swapping is good, the
Alp Tokercb402912014-01-24 17:20:08 +00003852 // subtract has a different layout as the compare.
Quentin Colombet5ab55552013-09-09 20:56:48 +00003853 // At the end, if the benefit is greater than 0, Op0 should come second to
3854 // expose more CSE opportunities.
3855 int GlobalSwapBenefits = 0;
Chandler Carruthcdf47882014-03-09 03:16:01 +00003856 for (const User *U : Op0->users()) {
3857 const BinaryOperator *BinOp = dyn_cast<BinaryOperator>(U);
Quentin Colombet5ab55552013-09-09 20:56:48 +00003858 if (!BinOp || BinOp->getOpcode() != Instruction::Sub)
3859 continue;
3860 // If Op0 is the first argument, this is not beneficial to swap the
3861 // arguments.
3862 int LocalSwapBenefits = -1;
3863 unsigned Op1Idx = 1;
3864 if (BinOp->getOperand(Op1Idx) == Op0) {
3865 Op1Idx = 0;
3866 LocalSwapBenefits = 1;
3867 }
3868 if (BinOp->getOperand(Op1Idx) != Op1)
3869 continue;
3870 GlobalSwapBenefits += LocalSwapBenefits;
3871 }
3872 return GlobalSwapBenefits > 0;
3873}
3874
Gerolf Hoflehnerec6217c2014-11-21 23:36:44 +00003875/// \brief Check that one use is in the same block as the definition and all
Sanjay Patel53523312016-09-12 14:25:46 +00003876/// other uses are in blocks dominated by a given block.
Gerolf Hoflehnerec6217c2014-11-21 23:36:44 +00003877///
3878/// \param DI Definition
3879/// \param UI Use
3880/// \param DB Block that must dominate all uses of \p DI outside
3881/// the parent block
3882/// \return true when \p UI is the only use of \p DI in the parent block
3883/// and all other uses of \p DI are in blocks dominated by \p DB.
3884///
3885bool InstCombiner::dominatesAllUses(const Instruction *DI,
3886 const Instruction *UI,
3887 const BasicBlock *DB) const {
3888 assert(DI && UI && "Instruction not defined\n");
Sanjay Patel53523312016-09-12 14:25:46 +00003889 // Ignore incomplete definitions.
Gerolf Hoflehnerec6217c2014-11-21 23:36:44 +00003890 if (!DI->getParent())
3891 return false;
Sanjay Patel53523312016-09-12 14:25:46 +00003892 // DI and UI must be in the same block.
Gerolf Hoflehnerec6217c2014-11-21 23:36:44 +00003893 if (DI->getParent() != UI->getParent())
3894 return false;
Sanjay Patel53523312016-09-12 14:25:46 +00003895 // Protect from self-referencing blocks.
Gerolf Hoflehnerec6217c2014-11-21 23:36:44 +00003896 if (DI->getParent() == DB)
3897 return false;
Gerolf Hoflehnerec6217c2014-11-21 23:36:44 +00003898 for (const User *U : DI->users()) {
3899 auto *Usr = cast<Instruction>(U);
Justin Bogner99798402016-08-05 01:06:44 +00003900 if (Usr != UI && !DT.dominates(DB, Usr->getParent()))
Gerolf Hoflehnerec6217c2014-11-21 23:36:44 +00003901 return false;
3902 }
3903 return true;
3904}
3905
Sanjay Patel5f0217f2016-06-05 16:46:18 +00003906/// Return true when the instruction sequence within a block is select-cmp-br.
Gerolf Hoflehnerec6217c2014-11-21 23:36:44 +00003907static bool isChainSelectCmpBranch(const SelectInst *SI) {
3908 const BasicBlock *BB = SI->getParent();
3909 if (!BB)
3910 return false;
3911 auto *BI = dyn_cast_or_null<BranchInst>(BB->getTerminator());
3912 if (!BI || BI->getNumSuccessors() != 2)
3913 return false;
3914 auto *IC = dyn_cast<ICmpInst>(BI->getCondition());
3915 if (!IC || (IC->getOperand(0) != SI && IC->getOperand(1) != SI))
3916 return false;
3917 return true;
3918}
3919
Gerolf Hoflehnerec6217c2014-11-21 23:36:44 +00003920/// \brief True when a select result is replaced by one of its operands
3921/// in select-icmp sequence. This will eventually result in the elimination
3922/// of the select.
3923///
3924/// \param SI Select instruction
3925/// \param Icmp Compare instruction
3926/// \param SIOpd Operand that replaces the select
3927///
3928/// Notes:
3929/// - The replacement is global and requires dominator information
3930/// - The caller is responsible for the actual replacement
3931///
3932/// Example:
3933///
3934/// entry:
3935/// %4 = select i1 %3, %C* %0, %C* null
3936/// %5 = icmp eq %C* %4, null
3937/// br i1 %5, label %9, label %7
3938/// ...
3939/// ; <label>:7 ; preds = %entry
3940/// %8 = getelementptr inbounds %C* %4, i64 0, i32 0
3941/// ...
3942///
3943/// can be transformed to
3944///
3945/// %5 = icmp eq %C* %0, null
3946/// %6 = select i1 %3, i1 %5, i1 true
3947/// br i1 %6, label %9, label %7
3948/// ...
3949/// ; <label>:7 ; preds = %entry
3950/// %8 = getelementptr inbounds %C* %0, i64 0, i32 0 // replace by %0!
3951///
3952/// Similar when the first operand of the select is a constant or/and
3953/// the compare is for not equal rather than equal.
3954///
3955/// NOTE: The function is only called when the select and compare constants
3956/// are equal, the optimization can work only for EQ predicates. This is not a
3957/// major restriction since a NE compare should be 'normalized' to an equal
3958/// compare, which usually happens in the combiner and test case
Sanjay Patel53523312016-09-12 14:25:46 +00003959/// select-cmp-br.ll checks for it.
Gerolf Hoflehnerec6217c2014-11-21 23:36:44 +00003960bool InstCombiner::replacedSelectWithOperand(SelectInst *SI,
3961 const ICmpInst *Icmp,
3962 const unsigned SIOpd) {
David Majnemer83484fd2014-11-22 06:09:28 +00003963 assert((SIOpd == 1 || SIOpd == 2) && "Invalid select operand!");
Gerolf Hoflehnerec6217c2014-11-21 23:36:44 +00003964 if (isChainSelectCmpBranch(SI) && Icmp->getPredicate() == ICmpInst::ICMP_EQ) {
3965 BasicBlock *Succ = SI->getParent()->getTerminator()->getSuccessor(1);
Bjorn Petterssone5027cf2017-03-02 15:18:58 +00003966 // The check for the single predecessor is not the best that can be
Sanjay Patel53523312016-09-12 14:25:46 +00003967 // done. But it protects efficiently against cases like when SI's
Gerolf Hoflehnerec6217c2014-11-21 23:36:44 +00003968 // home block has two successors, Succ and Succ1, and Succ1 predecessor
3969 // of Succ. Then SI can't be replaced by SIOpd because the use that gets
3970 // replaced can be reached on either path. So the uniqueness check
3971 // guarantees that the path all uses of SI (outside SI's parent) are on
3972 // is disjoint from all other paths out of SI. But that information
3973 // is more expensive to compute, and the trade-off here is in favor
Bjorn Petterssone5027cf2017-03-02 15:18:58 +00003974 // of compile-time. It should also be noticed that we check for a single
3975 // predecessor and not only uniqueness. This to handle the situation when
3976 // Succ and Succ1 points to the same basic block.
3977 if (Succ->getSinglePredecessor() && dominatesAllUses(SI, Icmp, Succ)) {
Gerolf Hoflehnerec6217c2014-11-21 23:36:44 +00003978 NumSel++;
3979 SI->replaceUsesOutsideBlock(SI->getOperand(SIOpd), SI->getParent());
3980 return true;
3981 }
3982 }
3983 return false;
3984}
3985
Sanjay Patel3151dec2016-09-12 15:24:31 +00003986/// Try to fold the comparison based on range information we can get by checking
3987/// whether bits are known to be zero or one in the inputs.
3988Instruction *InstCombiner::foldICmpUsingKnownBits(ICmpInst &I) {
3989 Value *Op0 = I.getOperand(0), *Op1 = I.getOperand(1);
3990 Type *Ty = Op0->getType();
Sanjay Patel0531f0a2016-09-12 15:52:28 +00003991 ICmpInst::Predicate Pred = I.getPredicate();
Sanjay Patel3151dec2016-09-12 15:24:31 +00003992
3993 // Get scalar or pointer size.
3994 unsigned BitWidth = Ty->isIntOrIntVectorTy()
3995 ? Ty->getScalarSizeInBits()
3996 : DL.getTypeSizeInBits(Ty->getScalarType());
3997
3998 if (!BitWidth)
3999 return nullptr;
4000
4001 // If this is a normal comparison, it demands all bits. If it is a sign bit
4002 // comparison, it only demands the sign bit.
4003 bool IsSignBit = false;
Sanjay Patelf5887f12016-09-12 16:25:41 +00004004 const APInt *CmpC;
4005 if (match(Op1, m_APInt(CmpC))) {
Sanjay Patel3151dec2016-09-12 15:24:31 +00004006 bool UnusedBit;
Sanjay Patelf5887f12016-09-12 16:25:41 +00004007 IsSignBit = isSignBitCheck(Pred, *CmpC, UnusedBit);
Sanjay Patel3151dec2016-09-12 15:24:31 +00004008 }
4009
Craig Topperb45eabc2017-04-26 16:39:58 +00004010 KnownBits Op0Known(BitWidth);
4011 KnownBits Op1Known(BitWidth);
Sanjay Patel3151dec2016-09-12 15:24:31 +00004012
Craig Topper47596dd2017-03-25 06:52:52 +00004013 if (SimplifyDemandedBits(&I, 0,
Sanjay Pateld93c4c02016-09-15 18:22:25 +00004014 getDemandedBitsLHSMask(I, BitWidth, IsSignBit),
Craig Topperb45eabc2017-04-26 16:39:58 +00004015 Op0Known, 0))
Sanjay Patel3151dec2016-09-12 15:24:31 +00004016 return &I;
4017
Craig Topper47596dd2017-03-25 06:52:52 +00004018 if (SimplifyDemandedBits(&I, 1, APInt::getAllOnesValue(BitWidth),
Craig Topperb45eabc2017-04-26 16:39:58 +00004019 Op1Known, 0))
Sanjay Patel3151dec2016-09-12 15:24:31 +00004020 return &I;
4021
4022 // Given the known and unknown bits, compute a range that the LHS could be
4023 // in. Compute the Min, Max and RHS values based on the known bits. For the
4024 // EQ and NE we use unsigned values.
4025 APInt Op0Min(BitWidth, 0), Op0Max(BitWidth, 0);
4026 APInt Op1Min(BitWidth, 0), Op1Max(BitWidth, 0);
4027 if (I.isSigned()) {
Craig Topperb45eabc2017-04-26 16:39:58 +00004028 computeSignedMinMaxValuesFromKnownBits(Op0Known, Op0Min, Op0Max);
4029 computeSignedMinMaxValuesFromKnownBits(Op1Known, Op1Min, Op1Max);
Sanjay Patel3151dec2016-09-12 15:24:31 +00004030 } else {
Craig Topperb45eabc2017-04-26 16:39:58 +00004031 computeUnsignedMinMaxValuesFromKnownBits(Op0Known, Op0Min, Op0Max);
4032 computeUnsignedMinMaxValuesFromKnownBits(Op1Known, Op1Min, Op1Max);
Sanjay Patel3151dec2016-09-12 15:24:31 +00004033 }
4034
4035 // If Min and Max are known to be the same, then SimplifyDemandedBits
Sanjay Patel0531f0a2016-09-12 15:52:28 +00004036 // figured out that the LHS is a constant. Constant fold this now, so that
4037 // code below can assume that Min != Max.
Sanjay Patel3151dec2016-09-12 15:24:31 +00004038 if (!isa<Constant>(Op0) && Op0Min == Op0Max)
Sanjay Patel0531f0a2016-09-12 15:52:28 +00004039 return new ICmpInst(Pred, ConstantInt::get(Op0->getType(), Op0Min), Op1);
Sanjay Patel3151dec2016-09-12 15:24:31 +00004040 if (!isa<Constant>(Op1) && Op1Min == Op1Max)
Sanjay Patel0531f0a2016-09-12 15:52:28 +00004041 return new ICmpInst(Pred, Op0, ConstantInt::get(Op1->getType(), Op1Min));
Sanjay Patel3151dec2016-09-12 15:24:31 +00004042
4043 // Based on the range information we know about the LHS, see if we can
4044 // simplify this comparison. For example, (x&4) < 8 is always true.
Sanjay Patel0531f0a2016-09-12 15:52:28 +00004045 switch (Pred) {
Sanjay Patel3151dec2016-09-12 15:24:31 +00004046 default:
4047 llvm_unreachable("Unknown icmp opcode!");
Sanjay Patel9efb1bd2016-09-14 23:38:56 +00004048 case ICmpInst::ICMP_EQ:
Sanjay Patel3151dec2016-09-12 15:24:31 +00004049 case ICmpInst::ICMP_NE: {
Sanjay Patel9efb1bd2016-09-14 23:38:56 +00004050 if (Op0Max.ult(Op1Min) || Op0Min.ugt(Op1Max)) {
4051 return Pred == CmpInst::ICMP_EQ
4052 ? replaceInstUsesWith(I, ConstantInt::getFalse(I.getType()))
4053 : replaceInstUsesWith(I, ConstantInt::getTrue(I.getType()));
4054 }
Sanjay Patel3151dec2016-09-12 15:24:31 +00004055
Sanjay Patel0531f0a2016-09-12 15:52:28 +00004056 // If all bits are known zero except for one, then we know at most one bit
4057 // is set. If the comparison is against zero, then this is a check to see if
4058 // *that* bit is set.
Craig Topperb45eabc2017-04-26 16:39:58 +00004059 APInt Op0KnownZeroInverted = ~Op0Known.Zero;
Craig Topperf0aeee02017-05-05 17:36:09 +00004060 if (Op1Known.isZero()) {
Sanjay Patel3151dec2016-09-12 15:24:31 +00004061 // If the LHS is an AND with the same constant, look through it.
4062 Value *LHS = nullptr;
Sanjay Patel7577a3d2016-09-15 14:15:47 +00004063 const APInt *LHSC;
4064 if (!match(Op0, m_And(m_Value(LHS), m_APInt(LHSC))) ||
4065 *LHSC != Op0KnownZeroInverted)
Sanjay Patel3151dec2016-09-12 15:24:31 +00004066 LHS = Op0;
4067
Sanjay Patel9efb1bd2016-09-14 23:38:56 +00004068 Value *X;
Sanjay Patel3151dec2016-09-12 15:24:31 +00004069 if (match(LHS, m_Shl(m_One(), m_Value(X)))) {
4070 APInt ValToCheck = Op0KnownZeroInverted;
Sanjay Patel9efb1bd2016-09-14 23:38:56 +00004071 Type *XTy = X->getType();
Sanjay Patel3151dec2016-09-12 15:24:31 +00004072 if (ValToCheck.isPowerOf2()) {
Sanjay Patel9efb1bd2016-09-14 23:38:56 +00004073 // ((1 << X) & 8) == 0 -> X != 3
4074 // ((1 << X) & 8) != 0 -> X == 3
4075 auto *CmpC = ConstantInt::get(XTy, ValToCheck.countTrailingZeros());
4076 auto NewPred = ICmpInst::getInversePredicate(Pred);
4077 return new ICmpInst(NewPred, X, CmpC);
Sanjay Patel3151dec2016-09-12 15:24:31 +00004078 } else if ((++ValToCheck).isPowerOf2()) {
Sanjay Patel9efb1bd2016-09-14 23:38:56 +00004079 // ((1 << X) & 7) == 0 -> X >= 3
4080 // ((1 << X) & 7) != 0 -> X < 3
4081 auto *CmpC = ConstantInt::get(XTy, ValToCheck.countTrailingZeros());
4082 auto NewPred =
4083 Pred == CmpInst::ICMP_EQ ? CmpInst::ICMP_UGE : CmpInst::ICMP_ULT;
4084 return new ICmpInst(NewPred, X, CmpC);
Sanjay Patel3151dec2016-09-12 15:24:31 +00004085 }
4086 }
4087
Sanjay Patel9efb1bd2016-09-14 23:38:56 +00004088 // Check if the LHS is 8 >>u x and the result is a power of 2 like 1.
Sanjay Patel3151dec2016-09-12 15:24:31 +00004089 const APInt *CI;
4090 if (Op0KnownZeroInverted == 1 &&
Sanjay Patel9efb1bd2016-09-14 23:38:56 +00004091 match(LHS, m_LShr(m_Power2(CI), m_Value(X)))) {
4092 // ((8 >>u X) & 1) == 0 -> X != 3
4093 // ((8 >>u X) & 1) != 0 -> X == 3
4094 unsigned CmpVal = CI->countTrailingZeros();
4095 auto NewPred = ICmpInst::getInversePredicate(Pred);
4096 return new ICmpInst(NewPred, X, ConstantInt::get(X->getType(), CmpVal));
4097 }
Sanjay Patel3151dec2016-09-12 15:24:31 +00004098 }
4099 break;
4100 }
4101 case ICmpInst::ICMP_ULT: {
4102 if (Op0Max.ult(Op1Min)) // A <u B -> true if max(A) < min(B)
4103 return replaceInstUsesWith(I, ConstantInt::getTrue(I.getType()));
4104 if (Op0Min.uge(Op1Max)) // A <u B -> false if min(A) >= max(B)
4105 return replaceInstUsesWith(I, ConstantInt::getFalse(I.getType()));
4106 if (Op1Min == Op0Max) // A <u B -> A != B if max(A) == min(B)
4107 return new ICmpInst(ICmpInst::ICMP_NE, Op0, Op1);
4108
4109 const APInt *CmpC;
4110 if (match(Op1, m_APInt(CmpC))) {
4111 // A <u C -> A == C-1 if min(A)+1 == C
4112 if (Op1Max == Op0Min + 1) {
4113 Constant *CMinus1 = ConstantInt::get(Op0->getType(), *CmpC - 1);
4114 return new ICmpInst(ICmpInst::ICMP_EQ, Op0, CMinus1);
4115 }
Sanjay Patel3151dec2016-09-12 15:24:31 +00004116 }
4117 break;
4118 }
4119 case ICmpInst::ICMP_UGT: {
4120 if (Op0Min.ugt(Op1Max)) // A >u B -> true if min(A) > max(B)
4121 return replaceInstUsesWith(I, ConstantInt::getTrue(I.getType()));
4122
4123 if (Op0Max.ule(Op1Min)) // A >u B -> false if max(A) <= max(B)
4124 return replaceInstUsesWith(I, ConstantInt::getFalse(I.getType()));
4125
4126 if (Op1Max == Op0Min) // A >u B -> A != B if min(A) == max(B)
4127 return new ICmpInst(ICmpInst::ICMP_NE, Op0, Op1);
4128
4129 const APInt *CmpC;
4130 if (match(Op1, m_APInt(CmpC))) {
4131 // A >u C -> A == C+1 if max(a)-1 == C
4132 if (*CmpC == Op0Max - 1)
4133 return new ICmpInst(ICmpInst::ICMP_EQ, Op0,
4134 ConstantInt::get(Op1->getType(), *CmpC + 1));
Sanjay Patel3151dec2016-09-12 15:24:31 +00004135 }
4136 break;
4137 }
4138 case ICmpInst::ICMP_SLT:
4139 if (Op0Max.slt(Op1Min)) // A <s B -> true if max(A) < min(C)
4140 return replaceInstUsesWith(I, ConstantInt::getTrue(I.getType()));
4141 if (Op0Min.sge(Op1Max)) // A <s B -> false if min(A) >= max(C)
4142 return replaceInstUsesWith(I, ConstantInt::getFalse(I.getType()));
4143 if (Op1Min == Op0Max) // A <s B -> A != B if max(A) == min(B)
4144 return new ICmpInst(ICmpInst::ICMP_NE, Op0, Op1);
4145 if (ConstantInt *CI = dyn_cast<ConstantInt>(Op1)) {
4146 if (Op1Max == Op0Min + 1) // A <s C -> A == C-1 if min(A)+1 == C
4147 return new ICmpInst(ICmpInst::ICMP_EQ, Op0,
4148 Builder->getInt(CI->getValue() - 1));
4149 }
4150 break;
4151 case ICmpInst::ICMP_SGT:
4152 if (Op0Min.sgt(Op1Max)) // A >s B -> true if min(A) > max(B)
4153 return replaceInstUsesWith(I, ConstantInt::getTrue(I.getType()));
4154 if (Op0Max.sle(Op1Min)) // A >s B -> false if max(A) <= min(B)
4155 return replaceInstUsesWith(I, ConstantInt::getFalse(I.getType()));
4156
4157 if (Op1Max == Op0Min) // A >s B -> A != B if min(A) == max(B)
4158 return new ICmpInst(ICmpInst::ICMP_NE, Op0, Op1);
4159 if (ConstantInt *CI = dyn_cast<ConstantInt>(Op1)) {
4160 if (Op1Min == Op0Max - 1) // A >s C -> A == C+1 if max(A)-1 == C
4161 return new ICmpInst(ICmpInst::ICMP_EQ, Op0,
4162 Builder->getInt(CI->getValue() + 1));
4163 }
4164 break;
4165 case ICmpInst::ICMP_SGE:
4166 assert(!isa<ConstantInt>(Op1) && "ICMP_SGE with ConstantInt not folded!");
4167 if (Op0Min.sge(Op1Max)) // A >=s B -> true if min(A) >= max(B)
4168 return replaceInstUsesWith(I, ConstantInt::getTrue(I.getType()));
4169 if (Op0Max.slt(Op1Min)) // A >=s B -> false if max(A) < min(B)
4170 return replaceInstUsesWith(I, ConstantInt::getFalse(I.getType()));
4171 break;
4172 case ICmpInst::ICMP_SLE:
4173 assert(!isa<ConstantInt>(Op1) && "ICMP_SLE with ConstantInt not folded!");
4174 if (Op0Max.sle(Op1Min)) // A <=s B -> true if max(A) <= min(B)
4175 return replaceInstUsesWith(I, ConstantInt::getTrue(I.getType()));
4176 if (Op0Min.sgt(Op1Max)) // A <=s B -> false if min(A) > max(B)
4177 return replaceInstUsesWith(I, ConstantInt::getFalse(I.getType()));
4178 break;
4179 case ICmpInst::ICMP_UGE:
4180 assert(!isa<ConstantInt>(Op1) && "ICMP_UGE with ConstantInt not folded!");
4181 if (Op0Min.uge(Op1Max)) // A >=u B -> true if min(A) >= max(B)
4182 return replaceInstUsesWith(I, ConstantInt::getTrue(I.getType()));
4183 if (Op0Max.ult(Op1Min)) // A >=u B -> false if max(A) < min(B)
4184 return replaceInstUsesWith(I, ConstantInt::getFalse(I.getType()));
4185 break;
4186 case ICmpInst::ICMP_ULE:
4187 assert(!isa<ConstantInt>(Op1) && "ICMP_ULE with ConstantInt not folded!");
4188 if (Op0Max.ule(Op1Min)) // A <=u B -> true if max(A) <= min(B)
4189 return replaceInstUsesWith(I, ConstantInt::getTrue(I.getType()));
4190 if (Op0Min.ugt(Op1Max)) // A <=u B -> false if min(A) > max(B)
4191 return replaceInstUsesWith(I, ConstantInt::getFalse(I.getType()));
4192 break;
4193 }
4194
4195 // Turn a signed comparison into an unsigned one if both operands are known to
4196 // have the same sign.
4197 if (I.isSigned() &&
Craig Topperb45eabc2017-04-26 16:39:58 +00004198 ((Op0Known.Zero.isNegative() && Op1Known.Zero.isNegative()) ||
4199 (Op0Known.One.isNegative() && Op1Known.One.isNegative())))
Sanjay Patel3151dec2016-09-12 15:24:31 +00004200 return new ICmpInst(I.getUnsignedPredicate(), Op0, Op1);
4201
4202 return nullptr;
4203}
4204
Sanjay Pateld5b0e542016-04-29 16:22:25 +00004205/// If we have an icmp le or icmp ge instruction with a constant operand, turn
4206/// it into the appropriate icmp lt or icmp gt instruction. This transform
4207/// allows them to be folded in visitICmpInst.
Sanjay Patele9b2c322016-05-17 00:57:57 +00004208static ICmpInst *canonicalizeCmpWithConstant(ICmpInst &I) {
4209 ICmpInst::Predicate Pred = I.getPredicate();
4210 if (Pred != ICmpInst::ICMP_SLE && Pred != ICmpInst::ICMP_SGE &&
4211 Pred != ICmpInst::ICMP_ULE && Pred != ICmpInst::ICMP_UGE)
4212 return nullptr;
4213
Sanjay Pateld5b0e542016-04-29 16:22:25 +00004214 Value *Op0 = I.getOperand(0);
4215 Value *Op1 = I.getOperand(1);
Sanjay Patele9b2c322016-05-17 00:57:57 +00004216 auto *Op1C = dyn_cast<Constant>(Op1);
4217 if (!Op1C)
4218 return nullptr;
Sanjay Pateld5b0e542016-04-29 16:22:25 +00004219
Sanjay Patele9b2c322016-05-17 00:57:57 +00004220 // Check if the constant operand can be safely incremented/decremented without
4221 // overflowing/underflowing. For scalars, SimplifyICmpInst has already handled
4222 // the edge cases for us, so we just assert on them. For vectors, we must
4223 // handle the edge cases.
4224 Type *Op1Type = Op1->getType();
4225 bool IsSigned = I.isSigned();
4226 bool IsLE = (Pred == ICmpInst::ICMP_SLE || Pred == ICmpInst::ICMP_ULE);
Sanjay Patel18254932016-05-17 01:12:31 +00004227 auto *CI = dyn_cast<ConstantInt>(Op1C);
4228 if (CI) {
Sanjay Patele9b2c322016-05-17 00:57:57 +00004229 // A <= MAX -> TRUE ; A >= MIN -> TRUE
4230 assert(IsLE ? !CI->isMaxValue(IsSigned) : !CI->isMinValue(IsSigned));
4231 } else if (Op1Type->isVectorTy()) {
Sanjay Patelb79ab272016-05-13 15:10:46 +00004232 // TODO? If the edge cases for vectors were guaranteed to be handled as they
Sanjay Patele9b2c322016-05-17 00:57:57 +00004233 // are for scalar, we could remove the min/max checks. However, to do that,
4234 // we would have to use insertelement/shufflevector to replace edge values.
4235 unsigned NumElts = Op1Type->getVectorNumElements();
4236 for (unsigned i = 0; i != NumElts; ++i) {
4237 Constant *Elt = Op1C->getAggregateElement(i);
Benjamin Kramerca9a0fe2016-05-17 12:08:55 +00004238 if (!Elt)
4239 return nullptr;
4240
Sanjay Patele9b2c322016-05-17 00:57:57 +00004241 if (isa<UndefValue>(Elt))
4242 continue;
Sanjay Patel06b127a2016-09-15 14:37:50 +00004243
Sanjay Patele9b2c322016-05-17 00:57:57 +00004244 // Bail out if we can't determine if this constant is min/max or if we
4245 // know that this constant is min/max.
4246 auto *CI = dyn_cast<ConstantInt>(Elt);
4247 if (!CI || (IsLE ? CI->isMaxValue(IsSigned) : CI->isMinValue(IsSigned)))
4248 return nullptr;
Sanjay Patelb79ab272016-05-13 15:10:46 +00004249 }
Sanjay Patele9b2c322016-05-17 00:57:57 +00004250 } else {
4251 // ConstantExpr?
4252 return nullptr;
Sanjay Patelb79ab272016-05-13 15:10:46 +00004253 }
Sanjay Pateld5b0e542016-04-29 16:22:25 +00004254
Sanjay Patele9b2c322016-05-17 00:57:57 +00004255 // Increment or decrement the constant and set the new comparison predicate:
4256 // ULE -> ULT ; UGE -> UGT ; SLE -> SLT ; SGE -> SGT
Sanjay Patel22b01fe2016-05-17 20:20:40 +00004257 Constant *OneOrNegOne = ConstantInt::get(Op1Type, IsLE ? 1 : -1, true);
Sanjay Patele9b2c322016-05-17 00:57:57 +00004258 CmpInst::Predicate NewPred = IsLE ? ICmpInst::ICMP_ULT: ICmpInst::ICMP_UGT;
4259 NewPred = IsSigned ? ICmpInst::getSignedPredicate(NewPred) : NewPred;
4260 return new ICmpInst(NewPred, Op0, ConstantExpr::getAdd(Op1C, OneOrNegOne));
Sanjay Pateld5b0e542016-04-29 16:22:25 +00004261}
4262
Sanjay Patele5747e32017-05-17 22:15:07 +00004263/// Integer compare with boolean values can always be turned into bitwise ops.
4264static Instruction *canonicalizeICmpBool(ICmpInst &I,
4265 InstCombiner::BuilderTy &Builder) {
4266 Value *A = I.getOperand(0), *B = I.getOperand(1);
4267 assert(A->getType()->getScalarType()->isIntegerTy(1) && "Bools only");
4268
Sanjay Patelba212c22017-05-17 22:29:40 +00004269 // A boolean compared to true/false can be simplified to Op0/true/false in
4270 // 14 out of the 20 (10 predicates * 2 constants) possible combinations.
4271 // Cases not handled by InstSimplify are always 'not' of Op0.
4272 if (match(B, m_Zero())) {
4273 switch (I.getPredicate()) {
4274 case CmpInst::ICMP_EQ: // A == 0 -> !A
4275 case CmpInst::ICMP_ULE: // A <=u 0 -> !A
4276 case CmpInst::ICMP_SGE: // A >=s 0 -> !A
4277 return BinaryOperator::CreateNot(A);
4278 default:
4279 llvm_unreachable("ICmp i1 X, C not simplified as expected.");
4280 }
4281 } else if (match(B, m_One())) {
4282 switch (I.getPredicate()) {
4283 case CmpInst::ICMP_NE: // A != 1 -> !A
4284 case CmpInst::ICMP_ULT: // A <u 1 -> !A
4285 case CmpInst::ICMP_SGT: // A >s -1 -> !A
4286 return BinaryOperator::CreateNot(A);
4287 default:
4288 llvm_unreachable("ICmp i1 X, C not simplified as expected.");
4289 }
4290 }
4291
Sanjay Patele5747e32017-05-17 22:15:07 +00004292 switch (I.getPredicate()) {
4293 default:
4294 llvm_unreachable("Invalid icmp instruction!");
4295 case ICmpInst::ICMP_EQ:
4296 // icmp eq i1 A, B -> ~(A ^ B)
4297 return BinaryOperator::CreateNot(Builder.CreateXor(A, B));
4298
4299 case ICmpInst::ICMP_NE:
4300 // icmp ne i1 A, B -> A ^ B
4301 return BinaryOperator::CreateXor(A, B);
4302
4303 case ICmpInst::ICMP_UGT:
4304 // icmp ugt -> icmp ult
4305 std::swap(A, B);
4306 LLVM_FALLTHROUGH;
4307 case ICmpInst::ICMP_ULT:
4308 // icmp ult i1 A, B -> ~A & B
4309 return BinaryOperator::CreateAnd(Builder.CreateNot(A), B);
4310
4311 case ICmpInst::ICMP_SGT:
4312 // icmp sgt -> icmp slt
4313 std::swap(A, B);
4314 LLVM_FALLTHROUGH;
4315 case ICmpInst::ICMP_SLT:
4316 // icmp slt i1 A, B -> A & ~B
4317 return BinaryOperator::CreateAnd(Builder.CreateNot(B), A);
4318
4319 case ICmpInst::ICMP_UGE:
4320 // icmp uge -> icmp ule
4321 std::swap(A, B);
4322 LLVM_FALLTHROUGH;
4323 case ICmpInst::ICMP_ULE:
4324 // icmp ule i1 A, B -> ~A | B
4325 return BinaryOperator::CreateOr(Builder.CreateNot(A), B);
4326
4327 case ICmpInst::ICMP_SGE:
4328 // icmp sge -> icmp sle
4329 std::swap(A, B);
4330 LLVM_FALLTHROUGH;
4331 case ICmpInst::ICMP_SLE:
4332 // icmp sle i1 A, B -> A | ~B
4333 return BinaryOperator::CreateOr(Builder.CreateNot(B), A);
4334 }
4335}
4336
Chris Lattner2188e402010-01-04 07:37:31 +00004337Instruction *InstCombiner::visitICmpInst(ICmpInst &I) {
4338 bool Changed = false;
Chris Lattner9306ffa2010-02-01 19:54:45 +00004339 Value *Op0 = I.getOperand(0), *Op1 = I.getOperand(1);
Quentin Colombet5ab55552013-09-09 20:56:48 +00004340 unsigned Op0Cplxity = getComplexity(Op0);
4341 unsigned Op1Cplxity = getComplexity(Op1);
Jim Grosbach129c52a2011-09-30 18:09:53 +00004342
Chris Lattner2188e402010-01-04 07:37:31 +00004343 /// Orders the operands of the compare so that they are listed from most
4344 /// complex to least complex. This puts constants before unary operators,
4345 /// before binary operators.
Quentin Colombet5ab55552013-09-09 20:56:48 +00004346 if (Op0Cplxity < Op1Cplxity ||
Sanjay Patel4c204232016-06-04 20:39:22 +00004347 (Op0Cplxity == Op1Cplxity && swapMayExposeCSEOpportunities(Op0, Op1))) {
Chris Lattner2188e402010-01-04 07:37:31 +00004348 I.swapOperands();
Chris Lattner9306ffa2010-02-01 19:54:45 +00004349 std::swap(Op0, Op1);
Chris Lattner2188e402010-01-04 07:37:31 +00004350 Changed = true;
4351 }
Jim Grosbach129c52a2011-09-30 18:09:53 +00004352
Daniel Berlin2c75c632017-04-26 20:56:07 +00004353 if (Value *V = SimplifyICmpInst(I.getPredicate(), Op0, Op1,
4354 SQ.getWithInstruction(&I)))
Sanjay Patel4b198802016-02-01 22:23:39 +00004355 return replaceInstUsesWith(I, V);
Jim Grosbach129c52a2011-09-30 18:09:53 +00004356
Pete Cooperbc5c5242011-12-01 03:58:40 +00004357 // comparing -val or val with non-zero is the same as just comparing val
Pete Cooperfdddc272011-12-01 19:13:26 +00004358 // ie, abs(val) != 0 -> val != 0
Sanjay Patel4c204232016-06-04 20:39:22 +00004359 if (I.getPredicate() == ICmpInst::ICMP_NE && match(Op1, m_Zero())) {
Pete Cooperfdddc272011-12-01 19:13:26 +00004360 Value *Cond, *SelectTrue, *SelectFalse;
4361 if (match(Op0, m_Select(m_Value(Cond), m_Value(SelectTrue),
Pete Cooperbc5c5242011-12-01 03:58:40 +00004362 m_Value(SelectFalse)))) {
Pete Cooperfdddc272011-12-01 19:13:26 +00004363 if (Value *V = dyn_castNegVal(SelectTrue)) {
4364 if (V == SelectFalse)
4365 return CmpInst::Create(Instruction::ICmp, I.getPredicate(), V, Op1);
4366 }
4367 else if (Value *V = dyn_castNegVal(SelectFalse)) {
4368 if (V == SelectTrue)
4369 return CmpInst::Create(Instruction::ICmp, I.getPredicate(), V, Op1);
Pete Cooperbc5c5242011-12-01 03:58:40 +00004370 }
4371 }
4372 }
4373
Sanjay Patele5747e32017-05-17 22:15:07 +00004374 if (Op0->getType()->getScalarType()->isIntegerTy(1))
4375 if (Instruction *Res = canonicalizeICmpBool(I, *Builder))
4376 return Res;
Chris Lattner2188e402010-01-04 07:37:31 +00004377
Sanjay Patele9b2c322016-05-17 00:57:57 +00004378 if (ICmpInst *NewICmp = canonicalizeCmpWithConstant(I))
Sanjay Pateld5b0e542016-04-29 16:22:25 +00004379 return NewICmp;
4380
Sanjay Patel06b127a2016-09-15 14:37:50 +00004381 if (Instruction *Res = foldICmpWithConstant(I))
4382 return Res;
Chris Lattner2188e402010-01-04 07:37:31 +00004383
Sanjay Patel3151dec2016-09-12 15:24:31 +00004384 if (Instruction *Res = foldICmpUsingKnownBits(I))
4385 return Res;
Chris Lattner2188e402010-01-04 07:37:31 +00004386
4387 // Test if the ICmpInst instruction is used exclusively by a select as
4388 // part of a minimum or maximum operation. If so, refrain from doing
4389 // any other folding. This helps out other analyses which understand
4390 // non-obfuscated minimum and maximum idioms, such as ScalarEvolution
4391 // and CodeGen. And in this case, at least one of the comparison
4392 // operands has at least one user besides the compare (the select),
4393 // which would often largely negate the benefit of folding anyway.
4394 if (I.hasOneUse())
Chandler Carruthcdf47882014-03-09 03:16:01 +00004395 if (SelectInst *SI = dyn_cast<SelectInst>(*I.user_begin()))
Chris Lattner2188e402010-01-04 07:37:31 +00004396 if ((SI->getOperand(1) == Op0 && SI->getOperand(2) == Op1) ||
4397 (SI->getOperand(2) == Op0 && SI->getOperand(1) == Op1))
Craig Topperf40110f2014-04-25 05:29:35 +00004398 return nullptr;
Chris Lattner2188e402010-01-04 07:37:31 +00004399
Sanjay Patelfebcb9c2017-01-27 23:26:27 +00004400 // FIXME: We only do this after checking for min/max to prevent infinite
4401 // looping caused by a reverse canonicalization of these patterns for min/max.
4402 // FIXME: The organization of folds is a mess. These would naturally go into
4403 // canonicalizeCmpWithConstant(), but we can't move all of the above folds
4404 // down here after the min/max restriction.
4405 ICmpInst::Predicate Pred = I.getPredicate();
4406 const APInt *C;
4407 if (match(Op1, m_APInt(C))) {
4408 // For i32: x >u 2147483647 -> x <s 0 -> true if sign bit set
4409 if (Pred == ICmpInst::ICMP_UGT && C->isMaxSignedValue()) {
4410 Constant *Zero = Constant::getNullValue(Op0->getType());
4411 return new ICmpInst(ICmpInst::ICMP_SLT, Op0, Zero);
4412 }
4413
4414 // For i32: x <u 2147483648 -> x >s -1 -> true if sign bit clear
4415 if (Pred == ICmpInst::ICMP_ULT && C->isMinSignedValue()) {
4416 Constant *AllOnes = Constant::getAllOnesValue(Op0->getType());
4417 return new ICmpInst(ICmpInst::ICMP_SGT, Op0, AllOnes);
4418 }
4419 }
4420
Sanjay Patelf58f68c2016-09-10 15:03:44 +00004421 if (Instruction *Res = foldICmpInstWithConstant(I))
Sanjay Patel1271bf92016-07-23 13:06:49 +00004422 return Res;
4423
Sanjay Patel10494b22016-09-16 16:10:22 +00004424 if (Instruction *Res = foldICmpInstWithConstantNotInt(I))
4425 return Res;
Chris Lattner2188e402010-01-04 07:37:31 +00004426
4427 // If we can optimize a 'icmp GEP, P' or 'icmp P, GEP', do so now.
4428 if (GEPOperator *GEP = dyn_cast<GEPOperator>(Op0))
Sanjay Patel43395062016-07-21 18:07:40 +00004429 if (Instruction *NI = foldGEPICmp(GEP, Op1, I.getPredicate(), I))
Chris Lattner2188e402010-01-04 07:37:31 +00004430 return NI;
4431 if (GEPOperator *GEP = dyn_cast<GEPOperator>(Op1))
Sanjay Patel43395062016-07-21 18:07:40 +00004432 if (Instruction *NI = foldGEPICmp(GEP, Op0,
Chris Lattner2188e402010-01-04 07:37:31 +00004433 ICmpInst::getSwappedPredicate(I.getPredicate()), I))
4434 return NI;
4435
Hans Wennborgf1f36512015-10-07 00:20:07 +00004436 // Try to optimize equality comparisons against alloca-based pointers.
4437 if (Op0->getType()->isPointerTy() && I.isEquality()) {
4438 assert(Op1->getType()->isPointerTy() && "Comparing pointer with non-pointer?");
4439 if (auto *Alloca = dyn_cast<AllocaInst>(GetUnderlyingObject(Op0, DL)))
Sanjay Patel43395062016-07-21 18:07:40 +00004440 if (Instruction *New = foldAllocaCmp(I, Alloca, Op1))
Hans Wennborgf1f36512015-10-07 00:20:07 +00004441 return New;
4442 if (auto *Alloca = dyn_cast<AllocaInst>(GetUnderlyingObject(Op1, DL)))
Sanjay Patel43395062016-07-21 18:07:40 +00004443 if (Instruction *New = foldAllocaCmp(I, Alloca, Op0))
Hans Wennborgf1f36512015-10-07 00:20:07 +00004444 return New;
4445 }
4446
Chris Lattner2188e402010-01-04 07:37:31 +00004447 // Test to see if the operands of the icmp are casted versions of other
4448 // values. If the ptr->ptr cast can be stripped off both arguments, we do so
4449 // now.
4450 if (BitCastInst *CI = dyn_cast<BitCastInst>(Op0)) {
Jim Grosbach129c52a2011-09-30 18:09:53 +00004451 if (Op0->getType()->isPointerTy() &&
4452 (isa<Constant>(Op1) || isa<BitCastInst>(Op1))) {
Chris Lattner2188e402010-01-04 07:37:31 +00004453 // We keep moving the cast from the left operand over to the right
4454 // operand, where it can often be eliminated completely.
4455 Op0 = CI->getOperand(0);
4456
4457 // If operand #1 is a bitcast instruction, it must also be a ptr->ptr cast
4458 // so eliminate it as well.
4459 if (BitCastInst *CI2 = dyn_cast<BitCastInst>(Op1))
4460 Op1 = CI2->getOperand(0);
4461
4462 // If Op1 is a constant, we can fold the cast into the constant.
4463 if (Op0->getType() != Op1->getType()) {
4464 if (Constant *Op1C = dyn_cast<Constant>(Op1)) {
4465 Op1 = ConstantExpr::getBitCast(Op1C, Op0->getType());
4466 } else {
4467 // Otherwise, cast the RHS right before the icmp
4468 Op1 = Builder->CreateBitCast(Op1, Op0->getType());
4469 }
4470 }
4471 return new ICmpInst(I.getPredicate(), Op0, Op1);
4472 }
4473 }
Jim Grosbach129c52a2011-09-30 18:09:53 +00004474
Chris Lattner2188e402010-01-04 07:37:31 +00004475 if (isa<CastInst>(Op0)) {
4476 // Handle the special case of: icmp (cast bool to X), <cst>
4477 // This comes up when you have code like
4478 // int X = A < B;
4479 // if (X) ...
4480 // For generality, we handle any zero-extension of any operand comparison
4481 // with a constant or another cast from the same type.
4482 if (isa<Constant>(Op1) || isa<CastInst>(Op1))
Sanjay Patel43395062016-07-21 18:07:40 +00004483 if (Instruction *R = foldICmpWithCastAndCast(I))
Chris Lattner2188e402010-01-04 07:37:31 +00004484 return R;
4485 }
Chris Lattner2188e402010-01-04 07:37:31 +00004486
Sanjay Patel10494b22016-09-16 16:10:22 +00004487 if (Instruction *Res = foldICmpBinOp(I))
4488 return Res;
Duncan Sandse5220012011-02-17 07:46:37 +00004489
Sanjay Pateldd46b522016-12-19 17:32:37 +00004490 if (Instruction *Res = foldICmpWithMinMax(I))
Sanjay Pateld6406412016-12-15 19:13:37 +00004491 return Res;
4492
Sanjay Patel10494b22016-09-16 16:10:22 +00004493 {
4494 Value *A, *B;
David Majnemer1a08acc2013-04-12 17:25:07 +00004495 // Transform (A & ~B) == 0 --> (A & B) != 0
4496 // and (A & ~B) != 0 --> (A & B) == 0
4497 // if A is a power of 2.
4498 if (match(Op0, m_And(m_Value(A), m_Not(m_Value(B)))) &&
Chandler Carruth66b31302015-01-04 12:03:27 +00004499 match(Op1, m_Zero()) &&
Daniel Jasperaec2fa32016-12-19 08:22:17 +00004500 isKnownToBeAPowerOfTwo(A, DL, false, 0, &AC, &I, &DT) && I.isEquality())
David Majnemer1a08acc2013-04-12 17:25:07 +00004501 return new ICmpInst(I.getInversePredicate(),
4502 Builder->CreateAnd(A, B),
4503 Op1);
4504
Chris Lattnerf3c4eef2011-01-15 05:41:33 +00004505 // ~x < ~y --> y < x
4506 // ~x < cst --> ~cst < x
4507 if (match(Op0, m_Not(m_Value(A)))) {
4508 if (match(Op1, m_Not(m_Value(B))))
4509 return new ICmpInst(I.getPredicate(), B, A);
Chris Lattner497459d2011-01-15 05:42:47 +00004510 if (ConstantInt *RHSC = dyn_cast<ConstantInt>(Op1))
Chris Lattnerf3c4eef2011-01-15 05:41:33 +00004511 return new ICmpInst(I.getPredicate(), ConstantExpr::getNot(RHSC), A);
4512 }
Chris Lattner5e0c0c72010-12-19 19:37:52 +00004513
Sanjoy Dasb6c59142015-04-10 21:07:09 +00004514 Instruction *AddI = nullptr;
4515 if (match(&I, m_UAddWithOverflow(m_Value(A), m_Value(B),
4516 m_Instruction(AddI))) &&
4517 isa<IntegerType>(A->getType())) {
4518 Value *Result;
4519 Constant *Overflow;
4520 if (OptimizeOverflowCheck(OCF_UNSIGNED_ADD, A, B, *AddI, Result,
4521 Overflow)) {
Sanjay Patel4b198802016-02-01 22:23:39 +00004522 replaceInstUsesWith(*AddI, Result);
4523 return replaceInstUsesWith(I, Overflow);
Sanjoy Dasb6c59142015-04-10 21:07:09 +00004524 }
4525 }
Serge Pavlov4bb54d52014-04-13 18:23:41 +00004526
4527 // (zext a) * (zext b) --> llvm.umul.with.overflow.
4528 if (match(Op0, m_Mul(m_ZExt(m_Value(A)), m_ZExt(m_Value(B))))) {
Sanjay Pateld93c4c02016-09-15 18:22:25 +00004529 if (Instruction *R = processUMulZExtIdiom(I, Op0, Op1, *this))
Serge Pavlov4bb54d52014-04-13 18:23:41 +00004530 return R;
4531 }
4532 if (match(Op1, m_Mul(m_ZExt(m_Value(A)), m_ZExt(m_Value(B))))) {
Sanjay Pateld93c4c02016-09-15 18:22:25 +00004533 if (Instruction *R = processUMulZExtIdiom(I, Op1, Op0, *this))
Serge Pavlov4bb54d52014-04-13 18:23:41 +00004534 return R;
4535 }
Chris Lattner2188e402010-01-04 07:37:31 +00004536 }
Jim Grosbach129c52a2011-09-30 18:09:53 +00004537
Sanjay Patel10494b22016-09-16 16:10:22 +00004538 if (Instruction *Res = foldICmpEquality(I))
4539 return Res;
Jim Grosbach129c52a2011-09-30 18:09:53 +00004540
David Majnemerc1eca5a2014-11-06 23:23:30 +00004541 // The 'cmpxchg' instruction returns an aggregate containing the old value and
4542 // an i1 which indicates whether or not we successfully did the swap.
4543 //
4544 // Replace comparisons between the old value and the expected value with the
4545 // indicator that 'cmpxchg' returns.
4546 //
4547 // N.B. This transform is only valid when the 'cmpxchg' is not permitted to
4548 // spuriously fail. In those cases, the old value may equal the expected
4549 // value but it is possible for the swap to not occur.
4550 if (I.getPredicate() == ICmpInst::ICMP_EQ)
4551 if (auto *EVI = dyn_cast<ExtractValueInst>(Op0))
4552 if (auto *ACXI = dyn_cast<AtomicCmpXchgInst>(EVI->getAggregateOperand()))
4553 if (EVI->getIndices()[0] == 0 && ACXI->getCompareOperand() == Op1 &&
4554 !ACXI->isWeak())
4555 return ExtractValueInst::Create(ACXI, 1);
4556
Chris Lattner2188e402010-01-04 07:37:31 +00004557 {
4558 Value *X; ConstantInt *Cst;
4559 // icmp X+Cst, X
4560 if (match(Op0, m_Add(m_Value(X), m_ConstantInt(Cst))) && Op1 == X)
Sanjay Patel43395062016-07-21 18:07:40 +00004561 return foldICmpAddOpConst(I, X, Cst, I.getPredicate());
Chris Lattner2188e402010-01-04 07:37:31 +00004562
4563 // icmp X, X+Cst
4564 if (match(Op1, m_Add(m_Value(X), m_ConstantInt(Cst))) && Op0 == X)
Sanjay Patel43395062016-07-21 18:07:40 +00004565 return foldICmpAddOpConst(I, X, Cst, I.getSwappedPredicate());
Chris Lattner2188e402010-01-04 07:37:31 +00004566 }
Craig Topperf40110f2014-04-25 05:29:35 +00004567 return Changed ? &I : nullptr;
Chris Lattner2188e402010-01-04 07:37:31 +00004568}
4569
Sanjay Patel5f0217f2016-06-05 16:46:18 +00004570/// Fold fcmp ([us]itofp x, cst) if possible.
Sanjay Patel43395062016-07-21 18:07:40 +00004571Instruction *InstCombiner::foldFCmpIntToFPConst(FCmpInst &I, Instruction *LHSI,
Chris Lattner2188e402010-01-04 07:37:31 +00004572 Constant *RHSC) {
Craig Topperf40110f2014-04-25 05:29:35 +00004573 if (!isa<ConstantFP>(RHSC)) return nullptr;
Chris Lattner2188e402010-01-04 07:37:31 +00004574 const APFloat &RHS = cast<ConstantFP>(RHSC)->getValueAPF();
Jim Grosbach129c52a2011-09-30 18:09:53 +00004575
Chris Lattner2188e402010-01-04 07:37:31 +00004576 // Get the width of the mantissa. We don't want to hack on conversions that
4577 // might lose information from the integer, e.g. "i64 -> float"
4578 int MantissaWidth = LHSI->getType()->getFPMantissaWidth();
Craig Topperf40110f2014-04-25 05:29:35 +00004579 if (MantissaWidth == -1) return nullptr; // Unknown.
Jim Grosbach129c52a2011-09-30 18:09:53 +00004580
Matt Arsenault55e73122015-01-06 15:50:59 +00004581 IntegerType *IntTy = cast<IntegerType>(LHSI->getOperand(0)->getType());
4582
Chris Lattner2188e402010-01-04 07:37:31 +00004583 bool LHSUnsigned = isa<UIToFPInst>(LHSI);
Jim Grosbach129c52a2011-09-30 18:09:53 +00004584
Matt Arsenault55e73122015-01-06 15:50:59 +00004585 if (I.isEquality()) {
4586 FCmpInst::Predicate P = I.getPredicate();
4587 bool IsExact = false;
4588 APSInt RHSCvt(IntTy->getBitWidth(), LHSUnsigned);
4589 RHS.convertToInteger(RHSCvt, APFloat::rmNearestTiesToEven, &IsExact);
4590
4591 // If the floating point constant isn't an integer value, we know if we will
4592 // ever compare equal / not equal to it.
4593 if (!IsExact) {
4594 // TODO: Can never be -0.0 and other non-representable values
4595 APFloat RHSRoundInt(RHS);
4596 RHSRoundInt.roundToIntegral(APFloat::rmNearestTiesToEven);
4597 if (RHS.compare(RHSRoundInt) != APFloat::cmpEqual) {
4598 if (P == FCmpInst::FCMP_OEQ || P == FCmpInst::FCMP_UEQ)
Sanjay Patel4b198802016-02-01 22:23:39 +00004599 return replaceInstUsesWith(I, Builder->getFalse());
Matt Arsenault55e73122015-01-06 15:50:59 +00004600
4601 assert(P == FCmpInst::FCMP_ONE || P == FCmpInst::FCMP_UNE);
Sanjay Patel4b198802016-02-01 22:23:39 +00004602 return replaceInstUsesWith(I, Builder->getTrue());
Matt Arsenault55e73122015-01-06 15:50:59 +00004603 }
4604 }
4605
4606 // TODO: If the constant is exactly representable, is it always OK to do
4607 // equality compares as integer?
4608 }
4609
Arch D. Robison8ed08542015-09-15 17:51:59 +00004610 // Check to see that the input is converted from an integer type that is small
4611 // enough that preserves all bits. TODO: check here for "known" sign bits.
4612 // This would allow us to handle (fptosi (x >>s 62) to float) if x is i64 f.e.
4613 unsigned InputSize = IntTy->getScalarSizeInBits();
Matt Arsenault55e73122015-01-06 15:50:59 +00004614
Justin Bognerc7e4fbe2016-08-05 01:09:48 +00004615 // Following test does NOT adjust InputSize downwards for signed inputs,
4616 // because the most negative value still requires all the mantissa bits
Arch D. Robison8ed08542015-09-15 17:51:59 +00004617 // to distinguish it from one less than that value.
4618 if ((int)InputSize > MantissaWidth) {
4619 // Conversion would lose accuracy. Check if loss can impact comparison.
4620 int Exp = ilogb(RHS);
4621 if (Exp == APFloat::IEK_Inf) {
4622 int MaxExponent = ilogb(APFloat::getLargest(RHS.getSemantics()));
Justin Bognerc7e4fbe2016-08-05 01:09:48 +00004623 if (MaxExponent < (int)InputSize - !LHSUnsigned)
Arch D. Robison8ed08542015-09-15 17:51:59 +00004624 // Conversion could create infinity.
4625 return nullptr;
4626 } else {
Justin Bognerc7e4fbe2016-08-05 01:09:48 +00004627 // Note that if RHS is zero or NaN, then Exp is negative
Arch D. Robison8ed08542015-09-15 17:51:59 +00004628 // and first condition is trivially false.
Justin Bognerc7e4fbe2016-08-05 01:09:48 +00004629 if (MantissaWidth <= Exp && Exp <= (int)InputSize - !LHSUnsigned)
Arch D. Robison8ed08542015-09-15 17:51:59 +00004630 // Conversion could affect comparison.
4631 return nullptr;
4632 }
4633 }
Jim Grosbach129c52a2011-09-30 18:09:53 +00004634
Chris Lattner2188e402010-01-04 07:37:31 +00004635 // Otherwise, we can potentially simplify the comparison. We know that it
4636 // will always come through as an integer value and we know the constant is
4637 // not a NAN (it would have been previously simplified).
4638 assert(!RHS.isNaN() && "NaN comparison not already folded!");
Jim Grosbach129c52a2011-09-30 18:09:53 +00004639
Chris Lattner2188e402010-01-04 07:37:31 +00004640 ICmpInst::Predicate Pred;
4641 switch (I.getPredicate()) {
4642 default: llvm_unreachable("Unexpected predicate!");
4643 case FCmpInst::FCMP_UEQ:
4644 case FCmpInst::FCMP_OEQ:
4645 Pred = ICmpInst::ICMP_EQ;
4646 break;
4647 case FCmpInst::FCMP_UGT:
4648 case FCmpInst::FCMP_OGT:
4649 Pred = LHSUnsigned ? ICmpInst::ICMP_UGT : ICmpInst::ICMP_SGT;
4650 break;
4651 case FCmpInst::FCMP_UGE:
4652 case FCmpInst::FCMP_OGE:
4653 Pred = LHSUnsigned ? ICmpInst::ICMP_UGE : ICmpInst::ICMP_SGE;
4654 break;
4655 case FCmpInst::FCMP_ULT:
4656 case FCmpInst::FCMP_OLT:
4657 Pred = LHSUnsigned ? ICmpInst::ICMP_ULT : ICmpInst::ICMP_SLT;
4658 break;
4659 case FCmpInst::FCMP_ULE:
4660 case FCmpInst::FCMP_OLE:
4661 Pred = LHSUnsigned ? ICmpInst::ICMP_ULE : ICmpInst::ICMP_SLE;
4662 break;
4663 case FCmpInst::FCMP_UNE:
4664 case FCmpInst::FCMP_ONE:
4665 Pred = ICmpInst::ICMP_NE;
4666 break;
4667 case FCmpInst::FCMP_ORD:
Sanjay Patel4b198802016-02-01 22:23:39 +00004668 return replaceInstUsesWith(I, Builder->getTrue());
Chris Lattner2188e402010-01-04 07:37:31 +00004669 case FCmpInst::FCMP_UNO:
Sanjay Patel4b198802016-02-01 22:23:39 +00004670 return replaceInstUsesWith(I, Builder->getFalse());
Chris Lattner2188e402010-01-04 07:37:31 +00004671 }
Jim Grosbach129c52a2011-09-30 18:09:53 +00004672
Chris Lattner2188e402010-01-04 07:37:31 +00004673 // Now we know that the APFloat is a normal number, zero or inf.
Jim Grosbach129c52a2011-09-30 18:09:53 +00004674
Chris Lattner2188e402010-01-04 07:37:31 +00004675 // See if the FP constant is too large for the integer. For example,
4676 // comparing an i8 to 300.0.
4677 unsigned IntWidth = IntTy->getScalarSizeInBits();
Jim Grosbach129c52a2011-09-30 18:09:53 +00004678
Chris Lattner2188e402010-01-04 07:37:31 +00004679 if (!LHSUnsigned) {
4680 // If the RHS value is > SignedMax, fold the comparison. This handles +INF
4681 // and large values.
Michael Gottesman79b09672013-06-27 21:58:19 +00004682 APFloat SMax(RHS.getSemantics());
Chris Lattner2188e402010-01-04 07:37:31 +00004683 SMax.convertFromAPInt(APInt::getSignedMaxValue(IntWidth), true,
4684 APFloat::rmNearestTiesToEven);
4685 if (SMax.compare(RHS) == APFloat::cmpLessThan) { // smax < 13123.0
4686 if (Pred == ICmpInst::ICMP_NE || Pred == ICmpInst::ICMP_SLT ||
4687 Pred == ICmpInst::ICMP_SLE)
Sanjay Patel4b198802016-02-01 22:23:39 +00004688 return replaceInstUsesWith(I, Builder->getTrue());
4689 return replaceInstUsesWith(I, Builder->getFalse());
Chris Lattner2188e402010-01-04 07:37:31 +00004690 }
4691 } else {
4692 // If the RHS value is > UnsignedMax, fold the comparison. This handles
4693 // +INF and large values.
Michael Gottesman79b09672013-06-27 21:58:19 +00004694 APFloat UMax(RHS.getSemantics());
Chris Lattner2188e402010-01-04 07:37:31 +00004695 UMax.convertFromAPInt(APInt::getMaxValue(IntWidth), false,
4696 APFloat::rmNearestTiesToEven);
4697 if (UMax.compare(RHS) == APFloat::cmpLessThan) { // umax < 13123.0
4698 if (Pred == ICmpInst::ICMP_NE || Pred == ICmpInst::ICMP_ULT ||
4699 Pred == ICmpInst::ICMP_ULE)
Sanjay Patel4b198802016-02-01 22:23:39 +00004700 return replaceInstUsesWith(I, Builder->getTrue());
4701 return replaceInstUsesWith(I, Builder->getFalse());
Chris Lattner2188e402010-01-04 07:37:31 +00004702 }
4703 }
Jim Grosbach129c52a2011-09-30 18:09:53 +00004704
Chris Lattner2188e402010-01-04 07:37:31 +00004705 if (!LHSUnsigned) {
4706 // See if the RHS value is < SignedMin.
Michael Gottesman79b09672013-06-27 21:58:19 +00004707 APFloat SMin(RHS.getSemantics());
Chris Lattner2188e402010-01-04 07:37:31 +00004708 SMin.convertFromAPInt(APInt::getSignedMinValue(IntWidth), true,
4709 APFloat::rmNearestTiesToEven);
4710 if (SMin.compare(RHS) == APFloat::cmpGreaterThan) { // smin > 12312.0
4711 if (Pred == ICmpInst::ICMP_NE || Pred == ICmpInst::ICMP_SGT ||
4712 Pred == ICmpInst::ICMP_SGE)
Sanjay Patel4b198802016-02-01 22:23:39 +00004713 return replaceInstUsesWith(I, Builder->getTrue());
4714 return replaceInstUsesWith(I, Builder->getFalse());
Chris Lattner2188e402010-01-04 07:37:31 +00004715 }
Devang Patel698452b2012-02-13 23:05:18 +00004716 } else {
4717 // See if the RHS value is < UnsignedMin.
Michael Gottesman79b09672013-06-27 21:58:19 +00004718 APFloat SMin(RHS.getSemantics());
Devang Patel698452b2012-02-13 23:05:18 +00004719 SMin.convertFromAPInt(APInt::getMinValue(IntWidth), true,
4720 APFloat::rmNearestTiesToEven);
4721 if (SMin.compare(RHS) == APFloat::cmpGreaterThan) { // umin > 12312.0
4722 if (Pred == ICmpInst::ICMP_NE || Pred == ICmpInst::ICMP_UGT ||
4723 Pred == ICmpInst::ICMP_UGE)
Sanjay Patel4b198802016-02-01 22:23:39 +00004724 return replaceInstUsesWith(I, Builder->getTrue());
4725 return replaceInstUsesWith(I, Builder->getFalse());
Devang Patel698452b2012-02-13 23:05:18 +00004726 }
Chris Lattner2188e402010-01-04 07:37:31 +00004727 }
4728
4729 // Okay, now we know that the FP constant fits in the range [SMIN, SMAX] or
4730 // [0, UMAX], but it may still be fractional. See if it is fractional by
4731 // casting the FP value to the integer value and back, checking for equality.
4732 // Don't do this for zero, because -0.0 is not fractional.
4733 Constant *RHSInt = LHSUnsigned
4734 ? ConstantExpr::getFPToUI(RHSC, IntTy)
4735 : ConstantExpr::getFPToSI(RHSC, IntTy);
4736 if (!RHS.isZero()) {
4737 bool Equal = LHSUnsigned
4738 ? ConstantExpr::getUIToFP(RHSInt, RHSC->getType()) == RHSC
4739 : ConstantExpr::getSIToFP(RHSInt, RHSC->getType()) == RHSC;
4740 if (!Equal) {
4741 // If we had a comparison against a fractional value, we have to adjust
4742 // the compare predicate and sometimes the value. RHSC is rounded towards
4743 // zero at this point.
4744 switch (Pred) {
4745 default: llvm_unreachable("Unexpected integer comparison!");
4746 case ICmpInst::ICMP_NE: // (float)int != 4.4 --> true
Sanjay Patel4b198802016-02-01 22:23:39 +00004747 return replaceInstUsesWith(I, Builder->getTrue());
Chris Lattner2188e402010-01-04 07:37:31 +00004748 case ICmpInst::ICMP_EQ: // (float)int == 4.4 --> false
Sanjay Patel4b198802016-02-01 22:23:39 +00004749 return replaceInstUsesWith(I, Builder->getFalse());
Chris Lattner2188e402010-01-04 07:37:31 +00004750 case ICmpInst::ICMP_ULE:
4751 // (float)int <= 4.4 --> int <= 4
4752 // (float)int <= -4.4 --> false
4753 if (RHS.isNegative())
Sanjay Patel4b198802016-02-01 22:23:39 +00004754 return replaceInstUsesWith(I, Builder->getFalse());
Chris Lattner2188e402010-01-04 07:37:31 +00004755 break;
4756 case ICmpInst::ICMP_SLE:
4757 // (float)int <= 4.4 --> int <= 4
4758 // (float)int <= -4.4 --> int < -4
4759 if (RHS.isNegative())
4760 Pred = ICmpInst::ICMP_SLT;
4761 break;
4762 case ICmpInst::ICMP_ULT:
4763 // (float)int < -4.4 --> false
4764 // (float)int < 4.4 --> int <= 4
4765 if (RHS.isNegative())
Sanjay Patel4b198802016-02-01 22:23:39 +00004766 return replaceInstUsesWith(I, Builder->getFalse());
Chris Lattner2188e402010-01-04 07:37:31 +00004767 Pred = ICmpInst::ICMP_ULE;
4768 break;
4769 case ICmpInst::ICMP_SLT:
4770 // (float)int < -4.4 --> int < -4
4771 // (float)int < 4.4 --> int <= 4
4772 if (!RHS.isNegative())
4773 Pred = ICmpInst::ICMP_SLE;
4774 break;
4775 case ICmpInst::ICMP_UGT:
4776 // (float)int > 4.4 --> int > 4
4777 // (float)int > -4.4 --> true
4778 if (RHS.isNegative())
Sanjay Patel4b198802016-02-01 22:23:39 +00004779 return replaceInstUsesWith(I, Builder->getTrue());
Chris Lattner2188e402010-01-04 07:37:31 +00004780 break;
4781 case ICmpInst::ICMP_SGT:
4782 // (float)int > 4.4 --> int > 4
4783 // (float)int > -4.4 --> int >= -4
4784 if (RHS.isNegative())
4785 Pred = ICmpInst::ICMP_SGE;
4786 break;
4787 case ICmpInst::ICMP_UGE:
4788 // (float)int >= -4.4 --> true
4789 // (float)int >= 4.4 --> int > 4
Bob Wilson61f3ad52012-08-07 22:35:16 +00004790 if (RHS.isNegative())
Sanjay Patel4b198802016-02-01 22:23:39 +00004791 return replaceInstUsesWith(I, Builder->getTrue());
Chris Lattner2188e402010-01-04 07:37:31 +00004792 Pred = ICmpInst::ICMP_UGT;
4793 break;
4794 case ICmpInst::ICMP_SGE:
4795 // (float)int >= -4.4 --> int >= -4
4796 // (float)int >= 4.4 --> int > 4
4797 if (!RHS.isNegative())
4798 Pred = ICmpInst::ICMP_SGT;
4799 break;
4800 }
4801 }
4802 }
4803
4804 // Lower this FP comparison into an appropriate integer version of the
4805 // comparison.
4806 return new ICmpInst(Pred, LHSI->getOperand(0), RHSInt);
4807}
4808
4809Instruction *InstCombiner::visitFCmpInst(FCmpInst &I) {
4810 bool Changed = false;
Jim Grosbach129c52a2011-09-30 18:09:53 +00004811
Chris Lattner2188e402010-01-04 07:37:31 +00004812 /// Orders the operands of the compare so that they are listed from most
4813 /// complex to least complex. This puts constants before unary operators,
4814 /// before binary operators.
4815 if (getComplexity(I.getOperand(0)) < getComplexity(I.getOperand(1))) {
4816 I.swapOperands();
4817 Changed = true;
4818 }
4819
4820 Value *Op0 = I.getOperand(0), *Op1 = I.getOperand(1);
Jim Grosbach129c52a2011-09-30 18:09:53 +00004821
Daniel Berlin2c75c632017-04-26 20:56:07 +00004822 if (Value *V =
4823 SimplifyFCmpInst(I.getPredicate(), Op0, Op1, I.getFastMathFlags(),
4824 SQ.getWithInstruction(&I)))
Sanjay Patel4b198802016-02-01 22:23:39 +00004825 return replaceInstUsesWith(I, V);
Chris Lattner2188e402010-01-04 07:37:31 +00004826
4827 // Simplify 'fcmp pred X, X'
4828 if (Op0 == Op1) {
4829 switch (I.getPredicate()) {
4830 default: llvm_unreachable("Unknown predicate!");
4831 case FCmpInst::FCMP_UNO: // True if unordered: isnan(X) | isnan(Y)
4832 case FCmpInst::FCMP_ULT: // True if unordered or less than
4833 case FCmpInst::FCMP_UGT: // True if unordered or greater than
4834 case FCmpInst::FCMP_UNE: // True if unordered or not equal
4835 // Canonicalize these to be 'fcmp uno %X, 0.0'.
4836 I.setPredicate(FCmpInst::FCMP_UNO);
4837 I.setOperand(1, Constant::getNullValue(Op0->getType()));
4838 return &I;
Jim Grosbach129c52a2011-09-30 18:09:53 +00004839
Chris Lattner2188e402010-01-04 07:37:31 +00004840 case FCmpInst::FCMP_ORD: // True if ordered (no nans)
4841 case FCmpInst::FCMP_OEQ: // True if ordered and equal
4842 case FCmpInst::FCMP_OGE: // True if ordered and greater than or equal
4843 case FCmpInst::FCMP_OLE: // True if ordered and less than or equal
4844 // Canonicalize these to be 'fcmp ord %X, 0.0'.
4845 I.setPredicate(FCmpInst::FCMP_ORD);
4846 I.setOperand(1, Constant::getNullValue(Op0->getType()));
4847 return &I;
4848 }
4849 }
Jim Grosbach129c52a2011-09-30 18:09:53 +00004850
James Molloy2b21a7c2015-05-20 18:41:25 +00004851 // Test if the FCmpInst instruction is used exclusively by a select as
4852 // part of a minimum or maximum operation. If so, refrain from doing
4853 // any other folding. This helps out other analyses which understand
4854 // non-obfuscated minimum and maximum idioms, such as ScalarEvolution
4855 // and CodeGen. And in this case, at least one of the comparison
4856 // operands has at least one user besides the compare (the select),
4857 // which would often largely negate the benefit of folding anyway.
4858 if (I.hasOneUse())
4859 if (SelectInst *SI = dyn_cast<SelectInst>(*I.user_begin()))
4860 if ((SI->getOperand(1) == Op0 && SI->getOperand(2) == Op1) ||
4861 (SI->getOperand(2) == Op0 && SI->getOperand(1) == Op1))
4862 return nullptr;
4863
Chris Lattner2188e402010-01-04 07:37:31 +00004864 // Handle fcmp with constant RHS
4865 if (Constant *RHSC = dyn_cast<Constant>(Op1)) {
4866 if (Instruction *LHSI = dyn_cast<Instruction>(Op0))
4867 switch (LHSI->getOpcode()) {
Benjamin Kramercbb18e92011-03-31 10:12:07 +00004868 case Instruction::FPExt: {
4869 // fcmp (fpext x), C -> fcmp x, (fptrunc C) if fptrunc is lossless
4870 FPExtInst *LHSExt = cast<FPExtInst>(LHSI);
4871 ConstantFP *RHSF = dyn_cast<ConstantFP>(RHSC);
4872 if (!RHSF)
4873 break;
4874
4875 const fltSemantics *Sem;
4876 // FIXME: This shouldn't be here.
Dan Gohman518cda42011-12-17 00:04:22 +00004877 if (LHSExt->getSrcTy()->isHalfTy())
Stephan Bergmann17c7f702016-12-14 11:57:17 +00004878 Sem = &APFloat::IEEEhalf();
Dan Gohman518cda42011-12-17 00:04:22 +00004879 else if (LHSExt->getSrcTy()->isFloatTy())
Stephan Bergmann17c7f702016-12-14 11:57:17 +00004880 Sem = &APFloat::IEEEsingle();
Benjamin Kramercbb18e92011-03-31 10:12:07 +00004881 else if (LHSExt->getSrcTy()->isDoubleTy())
Stephan Bergmann17c7f702016-12-14 11:57:17 +00004882 Sem = &APFloat::IEEEdouble();
Benjamin Kramercbb18e92011-03-31 10:12:07 +00004883 else if (LHSExt->getSrcTy()->isFP128Ty())
Stephan Bergmann17c7f702016-12-14 11:57:17 +00004884 Sem = &APFloat::IEEEquad();
Benjamin Kramercbb18e92011-03-31 10:12:07 +00004885 else if (LHSExt->getSrcTy()->isX86_FP80Ty())
Stephan Bergmann17c7f702016-12-14 11:57:17 +00004886 Sem = &APFloat::x87DoubleExtended();
Ulrich Weigand6a9bb512012-10-30 12:33:18 +00004887 else if (LHSExt->getSrcTy()->isPPC_FP128Ty())
Stephan Bergmann17c7f702016-12-14 11:57:17 +00004888 Sem = &APFloat::PPCDoubleDouble();
Benjamin Kramercbb18e92011-03-31 10:12:07 +00004889 else
4890 break;
4891
4892 bool Lossy;
4893 APFloat F = RHSF->getValueAPF();
4894 F.convert(*Sem, APFloat::rmNearestTiesToEven, &Lossy);
4895
Jim Grosbach24ff8342011-09-30 18:45:50 +00004896 // Avoid lossy conversions and denormals. Zero is a special case
4897 // that's OK to convert.
Jim Grosbach011dafb2011-09-30 19:58:46 +00004898 APFloat Fabs = F;
4899 Fabs.clearSign();
Benjamin Kramercbb18e92011-03-31 10:12:07 +00004900 if (!Lossy &&
Jim Grosbach011dafb2011-09-30 19:58:46 +00004901 ((Fabs.compare(APFloat::getSmallestNormalized(*Sem)) !=
4902 APFloat::cmpLessThan) || Fabs.isZero()))
Jim Grosbach24ff8342011-09-30 18:45:50 +00004903
Benjamin Kramercbb18e92011-03-31 10:12:07 +00004904 return new FCmpInst(I.getPredicate(), LHSExt->getOperand(0),
4905 ConstantFP::get(RHSC->getContext(), F));
4906 break;
4907 }
Chris Lattner2188e402010-01-04 07:37:31 +00004908 case Instruction::PHI:
4909 // Only fold fcmp into the PHI if the phi and fcmp are in the same
4910 // block. If in the same block, we're encouraging jump threading. If
4911 // not, we are just pessimizing the code by making an i1 phi.
4912 if (LHSI->getParent() == I.getParent())
Craig Topperfb71b7d2017-04-14 19:20:12 +00004913 if (Instruction *NV = foldOpIntoPhi(I, cast<PHINode>(LHSI)))
Chris Lattner2188e402010-01-04 07:37:31 +00004914 return NV;
4915 break;
4916 case Instruction::SIToFP:
4917 case Instruction::UIToFP:
Sanjay Patel43395062016-07-21 18:07:40 +00004918 if (Instruction *NV = foldFCmpIntToFPConst(I, LHSI, RHSC))
Chris Lattner2188e402010-01-04 07:37:31 +00004919 return NV;
4920 break;
Benjamin Kramera8c5d082011-03-31 10:12:15 +00004921 case Instruction::FSub: {
4922 // fcmp pred (fneg x), C -> fcmp swap(pred) x, -C
4923 Value *Op;
4924 if (match(LHSI, m_FNeg(m_Value(Op))))
4925 return new FCmpInst(I.getSwappedPredicate(), Op,
4926 ConstantExpr::getFNeg(RHSC));
4927 break;
4928 }
Dan Gohman94732022010-02-24 06:46:09 +00004929 case Instruction::Load:
4930 if (GetElementPtrInst *GEP =
4931 dyn_cast<GetElementPtrInst>(LHSI->getOperand(0))) {
4932 if (GlobalVariable *GV = dyn_cast<GlobalVariable>(GEP->getOperand(0)))
4933 if (GV->isConstant() && GV->hasDefinitiveInitializer() &&
4934 !cast<LoadInst>(LHSI)->isVolatile())
Sanjay Patel43395062016-07-21 18:07:40 +00004935 if (Instruction *Res = foldCmpLoadFromIndexedGlobal(GEP, GV, I))
Dan Gohman94732022010-02-24 06:46:09 +00004936 return Res;
4937 }
4938 break;
Benjamin Kramer8c2a7332012-08-18 20:06:47 +00004939 case Instruction::Call: {
Matt Arsenaultb935d9d2015-01-08 20:09:34 +00004940 if (!RHSC->isNullValue())
4941 break;
4942
Benjamin Kramer8c2a7332012-08-18 20:06:47 +00004943 CallInst *CI = cast<CallInst>(LHSI);
Justin Bogner99798402016-08-05 01:06:44 +00004944 Intrinsic::ID IID = getIntrinsicForCallSite(CI, &TLI);
David Majnemer2e02ba72016-04-15 17:21:03 +00004945 if (IID != Intrinsic::fabs)
Matt Arsenaultb935d9d2015-01-08 20:09:34 +00004946 break;
4947
Benjamin Kramer8c2a7332012-08-18 20:06:47 +00004948 // Various optimization for fabs compared with zero.
David Majnemer2e02ba72016-04-15 17:21:03 +00004949 switch (I.getPredicate()) {
4950 default:
4951 break;
4952 // fabs(x) < 0 --> false
4953 case FCmpInst::FCMP_OLT:
4954 llvm_unreachable("handled by SimplifyFCmpInst");
4955 // fabs(x) > 0 --> x != 0
4956 case FCmpInst::FCMP_OGT:
4957 return new FCmpInst(FCmpInst::FCMP_ONE, CI->getArgOperand(0), RHSC);
4958 // fabs(x) <= 0 --> x == 0
4959 case FCmpInst::FCMP_OLE:
4960 return new FCmpInst(FCmpInst::FCMP_OEQ, CI->getArgOperand(0), RHSC);
4961 // fabs(x) >= 0 --> !isnan(x)
4962 case FCmpInst::FCMP_OGE:
4963 return new FCmpInst(FCmpInst::FCMP_ORD, CI->getArgOperand(0), RHSC);
4964 // fabs(x) == 0 --> x == 0
4965 // fabs(x) != 0 --> x != 0
4966 case FCmpInst::FCMP_OEQ:
4967 case FCmpInst::FCMP_UEQ:
4968 case FCmpInst::FCMP_ONE:
4969 case FCmpInst::FCMP_UNE:
4970 return new FCmpInst(I.getPredicate(), CI->getArgOperand(0), RHSC);
Benjamin Kramer8c2a7332012-08-18 20:06:47 +00004971 }
4972 }
Chris Lattner2188e402010-01-04 07:37:31 +00004973 }
Chris Lattner2188e402010-01-04 07:37:31 +00004974 }
4975
Benjamin Kramerbe209ab2011-03-31 10:46:03 +00004976 // fcmp pred (fneg x), (fneg y) -> fcmp swap(pred) x, y
Benjamin Kramerd159d942011-03-31 10:12:22 +00004977 Value *X, *Y;
4978 if (match(Op0, m_FNeg(m_Value(X))) && match(Op1, m_FNeg(m_Value(Y))))
Benjamin Kramerbe209ab2011-03-31 10:46:03 +00004979 return new FCmpInst(I.getSwappedPredicate(), X, Y);
Benjamin Kramerd159d942011-03-31 10:12:22 +00004980
Benjamin Kramer2ccfbc82011-03-31 10:11:58 +00004981 // fcmp (fpext x), (fpext y) -> fcmp x, y
4982 if (FPExtInst *LHSExt = dyn_cast<FPExtInst>(Op0))
4983 if (FPExtInst *RHSExt = dyn_cast<FPExtInst>(Op1))
4984 if (LHSExt->getSrcTy() == RHSExt->getSrcTy())
4985 return new FCmpInst(I.getPredicate(), LHSExt->getOperand(0),
4986 RHSExt->getOperand(0));
4987
Craig Topperf40110f2014-04-25 05:29:35 +00004988 return Changed ? &I : nullptr;
Chris Lattner2188e402010-01-04 07:37:31 +00004989}