blob: 8dbf5aa523b8e2f8e8fa5ed940c442bf16ebe693 [file] [log] [blame]
Chris Lattner2188e402010-01-04 07:37:31 +00001//===- InstCombineCompares.cpp --------------------------------------------===//
2//
3// The LLVM Compiler Infrastructure
4//
5// This file is distributed under the University of Illinois Open Source
6// License. See LICENSE.TXT for details.
7//
8//===----------------------------------------------------------------------===//
9//
10// This file implements the visitICmp and visitFCmp functions.
11//
12//===----------------------------------------------------------------------===//
13
Chandler Carrutha9174582015-01-22 05:25:13 +000014#include "InstCombineInternal.h"
Matt Arsenault55e73122015-01-06 15:50:59 +000015#include "llvm/ADT/APSInt.h"
Silviu Barangaf29dfd32016-01-15 15:52:05 +000016#include "llvm/ADT/SetVector.h"
Gerolf Hoflehnerec6217c2014-11-21 23:36:44 +000017#include "llvm/ADT/Statistic.h"
Eli Friedman911e12f2011-07-20 21:57:23 +000018#include "llvm/Analysis/ConstantFolding.h"
Chris Lattner2188e402010-01-04 07:37:31 +000019#include "llvm/Analysis/InstructionSimplify.h"
Mehdi Aminib550cb12016-04-18 09:17:29 +000020#include "llvm/Analysis/TargetLibraryInfo.h"
Chandler Carruth8cd041e2014-03-04 12:24:34 +000021#include "llvm/IR/ConstantRange.h"
Chandler Carruth9fb823b2013-01-02 11:36:10 +000022#include "llvm/IR/DataLayout.h"
Chandler Carruth03eb0de2014-03-04 10:40:04 +000023#include "llvm/IR/GetElementPtrTypeIterator.h"
Chandler Carruth9fb823b2013-01-02 11:36:10 +000024#include "llvm/IR/IntrinsicInst.h"
Chandler Carruth820a9082014-03-04 11:08:18 +000025#include "llvm/IR/PatternMatch.h"
Gerolf Hoflehnerec6217c2014-11-21 23:36:44 +000026#include "llvm/Support/Debug.h"
Craig Topperb45eabc2017-04-26 16:39:58 +000027#include "llvm/Support/KnownBits.h"
Gerolf Hoflehnerec6217c2014-11-21 23:36:44 +000028
Chris Lattner2188e402010-01-04 07:37:31 +000029using namespace llvm;
30using namespace PatternMatch;
31
Chandler Carruth964daaa2014-04-22 02:55:47 +000032#define DEBUG_TYPE "instcombine"
33
Gerolf Hoflehnerec6217c2014-11-21 23:36:44 +000034// How many times is a select replaced by one of its operands?
35STATISTIC(NumSel, "Number of select opts");
36
Chris Lattner98457102011-02-10 05:23:05 +000037
Sanjay Patel5f0217f2016-06-05 16:46:18 +000038/// Compute Result = In1+In2, returning true if the result overflowed for this
39/// type.
Craig Topper6e025a32017-10-01 23:53:54 +000040static bool addWithOverflow(APInt &Result, const APInt &In1,
41 const APInt &In2, bool IsSigned = false) {
42 bool Overflow;
43 if (IsSigned)
44 Result = In1.sadd_ov(In2, Overflow);
45 else
46 Result = In1.uadd_ov(In2, Overflow);
Chris Lattner2188e402010-01-04 07:37:31 +000047
Craig Topper6e025a32017-10-01 23:53:54 +000048 return Overflow;
Chris Lattner2188e402010-01-04 07:37:31 +000049}
50
Sanjay Patel5f0217f2016-06-05 16:46:18 +000051/// Compute Result = In1-In2, returning true if the result overflowed for this
52/// type.
Craig Topper6e025a32017-10-01 23:53:54 +000053static bool subWithOverflow(APInt &Result, const APInt &In1,
54 const APInt &In2, bool IsSigned = false) {
55 bool Overflow;
56 if (IsSigned)
57 Result = In1.ssub_ov(In2, Overflow);
58 else
59 Result = In1.usub_ov(In2, Overflow);
Chris Lattner2188e402010-01-04 07:37:31 +000060
Craig Topper6e025a32017-10-01 23:53:54 +000061 return Overflow;
Chris Lattner2188e402010-01-04 07:37:31 +000062}
63
Balaram Makam569eaec2016-05-04 21:32:14 +000064/// Given an icmp instruction, return true if any use of this comparison is a
65/// branch on sign bit comparison.
Eric Christopher710c1c82017-06-30 01:35:31 +000066static bool hasBranchUse(ICmpInst &I) {
Balaram Makam569eaec2016-05-04 21:32:14 +000067 for (auto *U : I.users())
68 if (isa<BranchInst>(U))
Eric Christopher710c1c82017-06-30 01:35:31 +000069 return true;
Balaram Makam569eaec2016-05-04 21:32:14 +000070 return false;
71}
72
Sanjay Patel5f0217f2016-06-05 16:46:18 +000073/// Given an exploded icmp instruction, return true if the comparison only
74/// checks the sign bit. If it only checks the sign bit, set TrueIfSigned if the
75/// result of the comparison is true when the input value is signed.
Sanjay Patel79263662016-08-21 15:07:45 +000076static bool isSignBitCheck(ICmpInst::Predicate Pred, const APInt &RHS,
Chris Lattner2188e402010-01-04 07:37:31 +000077 bool &TrueIfSigned) {
Sanjay Patel5f0217f2016-06-05 16:46:18 +000078 switch (Pred) {
Chris Lattner2188e402010-01-04 07:37:31 +000079 case ICmpInst::ICMP_SLT: // True if LHS s< 0
80 TrueIfSigned = true;
Craig Topper73ba1c82017-06-07 07:40:37 +000081 return RHS.isNullValue();
Chris Lattner2188e402010-01-04 07:37:31 +000082 case ICmpInst::ICMP_SLE: // True if LHS s<= RHS and RHS == -1
83 TrueIfSigned = true;
Sanjay Patel79263662016-08-21 15:07:45 +000084 return RHS.isAllOnesValue();
Chris Lattner2188e402010-01-04 07:37:31 +000085 case ICmpInst::ICMP_SGT: // True if LHS s> -1
86 TrueIfSigned = false;
Sanjay Patel79263662016-08-21 15:07:45 +000087 return RHS.isAllOnesValue();
Chris Lattner2188e402010-01-04 07:37:31 +000088 case ICmpInst::ICMP_UGT:
89 // True if LHS u> RHS and RHS == high-bit-mask - 1
90 TrueIfSigned = true;
Sanjay Patel79263662016-08-21 15:07:45 +000091 return RHS.isMaxSignedValue();
Jim Grosbach129c52a2011-09-30 18:09:53 +000092 case ICmpInst::ICMP_UGE:
Chris Lattner2188e402010-01-04 07:37:31 +000093 // True if LHS u>= RHS and RHS == high-bit-mask (2^7, 2^15, 2^31, etc)
94 TrueIfSigned = true;
Craig Topperbcfd2d12017-04-20 16:56:25 +000095 return RHS.isSignMask();
Chris Lattner2188e402010-01-04 07:37:31 +000096 default:
97 return false;
98 }
99}
100
Arnaud A. de Grandmaison3ee88e82013-03-25 11:47:38 +0000101/// Returns true if the exploded icmp can be expressed as a signed comparison
102/// to zero and updates the predicate accordingly.
103/// The signedness of the comparison is preserved.
Sanjay Patel5b112842016-08-18 14:59:14 +0000104/// TODO: Refactor with decomposeBitTestICmp()?
105static bool isSignTest(ICmpInst::Predicate &Pred, const APInt &C) {
Sanjay Patel5f0217f2016-06-05 16:46:18 +0000106 if (!ICmpInst::isSigned(Pred))
Arnaud A. de Grandmaison9c383d62013-03-25 09:48:49 +0000107 return false;
108
Craig Topper73ba1c82017-06-07 07:40:37 +0000109 if (C.isNullValue())
Sanjay Patel5f0217f2016-06-05 16:46:18 +0000110 return ICmpInst::isRelational(Pred);
Arnaud A. de Grandmaison9c383d62013-03-25 09:48:49 +0000111
Craig Topper73ba1c82017-06-07 07:40:37 +0000112 if (C.isOneValue()) {
Sanjay Patel5f0217f2016-06-05 16:46:18 +0000113 if (Pred == ICmpInst::ICMP_SLT) {
114 Pred = ICmpInst::ICMP_SLE;
Arnaud A. de Grandmaison9c383d62013-03-25 09:48:49 +0000115 return true;
Arnaud A. de Grandmaison9c383d62013-03-25 09:48:49 +0000116 }
Sanjay Patel5b112842016-08-18 14:59:14 +0000117 } else if (C.isAllOnesValue()) {
Sanjay Patel5f0217f2016-06-05 16:46:18 +0000118 if (Pred == ICmpInst::ICMP_SGT) {
119 Pred = ICmpInst::ICMP_SGE;
Arnaud A. de Grandmaison9c383d62013-03-25 09:48:49 +0000120 return true;
Arnaud A. de Grandmaison9c383d62013-03-25 09:48:49 +0000121 }
Arnaud A. de Grandmaison3ee88e82013-03-25 11:47:38 +0000122 }
Arnaud A. de Grandmaison9c383d62013-03-25 09:48:49 +0000123
124 return false;
125}
126
Sanjay Patel5f0217f2016-06-05 16:46:18 +0000127/// Given a signed integer type and a set of known zero and one bits, compute
128/// the maximum and minimum values that could have the specified known zero and
129/// known one bits, returning them in Min/Max.
Craig Topperb45eabc2017-04-26 16:39:58 +0000130/// TODO: Move to method on KnownBits struct?
131static void computeSignedMinMaxValuesFromKnownBits(const KnownBits &Known,
Sanjay Patel5f0217f2016-06-05 16:46:18 +0000132 APInt &Min, APInt &Max) {
Craig Topperb45eabc2017-04-26 16:39:58 +0000133 assert(Known.getBitWidth() == Min.getBitWidth() &&
134 Known.getBitWidth() == Max.getBitWidth() &&
Chris Lattner2188e402010-01-04 07:37:31 +0000135 "KnownZero, KnownOne and Min, Max must have equal bitwidth.");
Craig Topperb45eabc2017-04-26 16:39:58 +0000136 APInt UnknownBits = ~(Known.Zero|Known.One);
Chris Lattner2188e402010-01-04 07:37:31 +0000137
138 // The minimum value is when all unknown bits are zeros, EXCEPT for the sign
139 // bit if it is unknown.
Craig Topperb45eabc2017-04-26 16:39:58 +0000140 Min = Known.One;
141 Max = Known.One|UnknownBits;
Jim Grosbach129c52a2011-09-30 18:09:53 +0000142
Chris Lattner2188e402010-01-04 07:37:31 +0000143 if (UnknownBits.isNegative()) { // Sign bit is unknown
Craig Topper24db6b82017-04-28 16:58:05 +0000144 Min.setSignBit();
145 Max.clearSignBit();
Chris Lattner2188e402010-01-04 07:37:31 +0000146 }
147}
148
Sanjay Patel5f0217f2016-06-05 16:46:18 +0000149/// Given an unsigned integer type and a set of known zero and one bits, compute
150/// the maximum and minimum values that could have the specified known zero and
151/// known one bits, returning them in Min/Max.
Craig Topperb45eabc2017-04-26 16:39:58 +0000152/// TODO: Move to method on KnownBits struct?
153static void computeUnsignedMinMaxValuesFromKnownBits(const KnownBits &Known,
Chris Lattner2188e402010-01-04 07:37:31 +0000154 APInt &Min, APInt &Max) {
Craig Topperb45eabc2017-04-26 16:39:58 +0000155 assert(Known.getBitWidth() == Min.getBitWidth() &&
156 Known.getBitWidth() == Max.getBitWidth() &&
Chris Lattner2188e402010-01-04 07:37:31 +0000157 "Ty, KnownZero, KnownOne and Min, Max must have equal bitwidth.");
Craig Topperb45eabc2017-04-26 16:39:58 +0000158 APInt UnknownBits = ~(Known.Zero|Known.One);
Jim Grosbach129c52a2011-09-30 18:09:53 +0000159
Chris Lattner2188e402010-01-04 07:37:31 +0000160 // The minimum value is when the unknown bits are all zeros.
Craig Topperb45eabc2017-04-26 16:39:58 +0000161 Min = Known.One;
Chris Lattner2188e402010-01-04 07:37:31 +0000162 // The maximum value is when the unknown bits are all ones.
Craig Topperb45eabc2017-04-26 16:39:58 +0000163 Max = Known.One|UnknownBits;
Chris Lattner2188e402010-01-04 07:37:31 +0000164}
165
Sanjay Patel5f0217f2016-06-05 16:46:18 +0000166/// This is called when we see this pattern:
Chris Lattner2188e402010-01-04 07:37:31 +0000167/// cmp pred (load (gep GV, ...)), cmpcst
Sanjay Patel5f0217f2016-06-05 16:46:18 +0000168/// where GV is a global variable with a constant initializer. Try to simplify
169/// this into some simple computation that does not need the load. For example
Chris Lattner2188e402010-01-04 07:37:31 +0000170/// we can optimize "icmp eq (load (gep "foo", 0, i)), 0" into "icmp eq i, 3".
171///
172/// If AndCst is non-null, then the loaded value is masked with that constant
Sanjay Patel5f0217f2016-06-05 16:46:18 +0000173/// before doing the comparison. This handles cases like "A[i]&4 == 0".
Sanjay Patel43395062016-07-21 18:07:40 +0000174Instruction *InstCombiner::foldCmpLoadFromIndexedGlobal(GetElementPtrInst *GEP,
175 GlobalVariable *GV,
176 CmpInst &ICI,
177 ConstantInt *AndCst) {
Chris Lattnerfe741762012-01-31 02:55:06 +0000178 Constant *Init = GV->getInitializer();
179 if (!isa<ConstantArray>(Init) && !isa<ConstantDataArray>(Init))
Craig Topperf40110f2014-04-25 05:29:35 +0000180 return nullptr;
Jim Grosbachbdbd7342013-04-05 21:20:12 +0000181
Chris Lattnerfe741762012-01-31 02:55:06 +0000182 uint64_t ArrayElementCount = Init->getType()->getArrayNumElements();
Davide Italiano2133bf52017-02-07 17:56:50 +0000183 // Don't blow up on huge arrays.
184 if (ArrayElementCount > MaxArraySizeForCombine)
185 return nullptr;
Jim Grosbach129c52a2011-09-30 18:09:53 +0000186
Chris Lattner2188e402010-01-04 07:37:31 +0000187 // There are many forms of this optimization we can handle, for now, just do
188 // the simple index into a single-dimensional array.
189 //
190 // Require: GEP GV, 0, i {{, constant indices}}
191 if (GEP->getNumOperands() < 3 ||
192 !isa<ConstantInt>(GEP->getOperand(1)) ||
193 !cast<ConstantInt>(GEP->getOperand(1))->isZero() ||
194 isa<Constant>(GEP->getOperand(2)))
Craig Topperf40110f2014-04-25 05:29:35 +0000195 return nullptr;
Chris Lattner2188e402010-01-04 07:37:31 +0000196
197 // Check that indices after the variable are constants and in-range for the
198 // type they index. Collect the indices. This is typically for arrays of
199 // structs.
200 SmallVector<unsigned, 4> LaterIndices;
Jim Grosbach129c52a2011-09-30 18:09:53 +0000201
Chris Lattnerfe741762012-01-31 02:55:06 +0000202 Type *EltTy = Init->getType()->getArrayElementType();
Chris Lattner2188e402010-01-04 07:37:31 +0000203 for (unsigned i = 3, e = GEP->getNumOperands(); i != e; ++i) {
204 ConstantInt *Idx = dyn_cast<ConstantInt>(GEP->getOperand(i));
Craig Topperf40110f2014-04-25 05:29:35 +0000205 if (!Idx) return nullptr; // Variable index.
Jim Grosbach129c52a2011-09-30 18:09:53 +0000206
Chris Lattner2188e402010-01-04 07:37:31 +0000207 uint64_t IdxVal = Idx->getZExtValue();
Craig Topperf40110f2014-04-25 05:29:35 +0000208 if ((unsigned)IdxVal != IdxVal) return nullptr; // Too large array index.
Jim Grosbach129c52a2011-09-30 18:09:53 +0000209
Chris Lattner229907c2011-07-18 04:54:35 +0000210 if (StructType *STy = dyn_cast<StructType>(EltTy))
Chris Lattner2188e402010-01-04 07:37:31 +0000211 EltTy = STy->getElementType(IdxVal);
Chris Lattner229907c2011-07-18 04:54:35 +0000212 else if (ArrayType *ATy = dyn_cast<ArrayType>(EltTy)) {
Craig Topperf40110f2014-04-25 05:29:35 +0000213 if (IdxVal >= ATy->getNumElements()) return nullptr;
Chris Lattner2188e402010-01-04 07:37:31 +0000214 EltTy = ATy->getElementType();
215 } else {
Craig Topperf40110f2014-04-25 05:29:35 +0000216 return nullptr; // Unknown type.
Chris Lattner2188e402010-01-04 07:37:31 +0000217 }
Jim Grosbach129c52a2011-09-30 18:09:53 +0000218
Chris Lattner2188e402010-01-04 07:37:31 +0000219 LaterIndices.push_back(IdxVal);
220 }
Jim Grosbach129c52a2011-09-30 18:09:53 +0000221
Chris Lattner2188e402010-01-04 07:37:31 +0000222 enum { Overdefined = -3, Undefined = -2 };
223
224 // Variables for our state machines.
Jim Grosbach129c52a2011-09-30 18:09:53 +0000225
Chris Lattner2188e402010-01-04 07:37:31 +0000226 // FirstTrueElement/SecondTrueElement - Used to emit a comparison of the form
227 // "i == 47 | i == 87", where 47 is the first index the condition is true for,
228 // and 87 is the second (and last) index. FirstTrueElement is -2 when
229 // undefined, otherwise set to the first true element. SecondTrueElement is
230 // -2 when undefined, -3 when overdefined and >= 0 when that index is true.
231 int FirstTrueElement = Undefined, SecondTrueElement = Undefined;
232
233 // FirstFalseElement/SecondFalseElement - Used to emit a comparison of the
234 // form "i != 47 & i != 87". Same state transitions as for true elements.
235 int FirstFalseElement = Undefined, SecondFalseElement = Undefined;
Jim Grosbach129c52a2011-09-30 18:09:53 +0000236
Chris Lattner2188e402010-01-04 07:37:31 +0000237 /// TrueRangeEnd/FalseRangeEnd - In conjunction with First*Element, these
238 /// define a state machine that triggers for ranges of values that the index
239 /// is true or false for. This triggers on things like "abbbbc"[i] == 'b'.
240 /// This is -2 when undefined, -3 when overdefined, and otherwise the last
241 /// index in the range (inclusive). We use -2 for undefined here because we
242 /// use relative comparisons and don't want 0-1 to match -1.
243 int TrueRangeEnd = Undefined, FalseRangeEnd = Undefined;
Jim Grosbach129c52a2011-09-30 18:09:53 +0000244
Chris Lattner2188e402010-01-04 07:37:31 +0000245 // MagicBitvector - This is a magic bitvector where we set a bit if the
246 // comparison is true for element 'i'. If there are 64 elements or less in
247 // the array, this will fully represent all the comparison results.
248 uint64_t MagicBitvector = 0;
Jim Grosbach129c52a2011-09-30 18:09:53 +0000249
Chris Lattner2188e402010-01-04 07:37:31 +0000250 // Scan the array and see if one of our patterns matches.
251 Constant *CompareRHS = cast<Constant>(ICI.getOperand(1));
Chris Lattnerfe741762012-01-31 02:55:06 +0000252 for (unsigned i = 0, e = ArrayElementCount; i != e; ++i) {
253 Constant *Elt = Init->getAggregateElement(i);
Craig Topperf40110f2014-04-25 05:29:35 +0000254 if (!Elt) return nullptr;
Jim Grosbach129c52a2011-09-30 18:09:53 +0000255
Chris Lattner2188e402010-01-04 07:37:31 +0000256 // If this is indexing an array of structures, get the structure element.
257 if (!LaterIndices.empty())
Jay Foad57aa6362011-07-13 10:26:04 +0000258 Elt = ConstantExpr::getExtractValue(Elt, LaterIndices);
Jim Grosbach129c52a2011-09-30 18:09:53 +0000259
Chris Lattner2188e402010-01-04 07:37:31 +0000260 // If the element is masked, handle it.
261 if (AndCst) Elt = ConstantExpr::getAnd(Elt, AndCst);
Jim Grosbach129c52a2011-09-30 18:09:53 +0000262
Chris Lattner2188e402010-01-04 07:37:31 +0000263 // Find out if the comparison would be true or false for the i'th element.
264 Constant *C = ConstantFoldCompareInstOperands(ICI.getPredicate(), Elt,
Justin Bogner99798402016-08-05 01:06:44 +0000265 CompareRHS, DL, &TLI);
Chris Lattner2188e402010-01-04 07:37:31 +0000266 // If the result is undef for this element, ignore it.
267 if (isa<UndefValue>(C)) {
268 // Extend range state machines to cover this element in case there is an
269 // undef in the middle of the range.
270 if (TrueRangeEnd == (int)i-1)
271 TrueRangeEnd = i;
272 if (FalseRangeEnd == (int)i-1)
273 FalseRangeEnd = i;
274 continue;
275 }
Jim Grosbach129c52a2011-09-30 18:09:53 +0000276
Chris Lattner2188e402010-01-04 07:37:31 +0000277 // If we can't compute the result for any of the elements, we have to give
278 // up evaluating the entire conditional.
Craig Topperf40110f2014-04-25 05:29:35 +0000279 if (!isa<ConstantInt>(C)) return nullptr;
Jim Grosbach129c52a2011-09-30 18:09:53 +0000280
Chris Lattner2188e402010-01-04 07:37:31 +0000281 // Otherwise, we know if the comparison is true or false for this element,
282 // update our state machines.
283 bool IsTrueForElt = !cast<ConstantInt>(C)->isZero();
Jim Grosbach129c52a2011-09-30 18:09:53 +0000284
Chris Lattner2188e402010-01-04 07:37:31 +0000285 // State machine for single/double/range index comparison.
286 if (IsTrueForElt) {
287 // Update the TrueElement state machine.
288 if (FirstTrueElement == Undefined)
289 FirstTrueElement = TrueRangeEnd = i; // First true element.
290 else {
291 // Update double-compare state machine.
292 if (SecondTrueElement == Undefined)
293 SecondTrueElement = i;
294 else
295 SecondTrueElement = Overdefined;
Jim Grosbach129c52a2011-09-30 18:09:53 +0000296
Chris Lattner2188e402010-01-04 07:37:31 +0000297 // Update range state machine.
298 if (TrueRangeEnd == (int)i-1)
299 TrueRangeEnd = i;
300 else
301 TrueRangeEnd = Overdefined;
302 }
303 } else {
304 // Update the FalseElement state machine.
305 if (FirstFalseElement == Undefined)
306 FirstFalseElement = FalseRangeEnd = i; // First false element.
307 else {
308 // Update double-compare state machine.
309 if (SecondFalseElement == Undefined)
310 SecondFalseElement = i;
311 else
312 SecondFalseElement = Overdefined;
Jim Grosbach129c52a2011-09-30 18:09:53 +0000313
Chris Lattner2188e402010-01-04 07:37:31 +0000314 // Update range state machine.
315 if (FalseRangeEnd == (int)i-1)
316 FalseRangeEnd = i;
317 else
318 FalseRangeEnd = Overdefined;
319 }
320 }
Jim Grosbach129c52a2011-09-30 18:09:53 +0000321
Chris Lattner2188e402010-01-04 07:37:31 +0000322 // If this element is in range, update our magic bitvector.
323 if (i < 64 && IsTrueForElt)
324 MagicBitvector |= 1ULL << i;
Jim Grosbach129c52a2011-09-30 18:09:53 +0000325
Chris Lattner2188e402010-01-04 07:37:31 +0000326 // If all of our states become overdefined, bail out early. Since the
327 // predicate is expensive, only check it every 8 elements. This is only
328 // really useful for really huge arrays.
329 if ((i & 8) == 0 && i >= 64 && SecondTrueElement == Overdefined &&
330 SecondFalseElement == Overdefined && TrueRangeEnd == Overdefined &&
331 FalseRangeEnd == Overdefined)
Craig Topperf40110f2014-04-25 05:29:35 +0000332 return nullptr;
Chris Lattner2188e402010-01-04 07:37:31 +0000333 }
334
335 // Now that we've scanned the entire array, emit our new comparison(s). We
336 // order the state machines in complexity of the generated code.
337 Value *Idx = GEP->getOperand(2);
338
Matt Arsenault5aeae182013-08-19 21:40:31 +0000339 // If the index is larger than the pointer size of the target, truncate the
340 // index down like the GEP would do implicitly. We don't have to do this for
341 // an inbounds GEP because the index can't be out of range.
Matt Arsenault84680622013-09-30 21:11:01 +0000342 if (!GEP->isInBounds()) {
Mehdi Aminia28d91d2015-03-10 02:37:25 +0000343 Type *IntPtrTy = DL.getIntPtrType(GEP->getType());
Matt Arsenault84680622013-09-30 21:11:01 +0000344 unsigned PtrSize = IntPtrTy->getIntegerBitWidth();
345 if (Idx->getType()->getPrimitiveSizeInBits() > PtrSize)
Craig Topperbb4069e2017-07-07 23:16:26 +0000346 Idx = Builder.CreateTrunc(Idx, IntPtrTy);
Matt Arsenault84680622013-09-30 21:11:01 +0000347 }
Matt Arsenault5aeae182013-08-19 21:40:31 +0000348
Chris Lattner2188e402010-01-04 07:37:31 +0000349 // If the comparison is only true for one or two elements, emit direct
350 // comparisons.
351 if (SecondTrueElement != Overdefined) {
352 // None true -> false.
353 if (FirstTrueElement == Undefined)
Craig Topperbb4069e2017-07-07 23:16:26 +0000354 return replaceInstUsesWith(ICI, Builder.getFalse());
Jim Grosbach129c52a2011-09-30 18:09:53 +0000355
Chris Lattner2188e402010-01-04 07:37:31 +0000356 Value *FirstTrueIdx = ConstantInt::get(Idx->getType(), FirstTrueElement);
Jim Grosbach129c52a2011-09-30 18:09:53 +0000357
Chris Lattner2188e402010-01-04 07:37:31 +0000358 // True for one element -> 'i == 47'.
359 if (SecondTrueElement == Undefined)
360 return new ICmpInst(ICmpInst::ICMP_EQ, Idx, FirstTrueIdx);
Jim Grosbach129c52a2011-09-30 18:09:53 +0000361
Chris Lattner2188e402010-01-04 07:37:31 +0000362 // True for two elements -> 'i == 47 | i == 72'.
Craig Topperbb4069e2017-07-07 23:16:26 +0000363 Value *C1 = Builder.CreateICmpEQ(Idx, FirstTrueIdx);
Chris Lattner2188e402010-01-04 07:37:31 +0000364 Value *SecondTrueIdx = ConstantInt::get(Idx->getType(), SecondTrueElement);
Craig Topperbb4069e2017-07-07 23:16:26 +0000365 Value *C2 = Builder.CreateICmpEQ(Idx, SecondTrueIdx);
Chris Lattner2188e402010-01-04 07:37:31 +0000366 return BinaryOperator::CreateOr(C1, C2);
367 }
368
369 // If the comparison is only false for one or two elements, emit direct
370 // comparisons.
371 if (SecondFalseElement != Overdefined) {
372 // None false -> true.
373 if (FirstFalseElement == Undefined)
Craig Topperbb4069e2017-07-07 23:16:26 +0000374 return replaceInstUsesWith(ICI, Builder.getTrue());
Jim Grosbach129c52a2011-09-30 18:09:53 +0000375
Chris Lattner2188e402010-01-04 07:37:31 +0000376 Value *FirstFalseIdx = ConstantInt::get(Idx->getType(), FirstFalseElement);
377
378 // False for one element -> 'i != 47'.
379 if (SecondFalseElement == Undefined)
380 return new ICmpInst(ICmpInst::ICMP_NE, Idx, FirstFalseIdx);
Jim Grosbach129c52a2011-09-30 18:09:53 +0000381
Chris Lattner2188e402010-01-04 07:37:31 +0000382 // False for two elements -> 'i != 47 & i != 72'.
Craig Topperbb4069e2017-07-07 23:16:26 +0000383 Value *C1 = Builder.CreateICmpNE(Idx, FirstFalseIdx);
Chris Lattner2188e402010-01-04 07:37:31 +0000384 Value *SecondFalseIdx = ConstantInt::get(Idx->getType(),SecondFalseElement);
Craig Topperbb4069e2017-07-07 23:16:26 +0000385 Value *C2 = Builder.CreateICmpNE(Idx, SecondFalseIdx);
Chris Lattner2188e402010-01-04 07:37:31 +0000386 return BinaryOperator::CreateAnd(C1, C2);
387 }
Jim Grosbach129c52a2011-09-30 18:09:53 +0000388
Chris Lattner2188e402010-01-04 07:37:31 +0000389 // If the comparison can be replaced with a range comparison for the elements
390 // where it is true, emit the range check.
391 if (TrueRangeEnd != Overdefined) {
392 assert(TrueRangeEnd != FirstTrueElement && "Should emit single compare");
Jim Grosbach129c52a2011-09-30 18:09:53 +0000393
Chris Lattner2188e402010-01-04 07:37:31 +0000394 // Generate (i-FirstTrue) <u (TrueRangeEnd-FirstTrue+1).
395 if (FirstTrueElement) {
396 Value *Offs = ConstantInt::get(Idx->getType(), -FirstTrueElement);
Craig Topperbb4069e2017-07-07 23:16:26 +0000397 Idx = Builder.CreateAdd(Idx, Offs);
Chris Lattner2188e402010-01-04 07:37:31 +0000398 }
Jim Grosbach129c52a2011-09-30 18:09:53 +0000399
Chris Lattner2188e402010-01-04 07:37:31 +0000400 Value *End = ConstantInt::get(Idx->getType(),
401 TrueRangeEnd-FirstTrueElement+1);
402 return new ICmpInst(ICmpInst::ICMP_ULT, Idx, End);
403 }
Jim Grosbach129c52a2011-09-30 18:09:53 +0000404
Chris Lattner2188e402010-01-04 07:37:31 +0000405 // False range check.
406 if (FalseRangeEnd != Overdefined) {
407 assert(FalseRangeEnd != FirstFalseElement && "Should emit single compare");
408 // Generate (i-FirstFalse) >u (FalseRangeEnd-FirstFalse).
409 if (FirstFalseElement) {
410 Value *Offs = ConstantInt::get(Idx->getType(), -FirstFalseElement);
Craig Topperbb4069e2017-07-07 23:16:26 +0000411 Idx = Builder.CreateAdd(Idx, Offs);
Chris Lattner2188e402010-01-04 07:37:31 +0000412 }
Jim Grosbach129c52a2011-09-30 18:09:53 +0000413
Chris Lattner2188e402010-01-04 07:37:31 +0000414 Value *End = ConstantInt::get(Idx->getType(),
415 FalseRangeEnd-FirstFalseElement);
416 return new ICmpInst(ICmpInst::ICMP_UGT, Idx, End);
417 }
Jim Grosbach129c52a2011-09-30 18:09:53 +0000418
Arnaud A. de Grandmaisonf364bc62013-03-22 08:25:01 +0000419 // If a magic bitvector captures the entire comparison state
Chris Lattner2188e402010-01-04 07:37:31 +0000420 // of this load, replace it with computation that does:
421 // ((magic_cst >> i) & 1) != 0
Arnaud A. de Grandmaisonf364bc62013-03-22 08:25:01 +0000422 {
Craig Topperf40110f2014-04-25 05:29:35 +0000423 Type *Ty = nullptr;
Arnaud A. de Grandmaisonf364bc62013-03-22 08:25:01 +0000424
425 // Look for an appropriate type:
426 // - The type of Idx if the magic fits
Craig Topper386fc252017-11-07 17:37:32 +0000427 // - The smallest fitting legal type
Arnaud A. de Grandmaisonf364bc62013-03-22 08:25:01 +0000428 if (ArrayElementCount <= Idx->getType()->getIntegerBitWidth())
429 Ty = Idx->getType();
Mehdi Aminia28d91d2015-03-10 02:37:25 +0000430 else
431 Ty = DL.getSmallestLegalIntType(Init->getContext(), ArrayElementCount);
Arnaud A. de Grandmaisonf364bc62013-03-22 08:25:01 +0000432
Craig Topperf40110f2014-04-25 05:29:35 +0000433 if (Ty) {
Craig Topperbb4069e2017-07-07 23:16:26 +0000434 Value *V = Builder.CreateIntCast(Idx, Ty, false);
435 V = Builder.CreateLShr(ConstantInt::get(Ty, MagicBitvector), V);
436 V = Builder.CreateAnd(ConstantInt::get(Ty, 1), V);
Arnaud A. de Grandmaisonf364bc62013-03-22 08:25:01 +0000437 return new ICmpInst(ICmpInst::ICMP_NE, V, ConstantInt::get(Ty, 0));
438 }
Chris Lattner2188e402010-01-04 07:37:31 +0000439 }
Jim Grosbach129c52a2011-09-30 18:09:53 +0000440
Craig Topperf40110f2014-04-25 05:29:35 +0000441 return nullptr;
Chris Lattner2188e402010-01-04 07:37:31 +0000442}
443
Sanjay Patel5f0217f2016-06-05 16:46:18 +0000444/// Return a value that can be used to compare the *offset* implied by a GEP to
445/// zero. For example, if we have &A[i], we want to return 'i' for
446/// "icmp ne i, 0". Note that, in general, indices can be complex, and scales
447/// are involved. The above expression would also be legal to codegen as
448/// "icmp ne (i*4), 0" (assuming A is a pointer to i32).
449/// This latter form is less amenable to optimization though, and we are allowed
Chris Lattner2188e402010-01-04 07:37:31 +0000450/// to generate the first by knowing that pointer arithmetic doesn't overflow.
451///
452/// If we can't emit an optimized form for this expression, this returns null.
Jim Grosbach129c52a2011-09-30 18:09:53 +0000453///
Sanjay Pateld93c4c02016-09-15 18:22:25 +0000454static Value *evaluateGEPOffsetExpression(User *GEP, InstCombiner &IC,
Mehdi Aminia28d91d2015-03-10 02:37:25 +0000455 const DataLayout &DL) {
Chris Lattner2188e402010-01-04 07:37:31 +0000456 gep_type_iterator GTI = gep_type_begin(GEP);
Jim Grosbach129c52a2011-09-30 18:09:53 +0000457
Chris Lattner2188e402010-01-04 07:37:31 +0000458 // Check to see if this gep only has a single variable index. If so, and if
459 // any constant indices are a multiple of its scale, then we can compute this
460 // in terms of the scale of the variable index. For example, if the GEP
461 // implies an offset of "12 + i*4", then we can codegen this as "3 + i",
462 // because the expression will cross zero at the same point.
463 unsigned i, e = GEP->getNumOperands();
464 int64_t Offset = 0;
465 for (i = 1; i != e; ++i, ++GTI) {
466 if (ConstantInt *CI = dyn_cast<ConstantInt>(GEP->getOperand(i))) {
467 // Compute the aggregate offset of constant indices.
468 if (CI->isZero()) continue;
Jim Grosbach129c52a2011-09-30 18:09:53 +0000469
Chris Lattner2188e402010-01-04 07:37:31 +0000470 // Handle a struct index, which adds its field offset to the pointer.
Peter Collingbourneab85225b2016-12-02 02:24:42 +0000471 if (StructType *STy = GTI.getStructTypeOrNull()) {
Rafael Espindola37dc9e12014-02-21 00:06:31 +0000472 Offset += DL.getStructLayout(STy)->getElementOffset(CI->getZExtValue());
Chris Lattner2188e402010-01-04 07:37:31 +0000473 } else {
Rafael Espindola37dc9e12014-02-21 00:06:31 +0000474 uint64_t Size = DL.getTypeAllocSize(GTI.getIndexedType());
Chris Lattner2188e402010-01-04 07:37:31 +0000475 Offset += Size*CI->getSExtValue();
476 }
477 } else {
478 // Found our variable index.
479 break;
480 }
481 }
Jim Grosbach129c52a2011-09-30 18:09:53 +0000482
Chris Lattner2188e402010-01-04 07:37:31 +0000483 // If there are no variable indices, we must have a constant offset, just
484 // evaluate it the general way.
Craig Topperf40110f2014-04-25 05:29:35 +0000485 if (i == e) return nullptr;
Jim Grosbach129c52a2011-09-30 18:09:53 +0000486
Chris Lattner2188e402010-01-04 07:37:31 +0000487 Value *VariableIdx = GEP->getOperand(i);
488 // Determine the scale factor of the variable element. For example, this is
489 // 4 if the variable index is into an array of i32.
Rafael Espindola37dc9e12014-02-21 00:06:31 +0000490 uint64_t VariableScale = DL.getTypeAllocSize(GTI.getIndexedType());
Jim Grosbach129c52a2011-09-30 18:09:53 +0000491
Chris Lattner2188e402010-01-04 07:37:31 +0000492 // Verify that there are no other variable indices. If so, emit the hard way.
493 for (++i, ++GTI; i != e; ++i, ++GTI) {
494 ConstantInt *CI = dyn_cast<ConstantInt>(GEP->getOperand(i));
Craig Topperf40110f2014-04-25 05:29:35 +0000495 if (!CI) return nullptr;
Jim Grosbach129c52a2011-09-30 18:09:53 +0000496
Chris Lattner2188e402010-01-04 07:37:31 +0000497 // Compute the aggregate offset of constant indices.
498 if (CI->isZero()) continue;
Jim Grosbach129c52a2011-09-30 18:09:53 +0000499
Chris Lattner2188e402010-01-04 07:37:31 +0000500 // Handle a struct index, which adds its field offset to the pointer.
Peter Collingbourneab85225b2016-12-02 02:24:42 +0000501 if (StructType *STy = GTI.getStructTypeOrNull()) {
Rafael Espindola37dc9e12014-02-21 00:06:31 +0000502 Offset += DL.getStructLayout(STy)->getElementOffset(CI->getZExtValue());
Chris Lattner2188e402010-01-04 07:37:31 +0000503 } else {
Rafael Espindola37dc9e12014-02-21 00:06:31 +0000504 uint64_t Size = DL.getTypeAllocSize(GTI.getIndexedType());
Chris Lattner2188e402010-01-04 07:37:31 +0000505 Offset += Size*CI->getSExtValue();
506 }
507 }
Jim Grosbach129c52a2011-09-30 18:09:53 +0000508
Chris Lattner2188e402010-01-04 07:37:31 +0000509 // Okay, we know we have a single variable index, which must be a
510 // pointer/array/vector index. If there is no offset, life is simple, return
511 // the index.
Rafael Espindola37dc9e12014-02-21 00:06:31 +0000512 Type *IntPtrTy = DL.getIntPtrType(GEP->getOperand(0)->getType());
Matt Arsenault745101d2013-08-21 19:53:10 +0000513 unsigned IntPtrWidth = IntPtrTy->getIntegerBitWidth();
Chris Lattner2188e402010-01-04 07:37:31 +0000514 if (Offset == 0) {
515 // Cast to intptrty in case a truncation occurs. If an extension is needed,
516 // we don't need to bother extending: the extension won't affect where the
517 // computation crosses zero.
Eli Friedman1754a252011-05-18 23:11:30 +0000518 if (VariableIdx->getType()->getPrimitiveSizeInBits() > IntPtrWidth) {
Craig Topperbb4069e2017-07-07 23:16:26 +0000519 VariableIdx = IC.Builder.CreateTrunc(VariableIdx, IntPtrTy);
Eli Friedman1754a252011-05-18 23:11:30 +0000520 }
Chris Lattner2188e402010-01-04 07:37:31 +0000521 return VariableIdx;
522 }
Jim Grosbach129c52a2011-09-30 18:09:53 +0000523
Chris Lattner2188e402010-01-04 07:37:31 +0000524 // Otherwise, there is an index. The computation we will do will be modulo
525 // the pointer size, so get it.
526 uint64_t PtrSizeMask = ~0ULL >> (64-IntPtrWidth);
Jim Grosbach129c52a2011-09-30 18:09:53 +0000527
Chris Lattner2188e402010-01-04 07:37:31 +0000528 Offset &= PtrSizeMask;
529 VariableScale &= PtrSizeMask;
Jim Grosbach129c52a2011-09-30 18:09:53 +0000530
Chris Lattner2188e402010-01-04 07:37:31 +0000531 // To do this transformation, any constant index must be a multiple of the
532 // variable scale factor. For example, we can evaluate "12 + 4*i" as "3 + i",
533 // but we can't evaluate "10 + 3*i" in terms of i. Check that the offset is a
534 // multiple of the variable scale.
535 int64_t NewOffs = Offset / (int64_t)VariableScale;
536 if (Offset != NewOffs*(int64_t)VariableScale)
Craig Topperf40110f2014-04-25 05:29:35 +0000537 return nullptr;
Jim Grosbach129c52a2011-09-30 18:09:53 +0000538
Chris Lattner2188e402010-01-04 07:37:31 +0000539 // Okay, we can do this evaluation. Start by converting the index to intptr.
Chris Lattner2188e402010-01-04 07:37:31 +0000540 if (VariableIdx->getType() != IntPtrTy)
Craig Topperbb4069e2017-07-07 23:16:26 +0000541 VariableIdx = IC.Builder.CreateIntCast(VariableIdx, IntPtrTy,
Eli Friedman1754a252011-05-18 23:11:30 +0000542 true /*Signed*/);
Chris Lattner2188e402010-01-04 07:37:31 +0000543 Constant *OffsetVal = ConstantInt::get(IntPtrTy, NewOffs);
Craig Topperbb4069e2017-07-07 23:16:26 +0000544 return IC.Builder.CreateAdd(VariableIdx, OffsetVal, "offset");
Chris Lattner2188e402010-01-04 07:37:31 +0000545}
546
Silviu Barangaf29dfd32016-01-15 15:52:05 +0000547/// Returns true if we can rewrite Start as a GEP with pointer Base
548/// and some integer offset. The nodes that need to be re-written
549/// for this transformation will be added to Explored.
550static bool canRewriteGEPAsOffset(Value *Start, Value *Base,
551 const DataLayout &DL,
552 SetVector<Value *> &Explored) {
553 SmallVector<Value *, 16> WorkList(1, Start);
554 Explored.insert(Base);
555
556 // The following traversal gives us an order which can be used
557 // when doing the final transformation. Since in the final
558 // transformation we create the PHI replacement instructions first,
559 // we don't have to get them in any particular order.
560 //
561 // However, for other instructions we will have to traverse the
562 // operands of an instruction first, which means that we have to
563 // do a post-order traversal.
564 while (!WorkList.empty()) {
565 SetVector<PHINode *> PHIs;
566
567 while (!WorkList.empty()) {
568 if (Explored.size() >= 100)
569 return false;
570
571 Value *V = WorkList.back();
572
573 if (Explored.count(V) != 0) {
574 WorkList.pop_back();
575 continue;
576 }
577
578 if (!isa<IntToPtrInst>(V) && !isa<PtrToIntInst>(V) &&
David Majnemer8b16da82016-09-15 20:10:09 +0000579 !isa<GetElementPtrInst>(V) && !isa<PHINode>(V))
Silviu Barangaf29dfd32016-01-15 15:52:05 +0000580 // We've found some value that we can't explore which is different from
581 // the base. Therefore we can't do this transformation.
582 return false;
583
584 if (isa<IntToPtrInst>(V) || isa<PtrToIntInst>(V)) {
585 auto *CI = dyn_cast<CastInst>(V);
586 if (!CI->isNoopCast(DL))
587 return false;
588
589 if (Explored.count(CI->getOperand(0)) == 0)
590 WorkList.push_back(CI->getOperand(0));
591 }
592
593 if (auto *GEP = dyn_cast<GEPOperator>(V)) {
594 // We're limiting the GEP to having one index. This will preserve
595 // the original pointer type. We could handle more cases in the
596 // future.
597 if (GEP->getNumIndices() != 1 || !GEP->isInBounds() ||
598 GEP->getType() != Start->getType())
599 return false;
600
601 if (Explored.count(GEP->getOperand(0)) == 0)
602 WorkList.push_back(GEP->getOperand(0));
603 }
604
605 if (WorkList.back() == V) {
606 WorkList.pop_back();
607 // We've finished visiting this node, mark it as such.
608 Explored.insert(V);
609 }
610
611 if (auto *PN = dyn_cast<PHINode>(V)) {
David Majnemercdf28732016-03-19 04:39:52 +0000612 // We cannot transform PHIs on unsplittable basic blocks.
613 if (isa<CatchSwitchInst>(PN->getParent()->getTerminator()))
614 return false;
Silviu Barangaf29dfd32016-01-15 15:52:05 +0000615 Explored.insert(PN);
616 PHIs.insert(PN);
617 }
618 }
619
620 // Explore the PHI nodes further.
621 for (auto *PN : PHIs)
622 for (Value *Op : PN->incoming_values())
623 if (Explored.count(Op) == 0)
624 WorkList.push_back(Op);
625 }
626
627 // Make sure that we can do this. Since we can't insert GEPs in a basic
628 // block before a PHI node, we can't easily do this transformation if
629 // we have PHI node users of transformed instructions.
630 for (Value *Val : Explored) {
631 for (Value *Use : Val->uses()) {
632
633 auto *PHI = dyn_cast<PHINode>(Use);
634 auto *Inst = dyn_cast<Instruction>(Val);
635
636 if (Inst == Base || Inst == PHI || !Inst || !PHI ||
637 Explored.count(PHI) == 0)
638 continue;
639
640 if (PHI->getParent() == Inst->getParent())
641 return false;
642 }
643 }
644 return true;
645}
646
647// Sets the appropriate insert point on Builder where we can add
648// a replacement Instruction for V (if that is possible).
649static void setInsertionPoint(IRBuilder<> &Builder, Value *V,
650 bool Before = true) {
651 if (auto *PHI = dyn_cast<PHINode>(V)) {
652 Builder.SetInsertPoint(&*PHI->getParent()->getFirstInsertionPt());
653 return;
654 }
655 if (auto *I = dyn_cast<Instruction>(V)) {
656 if (!Before)
657 I = &*std::next(I->getIterator());
658 Builder.SetInsertPoint(I);
659 return;
660 }
661 if (auto *A = dyn_cast<Argument>(V)) {
662 // Set the insertion point in the entry block.
663 BasicBlock &Entry = A->getParent()->getEntryBlock();
664 Builder.SetInsertPoint(&*Entry.getFirstInsertionPt());
665 return;
666 }
667 // Otherwise, this is a constant and we don't need to set a new
668 // insertion point.
669 assert(isa<Constant>(V) && "Setting insertion point for unknown value!");
670}
671
672/// Returns a re-written value of Start as an indexed GEP using Base as a
673/// pointer.
674static Value *rewriteGEPAsOffset(Value *Start, Value *Base,
675 const DataLayout &DL,
676 SetVector<Value *> &Explored) {
677 // Perform all the substitutions. This is a bit tricky because we can
678 // have cycles in our use-def chains.
679 // 1. Create the PHI nodes without any incoming values.
680 // 2. Create all the other values.
681 // 3. Add the edges for the PHI nodes.
682 // 4. Emit GEPs to get the original pointers.
683 // 5. Remove the original instructions.
684 Type *IndexType = IntegerType::get(
Elena Demikhovsky945b7e52018-02-14 06:58:08 +0000685 Base->getContext(), DL.getIndexTypeSizeInBits(Start->getType()));
Silviu Barangaf29dfd32016-01-15 15:52:05 +0000686
687 DenseMap<Value *, Value *> NewInsts;
688 NewInsts[Base] = ConstantInt::getNullValue(IndexType);
689
690 // Create the new PHI nodes, without adding any incoming values.
691 for (Value *Val : Explored) {
692 if (Val == Base)
693 continue;
694 // Create empty phi nodes. This avoids cyclic dependencies when creating
695 // the remaining instructions.
696 if (auto *PHI = dyn_cast<PHINode>(Val))
697 NewInsts[PHI] = PHINode::Create(IndexType, PHI->getNumIncomingValues(),
698 PHI->getName() + ".idx", PHI);
699 }
700 IRBuilder<> Builder(Base->getContext());
701
702 // Create all the other instructions.
703 for (Value *Val : Explored) {
704
705 if (NewInsts.find(Val) != NewInsts.end())
706 continue;
707
708 if (auto *CI = dyn_cast<CastInst>(Val)) {
709 NewInsts[CI] = NewInsts[CI->getOperand(0)];
710 continue;
711 }
712 if (auto *GEP = dyn_cast<GEPOperator>(Val)) {
713 Value *Index = NewInsts[GEP->getOperand(1)] ? NewInsts[GEP->getOperand(1)]
714 : GEP->getOperand(1);
715 setInsertionPoint(Builder, GEP);
716 // Indices might need to be sign extended. GEPs will magically do
717 // this, but we need to do it ourselves here.
718 if (Index->getType()->getScalarSizeInBits() !=
719 NewInsts[GEP->getOperand(0)]->getType()->getScalarSizeInBits()) {
720 Index = Builder.CreateSExtOrTrunc(
721 Index, NewInsts[GEP->getOperand(0)]->getType(),
722 GEP->getOperand(0)->getName() + ".sext");
723 }
724
725 auto *Op = NewInsts[GEP->getOperand(0)];
Craig Topper781aa182018-05-05 01:57:00 +0000726 if (isa<ConstantInt>(Op) && cast<ConstantInt>(Op)->isZero())
Silviu Barangaf29dfd32016-01-15 15:52:05 +0000727 NewInsts[GEP] = Index;
728 else
729 NewInsts[GEP] = Builder.CreateNSWAdd(
730 Op, Index, GEP->getOperand(0)->getName() + ".add");
731 continue;
732 }
733 if (isa<PHINode>(Val))
734 continue;
735
736 llvm_unreachable("Unexpected instruction type");
737 }
738
739 // Add the incoming values to the PHI nodes.
740 for (Value *Val : Explored) {
741 if (Val == Base)
742 continue;
743 // All the instructions have been created, we can now add edges to the
744 // phi nodes.
745 if (auto *PHI = dyn_cast<PHINode>(Val)) {
746 PHINode *NewPhi = static_cast<PHINode *>(NewInsts[PHI]);
747 for (unsigned I = 0, E = PHI->getNumIncomingValues(); I < E; ++I) {
748 Value *NewIncoming = PHI->getIncomingValue(I);
749
750 if (NewInsts.find(NewIncoming) != NewInsts.end())
751 NewIncoming = NewInsts[NewIncoming];
752
753 NewPhi->addIncoming(NewIncoming, PHI->getIncomingBlock(I));
754 }
755 }
756 }
757
758 for (Value *Val : Explored) {
759 if (Val == Base)
760 continue;
761
762 // Depending on the type, for external users we have to emit
763 // a GEP or a GEP + ptrtoint.
764 setInsertionPoint(Builder, Val, false);
765
766 // If required, create an inttoptr instruction for Base.
767 Value *NewBase = Base;
768 if (!Base->getType()->isPointerTy())
769 NewBase = Builder.CreateBitOrPointerCast(Base, Start->getType(),
770 Start->getName() + "to.ptr");
771
772 Value *GEP = Builder.CreateInBoundsGEP(
773 Start->getType()->getPointerElementType(), NewBase,
774 makeArrayRef(NewInsts[Val]), Val->getName() + ".ptr");
775
776 if (!Val->getType()->isPointerTy()) {
777 Value *Cast = Builder.CreatePointerCast(GEP, Val->getType(),
778 Val->getName() + ".conv");
779 GEP = Cast;
780 }
781 Val->replaceAllUsesWith(GEP);
782 }
783
784 return NewInsts[Start];
785}
786
787/// Looks through GEPs, IntToPtrInsts and PtrToIntInsts in order to express
788/// the input Value as a constant indexed GEP. Returns a pair containing
789/// the GEPs Pointer and Index.
790static std::pair<Value *, Value *>
791getAsConstantIndexedAddress(Value *V, const DataLayout &DL) {
792 Type *IndexType = IntegerType::get(V->getContext(),
Elena Demikhovsky945b7e52018-02-14 06:58:08 +0000793 DL.getIndexTypeSizeInBits(V->getType()));
Silviu Barangaf29dfd32016-01-15 15:52:05 +0000794
795 Constant *Index = ConstantInt::getNullValue(IndexType);
796 while (true) {
797 if (GEPOperator *GEP = dyn_cast<GEPOperator>(V)) {
798 // We accept only inbouds GEPs here to exclude the possibility of
799 // overflow.
800 if (!GEP->isInBounds())
801 break;
802 if (GEP->hasAllConstantIndices() && GEP->getNumIndices() == 1 &&
803 GEP->getType() == V->getType()) {
804 V = GEP->getOperand(0);
805 Constant *GEPIndex = static_cast<Constant *>(GEP->getOperand(1));
806 Index = ConstantExpr::getAdd(
807 Index, ConstantExpr::getSExtOrBitCast(GEPIndex, IndexType));
808 continue;
809 }
810 break;
811 }
812 if (auto *CI = dyn_cast<IntToPtrInst>(V)) {
813 if (!CI->isNoopCast(DL))
814 break;
815 V = CI->getOperand(0);
816 continue;
817 }
818 if (auto *CI = dyn_cast<PtrToIntInst>(V)) {
819 if (!CI->isNoopCast(DL))
820 break;
821 V = CI->getOperand(0);
822 continue;
823 }
824 break;
825 }
826 return {V, Index};
827}
828
Sanjay Patel5f0217f2016-06-05 16:46:18 +0000829/// Converts (CMP GEPLHS, RHS) if this change would make RHS a constant.
830/// We can look through PHIs, GEPs and casts in order to determine a common base
831/// between GEPLHS and RHS.
Silviu Barangaf29dfd32016-01-15 15:52:05 +0000832static Instruction *transformToIndexedCompare(GEPOperator *GEPLHS, Value *RHS,
833 ICmpInst::Predicate Cond,
834 const DataLayout &DL) {
835 if (!GEPLHS->hasAllConstantIndices())
836 return nullptr;
837
Silviu Barangac6d21eb2017-01-31 14:04:15 +0000838 // Make sure the pointers have the same type.
839 if (GEPLHS->getType() != RHS->getType())
840 return nullptr;
841
Silviu Barangaf29dfd32016-01-15 15:52:05 +0000842 Value *PtrBase, *Index;
843 std::tie(PtrBase, Index) = getAsConstantIndexedAddress(GEPLHS, DL);
844
845 // The set of nodes that will take part in this transformation.
846 SetVector<Value *> Nodes;
847
848 if (!canRewriteGEPAsOffset(RHS, PtrBase, DL, Nodes))
849 return nullptr;
850
851 // We know we can re-write this as
852 // ((gep Ptr, OFFSET1) cmp (gep Ptr, OFFSET2)
853 // Since we've only looked through inbouds GEPs we know that we
854 // can't have overflow on either side. We can therefore re-write
855 // this as:
856 // OFFSET1 cmp OFFSET2
857 Value *NewRHS = rewriteGEPAsOffset(RHS, PtrBase, DL, Nodes);
858
859 // RewriteGEPAsOffset has replaced RHS and all of its uses with a re-written
860 // GEP having PtrBase as the pointer base, and has returned in NewRHS the
861 // offset. Since Index is the offset of LHS to the base pointer, we will now
862 // compare the offsets instead of comparing the pointers.
863 return new ICmpInst(ICmpInst::getSignedPredicate(Cond), Index, NewRHS);
864}
865
Sanjay Patel5f0217f2016-06-05 16:46:18 +0000866/// Fold comparisons between a GEP instruction and something else. At this point
867/// we know that the GEP is on the LHS of the comparison.
Sanjay Patel43395062016-07-21 18:07:40 +0000868Instruction *InstCombiner::foldGEPICmp(GEPOperator *GEPLHS, Value *RHS,
Chris Lattner2188e402010-01-04 07:37:31 +0000869 ICmpInst::Predicate Cond,
870 Instruction &I) {
Benjamin Kramer6ee86902012-02-21 13:31:09 +0000871 // Don't transform signed compares of GEPs into index compares. Even if the
872 // GEP is inbounds, the final add of the base pointer can have signed overflow
873 // and would change the result of the icmp.
874 // e.g. "&foo[0] <s &foo[1]" can't be folded to "true" because "foo" could be
Benjamin Kramerc7a22fe2012-02-21 13:40:06 +0000875 // the maximum signed value for the pointer type.
Benjamin Kramer6ee86902012-02-21 13:31:09 +0000876 if (ICmpInst::isSigned(Cond))
Craig Topperf40110f2014-04-25 05:29:35 +0000877 return nullptr;
Benjamin Kramer6ee86902012-02-21 13:31:09 +0000878
Matt Arsenault44f60d02014-06-09 19:20:29 +0000879 // Look through bitcasts and addrspacecasts. We do not however want to remove
880 // 0 GEPs.
881 if (!isa<GetElementPtrInst>(RHS))
882 RHS = RHS->stripPointerCasts();
Chris Lattner2188e402010-01-04 07:37:31 +0000883
884 Value *PtrBase = GEPLHS->getOperand(0);
Mehdi Aminia28d91d2015-03-10 02:37:25 +0000885 if (PtrBase == RHS && GEPLHS->isInBounds()) {
Chris Lattner2188e402010-01-04 07:37:31 +0000886 // ((gep Ptr, OFFSET) cmp Ptr) ---> (OFFSET cmp 0).
887 // This transformation (ignoring the base and scales) is valid because we
888 // know pointers can't overflow since the gep is inbounds. See if we can
889 // output an optimized form.
Sanjay Pateld93c4c02016-09-15 18:22:25 +0000890 Value *Offset = evaluateGEPOffsetExpression(GEPLHS, *this, DL);
Jim Grosbach129c52a2011-09-30 18:09:53 +0000891
Chris Lattner2188e402010-01-04 07:37:31 +0000892 // If not, synthesize the offset the hard way.
Craig Topperf40110f2014-04-25 05:29:35 +0000893 if (!Offset)
Chris Lattner2188e402010-01-04 07:37:31 +0000894 Offset = EmitGEPOffset(GEPLHS);
895 return new ICmpInst(ICmpInst::getSignedPredicate(Cond), Offset,
896 Constant::getNullValue(Offset->getType()));
897 } else if (GEPOperator *GEPRHS = dyn_cast<GEPOperator>(RHS)) {
898 // If the base pointers are different, but the indices are the same, just
899 // compare the base pointer.
900 if (PtrBase != GEPRHS->getOperand(0)) {
901 bool IndicesTheSame = GEPLHS->getNumOperands()==GEPRHS->getNumOperands();
902 IndicesTheSame &= GEPLHS->getOperand(0)->getType() ==
903 GEPRHS->getOperand(0)->getType();
904 if (IndicesTheSame)
905 for (unsigned i = 1, e = GEPLHS->getNumOperands(); i != e; ++i)
906 if (GEPLHS->getOperand(i) != GEPRHS->getOperand(i)) {
907 IndicesTheSame = false;
908 break;
909 }
910
911 // If all indices are the same, just compare the base pointers.
Jesper Antonssonc954b862018-10-01 14:59:25 +0000912 Type *BaseType = GEPLHS->getOperand(0)->getType();
913 if (IndicesTheSame && CmpInst::makeCmpResultType(BaseType) == I.getType())
David Majnemer5953d372013-06-29 10:28:04 +0000914 return new ICmpInst(Cond, GEPLHS->getOperand(0), GEPRHS->getOperand(0));
Chris Lattner2188e402010-01-04 07:37:31 +0000915
Benjamin Kramer7adb1892012-02-20 15:07:47 +0000916 // If we're comparing GEPs with two base pointers that only differ in type
917 // and both GEPs have only constant indices or just one use, then fold
918 // the compare with the adjusted indices.
Mehdi Aminia28d91d2015-03-10 02:37:25 +0000919 if (GEPLHS->isInBounds() && GEPRHS->isInBounds() &&
Benjamin Kramer7adb1892012-02-20 15:07:47 +0000920 (GEPLHS->hasAllConstantIndices() || GEPLHS->hasOneUse()) &&
921 (GEPRHS->hasAllConstantIndices() || GEPRHS->hasOneUse()) &&
922 PtrBase->stripPointerCasts() ==
Mehdi Aminia28d91d2015-03-10 02:37:25 +0000923 GEPRHS->getOperand(0)->stripPointerCasts()) {
Matt Arsenault44f60d02014-06-09 19:20:29 +0000924 Value *LOffset = EmitGEPOffset(GEPLHS);
925 Value *ROffset = EmitGEPOffset(GEPRHS);
926
927 // If we looked through an addrspacecast between different sized address
928 // spaces, the LHS and RHS pointers are different sized
929 // integers. Truncate to the smaller one.
930 Type *LHSIndexTy = LOffset->getType();
931 Type *RHSIndexTy = ROffset->getType();
932 if (LHSIndexTy != RHSIndexTy) {
933 if (LHSIndexTy->getPrimitiveSizeInBits() <
934 RHSIndexTy->getPrimitiveSizeInBits()) {
Craig Topperbb4069e2017-07-07 23:16:26 +0000935 ROffset = Builder.CreateTrunc(ROffset, LHSIndexTy);
Matt Arsenault44f60d02014-06-09 19:20:29 +0000936 } else
Craig Topperbb4069e2017-07-07 23:16:26 +0000937 LOffset = Builder.CreateTrunc(LOffset, RHSIndexTy);
Matt Arsenault44f60d02014-06-09 19:20:29 +0000938 }
939
Craig Topperbb4069e2017-07-07 23:16:26 +0000940 Value *Cmp = Builder.CreateICmp(ICmpInst::getSignedPredicate(Cond),
941 LOffset, ROffset);
Sanjay Patel4b198802016-02-01 22:23:39 +0000942 return replaceInstUsesWith(I, Cmp);
Benjamin Kramer7adb1892012-02-20 15:07:47 +0000943 }
944
Chris Lattner2188e402010-01-04 07:37:31 +0000945 // Otherwise, the base pointers are different and the indices are
Silviu Barangaf29dfd32016-01-15 15:52:05 +0000946 // different. Try convert this to an indexed compare by looking through
947 // PHIs/casts.
948 return transformToIndexedCompare(GEPLHS, RHS, Cond, DL);
Chris Lattner2188e402010-01-04 07:37:31 +0000949 }
950
951 // If one of the GEPs has all zero indices, recurse.
Benjamin Kramerd0993e02014-07-07 11:01:16 +0000952 if (GEPLHS->hasAllZeroIndices())
Sanjay Patel43395062016-07-21 18:07:40 +0000953 return foldGEPICmp(GEPRHS, GEPLHS->getOperand(0),
David Majnemer92a8a7d2013-06-29 09:45:35 +0000954 ICmpInst::getSwappedPredicate(Cond), I);
Chris Lattner2188e402010-01-04 07:37:31 +0000955
956 // If the other GEP has all zero indices, recurse.
Benjamin Kramerd0993e02014-07-07 11:01:16 +0000957 if (GEPRHS->hasAllZeroIndices())
Sanjay Patel43395062016-07-21 18:07:40 +0000958 return foldGEPICmp(GEPLHS, GEPRHS->getOperand(0), Cond, I);
Chris Lattner2188e402010-01-04 07:37:31 +0000959
Stuart Hastings66a82b92011-05-14 05:55:10 +0000960 bool GEPsInBounds = GEPLHS->isInBounds() && GEPRHS->isInBounds();
Chris Lattner2188e402010-01-04 07:37:31 +0000961 if (GEPLHS->getNumOperands() == GEPRHS->getNumOperands()) {
962 // If the GEPs only differ by one index, compare it.
963 unsigned NumDifferences = 0; // Keep track of # differences.
964 unsigned DiffOperand = 0; // The operand that differs.
965 for (unsigned i = 1, e = GEPRHS->getNumOperands(); i != e; ++i)
966 if (GEPLHS->getOperand(i) != GEPRHS->getOperand(i)) {
967 if (GEPLHS->getOperand(i)->getType()->getPrimitiveSizeInBits() !=
968 GEPRHS->getOperand(i)->getType()->getPrimitiveSizeInBits()) {
969 // Irreconcilable differences.
970 NumDifferences = 2;
971 break;
972 } else {
973 if (NumDifferences++) break;
974 DiffOperand = i;
975 }
976 }
977
Rafael Espindolaa7bbc0b2013-06-06 17:03:05 +0000978 if (NumDifferences == 0) // SAME GEP?
Sanjay Patel4b198802016-02-01 22:23:39 +0000979 return replaceInstUsesWith(I, // No comparison is needed here.
Jesper Antonsson719fa052018-09-20 13:37:28 +0000980 ConstantInt::get(I.getType(), ICmpInst::isTrueWhenEqual(Cond)));
Chris Lattner2188e402010-01-04 07:37:31 +0000981
Stuart Hastings66a82b92011-05-14 05:55:10 +0000982 else if (NumDifferences == 1 && GEPsInBounds) {
Chris Lattner2188e402010-01-04 07:37:31 +0000983 Value *LHSV = GEPLHS->getOperand(DiffOperand);
984 Value *RHSV = GEPRHS->getOperand(DiffOperand);
985 // Make sure we do a signed comparison here.
986 return new ICmpInst(ICmpInst::getSignedPredicate(Cond), LHSV, RHSV);
987 }
988 }
989
990 // Only lower this if the icmp is the only user of the GEP or if we expect
991 // the result to fold to a constant!
Mehdi Aminia28d91d2015-03-10 02:37:25 +0000992 if (GEPsInBounds && (isa<ConstantExpr>(GEPLHS) || GEPLHS->hasOneUse()) &&
Chris Lattner2188e402010-01-04 07:37:31 +0000993 (isa<ConstantExpr>(GEPRHS) || GEPRHS->hasOneUse())) {
994 // ((gep Ptr, OFFSET1) cmp (gep Ptr, OFFSET2) ---> (OFFSET1 cmp OFFSET2)
995 Value *L = EmitGEPOffset(GEPLHS);
996 Value *R = EmitGEPOffset(GEPRHS);
997 return new ICmpInst(ICmpInst::getSignedPredicate(Cond), L, R);
998 }
999 }
Silviu Barangaf29dfd32016-01-15 15:52:05 +00001000
1001 // Try convert this to an indexed compare by looking through PHIs/casts as a
1002 // last resort.
1003 return transformToIndexedCompare(GEPLHS, RHS, Cond, DL);
Chris Lattner2188e402010-01-04 07:37:31 +00001004}
1005
Pete Cooper980a9352016-08-12 17:13:28 +00001006Instruction *InstCombiner::foldAllocaCmp(ICmpInst &ICI,
1007 const AllocaInst *Alloca,
1008 const Value *Other) {
Hans Wennborgf1f36512015-10-07 00:20:07 +00001009 assert(ICI.isEquality() && "Cannot fold non-equality comparison.");
1010
1011 // It would be tempting to fold away comparisons between allocas and any
1012 // pointer not based on that alloca (e.g. an argument). However, even
1013 // though such pointers cannot alias, they can still compare equal.
1014 //
1015 // But LLVM doesn't specify where allocas get their memory, so if the alloca
1016 // doesn't escape we can argue that it's impossible to guess its value, and we
1017 // can therefore act as if any such guesses are wrong.
1018 //
1019 // The code below checks that the alloca doesn't escape, and that it's only
1020 // used in a comparison once (the current instruction). The
1021 // single-comparison-use condition ensures that we're trivially folding all
1022 // comparisons against the alloca consistently, and avoids the risk of
1023 // erroneously folding a comparison of the pointer with itself.
1024
1025 unsigned MaxIter = 32; // Break cycles and bound to constant-time.
1026
Pete Cooper980a9352016-08-12 17:13:28 +00001027 SmallVector<const Use *, 32> Worklist;
1028 for (const Use &U : Alloca->uses()) {
Hans Wennborgf1f36512015-10-07 00:20:07 +00001029 if (Worklist.size() >= MaxIter)
1030 return nullptr;
1031 Worklist.push_back(&U);
1032 }
1033
1034 unsigned NumCmps = 0;
1035 while (!Worklist.empty()) {
1036 assert(Worklist.size() <= MaxIter);
Pete Cooper980a9352016-08-12 17:13:28 +00001037 const Use *U = Worklist.pop_back_val();
1038 const Value *V = U->getUser();
Hans Wennborgf1f36512015-10-07 00:20:07 +00001039 --MaxIter;
1040
1041 if (isa<BitCastInst>(V) || isa<GetElementPtrInst>(V) || isa<PHINode>(V) ||
1042 isa<SelectInst>(V)) {
1043 // Track the uses.
1044 } else if (isa<LoadInst>(V)) {
1045 // Loading from the pointer doesn't escape it.
1046 continue;
Pete Cooper980a9352016-08-12 17:13:28 +00001047 } else if (const auto *SI = dyn_cast<StoreInst>(V)) {
Hans Wennborgf1f36512015-10-07 00:20:07 +00001048 // Storing *to* the pointer is fine, but storing the pointer escapes it.
1049 if (SI->getValueOperand() == U->get())
1050 return nullptr;
1051 continue;
1052 } else if (isa<ICmpInst>(V)) {
1053 if (NumCmps++)
1054 return nullptr; // Found more than one cmp.
1055 continue;
Pete Cooper980a9352016-08-12 17:13:28 +00001056 } else if (const auto *Intrin = dyn_cast<IntrinsicInst>(V)) {
Hans Wennborgf1f36512015-10-07 00:20:07 +00001057 switch (Intrin->getIntrinsicID()) {
1058 // These intrinsics don't escape or compare the pointer. Memset is safe
1059 // because we don't allow ptrtoint. Memcpy and memmove are safe because
1060 // we don't allow stores, so src cannot point to V.
1061 case Intrinsic::lifetime_start: case Intrinsic::lifetime_end:
Hans Wennborgf1f36512015-10-07 00:20:07 +00001062 case Intrinsic::memcpy: case Intrinsic::memmove: case Intrinsic::memset:
1063 continue;
1064 default:
1065 return nullptr;
1066 }
1067 } else {
1068 return nullptr;
1069 }
Pete Cooper980a9352016-08-12 17:13:28 +00001070 for (const Use &U : V->uses()) {
Hans Wennborgf1f36512015-10-07 00:20:07 +00001071 if (Worklist.size() >= MaxIter)
1072 return nullptr;
1073 Worklist.push_back(&U);
1074 }
1075 }
1076
1077 Type *CmpTy = CmpInst::makeCmpResultType(Other->getType());
Sanjay Patel4b198802016-02-01 22:23:39 +00001078 return replaceInstUsesWith(
Hans Wennborgf1f36512015-10-07 00:20:07 +00001079 ICI,
1080 ConstantInt::get(CmpTy, !CmpInst::isTrueWhenEqual(ICI.getPredicate())));
1081}
1082
Craig Topperbee74792018-08-20 23:04:25 +00001083/// Fold "icmp pred (X+C), X".
1084Instruction *InstCombiner::foldICmpAddOpConst(Value *X, const APInt &C,
Sanjay Patel43395062016-07-21 18:07:40 +00001085 ICmpInst::Predicate Pred) {
Chris Lattner2188e402010-01-04 07:37:31 +00001086 // From this point on, we know that (X+C <= X) --> (X+C < X) because C != 0,
Chris Lattner0ab5e2c2011-04-15 05:18:47 +00001087 // so the values can never be equal. Similarly for all other "or equals"
Chris Lattner2188e402010-01-04 07:37:31 +00001088 // operators.
Craig Topperbee74792018-08-20 23:04:25 +00001089 assert(!!C && "C should not be zero!");
Jim Grosbach129c52a2011-09-30 18:09:53 +00001090
Chris Lattner8c92b572010-01-08 17:48:19 +00001091 // (X+1) <u X --> X >u (MAXUINT-1) --> X == 255
Chris Lattner2188e402010-01-04 07:37:31 +00001092 // (X+2) <u X --> X >u (MAXUINT-2) --> X > 253
1093 // (X+MAXUINT) <u X --> X >u (MAXUINT-MAXUINT) --> X != 0
1094 if (Pred == ICmpInst::ICMP_ULT || Pred == ICmpInst::ICMP_ULE) {
Craig Topperbee74792018-08-20 23:04:25 +00001095 Constant *R = ConstantInt::get(X->getType(),
1096 APInt::getMaxValue(C.getBitWidth()) - C);
Chris Lattner2188e402010-01-04 07:37:31 +00001097 return new ICmpInst(ICmpInst::ICMP_UGT, X, R);
1098 }
Jim Grosbach129c52a2011-09-30 18:09:53 +00001099
Chris Lattner2188e402010-01-04 07:37:31 +00001100 // (X+1) >u X --> X <u (0-1) --> X != 255
1101 // (X+2) >u X --> X <u (0-2) --> X <u 254
1102 // (X+MAXUINT) >u X --> X <u (0-MAXUINT) --> X <u 1 --> X == 0
Duncan Sandse5220012011-02-17 07:46:37 +00001103 if (Pred == ICmpInst::ICMP_UGT || Pred == ICmpInst::ICMP_UGE)
Craig Topperbee74792018-08-20 23:04:25 +00001104 return new ICmpInst(ICmpInst::ICMP_ULT, X,
1105 ConstantInt::get(X->getType(), -C));
Jim Grosbach129c52a2011-09-30 18:09:53 +00001106
Craig Topperbee74792018-08-20 23:04:25 +00001107 APInt SMax = APInt::getSignedMaxValue(C.getBitWidth());
Chris Lattner2188e402010-01-04 07:37:31 +00001108
1109 // (X+ 1) <s X --> X >s (MAXSINT-1) --> X == 127
1110 // (X+ 2) <s X --> X >s (MAXSINT-2) --> X >s 125
1111 // (X+MAXSINT) <s X --> X >s (MAXSINT-MAXSINT) --> X >s 0
1112 // (X+MINSINT) <s X --> X >s (MAXSINT-MINSINT) --> X >s -1
1113 // (X+ -2) <s X --> X >s (MAXSINT- -2) --> X >s 126
1114 // (X+ -1) <s X --> X >s (MAXSINT- -1) --> X != 127
Duncan Sandse5220012011-02-17 07:46:37 +00001115 if (Pred == ICmpInst::ICMP_SLT || Pred == ICmpInst::ICMP_SLE)
Craig Topperbee74792018-08-20 23:04:25 +00001116 return new ICmpInst(ICmpInst::ICMP_SGT, X,
1117 ConstantInt::get(X->getType(), SMax - C));
Jim Grosbach129c52a2011-09-30 18:09:53 +00001118
Chris Lattner2188e402010-01-04 07:37:31 +00001119 // (X+ 1) >s X --> X <s (MAXSINT-(1-1)) --> X != 127
1120 // (X+ 2) >s X --> X <s (MAXSINT-(2-1)) --> X <s 126
1121 // (X+MAXSINT) >s X --> X <s (MAXSINT-(MAXSINT-1)) --> X <s 1
1122 // (X+MINSINT) >s X --> X <s (MAXSINT-(MINSINT-1)) --> X <s -2
1123 // (X+ -2) >s X --> X <s (MAXSINT-(-2-1)) --> X <s -126
1124 // (X+ -1) >s X --> X <s (MAXSINT-(-1-1)) --> X == -128
Jim Grosbach129c52a2011-09-30 18:09:53 +00001125
Chris Lattner2188e402010-01-04 07:37:31 +00001126 assert(Pred == ICmpInst::ICMP_SGT || Pred == ICmpInst::ICMP_SGE);
Craig Topperbee74792018-08-20 23:04:25 +00001127 return new ICmpInst(ICmpInst::ICMP_SLT, X,
1128 ConstantInt::get(X->getType(), SMax - (C - 1)));
Chris Lattner2188e402010-01-04 07:37:31 +00001129}
1130
Sanjay Patel8da42cc2016-09-15 22:26:31 +00001131/// Handle "(icmp eq/ne (ashr/lshr AP2, A), AP1)" ->
1132/// (icmp eq/ne A, Log2(AP2/AP1)) ->
1133/// (icmp eq/ne A, Log2(AP2) - Log2(AP1)).
1134Instruction *InstCombiner::foldICmpShrConstConst(ICmpInst &I, Value *A,
1135 const APInt &AP1,
1136 const APInt &AP2) {
Suyog Sarda3a8c2c12014-07-22 19:19:36 +00001137 assert(I.isEquality() && "Cannot fold icmp gt/lt");
1138
Suyog Sarda3a8c2c12014-07-22 19:19:36 +00001139 auto getICmp = [&I](CmpInst::Predicate Pred, Value *LHS, Value *RHS) {
1140 if (I.getPredicate() == I.ICMP_NE)
1141 Pred = CmpInst::getInversePredicate(Pred);
1142 return new ICmpInst(Pred, LHS, RHS);
1143 };
1144
David Majnemer2abb8182014-10-25 07:13:13 +00001145 // Don't bother doing any work for cases which InstSimplify handles.
Craig Topper73ba1c82017-06-07 07:40:37 +00001146 if (AP2.isNullValue())
David Majnemer2abb8182014-10-25 07:13:13 +00001147 return nullptr;
Sanjay Patel8da42cc2016-09-15 22:26:31 +00001148
1149 bool IsAShr = isa<AShrOperator>(I.getOperand(0));
David Majnemer2abb8182014-10-25 07:13:13 +00001150 if (IsAShr) {
1151 if (AP2.isAllOnesValue())
1152 return nullptr;
1153 if (AP2.isNegative() != AP1.isNegative())
1154 return nullptr;
1155 if (AP2.sgt(AP1))
1156 return nullptr;
1157 }
Suyog Sarda3a8c2c12014-07-22 19:19:36 +00001158
David Majnemerd2056022014-10-21 19:51:55 +00001159 if (!AP1)
Suyog Sarda3a8c2c12014-07-22 19:19:36 +00001160 // 'A' must be large enough to shift out the highest set bit.
1161 return getICmp(I.ICMP_UGT, A,
1162 ConstantInt::get(A->getType(), AP2.logBase2()));
Suyog Sarda3a8c2c12014-07-22 19:19:36 +00001163
David Majnemerd2056022014-10-21 19:51:55 +00001164 if (AP1 == AP2)
1165 return getICmp(I.ICMP_EQ, A, ConstantInt::getNullValue(A->getType()));
Suyog Sarda3a8c2c12014-07-22 19:19:36 +00001166
Andrea Di Biagio5b92b492014-09-17 11:32:31 +00001167 int Shift;
David Majnemerd2056022014-10-21 19:51:55 +00001168 if (IsAShr && AP1.isNegative())
David Majnemere5977eb2015-09-19 00:48:26 +00001169 Shift = AP1.countLeadingOnes() - AP2.countLeadingOnes();
Andrea Di Biagio5b92b492014-09-17 11:32:31 +00001170 else
David Majnemere5977eb2015-09-19 00:48:26 +00001171 Shift = AP1.countLeadingZeros() - AP2.countLeadingZeros();
Suyog Sarda3a8c2c12014-07-22 19:19:36 +00001172
David Majnemerd2056022014-10-21 19:51:55 +00001173 if (Shift > 0) {
David Majnemere5977eb2015-09-19 00:48:26 +00001174 if (IsAShr && AP1 == AP2.ashr(Shift)) {
1175 // There are multiple solutions if we are comparing against -1 and the LHS
David Majnemer47ce0b82015-09-19 00:48:31 +00001176 // of the ashr is not a power of two.
David Majnemere5977eb2015-09-19 00:48:26 +00001177 if (AP1.isAllOnesValue() && !AP2.isPowerOf2())
1178 return getICmp(I.ICMP_UGE, A, ConstantInt::get(A->getType(), Shift));
David Majnemerd2056022014-10-21 19:51:55 +00001179 return getICmp(I.ICMP_EQ, A, ConstantInt::get(A->getType(), Shift));
David Majnemere5977eb2015-09-19 00:48:26 +00001180 } else if (AP1 == AP2.lshr(Shift)) {
1181 return getICmp(I.ICMP_EQ, A, ConstantInt::get(A->getType(), Shift));
1182 }
David Majnemerd2056022014-10-21 19:51:55 +00001183 }
Sanjay Patel524fcdf2016-09-15 19:04:55 +00001184
Suyog Sarda3a8c2c12014-07-22 19:19:36 +00001185 // Shifting const2 will never be equal to const1.
Sanjay Patel524fcdf2016-09-15 19:04:55 +00001186 // FIXME: This should always be handled by InstSimplify?
1187 auto *TorF = ConstantInt::get(I.getType(), I.getPredicate() == I.ICMP_NE);
1188 return replaceInstUsesWith(I, TorF);
Suyog Sarda3a8c2c12014-07-22 19:19:36 +00001189}
Chris Lattner2188e402010-01-04 07:37:31 +00001190
Sanjay Patel8da42cc2016-09-15 22:26:31 +00001191/// Handle "(icmp eq/ne (shl AP2, A), AP1)" ->
1192/// (icmp eq/ne A, TrailingZeros(AP1) - TrailingZeros(AP2)).
1193Instruction *InstCombiner::foldICmpShlConstConst(ICmpInst &I, Value *A,
1194 const APInt &AP1,
1195 const APInt &AP2) {
David Majnemer59939ac2014-10-19 08:23:08 +00001196 assert(I.isEquality() && "Cannot fold icmp gt/lt");
1197
David Majnemer59939ac2014-10-19 08:23:08 +00001198 auto getICmp = [&I](CmpInst::Predicate Pred, Value *LHS, Value *RHS) {
1199 if (I.getPredicate() == I.ICMP_NE)
1200 Pred = CmpInst::getInversePredicate(Pred);
1201 return new ICmpInst(Pred, LHS, RHS);
1202 };
1203
David Majnemer2abb8182014-10-25 07:13:13 +00001204 // Don't bother doing any work for cases which InstSimplify handles.
Craig Topper73ba1c82017-06-07 07:40:37 +00001205 if (AP2.isNullValue())
David Majnemer2abb8182014-10-25 07:13:13 +00001206 return nullptr;
David Majnemer59939ac2014-10-19 08:23:08 +00001207
1208 unsigned AP2TrailingZeros = AP2.countTrailingZeros();
1209
1210 if (!AP1 && AP2TrailingZeros != 0)
Sanjay Patelaf91d1f2016-09-15 21:35:30 +00001211 return getICmp(
1212 I.ICMP_UGE, A,
1213 ConstantInt::get(A->getType(), AP2.getBitWidth() - AP2TrailingZeros));
David Majnemer59939ac2014-10-19 08:23:08 +00001214
1215 if (AP1 == AP2)
1216 return getICmp(I.ICMP_EQ, A, ConstantInt::getNullValue(A->getType()));
1217
1218 // Get the distance between the lowest bits that are set.
1219 int Shift = AP1.countTrailingZeros() - AP2TrailingZeros;
1220
1221 if (Shift > 0 && AP2.shl(Shift) == AP1)
1222 return getICmp(I.ICMP_EQ, A, ConstantInt::get(A->getType(), Shift));
1223
1224 // Shifting const2 will never be equal to const1.
Sanjay Patel524fcdf2016-09-15 19:04:55 +00001225 // FIXME: This should always be handled by InstSimplify?
1226 auto *TorF = ConstantInt::get(I.getType(), I.getPredicate() == I.ICMP_NE);
1227 return replaceInstUsesWith(I, TorF);
David Majnemer59939ac2014-10-19 08:23:08 +00001228}
1229
Sanjay Patel06b127a2016-09-15 14:37:50 +00001230/// The caller has matched a pattern of the form:
1231/// I = icmp ugt (add (add A, B), CI2), CI1
1232/// If this is of the form:
1233/// sum = a + b
1234/// if (sum+128 >u 255)
1235/// Then replace it with llvm.sadd.with.overflow.i8.
1236///
Sanjay Pateld93c4c02016-09-15 18:22:25 +00001237static Instruction *processUGT_ADDCST_ADD(ICmpInst &I, Value *A, Value *B,
Sanjay Patel06b127a2016-09-15 14:37:50 +00001238 ConstantInt *CI2, ConstantInt *CI1,
1239 InstCombiner &IC) {
1240 // The transformation we're trying to do here is to transform this into an
1241 // llvm.sadd.with.overflow. To do this, we have to replace the original add
1242 // with a narrower add, and discard the add-with-constant that is part of the
1243 // range check (if we can't eliminate it, this isn't profitable).
1244
1245 // In order to eliminate the add-with-constant, the compare can be its only
1246 // use.
1247 Instruction *AddWithCst = cast<Instruction>(I.getOperand(0));
1248 if (!AddWithCst->hasOneUse())
1249 return nullptr;
1250
1251 // If CI2 is 2^7, 2^15, 2^31, then it might be an sadd.with.overflow.
1252 if (!CI2->getValue().isPowerOf2())
1253 return nullptr;
1254 unsigned NewWidth = CI2->getValue().countTrailingZeros();
1255 if (NewWidth != 7 && NewWidth != 15 && NewWidth != 31)
1256 return nullptr;
1257
1258 // The width of the new add formed is 1 more than the bias.
1259 ++NewWidth;
1260
1261 // Check to see that CI1 is an all-ones value with NewWidth bits.
1262 if (CI1->getBitWidth() == NewWidth ||
1263 CI1->getValue() != APInt::getLowBitsSet(CI1->getBitWidth(), NewWidth))
1264 return nullptr;
1265
1266 // This is only really a signed overflow check if the inputs have been
1267 // sign-extended; check for that condition. For example, if CI2 is 2^31 and
1268 // the operands of the add are 64 bits wide, we need at least 33 sign bits.
1269 unsigned NeededSignBits = CI1->getBitWidth() - NewWidth + 1;
1270 if (IC.ComputeNumSignBits(A, 0, &I) < NeededSignBits ||
1271 IC.ComputeNumSignBits(B, 0, &I) < NeededSignBits)
1272 return nullptr;
1273
1274 // In order to replace the original add with a narrower
1275 // llvm.sadd.with.overflow, the only uses allowed are the add-with-constant
1276 // and truncates that discard the high bits of the add. Verify that this is
1277 // the case.
1278 Instruction *OrigAdd = cast<Instruction>(AddWithCst->getOperand(0));
1279 for (User *U : OrigAdd->users()) {
1280 if (U == AddWithCst)
1281 continue;
1282
1283 // Only accept truncates for now. We would really like a nice recursive
1284 // predicate like SimplifyDemandedBits, but which goes downwards the use-def
1285 // chain to see which bits of a value are actually demanded. If the
1286 // original add had another add which was then immediately truncated, we
1287 // could still do the transformation.
1288 TruncInst *TI = dyn_cast<TruncInst>(U);
1289 if (!TI || TI->getType()->getPrimitiveSizeInBits() > NewWidth)
1290 return nullptr;
1291 }
1292
1293 // If the pattern matches, truncate the inputs to the narrower type and
1294 // use the sadd_with_overflow intrinsic to efficiently compute both the
1295 // result and the overflow bit.
1296 Type *NewType = IntegerType::get(OrigAdd->getContext(), NewWidth);
1297 Value *F = Intrinsic::getDeclaration(I.getModule(),
1298 Intrinsic::sadd_with_overflow, NewType);
1299
Craig Topperbb4069e2017-07-07 23:16:26 +00001300 InstCombiner::BuilderTy &Builder = IC.Builder;
Sanjay Patel06b127a2016-09-15 14:37:50 +00001301
1302 // Put the new code above the original add, in case there are any uses of the
1303 // add between the add and the compare.
Craig Topperbb4069e2017-07-07 23:16:26 +00001304 Builder.SetInsertPoint(OrigAdd);
Sanjay Patel06b127a2016-09-15 14:37:50 +00001305
Craig Topperbb4069e2017-07-07 23:16:26 +00001306 Value *TruncA = Builder.CreateTrunc(A, NewType, A->getName() + ".trunc");
1307 Value *TruncB = Builder.CreateTrunc(B, NewType, B->getName() + ".trunc");
1308 CallInst *Call = Builder.CreateCall(F, {TruncA, TruncB}, "sadd");
1309 Value *Add = Builder.CreateExtractValue(Call, 0, "sadd.result");
1310 Value *ZExt = Builder.CreateZExt(Add, OrigAdd->getType());
Sanjay Patel06b127a2016-09-15 14:37:50 +00001311
1312 // The inner add was the result of the narrow add, zero extended to the
1313 // wider type. Replace it with the result computed by the intrinsic.
1314 IC.replaceInstUsesWith(*OrigAdd, ZExt);
1315
1316 // The original icmp gets replaced with the overflow value.
1317 return ExtractValueInst::Create(Call, 1, "sadd.overflow");
1318}
1319
Nikolai Bozhenov0e7ebbc2017-10-16 09:19:21 +00001320// Handle (icmp sgt smin(PosA, B) 0) -> (icmp sgt B 0)
1321Instruction *InstCombiner::foldICmpWithZero(ICmpInst &Cmp) {
1322 CmpInst::Predicate Pred = Cmp.getPredicate();
1323 Value *X = Cmp.getOperand(0);
1324
1325 if (match(Cmp.getOperand(1), m_Zero()) && Pred == ICmpInst::ICMP_SGT) {
1326 Value *A, *B;
1327 SelectPatternResult SPR = matchSelectPattern(X, A, B);
1328 if (SPR.Flavor == SPF_SMIN) {
1329 if (isKnownPositive(A, DL, 0, &AC, &Cmp, &DT))
1330 return new ICmpInst(Pred, B, Cmp.getOperand(1));
1331 if (isKnownPositive(B, DL, 0, &AC, &Cmp, &DT))
1332 return new ICmpInst(Pred, A, Cmp.getOperand(1));
1333 }
1334 }
1335 return nullptr;
1336}
1337
Sanjay Patela40bf9ff2018-12-04 15:35:17 +00001338/// Fold icmp Pred X, C.
Sanjay Pateld23b5ed2018-12-04 17:44:24 +00001339/// TODO: This code structure does not make sense. The saturating add fold
Sanjay Patela40bf9ff2018-12-04 15:35:17 +00001340/// should be moved to some other helper and extended as noted below (it is also
Sanjay Pateld23b5ed2018-12-04 17:44:24 +00001341/// possible that code has been made unnecessary - do we canonicalize IR to
1342/// overflow/saturating intrinsics or not?).
Sanjay Patel97459832016-09-15 15:11:12 +00001343Instruction *InstCombiner::foldICmpWithConstant(ICmpInst &Cmp) {
Sanjay Patel97459832016-09-15 15:11:12 +00001344 // Match the following pattern, which is a common idiom when writing
1345 // overflow-safe integer arithmetic functions. The source performs an addition
1346 // in wider type and explicitly checks for overflow using comparisons against
1347 // INT_MIN and INT_MAX. Simplify by using the sadd_with_overflow intrinsic.
1348 //
1349 // TODO: This could probably be generalized to handle other overflow-safe
1350 // operations if we worked out the formulas to compute the appropriate magic
1351 // constants.
1352 //
1353 // sum = a + b
1354 // if (sum+128 >u 255) ... -> llvm.sadd.with.overflow.i8
Sanjay Patela40bf9ff2018-12-04 15:35:17 +00001355 CmpInst::Predicate Pred = Cmp.getPredicate();
1356 Value *Op0 = Cmp.getOperand(0), *Op1 = Cmp.getOperand(1);
1357 Value *A, *B;
1358 ConstantInt *CI, *CI2; // I = icmp ugt (add (add A, B), CI2), CI
1359 if (Pred == ICmpInst::ICMP_UGT && match(Op1, m_ConstantInt(CI)) &&
1360 match(Op0, m_Add(m_Add(m_Value(A), m_Value(B)), m_ConstantInt(CI2))))
1361 if (Instruction *Res = processUGT_ADDCST_ADD(Cmp, A, B, CI2, CI, *this))
1362 return Res;
Sanjay Patel06b127a2016-09-15 14:37:50 +00001363
Sanjay Patela40bf9ff2018-12-04 15:35:17 +00001364 return nullptr;
1365}
1366
1367/// Canonicalize icmp instructions based on dominating conditions.
1368Instruction *InstCombiner::foldICmpWithDominatingICmp(ICmpInst &Cmp) {
Sanjay Pateld23b5ed2018-12-04 17:44:24 +00001369 // This is a cheap/incomplete check for dominance - just match a single
1370 // predecessor with a conditional branch.
1371 BasicBlock *CmpBB = Cmp.getParent();
1372 BasicBlock *DomBB = CmpBB->getSinglePredecessor();
1373 if (!DomBB)
Sanjay Patel40c53ea2016-09-15 16:23:20 +00001374 return nullptr;
Sanjay Patel06b127a2016-09-15 14:37:50 +00001375
Sanjay Pateld23b5ed2018-12-04 17:44:24 +00001376 Value *DomCond;
Sanjay Patel97459832016-09-15 15:11:12 +00001377 BasicBlock *TrueBB, *FalseBB;
Sanjay Pateld23b5ed2018-12-04 17:44:24 +00001378 if (!match(DomBB->getTerminator(), m_Br(m_Value(DomCond), TrueBB, FalseBB)))
1379 return nullptr;
1380
1381 assert((TrueBB == CmpBB || FalseBB == CmpBB) &&
1382 "Predecessor block does not point to successor?");
1383
1384 // The branch should get simplified. Don't bother simplifying this condition.
1385 if (TrueBB == FalseBB)
1386 return nullptr;
1387
Sanjay Patelbaffae92018-12-05 15:04:00 +00001388 // Try to simplify this compare to T/F based on the dominating condition.
1389 Optional<bool> Imp = isImpliedCondition(DomCond, &Cmp, DL, TrueBB == CmpBB);
1390 if (Imp)
1391 return replaceInstUsesWith(Cmp, ConstantInt::get(Cmp.getType(), *Imp));
1392
Sanjay Pateld23b5ed2018-12-04 17:44:24 +00001393 CmpInst::Predicate Pred = Cmp.getPredicate();
1394 Value *X = Cmp.getOperand(0), *Y = Cmp.getOperand(1);
1395 ICmpInst::Predicate DomPred;
1396 const APInt *C, *DomC;
1397 if (match(DomCond, m_ICmp(DomPred, m_Specific(X), m_APInt(DomC))) &&
1398 match(Y, m_APInt(C))) {
1399 // We have 2 compares of a variable with constants. Calculate the constant
1400 // ranges of those compares to see if we can transform the 2nd compare:
1401 // DomBB:
1402 // DomCond = icmp DomPred X, DomC
1403 // br DomCond, CmpBB, FalseBB
1404 // CmpBB:
1405 // Cmp = icmp Pred X, C
1406 ConstantRange CR = ConstantRange::makeAllowedICmpRegion(Pred, *C);
Sanjay Patel97459832016-09-15 15:11:12 +00001407 ConstantRange DominatingCR =
Sanjay Pateld23b5ed2018-12-04 17:44:24 +00001408 (CmpBB == TrueBB) ? ConstantRange::makeExactICmpRegion(DomPred, *DomC)
1409 : ConstantRange::makeExactICmpRegion(
1410 CmpInst::getInversePredicate(DomPred), *DomC);
Sanjay Patel97459832016-09-15 15:11:12 +00001411 ConstantRange Intersection = DominatingCR.intersectWith(CR);
1412 ConstantRange Difference = DominatingCR.difference(CR);
1413 if (Intersection.isEmptySet())
Craig Topperbb4069e2017-07-07 23:16:26 +00001414 return replaceInstUsesWith(Cmp, Builder.getFalse());
Sanjay Patel97459832016-09-15 15:11:12 +00001415 if (Difference.isEmptySet())
Craig Topperbb4069e2017-07-07 23:16:26 +00001416 return replaceInstUsesWith(Cmp, Builder.getTrue());
Sanjay Patel06b127a2016-09-15 14:37:50 +00001417
Sanjay Patel97459832016-09-15 15:11:12 +00001418 // Canonicalizing a sign bit comparison that gets used in a branch,
1419 // pessimizes codegen by generating branch on zero instruction instead
1420 // of a test and branch. So we avoid canonicalizing in such situations
1421 // because test and branch instruction has better branch displacement
1422 // than compare and branch instruction.
Sanjay Pateld23b5ed2018-12-04 17:44:24 +00001423 bool UnusedBit;
1424 bool IsSignBit = isSignBitCheck(Pred, *C, UnusedBit);
Eric Christophera95aac32017-06-30 01:57:48 +00001425 if (Cmp.isEquality() || (IsSignBit && hasBranchUse(Cmp)))
1426 return nullptr;
1427
Sanjay Pateld23b5ed2018-12-04 17:44:24 +00001428 if (const APInt *EqC = Intersection.getSingleElement())
1429 return new ICmpInst(ICmpInst::ICMP_EQ, X, Builder.getInt(*EqC));
1430 if (const APInt *NeC = Difference.getSingleElement())
1431 return new ICmpInst(ICmpInst::ICMP_NE, X, Builder.getInt(*NeC));
Sanjay Patel06b127a2016-09-15 14:37:50 +00001432 }
1433
1434 return nullptr;
1435}
1436
Sanjay Patel5f4ce4e2016-08-18 20:25:16 +00001437/// Fold icmp (trunc X, Y), C.
1438Instruction *InstCombiner::foldICmpTruncConstant(ICmpInst &Cmp,
Craig Topper524c44f2017-08-23 05:46:07 +00001439 TruncInst *Trunc,
Craig Topper8ed1aa92017-10-03 05:31:07 +00001440 const APInt &C) {
Sanjay Patel5f4ce4e2016-08-18 20:25:16 +00001441 ICmpInst::Predicate Pred = Cmp.getPredicate();
1442 Value *X = Trunc->getOperand(0);
Craig Topper8ed1aa92017-10-03 05:31:07 +00001443 if (C.isOneValue() && C.getBitWidth() > 1) {
Sanjay Patela3f4f082016-08-16 17:54:36 +00001444 // icmp slt trunc(signum(V)) 1 --> icmp slt V, 1
1445 Value *V = nullptr;
Sanjay Patel5f4ce4e2016-08-18 20:25:16 +00001446 if (Pred == ICmpInst::ICMP_SLT && match(X, m_Signum(m_Value(V))))
Sanjay Patela3f4f082016-08-16 17:54:36 +00001447 return new ICmpInst(ICmpInst::ICMP_SLT, V,
1448 ConstantInt::get(V->getType(), 1));
1449 }
Sanjay Patel5f4ce4e2016-08-18 20:25:16 +00001450
1451 if (Cmp.isEquality() && Trunc->hasOneUse()) {
Sanjay Patela3f4f082016-08-16 17:54:36 +00001452 // Simplify icmp eq (trunc x to i8), 42 -> icmp eq x, 42|highbits if all
1453 // of the high bits truncated out of x are known.
Sanjay Patel40e8ca42016-08-18 20:28:54 +00001454 unsigned DstBits = Trunc->getType()->getScalarSizeInBits(),
1455 SrcBits = X->getType()->getScalarSizeInBits();
Craig Topper8205a1a2017-05-24 16:53:07 +00001456 KnownBits Known = computeKnownBits(X, 0, &Cmp);
Sanjay Patela3f4f082016-08-16 17:54:36 +00001457
1458 // If all the high bits are known, we can do this xform.
Craig Topperb45eabc2017-04-26 16:39:58 +00001459 if ((Known.Zero | Known.One).countLeadingOnes() >= SrcBits - DstBits) {
Sanjay Patela3f4f082016-08-16 17:54:36 +00001460 // Pull in the high bits from known-ones set.
Craig Topper8ed1aa92017-10-03 05:31:07 +00001461 APInt NewRHS = C.zext(SrcBits);
Craig Topperb45eabc2017-04-26 16:39:58 +00001462 NewRHS |= Known.One & APInt::getHighBitsSet(SrcBits, SrcBits - DstBits);
Sanjay Patel40e8ca42016-08-18 20:28:54 +00001463 return new ICmpInst(Pred, X, ConstantInt::get(X->getType(), NewRHS));
Sanjay Patela3f4f082016-08-16 17:54:36 +00001464 }
1465 }
Sanjay Patel5f4ce4e2016-08-18 20:25:16 +00001466
Sanjay Patela3f4f082016-08-16 17:54:36 +00001467 return nullptr;
1468}
1469
Sanjay Patel6d5f4482016-08-17 19:23:42 +00001470/// Fold icmp (xor X, Y), C.
Sanjay Patelc9196c42016-08-22 21:24:29 +00001471Instruction *InstCombiner::foldICmpXorConstant(ICmpInst &Cmp,
1472 BinaryOperator *Xor,
Craig Topper8ed1aa92017-10-03 05:31:07 +00001473 const APInt &C) {
Sanjay Patel4c5e60d2016-08-18 14:10:48 +00001474 Value *X = Xor->getOperand(0);
1475 Value *Y = Xor->getOperand(1);
Sanjay Pateldaffec912016-08-17 19:45:18 +00001476 const APInt *XorC;
Sanjay Patel4c5e60d2016-08-18 14:10:48 +00001477 if (!match(Y, m_APInt(XorC)))
Sanjay Patel6d5f4482016-08-17 19:23:42 +00001478 return nullptr;
Sanjay Patela3f4f082016-08-16 17:54:36 +00001479
Sanjay Patel6d5f4482016-08-17 19:23:42 +00001480 // If this is a comparison that tests the signbit (X < 0) or (x > -1),
1481 // fold the xor.
1482 ICmpInst::Predicate Pred = Cmp.getPredicate();
Craig Topperdf63b962017-10-03 19:14:23 +00001483 bool TrueIfSigned = false;
1484 if (isSignBitCheck(Cmp.getPredicate(), C, TrueIfSigned)) {
Sanjay Patela3f4f082016-08-16 17:54:36 +00001485
Sanjay Patel6d5f4482016-08-17 19:23:42 +00001486 // If the sign bit of the XorCst is not set, there is no change to
1487 // the operation, just stop using the Xor.
Sanjay Pateldaffec912016-08-17 19:45:18 +00001488 if (!XorC->isNegative()) {
1489 Cmp.setOperand(0, X);
Sanjay Patel6d5f4482016-08-17 19:23:42 +00001490 Worklist.Add(Xor);
1491 return &Cmp;
Sanjay Patela3f4f082016-08-16 17:54:36 +00001492 }
1493
Craig Topperdf63b962017-10-03 19:14:23 +00001494 // Emit the opposite comparison.
1495 if (TrueIfSigned)
1496 return new ICmpInst(ICmpInst::ICMP_SGT, X,
1497 ConstantInt::getAllOnesValue(X->getType()));
Sanjay Patel6d5f4482016-08-17 19:23:42 +00001498 else
Craig Topperdf63b962017-10-03 19:14:23 +00001499 return new ICmpInst(ICmpInst::ICMP_SLT, X,
1500 ConstantInt::getNullValue(X->getType()));
Sanjay Patela3f4f082016-08-16 17:54:36 +00001501 }
Sanjay Patel6d5f4482016-08-17 19:23:42 +00001502
1503 if (Xor->hasOneUse()) {
Craig Topperbcfd2d12017-04-20 16:56:25 +00001504 // (icmp u/s (xor X SignMask), C) -> (icmp s/u X, (xor C SignMask))
1505 if (!Cmp.isEquality() && XorC->isSignMask()) {
Sanjay Pateldaffec912016-08-17 19:45:18 +00001506 Pred = Cmp.isSigned() ? Cmp.getUnsignedPredicate()
1507 : Cmp.getSignedPredicate();
Craig Topper8ed1aa92017-10-03 05:31:07 +00001508 return new ICmpInst(Pred, X, ConstantInt::get(X->getType(), C ^ *XorC));
Sanjay Patel6d5f4482016-08-17 19:23:42 +00001509 }
1510
Craig Topperbcfd2d12017-04-20 16:56:25 +00001511 // (icmp u/s (xor X ~SignMask), C) -> (icmp s/u X, (xor C ~SignMask))
Sanjay Pateldaffec912016-08-17 19:45:18 +00001512 if (!Cmp.isEquality() && XorC->isMaxSignedValue()) {
1513 Pred = Cmp.isSigned() ? Cmp.getUnsignedPredicate()
1514 : Cmp.getSignedPredicate();
Sanjay Patel6d5f4482016-08-17 19:23:42 +00001515 Pred = Cmp.getSwappedPredicate(Pred);
Craig Topper8ed1aa92017-10-03 05:31:07 +00001516 return new ICmpInst(Pred, X, ConstantInt::get(X->getType(), C ^ *XorC));
Sanjay Patel6d5f4482016-08-17 19:23:42 +00001517 }
1518 }
1519
Sanjay Patel26725bd2018-09-11 22:00:15 +00001520 // Mask constant magic can eliminate an 'xor' with unsigned compares.
1521 if (Pred == ICmpInst::ICMP_UGT) {
1522 // (xor X, ~C) >u C --> X <u ~C (when C+1 is a power of 2)
1523 if (*XorC == ~C && (C + 1).isPowerOf2())
1524 return new ICmpInst(ICmpInst::ICMP_ULT, X, Y);
1525 // (xor X, C) >u C --> X >u C (when C+1 is a power of 2)
1526 if (*XorC == C && (C + 1).isPowerOf2())
1527 return new ICmpInst(ICmpInst::ICMP_UGT, X, Y);
1528 }
1529 if (Pred == ICmpInst::ICMP_ULT) {
1530 // (xor X, -C) <u C --> X >u ~C (when C is a power of 2)
1531 if (*XorC == -C && C.isPowerOf2())
1532 return new ICmpInst(ICmpInst::ICMP_UGT, X,
1533 ConstantInt::get(X->getType(), ~C));
1534 // (xor X, C) <u C --> X >u ~C (when -C is a power of 2)
1535 if (*XorC == C && (-C).isPowerOf2())
1536 return new ICmpInst(ICmpInst::ICMP_UGT, X,
1537 ConstantInt::get(X->getType(), ~C));
1538 }
Sanjay Patela3f4f082016-08-16 17:54:36 +00001539 return nullptr;
1540}
1541
Sanjay Patel14e0e182016-08-26 18:28:46 +00001542/// Fold icmp (and (sh X, Y), C2), C1.
1543Instruction *InstCombiner::foldICmpAndShift(ICmpInst &Cmp, BinaryOperator *And,
Craig Topper8ed1aa92017-10-03 05:31:07 +00001544 const APInt &C1, const APInt &C2) {
Sanjay Patel9b40f982016-09-07 22:33:03 +00001545 BinaryOperator *Shift = dyn_cast<BinaryOperator>(And->getOperand(0));
1546 if (!Shift || !Shift->isShift())
Sanjay Patelda9c5622016-08-26 17:15:22 +00001547 return nullptr;
Sanjay Patela3f4f082016-08-16 17:54:36 +00001548
Sanjay Patelda9c5622016-08-26 17:15:22 +00001549 // If this is: (X >> C3) & C2 != C1 (where any shift and any compare could
1550 // exist), turn it into (X & (C2 << C3)) != (C1 << C3). This happens a LOT in
1551 // code produced by the clang front-end, for bitfield access.
Sanjay Patelda9c5622016-08-26 17:15:22 +00001552 // This seemingly simple opportunity to fold away a shift turns out to be
1553 // rather complicated. See PR17827 for details.
Sanjay Patel9b40f982016-09-07 22:33:03 +00001554 unsigned ShiftOpcode = Shift->getOpcode();
1555 bool IsShl = ShiftOpcode == Instruction::Shl;
1556 const APInt *C3;
1557 if (match(Shift->getOperand(1), m_APInt(C3))) {
Sanjay Patelda9c5622016-08-26 17:15:22 +00001558 bool CanFold = false;
Craig Topper7a930922017-10-04 23:06:13 +00001559 if (ShiftOpcode == Instruction::Shl) {
Sanjay Patelda9c5622016-08-26 17:15:22 +00001560 // For a left shift, we can fold if the comparison is not signed. We can
1561 // also fold a signed comparison if the mask value and comparison value
1562 // are not negative. These constraints may not be obvious, but we can
1563 // prove that they are correct using an SMT solver.
Craig Topper8ed1aa92017-10-03 05:31:07 +00001564 if (!Cmp.isSigned() || (!C2.isNegative() && !C1.isNegative()))
Sanjay Patelda9c5622016-08-26 17:15:22 +00001565 CanFold = true;
Craig Topper7a930922017-10-04 23:06:13 +00001566 } else {
1567 bool IsAshr = ShiftOpcode == Instruction::AShr;
Sanjay Patelda9c5622016-08-26 17:15:22 +00001568 // For a logical right shift, we can fold if the comparison is not signed.
1569 // We can also fold a signed comparison if the shifted mask value and the
1570 // shifted comparison value are not negative. These constraints may not be
1571 // obvious, but we can prove that they are correct using an SMT solver.
Craig Topper7a930922017-10-04 23:06:13 +00001572 // For an arithmetic shift right we can do the same, if we ensure
1573 // the And doesn't use any bits being shifted in. Normally these would
1574 // be turned into lshr by SimplifyDemandedBits, but not if there is an
1575 // additional user.
1576 if (!IsAshr || (C2.shl(*C3).lshr(*C3) == C2)) {
1577 if (!Cmp.isSigned() ||
1578 (!C2.shl(*C3).isNegative() && !C1.shl(*C3).isNegative()))
1579 CanFold = true;
1580 }
Sanjay Patela3f4f082016-08-16 17:54:36 +00001581 }
1582
Sanjay Patelda9c5622016-08-26 17:15:22 +00001583 if (CanFold) {
Craig Topper8ed1aa92017-10-03 05:31:07 +00001584 APInt NewCst = IsShl ? C1.lshr(*C3) : C1.shl(*C3);
Sanjay Patel9b40f982016-09-07 22:33:03 +00001585 APInt SameAsC1 = IsShl ? NewCst.shl(*C3) : NewCst.lshr(*C3);
Sanjay Patelda9c5622016-08-26 17:15:22 +00001586 // Check to see if we are shifting out any of the bits being compared.
Craig Topper8ed1aa92017-10-03 05:31:07 +00001587 if (SameAsC1 != C1) {
Sanjay Patelda9c5622016-08-26 17:15:22 +00001588 // If we shifted bits out, the fold is not going to work out. As a
1589 // special case, check to see if this means that the result is always
1590 // true or false now.
1591 if (Cmp.getPredicate() == ICmpInst::ICMP_EQ)
Sanjay Patel1c608f42016-09-08 16:54:02 +00001592 return replaceInstUsesWith(Cmp, ConstantInt::getFalse(Cmp.getType()));
Sanjay Patelda9c5622016-08-26 17:15:22 +00001593 if (Cmp.getPredicate() == ICmpInst::ICMP_NE)
Sanjay Patel1c608f42016-09-08 16:54:02 +00001594 return replaceInstUsesWith(Cmp, ConstantInt::getTrue(Cmp.getType()));
Sanjay Patela3f4f082016-08-16 17:54:36 +00001595 } else {
Sanjay Patel9b40f982016-09-07 22:33:03 +00001596 Cmp.setOperand(1, ConstantInt::get(And->getType(), NewCst));
Craig Topper8ed1aa92017-10-03 05:31:07 +00001597 APInt NewAndCst = IsShl ? C2.lshr(*C3) : C2.shl(*C3);
Sanjay Patel9b40f982016-09-07 22:33:03 +00001598 And->setOperand(1, ConstantInt::get(And->getType(), NewAndCst));
Sanjay Patelda9c5622016-08-26 17:15:22 +00001599 And->setOperand(0, Shift->getOperand(0));
1600 Worklist.Add(Shift); // Shift is dead.
1601 return &Cmp;
Sanjay Patela3f4f082016-08-16 17:54:36 +00001602 }
Sanjay Patelda9c5622016-08-26 17:15:22 +00001603 }
1604 }
Sanjay Patela3f4f082016-08-16 17:54:36 +00001605
Sanjay Patelda9c5622016-08-26 17:15:22 +00001606 // Turn ((X >> Y) & C2) == 0 into (X & (C2 << Y)) == 0. The latter is
1607 // preferable because it allows the C2 << Y expression to be hoisted out of a
1608 // loop if Y is invariant and X is not.
Craig Topper8ed1aa92017-10-03 05:31:07 +00001609 if (Shift->hasOneUse() && C1.isNullValue() && Cmp.isEquality() &&
Sanjay Patelda9c5622016-08-26 17:15:22 +00001610 !Shift->isArithmeticShift() && !isa<Constant>(Shift->getOperand(0))) {
1611 // Compute C2 << Y.
Sanjay Patel9b40f982016-09-07 22:33:03 +00001612 Value *NewShift =
Craig Topperbb4069e2017-07-07 23:16:26 +00001613 IsShl ? Builder.CreateLShr(And->getOperand(1), Shift->getOperand(1))
1614 : Builder.CreateShl(And->getOperand(1), Shift->getOperand(1));
Sanjay Patela3f4f082016-08-16 17:54:36 +00001615
Sanjay Patelda9c5622016-08-26 17:15:22 +00001616 // Compute X & (C2 << Y).
Craig Topperbb4069e2017-07-07 23:16:26 +00001617 Value *NewAnd = Builder.CreateAnd(Shift->getOperand(0), NewShift);
Sanjay Patelda9c5622016-08-26 17:15:22 +00001618 Cmp.setOperand(0, NewAnd);
1619 return &Cmp;
1620 }
1621
Sanjay Patel14e0e182016-08-26 18:28:46 +00001622 return nullptr;
1623}
1624
1625/// Fold icmp (and X, C2), C1.
1626Instruction *InstCombiner::foldICmpAndConstConst(ICmpInst &Cmp,
1627 BinaryOperator *And,
Craig Topper8ed1aa92017-10-03 05:31:07 +00001628 const APInt &C1) {
Sanjay Patel05aadf82018-10-10 20:47:46 +00001629 // For vectors: icmp ne (and X, 1), 0 --> trunc X to N x i1
1630 // TODO: We canonicalize to the longer form for scalars because we have
1631 // better analysis/folds for icmp, and codegen may be better with icmp.
1632 if (Cmp.getPredicate() == CmpInst::ICMP_NE && Cmp.getType()->isVectorTy() &&
1633 C1.isNullValue() && match(And->getOperand(1), m_One()))
1634 return new TruncInst(And->getOperand(0), Cmp.getType());
1635
Sanjay Patel6b490972016-09-04 14:32:15 +00001636 const APInt *C2;
1637 if (!match(And->getOperand(1), m_APInt(C2)))
Sanjay Patel14e0e182016-08-26 18:28:46 +00001638 return nullptr;
1639
Craig Topper8bf62212017-09-26 18:47:25 +00001640 if (!And->hasOneUse())
Sanjay Patel14e0e182016-08-26 18:28:46 +00001641 return nullptr;
1642
Sanjay Patel6b490972016-09-04 14:32:15 +00001643 // If the LHS is an 'and' of a truncate and we can widen the and/compare to
1644 // the input width without changing the value produced, eliminate the cast:
1645 //
1646 // icmp (and (trunc W), C2), C1 -> icmp (and W, C2'), C1'
1647 //
1648 // We can do this transformation if the constants do not have their sign bits
1649 // set or if it is an equality comparison. Extending a relational comparison
1650 // when we're checking the sign bit would not work.
1651 Value *W;
Craig Topper8bf62212017-09-26 18:47:25 +00001652 if (match(And->getOperand(0), m_OneUse(m_Trunc(m_Value(W)))) &&
Craig Topper8ed1aa92017-10-03 05:31:07 +00001653 (Cmp.isEquality() || (!C1.isNegative() && !C2->isNegative()))) {
Sanjay Patel6b490972016-09-04 14:32:15 +00001654 // TODO: Is this a good transform for vectors? Wider types may reduce
1655 // throughput. Should this transform be limited (even for scalars) by using
Sanjay Patel2217f752017-01-31 17:25:42 +00001656 // shouldChangeType()?
Sanjay Patel6b490972016-09-04 14:32:15 +00001657 if (!Cmp.getType()->isVectorTy()) {
1658 Type *WideType = W->getType();
1659 unsigned WideScalarBits = WideType->getScalarSizeInBits();
Craig Topper8ed1aa92017-10-03 05:31:07 +00001660 Constant *ZextC1 = ConstantInt::get(WideType, C1.zext(WideScalarBits));
Sanjay Patel6b490972016-09-04 14:32:15 +00001661 Constant *ZextC2 = ConstantInt::get(WideType, C2->zext(WideScalarBits));
Craig Topperbb4069e2017-07-07 23:16:26 +00001662 Value *NewAnd = Builder.CreateAnd(W, ZextC2, And->getName());
Sanjay Patel6b490972016-09-04 14:32:15 +00001663 return new ICmpInst(Cmp.getPredicate(), NewAnd, ZextC1);
Sanjay Patel14e0e182016-08-26 18:28:46 +00001664 }
1665 }
1666
Craig Topper8ed1aa92017-10-03 05:31:07 +00001667 if (Instruction *I = foldICmpAndShift(Cmp, And, C1, *C2))
Sanjay Patel14e0e182016-08-26 18:28:46 +00001668 return I;
1669
Sanjay Patelda9c5622016-08-26 17:15:22 +00001670 // (icmp pred (and (or (lshr A, B), A), 1), 0) -->
Sanjay Patel6b490972016-09-04 14:32:15 +00001671 // (icmp pred (and A, (or (shl 1, B), 1), 0))
Sanjay Patelda9c5622016-08-26 17:15:22 +00001672 //
1673 // iff pred isn't signed
Craig Topper8ed1aa92017-10-03 05:31:07 +00001674 if (!Cmp.isSigned() && C1.isNullValue() && And->getOperand(0)->hasOneUse() &&
Craig Topper73ba1c82017-06-07 07:40:37 +00001675 match(And->getOperand(1), m_One())) {
Sanjay Pateldef931e2016-09-07 20:50:44 +00001676 Constant *One = cast<Constant>(And->getOperand(1));
1677 Value *Or = And->getOperand(0);
Sanjay Patelda9c5622016-08-26 17:15:22 +00001678 Value *A, *B, *LShr;
Sanjay Pateldef931e2016-09-07 20:50:44 +00001679 if (match(Or, m_Or(m_Value(LShr), m_Value(A))) &&
1680 match(LShr, m_LShr(m_Specific(A), m_Value(B)))) {
1681 unsigned UsesRemoved = 0;
1682 if (And->hasOneUse())
1683 ++UsesRemoved;
1684 if (Or->hasOneUse())
1685 ++UsesRemoved;
1686 if (LShr->hasOneUse())
1687 ++UsesRemoved;
1688
1689 // Compute A & ((1 << B) | 1)
1690 Value *NewOr = nullptr;
1691 if (auto *C = dyn_cast<Constant>(B)) {
1692 if (UsesRemoved >= 1)
1693 NewOr = ConstantExpr::getOr(ConstantExpr::getNUWShl(One, C), One);
1694 } else {
1695 if (UsesRemoved >= 3)
Craig Topperbb4069e2017-07-07 23:16:26 +00001696 NewOr = Builder.CreateOr(Builder.CreateShl(One, B, LShr->getName(),
1697 /*HasNUW=*/true),
1698 One, Or->getName());
Sanjay Pateldef931e2016-09-07 20:50:44 +00001699 }
1700 if (NewOr) {
Craig Topperbb4069e2017-07-07 23:16:26 +00001701 Value *NewAnd = Builder.CreateAnd(A, NewOr, And->getName());
Sanjay Pateldef931e2016-09-07 20:50:44 +00001702 Cmp.setOperand(0, NewAnd);
1703 return &Cmp;
Sanjay Patela3f4f082016-08-16 17:54:36 +00001704 }
1705 }
Sanjay Patela3f4f082016-08-16 17:54:36 +00001706 }
Sanjay Patelda9c5622016-08-26 17:15:22 +00001707
Sanjay Pateld3c7bb282016-08-26 16:42:33 +00001708 return nullptr;
1709}
1710
1711/// Fold icmp (and X, Y), C.
1712Instruction *InstCombiner::foldICmpAndConstant(ICmpInst &Cmp,
1713 BinaryOperator *And,
Craig Topper8ed1aa92017-10-03 05:31:07 +00001714 const APInt &C) {
Sanjay Pateld3c7bb282016-08-26 16:42:33 +00001715 if (Instruction *I = foldICmpAndConstConst(Cmp, And, C))
1716 return I;
1717
Sanjay Patel5c5311f2016-08-28 18:18:00 +00001718 // TODO: These all require that Y is constant too, so refactor with the above.
Sanjay Patela3f4f082016-08-16 17:54:36 +00001719
Sanjay Patel5c5311f2016-08-28 18:18:00 +00001720 // Try to optimize things like "A[i] & 42 == 0" to index computations.
1721 Value *X = And->getOperand(0);
1722 Value *Y = And->getOperand(1);
1723 if (auto *LI = dyn_cast<LoadInst>(X))
1724 if (auto *GEP = dyn_cast<GetElementPtrInst>(LI->getOperand(0)))
1725 if (auto *GV = dyn_cast<GlobalVariable>(GEP->getOperand(0)))
Sanjay Patela3f4f082016-08-16 17:54:36 +00001726 if (GV->isConstant() && GV->hasDefinitiveInitializer() &&
Sanjay Patel5c5311f2016-08-28 18:18:00 +00001727 !LI->isVolatile() && isa<ConstantInt>(Y)) {
1728 ConstantInt *C2 = cast<ConstantInt>(Y);
1729 if (Instruction *Res = foldCmpLoadFromIndexedGlobal(GEP, GV, Cmp, C2))
Sanjay Patela3f4f082016-08-16 17:54:36 +00001730 return Res;
1731 }
Sanjay Patel5c5311f2016-08-28 18:18:00 +00001732
1733 if (!Cmp.isEquality())
1734 return nullptr;
Sanjay Patela3f4f082016-08-16 17:54:36 +00001735
1736 // X & -C == -C -> X > u ~C
1737 // X & -C != -C -> X <= u ~C
1738 // iff C is a power of 2
Craig Topper8ed1aa92017-10-03 05:31:07 +00001739 if (Cmp.getOperand(1) == Y && (-C).isPowerOf2()) {
Sanjay Patel5c5311f2016-08-28 18:18:00 +00001740 auto NewPred = Cmp.getPredicate() == CmpInst::ICMP_EQ ? CmpInst::ICMP_UGT
1741 : CmpInst::ICMP_ULE;
1742 return new ICmpInst(NewPred, X, SubOne(cast<Constant>(Cmp.getOperand(1))));
1743 }
Sanjay Patela3f4f082016-08-16 17:54:36 +00001744
Sanjay Patel5c5311f2016-08-28 18:18:00 +00001745 // (X & C2) == 0 -> (trunc X) >= 0
1746 // (X & C2) != 0 -> (trunc X) < 0
1747 // iff C2 is a power of 2 and it masks the sign bit of a legal integer type.
1748 const APInt *C2;
Craig Topper8ed1aa92017-10-03 05:31:07 +00001749 if (And->hasOneUse() && C.isNullValue() && match(Y, m_APInt(C2))) {
Sanjay Patel5c5311f2016-08-28 18:18:00 +00001750 int32_t ExactLogBase2 = C2->exactLogBase2();
1751 if (ExactLogBase2 != -1 && DL.isLegalInteger(ExactLogBase2 + 1)) {
1752 Type *NTy = IntegerType::get(Cmp.getContext(), ExactLogBase2 + 1);
1753 if (And->getType()->isVectorTy())
1754 NTy = VectorType::get(NTy, And->getType()->getVectorNumElements());
Craig Topperbb4069e2017-07-07 23:16:26 +00001755 Value *Trunc = Builder.CreateTrunc(X, NTy);
Sanjay Patel5c5311f2016-08-28 18:18:00 +00001756 auto NewPred = Cmp.getPredicate() == CmpInst::ICMP_EQ ? CmpInst::ICMP_SGE
1757 : CmpInst::ICMP_SLT;
1758 return new ICmpInst(NewPred, Trunc, Constant::getNullValue(NTy));
Sanjay Patela3f4f082016-08-16 17:54:36 +00001759 }
1760 }
Sanjay Patel5c5311f2016-08-28 18:18:00 +00001761
Sanjay Patela3f4f082016-08-16 17:54:36 +00001762 return nullptr;
1763}
1764
Sanjay Patel943e92e2016-08-17 16:30:43 +00001765/// Fold icmp (or X, Y), C.
Sanjay Patelc9196c42016-08-22 21:24:29 +00001766Instruction *InstCombiner::foldICmpOrConstant(ICmpInst &Cmp, BinaryOperator *Or,
Craig Topper8ed1aa92017-10-03 05:31:07 +00001767 const APInt &C) {
Sanjay Patel943e92e2016-08-17 16:30:43 +00001768 ICmpInst::Predicate Pred = Cmp.getPredicate();
Craig Topper8ed1aa92017-10-03 05:31:07 +00001769 if (C.isOneValue()) {
Sanjay Patela3f4f082016-08-16 17:54:36 +00001770 // icmp slt signum(V) 1 --> icmp slt V, 1
1771 Value *V = nullptr;
Sanjay Patel943e92e2016-08-17 16:30:43 +00001772 if (Pred == ICmpInst::ICMP_SLT && match(Or, m_Signum(m_Value(V))))
Sanjay Patela3f4f082016-08-16 17:54:36 +00001773 return new ICmpInst(ICmpInst::ICMP_SLT, V,
1774 ConstantInt::get(V->getType(), 1));
1775 }
1776
Sanjay Patel50c82c42017-04-05 17:57:05 +00001777 // X | C == C --> X <=u C
1778 // X | C != C --> X >u C
1779 // iff C+1 is a power of 2 (C is a bitmask of the low bits)
1780 if (Cmp.isEquality() && Cmp.getOperand(1) == Or->getOperand(1) &&
Craig Topper8ed1aa92017-10-03 05:31:07 +00001781 (C + 1).isPowerOf2()) {
Sanjay Patel50c82c42017-04-05 17:57:05 +00001782 Pred = (Pred == CmpInst::ICMP_EQ) ? CmpInst::ICMP_ULE : CmpInst::ICMP_UGT;
1783 return new ICmpInst(Pred, Or->getOperand(0), Or->getOperand(1));
1784 }
1785
Craig Topper8ed1aa92017-10-03 05:31:07 +00001786 if (!Cmp.isEquality() || !C.isNullValue() || !Or->hasOneUse())
Sanjay Patela3f4f082016-08-16 17:54:36 +00001787 return nullptr;
1788
1789 Value *P, *Q;
Sanjay Patel943e92e2016-08-17 16:30:43 +00001790 if (match(Or, m_Or(m_PtrToInt(m_Value(P)), m_PtrToInt(m_Value(Q))))) {
Sanjay Patela3f4f082016-08-16 17:54:36 +00001791 // Simplify icmp eq (or (ptrtoint P), (ptrtoint Q)), 0
1792 // -> and (icmp eq P, null), (icmp eq Q, null).
Reid Klecknera871d382016-08-19 16:53:18 +00001793 Value *CmpP =
Craig Topperbb4069e2017-07-07 23:16:26 +00001794 Builder.CreateICmp(Pred, P, ConstantInt::getNullValue(P->getType()));
Reid Klecknera871d382016-08-19 16:53:18 +00001795 Value *CmpQ =
Craig Topperbb4069e2017-07-07 23:16:26 +00001796 Builder.CreateICmp(Pred, Q, ConstantInt::getNullValue(Q->getType()));
Sanjay Patel3f4db3e2017-07-14 15:09:49 +00001797 auto BOpc = Pred == CmpInst::ICMP_EQ ? Instruction::And : Instruction::Or;
1798 return BinaryOperator::Create(BOpc, CmpP, CmpQ);
1799 }
1800
1801 // Are we using xors to bitwise check for a pair of (in)equalities? Convert to
1802 // a shorter form that has more potential to be folded even further.
1803 Value *X1, *X2, *X3, *X4;
1804 if (match(Or->getOperand(0), m_OneUse(m_Xor(m_Value(X1), m_Value(X2)))) &&
1805 match(Or->getOperand(1), m_OneUse(m_Xor(m_Value(X3), m_Value(X4))))) {
1806 // ((X1 ^ X2) || (X3 ^ X4)) == 0 --> (X1 == X2) && (X3 == X4)
1807 // ((X1 ^ X2) || (X3 ^ X4)) != 0 --> (X1 != X2) || (X3 != X4)
1808 Value *Cmp12 = Builder.CreateICmp(Pred, X1, X2);
1809 Value *Cmp34 = Builder.CreateICmp(Pred, X3, X4);
1810 auto BOpc = Pred == CmpInst::ICMP_EQ ? Instruction::And : Instruction::Or;
1811 return BinaryOperator::Create(BOpc, Cmp12, Cmp34);
Sanjay Patela3f4f082016-08-16 17:54:36 +00001812 }
Sanjay Patel943e92e2016-08-17 16:30:43 +00001813
Sanjay Patela3f4f082016-08-16 17:54:36 +00001814 return nullptr;
1815}
1816
Sanjay Patel63478072016-08-18 15:44:44 +00001817/// Fold icmp (mul X, Y), C.
Sanjay Patelc9196c42016-08-22 21:24:29 +00001818Instruction *InstCombiner::foldICmpMulConstant(ICmpInst &Cmp,
1819 BinaryOperator *Mul,
Craig Topper8ed1aa92017-10-03 05:31:07 +00001820 const APInt &C) {
Sanjay Patel63478072016-08-18 15:44:44 +00001821 const APInt *MulC;
1822 if (!match(Mul->getOperand(1), m_APInt(MulC)))
Sanjay Patela3f4f082016-08-16 17:54:36 +00001823 return nullptr;
1824
Sanjay Patel63478072016-08-18 15:44:44 +00001825 // If this is a test of the sign bit and the multiply is sign-preserving with
1826 // a constant operand, use the multiply LHS operand instead.
1827 ICmpInst::Predicate Pred = Cmp.getPredicate();
Craig Topper8ed1aa92017-10-03 05:31:07 +00001828 if (isSignTest(Pred, C) && Mul->hasNoSignedWrap()) {
Sanjay Patel63478072016-08-18 15:44:44 +00001829 if (MulC->isNegative())
1830 Pred = ICmpInst::getSwappedPredicate(Pred);
1831 return new ICmpInst(Pred, Mul->getOperand(0),
1832 Constant::getNullValue(Mul->getType()));
1833 }
Sanjay Patela3f4f082016-08-16 17:54:36 +00001834
1835 return nullptr;
1836}
1837
Sanjay Patel98cd99d2016-08-18 21:28:30 +00001838/// Fold icmp (shl 1, Y), C.
1839static Instruction *foldICmpShlOne(ICmpInst &Cmp, Instruction *Shl,
Craig Topper8ed1aa92017-10-03 05:31:07 +00001840 const APInt &C) {
Sanjay Patel98cd99d2016-08-18 21:28:30 +00001841 Value *Y;
1842 if (!match(Shl, m_Shl(m_One(), m_Value(Y))))
1843 return nullptr;
1844
1845 Type *ShiftType = Shl->getType();
Craig Topper8ed1aa92017-10-03 05:31:07 +00001846 unsigned TypeBits = C.getBitWidth();
1847 bool CIsPowerOf2 = C.isPowerOf2();
Sanjay Patel98cd99d2016-08-18 21:28:30 +00001848 ICmpInst::Predicate Pred = Cmp.getPredicate();
1849 if (Cmp.isUnsigned()) {
1850 // (1 << Y) pred C -> Y pred Log2(C)
1851 if (!CIsPowerOf2) {
1852 // (1 << Y) < 30 -> Y <= 4
1853 // (1 << Y) <= 30 -> Y <= 4
1854 // (1 << Y) >= 30 -> Y > 4
1855 // (1 << Y) > 30 -> Y > 4
1856 if (Pred == ICmpInst::ICMP_ULT)
1857 Pred = ICmpInst::ICMP_ULE;
1858 else if (Pred == ICmpInst::ICMP_UGE)
1859 Pred = ICmpInst::ICMP_UGT;
1860 }
1861
1862 // (1 << Y) >= 2147483648 -> Y >= 31 -> Y == 31
1863 // (1 << Y) < 2147483648 -> Y < 31 -> Y != 31
Craig Topper8ed1aa92017-10-03 05:31:07 +00001864 unsigned CLog2 = C.logBase2();
Sanjay Patel98cd99d2016-08-18 21:28:30 +00001865 if (CLog2 == TypeBits - 1) {
1866 if (Pred == ICmpInst::ICMP_UGE)
1867 Pred = ICmpInst::ICMP_EQ;
1868 else if (Pred == ICmpInst::ICMP_ULT)
1869 Pred = ICmpInst::ICMP_NE;
1870 }
1871 return new ICmpInst(Pred, Y, ConstantInt::get(ShiftType, CLog2));
1872 } else if (Cmp.isSigned()) {
1873 Constant *BitWidthMinusOne = ConstantInt::get(ShiftType, TypeBits - 1);
Craig Topper8ed1aa92017-10-03 05:31:07 +00001874 if (C.isAllOnesValue()) {
Sanjay Patel98cd99d2016-08-18 21:28:30 +00001875 // (1 << Y) <= -1 -> Y == 31
1876 if (Pred == ICmpInst::ICMP_SLE)
1877 return new ICmpInst(ICmpInst::ICMP_EQ, Y, BitWidthMinusOne);
1878
1879 // (1 << Y) > -1 -> Y != 31
1880 if (Pred == ICmpInst::ICMP_SGT)
1881 return new ICmpInst(ICmpInst::ICMP_NE, Y, BitWidthMinusOne);
Craig Topper8ed1aa92017-10-03 05:31:07 +00001882 } else if (!C) {
Sanjay Patel98cd99d2016-08-18 21:28:30 +00001883 // (1 << Y) < 0 -> Y == 31
1884 // (1 << Y) <= 0 -> Y == 31
1885 if (Pred == ICmpInst::ICMP_SLT || Pred == ICmpInst::ICMP_SLE)
1886 return new ICmpInst(ICmpInst::ICMP_EQ, Y, BitWidthMinusOne);
1887
1888 // (1 << Y) >= 0 -> Y != 31
1889 // (1 << Y) > 0 -> Y != 31
1890 if (Pred == ICmpInst::ICMP_SGT || Pred == ICmpInst::ICMP_SGE)
1891 return new ICmpInst(ICmpInst::ICMP_NE, Y, BitWidthMinusOne);
1892 }
1893 } else if (Cmp.isEquality() && CIsPowerOf2) {
Craig Topper8ed1aa92017-10-03 05:31:07 +00001894 return new ICmpInst(Pred, Y, ConstantInt::get(ShiftType, C.logBase2()));
Sanjay Patel98cd99d2016-08-18 21:28:30 +00001895 }
1896
1897 return nullptr;
1898}
1899
Sanjay Patel38b75062016-08-19 17:20:37 +00001900/// Fold icmp (shl X, Y), C.
Sanjay Patelc9196c42016-08-22 21:24:29 +00001901Instruction *InstCombiner::foldICmpShlConstant(ICmpInst &Cmp,
1902 BinaryOperator *Shl,
Craig Topper8ed1aa92017-10-03 05:31:07 +00001903 const APInt &C) {
Sanjay Patel8da42cc2016-09-15 22:26:31 +00001904 const APInt *ShiftVal;
1905 if (Cmp.isEquality() && match(Shl->getOperand(0), m_APInt(ShiftVal)))
Craig Topper8ed1aa92017-10-03 05:31:07 +00001906 return foldICmpShlConstConst(Cmp, Shl->getOperand(1), C, *ShiftVal);
Sanjay Patel8da42cc2016-09-15 22:26:31 +00001907
Sanjay Patelfa7de602016-08-19 22:33:26 +00001908 const APInt *ShiftAmt;
1909 if (!match(Shl->getOperand(1), m_APInt(ShiftAmt)))
Sanjay Patel38b75062016-08-19 17:20:37 +00001910 return foldICmpShlOne(Cmp, Shl, C);
Sanjay Patela867afe2016-08-19 16:12:16 +00001911
Sanjay Patel38b75062016-08-19 17:20:37 +00001912 // Check that the shift amount is in range. If not, don't perform undefined
Sanjay Patel940c0612017-01-09 16:27:56 +00001913 // shifts. When the shift is visited, it will be simplified.
Craig Topper8ed1aa92017-10-03 05:31:07 +00001914 unsigned TypeBits = C.getBitWidth();
Sanjay Patelfa7de602016-08-19 22:33:26 +00001915 if (ShiftAmt->uge(TypeBits))
Sanjay Patela3f4f082016-08-16 17:54:36 +00001916 return nullptr;
1917
Sanjay Patele38e79c2016-08-19 17:34:05 +00001918 ICmpInst::Predicate Pred = Cmp.getPredicate();
1919 Value *X = Shl->getOperand(0);
Sanjay Patel14715b32017-01-17 21:25:16 +00001920 Type *ShType = Shl->getType();
1921
Sanjay Patel291c3d82017-01-19 16:12:10 +00001922 // NSW guarantees that we are only shifting out sign bits from the high bits,
1923 // so we can ASHR the compare constant without needing a mask and eliminate
1924 // the shift.
1925 if (Shl->hasNoSignedWrap()) {
1926 if (Pred == ICmpInst::ICMP_SGT) {
1927 // icmp Pred (shl nsw X, ShiftAmt), C --> icmp Pred X, (C >>s ShiftAmt)
Craig Topper8ed1aa92017-10-03 05:31:07 +00001928 APInt ShiftedC = C.ashr(*ShiftAmt);
Sanjay Patel291c3d82017-01-19 16:12:10 +00001929 return new ICmpInst(Pred, X, ConstantInt::get(ShType, ShiftedC));
1930 }
Sanjay Patel6fb13572018-01-09 18:56:03 +00001931 if ((Pred == ICmpInst::ICMP_EQ || Pred == ICmpInst::ICMP_NE) &&
1932 C.ashr(*ShiftAmt).shl(*ShiftAmt) == C) {
Craig Topper8ed1aa92017-10-03 05:31:07 +00001933 APInt ShiftedC = C.ashr(*ShiftAmt);
Sanjay Patel291c3d82017-01-19 16:12:10 +00001934 return new ICmpInst(Pred, X, ConstantInt::get(ShType, ShiftedC));
1935 }
1936 if (Pred == ICmpInst::ICMP_SLT) {
1937 // SLE is the same as above, but SLE is canonicalized to SLT, so convert:
1938 // (X << S) <=s C is equiv to X <=s (C >> S) for all C
1939 // (X << S) <s (C + 1) is equiv to X <s (C >> S) + 1 if C <s SMAX
1940 // (X << S) <s C is equiv to X <s ((C - 1) >> S) + 1 if C >s SMIN
Craig Topper8ed1aa92017-10-03 05:31:07 +00001941 assert(!C.isMinSignedValue() && "Unexpected icmp slt");
1942 APInt ShiftedC = (C - 1).ashr(*ShiftAmt) + 1;
Sanjay Patel291c3d82017-01-19 16:12:10 +00001943 return new ICmpInst(Pred, X, ConstantInt::get(ShType, ShiftedC));
1944 }
1945 // If this is a signed comparison to 0 and the shift is sign preserving,
1946 // use the shift LHS operand instead; isSignTest may change 'Pred', so only
1947 // do that if we're sure to not continue on in this function.
Craig Topper8ed1aa92017-10-03 05:31:07 +00001948 if (isSignTest(Pred, C))
Sanjay Patel291c3d82017-01-19 16:12:10 +00001949 return new ICmpInst(Pred, X, Constant::getNullValue(ShType));
1950 }
Sanjay Patel14715b32017-01-17 21:25:16 +00001951
Sanjay Patel291c3d82017-01-19 16:12:10 +00001952 // NUW guarantees that we are only shifting out zero bits from the high bits,
1953 // so we can LSHR the compare constant without needing a mask and eliminate
1954 // the shift.
Sanjay Patel14715b32017-01-17 21:25:16 +00001955 if (Shl->hasNoUnsignedWrap()) {
Sanjay Patelae23d652017-01-18 21:16:12 +00001956 if (Pred == ICmpInst::ICMP_UGT) {
Sanjay Patel14715b32017-01-17 21:25:16 +00001957 // icmp Pred (shl nuw X, ShiftAmt), C --> icmp Pred X, (C >>u ShiftAmt)
Craig Topper8ed1aa92017-10-03 05:31:07 +00001958 APInt ShiftedC = C.lshr(*ShiftAmt);
Sanjay Patel14715b32017-01-17 21:25:16 +00001959 return new ICmpInst(Pred, X, ConstantInt::get(ShType, ShiftedC));
1960 }
Sanjay Patel6fb13572018-01-09 18:56:03 +00001961 if ((Pred == ICmpInst::ICMP_EQ || Pred == ICmpInst::ICMP_NE) &&
1962 C.lshr(*ShiftAmt).shl(*ShiftAmt) == C) {
Craig Topper8ed1aa92017-10-03 05:31:07 +00001963 APInt ShiftedC = C.lshr(*ShiftAmt);
Sanjay Patelae23d652017-01-18 21:16:12 +00001964 return new ICmpInst(Pred, X, ConstantInt::get(ShType, ShiftedC));
1965 }
Sanjay Patel14715b32017-01-17 21:25:16 +00001966 if (Pred == ICmpInst::ICMP_ULT) {
1967 // ULE is the same as above, but ULE is canonicalized to ULT, so convert:
1968 // (X << S) <=u C is equiv to X <=u (C >> S) for all C
1969 // (X << S) <u (C + 1) is equiv to X <u (C >> S) + 1 if C <u ~0u
1970 // (X << S) <u C is equiv to X <u ((C - 1) >> S) + 1 if C >u 0
Craig Topper8ed1aa92017-10-03 05:31:07 +00001971 assert(C.ugt(0) && "ult 0 should have been eliminated");
1972 APInt ShiftedC = (C - 1).lshr(*ShiftAmt) + 1;
Sanjay Patel14715b32017-01-17 21:25:16 +00001973 return new ICmpInst(Pred, X, ConstantInt::get(ShType, ShiftedC));
1974 }
1975 }
1976
Sanjay Patel291c3d82017-01-19 16:12:10 +00001977 if (Cmp.isEquality() && Shl->hasOneUse()) {
1978 // Strength-reduce the shift into an 'and'.
1979 Constant *Mask = ConstantInt::get(
1980 ShType,
1981 APInt::getLowBitsSet(TypeBits, TypeBits - ShiftAmt->getZExtValue()));
Craig Topperbb4069e2017-07-07 23:16:26 +00001982 Value *And = Builder.CreateAnd(X, Mask, Shl->getName() + ".mask");
Craig Topper8ed1aa92017-10-03 05:31:07 +00001983 Constant *LShrC = ConstantInt::get(ShType, C.lshr(*ShiftAmt));
Sanjay Patel291c3d82017-01-19 16:12:10 +00001984 return new ICmpInst(Pred, And, LShrC);
Sanjay Patela3f4f082016-08-16 17:54:36 +00001985 }
1986
Sanjay Patela3f4f082016-08-16 17:54:36 +00001987 // Otherwise, if this is a comparison of the sign bit, simplify to and/test.
1988 bool TrueIfSigned = false;
Craig Topper8ed1aa92017-10-03 05:31:07 +00001989 if (Shl->hasOneUse() && isSignBitCheck(Pred, C, TrueIfSigned)) {
Sanjay Patel7ffcde72016-08-21 16:35:34 +00001990 // (X << 31) <s 0 --> (X & 1) != 0
Sanjay Patela3f4f082016-08-16 17:54:36 +00001991 Constant *Mask = ConstantInt::get(
Sanjay Patel14715b32017-01-17 21:25:16 +00001992 ShType,
Sanjay Patelfa7de602016-08-19 22:33:26 +00001993 APInt::getOneBitSet(TypeBits, TypeBits - ShiftAmt->getZExtValue() - 1));
Craig Topperbb4069e2017-07-07 23:16:26 +00001994 Value *And = Builder.CreateAnd(X, Mask, Shl->getName() + ".mask");
Sanjay Patela3f4f082016-08-16 17:54:36 +00001995 return new ICmpInst(TrueIfSigned ? ICmpInst::ICMP_NE : ICmpInst::ICMP_EQ,
Sanjay Patel14715b32017-01-17 21:25:16 +00001996 And, Constant::getNullValue(ShType));
Sanjay Patelc0339c72016-11-01 19:19:29 +00001997 }
1998
Sanjay Patel643d21a2016-08-21 17:10:07 +00001999 // Transform (icmp pred iM (shl iM %v, N), C)
2000 // -> (icmp pred i(M-N) (trunc %v iM to i(M-N)), (trunc (C>>N))
2001 // Transform the shl to a trunc if (trunc (C>>N)) has no loss and M-N.
Sanjay Patel940c0612017-01-09 16:27:56 +00002002 // This enables us to get rid of the shift in favor of a trunc that may be
Sanjay Patela3f4f082016-08-16 17:54:36 +00002003 // free on the target. It has the additional benefit of comparing to a
Sanjay Patel940c0612017-01-09 16:27:56 +00002004 // smaller constant that may be more target-friendly.
Sanjay Patelfa7de602016-08-19 22:33:26 +00002005 unsigned Amt = ShiftAmt->getLimitedValue(TypeBits - 1);
Craig Topper8ed1aa92017-10-03 05:31:07 +00002006 if (Shl->hasOneUse() && Amt != 0 && C.countTrailingZeros() >= Amt &&
Sanjay Patelf3dda132016-10-25 20:11:47 +00002007 DL.isLegalInteger(TypeBits - Amt)) {
Sanjay Patel643d21a2016-08-21 17:10:07 +00002008 Type *TruncTy = IntegerType::get(Cmp.getContext(), TypeBits - Amt);
Sanjay Patel14715b32017-01-17 21:25:16 +00002009 if (ShType->isVectorTy())
2010 TruncTy = VectorType::get(TruncTy, ShType->getVectorNumElements());
Sanjay Patel643d21a2016-08-21 17:10:07 +00002011 Constant *NewC =
Craig Topper8ed1aa92017-10-03 05:31:07 +00002012 ConstantInt::get(TruncTy, C.ashr(*ShiftAmt).trunc(TypeBits - Amt));
Craig Topperbb4069e2017-07-07 23:16:26 +00002013 return new ICmpInst(Pred, Builder.CreateTrunc(X, TruncTy), NewC);
Sanjay Patela3f4f082016-08-16 17:54:36 +00002014 }
2015
2016 return nullptr;
2017}
2018
Sanjay Patela3920492016-08-22 20:45:06 +00002019/// Fold icmp ({al}shr X, Y), C.
Sanjay Patelc9196c42016-08-22 21:24:29 +00002020Instruction *InstCombiner::foldICmpShrConstant(ICmpInst &Cmp,
2021 BinaryOperator *Shr,
Craig Topper8ed1aa92017-10-03 05:31:07 +00002022 const APInt &C) {
Sanjay Patela3920492016-08-22 20:45:06 +00002023 // An exact shr only shifts out zero bits, so:
2024 // icmp eq/ne (shr X, Y), 0 --> icmp eq/ne X, 0
Sanjay Pateld64e9882016-08-23 22:05:55 +00002025 Value *X = Shr->getOperand(0);
Sanjay Patelc9196c42016-08-22 21:24:29 +00002026 CmpInst::Predicate Pred = Cmp.getPredicate();
Craig Topper73ba1c82017-06-07 07:40:37 +00002027 if (Cmp.isEquality() && Shr->isExact() && Shr->hasOneUse() &&
Craig Topper8ed1aa92017-10-03 05:31:07 +00002028 C.isNullValue())
Sanjay Pateld64e9882016-08-23 22:05:55 +00002029 return new ICmpInst(Pred, X, Cmp.getOperand(1));
Sanjay Patela3920492016-08-22 20:45:06 +00002030
Sanjay Patel8da42cc2016-09-15 22:26:31 +00002031 const APInt *ShiftVal;
2032 if (Cmp.isEquality() && match(Shr->getOperand(0), m_APInt(ShiftVal)))
Craig Topper8ed1aa92017-10-03 05:31:07 +00002033 return foldICmpShrConstConst(Cmp, Shr->getOperand(1), C, *ShiftVal);
Sanjay Patel8da42cc2016-09-15 22:26:31 +00002034
Sanjay Pateld398d4a2016-08-24 22:22:06 +00002035 const APInt *ShiftAmt;
2036 if (!match(Shr->getOperand(1), m_APInt(ShiftAmt)))
Sanjay Patela3f4f082016-08-16 17:54:36 +00002037 return nullptr;
2038
Sanjay Pateld398d4a2016-08-24 22:22:06 +00002039 // Check that the shift amount is in range. If not, don't perform undefined
2040 // shifts. When the shift is visited it will be simplified.
Craig Topper8ed1aa92017-10-03 05:31:07 +00002041 unsigned TypeBits = C.getBitWidth();
Sanjay Pateld398d4a2016-08-24 22:22:06 +00002042 unsigned ShAmtVal = ShiftAmt->getLimitedValue(TypeBits);
Sanjay Pateldcac0df2016-08-23 21:25:13 +00002043 if (ShAmtVal >= TypeBits || ShAmtVal == 0)
2044 return nullptr;
2045
Sanjay Pateld64e9882016-08-23 22:05:55 +00002046 bool IsAShr = Shr->getOpcode() == Instruction::AShr;
Sanjay Patel7ac2db62017-10-05 21:11:49 +00002047 bool IsExact = Shr->isExact();
2048 Type *ShrTy = Shr->getType();
2049 // TODO: If we could guarantee that InstSimplify would handle all of the
2050 // constant-value-based preconditions in the folds below, then we could assert
2051 // those conditions rather than checking them. This is difficult because of
2052 // undef/poison (PR34838).
2053 if (IsAShr) {
2054 if (Pred == CmpInst::ICMP_SLT || (Pred == CmpInst::ICMP_SGT && IsExact)) {
2055 // icmp slt (ashr X, ShAmtC), C --> icmp slt X, (C << ShAmtC)
2056 // icmp sgt (ashr exact X, ShAmtC), C --> icmp sgt X, (C << ShAmtC)
2057 APInt ShiftedC = C.shl(ShAmtVal);
2058 if (ShiftedC.ashr(ShAmtVal) == C)
2059 return new ICmpInst(Pred, X, ConstantInt::get(ShrTy, ShiftedC));
2060 }
2061 if (Pred == CmpInst::ICMP_SGT) {
2062 // icmp sgt (ashr X, ShAmtC), C --> icmp sgt X, ((C + 1) << ShAmtC) - 1
2063 APInt ShiftedC = (C + 1).shl(ShAmtVal) - 1;
2064 if (!C.isMaxSignedValue() && !(C + 1).shl(ShAmtVal).isMinSignedValue() &&
2065 (ShiftedC + 1).ashr(ShAmtVal) == (C + 1))
2066 return new ICmpInst(Pred, X, ConstantInt::get(ShrTy, ShiftedC));
2067 }
2068 } else {
2069 if (Pred == CmpInst::ICMP_ULT || (Pred == CmpInst::ICMP_UGT && IsExact)) {
2070 // icmp ult (lshr X, ShAmtC), C --> icmp ult X, (C << ShAmtC)
2071 // icmp ugt (lshr exact X, ShAmtC), C --> icmp ugt X, (C << ShAmtC)
2072 APInt ShiftedC = C.shl(ShAmtVal);
2073 if (ShiftedC.lshr(ShAmtVal) == C)
2074 return new ICmpInst(Pred, X, ConstantInt::get(ShrTy, ShiftedC));
2075 }
2076 if (Pred == CmpInst::ICMP_UGT) {
2077 // icmp ugt (lshr X, ShAmtC), C --> icmp ugt X, ((C + 1) << ShAmtC) - 1
2078 APInt ShiftedC = (C + 1).shl(ShAmtVal) - 1;
2079 if ((ShiftedC + 1).lshr(ShAmtVal) == (C + 1))
2080 return new ICmpInst(Pred, X, ConstantInt::get(ShrTy, ShiftedC));
2081 }
Sanjay Pateldcac0df2016-08-23 21:25:13 +00002082 }
2083
Sanjay Patel7ac2db62017-10-05 21:11:49 +00002084 if (!Cmp.isEquality())
2085 return nullptr;
2086
Sanjay Pateld398d4a2016-08-24 22:22:06 +00002087 // Handle equality comparisons of shift-by-constant.
2088
Sanjay Patel8e297742016-08-24 13:55:55 +00002089 // If the comparison constant changes with the shift, the comparison cannot
2090 // succeed (bits of the comparison constant cannot match the shifted value).
2091 // This should be known by InstSimplify and already be folded to true/false.
Craig Topper8ed1aa92017-10-03 05:31:07 +00002092 assert(((IsAShr && C.shl(ShAmtVal).ashr(ShAmtVal) == C) ||
2093 (!IsAShr && C.shl(ShAmtVal).lshr(ShAmtVal) == C)) &&
Sanjay Patel8e297742016-08-24 13:55:55 +00002094 "Expected icmp+shr simplify did not occur.");
2095
Sanjay Patel934738a2017-10-15 15:39:15 +00002096 // If the bits shifted out are known zero, compare the unshifted value:
Sanjay Pateldcac0df2016-08-23 21:25:13 +00002097 // (X & 4) >> 1 == 2 --> (X & 4) == 4.
Sanjay Patel934738a2017-10-15 15:39:15 +00002098 if (Shr->isExact())
Sanjay Patel42135be2017-10-16 14:47:24 +00002099 return new ICmpInst(Pred, X, ConstantInt::get(ShrTy, C << ShAmtVal));
Sanjay Patelf11b5b42017-10-05 14:26:15 +00002100
Sanjay Patel934738a2017-10-15 15:39:15 +00002101 if (Shr->hasOneUse()) {
2102 // Canonicalize the shift into an 'and':
2103 // icmp eq/ne (shr X, ShAmt), C --> icmp eq/ne (and X, HiMask), (C << ShAmt)
Sanjay Pateld398d4a2016-08-24 22:22:06 +00002104 APInt Val(APInt::getHighBitsSet(TypeBits, TypeBits - ShAmtVal));
Sanjay Patel7ac2db62017-10-05 21:11:49 +00002105 Constant *Mask = ConstantInt::get(ShrTy, Val);
Craig Topperbb4069e2017-07-07 23:16:26 +00002106 Value *And = Builder.CreateAnd(X, Mask, Shr->getName() + ".mask");
Sanjay Patel42135be2017-10-16 14:47:24 +00002107 return new ICmpInst(Pred, And, ConstantInt::get(ShrTy, C << ShAmtVal));
Sanjay Pateldcac0df2016-08-23 21:25:13 +00002108 }
Sanjay Patela3f4f082016-08-16 17:54:36 +00002109
2110 return nullptr;
2111}
2112
Sanjay Patel12a41052016-08-18 17:37:26 +00002113/// Fold icmp (udiv X, Y), C.
2114Instruction *InstCombiner::foldICmpUDivConstant(ICmpInst &Cmp,
Sanjay Patelc9196c42016-08-22 21:24:29 +00002115 BinaryOperator *UDiv,
Craig Topper8ed1aa92017-10-03 05:31:07 +00002116 const APInt &C) {
Sanjay Patelfa5ca2b2016-08-18 17:55:59 +00002117 const APInt *C2;
2118 if (!match(UDiv->getOperand(0), m_APInt(C2)))
2119 return nullptr;
2120
Craig Topper29c282e2017-06-07 07:40:29 +00002121 assert(*C2 != 0 && "udiv 0, X should have been simplified already.");
Sanjay Patelfa5ca2b2016-08-18 17:55:59 +00002122
2123 // (icmp ugt (udiv C2, Y), C) -> (icmp ule Y, C2/(C+1))
2124 Value *Y = UDiv->getOperand(1);
2125 if (Cmp.getPredicate() == ICmpInst::ICMP_UGT) {
Craig Topper8ed1aa92017-10-03 05:31:07 +00002126 assert(!C.isMaxValue() &&
Sanjay Patelfa5ca2b2016-08-18 17:55:59 +00002127 "icmp ugt X, UINT_MAX should have been simplified already.");
2128 return new ICmpInst(ICmpInst::ICMP_ULE, Y,
Craig Topper8ed1aa92017-10-03 05:31:07 +00002129 ConstantInt::get(Y->getType(), C2->udiv(C + 1)));
Sanjay Patelfa5ca2b2016-08-18 17:55:59 +00002130 }
2131
2132 // (icmp ult (udiv C2, Y), C) -> (icmp ugt Y, C2/C)
2133 if (Cmp.getPredicate() == ICmpInst::ICMP_ULT) {
Craig Topper8ed1aa92017-10-03 05:31:07 +00002134 assert(C != 0 && "icmp ult X, 0 should have been simplified already.");
Sanjay Patelfa5ca2b2016-08-18 17:55:59 +00002135 return new ICmpInst(ICmpInst::ICMP_UGT, Y,
Craig Topper8ed1aa92017-10-03 05:31:07 +00002136 ConstantInt::get(Y->getType(), C2->udiv(C)));
Sanjay Patela3f4f082016-08-16 17:54:36 +00002137 }
2138
2139 return nullptr;
2140}
2141
Sanjay Patelf7ba0892016-08-26 15:53:01 +00002142/// Fold icmp ({su}div X, Y), C.
2143Instruction *InstCombiner::foldICmpDivConstant(ICmpInst &Cmp,
2144 BinaryOperator *Div,
Craig Topper8ed1aa92017-10-03 05:31:07 +00002145 const APInt &C) {
Sanjay Patela7cb4772016-08-30 17:10:49 +00002146 // Fold: icmp pred ([us]div X, C2), C -> range test
Sanjay Patela3f4f082016-08-16 17:54:36 +00002147 // Fold this div into the comparison, producing a range check.
2148 // Determine, based on the divide type, what the range is being
2149 // checked. If there is an overflow on the low or high side, remember
2150 // it, otherwise compute the range [low, hi) bounding the new value.
2151 // See: InsertRangeTest above for the kinds of replacements possible.
Sanjay Patela7cb4772016-08-30 17:10:49 +00002152 const APInt *C2;
2153 if (!match(Div->getOperand(1), m_APInt(C2)))
Sanjay Patel16554142016-08-24 23:03:36 +00002154 return nullptr;
2155
Sanjay Patel16554142016-08-24 23:03:36 +00002156 // FIXME: If the operand types don't match the type of the divide
2157 // then don't attempt this transform. The code below doesn't have the
2158 // logic to deal with a signed divide and an unsigned compare (and
Sanjay Patela7cb4772016-08-30 17:10:49 +00002159 // vice versa). This is because (x /s C2) <s C produces different
2160 // results than (x /s C2) <u C or (x /u C2) <s C or even
2161 // (x /u C2) <u C. Simply casting the operands and result won't
Sanjay Patel16554142016-08-24 23:03:36 +00002162 // work. :( The if statement below tests that condition and bails
2163 // if it finds it.
Sanjay Patelf7ba0892016-08-26 15:53:01 +00002164 bool DivIsSigned = Div->getOpcode() == Instruction::SDiv;
2165 if (!Cmp.isEquality() && DivIsSigned != Cmp.isSigned())
Sanjay Patel16554142016-08-24 23:03:36 +00002166 return nullptr;
Sanjay Patela7cb4772016-08-30 17:10:49 +00002167
Sanjay Pateleea2ef72016-09-05 23:38:22 +00002168 // The ProdOV computation fails on divide by 0 and divide by -1. Cases with
2169 // INT_MIN will also fail if the divisor is 1. Although folds of all these
2170 // division-by-constant cases should be present, we can not assert that they
2171 // have happened before we reach this icmp instruction.
Craig Topper73ba1c82017-06-07 07:40:37 +00002172 if (C2->isNullValue() || C2->isOneValue() ||
2173 (DivIsSigned && C2->isAllOnesValue()))
Sanjay Pateleea2ef72016-09-05 23:38:22 +00002174 return nullptr;
Sanjay Patelb3714572016-08-30 17:31:34 +00002175
Craig Topper6e025a32017-10-01 23:53:54 +00002176 // Compute Prod = C * C2. We are essentially solving an equation of
2177 // form X / C2 = C. We solve for X by multiplying C2 and C.
Sanjay Patel541aef42016-08-31 21:57:21 +00002178 // By solving for X, we can turn this into a range check instead of computing
2179 // a divide.
Craig Topper8ed1aa92017-10-03 05:31:07 +00002180 APInt Prod = C * *C2;
Sanjay Patel16554142016-08-24 23:03:36 +00002181
Sanjay Patel541aef42016-08-31 21:57:21 +00002182 // Determine if the product overflows by seeing if the product is not equal to
2183 // the divide. Make sure we do the same kind of divide as in the LHS
2184 // instruction that we're folding.
Craig Topper8ed1aa92017-10-03 05:31:07 +00002185 bool ProdOV = (DivIsSigned ? Prod.sdiv(*C2) : Prod.udiv(*C2)) != C;
Sanjay Patel16554142016-08-24 23:03:36 +00002186
Sanjay Patelf7ba0892016-08-26 15:53:01 +00002187 ICmpInst::Predicate Pred = Cmp.getPredicate();
Sanjay Patel16554142016-08-24 23:03:36 +00002188
2189 // If the division is known to be exact, then there is no remainder from the
2190 // divide, so the covered range size is unit, otherwise it is the divisor.
Craig Topper6e025a32017-10-01 23:53:54 +00002191 APInt RangeSize = Div->isExact() ? APInt(C2->getBitWidth(), 1) : *C2;
Sanjay Patel16554142016-08-24 23:03:36 +00002192
2193 // Figure out the interval that is being checked. For example, a comparison
2194 // like "X /u 5 == 0" is really checking that X is in the interval [0, 5).
2195 // Compute this interval based on the constants involved and the signedness of
2196 // the compare/divide. This computes a half-open interval, keeping track of
2197 // whether either value in the interval overflows. After analysis each
2198 // overflow variable is set to 0 if it's corresponding bound variable is valid
2199 // -1 if overflowed off the bottom end, or +1 if overflowed off the top end.
2200 int LoOverflow = 0, HiOverflow = 0;
Craig Topper6e025a32017-10-01 23:53:54 +00002201 APInt LoBound, HiBound;
Sanjay Patel16554142016-08-24 23:03:36 +00002202
2203 if (!DivIsSigned) { // udiv
2204 // e.g. X/5 op 3 --> [15, 20)
2205 LoBound = Prod;
2206 HiOverflow = LoOverflow = ProdOV;
2207 if (!HiOverflow) {
2208 // If this is not an exact divide, then many values in the range collapse
2209 // to the same result value.
Sanjay Pateld93c4c02016-09-15 18:22:25 +00002210 HiOverflow = addWithOverflow(HiBound, LoBound, RangeSize, false);
Sanjay Patel16554142016-08-24 23:03:36 +00002211 }
Sanjay Patel541aef42016-08-31 21:57:21 +00002212 } else if (C2->isStrictlyPositive()) { // Divisor is > 0.
Craig Topper8ed1aa92017-10-03 05:31:07 +00002213 if (C.isNullValue()) { // (X / pos) op 0
Sanjay Patel16554142016-08-24 23:03:36 +00002214 // Can't overflow. e.g. X/2 op 0 --> [-1, 2)
Craig Topper6e025a32017-10-01 23:53:54 +00002215 LoBound = -(RangeSize - 1);
Sanjay Patel16554142016-08-24 23:03:36 +00002216 HiBound = RangeSize;
Craig Topper8ed1aa92017-10-03 05:31:07 +00002217 } else if (C.isStrictlyPositive()) { // (X / pos) op pos
Sanjay Patel16554142016-08-24 23:03:36 +00002218 LoBound = Prod; // e.g. X/5 op 3 --> [15, 20)
2219 HiOverflow = LoOverflow = ProdOV;
2220 if (!HiOverflow)
Sanjay Pateld93c4c02016-09-15 18:22:25 +00002221 HiOverflow = addWithOverflow(HiBound, Prod, RangeSize, true);
Sanjay Patel16554142016-08-24 23:03:36 +00002222 } else { // (X / pos) op neg
2223 // e.g. X/5 op -3 --> [-15-4, -15+1) --> [-19, -14)
Craig Topper6e025a32017-10-01 23:53:54 +00002224 HiBound = Prod + 1;
Sanjay Patel16554142016-08-24 23:03:36 +00002225 LoOverflow = HiOverflow = ProdOV ? -1 : 0;
2226 if (!LoOverflow) {
Craig Topper6e025a32017-10-01 23:53:54 +00002227 APInt DivNeg = -RangeSize;
Sanjay Pateld93c4c02016-09-15 18:22:25 +00002228 LoOverflow = addWithOverflow(LoBound, HiBound, DivNeg, true) ? -1 : 0;
Sanjay Patel16554142016-08-24 23:03:36 +00002229 }
2230 }
Sanjay Patel541aef42016-08-31 21:57:21 +00002231 } else if (C2->isNegative()) { // Divisor is < 0.
Sanjay Patelf7ba0892016-08-26 15:53:01 +00002232 if (Div->isExact())
Craig Topper6e025a32017-10-01 23:53:54 +00002233 RangeSize.negate();
Craig Topper8ed1aa92017-10-03 05:31:07 +00002234 if (C.isNullValue()) { // (X / neg) op 0
Sanjay Patel16554142016-08-24 23:03:36 +00002235 // e.g. X/-5 op 0 --> [-4, 5)
Craig Topper6e025a32017-10-01 23:53:54 +00002236 LoBound = RangeSize + 1;
2237 HiBound = -RangeSize;
2238 if (HiBound == *C2) { // -INTMIN = INTMIN
Sanjay Patel16554142016-08-24 23:03:36 +00002239 HiOverflow = 1; // [INTMIN+1, overflow)
Craig Topper6e025a32017-10-01 23:53:54 +00002240 HiBound = APInt(); // e.g. X/INTMIN = 0 --> X > INTMIN
Sanjay Patel16554142016-08-24 23:03:36 +00002241 }
Craig Topper8ed1aa92017-10-03 05:31:07 +00002242 } else if (C.isStrictlyPositive()) { // (X / neg) op pos
Sanjay Patel16554142016-08-24 23:03:36 +00002243 // e.g. X/-5 op 3 --> [-19, -14)
Craig Topper6e025a32017-10-01 23:53:54 +00002244 HiBound = Prod + 1;
Sanjay Patel16554142016-08-24 23:03:36 +00002245 HiOverflow = LoOverflow = ProdOV ? -1 : 0;
2246 if (!LoOverflow)
Sanjay Pateld93c4c02016-09-15 18:22:25 +00002247 LoOverflow = addWithOverflow(LoBound, HiBound, RangeSize, true) ? -1:0;
Sanjay Patel16554142016-08-24 23:03:36 +00002248 } else { // (X / neg) op neg
2249 LoBound = Prod; // e.g. X/-5 op -3 --> [15, 20)
2250 LoOverflow = HiOverflow = ProdOV;
2251 if (!HiOverflow)
Sanjay Pateld93c4c02016-09-15 18:22:25 +00002252 HiOverflow = subWithOverflow(HiBound, Prod, RangeSize, true);
Sanjay Patel16554142016-08-24 23:03:36 +00002253 }
2254
2255 // Dividing by a negative swaps the condition. LT <-> GT
2256 Pred = ICmpInst::getSwappedPredicate(Pred);
2257 }
2258
Sanjay Patelf7ba0892016-08-26 15:53:01 +00002259 Value *X = Div->getOperand(0);
Sanjay Patel16554142016-08-24 23:03:36 +00002260 switch (Pred) {
2261 default: llvm_unreachable("Unhandled icmp opcode!");
2262 case ICmpInst::ICMP_EQ:
2263 if (LoOverflow && HiOverflow)
Craig Topperbb4069e2017-07-07 23:16:26 +00002264 return replaceInstUsesWith(Cmp, Builder.getFalse());
Sanjay Patel16554142016-08-24 23:03:36 +00002265 if (HiOverflow)
2266 return new ICmpInst(DivIsSigned ? ICmpInst::ICMP_SGE :
Craig Topper6e025a32017-10-01 23:53:54 +00002267 ICmpInst::ICMP_UGE, X,
2268 ConstantInt::get(Div->getType(), LoBound));
Sanjay Patel16554142016-08-24 23:03:36 +00002269 if (LoOverflow)
2270 return new ICmpInst(DivIsSigned ? ICmpInst::ICMP_SLT :
Craig Topper6e025a32017-10-01 23:53:54 +00002271 ICmpInst::ICMP_ULT, X,
2272 ConstantInt::get(Div->getType(), HiBound));
Sanjay Patel85d79742016-08-31 19:49:56 +00002273 return replaceInstUsesWith(
Craig Topper6e025a32017-10-01 23:53:54 +00002274 Cmp, insertRangeTest(X, LoBound, HiBound, DivIsSigned, true));
Sanjay Patel16554142016-08-24 23:03:36 +00002275 case ICmpInst::ICMP_NE:
2276 if (LoOverflow && HiOverflow)
Craig Topperbb4069e2017-07-07 23:16:26 +00002277 return replaceInstUsesWith(Cmp, Builder.getTrue());
Sanjay Patel16554142016-08-24 23:03:36 +00002278 if (HiOverflow)
2279 return new ICmpInst(DivIsSigned ? ICmpInst::ICMP_SLT :
Craig Topper6e025a32017-10-01 23:53:54 +00002280 ICmpInst::ICMP_ULT, X,
2281 ConstantInt::get(Div->getType(), LoBound));
Sanjay Patel16554142016-08-24 23:03:36 +00002282 if (LoOverflow)
2283 return new ICmpInst(DivIsSigned ? ICmpInst::ICMP_SGE :
Craig Topper6e025a32017-10-01 23:53:54 +00002284 ICmpInst::ICMP_UGE, X,
2285 ConstantInt::get(Div->getType(), HiBound));
Sanjay Patel541aef42016-08-31 21:57:21 +00002286 return replaceInstUsesWith(Cmp,
Craig Topper6e025a32017-10-01 23:53:54 +00002287 insertRangeTest(X, LoBound, HiBound,
Sanjay Patel541aef42016-08-31 21:57:21 +00002288 DivIsSigned, false));
Sanjay Patel16554142016-08-24 23:03:36 +00002289 case ICmpInst::ICMP_ULT:
2290 case ICmpInst::ICMP_SLT:
2291 if (LoOverflow == +1) // Low bound is greater than input range.
Craig Topperbb4069e2017-07-07 23:16:26 +00002292 return replaceInstUsesWith(Cmp, Builder.getTrue());
Sanjay Patel16554142016-08-24 23:03:36 +00002293 if (LoOverflow == -1) // Low bound is less than input range.
Craig Topperbb4069e2017-07-07 23:16:26 +00002294 return replaceInstUsesWith(Cmp, Builder.getFalse());
Craig Topper6e025a32017-10-01 23:53:54 +00002295 return new ICmpInst(Pred, X, ConstantInt::get(Div->getType(), LoBound));
Sanjay Patel16554142016-08-24 23:03:36 +00002296 case ICmpInst::ICMP_UGT:
2297 case ICmpInst::ICMP_SGT:
2298 if (HiOverflow == +1) // High bound greater than input range.
Craig Topperbb4069e2017-07-07 23:16:26 +00002299 return replaceInstUsesWith(Cmp, Builder.getFalse());
Sanjay Patel16554142016-08-24 23:03:36 +00002300 if (HiOverflow == -1) // High bound less than input range.
Craig Topperbb4069e2017-07-07 23:16:26 +00002301 return replaceInstUsesWith(Cmp, Builder.getTrue());
Sanjay Patel16554142016-08-24 23:03:36 +00002302 if (Pred == ICmpInst::ICMP_UGT)
Craig Topper6e025a32017-10-01 23:53:54 +00002303 return new ICmpInst(ICmpInst::ICMP_UGE, X,
2304 ConstantInt::get(Div->getType(), HiBound));
2305 return new ICmpInst(ICmpInst::ICMP_SGE, X,
2306 ConstantInt::get(Div->getType(), HiBound));
Sanjay Patel16554142016-08-24 23:03:36 +00002307 }
Sanjay Patela3f4f082016-08-16 17:54:36 +00002308
2309 return nullptr;
2310}
2311
Sanjay Patelb9aa67b2016-08-16 21:26:10 +00002312/// Fold icmp (sub X, Y), C.
Sanjay Patelc9196c42016-08-22 21:24:29 +00002313Instruction *InstCombiner::foldICmpSubConstant(ICmpInst &Cmp,
2314 BinaryOperator *Sub,
Craig Topper8ed1aa92017-10-03 05:31:07 +00002315 const APInt &C) {
Sanjay Patel886a5422016-09-15 18:05:17 +00002316 Value *X = Sub->getOperand(0), *Y = Sub->getOperand(1);
2317 ICmpInst::Predicate Pred = Cmp.getPredicate();
2318
2319 // The following transforms are only worth it if the only user of the subtract
2320 // is the icmp.
2321 if (!Sub->hasOneUse())
Sanjay Patela3f4f082016-08-16 17:54:36 +00002322 return nullptr;
2323
Sanjay Patel886a5422016-09-15 18:05:17 +00002324 if (Sub->hasNoSignedWrap()) {
2325 // (icmp sgt (sub nsw X, Y), -1) -> (icmp sge X, Y)
Craig Topper8ed1aa92017-10-03 05:31:07 +00002326 if (Pred == ICmpInst::ICMP_SGT && C.isAllOnesValue())
Sanjay Patel886a5422016-09-15 18:05:17 +00002327 return new ICmpInst(ICmpInst::ICMP_SGE, X, Y);
Sanjay Patela3f4f082016-08-16 17:54:36 +00002328
Sanjay Patel886a5422016-09-15 18:05:17 +00002329 // (icmp sgt (sub nsw X, Y), 0) -> (icmp sgt X, Y)
Craig Topper8ed1aa92017-10-03 05:31:07 +00002330 if (Pred == ICmpInst::ICMP_SGT && C.isNullValue())
Sanjay Patel886a5422016-09-15 18:05:17 +00002331 return new ICmpInst(ICmpInst::ICMP_SGT, X, Y);
2332
2333 // (icmp slt (sub nsw X, Y), 0) -> (icmp slt X, Y)
Craig Topper8ed1aa92017-10-03 05:31:07 +00002334 if (Pred == ICmpInst::ICMP_SLT && C.isNullValue())
Sanjay Patel886a5422016-09-15 18:05:17 +00002335 return new ICmpInst(ICmpInst::ICMP_SLT, X, Y);
2336
2337 // (icmp slt (sub nsw X, Y), 1) -> (icmp sle X, Y)
Craig Topper8ed1aa92017-10-03 05:31:07 +00002338 if (Pred == ICmpInst::ICMP_SLT && C.isOneValue())
Sanjay Patel886a5422016-09-15 18:05:17 +00002339 return new ICmpInst(ICmpInst::ICMP_SLE, X, Y);
2340 }
2341
2342 const APInt *C2;
2343 if (!match(X, m_APInt(C2)))
2344 return nullptr;
2345
2346 // C2 - Y <u C -> (Y | (C - 1)) == C2
2347 // iff (C2 & (C - 1)) == C - 1 and C is a power of 2
Craig Topper8ed1aa92017-10-03 05:31:07 +00002348 if (Pred == ICmpInst::ICMP_ULT && C.isPowerOf2() &&
2349 (*C2 & (C - 1)) == (C - 1))
2350 return new ICmpInst(ICmpInst::ICMP_EQ, Builder.CreateOr(Y, C - 1), X);
Sanjay Patel886a5422016-09-15 18:05:17 +00002351
2352 // C2 - Y >u C -> (Y | C) != C2
2353 // iff C2 & C == C and C + 1 is a power of 2
Craig Topper8ed1aa92017-10-03 05:31:07 +00002354 if (Pred == ICmpInst::ICMP_UGT && (C + 1).isPowerOf2() && (*C2 & C) == C)
2355 return new ICmpInst(ICmpInst::ICMP_NE, Builder.CreateOr(Y, C), X);
Sanjay Patela3f4f082016-08-16 17:54:36 +00002356
2357 return nullptr;
2358}
2359
Sanjay Patel60ea1b42016-08-16 22:34:42 +00002360/// Fold icmp (add X, Y), C.
Sanjay Patelc9196c42016-08-22 21:24:29 +00002361Instruction *InstCombiner::foldICmpAddConstant(ICmpInst &Cmp,
2362 BinaryOperator *Add,
Craig Topper8ed1aa92017-10-03 05:31:07 +00002363 const APInt &C) {
Sanjay Patel4f7eb2a2016-08-17 15:24:30 +00002364 Value *Y = Add->getOperand(1);
2365 const APInt *C2;
2366 if (Cmp.isEquality() || !match(Y, m_APInt(C2)))
Sanjay Patela3f4f082016-08-16 17:54:36 +00002367 return nullptr;
2368
Sanjay Patel4f7eb2a2016-08-17 15:24:30 +00002369 // Fold icmp pred (add X, C2), C.
Sanjay Patel60ea1b42016-08-16 22:34:42 +00002370 Value *X = Add->getOperand(0);
Sanjay Patel4f7eb2a2016-08-17 15:24:30 +00002371 Type *Ty = Add->getType();
Sanjay Patel6dd2eae2017-02-08 16:19:36 +00002372 CmpInst::Predicate Pred = Cmp.getPredicate();
Sanjay Patel45b7e692017-02-12 16:40:30 +00002373
Tim Northover12c1f762018-09-10 14:26:44 +00002374 if (!Add->hasOneUse())
2375 return nullptr;
2376
Sanjay Patel45b7e692017-02-12 16:40:30 +00002377 // If the add does not wrap, we can always adjust the compare by subtracting
Nicola Zaghen9588ad92018-09-04 10:29:48 +00002378 // the constants. Equality comparisons are handled elsewhere. SGE/SLE/UGE/ULE
2379 // are canonicalized to SGT/SLT/UGT/ULT.
2380 if ((Add->hasNoSignedWrap() &&
2381 (Pred == ICmpInst::ICMP_SGT || Pred == ICmpInst::ICMP_SLT)) ||
2382 (Add->hasNoUnsignedWrap() &&
2383 (Pred == ICmpInst::ICMP_UGT || Pred == ICmpInst::ICMP_ULT))) {
Sanjay Patel45b7e692017-02-12 16:40:30 +00002384 bool Overflow;
Nicola Zaghen9588ad92018-09-04 10:29:48 +00002385 APInt NewC =
2386 Cmp.isSigned() ? C.ssub_ov(*C2, Overflow) : C.usub_ov(*C2, Overflow);
Sanjay Patel45b7e692017-02-12 16:40:30 +00002387 // If there is overflow, the result must be true or false.
2388 // TODO: Can we assert there is no overflow because InstSimplify always
2389 // handles those cases?
2390 if (!Overflow)
2391 // icmp Pred (add nsw X, C2), C --> icmp Pred X, (C - C2)
2392 return new ICmpInst(Pred, X, ConstantInt::get(Ty, NewC));
2393 }
2394
Craig Topper8ed1aa92017-10-03 05:31:07 +00002395 auto CR = ConstantRange::makeExactICmpRegion(Pred, C).subtract(*C2);
Sanjay Patel60ea1b42016-08-16 22:34:42 +00002396 const APInt &Upper = CR.getUpper();
2397 const APInt &Lower = CR.getLower();
2398 if (Cmp.isSigned()) {
Craig Topperbcfd2d12017-04-20 16:56:25 +00002399 if (Lower.isSignMask())
Sanjay Patel4f7eb2a2016-08-17 15:24:30 +00002400 return new ICmpInst(ICmpInst::ICMP_SLT, X, ConstantInt::get(Ty, Upper));
Craig Topperbcfd2d12017-04-20 16:56:25 +00002401 if (Upper.isSignMask())
Sanjay Patel4f7eb2a2016-08-17 15:24:30 +00002402 return new ICmpInst(ICmpInst::ICMP_SGE, X, ConstantInt::get(Ty, Lower));
Sanjay Patel60ea1b42016-08-16 22:34:42 +00002403 } else {
2404 if (Lower.isMinValue())
Sanjay Patel4f7eb2a2016-08-17 15:24:30 +00002405 return new ICmpInst(ICmpInst::ICMP_ULT, X, ConstantInt::get(Ty, Upper));
Sanjay Patel60ea1b42016-08-16 22:34:42 +00002406 if (Upper.isMinValue())
Sanjay Patel4f7eb2a2016-08-17 15:24:30 +00002407 return new ICmpInst(ICmpInst::ICMP_UGE, X, ConstantInt::get(Ty, Lower));
Sanjay Patel60ea1b42016-08-16 22:34:42 +00002408 }
Sanjay Patela3f4f082016-08-16 17:54:36 +00002409
Sanjay Patel4f7eb2a2016-08-17 15:24:30 +00002410 // X+C <u C2 -> (X & -C2) == C
2411 // iff C & (C2-1) == 0
2412 // C2 is a power of 2
Craig Topper8ed1aa92017-10-03 05:31:07 +00002413 if (Pred == ICmpInst::ICMP_ULT && C.isPowerOf2() && (*C2 & (C - 1)) == 0)
2414 return new ICmpInst(ICmpInst::ICMP_EQ, Builder.CreateAnd(X, -C),
Sanjay Patel4f7eb2a2016-08-17 15:24:30 +00002415 ConstantExpr::getNeg(cast<Constant>(Y)));
2416
2417 // X+C >u C2 -> (X & ~C2) != C
2418 // iff C & C2 == 0
2419 // C2+1 is a power of 2
Craig Topper8ed1aa92017-10-03 05:31:07 +00002420 if (Pred == ICmpInst::ICMP_UGT && (C + 1).isPowerOf2() && (*C2 & C) == 0)
2421 return new ICmpInst(ICmpInst::ICMP_NE, Builder.CreateAnd(X, ~C),
Sanjay Patel4f7eb2a2016-08-17 15:24:30 +00002422 ConstantExpr::getNeg(cast<Constant>(Y)));
2423
Sanjay Patela3f4f082016-08-16 17:54:36 +00002424 return nullptr;
2425}
2426
Anna Thomasd67165c2017-06-23 13:41:45 +00002427bool InstCombiner::matchThreeWayIntCompare(SelectInst *SI, Value *&LHS,
2428 Value *&RHS, ConstantInt *&Less,
2429 ConstantInt *&Equal,
2430 ConstantInt *&Greater) {
2431 // TODO: Generalize this to work with other comparison idioms or ensure
2432 // they get canonicalized into this form.
2433
2434 // select i1 (a == b), i32 Equal, i32 (select i1 (a < b), i32 Less, i32
2435 // Greater), where Equal, Less and Greater are placeholders for any three
2436 // constants.
2437 ICmpInst::Predicate PredA, PredB;
2438 if (match(SI->getTrueValue(), m_ConstantInt(Equal)) &&
2439 match(SI->getCondition(), m_ICmp(PredA, m_Value(LHS), m_Value(RHS))) &&
2440 PredA == ICmpInst::ICMP_EQ &&
2441 match(SI->getFalseValue(),
2442 m_Select(m_ICmp(PredB, m_Specific(LHS), m_Specific(RHS)),
2443 m_ConstantInt(Less), m_ConstantInt(Greater))) &&
2444 PredB == ICmpInst::ICMP_SLT) {
2445 return true;
2446 }
2447 return false;
2448}
2449
2450Instruction *InstCombiner::foldICmpSelectConstant(ICmpInst &Cmp,
Craig Topper524c44f2017-08-23 05:46:07 +00002451 SelectInst *Select,
Anna Thomasd67165c2017-06-23 13:41:45 +00002452 ConstantInt *C) {
2453
2454 assert(C && "Cmp RHS should be a constant int!");
2455 // If we're testing a constant value against the result of a three way
2456 // comparison, the result can be expressed directly in terms of the
2457 // original values being compared. Note: We could possibly be more
2458 // aggressive here and remove the hasOneUse test. The original select is
2459 // really likely to simplify or sink when we remove a test of the result.
2460 Value *OrigLHS, *OrigRHS;
2461 ConstantInt *C1LessThan, *C2Equal, *C3GreaterThan;
2462 if (Cmp.hasOneUse() &&
Craig Topper524c44f2017-08-23 05:46:07 +00002463 matchThreeWayIntCompare(Select, OrigLHS, OrigRHS, C1LessThan, C2Equal,
2464 C3GreaterThan)) {
Anna Thomasd67165c2017-06-23 13:41:45 +00002465 assert(C1LessThan && C2Equal && C3GreaterThan);
2466
2467 bool TrueWhenLessThan =
2468 ConstantExpr::getCompare(Cmp.getPredicate(), C1LessThan, C)
2469 ->isAllOnesValue();
2470 bool TrueWhenEqual =
2471 ConstantExpr::getCompare(Cmp.getPredicate(), C2Equal, C)
2472 ->isAllOnesValue();
2473 bool TrueWhenGreaterThan =
2474 ConstantExpr::getCompare(Cmp.getPredicate(), C3GreaterThan, C)
2475 ->isAllOnesValue();
2476
2477 // This generates the new instruction that will replace the original Cmp
2478 // Instruction. Instead of enumerating the various combinations when
2479 // TrueWhenLessThan, TrueWhenEqual and TrueWhenGreaterThan are true versus
2480 // false, we rely on chaining of ORs and future passes of InstCombine to
2481 // simplify the OR further (i.e. a s< b || a == b becomes a s<= b).
2482
2483 // When none of the three constants satisfy the predicate for the RHS (C),
2484 // the entire original Cmp can be simplified to a false.
Craig Topperbb4069e2017-07-07 23:16:26 +00002485 Value *Cond = Builder.getFalse();
Anna Thomasd67165c2017-06-23 13:41:45 +00002486 if (TrueWhenLessThan)
Craig Topperbb4069e2017-07-07 23:16:26 +00002487 Cond = Builder.CreateOr(Cond, Builder.CreateICmp(ICmpInst::ICMP_SLT, OrigLHS, OrigRHS));
Anna Thomasd67165c2017-06-23 13:41:45 +00002488 if (TrueWhenEqual)
Craig Topperbb4069e2017-07-07 23:16:26 +00002489 Cond = Builder.CreateOr(Cond, Builder.CreateICmp(ICmpInst::ICMP_EQ, OrigLHS, OrigRHS));
Anna Thomasd67165c2017-06-23 13:41:45 +00002490 if (TrueWhenGreaterThan)
Craig Topperbb4069e2017-07-07 23:16:26 +00002491 Cond = Builder.CreateOr(Cond, Builder.CreateICmp(ICmpInst::ICMP_SGT, OrigLHS, OrigRHS));
Anna Thomasd67165c2017-06-23 13:41:45 +00002492
2493 return replaceInstUsesWith(Cmp, Cond);
2494 }
2495 return nullptr;
2496}
2497
Daniel Neilson901acfa2018-04-03 17:26:20 +00002498Instruction *InstCombiner::foldICmpBitCastConstant(ICmpInst &Cmp,
2499 BitCastInst *Bitcast,
2500 const APInt &C) {
2501 // Folding: icmp <pred> iN X, C
2502 // where X = bitcast <M x iK> (shufflevector <M x iK> %vec, undef, SC)) to iN
2503 // and C is a splat of a K-bit pattern
2504 // and SC is a constant vector = <C', C', C', ..., C'>
2505 // Into:
2506 // %E = extractelement <M x iK> %vec, i32 C'
2507 // icmp <pred> iK %E, trunc(C)
2508 if (!Bitcast->getType()->isIntegerTy() ||
2509 !Bitcast->getSrcTy()->isIntOrIntVectorTy())
2510 return nullptr;
2511
2512 Value *BCIOp = Bitcast->getOperand(0);
2513 Value *Vec = nullptr; // 1st vector arg of the shufflevector
2514 Constant *Mask = nullptr; // Mask arg of the shufflevector
2515 if (match(BCIOp,
2516 m_ShuffleVector(m_Value(Vec), m_Undef(), m_Constant(Mask)))) {
2517 // Check whether every element of Mask is the same constant
2518 if (auto *Elem = dyn_cast_or_null<ConstantInt>(Mask->getSplatValue())) {
2519 auto *VecTy = cast<VectorType>(BCIOp->getType());
2520 auto *EltTy = cast<IntegerType>(VecTy->getElementType());
2521 auto Pred = Cmp.getPredicate();
2522 if (C.isSplat(EltTy->getBitWidth())) {
2523 // Fold the icmp based on the value of C
2524 // If C is M copies of an iK sized bit pattern,
2525 // then:
2526 // => %E = extractelement <N x iK> %vec, i32 Elem
2527 // icmp <pred> iK %SplatVal, <pattern>
2528 Value *Extract = Builder.CreateExtractElement(Vec, Elem);
2529 Value *NewC = ConstantInt::get(EltTy, C.trunc(EltTy->getBitWidth()));
2530 return new ICmpInst(Pred, Extract, NewC);
2531 }
2532 }
2533 }
2534 return nullptr;
2535}
2536
Sanjay Patelf58f68c2016-09-10 15:03:44 +00002537/// Try to fold integer comparisons with a constant operand: icmp Pred X, C
2538/// where X is some kind of instruction.
2539Instruction *InstCombiner::foldICmpInstWithConstant(ICmpInst &Cmp) {
Sanjay Patelc9196c42016-08-22 21:24:29 +00002540 const APInt *C;
2541 if (!match(Cmp.getOperand(1), m_APInt(C)))
Sanjay Patel1e5b2d12016-08-16 16:08:11 +00002542 return nullptr;
2543
Craig Toppera94069f2017-08-23 05:46:08 +00002544 if (auto *BO = dyn_cast<BinaryOperator>(Cmp.getOperand(0))) {
Sanjay Patelc9196c42016-08-22 21:24:29 +00002545 switch (BO->getOpcode()) {
2546 case Instruction::Xor:
Craig Topper8ed1aa92017-10-03 05:31:07 +00002547 if (Instruction *I = foldICmpXorConstant(Cmp, BO, *C))
Sanjay Patelc9196c42016-08-22 21:24:29 +00002548 return I;
2549 break;
2550 case Instruction::And:
Craig Topper8ed1aa92017-10-03 05:31:07 +00002551 if (Instruction *I = foldICmpAndConstant(Cmp, BO, *C))
Sanjay Patelc9196c42016-08-22 21:24:29 +00002552 return I;
2553 break;
2554 case Instruction::Or:
Craig Topper8ed1aa92017-10-03 05:31:07 +00002555 if (Instruction *I = foldICmpOrConstant(Cmp, BO, *C))
Sanjay Patelc9196c42016-08-22 21:24:29 +00002556 return I;
2557 break;
2558 case Instruction::Mul:
Craig Topper8ed1aa92017-10-03 05:31:07 +00002559 if (Instruction *I = foldICmpMulConstant(Cmp, BO, *C))
Sanjay Patelc9196c42016-08-22 21:24:29 +00002560 return I;
2561 break;
2562 case Instruction::Shl:
Craig Topper8ed1aa92017-10-03 05:31:07 +00002563 if (Instruction *I = foldICmpShlConstant(Cmp, BO, *C))
Sanjay Patelc9196c42016-08-22 21:24:29 +00002564 return I;
2565 break;
2566 case Instruction::LShr:
2567 case Instruction::AShr:
Craig Topper8ed1aa92017-10-03 05:31:07 +00002568 if (Instruction *I = foldICmpShrConstant(Cmp, BO, *C))
Sanjay Patelc9196c42016-08-22 21:24:29 +00002569 return I;
2570 break;
2571 case Instruction::UDiv:
Craig Topper8ed1aa92017-10-03 05:31:07 +00002572 if (Instruction *I = foldICmpUDivConstant(Cmp, BO, *C))
Sanjay Patelc9196c42016-08-22 21:24:29 +00002573 return I;
2574 LLVM_FALLTHROUGH;
2575 case Instruction::SDiv:
Craig Topper8ed1aa92017-10-03 05:31:07 +00002576 if (Instruction *I = foldICmpDivConstant(Cmp, BO, *C))
Sanjay Patelc9196c42016-08-22 21:24:29 +00002577 return I;
2578 break;
2579 case Instruction::Sub:
Craig Topper8ed1aa92017-10-03 05:31:07 +00002580 if (Instruction *I = foldICmpSubConstant(Cmp, BO, *C))
Sanjay Patelc9196c42016-08-22 21:24:29 +00002581 return I;
2582 break;
2583 case Instruction::Add:
Craig Topper8ed1aa92017-10-03 05:31:07 +00002584 if (Instruction *I = foldICmpAddConstant(Cmp, BO, *C))
Sanjay Patelc9196c42016-08-22 21:24:29 +00002585 return I;
2586 break;
2587 default:
2588 break;
2589 }
Sanjay Patelf58f68c2016-09-10 15:03:44 +00002590 // TODO: These folds could be refactored to be part of the above calls.
Craig Topper8ed1aa92017-10-03 05:31:07 +00002591 if (Instruction *I = foldICmpBinOpEqualityWithConstant(Cmp, BO, *C))
Sanjay Patelf58f68c2016-09-10 15:03:44 +00002592 return I;
Chris Lattner2188e402010-01-04 07:37:31 +00002593 }
Jim Grosbach129c52a2011-09-30 18:09:53 +00002594
Anna Thomasd67165c2017-06-23 13:41:45 +00002595 // Match against CmpInst LHS being instructions other than binary operators.
Craig Topper524c44f2017-08-23 05:46:07 +00002596
2597 if (auto *SI = dyn_cast<SelectInst>(Cmp.getOperand(0))) {
2598 // For now, we only support constant integers while folding the
2599 // ICMP(SELECT)) pattern. We can extend this to support vector of integers
2600 // similar to the cases handled by binary ops above.
2601 if (ConstantInt *ConstRHS = dyn_cast<ConstantInt>(Cmp.getOperand(1)))
2602 if (Instruction *I = foldICmpSelectConstant(Cmp, SI, ConstRHS))
Anna Thomasd67165c2017-06-23 13:41:45 +00002603 return I;
Craig Topper524c44f2017-08-23 05:46:07 +00002604 }
2605
2606 if (auto *TI = dyn_cast<TruncInst>(Cmp.getOperand(0))) {
Craig Topper8ed1aa92017-10-03 05:31:07 +00002607 if (Instruction *I = foldICmpTruncConstant(Cmp, TI, *C))
Craig Topper524c44f2017-08-23 05:46:07 +00002608 return I;
Anna Thomasd67165c2017-06-23 13:41:45 +00002609 }
Sanjay Patelc9196c42016-08-22 21:24:29 +00002610
Daniel Neilson901acfa2018-04-03 17:26:20 +00002611 if (auto *BCI = dyn_cast<BitCastInst>(Cmp.getOperand(0))) {
2612 if (Instruction *I = foldICmpBitCastConstant(Cmp, BCI, *C))
2613 return I;
2614 }
2615
Craig Topper8ed1aa92017-10-03 05:31:07 +00002616 if (Instruction *I = foldICmpIntrinsicWithConstant(Cmp, *C))
Sanjay Patelf58f68c2016-09-10 15:03:44 +00002617 return I;
2618
Sanjay Patel1710e7c2016-07-21 17:15:49 +00002619 return nullptr;
2620}
Jim Grosbach129c52a2011-09-30 18:09:53 +00002621
Sanjay Patel0a3d72b2016-09-10 15:33:39 +00002622/// Fold an icmp equality instruction with binary operator LHS and constant RHS:
2623/// icmp eq/ne BO, C.
2624Instruction *InstCombiner::foldICmpBinOpEqualityWithConstant(ICmpInst &Cmp,
2625 BinaryOperator *BO,
Craig Topper8ed1aa92017-10-03 05:31:07 +00002626 const APInt &C) {
Sanjay Patel0a3d72b2016-09-10 15:33:39 +00002627 // TODO: Some of these folds could work with arbitrary constants, but this
2628 // function is limited to scalar and vector splat constants.
2629 if (!Cmp.isEquality())
Sanjay Patel1710e7c2016-07-21 17:15:49 +00002630 return nullptr;
2631
Sanjay Patel0a3d72b2016-09-10 15:33:39 +00002632 ICmpInst::Predicate Pred = Cmp.getPredicate();
2633 bool isICMP_NE = Pred == ICmpInst::ICMP_NE;
2634 Constant *RHS = cast<Constant>(Cmp.getOperand(1));
Sanjay Patel51a767c2016-08-03 17:23:08 +00002635 Value *BOp0 = BO->getOperand(0), *BOp1 = BO->getOperand(1);
Sanjay Patel1710e7c2016-07-21 17:15:49 +00002636
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002637 switch (BO->getOpcode()) {
2638 case Instruction::SRem:
2639 // If we have a signed (X % (2^c)) == 0, turn it into an unsigned one.
Craig Topper8ed1aa92017-10-03 05:31:07 +00002640 if (C.isNullValue() && BO->hasOneUse()) {
Sanjay Patel2e9675f2016-08-03 19:48:40 +00002641 const APInt *BOC;
2642 if (match(BOp1, m_APInt(BOC)) && BOC->sgt(1) && BOC->isPowerOf2()) {
Craig Topperbb4069e2017-07-07 23:16:26 +00002643 Value *NewRem = Builder.CreateURem(BOp0, BOp1, BO->getName());
Sanjay Patel0a3d72b2016-09-10 15:33:39 +00002644 return new ICmpInst(Pred, NewRem,
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002645 Constant::getNullValue(BO->getType()));
Chris Lattner2188e402010-01-04 07:37:31 +00002646 }
Sanjay Patel1710e7c2016-07-21 17:15:49 +00002647 }
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002648 break;
Sanjay Patel00a324e2016-08-03 22:08:44 +00002649 case Instruction::Add: {
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002650 // Replace ((add A, B) != C) with (A != C-B) if B & C are constants.
Sanjay Patel00a324e2016-08-03 22:08:44 +00002651 const APInt *BOC;
2652 if (match(BOp1, m_APInt(BOC))) {
2653 if (BO->hasOneUse()) {
2654 Constant *SubC = ConstantExpr::getSub(RHS, cast<Constant>(BOp1));
Sanjay Patel0a3d72b2016-09-10 15:33:39 +00002655 return new ICmpInst(Pred, BOp0, SubC);
Sanjay Patel00a324e2016-08-03 22:08:44 +00002656 }
Craig Topper8ed1aa92017-10-03 05:31:07 +00002657 } else if (C.isNullValue()) {
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002658 // Replace ((add A, B) != 0) with (A != -B) if A or B is
2659 // efficiently invertible, or if the add has just this one use.
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002660 if (Value *NegVal = dyn_castNegVal(BOp1))
Sanjay Patel0a3d72b2016-09-10 15:33:39 +00002661 return new ICmpInst(Pred, BOp0, NegVal);
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002662 if (Value *NegVal = dyn_castNegVal(BOp0))
Sanjay Patel0a3d72b2016-09-10 15:33:39 +00002663 return new ICmpInst(Pred, NegVal, BOp1);
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002664 if (BO->hasOneUse()) {
Craig Topperbb4069e2017-07-07 23:16:26 +00002665 Value *Neg = Builder.CreateNeg(BOp1);
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002666 Neg->takeName(BO);
Sanjay Patel0a3d72b2016-09-10 15:33:39 +00002667 return new ICmpInst(Pred, BOp0, Neg);
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002668 }
2669 }
2670 break;
Sanjay Patel00a324e2016-08-03 22:08:44 +00002671 }
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002672 case Instruction::Xor:
2673 if (BO->hasOneUse()) {
Sanjay Patel51a767c2016-08-03 17:23:08 +00002674 if (Constant *BOC = dyn_cast<Constant>(BOp1)) {
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002675 // For the xor case, we can xor two constants together, eliminating
2676 // the explicit xor.
Sanjay Patel0a3d72b2016-09-10 15:33:39 +00002677 return new ICmpInst(Pred, BOp0, ConstantExpr::getXor(RHS, BOC));
Craig Topper8ed1aa92017-10-03 05:31:07 +00002678 } else if (C.isNullValue()) {
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002679 // Replace ((xor A, B) != 0) with (A != B)
Sanjay Patel0a3d72b2016-09-10 15:33:39 +00002680 return new ICmpInst(Pred, BOp0, BOp1);
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002681 }
2682 }
2683 break;
2684 case Instruction::Sub:
2685 if (BO->hasOneUse()) {
Sanjay Patel9d591d12016-08-04 15:19:25 +00002686 const APInt *BOC;
2687 if (match(BOp0, m_APInt(BOC))) {
Sanjay Patel362ff5c2016-09-15 17:01:17 +00002688 // Replace ((sub BOC, B) != C) with (B != BOC-C).
Sanjay Patel9d591d12016-08-04 15:19:25 +00002689 Constant *SubC = ConstantExpr::getSub(cast<Constant>(BOp0), RHS);
Sanjay Patel0a3d72b2016-09-10 15:33:39 +00002690 return new ICmpInst(Pred, BOp1, SubC);
Craig Topper8ed1aa92017-10-03 05:31:07 +00002691 } else if (C.isNullValue()) {
Sanjay Patel362ff5c2016-09-15 17:01:17 +00002692 // Replace ((sub A, B) != 0) with (A != B).
Sanjay Patel0a3d72b2016-09-10 15:33:39 +00002693 return new ICmpInst(Pred, BOp0, BOp1);
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002694 }
2695 }
2696 break;
Sanjay Patelb3de75d2016-08-04 19:12:12 +00002697 case Instruction::Or: {
2698 const APInt *BOC;
2699 if (match(BOp1, m_APInt(BOC)) && BO->hasOneUse() && RHS->isAllOnesValue()) {
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002700 // Comparing if all bits outside of a constant mask are set?
2701 // Replace (X | C) == -1 with (X & ~C) == ~C.
2702 // This removes the -1 constant.
Sanjay Patelb3de75d2016-08-04 19:12:12 +00002703 Constant *NotBOC = ConstantExpr::getNot(cast<Constant>(BOp1));
Craig Topperbb4069e2017-07-07 23:16:26 +00002704 Value *And = Builder.CreateAnd(BOp0, NotBOC);
Sanjay Patel0a3d72b2016-09-10 15:33:39 +00002705 return new ICmpInst(Pred, And, NotBOC);
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002706 }
2707 break;
Sanjay Patelb3de75d2016-08-04 19:12:12 +00002708 }
Sanjay Pateld938e882016-08-04 20:05:02 +00002709 case Instruction::And: {
2710 const APInt *BOC;
2711 if (match(BOp1, m_APInt(BOC))) {
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002712 // If we have ((X & C) == C), turn it into ((X & C) != 0).
Craig Topper8ed1aa92017-10-03 05:31:07 +00002713 if (C == *BOC && C.isPowerOf2())
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002714 return new ICmpInst(isICMP_NE ? ICmpInst::ICMP_EQ : ICmpInst::ICMP_NE,
Sanjay Patelab50a932016-08-02 22:38:33 +00002715 BO, Constant::getNullValue(RHS->getType()));
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002716
2717 // Don't perform the following transforms if the AND has multiple uses
2718 if (!BO->hasOneUse())
2719 break;
2720
2721 // Replace (and X, (1 << size(X)-1) != 0) with x s< 0
Craig Topperbcfd2d12017-04-20 16:56:25 +00002722 if (BOC->isSignMask()) {
Sanjay Patel51a767c2016-08-03 17:23:08 +00002723 Constant *Zero = Constant::getNullValue(BOp0->getType());
Sanjay Patel0a3d72b2016-09-10 15:33:39 +00002724 auto NewPred = isICMP_NE ? ICmpInst::ICMP_SLT : ICmpInst::ICMP_SGE;
2725 return new ICmpInst(NewPred, BOp0, Zero);
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002726 }
2727
2728 // ((X & ~7) == 0) --> X < 8
Craig Topper8ed1aa92017-10-03 05:31:07 +00002729 if (C.isNullValue() && (~(*BOC) + 1).isPowerOf2()) {
Sanjay Pateld938e882016-08-04 20:05:02 +00002730 Constant *NegBOC = ConstantExpr::getNeg(cast<Constant>(BOp1));
Sanjay Patel0a3d72b2016-09-10 15:33:39 +00002731 auto NewPred = isICMP_NE ? ICmpInst::ICMP_UGE : ICmpInst::ICMP_ULT;
2732 return new ICmpInst(NewPred, BOp0, NegBOC);
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002733 }
2734 }
2735 break;
Sanjay Pateld938e882016-08-04 20:05:02 +00002736 }
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002737 case Instruction::Mul:
Craig Topper8ed1aa92017-10-03 05:31:07 +00002738 if (C.isNullValue() && BO->hasNoSignedWrap()) {
Sanjay Patel3bade132016-08-04 22:19:27 +00002739 const APInt *BOC;
Craig Topper73ba1c82017-06-07 07:40:37 +00002740 if (match(BOp1, m_APInt(BOC)) && !BOC->isNullValue()) {
Sanjay Patel3bade132016-08-04 22:19:27 +00002741 // The trivial case (mul X, 0) is handled by InstSimplify.
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002742 // General case : (mul X, C) != 0 iff X != 0
2743 // (mul X, C) == 0 iff X == 0
Sanjay Patel0a3d72b2016-09-10 15:33:39 +00002744 return new ICmpInst(Pred, BOp0, Constant::getNullValue(RHS->getType()));
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002745 }
2746 }
2747 break;
Sanjay Patel6ebd5852016-07-23 00:28:39 +00002748 case Instruction::UDiv:
Craig Topper8ed1aa92017-10-03 05:31:07 +00002749 if (C.isNullValue()) {
Sanjay Patel6ebd5852016-07-23 00:28:39 +00002750 // (icmp eq/ne (udiv A, B), 0) -> (icmp ugt/ule i32 B, A)
Sanjay Patel0a3d72b2016-09-10 15:33:39 +00002751 auto NewPred = isICMP_NE ? ICmpInst::ICMP_ULE : ICmpInst::ICMP_UGT;
2752 return new ICmpInst(NewPred, BOp1, BOp0);
Sanjay Patel6ebd5852016-07-23 00:28:39 +00002753 }
2754 break;
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002755 default:
2756 break;
2757 }
2758 return nullptr;
2759}
2760
Sanjay Patel0a3d72b2016-09-10 15:33:39 +00002761/// Fold an icmp with LLVM intrinsic and constant operand: icmp Pred II, C.
2762Instruction *InstCombiner::foldICmpIntrinsicWithConstant(ICmpInst &Cmp,
Craig Topper8ed1aa92017-10-03 05:31:07 +00002763 const APInt &C) {
Sanjay Patel0a3d72b2016-09-10 15:33:39 +00002764 IntrinsicInst *II = dyn_cast<IntrinsicInst>(Cmp.getOperand(0));
2765 if (!II || !Cmp.isEquality())
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002766 return nullptr;
2767
Sanjay Patelb51e0722017-07-02 16:05:11 +00002768 // Handle icmp {eq|ne} <intrinsic>, Constant.
2769 Type *Ty = II->getType();
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002770 switch (II->getIntrinsicID()) {
2771 case Intrinsic::bswap:
2772 Worklist.Add(II);
Sanjay Patel0a3d72b2016-09-10 15:33:39 +00002773 Cmp.setOperand(0, II->getArgOperand(0));
Craig Topper8ed1aa92017-10-03 05:31:07 +00002774 Cmp.setOperand(1, ConstantInt::get(Ty, C.byteSwap()));
Sanjay Patel0a3d72b2016-09-10 15:33:39 +00002775 return &Cmp;
Sanjay Patelb51e0722017-07-02 16:05:11 +00002776
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002777 case Intrinsic::ctlz:
2778 case Intrinsic::cttz:
Amaury Sechet6bea6742016-08-04 05:27:20 +00002779 // ctz(A) == bitwidth(A) -> A == 0 and likewise for !=
Craig Topper8ed1aa92017-10-03 05:31:07 +00002780 if (C == C.getBitWidth()) {
Sanjay Patel1710e7c2016-07-21 17:15:49 +00002781 Worklist.Add(II);
Sanjay Patel0a3d72b2016-09-10 15:33:39 +00002782 Cmp.setOperand(0, II->getArgOperand(0));
Sanjay Patelb51e0722017-07-02 16:05:11 +00002783 Cmp.setOperand(1, ConstantInt::getNullValue(Ty));
Sanjay Patel0a3d72b2016-09-10 15:33:39 +00002784 return &Cmp;
Chris Lattner2188e402010-01-04 07:37:31 +00002785 }
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002786 break;
Sanjay Patelb51e0722017-07-02 16:05:11 +00002787
Amaury Sechet6bea6742016-08-04 05:27:20 +00002788 case Intrinsic::ctpop: {
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002789 // popcount(A) == 0 -> A == 0 and likewise for !=
Amaury Sechet6bea6742016-08-04 05:27:20 +00002790 // popcount(A) == bitwidth(A) -> A == -1 and likewise for !=
Craig Topper8ed1aa92017-10-03 05:31:07 +00002791 bool IsZero = C.isNullValue();
2792 if (IsZero || C == C.getBitWidth()) {
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002793 Worklist.Add(II);
Sanjay Patel0a3d72b2016-09-10 15:33:39 +00002794 Cmp.setOperand(0, II->getArgOperand(0));
Sanjay Patelb51e0722017-07-02 16:05:11 +00002795 auto *NewOp =
2796 IsZero ? Constant::getNullValue(Ty) : Constant::getAllOnesValue(Ty);
Sanjay Patel0a3d72b2016-09-10 15:33:39 +00002797 Cmp.setOperand(1, NewOp);
2798 return &Cmp;
Amaury Sechet6bea6742016-08-04 05:27:20 +00002799 }
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002800 break;
Sanjay Patel0a3d72b2016-09-10 15:33:39 +00002801 }
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002802 default:
2803 break;
Chris Lattner2188e402010-01-04 07:37:31 +00002804 }
Sanjay Patelb51e0722017-07-02 16:05:11 +00002805
Craig Topperf40110f2014-04-25 05:29:35 +00002806 return nullptr;
Chris Lattner2188e402010-01-04 07:37:31 +00002807}
2808
Sanjay Patel10494b22016-09-16 16:10:22 +00002809/// Handle icmp with constant (but not simple integer constant) RHS.
2810Instruction *InstCombiner::foldICmpInstWithConstantNotInt(ICmpInst &I) {
2811 Value *Op0 = I.getOperand(0), *Op1 = I.getOperand(1);
2812 Constant *RHSC = dyn_cast<Constant>(Op1);
2813 Instruction *LHSI = dyn_cast<Instruction>(Op0);
2814 if (!RHSC || !LHSI)
2815 return nullptr;
2816
2817 switch (LHSI->getOpcode()) {
2818 case Instruction::GetElementPtr:
2819 // icmp pred GEP (P, int 0, int 0, int 0), null -> icmp pred P, null
2820 if (RHSC->isNullValue() &&
2821 cast<GetElementPtrInst>(LHSI)->hasAllZeroIndices())
2822 return new ICmpInst(
2823 I.getPredicate(), LHSI->getOperand(0),
2824 Constant::getNullValue(LHSI->getOperand(0)->getType()));
2825 break;
2826 case Instruction::PHI:
2827 // Only fold icmp into the PHI if the phi and icmp are in the same
2828 // block. If in the same block, we're encouraging jump threading. If
2829 // not, we are just pessimizing the code by making an i1 phi.
2830 if (LHSI->getParent() == I.getParent())
Craig Topperfb71b7d2017-04-14 19:20:12 +00002831 if (Instruction *NV = foldOpIntoPhi(I, cast<PHINode>(LHSI)))
Sanjay Patel10494b22016-09-16 16:10:22 +00002832 return NV;
2833 break;
2834 case Instruction::Select: {
2835 // If either operand of the select is a constant, we can fold the
2836 // comparison into the select arms, which will cause one to be
2837 // constant folded and the select turned into a bitwise or.
2838 Value *Op1 = nullptr, *Op2 = nullptr;
2839 ConstantInt *CI = nullptr;
2840 if (Constant *C = dyn_cast<Constant>(LHSI->getOperand(1))) {
2841 Op1 = ConstantExpr::getICmp(I.getPredicate(), C, RHSC);
2842 CI = dyn_cast<ConstantInt>(Op1);
2843 }
2844 if (Constant *C = dyn_cast<Constant>(LHSI->getOperand(2))) {
2845 Op2 = ConstantExpr::getICmp(I.getPredicate(), C, RHSC);
2846 CI = dyn_cast<ConstantInt>(Op2);
2847 }
2848
2849 // We only want to perform this transformation if it will not lead to
2850 // additional code. This is true if either both sides of the select
2851 // fold to a constant (in which case the icmp is replaced with a select
2852 // which will usually simplify) or this is the only user of the
2853 // select (in which case we are trading a select+icmp for a simpler
2854 // select+icmp) or all uses of the select can be replaced based on
2855 // dominance information ("Global cases").
2856 bool Transform = false;
2857 if (Op1 && Op2)
2858 Transform = true;
2859 else if (Op1 || Op2) {
2860 // Local case
2861 if (LHSI->hasOneUse())
2862 Transform = true;
2863 // Global cases
2864 else if (CI && !CI->isZero())
2865 // When Op1 is constant try replacing select with second operand.
2866 // Otherwise Op2 is constant and try replacing select with first
2867 // operand.
2868 Transform =
2869 replacedSelectWithOperand(cast<SelectInst>(LHSI), &I, Op1 ? 2 : 1);
2870 }
2871 if (Transform) {
2872 if (!Op1)
Craig Topperbb4069e2017-07-07 23:16:26 +00002873 Op1 = Builder.CreateICmp(I.getPredicate(), LHSI->getOperand(1), RHSC,
2874 I.getName());
Sanjay Patel10494b22016-09-16 16:10:22 +00002875 if (!Op2)
Craig Topperbb4069e2017-07-07 23:16:26 +00002876 Op2 = Builder.CreateICmp(I.getPredicate(), LHSI->getOperand(2), RHSC,
2877 I.getName());
Sanjay Patel10494b22016-09-16 16:10:22 +00002878 return SelectInst::Create(LHSI->getOperand(0), Op1, Op2);
2879 }
2880 break;
2881 }
2882 case Instruction::IntToPtr:
2883 // icmp pred inttoptr(X), null -> icmp pred X, 0
2884 if (RHSC->isNullValue() &&
2885 DL.getIntPtrType(RHSC->getType()) == LHSI->getOperand(0)->getType())
2886 return new ICmpInst(
2887 I.getPredicate(), LHSI->getOperand(0),
2888 Constant::getNullValue(LHSI->getOperand(0)->getType()));
2889 break;
2890
2891 case Instruction::Load:
2892 // Try to optimize things like "A[i] > 4" to index computations.
2893 if (GetElementPtrInst *GEP =
2894 dyn_cast<GetElementPtrInst>(LHSI->getOperand(0))) {
2895 if (GlobalVariable *GV = dyn_cast<GlobalVariable>(GEP->getOperand(0)))
2896 if (GV->isConstant() && GV->hasDefinitiveInitializer() &&
2897 !cast<LoadInst>(LHSI)->isVolatile())
2898 if (Instruction *Res = foldCmpLoadFromIndexedGlobal(GEP, GV, I))
2899 return Res;
2900 }
2901 break;
2902 }
2903
2904 return nullptr;
2905}
2906
Roman Lebedev68d54cf2018-07-11 19:05:04 +00002907/// Some comparisons can be simplified.
2908/// In this case, we are looking for comparisons that look like
2909/// a check for a lossy truncation.
2910/// Folds:
Roman Lebedev183a4652018-09-19 13:35:27 +00002911/// icmp SrcPred (x & Mask), x to icmp DstPred x, Mask
2912/// Where Mask is some pattern that produces all-ones in low bits:
2913/// (-1 >> y)
Roman Lebedevf50023d2018-09-19 13:35:46 +00002914/// ((-1 << y) >> y) <- non-canonical, has extra uses
Roman Lebedev183a4652018-09-19 13:35:27 +00002915/// ~(-1 << y)
Roman Lebedevca2bdb02018-09-19 13:35:40 +00002916/// ((1 << y) + (-1)) <- non-canonical, has extra uses
Roman Lebedev68d54cf2018-07-11 19:05:04 +00002917/// The Mask can be a constant, too.
Roman Lebedevc7bc4c02018-07-14 20:08:52 +00002918/// For some predicates, the operands are commutative.
2919/// For others, x can only be on a specific side.
Roman Lebedev68d54cf2018-07-11 19:05:04 +00002920static Value *foldICmpWithLowBitMaskedVal(ICmpInst &I,
2921 InstCombiner::BuilderTy &Builder) {
2922 ICmpInst::Predicate SrcPred;
Roman Lebedevf50023d2018-09-19 13:35:46 +00002923 Value *X, *M, *Y;
2924 auto m_VariableMask = m_CombineOr(
2925 m_CombineOr(m_Not(m_Shl(m_AllOnes(), m_Value())),
2926 m_Add(m_Shl(m_One(), m_Value()), m_AllOnes())),
2927 m_CombineOr(m_LShr(m_AllOnes(), m_Value()),
2928 m_LShr(m_Shl(m_AllOnes(), m_Value(Y)), m_Deferred(Y))));
Roman Lebedev183a4652018-09-19 13:35:27 +00002929 auto m_Mask = m_CombineOr(m_VariableMask, m_LowBitMask());
Roman Lebedev68d54cf2018-07-11 19:05:04 +00002930 if (!match(&I, m_c_ICmp(SrcPred,
2931 m_c_And(m_CombineAnd(m_Mask, m_Value(M)), m_Value(X)),
2932 m_Deferred(X))))
2933 return nullptr;
2934
2935 ICmpInst::Predicate DstPred;
2936 switch (SrcPred) {
2937 case ICmpInst::Predicate::ICMP_EQ:
2938 // x & (-1 >> y) == x -> x u<= (-1 >> y)
2939 DstPred = ICmpInst::Predicate::ICMP_ULE;
2940 break;
Roman Lebedev74f899f2018-07-12 14:56:12 +00002941 case ICmpInst::Predicate::ICMP_NE:
2942 // x & (-1 >> y) != x -> x u> (-1 >> y)
2943 DstPred = ICmpInst::Predicate::ICMP_UGT;
2944 break;
Roman Lebedev74f611a2018-07-14 16:44:43 +00002945 case ICmpInst::Predicate::ICMP_UGT:
2946 // x u> x & (-1 >> y) -> x u> (-1 >> y)
2947 assert(X == I.getOperand(0) && "instsimplify took care of commut. variant");
2948 DstPred = ICmpInst::Predicate::ICMP_UGT;
2949 break;
Roman Lebedevfac48472018-07-14 12:20:06 +00002950 case ICmpInst::Predicate::ICMP_UGE:
2951 // x & (-1 >> y) u>= x -> x u<= (-1 >> y)
2952 assert(X == I.getOperand(1) && "instsimplify took care of commut. variant");
2953 DstPred = ICmpInst::Predicate::ICMP_ULE;
2954 break;
Roman Lebedeve3dc5872018-07-14 12:20:16 +00002955 case ICmpInst::Predicate::ICMP_ULT:
2956 // x & (-1 >> y) u< x -> x u> (-1 >> y)
2957 assert(X == I.getOperand(1) && "instsimplify took care of commut. variant");
2958 DstPred = ICmpInst::Predicate::ICMP_UGT;
2959 break;
Roman Lebedev0f5ec892018-07-14 16:44:54 +00002960 case ICmpInst::Predicate::ICMP_ULE:
2961 // x u<= x & (-1 >> y) -> x u<= (-1 >> y)
2962 assert(X == I.getOperand(0) && "instsimplify took care of commut. variant");
2963 DstPred = ICmpInst::Predicate::ICMP_ULE;
2964 break;
Roman Lebedev859e14a2018-07-14 20:08:16 +00002965 case ICmpInst::Predicate::ICMP_SGT:
2966 // x s> x & (-1 >> y) -> x s> (-1 >> y)
2967 if (X != I.getOperand(0)) // X must be on LHS of comparison!
2968 return nullptr; // Ignore the other case.
2969 DstPred = ICmpInst::Predicate::ICMP_SGT;
2970 break;
Roman Lebedevf1442612018-07-14 20:08:37 +00002971 case ICmpInst::Predicate::ICMP_SGE:
2972 // x & (-1 >> y) s>= x -> x s<= (-1 >> y)
2973 if (X != I.getOperand(1)) // X must be on RHS of comparison!
2974 return nullptr; // Ignore the other case.
Roman Lebedev7bf2fed2018-12-03 20:07:58 +00002975 if (!match(M, m_Constant())) // Can not do this fold with non-constant.
2976 return nullptr;
Roman Lebedevf1442612018-07-14 20:08:37 +00002977 DstPred = ICmpInst::Predicate::ICMP_SLE;
2978 break;
Roman Lebedevb972fc32018-07-14 20:08:47 +00002979 case ICmpInst::Predicate::ICMP_SLT:
2980 // x & (-1 >> y) s< x -> x s> (-1 >> y)
2981 if (X != I.getOperand(1)) // X must be on RHS of comparison!
2982 return nullptr; // Ignore the other case.
Roman Lebedev7bf2fed2018-12-03 20:07:58 +00002983 if (!match(M, m_Constant())) // Can not do this fold with non-constant.
2984 return nullptr;
Roman Lebedevb972fc32018-07-14 20:08:47 +00002985 DstPred = ICmpInst::Predicate::ICMP_SGT;
2986 break;
Roman Lebedev1e61e352018-07-14 20:08:26 +00002987 case ICmpInst::Predicate::ICMP_SLE:
2988 // x s<= x & (-1 >> y) -> x s<= (-1 >> y)
2989 if (X != I.getOperand(0)) // X must be on LHS of comparison!
2990 return nullptr; // Ignore the other case.
2991 DstPred = ICmpInst::Predicate::ICMP_SLE;
2992 break;
Roman Lebedev68d54cf2018-07-11 19:05:04 +00002993 default:
Roman Lebedevc7bc4c02018-07-14 20:08:52 +00002994 llvm_unreachable("All possible folds are handled.");
Roman Lebedev68d54cf2018-07-11 19:05:04 +00002995 }
2996
2997 return Builder.CreateICmp(DstPred, X, M);
2998}
2999
Roman Lebedev3cb87e92018-07-18 10:55:17 +00003000/// Some comparisons can be simplified.
3001/// In this case, we are looking for comparisons that look like
3002/// a check for a lossy signed truncation.
3003/// Folds: (MaskedBits is a constant.)
3004/// ((%x << MaskedBits) a>> MaskedBits) SrcPred %x
3005/// Into:
3006/// (add %x, (1 << (KeptBits-1))) DstPred (1 << KeptBits)
3007/// Where KeptBits = bitwidth(%x) - MaskedBits
3008static Value *
3009foldICmpWithTruncSignExtendedVal(ICmpInst &I,
3010 InstCombiner::BuilderTy &Builder) {
3011 ICmpInst::Predicate SrcPred;
3012 Value *X;
3013 const APInt *C0, *C1; // FIXME: non-splats, potentially with undef.
3014 // We are ok with 'shl' having multiple uses, but 'ashr' must be one-use.
3015 if (!match(&I, m_c_ICmp(SrcPred,
3016 m_OneUse(m_AShr(m_Shl(m_Value(X), m_APInt(C0)),
3017 m_APInt(C1))),
3018 m_Deferred(X))))
3019 return nullptr;
3020
3021 // Potential handling of non-splats: for each element:
3022 // * if both are undef, replace with constant 0.
3023 // Because (1<<0) is OK and is 1, and ((1<<0)>>1) is also OK and is 0.
3024 // * if both are not undef, and are different, bailout.
3025 // * else, only one is undef, then pick the non-undef one.
3026
3027 // The shift amount must be equal.
3028 if (*C0 != *C1)
3029 return nullptr;
3030 const APInt &MaskedBits = *C0;
3031 assert(MaskedBits != 0 && "shift by zero should be folded away already.");
3032
3033 ICmpInst::Predicate DstPred;
3034 switch (SrcPred) {
3035 case ICmpInst::Predicate::ICMP_EQ:
3036 // ((%x << MaskedBits) a>> MaskedBits) == %x
3037 // =>
3038 // (add %x, (1 << (KeptBits-1))) u< (1 << KeptBits)
3039 DstPred = ICmpInst::Predicate::ICMP_ULT;
3040 break;
3041 case ICmpInst::Predicate::ICMP_NE:
3042 // ((%x << MaskedBits) a>> MaskedBits) != %x
3043 // =>
3044 // (add %x, (1 << (KeptBits-1))) u>= (1 << KeptBits)
3045 DstPred = ICmpInst::Predicate::ICMP_UGE;
3046 break;
3047 // FIXME: are more folds possible?
3048 default:
3049 return nullptr;
3050 }
3051
3052 auto *XType = X->getType();
3053 const unsigned XBitWidth = XType->getScalarSizeInBits();
3054 const APInt BitWidth = APInt(XBitWidth, XBitWidth);
3055 assert(BitWidth.ugt(MaskedBits) && "shifts should leave some bits untouched");
3056
3057 // KeptBits = bitwidth(%x) - MaskedBits
3058 const APInt KeptBits = BitWidth - MaskedBits;
3059 assert(KeptBits.ugt(0) && KeptBits.ult(BitWidth) && "unreachable");
3060 // ICmpCst = (1 << KeptBits)
3061 const APInt ICmpCst = APInt(XBitWidth, 1).shl(KeptBits);
3062 assert(ICmpCst.isPowerOf2());
3063 // AddCst = (1 << (KeptBits-1))
3064 const APInt AddCst = ICmpCst.lshr(1);
3065 assert(AddCst.ult(ICmpCst) && AddCst.isPowerOf2());
3066
3067 // T0 = add %x, AddCst
3068 Value *T0 = Builder.CreateAdd(X, ConstantInt::get(XType, AddCst));
3069 // T1 = T0 DstPred ICmpCst
3070 Value *T1 = Builder.CreateICmp(DstPred, T0, ConstantInt::get(XType, ICmpCst));
3071
3072 return T1;
3073}
3074
Sanjay Patel10494b22016-09-16 16:10:22 +00003075/// Try to fold icmp (binop), X or icmp X, (binop).
Sanjay Patel2df38a82017-05-08 16:21:55 +00003076/// TODO: A large part of this logic is duplicated in InstSimplify's
3077/// simplifyICmpWithBinOp(). We should be able to share that and avoid the code
3078/// duplication.
Sanjay Patel10494b22016-09-16 16:10:22 +00003079Instruction *InstCombiner::foldICmpBinOp(ICmpInst &I) {
3080 Value *Op0 = I.getOperand(0), *Op1 = I.getOperand(1);
3081
3082 // Special logic for binary operators.
3083 BinaryOperator *BO0 = dyn_cast<BinaryOperator>(Op0);
3084 BinaryOperator *BO1 = dyn_cast<BinaryOperator>(Op1);
3085 if (!BO0 && !BO1)
3086 return nullptr;
3087
Sanjay Patel2a062632017-05-08 16:33:42 +00003088 const CmpInst::Predicate Pred = I.getPredicate();
Sanjay Patel1cf07342018-09-11 22:40:20 +00003089 Value *X;
3090
3091 // Convert add-with-unsigned-overflow comparisons into a 'not' with compare.
3092 // (Op1 + X) <u Op1 --> ~Op1 <u X
3093 // Op0 >u (Op0 + X) --> X >u ~Op0
3094 if (match(Op0, m_OneUse(m_c_Add(m_Specific(Op1), m_Value(X)))) &&
3095 Pred == ICmpInst::ICMP_ULT)
3096 return new ICmpInst(Pred, Builder.CreateNot(Op1), X);
3097 if (match(Op1, m_OneUse(m_c_Add(m_Specific(Op0), m_Value(X)))) &&
3098 Pred == ICmpInst::ICMP_UGT)
3099 return new ICmpInst(Pred, X, Builder.CreateNot(Op0));
3100
Sanjay Patel10494b22016-09-16 16:10:22 +00003101 bool NoOp0WrapProblem = false, NoOp1WrapProblem = false;
3102 if (BO0 && isa<OverflowingBinaryOperator>(BO0))
3103 NoOp0WrapProblem =
3104 ICmpInst::isEquality(Pred) ||
3105 (CmpInst::isUnsigned(Pred) && BO0->hasNoUnsignedWrap()) ||
3106 (CmpInst::isSigned(Pred) && BO0->hasNoSignedWrap());
3107 if (BO1 && isa<OverflowingBinaryOperator>(BO1))
3108 NoOp1WrapProblem =
3109 ICmpInst::isEquality(Pred) ||
3110 (CmpInst::isUnsigned(Pred) && BO1->hasNoUnsignedWrap()) ||
3111 (CmpInst::isSigned(Pred) && BO1->hasNoSignedWrap());
3112
3113 // Analyze the case when either Op0 or Op1 is an add instruction.
3114 // Op0 = A + B (or A and B are null); Op1 = C + D (or C and D are null).
3115 Value *A = nullptr, *B = nullptr, *C = nullptr, *D = nullptr;
3116 if (BO0 && BO0->getOpcode() == Instruction::Add) {
3117 A = BO0->getOperand(0);
3118 B = BO0->getOperand(1);
3119 }
3120 if (BO1 && BO1->getOpcode() == Instruction::Add) {
3121 C = BO1->getOperand(0);
3122 D = BO1->getOperand(1);
3123 }
3124
Sanjay Patel10494b22016-09-16 16:10:22 +00003125 // icmp (X+Y), X -> icmp Y, 0 for equalities or if there is no overflow.
3126 if ((A == Op1 || B == Op1) && NoOp0WrapProblem)
3127 return new ICmpInst(Pred, A == Op1 ? B : A,
3128 Constant::getNullValue(Op1->getType()));
3129
3130 // icmp X, (X+Y) -> icmp 0, Y for equalities or if there is no overflow.
3131 if ((C == Op0 || D == Op0) && NoOp1WrapProblem)
3132 return new ICmpInst(Pred, Constant::getNullValue(Op0->getType()),
3133 C == Op0 ? D : C);
3134
3135 // icmp (X+Y), (X+Z) -> icmp Y, Z for equalities or if there is no overflow.
3136 if (A && C && (A == C || A == D || B == C || B == D) && NoOp0WrapProblem &&
3137 NoOp1WrapProblem &&
3138 // Try not to increase register pressure.
3139 BO0->hasOneUse() && BO1->hasOneUse()) {
3140 // Determine Y and Z in the form icmp (X+Y), (X+Z).
3141 Value *Y, *Z;
3142 if (A == C) {
3143 // C + B == C + D -> B == D
3144 Y = B;
3145 Z = D;
3146 } else if (A == D) {
3147 // D + B == C + D -> B == C
3148 Y = B;
3149 Z = C;
3150 } else if (B == C) {
3151 // A + C == C + D -> A == D
3152 Y = A;
3153 Z = D;
3154 } else {
3155 assert(B == D);
3156 // A + D == C + D -> A == C
3157 Y = A;
3158 Z = C;
3159 }
3160 return new ICmpInst(Pred, Y, Z);
3161 }
3162
3163 // icmp slt (X + -1), Y -> icmp sle X, Y
3164 if (A && NoOp0WrapProblem && Pred == CmpInst::ICMP_SLT &&
3165 match(B, m_AllOnes()))
3166 return new ICmpInst(CmpInst::ICMP_SLE, A, Op1);
3167
3168 // icmp sge (X + -1), Y -> icmp sgt X, Y
3169 if (A && NoOp0WrapProblem && Pred == CmpInst::ICMP_SGE &&
3170 match(B, m_AllOnes()))
3171 return new ICmpInst(CmpInst::ICMP_SGT, A, Op1);
3172
3173 // icmp sle (X + 1), Y -> icmp slt X, Y
3174 if (A && NoOp0WrapProblem && Pred == CmpInst::ICMP_SLE && match(B, m_One()))
3175 return new ICmpInst(CmpInst::ICMP_SLT, A, Op1);
3176
3177 // icmp sgt (X + 1), Y -> icmp sge X, Y
3178 if (A && NoOp0WrapProblem && Pred == CmpInst::ICMP_SGT && match(B, m_One()))
3179 return new ICmpInst(CmpInst::ICMP_SGE, A, Op1);
3180
3181 // icmp sgt X, (Y + -1) -> icmp sge X, Y
3182 if (C && NoOp1WrapProblem && Pred == CmpInst::ICMP_SGT &&
3183 match(D, m_AllOnes()))
3184 return new ICmpInst(CmpInst::ICMP_SGE, Op0, C);
3185
3186 // icmp sle X, (Y + -1) -> icmp slt X, Y
3187 if (C && NoOp1WrapProblem && Pred == CmpInst::ICMP_SLE &&
3188 match(D, m_AllOnes()))
3189 return new ICmpInst(CmpInst::ICMP_SLT, Op0, C);
3190
3191 // icmp sge X, (Y + 1) -> icmp sgt X, Y
3192 if (C && NoOp1WrapProblem && Pred == CmpInst::ICMP_SGE && match(D, m_One()))
3193 return new ICmpInst(CmpInst::ICMP_SGT, Op0, C);
3194
3195 // icmp slt X, (Y + 1) -> icmp sle X, Y
3196 if (C && NoOp1WrapProblem && Pred == CmpInst::ICMP_SLT && match(D, m_One()))
3197 return new ICmpInst(CmpInst::ICMP_SLE, Op0, C);
3198
Sanjay Patel40f40172017-01-13 23:25:46 +00003199 // TODO: The subtraction-related identities shown below also hold, but
3200 // canonicalization from (X -nuw 1) to (X + -1) means that the combinations
3201 // wouldn't happen even if they were implemented.
3202 //
3203 // icmp ult (X - 1), Y -> icmp ule X, Y
3204 // icmp uge (X - 1), Y -> icmp ugt X, Y
3205 // icmp ugt X, (Y - 1) -> icmp uge X, Y
3206 // icmp ule X, (Y - 1) -> icmp ult X, Y
3207
3208 // icmp ule (X + 1), Y -> icmp ult X, Y
3209 if (A && NoOp0WrapProblem && Pred == CmpInst::ICMP_ULE && match(B, m_One()))
3210 return new ICmpInst(CmpInst::ICMP_ULT, A, Op1);
3211
3212 // icmp ugt (X + 1), Y -> icmp uge X, Y
3213 if (A && NoOp0WrapProblem && Pred == CmpInst::ICMP_UGT && match(B, m_One()))
3214 return new ICmpInst(CmpInst::ICMP_UGE, A, Op1);
3215
3216 // icmp uge X, (Y + 1) -> icmp ugt X, Y
3217 if (C && NoOp1WrapProblem && Pred == CmpInst::ICMP_UGE && match(D, m_One()))
3218 return new ICmpInst(CmpInst::ICMP_UGT, Op0, C);
3219
3220 // icmp ult X, (Y + 1) -> icmp ule X, Y
3221 if (C && NoOp1WrapProblem && Pred == CmpInst::ICMP_ULT && match(D, m_One()))
3222 return new ICmpInst(CmpInst::ICMP_ULE, Op0, C);
3223
Sanjay Patel10494b22016-09-16 16:10:22 +00003224 // if C1 has greater magnitude than C2:
3225 // icmp (X + C1), (Y + C2) -> icmp (X + C3), Y
3226 // s.t. C3 = C1 - C2
3227 //
3228 // if C2 has greater magnitude than C1:
3229 // icmp (X + C1), (Y + C2) -> icmp X, (Y + C3)
3230 // s.t. C3 = C2 - C1
3231 if (A && C && NoOp0WrapProblem && NoOp1WrapProblem &&
3232 (BO0->hasOneUse() || BO1->hasOneUse()) && !I.isUnsigned())
3233 if (ConstantInt *C1 = dyn_cast<ConstantInt>(B))
3234 if (ConstantInt *C2 = dyn_cast<ConstantInt>(D)) {
3235 const APInt &AP1 = C1->getValue();
3236 const APInt &AP2 = C2->getValue();
3237 if (AP1.isNegative() == AP2.isNegative()) {
3238 APInt AP1Abs = C1->getValue().abs();
3239 APInt AP2Abs = C2->getValue().abs();
3240 if (AP1Abs.uge(AP2Abs)) {
Craig Topperbb4069e2017-07-07 23:16:26 +00003241 ConstantInt *C3 = Builder.getInt(AP1 - AP2);
3242 Value *NewAdd = Builder.CreateNSWAdd(A, C3);
Sanjay Patel10494b22016-09-16 16:10:22 +00003243 return new ICmpInst(Pred, NewAdd, C);
3244 } else {
Craig Topperbb4069e2017-07-07 23:16:26 +00003245 ConstantInt *C3 = Builder.getInt(AP2 - AP1);
3246 Value *NewAdd = Builder.CreateNSWAdd(C, C3);
Sanjay Patel10494b22016-09-16 16:10:22 +00003247 return new ICmpInst(Pred, A, NewAdd);
3248 }
3249 }
3250 }
3251
3252 // Analyze the case when either Op0 or Op1 is a sub instruction.
3253 // Op0 = A - B (or A and B are null); Op1 = C - D (or C and D are null).
3254 A = nullptr;
3255 B = nullptr;
3256 C = nullptr;
3257 D = nullptr;
3258 if (BO0 && BO0->getOpcode() == Instruction::Sub) {
3259 A = BO0->getOperand(0);
3260 B = BO0->getOperand(1);
3261 }
3262 if (BO1 && BO1->getOpcode() == Instruction::Sub) {
3263 C = BO1->getOperand(0);
3264 D = BO1->getOperand(1);
3265 }
3266
3267 // icmp (X-Y), X -> icmp 0, Y for equalities or if there is no overflow.
3268 if (A == Op1 && NoOp0WrapProblem)
3269 return new ICmpInst(Pred, Constant::getNullValue(Op1->getType()), B);
Sanjay Patel10494b22016-09-16 16:10:22 +00003270 // icmp X, (X-Y) -> icmp Y, 0 for equalities or if there is no overflow.
3271 if (C == Op0 && NoOp1WrapProblem)
3272 return new ICmpInst(Pred, D, Constant::getNullValue(Op0->getType()));
3273
Sanjay Patelcbb04502018-04-02 20:37:40 +00003274 // (A - B) >u A --> A <u B
3275 if (A == Op1 && Pred == ICmpInst::ICMP_UGT)
3276 return new ICmpInst(ICmpInst::ICMP_ULT, A, B);
3277 // C <u (C - D) --> C <u D
3278 if (C == Op0 && Pred == ICmpInst::ICMP_ULT)
3279 return new ICmpInst(ICmpInst::ICMP_ULT, C, D);
3280
Sanjay Patel10494b22016-09-16 16:10:22 +00003281 // icmp (Y-X), (Z-X) -> icmp Y, Z for equalities or if there is no overflow.
3282 if (B && D && B == D && NoOp0WrapProblem && NoOp1WrapProblem &&
3283 // Try not to increase register pressure.
3284 BO0->hasOneUse() && BO1->hasOneUse())
3285 return new ICmpInst(Pred, A, C);
Sanjay Patel10494b22016-09-16 16:10:22 +00003286 // icmp (X-Y), (X-Z) -> icmp Z, Y for equalities or if there is no overflow.
3287 if (A && C && A == C && NoOp0WrapProblem && NoOp1WrapProblem &&
3288 // Try not to increase register pressure.
3289 BO0->hasOneUse() && BO1->hasOneUse())
3290 return new ICmpInst(Pred, D, B);
3291
3292 // icmp (0-X) < cst --> x > -cst
3293 if (NoOp0WrapProblem && ICmpInst::isSigned(Pred)) {
3294 Value *X;
3295 if (match(BO0, m_Neg(m_Value(X))))
Chen Zhengb9722732018-07-16 00:51:40 +00003296 if (Constant *RHSC = dyn_cast<Constant>(Op1))
3297 if (RHSC->isNotMinSignedValue())
Sanjay Patel10494b22016-09-16 16:10:22 +00003298 return new ICmpInst(I.getSwappedPredicate(), X,
3299 ConstantExpr::getNeg(RHSC));
3300 }
3301
3302 BinaryOperator *SRem = nullptr;
3303 // icmp (srem X, Y), Y
3304 if (BO0 && BO0->getOpcode() == Instruction::SRem && Op1 == BO0->getOperand(1))
3305 SRem = BO0;
3306 // icmp Y, (srem X, Y)
3307 else if (BO1 && BO1->getOpcode() == Instruction::SRem &&
3308 Op0 == BO1->getOperand(1))
3309 SRem = BO1;
3310 if (SRem) {
3311 // We don't check hasOneUse to avoid increasing register pressure because
3312 // the value we use is the same value this instruction was already using.
3313 switch (SRem == BO0 ? ICmpInst::getSwappedPredicate(Pred) : Pred) {
3314 default:
3315 break;
3316 case ICmpInst::ICMP_EQ:
3317 return replaceInstUsesWith(I, ConstantInt::getFalse(I.getType()));
3318 case ICmpInst::ICMP_NE:
3319 return replaceInstUsesWith(I, ConstantInt::getTrue(I.getType()));
3320 case ICmpInst::ICMP_SGT:
3321 case ICmpInst::ICMP_SGE:
3322 return new ICmpInst(ICmpInst::ICMP_SGT, SRem->getOperand(1),
3323 Constant::getAllOnesValue(SRem->getType()));
3324 case ICmpInst::ICMP_SLT:
3325 case ICmpInst::ICMP_SLE:
3326 return new ICmpInst(ICmpInst::ICMP_SLT, SRem->getOperand(1),
3327 Constant::getNullValue(SRem->getType()));
3328 }
3329 }
3330
3331 if (BO0 && BO1 && BO0->getOpcode() == BO1->getOpcode() && BO0->hasOneUse() &&
3332 BO1->hasOneUse() && BO0->getOperand(1) == BO1->getOperand(1)) {
3333 switch (BO0->getOpcode()) {
3334 default:
3335 break;
3336 case Instruction::Add:
3337 case Instruction::Sub:
Sanjay Pateld3106ad2017-05-23 17:29:58 +00003338 case Instruction::Xor: {
Sanjay Patel10494b22016-09-16 16:10:22 +00003339 if (I.isEquality()) // a+x icmp eq/ne b+x --> a icmp b
Sanjay Patel2a062632017-05-08 16:33:42 +00003340 return new ICmpInst(Pred, BO0->getOperand(0), BO1->getOperand(0));
Sanjay Pateld3106ad2017-05-23 17:29:58 +00003341
3342 const APInt *C;
3343 if (match(BO0->getOperand(1), m_APInt(C))) {
3344 // icmp u/s (a ^ signmask), (b ^ signmask) --> icmp s/u a, b
3345 if (C->isSignMask()) {
Sanjay Patel2a062632017-05-08 16:33:42 +00003346 ICmpInst::Predicate NewPred =
Sanjay Patel10494b22016-09-16 16:10:22 +00003347 I.isSigned() ? I.getUnsignedPredicate() : I.getSignedPredicate();
Sanjay Patel2a062632017-05-08 16:33:42 +00003348 return new ICmpInst(NewPred, BO0->getOperand(0), BO1->getOperand(0));
Sanjay Patel10494b22016-09-16 16:10:22 +00003349 }
3350
Sanjay Pateld3106ad2017-05-23 17:29:58 +00003351 // icmp u/s (a ^ maxsignval), (b ^ maxsignval) --> icmp s/u' a, b
3352 if (BO0->getOpcode() == Instruction::Xor && C->isMaxSignedValue()) {
Sanjay Patel2a062632017-05-08 16:33:42 +00003353 ICmpInst::Predicate NewPred =
Sanjay Patel10494b22016-09-16 16:10:22 +00003354 I.isSigned() ? I.getUnsignedPredicate() : I.getSignedPredicate();
Sanjay Patel2a062632017-05-08 16:33:42 +00003355 NewPred = I.getSwappedPredicate(NewPred);
3356 return new ICmpInst(NewPred, BO0->getOperand(0), BO1->getOperand(0));
Sanjay Patel10494b22016-09-16 16:10:22 +00003357 }
3358 }
3359 break;
Sanjay Pateld3106ad2017-05-23 17:29:58 +00003360 }
Sanjay Patel07b1ba52017-05-24 22:58:17 +00003361 case Instruction::Mul: {
Sanjay Patel10494b22016-09-16 16:10:22 +00003362 if (!I.isEquality())
3363 break;
3364
Sanjay Patel07b1ba52017-05-24 22:58:17 +00003365 const APInt *C;
Craig Topper73ba1c82017-06-07 07:40:37 +00003366 if (match(BO0->getOperand(1), m_APInt(C)) && !C->isNullValue() &&
3367 !C->isOneValue()) {
Sanjay Patel07b1ba52017-05-24 22:58:17 +00003368 // icmp eq/ne (X * C), (Y * C) --> icmp (X & Mask), (Y & Mask)
3369 // Mask = -1 >> count-trailing-zeros(C).
Sanjay Patel51506122017-05-25 14:13:57 +00003370 if (unsigned TZs = C->countTrailingZeros()) {
Sanjay Patel07b1ba52017-05-24 22:58:17 +00003371 Constant *Mask = ConstantInt::get(
3372 BO0->getType(),
Sanjay Patel51506122017-05-25 14:13:57 +00003373 APInt::getLowBitsSet(C->getBitWidth(), C->getBitWidth() - TZs));
Craig Topperbb4069e2017-07-07 23:16:26 +00003374 Value *And1 = Builder.CreateAnd(BO0->getOperand(0), Mask);
3375 Value *And2 = Builder.CreateAnd(BO1->getOperand(0), Mask);
Sanjay Patel2a062632017-05-08 16:33:42 +00003376 return new ICmpInst(Pred, And1, And2);
Sanjay Patel10494b22016-09-16 16:10:22 +00003377 }
Sanjay Patel51506122017-05-25 14:13:57 +00003378 // If there are no trailing zeros in the multiplier, just eliminate
3379 // the multiplies (no masking is needed):
3380 // icmp eq/ne (X * C), (Y * C) --> icmp eq/ne X, Y
3381 return new ICmpInst(Pred, BO0->getOperand(0), BO1->getOperand(0));
Sanjay Patel10494b22016-09-16 16:10:22 +00003382 }
3383 break;
Sanjay Patel07b1ba52017-05-24 22:58:17 +00003384 }
Sanjay Patel10494b22016-09-16 16:10:22 +00003385 case Instruction::UDiv:
3386 case Instruction::LShr:
Sanjay Patel878715f2017-05-15 19:27:53 +00003387 if (I.isSigned() || !BO0->isExact() || !BO1->isExact())
Sanjay Patel10494b22016-09-16 16:10:22 +00003388 break;
Sanjay Patel878715f2017-05-15 19:27:53 +00003389 return new ICmpInst(Pred, BO0->getOperand(0), BO1->getOperand(0));
3390
Sanjay Patel10494b22016-09-16 16:10:22 +00003391 case Instruction::SDiv:
Sanjay Patel878715f2017-05-15 19:27:53 +00003392 if (!I.isEquality() || !BO0->isExact() || !BO1->isExact())
3393 break;
3394 return new ICmpInst(Pred, BO0->getOperand(0), BO1->getOperand(0));
3395
Sanjay Patel10494b22016-09-16 16:10:22 +00003396 case Instruction::AShr:
3397 if (!BO0->isExact() || !BO1->isExact())
3398 break;
Sanjay Patel2a062632017-05-08 16:33:42 +00003399 return new ICmpInst(Pred, BO0->getOperand(0), BO1->getOperand(0));
Sanjay Patel878715f2017-05-15 19:27:53 +00003400
Sanjay Patel10494b22016-09-16 16:10:22 +00003401 case Instruction::Shl: {
3402 bool NUW = BO0->hasNoUnsignedWrap() && BO1->hasNoUnsignedWrap();
3403 bool NSW = BO0->hasNoSignedWrap() && BO1->hasNoSignedWrap();
3404 if (!NUW && !NSW)
3405 break;
3406 if (!NSW && I.isSigned())
3407 break;
Sanjay Patel2a062632017-05-08 16:33:42 +00003408 return new ICmpInst(Pred, BO0->getOperand(0), BO1->getOperand(0));
Sanjay Patel10494b22016-09-16 16:10:22 +00003409 }
3410 }
3411 }
3412
3413 if (BO0) {
3414 // Transform A & (L - 1) `ult` L --> L != 0
3415 auto LSubOne = m_Add(m_Specific(Op1), m_AllOnes());
Craig Topper72ee6942017-06-24 06:24:01 +00003416 auto BitwiseAnd = m_c_And(m_Value(), LSubOne);
Sanjay Patel10494b22016-09-16 16:10:22 +00003417
Sanjay Patel2a062632017-05-08 16:33:42 +00003418 if (match(BO0, BitwiseAnd) && Pred == ICmpInst::ICMP_ULT) {
Sanjay Patel10494b22016-09-16 16:10:22 +00003419 auto *Zero = Constant::getNullValue(BO0->getType());
3420 return new ICmpInst(ICmpInst::ICMP_NE, Op1, Zero);
3421 }
3422 }
3423
Roman Lebedev68d54cf2018-07-11 19:05:04 +00003424 if (Value *V = foldICmpWithLowBitMaskedVal(I, Builder))
3425 return replaceInstUsesWith(I, V);
3426
Roman Lebedev3cb87e92018-07-18 10:55:17 +00003427 if (Value *V = foldICmpWithTruncSignExtendedVal(I, Builder))
3428 return replaceInstUsesWith(I, V);
3429
Sanjay Patel10494b22016-09-16 16:10:22 +00003430 return nullptr;
3431}
3432
Sanjay Pateldd46b522016-12-19 17:32:37 +00003433/// Fold icmp Pred min|max(X, Y), X.
3434static Instruction *foldICmpWithMinMax(ICmpInst &Cmp) {
Sanjay Pateld6406412016-12-15 19:13:37 +00003435 ICmpInst::Predicate Pred = Cmp.getPredicate();
3436 Value *Op0 = Cmp.getOperand(0);
3437 Value *X = Cmp.getOperand(1);
3438
Sanjay Pateldd46b522016-12-19 17:32:37 +00003439 // Canonicalize minimum or maximum operand to LHS of the icmp.
Sanjay Patel8296c6c2016-12-19 16:28:53 +00003440 if (match(X, m_c_SMin(m_Specific(Op0), m_Value())) ||
Sanjay Pateldd46b522016-12-19 17:32:37 +00003441 match(X, m_c_SMax(m_Specific(Op0), m_Value())) ||
3442 match(X, m_c_UMin(m_Specific(Op0), m_Value())) ||
3443 match(X, m_c_UMax(m_Specific(Op0), m_Value()))) {
Sanjay Pateld6406412016-12-15 19:13:37 +00003444 std::swap(Op0, X);
3445 Pred = Cmp.getSwappedPredicate();
3446 }
3447
3448 Value *Y;
Sanjay Patel8296c6c2016-12-19 16:28:53 +00003449 if (match(Op0, m_c_SMin(m_Specific(X), m_Value(Y)))) {
Sanjay Pateldd46b522016-12-19 17:32:37 +00003450 // smin(X, Y) == X --> X s<= Y
3451 // smin(X, Y) s>= X --> X s<= Y
Sanjay Patel8296c6c2016-12-19 16:28:53 +00003452 if (Pred == CmpInst::ICMP_EQ || Pred == CmpInst::ICMP_SGE)
3453 return new ICmpInst(ICmpInst::ICMP_SLE, X, Y);
3454
Sanjay Pateldd46b522016-12-19 17:32:37 +00003455 // smin(X, Y) != X --> X s> Y
3456 // smin(X, Y) s< X --> X s> Y
Sanjay Patel8296c6c2016-12-19 16:28:53 +00003457 if (Pred == CmpInst::ICMP_NE || Pred == CmpInst::ICMP_SLT)
3458 return new ICmpInst(ICmpInst::ICMP_SGT, X, Y);
3459
3460 // These cases should be handled in InstSimplify:
Sanjay Pateldd46b522016-12-19 17:32:37 +00003461 // smin(X, Y) s<= X --> true
3462 // smin(X, Y) s> X --> false
Sanjay Pateld6406412016-12-15 19:13:37 +00003463 return nullptr;
Sanjay Patel8296c6c2016-12-19 16:28:53 +00003464 }
Sanjay Pateldd46b522016-12-19 17:32:37 +00003465
Sanjay Patel8296c6c2016-12-19 16:28:53 +00003466 if (match(Op0, m_c_SMax(m_Specific(X), m_Value(Y)))) {
Sanjay Pateldd46b522016-12-19 17:32:37 +00003467 // smax(X, Y) == X --> X s>= Y
3468 // smax(X, Y) s<= X --> X s>= Y
Sanjay Patel8296c6c2016-12-19 16:28:53 +00003469 if (Pred == CmpInst::ICMP_EQ || Pred == CmpInst::ICMP_SLE)
3470 return new ICmpInst(ICmpInst::ICMP_SGE, X, Y);
Sanjay Pateld6406412016-12-15 19:13:37 +00003471
Sanjay Pateldd46b522016-12-19 17:32:37 +00003472 // smax(X, Y) != X --> X s< Y
3473 // smax(X, Y) s> X --> X s< Y
Sanjay Patel8296c6c2016-12-19 16:28:53 +00003474 if (Pred == CmpInst::ICMP_NE || Pred == CmpInst::ICMP_SGT)
3475 return new ICmpInst(ICmpInst::ICMP_SLT, X, Y);
Sanjay Pateld6406412016-12-15 19:13:37 +00003476
Sanjay Patel8296c6c2016-12-19 16:28:53 +00003477 // These cases should be handled in InstSimplify:
Sanjay Pateldd46b522016-12-19 17:32:37 +00003478 // smax(X, Y) s>= X --> true
3479 // smax(X, Y) s< X --> false
3480 return nullptr;
3481 }
3482
3483 if (match(Op0, m_c_UMin(m_Specific(X), m_Value(Y)))) {
3484 // umin(X, Y) == X --> X u<= Y
3485 // umin(X, Y) u>= X --> X u<= Y
3486 if (Pred == CmpInst::ICMP_EQ || Pred == CmpInst::ICMP_UGE)
3487 return new ICmpInst(ICmpInst::ICMP_ULE, X, Y);
3488
3489 // umin(X, Y) != X --> X u> Y
3490 // umin(X, Y) u< X --> X u> Y
3491 if (Pred == CmpInst::ICMP_NE || Pred == CmpInst::ICMP_ULT)
3492 return new ICmpInst(ICmpInst::ICMP_UGT, X, Y);
3493
3494 // These cases should be handled in InstSimplify:
3495 // umin(X, Y) u<= X --> true
3496 // umin(X, Y) u> X --> false
3497 return nullptr;
3498 }
3499
3500 if (match(Op0, m_c_UMax(m_Specific(X), m_Value(Y)))) {
3501 // umax(X, Y) == X --> X u>= Y
3502 // umax(X, Y) u<= X --> X u>= Y
3503 if (Pred == CmpInst::ICMP_EQ || Pred == CmpInst::ICMP_ULE)
3504 return new ICmpInst(ICmpInst::ICMP_UGE, X, Y);
3505
3506 // umax(X, Y) != X --> X u< Y
3507 // umax(X, Y) u> X --> X u< Y
3508 if (Pred == CmpInst::ICMP_NE || Pred == CmpInst::ICMP_UGT)
3509 return new ICmpInst(ICmpInst::ICMP_ULT, X, Y);
3510
3511 // These cases should be handled in InstSimplify:
3512 // umax(X, Y) u>= X --> true
3513 // umax(X, Y) u< X --> false
Sanjay Patel8296c6c2016-12-19 16:28:53 +00003514 return nullptr;
3515 }
Sanjay Pateld6406412016-12-15 19:13:37 +00003516
Sanjay Pateld6406412016-12-15 19:13:37 +00003517 return nullptr;
3518}
3519
Sanjay Patel10494b22016-09-16 16:10:22 +00003520Instruction *InstCombiner::foldICmpEquality(ICmpInst &I) {
3521 if (!I.isEquality())
3522 return nullptr;
3523
3524 Value *Op0 = I.getOperand(0), *Op1 = I.getOperand(1);
Sanjay Patel4e96f192017-06-28 16:39:06 +00003525 const CmpInst::Predicate Pred = I.getPredicate();
Sanjay Patel10494b22016-09-16 16:10:22 +00003526 Value *A, *B, *C, *D;
3527 if (match(Op0, m_Xor(m_Value(A), m_Value(B)))) {
3528 if (A == Op1 || B == Op1) { // (A^B) == A -> B == 0
3529 Value *OtherVal = A == Op1 ? B : A;
Sanjay Patel4e96f192017-06-28 16:39:06 +00003530 return new ICmpInst(Pred, OtherVal, Constant::getNullValue(A->getType()));
Sanjay Patel10494b22016-09-16 16:10:22 +00003531 }
3532
3533 if (match(Op1, m_Xor(m_Value(C), m_Value(D)))) {
3534 // A^c1 == C^c2 --> A == C^(c1^c2)
3535 ConstantInt *C1, *C2;
3536 if (match(B, m_ConstantInt(C1)) && match(D, m_ConstantInt(C2)) &&
3537 Op1->hasOneUse()) {
Craig Topperbb4069e2017-07-07 23:16:26 +00003538 Constant *NC = Builder.getInt(C1->getValue() ^ C2->getValue());
3539 Value *Xor = Builder.CreateXor(C, NC);
Sanjay Patel4e96f192017-06-28 16:39:06 +00003540 return new ICmpInst(Pred, A, Xor);
Sanjay Patel10494b22016-09-16 16:10:22 +00003541 }
3542
3543 // A^B == A^D -> B == D
3544 if (A == C)
Sanjay Patel4e96f192017-06-28 16:39:06 +00003545 return new ICmpInst(Pred, B, D);
Sanjay Patel10494b22016-09-16 16:10:22 +00003546 if (A == D)
Sanjay Patel4e96f192017-06-28 16:39:06 +00003547 return new ICmpInst(Pred, B, C);
Sanjay Patel10494b22016-09-16 16:10:22 +00003548 if (B == C)
Sanjay Patel4e96f192017-06-28 16:39:06 +00003549 return new ICmpInst(Pred, A, D);
Sanjay Patel10494b22016-09-16 16:10:22 +00003550 if (B == D)
Sanjay Patel4e96f192017-06-28 16:39:06 +00003551 return new ICmpInst(Pred, A, C);
Sanjay Patel10494b22016-09-16 16:10:22 +00003552 }
3553 }
3554
3555 if (match(Op1, m_Xor(m_Value(A), m_Value(B))) && (A == Op0 || B == Op0)) {
3556 // A == (A^B) -> B == 0
3557 Value *OtherVal = A == Op0 ? B : A;
Sanjay Patel4e96f192017-06-28 16:39:06 +00003558 return new ICmpInst(Pred, OtherVal, Constant::getNullValue(A->getType()));
Sanjay Patel10494b22016-09-16 16:10:22 +00003559 }
3560
3561 // (X&Z) == (Y&Z) -> (X^Y) & Z == 0
3562 if (match(Op0, m_OneUse(m_And(m_Value(A), m_Value(B)))) &&
3563 match(Op1, m_OneUse(m_And(m_Value(C), m_Value(D))))) {
3564 Value *X = nullptr, *Y = nullptr, *Z = nullptr;
3565
3566 if (A == C) {
3567 X = B;
3568 Y = D;
3569 Z = A;
3570 } else if (A == D) {
3571 X = B;
3572 Y = C;
3573 Z = A;
3574 } else if (B == C) {
3575 X = A;
3576 Y = D;
3577 Z = B;
3578 } else if (B == D) {
3579 X = A;
3580 Y = C;
3581 Z = B;
3582 }
3583
3584 if (X) { // Build (X^Y) & Z
Craig Topperbb4069e2017-07-07 23:16:26 +00003585 Op1 = Builder.CreateXor(X, Y);
3586 Op1 = Builder.CreateAnd(Op1, Z);
Sanjay Patel10494b22016-09-16 16:10:22 +00003587 I.setOperand(0, Op1);
3588 I.setOperand(1, Constant::getNullValue(Op1->getType()));
3589 return &I;
3590 }
3591 }
3592
3593 // Transform (zext A) == (B & (1<<X)-1) --> A == (trunc B)
3594 // and (B & (1<<X)-1) == (zext A) --> A == (trunc B)
3595 ConstantInt *Cst1;
3596 if ((Op0->hasOneUse() && match(Op0, m_ZExt(m_Value(A))) &&
3597 match(Op1, m_And(m_Value(B), m_ConstantInt(Cst1)))) ||
3598 (Op1->hasOneUse() && match(Op0, m_And(m_Value(B), m_ConstantInt(Cst1))) &&
3599 match(Op1, m_ZExt(m_Value(A))))) {
3600 APInt Pow2 = Cst1->getValue() + 1;
3601 if (Pow2.isPowerOf2() && isa<IntegerType>(A->getType()) &&
3602 Pow2.logBase2() == cast<IntegerType>(A->getType())->getBitWidth())
Craig Topperbb4069e2017-07-07 23:16:26 +00003603 return new ICmpInst(Pred, A, Builder.CreateTrunc(B, A->getType()));
Sanjay Patel10494b22016-09-16 16:10:22 +00003604 }
3605
3606 // (A >> C) == (B >> C) --> (A^B) u< (1 << C)
3607 // For lshr and ashr pairs.
3608 if ((match(Op0, m_OneUse(m_LShr(m_Value(A), m_ConstantInt(Cst1)))) &&
3609 match(Op1, m_OneUse(m_LShr(m_Value(B), m_Specific(Cst1))))) ||
3610 (match(Op0, m_OneUse(m_AShr(m_Value(A), m_ConstantInt(Cst1)))) &&
3611 match(Op1, m_OneUse(m_AShr(m_Value(B), m_Specific(Cst1)))))) {
3612 unsigned TypeBits = Cst1->getBitWidth();
3613 unsigned ShAmt = (unsigned)Cst1->getLimitedValue(TypeBits);
3614 if (ShAmt < TypeBits && ShAmt != 0) {
Sanjay Patel4e96f192017-06-28 16:39:06 +00003615 ICmpInst::Predicate NewPred =
3616 Pred == ICmpInst::ICMP_NE ? ICmpInst::ICMP_UGE : ICmpInst::ICMP_ULT;
Craig Topperbb4069e2017-07-07 23:16:26 +00003617 Value *Xor = Builder.CreateXor(A, B, I.getName() + ".unshifted");
Sanjay Patel10494b22016-09-16 16:10:22 +00003618 APInt CmpVal = APInt::getOneBitSet(TypeBits, ShAmt);
Craig Topperbb4069e2017-07-07 23:16:26 +00003619 return new ICmpInst(NewPred, Xor, Builder.getInt(CmpVal));
Sanjay Patel10494b22016-09-16 16:10:22 +00003620 }
3621 }
3622
3623 // (A << C) == (B << C) --> ((A^B) & (~0U >> C)) == 0
3624 if (match(Op0, m_OneUse(m_Shl(m_Value(A), m_ConstantInt(Cst1)))) &&
3625 match(Op1, m_OneUse(m_Shl(m_Value(B), m_Specific(Cst1))))) {
3626 unsigned TypeBits = Cst1->getBitWidth();
3627 unsigned ShAmt = (unsigned)Cst1->getLimitedValue(TypeBits);
3628 if (ShAmt < TypeBits && ShAmt != 0) {
Craig Topperbb4069e2017-07-07 23:16:26 +00003629 Value *Xor = Builder.CreateXor(A, B, I.getName() + ".unshifted");
Sanjay Patel10494b22016-09-16 16:10:22 +00003630 APInt AndVal = APInt::getLowBitsSet(TypeBits, TypeBits - ShAmt);
Craig Topperbb4069e2017-07-07 23:16:26 +00003631 Value *And = Builder.CreateAnd(Xor, Builder.getInt(AndVal),
Sanjay Patel10494b22016-09-16 16:10:22 +00003632 I.getName() + ".mask");
Sanjay Patel4e96f192017-06-28 16:39:06 +00003633 return new ICmpInst(Pred, And, Constant::getNullValue(Cst1->getType()));
Sanjay Patel10494b22016-09-16 16:10:22 +00003634 }
3635 }
3636
3637 // Transform "icmp eq (trunc (lshr(X, cst1)), cst" to
3638 // "icmp (and X, mask), cst"
3639 uint64_t ShAmt = 0;
3640 if (Op0->hasOneUse() &&
3641 match(Op0, m_Trunc(m_OneUse(m_LShr(m_Value(A), m_ConstantInt(ShAmt))))) &&
3642 match(Op1, m_ConstantInt(Cst1)) &&
3643 // Only do this when A has multiple uses. This is most important to do
3644 // when it exposes other optimizations.
3645 !A->hasOneUse()) {
3646 unsigned ASize = cast<IntegerType>(A->getType())->getPrimitiveSizeInBits();
3647
3648 if (ShAmt < ASize) {
3649 APInt MaskV =
3650 APInt::getLowBitsSet(ASize, Op0->getType()->getPrimitiveSizeInBits());
3651 MaskV <<= ShAmt;
3652
3653 APInt CmpV = Cst1->getValue().zext(ASize);
3654 CmpV <<= ShAmt;
3655
Craig Topperbb4069e2017-07-07 23:16:26 +00003656 Value *Mask = Builder.CreateAnd(A, Builder.getInt(MaskV));
3657 return new ICmpInst(Pred, Mask, Builder.getInt(CmpV));
Sanjay Patel10494b22016-09-16 16:10:22 +00003658 }
3659 }
3660
Sanjay Patelc3d5cf02017-07-02 14:34:50 +00003661 // If both operands are byte-swapped or bit-reversed, just compare the
3662 // original values.
3663 // TODO: Move this to a function similar to foldICmpIntrinsicWithConstant()
3664 // and handle more intrinsics.
3665 if ((match(Op0, m_BSwap(m_Value(A))) && match(Op1, m_BSwap(m_Value(B)))) ||
Simon Pilgrimdf2657a2017-07-02 16:31:16 +00003666 (match(Op0, m_BitReverse(m_Value(A))) &&
3667 match(Op1, m_BitReverse(m_Value(B)))))
Sanjay Patelc3d5cf02017-07-02 14:34:50 +00003668 return new ICmpInst(Pred, A, B);
3669
Sanjay Patel10494b22016-09-16 16:10:22 +00003670 return nullptr;
3671}
3672
Sanjay Patel6f8f47b2016-06-05 00:12:32 +00003673/// Handle icmp (cast x to y), (cast/cst). We only handle extending casts so
3674/// far.
Sanjay Patel43395062016-07-21 18:07:40 +00003675Instruction *InstCombiner::foldICmpWithCastAndCast(ICmpInst &ICmp) {
Sanjay Patel6f8f47b2016-06-05 00:12:32 +00003676 const CastInst *LHSCI = cast<CastInst>(ICmp.getOperand(0));
Chris Lattner2188e402010-01-04 07:37:31 +00003677 Value *LHSCIOp = LHSCI->getOperand(0);
Chris Lattner229907c2011-07-18 04:54:35 +00003678 Type *SrcTy = LHSCIOp->getType();
3679 Type *DestTy = LHSCI->getType();
Chris Lattner2188e402010-01-04 07:37:31 +00003680 Value *RHSCIOp;
3681
Jim Grosbach129c52a2011-09-30 18:09:53 +00003682 // Turn icmp (ptrtoint x), (ptrtoint/c) into a compare of the input if the
Chris Lattner2188e402010-01-04 07:37:31 +00003683 // integer type is the same size as the pointer type.
Daniel Neilsonbdda1152018-03-05 18:05:51 +00003684 const auto& CompatibleSizes = [&](Type* SrcTy, Type* DestTy) -> bool {
3685 if (isa<VectorType>(SrcTy)) {
3686 SrcTy = cast<VectorType>(SrcTy)->getElementType();
3687 DestTy = cast<VectorType>(DestTy)->getElementType();
3688 }
3689 return DL.getPointerTypeSizeInBits(SrcTy) == DestTy->getIntegerBitWidth();
3690 };
Mehdi Aminia28d91d2015-03-10 02:37:25 +00003691 if (LHSCI->getOpcode() == Instruction::PtrToInt &&
Daniel Neilsonbdda1152018-03-05 18:05:51 +00003692 CompatibleSizes(SrcTy, DestTy)) {
Craig Topperf40110f2014-04-25 05:29:35 +00003693 Value *RHSOp = nullptr;
Sanjay Patel6f8f47b2016-06-05 00:12:32 +00003694 if (auto *RHSC = dyn_cast<PtrToIntOperator>(ICmp.getOperand(1))) {
Michael Liaod266b922015-02-13 04:51:26 +00003695 Value *RHSCIOp = RHSC->getOperand(0);
3696 if (RHSCIOp->getType()->getPointerAddressSpace() ==
3697 LHSCIOp->getType()->getPointerAddressSpace()) {
3698 RHSOp = RHSC->getOperand(0);
3699 // If the pointer types don't match, insert a bitcast.
3700 if (LHSCIOp->getType() != RHSOp->getType())
Craig Topperbb4069e2017-07-07 23:16:26 +00003701 RHSOp = Builder.CreateBitCast(RHSOp, LHSCIOp->getType());
Michael Liaod266b922015-02-13 04:51:26 +00003702 }
Sanjay Patel6f8f47b2016-06-05 00:12:32 +00003703 } else if (auto *RHSC = dyn_cast<Constant>(ICmp.getOperand(1))) {
Chris Lattner2188e402010-01-04 07:37:31 +00003704 RHSOp = ConstantExpr::getIntToPtr(RHSC, SrcTy);
Sanjay Patel6f8f47b2016-06-05 00:12:32 +00003705 }
Chris Lattner2188e402010-01-04 07:37:31 +00003706
3707 if (RHSOp)
Sanjay Patel6f8f47b2016-06-05 00:12:32 +00003708 return new ICmpInst(ICmp.getPredicate(), LHSCIOp, RHSOp);
Chris Lattner2188e402010-01-04 07:37:31 +00003709 }
Jim Grosbach129c52a2011-09-30 18:09:53 +00003710
Chris Lattner2188e402010-01-04 07:37:31 +00003711 // The code below only handles extension cast instructions, so far.
3712 // Enforce this.
3713 if (LHSCI->getOpcode() != Instruction::ZExt &&
3714 LHSCI->getOpcode() != Instruction::SExt)
Craig Topperf40110f2014-04-25 05:29:35 +00003715 return nullptr;
Chris Lattner2188e402010-01-04 07:37:31 +00003716
3717 bool isSignedExt = LHSCI->getOpcode() == Instruction::SExt;
Sanjay Patel6f8f47b2016-06-05 00:12:32 +00003718 bool isSignedCmp = ICmp.isSigned();
Chris Lattner2188e402010-01-04 07:37:31 +00003719
Sanjay Patel6f8f47b2016-06-05 00:12:32 +00003720 if (auto *CI = dyn_cast<CastInst>(ICmp.getOperand(1))) {
Chris Lattner2188e402010-01-04 07:37:31 +00003721 // Not an extension from the same type?
3722 RHSCIOp = CI->getOperand(0);
Jim Grosbach129c52a2011-09-30 18:09:53 +00003723 if (RHSCIOp->getType() != LHSCIOp->getType())
Craig Topperf40110f2014-04-25 05:29:35 +00003724 return nullptr;
Jim Grosbach129c52a2011-09-30 18:09:53 +00003725
Chris Lattner2188e402010-01-04 07:37:31 +00003726 // If the signedness of the two casts doesn't agree (i.e. one is a sext
3727 // and the other is a zext), then we can't handle this.
3728 if (CI->getOpcode() != LHSCI->getOpcode())
Craig Topperf40110f2014-04-25 05:29:35 +00003729 return nullptr;
Chris Lattner2188e402010-01-04 07:37:31 +00003730
3731 // Deal with equality cases early.
Sanjay Patel6f8f47b2016-06-05 00:12:32 +00003732 if (ICmp.isEquality())
3733 return new ICmpInst(ICmp.getPredicate(), LHSCIOp, RHSCIOp);
Chris Lattner2188e402010-01-04 07:37:31 +00003734
3735 // A signed comparison of sign extended values simplifies into a
3736 // signed comparison.
3737 if (isSignedCmp && isSignedExt)
Sanjay Patel6f8f47b2016-06-05 00:12:32 +00003738 return new ICmpInst(ICmp.getPredicate(), LHSCIOp, RHSCIOp);
Chris Lattner2188e402010-01-04 07:37:31 +00003739
3740 // The other three cases all fold into an unsigned comparison.
Sanjay Patel6f8f47b2016-06-05 00:12:32 +00003741 return new ICmpInst(ICmp.getUnsignedPredicate(), LHSCIOp, RHSCIOp);
Chris Lattner2188e402010-01-04 07:37:31 +00003742 }
3743
Sanjay Patel4c204232016-06-04 20:39:22 +00003744 // If we aren't dealing with a constant on the RHS, exit early.
Sanjay Patel6f8f47b2016-06-05 00:12:32 +00003745 auto *C = dyn_cast<Constant>(ICmp.getOperand(1));
3746 if (!C)
Craig Topperf40110f2014-04-25 05:29:35 +00003747 return nullptr;
Chris Lattner2188e402010-01-04 07:37:31 +00003748
3749 // Compute the constant that would happen if we truncated to SrcTy then
Sanjay Patelc774f8c2016-06-04 21:20:44 +00003750 // re-extended to DestTy.
Sanjay Patel6f8f47b2016-06-05 00:12:32 +00003751 Constant *Res1 = ConstantExpr::getTrunc(C, SrcTy);
Sanjay Patelc774f8c2016-06-04 21:20:44 +00003752 Constant *Res2 = ConstantExpr::getCast(LHSCI->getOpcode(), Res1, DestTy);
Chris Lattner2188e402010-01-04 07:37:31 +00003753
3754 // If the re-extended constant didn't change...
Sanjay Patel6f8f47b2016-06-05 00:12:32 +00003755 if (Res2 == C) {
Chris Lattner2188e402010-01-04 07:37:31 +00003756 // Deal with equality cases early.
Sanjay Patel6f8f47b2016-06-05 00:12:32 +00003757 if (ICmp.isEquality())
3758 return new ICmpInst(ICmp.getPredicate(), LHSCIOp, Res1);
Chris Lattner2188e402010-01-04 07:37:31 +00003759
3760 // A signed comparison of sign extended values simplifies into a
3761 // signed comparison.
3762 if (isSignedExt && isSignedCmp)
Sanjay Patel6f8f47b2016-06-05 00:12:32 +00003763 return new ICmpInst(ICmp.getPredicate(), LHSCIOp, Res1);
Chris Lattner2188e402010-01-04 07:37:31 +00003764
3765 // The other three cases all fold into an unsigned comparison.
Sanjay Patel6f8f47b2016-06-05 00:12:32 +00003766 return new ICmpInst(ICmp.getUnsignedPredicate(), LHSCIOp, Res1);
Chris Lattner2188e402010-01-04 07:37:31 +00003767 }
3768
Sanjay Patel6a333c32016-06-06 16:56:57 +00003769 // The re-extended constant changed, partly changed (in the case of a vector),
3770 // or could not be determined to be equal (in the case of a constant
3771 // expression), so the constant cannot be represented in the shorter type.
3772 // Consequently, we cannot emit a simple comparison.
Duncan Sands8fb2c382011-01-20 13:21:55 +00003773 // All the cases that fold to true or false will have already been handled
3774 // by SimplifyICmpInst, so only deal with the tricky case.
Chris Lattner2188e402010-01-04 07:37:31 +00003775
Sanjay Patel6a333c32016-06-06 16:56:57 +00003776 if (isSignedCmp || !isSignedExt || !isa<ConstantInt>(C))
Craig Topperf40110f2014-04-25 05:29:35 +00003777 return nullptr;
Chris Lattner2188e402010-01-04 07:37:31 +00003778
3779 // Evaluate the comparison for LT (we invert for GT below). LE and GE cases
3780 // should have been folded away previously and not enter in here.
Duncan Sands8fb2c382011-01-20 13:21:55 +00003781
3782 // We're performing an unsigned comp with a sign extended value.
3783 // This is true if the input is >= 0. [aka >s -1]
3784 Constant *NegOne = Constant::getAllOnesValue(SrcTy);
Craig Topperbb4069e2017-07-07 23:16:26 +00003785 Value *Result = Builder.CreateICmpSGT(LHSCIOp, NegOne, ICmp.getName());
Chris Lattner2188e402010-01-04 07:37:31 +00003786
3787 // Finally, return the value computed.
Sanjay Patel6f8f47b2016-06-05 00:12:32 +00003788 if (ICmp.getPredicate() == ICmpInst::ICMP_ULT)
3789 return replaceInstUsesWith(ICmp, Result);
Chris Lattner2188e402010-01-04 07:37:31 +00003790
Sanjay Patel6f8f47b2016-06-05 00:12:32 +00003791 assert(ICmp.getPredicate() == ICmpInst::ICMP_UGT && "ICmp should be folded!");
Chris Lattner2188e402010-01-04 07:37:31 +00003792 return BinaryOperator::CreateNot(Result);
3793}
3794
Sanjoy Dasb0984472015-04-08 04:27:22 +00003795bool InstCombiner::OptimizeOverflowCheck(OverflowCheckFlavor OCF, Value *LHS,
3796 Value *RHS, Instruction &OrigI,
3797 Value *&Result, Constant *&Overflow) {
Sanjoy Das827529e2015-08-11 21:33:55 +00003798 if (OrigI.isCommutative() && isa<Constant>(LHS) && !isa<Constant>(RHS))
3799 std::swap(LHS, RHS);
Sanjoy Dasb0984472015-04-08 04:27:22 +00003800
3801 auto SetResult = [&](Value *OpResult, Constant *OverflowVal, bool ReuseName) {
3802 Result = OpResult;
3803 Overflow = OverflowVal;
3804 if (ReuseName)
3805 Result->takeName(&OrigI);
3806 return true;
3807 };
3808
Sanjoy Das6f5dca72015-08-28 19:09:31 +00003809 // If the overflow check was an add followed by a compare, the insertion point
3810 // may be pointing to the compare. We want to insert the new instructions
3811 // before the add in case there are uses of the add between the add and the
3812 // compare.
Craig Topperbb4069e2017-07-07 23:16:26 +00003813 Builder.SetInsertPoint(&OrigI);
Sanjoy Das6f5dca72015-08-28 19:09:31 +00003814
Sanjoy Dasb0984472015-04-08 04:27:22 +00003815 switch (OCF) {
3816 case OCF_INVALID:
3817 llvm_unreachable("bad overflow check kind!");
3818
3819 case OCF_UNSIGNED_ADD: {
3820 OverflowResult OR = computeOverflowForUnsignedAdd(LHS, RHS, &OrigI);
3821 if (OR == OverflowResult::NeverOverflows)
Craig Topperbb4069e2017-07-07 23:16:26 +00003822 return SetResult(Builder.CreateNUWAdd(LHS, RHS), Builder.getFalse(),
Sanjoy Dasb0984472015-04-08 04:27:22 +00003823 true);
3824
3825 if (OR == OverflowResult::AlwaysOverflows)
Craig Topperbb4069e2017-07-07 23:16:26 +00003826 return SetResult(Builder.CreateAdd(LHS, RHS), Builder.getTrue(), true);
Justin Bognercd1d5aa2016-08-17 20:30:52 +00003827
3828 // Fall through uadd into sadd
3829 LLVM_FALLTHROUGH;
Sanjoy Dasb0984472015-04-08 04:27:22 +00003830 }
Sanjoy Dasb0984472015-04-08 04:27:22 +00003831 case OCF_SIGNED_ADD: {
David Majnemer27e89ba2015-05-21 23:04:21 +00003832 // X + 0 -> {X, false}
3833 if (match(RHS, m_Zero()))
Craig Topperbb4069e2017-07-07 23:16:26 +00003834 return SetResult(LHS, Builder.getFalse(), false);
Sanjoy Dasb0984472015-04-08 04:27:22 +00003835
3836 // We can strength reduce this signed add into a regular add if we can prove
3837 // that it will never overflow.
3838 if (OCF == OCF_SIGNED_ADD)
Craig Topper2b1fc322017-05-22 06:25:31 +00003839 if (willNotOverflowSignedAdd(LHS, RHS, OrigI))
Craig Topperbb4069e2017-07-07 23:16:26 +00003840 return SetResult(Builder.CreateNSWAdd(LHS, RHS), Builder.getFalse(),
Sanjoy Dasb0984472015-04-08 04:27:22 +00003841 true);
Sanjoy Das72cb5e12015-06-05 18:04:42 +00003842 break;
Sanjoy Dasb0984472015-04-08 04:27:22 +00003843 }
3844
3845 case OCF_UNSIGNED_SUB:
3846 case OCF_SIGNED_SUB: {
David Majnemer27e89ba2015-05-21 23:04:21 +00003847 // X - 0 -> {X, false}
3848 if (match(RHS, m_Zero()))
Craig Topperbb4069e2017-07-07 23:16:26 +00003849 return SetResult(LHS, Builder.getFalse(), false);
Sanjoy Dasb0984472015-04-08 04:27:22 +00003850
3851 if (OCF == OCF_SIGNED_SUB) {
Craig Topper2b1fc322017-05-22 06:25:31 +00003852 if (willNotOverflowSignedSub(LHS, RHS, OrigI))
Craig Topperbb4069e2017-07-07 23:16:26 +00003853 return SetResult(Builder.CreateNSWSub(LHS, RHS), Builder.getFalse(),
Sanjoy Dasb0984472015-04-08 04:27:22 +00003854 true);
3855 } else {
Craig Topper2b1fc322017-05-22 06:25:31 +00003856 if (willNotOverflowUnsignedSub(LHS, RHS, OrigI))
Craig Topperbb4069e2017-07-07 23:16:26 +00003857 return SetResult(Builder.CreateNUWSub(LHS, RHS), Builder.getFalse(),
Sanjoy Dasb0984472015-04-08 04:27:22 +00003858 true);
3859 }
3860 break;
3861 }
3862
3863 case OCF_UNSIGNED_MUL: {
3864 OverflowResult OR = computeOverflowForUnsignedMul(LHS, RHS, &OrigI);
3865 if (OR == OverflowResult::NeverOverflows)
Craig Topperbb4069e2017-07-07 23:16:26 +00003866 return SetResult(Builder.CreateNUWMul(LHS, RHS), Builder.getFalse(),
Sanjoy Dasb0984472015-04-08 04:27:22 +00003867 true);
3868 if (OR == OverflowResult::AlwaysOverflows)
Craig Topperbb4069e2017-07-07 23:16:26 +00003869 return SetResult(Builder.CreateMul(LHS, RHS), Builder.getTrue(), true);
Justin Bognercd1d5aa2016-08-17 20:30:52 +00003870 LLVM_FALLTHROUGH;
3871 }
Sanjoy Dasb0984472015-04-08 04:27:22 +00003872 case OCF_SIGNED_MUL:
3873 // X * undef -> undef
3874 if (isa<UndefValue>(RHS))
Craig Topperbb4069e2017-07-07 23:16:26 +00003875 return SetResult(RHS, UndefValue::get(Builder.getInt1Ty()), false);
Sanjoy Dasb0984472015-04-08 04:27:22 +00003876
David Majnemer27e89ba2015-05-21 23:04:21 +00003877 // X * 0 -> {0, false}
3878 if (match(RHS, m_Zero()))
Craig Topperbb4069e2017-07-07 23:16:26 +00003879 return SetResult(RHS, Builder.getFalse(), false);
Sanjoy Dasb0984472015-04-08 04:27:22 +00003880
David Majnemer27e89ba2015-05-21 23:04:21 +00003881 // X * 1 -> {X, false}
3882 if (match(RHS, m_One()))
Craig Topperbb4069e2017-07-07 23:16:26 +00003883 return SetResult(LHS, Builder.getFalse(), false);
Sanjoy Dasb0984472015-04-08 04:27:22 +00003884
3885 if (OCF == OCF_SIGNED_MUL)
Craig Topper2b1fc322017-05-22 06:25:31 +00003886 if (willNotOverflowSignedMul(LHS, RHS, OrigI))
Craig Topperbb4069e2017-07-07 23:16:26 +00003887 return SetResult(Builder.CreateNSWMul(LHS, RHS), Builder.getFalse(),
Sanjoy Dasb0984472015-04-08 04:27:22 +00003888 true);
Sanjoy Dasc80dad62015-06-05 18:04:46 +00003889 break;
Sanjoy Dasb0984472015-04-08 04:27:22 +00003890 }
3891
3892 return false;
3893}
3894
Adrian Prantl5f8f34e42018-05-01 15:54:18 +00003895/// Recognize and process idiom involving test for multiplication
Serge Pavlov4bb54d52014-04-13 18:23:41 +00003896/// overflow.
3897///
3898/// The caller has matched a pattern of the form:
3899/// I = cmp u (mul(zext A, zext B), V
3900/// The function checks if this is a test for overflow and if so replaces
3901/// multiplication with call to 'mul.with.overflow' intrinsic.
3902///
3903/// \param I Compare instruction.
3904/// \param MulVal Result of 'mult' instruction. It is one of the arguments of
3905/// the compare instruction. Must be of integer type.
3906/// \param OtherVal The other argument of compare instruction.
3907/// \returns Instruction which must replace the compare instruction, NULL if no
3908/// replacement required.
Sanjay Pateld93c4c02016-09-15 18:22:25 +00003909static Instruction *processUMulZExtIdiom(ICmpInst &I, Value *MulVal,
Serge Pavlov4bb54d52014-04-13 18:23:41 +00003910 Value *OtherVal, InstCombiner &IC) {
Benjamin Kramerc96a7f82014-06-24 10:47:52 +00003911 // Don't bother doing this transformation for pointers, don't do it for
3912 // vectors.
3913 if (!isa<IntegerType>(MulVal->getType()))
3914 return nullptr;
3915
Serge Pavlov4bb54d52014-04-13 18:23:41 +00003916 assert(I.getOperand(0) == MulVal || I.getOperand(1) == MulVal);
3917 assert(I.getOperand(0) == OtherVal || I.getOperand(1) == OtherVal);
David Majnemerdaa24b92015-09-05 20:44:56 +00003918 auto *MulInstr = dyn_cast<Instruction>(MulVal);
3919 if (!MulInstr)
3920 return nullptr;
Serge Pavlov4bb54d52014-04-13 18:23:41 +00003921 assert(MulInstr->getOpcode() == Instruction::Mul);
3922
David Majnemer634ca232014-11-01 23:46:05 +00003923 auto *LHS = cast<ZExtOperator>(MulInstr->getOperand(0)),
3924 *RHS = cast<ZExtOperator>(MulInstr->getOperand(1));
Serge Pavlov4bb54d52014-04-13 18:23:41 +00003925 assert(LHS->getOpcode() == Instruction::ZExt);
3926 assert(RHS->getOpcode() == Instruction::ZExt);
3927 Value *A = LHS->getOperand(0), *B = RHS->getOperand(0);
3928
3929 // Calculate type and width of the result produced by mul.with.overflow.
3930 Type *TyA = A->getType(), *TyB = B->getType();
3931 unsigned WidthA = TyA->getPrimitiveSizeInBits(),
3932 WidthB = TyB->getPrimitiveSizeInBits();
3933 unsigned MulWidth;
3934 Type *MulType;
3935 if (WidthB > WidthA) {
3936 MulWidth = WidthB;
3937 MulType = TyB;
3938 } else {
3939 MulWidth = WidthA;
3940 MulType = TyA;
3941 }
3942
3943 // In order to replace the original mul with a narrower mul.with.overflow,
3944 // all uses must ignore upper bits of the product. The number of used low
3945 // bits must be not greater than the width of mul.with.overflow.
3946 if (MulVal->hasNUsesOrMore(2))
3947 for (User *U : MulVal->users()) {
3948 if (U == &I)
3949 continue;
3950 if (TruncInst *TI = dyn_cast<TruncInst>(U)) {
3951 // Check if truncation ignores bits above MulWidth.
3952 unsigned TruncWidth = TI->getType()->getPrimitiveSizeInBits();
3953 if (TruncWidth > MulWidth)
Craig Topperf40110f2014-04-25 05:29:35 +00003954 return nullptr;
Serge Pavlov4bb54d52014-04-13 18:23:41 +00003955 } else if (BinaryOperator *BO = dyn_cast<BinaryOperator>(U)) {
3956 // Check if AND ignores bits above MulWidth.
3957 if (BO->getOpcode() != Instruction::And)
Craig Topperf40110f2014-04-25 05:29:35 +00003958 return nullptr;
Serge Pavlov4bb54d52014-04-13 18:23:41 +00003959 if (ConstantInt *CI = dyn_cast<ConstantInt>(BO->getOperand(1))) {
3960 const APInt &CVal = CI->getValue();
3961 if (CVal.getBitWidth() - CVal.countLeadingZeros() > MulWidth)
Craig Topperf40110f2014-04-25 05:29:35 +00003962 return nullptr;
Davide Italiano579064e2017-07-16 18:56:30 +00003963 } else {
3964 // In this case we could have the operand of the binary operation
3965 // being defined in another block, and performing the replacement
3966 // could break the dominance relation.
3967 return nullptr;
Serge Pavlov4bb54d52014-04-13 18:23:41 +00003968 }
3969 } else {
3970 // Other uses prohibit this transformation.
Craig Topperf40110f2014-04-25 05:29:35 +00003971 return nullptr;
Serge Pavlov4bb54d52014-04-13 18:23:41 +00003972 }
3973 }
3974
3975 // Recognize patterns
3976 switch (I.getPredicate()) {
3977 case ICmpInst::ICMP_EQ:
3978 case ICmpInst::ICMP_NE:
3979 // Recognize pattern:
3980 // mulval = mul(zext A, zext B)
3981 // cmp eq/neq mulval, zext trunc mulval
3982 if (ZExtInst *Zext = dyn_cast<ZExtInst>(OtherVal))
3983 if (Zext->hasOneUse()) {
3984 Value *ZextArg = Zext->getOperand(0);
3985 if (TruncInst *Trunc = dyn_cast<TruncInst>(ZextArg))
3986 if (Trunc->getType()->getPrimitiveSizeInBits() == MulWidth)
3987 break; //Recognized
3988 }
3989
3990 // Recognize pattern:
3991 // mulval = mul(zext A, zext B)
3992 // cmp eq/neq mulval, and(mulval, mask), mask selects low MulWidth bits.
3993 ConstantInt *CI;
3994 Value *ValToMask;
3995 if (match(OtherVal, m_And(m_Value(ValToMask), m_ConstantInt(CI)))) {
3996 if (ValToMask != MulVal)
Craig Topperf40110f2014-04-25 05:29:35 +00003997 return nullptr;
Serge Pavlov4bb54d52014-04-13 18:23:41 +00003998 const APInt &CVal = CI->getValue() + 1;
3999 if (CVal.isPowerOf2()) {
4000 unsigned MaskWidth = CVal.logBase2();
4001 if (MaskWidth == MulWidth)
4002 break; // Recognized
4003 }
4004 }
Craig Topperf40110f2014-04-25 05:29:35 +00004005 return nullptr;
Serge Pavlov4bb54d52014-04-13 18:23:41 +00004006
4007 case ICmpInst::ICMP_UGT:
4008 // Recognize pattern:
4009 // mulval = mul(zext A, zext B)
4010 // cmp ugt mulval, max
4011 if (ConstantInt *CI = dyn_cast<ConstantInt>(OtherVal)) {
4012 APInt MaxVal = APInt::getMaxValue(MulWidth);
4013 MaxVal = MaxVal.zext(CI->getBitWidth());
4014 if (MaxVal.eq(CI->getValue()))
4015 break; // Recognized
4016 }
Craig Topperf40110f2014-04-25 05:29:35 +00004017 return nullptr;
Serge Pavlov4bb54d52014-04-13 18:23:41 +00004018
4019 case ICmpInst::ICMP_UGE:
4020 // Recognize pattern:
4021 // mulval = mul(zext A, zext B)
4022 // cmp uge mulval, max+1
4023 if (ConstantInt *CI = dyn_cast<ConstantInt>(OtherVal)) {
4024 APInt MaxVal = APInt::getOneBitSet(CI->getBitWidth(), MulWidth);
4025 if (MaxVal.eq(CI->getValue()))
4026 break; // Recognized
4027 }
Craig Topperf40110f2014-04-25 05:29:35 +00004028 return nullptr;
Serge Pavlov4bb54d52014-04-13 18:23:41 +00004029
4030 case ICmpInst::ICMP_ULE:
4031 // Recognize pattern:
4032 // mulval = mul(zext A, zext B)
4033 // cmp ule mulval, max
4034 if (ConstantInt *CI = dyn_cast<ConstantInt>(OtherVal)) {
4035 APInt MaxVal = APInt::getMaxValue(MulWidth);
4036 MaxVal = MaxVal.zext(CI->getBitWidth());
4037 if (MaxVal.eq(CI->getValue()))
4038 break; // Recognized
4039 }
Craig Topperf40110f2014-04-25 05:29:35 +00004040 return nullptr;
Serge Pavlov4bb54d52014-04-13 18:23:41 +00004041
4042 case ICmpInst::ICMP_ULT:
4043 // Recognize pattern:
4044 // mulval = mul(zext A, zext B)
4045 // cmp ule mulval, max + 1
4046 if (ConstantInt *CI = dyn_cast<ConstantInt>(OtherVal)) {
Serge Pavlovb5f3ddc2014-04-14 02:20:19 +00004047 APInt MaxVal = APInt::getOneBitSet(CI->getBitWidth(), MulWidth);
Serge Pavlov4bb54d52014-04-13 18:23:41 +00004048 if (MaxVal.eq(CI->getValue()))
4049 break; // Recognized
4050 }
Craig Topperf40110f2014-04-25 05:29:35 +00004051 return nullptr;
Serge Pavlov4bb54d52014-04-13 18:23:41 +00004052
4053 default:
Craig Topperf40110f2014-04-25 05:29:35 +00004054 return nullptr;
Serge Pavlov4bb54d52014-04-13 18:23:41 +00004055 }
4056
Craig Topperbb4069e2017-07-07 23:16:26 +00004057 InstCombiner::BuilderTy &Builder = IC.Builder;
4058 Builder.SetInsertPoint(MulInstr);
Serge Pavlov4bb54d52014-04-13 18:23:41 +00004059
4060 // Replace: mul(zext A, zext B) --> mul.with.overflow(A, B)
4061 Value *MulA = A, *MulB = B;
4062 if (WidthA < MulWidth)
Craig Topperbb4069e2017-07-07 23:16:26 +00004063 MulA = Builder.CreateZExt(A, MulType);
Serge Pavlov4bb54d52014-04-13 18:23:41 +00004064 if (WidthB < MulWidth)
Craig Topperbb4069e2017-07-07 23:16:26 +00004065 MulB = Builder.CreateZExt(B, MulType);
Sanjay Patelaf674fb2015-12-14 17:24:23 +00004066 Value *F = Intrinsic::getDeclaration(I.getModule(),
4067 Intrinsic::umul_with_overflow, MulType);
Craig Topperbb4069e2017-07-07 23:16:26 +00004068 CallInst *Call = Builder.CreateCall(F, {MulA, MulB}, "umul");
Serge Pavlov4bb54d52014-04-13 18:23:41 +00004069 IC.Worklist.Add(MulInstr);
4070
4071 // If there are uses of mul result other than the comparison, we know that
4072 // they are truncation or binary AND. Change them to use result of
Serge Pavlovb5f3ddc2014-04-14 02:20:19 +00004073 // mul.with.overflow and adjust properly mask/size.
Serge Pavlov4bb54d52014-04-13 18:23:41 +00004074 if (MulVal->hasNUsesOrMore(2)) {
Craig Topperbb4069e2017-07-07 23:16:26 +00004075 Value *Mul = Builder.CreateExtractValue(Call, 0, "umul.value");
Joseph Tremoulet6f406d42018-06-15 16:52:40 +00004076 for (auto UI = MulVal->user_begin(), UE = MulVal->user_end(); UI != UE;) {
4077 User *U = *UI++;
Serge Pavlov4bb54d52014-04-13 18:23:41 +00004078 if (U == &I || U == OtherVal)
4079 continue;
4080 if (TruncInst *TI = dyn_cast<TruncInst>(U)) {
4081 if (TI->getType()->getPrimitiveSizeInBits() == MulWidth)
Sanjay Patel4b198802016-02-01 22:23:39 +00004082 IC.replaceInstUsesWith(*TI, Mul);
Serge Pavlov4bb54d52014-04-13 18:23:41 +00004083 else
4084 TI->setOperand(0, Mul);
4085 } else if (BinaryOperator *BO = dyn_cast<BinaryOperator>(U)) {
4086 assert(BO->getOpcode() == Instruction::And);
4087 // Replace (mul & mask) --> zext (mul.with.overflow & short_mask)
Davide Italiano579064e2017-07-16 18:56:30 +00004088 ConstantInt *CI = cast<ConstantInt>(BO->getOperand(1));
4089 APInt ShortMask = CI->getValue().trunc(MulWidth);
Craig Topperbb4069e2017-07-07 23:16:26 +00004090 Value *ShortAnd = Builder.CreateAnd(Mul, ShortMask);
Davide Italiano579064e2017-07-16 18:56:30 +00004091 Instruction *Zext =
4092 cast<Instruction>(Builder.CreateZExt(ShortAnd, BO->getType()));
4093 IC.Worklist.Add(Zext);
Sanjay Patel4b198802016-02-01 22:23:39 +00004094 IC.replaceInstUsesWith(*BO, Zext);
Serge Pavlov4bb54d52014-04-13 18:23:41 +00004095 } else {
4096 llvm_unreachable("Unexpected Binary operation");
4097 }
Davide Italiano579064e2017-07-16 18:56:30 +00004098 IC.Worklist.Add(cast<Instruction>(U));
Serge Pavlov4bb54d52014-04-13 18:23:41 +00004099 }
4100 }
4101 if (isa<Instruction>(OtherVal))
4102 IC.Worklist.Add(cast<Instruction>(OtherVal));
4103
4104 // The original icmp gets replaced with the overflow value, maybe inverted
4105 // depending on predicate.
4106 bool Inverse = false;
4107 switch (I.getPredicate()) {
4108 case ICmpInst::ICMP_NE:
4109 break;
4110 case ICmpInst::ICMP_EQ:
4111 Inverse = true;
4112 break;
4113 case ICmpInst::ICMP_UGT:
4114 case ICmpInst::ICMP_UGE:
4115 if (I.getOperand(0) == MulVal)
4116 break;
4117 Inverse = true;
4118 break;
4119 case ICmpInst::ICMP_ULT:
4120 case ICmpInst::ICMP_ULE:
4121 if (I.getOperand(1) == MulVal)
4122 break;
4123 Inverse = true;
4124 break;
4125 default:
4126 llvm_unreachable("Unexpected predicate");
4127 }
4128 if (Inverse) {
Craig Topperbb4069e2017-07-07 23:16:26 +00004129 Value *Res = Builder.CreateExtractValue(Call, 1);
Serge Pavlov4bb54d52014-04-13 18:23:41 +00004130 return BinaryOperator::CreateNot(Res);
4131 }
4132
4133 return ExtractValueInst::Create(Call, 1);
4134}
4135
Sanjay Patel5f0217f2016-06-05 16:46:18 +00004136/// When performing a comparison against a constant, it is possible that not all
4137/// the bits in the LHS are demanded. This helper method computes the mask that
4138/// IS demanded.
Craig Topper3edda872017-09-22 18:57:23 +00004139static APInt getDemandedBitsLHSMask(ICmpInst &I, unsigned BitWidth) {
Craig Topper18887bf2017-09-20 23:48:58 +00004140 const APInt *RHS;
4141 if (!match(I.getOperand(1), m_APInt(RHS)))
4142 return APInt::getAllOnesValue(BitWidth);
Jim Grosbach129c52a2011-09-30 18:09:53 +00004143
Craig Topper3edda872017-09-22 18:57:23 +00004144 // If this is a normal comparison, it demands all bits. If it is a sign bit
4145 // comparison, it only demands the sign bit.
4146 bool UnusedBit;
4147 if (isSignBitCheck(I.getPredicate(), *RHS, UnusedBit))
4148 return APInt::getSignMask(BitWidth);
4149
Owen Andersond490c2d2011-01-11 00:36:45 +00004150 switch (I.getPredicate()) {
Jim Grosbach129c52a2011-09-30 18:09:53 +00004151 // For a UGT comparison, we don't care about any bits that
Owen Andersond490c2d2011-01-11 00:36:45 +00004152 // correspond to the trailing ones of the comparand. The value of these
4153 // bits doesn't impact the outcome of the comparison, because any value
4154 // greater than the RHS must differ in a bit higher than these due to carry.
Craig Topper18887bf2017-09-20 23:48:58 +00004155 case ICmpInst::ICMP_UGT:
4156 return APInt::getBitsSetFrom(BitWidth, RHS->countTrailingOnes());
Jim Grosbach129c52a2011-09-30 18:09:53 +00004157
Owen Andersond490c2d2011-01-11 00:36:45 +00004158 // Similarly, for a ULT comparison, we don't care about the trailing zeros.
4159 // Any value less than the RHS must differ in a higher bit because of carries.
Craig Topper18887bf2017-09-20 23:48:58 +00004160 case ICmpInst::ICMP_ULT:
4161 return APInt::getBitsSetFrom(BitWidth, RHS->countTrailingZeros());
Jim Grosbach129c52a2011-09-30 18:09:53 +00004162
Owen Andersond490c2d2011-01-11 00:36:45 +00004163 default:
4164 return APInt::getAllOnesValue(BitWidth);
4165 }
Owen Andersond490c2d2011-01-11 00:36:45 +00004166}
Chris Lattner2188e402010-01-04 07:37:31 +00004167
Sanjay Patel4ccae1c2018-02-02 18:39:05 +00004168/// Check if the order of \p Op0 and \p Op1 as operands in an ICmpInst
Quentin Colombet5ab55552013-09-09 20:56:48 +00004169/// should be swapped.
Alp Tokercb402912014-01-24 17:20:08 +00004170/// The decision is based on how many times these two operands are reused
Quentin Colombet5ab55552013-09-09 20:56:48 +00004171/// as subtract operands and their positions in those instructions.
Sanjay Patel4ccae1c2018-02-02 18:39:05 +00004172/// The rationale is that several architectures use the same instruction for
4173/// both subtract and cmp. Thus, it is better if the order of those operands
Quentin Colombet5ab55552013-09-09 20:56:48 +00004174/// match.
4175/// \return true if Op0 and Op1 should be swapped.
Sanjay Patel4ccae1c2018-02-02 18:39:05 +00004176static bool swapMayExposeCSEOpportunities(const Value *Op0, const Value *Op1) {
4177 // Filter out pointer values as those cannot appear directly in subtract.
Quentin Colombet5ab55552013-09-09 20:56:48 +00004178 // FIXME: we may want to go through inttoptrs or bitcasts.
4179 if (Op0->getType()->isPointerTy())
4180 return false;
Sanjay Patel1ea86972018-02-02 19:08:12 +00004181 // If a subtract already has the same operands as a compare, swapping would be
4182 // bad. If a subtract has the same operands as a compare but in reverse order,
4183 // then swapping is good.
4184 int GoodToSwap = 0;
Chandler Carruthcdf47882014-03-09 03:16:01 +00004185 for (const User *U : Op0->users()) {
Sanjay Patel1ea86972018-02-02 19:08:12 +00004186 if (match(U, m_Sub(m_Specific(Op1), m_Specific(Op0))))
4187 GoodToSwap++;
4188 else if (match(U, m_Sub(m_Specific(Op0), m_Specific(Op1))))
4189 GoodToSwap--;
Quentin Colombet5ab55552013-09-09 20:56:48 +00004190 }
Sanjay Patel1ea86972018-02-02 19:08:12 +00004191 return GoodToSwap > 0;
Quentin Colombet5ab55552013-09-09 20:56:48 +00004192}
4193
Adrian Prantl5f8f34e42018-05-01 15:54:18 +00004194/// Check that one use is in the same block as the definition and all
Sanjay Patel53523312016-09-12 14:25:46 +00004195/// other uses are in blocks dominated by a given block.
Gerolf Hoflehnerec6217c2014-11-21 23:36:44 +00004196///
4197/// \param DI Definition
4198/// \param UI Use
4199/// \param DB Block that must dominate all uses of \p DI outside
4200/// the parent block
4201/// \return true when \p UI is the only use of \p DI in the parent block
4202/// and all other uses of \p DI are in blocks dominated by \p DB.
4203///
4204bool InstCombiner::dominatesAllUses(const Instruction *DI,
4205 const Instruction *UI,
4206 const BasicBlock *DB) const {
4207 assert(DI && UI && "Instruction not defined\n");
Sanjay Patel53523312016-09-12 14:25:46 +00004208 // Ignore incomplete definitions.
Gerolf Hoflehnerec6217c2014-11-21 23:36:44 +00004209 if (!DI->getParent())
4210 return false;
Sanjay Patel53523312016-09-12 14:25:46 +00004211 // DI and UI must be in the same block.
Gerolf Hoflehnerec6217c2014-11-21 23:36:44 +00004212 if (DI->getParent() != UI->getParent())
4213 return false;
Sanjay Patel53523312016-09-12 14:25:46 +00004214 // Protect from self-referencing blocks.
Gerolf Hoflehnerec6217c2014-11-21 23:36:44 +00004215 if (DI->getParent() == DB)
4216 return false;
Gerolf Hoflehnerec6217c2014-11-21 23:36:44 +00004217 for (const User *U : DI->users()) {
4218 auto *Usr = cast<Instruction>(U);
Justin Bogner99798402016-08-05 01:06:44 +00004219 if (Usr != UI && !DT.dominates(DB, Usr->getParent()))
Gerolf Hoflehnerec6217c2014-11-21 23:36:44 +00004220 return false;
4221 }
4222 return true;
4223}
4224
Sanjay Patel5f0217f2016-06-05 16:46:18 +00004225/// Return true when the instruction sequence within a block is select-cmp-br.
Gerolf Hoflehnerec6217c2014-11-21 23:36:44 +00004226static bool isChainSelectCmpBranch(const SelectInst *SI) {
4227 const BasicBlock *BB = SI->getParent();
4228 if (!BB)
4229 return false;
4230 auto *BI = dyn_cast_or_null<BranchInst>(BB->getTerminator());
4231 if (!BI || BI->getNumSuccessors() != 2)
4232 return false;
4233 auto *IC = dyn_cast<ICmpInst>(BI->getCondition());
4234 if (!IC || (IC->getOperand(0) != SI && IC->getOperand(1) != SI))
4235 return false;
4236 return true;
4237}
4238
Adrian Prantl5f8f34e42018-05-01 15:54:18 +00004239/// True when a select result is replaced by one of its operands
Gerolf Hoflehnerec6217c2014-11-21 23:36:44 +00004240/// in select-icmp sequence. This will eventually result in the elimination
4241/// of the select.
4242///
4243/// \param SI Select instruction
4244/// \param Icmp Compare instruction
4245/// \param SIOpd Operand that replaces the select
4246///
4247/// Notes:
4248/// - The replacement is global and requires dominator information
4249/// - The caller is responsible for the actual replacement
4250///
4251/// Example:
4252///
4253/// entry:
4254/// %4 = select i1 %3, %C* %0, %C* null
4255/// %5 = icmp eq %C* %4, null
4256/// br i1 %5, label %9, label %7
4257/// ...
4258/// ; <label>:7 ; preds = %entry
4259/// %8 = getelementptr inbounds %C* %4, i64 0, i32 0
4260/// ...
4261///
4262/// can be transformed to
4263///
4264/// %5 = icmp eq %C* %0, null
4265/// %6 = select i1 %3, i1 %5, i1 true
4266/// br i1 %6, label %9, label %7
4267/// ...
4268/// ; <label>:7 ; preds = %entry
4269/// %8 = getelementptr inbounds %C* %0, i64 0, i32 0 // replace by %0!
4270///
4271/// Similar when the first operand of the select is a constant or/and
4272/// the compare is for not equal rather than equal.
4273///
4274/// NOTE: The function is only called when the select and compare constants
4275/// are equal, the optimization can work only for EQ predicates. This is not a
4276/// major restriction since a NE compare should be 'normalized' to an equal
4277/// compare, which usually happens in the combiner and test case
Sanjay Patel53523312016-09-12 14:25:46 +00004278/// select-cmp-br.ll checks for it.
Gerolf Hoflehnerec6217c2014-11-21 23:36:44 +00004279bool InstCombiner::replacedSelectWithOperand(SelectInst *SI,
4280 const ICmpInst *Icmp,
4281 const unsigned SIOpd) {
David Majnemer83484fd2014-11-22 06:09:28 +00004282 assert((SIOpd == 1 || SIOpd == 2) && "Invalid select operand!");
Gerolf Hoflehnerec6217c2014-11-21 23:36:44 +00004283 if (isChainSelectCmpBranch(SI) && Icmp->getPredicate() == ICmpInst::ICMP_EQ) {
4284 BasicBlock *Succ = SI->getParent()->getTerminator()->getSuccessor(1);
Bjorn Petterssone5027cf2017-03-02 15:18:58 +00004285 // The check for the single predecessor is not the best that can be
Sanjay Patel53523312016-09-12 14:25:46 +00004286 // done. But it protects efficiently against cases like when SI's
Gerolf Hoflehnerec6217c2014-11-21 23:36:44 +00004287 // home block has two successors, Succ and Succ1, and Succ1 predecessor
4288 // of Succ. Then SI can't be replaced by SIOpd because the use that gets
4289 // replaced can be reached on either path. So the uniqueness check
4290 // guarantees that the path all uses of SI (outside SI's parent) are on
4291 // is disjoint from all other paths out of SI. But that information
4292 // is more expensive to compute, and the trade-off here is in favor
Bjorn Petterssone5027cf2017-03-02 15:18:58 +00004293 // of compile-time. It should also be noticed that we check for a single
4294 // predecessor and not only uniqueness. This to handle the situation when
4295 // Succ and Succ1 points to the same basic block.
4296 if (Succ->getSinglePredecessor() && dominatesAllUses(SI, Icmp, Succ)) {
Gerolf Hoflehnerec6217c2014-11-21 23:36:44 +00004297 NumSel++;
4298 SI->replaceUsesOutsideBlock(SI->getOperand(SIOpd), SI->getParent());
4299 return true;
4300 }
4301 }
4302 return false;
4303}
4304
Sanjay Patel3151dec2016-09-12 15:24:31 +00004305/// Try to fold the comparison based on range information we can get by checking
4306/// whether bits are known to be zero or one in the inputs.
4307Instruction *InstCombiner::foldICmpUsingKnownBits(ICmpInst &I) {
4308 Value *Op0 = I.getOperand(0), *Op1 = I.getOperand(1);
4309 Type *Ty = Op0->getType();
Sanjay Patel0531f0a2016-09-12 15:52:28 +00004310 ICmpInst::Predicate Pred = I.getPredicate();
Sanjay Patel3151dec2016-09-12 15:24:31 +00004311
4312 // Get scalar or pointer size.
4313 unsigned BitWidth = Ty->isIntOrIntVectorTy()
4314 ? Ty->getScalarSizeInBits()
Elena Demikhovsky945b7e52018-02-14 06:58:08 +00004315 : DL.getIndexTypeSizeInBits(Ty->getScalarType());
Sanjay Patel3151dec2016-09-12 15:24:31 +00004316
4317 if (!BitWidth)
4318 return nullptr;
4319
Craig Topperb45eabc2017-04-26 16:39:58 +00004320 KnownBits Op0Known(BitWidth);
4321 KnownBits Op1Known(BitWidth);
Sanjay Patel3151dec2016-09-12 15:24:31 +00004322
Craig Topper47596dd2017-03-25 06:52:52 +00004323 if (SimplifyDemandedBits(&I, 0,
Craig Topper3edda872017-09-22 18:57:23 +00004324 getDemandedBitsLHSMask(I, BitWidth),
Craig Topperb45eabc2017-04-26 16:39:58 +00004325 Op0Known, 0))
Sanjay Patel3151dec2016-09-12 15:24:31 +00004326 return &I;
4327
Craig Topper47596dd2017-03-25 06:52:52 +00004328 if (SimplifyDemandedBits(&I, 1, APInt::getAllOnesValue(BitWidth),
Craig Topperb45eabc2017-04-26 16:39:58 +00004329 Op1Known, 0))
Sanjay Patel3151dec2016-09-12 15:24:31 +00004330 return &I;
4331
4332 // Given the known and unknown bits, compute a range that the LHS could be
4333 // in. Compute the Min, Max and RHS values based on the known bits. For the
4334 // EQ and NE we use unsigned values.
4335 APInt Op0Min(BitWidth, 0), Op0Max(BitWidth, 0);
4336 APInt Op1Min(BitWidth, 0), Op1Max(BitWidth, 0);
4337 if (I.isSigned()) {
Craig Topperb45eabc2017-04-26 16:39:58 +00004338 computeSignedMinMaxValuesFromKnownBits(Op0Known, Op0Min, Op0Max);
4339 computeSignedMinMaxValuesFromKnownBits(Op1Known, Op1Min, Op1Max);
Sanjay Patel3151dec2016-09-12 15:24:31 +00004340 } else {
Craig Topperb45eabc2017-04-26 16:39:58 +00004341 computeUnsignedMinMaxValuesFromKnownBits(Op0Known, Op0Min, Op0Max);
4342 computeUnsignedMinMaxValuesFromKnownBits(Op1Known, Op1Min, Op1Max);
Sanjay Patel3151dec2016-09-12 15:24:31 +00004343 }
4344
Sanjay Patelc63f9012018-01-04 14:31:56 +00004345 // If Min and Max are known to be the same, then SimplifyDemandedBits figured
4346 // out that the LHS or RHS is a constant. Constant fold this now, so that
Sanjay Patel0531f0a2016-09-12 15:52:28 +00004347 // code below can assume that Min != Max.
Sanjay Patel3151dec2016-09-12 15:24:31 +00004348 if (!isa<Constant>(Op0) && Op0Min == Op0Max)
Sanjay Patelc63f9012018-01-04 14:31:56 +00004349 return new ICmpInst(Pred, ConstantExpr::getIntegerValue(Ty, Op0Min), Op1);
Sanjay Patel3151dec2016-09-12 15:24:31 +00004350 if (!isa<Constant>(Op1) && Op1Min == Op1Max)
Sanjay Patelc63f9012018-01-04 14:31:56 +00004351 return new ICmpInst(Pred, Op0, ConstantExpr::getIntegerValue(Ty, Op1Min));
Sanjay Patel3151dec2016-09-12 15:24:31 +00004352
4353 // Based on the range information we know about the LHS, see if we can
4354 // simplify this comparison. For example, (x&4) < 8 is always true.
Sanjay Patel0531f0a2016-09-12 15:52:28 +00004355 switch (Pred) {
Sanjay Patel3151dec2016-09-12 15:24:31 +00004356 default:
4357 llvm_unreachable("Unknown icmp opcode!");
Sanjay Patel9efb1bd2016-09-14 23:38:56 +00004358 case ICmpInst::ICMP_EQ:
Sanjay Patel3151dec2016-09-12 15:24:31 +00004359 case ICmpInst::ICMP_NE: {
Sanjay Patel9efb1bd2016-09-14 23:38:56 +00004360 if (Op0Max.ult(Op1Min) || Op0Min.ugt(Op1Max)) {
4361 return Pred == CmpInst::ICMP_EQ
4362 ? replaceInstUsesWith(I, ConstantInt::getFalse(I.getType()))
4363 : replaceInstUsesWith(I, ConstantInt::getTrue(I.getType()));
4364 }
Sanjay Patel3151dec2016-09-12 15:24:31 +00004365
Sanjay Patel0531f0a2016-09-12 15:52:28 +00004366 // If all bits are known zero except for one, then we know at most one bit
4367 // is set. If the comparison is against zero, then this is a check to see if
4368 // *that* bit is set.
Craig Topperb45eabc2017-04-26 16:39:58 +00004369 APInt Op0KnownZeroInverted = ~Op0Known.Zero;
Craig Topperf0aeee02017-05-05 17:36:09 +00004370 if (Op1Known.isZero()) {
Sanjay Patel3151dec2016-09-12 15:24:31 +00004371 // If the LHS is an AND with the same constant, look through it.
4372 Value *LHS = nullptr;
Sanjay Patel7577a3d2016-09-15 14:15:47 +00004373 const APInt *LHSC;
4374 if (!match(Op0, m_And(m_Value(LHS), m_APInt(LHSC))) ||
4375 *LHSC != Op0KnownZeroInverted)
Sanjay Patel3151dec2016-09-12 15:24:31 +00004376 LHS = Op0;
4377
Sanjay Patel9efb1bd2016-09-14 23:38:56 +00004378 Value *X;
Sanjay Patel3151dec2016-09-12 15:24:31 +00004379 if (match(LHS, m_Shl(m_One(), m_Value(X)))) {
4380 APInt ValToCheck = Op0KnownZeroInverted;
Sanjay Patel9efb1bd2016-09-14 23:38:56 +00004381 Type *XTy = X->getType();
Sanjay Patel3151dec2016-09-12 15:24:31 +00004382 if (ValToCheck.isPowerOf2()) {
Sanjay Patel9efb1bd2016-09-14 23:38:56 +00004383 // ((1 << X) & 8) == 0 -> X != 3
4384 // ((1 << X) & 8) != 0 -> X == 3
4385 auto *CmpC = ConstantInt::get(XTy, ValToCheck.countTrailingZeros());
4386 auto NewPred = ICmpInst::getInversePredicate(Pred);
4387 return new ICmpInst(NewPred, X, CmpC);
Sanjay Patel3151dec2016-09-12 15:24:31 +00004388 } else if ((++ValToCheck).isPowerOf2()) {
Sanjay Patel9efb1bd2016-09-14 23:38:56 +00004389 // ((1 << X) & 7) == 0 -> X >= 3
4390 // ((1 << X) & 7) != 0 -> X < 3
4391 auto *CmpC = ConstantInt::get(XTy, ValToCheck.countTrailingZeros());
4392 auto NewPred =
4393 Pred == CmpInst::ICMP_EQ ? CmpInst::ICMP_UGE : CmpInst::ICMP_ULT;
4394 return new ICmpInst(NewPred, X, CmpC);
Sanjay Patel3151dec2016-09-12 15:24:31 +00004395 }
4396 }
4397
Sanjay Patel9efb1bd2016-09-14 23:38:56 +00004398 // Check if the LHS is 8 >>u x and the result is a power of 2 like 1.
Sanjay Patel3151dec2016-09-12 15:24:31 +00004399 const APInt *CI;
Craig Topper73ba1c82017-06-07 07:40:37 +00004400 if (Op0KnownZeroInverted.isOneValue() &&
Sanjay Patel9efb1bd2016-09-14 23:38:56 +00004401 match(LHS, m_LShr(m_Power2(CI), m_Value(X)))) {
4402 // ((8 >>u X) & 1) == 0 -> X != 3
4403 // ((8 >>u X) & 1) != 0 -> X == 3
4404 unsigned CmpVal = CI->countTrailingZeros();
4405 auto NewPred = ICmpInst::getInversePredicate(Pred);
4406 return new ICmpInst(NewPred, X, ConstantInt::get(X->getType(), CmpVal));
4407 }
Sanjay Patel3151dec2016-09-12 15:24:31 +00004408 }
4409 break;
4410 }
4411 case ICmpInst::ICMP_ULT: {
4412 if (Op0Max.ult(Op1Min)) // A <u B -> true if max(A) < min(B)
4413 return replaceInstUsesWith(I, ConstantInt::getTrue(I.getType()));
4414 if (Op0Min.uge(Op1Max)) // A <u B -> false if min(A) >= max(B)
4415 return replaceInstUsesWith(I, ConstantInt::getFalse(I.getType()));
4416 if (Op1Min == Op0Max) // A <u B -> A != B if max(A) == min(B)
4417 return new ICmpInst(ICmpInst::ICMP_NE, Op0, Op1);
4418
Craig Topper0cd25942017-09-27 22:57:18 +00004419 const APInt *CmpC;
4420 if (match(Op1, m_APInt(CmpC))) {
Sanjay Patel3151dec2016-09-12 15:24:31 +00004421 // A <u C -> A == C-1 if min(A)+1 == C
Craig Topper0cd25942017-09-27 22:57:18 +00004422 if (*CmpC == Op0Min + 1)
Craig Topper2c9b7d72017-09-22 18:57:20 +00004423 return new ICmpInst(ICmpInst::ICMP_EQ, Op0,
Craig Topper0cd25942017-09-27 22:57:18 +00004424 ConstantInt::get(Op1->getType(), *CmpC - 1));
Craig Topper30dc9792017-09-25 21:15:00 +00004425 // X <u C --> X == 0, if the number of zero bits in the bottom of X
4426 // exceeds the log2 of C.
Craig Topper0cd25942017-09-27 22:57:18 +00004427 if (Op0Known.countMinTrailingZeros() >= CmpC->ceilLogBase2())
Craig Topper30dc9792017-09-25 21:15:00 +00004428 return new ICmpInst(ICmpInst::ICMP_EQ, Op0,
4429 Constant::getNullValue(Op1->getType()));
Sanjay Patel3151dec2016-09-12 15:24:31 +00004430 }
4431 break;
4432 }
4433 case ICmpInst::ICMP_UGT: {
4434 if (Op0Min.ugt(Op1Max)) // A >u B -> true if min(A) > max(B)
4435 return replaceInstUsesWith(I, ConstantInt::getTrue(I.getType()));
Sanjay Patel3151dec2016-09-12 15:24:31 +00004436 if (Op0Max.ule(Op1Min)) // A >u B -> false if max(A) <= max(B)
4437 return replaceInstUsesWith(I, ConstantInt::getFalse(I.getType()));
Sanjay Patel3151dec2016-09-12 15:24:31 +00004438 if (Op1Max == Op0Min) // A >u B -> A != B if min(A) == max(B)
4439 return new ICmpInst(ICmpInst::ICMP_NE, Op0, Op1);
4440
Craig Topper0cd25942017-09-27 22:57:18 +00004441 const APInt *CmpC;
4442 if (match(Op1, m_APInt(CmpC))) {
Sanjay Patel3151dec2016-09-12 15:24:31 +00004443 // A >u C -> A == C+1 if max(a)-1 == C
Craig Topper0cd25942017-09-27 22:57:18 +00004444 if (*CmpC == Op0Max - 1)
Sanjay Patel3151dec2016-09-12 15:24:31 +00004445 return new ICmpInst(ICmpInst::ICMP_EQ, Op0,
Craig Topper0cd25942017-09-27 22:57:18 +00004446 ConstantInt::get(Op1->getType(), *CmpC + 1));
Craig Topper30dc9792017-09-25 21:15:00 +00004447 // X >u C --> X != 0, if the number of zero bits in the bottom of X
4448 // exceeds the log2 of C.
Craig Topper0cd25942017-09-27 22:57:18 +00004449 if (Op0Known.countMinTrailingZeros() >= CmpC->getActiveBits())
Craig Topper30dc9792017-09-25 21:15:00 +00004450 return new ICmpInst(ICmpInst::ICMP_NE, Op0,
4451 Constant::getNullValue(Op1->getType()));
Sanjay Patel3151dec2016-09-12 15:24:31 +00004452 }
4453 break;
4454 }
Craig Topper0cd25942017-09-27 22:57:18 +00004455 case ICmpInst::ICMP_SLT: {
Sanjay Patel3151dec2016-09-12 15:24:31 +00004456 if (Op0Max.slt(Op1Min)) // A <s B -> true if max(A) < min(C)
4457 return replaceInstUsesWith(I, ConstantInt::getTrue(I.getType()));
4458 if (Op0Min.sge(Op1Max)) // A <s B -> false if min(A) >= max(C)
4459 return replaceInstUsesWith(I, ConstantInt::getFalse(I.getType()));
4460 if (Op1Min == Op0Max) // A <s B -> A != B if max(A) == min(B)
4461 return new ICmpInst(ICmpInst::ICMP_NE, Op0, Op1);
Craig Topper0cd25942017-09-27 22:57:18 +00004462 const APInt *CmpC;
4463 if (match(Op1, m_APInt(CmpC))) {
4464 if (*CmpC == Op0Min + 1) // A <s C -> A == C-1 if min(A)+1 == C
Sanjay Patel3151dec2016-09-12 15:24:31 +00004465 return new ICmpInst(ICmpInst::ICMP_EQ, Op0,
Craig Topper0cd25942017-09-27 22:57:18 +00004466 ConstantInt::get(Op1->getType(), *CmpC - 1));
Sanjay Patel3151dec2016-09-12 15:24:31 +00004467 }
4468 break;
Craig Topper0cd25942017-09-27 22:57:18 +00004469 }
4470 case ICmpInst::ICMP_SGT: {
Sanjay Patel3151dec2016-09-12 15:24:31 +00004471 if (Op0Min.sgt(Op1Max)) // A >s B -> true if min(A) > max(B)
4472 return replaceInstUsesWith(I, ConstantInt::getTrue(I.getType()));
4473 if (Op0Max.sle(Op1Min)) // A >s B -> false if max(A) <= min(B)
4474 return replaceInstUsesWith(I, ConstantInt::getFalse(I.getType()));
Sanjay Patel3151dec2016-09-12 15:24:31 +00004475 if (Op1Max == Op0Min) // A >s B -> A != B if min(A) == max(B)
4476 return new ICmpInst(ICmpInst::ICMP_NE, Op0, Op1);
Craig Topper0cd25942017-09-27 22:57:18 +00004477 const APInt *CmpC;
4478 if (match(Op1, m_APInt(CmpC))) {
4479 if (*CmpC == Op0Max - 1) // A >s C -> A == C+1 if max(A)-1 == C
Sanjay Patel3151dec2016-09-12 15:24:31 +00004480 return new ICmpInst(ICmpInst::ICMP_EQ, Op0,
Craig Topper0cd25942017-09-27 22:57:18 +00004481 ConstantInt::get(Op1->getType(), *CmpC + 1));
Sanjay Patel3151dec2016-09-12 15:24:31 +00004482 }
4483 break;
Craig Topper0cd25942017-09-27 22:57:18 +00004484 }
Sanjay Patel3151dec2016-09-12 15:24:31 +00004485 case ICmpInst::ICMP_SGE:
4486 assert(!isa<ConstantInt>(Op1) && "ICMP_SGE with ConstantInt not folded!");
4487 if (Op0Min.sge(Op1Max)) // A >=s B -> true if min(A) >= max(B)
4488 return replaceInstUsesWith(I, ConstantInt::getTrue(I.getType()));
4489 if (Op0Max.slt(Op1Min)) // A >=s B -> false if max(A) < min(B)
4490 return replaceInstUsesWith(I, ConstantInt::getFalse(I.getType()));
Craig Topperea927ba2017-09-22 21:47:22 +00004491 if (Op1Min == Op0Max) // A >=s B -> A == B if max(A) == min(B)
4492 return new ICmpInst(ICmpInst::ICMP_EQ, Op0, Op1);
Sanjay Patel3151dec2016-09-12 15:24:31 +00004493 break;
4494 case ICmpInst::ICMP_SLE:
4495 assert(!isa<ConstantInt>(Op1) && "ICMP_SLE with ConstantInt not folded!");
4496 if (Op0Max.sle(Op1Min)) // A <=s B -> true if max(A) <= min(B)
4497 return replaceInstUsesWith(I, ConstantInt::getTrue(I.getType()));
4498 if (Op0Min.sgt(Op1Max)) // A <=s B -> false if min(A) > max(B)
4499 return replaceInstUsesWith(I, ConstantInt::getFalse(I.getType()));
Craig Topperea927ba2017-09-22 21:47:22 +00004500 if (Op1Max == Op0Min) // A <=s B -> A == B if min(A) == max(B)
4501 return new ICmpInst(ICmpInst::ICMP_EQ, Op0, Op1);
Sanjay Patel3151dec2016-09-12 15:24:31 +00004502 break;
4503 case ICmpInst::ICMP_UGE:
4504 assert(!isa<ConstantInt>(Op1) && "ICMP_UGE with ConstantInt not folded!");
4505 if (Op0Min.uge(Op1Max)) // A >=u B -> true if min(A) >= max(B)
4506 return replaceInstUsesWith(I, ConstantInt::getTrue(I.getType()));
4507 if (Op0Max.ult(Op1Min)) // A >=u B -> false if max(A) < min(B)
4508 return replaceInstUsesWith(I, ConstantInt::getFalse(I.getType()));
Craig Topperea927ba2017-09-22 21:47:22 +00004509 if (Op1Min == Op0Max) // A >=u B -> A == B if max(A) == min(B)
4510 return new ICmpInst(ICmpInst::ICMP_EQ, Op0, Op1);
Sanjay Patel3151dec2016-09-12 15:24:31 +00004511 break;
4512 case ICmpInst::ICMP_ULE:
4513 assert(!isa<ConstantInt>(Op1) && "ICMP_ULE with ConstantInt not folded!");
4514 if (Op0Max.ule(Op1Min)) // A <=u B -> true if max(A) <= min(B)
4515 return replaceInstUsesWith(I, ConstantInt::getTrue(I.getType()));
4516 if (Op0Min.ugt(Op1Max)) // A <=u B -> false if min(A) > max(B)
4517 return replaceInstUsesWith(I, ConstantInt::getFalse(I.getType()));
Craig Topperea927ba2017-09-22 21:47:22 +00004518 if (Op1Max == Op0Min) // A <=u B -> A == B if min(A) == max(B)
4519 return new ICmpInst(ICmpInst::ICMP_EQ, Op0, Op1);
Sanjay Patel3151dec2016-09-12 15:24:31 +00004520 break;
4521 }
4522
4523 // Turn a signed comparison into an unsigned one if both operands are known to
4524 // have the same sign.
4525 if (I.isSigned() &&
Craig Topperb45eabc2017-04-26 16:39:58 +00004526 ((Op0Known.Zero.isNegative() && Op1Known.Zero.isNegative()) ||
4527 (Op0Known.One.isNegative() && Op1Known.One.isNegative())))
Sanjay Patel3151dec2016-09-12 15:24:31 +00004528 return new ICmpInst(I.getUnsignedPredicate(), Op0, Op1);
4529
4530 return nullptr;
4531}
4532
Sanjay Pateld5b0e542016-04-29 16:22:25 +00004533/// If we have an icmp le or icmp ge instruction with a constant operand, turn
4534/// it into the appropriate icmp lt or icmp gt instruction. This transform
4535/// allows them to be folded in visitICmpInst.
Sanjay Patele9b2c322016-05-17 00:57:57 +00004536static ICmpInst *canonicalizeCmpWithConstant(ICmpInst &I) {
4537 ICmpInst::Predicate Pred = I.getPredicate();
4538 if (Pred != ICmpInst::ICMP_SLE && Pred != ICmpInst::ICMP_SGE &&
4539 Pred != ICmpInst::ICMP_ULE && Pred != ICmpInst::ICMP_UGE)
4540 return nullptr;
4541
Sanjay Pateld5b0e542016-04-29 16:22:25 +00004542 Value *Op0 = I.getOperand(0);
4543 Value *Op1 = I.getOperand(1);
Sanjay Patele9b2c322016-05-17 00:57:57 +00004544 auto *Op1C = dyn_cast<Constant>(Op1);
4545 if (!Op1C)
4546 return nullptr;
Sanjay Pateld5b0e542016-04-29 16:22:25 +00004547
Sanjay Patele9b2c322016-05-17 00:57:57 +00004548 // Check if the constant operand can be safely incremented/decremented without
4549 // overflowing/underflowing. For scalars, SimplifyICmpInst has already handled
4550 // the edge cases for us, so we just assert on them. For vectors, we must
4551 // handle the edge cases.
4552 Type *Op1Type = Op1->getType();
4553 bool IsSigned = I.isSigned();
4554 bool IsLE = (Pred == ICmpInst::ICMP_SLE || Pred == ICmpInst::ICMP_ULE);
Sanjay Patel18254932016-05-17 01:12:31 +00004555 auto *CI = dyn_cast<ConstantInt>(Op1C);
4556 if (CI) {
Sanjay Patele9b2c322016-05-17 00:57:57 +00004557 // A <= MAX -> TRUE ; A >= MIN -> TRUE
4558 assert(IsLE ? !CI->isMaxValue(IsSigned) : !CI->isMinValue(IsSigned));
4559 } else if (Op1Type->isVectorTy()) {
Sanjay Patelb79ab272016-05-13 15:10:46 +00004560 // TODO? If the edge cases for vectors were guaranteed to be handled as they
Sanjay Patele9b2c322016-05-17 00:57:57 +00004561 // are for scalar, we could remove the min/max checks. However, to do that,
4562 // we would have to use insertelement/shufflevector to replace edge values.
4563 unsigned NumElts = Op1Type->getVectorNumElements();
4564 for (unsigned i = 0; i != NumElts; ++i) {
4565 Constant *Elt = Op1C->getAggregateElement(i);
Benjamin Kramerca9a0fe2016-05-17 12:08:55 +00004566 if (!Elt)
4567 return nullptr;
4568
Sanjay Patele9b2c322016-05-17 00:57:57 +00004569 if (isa<UndefValue>(Elt))
4570 continue;
Sanjay Patel06b127a2016-09-15 14:37:50 +00004571
Sanjay Patele9b2c322016-05-17 00:57:57 +00004572 // Bail out if we can't determine if this constant is min/max or if we
4573 // know that this constant is min/max.
4574 auto *CI = dyn_cast<ConstantInt>(Elt);
4575 if (!CI || (IsLE ? CI->isMaxValue(IsSigned) : CI->isMinValue(IsSigned)))
4576 return nullptr;
Sanjay Patelb79ab272016-05-13 15:10:46 +00004577 }
Sanjay Patele9b2c322016-05-17 00:57:57 +00004578 } else {
4579 // ConstantExpr?
4580 return nullptr;
Sanjay Patelb79ab272016-05-13 15:10:46 +00004581 }
Sanjay Pateld5b0e542016-04-29 16:22:25 +00004582
Sanjay Patele9b2c322016-05-17 00:57:57 +00004583 // Increment or decrement the constant and set the new comparison predicate:
4584 // ULE -> ULT ; UGE -> UGT ; SLE -> SLT ; SGE -> SGT
Sanjay Patel22b01fe2016-05-17 20:20:40 +00004585 Constant *OneOrNegOne = ConstantInt::get(Op1Type, IsLE ? 1 : -1, true);
Sanjay Patele9b2c322016-05-17 00:57:57 +00004586 CmpInst::Predicate NewPred = IsLE ? ICmpInst::ICMP_ULT: ICmpInst::ICMP_UGT;
4587 NewPred = IsSigned ? ICmpInst::getSignedPredicate(NewPred) : NewPred;
4588 return new ICmpInst(NewPred, Op0, ConstantExpr::getAdd(Op1C, OneOrNegOne));
Sanjay Pateld5b0e542016-04-29 16:22:25 +00004589}
4590
Sanjay Patele5747e32017-05-17 22:15:07 +00004591/// Integer compare with boolean values can always be turned into bitwise ops.
4592static Instruction *canonicalizeICmpBool(ICmpInst &I,
4593 InstCombiner::BuilderTy &Builder) {
4594 Value *A = I.getOperand(0), *B = I.getOperand(1);
Craig Topperfde47232017-07-09 07:04:03 +00004595 assert(A->getType()->isIntOrIntVectorTy(1) && "Bools only");
Sanjay Patele5747e32017-05-17 22:15:07 +00004596
Sanjay Patelba212c22017-05-17 22:29:40 +00004597 // A boolean compared to true/false can be simplified to Op0/true/false in
4598 // 14 out of the 20 (10 predicates * 2 constants) possible combinations.
4599 // Cases not handled by InstSimplify are always 'not' of Op0.
4600 if (match(B, m_Zero())) {
4601 switch (I.getPredicate()) {
4602 case CmpInst::ICMP_EQ: // A == 0 -> !A
4603 case CmpInst::ICMP_ULE: // A <=u 0 -> !A
4604 case CmpInst::ICMP_SGE: // A >=s 0 -> !A
4605 return BinaryOperator::CreateNot(A);
4606 default:
4607 llvm_unreachable("ICmp i1 X, C not simplified as expected.");
4608 }
4609 } else if (match(B, m_One())) {
4610 switch (I.getPredicate()) {
4611 case CmpInst::ICMP_NE: // A != 1 -> !A
4612 case CmpInst::ICMP_ULT: // A <u 1 -> !A
4613 case CmpInst::ICMP_SGT: // A >s -1 -> !A
4614 return BinaryOperator::CreateNot(A);
4615 default:
4616 llvm_unreachable("ICmp i1 X, C not simplified as expected.");
4617 }
4618 }
4619
Sanjay Patele5747e32017-05-17 22:15:07 +00004620 switch (I.getPredicate()) {
4621 default:
4622 llvm_unreachable("Invalid icmp instruction!");
4623 case ICmpInst::ICMP_EQ:
4624 // icmp eq i1 A, B -> ~(A ^ B)
4625 return BinaryOperator::CreateNot(Builder.CreateXor(A, B));
4626
4627 case ICmpInst::ICMP_NE:
4628 // icmp ne i1 A, B -> A ^ B
4629 return BinaryOperator::CreateXor(A, B);
4630
4631 case ICmpInst::ICMP_UGT:
4632 // icmp ugt -> icmp ult
4633 std::swap(A, B);
4634 LLVM_FALLTHROUGH;
4635 case ICmpInst::ICMP_ULT:
4636 // icmp ult i1 A, B -> ~A & B
4637 return BinaryOperator::CreateAnd(Builder.CreateNot(A), B);
4638
4639 case ICmpInst::ICMP_SGT:
4640 // icmp sgt -> icmp slt
4641 std::swap(A, B);
4642 LLVM_FALLTHROUGH;
4643 case ICmpInst::ICMP_SLT:
4644 // icmp slt i1 A, B -> A & ~B
4645 return BinaryOperator::CreateAnd(Builder.CreateNot(B), A);
4646
4647 case ICmpInst::ICMP_UGE:
4648 // icmp uge -> icmp ule
4649 std::swap(A, B);
4650 LLVM_FALLTHROUGH;
4651 case ICmpInst::ICMP_ULE:
4652 // icmp ule i1 A, B -> ~A | B
4653 return BinaryOperator::CreateOr(Builder.CreateNot(A), B);
4654
4655 case ICmpInst::ICMP_SGE:
4656 // icmp sge -> icmp sle
4657 std::swap(A, B);
4658 LLVM_FALLTHROUGH;
4659 case ICmpInst::ICMP_SLE:
4660 // icmp sle i1 A, B -> A | ~B
4661 return BinaryOperator::CreateOr(Builder.CreateNot(B), A);
4662 }
4663}
4664
Roman Lebedev75404fb2018-09-12 18:19:43 +00004665// Transform pattern like:
Roman Lebedev1b7fc872018-09-15 12:04:13 +00004666// (1 << Y) u<= X or ~(-1 << Y) u< X or ((1 << Y)+(-1)) u< X
4667// (1 << Y) u> X or ~(-1 << Y) u>= X or ((1 << Y)+(-1)) u>= X
Roman Lebedev75404fb2018-09-12 18:19:43 +00004668// Into:
4669// (X l>> Y) != 0
4670// (X l>> Y) == 0
4671static Instruction *foldICmpWithHighBitMask(ICmpInst &Cmp,
4672 InstCombiner::BuilderTy &Builder) {
Roman Lebedev6dc87002018-09-13 20:33:12 +00004673 ICmpInst::Predicate Pred, NewPred;
Roman Lebedev75404fb2018-09-12 18:19:43 +00004674 Value *X, *Y;
Roman Lebedev6dc87002018-09-13 20:33:12 +00004675 if (match(&Cmp,
4676 m_c_ICmp(Pred, m_OneUse(m_Shl(m_One(), m_Value(Y))), m_Value(X)))) {
4677 // We want X to be the icmp's second operand, so swap predicate if it isn't.
4678 if (Cmp.getOperand(0) == X)
4679 Pred = Cmp.getSwappedPredicate();
Roman Lebedev75404fb2018-09-12 18:19:43 +00004680
Roman Lebedev6dc87002018-09-13 20:33:12 +00004681 switch (Pred) {
4682 case ICmpInst::ICMP_ULE:
4683 NewPred = ICmpInst::ICMP_NE;
4684 break;
4685 case ICmpInst::ICMP_UGT:
4686 NewPred = ICmpInst::ICMP_EQ;
4687 break;
4688 default:
4689 return nullptr;
4690 }
Roman Lebedev1b7fc872018-09-15 12:04:13 +00004691 } else if (match(&Cmp, m_c_ICmp(Pred,
4692 m_OneUse(m_CombineOr(
4693 m_Not(m_Shl(m_AllOnes(), m_Value(Y))),
4694 m_Add(m_Shl(m_One(), m_Value(Y)),
4695 m_AllOnes()))),
4696 m_Value(X)))) {
4697 // The variant with 'add' is not canonical, (the variant with 'not' is)
4698 // we only get it because it has extra uses, and can't be canonicalized,
4699
Roman Lebedev6dc87002018-09-13 20:33:12 +00004700 // We want X to be the icmp's second operand, so swap predicate if it isn't.
4701 if (Cmp.getOperand(0) == X)
4702 Pred = Cmp.getSwappedPredicate();
Roman Lebedev75404fb2018-09-12 18:19:43 +00004703
Roman Lebedev6dc87002018-09-13 20:33:12 +00004704 switch (Pred) {
4705 case ICmpInst::ICMP_ULT:
4706 NewPred = ICmpInst::ICMP_NE;
4707 break;
4708 case ICmpInst::ICMP_UGE:
4709 NewPred = ICmpInst::ICMP_EQ;
4710 break;
4711 default:
4712 return nullptr;
4713 }
4714 } else
Roman Lebedev75404fb2018-09-12 18:19:43 +00004715 return nullptr;
Roman Lebedev75404fb2018-09-12 18:19:43 +00004716
4717 Value *NewX = Builder.CreateLShr(X, Y, X->getName() + ".highbits");
4718 Constant *Zero = Constant::getNullValue(NewX->getType());
4719 return CmpInst::Create(Instruction::ICmp, NewPred, NewX, Zero);
4720}
4721
Sanjay Patel039f5562018-08-16 12:52:17 +00004722static Instruction *foldVectorCmp(CmpInst &Cmp,
4723 InstCombiner::BuilderTy &Builder) {
4724 // If both arguments of the cmp are shuffles that use the same mask and
4725 // shuffle within a single vector, move the shuffle after the cmp.
4726 Value *LHS = Cmp.getOperand(0), *RHS = Cmp.getOperand(1);
4727 Value *V1, *V2;
4728 Constant *M;
4729 if (match(LHS, m_ShuffleVector(m_Value(V1), m_Undef(), m_Constant(M))) &&
4730 match(RHS, m_ShuffleVector(m_Value(V2), m_Undef(), m_Specific(M))) &&
4731 V1->getType() == V2->getType() &&
4732 (LHS->hasOneUse() || RHS->hasOneUse())) {
4733 // cmp (shuffle V1, M), (shuffle V2, M) --> shuffle (cmp V1, V2), M
4734 CmpInst::Predicate P = Cmp.getPredicate();
4735 Value *NewCmp = isa<ICmpInst>(Cmp) ? Builder.CreateICmp(P, V1, V2)
4736 : Builder.CreateFCmp(P, V1, V2);
4737 return new ShuffleVectorInst(NewCmp, UndefValue::get(NewCmp->getType()), M);
4738 }
4739 return nullptr;
4740}
4741
Chris Lattner2188e402010-01-04 07:37:31 +00004742Instruction *InstCombiner::visitICmpInst(ICmpInst &I) {
4743 bool Changed = false;
Chris Lattner9306ffa2010-02-01 19:54:45 +00004744 Value *Op0 = I.getOperand(0), *Op1 = I.getOperand(1);
Quentin Colombet5ab55552013-09-09 20:56:48 +00004745 unsigned Op0Cplxity = getComplexity(Op0);
4746 unsigned Op1Cplxity = getComplexity(Op1);
Jim Grosbach129c52a2011-09-30 18:09:53 +00004747
Chris Lattner2188e402010-01-04 07:37:31 +00004748 /// Orders the operands of the compare so that they are listed from most
4749 /// complex to least complex. This puts constants before unary operators,
4750 /// before binary operators.
Quentin Colombet5ab55552013-09-09 20:56:48 +00004751 if (Op0Cplxity < Op1Cplxity ||
Sanjay Patel4c204232016-06-04 20:39:22 +00004752 (Op0Cplxity == Op1Cplxity && swapMayExposeCSEOpportunities(Op0, Op1))) {
Chris Lattner2188e402010-01-04 07:37:31 +00004753 I.swapOperands();
Chris Lattner9306ffa2010-02-01 19:54:45 +00004754 std::swap(Op0, Op1);
Chris Lattner2188e402010-01-04 07:37:31 +00004755 Changed = true;
4756 }
Jim Grosbach129c52a2011-09-30 18:09:53 +00004757
Daniel Berlin2c75c632017-04-26 20:56:07 +00004758 if (Value *V = SimplifyICmpInst(I.getPredicate(), Op0, Op1,
4759 SQ.getWithInstruction(&I)))
Sanjay Patel4b198802016-02-01 22:23:39 +00004760 return replaceInstUsesWith(I, V);
Jim Grosbach129c52a2011-09-30 18:09:53 +00004761
Uriel Korach18972232017-09-10 08:31:22 +00004762 // Comparing -val or val with non-zero is the same as just comparing val
Pete Cooperfdddc272011-12-01 19:13:26 +00004763 // ie, abs(val) != 0 -> val != 0
Sanjay Patel4c204232016-06-04 20:39:22 +00004764 if (I.getPredicate() == ICmpInst::ICMP_NE && match(Op1, m_Zero())) {
Pete Cooperfdddc272011-12-01 19:13:26 +00004765 Value *Cond, *SelectTrue, *SelectFalse;
4766 if (match(Op0, m_Select(m_Value(Cond), m_Value(SelectTrue),
Pete Cooperbc5c5242011-12-01 03:58:40 +00004767 m_Value(SelectFalse)))) {
Pete Cooperfdddc272011-12-01 19:13:26 +00004768 if (Value *V = dyn_castNegVal(SelectTrue)) {
4769 if (V == SelectFalse)
4770 return CmpInst::Create(Instruction::ICmp, I.getPredicate(), V, Op1);
4771 }
4772 else if (Value *V = dyn_castNegVal(SelectFalse)) {
4773 if (V == SelectTrue)
4774 return CmpInst::Create(Instruction::ICmp, I.getPredicate(), V, Op1);
Pete Cooperbc5c5242011-12-01 03:58:40 +00004775 }
4776 }
4777 }
4778
Craig Topperfde47232017-07-09 07:04:03 +00004779 if (Op0->getType()->isIntOrIntVectorTy(1))
Craig Topperbb4069e2017-07-07 23:16:26 +00004780 if (Instruction *Res = canonicalizeICmpBool(I, Builder))
Sanjay Patele5747e32017-05-17 22:15:07 +00004781 return Res;
Chris Lattner2188e402010-01-04 07:37:31 +00004782
Sanjay Patele9b2c322016-05-17 00:57:57 +00004783 if (ICmpInst *NewICmp = canonicalizeCmpWithConstant(I))
Sanjay Pateld5b0e542016-04-29 16:22:25 +00004784 return NewICmp;
4785
Sanjay Patel06b127a2016-09-15 14:37:50 +00004786 if (Instruction *Res = foldICmpWithConstant(I))
4787 return Res;
Chris Lattner2188e402010-01-04 07:37:31 +00004788
Sanjay Pateld23b5ed2018-12-04 17:44:24 +00004789 if (Instruction *Res = foldICmpWithDominatingICmp(I))
4790 return Res;
4791
Max Kazantsev20da7e42018-07-06 04:04:13 +00004792 if (Instruction *Res = foldICmpUsingKnownBits(I))
4793 return Res;
4794
Chris Lattner2188e402010-01-04 07:37:31 +00004795 // Test if the ICmpInst instruction is used exclusively by a select as
4796 // part of a minimum or maximum operation. If so, refrain from doing
4797 // any other folding. This helps out other analyses which understand
4798 // non-obfuscated minimum and maximum idioms, such as ScalarEvolution
4799 // and CodeGen. And in this case, at least one of the comparison
4800 // operands has at least one user besides the compare (the select),
4801 // which would often largely negate the benefit of folding anyway.
Craig Topperd3e57812017-11-12 02:28:21 +00004802 //
4803 // Do the same for the other patterns recognized by matchSelectPattern.
Chris Lattner2188e402010-01-04 07:37:31 +00004804 if (I.hasOneUse())
Craig Topperd3e57812017-11-12 02:28:21 +00004805 if (SelectInst *SI = dyn_cast<SelectInst>(I.user_back())) {
4806 Value *A, *B;
4807 SelectPatternResult SPR = matchSelectPattern(SI, A, B);
4808 if (SPR.Flavor != SPF_UNKNOWN)
Craig Topperf40110f2014-04-25 05:29:35 +00004809 return nullptr;
Craig Topperd3e57812017-11-12 02:28:21 +00004810 }
Chris Lattner2188e402010-01-04 07:37:31 +00004811
Nikolai Bozhenov0e7ebbc2017-10-16 09:19:21 +00004812 // Do this after checking for min/max to prevent infinite looping.
4813 if (Instruction *Res = foldICmpWithZero(I))
4814 return Res;
4815
Sanjay Patelfebcb9c2017-01-27 23:26:27 +00004816 // FIXME: We only do this after checking for min/max to prevent infinite
4817 // looping caused by a reverse canonicalization of these patterns for min/max.
4818 // FIXME: The organization of folds is a mess. These would naturally go into
4819 // canonicalizeCmpWithConstant(), but we can't move all of the above folds
4820 // down here after the min/max restriction.
4821 ICmpInst::Predicate Pred = I.getPredicate();
4822 const APInt *C;
4823 if (match(Op1, m_APInt(C))) {
4824 // For i32: x >u 2147483647 -> x <s 0 -> true if sign bit set
4825 if (Pred == ICmpInst::ICMP_UGT && C->isMaxSignedValue()) {
4826 Constant *Zero = Constant::getNullValue(Op0->getType());
4827 return new ICmpInst(ICmpInst::ICMP_SLT, Op0, Zero);
4828 }
4829
4830 // For i32: x <u 2147483648 -> x >s -1 -> true if sign bit clear
4831 if (Pred == ICmpInst::ICMP_ULT && C->isMinSignedValue()) {
4832 Constant *AllOnes = Constant::getAllOnesValue(Op0->getType());
4833 return new ICmpInst(ICmpInst::ICMP_SGT, Op0, AllOnes);
4834 }
4835 }
4836
Sanjay Patelf58f68c2016-09-10 15:03:44 +00004837 if (Instruction *Res = foldICmpInstWithConstant(I))
Sanjay Patel1271bf92016-07-23 13:06:49 +00004838 return Res;
4839
Sanjay Patel10494b22016-09-16 16:10:22 +00004840 if (Instruction *Res = foldICmpInstWithConstantNotInt(I))
4841 return Res;
Chris Lattner2188e402010-01-04 07:37:31 +00004842
4843 // If we can optimize a 'icmp GEP, P' or 'icmp P, GEP', do so now.
4844 if (GEPOperator *GEP = dyn_cast<GEPOperator>(Op0))
Sanjay Patel43395062016-07-21 18:07:40 +00004845 if (Instruction *NI = foldGEPICmp(GEP, Op1, I.getPredicate(), I))
Chris Lattner2188e402010-01-04 07:37:31 +00004846 return NI;
4847 if (GEPOperator *GEP = dyn_cast<GEPOperator>(Op1))
Sanjay Patel43395062016-07-21 18:07:40 +00004848 if (Instruction *NI = foldGEPICmp(GEP, Op0,
Chris Lattner2188e402010-01-04 07:37:31 +00004849 ICmpInst::getSwappedPredicate(I.getPredicate()), I))
4850 return NI;
4851
Hans Wennborgf1f36512015-10-07 00:20:07 +00004852 // Try to optimize equality comparisons against alloca-based pointers.
4853 if (Op0->getType()->isPointerTy() && I.isEquality()) {
4854 assert(Op1->getType()->isPointerTy() && "Comparing pointer with non-pointer?");
4855 if (auto *Alloca = dyn_cast<AllocaInst>(GetUnderlyingObject(Op0, DL)))
Sanjay Patel43395062016-07-21 18:07:40 +00004856 if (Instruction *New = foldAllocaCmp(I, Alloca, Op1))
Hans Wennborgf1f36512015-10-07 00:20:07 +00004857 return New;
4858 if (auto *Alloca = dyn_cast<AllocaInst>(GetUnderlyingObject(Op1, DL)))
Sanjay Patel43395062016-07-21 18:07:40 +00004859 if (Instruction *New = foldAllocaCmp(I, Alloca, Op0))
Hans Wennborgf1f36512015-10-07 00:20:07 +00004860 return New;
4861 }
4862
Sanjay Patel841aac02018-03-25 14:01:42 +00004863 // Zero-equality and sign-bit checks are preserved through sitofp + bitcast.
Roman Lebedeve6da3062018-03-18 15:53:02 +00004864 Value *X;
Sanjay Patel745a9c62018-03-24 15:45:02 +00004865 if (match(Op0, m_BitCast(m_SIToFP(m_Value(X))))) {
Sanjay Patel841aac02018-03-25 14:01:42 +00004866 // icmp eq (bitcast (sitofp X)), 0 --> icmp eq X, 0
4867 // icmp ne (bitcast (sitofp X)), 0 --> icmp ne X, 0
4868 // icmp slt (bitcast (sitofp X)), 0 --> icmp slt X, 0
4869 // icmp sgt (bitcast (sitofp X)), 0 --> icmp sgt X, 0
4870 if ((Pred == ICmpInst::ICMP_EQ || Pred == ICmpInst::ICMP_SLT ||
4871 Pred == ICmpInst::ICMP_NE || Pred == ICmpInst::ICMP_SGT) &&
4872 match(Op1, m_Zero()))
Sanjay Patel745a9c62018-03-24 15:45:02 +00004873 return new ICmpInst(Pred, X, ConstantInt::getNullValue(X->getType()));
Sanjay Patel841aac02018-03-25 14:01:42 +00004874
4875 // icmp slt (bitcast (sitofp X)), 1 --> icmp slt X, 1
4876 if (Pred == ICmpInst::ICMP_SLT && match(Op1, m_One()))
4877 return new ICmpInst(Pred, X, ConstantInt::get(X->getType(), 1));
4878
4879 // icmp sgt (bitcast (sitofp X)), -1 --> icmp sgt X, -1
Sanjay Patel745a9c62018-03-24 15:45:02 +00004880 if (Pred == ICmpInst::ICMP_SGT && match(Op1, m_AllOnes()))
4881 return new ICmpInst(Pred, X, ConstantInt::getAllOnesValue(X->getType()));
4882 }
Roman Lebedeve6da3062018-03-18 15:53:02 +00004883
4884 // Zero-equality checks are preserved through unsigned floating-point casts:
4885 // icmp eq (bitcast (uitofp X)), 0 --> icmp eq X, 0
4886 // icmp ne (bitcast (uitofp X)), 0 --> icmp ne X, 0
4887 if (match(Op0, m_BitCast(m_UIToFP(m_Value(X)))))
4888 if (I.isEquality() && match(Op1, m_Zero()))
4889 return new ICmpInst(Pred, X, ConstantInt::getNullValue(X->getType()));
4890
Chris Lattner2188e402010-01-04 07:37:31 +00004891 // Test to see if the operands of the icmp are casted versions of other
4892 // values. If the ptr->ptr cast can be stripped off both arguments, we do so
4893 // now.
4894 if (BitCastInst *CI = dyn_cast<BitCastInst>(Op0)) {
Jim Grosbach129c52a2011-09-30 18:09:53 +00004895 if (Op0->getType()->isPointerTy() &&
4896 (isa<Constant>(Op1) || isa<BitCastInst>(Op1))) {
Chris Lattner2188e402010-01-04 07:37:31 +00004897 // We keep moving the cast from the left operand over to the right
4898 // operand, where it can often be eliminated completely.
4899 Op0 = CI->getOperand(0);
4900
4901 // If operand #1 is a bitcast instruction, it must also be a ptr->ptr cast
4902 // so eliminate it as well.
4903 if (BitCastInst *CI2 = dyn_cast<BitCastInst>(Op1))
4904 Op1 = CI2->getOperand(0);
4905
4906 // If Op1 is a constant, we can fold the cast into the constant.
4907 if (Op0->getType() != Op1->getType()) {
4908 if (Constant *Op1C = dyn_cast<Constant>(Op1)) {
4909 Op1 = ConstantExpr::getBitCast(Op1C, Op0->getType());
4910 } else {
4911 // Otherwise, cast the RHS right before the icmp
Craig Topperbb4069e2017-07-07 23:16:26 +00004912 Op1 = Builder.CreateBitCast(Op1, Op0->getType());
Chris Lattner2188e402010-01-04 07:37:31 +00004913 }
4914 }
4915 return new ICmpInst(I.getPredicate(), Op0, Op1);
4916 }
4917 }
Jim Grosbach129c52a2011-09-30 18:09:53 +00004918
Chris Lattner2188e402010-01-04 07:37:31 +00004919 if (isa<CastInst>(Op0)) {
4920 // Handle the special case of: icmp (cast bool to X), <cst>
4921 // This comes up when you have code like
4922 // int X = A < B;
4923 // if (X) ...
4924 // For generality, we handle any zero-extension of any operand comparison
4925 // with a constant or another cast from the same type.
4926 if (isa<Constant>(Op1) || isa<CastInst>(Op1))
Sanjay Patel43395062016-07-21 18:07:40 +00004927 if (Instruction *R = foldICmpWithCastAndCast(I))
Chris Lattner2188e402010-01-04 07:37:31 +00004928 return R;
4929 }
Chris Lattner2188e402010-01-04 07:37:31 +00004930
Sanjay Patel10494b22016-09-16 16:10:22 +00004931 if (Instruction *Res = foldICmpBinOp(I))
4932 return Res;
Duncan Sandse5220012011-02-17 07:46:37 +00004933
Sanjay Pateldd46b522016-12-19 17:32:37 +00004934 if (Instruction *Res = foldICmpWithMinMax(I))
Sanjay Pateld6406412016-12-15 19:13:37 +00004935 return Res;
4936
Sanjay Patel10494b22016-09-16 16:10:22 +00004937 {
4938 Value *A, *B;
David Majnemer1a08acc2013-04-12 17:25:07 +00004939 // Transform (A & ~B) == 0 --> (A & B) != 0
4940 // and (A & ~B) != 0 --> (A & B) == 0
4941 // if A is a power of 2.
4942 if (match(Op0, m_And(m_Value(A), m_Not(m_Value(B)))) &&
Chandler Carruth66b31302015-01-04 12:03:27 +00004943 match(Op1, m_Zero()) &&
Craig Topperd4039f72017-05-25 21:51:12 +00004944 isKnownToBeAPowerOfTwo(A, false, 0, &I) && I.isEquality())
Craig Topperbb4069e2017-07-07 23:16:26 +00004945 return new ICmpInst(I.getInversePredicate(), Builder.CreateAnd(A, B),
David Majnemer1a08acc2013-04-12 17:25:07 +00004946 Op1);
4947
Sanjay Patel4dc85eb2017-06-02 16:11:14 +00004948 // ~X < ~Y --> Y < X
4949 // ~X < C --> X > ~C
Chris Lattnerf3c4eef2011-01-15 05:41:33 +00004950 if (match(Op0, m_Not(m_Value(A)))) {
4951 if (match(Op1, m_Not(m_Value(B))))
4952 return new ICmpInst(I.getPredicate(), B, A);
Sanjay Patel4dc85eb2017-06-02 16:11:14 +00004953
Sanjay Patelce241f42017-06-02 16:29:41 +00004954 const APInt *C;
4955 if (match(Op1, m_APInt(C)))
Sanjay Patel4dc85eb2017-06-02 16:11:14 +00004956 return new ICmpInst(I.getSwappedPredicate(), A,
Sanjay Patelce241f42017-06-02 16:29:41 +00004957 ConstantInt::get(Op1->getType(), ~(*C)));
Chris Lattnerf3c4eef2011-01-15 05:41:33 +00004958 }
Chris Lattner5e0c0c72010-12-19 19:37:52 +00004959
Sanjoy Dasb6c59142015-04-10 21:07:09 +00004960 Instruction *AddI = nullptr;
4961 if (match(&I, m_UAddWithOverflow(m_Value(A), m_Value(B),
4962 m_Instruction(AddI))) &&
4963 isa<IntegerType>(A->getType())) {
4964 Value *Result;
4965 Constant *Overflow;
4966 if (OptimizeOverflowCheck(OCF_UNSIGNED_ADD, A, B, *AddI, Result,
4967 Overflow)) {
Sanjay Patel4b198802016-02-01 22:23:39 +00004968 replaceInstUsesWith(*AddI, Result);
4969 return replaceInstUsesWith(I, Overflow);
Sanjoy Dasb6c59142015-04-10 21:07:09 +00004970 }
4971 }
Serge Pavlov4bb54d52014-04-13 18:23:41 +00004972
4973 // (zext a) * (zext b) --> llvm.umul.with.overflow.
4974 if (match(Op0, m_Mul(m_ZExt(m_Value(A)), m_ZExt(m_Value(B))))) {
Sanjay Pateld93c4c02016-09-15 18:22:25 +00004975 if (Instruction *R = processUMulZExtIdiom(I, Op0, Op1, *this))
Serge Pavlov4bb54d52014-04-13 18:23:41 +00004976 return R;
4977 }
4978 if (match(Op1, m_Mul(m_ZExt(m_Value(A)), m_ZExt(m_Value(B))))) {
Sanjay Pateld93c4c02016-09-15 18:22:25 +00004979 if (Instruction *R = processUMulZExtIdiom(I, Op1, Op0, *this))
Serge Pavlov4bb54d52014-04-13 18:23:41 +00004980 return R;
4981 }
Chris Lattner2188e402010-01-04 07:37:31 +00004982 }
Jim Grosbach129c52a2011-09-30 18:09:53 +00004983
Sanjay Patel10494b22016-09-16 16:10:22 +00004984 if (Instruction *Res = foldICmpEquality(I))
4985 return Res;
Jim Grosbach129c52a2011-09-30 18:09:53 +00004986
David Majnemerc1eca5a2014-11-06 23:23:30 +00004987 // The 'cmpxchg' instruction returns an aggregate containing the old value and
4988 // an i1 which indicates whether or not we successfully did the swap.
4989 //
4990 // Replace comparisons between the old value and the expected value with the
4991 // indicator that 'cmpxchg' returns.
4992 //
4993 // N.B. This transform is only valid when the 'cmpxchg' is not permitted to
4994 // spuriously fail. In those cases, the old value may equal the expected
4995 // value but it is possible for the swap to not occur.
4996 if (I.getPredicate() == ICmpInst::ICMP_EQ)
4997 if (auto *EVI = dyn_cast<ExtractValueInst>(Op0))
4998 if (auto *ACXI = dyn_cast<AtomicCmpXchgInst>(EVI->getAggregateOperand()))
4999 if (EVI->getIndices()[0] == 0 && ACXI->getCompareOperand() == Op1 &&
5000 !ACXI->isWeak())
5001 return ExtractValueInst::Create(ACXI, 1);
5002
Chris Lattner2188e402010-01-04 07:37:31 +00005003 {
Craig Topperbee74792018-08-20 23:04:25 +00005004 Value *X;
5005 const APInt *C;
Chris Lattner2188e402010-01-04 07:37:31 +00005006 // icmp X+Cst, X
Craig Topperbee74792018-08-20 23:04:25 +00005007 if (match(Op0, m_Add(m_Value(X), m_APInt(C))) && Op1 == X)
5008 return foldICmpAddOpConst(X, *C, I.getPredicate());
Chris Lattner2188e402010-01-04 07:37:31 +00005009
5010 // icmp X, X+Cst
Craig Topperbee74792018-08-20 23:04:25 +00005011 if (match(Op1, m_Add(m_Value(X), m_APInt(C))) && Op0 == X)
5012 return foldICmpAddOpConst(X, *C, I.getSwappedPredicate());
Chris Lattner2188e402010-01-04 07:37:31 +00005013 }
Roman Lebedev68d54cf2018-07-11 19:05:04 +00005014
Roman Lebedev75404fb2018-09-12 18:19:43 +00005015 if (Instruction *Res = foldICmpWithHighBitMask(I, Builder))
5016 return Res;
5017
Sanjay Patel039f5562018-08-16 12:52:17 +00005018 if (I.getType()->isVectorTy())
5019 if (Instruction *Res = foldVectorCmp(I, Builder))
5020 return Res;
5021
Craig Topperf40110f2014-04-25 05:29:35 +00005022 return Changed ? &I : nullptr;
Chris Lattner2188e402010-01-04 07:37:31 +00005023}
5024
Sanjay Patel5f0217f2016-06-05 16:46:18 +00005025/// Fold fcmp ([us]itofp x, cst) if possible.
Sanjay Patel43395062016-07-21 18:07:40 +00005026Instruction *InstCombiner::foldFCmpIntToFPConst(FCmpInst &I, Instruction *LHSI,
Chris Lattner2188e402010-01-04 07:37:31 +00005027 Constant *RHSC) {
Craig Topperf40110f2014-04-25 05:29:35 +00005028 if (!isa<ConstantFP>(RHSC)) return nullptr;
Chris Lattner2188e402010-01-04 07:37:31 +00005029 const APFloat &RHS = cast<ConstantFP>(RHSC)->getValueAPF();
Jim Grosbach129c52a2011-09-30 18:09:53 +00005030
Chris Lattner2188e402010-01-04 07:37:31 +00005031 // Get the width of the mantissa. We don't want to hack on conversions that
5032 // might lose information from the integer, e.g. "i64 -> float"
5033 int MantissaWidth = LHSI->getType()->getFPMantissaWidth();
Craig Topperf40110f2014-04-25 05:29:35 +00005034 if (MantissaWidth == -1) return nullptr; // Unknown.
Jim Grosbach129c52a2011-09-30 18:09:53 +00005035
Matt Arsenault55e73122015-01-06 15:50:59 +00005036 IntegerType *IntTy = cast<IntegerType>(LHSI->getOperand(0)->getType());
5037
Chris Lattner2188e402010-01-04 07:37:31 +00005038 bool LHSUnsigned = isa<UIToFPInst>(LHSI);
Jim Grosbach129c52a2011-09-30 18:09:53 +00005039
Matt Arsenault55e73122015-01-06 15:50:59 +00005040 if (I.isEquality()) {
5041 FCmpInst::Predicate P = I.getPredicate();
5042 bool IsExact = false;
5043 APSInt RHSCvt(IntTy->getBitWidth(), LHSUnsigned);
5044 RHS.convertToInteger(RHSCvt, APFloat::rmNearestTiesToEven, &IsExact);
5045
5046 // If the floating point constant isn't an integer value, we know if we will
5047 // ever compare equal / not equal to it.
5048 if (!IsExact) {
5049 // TODO: Can never be -0.0 and other non-representable values
5050 APFloat RHSRoundInt(RHS);
5051 RHSRoundInt.roundToIntegral(APFloat::rmNearestTiesToEven);
5052 if (RHS.compare(RHSRoundInt) != APFloat::cmpEqual) {
5053 if (P == FCmpInst::FCMP_OEQ || P == FCmpInst::FCMP_UEQ)
Craig Topperbb4069e2017-07-07 23:16:26 +00005054 return replaceInstUsesWith(I, Builder.getFalse());
Matt Arsenault55e73122015-01-06 15:50:59 +00005055
5056 assert(P == FCmpInst::FCMP_ONE || P == FCmpInst::FCMP_UNE);
Craig Topperbb4069e2017-07-07 23:16:26 +00005057 return replaceInstUsesWith(I, Builder.getTrue());
Matt Arsenault55e73122015-01-06 15:50:59 +00005058 }
5059 }
5060
5061 // TODO: If the constant is exactly representable, is it always OK to do
5062 // equality compares as integer?
5063 }
5064
Arch D. Robison8ed08542015-09-15 17:51:59 +00005065 // Check to see that the input is converted from an integer type that is small
5066 // enough that preserves all bits. TODO: check here for "known" sign bits.
5067 // This would allow us to handle (fptosi (x >>s 62) to float) if x is i64 f.e.
5068 unsigned InputSize = IntTy->getScalarSizeInBits();
Matt Arsenault55e73122015-01-06 15:50:59 +00005069
Justin Bognerc7e4fbe2016-08-05 01:09:48 +00005070 // Following test does NOT adjust InputSize downwards for signed inputs,
5071 // because the most negative value still requires all the mantissa bits
Arch D. Robison8ed08542015-09-15 17:51:59 +00005072 // to distinguish it from one less than that value.
5073 if ((int)InputSize > MantissaWidth) {
5074 // Conversion would lose accuracy. Check if loss can impact comparison.
5075 int Exp = ilogb(RHS);
5076 if (Exp == APFloat::IEK_Inf) {
5077 int MaxExponent = ilogb(APFloat::getLargest(RHS.getSemantics()));
Justin Bognerc7e4fbe2016-08-05 01:09:48 +00005078 if (MaxExponent < (int)InputSize - !LHSUnsigned)
Arch D. Robison8ed08542015-09-15 17:51:59 +00005079 // Conversion could create infinity.
5080 return nullptr;
5081 } else {
Justin Bognerc7e4fbe2016-08-05 01:09:48 +00005082 // Note that if RHS is zero or NaN, then Exp is negative
Arch D. Robison8ed08542015-09-15 17:51:59 +00005083 // and first condition is trivially false.
Justin Bognerc7e4fbe2016-08-05 01:09:48 +00005084 if (MantissaWidth <= Exp && Exp <= (int)InputSize - !LHSUnsigned)
Arch D. Robison8ed08542015-09-15 17:51:59 +00005085 // Conversion could affect comparison.
5086 return nullptr;
5087 }
5088 }
Jim Grosbach129c52a2011-09-30 18:09:53 +00005089
Chris Lattner2188e402010-01-04 07:37:31 +00005090 // Otherwise, we can potentially simplify the comparison. We know that it
5091 // will always come through as an integer value and we know the constant is
5092 // not a NAN (it would have been previously simplified).
5093 assert(!RHS.isNaN() && "NaN comparison not already folded!");
Jim Grosbach129c52a2011-09-30 18:09:53 +00005094
Chris Lattner2188e402010-01-04 07:37:31 +00005095 ICmpInst::Predicate Pred;
5096 switch (I.getPredicate()) {
5097 default: llvm_unreachable("Unexpected predicate!");
5098 case FCmpInst::FCMP_UEQ:
5099 case FCmpInst::FCMP_OEQ:
5100 Pred = ICmpInst::ICMP_EQ;
5101 break;
5102 case FCmpInst::FCMP_UGT:
5103 case FCmpInst::FCMP_OGT:
5104 Pred = LHSUnsigned ? ICmpInst::ICMP_UGT : ICmpInst::ICMP_SGT;
5105 break;
5106 case FCmpInst::FCMP_UGE:
5107 case FCmpInst::FCMP_OGE:
5108 Pred = LHSUnsigned ? ICmpInst::ICMP_UGE : ICmpInst::ICMP_SGE;
5109 break;
5110 case FCmpInst::FCMP_ULT:
5111 case FCmpInst::FCMP_OLT:
5112 Pred = LHSUnsigned ? ICmpInst::ICMP_ULT : ICmpInst::ICMP_SLT;
5113 break;
5114 case FCmpInst::FCMP_ULE:
5115 case FCmpInst::FCMP_OLE:
5116 Pred = LHSUnsigned ? ICmpInst::ICMP_ULE : ICmpInst::ICMP_SLE;
5117 break;
5118 case FCmpInst::FCMP_UNE:
5119 case FCmpInst::FCMP_ONE:
5120 Pred = ICmpInst::ICMP_NE;
5121 break;
5122 case FCmpInst::FCMP_ORD:
Craig Topperbb4069e2017-07-07 23:16:26 +00005123 return replaceInstUsesWith(I, Builder.getTrue());
Chris Lattner2188e402010-01-04 07:37:31 +00005124 case FCmpInst::FCMP_UNO:
Craig Topperbb4069e2017-07-07 23:16:26 +00005125 return replaceInstUsesWith(I, Builder.getFalse());
Chris Lattner2188e402010-01-04 07:37:31 +00005126 }
Jim Grosbach129c52a2011-09-30 18:09:53 +00005127
Chris Lattner2188e402010-01-04 07:37:31 +00005128 // Now we know that the APFloat is a normal number, zero or inf.
Jim Grosbach129c52a2011-09-30 18:09:53 +00005129
Chris Lattner2188e402010-01-04 07:37:31 +00005130 // See if the FP constant is too large for the integer. For example,
5131 // comparing an i8 to 300.0.
5132 unsigned IntWidth = IntTy->getScalarSizeInBits();
Jim Grosbach129c52a2011-09-30 18:09:53 +00005133
Chris Lattner2188e402010-01-04 07:37:31 +00005134 if (!LHSUnsigned) {
5135 // If the RHS value is > SignedMax, fold the comparison. This handles +INF
5136 // and large values.
Michael Gottesman79b09672013-06-27 21:58:19 +00005137 APFloat SMax(RHS.getSemantics());
Chris Lattner2188e402010-01-04 07:37:31 +00005138 SMax.convertFromAPInt(APInt::getSignedMaxValue(IntWidth), true,
5139 APFloat::rmNearestTiesToEven);
5140 if (SMax.compare(RHS) == APFloat::cmpLessThan) { // smax < 13123.0
5141 if (Pred == ICmpInst::ICMP_NE || Pred == ICmpInst::ICMP_SLT ||
5142 Pred == ICmpInst::ICMP_SLE)
Craig Topperbb4069e2017-07-07 23:16:26 +00005143 return replaceInstUsesWith(I, Builder.getTrue());
5144 return replaceInstUsesWith(I, Builder.getFalse());
Chris Lattner2188e402010-01-04 07:37:31 +00005145 }
5146 } else {
5147 // If the RHS value is > UnsignedMax, fold the comparison. This handles
5148 // +INF and large values.
Michael Gottesman79b09672013-06-27 21:58:19 +00005149 APFloat UMax(RHS.getSemantics());
Chris Lattner2188e402010-01-04 07:37:31 +00005150 UMax.convertFromAPInt(APInt::getMaxValue(IntWidth), false,
5151 APFloat::rmNearestTiesToEven);
5152 if (UMax.compare(RHS) == APFloat::cmpLessThan) { // umax < 13123.0
5153 if (Pred == ICmpInst::ICMP_NE || Pred == ICmpInst::ICMP_ULT ||
5154 Pred == ICmpInst::ICMP_ULE)
Craig Topperbb4069e2017-07-07 23:16:26 +00005155 return replaceInstUsesWith(I, Builder.getTrue());
5156 return replaceInstUsesWith(I, Builder.getFalse());
Chris Lattner2188e402010-01-04 07:37:31 +00005157 }
5158 }
Jim Grosbach129c52a2011-09-30 18:09:53 +00005159
Chris Lattner2188e402010-01-04 07:37:31 +00005160 if (!LHSUnsigned) {
5161 // See if the RHS value is < SignedMin.
Michael Gottesman79b09672013-06-27 21:58:19 +00005162 APFloat SMin(RHS.getSemantics());
Chris Lattner2188e402010-01-04 07:37:31 +00005163 SMin.convertFromAPInt(APInt::getSignedMinValue(IntWidth), true,
5164 APFloat::rmNearestTiesToEven);
5165 if (SMin.compare(RHS) == APFloat::cmpGreaterThan) { // smin > 12312.0
5166 if (Pred == ICmpInst::ICMP_NE || Pred == ICmpInst::ICMP_SGT ||
5167 Pred == ICmpInst::ICMP_SGE)
Craig Topperbb4069e2017-07-07 23:16:26 +00005168 return replaceInstUsesWith(I, Builder.getTrue());
5169 return replaceInstUsesWith(I, Builder.getFalse());
Chris Lattner2188e402010-01-04 07:37:31 +00005170 }
Devang Patel698452b2012-02-13 23:05:18 +00005171 } else {
5172 // See if the RHS value is < UnsignedMin.
Michael Gottesman79b09672013-06-27 21:58:19 +00005173 APFloat SMin(RHS.getSemantics());
Devang Patel698452b2012-02-13 23:05:18 +00005174 SMin.convertFromAPInt(APInt::getMinValue(IntWidth), true,
5175 APFloat::rmNearestTiesToEven);
5176 if (SMin.compare(RHS) == APFloat::cmpGreaterThan) { // umin > 12312.0
5177 if (Pred == ICmpInst::ICMP_NE || Pred == ICmpInst::ICMP_UGT ||
5178 Pred == ICmpInst::ICMP_UGE)
Craig Topperbb4069e2017-07-07 23:16:26 +00005179 return replaceInstUsesWith(I, Builder.getTrue());
5180 return replaceInstUsesWith(I, Builder.getFalse());
Devang Patel698452b2012-02-13 23:05:18 +00005181 }
Chris Lattner2188e402010-01-04 07:37:31 +00005182 }
5183
5184 // Okay, now we know that the FP constant fits in the range [SMIN, SMAX] or
5185 // [0, UMAX], but it may still be fractional. See if it is fractional by
5186 // casting the FP value to the integer value and back, checking for equality.
5187 // Don't do this for zero, because -0.0 is not fractional.
5188 Constant *RHSInt = LHSUnsigned
5189 ? ConstantExpr::getFPToUI(RHSC, IntTy)
5190 : ConstantExpr::getFPToSI(RHSC, IntTy);
5191 if (!RHS.isZero()) {
5192 bool Equal = LHSUnsigned
5193 ? ConstantExpr::getUIToFP(RHSInt, RHSC->getType()) == RHSC
5194 : ConstantExpr::getSIToFP(RHSInt, RHSC->getType()) == RHSC;
5195 if (!Equal) {
5196 // If we had a comparison against a fractional value, we have to adjust
5197 // the compare predicate and sometimes the value. RHSC is rounded towards
5198 // zero at this point.
5199 switch (Pred) {
5200 default: llvm_unreachable("Unexpected integer comparison!");
5201 case ICmpInst::ICMP_NE: // (float)int != 4.4 --> true
Craig Topperbb4069e2017-07-07 23:16:26 +00005202 return replaceInstUsesWith(I, Builder.getTrue());
Chris Lattner2188e402010-01-04 07:37:31 +00005203 case ICmpInst::ICMP_EQ: // (float)int == 4.4 --> false
Craig Topperbb4069e2017-07-07 23:16:26 +00005204 return replaceInstUsesWith(I, Builder.getFalse());
Chris Lattner2188e402010-01-04 07:37:31 +00005205 case ICmpInst::ICMP_ULE:
5206 // (float)int <= 4.4 --> int <= 4
5207 // (float)int <= -4.4 --> false
5208 if (RHS.isNegative())
Craig Topperbb4069e2017-07-07 23:16:26 +00005209 return replaceInstUsesWith(I, Builder.getFalse());
Chris Lattner2188e402010-01-04 07:37:31 +00005210 break;
5211 case ICmpInst::ICMP_SLE:
5212 // (float)int <= 4.4 --> int <= 4
5213 // (float)int <= -4.4 --> int < -4
5214 if (RHS.isNegative())
5215 Pred = ICmpInst::ICMP_SLT;
5216 break;
5217 case ICmpInst::ICMP_ULT:
5218 // (float)int < -4.4 --> false
5219 // (float)int < 4.4 --> int <= 4
5220 if (RHS.isNegative())
Craig Topperbb4069e2017-07-07 23:16:26 +00005221 return replaceInstUsesWith(I, Builder.getFalse());
Chris Lattner2188e402010-01-04 07:37:31 +00005222 Pred = ICmpInst::ICMP_ULE;
5223 break;
5224 case ICmpInst::ICMP_SLT:
5225 // (float)int < -4.4 --> int < -4
5226 // (float)int < 4.4 --> int <= 4
5227 if (!RHS.isNegative())
5228 Pred = ICmpInst::ICMP_SLE;
5229 break;
5230 case ICmpInst::ICMP_UGT:
5231 // (float)int > 4.4 --> int > 4
5232 // (float)int > -4.4 --> true
5233 if (RHS.isNegative())
Craig Topperbb4069e2017-07-07 23:16:26 +00005234 return replaceInstUsesWith(I, Builder.getTrue());
Chris Lattner2188e402010-01-04 07:37:31 +00005235 break;
5236 case ICmpInst::ICMP_SGT:
5237 // (float)int > 4.4 --> int > 4
5238 // (float)int > -4.4 --> int >= -4
5239 if (RHS.isNegative())
5240 Pred = ICmpInst::ICMP_SGE;
5241 break;
5242 case ICmpInst::ICMP_UGE:
5243 // (float)int >= -4.4 --> true
5244 // (float)int >= 4.4 --> int > 4
Bob Wilson61f3ad52012-08-07 22:35:16 +00005245 if (RHS.isNegative())
Craig Topperbb4069e2017-07-07 23:16:26 +00005246 return replaceInstUsesWith(I, Builder.getTrue());
Chris Lattner2188e402010-01-04 07:37:31 +00005247 Pred = ICmpInst::ICMP_UGT;
5248 break;
5249 case ICmpInst::ICMP_SGE:
5250 // (float)int >= -4.4 --> int >= -4
5251 // (float)int >= 4.4 --> int > 4
5252 if (!RHS.isNegative())
5253 Pred = ICmpInst::ICMP_SGT;
5254 break;
5255 }
5256 }
5257 }
5258
5259 // Lower this FP comparison into an appropriate integer version of the
5260 // comparison.
5261 return new ICmpInst(Pred, LHSI->getOperand(0), RHSInt);
5262}
5263
Sanjay Patelc3f50ff2018-09-27 15:59:24 +00005264/// Fold (C / X) < 0.0 --> X < 0.0 if possible. Swap predicate if necessary.
5265static Instruction *foldFCmpReciprocalAndZero(FCmpInst &I, Instruction *LHSI,
5266 Constant *RHSC) {
5267 // When C is not 0.0 and infinities are not allowed:
5268 // (C / X) < 0.0 is a sign-bit test of X
5269 // (C / X) < 0.0 --> X < 0.0 (if C is positive)
5270 // (C / X) < 0.0 --> X > 0.0 (if C is negative, swap the predicate)
5271 //
5272 // Proof:
5273 // Multiply (C / X) < 0.0 by X * X / C.
5274 // - X is non zero, if it is the flag 'ninf' is violated.
5275 // - C defines the sign of X * X * C. Thus it also defines whether to swap
5276 // the predicate. C is also non zero by definition.
5277 //
5278 // Thus X * X / C is non zero and the transformation is valid. [qed]
5279
5280 FCmpInst::Predicate Pred = I.getPredicate();
5281
5282 // Check that predicates are valid.
5283 if ((Pred != FCmpInst::FCMP_OGT) && (Pred != FCmpInst::FCMP_OLT) &&
5284 (Pred != FCmpInst::FCMP_OGE) && (Pred != FCmpInst::FCMP_OLE))
5285 return nullptr;
5286
5287 // Check that RHS operand is zero.
5288 if (!match(RHSC, m_AnyZeroFP()))
5289 return nullptr;
5290
5291 // Check fastmath flags ('ninf').
5292 if (!LHSI->hasNoInfs() || !I.hasNoInfs())
5293 return nullptr;
5294
5295 // Check the properties of the dividend. It must not be zero to avoid a
5296 // division by zero (see Proof).
5297 const APFloat *C;
5298 if (!match(LHSI->getOperand(0), m_APFloat(C)))
5299 return nullptr;
5300
5301 if (C->isZero())
5302 return nullptr;
5303
5304 // Get swapped predicate if necessary.
5305 if (C->isNegative())
5306 Pred = I.getSwappedPredicate();
5307
Sanjay Pateld1172a02018-11-07 00:00:42 +00005308 return new FCmpInst(Pred, LHSI->getOperand(1), RHSC, "", &I);
Sanjay Patelc3f50ff2018-09-27 15:59:24 +00005309}
5310
Sanjay Patel1c254c62018-10-31 16:34:43 +00005311/// Optimize fabs(X) compared with zero.
5312static Instruction *foldFabsWithFcmpZero(FCmpInst &I) {
5313 Value *X;
5314 if (!match(I.getOperand(0), m_Intrinsic<Intrinsic::fabs>(m_Value(X))) ||
5315 !match(I.getOperand(1), m_PosZeroFP()))
5316 return nullptr;
5317
Sanjay Patel57a08b32018-11-07 16:15:01 +00005318 auto replacePredAndOp0 = [](FCmpInst *I, FCmpInst::Predicate P, Value *X) {
5319 I->setPredicate(P);
5320 I->setOperand(0, X);
5321 return I;
5322 };
5323
Sanjay Patel1c254c62018-10-31 16:34:43 +00005324 switch (I.getPredicate()) {
5325 case FCmpInst::FCMP_UGE:
5326 case FCmpInst::FCMP_OLT:
5327 // fabs(X) >= 0.0 --> true
5328 // fabs(X) < 0.0 --> false
5329 llvm_unreachable("fcmp should have simplified");
5330
5331 case FCmpInst::FCMP_OGT:
5332 // fabs(X) > 0.0 --> X != 0.0
Sanjay Patel57a08b32018-11-07 16:15:01 +00005333 return replacePredAndOp0(&I, FCmpInst::FCMP_ONE, X);
Sanjay Patel1c254c62018-10-31 16:34:43 +00005334
Sanjay Patelfa5f1462018-11-07 15:33:03 +00005335 case FCmpInst::FCMP_UGT:
5336 // fabs(X) u> 0.0 --> X u!= 0.0
Sanjay Patel57a08b32018-11-07 16:15:01 +00005337 return replacePredAndOp0(&I, FCmpInst::FCMP_UNE, X);
Sanjay Patelfa5f1462018-11-07 15:33:03 +00005338
Sanjay Patel1c254c62018-10-31 16:34:43 +00005339 case FCmpInst::FCMP_OLE:
5340 // fabs(X) <= 0.0 --> X == 0.0
Sanjay Patel57a08b32018-11-07 16:15:01 +00005341 return replacePredAndOp0(&I, FCmpInst::FCMP_OEQ, X);
Sanjay Patel1c254c62018-10-31 16:34:43 +00005342
Sanjay Patelfa5f1462018-11-07 15:33:03 +00005343 case FCmpInst::FCMP_ULE:
5344 // fabs(X) u<= 0.0 --> X u== 0.0
Sanjay Patel57a08b32018-11-07 16:15:01 +00005345 return replacePredAndOp0(&I, FCmpInst::FCMP_UEQ, X);
Sanjay Patelfa5f1462018-11-07 15:33:03 +00005346
Sanjay Patel1c254c62018-10-31 16:34:43 +00005347 case FCmpInst::FCMP_OGE:
5348 // fabs(X) >= 0.0 --> !isnan(X)
5349 assert(!I.hasNoNaNs() && "fcmp should have simplified");
Sanjay Patel57a08b32018-11-07 16:15:01 +00005350 return replacePredAndOp0(&I, FCmpInst::FCMP_ORD, X);
Sanjay Patel1c254c62018-10-31 16:34:43 +00005351
Sanjay Patel76faf512018-11-07 15:11:32 +00005352 case FCmpInst::FCMP_ULT:
5353 // fabs(X) u< 0.0 --> isnan(X)
5354 assert(!I.hasNoNaNs() && "fcmp should have simplified");
Sanjay Patel57a08b32018-11-07 16:15:01 +00005355 return replacePredAndOp0(&I, FCmpInst::FCMP_UNO, X);
Sanjay Patel76faf512018-11-07 15:11:32 +00005356
Sanjay Patel1c254c62018-10-31 16:34:43 +00005357 case FCmpInst::FCMP_OEQ:
5358 case FCmpInst::FCMP_UEQ:
5359 case FCmpInst::FCMP_ONE:
5360 case FCmpInst::FCMP_UNE:
Sanjay Patelbb521e62018-11-07 15:44:26 +00005361 case FCmpInst::FCMP_ORD:
5362 case FCmpInst::FCMP_UNO:
5363 // Look through the fabs() because it doesn't change anything but the sign.
5364 // fabs(X) == 0.0 --> X == 0.0,
Sanjay Patel1c254c62018-10-31 16:34:43 +00005365 // fabs(X) != 0.0 --> X != 0.0
Sanjay Patelbb521e62018-11-07 15:44:26 +00005366 // isnan(fabs(X)) --> isnan(X)
5367 // !isnan(fabs(X) --> !isnan(X)
Sanjay Patel57a08b32018-11-07 16:15:01 +00005368 return replacePredAndOp0(&I, I.getPredicate(), X);
Sanjay Patel1c254c62018-10-31 16:34:43 +00005369
5370 default:
5371 return nullptr;
5372 }
5373}
5374
Chris Lattner2188e402010-01-04 07:37:31 +00005375Instruction *InstCombiner::visitFCmpInst(FCmpInst &I) {
5376 bool Changed = false;
Jim Grosbach129c52a2011-09-30 18:09:53 +00005377
Chris Lattner2188e402010-01-04 07:37:31 +00005378 /// Orders the operands of the compare so that they are listed from most
5379 /// complex to least complex. This puts constants before unary operators,
5380 /// before binary operators.
5381 if (getComplexity(I.getOperand(0)) < getComplexity(I.getOperand(1))) {
5382 I.swapOperands();
5383 Changed = true;
5384 }
5385
Sanjay Patel6b139462017-09-02 15:11:55 +00005386 const CmpInst::Predicate Pred = I.getPredicate();
Chris Lattner2188e402010-01-04 07:37:31 +00005387 Value *Op0 = I.getOperand(0), *Op1 = I.getOperand(1);
Sanjay Patel6b139462017-09-02 15:11:55 +00005388 if (Value *V = SimplifyFCmpInst(Pred, Op0, Op1, I.getFastMathFlags(),
5389 SQ.getWithInstruction(&I)))
Sanjay Patel4b198802016-02-01 22:23:39 +00005390 return replaceInstUsesWith(I, V);
Chris Lattner2188e402010-01-04 07:37:31 +00005391
5392 // Simplify 'fcmp pred X, X'
5393 if (Op0 == Op1) {
Sanjay Patel6b139462017-09-02 15:11:55 +00005394 switch (Pred) {
5395 default: break;
Chris Lattner2188e402010-01-04 07:37:31 +00005396 case FCmpInst::FCMP_UNO: // True if unordered: isnan(X) | isnan(Y)
5397 case FCmpInst::FCMP_ULT: // True if unordered or less than
5398 case FCmpInst::FCMP_UGT: // True if unordered or greater than
5399 case FCmpInst::FCMP_UNE: // True if unordered or not equal
5400 // Canonicalize these to be 'fcmp uno %X, 0.0'.
5401 I.setPredicate(FCmpInst::FCMP_UNO);
5402 I.setOperand(1, Constant::getNullValue(Op0->getType()));
5403 return &I;
Jim Grosbach129c52a2011-09-30 18:09:53 +00005404
Chris Lattner2188e402010-01-04 07:37:31 +00005405 case FCmpInst::FCMP_ORD: // True if ordered (no nans)
5406 case FCmpInst::FCMP_OEQ: // True if ordered and equal
5407 case FCmpInst::FCMP_OGE: // True if ordered and greater than or equal
5408 case FCmpInst::FCMP_OLE: // True if ordered and less than or equal
5409 // Canonicalize these to be 'fcmp ord %X, 0.0'.
5410 I.setPredicate(FCmpInst::FCMP_ORD);
5411 I.setOperand(1, Constant::getNullValue(Op0->getType()));
5412 return &I;
5413 }
5414 }
Jim Grosbach129c52a2011-09-30 18:09:53 +00005415
Sanjay Patel6840c5f2017-09-05 23:13:13 +00005416 // If we're just checking for a NaN (ORD/UNO) and have a non-NaN operand,
5417 // then canonicalize the operand to 0.0.
5418 if (Pred == CmpInst::FCMP_ORD || Pred == CmpInst::FCMP_UNO) {
Matt Arsenaultd54b7f02018-08-09 22:40:08 +00005419 if (!match(Op0, m_PosZeroFP()) && isKnownNeverNaN(Op0, &TLI)) {
Sanjay Patel6840c5f2017-09-05 23:13:13 +00005420 I.setOperand(0, ConstantFP::getNullValue(Op0->getType()));
5421 return &I;
5422 }
Matt Arsenaultd54b7f02018-08-09 22:40:08 +00005423 if (!match(Op1, m_PosZeroFP()) && isKnownNeverNaN(Op1, &TLI)) {
Sanjay Patel6840c5f2017-09-05 23:13:13 +00005424 I.setOperand(1, ConstantFP::getNullValue(Op0->getType()));
5425 return &I;
5426 }
5427 }
5428
James Molloy2b21a7c2015-05-20 18:41:25 +00005429 // Test if the FCmpInst instruction is used exclusively by a select as
5430 // part of a minimum or maximum operation. If so, refrain from doing
5431 // any other folding. This helps out other analyses which understand
5432 // non-obfuscated minimum and maximum idioms, such as ScalarEvolution
5433 // and CodeGen. And in this case, at least one of the comparison
5434 // operands has at least one user besides the compare (the select),
5435 // which would often largely negate the benefit of folding anyway.
5436 if (I.hasOneUse())
Craig Topperd3e57812017-11-12 02:28:21 +00005437 if (SelectInst *SI = dyn_cast<SelectInst>(I.user_back())) {
5438 Value *A, *B;
5439 SelectPatternResult SPR = matchSelectPattern(SI, A, B);
5440 if (SPR.Flavor != SPF_UNKNOWN)
James Molloy2b21a7c2015-05-20 18:41:25 +00005441 return nullptr;
Craig Topperd3e57812017-11-12 02:28:21 +00005442 }
James Molloy2b21a7c2015-05-20 18:41:25 +00005443
Sanjay Patelc26fd1e2018-11-05 17:26:42 +00005444 // The sign of 0.0 is ignored by fcmp, so canonicalize to +0.0:
5445 // fcmp Pred X, -0.0 --> fcmp Pred X, 0.0
5446 if (match(Op1, m_AnyZeroFP()) && !match(Op1, m_PosZeroFP())) {
5447 I.setOperand(1, ConstantFP::getNullValue(Op1->getType()));
5448 return &I;
5449 }
5450
Sanjay Patel4c39dfc2018-10-30 20:52:25 +00005451 // Handle fcmp with instruction LHS and constant RHS.
5452 Instruction *LHSI;
5453 Constant *RHSC;
5454 if (match(Op0, m_Instruction(LHSI)) && match(Op1, m_Constant(RHSC))) {
5455 switch (LHSI->getOpcode()) {
Sanjay Patel4c39dfc2018-10-30 20:52:25 +00005456 case Instruction::PHI:
5457 // Only fold fcmp into the PHI if the phi and fcmp are in the same
5458 // block. If in the same block, we're encouraging jump threading. If
5459 // not, we are just pessimizing the code by making an i1 phi.
5460 if (LHSI->getParent() == I.getParent())
5461 if (Instruction *NV = foldOpIntoPhi(I, cast<PHINode>(LHSI)))
Chris Lattner2188e402010-01-04 07:37:31 +00005462 return NV;
Sanjay Patel4c39dfc2018-10-30 20:52:25 +00005463 break;
5464 case Instruction::SIToFP:
5465 case Instruction::UIToFP:
5466 if (Instruction *NV = foldFCmpIntToFPConst(I, LHSI, RHSC))
5467 return NV;
5468 break;
Sanjay Patel4c39dfc2018-10-30 20:52:25 +00005469 case Instruction::FDiv:
5470 if (Instruction *NV = foldFCmpReciprocalAndZero(I, LHSI, RHSC))
5471 return NV;
5472 break;
5473 case Instruction::Load:
5474 if (auto *GEP = dyn_cast<GetElementPtrInst>(LHSI->getOperand(0)))
5475 if (auto *GV = dyn_cast<GlobalVariable>(GEP->getOperand(0)))
5476 if (GV->isConstant() && GV->hasDefinitiveInitializer() &&
5477 !cast<LoadInst>(LHSI)->isVolatile())
5478 if (Instruction *Res = foldCmpLoadFromIndexedGlobal(GEP, GV, I))
5479 return Res;
5480 break;
Sanjay Patel1c254c62018-10-31 16:34:43 +00005481 }
Chris Lattner2188e402010-01-04 07:37:31 +00005482 }
5483
Sanjay Pateld1172a02018-11-07 00:00:42 +00005484 if (Instruction *R = foldFabsWithFcmpZero(I))
5485 return R;
5486
Benjamin Kramerd159d942011-03-31 10:12:22 +00005487 Value *X, *Y;
Sanjay Patel70282a02018-11-06 15:49:45 +00005488 if (match(Op0, m_FNeg(m_Value(X)))) {
Sanjay Pateld1172a02018-11-07 00:00:42 +00005489 // fcmp pred (fneg X), (fneg Y) -> fcmp swap(pred) X, Y
5490 if (match(Op1, m_FNeg(m_Value(Y))))
5491 return new FCmpInst(I.getSwappedPredicate(), X, Y, "", &I);
Sanjay Patel70282a02018-11-06 15:49:45 +00005492
Sanjay Pateld1172a02018-11-07 00:00:42 +00005493 // fcmp pred (fneg X), C --> fcmp swap(pred) X, -C
Sanjay Patel70282a02018-11-06 15:49:45 +00005494 Constant *C;
5495 if (match(Op1, m_Constant(C))) {
Sanjay Patel70282a02018-11-06 15:49:45 +00005496 Constant *NegC = ConstantExpr::getFNeg(C);
Sanjay Pateld1172a02018-11-07 00:00:42 +00005497 return new FCmpInst(I.getSwappedPredicate(), X, NegC, "", &I);
Sanjay Patel70282a02018-11-06 15:49:45 +00005498 }
5499 }
Benjamin Kramerd159d942011-03-31 10:12:22 +00005500
Sanjay Patel7c3ee4d2018-11-06 16:37:35 +00005501 if (match(Op0, m_FPExt(m_Value(X)))) {
Sanjay Pateld1172a02018-11-07 00:00:42 +00005502 // fcmp (fpext X), (fpext Y) -> fcmp X, Y
5503 if (match(Op1, m_FPExt(m_Value(Y))) && X->getType() == Y->getType())
5504 return new FCmpInst(Pred, X, Y, "", &I);
Sanjay Patel7c3ee4d2018-11-06 16:37:35 +00005505
Sanjay Pateld1172a02018-11-07 00:00:42 +00005506 // fcmp (fpext X), C -> fcmp X, (fptrunc C) if fptrunc is lossless
Sanjay Patel724014a2018-11-06 17:20:20 +00005507 const APFloat *C;
5508 if (match(Op1, m_APFloat(C))) {
Sanjay Patel724014a2018-11-06 17:20:20 +00005509 const fltSemantics &FPSem =
5510 X->getType()->getScalarType()->getFltSemantics();
Sanjay Patel7c3ee4d2018-11-06 16:37:35 +00005511 bool Lossy;
Sanjay Patel724014a2018-11-06 17:20:20 +00005512 APFloat TruncC = *C;
5513 TruncC.convert(FPSem, APFloat::rmNearestTiesToEven, &Lossy);
Sanjay Patel7c3ee4d2018-11-06 16:37:35 +00005514
5515 // Avoid lossy conversions and denormals.
5516 // Zero is a special case that's OK to convert.
Sanjay Patel724014a2018-11-06 17:20:20 +00005517 APFloat Fabs = TruncC;
Sanjay Patel7c3ee4d2018-11-06 16:37:35 +00005518 Fabs.clearSign();
5519 if (!Lossy &&
5520 ((Fabs.compare(APFloat::getSmallestNormalized(FPSem)) !=
Sanjay Patel46bf3922018-11-06 16:45:27 +00005521 APFloat::cmpLessThan) || Fabs.isZero())) {
Sanjay Patel724014a2018-11-06 17:20:20 +00005522 Constant *NewC = ConstantFP::get(X->getType(), TruncC);
Sanjay Pateld1172a02018-11-07 00:00:42 +00005523 return new FCmpInst(Pred, X, NewC, "", &I);
Sanjay Patel46bf3922018-11-06 16:45:27 +00005524 }
Sanjay Patel7c3ee4d2018-11-06 16:37:35 +00005525 }
Sanjay Patel1b85f0022018-11-06 16:23:03 +00005526 }
Benjamin Kramer2ccfbc82011-03-31 10:11:58 +00005527
Sanjay Patel039f5562018-08-16 12:52:17 +00005528 if (I.getType()->isVectorTy())
5529 if (Instruction *Res = foldVectorCmp(I, Builder))
5530 return Res;
5531
Craig Topperf40110f2014-04-25 05:29:35 +00005532 return Changed ? &I : nullptr;
Chris Lattner2188e402010-01-04 07:37:31 +00005533}