blob: e14f44bb7069248f6b9d163472c06047f47a6a37 [file] [log] [blame]
Sanjoy Das083f3892016-05-18 22:55:34 +00001//===- GuardWidening.cpp - ---- Guard widening ----------------------------===//
2//
Chandler Carruth2946cd72019-01-19 08:50:56 +00003// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
4// See https://llvm.org/LICENSE.txt for license information.
5// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
Sanjoy Das083f3892016-05-18 22:55:34 +00006//
7//===----------------------------------------------------------------------===//
8//
9// This file implements the guard widening pass. The semantics of the
10// @llvm.experimental.guard intrinsic lets LLVM transform it so that it fails
11// more often that it did before the transform. This optimization is called
12// "widening" and can be used hoist and common runtime checks in situations like
13// these:
14//
15// %cmp0 = 7 u< Length
16// call @llvm.experimental.guard(i1 %cmp0) [ "deopt"(...) ]
17// call @unknown_side_effects()
18// %cmp1 = 9 u< Length
19// call @llvm.experimental.guard(i1 %cmp1) [ "deopt"(...) ]
20// ...
21//
22// =>
23//
24// %cmp0 = 9 u< Length
25// call @llvm.experimental.guard(i1 %cmp0) [ "deopt"(...) ]
26// call @unknown_side_effects()
27// ...
28//
29// If %cmp0 is false, @llvm.experimental.guard will "deoptimize" back to a
30// generic implementation of the same function, which will have the correct
31// semantics from that point onward. It is always _legal_ to deoptimize (so
32// replacing %cmp0 with false is "correct"), though it may not always be
33// profitable to do so.
34//
35// NB! This pass is a work in progress. It hasn't been tuned to be "production
36// ready" yet. It is known to have quadriatic running time and will not scale
37// to large numbers of guards
38//
39//===----------------------------------------------------------------------===//
40
41#include "llvm/Transforms/Scalar/GuardWidening.h"
Philip Reames9258e9d2018-04-27 17:29:10 +000042#include <functional>
Sanjoy Das083f3892016-05-18 22:55:34 +000043#include "llvm/ADT/DenseMap.h"
44#include "llvm/ADT/DepthFirstIterator.h"
Max Kazantseveb8e9c02018-07-31 04:37:11 +000045#include "llvm/ADT/Statistic.h"
Max Kazantseveded4ab2018-08-06 05:49:19 +000046#include "llvm/Analysis/BranchProbabilityInfo.h"
Max Kazantsev3c284bd2018-08-30 03:39:16 +000047#include "llvm/Analysis/GuardUtils.h"
Sanjoy Das083f3892016-05-18 22:55:34 +000048#include "llvm/Analysis/LoopInfo.h"
Philip Reames9258e9d2018-04-27 17:29:10 +000049#include "llvm/Analysis/LoopPass.h"
Sanjoy Das083f3892016-05-18 22:55:34 +000050#include "llvm/Analysis/PostDominators.h"
51#include "llvm/Analysis/ValueTracking.h"
Peter Collingbourneecdd58f2016-10-21 19:59:26 +000052#include "llvm/IR/ConstantRange.h"
Sanjoy Das083f3892016-05-18 22:55:34 +000053#include "llvm/IR/Dominators.h"
54#include "llvm/IR/IntrinsicInst.h"
55#include "llvm/IR/PatternMatch.h"
Chandler Carruth6bda14b2017-06-06 11:49:48 +000056#include "llvm/Pass.h"
Sanjoy Das083f3892016-05-18 22:55:34 +000057#include "llvm/Support/Debug.h"
Craig Topperb45eabc2017-04-26 16:39:58 +000058#include "llvm/Support/KnownBits.h"
Sanjoy Das083f3892016-05-18 22:55:34 +000059#include "llvm/Transforms/Scalar.h"
Philip Reames9258e9d2018-04-27 17:29:10 +000060#include "llvm/Transforms/Utils/LoopUtils.h"
Sanjoy Das083f3892016-05-18 22:55:34 +000061
62using namespace llvm;
63
64#define DEBUG_TYPE "guard-widening"
65
Max Kazantseveb8e9c02018-07-31 04:37:11 +000066STATISTIC(GuardsEliminated, "Number of eliminated guards");
Max Kazantseveded4ab2018-08-06 05:49:19 +000067STATISTIC(CondBranchEliminated, "Number of eliminated conditional branches");
68
69static cl::opt<bool> WidenFrequentBranches(
70 "guard-widening-widen-frequent-branches", cl::Hidden,
71 cl::desc("Widen conditions of explicit branches into dominating guards in "
72 "case if their taken frequency exceeds threshold set by "
73 "guard-widening-frequent-branch-threshold option"),
74 cl::init(false));
75
76static cl::opt<unsigned> FrequentBranchThreshold(
77 "guard-widening-frequent-branch-threshold", cl::Hidden,
78 cl::desc("When WidenFrequentBranches is set to true, this option is used "
79 "to determine which branches are frequently taken. The criteria "
80 "that a branch is taken more often than "
81 "((FrequentBranchThreshold - 1) / FrequentBranchThreshold), then "
82 "it is considered frequently taken"),
83 cl::init(1000));
84
Max Kazantsev2bb95e72019-02-13 09:56:30 +000085static cl::opt<bool>
86 WidenBranchGuards("guard-widening-widen-branch-guards", cl::Hidden,
87 cl::desc("Whether or not we should widen guards "
88 "expressed as branches by widenable conditions"),
89 cl::init(true));
Max Kazantseveb8e9c02018-07-31 04:37:11 +000090
Sanjoy Das083f3892016-05-18 22:55:34 +000091namespace {
92
Max Kazantseveded4ab2018-08-06 05:49:19 +000093// Get the condition of \p I. It can either be a guard or a conditional branch.
94static Value *getCondition(Instruction *I) {
95 if (IntrinsicInst *GI = dyn_cast<IntrinsicInst>(I)) {
96 assert(GI->getIntrinsicID() == Intrinsic::experimental_guard &&
97 "Bad guard intrinsic?");
98 return GI->getArgOperand(0);
99 }
Max Kazantsev2bb95e72019-02-13 09:56:30 +0000100 if (isGuardAsWidenableBranch(I)) {
101 auto *Cond = cast<BranchInst>(I)->getCondition();
102 return cast<BinaryOperator>(Cond)->getOperand(0);
103 }
Max Kazantseveded4ab2018-08-06 05:49:19 +0000104 return cast<BranchInst>(I)->getCondition();
Max Kazantsev65cd4832018-08-03 10:16:40 +0000105}
106
Max Kazantseveded4ab2018-08-06 05:49:19 +0000107// Set the condition for \p I to \p NewCond. \p I can either be a guard or a
108// conditional branch.
109static void setCondition(Instruction *I, Value *NewCond) {
110 if (IntrinsicInst *GI = dyn_cast<IntrinsicInst>(I)) {
111 assert(GI->getIntrinsicID() == Intrinsic::experimental_guard &&
112 "Bad guard intrinsic?");
113 GI->setArgOperand(0, NewCond);
114 return;
115 }
116 cast<BranchInst>(I)->setCondition(NewCond);
Max Kazantsev65cd4832018-08-03 10:16:40 +0000117}
118
Max Kazantsev65cd4832018-08-03 10:16:40 +0000119// Eliminates the guard instruction properly.
120static void eliminateGuard(Instruction *GuardInst) {
121 GuardInst->eraseFromParent();
122 ++GuardsEliminated;
123}
124
Sanjoy Das083f3892016-05-18 22:55:34 +0000125class GuardWideningImpl {
126 DominatorTree &DT;
Philip Reames502d44812018-04-27 23:15:56 +0000127 PostDominatorTree *PDT;
Sanjoy Das083f3892016-05-18 22:55:34 +0000128 LoopInfo &LI;
Max Kazantseveded4ab2018-08-06 05:49:19 +0000129 BranchProbabilityInfo *BPI;
Sanjoy Das083f3892016-05-18 22:55:34 +0000130
Philip Reames9258e9d2018-04-27 17:29:10 +0000131 /// Together, these describe the region of interest. This might be all of
132 /// the blocks within a function, or only a given loop's blocks and preheader.
133 DomTreeNode *Root;
134 std::function<bool(BasicBlock*)> BlockFilter;
135
Max Kazantseveded4ab2018-08-06 05:49:19 +0000136 /// The set of guards and conditional branches whose conditions have been
137 /// widened into dominating guards.
138 SmallVector<Instruction *, 16> EliminatedGuardsAndBranches;
Sanjoy Das083f3892016-05-18 22:55:34 +0000139
140 /// The set of guards which have been widened to include conditions to other
141 /// guards.
Max Kazantsev3327bca2018-07-30 07:07:32 +0000142 DenseSet<Instruction *> WidenedGuards;
Sanjoy Das083f3892016-05-18 22:55:34 +0000143
Max Kazantsev09802f42019-02-04 10:31:18 +0000144 /// Try to eliminate instruction \p Instr by widening it into an earlier
145 /// dominating guard. \p DFSI is the DFS iterator on the dominator tree that
146 /// is currently visiting the block containing \p Guard, and \p GuardsPerBlock
Sanjoy Das083f3892016-05-18 22:55:34 +0000147 /// maps BasicBlocks to the set of guards seen in that block.
Max Kazantsev09802f42019-02-04 10:31:18 +0000148 bool eliminateInstrViaWidening(
149 Instruction *Instr, const df_iterator<DomTreeNode *> &DFSI,
Max Kazantsev3327bca2018-07-30 07:07:32 +0000150 const DenseMap<BasicBlock *, SmallVector<Instruction *, 8>> &
Max Kazantsev5c490b42018-08-13 07:58:19 +0000151 GuardsPerBlock, bool InvertCondition = false);
Sanjoy Das083f3892016-05-18 22:55:34 +0000152
153 /// Used to keep track of which widening potential is more effective.
154 enum WideningScore {
155 /// Don't widen.
156 WS_IllegalOrNegative,
157
158 /// Widening is performance neutral as far as the cycles spent in check
159 /// conditions goes (but can still help, e.g., code layout, having less
160 /// deopt state).
161 WS_Neutral,
162
163 /// Widening is profitable.
164 WS_Positive,
165
166 /// Widening is very profitable. Not significantly different from \c
167 /// WS_Positive, except by the order.
168 WS_VeryPositive
169 };
170
171 static StringRef scoreTypeToString(WideningScore WS);
172
Max Kazantsev09802f42019-02-04 10:31:18 +0000173 /// Compute the score for widening the condition in \p DominatedInstr
Max Kazantsev13ab5cb2019-02-04 10:20:51 +0000174 /// into \p DominatingGuard. If \p InvertCond is set, then we widen the
Max Kazantsev5c490b42018-08-13 07:58:19 +0000175 /// inverted condition of the dominating guard.
Max Kazantsev09802f42019-02-04 10:31:18 +0000176 WideningScore computeWideningScore(Instruction *DominatedInstr,
Max Kazantsev3327bca2018-07-30 07:07:32 +0000177 Instruction *DominatingGuard,
Max Kazantsev5c490b42018-08-13 07:58:19 +0000178 bool InvertCond);
Sanjoy Das083f3892016-05-18 22:55:34 +0000179
180 /// Helper to check if \p V can be hoisted to \p InsertPos.
Max Kazantsev3fe9ad72019-02-13 11:54:45 +0000181 bool isAvailableAt(const Value *V, const Instruction *InsertPos) const {
182 SmallPtrSet<const Instruction *, 8> Visited;
Sanjoy Das083f3892016-05-18 22:55:34 +0000183 return isAvailableAt(V, InsertPos, Visited);
184 }
185
Max Kazantsev3fe9ad72019-02-13 11:54:45 +0000186 bool isAvailableAt(const Value *V, const Instruction *InsertPos,
187 SmallPtrSetImpl<const Instruction *> &Visited) const;
Sanjoy Das083f3892016-05-18 22:55:34 +0000188
189 /// Helper to hoist \p V to \p InsertPos. Guaranteed to succeed if \c
190 /// isAvailableAt returned true.
Max Kazantsev3fe9ad72019-02-13 11:54:45 +0000191 void makeAvailableAt(Value *V, Instruction *InsertPos) const;
Sanjoy Das083f3892016-05-18 22:55:34 +0000192
193 /// Common helper used by \c widenGuard and \c isWideningCondProfitable. Try
Max Kazantsev5c490b42018-08-13 07:58:19 +0000194 /// to generate an expression computing the logical AND of \p Cond0 and (\p
195 /// Cond1 XOR \p InvertCondition).
196 /// Return true if the expression computing the AND is only as
Sanjoy Das083f3892016-05-18 22:55:34 +0000197 /// expensive as computing one of the two. If \p InsertPt is true then
198 /// actually generate the resulting expression, make it available at \p
199 /// InsertPt and return it in \p Result (else no change to the IR is made).
200 bool widenCondCommon(Value *Cond0, Value *Cond1, Instruction *InsertPt,
Max Kazantsev5c490b42018-08-13 07:58:19 +0000201 Value *&Result, bool InvertCondition);
Sanjoy Das083f3892016-05-18 22:55:34 +0000202
Sanjoy Dasf5f03312016-05-19 22:55:46 +0000203 /// Represents a range check of the form \c Base + \c Offset u< \c Length,
204 /// with the constraint that \c Length is not negative. \c CheckInst is the
205 /// pre-existing instruction in the IR that computes the result of this range
206 /// check.
Sanjoy Dasbe991532016-05-24 20:54:45 +0000207 class RangeCheck {
Max Kazantsev3fe9ad72019-02-13 11:54:45 +0000208 const Value *Base;
209 const ConstantInt *Offset;
210 const Value *Length;
Sanjoy Dasf5f03312016-05-19 22:55:46 +0000211 ICmpInst *CheckInst;
212
Sanjoy Dasbe991532016-05-24 20:54:45 +0000213 public:
Max Kazantsev3fe9ad72019-02-13 11:54:45 +0000214 explicit RangeCheck(const Value *Base, const ConstantInt *Offset,
215 const Value *Length, ICmpInst *CheckInst)
Sanjoy Dasf5f03312016-05-19 22:55:46 +0000216 : Base(Base), Offset(Offset), Length(Length), CheckInst(CheckInst) {}
217
Max Kazantsev3fe9ad72019-02-13 11:54:45 +0000218 void setBase(const Value *NewBase) { Base = NewBase; }
219 void setOffset(const ConstantInt *NewOffset) { Offset = NewOffset; }
Sanjoy Dasbe991532016-05-24 20:54:45 +0000220
Max Kazantsev3fe9ad72019-02-13 11:54:45 +0000221 const Value *getBase() const { return Base; }
222 const ConstantInt *getOffset() const { return Offset; }
Sanjoy Dasbe991532016-05-24 20:54:45 +0000223 const APInt &getOffsetValue() const { return getOffset()->getValue(); }
Max Kazantsev3fe9ad72019-02-13 11:54:45 +0000224 const Value *getLength() const { return Length; };
Sanjoy Dasbe991532016-05-24 20:54:45 +0000225 ICmpInst *getCheckInst() const { return CheckInst; }
226
Sanjoy Dasf5f03312016-05-19 22:55:46 +0000227 void print(raw_ostream &OS, bool PrintTypes = false) {
228 OS << "Base: ";
229 Base->printAsOperand(OS, PrintTypes);
230 OS << " Offset: ";
231 Offset->printAsOperand(OS, PrintTypes);
232 OS << " Length: ";
233 Length->printAsOperand(OS, PrintTypes);
234 }
235
236 LLVM_DUMP_METHOD void dump() {
237 print(dbgs());
238 dbgs() << "\n";
239 }
240 };
241
242 /// Parse \p CheckCond into a conjunction (logical-and) of range checks; and
243 /// append them to \p Checks. Returns true on success, may clobber \c Checks
244 /// on failure.
245 bool parseRangeChecks(Value *CheckCond, SmallVectorImpl<RangeCheck> &Checks) {
Max Kazantsev3fe9ad72019-02-13 11:54:45 +0000246 SmallPtrSet<const Value *, 8> Visited;
Sanjoy Dasf5f03312016-05-19 22:55:46 +0000247 return parseRangeChecks(CheckCond, Checks, Visited);
248 }
249
250 bool parseRangeChecks(Value *CheckCond, SmallVectorImpl<RangeCheck> &Checks,
Max Kazantsev3fe9ad72019-02-13 11:54:45 +0000251 SmallPtrSetImpl<const Value *> &Visited);
Sanjoy Dasf5f03312016-05-19 22:55:46 +0000252
253 /// Combine the checks in \p Checks into a smaller set of checks and append
254 /// them into \p CombinedChecks. Return true on success (i.e. all of checks
255 /// in \p Checks were combined into \p CombinedChecks). Clobbers \p Checks
256 /// and \p CombinedChecks on success and on failure.
257 bool combineRangeChecks(SmallVectorImpl<RangeCheck> &Checks,
Max Kazantsev3fe9ad72019-02-13 11:54:45 +0000258 SmallVectorImpl<RangeCheck> &CombinedChecks) const;
Sanjoy Dasf5f03312016-05-19 22:55:46 +0000259
Sanjoy Das083f3892016-05-18 22:55:34 +0000260 /// Can we compute the logical AND of \p Cond0 and \p Cond1 for the price of
261 /// computing only one of the two expressions?
Max Kazantsev5c490b42018-08-13 07:58:19 +0000262 bool isWideningCondProfitable(Value *Cond0, Value *Cond1, bool InvertCond) {
Sanjoy Das083f3892016-05-18 22:55:34 +0000263 Value *ResultUnused;
Max Kazantsev5c490b42018-08-13 07:58:19 +0000264 return widenCondCommon(Cond0, Cond1, /*InsertPt=*/nullptr, ResultUnused,
265 InvertCond);
Sanjoy Das083f3892016-05-18 22:55:34 +0000266 }
267
Max Kazantsev5c490b42018-08-13 07:58:19 +0000268 /// If \p InvertCondition is false, Widen \p ToWiden to fail if
269 /// \p NewCondition is false, otherwise make it fail if \p NewCondition is
270 /// true (in addition to whatever it is already checking).
271 void widenGuard(Instruction *ToWiden, Value *NewCondition,
272 bool InvertCondition) {
Sanjoy Das083f3892016-05-18 22:55:34 +0000273 Value *Result;
Max Kazantsev2bb95e72019-02-13 09:56:30 +0000274 widenCondCommon(getCondition(ToWiden), NewCondition, ToWiden, Result,
Max Kazantsev5c490b42018-08-13 07:58:19 +0000275 InvertCondition);
Max Kazantsev2bb95e72019-02-13 09:56:30 +0000276 Value *WidenableCondition = nullptr;
277 if (isGuardAsWidenableBranch(ToWiden)) {
278 auto *Cond = cast<BranchInst>(ToWiden)->getCondition();
279 WidenableCondition = cast<BinaryOperator>(Cond)->getOperand(1);
280 }
281 if (WidenableCondition)
282 Result = BinaryOperator::CreateAnd(Result, WidenableCondition,
283 "guard.chk", ToWiden);
Max Kazantseveded4ab2018-08-06 05:49:19 +0000284 setCondition(ToWiden, Result);
Sanjoy Das083f3892016-05-18 22:55:34 +0000285 }
286
287public:
Philip Reames9258e9d2018-04-27 17:29:10 +0000288
Philip Reames502d44812018-04-27 23:15:56 +0000289 explicit GuardWideningImpl(DominatorTree &DT, PostDominatorTree *PDT,
Max Kazantseveded4ab2018-08-06 05:49:19 +0000290 LoopInfo &LI, BranchProbabilityInfo *BPI,
291 DomTreeNode *Root,
Philip Reames9258e9d2018-04-27 17:29:10 +0000292 std::function<bool(BasicBlock*)> BlockFilter)
Max Kazantseveded4ab2018-08-06 05:49:19 +0000293 : DT(DT), PDT(PDT), LI(LI), BPI(BPI), Root(Root), BlockFilter(BlockFilter)
294 {}
Sanjoy Das083f3892016-05-18 22:55:34 +0000295
296 /// The entry point for this pass.
297 bool run();
298};
Sanjoy Das083f3892016-05-18 22:55:34 +0000299}
300
Max Kazantsev2bb95e72019-02-13 09:56:30 +0000301static bool isSupportedGuardInstruction(const Instruction *Insn) {
302 if (isGuard(Insn))
303 return true;
304 if (WidenBranchGuards && isGuardAsWidenableBranch(Insn))
305 return true;
306 return false;
307}
308
Sanjoy Das083f3892016-05-18 22:55:34 +0000309bool GuardWideningImpl::run() {
Max Kazantsev3327bca2018-07-30 07:07:32 +0000310 DenseMap<BasicBlock *, SmallVector<Instruction *, 8>> GuardsInBlock;
Sanjoy Das083f3892016-05-18 22:55:34 +0000311 bool Changed = false;
Max Kazantseveded4ab2018-08-06 05:49:19 +0000312 Optional<BranchProbability> LikelyTaken = None;
313 if (WidenFrequentBranches && BPI) {
314 unsigned Threshold = FrequentBranchThreshold;
315 assert(Threshold > 0 && "Zero threshold makes no sense!");
Max Kazantsev778f62b2018-08-06 06:35:21 +0000316 LikelyTaken = BranchProbability(Threshold - 1, Threshold);
Max Kazantseveded4ab2018-08-06 05:49:19 +0000317 }
Sanjoy Das083f3892016-05-18 22:55:34 +0000318
Philip Reames9258e9d2018-04-27 17:29:10 +0000319 for (auto DFI = df_begin(Root), DFE = df_end(Root);
Sanjoy Das083f3892016-05-18 22:55:34 +0000320 DFI != DFE; ++DFI) {
321 auto *BB = (*DFI)->getBlock();
Philip Reames9258e9d2018-04-27 17:29:10 +0000322 if (!BlockFilter(BB))
323 continue;
324
Sanjoy Das083f3892016-05-18 22:55:34 +0000325 auto &CurrentList = GuardsInBlock[BB];
326
327 for (auto &I : *BB)
Max Kazantsev2bb95e72019-02-13 09:56:30 +0000328 if (isSupportedGuardInstruction(&I))
Max Kazantsev3327bca2018-07-30 07:07:32 +0000329 CurrentList.push_back(cast<Instruction>(&I));
Sanjoy Das083f3892016-05-18 22:55:34 +0000330
331 for (auto *II : CurrentList)
Max Kazantsev09802f42019-02-04 10:31:18 +0000332 Changed |= eliminateInstrViaWidening(II, DFI, GuardsInBlock);
Max Kazantseveded4ab2018-08-06 05:49:19 +0000333 if (WidenFrequentBranches && BPI)
334 if (auto *BI = dyn_cast<BranchInst>(BB->getTerminator()))
Max Kazantsev5c490b42018-08-13 07:58:19 +0000335 if (BI->isConditional()) {
336 // If one of branches of a conditional is likely taken, try to
337 // eliminate it.
338 if (BPI->getEdgeProbability(BB, 0U) >= *LikelyTaken)
Max Kazantsev09802f42019-02-04 10:31:18 +0000339 Changed |= eliminateInstrViaWidening(BI, DFI, GuardsInBlock);
Max Kazantsev5c490b42018-08-13 07:58:19 +0000340 else if (BPI->getEdgeProbability(BB, 1U) >= *LikelyTaken)
Max Kazantsev09802f42019-02-04 10:31:18 +0000341 Changed |= eliminateInstrViaWidening(BI, DFI, GuardsInBlock,
Max Kazantsev5c490b42018-08-13 07:58:19 +0000342 /*InvertCondition*/true);
343 }
Sanjoy Das083f3892016-05-18 22:55:34 +0000344 }
345
Max Kazantseveded4ab2018-08-06 05:49:19 +0000346 assert(EliminatedGuardsAndBranches.empty() || Changed);
347 for (auto *I : EliminatedGuardsAndBranches)
348 if (!WidenedGuards.count(I)) {
349 assert(isa<ConstantInt>(getCondition(I)) && "Should be!");
Max Kazantsev2bb95e72019-02-13 09:56:30 +0000350 if (isSupportedGuardInstruction(I))
Max Kazantseveded4ab2018-08-06 05:49:19 +0000351 eliminateGuard(I);
352 else {
353 assert(isa<BranchInst>(I) &&
354 "Eliminated something other than guard or branch?");
355 ++CondBranchEliminated;
356 }
357 }
Sanjoy Das083f3892016-05-18 22:55:34 +0000358
359 return Changed;
360}
361
Max Kazantsev09802f42019-02-04 10:31:18 +0000362bool GuardWideningImpl::eliminateInstrViaWidening(
363 Instruction *Instr, const df_iterator<DomTreeNode *> &DFSI,
Max Kazantsev3327bca2018-07-30 07:07:32 +0000364 const DenseMap<BasicBlock *, SmallVector<Instruction *, 8>> &
Max Kazantsev5c490b42018-08-13 07:58:19 +0000365 GuardsInBlock, bool InvertCondition) {
Max Kazantsev611d6452018-08-22 02:40:49 +0000366 // Ignore trivial true or false conditions. These instructions will be
367 // trivially eliminated by any cleanup pass. Do not erase them because other
368 // guards can possibly be widened into them.
Max Kazantsev09802f42019-02-04 10:31:18 +0000369 if (isa<ConstantInt>(getCondition(Instr)))
Max Kazantsev611d6452018-08-22 02:40:49 +0000370 return false;
371
Max Kazantsev3327bca2018-07-30 07:07:32 +0000372 Instruction *BestSoFar = nullptr;
Sanjoy Das083f3892016-05-18 22:55:34 +0000373 auto BestScoreSoFar = WS_IllegalOrNegative;
Sanjoy Das083f3892016-05-18 22:55:34 +0000374
375 // In the set of dominating guards, find the one we can merge GuardInst with
376 // for the most profit.
377 for (unsigned i = 0, e = DFSI.getPathLength(); i != e; ++i) {
378 auto *CurBB = DFSI.getPath(i)->getBlock();
Philip Reames9258e9d2018-04-27 17:29:10 +0000379 if (!BlockFilter(CurBB))
380 break;
Sanjoy Das083f3892016-05-18 22:55:34 +0000381 assert(GuardsInBlock.count(CurBB) && "Must have been populated by now!");
382 const auto &GuardsInCurBB = GuardsInBlock.find(CurBB)->second;
383
384 auto I = GuardsInCurBB.begin();
Max Kazantsevcd48ac32019-02-06 11:27:00 +0000385 auto E = Instr->getParent() == CurBB
386 ? std::find(GuardsInCurBB.begin(), GuardsInCurBB.end(), Instr)
387 : GuardsInCurBB.end();
Sanjoy Das083f3892016-05-18 22:55:34 +0000388
389#ifndef NDEBUG
390 {
391 unsigned Index = 0;
392 for (auto &I : *CurBB) {
393 if (Index == GuardsInCurBB.size())
394 break;
395 if (GuardsInCurBB[Index] == &I)
396 Index++;
397 }
398 assert(Index == GuardsInCurBB.size() &&
399 "Guards expected to be in order!");
400 }
401#endif
402
Max Kazantsev09802f42019-02-04 10:31:18 +0000403 assert((i == (e - 1)) == (Instr->getParent() == CurBB) && "Bad DFS?");
Sanjoy Das083f3892016-05-18 22:55:34 +0000404
Sanjoy Das083f3892016-05-18 22:55:34 +0000405 for (auto *Candidate : make_range(I, E)) {
Max Kazantsev09802f42019-02-04 10:31:18 +0000406 auto Score = computeWideningScore(Instr, Candidate, InvertCondition);
407 LLVM_DEBUG(dbgs() << "Score between " << *getCondition(Instr)
Max Kazantseveded4ab2018-08-06 05:49:19 +0000408 << " and " << *getCondition(Candidate) << " is "
Nicola Zaghend34e60c2018-05-14 12:53:11 +0000409 << scoreTypeToString(Score) << "\n");
Sanjoy Das083f3892016-05-18 22:55:34 +0000410 if (Score > BestScoreSoFar) {
411 BestScoreSoFar = Score;
412 BestSoFar = Candidate;
413 }
414 }
415 }
416
417 if (BestScoreSoFar == WS_IllegalOrNegative) {
Max Kazantsev09802f42019-02-04 10:31:18 +0000418 LLVM_DEBUG(dbgs() << "Did not eliminate guard " << *Instr << "\n");
Sanjoy Das083f3892016-05-18 22:55:34 +0000419 return false;
420 }
421
Max Kazantsev09802f42019-02-04 10:31:18 +0000422 assert(BestSoFar != Instr && "Should have never visited same guard!");
423 assert(DT.dominates(BestSoFar, Instr) && "Should be!");
Sanjoy Das083f3892016-05-18 22:55:34 +0000424
Max Kazantsev09802f42019-02-04 10:31:18 +0000425 LLVM_DEBUG(dbgs() << "Widening " << *Instr << " into " << *BestSoFar
Nicola Zaghend34e60c2018-05-14 12:53:11 +0000426 << " with score " << scoreTypeToString(BestScoreSoFar)
427 << "\n");
Max Kazantsev09802f42019-02-04 10:31:18 +0000428 widenGuard(BestSoFar, getCondition(Instr), InvertCondition);
Max Kazantsev5c490b42018-08-13 07:58:19 +0000429 auto NewGuardCondition = InvertCondition
Max Kazantsev09802f42019-02-04 10:31:18 +0000430 ? ConstantInt::getFalse(Instr->getContext())
431 : ConstantInt::getTrue(Instr->getContext());
432 setCondition(Instr, NewGuardCondition);
433 EliminatedGuardsAndBranches.push_back(Instr);
Sanjoy Das083f3892016-05-18 22:55:34 +0000434 WidenedGuards.insert(BestSoFar);
435 return true;
436}
437
Max Kazantsev13ab5cb2019-02-04 10:20:51 +0000438GuardWideningImpl::WideningScore
Max Kazantsev09802f42019-02-04 10:31:18 +0000439GuardWideningImpl::computeWideningScore(Instruction *DominatedInstr,
Max Kazantsev13ab5cb2019-02-04 10:20:51 +0000440 Instruction *DominatingGuard,
441 bool InvertCond) {
Max Kazantsev09802f42019-02-04 10:31:18 +0000442 Loop *DominatedInstrLoop = LI.getLoopFor(DominatedInstr->getParent());
Max Kazantsev13ab5cb2019-02-04 10:20:51 +0000443 Loop *DominatingGuardLoop = LI.getLoopFor(DominatingGuard->getParent());
Sanjoy Das083f3892016-05-18 22:55:34 +0000444 bool HoistingOutOfLoop = false;
445
Max Kazantsev09802f42019-02-04 10:31:18 +0000446 if (DominatingGuardLoop != DominatedInstrLoop) {
Philip Reamesde5a1da2018-04-27 17:41:37 +0000447 // Be conservative and don't widen into a sibling loop. TODO: If the
448 // sibling is colder, we should consider allowing this.
Sanjoy Das083f3892016-05-18 22:55:34 +0000449 if (DominatingGuardLoop &&
Max Kazantsev09802f42019-02-04 10:31:18 +0000450 !DominatingGuardLoop->contains(DominatedInstrLoop))
Sanjoy Das083f3892016-05-18 22:55:34 +0000451 return WS_IllegalOrNegative;
452
453 HoistingOutOfLoop = true;
454 }
455
Max Kazantsev09802f42019-02-04 10:31:18 +0000456 if (!isAvailableAt(getCondition(DominatedInstr), DominatingGuard))
Sanjoy Das083f3892016-05-18 22:55:34 +0000457 return WS_IllegalOrNegative;
458
Philip Reamesde5a1da2018-04-27 17:41:37 +0000459 // If the guard was conditional executed, it may never be reached
460 // dynamically. There are two potential downsides to hoisting it out of the
461 // conditionally executed region: 1) we may spuriously deopt without need and
462 // 2) we have the extra cost of computing the guard condition in the common
463 // case. At the moment, we really only consider the second in our heuristic
464 // here. TODO: evaluate cost model for spurious deopt
Philip Reames502d44812018-04-27 23:15:56 +0000465 // NOTE: As written, this also lets us hoist right over another guard which
Fangrui Songf78650a2018-07-30 19:41:25 +0000466 // is essentially just another spelling for control flow.
Max Kazantsev09802f42019-02-04 10:31:18 +0000467 if (isWideningCondProfitable(getCondition(DominatedInstr),
Max Kazantsev5c490b42018-08-13 07:58:19 +0000468 getCondition(DominatingGuard), InvertCond))
Sanjoy Das083f3892016-05-18 22:55:34 +0000469 return HoistingOutOfLoop ? WS_VeryPositive : WS_Positive;
470
471 if (HoistingOutOfLoop)
472 return WS_Positive;
473
Philip Reames502d44812018-04-27 23:15:56 +0000474 // Returns true if we might be hoisting above explicit control flow. Note
475 // that this completely ignores implicit control flow (guards, calls which
476 // throw, etc...). That choice appears arbitrary.
477 auto MaybeHoistingOutOfIf = [&]() {
478 auto *DominatingBlock = DominatingGuard->getParent();
Max Kazantsev09802f42019-02-04 10:31:18 +0000479 auto *DominatedBlock = DominatedInstr->getParent();
Max Kazantsev2bb95e72019-02-13 09:56:30 +0000480 if (isGuardAsWidenableBranch(DominatingGuard))
481 DominatingBlock = cast<BranchInst>(DominatingGuard)->getSuccessor(0);
Fangrui Songf78650a2018-07-30 19:41:25 +0000482
Philip Reames502d44812018-04-27 23:15:56 +0000483 // Same Block?
484 if (DominatedBlock == DominatingBlock)
485 return false;
486 // Obvious successor (common loop header/preheader case)
487 if (DominatedBlock == DominatingBlock->getUniqueSuccessor())
488 return false;
489 // TODO: diamond, triangle cases
490 if (!PDT) return true;
Max Kazantsev9b25bf32018-12-25 07:20:06 +0000491 return !PDT->dominates(DominatedBlock, DominatingBlock);
Philip Reames502d44812018-04-27 23:15:56 +0000492 };
493
494 return MaybeHoistingOutOfIf() ? WS_IllegalOrNegative : WS_Neutral;
Sanjoy Das083f3892016-05-18 22:55:34 +0000495}
496
Max Kazantsev3fe9ad72019-02-13 11:54:45 +0000497bool GuardWideningImpl::isAvailableAt(
498 const Value *V, const Instruction *Loc,
499 SmallPtrSetImpl<const Instruction *> &Visited) const {
Sanjoy Das083f3892016-05-18 22:55:34 +0000500 auto *Inst = dyn_cast<Instruction>(V);
501 if (!Inst || DT.dominates(Inst, Loc) || Visited.count(Inst))
502 return true;
503
504 if (!isSafeToSpeculativelyExecute(Inst, Loc, &DT) ||
505 Inst->mayReadFromMemory())
506 return false;
507
508 Visited.insert(Inst);
509
510 // We only want to go _up_ the dominance chain when recursing.
511 assert(!isa<PHINode>(Loc) &&
512 "PHIs should return false for isSafeToSpeculativelyExecute");
513 assert(DT.isReachableFromEntry(Inst->getParent()) &&
514 "We did a DFS from the block entry!");
515 return all_of(Inst->operands(),
516 [&](Value *Op) { return isAvailableAt(Op, Loc, Visited); });
517}
518
Max Kazantsev3fe9ad72019-02-13 11:54:45 +0000519void GuardWideningImpl::makeAvailableAt(Value *V, Instruction *Loc) const {
Sanjoy Das083f3892016-05-18 22:55:34 +0000520 auto *Inst = dyn_cast<Instruction>(V);
521 if (!Inst || DT.dominates(Inst, Loc))
522 return;
523
524 assert(isSafeToSpeculativelyExecute(Inst, Loc, &DT) &&
525 !Inst->mayReadFromMemory() && "Should've checked with isAvailableAt!");
526
527 for (Value *Op : Inst->operands())
528 makeAvailableAt(Op, Loc);
529
530 Inst->moveBefore(Loc);
531}
532
533bool GuardWideningImpl::widenCondCommon(Value *Cond0, Value *Cond1,
Max Kazantsev5c490b42018-08-13 07:58:19 +0000534 Instruction *InsertPt, Value *&Result,
535 bool InvertCondition) {
Sanjoy Das083f3892016-05-18 22:55:34 +0000536 using namespace llvm::PatternMatch;
537
538 {
539 // L >u C0 && L >u C1 -> L >u max(C0, C1)
540 ConstantInt *RHS0, *RHS1;
541 Value *LHS;
542 ICmpInst::Predicate Pred0, Pred1;
543 if (match(Cond0, m_ICmp(Pred0, m_Value(LHS), m_ConstantInt(RHS0))) &&
544 match(Cond1, m_ICmp(Pred1, m_Specific(LHS), m_ConstantInt(RHS1)))) {
Max Kazantsev5c490b42018-08-13 07:58:19 +0000545 if (InvertCondition)
546 Pred1 = ICmpInst::getInversePredicate(Pred1);
Sanjoy Das083f3892016-05-18 22:55:34 +0000547
Sanjoy Dasb784ed32016-05-19 03:53:17 +0000548 ConstantRange CR0 =
549 ConstantRange::makeExactICmpRegion(Pred0, RHS0->getValue());
550 ConstantRange CR1 =
551 ConstantRange::makeExactICmpRegion(Pred1, RHS1->getValue());
Sanjoy Das083f3892016-05-18 22:55:34 +0000552
Sanjoy Dasb784ed32016-05-19 03:53:17 +0000553 // SubsetIntersect is a subset of the actual mathematical intersection of
Sanjay Patelf8ee0e02016-06-19 17:20:27 +0000554 // CR0 and CR1, while SupersetIntersect is a superset of the actual
Sanjoy Dasb784ed32016-05-19 03:53:17 +0000555 // mathematical intersection. If these two ConstantRanges are equal, then
556 // we know we were able to represent the actual mathematical intersection
557 // of CR0 and CR1, and can use the same to generate an icmp instruction.
558 //
559 // Given what we're doing here and the semantics of guards, it would
560 // actually be correct to just use SubsetIntersect, but that may be too
561 // aggressive in cases we care about.
562 auto SubsetIntersect = CR0.inverse().unionWith(CR1.inverse()).inverse();
563 auto SupersetIntersect = CR0.intersectWith(CR1);
564
565 APInt NewRHSAP;
566 CmpInst::Predicate Pred;
567 if (SubsetIntersect == SupersetIntersect &&
568 SubsetIntersect.getEquivalentICmp(Pred, NewRHSAP)) {
Sanjoy Das083f3892016-05-18 22:55:34 +0000569 if (InsertPt) {
Sanjoy Dasb784ed32016-05-19 03:53:17 +0000570 ConstantInt *NewRHS = ConstantInt::get(Cond0->getContext(), NewRHSAP);
571 Result = new ICmpInst(InsertPt, Pred, LHS, NewRHS, "wide.chk");
Sanjoy Das083f3892016-05-18 22:55:34 +0000572 }
Sanjoy Das083f3892016-05-18 22:55:34 +0000573 return true;
574 }
575 }
576 }
577
Sanjoy Dasf5f03312016-05-19 22:55:46 +0000578 {
579 SmallVector<GuardWideningImpl::RangeCheck, 4> Checks, CombinedChecks;
Max Kazantsev5c490b42018-08-13 07:58:19 +0000580 // TODO: Support InvertCondition case?
581 if (!InvertCondition &&
582 parseRangeChecks(Cond0, Checks) && parseRangeChecks(Cond1, Checks) &&
Sanjoy Dasf5f03312016-05-19 22:55:46 +0000583 combineRangeChecks(Checks, CombinedChecks)) {
584 if (InsertPt) {
585 Result = nullptr;
586 for (auto &RC : CombinedChecks) {
Sanjoy Dasbe991532016-05-24 20:54:45 +0000587 makeAvailableAt(RC.getCheckInst(), InsertPt);
Sanjoy Dasf5f03312016-05-19 22:55:46 +0000588 if (Result)
Sanjoy Dasbe991532016-05-24 20:54:45 +0000589 Result = BinaryOperator::CreateAnd(RC.getCheckInst(), Result, "",
590 InsertPt);
Sanjoy Dasf5f03312016-05-19 22:55:46 +0000591 else
Sanjoy Dasbe991532016-05-24 20:54:45 +0000592 Result = RC.getCheckInst();
Sanjoy Dasf5f03312016-05-19 22:55:46 +0000593 }
594
595 Result->setName("wide.chk");
596 }
597 return true;
598 }
599 }
600
Sanjoy Das083f3892016-05-18 22:55:34 +0000601 // Base case -- just logical-and the two conditions together.
602
603 if (InsertPt) {
604 makeAvailableAt(Cond0, InsertPt);
605 makeAvailableAt(Cond1, InsertPt);
Max Kazantsev5c490b42018-08-13 07:58:19 +0000606 if (InvertCondition)
607 Cond1 = BinaryOperator::CreateNot(Cond1, "inverted", InsertPt);
Sanjoy Das083f3892016-05-18 22:55:34 +0000608 Result = BinaryOperator::CreateAnd(Cond0, Cond1, "wide.chk", InsertPt);
609 }
610
611 // We were not able to compute Cond0 AND Cond1 for the price of one.
612 return false;
613}
614
Sanjoy Dasf5f03312016-05-19 22:55:46 +0000615bool GuardWideningImpl::parseRangeChecks(
616 Value *CheckCond, SmallVectorImpl<GuardWideningImpl::RangeCheck> &Checks,
Max Kazantsev3fe9ad72019-02-13 11:54:45 +0000617 SmallPtrSetImpl<const Value *> &Visited) {
Sanjoy Dasf5f03312016-05-19 22:55:46 +0000618 if (!Visited.insert(CheckCond).second)
619 return true;
620
621 using namespace llvm::PatternMatch;
622
623 {
624 Value *AndLHS, *AndRHS;
625 if (match(CheckCond, m_And(m_Value(AndLHS), m_Value(AndRHS))))
626 return parseRangeChecks(AndLHS, Checks) &&
627 parseRangeChecks(AndRHS, Checks);
628 }
629
630 auto *IC = dyn_cast<ICmpInst>(CheckCond);
631 if (!IC || !IC->getOperand(0)->getType()->isIntegerTy() ||
632 (IC->getPredicate() != ICmpInst::ICMP_ULT &&
633 IC->getPredicate() != ICmpInst::ICMP_UGT))
634 return false;
635
Max Kazantsev3fe9ad72019-02-13 11:54:45 +0000636 const Value *CmpLHS = IC->getOperand(0), *CmpRHS = IC->getOperand(1);
Sanjoy Dasf5f03312016-05-19 22:55:46 +0000637 if (IC->getPredicate() == ICmpInst::ICMP_UGT)
638 std::swap(CmpLHS, CmpRHS);
639
640 auto &DL = IC->getModule()->getDataLayout();
641
Sanjoy Dasbe991532016-05-24 20:54:45 +0000642 GuardWideningImpl::RangeCheck Check(
643 CmpLHS, cast<ConstantInt>(ConstantInt::getNullValue(CmpRHS->getType())),
644 CmpRHS, IC);
Sanjoy Dasf5f03312016-05-19 22:55:46 +0000645
Sanjoy Dasbe991532016-05-24 20:54:45 +0000646 if (!isKnownNonNegative(Check.getLength(), DL))
Sanjoy Dasf5f03312016-05-19 22:55:46 +0000647 return false;
648
649 // What we have in \c Check now is a correct interpretation of \p CheckCond.
650 // Try to see if we can move some constant offsets into the \c Offset field.
651
652 bool Changed;
Sanjoy Dasbe991532016-05-24 20:54:45 +0000653 auto &Ctx = CheckCond->getContext();
Sanjoy Dasf5f03312016-05-19 22:55:46 +0000654
655 do {
656 Value *OpLHS;
657 ConstantInt *OpRHS;
658 Changed = false;
659
660#ifndef NDEBUG
Sanjoy Dasbe991532016-05-24 20:54:45 +0000661 auto *BaseInst = dyn_cast<Instruction>(Check.getBase());
Sanjoy Dasf5f03312016-05-19 22:55:46 +0000662 assert((!BaseInst || DT.isReachableFromEntry(BaseInst->getParent())) &&
663 "Unreachable instruction?");
664#endif
665
Sanjoy Dasbe991532016-05-24 20:54:45 +0000666 if (match(Check.getBase(), m_Add(m_Value(OpLHS), m_ConstantInt(OpRHS)))) {
667 Check.setBase(OpLHS);
668 APInt NewOffset = Check.getOffsetValue() + OpRHS->getValue();
669 Check.setOffset(ConstantInt::get(Ctx, NewOffset));
Sanjoy Dasf5f03312016-05-19 22:55:46 +0000670 Changed = true;
Sanjoy Dasbe991532016-05-24 20:54:45 +0000671 } else if (match(Check.getBase(),
672 m_Or(m_Value(OpLHS), m_ConstantInt(OpRHS)))) {
Craig Topper8205a1a2017-05-24 16:53:07 +0000673 KnownBits Known = computeKnownBits(OpLHS, DL);
Craig Topperb45eabc2017-04-26 16:39:58 +0000674 if ((OpRHS->getValue() & Known.Zero) == OpRHS->getValue()) {
Sanjoy Dasbe991532016-05-24 20:54:45 +0000675 Check.setBase(OpLHS);
676 APInt NewOffset = Check.getOffsetValue() + OpRHS->getValue();
677 Check.setOffset(ConstantInt::get(Ctx, NewOffset));
Sanjoy Dasf5f03312016-05-19 22:55:46 +0000678 Changed = true;
679 }
680 }
681 } while (Changed);
682
683 Checks.push_back(Check);
684 return true;
685}
686
687bool GuardWideningImpl::combineRangeChecks(
688 SmallVectorImpl<GuardWideningImpl::RangeCheck> &Checks,
Max Kazantsev3fe9ad72019-02-13 11:54:45 +0000689 SmallVectorImpl<GuardWideningImpl::RangeCheck> &RangeChecksOut) const {
Sanjoy Dasf5f03312016-05-19 22:55:46 +0000690 unsigned OldCount = Checks.size();
691 while (!Checks.empty()) {
Sanjoy Dasbe6c7a12016-05-21 02:24:44 +0000692 // Pick all of the range checks with a specific base and length, and try to
693 // merge them.
Max Kazantsev3fe9ad72019-02-13 11:54:45 +0000694 const Value *CurrentBase = Checks.front().getBase();
695 const Value *CurrentLength = Checks.front().getLength();
Sanjoy Dasf5f03312016-05-19 22:55:46 +0000696
Sanjoy Dasbe6c7a12016-05-21 02:24:44 +0000697 SmallVector<GuardWideningImpl::RangeCheck, 3> CurrentChecks;
Sanjoy Dasf5f03312016-05-19 22:55:46 +0000698
Sanjoy Dasbe6c7a12016-05-21 02:24:44 +0000699 auto IsCurrentCheck = [&](GuardWideningImpl::RangeCheck &RC) {
Sanjoy Dasbe991532016-05-24 20:54:45 +0000700 return RC.getBase() == CurrentBase && RC.getLength() == CurrentLength;
Sanjoy Dasbe6c7a12016-05-21 02:24:44 +0000701 };
702
Sanjoy Das90208722017-02-21 00:38:44 +0000703 copy_if(Checks, std::back_inserter(CurrentChecks), IsCurrentCheck);
Sanjoy Dasbe6c7a12016-05-21 02:24:44 +0000704 Checks.erase(remove_if(Checks, IsCurrentCheck), Checks.end());
705
706 assert(CurrentChecks.size() != 0 && "We know we have at least one!");
707
708 if (CurrentChecks.size() < 3) {
709 RangeChecksOut.insert(RangeChecksOut.end(), CurrentChecks.begin(),
710 CurrentChecks.end());
Sanjoy Dasf5f03312016-05-19 22:55:46 +0000711 continue;
712 }
713
Sanjoy Dasbe6c7a12016-05-21 02:24:44 +0000714 // CurrentChecks.size() will typically be 3 here, but so far there has been
715 // no need to hard-code that fact.
Sanjoy Dasf5f03312016-05-19 22:55:46 +0000716
Fangrui Song0cac7262018-09-27 02:13:45 +0000717 llvm::sort(CurrentChecks, [&](const GuardWideningImpl::RangeCheck &LHS,
718 const GuardWideningImpl::RangeCheck &RHS) {
Sanjoy Dasbe991532016-05-24 20:54:45 +0000719 return LHS.getOffsetValue().slt(RHS.getOffsetValue());
Sanjoy Dasf5f03312016-05-19 22:55:46 +0000720 });
721
722 // Note: std::sort should not invalidate the ChecksStart iterator.
723
Max Kazantsev3fe9ad72019-02-13 11:54:45 +0000724 const ConstantInt *MinOffset = CurrentChecks.front().getOffset();
725 const ConstantInt *MaxOffset = CurrentChecks.back().getOffset();
Sanjoy Dasf5f03312016-05-19 22:55:46 +0000726
727 unsigned BitWidth = MaxOffset->getValue().getBitWidth();
728 if ((MaxOffset->getValue() - MinOffset->getValue())
729 .ugt(APInt::getSignedMinValue(BitWidth)))
730 return false;
731
732 APInt MaxDiff = MaxOffset->getValue() - MinOffset->getValue();
Benjamin Kramer46e38f32016-06-08 10:01:20 +0000733 const APInt &HighOffset = MaxOffset->getValue();
Sanjoy Das23519752016-05-19 23:15:59 +0000734 auto OffsetOK = [&](const GuardWideningImpl::RangeCheck &RC) {
Sanjoy Dasbe991532016-05-24 20:54:45 +0000735 return (HighOffset - RC.getOffsetValue()).ult(MaxDiff);
Sanjoy Dasf5f03312016-05-19 22:55:46 +0000736 };
737
738 if (MaxDiff.isMinValue() ||
Sanjoy Dasbe6c7a12016-05-21 02:24:44 +0000739 !std::all_of(std::next(CurrentChecks.begin()), CurrentChecks.end(),
740 OffsetOK))
Sanjoy Dasf5f03312016-05-19 22:55:46 +0000741 return false;
742
743 // We have a series of f+1 checks as:
744 //
745 // I+k_0 u< L ... Chk_0
Sanjoy Das23f314d2017-05-03 18:29:34 +0000746 // I+k_1 u< L ... Chk_1
Sanjoy Dasf5f03312016-05-19 22:55:46 +0000747 // ...
Sanjoy Das23f314d2017-05-03 18:29:34 +0000748 // I+k_f u< L ... Chk_f
Sanjoy Dasf5f03312016-05-19 22:55:46 +0000749 //
Sanjoy Das23f314d2017-05-03 18:29:34 +0000750 // with forall i in [0,f]: k_f-k_i u< k_f-k_0 ... Precond_0
Sanjoy Dasf5f03312016-05-19 22:55:46 +0000751 // k_f-k_0 u< INT_MIN+k_f ... Precond_1
752 // k_f != k_0 ... Precond_2
753 //
754 // Claim:
Sanjoy Das23f314d2017-05-03 18:29:34 +0000755 // Chk_0 AND Chk_f implies all the other checks
Sanjoy Dasf5f03312016-05-19 22:55:46 +0000756 //
757 // Informal proof sketch:
758 //
759 // We will show that the integer range [I+k_0,I+k_f] does not unsigned-wrap
760 // (i.e. going from I+k_0 to I+k_f does not cross the -1,0 boundary) and
761 // thus I+k_f is the greatest unsigned value in that range.
762 //
763 // This combined with Ckh_(f+1) shows that everything in that range is u< L.
764 // Via Precond_0 we know that all of the indices in Chk_0 through Chk_(f+1)
765 // lie in [I+k_0,I+k_f], this proving our claim.
766 //
767 // To see that [I+k_0,I+k_f] is not a wrapping range, note that there are
768 // two possibilities: I+k_0 u< I+k_f or I+k_0 >u I+k_f (they can't be equal
769 // since k_0 != k_f). In the former case, [I+k_0,I+k_f] is not a wrapping
770 // range by definition, and the latter case is impossible:
771 //
772 // 0-----I+k_f---I+k_0----L---INT_MAX,INT_MIN------------------(-1)
773 // xxxxxx xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx
774 //
775 // For Chk_0 to succeed, we'd have to have k_f-k_0 (the range highlighted
776 // with 'x' above) to be at least >u INT_MIN.
777
Sanjoy Dasbe6c7a12016-05-21 02:24:44 +0000778 RangeChecksOut.emplace_back(CurrentChecks.front());
779 RangeChecksOut.emplace_back(CurrentChecks.back());
Sanjoy Dasf5f03312016-05-19 22:55:46 +0000780 }
781
782 assert(RangeChecksOut.size() <= OldCount && "We pessimized!");
783 return RangeChecksOut.size() != OldCount;
784}
785
Florian Hahn6b3216a2017-07-31 10:07:49 +0000786#ifndef NDEBUG
Sanjoy Das083f3892016-05-18 22:55:34 +0000787StringRef GuardWideningImpl::scoreTypeToString(WideningScore WS) {
788 switch (WS) {
789 case WS_IllegalOrNegative:
790 return "IllegalOrNegative";
791 case WS_Neutral:
792 return "Neutral";
793 case WS_Positive:
794 return "Positive";
795 case WS_VeryPositive:
796 return "VeryPositive";
797 }
798
799 llvm_unreachable("Fully covered switch above!");
800}
Florian Hahn6b3216a2017-07-31 10:07:49 +0000801#endif
Sanjoy Das083f3892016-05-18 22:55:34 +0000802
Philip Reames6a1f3442018-03-23 23:41:47 +0000803PreservedAnalyses GuardWideningPass::run(Function &F,
804 FunctionAnalysisManager &AM) {
805 auto &DT = AM.getResult<DominatorTreeAnalysis>(F);
806 auto &LI = AM.getResult<LoopAnalysis>(F);
807 auto &PDT = AM.getResult<PostDominatorTreeAnalysis>(F);
Max Kazantseveded4ab2018-08-06 05:49:19 +0000808 BranchProbabilityInfo *BPI = nullptr;
809 if (WidenFrequentBranches)
810 BPI = AM.getCachedResult<BranchProbabilityAnalysis>(F);
811 if (!GuardWideningImpl(DT, &PDT, LI, BPI, DT.getRootNode(),
Philip Reames9258e9d2018-04-27 17:29:10 +0000812 [](BasicBlock*) { return true; } ).run())
Philip Reames6a1f3442018-03-23 23:41:47 +0000813 return PreservedAnalyses::all();
814
815 PreservedAnalyses PA;
816 PA.preserveSet<CFGAnalyses>();
817 return PA;
818}
819
Philip Reames137995d2019-04-18 19:17:14 +0000820PreservedAnalyses GuardWideningPass::run(Loop &L, LoopAnalysisManager &AM,
821 LoopStandardAnalysisResults &AR,
822 LPMUpdater &U) {
823
824 const auto &FAM =
825 AM.getResult<FunctionAnalysisManagerLoopProxy>(L, AR).getManager();
826 Function &F = *L.getHeader()->getParent();
827 BranchProbabilityInfo *BPI = nullptr;
828 if (WidenFrequentBranches)
829 BPI = FAM.getCachedResult<BranchProbabilityAnalysis>(F);
830
831 BasicBlock *RootBB = L.getLoopPredecessor();
832 if (!RootBB)
833 RootBB = L.getHeader();
834 auto BlockFilter = [&](BasicBlock *BB) {
835 return BB == RootBB || L.contains(BB);
836 };
837 if (!GuardWideningImpl(AR.DT, nullptr, AR.LI, BPI,
838 AR.DT.getNode(RootBB),
839 BlockFilter).run())
840 return PreservedAnalyses::all();
841
842 return getLoopPassPreservedAnalyses();
843}
844
Philip Reames6a1f3442018-03-23 23:41:47 +0000845namespace {
846struct GuardWideningLegacyPass : public FunctionPass {
847 static char ID;
Philip Reames6a1f3442018-03-23 23:41:47 +0000848
849 GuardWideningLegacyPass() : FunctionPass(ID) {
850 initializeGuardWideningLegacyPassPass(*PassRegistry::getPassRegistry());
851 }
852
853 bool runOnFunction(Function &F) override {
854 if (skipFunction(F))
855 return false;
Philip Reames9258e9d2018-04-27 17:29:10 +0000856 auto &DT = getAnalysis<DominatorTreeWrapperPass>().getDomTree();
857 auto &LI = getAnalysis<LoopInfoWrapperPass>().getLoopInfo();
858 auto &PDT = getAnalysis<PostDominatorTreeWrapperPass>().getPostDomTree();
Max Kazantseveded4ab2018-08-06 05:49:19 +0000859 BranchProbabilityInfo *BPI = nullptr;
860 if (WidenFrequentBranches)
861 BPI = &getAnalysis<BranchProbabilityInfoWrapperPass>().getBPI();
862 return GuardWideningImpl(DT, &PDT, LI, BPI, DT.getRootNode(),
Philip Reames9258e9d2018-04-27 17:29:10 +0000863 [](BasicBlock*) { return true; } ).run();
Philip Reames6a1f3442018-03-23 23:41:47 +0000864 }
865
866 void getAnalysisUsage(AnalysisUsage &AU) const override {
867 AU.setPreservesCFG();
868 AU.addRequired<DominatorTreeWrapperPass>();
869 AU.addRequired<PostDominatorTreeWrapperPass>();
870 AU.addRequired<LoopInfoWrapperPass>();
Max Kazantseveded4ab2018-08-06 05:49:19 +0000871 if (WidenFrequentBranches)
872 AU.addRequired<BranchProbabilityInfoWrapperPass>();
Philip Reames6a1f3442018-03-23 23:41:47 +0000873 }
874};
Philip Reames9258e9d2018-04-27 17:29:10 +0000875
876/// Same as above, but restricted to a single loop at a time. Can be
877/// scheduled with other loop passes w/o breaking out of LPM
878struct LoopGuardWideningLegacyPass : public LoopPass {
879 static char ID;
880
881 LoopGuardWideningLegacyPass() : LoopPass(ID) {
882 initializeLoopGuardWideningLegacyPassPass(*PassRegistry::getPassRegistry());
883 }
884
885 bool runOnLoop(Loop *L, LPPassManager &LPM) override {
886 if (skipLoop(L))
887 return false;
888 auto &DT = getAnalysis<DominatorTreeWrapperPass>().getDomTree();
889 auto &LI = getAnalysis<LoopInfoWrapperPass>().getLoopInfo();
Philip Reames502d44812018-04-27 23:15:56 +0000890 auto *PDTWP = getAnalysisIfAvailable<PostDominatorTreeWrapperPass>();
891 auto *PDT = PDTWP ? &PDTWP->getPostDomTree() : nullptr;
Philip Reames9258e9d2018-04-27 17:29:10 +0000892 BasicBlock *RootBB = L->getLoopPredecessor();
893 if (!RootBB)
894 RootBB = L->getHeader();
895 auto BlockFilter = [&](BasicBlock *BB) {
896 return BB == RootBB || L->contains(BB);
897 };
Max Kazantseveded4ab2018-08-06 05:49:19 +0000898 BranchProbabilityInfo *BPI = nullptr;
899 if (WidenFrequentBranches)
900 BPI = &getAnalysis<BranchProbabilityInfoWrapperPass>().getBPI();
901 return GuardWideningImpl(DT, PDT, LI, BPI,
Philip Reames9258e9d2018-04-27 17:29:10 +0000902 DT.getNode(RootBB), BlockFilter).run();
903 }
904
905 void getAnalysisUsage(AnalysisUsage &AU) const override {
Max Kazantseveded4ab2018-08-06 05:49:19 +0000906 if (WidenFrequentBranches)
907 AU.addRequired<BranchProbabilityInfoWrapperPass>();
Philip Reames9258e9d2018-04-27 17:29:10 +0000908 AU.setPreservesCFG();
909 getLoopAnalysisUsage(AU);
Philip Reames9258e9d2018-04-27 17:29:10 +0000910 AU.addPreserved<PostDominatorTreeWrapperPass>();
911 }
912};
Philip Reames6a1f3442018-03-23 23:41:47 +0000913}
914
Sanjoy Das083f3892016-05-18 22:55:34 +0000915char GuardWideningLegacyPass::ID = 0;
Philip Reames9258e9d2018-04-27 17:29:10 +0000916char LoopGuardWideningLegacyPass::ID = 0;
Sanjoy Das083f3892016-05-18 22:55:34 +0000917
918INITIALIZE_PASS_BEGIN(GuardWideningLegacyPass, "guard-widening", "Widen guards",
919 false, false)
920INITIALIZE_PASS_DEPENDENCY(DominatorTreeWrapperPass)
921INITIALIZE_PASS_DEPENDENCY(PostDominatorTreeWrapperPass)
922INITIALIZE_PASS_DEPENDENCY(LoopInfoWrapperPass)
Max Kazantseveded4ab2018-08-06 05:49:19 +0000923if (WidenFrequentBranches)
924 INITIALIZE_PASS_DEPENDENCY(BranchProbabilityInfoWrapperPass)
Sanjoy Das083f3892016-05-18 22:55:34 +0000925INITIALIZE_PASS_END(GuardWideningLegacyPass, "guard-widening", "Widen guards",
926 false, false)
927
Philip Reames9258e9d2018-04-27 17:29:10 +0000928INITIALIZE_PASS_BEGIN(LoopGuardWideningLegacyPass, "loop-guard-widening",
929 "Widen guards (within a single loop, as a loop pass)",
930 false, false)
931INITIALIZE_PASS_DEPENDENCY(DominatorTreeWrapperPass)
932INITIALIZE_PASS_DEPENDENCY(PostDominatorTreeWrapperPass)
933INITIALIZE_PASS_DEPENDENCY(LoopInfoWrapperPass)
Max Kazantseveded4ab2018-08-06 05:49:19 +0000934if (WidenFrequentBranches)
935 INITIALIZE_PASS_DEPENDENCY(BranchProbabilityInfoWrapperPass)
Philip Reames9258e9d2018-04-27 17:29:10 +0000936INITIALIZE_PASS_END(LoopGuardWideningLegacyPass, "loop-guard-widening",
937 "Widen guards (within a single loop, as a loop pass)",
938 false, false)
939
Sanjoy Das083f3892016-05-18 22:55:34 +0000940FunctionPass *llvm::createGuardWideningPass() {
941 return new GuardWideningLegacyPass();
942}
Philip Reames9258e9d2018-04-27 17:29:10 +0000943
944Pass *llvm::createLoopGuardWideningPass() {
945 return new LoopGuardWideningLegacyPass();
946}