Zhongxing Xu | 88cca6b | 2009-11-12 08:38:56 +0000 | [diff] [blame] | 1 | //=== MallocChecker.cpp - A malloc/free checker -------------------*- C++ -*--// |
| 2 | // |
| 3 | // The LLVM Compiler Infrastructure |
| 4 | // |
| 5 | // This file is distributed under the University of Illinois Open Source |
| 6 | // License. See LICENSE.TXT for details. |
| 7 | // |
| 8 | //===----------------------------------------------------------------------===// |
| 9 | // |
| 10 | // This file defines malloc/free checker, which checks for potential memory |
| 11 | // leaks, double free, and use-after-free problems. |
| 12 | // |
| 13 | //===----------------------------------------------------------------------===// |
| 14 | |
Argyrios Kyrtzidis | 183f0fb | 2011-02-28 01:26:35 +0000 | [diff] [blame] | 15 | #include "ClangSACheckers.h" |
Anna Zaks | e56167e | 2012-02-17 22:35:31 +0000 | [diff] [blame] | 16 | #include "InterCheckerAPI.h" |
Chandler Carruth | 3a02247 | 2012-12-04 09:13:33 +0000 | [diff] [blame] | 17 | #include "clang/AST/Attr.h" |
Anton Yartsev | 4e4cb6b | 2014-08-05 18:26:05 +0000 | [diff] [blame] | 18 | #include "clang/AST/ParentMap.h" |
Chandler Carruth | 3a02247 | 2012-12-04 09:13:33 +0000 | [diff] [blame] | 19 | #include "clang/Basic/SourceManager.h" |
Jordan Rose | 6b33c6f | 2014-03-26 17:05:46 +0000 | [diff] [blame] | 20 | #include "clang/Basic/TargetInfo.h" |
Chandler Carruth | 3a02247 | 2012-12-04 09:13:33 +0000 | [diff] [blame] | 21 | #include "clang/StaticAnalyzer/Core/BugReporter/BugType.h" |
Argyrios Kyrtzidis | 6a5674f | 2011-03-01 01:16:21 +0000 | [diff] [blame] | 22 | #include "clang/StaticAnalyzer/Core/Checker.h" |
Argyrios Kyrtzidis | 183f0fb | 2011-02-28 01:26:35 +0000 | [diff] [blame] | 23 | #include "clang/StaticAnalyzer/Core/CheckerManager.h" |
Jordan Rose | 4f7df9b | 2012-07-26 21:39:41 +0000 | [diff] [blame] | 24 | #include "clang/StaticAnalyzer/Core/PathSensitive/CallEvent.h" |
Chandler Carruth | 3a02247 | 2012-12-04 09:13:33 +0000 | [diff] [blame] | 25 | #include "clang/StaticAnalyzer/Core/PathSensitive/CheckerContext.h" |
Ted Kremenek | 001fd5b | 2011-08-15 22:09:50 +0000 | [diff] [blame] | 26 | #include "clang/StaticAnalyzer/Core/PathSensitive/ProgramState.h" |
| 27 | #include "clang/StaticAnalyzer/Core/PathSensitive/ProgramStateTrait.h" |
Ted Kremenek | f8cbac4 | 2011-02-10 01:03:03 +0000 | [diff] [blame] | 28 | #include "clang/StaticAnalyzer/Core/PathSensitive/SymbolManager.h" |
Benjamin Kramer | 3307c508 | 2012-02-04 12:31:12 +0000 | [diff] [blame] | 29 | #include "llvm/ADT/STLExtras.h" |
Benjamin Kramer | ea70eb3 | 2012-12-01 15:09:41 +0000 | [diff] [blame] | 30 | #include "llvm/ADT/SmallString.h" |
Jordan Rose | c102b35 | 2012-09-22 01:24:42 +0000 | [diff] [blame] | 31 | #include "llvm/ADT/StringExtras.h" |
Anna Zaks | 199e8e5 | 2012-02-22 03:14:20 +0000 | [diff] [blame] | 32 | #include <climits> |
Benjamin Kramer | cfeacf5 | 2016-05-27 14:27:13 +0000 | [diff] [blame] | 33 | #include <utility> |
Anna Zaks | 199e8e5 | 2012-02-22 03:14:20 +0000 | [diff] [blame] | 34 | |
Zhongxing Xu | 88cca6b | 2009-11-12 08:38:56 +0000 | [diff] [blame] | 35 | using namespace clang; |
Ted Kremenek | 98857c9 | 2010-12-23 07:20:52 +0000 | [diff] [blame] | 36 | using namespace ento; |
Zhongxing Xu | 88cca6b | 2009-11-12 08:38:56 +0000 | [diff] [blame] | 37 | |
| 38 | namespace { |
| 39 | |
Anton Yartsev | 0578959 | 2013-03-28 17:05:19 +0000 | [diff] [blame] | 40 | // Used to check correspondence between allocators and deallocators. |
| 41 | enum AllocationFamily { |
| 42 | AF_None, |
| 43 | AF_Malloc, |
| 44 | AF_CXXNew, |
Anna Zaks | d79b840 | 2014-10-03 21:48:59 +0000 | [diff] [blame] | 45 | AF_CXXNewArray, |
Anton Yartsev | 5b5c7ce | 2015-02-19 13:36:20 +0000 | [diff] [blame] | 46 | AF_IfNameIndex, |
| 47 | AF_Alloca |
Anton Yartsev | 0578959 | 2013-03-28 17:05:19 +0000 | [diff] [blame] | 48 | }; |
| 49 | |
Zhongxing Xu | 1239de1 | 2009-12-11 00:55:44 +0000 | [diff] [blame] | 50 | class RefState { |
Anna Zaks | 9050ffd | 2012-06-20 20:57:46 +0000 | [diff] [blame] | 51 | enum Kind { // Reference to allocated memory. |
| 52 | Allocated, |
Anton Yartsev | b50f4ba | 2015-04-14 14:18:04 +0000 | [diff] [blame] | 53 | // Reference to zero-allocated memory. |
| 54 | AllocatedOfSizeZero, |
Anna Zaks | 9050ffd | 2012-06-20 20:57:46 +0000 | [diff] [blame] | 55 | // Reference to released/freed memory. |
| 56 | Released, |
Alp Toker | 5faf0c0 | 2013-12-02 03:50:25 +0000 | [diff] [blame] | 57 | // The responsibility for freeing resources has transferred from |
Anna Zaks | 9050ffd | 2012-06-20 20:57:46 +0000 | [diff] [blame] | 58 | // this reference. A relinquished symbol should not be freed. |
Anna Zaks | 93a21a8 | 2013-04-09 00:30:28 +0000 | [diff] [blame] | 59 | Relinquished, |
| 60 | // We are no longer guaranteed to have observed all manipulations |
| 61 | // of this pointer/memory. For example, it could have been |
| 62 | // passed as a parameter to an opaque function. |
| 63 | Escaped |
| 64 | }; |
Anton Yartsev | 0578959 | 2013-03-28 17:05:19 +0000 | [diff] [blame] | 65 | |
Zhongxing Xu | 4668c7e | 2009-11-17 07:54:15 +0000 | [diff] [blame] | 66 | const Stmt *S; |
Anton Yartsev | b50f4ba | 2015-04-14 14:18:04 +0000 | [diff] [blame] | 67 | unsigned K : 3; // Kind enum, but stored as a bitfield. |
Ted Kremenek | 3a0678e | 2015-09-08 03:50:52 +0000 | [diff] [blame] | 68 | unsigned Family : 29; // Rest of 32-bit word, currently just an allocation |
Anton Yartsev | 0578959 | 2013-03-28 17:05:19 +0000 | [diff] [blame] | 69 | // family. |
Zhongxing Xu | 4668c7e | 2009-11-17 07:54:15 +0000 | [diff] [blame] | 70 | |
Ted Kremenek | 3a0678e | 2015-09-08 03:50:52 +0000 | [diff] [blame] | 71 | RefState(Kind k, const Stmt *s, unsigned family) |
Anna Zaks | 93a21a8 | 2013-04-09 00:30:28 +0000 | [diff] [blame] | 72 | : S(s), K(k), Family(family) { |
| 73 | assert(family != AF_None); |
| 74 | } |
Zhongxing Xu | 1239de1 | 2009-12-11 00:55:44 +0000 | [diff] [blame] | 75 | public: |
Anna Zaks | 9050ffd | 2012-06-20 20:57:46 +0000 | [diff] [blame] | 76 | bool isAllocated() const { return K == Allocated; } |
Anton Yartsev | b50f4ba | 2015-04-14 14:18:04 +0000 | [diff] [blame] | 77 | bool isAllocatedOfSizeZero() const { return K == AllocatedOfSizeZero; } |
Zhongxing Xu | 4668c7e | 2009-11-17 07:54:15 +0000 | [diff] [blame] | 78 | bool isReleased() const { return K == Released; } |
Anna Zaks | 9050ffd | 2012-06-20 20:57:46 +0000 | [diff] [blame] | 79 | bool isRelinquished() const { return K == Relinquished; } |
Anna Zaks | 93a21a8 | 2013-04-09 00:30:28 +0000 | [diff] [blame] | 80 | bool isEscaped() const { return K == Escaped; } |
| 81 | AllocationFamily getAllocationFamily() const { |
Anton Yartsev | 0578959 | 2013-03-28 17:05:19 +0000 | [diff] [blame] | 82 | return (AllocationFamily)Family; |
| 83 | } |
Anna Zaks | d56c879 | 2012-02-13 18:05:39 +0000 | [diff] [blame] | 84 | const Stmt *getStmt() const { return S; } |
Zhongxing Xu | 4668c7e | 2009-11-17 07:54:15 +0000 | [diff] [blame] | 85 | |
| 86 | bool operator==(const RefState &X) const { |
Anton Yartsev | 0578959 | 2013-03-28 17:05:19 +0000 | [diff] [blame] | 87 | return K == X.K && S == X.S && Family == X.Family; |
Zhongxing Xu | 4668c7e | 2009-11-17 07:54:15 +0000 | [diff] [blame] | 88 | } |
| 89 | |
Anton Yartsev | 0578959 | 2013-03-28 17:05:19 +0000 | [diff] [blame] | 90 | static RefState getAllocated(unsigned family, const Stmt *s) { |
| 91 | return RefState(Allocated, s, family); |
Zhongxing Xu | b0e15df | 2009-12-31 06:13:07 +0000 | [diff] [blame] | 92 | } |
Anton Yartsev | b50f4ba | 2015-04-14 14:18:04 +0000 | [diff] [blame] | 93 | static RefState getAllocatedOfSizeZero(const RefState *RS) { |
| 94 | return RefState(AllocatedOfSizeZero, RS->getStmt(), |
| 95 | RS->getAllocationFamily()); |
| 96 | } |
Ted Kremenek | 3a0678e | 2015-09-08 03:50:52 +0000 | [diff] [blame] | 97 | static RefState getReleased(unsigned family, const Stmt *s) { |
Anton Yartsev | 0578959 | 2013-03-28 17:05:19 +0000 | [diff] [blame] | 98 | return RefState(Released, s, family); |
| 99 | } |
| 100 | static RefState getRelinquished(unsigned family, const Stmt *s) { |
| 101 | return RefState(Relinquished, s, family); |
Ted Kremenek | 0bbf24d | 2010-08-06 21:12:55 +0000 | [diff] [blame] | 102 | } |
Anna Zaks | 93a21a8 | 2013-04-09 00:30:28 +0000 | [diff] [blame] | 103 | static RefState getEscaped(const RefState *RS) { |
| 104 | return RefState(Escaped, RS->getStmt(), RS->getAllocationFamily()); |
| 105 | } |
Zhongxing Xu | 4668c7e | 2009-11-17 07:54:15 +0000 | [diff] [blame] | 106 | |
| 107 | void Profile(llvm::FoldingSetNodeID &ID) const { |
| 108 | ID.AddInteger(K); |
| 109 | ID.AddPointer(S); |
Anton Yartsev | 0578959 | 2013-03-28 17:05:19 +0000 | [diff] [blame] | 110 | ID.AddInteger(Family); |
Zhongxing Xu | 4668c7e | 2009-11-17 07:54:15 +0000 | [diff] [blame] | 111 | } |
Ted Kremenek | 6fcefb5 | 2013-01-03 01:30:12 +0000 | [diff] [blame] | 112 | |
Dmitri Gribenko | f857950 | 2013-01-12 19:30:44 +0000 | [diff] [blame] | 113 | void dump(raw_ostream &OS) const { |
Jordan Rose | 6adadb9 | 2014-01-23 03:59:01 +0000 | [diff] [blame] | 114 | switch (static_cast<Kind>(K)) { |
| 115 | #define CASE(ID) case ID: OS << #ID; break; |
| 116 | CASE(Allocated) |
Anton Yartsev | b50f4ba | 2015-04-14 14:18:04 +0000 | [diff] [blame] | 117 | CASE(AllocatedOfSizeZero) |
Jordan Rose | 6adadb9 | 2014-01-23 03:59:01 +0000 | [diff] [blame] | 118 | CASE(Released) |
| 119 | CASE(Relinquished) |
| 120 | CASE(Escaped) |
| 121 | } |
Ted Kremenek | 6fcefb5 | 2013-01-03 01:30:12 +0000 | [diff] [blame] | 122 | } |
| 123 | |
Alp Toker | ef6b007 | 2014-01-04 13:47:14 +0000 | [diff] [blame] | 124 | LLVM_DUMP_METHOD void dump() const { dump(llvm::errs()); } |
Zhongxing Xu | 88cca6b | 2009-11-12 08:38:56 +0000 | [diff] [blame] | 125 | }; |
| 126 | |
Anna Zaks | 75cfbb6 | 2012-09-12 22:57:34 +0000 | [diff] [blame] | 127 | enum ReallocPairKind { |
| 128 | RPToBeFreedAfterFailure, |
| 129 | // The symbol has been freed when reallocation failed. |
| 130 | RPIsFreeOnFailure, |
| 131 | // The symbol does not need to be freed after reallocation fails. |
| 132 | RPDoNotTrackAfterFailure |
| 133 | }; |
| 134 | |
Anna Zaks | fe6eb67 | 2012-08-24 02:28:20 +0000 | [diff] [blame] | 135 | /// \class ReallocPair |
| 136 | /// \brief Stores information about the symbol being reallocated by a call to |
| 137 | /// 'realloc' to allow modeling failed reallocation later in the path. |
Anna Zaks | ac06814 | 2012-02-15 00:11:25 +0000 | [diff] [blame] | 138 | struct ReallocPair { |
Anna Zaks | fe6eb67 | 2012-08-24 02:28:20 +0000 | [diff] [blame] | 139 | // \brief The symbol which realloc reallocated. |
Anna Zaks | ac06814 | 2012-02-15 00:11:25 +0000 | [diff] [blame] | 140 | SymbolRef ReallocatedSym; |
Anna Zaks | 75cfbb6 | 2012-09-12 22:57:34 +0000 | [diff] [blame] | 141 | ReallocPairKind Kind; |
Anna Zaks | fe6eb67 | 2012-08-24 02:28:20 +0000 | [diff] [blame] | 142 | |
Anna Zaks | 75cfbb6 | 2012-09-12 22:57:34 +0000 | [diff] [blame] | 143 | ReallocPair(SymbolRef S, ReallocPairKind K) : |
| 144 | ReallocatedSym(S), Kind(K) {} |
Anna Zaks | ac06814 | 2012-02-15 00:11:25 +0000 | [diff] [blame] | 145 | void Profile(llvm::FoldingSetNodeID &ID) const { |
Anna Zaks | 75cfbb6 | 2012-09-12 22:57:34 +0000 | [diff] [blame] | 146 | ID.AddInteger(Kind); |
Anna Zaks | ac06814 | 2012-02-15 00:11:25 +0000 | [diff] [blame] | 147 | ID.AddPointer(ReallocatedSym); |
| 148 | } |
| 149 | bool operator==(const ReallocPair &X) const { |
| 150 | return ReallocatedSym == X.ReallocatedSym && |
Anna Zaks | 75cfbb6 | 2012-09-12 22:57:34 +0000 | [diff] [blame] | 151 | Kind == X.Kind; |
Anna Zaks | ac06814 | 2012-02-15 00:11:25 +0000 | [diff] [blame] | 152 | } |
| 153 | }; |
| 154 | |
Anna Zaks | a043d0c | 2013-01-08 00:25:29 +0000 | [diff] [blame] | 155 | typedef std::pair<const ExplodedNode*, const MemRegion*> LeakInfo; |
Anna Zaks | fc2e153 | 2012-03-21 19:45:08 +0000 | [diff] [blame] | 156 | |
Anna Zaks | c68bf4c | 2012-02-08 20:13:28 +0000 | [diff] [blame] | 157 | class MallocChecker : public Checker<check::DeadSymbols, |
Anna Zaks | dc15415 | 2012-12-20 00:38:25 +0000 | [diff] [blame] | 158 | check::PointerEscape, |
Anna Zaks | 333481b | 2013-03-28 23:15:29 +0000 | [diff] [blame] | 159 | check::ConstPointerEscape, |
Ted Kremenek | 778d2bb | 2012-01-04 23:48:37 +0000 | [diff] [blame] | 160 | check::PreStmt<ReturnStmt>, |
Anton Yartsev | cb2ccd6 | 2013-04-10 22:21:41 +0000 | [diff] [blame] | 161 | check::PreCall, |
Anna Zaks | c68bf4c | 2012-02-08 20:13:28 +0000 | [diff] [blame] | 162 | check::PostStmt<CallExpr>, |
Anton Yartsev | 13df036 | 2013-03-25 01:35:45 +0000 | [diff] [blame] | 163 | check::PostStmt<CXXNewExpr>, |
| 164 | check::PreStmt<CXXDeleteExpr>, |
Anna Zaks | 9fe8098 | 2012-03-22 00:57:20 +0000 | [diff] [blame] | 165 | check::PostStmt<BlockExpr>, |
Anna Zaks | 67291b9 | 2012-11-13 03:18:01 +0000 | [diff] [blame] | 166 | check::PostObjCMessage, |
Ted Kremenek | 778d2bb | 2012-01-04 23:48:37 +0000 | [diff] [blame] | 167 | check::Location, |
Anna Zaks | dc15415 | 2012-12-20 00:38:25 +0000 | [diff] [blame] | 168 | eval::Assume> |
Ted Kremenek | 778d2bb | 2012-01-04 23:48:37 +0000 | [diff] [blame] | 169 | { |
Zhongxing Xu | 88cca6b | 2009-11-12 08:38:56 +0000 | [diff] [blame] | 170 | public: |
Craig Topper | 0dbb783 | 2014-05-27 02:45:47 +0000 | [diff] [blame] | 171 | MallocChecker() |
Anna Zaks | 30d4668 | 2016-03-08 01:21:51 +0000 | [diff] [blame] | 172 | : II_alloca(nullptr), II_win_alloca(nullptr), II_malloc(nullptr), |
| 173 | II_free(nullptr), II_realloc(nullptr), II_calloc(nullptr), |
| 174 | II_valloc(nullptr), II_reallocf(nullptr), II_strndup(nullptr), |
| 175 | II_strdup(nullptr), II_win_strdup(nullptr), II_kmalloc(nullptr), |
| 176 | II_if_nameindex(nullptr), II_if_freenameindex(nullptr), |
Anna Zaks | bbec97c | 2017-03-09 00:01:01 +0000 | [diff] [blame^] | 177 | II_wcsdup(nullptr), II_win_wcsdup(nullptr), II_g_malloc(nullptr), |
| 178 | II_g_malloc0(nullptr), II_g_realloc(nullptr), II_g_try_malloc(nullptr), |
| 179 | II_g_try_malloc0(nullptr), II_g_try_realloc(nullptr), |
| 180 | II_g_free(nullptr), II_g_memdup(nullptr) {} |
Anna Zaks | cd37bf4 | 2012-02-08 23:16:52 +0000 | [diff] [blame] | 181 | |
| 182 | /// In pessimistic mode, the checker assumes that it does not know which |
| 183 | /// functions might free the memory. |
Alexander Kornienko | 4aca9b1 | 2014-02-11 21:49:21 +0000 | [diff] [blame] | 184 | enum CheckKind { |
Gabor Horvath | e40c71c | 2015-03-04 17:59:34 +0000 | [diff] [blame] | 185 | CK_MallocChecker, |
Alexander Kornienko | 4aca9b1 | 2014-02-11 21:49:21 +0000 | [diff] [blame] | 186 | CK_NewDeleteChecker, |
| 187 | CK_NewDeleteLeaksChecker, |
| 188 | CK_MismatchedDeallocatorChecker, |
| 189 | CK_NumCheckKinds |
Anna Zaks | cd37bf4 | 2012-02-08 23:16:52 +0000 | [diff] [blame] | 190 | }; |
| 191 | |
Ted Kremenek | 3a0678e | 2015-09-08 03:50:52 +0000 | [diff] [blame] | 192 | enum class MemoryOperationKind { |
Anna Zaks | d79b840 | 2014-10-03 21:48:59 +0000 | [diff] [blame] | 193 | MOK_Allocate, |
| 194 | MOK_Free, |
| 195 | MOK_Any |
| 196 | }; |
| 197 | |
Gabor Horvath | e40c71c | 2015-03-04 17:59:34 +0000 | [diff] [blame] | 198 | DefaultBool IsOptimistic; |
| 199 | |
Alexander Kornienko | 4aca9b1 | 2014-02-11 21:49:21 +0000 | [diff] [blame] | 200 | DefaultBool ChecksEnabled[CK_NumCheckKinds]; |
| 201 | CheckName CheckNames[CK_NumCheckKinds]; |
Anna Zaks | cd37bf4 | 2012-02-08 23:16:52 +0000 | [diff] [blame] | 202 | |
Anton Yartsev | cb2ccd6 | 2013-04-10 22:21:41 +0000 | [diff] [blame] | 203 | void checkPreCall(const CallEvent &Call, CheckerContext &C) const; |
Anna Zaks | c68bf4c | 2012-02-08 20:13:28 +0000 | [diff] [blame] | 204 | void checkPostStmt(const CallExpr *CE, CheckerContext &C) const; |
Anton Yartsev | 13df036 | 2013-03-25 01:35:45 +0000 | [diff] [blame] | 205 | void checkPostStmt(const CXXNewExpr *NE, CheckerContext &C) const; |
| 206 | void checkPreStmt(const CXXDeleteExpr *DE, CheckerContext &C) const; |
Anna Zaks | 67291b9 | 2012-11-13 03:18:01 +0000 | [diff] [blame] | 207 | void checkPostObjCMessage(const ObjCMethodCall &Call, CheckerContext &C) const; |
Anna Zaks | 9fe8098 | 2012-03-22 00:57:20 +0000 | [diff] [blame] | 208 | void checkPostStmt(const BlockExpr *BE, CheckerContext &C) const; |
Argyrios Kyrtzidis | 183f0fb | 2011-02-28 01:26:35 +0000 | [diff] [blame] | 209 | void checkDeadSymbols(SymbolReaper &SymReaper, CheckerContext &C) const; |
Argyrios Kyrtzidis | 183f0fb | 2011-02-28 01:26:35 +0000 | [diff] [blame] | 210 | void checkPreStmt(const ReturnStmt *S, CheckerContext &C) const; |
Ted Kremenek | 49b1e38 | 2012-01-26 21:29:00 +0000 | [diff] [blame] | 211 | ProgramStateRef evalAssume(ProgramStateRef state, SVal Cond, |
Argyrios Kyrtzidis | 183f0fb | 2011-02-28 01:26:35 +0000 | [diff] [blame] | 212 | bool Assumption) const; |
Anna Zaks | 3e0f415 | 2011-10-06 00:43:15 +0000 | [diff] [blame] | 213 | void checkLocation(SVal l, bool isLoad, const Stmt *S, |
| 214 | CheckerContext &C) const; |
Anna Zaks | dc15415 | 2012-12-20 00:38:25 +0000 | [diff] [blame] | 215 | |
| 216 | ProgramStateRef checkPointerEscape(ProgramStateRef State, |
| 217 | const InvalidatedSymbols &Escaped, |
Anna Zaks | acdc13c | 2013-02-07 23:05:43 +0000 | [diff] [blame] | 218 | const CallEvent *Call, |
| 219 | PointerEscapeKind Kind) const; |
Anna Zaks | 333481b | 2013-03-28 23:15:29 +0000 | [diff] [blame] | 220 | ProgramStateRef checkConstPointerEscape(ProgramStateRef State, |
| 221 | const InvalidatedSymbols &Escaped, |
| 222 | const CallEvent *Call, |
| 223 | PointerEscapeKind Kind) const; |
Zhongxing Xu | b0e15df | 2009-12-31 06:13:07 +0000 | [diff] [blame] | 224 | |
Anna Zaks | 263b7e0 | 2012-05-02 00:05:20 +0000 | [diff] [blame] | 225 | void printState(raw_ostream &Out, ProgramStateRef State, |
Craig Topper | fb6b25b | 2014-03-15 04:29:04 +0000 | [diff] [blame] | 226 | const char *NL, const char *Sep) const override; |
Anna Zaks | 263b7e0 | 2012-05-02 00:05:20 +0000 | [diff] [blame] | 227 | |
Zhongxing Xu | c4902a5 | 2009-11-13 07:25:27 +0000 | [diff] [blame] | 228 | private: |
Ahmed Charles | b898432 | 2014-03-07 20:03:18 +0000 | [diff] [blame] | 229 | mutable std::unique_ptr<BugType> BT_DoubleFree[CK_NumCheckKinds]; |
| 230 | mutable std::unique_ptr<BugType> BT_DoubleDelete; |
| 231 | mutable std::unique_ptr<BugType> BT_Leak[CK_NumCheckKinds]; |
| 232 | mutable std::unique_ptr<BugType> BT_UseFree[CK_NumCheckKinds]; |
| 233 | mutable std::unique_ptr<BugType> BT_BadFree[CK_NumCheckKinds]; |
Anton Yartsev | 5b5c7ce | 2015-02-19 13:36:20 +0000 | [diff] [blame] | 234 | mutable std::unique_ptr<BugType> BT_FreeAlloca[CK_NumCheckKinds]; |
Ahmed Charles | b898432 | 2014-03-07 20:03:18 +0000 | [diff] [blame] | 235 | mutable std::unique_ptr<BugType> BT_MismatchedDealloc; |
| 236 | mutable std::unique_ptr<BugType> BT_OffsetFree[CK_NumCheckKinds]; |
Anton Yartsev | b50f4ba | 2015-04-14 14:18:04 +0000 | [diff] [blame] | 237 | mutable std::unique_ptr<BugType> BT_UseZerroAllocated[CK_NumCheckKinds]; |
Anna Zaks | 30d4668 | 2016-03-08 01:21:51 +0000 | [diff] [blame] | 238 | mutable IdentifierInfo *II_alloca, *II_win_alloca, *II_malloc, *II_free, |
| 239 | *II_realloc, *II_calloc, *II_valloc, *II_reallocf, |
| 240 | *II_strndup, *II_strdup, *II_win_strdup, *II_kmalloc, |
| 241 | *II_if_nameindex, *II_if_freenameindex, *II_wcsdup, |
Anna Zaks | bbec97c | 2017-03-09 00:01:01 +0000 | [diff] [blame^] | 242 | *II_win_wcsdup, *II_g_malloc, *II_g_malloc0, |
| 243 | *II_g_realloc, *II_g_try_malloc, *II_g_try_malloc0, |
| 244 | *II_g_try_realloc, *II_g_free, *II_g_memdup; |
Jordan Rose | 6b33c6f | 2014-03-26 17:05:46 +0000 | [diff] [blame] | 245 | mutable Optional<uint64_t> KernelZeroFlagVal; |
Alexander Kornienko | 4aca9b1 | 2014-02-11 21:49:21 +0000 | [diff] [blame] | 246 | |
Anna Zaks | 3d34834 | 2012-02-14 21:55:24 +0000 | [diff] [blame] | 247 | void initIdentifierInfo(ASTContext &C) const; |
| 248 | |
Anton Yartsev | 0578959 | 2013-03-28 17:05:19 +0000 | [diff] [blame] | 249 | /// \brief Determine family of a deallocation expression. |
Anton Yartsev | e3377fb | 2013-04-04 23:46:29 +0000 | [diff] [blame] | 250 | AllocationFamily getAllocationFamily(CheckerContext &C, const Stmt *S) const; |
Anton Yartsev | 0578959 | 2013-03-28 17:05:19 +0000 | [diff] [blame] | 251 | |
| 252 | /// \brief Print names of allocators and deallocators. |
| 253 | /// |
| 254 | /// \returns true on success. |
Ted Kremenek | 3a0678e | 2015-09-08 03:50:52 +0000 | [diff] [blame] | 255 | bool printAllocDeallocName(raw_ostream &os, CheckerContext &C, |
Anton Yartsev | 0578959 | 2013-03-28 17:05:19 +0000 | [diff] [blame] | 256 | const Expr *E) const; |
| 257 | |
| 258 | /// \brief Print expected name of an allocator based on the deallocator's |
| 259 | /// family derived from the DeallocExpr. |
Ted Kremenek | 3a0678e | 2015-09-08 03:50:52 +0000 | [diff] [blame] | 260 | void printExpectedAllocName(raw_ostream &os, CheckerContext &C, |
Anton Yartsev | 0578959 | 2013-03-28 17:05:19 +0000 | [diff] [blame] | 261 | const Expr *DeallocExpr) const; |
Ted Kremenek | 3a0678e | 2015-09-08 03:50:52 +0000 | [diff] [blame] | 262 | /// \brief Print expected name of a deallocator based on the allocator's |
Anton Yartsev | 0578959 | 2013-03-28 17:05:19 +0000 | [diff] [blame] | 263 | /// family. |
| 264 | void printExpectedDeallocName(raw_ostream &os, AllocationFamily Family) const; |
| 265 | |
Jordan Rose | 613f3c0 | 2013-03-09 00:59:10 +0000 | [diff] [blame] | 266 | ///@{ |
Ted Kremenek | 3a0678e | 2015-09-08 03:50:52 +0000 | [diff] [blame] | 267 | /// Check if this is one of the functions which can allocate/reallocate memory |
Anna Zaks | 3d34834 | 2012-02-14 21:55:24 +0000 | [diff] [blame] | 268 | /// pointed to by one of its arguments. |
| 269 | bool isMemFunction(const FunctionDecl *FD, ASTContext &C) const; |
Anna Zaks | d79b840 | 2014-10-03 21:48:59 +0000 | [diff] [blame] | 270 | bool isCMemFunction(const FunctionDecl *FD, |
| 271 | ASTContext &C, |
| 272 | AllocationFamily Family, |
Benjamin Kramer | 719772c | 2014-10-03 22:20:30 +0000 | [diff] [blame] | 273 | MemoryOperationKind MemKind) const; |
Anton Yartsev | 13df036 | 2013-03-25 01:35:45 +0000 | [diff] [blame] | 274 | bool isStandardNewDelete(const FunctionDecl *FD, ASTContext &C) const; |
Jordan Rose | 613f3c0 | 2013-03-09 00:59:10 +0000 | [diff] [blame] | 275 | ///@} |
Anton Yartsev | b50f4ba | 2015-04-14 14:18:04 +0000 | [diff] [blame] | 276 | |
| 277 | /// \brief Perform a zero-allocation check. |
| 278 | ProgramStateRef ProcessZeroAllocation(CheckerContext &C, const Expr *E, |
| 279 | const unsigned AllocationSizeArg, |
| 280 | ProgramStateRef State) const; |
| 281 | |
Richard Smith | 852e9ce | 2013-11-27 01:46:48 +0000 | [diff] [blame] | 282 | ProgramStateRef MallocMemReturnsAttr(CheckerContext &C, |
| 283 | const CallExpr *CE, |
Anton Yartsev | b3fa86d | 2015-02-10 20:13:08 +0000 | [diff] [blame] | 284 | const OwnershipAttr* Att, |
| 285 | ProgramStateRef State) const; |
Ted Kremenek | 49b1e38 | 2012-01-26 21:29:00 +0000 | [diff] [blame] | 286 | static ProgramStateRef MallocMemAux(CheckerContext &C, const CallExpr *CE, |
Anton Yartsev | b3fa86d | 2015-02-10 20:13:08 +0000 | [diff] [blame] | 287 | const Expr *SizeEx, SVal Init, |
| 288 | ProgramStateRef State, |
| 289 | AllocationFamily Family = AF_Malloc); |
Ted Kremenek | 49b1e38 | 2012-01-26 21:29:00 +0000 | [diff] [blame] | 290 | static ProgramStateRef MallocMemAux(CheckerContext &C, const CallExpr *CE, |
Anton Yartsev | b3fa86d | 2015-02-10 20:13:08 +0000 | [diff] [blame] | 291 | SVal SizeEx, SVal Init, |
| 292 | ProgramStateRef State, |
| 293 | AllocationFamily Family = AF_Malloc); |
Zhongxing Xu | 527ff6d | 2010-06-01 03:01:33 +0000 | [diff] [blame] | 294 | |
Gabor Horvath | 7304027 | 2016-09-19 20:39:52 +0000 | [diff] [blame] | 295 | static ProgramStateRef addExtentSize(CheckerContext &C, const CXXNewExpr *NE, |
| 296 | ProgramStateRef State); |
| 297 | |
Jordan Rose | 6b33c6f | 2014-03-26 17:05:46 +0000 | [diff] [blame] | 298 | // Check if this malloc() for special flags. At present that means M_ZERO or |
| 299 | // __GFP_ZERO (in which case, treat it like calloc). |
| 300 | llvm::Optional<ProgramStateRef> |
| 301 | performKernelMalloc(const CallExpr *CE, CheckerContext &C, |
| 302 | const ProgramStateRef &State) const; |
| 303 | |
Anna Zaks | 40a7eb3 | 2012-02-22 19:24:52 +0000 | [diff] [blame] | 304 | /// Update the RefState to reflect the new memory allocation. |
Ted Kremenek | 3a0678e | 2015-09-08 03:50:52 +0000 | [diff] [blame] | 305 | static ProgramStateRef |
Anton Yartsev | 0578959 | 2013-03-28 17:05:19 +0000 | [diff] [blame] | 306 | MallocUpdateRefState(CheckerContext &C, const Expr *E, ProgramStateRef State, |
| 307 | AllocationFamily Family = AF_Malloc); |
Anna Zaks | 40a7eb3 | 2012-02-22 19:24:52 +0000 | [diff] [blame] | 308 | |
| 309 | ProgramStateRef FreeMemAttr(CheckerContext &C, const CallExpr *CE, |
Anton Yartsev | b3fa86d | 2015-02-10 20:13:08 +0000 | [diff] [blame] | 310 | const OwnershipAttr* Att, |
| 311 | ProgramStateRef State) const; |
Ted Kremenek | 49b1e38 | 2012-01-26 21:29:00 +0000 | [diff] [blame] | 312 | ProgramStateRef FreeMemAux(CheckerContext &C, const CallExpr *CE, |
Anna Zaks | 0d6989b | 2012-06-22 02:04:31 +0000 | [diff] [blame] | 313 | ProgramStateRef state, unsigned Num, |
Anna Zaks | fe6eb67 | 2012-08-24 02:28:20 +0000 | [diff] [blame] | 314 | bool Hold, |
Anna Zaks | 67291b9 | 2012-11-13 03:18:01 +0000 | [diff] [blame] | 315 | bool &ReleasedAllocated, |
| 316 | bool ReturnsNullOnFailure = false) const; |
Anna Zaks | 0d6989b | 2012-06-22 02:04:31 +0000 | [diff] [blame] | 317 | ProgramStateRef FreeMemAux(CheckerContext &C, const Expr *Arg, |
| 318 | const Expr *ParentExpr, |
Anna Zaks | 67291b9 | 2012-11-13 03:18:01 +0000 | [diff] [blame] | 319 | ProgramStateRef State, |
Anna Zaks | fe6eb67 | 2012-08-24 02:28:20 +0000 | [diff] [blame] | 320 | bool Hold, |
Anna Zaks | 67291b9 | 2012-11-13 03:18:01 +0000 | [diff] [blame] | 321 | bool &ReleasedAllocated, |
| 322 | bool ReturnsNullOnFailure = false) const; |
Zhongxing Xu | c0484fa | 2009-12-12 12:29:38 +0000 | [diff] [blame] | 323 | |
Anna Zaks | 40a7eb3 | 2012-02-22 19:24:52 +0000 | [diff] [blame] | 324 | ProgramStateRef ReallocMem(CheckerContext &C, const CallExpr *CE, |
Ted Kremenek | 3a0678e | 2015-09-08 03:50:52 +0000 | [diff] [blame] | 325 | bool FreesMemOnFailure, |
Anton Yartsev | b3fa86d | 2015-02-10 20:13:08 +0000 | [diff] [blame] | 326 | ProgramStateRef State) const; |
| 327 | static ProgramStateRef CallocMem(CheckerContext &C, const CallExpr *CE, |
| 328 | ProgramStateRef State); |
Ted Kremenek | 3a0678e | 2015-09-08 03:50:52 +0000 | [diff] [blame] | 329 | |
Anna Zaks | 46d0160 | 2012-05-18 01:16:10 +0000 | [diff] [blame] | 330 | ///\brief Check if the memory associated with this symbol was released. |
| 331 | bool isReleased(SymbolRef Sym, CheckerContext &C) const; |
| 332 | |
Anton Yartsev | 13df036 | 2013-03-25 01:35:45 +0000 | [diff] [blame] | 333 | bool checkUseAfterFree(SymbolRef Sym, CheckerContext &C, const Stmt *S) const; |
Anna Zaks | a1b227b | 2012-02-08 23:16:56 +0000 | [diff] [blame] | 334 | |
Ted Kremenek | 3a0678e | 2015-09-08 03:50:52 +0000 | [diff] [blame] | 335 | void checkUseZeroAllocated(SymbolRef Sym, CheckerContext &C, |
Anton Yartsev | b50f4ba | 2015-04-14 14:18:04 +0000 | [diff] [blame] | 336 | const Stmt *S) const; |
| 337 | |
Jordan Rose | 656fdd5 | 2014-01-08 18:46:55 +0000 | [diff] [blame] | 338 | bool checkDoubleDelete(SymbolRef Sym, CheckerContext &C) const; |
| 339 | |
Anna Zaks | a4bc5e1 | 2013-05-31 23:47:32 +0000 | [diff] [blame] | 340 | /// Check if the function is known free memory, or if it is |
Jordan Rose | 613f3c0 | 2013-03-09 00:59:10 +0000 | [diff] [blame] | 341 | /// "interesting" and should be modeled explicitly. |
| 342 | /// |
Ted Kremenek | 3a0678e | 2015-09-08 03:50:52 +0000 | [diff] [blame] | 343 | /// \param [out] EscapingSymbol A function might not free memory in general, |
Anna Zaks | 8ebeb64 | 2013-06-08 00:29:29 +0000 | [diff] [blame] | 344 | /// but could be known to free a particular symbol. In this case, false is |
Anna Zaks | a4bc5e1 | 2013-05-31 23:47:32 +0000 | [diff] [blame] | 345 | /// returned and the single escaping symbol is returned through the out |
| 346 | /// parameter. |
| 347 | /// |
Jordan Rose | 613f3c0 | 2013-03-09 00:59:10 +0000 | [diff] [blame] | 348 | /// We assume that pointers do not escape through calls to system functions |
| 349 | /// not handled by this checker. |
Anna Zaks | 8ebeb64 | 2013-06-08 00:29:29 +0000 | [diff] [blame] | 350 | bool mayFreeAnyEscapedMemoryOrIsModeledExplicitly(const CallEvent *Call, |
Anna Zaks | a4bc5e1 | 2013-05-31 23:47:32 +0000 | [diff] [blame] | 351 | ProgramStateRef State, |
| 352 | SymbolRef &EscapingSymbol) const; |
Anna Zaks | 3d34834 | 2012-02-14 21:55:24 +0000 | [diff] [blame] | 353 | |
Anna Zaks | 333481b | 2013-03-28 23:15:29 +0000 | [diff] [blame] | 354 | // Implementation of the checkPointerEscape callabcks. |
| 355 | ProgramStateRef checkPointerEscapeAux(ProgramStateRef State, |
| 356 | const InvalidatedSymbols &Escaped, |
| 357 | const CallEvent *Call, |
| 358 | PointerEscapeKind Kind, |
| 359 | bool(*CheckRefState)(const RefState*)) const; |
| 360 | |
Anton Yartsev | 1e2bc9b | 2013-04-11 00:05:20 +0000 | [diff] [blame] | 361 | ///@{ |
| 362 | /// Tells if a given family/call/symbol is tracked by the current checker. |
Anton Yartsev | 4eb394d | 2015-03-07 00:31:53 +0000 | [diff] [blame] | 363 | /// Sets CheckKind to the kind of the checker responsible for this |
| 364 | /// family/call/symbol. |
Anton Yartsev | 2487dd6 | 2015-03-10 22:24:21 +0000 | [diff] [blame] | 365 | Optional<CheckKind> getCheckIfTracked(AllocationFamily Family, |
| 366 | bool IsALeakCheck = false) const; |
Anton Yartsev | 4eb394d | 2015-03-07 00:31:53 +0000 | [diff] [blame] | 367 | Optional<CheckKind> getCheckIfTracked(CheckerContext &C, |
Anton Yartsev | 2487dd6 | 2015-03-10 22:24:21 +0000 | [diff] [blame] | 368 | const Stmt *AllocDeallocStmt, |
| 369 | bool IsALeakCheck = false) const; |
Ted Kremenek | 3a0678e | 2015-09-08 03:50:52 +0000 | [diff] [blame] | 370 | Optional<CheckKind> getCheckIfTracked(CheckerContext &C, SymbolRef Sym, |
Anton Yartsev | 2487dd6 | 2015-03-10 22:24:21 +0000 | [diff] [blame] | 371 | bool IsALeakCheck = false) const; |
Anton Yartsev | 1e2bc9b | 2013-04-11 00:05:20 +0000 | [diff] [blame] | 372 | ///@} |
Ted Kremenek | 5ef32db | 2011-08-12 23:37:29 +0000 | [diff] [blame] | 373 | static bool SummarizeValue(raw_ostream &os, SVal V); |
| 374 | static bool SummarizeRegion(raw_ostream &os, const MemRegion *MR); |
Ted Kremenek | 3a0678e | 2015-09-08 03:50:52 +0000 | [diff] [blame] | 375 | void ReportBadFree(CheckerContext &C, SVal ArgVal, SourceRange Range, |
Anton Yartsev | 0578959 | 2013-03-28 17:05:19 +0000 | [diff] [blame] | 376 | const Expr *DeallocExpr) const; |
Anton Yartsev | 5b5c7ce | 2015-02-19 13:36:20 +0000 | [diff] [blame] | 377 | void ReportFreeAlloca(CheckerContext &C, SVal ArgVal, |
| 378 | SourceRange Range) const; |
Anton Yartsev | e3377fb | 2013-04-04 23:46:29 +0000 | [diff] [blame] | 379 | void ReportMismatchedDealloc(CheckerContext &C, SourceRange Range, |
Anton Yartsev | f0593d6 | 2013-04-05 11:25:10 +0000 | [diff] [blame] | 380 | const Expr *DeallocExpr, const RefState *RS, |
Anton Yartsev | f5bccce | 2013-09-16 17:51:25 +0000 | [diff] [blame] | 381 | SymbolRef Sym, bool OwnershipTransferred) const; |
Ted Kremenek | 3a0678e | 2015-09-08 03:50:52 +0000 | [diff] [blame] | 382 | void ReportOffsetFree(CheckerContext &C, SVal ArgVal, SourceRange Range, |
| 383 | const Expr *DeallocExpr, |
Craig Topper | 0dbb783 | 2014-05-27 02:45:47 +0000 | [diff] [blame] | 384 | const Expr *AllocExpr = nullptr) const; |
Anton Yartsev | 59ed15b | 2013-03-13 14:39:10 +0000 | [diff] [blame] | 385 | void ReportUseAfterFree(CheckerContext &C, SourceRange Range, |
| 386 | SymbolRef Sym) const; |
| 387 | void ReportDoubleFree(CheckerContext &C, SourceRange Range, bool Released, |
Anton Yartsev | 6c2af43 | 2013-03-13 17:07:32 +0000 | [diff] [blame] | 388 | SymbolRef Sym, SymbolRef PrevSym) const; |
Anna Zaks | 2b5bb97 | 2012-02-09 06:25:51 +0000 | [diff] [blame] | 389 | |
Jordan Rose | 656fdd5 | 2014-01-08 18:46:55 +0000 | [diff] [blame] | 390 | void ReportDoubleDelete(CheckerContext &C, SymbolRef Sym) const; |
| 391 | |
Anton Yartsev | b50f4ba | 2015-04-14 14:18:04 +0000 | [diff] [blame] | 392 | void ReportUseZeroAllocated(CheckerContext &C, SourceRange Range, |
| 393 | SymbolRef Sym) const; |
| 394 | |
Anna Zaks | df901a4 | 2012-02-23 21:38:21 +0000 | [diff] [blame] | 395 | /// Find the location of the allocation for Sym on the path leading to the |
| 396 | /// exploded node N. |
Anna Zaks | fc2e153 | 2012-03-21 19:45:08 +0000 | [diff] [blame] | 397 | LeakInfo getAllocationSite(const ExplodedNode *N, SymbolRef Sym, |
| 398 | CheckerContext &C) const; |
Anna Zaks | df901a4 | 2012-02-23 21:38:21 +0000 | [diff] [blame] | 399 | |
Anna Zaks | d3571e5a | 2012-02-11 21:02:40 +0000 | [diff] [blame] | 400 | void reportLeak(SymbolRef Sym, ExplodedNode *N, CheckerContext &C) const; |
| 401 | |
Anna Zaks | 2b5bb97 | 2012-02-09 06:25:51 +0000 | [diff] [blame] | 402 | /// The bug visitor which allows us to print extra diagnostics along the |
| 403 | /// BugReport path. For example, showing the allocation site of the leaked |
| 404 | /// region. |
David Blaikie | 6951e3e | 2015-08-13 22:58:37 +0000 | [diff] [blame] | 405 | class MallocBugVisitor final |
| 406 | : public BugReporterVisitorImpl<MallocBugVisitor> { |
Anna Zaks | 2b5bb97 | 2012-02-09 06:25:51 +0000 | [diff] [blame] | 407 | protected: |
Anna Zaks | 9eb7bc8 | 2012-02-16 22:26:07 +0000 | [diff] [blame] | 408 | enum NotificationMode { |
| 409 | Normal, |
Anna Zaks | 9eb7bc8 | 2012-02-16 22:26:07 +0000 | [diff] [blame] | 410 | ReallocationFailed |
| 411 | }; |
| 412 | |
Anna Zaks | 2b5bb97 | 2012-02-09 06:25:51 +0000 | [diff] [blame] | 413 | // The allocated region symbol tracked by the main analysis. |
| 414 | SymbolRef Sym; |
| 415 | |
Anna Zaks | 62cce9e | 2012-05-10 01:37:40 +0000 | [diff] [blame] | 416 | // The mode we are in, i.e. what kind of diagnostics will be emitted. |
| 417 | NotificationMode Mode; |
Jordy Rose | 21ff76e | 2012-03-24 03:15:09 +0000 | [diff] [blame] | 418 | |
Anna Zaks | 62cce9e | 2012-05-10 01:37:40 +0000 | [diff] [blame] | 419 | // A symbol from when the primary region should have been reallocated. |
| 420 | SymbolRef FailedReallocSymbol; |
Jordy Rose | 21ff76e | 2012-03-24 03:15:09 +0000 | [diff] [blame] | 421 | |
Anna Zaks | 62cce9e | 2012-05-10 01:37:40 +0000 | [diff] [blame] | 422 | bool IsLeak; |
| 423 | |
| 424 | public: |
| 425 | MallocBugVisitor(SymbolRef S, bool isLeak = false) |
Craig Topper | 0dbb783 | 2014-05-27 02:45:47 +0000 | [diff] [blame] | 426 | : Sym(S), Mode(Normal), FailedReallocSymbol(nullptr), IsLeak(isLeak) {} |
Jordy Rose | 21ff76e | 2012-03-24 03:15:09 +0000 | [diff] [blame] | 427 | |
Craig Topper | fb6b25b | 2014-03-15 04:29:04 +0000 | [diff] [blame] | 428 | void Profile(llvm::FoldingSetNodeID &ID) const override { |
Anna Zaks | 2b5bb97 | 2012-02-09 06:25:51 +0000 | [diff] [blame] | 429 | static int X = 0; |
| 430 | ID.AddPointer(&X); |
| 431 | ID.AddPointer(Sym); |
| 432 | } |
| 433 | |
Anna Zaks | 9eb7bc8 | 2012-02-16 22:26:07 +0000 | [diff] [blame] | 434 | inline bool isAllocated(const RefState *S, const RefState *SPrev, |
| 435 | const Stmt *Stmt) { |
Anna Zaks | 2b5bb97 | 2012-02-09 06:25:51 +0000 | [diff] [blame] | 436 | // Did not track -> allocated. Other state (released) -> allocated. |
Anton Yartsev | 13df036 | 2013-03-25 01:35:45 +0000 | [diff] [blame] | 437 | return (Stmt && (isa<CallExpr>(Stmt) || isa<CXXNewExpr>(Stmt)) && |
Ted Kremenek | 3a0678e | 2015-09-08 03:50:52 +0000 | [diff] [blame] | 438 | (S && (S->isAllocated() || S->isAllocatedOfSizeZero())) && |
| 439 | (!SPrev || !(SPrev->isAllocated() || |
Anton Yartsev | b50f4ba | 2015-04-14 14:18:04 +0000 | [diff] [blame] | 440 | SPrev->isAllocatedOfSizeZero()))); |
Anna Zaks | 2b5bb97 | 2012-02-09 06:25:51 +0000 | [diff] [blame] | 441 | } |
| 442 | |
Anna Zaks | 9eb7bc8 | 2012-02-16 22:26:07 +0000 | [diff] [blame] | 443 | inline bool isReleased(const RefState *S, const RefState *SPrev, |
| 444 | const Stmt *Stmt) { |
Anna Zaks | 2b5bb97 | 2012-02-09 06:25:51 +0000 | [diff] [blame] | 445 | // Did not track -> released. Other state (allocated) -> released. |
Anton Yartsev | 13df036 | 2013-03-25 01:35:45 +0000 | [diff] [blame] | 446 | return (Stmt && (isa<CallExpr>(Stmt) || isa<CXXDeleteExpr>(Stmt)) && |
Anna Zaks | 9eb7bc8 | 2012-02-16 22:26:07 +0000 | [diff] [blame] | 447 | (S && S->isReleased()) && (!SPrev || !SPrev->isReleased())); |
| 448 | } |
| 449 | |
Anna Zaks | 0d6989b | 2012-06-22 02:04:31 +0000 | [diff] [blame] | 450 | inline bool isRelinquished(const RefState *S, const RefState *SPrev, |
| 451 | const Stmt *Stmt) { |
| 452 | // Did not track -> relinquished. Other state (allocated) -> relinquished. |
| 453 | return (Stmt && (isa<CallExpr>(Stmt) || isa<ObjCMessageExpr>(Stmt) || |
| 454 | isa<ObjCPropertyRefExpr>(Stmt)) && |
| 455 | (S && S->isRelinquished()) && |
| 456 | (!SPrev || !SPrev->isRelinquished())); |
| 457 | } |
| 458 | |
Anna Zaks | 9eb7bc8 | 2012-02-16 22:26:07 +0000 | [diff] [blame] | 459 | inline bool isReallocFailedCheck(const RefState *S, const RefState *SPrev, |
| 460 | const Stmt *Stmt) { |
| 461 | // If the expression is not a call, and the state change is |
| 462 | // released -> allocated, it must be the realloc return value |
| 463 | // check. If we have to handle more cases here, it might be cleaner just |
| 464 | // to track this extra bit in the state itself. |
| 465 | return ((!Stmt || !isa<CallExpr>(Stmt)) && |
Anton Yartsev | b50f4ba | 2015-04-14 14:18:04 +0000 | [diff] [blame] | 466 | (S && (S->isAllocated() || S->isAllocatedOfSizeZero())) && |
| 467 | (SPrev && !(SPrev->isAllocated() || |
| 468 | SPrev->isAllocatedOfSizeZero()))); |
Anna Zaks | 2b5bb97 | 2012-02-09 06:25:51 +0000 | [diff] [blame] | 469 | } |
| 470 | |
David Blaikie | 0a0c275 | 2017-01-05 17:26:53 +0000 | [diff] [blame] | 471 | std::shared_ptr<PathDiagnosticPiece> VisitNode(const ExplodedNode *N, |
| 472 | const ExplodedNode *PrevN, |
| 473 | BugReporterContext &BRC, |
| 474 | BugReport &BR) override; |
Anna Zaks | 62cce9e | 2012-05-10 01:37:40 +0000 | [diff] [blame] | 475 | |
David Blaikie | d15481c | 2014-08-29 18:18:43 +0000 | [diff] [blame] | 476 | std::unique_ptr<PathDiagnosticPiece> |
| 477 | getEndPath(BugReporterContext &BRC, const ExplodedNode *EndPathNode, |
| 478 | BugReport &BR) override { |
Anna Zaks | 62cce9e | 2012-05-10 01:37:40 +0000 | [diff] [blame] | 479 | if (!IsLeak) |
Craig Topper | 0dbb783 | 2014-05-27 02:45:47 +0000 | [diff] [blame] | 480 | return nullptr; |
Anna Zaks | 62cce9e | 2012-05-10 01:37:40 +0000 | [diff] [blame] | 481 | |
| 482 | PathDiagnosticLocation L = |
| 483 | PathDiagnosticLocation::createEndOfPath(EndPathNode, |
| 484 | BRC.getSourceManager()); |
| 485 | // Do not add the statement itself as a range in case of leak. |
David Blaikie | d15481c | 2014-08-29 18:18:43 +0000 | [diff] [blame] | 486 | return llvm::make_unique<PathDiagnosticEventPiece>(L, BR.getDescription(), |
| 487 | false); |
Anna Zaks | 62cce9e | 2012-05-10 01:37:40 +0000 | [diff] [blame] | 488 | } |
| 489 | |
Anna Zaks | cba4f29 | 2012-03-16 23:24:20 +0000 | [diff] [blame] | 490 | private: |
| 491 | class StackHintGeneratorForReallocationFailed |
| 492 | : public StackHintGeneratorForSymbol { |
| 493 | public: |
| 494 | StackHintGeneratorForReallocationFailed(SymbolRef S, StringRef M) |
| 495 | : StackHintGeneratorForSymbol(S, M) {} |
| 496 | |
Craig Topper | fb6b25b | 2014-03-15 04:29:04 +0000 | [diff] [blame] | 497 | std::string getMessageForArg(const Expr *ArgE, |
| 498 | unsigned ArgIndex) override { |
Jordan Rose | c102b35 | 2012-09-22 01:24:42 +0000 | [diff] [blame] | 499 | // Printed parameters start at 1, not 0. |
| 500 | ++ArgIndex; |
| 501 | |
Anna Zaks | cba4f29 | 2012-03-16 23:24:20 +0000 | [diff] [blame] | 502 | SmallString<200> buf; |
| 503 | llvm::raw_svector_ostream os(buf); |
| 504 | |
Jordan Rose | c102b35 | 2012-09-22 01:24:42 +0000 | [diff] [blame] | 505 | os << "Reallocation of " << ArgIndex << llvm::getOrdinalSuffix(ArgIndex) |
| 506 | << " parameter failed"; |
Anna Zaks | cba4f29 | 2012-03-16 23:24:20 +0000 | [diff] [blame] | 507 | |
| 508 | return os.str(); |
| 509 | } |
| 510 | |
Craig Topper | fb6b25b | 2014-03-15 04:29:04 +0000 | [diff] [blame] | 511 | std::string getMessageForReturn(const CallExpr *CallExpr) override { |
Anna Zaks | a7f457a | 2012-03-16 23:44:28 +0000 | [diff] [blame] | 512 | return "Reallocation of returned value failed"; |
Anna Zaks | cba4f29 | 2012-03-16 23:24:20 +0000 | [diff] [blame] | 513 | } |
| 514 | }; |
Anna Zaks | 2b5bb97 | 2012-02-09 06:25:51 +0000 | [diff] [blame] | 515 | }; |
Zhongxing Xu | 88cca6b | 2009-11-12 08:38:56 +0000 | [diff] [blame] | 516 | }; |
Kovarththanan Rajaratnam | 65c6566 | 2009-11-28 06:07:30 +0000 | [diff] [blame] | 517 | } // end anonymous namespace |
Zhongxing Xu | 88cca6b | 2009-11-12 08:38:56 +0000 | [diff] [blame] | 518 | |
Jordan Rose | 0c153cb | 2012-11-02 01:54:06 +0000 | [diff] [blame] | 519 | REGISTER_MAP_WITH_PROGRAMSTATE(RegionState, SymbolRef, RefState) |
| 520 | REGISTER_MAP_WITH_PROGRAMSTATE(ReallocPairs, SymbolRef, ReallocPair) |
Devin Coughlin | 8177173 | 2015-09-22 22:47:14 +0000 | [diff] [blame] | 521 | REGISTER_SET_WITH_PROGRAMSTATE(ReallocSizeZeroSymbols, SymbolRef) |
Zhongxing Xu | 88cca6b | 2009-11-12 08:38:56 +0000 | [diff] [blame] | 522 | |
Ted Kremenek | 3a0678e | 2015-09-08 03:50:52 +0000 | [diff] [blame] | 523 | // A map from the freed symbol to the symbol representing the return value of |
Anna Zaks | 67291b9 | 2012-11-13 03:18:01 +0000 | [diff] [blame] | 524 | // the free function. |
| 525 | REGISTER_MAP_WITH_PROGRAMSTATE(FreeReturnValue, SymbolRef, SymbolRef) |
| 526 | |
Anna Zaks | bb1ef90 | 2012-02-11 21:02:35 +0000 | [diff] [blame] | 527 | namespace { |
David Blaikie | 903c293 | 2015-08-13 22:50:09 +0000 | [diff] [blame] | 528 | class StopTrackingCallback final : public SymbolVisitor { |
Anna Zaks | bb1ef90 | 2012-02-11 21:02:35 +0000 | [diff] [blame] | 529 | ProgramStateRef state; |
| 530 | public: |
Benjamin Kramer | cfeacf5 | 2016-05-27 14:27:13 +0000 | [diff] [blame] | 531 | StopTrackingCallback(ProgramStateRef st) : state(std::move(st)) {} |
Anna Zaks | bb1ef90 | 2012-02-11 21:02:35 +0000 | [diff] [blame] | 532 | ProgramStateRef getState() const { return state; } |
| 533 | |
Craig Topper | fb6b25b | 2014-03-15 04:29:04 +0000 | [diff] [blame] | 534 | bool VisitSymbol(SymbolRef sym) override { |
Anna Zaks | bb1ef90 | 2012-02-11 21:02:35 +0000 | [diff] [blame] | 535 | state = state->remove<RegionState>(sym); |
| 536 | return true; |
| 537 | } |
| 538 | }; |
| 539 | } // end anonymous namespace |
| 540 | |
Anna Zaks | 3d34834 | 2012-02-14 21:55:24 +0000 | [diff] [blame] | 541 | void MallocChecker::initIdentifierInfo(ASTContext &Ctx) const { |
Anna Zaks | b343660 | 2012-05-18 22:47:40 +0000 | [diff] [blame] | 542 | if (II_malloc) |
| 543 | return; |
Anton Yartsev | 5b5c7ce | 2015-02-19 13:36:20 +0000 | [diff] [blame] | 544 | II_alloca = &Ctx.Idents.get("alloca"); |
Anna Zaks | b343660 | 2012-05-18 22:47:40 +0000 | [diff] [blame] | 545 | II_malloc = &Ctx.Idents.get("malloc"); |
| 546 | II_free = &Ctx.Idents.get("free"); |
| 547 | II_realloc = &Ctx.Idents.get("realloc"); |
| 548 | II_reallocf = &Ctx.Idents.get("reallocf"); |
| 549 | II_calloc = &Ctx.Idents.get("calloc"); |
| 550 | II_valloc = &Ctx.Idents.get("valloc"); |
| 551 | II_strdup = &Ctx.Idents.get("strdup"); |
| 552 | II_strndup = &Ctx.Idents.get("strndup"); |
Anna Zaks | 30d4668 | 2016-03-08 01:21:51 +0000 | [diff] [blame] | 553 | II_wcsdup = &Ctx.Idents.get("wcsdup"); |
Jordan Rose | 6b33c6f | 2014-03-26 17:05:46 +0000 | [diff] [blame] | 554 | II_kmalloc = &Ctx.Idents.get("kmalloc"); |
Anna Zaks | d79b840 | 2014-10-03 21:48:59 +0000 | [diff] [blame] | 555 | II_if_nameindex = &Ctx.Idents.get("if_nameindex"); |
| 556 | II_if_freenameindex = &Ctx.Idents.get("if_freenameindex"); |
Anna Zaks | 30d4668 | 2016-03-08 01:21:51 +0000 | [diff] [blame] | 557 | |
| 558 | //MSVC uses `_`-prefixed instead, so we check for them too. |
| 559 | II_win_strdup = &Ctx.Idents.get("_strdup"); |
| 560 | II_win_wcsdup = &Ctx.Idents.get("_wcsdup"); |
| 561 | II_win_alloca = &Ctx.Idents.get("_alloca"); |
Anna Zaks | bbec97c | 2017-03-09 00:01:01 +0000 | [diff] [blame^] | 562 | |
| 563 | // Glib |
| 564 | II_g_malloc = &Ctx.Idents.get("g_malloc"); |
| 565 | II_g_malloc0 = &Ctx.Idents.get("g_malloc0"); |
| 566 | II_g_realloc = &Ctx.Idents.get("g_realloc"); |
| 567 | II_g_try_malloc = &Ctx.Idents.get("g_try_malloc"); |
| 568 | II_g_try_malloc0 = &Ctx.Idents.get("g_try_malloc0"); |
| 569 | II_g_try_realloc = &Ctx.Idents.get("g_try_realloc"); |
| 570 | II_g_free = &Ctx.Idents.get("g_free"); |
| 571 | II_g_memdup = &Ctx.Idents.get("g_memdup"); |
Anna Zaks | c68bf4c | 2012-02-08 20:13:28 +0000 | [diff] [blame] | 572 | } |
| 573 | |
Anna Zaks | 3d34834 | 2012-02-14 21:55:24 +0000 | [diff] [blame] | 574 | bool MallocChecker::isMemFunction(const FunctionDecl *FD, ASTContext &C) const { |
Anna Zaks | d79b840 | 2014-10-03 21:48:59 +0000 | [diff] [blame] | 575 | if (isCMemFunction(FD, C, AF_Malloc, MemoryOperationKind::MOK_Any)) |
Anna Zaks | 46d0160 | 2012-05-18 01:16:10 +0000 | [diff] [blame] | 576 | return true; |
| 577 | |
Anna Zaks | d79b840 | 2014-10-03 21:48:59 +0000 | [diff] [blame] | 578 | if (isCMemFunction(FD, C, AF_IfNameIndex, MemoryOperationKind::MOK_Any)) |
Anna Zaks | 46d0160 | 2012-05-18 01:16:10 +0000 | [diff] [blame] | 579 | return true; |
| 580 | |
Anton Yartsev | 5b5c7ce | 2015-02-19 13:36:20 +0000 | [diff] [blame] | 581 | if (isCMemFunction(FD, C, AF_Alloca, MemoryOperationKind::MOK_Any)) |
| 582 | return true; |
| 583 | |
Anton Yartsev | 13df036 | 2013-03-25 01:35:45 +0000 | [diff] [blame] | 584 | if (isStandardNewDelete(FD, C)) |
| 585 | return true; |
| 586 | |
Anna Zaks | 46d0160 | 2012-05-18 01:16:10 +0000 | [diff] [blame] | 587 | return false; |
| 588 | } |
| 589 | |
Anna Zaks | d79b840 | 2014-10-03 21:48:59 +0000 | [diff] [blame] | 590 | bool MallocChecker::isCMemFunction(const FunctionDecl *FD, |
| 591 | ASTContext &C, |
| 592 | AllocationFamily Family, |
Benjamin Kramer | 719772c | 2014-10-03 22:20:30 +0000 | [diff] [blame] | 593 | MemoryOperationKind MemKind) const { |
Anna Zaks | d1ff1cb | 2012-02-15 02:12:00 +0000 | [diff] [blame] | 594 | if (!FD) |
| 595 | return false; |
Anna Zaks | 46d0160 | 2012-05-18 01:16:10 +0000 | [diff] [blame] | 596 | |
Anna Zaks | d79b840 | 2014-10-03 21:48:59 +0000 | [diff] [blame] | 597 | bool CheckFree = (MemKind == MemoryOperationKind::MOK_Any || |
| 598 | MemKind == MemoryOperationKind::MOK_Free); |
| 599 | bool CheckAlloc = (MemKind == MemoryOperationKind::MOK_Any || |
| 600 | MemKind == MemoryOperationKind::MOK_Allocate); |
| 601 | |
Jordan Rose | 6cd16c5 | 2012-07-10 23:13:01 +0000 | [diff] [blame] | 602 | if (FD->getKind() == Decl::Function) { |
Anna Zaks | d79b840 | 2014-10-03 21:48:59 +0000 | [diff] [blame] | 603 | const IdentifierInfo *FunI = FD->getIdentifier(); |
Jordan Rose | 6cd16c5 | 2012-07-10 23:13:01 +0000 | [diff] [blame] | 604 | initIdentifierInfo(C); |
Anna Zaks | 3d34834 | 2012-02-14 21:55:24 +0000 | [diff] [blame] | 605 | |
Anna Zaks | d79b840 | 2014-10-03 21:48:59 +0000 | [diff] [blame] | 606 | if (Family == AF_Malloc && CheckFree) { |
Anna Zaks | bbec97c | 2017-03-09 00:01:01 +0000 | [diff] [blame^] | 607 | if (FunI == II_free || FunI == II_realloc || FunI == II_reallocf || |
| 608 | FunI == II_g_free) |
Anna Zaks | d79b840 | 2014-10-03 21:48:59 +0000 | [diff] [blame] | 609 | return true; |
| 610 | } |
| 611 | |
| 612 | if (Family == AF_Malloc && CheckAlloc) { |
| 613 | if (FunI == II_malloc || FunI == II_realloc || FunI == II_reallocf || |
| 614 | FunI == II_calloc || FunI == II_valloc || FunI == II_strdup || |
Anna Zaks | 30d4668 | 2016-03-08 01:21:51 +0000 | [diff] [blame] | 615 | FunI == II_win_strdup || FunI == II_strndup || FunI == II_wcsdup || |
Anna Zaks | bbec97c | 2017-03-09 00:01:01 +0000 | [diff] [blame^] | 616 | FunI == II_win_wcsdup || FunI == II_kmalloc || |
| 617 | FunI == II_g_malloc || FunI == II_g_malloc0 || |
| 618 | FunI == II_g_realloc || FunI == II_g_try_malloc || |
| 619 | FunI == II_g_try_malloc0 || FunI == II_g_try_realloc || |
| 620 | FunI == II_g_memdup) |
Anna Zaks | d79b840 | 2014-10-03 21:48:59 +0000 | [diff] [blame] | 621 | return true; |
| 622 | } |
| 623 | |
| 624 | if (Family == AF_IfNameIndex && CheckFree) { |
| 625 | if (FunI == II_if_freenameindex) |
| 626 | return true; |
| 627 | } |
| 628 | |
| 629 | if (Family == AF_IfNameIndex && CheckAlloc) { |
| 630 | if (FunI == II_if_nameindex) |
| 631 | return true; |
| 632 | } |
Anton Yartsev | 5b5c7ce | 2015-02-19 13:36:20 +0000 | [diff] [blame] | 633 | |
| 634 | if (Family == AF_Alloca && CheckAlloc) { |
Anna Zaks | 30d4668 | 2016-03-08 01:21:51 +0000 | [diff] [blame] | 635 | if (FunI == II_alloca || FunI == II_win_alloca) |
Anton Yartsev | 5b5c7ce | 2015-02-19 13:36:20 +0000 | [diff] [blame] | 636 | return true; |
| 637 | } |
Jordan Rose | 6cd16c5 | 2012-07-10 23:13:01 +0000 | [diff] [blame] | 638 | } |
Anna Zaks | 3d34834 | 2012-02-14 21:55:24 +0000 | [diff] [blame] | 639 | |
Anna Zaks | d79b840 | 2014-10-03 21:48:59 +0000 | [diff] [blame] | 640 | if (Family != AF_Malloc) |
Anna Zaks | 46d0160 | 2012-05-18 01:16:10 +0000 | [diff] [blame] | 641 | return false; |
| 642 | |
Gabor Horvath | e40c71c | 2015-03-04 17:59:34 +0000 | [diff] [blame] | 643 | if (IsOptimistic && FD->hasAttrs()) { |
Anna Zaks | d79b840 | 2014-10-03 21:48:59 +0000 | [diff] [blame] | 644 | for (const auto *I : FD->specific_attrs<OwnershipAttr>()) { |
| 645 | OwnershipAttr::OwnershipKind OwnKind = I->getOwnKind(); |
| 646 | if(OwnKind == OwnershipAttr::Takes || OwnKind == OwnershipAttr::Holds) { |
| 647 | if (CheckFree) |
| 648 | return true; |
| 649 | } else if (OwnKind == OwnershipAttr::Returns) { |
| 650 | if (CheckAlloc) |
| 651 | return true; |
| 652 | } |
| 653 | } |
Jordan Rose | 6cd16c5 | 2012-07-10 23:13:01 +0000 | [diff] [blame] | 654 | } |
Anna Zaks | 3d34834 | 2012-02-14 21:55:24 +0000 | [diff] [blame] | 655 | |
Anna Zaks | 3d34834 | 2012-02-14 21:55:24 +0000 | [diff] [blame] | 656 | return false; |
| 657 | } |
| 658 | |
Anton Yartsev | 8b66270 | 2013-03-28 16:10:38 +0000 | [diff] [blame] | 659 | // Tells if the callee is one of the following: |
| 660 | // 1) A global non-placement new/delete operator function. |
| 661 | // 2) A global placement operator function with the single placement argument |
| 662 | // of type std::nothrow_t. |
Anton Yartsev | 13df036 | 2013-03-25 01:35:45 +0000 | [diff] [blame] | 663 | bool MallocChecker::isStandardNewDelete(const FunctionDecl *FD, |
| 664 | ASTContext &C) const { |
| 665 | if (!FD) |
| 666 | return false; |
| 667 | |
| 668 | OverloadedOperatorKind Kind = FD->getOverloadedOperator(); |
Ted Kremenek | 3a0678e | 2015-09-08 03:50:52 +0000 | [diff] [blame] | 669 | if (Kind != OO_New && Kind != OO_Array_New && |
Anton Yartsev | 13df036 | 2013-03-25 01:35:45 +0000 | [diff] [blame] | 670 | Kind != OO_Delete && Kind != OO_Array_Delete) |
| 671 | return false; |
| 672 | |
Anton Yartsev | 8b66270 | 2013-03-28 16:10:38 +0000 | [diff] [blame] | 673 | // Skip all operator new/delete methods. |
| 674 | if (isa<CXXMethodDecl>(FD)) |
Anton Yartsev | 13df036 | 2013-03-25 01:35:45 +0000 | [diff] [blame] | 675 | return false; |
| 676 | |
| 677 | // Return true if tested operator is a standard placement nothrow operator. |
| 678 | if (FD->getNumParams() == 2) { |
| 679 | QualType T = FD->getParamDecl(1)->getType(); |
| 680 | if (const IdentifierInfo *II = T.getBaseTypeIdentifier()) |
| 681 | return II->getName().equals("nothrow_t"); |
| 682 | } |
| 683 | |
| 684 | // Skip placement operators. |
| 685 | if (FD->getNumParams() != 1 || FD->isVariadic()) |
| 686 | return false; |
| 687 | |
| 688 | // One of the standard new/new[]/delete/delete[] non-placement operators. |
| 689 | return true; |
| 690 | } |
| 691 | |
Jordan Rose | 6b33c6f | 2014-03-26 17:05:46 +0000 | [diff] [blame] | 692 | llvm::Optional<ProgramStateRef> MallocChecker::performKernelMalloc( |
| 693 | const CallExpr *CE, CheckerContext &C, const ProgramStateRef &State) const { |
| 694 | // 3-argument malloc(), as commonly used in {Free,Net,Open}BSD Kernels: |
| 695 | // |
| 696 | // void *malloc(unsigned long size, struct malloc_type *mtp, int flags); |
| 697 | // |
| 698 | // One of the possible flags is M_ZERO, which means 'give me back an |
| 699 | // allocation which is already zeroed', like calloc. |
| 700 | |
| 701 | // 2-argument kmalloc(), as used in the Linux kernel: |
| 702 | // |
| 703 | // void *kmalloc(size_t size, gfp_t flags); |
| 704 | // |
| 705 | // Has the similar flag value __GFP_ZERO. |
| 706 | |
| 707 | // This logic is largely cloned from O_CREAT in UnixAPIChecker, maybe some |
| 708 | // code could be shared. |
| 709 | |
| 710 | ASTContext &Ctx = C.getASTContext(); |
| 711 | llvm::Triple::OSType OS = Ctx.getTargetInfo().getTriple().getOS(); |
| 712 | |
| 713 | if (!KernelZeroFlagVal.hasValue()) { |
| 714 | if (OS == llvm::Triple::FreeBSD) |
| 715 | KernelZeroFlagVal = 0x0100; |
| 716 | else if (OS == llvm::Triple::NetBSD) |
| 717 | KernelZeroFlagVal = 0x0002; |
| 718 | else if (OS == llvm::Triple::OpenBSD) |
| 719 | KernelZeroFlagVal = 0x0008; |
| 720 | else if (OS == llvm::Triple::Linux) |
| 721 | // __GFP_ZERO |
| 722 | KernelZeroFlagVal = 0x8000; |
| 723 | else |
| 724 | // FIXME: We need a more general way of getting the M_ZERO value. |
| 725 | // See also: O_CREAT in UnixAPIChecker.cpp. |
| 726 | |
| 727 | // Fall back to normal malloc behavior on platforms where we don't |
| 728 | // know M_ZERO. |
| 729 | return None; |
| 730 | } |
| 731 | |
| 732 | // We treat the last argument as the flags argument, and callers fall-back to |
| 733 | // normal malloc on a None return. This works for the FreeBSD kernel malloc |
| 734 | // as well as Linux kmalloc. |
| 735 | if (CE->getNumArgs() < 2) |
| 736 | return None; |
| 737 | |
| 738 | const Expr *FlagsEx = CE->getArg(CE->getNumArgs() - 1); |
| 739 | const SVal V = State->getSVal(FlagsEx, C.getLocationContext()); |
| 740 | if (!V.getAs<NonLoc>()) { |
| 741 | // The case where 'V' can be a location can only be due to a bad header, |
| 742 | // so in this case bail out. |
| 743 | return None; |
| 744 | } |
| 745 | |
| 746 | NonLoc Flags = V.castAs<NonLoc>(); |
| 747 | NonLoc ZeroFlag = C.getSValBuilder() |
| 748 | .makeIntVal(KernelZeroFlagVal.getValue(), FlagsEx->getType()) |
| 749 | .castAs<NonLoc>(); |
| 750 | SVal MaskedFlagsUC = C.getSValBuilder().evalBinOpNN(State, BO_And, |
| 751 | Flags, ZeroFlag, |
| 752 | FlagsEx->getType()); |
| 753 | if (MaskedFlagsUC.isUnknownOrUndef()) |
| 754 | return None; |
| 755 | DefinedSVal MaskedFlags = MaskedFlagsUC.castAs<DefinedSVal>(); |
| 756 | |
| 757 | // Check if maskedFlags is non-zero. |
| 758 | ProgramStateRef TrueState, FalseState; |
| 759 | std::tie(TrueState, FalseState) = State->assume(MaskedFlags); |
| 760 | |
| 761 | // If M_ZERO is set, treat this like calloc (initialized). |
| 762 | if (TrueState && !FalseState) { |
| 763 | SVal ZeroVal = C.getSValBuilder().makeZeroVal(Ctx.CharTy); |
| 764 | return MallocMemAux(C, CE, CE->getArg(0), ZeroVal, TrueState); |
| 765 | } |
| 766 | |
| 767 | return None; |
| 768 | } |
| 769 | |
Anna Zaks | c68bf4c | 2012-02-08 20:13:28 +0000 | [diff] [blame] | 770 | void MallocChecker::checkPostStmt(const CallExpr *CE, CheckerContext &C) const { |
Jordan Rose | d6e5fd5 | 2012-09-20 01:55:32 +0000 | [diff] [blame] | 771 | if (C.wasInlined) |
| 772 | return; |
Jordan Rose | 6b33c6f | 2014-03-26 17:05:46 +0000 | [diff] [blame] | 773 | |
Anna Zaks | c68bf4c | 2012-02-08 20:13:28 +0000 | [diff] [blame] | 774 | const FunctionDecl *FD = C.getCalleeDecl(CE); |
| 775 | if (!FD) |
| 776 | return; |
Zhongxing Xu | 88cca6b | 2009-11-12 08:38:56 +0000 | [diff] [blame] | 777 | |
Anna Zaks | 40a7eb3 | 2012-02-22 19:24:52 +0000 | [diff] [blame] | 778 | ProgramStateRef State = C.getState(); |
Anna Zaks | fe6eb67 | 2012-08-24 02:28:20 +0000 | [diff] [blame] | 779 | bool ReleasedAllocatedMemory = false; |
Jordan Rose | 6cd16c5 | 2012-07-10 23:13:01 +0000 | [diff] [blame] | 780 | |
| 781 | if (FD->getKind() == Decl::Function) { |
| 782 | initIdentifierInfo(C.getASTContext()); |
| 783 | IdentifierInfo *FunI = FD->getIdentifier(); |
| 784 | |
Anna Zaks | bbec97c | 2017-03-09 00:01:01 +0000 | [diff] [blame^] | 785 | if (FunI == II_malloc || FunI == II_g_malloc || FunI == II_g_try_malloc) { |
Jordan Rose | 6b33c6f | 2014-03-26 17:05:46 +0000 | [diff] [blame] | 786 | if (CE->getNumArgs() < 1) |
| 787 | return; |
| 788 | if (CE->getNumArgs() < 3) { |
| 789 | State = MallocMemAux(C, CE, CE->getArg(0), UndefinedVal(), State); |
Anton Yartsev | b50f4ba | 2015-04-14 14:18:04 +0000 | [diff] [blame] | 790 | if (CE->getNumArgs() == 1) |
| 791 | State = ProcessZeroAllocation(C, CE, 0, State); |
Jordan Rose | 6b33c6f | 2014-03-26 17:05:46 +0000 | [diff] [blame] | 792 | } else if (CE->getNumArgs() == 3) { |
| 793 | llvm::Optional<ProgramStateRef> MaybeState = |
| 794 | performKernelMalloc(CE, C, State); |
| 795 | if (MaybeState.hasValue()) |
| 796 | State = MaybeState.getValue(); |
| 797 | else |
| 798 | State = MallocMemAux(C, CE, CE->getArg(0), UndefinedVal(), State); |
| 799 | } |
| 800 | } else if (FunI == II_kmalloc) { |
Devin Coughlin | 684d19d | 2016-10-16 22:19:03 +0000 | [diff] [blame] | 801 | if (CE->getNumArgs() < 1) |
| 802 | return; |
Jordan Rose | 6b33c6f | 2014-03-26 17:05:46 +0000 | [diff] [blame] | 803 | llvm::Optional<ProgramStateRef> MaybeState = |
| 804 | performKernelMalloc(CE, C, State); |
| 805 | if (MaybeState.hasValue()) |
| 806 | State = MaybeState.getValue(); |
| 807 | else |
| 808 | State = MallocMemAux(C, CE, CE->getArg(0), UndefinedVal(), State); |
| 809 | } else if (FunI == II_valloc) { |
Anton Yartsev | e3377fb | 2013-04-04 23:46:29 +0000 | [diff] [blame] | 810 | if (CE->getNumArgs() < 1) |
| 811 | return; |
| 812 | State = MallocMemAux(C, CE, CE->getArg(0), UndefinedVal(), State); |
Anton Yartsev | b50f4ba | 2015-04-14 14:18:04 +0000 | [diff] [blame] | 813 | State = ProcessZeroAllocation(C, CE, 0, State); |
Anna Zaks | bbec97c | 2017-03-09 00:01:01 +0000 | [diff] [blame^] | 814 | } else if (FunI == II_realloc || FunI == II_g_realloc || |
| 815 | FunI == II_g_try_realloc) { |
Anton Yartsev | b3fa86d | 2015-02-10 20:13:08 +0000 | [diff] [blame] | 816 | State = ReallocMem(C, CE, false, State); |
Anton Yartsev | b50f4ba | 2015-04-14 14:18:04 +0000 | [diff] [blame] | 817 | State = ProcessZeroAllocation(C, CE, 1, State); |
Anton Yartsev | e3377fb | 2013-04-04 23:46:29 +0000 | [diff] [blame] | 818 | } else if (FunI == II_reallocf) { |
Anton Yartsev | b3fa86d | 2015-02-10 20:13:08 +0000 | [diff] [blame] | 819 | State = ReallocMem(C, CE, true, State); |
Anton Yartsev | b50f4ba | 2015-04-14 14:18:04 +0000 | [diff] [blame] | 820 | State = ProcessZeroAllocation(C, CE, 1, State); |
Anton Yartsev | e3377fb | 2013-04-04 23:46:29 +0000 | [diff] [blame] | 821 | } else if (FunI == II_calloc) { |
Anton Yartsev | b3fa86d | 2015-02-10 20:13:08 +0000 | [diff] [blame] | 822 | State = CallocMem(C, CE, State); |
Anton Yartsev | b50f4ba | 2015-04-14 14:18:04 +0000 | [diff] [blame] | 823 | State = ProcessZeroAllocation(C, CE, 0, State); |
| 824 | State = ProcessZeroAllocation(C, CE, 1, State); |
Anna Zaks | bbec97c | 2017-03-09 00:01:01 +0000 | [diff] [blame^] | 825 | } else if (FunI == II_free || FunI == II_g_free) { |
Anton Yartsev | e3377fb | 2013-04-04 23:46:29 +0000 | [diff] [blame] | 826 | State = FreeMemAux(C, CE, State, 0, false, ReleasedAllocatedMemory); |
Anna Zaks | 30d4668 | 2016-03-08 01:21:51 +0000 | [diff] [blame] | 827 | } else if (FunI == II_strdup || FunI == II_win_strdup || |
| 828 | FunI == II_wcsdup || FunI == II_win_wcsdup) { |
Anton Yartsev | e3377fb | 2013-04-04 23:46:29 +0000 | [diff] [blame] | 829 | State = MallocUpdateRefState(C, CE, State); |
| 830 | } else if (FunI == II_strndup) { |
| 831 | State = MallocUpdateRefState(C, CE, State); |
Anna Zaks | 30d4668 | 2016-03-08 01:21:51 +0000 | [diff] [blame] | 832 | } else if (FunI == II_alloca || FunI == II_win_alloca) { |
Devin Coughlin | 684d19d | 2016-10-16 22:19:03 +0000 | [diff] [blame] | 833 | if (CE->getNumArgs() < 1) |
| 834 | return; |
Anton Yartsev | 5b5c7ce | 2015-02-19 13:36:20 +0000 | [diff] [blame] | 835 | State = MallocMemAux(C, CE, CE->getArg(0), UndefinedVal(), State, |
| 836 | AF_Alloca); |
Anton Yartsev | b50f4ba | 2015-04-14 14:18:04 +0000 | [diff] [blame] | 837 | State = ProcessZeroAllocation(C, CE, 0, State); |
Anton Yartsev | 5b5c7ce | 2015-02-19 13:36:20 +0000 | [diff] [blame] | 838 | } else if (isStandardNewDelete(FD, C.getASTContext())) { |
Anton Yartsev | e3377fb | 2013-04-04 23:46:29 +0000 | [diff] [blame] | 839 | // Process direct calls to operator new/new[]/delete/delete[] functions |
Ted Kremenek | 3a0678e | 2015-09-08 03:50:52 +0000 | [diff] [blame] | 840 | // as distinct from new/new[]/delete/delete[] expressions that are |
| 841 | // processed by the checkPostStmt callbacks for CXXNewExpr and |
Anton Yartsev | e3377fb | 2013-04-04 23:46:29 +0000 | [diff] [blame] | 842 | // CXXDeleteExpr. |
| 843 | OverloadedOperatorKind K = FD->getOverloadedOperator(); |
Anton Yartsev | b50f4ba | 2015-04-14 14:18:04 +0000 | [diff] [blame] | 844 | if (K == OO_New) { |
Anton Yartsev | e3377fb | 2013-04-04 23:46:29 +0000 | [diff] [blame] | 845 | State = MallocMemAux(C, CE, CE->getArg(0), UndefinedVal(), State, |
| 846 | AF_CXXNew); |
Anton Yartsev | b50f4ba | 2015-04-14 14:18:04 +0000 | [diff] [blame] | 847 | State = ProcessZeroAllocation(C, CE, 0, State); |
| 848 | } |
| 849 | else if (K == OO_Array_New) { |
Anton Yartsev | e3377fb | 2013-04-04 23:46:29 +0000 | [diff] [blame] | 850 | State = MallocMemAux(C, CE, CE->getArg(0), UndefinedVal(), State, |
| 851 | AF_CXXNewArray); |
Anton Yartsev | b50f4ba | 2015-04-14 14:18:04 +0000 | [diff] [blame] | 852 | State = ProcessZeroAllocation(C, CE, 0, State); |
| 853 | } |
Anton Yartsev | e3377fb | 2013-04-04 23:46:29 +0000 | [diff] [blame] | 854 | else if (K == OO_Delete || K == OO_Array_Delete) |
| 855 | State = FreeMemAux(C, CE, State, 0, false, ReleasedAllocatedMemory); |
| 856 | else |
| 857 | llvm_unreachable("not a new/delete operator"); |
Anna Zaks | d79b840 | 2014-10-03 21:48:59 +0000 | [diff] [blame] | 858 | } else if (FunI == II_if_nameindex) { |
| 859 | // Should we model this differently? We can allocate a fixed number of |
| 860 | // elements with zeros in the last one. |
| 861 | State = MallocMemAux(C, CE, UnknownVal(), UnknownVal(), State, |
| 862 | AF_IfNameIndex); |
| 863 | } else if (FunI == II_if_freenameindex) { |
| 864 | State = FreeMemAux(C, CE, State, 0, false, ReleasedAllocatedMemory); |
Anna Zaks | bbec97c | 2017-03-09 00:01:01 +0000 | [diff] [blame^] | 865 | } else if (FunI == II_g_malloc0 || FunI == II_g_try_malloc0) { |
| 866 | if (CE->getNumArgs() < 1) |
| 867 | return; |
| 868 | SValBuilder &svalBuilder = C.getSValBuilder(); |
| 869 | SVal zeroVal = svalBuilder.makeZeroVal(svalBuilder.getContext().CharTy); |
| 870 | State = MallocMemAux(C, CE, CE->getArg(0), zeroVal, State); |
| 871 | State = ProcessZeroAllocation(C, CE, 0, State); |
| 872 | } else if (FunI == II_g_memdup) { |
| 873 | if (CE->getNumArgs() < 2) |
| 874 | return; |
| 875 | State = MallocMemAux(C, CE, CE->getArg(1), UndefinedVal(), State); |
| 876 | State = ProcessZeroAllocation(C, CE, 1, State); |
Jordan Rose | 6cd16c5 | 2012-07-10 23:13:01 +0000 | [diff] [blame] | 877 | } |
| 878 | } |
| 879 | |
Gabor Horvath | e40c71c | 2015-03-04 17:59:34 +0000 | [diff] [blame] | 880 | if (IsOptimistic || ChecksEnabled[CK_MismatchedDeallocatorChecker]) { |
Anna Zaks | 40a7eb3 | 2012-02-22 19:24:52 +0000 | [diff] [blame] | 881 | // Check all the attributes, if there are any. |
| 882 | // There can be multiple of these attributes. |
| 883 | if (FD->hasAttrs()) |
Aaron Ballman | be22bcb | 2014-03-10 17:08:28 +0000 | [diff] [blame] | 884 | for (const auto *I : FD->specific_attrs<OwnershipAttr>()) { |
| 885 | switch (I->getOwnKind()) { |
Anna Zaks | 40a7eb3 | 2012-02-22 19:24:52 +0000 | [diff] [blame] | 886 | case OwnershipAttr::Returns: |
Anton Yartsev | b3fa86d | 2015-02-10 20:13:08 +0000 | [diff] [blame] | 887 | State = MallocMemReturnsAttr(C, CE, I, State); |
Anna Zaks | 40a7eb3 | 2012-02-22 19:24:52 +0000 | [diff] [blame] | 888 | break; |
| 889 | case OwnershipAttr::Takes: |
| 890 | case OwnershipAttr::Holds: |
Anton Yartsev | b3fa86d | 2015-02-10 20:13:08 +0000 | [diff] [blame] | 891 | State = FreeMemAttr(C, CE, I, State); |
Anna Zaks | 40a7eb3 | 2012-02-22 19:24:52 +0000 | [diff] [blame] | 892 | break; |
| 893 | } |
| 894 | } |
Zhongxing Xu | 527ff6d | 2010-06-01 03:01:33 +0000 | [diff] [blame] | 895 | } |
Anna Zaks | 199e8e5 | 2012-02-22 03:14:20 +0000 | [diff] [blame] | 896 | C.addTransition(State); |
Zhongxing Xu | c0484fa | 2009-12-12 12:29:38 +0000 | [diff] [blame] | 897 | } |
| 898 | |
Anton Yartsev | b50f4ba | 2015-04-14 14:18:04 +0000 | [diff] [blame] | 899 | // Performs a 0-sized allocations check. |
| 900 | ProgramStateRef MallocChecker::ProcessZeroAllocation(CheckerContext &C, |
| 901 | const Expr *E, |
| 902 | const unsigned AllocationSizeArg, |
| 903 | ProgramStateRef State) const { |
| 904 | if (!State) |
| 905 | return nullptr; |
| 906 | |
| 907 | const Expr *Arg = nullptr; |
| 908 | |
| 909 | if (const CallExpr *CE = dyn_cast<CallExpr>(E)) { |
| 910 | Arg = CE->getArg(AllocationSizeArg); |
| 911 | } |
| 912 | else if (const CXXNewExpr *NE = dyn_cast<CXXNewExpr>(E)) { |
| 913 | if (NE->isArray()) |
| 914 | Arg = NE->getArraySize(); |
| 915 | else |
| 916 | return State; |
| 917 | } |
| 918 | else |
| 919 | llvm_unreachable("not a CallExpr or CXXNewExpr"); |
| 920 | |
| 921 | assert(Arg); |
| 922 | |
Ted Kremenek | 3a0678e | 2015-09-08 03:50:52 +0000 | [diff] [blame] | 923 | Optional<DefinedSVal> DefArgVal = |
Anton Yartsev | b50f4ba | 2015-04-14 14:18:04 +0000 | [diff] [blame] | 924 | State->getSVal(Arg, C.getLocationContext()).getAs<DefinedSVal>(); |
| 925 | |
| 926 | if (!DefArgVal) |
| 927 | return State; |
| 928 | |
| 929 | // Check if the allocation size is 0. |
| 930 | ProgramStateRef TrueState, FalseState; |
| 931 | SValBuilder &SvalBuilder = C.getSValBuilder(); |
| 932 | DefinedSVal Zero = |
| 933 | SvalBuilder.makeZeroVal(Arg->getType()).castAs<DefinedSVal>(); |
| 934 | |
Ted Kremenek | 3a0678e | 2015-09-08 03:50:52 +0000 | [diff] [blame] | 935 | std::tie(TrueState, FalseState) = |
Anton Yartsev | b50f4ba | 2015-04-14 14:18:04 +0000 | [diff] [blame] | 936 | State->assume(SvalBuilder.evalEQ(State, *DefArgVal, Zero)); |
| 937 | |
| 938 | if (TrueState && !FalseState) { |
| 939 | SVal retVal = State->getSVal(E, C.getLocationContext()); |
| 940 | SymbolRef Sym = retVal.getAsLocSymbol(); |
| 941 | if (!Sym) |
| 942 | return State; |
| 943 | |
| 944 | const RefState *RS = State->get<RegionState>(Sym); |
Devin Coughlin | 8177173 | 2015-09-22 22:47:14 +0000 | [diff] [blame] | 945 | if (RS) { |
| 946 | if (RS->isAllocated()) |
| 947 | return TrueState->set<RegionState>(Sym, |
| 948 | RefState::getAllocatedOfSizeZero(RS)); |
| 949 | else |
| 950 | return State; |
| 951 | } else { |
| 952 | // Case of zero-size realloc. Historically 'realloc(ptr, 0)' is treated as |
| 953 | // 'free(ptr)' and the returned value from 'realloc(ptr, 0)' is not |
| 954 | // tracked. Add zero-reallocated Sym to the state to catch references |
| 955 | // to zero-allocated memory. |
| 956 | return TrueState->add<ReallocSizeZeroSymbols>(Sym); |
| 957 | } |
Anton Yartsev | b50f4ba | 2015-04-14 14:18:04 +0000 | [diff] [blame] | 958 | } |
| 959 | |
| 960 | // Assume the value is non-zero going forward. |
| 961 | assert(FalseState); |
| 962 | return FalseState; |
| 963 | } |
| 964 | |
Anton Yartsev | 4e4cb6b | 2014-08-05 18:26:05 +0000 | [diff] [blame] | 965 | static QualType getDeepPointeeType(QualType T) { |
| 966 | QualType Result = T, PointeeType = T->getPointeeType(); |
| 967 | while (!PointeeType.isNull()) { |
| 968 | Result = PointeeType; |
| 969 | PointeeType = PointeeType->getPointeeType(); |
| 970 | } |
| 971 | return Result; |
| 972 | } |
| 973 | |
| 974 | static bool treatUnusedNewEscaped(const CXXNewExpr *NE) { |
| 975 | |
| 976 | const CXXConstructExpr *ConstructE = NE->getConstructExpr(); |
| 977 | if (!ConstructE) |
| 978 | return false; |
| 979 | |
| 980 | if (!NE->getAllocatedType()->getAsCXXRecordDecl()) |
| 981 | return false; |
| 982 | |
| 983 | const CXXConstructorDecl *CtorD = ConstructE->getConstructor(); |
| 984 | |
| 985 | // Iterate over the constructor parameters. |
David Majnemer | 59f7792 | 2016-06-24 04:05:48 +0000 | [diff] [blame] | 986 | for (const auto *CtorParam : CtorD->parameters()) { |
Anton Yartsev | 4e4cb6b | 2014-08-05 18:26:05 +0000 | [diff] [blame] | 987 | |
| 988 | QualType CtorParamPointeeT = CtorParam->getType()->getPointeeType(); |
| 989 | if (CtorParamPointeeT.isNull()) |
| 990 | continue; |
| 991 | |
| 992 | CtorParamPointeeT = getDeepPointeeType(CtorParamPointeeT); |
| 993 | |
| 994 | if (CtorParamPointeeT->getAsCXXRecordDecl()) |
| 995 | return true; |
| 996 | } |
| 997 | |
| 998 | return false; |
| 999 | } |
| 1000 | |
Ted Kremenek | 3a0678e | 2015-09-08 03:50:52 +0000 | [diff] [blame] | 1001 | void MallocChecker::checkPostStmt(const CXXNewExpr *NE, |
Anton Yartsev | 13df036 | 2013-03-25 01:35:45 +0000 | [diff] [blame] | 1002 | CheckerContext &C) const { |
| 1003 | |
| 1004 | if (NE->getNumPlacementArgs()) |
| 1005 | for (CXXNewExpr::const_arg_iterator I = NE->placement_arg_begin(), |
| 1006 | E = NE->placement_arg_end(); I != E; ++I) |
| 1007 | if (SymbolRef Sym = C.getSVal(*I).getAsSymbol()) |
| 1008 | checkUseAfterFree(Sym, C, *I); |
| 1009 | |
Anton Yartsev | 13df036 | 2013-03-25 01:35:45 +0000 | [diff] [blame] | 1010 | if (!isStandardNewDelete(NE->getOperatorNew(), C.getASTContext())) |
| 1011 | return; |
| 1012 | |
Anton Yartsev | 4e4cb6b | 2014-08-05 18:26:05 +0000 | [diff] [blame] | 1013 | ParentMap &PM = C.getLocationContext()->getParentMap(); |
| 1014 | if (!PM.isConsumedExpr(NE) && treatUnusedNewEscaped(NE)) |
| 1015 | return; |
| 1016 | |
Anton Yartsev | 13df036 | 2013-03-25 01:35:45 +0000 | [diff] [blame] | 1017 | ProgramStateRef State = C.getState(); |
Ted Kremenek | 3a0678e | 2015-09-08 03:50:52 +0000 | [diff] [blame] | 1018 | // The return value from operator new is bound to a specified initialization |
| 1019 | // value (if any) and we don't want to loose this value. So we call |
| 1020 | // MallocUpdateRefState() instead of MallocMemAux() which breakes the |
Anton Yartsev | 13df036 | 2013-03-25 01:35:45 +0000 | [diff] [blame] | 1021 | // existing binding. |
Ted Kremenek | 3a0678e | 2015-09-08 03:50:52 +0000 | [diff] [blame] | 1022 | State = MallocUpdateRefState(C, NE, State, NE->isArray() ? AF_CXXNewArray |
Anton Yartsev | 0578959 | 2013-03-28 17:05:19 +0000 | [diff] [blame] | 1023 | : AF_CXXNew); |
Gabor Horvath | 7304027 | 2016-09-19 20:39:52 +0000 | [diff] [blame] | 1024 | State = addExtentSize(C, NE, State); |
Anton Yartsev | b50f4ba | 2015-04-14 14:18:04 +0000 | [diff] [blame] | 1025 | State = ProcessZeroAllocation(C, NE, 0, State); |
Anton Yartsev | 13df036 | 2013-03-25 01:35:45 +0000 | [diff] [blame] | 1026 | C.addTransition(State); |
| 1027 | } |
| 1028 | |
Gabor Horvath | 7304027 | 2016-09-19 20:39:52 +0000 | [diff] [blame] | 1029 | // Sets the extent value of the MemRegion allocated by |
| 1030 | // new expression NE to its size in Bytes. |
| 1031 | // |
| 1032 | ProgramStateRef MallocChecker::addExtentSize(CheckerContext &C, |
| 1033 | const CXXNewExpr *NE, |
| 1034 | ProgramStateRef State) { |
| 1035 | if (!State) |
| 1036 | return nullptr; |
| 1037 | SValBuilder &svalBuilder = C.getSValBuilder(); |
| 1038 | SVal ElementCount; |
| 1039 | const LocationContext *LCtx = C.getLocationContext(); |
| 1040 | const SubRegion *Region; |
| 1041 | if (NE->isArray()) { |
| 1042 | const Expr *SizeExpr = NE->getArraySize(); |
| 1043 | ElementCount = State->getSVal(SizeExpr, C.getLocationContext()); |
| 1044 | // Store the extent size for the (symbolic)region |
| 1045 | // containing the elements. |
| 1046 | Region = (State->getSVal(NE, LCtx)) |
| 1047 | .getAsRegion() |
| 1048 | ->getAs<SubRegion>() |
| 1049 | ->getSuperRegion() |
| 1050 | ->getAs<SubRegion>(); |
| 1051 | } else { |
| 1052 | ElementCount = svalBuilder.makeIntVal(1, true); |
| 1053 | Region = (State->getSVal(NE, LCtx)).getAsRegion()->getAs<SubRegion>(); |
| 1054 | } |
| 1055 | assert(Region); |
| 1056 | |
| 1057 | // Set the region's extent equal to the Size in Bytes. |
| 1058 | QualType ElementType = NE->getAllocatedType(); |
| 1059 | ASTContext &AstContext = C.getASTContext(); |
| 1060 | CharUnits TypeSize = AstContext.getTypeSizeInChars(ElementType); |
| 1061 | |
Devin Coughlin | e3b75de | 2016-12-16 18:41:40 +0000 | [diff] [blame] | 1062 | if (ElementCount.getAs<NonLoc>()) { |
Gabor Horvath | 7304027 | 2016-09-19 20:39:52 +0000 | [diff] [blame] | 1063 | DefinedOrUnknownSVal Extent = Region->getExtent(svalBuilder); |
| 1064 | // size in Bytes = ElementCount*TypeSize |
| 1065 | SVal SizeInBytes = svalBuilder.evalBinOpNN( |
| 1066 | State, BO_Mul, ElementCount.castAs<NonLoc>(), |
| 1067 | svalBuilder.makeArrayIndex(TypeSize.getQuantity()), |
| 1068 | svalBuilder.getArrayIndexType()); |
| 1069 | DefinedOrUnknownSVal extentMatchesSize = svalBuilder.evalEQ( |
| 1070 | State, Extent, SizeInBytes.castAs<DefinedOrUnknownSVal>()); |
| 1071 | State = State->assume(extentMatchesSize, true); |
| 1072 | } |
| 1073 | return State; |
| 1074 | } |
| 1075 | |
Ted Kremenek | 3a0678e | 2015-09-08 03:50:52 +0000 | [diff] [blame] | 1076 | void MallocChecker::checkPreStmt(const CXXDeleteExpr *DE, |
Anton Yartsev | 13df036 | 2013-03-25 01:35:45 +0000 | [diff] [blame] | 1077 | CheckerContext &C) const { |
| 1078 | |
Alexander Kornienko | 4aca9b1 | 2014-02-11 21:49:21 +0000 | [diff] [blame] | 1079 | if (!ChecksEnabled[CK_NewDeleteChecker]) |
Anton Yartsev | 13df036 | 2013-03-25 01:35:45 +0000 | [diff] [blame] | 1080 | if (SymbolRef Sym = C.getSVal(DE->getArgument()).getAsSymbol()) |
| 1081 | checkUseAfterFree(Sym, C, DE->getArgument()); |
| 1082 | |
Anton Yartsev | 13df036 | 2013-03-25 01:35:45 +0000 | [diff] [blame] | 1083 | if (!isStandardNewDelete(DE->getOperatorDelete(), C.getASTContext())) |
| 1084 | return; |
| 1085 | |
| 1086 | ProgramStateRef State = C.getState(); |
| 1087 | bool ReleasedAllocated; |
| 1088 | State = FreeMemAux(C, DE->getArgument(), DE, State, |
| 1089 | /*Hold*/false, ReleasedAllocated); |
| 1090 | |
| 1091 | C.addTransition(State); |
| 1092 | } |
| 1093 | |
Jordan Rose | 613f3c0 | 2013-03-09 00:59:10 +0000 | [diff] [blame] | 1094 | static bool isKnownDeallocObjCMethodName(const ObjCMethodCall &Call) { |
| 1095 | // If the first selector piece is one of the names below, assume that the |
| 1096 | // object takes ownership of the memory, promising to eventually deallocate it |
| 1097 | // with free(). |
| 1098 | // Ex: [NSData dataWithBytesNoCopy:bytes length:10]; |
| 1099 | // (...unless a 'freeWhenDone' parameter is false, but that's checked later.) |
| 1100 | StringRef FirstSlot = Call.getSelector().getNameForSlot(0); |
Alexander Kornienko | 9c10490 | 2015-12-28 13:06:58 +0000 | [diff] [blame] | 1101 | return FirstSlot == "dataWithBytesNoCopy" || |
| 1102 | FirstSlot == "initWithBytesNoCopy" || |
| 1103 | FirstSlot == "initWithCharactersNoCopy"; |
Anna Zaks | 0d6989b | 2012-06-22 02:04:31 +0000 | [diff] [blame] | 1104 | } |
| 1105 | |
Jordan Rose | 613f3c0 | 2013-03-09 00:59:10 +0000 | [diff] [blame] | 1106 | static Optional<bool> getFreeWhenDoneArg(const ObjCMethodCall &Call) { |
| 1107 | Selector S = Call.getSelector(); |
| 1108 | |
| 1109 | // FIXME: We should not rely on fully-constrained symbols being folded. |
| 1110 | for (unsigned i = 1; i < S.getNumArgs(); ++i) |
| 1111 | if (S.getNameForSlot(i).equals("freeWhenDone")) |
| 1112 | return !Call.getArgSVal(i).isZeroConstant(); |
| 1113 | |
| 1114 | return None; |
| 1115 | } |
| 1116 | |
Anna Zaks | 67291b9 | 2012-11-13 03:18:01 +0000 | [diff] [blame] | 1117 | void MallocChecker::checkPostObjCMessage(const ObjCMethodCall &Call, |
| 1118 | CheckerContext &C) const { |
Anna Zaks | a7b1c47 | 2012-12-11 00:17:53 +0000 | [diff] [blame] | 1119 | if (C.wasInlined) |
| 1120 | return; |
| 1121 | |
Jordan Rose | 613f3c0 | 2013-03-09 00:59:10 +0000 | [diff] [blame] | 1122 | if (!isKnownDeallocObjCMethodName(Call)) |
| 1123 | return; |
Anna Zaks | 67291b9 | 2012-11-13 03:18:01 +0000 | [diff] [blame] | 1124 | |
Jordan Rose | 613f3c0 | 2013-03-09 00:59:10 +0000 | [diff] [blame] | 1125 | if (Optional<bool> FreeWhenDone = getFreeWhenDoneArg(Call)) |
| 1126 | if (!*FreeWhenDone) |
| 1127 | return; |
| 1128 | |
| 1129 | bool ReleasedAllocatedMemory; |
| 1130 | ProgramStateRef State = FreeMemAux(C, Call.getArgExpr(0), |
| 1131 | Call.getOriginExpr(), C.getState(), |
| 1132 | /*Hold=*/true, ReleasedAllocatedMemory, |
| 1133 | /*RetNullOnFailure=*/true); |
| 1134 | |
| 1135 | C.addTransition(State); |
Anna Zaks | 0d6989b | 2012-06-22 02:04:31 +0000 | [diff] [blame] | 1136 | } |
| 1137 | |
Richard Smith | 852e9ce | 2013-11-27 01:46:48 +0000 | [diff] [blame] | 1138 | ProgramStateRef |
| 1139 | MallocChecker::MallocMemReturnsAttr(CheckerContext &C, const CallExpr *CE, |
Ted Kremenek | 3a0678e | 2015-09-08 03:50:52 +0000 | [diff] [blame] | 1140 | const OwnershipAttr *Att, |
Anton Yartsev | b3fa86d | 2015-02-10 20:13:08 +0000 | [diff] [blame] | 1141 | ProgramStateRef State) const { |
| 1142 | if (!State) |
| 1143 | return nullptr; |
| 1144 | |
Richard Smith | 852e9ce | 2013-11-27 01:46:48 +0000 | [diff] [blame] | 1145 | if (Att->getModule() != II_malloc) |
Craig Topper | 0dbb783 | 2014-05-27 02:45:47 +0000 | [diff] [blame] | 1146 | return nullptr; |
Ted Kremenek | d21139a | 2010-07-31 01:52:11 +0000 | [diff] [blame] | 1147 | |
Alexis Hunt | dcfba7b | 2010-08-18 23:23:40 +0000 | [diff] [blame] | 1148 | OwnershipAttr::args_iterator I = Att->args_begin(), E = Att->args_end(); |
Ted Kremenek | d21139a | 2010-07-31 01:52:11 +0000 | [diff] [blame] | 1149 | if (I != E) { |
Anton Yartsev | b3fa86d | 2015-02-10 20:13:08 +0000 | [diff] [blame] | 1150 | return MallocMemAux(C, CE, CE->getArg(*I), UndefinedVal(), State); |
Ted Kremenek | d21139a | 2010-07-31 01:52:11 +0000 | [diff] [blame] | 1151 | } |
Anton Yartsev | b3fa86d | 2015-02-10 20:13:08 +0000 | [diff] [blame] | 1152 | return MallocMemAux(C, CE, UnknownVal(), UndefinedVal(), State); |
| 1153 | } |
| 1154 | |
| 1155 | ProgramStateRef MallocChecker::MallocMemAux(CheckerContext &C, |
| 1156 | const CallExpr *CE, |
| 1157 | const Expr *SizeEx, SVal Init, |
| 1158 | ProgramStateRef State, |
| 1159 | AllocationFamily Family) { |
| 1160 | if (!State) |
| 1161 | return nullptr; |
| 1162 | |
| 1163 | return MallocMemAux(C, CE, State->getSVal(SizeEx, C.getLocationContext()), |
| 1164 | Init, State, Family); |
Ted Kremenek | d21139a | 2010-07-31 01:52:11 +0000 | [diff] [blame] | 1165 | } |
| 1166 | |
Anna Zaks | c68bf4c | 2012-02-08 20:13:28 +0000 | [diff] [blame] | 1167 | ProgramStateRef MallocChecker::MallocMemAux(CheckerContext &C, |
Zhongxing Xu | c0484fa | 2009-12-12 12:29:38 +0000 | [diff] [blame] | 1168 | const CallExpr *CE, |
Zhongxing Xu | 527ff6d | 2010-06-01 03:01:33 +0000 | [diff] [blame] | 1169 | SVal Size, SVal Init, |
Anton Yartsev | 0578959 | 2013-03-28 17:05:19 +0000 | [diff] [blame] | 1170 | ProgramStateRef State, |
| 1171 | AllocationFamily Family) { |
Anton Yartsev | b3fa86d | 2015-02-10 20:13:08 +0000 | [diff] [blame] | 1172 | if (!State) |
| 1173 | return nullptr; |
Anna Zaks | 3563fde | 2012-06-07 03:57:32 +0000 | [diff] [blame] | 1174 | |
Jordan Rose | f69e65f | 2014-09-05 16:33:51 +0000 | [diff] [blame] | 1175 | // We expect the malloc functions to return a pointer. |
| 1176 | if (!Loc::isLocType(CE->getType())) |
| 1177 | return nullptr; |
| 1178 | |
Anna Zaks | 3563fde | 2012-06-07 03:57:32 +0000 | [diff] [blame] | 1179 | // Bind the return value to the symbolic value from the heap region. |
| 1180 | // TODO: We could rewrite post visit to eval call; 'malloc' does not have |
| 1181 | // side effects other than what we model here. |
Ted Kremenek | d94854a | 2012-08-22 06:26:15 +0000 | [diff] [blame] | 1182 | unsigned Count = C.blockCount(); |
Anna Zaks | 3563fde | 2012-06-07 03:57:32 +0000 | [diff] [blame] | 1183 | SValBuilder &svalBuilder = C.getSValBuilder(); |
| 1184 | const LocationContext *LCtx = C.getPredecessor()->getLocationContext(); |
David Blaikie | 2fdacbc | 2013-02-20 05:52:05 +0000 | [diff] [blame] | 1185 | DefinedSVal RetVal = svalBuilder.getConjuredHeapSymbolVal(CE, LCtx, Count) |
| 1186 | .castAs<DefinedSVal>(); |
Anton Yartsev | 0578959 | 2013-03-28 17:05:19 +0000 | [diff] [blame] | 1187 | State = State->BindExpr(CE, C.getLocationContext(), RetVal); |
Zhongxing Xu | 9cb53b8 | 2009-12-11 03:09:01 +0000 | [diff] [blame] | 1188 | |
Jordy Rose | 674bd55 | 2010-07-04 00:00:41 +0000 | [diff] [blame] | 1189 | // Fill the region with the initialization value. |
Anna Zaks | b570195 | 2017-01-13 00:50:57 +0000 | [diff] [blame] | 1190 | State = State->bindDefault(RetVal, Init, LCtx); |
Zhongxing Xu | 527ff6d | 2010-06-01 03:01:33 +0000 | [diff] [blame] | 1191 | |
Jordy Rose | 674bd55 | 2010-07-04 00:00:41 +0000 | [diff] [blame] | 1192 | // Set the region's extent equal to the Size parameter. |
Anna Zaks | 3188686 | 2012-02-10 01:11:00 +0000 | [diff] [blame] | 1193 | const SymbolicRegion *R = |
Anna Zaks | 3563fde | 2012-06-07 03:57:32 +0000 | [diff] [blame] | 1194 | dyn_cast_or_null<SymbolicRegion>(RetVal.getAsRegion()); |
Anna Zaks | 199e8e5 | 2012-02-22 03:14:20 +0000 | [diff] [blame] | 1195 | if (!R) |
Craig Topper | 0dbb783 | 2014-05-27 02:45:47 +0000 | [diff] [blame] | 1196 | return nullptr; |
David Blaikie | 05785d1 | 2013-02-20 22:23:23 +0000 | [diff] [blame] | 1197 | if (Optional<DefinedOrUnknownSVal> DefinedSize = |
David Blaikie | 2fdacbc | 2013-02-20 05:52:05 +0000 | [diff] [blame] | 1198 | Size.getAs<DefinedOrUnknownSVal>()) { |
Anna Zaks | 40a7eb3 | 2012-02-22 19:24:52 +0000 | [diff] [blame] | 1199 | SValBuilder &svalBuilder = C.getSValBuilder(); |
Anna Zaks | 199e8e5 | 2012-02-22 03:14:20 +0000 | [diff] [blame] | 1200 | DefinedOrUnknownSVal Extent = R->getExtent(svalBuilder); |
Anna Zaks | 199e8e5 | 2012-02-22 03:14:20 +0000 | [diff] [blame] | 1201 | DefinedOrUnknownSVal extentMatchesSize = |
Anton Yartsev | 0578959 | 2013-03-28 17:05:19 +0000 | [diff] [blame] | 1202 | svalBuilder.evalEQ(State, Extent, *DefinedSize); |
Anna Zaks | 3188686 | 2012-02-10 01:11:00 +0000 | [diff] [blame] | 1203 | |
Anton Yartsev | 0578959 | 2013-03-28 17:05:19 +0000 | [diff] [blame] | 1204 | State = State->assume(extentMatchesSize, true); |
| 1205 | assert(State); |
Anna Zaks | 199e8e5 | 2012-02-22 03:14:20 +0000 | [diff] [blame] | 1206 | } |
Ted Kremenek | 3a0678e | 2015-09-08 03:50:52 +0000 | [diff] [blame] | 1207 | |
Anton Yartsev | 0578959 | 2013-03-28 17:05:19 +0000 | [diff] [blame] | 1208 | return MallocUpdateRefState(C, CE, State, Family); |
Anna Zaks | 40a7eb3 | 2012-02-22 19:24:52 +0000 | [diff] [blame] | 1209 | } |
| 1210 | |
| 1211 | ProgramStateRef MallocChecker::MallocUpdateRefState(CheckerContext &C, |
Anton Yartsev | 13df036 | 2013-03-25 01:35:45 +0000 | [diff] [blame] | 1212 | const Expr *E, |
Anton Yartsev | 0578959 | 2013-03-28 17:05:19 +0000 | [diff] [blame] | 1213 | ProgramStateRef State, |
| 1214 | AllocationFamily Family) { |
Anton Yartsev | b3fa86d | 2015-02-10 20:13:08 +0000 | [diff] [blame] | 1215 | if (!State) |
| 1216 | return nullptr; |
| 1217 | |
Anna Zaks | 40a7eb3 | 2012-02-22 19:24:52 +0000 | [diff] [blame] | 1218 | // Get the return value. |
Anton Yartsev | 0578959 | 2013-03-28 17:05:19 +0000 | [diff] [blame] | 1219 | SVal retVal = State->getSVal(E, C.getLocationContext()); |
Anna Zaks | 40a7eb3 | 2012-02-22 19:24:52 +0000 | [diff] [blame] | 1220 | |
| 1221 | // We expect the malloc functions to return a pointer. |
David Blaikie | 2fdacbc | 2013-02-20 05:52:05 +0000 | [diff] [blame] | 1222 | if (!retVal.getAs<Loc>()) |
Craig Topper | 0dbb783 | 2014-05-27 02:45:47 +0000 | [diff] [blame] | 1223 | return nullptr; |
Anna Zaks | 40a7eb3 | 2012-02-22 19:24:52 +0000 | [diff] [blame] | 1224 | |
Ted Kremenek | 90af909 | 2010-12-02 07:49:45 +0000 | [diff] [blame] | 1225 | SymbolRef Sym = retVal.getAsLocSymbol(); |
Zhongxing Xu | 88cca6b | 2009-11-12 08:38:56 +0000 | [diff] [blame] | 1226 | assert(Sym); |
Ted Kremenek | 90af909 | 2010-12-02 07:49:45 +0000 | [diff] [blame] | 1227 | |
Zhongxing Xu | 88cca6b | 2009-11-12 08:38:56 +0000 | [diff] [blame] | 1228 | // Set the symbol's state to Allocated. |
Anton Yartsev | 0578959 | 2013-03-28 17:05:19 +0000 | [diff] [blame] | 1229 | return State->set<RegionState>(Sym, RefState::getAllocated(Family, E)); |
Zhongxing Xu | 88cca6b | 2009-11-12 08:38:56 +0000 | [diff] [blame] | 1230 | } |
| 1231 | |
Anna Zaks | 40a7eb3 | 2012-02-22 19:24:52 +0000 | [diff] [blame] | 1232 | ProgramStateRef MallocChecker::FreeMemAttr(CheckerContext &C, |
| 1233 | const CallExpr *CE, |
Ted Kremenek | 3a0678e | 2015-09-08 03:50:52 +0000 | [diff] [blame] | 1234 | const OwnershipAttr *Att, |
Anton Yartsev | b3fa86d | 2015-02-10 20:13:08 +0000 | [diff] [blame] | 1235 | ProgramStateRef State) const { |
| 1236 | if (!State) |
| 1237 | return nullptr; |
| 1238 | |
Richard Smith | 852e9ce | 2013-11-27 01:46:48 +0000 | [diff] [blame] | 1239 | if (Att->getModule() != II_malloc) |
Craig Topper | 0dbb783 | 2014-05-27 02:45:47 +0000 | [diff] [blame] | 1240 | return nullptr; |
Ted Kremenek | d21139a | 2010-07-31 01:52:11 +0000 | [diff] [blame] | 1241 | |
Anna Zaks | fe6eb67 | 2012-08-24 02:28:20 +0000 | [diff] [blame] | 1242 | bool ReleasedAllocated = false; |
Anna Zaks | 8dc53af | 2012-03-01 22:06:06 +0000 | [diff] [blame] | 1243 | |
Aaron Ballman | a82eaa7 | 2014-05-02 13:35:42 +0000 | [diff] [blame] | 1244 | for (const auto &Arg : Att->args()) { |
| 1245 | ProgramStateRef StateI = FreeMemAux(C, CE, State, Arg, |
Anna Zaks | fe6eb67 | 2012-08-24 02:28:20 +0000 | [diff] [blame] | 1246 | Att->getOwnKind() == OwnershipAttr::Holds, |
| 1247 | ReleasedAllocated); |
Anna Zaks | 8dc53af | 2012-03-01 22:06:06 +0000 | [diff] [blame] | 1248 | if (StateI) |
| 1249 | State = StateI; |
Ted Kremenek | d21139a | 2010-07-31 01:52:11 +0000 | [diff] [blame] | 1250 | } |
Anna Zaks | 8dc53af | 2012-03-01 22:06:06 +0000 | [diff] [blame] | 1251 | return State; |
Ted Kremenek | d21139a | 2010-07-31 01:52:11 +0000 | [diff] [blame] | 1252 | } |
| 1253 | |
Ted Kremenek | 49b1e38 | 2012-01-26 21:29:00 +0000 | [diff] [blame] | 1254 | ProgramStateRef MallocChecker::FreeMemAux(CheckerContext &C, |
Anna Zaks | 3188686 | 2012-02-10 01:11:00 +0000 | [diff] [blame] | 1255 | const CallExpr *CE, |
Anton Yartsev | b3fa86d | 2015-02-10 20:13:08 +0000 | [diff] [blame] | 1256 | ProgramStateRef State, |
Anna Zaks | 3188686 | 2012-02-10 01:11:00 +0000 | [diff] [blame] | 1257 | unsigned Num, |
Anna Zaks | fe6eb67 | 2012-08-24 02:28:20 +0000 | [diff] [blame] | 1258 | bool Hold, |
Anna Zaks | 67291b9 | 2012-11-13 03:18:01 +0000 | [diff] [blame] | 1259 | bool &ReleasedAllocated, |
| 1260 | bool ReturnsNullOnFailure) const { |
Anton Yartsev | b3fa86d | 2015-02-10 20:13:08 +0000 | [diff] [blame] | 1261 | if (!State) |
| 1262 | return nullptr; |
| 1263 | |
Anna Zaks | b508d29 | 2012-04-10 23:41:11 +0000 | [diff] [blame] | 1264 | if (CE->getNumArgs() < (Num + 1)) |
Craig Topper | 0dbb783 | 2014-05-27 02:45:47 +0000 | [diff] [blame] | 1265 | return nullptr; |
Anna Zaks | b508d29 | 2012-04-10 23:41:11 +0000 | [diff] [blame] | 1266 | |
Anton Yartsev | b3fa86d | 2015-02-10 20:13:08 +0000 | [diff] [blame] | 1267 | return FreeMemAux(C, CE->getArg(Num), CE, State, Hold, |
Anna Zaks | 67291b9 | 2012-11-13 03:18:01 +0000 | [diff] [blame] | 1268 | ReleasedAllocated, ReturnsNullOnFailure); |
| 1269 | } |
| 1270 | |
Anna Zaks | a14c1d0 | 2012-11-13 19:47:40 +0000 | [diff] [blame] | 1271 | /// Checks if the previous call to free on the given symbol failed - if free |
| 1272 | /// failed, returns true. Also, returns the corresponding return value symbol. |
Benjamin Kramer | ba4c85e | 2012-11-22 15:02:44 +0000 | [diff] [blame] | 1273 | static bool didPreviousFreeFail(ProgramStateRef State, |
| 1274 | SymbolRef Sym, SymbolRef &RetStatusSymbol) { |
Anna Zaks | a14c1d0 | 2012-11-13 19:47:40 +0000 | [diff] [blame] | 1275 | const SymbolRef *Ret = State->get<FreeReturnValue>(Sym); |
Anna Zaks | 67291b9 | 2012-11-13 03:18:01 +0000 | [diff] [blame] | 1276 | if (Ret) { |
| 1277 | assert(*Ret && "We should not store the null return symbol"); |
| 1278 | ConstraintManager &CMgr = State->getConstraintManager(); |
| 1279 | ConditionTruthVal FreeFailed = CMgr.isNull(State, *Ret); |
Anna Zaks | a14c1d0 | 2012-11-13 19:47:40 +0000 | [diff] [blame] | 1280 | RetStatusSymbol = *Ret; |
| 1281 | return FreeFailed.isConstrainedTrue(); |
Anna Zaks | 67291b9 | 2012-11-13 03:18:01 +0000 | [diff] [blame] | 1282 | } |
Anna Zaks | a14c1d0 | 2012-11-13 19:47:40 +0000 | [diff] [blame] | 1283 | return false; |
Anna Zaks | 0d6989b | 2012-06-22 02:04:31 +0000 | [diff] [blame] | 1284 | } |
| 1285 | |
Ted Kremenek | 3a0678e | 2015-09-08 03:50:52 +0000 | [diff] [blame] | 1286 | AllocationFamily MallocChecker::getAllocationFamily(CheckerContext &C, |
Anton Yartsev | e3377fb | 2013-04-04 23:46:29 +0000 | [diff] [blame] | 1287 | const Stmt *S) const { |
| 1288 | if (!S) |
Anton Yartsev | 0578959 | 2013-03-28 17:05:19 +0000 | [diff] [blame] | 1289 | return AF_None; |
| 1290 | |
Anton Yartsev | e3377fb | 2013-04-04 23:46:29 +0000 | [diff] [blame] | 1291 | if (const CallExpr *CE = dyn_cast<CallExpr>(S)) { |
Anton Yartsev | 0578959 | 2013-03-28 17:05:19 +0000 | [diff] [blame] | 1292 | const FunctionDecl *FD = C.getCalleeDecl(CE); |
Anton Yartsev | e3377fb | 2013-04-04 23:46:29 +0000 | [diff] [blame] | 1293 | |
| 1294 | if (!FD) |
| 1295 | FD = dyn_cast<FunctionDecl>(CE->getCalleeDecl()); |
| 1296 | |
Anton Yartsev | 0578959 | 2013-03-28 17:05:19 +0000 | [diff] [blame] | 1297 | ASTContext &Ctx = C.getASTContext(); |
| 1298 | |
Anna Zaks | d79b840 | 2014-10-03 21:48:59 +0000 | [diff] [blame] | 1299 | if (isCMemFunction(FD, Ctx, AF_Malloc, MemoryOperationKind::MOK_Any)) |
Anton Yartsev | 0578959 | 2013-03-28 17:05:19 +0000 | [diff] [blame] | 1300 | return AF_Malloc; |
| 1301 | |
| 1302 | if (isStandardNewDelete(FD, Ctx)) { |
| 1303 | OverloadedOperatorKind Kind = FD->getOverloadedOperator(); |
Anton Yartsev | e3377fb | 2013-04-04 23:46:29 +0000 | [diff] [blame] | 1304 | if (Kind == OO_New || Kind == OO_Delete) |
Anton Yartsev | 0578959 | 2013-03-28 17:05:19 +0000 | [diff] [blame] | 1305 | return AF_CXXNew; |
Anton Yartsev | e3377fb | 2013-04-04 23:46:29 +0000 | [diff] [blame] | 1306 | else if (Kind == OO_Array_New || Kind == OO_Array_Delete) |
Anton Yartsev | 0578959 | 2013-03-28 17:05:19 +0000 | [diff] [blame] | 1307 | return AF_CXXNewArray; |
| 1308 | } |
| 1309 | |
Anna Zaks | d79b840 | 2014-10-03 21:48:59 +0000 | [diff] [blame] | 1310 | if (isCMemFunction(FD, Ctx, AF_IfNameIndex, MemoryOperationKind::MOK_Any)) |
| 1311 | return AF_IfNameIndex; |
| 1312 | |
Anton Yartsev | 5b5c7ce | 2015-02-19 13:36:20 +0000 | [diff] [blame] | 1313 | if (isCMemFunction(FD, Ctx, AF_Alloca, MemoryOperationKind::MOK_Any)) |
| 1314 | return AF_Alloca; |
| 1315 | |
Anton Yartsev | 0578959 | 2013-03-28 17:05:19 +0000 | [diff] [blame] | 1316 | return AF_None; |
| 1317 | } |
| 1318 | |
Anton Yartsev | e3377fb | 2013-04-04 23:46:29 +0000 | [diff] [blame] | 1319 | if (const CXXNewExpr *NE = dyn_cast<CXXNewExpr>(S)) |
| 1320 | return NE->isArray() ? AF_CXXNewArray : AF_CXXNew; |
| 1321 | |
| 1322 | if (const CXXDeleteExpr *DE = dyn_cast<CXXDeleteExpr>(S)) |
Anton Yartsev | 0578959 | 2013-03-28 17:05:19 +0000 | [diff] [blame] | 1323 | return DE->isArrayForm() ? AF_CXXNewArray : AF_CXXNew; |
| 1324 | |
Anton Yartsev | e3377fb | 2013-04-04 23:46:29 +0000 | [diff] [blame] | 1325 | if (isa<ObjCMessageExpr>(S)) |
Anton Yartsev | 0578959 | 2013-03-28 17:05:19 +0000 | [diff] [blame] | 1326 | return AF_Malloc; |
| 1327 | |
| 1328 | return AF_None; |
| 1329 | } |
| 1330 | |
Ted Kremenek | 3a0678e | 2015-09-08 03:50:52 +0000 | [diff] [blame] | 1331 | bool MallocChecker::printAllocDeallocName(raw_ostream &os, CheckerContext &C, |
Anton Yartsev | 0578959 | 2013-03-28 17:05:19 +0000 | [diff] [blame] | 1332 | const Expr *E) const { |
| 1333 | if (const CallExpr *CE = dyn_cast<CallExpr>(E)) { |
| 1334 | // FIXME: This doesn't handle indirect calls. |
| 1335 | const FunctionDecl *FD = CE->getDirectCallee(); |
| 1336 | if (!FD) |
| 1337 | return false; |
Ted Kremenek | 3a0678e | 2015-09-08 03:50:52 +0000 | [diff] [blame] | 1338 | |
Anton Yartsev | 0578959 | 2013-03-28 17:05:19 +0000 | [diff] [blame] | 1339 | os << *FD; |
| 1340 | if (!FD->isOverloadedOperator()) |
| 1341 | os << "()"; |
| 1342 | return true; |
| 1343 | } |
| 1344 | |
| 1345 | if (const ObjCMessageExpr *Msg = dyn_cast<ObjCMessageExpr>(E)) { |
| 1346 | if (Msg->isInstanceMessage()) |
| 1347 | os << "-"; |
| 1348 | else |
| 1349 | os << "+"; |
Aaron Ballman | b190f97 | 2014-01-03 17:59:55 +0000 | [diff] [blame] | 1350 | Msg->getSelector().print(os); |
Anton Yartsev | 0578959 | 2013-03-28 17:05:19 +0000 | [diff] [blame] | 1351 | return true; |
| 1352 | } |
| 1353 | |
| 1354 | if (const CXXNewExpr *NE = dyn_cast<CXXNewExpr>(E)) { |
Ted Kremenek | 3a0678e | 2015-09-08 03:50:52 +0000 | [diff] [blame] | 1355 | os << "'" |
Anton Yartsev | 0578959 | 2013-03-28 17:05:19 +0000 | [diff] [blame] | 1356 | << getOperatorSpelling(NE->getOperatorNew()->getOverloadedOperator()) |
| 1357 | << "'"; |
| 1358 | return true; |
| 1359 | } |
| 1360 | |
| 1361 | if (const CXXDeleteExpr *DE = dyn_cast<CXXDeleteExpr>(E)) { |
Ted Kremenek | 3a0678e | 2015-09-08 03:50:52 +0000 | [diff] [blame] | 1362 | os << "'" |
Anton Yartsev | 0578959 | 2013-03-28 17:05:19 +0000 | [diff] [blame] | 1363 | << getOperatorSpelling(DE->getOperatorDelete()->getOverloadedOperator()) |
| 1364 | << "'"; |
| 1365 | return true; |
| 1366 | } |
| 1367 | |
| 1368 | return false; |
| 1369 | } |
| 1370 | |
| 1371 | void MallocChecker::printExpectedAllocName(raw_ostream &os, CheckerContext &C, |
| 1372 | const Expr *E) const { |
| 1373 | AllocationFamily Family = getAllocationFamily(C, E); |
| 1374 | |
| 1375 | switch(Family) { |
| 1376 | case AF_Malloc: os << "malloc()"; return; |
| 1377 | case AF_CXXNew: os << "'new'"; return; |
| 1378 | case AF_CXXNewArray: os << "'new[]'"; return; |
Anna Zaks | d79b840 | 2014-10-03 21:48:59 +0000 | [diff] [blame] | 1379 | case AF_IfNameIndex: os << "'if_nameindex()'"; return; |
Anton Yartsev | 5b5c7ce | 2015-02-19 13:36:20 +0000 | [diff] [blame] | 1380 | case AF_Alloca: |
Anton Yartsev | 0578959 | 2013-03-28 17:05:19 +0000 | [diff] [blame] | 1381 | case AF_None: llvm_unreachable("not a deallocation expression"); |
| 1382 | } |
| 1383 | } |
| 1384 | |
Ted Kremenek | 3a0678e | 2015-09-08 03:50:52 +0000 | [diff] [blame] | 1385 | void MallocChecker::printExpectedDeallocName(raw_ostream &os, |
Anton Yartsev | 0578959 | 2013-03-28 17:05:19 +0000 | [diff] [blame] | 1386 | AllocationFamily Family) const { |
| 1387 | switch(Family) { |
| 1388 | case AF_Malloc: os << "free()"; return; |
| 1389 | case AF_CXXNew: os << "'delete'"; return; |
| 1390 | case AF_CXXNewArray: os << "'delete[]'"; return; |
Anna Zaks | d79b840 | 2014-10-03 21:48:59 +0000 | [diff] [blame] | 1391 | case AF_IfNameIndex: os << "'if_freenameindex()'"; return; |
Anton Yartsev | 5b5c7ce | 2015-02-19 13:36:20 +0000 | [diff] [blame] | 1392 | case AF_Alloca: |
| 1393 | case AF_None: llvm_unreachable("suspicious argument"); |
Anton Yartsev | 0578959 | 2013-03-28 17:05:19 +0000 | [diff] [blame] | 1394 | } |
| 1395 | } |
| 1396 | |
Anna Zaks | 0d6989b | 2012-06-22 02:04:31 +0000 | [diff] [blame] | 1397 | ProgramStateRef MallocChecker::FreeMemAux(CheckerContext &C, |
| 1398 | const Expr *ArgExpr, |
| 1399 | const Expr *ParentExpr, |
Anna Zaks | 67291b9 | 2012-11-13 03:18:01 +0000 | [diff] [blame] | 1400 | ProgramStateRef State, |
Anna Zaks | fe6eb67 | 2012-08-24 02:28:20 +0000 | [diff] [blame] | 1401 | bool Hold, |
Anna Zaks | 67291b9 | 2012-11-13 03:18:01 +0000 | [diff] [blame] | 1402 | bool &ReleasedAllocated, |
| 1403 | bool ReturnsNullOnFailure) const { |
Anna Zaks | 0d6989b | 2012-06-22 02:04:31 +0000 | [diff] [blame] | 1404 | |
Anton Yartsev | b3fa86d | 2015-02-10 20:13:08 +0000 | [diff] [blame] | 1405 | if (!State) |
| 1406 | return nullptr; |
| 1407 | |
Anna Zaks | 67291b9 | 2012-11-13 03:18:01 +0000 | [diff] [blame] | 1408 | SVal ArgVal = State->getSVal(ArgExpr, C.getLocationContext()); |
David Blaikie | 2fdacbc | 2013-02-20 05:52:05 +0000 | [diff] [blame] | 1409 | if (!ArgVal.getAs<DefinedOrUnknownSVal>()) |
Craig Topper | 0dbb783 | 2014-05-27 02:45:47 +0000 | [diff] [blame] | 1410 | return nullptr; |
David Blaikie | 2fdacbc | 2013-02-20 05:52:05 +0000 | [diff] [blame] | 1411 | DefinedOrUnknownSVal location = ArgVal.castAs<DefinedOrUnknownSVal>(); |
Ted Kremenek | d21139a | 2010-07-31 01:52:11 +0000 | [diff] [blame] | 1412 | |
| 1413 | // Check for null dereferences. |
David Blaikie | 2fdacbc | 2013-02-20 05:52:05 +0000 | [diff] [blame] | 1414 | if (!location.getAs<Loc>()) |
Craig Topper | 0dbb783 | 2014-05-27 02:45:47 +0000 | [diff] [blame] | 1415 | return nullptr; |
Ted Kremenek | d21139a | 2010-07-31 01:52:11 +0000 | [diff] [blame] | 1416 | |
Anna Zaks | ad01ef5 | 2012-02-14 00:26:13 +0000 | [diff] [blame] | 1417 | // The explicit NULL case, no operation is performed. |
Ted Kremenek | 49b1e38 | 2012-01-26 21:29:00 +0000 | [diff] [blame] | 1418 | ProgramStateRef notNullState, nullState; |
Benjamin Kramer | 867ea1d | 2014-03-02 13:01:17 +0000 | [diff] [blame] | 1419 | std::tie(notNullState, nullState) = State->assume(location); |
Ted Kremenek | d21139a | 2010-07-31 01:52:11 +0000 | [diff] [blame] | 1420 | if (nullState && !notNullState) |
Craig Topper | 0dbb783 | 2014-05-27 02:45:47 +0000 | [diff] [blame] | 1421 | return nullptr; |
Ted Kremenek | d21139a | 2010-07-31 01:52:11 +0000 | [diff] [blame] | 1422 | |
Jordy Rose | 3597b21 | 2010-06-07 19:32:37 +0000 | [diff] [blame] | 1423 | // Unknown values could easily be okay |
| 1424 | // Undefined values are handled elsewhere |
| 1425 | if (ArgVal.isUnknownOrUndef()) |
Craig Topper | 0dbb783 | 2014-05-27 02:45:47 +0000 | [diff] [blame] | 1426 | return nullptr; |
Zhongxing Xu | 88cca6b | 2009-11-12 08:38:56 +0000 | [diff] [blame] | 1427 | |
Jordy Rose | 3597b21 | 2010-06-07 19:32:37 +0000 | [diff] [blame] | 1428 | const MemRegion *R = ArgVal.getAsRegion(); |
Ted Kremenek | 3a0678e | 2015-09-08 03:50:52 +0000 | [diff] [blame] | 1429 | |
Jordy Rose | 3597b21 | 2010-06-07 19:32:37 +0000 | [diff] [blame] | 1430 | // Nonlocs can't be freed, of course. |
| 1431 | // Non-region locations (labels and fixed addresses) also shouldn't be freed. |
| 1432 | if (!R) { |
Anton Yartsev | 0578959 | 2013-03-28 17:05:19 +0000 | [diff] [blame] | 1433 | ReportBadFree(C, ArgVal, ArgExpr->getSourceRange(), ParentExpr); |
Craig Topper | 0dbb783 | 2014-05-27 02:45:47 +0000 | [diff] [blame] | 1434 | return nullptr; |
Jordy Rose | 3597b21 | 2010-06-07 19:32:37 +0000 | [diff] [blame] | 1435 | } |
Ted Kremenek | 3a0678e | 2015-09-08 03:50:52 +0000 | [diff] [blame] | 1436 | |
Jordy Rose | 3597b21 | 2010-06-07 19:32:37 +0000 | [diff] [blame] | 1437 | R = R->StripCasts(); |
Ted Kremenek | 3a0678e | 2015-09-08 03:50:52 +0000 | [diff] [blame] | 1438 | |
Jordy Rose | 3597b21 | 2010-06-07 19:32:37 +0000 | [diff] [blame] | 1439 | // Blocks might show up as heap data, but should not be free()d |
| 1440 | if (isa<BlockDataRegion>(R)) { |
Anton Yartsev | 0578959 | 2013-03-28 17:05:19 +0000 | [diff] [blame] | 1441 | ReportBadFree(C, ArgVal, ArgExpr->getSourceRange(), ParentExpr); |
Craig Topper | 0dbb783 | 2014-05-27 02:45:47 +0000 | [diff] [blame] | 1442 | return nullptr; |
Jordy Rose | 3597b21 | 2010-06-07 19:32:37 +0000 | [diff] [blame] | 1443 | } |
Ted Kremenek | 3a0678e | 2015-09-08 03:50:52 +0000 | [diff] [blame] | 1444 | |
Jordy Rose | 3597b21 | 2010-06-07 19:32:37 +0000 | [diff] [blame] | 1445 | const MemSpaceRegion *MS = R->getMemorySpace(); |
Ted Kremenek | 3a0678e | 2015-09-08 03:50:52 +0000 | [diff] [blame] | 1446 | |
| 1447 | // Parameters, locals, statics, globals, and memory returned by |
Anton Yartsev | c38d795 | 2015-03-03 22:58:46 +0000 | [diff] [blame] | 1448 | // __builtin_alloca() shouldn't be freed. |
Jordy Rose | 3597b21 | 2010-06-07 19:32:37 +0000 | [diff] [blame] | 1449 | if (!(isa<UnknownSpaceRegion>(MS) || isa<HeapSpaceRegion>(MS))) { |
| 1450 | // FIXME: at the time this code was written, malloc() regions were |
| 1451 | // represented by conjured symbols, which are all in UnknownSpaceRegion. |
| 1452 | // This means that there isn't actually anything from HeapSpaceRegion |
| 1453 | // that should be freed, even though we allow it here. |
| 1454 | // Of course, free() can work on memory allocated outside the current |
| 1455 | // function, so UnknownSpaceRegion is always a possibility. |
| 1456 | // False negatives are better than false positives. |
Anton Yartsev | c38d795 | 2015-03-03 22:58:46 +0000 | [diff] [blame] | 1457 | |
| 1458 | if (isa<AllocaRegion>(R)) |
| 1459 | ReportFreeAlloca(C, ArgVal, ArgExpr->getSourceRange()); |
| 1460 | else |
| 1461 | ReportBadFree(C, ArgVal, ArgExpr->getSourceRange(), ParentExpr); |
| 1462 | |
Craig Topper | 0dbb783 | 2014-05-27 02:45:47 +0000 | [diff] [blame] | 1463 | return nullptr; |
Jordy Rose | 3597b21 | 2010-06-07 19:32:37 +0000 | [diff] [blame] | 1464 | } |
Anna Zaks | c89ad07 | 2013-02-07 23:05:47 +0000 | [diff] [blame] | 1465 | |
| 1466 | const SymbolicRegion *SrBase = dyn_cast<SymbolicRegion>(R->getBaseRegion()); |
Jordy Rose | 3597b21 | 2010-06-07 19:32:37 +0000 | [diff] [blame] | 1467 | // Various cases could lead to non-symbol values here. |
| 1468 | // For now, ignore them. |
Anna Zaks | c89ad07 | 2013-02-07 23:05:47 +0000 | [diff] [blame] | 1469 | if (!SrBase) |
Craig Topper | 0dbb783 | 2014-05-27 02:45:47 +0000 | [diff] [blame] | 1470 | return nullptr; |
Jordy Rose | 3597b21 | 2010-06-07 19:32:37 +0000 | [diff] [blame] | 1471 | |
Anna Zaks | c89ad07 | 2013-02-07 23:05:47 +0000 | [diff] [blame] | 1472 | SymbolRef SymBase = SrBase->getSymbol(); |
| 1473 | const RefState *RsBase = State->get<RegionState>(SymBase); |
Craig Topper | 0dbb783 | 2014-05-27 02:45:47 +0000 | [diff] [blame] | 1474 | SymbolRef PreviousRetStatusSymbol = nullptr; |
Zhongxing Xu | e2bdb9a | 2010-01-18 03:27:34 +0000 | [diff] [blame] | 1475 | |
Anton Yartsev | e3377fb | 2013-04-04 23:46:29 +0000 | [diff] [blame] | 1476 | if (RsBase) { |
Zhongxing Xu | 88cca6b | 2009-11-12 08:38:56 +0000 | [diff] [blame] | 1477 | |
Anton Yartsev | 5b5c7ce | 2015-02-19 13:36:20 +0000 | [diff] [blame] | 1478 | // Memory returned by alloca() shouldn't be freed. |
| 1479 | if (RsBase->getAllocationFamily() == AF_Alloca) { |
| 1480 | ReportFreeAlloca(C, ArgVal, ArgExpr->getSourceRange()); |
| 1481 | return nullptr; |
| 1482 | } |
| 1483 | |
Anna Zaks | 93a21a8 | 2013-04-09 00:30:28 +0000 | [diff] [blame] | 1484 | // Check for double free first. |
| 1485 | if ((RsBase->isReleased() || RsBase->isRelinquished()) && |
Anton Yartsev | e3377fb | 2013-04-04 23:46:29 +0000 | [diff] [blame] | 1486 | !didPreviousFreeFail(State, SymBase, PreviousRetStatusSymbol)) { |
| 1487 | ReportDoubleFree(C, ParentExpr->getSourceRange(), RsBase->isReleased(), |
| 1488 | SymBase, PreviousRetStatusSymbol); |
Craig Topper | 0dbb783 | 2014-05-27 02:45:47 +0000 | [diff] [blame] | 1489 | return nullptr; |
Anton Yartsev | e3377fb | 2013-04-04 23:46:29 +0000 | [diff] [blame] | 1490 | |
Anna Zaks | 93a21a8 | 2013-04-09 00:30:28 +0000 | [diff] [blame] | 1491 | // If the pointer is allocated or escaped, but we are now trying to free it, |
| 1492 | // check that the call to free is proper. |
Ted Kremenek | 3a0678e | 2015-09-08 03:50:52 +0000 | [diff] [blame] | 1493 | } else if (RsBase->isAllocated() || RsBase->isAllocatedOfSizeZero() || |
Anton Yartsev | b50f4ba | 2015-04-14 14:18:04 +0000 | [diff] [blame] | 1494 | RsBase->isEscaped()) { |
Anna Zaks | 93a21a8 | 2013-04-09 00:30:28 +0000 | [diff] [blame] | 1495 | |
| 1496 | // Check if an expected deallocation function matches the real one. |
| 1497 | bool DeallocMatchesAlloc = |
| 1498 | RsBase->getAllocationFamily() == getAllocationFamily(C, ParentExpr); |
| 1499 | if (!DeallocMatchesAlloc) { |
| 1500 | ReportMismatchedDealloc(C, ArgExpr->getSourceRange(), |
Anton Yartsev | f5bccce | 2013-09-16 17:51:25 +0000 | [diff] [blame] | 1501 | ParentExpr, RsBase, SymBase, Hold); |
Craig Topper | 0dbb783 | 2014-05-27 02:45:47 +0000 | [diff] [blame] | 1502 | return nullptr; |
Anna Zaks | 93a21a8 | 2013-04-09 00:30:28 +0000 | [diff] [blame] | 1503 | } |
| 1504 | |
| 1505 | // Check if the memory location being freed is the actual location |
| 1506 | // allocated, or an offset. |
| 1507 | RegionOffset Offset = R->getAsOffset(); |
| 1508 | if (Offset.isValid() && |
| 1509 | !Offset.hasSymbolicOffset() && |
| 1510 | Offset.getOffset() != 0) { |
| 1511 | const Expr *AllocExpr = cast<Expr>(RsBase->getStmt()); |
Ted Kremenek | 3a0678e | 2015-09-08 03:50:52 +0000 | [diff] [blame] | 1512 | ReportOffsetFree(C, ArgVal, ArgExpr->getSourceRange(), ParentExpr, |
Anna Zaks | 93a21a8 | 2013-04-09 00:30:28 +0000 | [diff] [blame] | 1513 | AllocExpr); |
Craig Topper | 0dbb783 | 2014-05-27 02:45:47 +0000 | [diff] [blame] | 1514 | return nullptr; |
Anna Zaks | 93a21a8 | 2013-04-09 00:30:28 +0000 | [diff] [blame] | 1515 | } |
Anton Yartsev | e3377fb | 2013-04-04 23:46:29 +0000 | [diff] [blame] | 1516 | } |
Anna Zaks | c89ad07 | 2013-02-07 23:05:47 +0000 | [diff] [blame] | 1517 | } |
| 1518 | |
Ted Kremenek | 3a0678e | 2015-09-08 03:50:52 +0000 | [diff] [blame] | 1519 | ReleasedAllocated = (RsBase != nullptr) && (RsBase->isAllocated() || |
Anton Yartsev | b50f4ba | 2015-04-14 14:18:04 +0000 | [diff] [blame] | 1520 | RsBase->isAllocatedOfSizeZero()); |
Anna Zaks | fe6eb67 | 2012-08-24 02:28:20 +0000 | [diff] [blame] | 1521 | |
Anna Zaks | a14c1d0 | 2012-11-13 19:47:40 +0000 | [diff] [blame] | 1522 | // Clean out the info on previous call to free return info. |
Anna Zaks | c89ad07 | 2013-02-07 23:05:47 +0000 | [diff] [blame] | 1523 | State = State->remove<FreeReturnValue>(SymBase); |
Anna Zaks | a14c1d0 | 2012-11-13 19:47:40 +0000 | [diff] [blame] | 1524 | |
Ted Kremenek | 3a0678e | 2015-09-08 03:50:52 +0000 | [diff] [blame] | 1525 | // Keep track of the return value. If it is NULL, we will know that free |
Anna Zaks | 67291b9 | 2012-11-13 03:18:01 +0000 | [diff] [blame] | 1526 | // failed. |
| 1527 | if (ReturnsNullOnFailure) { |
| 1528 | SVal RetVal = C.getSVal(ParentExpr); |
| 1529 | SymbolRef RetStatusSymbol = RetVal.getAsSymbol(); |
| 1530 | if (RetStatusSymbol) { |
Anna Zaks | c89ad07 | 2013-02-07 23:05:47 +0000 | [diff] [blame] | 1531 | C.getSymbolManager().addSymbolDependency(SymBase, RetStatusSymbol); |
| 1532 | State = State->set<FreeReturnValue>(SymBase, RetStatusSymbol); |
Anna Zaks | 67291b9 | 2012-11-13 03:18:01 +0000 | [diff] [blame] | 1533 | } |
| 1534 | } |
| 1535 | |
Anton Yartsev | 030bcdd | 2013-04-05 19:08:04 +0000 | [diff] [blame] | 1536 | AllocationFamily Family = RsBase ? RsBase->getAllocationFamily() |
| 1537 | : getAllocationFamily(C, ParentExpr); |
Zhongxing Xu | 88cca6b | 2009-11-12 08:38:56 +0000 | [diff] [blame] | 1538 | // Normal free. |
Anton Yartsev | 0578959 | 2013-03-28 17:05:19 +0000 | [diff] [blame] | 1539 | if (Hold) |
Anna Zaks | c89ad07 | 2013-02-07 23:05:47 +0000 | [diff] [blame] | 1540 | return State->set<RegionState>(SymBase, |
Anton Yartsev | 0578959 | 2013-03-28 17:05:19 +0000 | [diff] [blame] | 1541 | RefState::getRelinquished(Family, |
| 1542 | ParentExpr)); |
| 1543 | |
| 1544 | return State->set<RegionState>(SymBase, |
| 1545 | RefState::getReleased(Family, ParentExpr)); |
Zhongxing Xu | c0484fa | 2009-12-12 12:29:38 +0000 | [diff] [blame] | 1546 | } |
| 1547 | |
Alexander Kornienko | 4aca9b1 | 2014-02-11 21:49:21 +0000 | [diff] [blame] | 1548 | Optional<MallocChecker::CheckKind> |
Anton Yartsev | 2487dd6 | 2015-03-10 22:24:21 +0000 | [diff] [blame] | 1549 | MallocChecker::getCheckIfTracked(AllocationFamily Family, |
| 1550 | bool IsALeakCheck) const { |
Anton Yartsev | 717aa0e | 2013-04-05 00:31:02 +0000 | [diff] [blame] | 1551 | switch (Family) { |
Anna Zaks | d79b840 | 2014-10-03 21:48:59 +0000 | [diff] [blame] | 1552 | case AF_Malloc: |
Anton Yartsev | 4eb394d | 2015-03-07 00:31:53 +0000 | [diff] [blame] | 1553 | case AF_Alloca: |
| 1554 | case AF_IfNameIndex: { |
| 1555 | if (ChecksEnabled[CK_MallocChecker]) |
| 1556 | return CK_MallocChecker; |
| 1557 | |
Alexander Kornienko | 4aca9b1 | 2014-02-11 21:49:21 +0000 | [diff] [blame] | 1558 | return Optional<MallocChecker::CheckKind>(); |
Anton Yartsev | 717aa0e | 2013-04-05 00:31:02 +0000 | [diff] [blame] | 1559 | } |
| 1560 | case AF_CXXNew: |
| 1561 | case AF_CXXNewArray: { |
Anton Yartsev | 2487dd6 | 2015-03-10 22:24:21 +0000 | [diff] [blame] | 1562 | if (IsALeakCheck) { |
| 1563 | if (ChecksEnabled[CK_NewDeleteLeaksChecker]) |
| 1564 | return CK_NewDeleteLeaksChecker; |
Ted Kremenek | 3a0678e | 2015-09-08 03:50:52 +0000 | [diff] [blame] | 1565 | } |
Anton Yartsev | 2487dd6 | 2015-03-10 22:24:21 +0000 | [diff] [blame] | 1566 | else { |
| 1567 | if (ChecksEnabled[CK_NewDeleteChecker]) |
| 1568 | return CK_NewDeleteChecker; |
Alexander Kornienko | 4aca9b1 | 2014-02-11 21:49:21 +0000 | [diff] [blame] | 1569 | } |
| 1570 | return Optional<MallocChecker::CheckKind>(); |
Anton Yartsev | 717aa0e | 2013-04-05 00:31:02 +0000 | [diff] [blame] | 1571 | } |
| 1572 | case AF_None: { |
Anton Yartsev | 030bcdd | 2013-04-05 19:08:04 +0000 | [diff] [blame] | 1573 | llvm_unreachable("no family"); |
Anton Yartsev | 717aa0e | 2013-04-05 00:31:02 +0000 | [diff] [blame] | 1574 | } |
Anton Yartsev | 717aa0e | 2013-04-05 00:31:02 +0000 | [diff] [blame] | 1575 | } |
Anton Yartsev | 2f91004 | 2013-04-05 02:12:04 +0000 | [diff] [blame] | 1576 | llvm_unreachable("unhandled family"); |
Anton Yartsev | e3377fb | 2013-04-04 23:46:29 +0000 | [diff] [blame] | 1577 | } |
| 1578 | |
Alexander Kornienko | 4aca9b1 | 2014-02-11 21:49:21 +0000 | [diff] [blame] | 1579 | Optional<MallocChecker::CheckKind> |
Anton Yartsev | 4eb394d | 2015-03-07 00:31:53 +0000 | [diff] [blame] | 1580 | MallocChecker::getCheckIfTracked(CheckerContext &C, |
Anton Yartsev | 2487dd6 | 2015-03-10 22:24:21 +0000 | [diff] [blame] | 1581 | const Stmt *AllocDeallocStmt, |
| 1582 | bool IsALeakCheck) const { |
| 1583 | return getCheckIfTracked(getAllocationFamily(C, AllocDeallocStmt), |
| 1584 | IsALeakCheck); |
Anton Yartsev | e5c0c14 | 2015-02-18 00:39:06 +0000 | [diff] [blame] | 1585 | } |
| 1586 | |
| 1587 | Optional<MallocChecker::CheckKind> |
Anton Yartsev | 2487dd6 | 2015-03-10 22:24:21 +0000 | [diff] [blame] | 1588 | MallocChecker::getCheckIfTracked(CheckerContext &C, SymbolRef Sym, |
| 1589 | bool IsALeakCheck) const { |
Devin Coughlin | 8177173 | 2015-09-22 22:47:14 +0000 | [diff] [blame] | 1590 | if (C.getState()->contains<ReallocSizeZeroSymbols>(Sym)) |
| 1591 | return CK_MallocChecker; |
| 1592 | |
Anton Yartsev | 030bcdd | 2013-04-05 19:08:04 +0000 | [diff] [blame] | 1593 | const RefState *RS = C.getState()->get<RegionState>(Sym); |
| 1594 | assert(RS); |
Anton Yartsev | 2487dd6 | 2015-03-10 22:24:21 +0000 | [diff] [blame] | 1595 | return getCheckIfTracked(RS->getAllocationFamily(), IsALeakCheck); |
Anton Yartsev | e3377fb | 2013-04-04 23:46:29 +0000 | [diff] [blame] | 1596 | } |
| 1597 | |
Ted Kremenek | 5ef32db | 2011-08-12 23:37:29 +0000 | [diff] [blame] | 1598 | bool MallocChecker::SummarizeValue(raw_ostream &os, SVal V) { |
David Blaikie | 05785d1 | 2013-02-20 22:23:23 +0000 | [diff] [blame] | 1599 | if (Optional<nonloc::ConcreteInt> IntVal = V.getAs<nonloc::ConcreteInt>()) |
Jordy Rose | 3597b21 | 2010-06-07 19:32:37 +0000 | [diff] [blame] | 1600 | os << "an integer (" << IntVal->getValue() << ")"; |
David Blaikie | 05785d1 | 2013-02-20 22:23:23 +0000 | [diff] [blame] | 1601 | else if (Optional<loc::ConcreteInt> ConstAddr = V.getAs<loc::ConcreteInt>()) |
Jordy Rose | 3597b21 | 2010-06-07 19:32:37 +0000 | [diff] [blame] | 1602 | os << "a constant address (" << ConstAddr->getValue() << ")"; |
David Blaikie | 05785d1 | 2013-02-20 22:23:23 +0000 | [diff] [blame] | 1603 | else if (Optional<loc::GotoLabel> Label = V.getAs<loc::GotoLabel>()) |
Chris Lattner | 5a9b1ec | 2011-02-17 05:38:27 +0000 | [diff] [blame] | 1604 | os << "the address of the label '" << Label->getLabel()->getName() << "'"; |
Jordy Rose | 3597b21 | 2010-06-07 19:32:37 +0000 | [diff] [blame] | 1605 | else |
| 1606 | return false; |
Ted Kremenek | 3a0678e | 2015-09-08 03:50:52 +0000 | [diff] [blame] | 1607 | |
Jordy Rose | 3597b21 | 2010-06-07 19:32:37 +0000 | [diff] [blame] | 1608 | return true; |
| 1609 | } |
| 1610 | |
Ted Kremenek | 5ef32db | 2011-08-12 23:37:29 +0000 | [diff] [blame] | 1611 | bool MallocChecker::SummarizeRegion(raw_ostream &os, |
Jordy Rose | 3597b21 | 2010-06-07 19:32:37 +0000 | [diff] [blame] | 1612 | const MemRegion *MR) { |
| 1613 | switch (MR->getKind()) { |
Artem Dergachev | 73f018e | 2016-01-13 13:49:29 +0000 | [diff] [blame] | 1614 | case MemRegion::FunctionCodeRegionKind: { |
| 1615 | const NamedDecl *FD = cast<FunctionCodeRegion>(MR)->getDecl(); |
Jordy Rose | 3597b21 | 2010-06-07 19:32:37 +0000 | [diff] [blame] | 1616 | if (FD) |
Benjamin Kramer | b89514a | 2011-10-14 18:45:37 +0000 | [diff] [blame] | 1617 | os << "the address of the function '" << *FD << '\''; |
Jordy Rose | 3597b21 | 2010-06-07 19:32:37 +0000 | [diff] [blame] | 1618 | else |
| 1619 | os << "the address of a function"; |
| 1620 | return true; |
| 1621 | } |
Artem Dergachev | 73f018e | 2016-01-13 13:49:29 +0000 | [diff] [blame] | 1622 | case MemRegion::BlockCodeRegionKind: |
Jordy Rose | 3597b21 | 2010-06-07 19:32:37 +0000 | [diff] [blame] | 1623 | os << "block text"; |
| 1624 | return true; |
| 1625 | case MemRegion::BlockDataRegionKind: |
| 1626 | // FIXME: where the block came from? |
| 1627 | os << "a block"; |
| 1628 | return true; |
| 1629 | default: { |
| 1630 | const MemSpaceRegion *MS = MR->getMemorySpace(); |
Ted Kremenek | 3a0678e | 2015-09-08 03:50:52 +0000 | [diff] [blame] | 1631 | |
Anna Zaks | 8158ef0 | 2012-01-04 23:54:01 +0000 | [diff] [blame] | 1632 | if (isa<StackLocalsSpaceRegion>(MS)) { |
Jordy Rose | 3597b21 | 2010-06-07 19:32:37 +0000 | [diff] [blame] | 1633 | const VarRegion *VR = dyn_cast<VarRegion>(MR); |
| 1634 | const VarDecl *VD; |
| 1635 | if (VR) |
| 1636 | VD = VR->getDecl(); |
| 1637 | else |
Craig Topper | 0dbb783 | 2014-05-27 02:45:47 +0000 | [diff] [blame] | 1638 | VD = nullptr; |
| 1639 | |
Jordy Rose | 3597b21 | 2010-06-07 19:32:37 +0000 | [diff] [blame] | 1640 | if (VD) |
| 1641 | os << "the address of the local variable '" << VD->getName() << "'"; |
| 1642 | else |
| 1643 | os << "the address of a local stack variable"; |
| 1644 | return true; |
| 1645 | } |
Anna Zaks | 8158ef0 | 2012-01-04 23:54:01 +0000 | [diff] [blame] | 1646 | |
| 1647 | if (isa<StackArgumentsSpaceRegion>(MS)) { |
Jordy Rose | 3597b21 | 2010-06-07 19:32:37 +0000 | [diff] [blame] | 1648 | const VarRegion *VR = dyn_cast<VarRegion>(MR); |
| 1649 | const VarDecl *VD; |
| 1650 | if (VR) |
| 1651 | VD = VR->getDecl(); |
| 1652 | else |
Craig Topper | 0dbb783 | 2014-05-27 02:45:47 +0000 | [diff] [blame] | 1653 | VD = nullptr; |
| 1654 | |
Jordy Rose | 3597b21 | 2010-06-07 19:32:37 +0000 | [diff] [blame] | 1655 | if (VD) |
| 1656 | os << "the address of the parameter '" << VD->getName() << "'"; |
| 1657 | else |
| 1658 | os << "the address of a parameter"; |
| 1659 | return true; |
| 1660 | } |
Anna Zaks | 8158ef0 | 2012-01-04 23:54:01 +0000 | [diff] [blame] | 1661 | |
| 1662 | if (isa<GlobalsSpaceRegion>(MS)) { |
Jordy Rose | 3597b21 | 2010-06-07 19:32:37 +0000 | [diff] [blame] | 1663 | const VarRegion *VR = dyn_cast<VarRegion>(MR); |
| 1664 | const VarDecl *VD; |
| 1665 | if (VR) |
| 1666 | VD = VR->getDecl(); |
| 1667 | else |
Craig Topper | 0dbb783 | 2014-05-27 02:45:47 +0000 | [diff] [blame] | 1668 | VD = nullptr; |
| 1669 | |
Jordy Rose | 3597b21 | 2010-06-07 19:32:37 +0000 | [diff] [blame] | 1670 | if (VD) { |
| 1671 | if (VD->isStaticLocal()) |
| 1672 | os << "the address of the static variable '" << VD->getName() << "'"; |
| 1673 | else |
| 1674 | os << "the address of the global variable '" << VD->getName() << "'"; |
| 1675 | } else |
| 1676 | os << "the address of a global variable"; |
| 1677 | return true; |
| 1678 | } |
Anna Zaks | 8158ef0 | 2012-01-04 23:54:01 +0000 | [diff] [blame] | 1679 | |
| 1680 | return false; |
Jordy Rose | 3597b21 | 2010-06-07 19:32:37 +0000 | [diff] [blame] | 1681 | } |
| 1682 | } |
| 1683 | } |
| 1684 | |
Ted Kremenek | 3a0678e | 2015-09-08 03:50:52 +0000 | [diff] [blame] | 1685 | void MallocChecker::ReportBadFree(CheckerContext &C, SVal ArgVal, |
| 1686 | SourceRange Range, |
Anton Yartsev | 0578959 | 2013-03-28 17:05:19 +0000 | [diff] [blame] | 1687 | const Expr *DeallocExpr) const { |
| 1688 | |
Anton Yartsev | 4eb394d | 2015-03-07 00:31:53 +0000 | [diff] [blame] | 1689 | if (!ChecksEnabled[CK_MallocChecker] && |
| 1690 | !ChecksEnabled[CK_NewDeleteChecker]) |
| 1691 | return; |
| 1692 | |
| 1693 | Optional<MallocChecker::CheckKind> CheckKind = |
| 1694 | getCheckIfTracked(C, DeallocExpr); |
Alexander Kornienko | 4aca9b1 | 2014-02-11 21:49:21 +0000 | [diff] [blame] | 1695 | if (!CheckKind.hasValue()) |
Anton Yartsev | e3377fb | 2013-04-04 23:46:29 +0000 | [diff] [blame] | 1696 | return; |
| 1697 | |
Devin Coughlin | e39bd40 | 2015-09-16 22:03:05 +0000 | [diff] [blame] | 1698 | if (ExplodedNode *N = C.generateErrorNode()) { |
Alexander Kornienko | 4aca9b1 | 2014-02-11 21:49:21 +0000 | [diff] [blame] | 1699 | if (!BT_BadFree[*CheckKind]) |
| 1700 | BT_BadFree[*CheckKind].reset( |
| 1701 | new BugType(CheckNames[*CheckKind], "Bad free", "Memory Error")); |
| 1702 | |
Dylan Noblesmith | 2c1dd27 | 2012-02-05 02:13:05 +0000 | [diff] [blame] | 1703 | SmallString<100> buf; |
Jordy Rose | 3597b21 | 2010-06-07 19:32:37 +0000 | [diff] [blame] | 1704 | llvm::raw_svector_ostream os(buf); |
Anton Yartsev | 0578959 | 2013-03-28 17:05:19 +0000 | [diff] [blame] | 1705 | |
Jordy Rose | 3597b21 | 2010-06-07 19:32:37 +0000 | [diff] [blame] | 1706 | const MemRegion *MR = ArgVal.getAsRegion(); |
Anton Yartsev | 0578959 | 2013-03-28 17:05:19 +0000 | [diff] [blame] | 1707 | while (const ElementRegion *ER = dyn_cast_or_null<ElementRegion>(MR)) |
| 1708 | MR = ER->getSuperRegion(); |
| 1709 | |
Anton Yartsev | 5b5c7ce | 2015-02-19 13:36:20 +0000 | [diff] [blame] | 1710 | os << "Argument to "; |
| 1711 | if (!printAllocDeallocName(os, C, DeallocExpr)) |
| 1712 | os << "deallocator"; |
Anton Yartsev | 0578959 | 2013-03-28 17:05:19 +0000 | [diff] [blame] | 1713 | |
Anton Yartsev | 5b5c7ce | 2015-02-19 13:36:20 +0000 | [diff] [blame] | 1714 | os << " is "; |
Ted Kremenek | 3a0678e | 2015-09-08 03:50:52 +0000 | [diff] [blame] | 1715 | bool Summarized = MR ? SummarizeRegion(os, MR) |
Anton Yartsev | 5b5c7ce | 2015-02-19 13:36:20 +0000 | [diff] [blame] | 1716 | : SummarizeValue(os, ArgVal); |
| 1717 | if (Summarized) |
| 1718 | os << ", which is not memory allocated by "; |
| 1719 | else |
| 1720 | os << "not memory allocated by "; |
Anton Yartsev | 0578959 | 2013-03-28 17:05:19 +0000 | [diff] [blame] | 1721 | |
Anton Yartsev | 5b5c7ce | 2015-02-19 13:36:20 +0000 | [diff] [blame] | 1722 | printExpectedAllocName(os, C, DeallocExpr); |
Anton Yartsev | 0578959 | 2013-03-28 17:05:19 +0000 | [diff] [blame] | 1723 | |
Aaron Ballman | 8d3a7a5 | 2015-06-23 13:15:32 +0000 | [diff] [blame] | 1724 | auto R = llvm::make_unique<BugReport>(*BT_BadFree[*CheckKind], os.str(), N); |
Ted Kremenek | 1e809b4 | 2012-03-09 01:13:14 +0000 | [diff] [blame] | 1725 | R->markInteresting(MR); |
Anton Yartsev | 59ed15b | 2013-03-13 14:39:10 +0000 | [diff] [blame] | 1726 | R->addRange(Range); |
Aaron Ballman | 8d3a7a5 | 2015-06-23 13:15:32 +0000 | [diff] [blame] | 1727 | C.emitReport(std::move(R)); |
Jordy Rose | 3597b21 | 2010-06-07 19:32:37 +0000 | [diff] [blame] | 1728 | } |
| 1729 | } |
| 1730 | |
Ted Kremenek | 3a0678e | 2015-09-08 03:50:52 +0000 | [diff] [blame] | 1731 | void MallocChecker::ReportFreeAlloca(CheckerContext &C, SVal ArgVal, |
Anton Yartsev | 5b5c7ce | 2015-02-19 13:36:20 +0000 | [diff] [blame] | 1732 | SourceRange Range) const { |
| 1733 | |
Anton Yartsev | 4eb394d | 2015-03-07 00:31:53 +0000 | [diff] [blame] | 1734 | Optional<MallocChecker::CheckKind> CheckKind; |
| 1735 | |
| 1736 | if (ChecksEnabled[CK_MallocChecker]) |
| 1737 | CheckKind = CK_MallocChecker; |
| 1738 | else if (ChecksEnabled[CK_MismatchedDeallocatorChecker]) |
| 1739 | CheckKind = CK_MismatchedDeallocatorChecker; |
| 1740 | else |
Anton Yartsev | 5b5c7ce | 2015-02-19 13:36:20 +0000 | [diff] [blame] | 1741 | return; |
| 1742 | |
Devin Coughlin | e39bd40 | 2015-09-16 22:03:05 +0000 | [diff] [blame] | 1743 | if (ExplodedNode *N = C.generateErrorNode()) { |
Anton Yartsev | 5b5c7ce | 2015-02-19 13:36:20 +0000 | [diff] [blame] | 1744 | if (!BT_FreeAlloca[*CheckKind]) |
| 1745 | BT_FreeAlloca[*CheckKind].reset( |
| 1746 | new BugType(CheckNames[*CheckKind], "Free alloca()", "Memory Error")); |
| 1747 | |
Aaron Ballman | 8d3a7a5 | 2015-06-23 13:15:32 +0000 | [diff] [blame] | 1748 | auto R = llvm::make_unique<BugReport>( |
| 1749 | *BT_FreeAlloca[*CheckKind], |
| 1750 | "Memory allocated by alloca() should not be deallocated", N); |
Anton Yartsev | 5b5c7ce | 2015-02-19 13:36:20 +0000 | [diff] [blame] | 1751 | R->markInteresting(ArgVal.getAsRegion()); |
| 1752 | R->addRange(Range); |
Aaron Ballman | 8d3a7a5 | 2015-06-23 13:15:32 +0000 | [diff] [blame] | 1753 | C.emitReport(std::move(R)); |
Anton Yartsev | 5b5c7ce | 2015-02-19 13:36:20 +0000 | [diff] [blame] | 1754 | } |
| 1755 | } |
| 1756 | |
Ted Kremenek | 3a0678e | 2015-09-08 03:50:52 +0000 | [diff] [blame] | 1757 | void MallocChecker::ReportMismatchedDealloc(CheckerContext &C, |
Anton Yartsev | e3377fb | 2013-04-04 23:46:29 +0000 | [diff] [blame] | 1758 | SourceRange Range, |
Ted Kremenek | 3a0678e | 2015-09-08 03:50:52 +0000 | [diff] [blame] | 1759 | const Expr *DeallocExpr, |
Anton Yartsev | f0593d6 | 2013-04-05 11:25:10 +0000 | [diff] [blame] | 1760 | const RefState *RS, |
Ted Kremenek | 3a0678e | 2015-09-08 03:50:52 +0000 | [diff] [blame] | 1761 | SymbolRef Sym, |
Anton Yartsev | f5bccce | 2013-09-16 17:51:25 +0000 | [diff] [blame] | 1762 | bool OwnershipTransferred) const { |
Anton Yartsev | 0578959 | 2013-03-28 17:05:19 +0000 | [diff] [blame] | 1763 | |
Alexander Kornienko | 4aca9b1 | 2014-02-11 21:49:21 +0000 | [diff] [blame] | 1764 | if (!ChecksEnabled[CK_MismatchedDeallocatorChecker]) |
Anton Yartsev | 0578959 | 2013-03-28 17:05:19 +0000 | [diff] [blame] | 1765 | return; |
| 1766 | |
Devin Coughlin | e39bd40 | 2015-09-16 22:03:05 +0000 | [diff] [blame] | 1767 | if (ExplodedNode *N = C.generateErrorNode()) { |
Anton Yartsev | e3377fb | 2013-04-04 23:46:29 +0000 | [diff] [blame] | 1768 | if (!BT_MismatchedDealloc) |
Alexander Kornienko | 4aca9b1 | 2014-02-11 21:49:21 +0000 | [diff] [blame] | 1769 | BT_MismatchedDealloc.reset( |
| 1770 | new BugType(CheckNames[CK_MismatchedDeallocatorChecker], |
| 1771 | "Bad deallocator", "Memory Error")); |
| 1772 | |
Anton Yartsev | 0578959 | 2013-03-28 17:05:19 +0000 | [diff] [blame] | 1773 | SmallString<100> buf; |
| 1774 | llvm::raw_svector_ostream os(buf); |
| 1775 | |
| 1776 | const Expr *AllocExpr = cast<Expr>(RS->getStmt()); |
| 1777 | SmallString<20> AllocBuf; |
| 1778 | llvm::raw_svector_ostream AllocOs(AllocBuf); |
| 1779 | SmallString<20> DeallocBuf; |
| 1780 | llvm::raw_svector_ostream DeallocOs(DeallocBuf); |
| 1781 | |
Anton Yartsev | f5bccce | 2013-09-16 17:51:25 +0000 | [diff] [blame] | 1782 | if (OwnershipTransferred) { |
| 1783 | if (printAllocDeallocName(DeallocOs, C, DeallocExpr)) |
| 1784 | os << DeallocOs.str() << " cannot"; |
Ted Kremenek | 3a0678e | 2015-09-08 03:50:52 +0000 | [diff] [blame] | 1785 | else |
Anton Yartsev | f5bccce | 2013-09-16 17:51:25 +0000 | [diff] [blame] | 1786 | os << "Cannot"; |
Anton Yartsev | 0578959 | 2013-03-28 17:05:19 +0000 | [diff] [blame] | 1787 | |
Anton Yartsev | f5bccce | 2013-09-16 17:51:25 +0000 | [diff] [blame] | 1788 | os << " take ownership of memory"; |
Anton Yartsev | 0578959 | 2013-03-28 17:05:19 +0000 | [diff] [blame] | 1789 | |
Anton Yartsev | f5bccce | 2013-09-16 17:51:25 +0000 | [diff] [blame] | 1790 | if (printAllocDeallocName(AllocOs, C, AllocExpr)) |
| 1791 | os << " allocated by " << AllocOs.str(); |
| 1792 | } else { |
| 1793 | os << "Memory"; |
| 1794 | if (printAllocDeallocName(AllocOs, C, AllocExpr)) |
| 1795 | os << " allocated by " << AllocOs.str(); |
| 1796 | |
| 1797 | os << " should be deallocated by "; |
| 1798 | printExpectedDeallocName(os, RS->getAllocationFamily()); |
| 1799 | |
| 1800 | if (printAllocDeallocName(DeallocOs, C, DeallocExpr)) |
| 1801 | os << ", not " << DeallocOs.str(); |
| 1802 | } |
Anton Yartsev | 0578959 | 2013-03-28 17:05:19 +0000 | [diff] [blame] | 1803 | |
Aaron Ballman | 8d3a7a5 | 2015-06-23 13:15:32 +0000 | [diff] [blame] | 1804 | auto R = llvm::make_unique<BugReport>(*BT_MismatchedDealloc, os.str(), N); |
Anton Yartsev | f0593d6 | 2013-04-05 11:25:10 +0000 | [diff] [blame] | 1805 | R->markInteresting(Sym); |
Anton Yartsev | 0578959 | 2013-03-28 17:05:19 +0000 | [diff] [blame] | 1806 | R->addRange(Range); |
David Blaikie | 91e7902 | 2014-09-04 23:54:33 +0000 | [diff] [blame] | 1807 | R->addVisitor(llvm::make_unique<MallocBugVisitor>(Sym)); |
Aaron Ballman | 8d3a7a5 | 2015-06-23 13:15:32 +0000 | [diff] [blame] | 1808 | C.emitReport(std::move(R)); |
Anton Yartsev | 0578959 | 2013-03-28 17:05:19 +0000 | [diff] [blame] | 1809 | } |
| 1810 | } |
| 1811 | |
Anna Zaks | c89ad07 | 2013-02-07 23:05:47 +0000 | [diff] [blame] | 1812 | void MallocChecker::ReportOffsetFree(CheckerContext &C, SVal ArgVal, |
Anton Yartsev | 0578959 | 2013-03-28 17:05:19 +0000 | [diff] [blame] | 1813 | SourceRange Range, const Expr *DeallocExpr, |
| 1814 | const Expr *AllocExpr) const { |
| 1815 | |
Anton Yartsev | 0578959 | 2013-03-28 17:05:19 +0000 | [diff] [blame] | 1816 | |
Anton Yartsev | 4eb394d | 2015-03-07 00:31:53 +0000 | [diff] [blame] | 1817 | if (!ChecksEnabled[CK_MallocChecker] && |
| 1818 | !ChecksEnabled[CK_NewDeleteChecker]) |
| 1819 | return; |
| 1820 | |
| 1821 | Optional<MallocChecker::CheckKind> CheckKind = |
| 1822 | getCheckIfTracked(C, AllocExpr); |
Alexander Kornienko | 4aca9b1 | 2014-02-11 21:49:21 +0000 | [diff] [blame] | 1823 | if (!CheckKind.hasValue()) |
Anton Yartsev | e3377fb | 2013-04-04 23:46:29 +0000 | [diff] [blame] | 1824 | return; |
| 1825 | |
Devin Coughlin | e39bd40 | 2015-09-16 22:03:05 +0000 | [diff] [blame] | 1826 | ExplodedNode *N = C.generateErrorNode(); |
Craig Topper | 0dbb783 | 2014-05-27 02:45:47 +0000 | [diff] [blame] | 1827 | if (!N) |
Anna Zaks | c89ad07 | 2013-02-07 23:05:47 +0000 | [diff] [blame] | 1828 | return; |
| 1829 | |
Alexander Kornienko | 4aca9b1 | 2014-02-11 21:49:21 +0000 | [diff] [blame] | 1830 | if (!BT_OffsetFree[*CheckKind]) |
| 1831 | BT_OffsetFree[*CheckKind].reset( |
| 1832 | new BugType(CheckNames[*CheckKind], "Offset free", "Memory Error")); |
Anna Zaks | c89ad07 | 2013-02-07 23:05:47 +0000 | [diff] [blame] | 1833 | |
| 1834 | SmallString<100> buf; |
| 1835 | llvm::raw_svector_ostream os(buf); |
Anton Yartsev | 0578959 | 2013-03-28 17:05:19 +0000 | [diff] [blame] | 1836 | SmallString<20> AllocNameBuf; |
| 1837 | llvm::raw_svector_ostream AllocNameOs(AllocNameBuf); |
Anna Zaks | c89ad07 | 2013-02-07 23:05:47 +0000 | [diff] [blame] | 1838 | |
| 1839 | const MemRegion *MR = ArgVal.getAsRegion(); |
| 1840 | assert(MR && "Only MemRegion based symbols can have offset free errors"); |
| 1841 | |
| 1842 | RegionOffset Offset = MR->getAsOffset(); |
| 1843 | assert((Offset.isValid() && |
| 1844 | !Offset.hasSymbolicOffset() && |
| 1845 | Offset.getOffset() != 0) && |
| 1846 | "Only symbols with a valid offset can have offset free errors"); |
| 1847 | |
| 1848 | int offsetBytes = Offset.getOffset() / C.getASTContext().getCharWidth(); |
| 1849 | |
Anton Yartsev | 0578959 | 2013-03-28 17:05:19 +0000 | [diff] [blame] | 1850 | os << "Argument to "; |
| 1851 | if (!printAllocDeallocName(os, C, DeallocExpr)) |
| 1852 | os << "deallocator"; |
| 1853 | os << " is offset by " |
Anna Zaks | c89ad07 | 2013-02-07 23:05:47 +0000 | [diff] [blame] | 1854 | << offsetBytes |
| 1855 | << " " |
| 1856 | << ((abs(offsetBytes) > 1) ? "bytes" : "byte") |
Anton Yartsev | 0578959 | 2013-03-28 17:05:19 +0000 | [diff] [blame] | 1857 | << " from the start of "; |
| 1858 | if (AllocExpr && printAllocDeallocName(AllocNameOs, C, AllocExpr)) |
| 1859 | os << "memory allocated by " << AllocNameOs.str(); |
| 1860 | else |
| 1861 | os << "allocated memory"; |
Anna Zaks | c89ad07 | 2013-02-07 23:05:47 +0000 | [diff] [blame] | 1862 | |
Aaron Ballman | 8d3a7a5 | 2015-06-23 13:15:32 +0000 | [diff] [blame] | 1863 | auto R = llvm::make_unique<BugReport>(*BT_OffsetFree[*CheckKind], os.str(), N); |
Anna Zaks | c89ad07 | 2013-02-07 23:05:47 +0000 | [diff] [blame] | 1864 | R->markInteresting(MR->getBaseRegion()); |
| 1865 | R->addRange(Range); |
Aaron Ballman | 8d3a7a5 | 2015-06-23 13:15:32 +0000 | [diff] [blame] | 1866 | C.emitReport(std::move(R)); |
Anna Zaks | c89ad07 | 2013-02-07 23:05:47 +0000 | [diff] [blame] | 1867 | } |
| 1868 | |
Anton Yartsev | 59ed15b | 2013-03-13 14:39:10 +0000 | [diff] [blame] | 1869 | void MallocChecker::ReportUseAfterFree(CheckerContext &C, SourceRange Range, |
| 1870 | SymbolRef Sym) const { |
| 1871 | |
Anton Yartsev | 4eb394d | 2015-03-07 00:31:53 +0000 | [diff] [blame] | 1872 | if (!ChecksEnabled[CK_MallocChecker] && |
| 1873 | !ChecksEnabled[CK_NewDeleteChecker]) |
| 1874 | return; |
| 1875 | |
| 1876 | Optional<MallocChecker::CheckKind> CheckKind = getCheckIfTracked(C, Sym); |
Alexander Kornienko | 4aca9b1 | 2014-02-11 21:49:21 +0000 | [diff] [blame] | 1877 | if (!CheckKind.hasValue()) |
Anton Yartsev | e3377fb | 2013-04-04 23:46:29 +0000 | [diff] [blame] | 1878 | return; |
| 1879 | |
Devin Coughlin | e39bd40 | 2015-09-16 22:03:05 +0000 | [diff] [blame] | 1880 | if (ExplodedNode *N = C.generateErrorNode()) { |
Alexander Kornienko | 4aca9b1 | 2014-02-11 21:49:21 +0000 | [diff] [blame] | 1881 | if (!BT_UseFree[*CheckKind]) |
| 1882 | BT_UseFree[*CheckKind].reset(new BugType( |
| 1883 | CheckNames[*CheckKind], "Use-after-free", "Memory Error")); |
Anton Yartsev | 59ed15b | 2013-03-13 14:39:10 +0000 | [diff] [blame] | 1884 | |
Aaron Ballman | 8d3a7a5 | 2015-06-23 13:15:32 +0000 | [diff] [blame] | 1885 | auto R = llvm::make_unique<BugReport>(*BT_UseFree[*CheckKind], |
| 1886 | "Use of memory after it is freed", N); |
Anton Yartsev | 59ed15b | 2013-03-13 14:39:10 +0000 | [diff] [blame] | 1887 | |
| 1888 | R->markInteresting(Sym); |
| 1889 | R->addRange(Range); |
David Blaikie | 91e7902 | 2014-09-04 23:54:33 +0000 | [diff] [blame] | 1890 | R->addVisitor(llvm::make_unique<MallocBugVisitor>(Sym)); |
Aaron Ballman | 8d3a7a5 | 2015-06-23 13:15:32 +0000 | [diff] [blame] | 1891 | C.emitReport(std::move(R)); |
Anton Yartsev | 59ed15b | 2013-03-13 14:39:10 +0000 | [diff] [blame] | 1892 | } |
| 1893 | } |
| 1894 | |
| 1895 | void MallocChecker::ReportDoubleFree(CheckerContext &C, SourceRange Range, |
Ted Kremenek | 3a0678e | 2015-09-08 03:50:52 +0000 | [diff] [blame] | 1896 | bool Released, SymbolRef Sym, |
Anton Yartsev | 6c2af43 | 2013-03-13 17:07:32 +0000 | [diff] [blame] | 1897 | SymbolRef PrevSym) const { |
Anton Yartsev | 59ed15b | 2013-03-13 14:39:10 +0000 | [diff] [blame] | 1898 | |
Anton Yartsev | 4eb394d | 2015-03-07 00:31:53 +0000 | [diff] [blame] | 1899 | if (!ChecksEnabled[CK_MallocChecker] && |
| 1900 | !ChecksEnabled[CK_NewDeleteChecker]) |
| 1901 | return; |
| 1902 | |
| 1903 | Optional<MallocChecker::CheckKind> CheckKind = getCheckIfTracked(C, Sym); |
Alexander Kornienko | 4aca9b1 | 2014-02-11 21:49:21 +0000 | [diff] [blame] | 1904 | if (!CheckKind.hasValue()) |
Anton Yartsev | e3377fb | 2013-04-04 23:46:29 +0000 | [diff] [blame] | 1905 | return; |
| 1906 | |
Devin Coughlin | e39bd40 | 2015-09-16 22:03:05 +0000 | [diff] [blame] | 1907 | if (ExplodedNode *N = C.generateErrorNode()) { |
Alexander Kornienko | 4aca9b1 | 2014-02-11 21:49:21 +0000 | [diff] [blame] | 1908 | if (!BT_DoubleFree[*CheckKind]) |
| 1909 | BT_DoubleFree[*CheckKind].reset( |
| 1910 | new BugType(CheckNames[*CheckKind], "Double free", "Memory Error")); |
Anton Yartsev | 59ed15b | 2013-03-13 14:39:10 +0000 | [diff] [blame] | 1911 | |
Aaron Ballman | 8d3a7a5 | 2015-06-23 13:15:32 +0000 | [diff] [blame] | 1912 | auto R = llvm::make_unique<BugReport>( |
| 1913 | *BT_DoubleFree[*CheckKind], |
| 1914 | (Released ? "Attempt to free released memory" |
| 1915 | : "Attempt to free non-owned memory"), |
| 1916 | N); |
Anton Yartsev | 59ed15b | 2013-03-13 14:39:10 +0000 | [diff] [blame] | 1917 | R->addRange(Range); |
Anton Yartsev | 6c2af43 | 2013-03-13 17:07:32 +0000 | [diff] [blame] | 1918 | R->markInteresting(Sym); |
| 1919 | if (PrevSym) |
| 1920 | R->markInteresting(PrevSym); |
David Blaikie | 91e7902 | 2014-09-04 23:54:33 +0000 | [diff] [blame] | 1921 | R->addVisitor(llvm::make_unique<MallocBugVisitor>(Sym)); |
Aaron Ballman | 8d3a7a5 | 2015-06-23 13:15:32 +0000 | [diff] [blame] | 1922 | C.emitReport(std::move(R)); |
Anton Yartsev | 59ed15b | 2013-03-13 14:39:10 +0000 | [diff] [blame] | 1923 | } |
| 1924 | } |
| 1925 | |
Jordan Rose | 656fdd5 | 2014-01-08 18:46:55 +0000 | [diff] [blame] | 1926 | void MallocChecker::ReportDoubleDelete(CheckerContext &C, SymbolRef Sym) const { |
| 1927 | |
Anton Yartsev | 4eb394d | 2015-03-07 00:31:53 +0000 | [diff] [blame] | 1928 | if (!ChecksEnabled[CK_NewDeleteChecker]) |
| 1929 | return; |
| 1930 | |
| 1931 | Optional<MallocChecker::CheckKind> CheckKind = getCheckIfTracked(C, Sym); |
Alexander Kornienko | 4aca9b1 | 2014-02-11 21:49:21 +0000 | [diff] [blame] | 1932 | if (!CheckKind.hasValue()) |
Jordan Rose | 656fdd5 | 2014-01-08 18:46:55 +0000 | [diff] [blame] | 1933 | return; |
| 1934 | |
Devin Coughlin | e39bd40 | 2015-09-16 22:03:05 +0000 | [diff] [blame] | 1935 | if (ExplodedNode *N = C.generateErrorNode()) { |
Jordan Rose | 656fdd5 | 2014-01-08 18:46:55 +0000 | [diff] [blame] | 1936 | if (!BT_DoubleDelete) |
Alexander Kornienko | 4aca9b1 | 2014-02-11 21:49:21 +0000 | [diff] [blame] | 1937 | BT_DoubleDelete.reset(new BugType(CheckNames[CK_NewDeleteChecker], |
| 1938 | "Double delete", "Memory Error")); |
Jordan Rose | 656fdd5 | 2014-01-08 18:46:55 +0000 | [diff] [blame] | 1939 | |
Aaron Ballman | 8d3a7a5 | 2015-06-23 13:15:32 +0000 | [diff] [blame] | 1940 | auto R = llvm::make_unique<BugReport>( |
| 1941 | *BT_DoubleDelete, "Attempt to delete released memory", N); |
Jordan Rose | 656fdd5 | 2014-01-08 18:46:55 +0000 | [diff] [blame] | 1942 | |
| 1943 | R->markInteresting(Sym); |
David Blaikie | 91e7902 | 2014-09-04 23:54:33 +0000 | [diff] [blame] | 1944 | R->addVisitor(llvm::make_unique<MallocBugVisitor>(Sym)); |
Aaron Ballman | 8d3a7a5 | 2015-06-23 13:15:32 +0000 | [diff] [blame] | 1945 | C.emitReport(std::move(R)); |
Jordan Rose | 656fdd5 | 2014-01-08 18:46:55 +0000 | [diff] [blame] | 1946 | } |
| 1947 | } |
| 1948 | |
Anton Yartsev | b50f4ba | 2015-04-14 14:18:04 +0000 | [diff] [blame] | 1949 | void MallocChecker::ReportUseZeroAllocated(CheckerContext &C, |
| 1950 | SourceRange Range, |
| 1951 | SymbolRef Sym) const { |
| 1952 | |
| 1953 | if (!ChecksEnabled[CK_MallocChecker] && |
| 1954 | !ChecksEnabled[CK_NewDeleteChecker]) |
| 1955 | return; |
| 1956 | |
| 1957 | Optional<MallocChecker::CheckKind> CheckKind = getCheckIfTracked(C, Sym); |
| 1958 | |
| 1959 | if (!CheckKind.hasValue()) |
| 1960 | return; |
| 1961 | |
Devin Coughlin | e39bd40 | 2015-09-16 22:03:05 +0000 | [diff] [blame] | 1962 | if (ExplodedNode *N = C.generateErrorNode()) { |
Anton Yartsev | b50f4ba | 2015-04-14 14:18:04 +0000 | [diff] [blame] | 1963 | if (!BT_UseZerroAllocated[*CheckKind]) |
| 1964 | BT_UseZerroAllocated[*CheckKind].reset(new BugType( |
| 1965 | CheckNames[*CheckKind], "Use of zero allocated", "Memory Error")); |
| 1966 | |
Aaron Ballman | 8d3a7a5 | 2015-06-23 13:15:32 +0000 | [diff] [blame] | 1967 | auto R = llvm::make_unique<BugReport>(*BT_UseZerroAllocated[*CheckKind], |
| 1968 | "Use of zero-allocated memory", N); |
Anton Yartsev | b50f4ba | 2015-04-14 14:18:04 +0000 | [diff] [blame] | 1969 | |
| 1970 | R->addRange(Range); |
| 1971 | if (Sym) { |
| 1972 | R->markInteresting(Sym); |
| 1973 | R->addVisitor(llvm::make_unique<MallocBugVisitor>(Sym)); |
| 1974 | } |
Aaron Ballman | 8d3a7a5 | 2015-06-23 13:15:32 +0000 | [diff] [blame] | 1975 | C.emitReport(std::move(R)); |
Anton Yartsev | b50f4ba | 2015-04-14 14:18:04 +0000 | [diff] [blame] | 1976 | } |
| 1977 | } |
| 1978 | |
Anna Zaks | 40a7eb3 | 2012-02-22 19:24:52 +0000 | [diff] [blame] | 1979 | ProgramStateRef MallocChecker::ReallocMem(CheckerContext &C, |
| 1980 | const CallExpr *CE, |
Anton Yartsev | b3fa86d | 2015-02-10 20:13:08 +0000 | [diff] [blame] | 1981 | bool FreesOnFail, |
| 1982 | ProgramStateRef State) const { |
| 1983 | if (!State) |
| 1984 | return nullptr; |
| 1985 | |
Anna Zaks | b508d29 | 2012-04-10 23:41:11 +0000 | [diff] [blame] | 1986 | if (CE->getNumArgs() < 2) |
Craig Topper | 0dbb783 | 2014-05-27 02:45:47 +0000 | [diff] [blame] | 1987 | return nullptr; |
Anna Zaks | b508d29 | 2012-04-10 23:41:11 +0000 | [diff] [blame] | 1988 | |
Ted Kremenek | 90af909 | 2010-12-02 07:49:45 +0000 | [diff] [blame] | 1989 | const Expr *arg0Expr = CE->getArg(0); |
Ted Kremenek | 632e3b7 | 2012-01-06 22:09:28 +0000 | [diff] [blame] | 1990 | const LocationContext *LCtx = C.getLocationContext(); |
Anton Yartsev | b3fa86d | 2015-02-10 20:13:08 +0000 | [diff] [blame] | 1991 | SVal Arg0Val = State->getSVal(arg0Expr, LCtx); |
David Blaikie | 2fdacbc | 2013-02-20 05:52:05 +0000 | [diff] [blame] | 1992 | if (!Arg0Val.getAs<DefinedOrUnknownSVal>()) |
Craig Topper | 0dbb783 | 2014-05-27 02:45:47 +0000 | [diff] [blame] | 1993 | return nullptr; |
David Blaikie | 2fdacbc | 2013-02-20 05:52:05 +0000 | [diff] [blame] | 1994 | DefinedOrUnknownSVal arg0Val = Arg0Val.castAs<DefinedOrUnknownSVal>(); |
Zhongxing Xu | c0484fa | 2009-12-12 12:29:38 +0000 | [diff] [blame] | 1995 | |
Ted Kremenek | 9d0bb1e | 2010-12-01 21:28:31 +0000 | [diff] [blame] | 1996 | SValBuilder &svalBuilder = C.getSValBuilder(); |
Zhongxing Xu | c0484fa | 2009-12-12 12:29:38 +0000 | [diff] [blame] | 1997 | |
Ted Kremenek | 90af909 | 2010-12-02 07:49:45 +0000 | [diff] [blame] | 1998 | DefinedOrUnknownSVal PtrEQ = |
Anton Yartsev | b3fa86d | 2015-02-10 20:13:08 +0000 | [diff] [blame] | 1999 | svalBuilder.evalEQ(State, arg0Val, svalBuilder.makeNull()); |
Zhongxing Xu | c0484fa | 2009-12-12 12:29:38 +0000 | [diff] [blame] | 2000 | |
Lenny Maiorani | 005b5c1 | 2011-04-27 14:49:29 +0000 | [diff] [blame] | 2001 | // Get the size argument. If there is no size arg then give up. |
| 2002 | const Expr *Arg1 = CE->getArg(1); |
| 2003 | if (!Arg1) |
Craig Topper | 0dbb783 | 2014-05-27 02:45:47 +0000 | [diff] [blame] | 2004 | return nullptr; |
Lenny Maiorani | 005b5c1 | 2011-04-27 14:49:29 +0000 | [diff] [blame] | 2005 | |
| 2006 | // Get the value of the size argument. |
Anton Yartsev | b3fa86d | 2015-02-10 20:13:08 +0000 | [diff] [blame] | 2007 | SVal Arg1ValG = State->getSVal(Arg1, LCtx); |
David Blaikie | 2fdacbc | 2013-02-20 05:52:05 +0000 | [diff] [blame] | 2008 | if (!Arg1ValG.getAs<DefinedOrUnknownSVal>()) |
Craig Topper | 0dbb783 | 2014-05-27 02:45:47 +0000 | [diff] [blame] | 2009 | return nullptr; |
David Blaikie | 2fdacbc | 2013-02-20 05:52:05 +0000 | [diff] [blame] | 2010 | DefinedOrUnknownSVal Arg1Val = Arg1ValG.castAs<DefinedOrUnknownSVal>(); |
Lenny Maiorani | 005b5c1 | 2011-04-27 14:49:29 +0000 | [diff] [blame] | 2011 | |
| 2012 | // Compare the size argument to 0. |
| 2013 | DefinedOrUnknownSVal SizeZero = |
Anton Yartsev | b3fa86d | 2015-02-10 20:13:08 +0000 | [diff] [blame] | 2014 | svalBuilder.evalEQ(State, Arg1Val, |
Lenny Maiorani | 005b5c1 | 2011-04-27 14:49:29 +0000 | [diff] [blame] | 2015 | svalBuilder.makeIntValWithPtrWidth(0, false)); |
| 2016 | |
Anna Zaks | d56c879 | 2012-02-13 18:05:39 +0000 | [diff] [blame] | 2017 | ProgramStateRef StatePtrIsNull, StatePtrNotNull; |
Anton Yartsev | b3fa86d | 2015-02-10 20:13:08 +0000 | [diff] [blame] | 2018 | std::tie(StatePtrIsNull, StatePtrNotNull) = State->assume(PtrEQ); |
Anna Zaks | d56c879 | 2012-02-13 18:05:39 +0000 | [diff] [blame] | 2019 | ProgramStateRef StateSizeIsZero, StateSizeNotZero; |
Anton Yartsev | b3fa86d | 2015-02-10 20:13:08 +0000 | [diff] [blame] | 2020 | std::tie(StateSizeIsZero, StateSizeNotZero) = State->assume(SizeZero); |
Anna Zaks | d56c879 | 2012-02-13 18:05:39 +0000 | [diff] [blame] | 2021 | // We only assume exceptional states if they are definitely true; if the |
| 2022 | // state is under-constrained, assume regular realloc behavior. |
| 2023 | bool PrtIsNull = StatePtrIsNull && !StatePtrNotNull; |
| 2024 | bool SizeIsZero = StateSizeIsZero && !StateSizeNotZero; |
| 2025 | |
Ted Kremenek | 3a0678e | 2015-09-08 03:50:52 +0000 | [diff] [blame] | 2026 | // If the ptr is NULL and the size is not 0, the call is equivalent to |
Lenny Maiorani | 005b5c1 | 2011-04-27 14:49:29 +0000 | [diff] [blame] | 2027 | // malloc(size). |
Anna Zaks | d56c879 | 2012-02-13 18:05:39 +0000 | [diff] [blame] | 2028 | if ( PrtIsNull && !SizeIsZero) { |
Anna Zaks | 40a7eb3 | 2012-02-22 19:24:52 +0000 | [diff] [blame] | 2029 | ProgramStateRef stateMalloc = MallocMemAux(C, CE, CE->getArg(1), |
Anna Zaks | d56c879 | 2012-02-13 18:05:39 +0000 | [diff] [blame] | 2030 | UndefinedVal(), StatePtrIsNull); |
Anna Zaks | 40a7eb3 | 2012-02-22 19:24:52 +0000 | [diff] [blame] | 2031 | return stateMalloc; |
Zhongxing Xu | c0484fa | 2009-12-12 12:29:38 +0000 | [diff] [blame] | 2032 | } |
| 2033 | |
Anna Zaks | d56c879 | 2012-02-13 18:05:39 +0000 | [diff] [blame] | 2034 | if (PrtIsNull && SizeIsZero) |
Devin Coughlin | 8177173 | 2015-09-22 22:47:14 +0000 | [diff] [blame] | 2035 | return State; |
Zhongxing Xu | c0484fa | 2009-12-12 12:29:38 +0000 | [diff] [blame] | 2036 | |
Anna Zaks | 8fd0f2a | 2012-02-13 20:57:07 +0000 | [diff] [blame] | 2037 | // Get the from and to pointer symbols as in toPtr = realloc(fromPtr, size). |
Anna Zaks | d56c879 | 2012-02-13 18:05:39 +0000 | [diff] [blame] | 2038 | assert(!PrtIsNull); |
Anna Zaks | 8fd0f2a | 2012-02-13 20:57:07 +0000 | [diff] [blame] | 2039 | SymbolRef FromPtr = arg0Val.getAsSymbol(); |
Anton Yartsev | b3fa86d | 2015-02-10 20:13:08 +0000 | [diff] [blame] | 2040 | SVal RetVal = State->getSVal(CE, LCtx); |
Anna Zaks | 8fd0f2a | 2012-02-13 20:57:07 +0000 | [diff] [blame] | 2041 | SymbolRef ToPtr = RetVal.getAsSymbol(); |
| 2042 | if (!FromPtr || !ToPtr) |
Craig Topper | 0dbb783 | 2014-05-27 02:45:47 +0000 | [diff] [blame] | 2043 | return nullptr; |
Anna Zaks | d56c879 | 2012-02-13 18:05:39 +0000 | [diff] [blame] | 2044 | |
Anna Zaks | fe6eb67 | 2012-08-24 02:28:20 +0000 | [diff] [blame] | 2045 | bool ReleasedAllocated = false; |
| 2046 | |
Anna Zaks | d56c879 | 2012-02-13 18:05:39 +0000 | [diff] [blame] | 2047 | // If the size is 0, free the memory. |
| 2048 | if (SizeIsZero) |
Anna Zaks | fe6eb67 | 2012-08-24 02:28:20 +0000 | [diff] [blame] | 2049 | if (ProgramStateRef stateFree = FreeMemAux(C, CE, StateSizeIsZero, 0, |
| 2050 | false, ReleasedAllocated)){ |
Anna Zaks | d56c879 | 2012-02-13 18:05:39 +0000 | [diff] [blame] | 2051 | // The semantics of the return value are: |
| 2052 | // If size was equal to 0, either NULL or a pointer suitable to be passed |
Anna Zaks | 52242a6 | 2012-08-03 18:30:18 +0000 | [diff] [blame] | 2053 | // to free() is returned. We just free the input pointer and do not add |
| 2054 | // any constrains on the output pointer. |
Anna Zaks | 40a7eb3 | 2012-02-22 19:24:52 +0000 | [diff] [blame] | 2055 | return stateFree; |
Anna Zaks | d56c879 | 2012-02-13 18:05:39 +0000 | [diff] [blame] | 2056 | } |
| 2057 | |
| 2058 | // Default behavior. |
Anna Zaks | fe6eb67 | 2012-08-24 02:28:20 +0000 | [diff] [blame] | 2059 | if (ProgramStateRef stateFree = |
Anton Yartsev | b3fa86d | 2015-02-10 20:13:08 +0000 | [diff] [blame] | 2060 | FreeMemAux(C, CE, State, 0, false, ReleasedAllocated)) { |
Anna Zaks | fe6eb67 | 2012-08-24 02:28:20 +0000 | [diff] [blame] | 2061 | |
Anna Zaks | d56c879 | 2012-02-13 18:05:39 +0000 | [diff] [blame] | 2062 | ProgramStateRef stateRealloc = MallocMemAux(C, CE, CE->getArg(1), |
| 2063 | UnknownVal(), stateFree); |
Anna Zaks | 8fd0f2a | 2012-02-13 20:57:07 +0000 | [diff] [blame] | 2064 | if (!stateRealloc) |
Craig Topper | 0dbb783 | 2014-05-27 02:45:47 +0000 | [diff] [blame] | 2065 | return nullptr; |
Anna Zaks | fe6eb67 | 2012-08-24 02:28:20 +0000 | [diff] [blame] | 2066 | |
Anna Zaks | 75cfbb6 | 2012-09-12 22:57:34 +0000 | [diff] [blame] | 2067 | ReallocPairKind Kind = RPToBeFreedAfterFailure; |
| 2068 | if (FreesOnFail) |
| 2069 | Kind = RPIsFreeOnFailure; |
| 2070 | else if (!ReleasedAllocated) |
| 2071 | Kind = RPDoNotTrackAfterFailure; |
| 2072 | |
Anna Zaks | fe6eb67 | 2012-08-24 02:28:20 +0000 | [diff] [blame] | 2073 | // Record the info about the reallocated symbol so that we could properly |
| 2074 | // process failed reallocation. |
Anna Zaks | ac06814 | 2012-02-15 00:11:25 +0000 | [diff] [blame] | 2075 | stateRealloc = stateRealloc->set<ReallocPairs>(ToPtr, |
Anna Zaks | 75cfbb6 | 2012-09-12 22:57:34 +0000 | [diff] [blame] | 2076 | ReallocPair(FromPtr, Kind)); |
Anna Zaks | fe6eb67 | 2012-08-24 02:28:20 +0000 | [diff] [blame] | 2077 | // The reallocated symbol should stay alive for as long as the new symbol. |
Anna Zaks | ad01ef5 | 2012-02-14 00:26:13 +0000 | [diff] [blame] | 2078 | C.getSymbolManager().addSymbolDependency(ToPtr, FromPtr); |
Anna Zaks | 40a7eb3 | 2012-02-22 19:24:52 +0000 | [diff] [blame] | 2079 | return stateRealloc; |
Zhongxing Xu | c0484fa | 2009-12-12 12:29:38 +0000 | [diff] [blame] | 2080 | } |
Craig Topper | 0dbb783 | 2014-05-27 02:45:47 +0000 | [diff] [blame] | 2081 | return nullptr; |
Zhongxing Xu | 88cca6b | 2009-11-12 08:38:56 +0000 | [diff] [blame] | 2082 | } |
Zhongxing Xu | c4902a5 | 2009-11-13 07:25:27 +0000 | [diff] [blame] | 2083 | |
Ted Kremenek | 3a0678e | 2015-09-08 03:50:52 +0000 | [diff] [blame] | 2084 | ProgramStateRef MallocChecker::CallocMem(CheckerContext &C, const CallExpr *CE, |
Anton Yartsev | b3fa86d | 2015-02-10 20:13:08 +0000 | [diff] [blame] | 2085 | ProgramStateRef State) { |
| 2086 | if (!State) |
| 2087 | return nullptr; |
| 2088 | |
Anna Zaks | b508d29 | 2012-04-10 23:41:11 +0000 | [diff] [blame] | 2089 | if (CE->getNumArgs() < 2) |
Craig Topper | 0dbb783 | 2014-05-27 02:45:47 +0000 | [diff] [blame] | 2090 | return nullptr; |
Anna Zaks | b508d29 | 2012-04-10 23:41:11 +0000 | [diff] [blame] | 2091 | |
Ted Kremenek | 9d0bb1e | 2010-12-01 21:28:31 +0000 | [diff] [blame] | 2092 | SValBuilder &svalBuilder = C.getSValBuilder(); |
Ted Kremenek | 632e3b7 | 2012-01-06 22:09:28 +0000 | [diff] [blame] | 2093 | const LocationContext *LCtx = C.getLocationContext(); |
Anton Yartsev | b3fa86d | 2015-02-10 20:13:08 +0000 | [diff] [blame] | 2094 | SVal count = State->getSVal(CE->getArg(0), LCtx); |
| 2095 | SVal elementSize = State->getSVal(CE->getArg(1), LCtx); |
| 2096 | SVal TotalSize = svalBuilder.evalBinOp(State, BO_Mul, count, elementSize, |
Ted Kremenek | 3a0678e | 2015-09-08 03:50:52 +0000 | [diff] [blame] | 2097 | svalBuilder.getContext().getSizeType()); |
Ted Kremenek | 90af909 | 2010-12-02 07:49:45 +0000 | [diff] [blame] | 2098 | SVal zeroVal = svalBuilder.makeZeroVal(svalBuilder.getContext().CharTy); |
Zhongxing Xu | 527ff6d | 2010-06-01 03:01:33 +0000 | [diff] [blame] | 2099 | |
Anton Yartsev | b3fa86d | 2015-02-10 20:13:08 +0000 | [diff] [blame] | 2100 | return MallocMemAux(C, CE, TotalSize, zeroVal, State); |
Zhongxing Xu | 527ff6d | 2010-06-01 03:01:33 +0000 | [diff] [blame] | 2101 | } |
| 2102 | |
Anna Zaks | fc2e153 | 2012-03-21 19:45:08 +0000 | [diff] [blame] | 2103 | LeakInfo |
Anna Zaks | df901a4 | 2012-02-23 21:38:21 +0000 | [diff] [blame] | 2104 | MallocChecker::getAllocationSite(const ExplodedNode *N, SymbolRef Sym, |
| 2105 | CheckerContext &C) const { |
Anna Zaks | 43ffba2 | 2012-02-27 23:40:55 +0000 | [diff] [blame] | 2106 | const LocationContext *LeakContext = N->getLocationContext(); |
Anna Zaks | df901a4 | 2012-02-23 21:38:21 +0000 | [diff] [blame] | 2107 | // Walk the ExplodedGraph backwards and find the first node that referred to |
| 2108 | // the tracked symbol. |
| 2109 | const ExplodedNode *AllocNode = N; |
Craig Topper | 0dbb783 | 2014-05-27 02:45:47 +0000 | [diff] [blame] | 2110 | const MemRegion *ReferenceRegion = nullptr; |
Anna Zaks | df901a4 | 2012-02-23 21:38:21 +0000 | [diff] [blame] | 2111 | |
| 2112 | while (N) { |
Anna Zaks | fc2e153 | 2012-03-21 19:45:08 +0000 | [diff] [blame] | 2113 | ProgramStateRef State = N->getState(); |
| 2114 | if (!State->get<RegionState>(Sym)) |
Anna Zaks | df901a4 | 2012-02-23 21:38:21 +0000 | [diff] [blame] | 2115 | break; |
Anna Zaks | fc2e153 | 2012-03-21 19:45:08 +0000 | [diff] [blame] | 2116 | |
| 2117 | // Find the most recent expression bound to the symbol in the current |
| 2118 | // context. |
Anna Zaks | 7c19abe | 2013-04-10 21:42:02 +0000 | [diff] [blame] | 2119 | if (!ReferenceRegion) { |
| 2120 | if (const MemRegion *MR = C.getLocationRegionIfPostStore(N)) { |
| 2121 | SVal Val = State->getSVal(MR); |
| 2122 | if (Val.getAsLocSymbol() == Sym) { |
Anna Zaks | 07804ef | 2013-04-10 22:56:33 +0000 | [diff] [blame] | 2123 | const VarRegion* VR = MR->getBaseRegion()->getAs<VarRegion>(); |
Anna Zaks | 7c19abe | 2013-04-10 21:42:02 +0000 | [diff] [blame] | 2124 | // Do not show local variables belonging to a function other than |
| 2125 | // where the error is reported. |
| 2126 | if (!VR || |
| 2127 | (VR->getStackFrame() == LeakContext->getCurrentStackFrame())) |
| 2128 | ReferenceRegion = MR; |
| 2129 | } |
| 2130 | } |
Benjamin Kramer | c25c5e0 | 2012-03-21 21:03:48 +0000 | [diff] [blame] | 2131 | } |
Anna Zaks | fc2e153 | 2012-03-21 19:45:08 +0000 | [diff] [blame] | 2132 | |
Anna Zaks | 486a0ff | 2015-02-05 01:02:53 +0000 | [diff] [blame] | 2133 | // Allocation node, is the last node in the current or parent context in |
| 2134 | // which the symbol was tracked. |
| 2135 | const LocationContext *NContext = N->getLocationContext(); |
| 2136 | if (NContext == LeakContext || |
| 2137 | NContext->isParentOf(LeakContext)) |
Anna Zaks | 43ffba2 | 2012-02-27 23:40:55 +0000 | [diff] [blame] | 2138 | AllocNode = N; |
Craig Topper | 0dbb783 | 2014-05-27 02:45:47 +0000 | [diff] [blame] | 2139 | N = N->pred_empty() ? nullptr : *(N->pred_begin()); |
Anna Zaks | df901a4 | 2012-02-23 21:38:21 +0000 | [diff] [blame] | 2140 | } |
| 2141 | |
Anna Zaks | a043d0c | 2013-01-08 00:25:29 +0000 | [diff] [blame] | 2142 | return LeakInfo(AllocNode, ReferenceRegion); |
Anna Zaks | df901a4 | 2012-02-23 21:38:21 +0000 | [diff] [blame] | 2143 | } |
| 2144 | |
Anna Zaks | d3571e5a | 2012-02-11 21:02:40 +0000 | [diff] [blame] | 2145 | void MallocChecker::reportLeak(SymbolRef Sym, ExplodedNode *N, |
| 2146 | CheckerContext &C) const { |
Anton Yartsev | 0578959 | 2013-03-28 17:05:19 +0000 | [diff] [blame] | 2147 | |
Anton Yartsev | 4eb394d | 2015-03-07 00:31:53 +0000 | [diff] [blame] | 2148 | if (!ChecksEnabled[CK_MallocChecker] && |
| 2149 | !ChecksEnabled[CK_NewDeleteLeaksChecker]) |
Anton Yartsev | 6e49925 | 2013-04-05 02:25:02 +0000 | [diff] [blame] | 2150 | return; |
| 2151 | |
Anton Yartsev | 9907fc9 | 2015-03-04 23:18:21 +0000 | [diff] [blame] | 2152 | const RefState *RS = C.getState()->get<RegionState>(Sym); |
Anton Yartsev | 4eb394d | 2015-03-07 00:31:53 +0000 | [diff] [blame] | 2153 | assert(RS && "cannot leak an untracked symbol"); |
| 2154 | AllocationFamily Family = RS->getAllocationFamily(); |
Anton Yartsev | 2487dd6 | 2015-03-10 22:24:21 +0000 | [diff] [blame] | 2155 | |
| 2156 | if (Family == AF_Alloca) |
Anton Yartsev | 4eb394d | 2015-03-07 00:31:53 +0000 | [diff] [blame] | 2157 | return; |
| 2158 | |
Anton Yartsev | 2487dd6 | 2015-03-10 22:24:21 +0000 | [diff] [blame] | 2159 | Optional<MallocChecker::CheckKind> |
| 2160 | CheckKind = getCheckIfTracked(Family, true); |
Anton Yartsev | 4eb394d | 2015-03-07 00:31:53 +0000 | [diff] [blame] | 2161 | |
Anton Yartsev | 2487dd6 | 2015-03-10 22:24:21 +0000 | [diff] [blame] | 2162 | if (!CheckKind.hasValue()) |
Anton Yartsev | 9907fc9 | 2015-03-04 23:18:21 +0000 | [diff] [blame] | 2163 | return; |
| 2164 | |
Anna Zaks | d3571e5a | 2012-02-11 21:02:40 +0000 | [diff] [blame] | 2165 | assert(N); |
Alexander Kornienko | 4aca9b1 | 2014-02-11 21:49:21 +0000 | [diff] [blame] | 2166 | if (!BT_Leak[*CheckKind]) { |
| 2167 | BT_Leak[*CheckKind].reset( |
| 2168 | new BugType(CheckNames[*CheckKind], "Memory leak", "Memory Error")); |
Anna Zaks | d3571e5a | 2012-02-11 21:02:40 +0000 | [diff] [blame] | 2169 | // Leaks should not be reported if they are post-dominated by a sink: |
| 2170 | // (1) Sinks are higher importance bugs. |
| 2171 | // (2) NoReturnFunctionChecker uses sink nodes to represent paths ending |
| 2172 | // with __noreturn functions such as assert() or exit(). We choose not |
| 2173 | // to report leaks on such paths. |
Alexander Kornienko | 4aca9b1 | 2014-02-11 21:49:21 +0000 | [diff] [blame] | 2174 | BT_Leak[*CheckKind]->setSuppressOnSink(true); |
Anna Zaks | d3571e5a | 2012-02-11 21:02:40 +0000 | [diff] [blame] | 2175 | } |
| 2176 | |
Anna Zaks | df901a4 | 2012-02-23 21:38:21 +0000 | [diff] [blame] | 2177 | // Most bug reports are cached at the location where they occurred. |
| 2178 | // With leaks, we want to unique them by the location where they were |
| 2179 | // allocated, and only report a single path. |
Anna Zaks | 43ffba2 | 2012-02-27 23:40:55 +0000 | [diff] [blame] | 2180 | PathDiagnosticLocation LocUsedForUniqueing; |
Craig Topper | 0dbb783 | 2014-05-27 02:45:47 +0000 | [diff] [blame] | 2181 | const ExplodedNode *AllocNode = nullptr; |
| 2182 | const MemRegion *Region = nullptr; |
Benjamin Kramer | 867ea1d | 2014-03-02 13:01:17 +0000 | [diff] [blame] | 2183 | std::tie(AllocNode, Region) = getAllocationSite(N, Sym, C); |
Ted Kremenek | 3a0678e | 2015-09-08 03:50:52 +0000 | [diff] [blame] | 2184 | |
Gabor Horvath | 6ee4f90 | 2016-08-18 07:54:50 +0000 | [diff] [blame] | 2185 | const Stmt *AllocationStmt = PathDiagnosticLocation::getStmt(AllocNode); |
Anton Yartsev | 6e49925 | 2013-04-05 02:25:02 +0000 | [diff] [blame] | 2186 | if (AllocationStmt) |
Anna Zaks | a043d0c | 2013-01-08 00:25:29 +0000 | [diff] [blame] | 2187 | LocUsedForUniqueing = PathDiagnosticLocation::createBegin(AllocationStmt, |
| 2188 | C.getSourceManager(), |
| 2189 | AllocNode->getLocationContext()); |
Anna Zaks | df901a4 | 2012-02-23 21:38:21 +0000 | [diff] [blame] | 2190 | |
Anna Zaks | fc2e153 | 2012-03-21 19:45:08 +0000 | [diff] [blame] | 2191 | SmallString<200> buf; |
| 2192 | llvm::raw_svector_ostream os(buf); |
Jordan Rose | d86b3bd | 2012-08-08 18:23:36 +0000 | [diff] [blame] | 2193 | if (Region && Region->canPrintPretty()) { |
Anna Zaks | 6cea7d9 | 2013-04-12 18:40:21 +0000 | [diff] [blame] | 2194 | os << "Potential leak of memory pointed to by "; |
Jordan Rose | d86b3bd | 2012-08-08 18:23:36 +0000 | [diff] [blame] | 2195 | Region->printPretty(os); |
Anna Zaks | a1de856 | 2013-04-06 00:41:36 +0000 | [diff] [blame] | 2196 | } else { |
| 2197 | os << "Potential memory leak"; |
Anna Zaks | fc2e153 | 2012-03-21 19:45:08 +0000 | [diff] [blame] | 2198 | } |
| 2199 | |
Aaron Ballman | 8d3a7a5 | 2015-06-23 13:15:32 +0000 | [diff] [blame] | 2200 | auto R = llvm::make_unique<BugReport>( |
| 2201 | *BT_Leak[*CheckKind], os.str(), N, LocUsedForUniqueing, |
| 2202 | AllocNode->getLocationContext()->getDecl()); |
Ted Kremenek | 1e809b4 | 2012-03-09 01:13:14 +0000 | [diff] [blame] | 2203 | R->markInteresting(Sym); |
David Blaikie | 91e7902 | 2014-09-04 23:54:33 +0000 | [diff] [blame] | 2204 | R->addVisitor(llvm::make_unique<MallocBugVisitor>(Sym, true)); |
Aaron Ballman | 8d3a7a5 | 2015-06-23 13:15:32 +0000 | [diff] [blame] | 2205 | C.emitReport(std::move(R)); |
Anna Zaks | d3571e5a | 2012-02-11 21:02:40 +0000 | [diff] [blame] | 2206 | } |
| 2207 | |
Argyrios Kyrtzidis | 183f0fb | 2011-02-28 01:26:35 +0000 | [diff] [blame] | 2208 | void MallocChecker::checkDeadSymbols(SymbolReaper &SymReaper, |
| 2209 | CheckerContext &C) const |
Ted Kremenek | 90af909 | 2010-12-02 07:49:45 +0000 | [diff] [blame] | 2210 | { |
Zhongxing Xu | bce831f | 2010-08-15 08:19:57 +0000 | [diff] [blame] | 2211 | if (!SymReaper.hasDeadSymbols()) |
| 2212 | return; |
Zhongxing Xu | c746096 | 2009-11-13 07:48:11 +0000 | [diff] [blame] | 2213 | |
Ted Kremenek | 49b1e38 | 2012-01-26 21:29:00 +0000 | [diff] [blame] | 2214 | ProgramStateRef state = C.getState(); |
Zhongxing Xu | bce831f | 2010-08-15 08:19:57 +0000 | [diff] [blame] | 2215 | RegionStateTy RS = state->get<RegionState>(); |
Jordy Rose | 8258499 | 2010-08-18 04:33:47 +0000 | [diff] [blame] | 2216 | RegionStateTy::Factory &F = state->get_context<RegionState>(); |
Zhongxing Xu | bce831f | 2010-08-15 08:19:57 +0000 | [diff] [blame] | 2217 | |
Dmitri Gribenko | f857950 | 2013-01-12 19:30:44 +0000 | [diff] [blame] | 2218 | SmallVector<SymbolRef, 2> Errors; |
Zhongxing Xu | bce831f | 2010-08-15 08:19:57 +0000 | [diff] [blame] | 2219 | for (RegionStateTy::iterator I = RS.begin(), E = RS.end(); I != E; ++I) { |
| 2220 | if (SymReaper.isDead(I->first)) { |
Anton Yartsev | b50f4ba | 2015-04-14 14:18:04 +0000 | [diff] [blame] | 2221 | if (I->second.isAllocated() || I->second.isAllocatedOfSizeZero()) |
Anna Zaks | 78edc2f | 2012-02-09 06:48:19 +0000 | [diff] [blame] | 2222 | Errors.push_back(I->first); |
Jordy Rose | 8258499 | 2010-08-18 04:33:47 +0000 | [diff] [blame] | 2223 | // Remove the dead symbol from the map. |
Ted Kremenek | b3b56c6 | 2010-11-24 00:54:37 +0000 | [diff] [blame] | 2224 | RS = F.remove(RS, I->first); |
Ted Kremenek | e227f49 | 2011-07-28 23:07:51 +0000 | [diff] [blame] | 2225 | |
Zhongxing Xu | c746096 | 2009-11-13 07:48:11 +0000 | [diff] [blame] | 2226 | } |
| 2227 | } |
Ted Kremenek | 3a0678e | 2015-09-08 03:50:52 +0000 | [diff] [blame] | 2228 | |
Anna Zaks | d56c879 | 2012-02-13 18:05:39 +0000 | [diff] [blame] | 2229 | // Cleanup the Realloc Pairs Map. |
Jordan Rose | 0c153cb | 2012-11-02 01:54:06 +0000 | [diff] [blame] | 2230 | ReallocPairsTy RP = state->get<ReallocPairs>(); |
| 2231 | for (ReallocPairsTy::iterator I = RP.begin(), E = RP.end(); I != E; ++I) { |
Anna Zaks | ac06814 | 2012-02-15 00:11:25 +0000 | [diff] [blame] | 2232 | if (SymReaper.isDead(I->first) || |
| 2233 | SymReaper.isDead(I->second.ReallocatedSym)) { |
Anna Zaks | d56c879 | 2012-02-13 18:05:39 +0000 | [diff] [blame] | 2234 | state = state->remove<ReallocPairs>(I->first); |
| 2235 | } |
| 2236 | } |
| 2237 | |
Anna Zaks | 67291b9 | 2012-11-13 03:18:01 +0000 | [diff] [blame] | 2238 | // Cleanup the FreeReturnValue Map. |
| 2239 | FreeReturnValueTy FR = state->get<FreeReturnValue>(); |
| 2240 | for (FreeReturnValueTy::iterator I = FR.begin(), E = FR.end(); I != E; ++I) { |
| 2241 | if (SymReaper.isDead(I->first) || |
| 2242 | SymReaper.isDead(I->second)) { |
| 2243 | state = state->remove<FreeReturnValue>(I->first); |
| 2244 | } |
| 2245 | } |
| 2246 | |
Anna Zaks | df901a4 | 2012-02-23 21:38:21 +0000 | [diff] [blame] | 2247 | // Generate leak node. |
Anna Zaks | 58a2c4e | 2012-10-29 22:51:54 +0000 | [diff] [blame] | 2248 | ExplodedNode *N = C.getPredecessor(); |
| 2249 | if (!Errors.empty()) { |
Anton Yartsev | 6a61922 | 2014-02-17 18:25:34 +0000 | [diff] [blame] | 2250 | static CheckerProgramPointTag Tag("MallocChecker", "DeadSymbolsLeak"); |
Devin Coughlin | e39bd40 | 2015-09-16 22:03:05 +0000 | [diff] [blame] | 2251 | N = C.generateNonFatalErrorNode(C.getState(), &Tag); |
| 2252 | if (N) { |
| 2253 | for (SmallVectorImpl<SymbolRef>::iterator |
Craig Topper | 2341c0d | 2013-07-04 03:08:24 +0000 | [diff] [blame] | 2254 | I = Errors.begin(), E = Errors.end(); I != E; ++I) { |
Devin Coughlin | e39bd40 | 2015-09-16 22:03:05 +0000 | [diff] [blame] | 2255 | reportLeak(*I, N, C); |
| 2256 | } |
Anna Zaks | 78edc2f | 2012-02-09 06:48:19 +0000 | [diff] [blame] | 2257 | } |
Ted Kremenek | e227f49 | 2011-07-28 23:07:51 +0000 | [diff] [blame] | 2258 | } |
Anna Zaks | 58a2c4e | 2012-10-29 22:51:54 +0000 | [diff] [blame] | 2259 | |
Anna Zaks | df901a4 | 2012-02-23 21:38:21 +0000 | [diff] [blame] | 2260 | C.addTransition(state->set<RegionState>(RS), N); |
Zhongxing Xu | c4902a5 | 2009-11-13 07:25:27 +0000 | [diff] [blame] | 2261 | } |
Zhongxing Xu | 4668c7e | 2009-11-17 07:54:15 +0000 | [diff] [blame] | 2262 | |
Anton Yartsev | cb2ccd6 | 2013-04-10 22:21:41 +0000 | [diff] [blame] | 2263 | void MallocChecker::checkPreCall(const CallEvent &Call, |
| 2264 | CheckerContext &C) const { |
| 2265 | |
Jordan Rose | 656fdd5 | 2014-01-08 18:46:55 +0000 | [diff] [blame] | 2266 | if (const CXXDestructorCall *DC = dyn_cast<CXXDestructorCall>(&Call)) { |
| 2267 | SymbolRef Sym = DC->getCXXThisVal().getAsSymbol(); |
| 2268 | if (!Sym || checkDoubleDelete(Sym, C)) |
| 2269 | return; |
| 2270 | } |
| 2271 | |
Anna Zaks | 46d0160 | 2012-05-18 01:16:10 +0000 | [diff] [blame] | 2272 | // We will check for double free in the post visit. |
Anton Yartsev | cb2ccd6 | 2013-04-10 22:21:41 +0000 | [diff] [blame] | 2273 | if (const AnyFunctionCall *FC = dyn_cast<AnyFunctionCall>(&Call)) { |
| 2274 | const FunctionDecl *FD = FC->getDecl(); |
| 2275 | if (!FD) |
| 2276 | return; |
Anton Yartsev | 13df036 | 2013-03-25 01:35:45 +0000 | [diff] [blame] | 2277 | |
Anna Zaks | d79b840 | 2014-10-03 21:48:59 +0000 | [diff] [blame] | 2278 | ASTContext &Ctx = C.getASTContext(); |
Gabor Horvath | e40c71c | 2015-03-04 17:59:34 +0000 | [diff] [blame] | 2279 | if (ChecksEnabled[CK_MallocChecker] && |
Anna Zaks | d79b840 | 2014-10-03 21:48:59 +0000 | [diff] [blame] | 2280 | (isCMemFunction(FD, Ctx, AF_Malloc, MemoryOperationKind::MOK_Free) || |
| 2281 | isCMemFunction(FD, Ctx, AF_IfNameIndex, |
| 2282 | MemoryOperationKind::MOK_Free))) |
Anton Yartsev | cb2ccd6 | 2013-04-10 22:21:41 +0000 | [diff] [blame] | 2283 | return; |
Anna Zaks | 3d34834 | 2012-02-14 21:55:24 +0000 | [diff] [blame] | 2284 | |
Alexander Kornienko | 4aca9b1 | 2014-02-11 21:49:21 +0000 | [diff] [blame] | 2285 | if (ChecksEnabled[CK_NewDeleteChecker] && |
Anna Zaks | d79b840 | 2014-10-03 21:48:59 +0000 | [diff] [blame] | 2286 | isStandardNewDelete(FD, Ctx)) |
Anton Yartsev | cb2ccd6 | 2013-04-10 22:21:41 +0000 | [diff] [blame] | 2287 | return; |
| 2288 | } |
| 2289 | |
| 2290 | // Check if the callee of a method is deleted. |
| 2291 | if (const CXXInstanceCall *CC = dyn_cast<CXXInstanceCall>(&Call)) { |
| 2292 | SymbolRef Sym = CC->getCXXThisVal().getAsSymbol(); |
| 2293 | if (!Sym || checkUseAfterFree(Sym, C, CC->getCXXThisExpr())) |
| 2294 | return; |
| 2295 | } |
| 2296 | |
| 2297 | // Check arguments for being used after free. |
| 2298 | for (unsigned I = 0, E = Call.getNumArgs(); I != E; ++I) { |
| 2299 | SVal ArgSVal = Call.getArgSVal(I); |
| 2300 | if (ArgSVal.getAs<Loc>()) { |
| 2301 | SymbolRef Sym = ArgSVal.getAsSymbol(); |
Anna Zaks | 3d34834 | 2012-02-14 21:55:24 +0000 | [diff] [blame] | 2302 | if (!Sym) |
| 2303 | continue; |
Anton Yartsev | cb2ccd6 | 2013-04-10 22:21:41 +0000 | [diff] [blame] | 2304 | if (checkUseAfterFree(Sym, C, Call.getArgExpr(I))) |
Anna Zaks | 3d34834 | 2012-02-14 21:55:24 +0000 | [diff] [blame] | 2305 | return; |
| 2306 | } |
| 2307 | } |
| 2308 | } |
| 2309 | |
Anna Zaks | a1b227b | 2012-02-08 23:16:56 +0000 | [diff] [blame] | 2310 | void MallocChecker::checkPreStmt(const ReturnStmt *S, CheckerContext &C) const { |
| 2311 | const Expr *E = S->getRetValue(); |
| 2312 | if (!E) |
| 2313 | return; |
Anna Zaks | 3aa5225 | 2012-02-11 21:44:39 +0000 | [diff] [blame] | 2314 | |
| 2315 | // Check if we are returning a symbol. |
Jordan Rose | 356279c | 2012-08-08 18:23:31 +0000 | [diff] [blame] | 2316 | ProgramStateRef State = C.getState(); |
| 2317 | SVal RetVal = State->getSVal(E, C.getLocationContext()); |
Anna Zaks | 4ca45b1 | 2012-02-22 02:36:01 +0000 | [diff] [blame] | 2318 | SymbolRef Sym = RetVal.getAsSymbol(); |
| 2319 | if (!Sym) |
| 2320 | // If we are returning a field of the allocated struct or an array element, |
| 2321 | // the callee could still free the memory. |
| 2322 | // TODO: This logic should be a part of generic symbol escape callback. |
| 2323 | if (const MemRegion *MR = RetVal.getAsRegion()) |
| 2324 | if (isa<FieldRegion>(MR) || isa<ElementRegion>(MR)) |
| 2325 | if (const SymbolicRegion *BMR = |
| 2326 | dyn_cast<SymbolicRegion>(MR->getBaseRegion())) |
| 2327 | Sym = BMR->getSymbol(); |
Zhongxing Xu | 23baa01 | 2009-11-17 08:58:18 +0000 | [diff] [blame] | 2328 | |
Anna Zaks | 3aa5225 | 2012-02-11 21:44:39 +0000 | [diff] [blame] | 2329 | // Check if we are returning freed memory. |
Jordan Rose | 356279c | 2012-08-08 18:23:31 +0000 | [diff] [blame] | 2330 | if (Sym) |
Jordan Rose | f1f2614 | 2012-11-15 19:11:33 +0000 | [diff] [blame] | 2331 | checkUseAfterFree(Sym, C, E); |
Zhongxing Xu | 23baa01 | 2009-11-17 08:58:18 +0000 | [diff] [blame] | 2332 | } |
Zhongxing Xu | b0e15df | 2009-12-31 06:13:07 +0000 | [diff] [blame] | 2333 | |
Anna Zaks | 9fe8098 | 2012-03-22 00:57:20 +0000 | [diff] [blame] | 2334 | // TODO: Blocks should be either inlined or should call invalidate regions |
Ted Kremenek | 3a0678e | 2015-09-08 03:50:52 +0000 | [diff] [blame] | 2335 | // upon invocation. After that's in place, special casing here will not be |
Anna Zaks | 9fe8098 | 2012-03-22 00:57:20 +0000 | [diff] [blame] | 2336 | // needed. |
| 2337 | void MallocChecker::checkPostStmt(const BlockExpr *BE, |
| 2338 | CheckerContext &C) const { |
| 2339 | |
| 2340 | // Scan the BlockDecRefExprs for any object the retain count checker |
| 2341 | // may be tracking. |
| 2342 | if (!BE->getBlockDecl()->hasCaptures()) |
| 2343 | return; |
| 2344 | |
| 2345 | ProgramStateRef state = C.getState(); |
| 2346 | const BlockDataRegion *R = |
| 2347 | cast<BlockDataRegion>(state->getSVal(BE, |
| 2348 | C.getLocationContext()).getAsRegion()); |
| 2349 | |
| 2350 | BlockDataRegion::referenced_vars_iterator I = R->referenced_vars_begin(), |
| 2351 | E = R->referenced_vars_end(); |
| 2352 | |
| 2353 | if (I == E) |
| 2354 | return; |
| 2355 | |
| 2356 | SmallVector<const MemRegion*, 10> Regions; |
| 2357 | const LocationContext *LC = C.getLocationContext(); |
| 2358 | MemRegionManager &MemMgr = C.getSValBuilder().getRegionManager(); |
| 2359 | |
| 2360 | for ( ; I != E; ++I) { |
Ted Kremenek | bcf9053 | 2012-12-06 07:17:20 +0000 | [diff] [blame] | 2361 | const VarRegion *VR = I.getCapturedRegion(); |
Anna Zaks | 9fe8098 | 2012-03-22 00:57:20 +0000 | [diff] [blame] | 2362 | if (VR->getSuperRegion() == R) { |
| 2363 | VR = MemMgr.getVarRegion(VR->getDecl(), LC); |
| 2364 | } |
| 2365 | Regions.push_back(VR); |
| 2366 | } |
| 2367 | |
| 2368 | state = |
| 2369 | state->scanReachableSymbols<StopTrackingCallback>(Regions.data(), |
| 2370 | Regions.data() + Regions.size()).getState(); |
| 2371 | C.addTransition(state); |
| 2372 | } |
| 2373 | |
Anna Zaks | 46d0160 | 2012-05-18 01:16:10 +0000 | [diff] [blame] | 2374 | bool MallocChecker::isReleased(SymbolRef Sym, CheckerContext &C) const { |
Anna Zaks | a1b227b | 2012-02-08 23:16:56 +0000 | [diff] [blame] | 2375 | assert(Sym); |
| 2376 | const RefState *RS = C.getState()->get<RegionState>(Sym); |
Anna Zaks | 46d0160 | 2012-05-18 01:16:10 +0000 | [diff] [blame] | 2377 | return (RS && RS->isReleased()); |
| 2378 | } |
| 2379 | |
| 2380 | bool MallocChecker::checkUseAfterFree(SymbolRef Sym, CheckerContext &C, |
| 2381 | const Stmt *S) const { |
Anna Zaks | a1b227b | 2012-02-08 23:16:56 +0000 | [diff] [blame] | 2382 | |
Jordan Rose | 656fdd5 | 2014-01-08 18:46:55 +0000 | [diff] [blame] | 2383 | if (isReleased(Sym, C)) { |
Anton Yartsev | 59ed15b | 2013-03-13 14:39:10 +0000 | [diff] [blame] | 2384 | ReportUseAfterFree(C, S->getSourceRange(), Sym); |
| 2385 | return true; |
Anna Zaks | a1b227b | 2012-02-08 23:16:56 +0000 | [diff] [blame] | 2386 | } |
Anton Yartsev | 59ed15b | 2013-03-13 14:39:10 +0000 | [diff] [blame] | 2387 | |
Anna Zaks | a1b227b | 2012-02-08 23:16:56 +0000 | [diff] [blame] | 2388 | return false; |
| 2389 | } |
| 2390 | |
Anton Yartsev | b50f4ba | 2015-04-14 14:18:04 +0000 | [diff] [blame] | 2391 | void MallocChecker::checkUseZeroAllocated(SymbolRef Sym, CheckerContext &C, |
| 2392 | const Stmt *S) const { |
| 2393 | assert(Sym); |
Anton Yartsev | b50f4ba | 2015-04-14 14:18:04 +0000 | [diff] [blame] | 2394 | |
Devin Coughlin | 8177173 | 2015-09-22 22:47:14 +0000 | [diff] [blame] | 2395 | if (const RefState *RS = C.getState()->get<RegionState>(Sym)) { |
| 2396 | if (RS->isAllocatedOfSizeZero()) |
| 2397 | ReportUseZeroAllocated(C, RS->getStmt()->getSourceRange(), Sym); |
| 2398 | } |
| 2399 | else if (C.getState()->contains<ReallocSizeZeroSymbols>(Sym)) { |
| 2400 | ReportUseZeroAllocated(C, S->getSourceRange(), Sym); |
| 2401 | } |
Anton Yartsev | b50f4ba | 2015-04-14 14:18:04 +0000 | [diff] [blame] | 2402 | } |
| 2403 | |
Jordan Rose | 656fdd5 | 2014-01-08 18:46:55 +0000 | [diff] [blame] | 2404 | bool MallocChecker::checkDoubleDelete(SymbolRef Sym, CheckerContext &C) const { |
| 2405 | |
| 2406 | if (isReleased(Sym, C)) { |
| 2407 | ReportDoubleDelete(C, Sym); |
| 2408 | return true; |
| 2409 | } |
| 2410 | return false; |
| 2411 | } |
| 2412 | |
Zhongxing Xu | 1bb6a1a | 2010-03-10 04:58:55 +0000 | [diff] [blame] | 2413 | // Check if the location is a freed symbolic region. |
Anna Zaks | 3e0f415 | 2011-10-06 00:43:15 +0000 | [diff] [blame] | 2414 | void MallocChecker::checkLocation(SVal l, bool isLoad, const Stmt *S, |
| 2415 | CheckerContext &C) const { |
Zhongxing Xu | 1bb6a1a | 2010-03-10 04:58:55 +0000 | [diff] [blame] | 2416 | SymbolRef Sym = l.getLocSymbolInBase(); |
Anton Yartsev | b50f4ba | 2015-04-14 14:18:04 +0000 | [diff] [blame] | 2417 | if (Sym) { |
Anna Zaks | 46d0160 | 2012-05-18 01:16:10 +0000 | [diff] [blame] | 2418 | checkUseAfterFree(Sym, C, S); |
Anton Yartsev | b50f4ba | 2015-04-14 14:18:04 +0000 | [diff] [blame] | 2419 | checkUseZeroAllocated(Sym, C, S); |
| 2420 | } |
Zhongxing Xu | 1bb6a1a | 2010-03-10 04:58:55 +0000 | [diff] [blame] | 2421 | } |
Ted Kremenek | d21139a | 2010-07-31 01:52:11 +0000 | [diff] [blame] | 2422 | |
Anna Zaks | bb1ef90 | 2012-02-11 21:02:35 +0000 | [diff] [blame] | 2423 | // If a symbolic region is assumed to NULL (or another constant), stop tracking |
| 2424 | // it - assuming that allocation failed on this path. |
| 2425 | ProgramStateRef MallocChecker::evalAssume(ProgramStateRef state, |
| 2426 | SVal Cond, |
| 2427 | bool Assumption) const { |
| 2428 | RegionStateTy RS = state->get<RegionState>(); |
Anna Zaks | bb1ef90 | 2012-02-11 21:02:35 +0000 | [diff] [blame] | 2429 | for (RegionStateTy::iterator I = RS.begin(), E = RS.end(); I != E; ++I) { |
Ted Kremenek | 244e1d7 | 2012-09-07 22:31:01 +0000 | [diff] [blame] | 2430 | // If the symbol is assumed to be NULL, remove it from consideration. |
Jordan Rose | 14fe9f3 | 2012-11-01 00:18:27 +0000 | [diff] [blame] | 2431 | ConstraintManager &CMgr = state->getConstraintManager(); |
| 2432 | ConditionTruthVal AllocFailed = CMgr.isNull(state, I.getKey()); |
| 2433 | if (AllocFailed.isConstrainedTrue()) |
Anna Zaks | bb1ef90 | 2012-02-11 21:02:35 +0000 | [diff] [blame] | 2434 | state = state->remove<RegionState>(I.getKey()); |
| 2435 | } |
| 2436 | |
Anna Zaks | d56c879 | 2012-02-13 18:05:39 +0000 | [diff] [blame] | 2437 | // Realloc returns 0 when reallocation fails, which means that we should |
| 2438 | // restore the state of the pointer being reallocated. |
Jordan Rose | 0c153cb | 2012-11-02 01:54:06 +0000 | [diff] [blame] | 2439 | ReallocPairsTy RP = state->get<ReallocPairs>(); |
| 2440 | for (ReallocPairsTy::iterator I = RP.begin(), E = RP.end(); I != E; ++I) { |
Ted Kremenek | 244e1d7 | 2012-09-07 22:31:01 +0000 | [diff] [blame] | 2441 | // If the symbol is assumed to be NULL, remove it from consideration. |
Jordan Rose | 14fe9f3 | 2012-11-01 00:18:27 +0000 | [diff] [blame] | 2442 | ConstraintManager &CMgr = state->getConstraintManager(); |
| 2443 | ConditionTruthVal AllocFailed = CMgr.isNull(state, I.getKey()); |
Jordan Rose | 40bb1249 | 2012-11-01 00:25:15 +0000 | [diff] [blame] | 2444 | if (!AllocFailed.isConstrainedTrue()) |
Anna Zaks | 75cfbb6 | 2012-09-12 22:57:34 +0000 | [diff] [blame] | 2445 | continue; |
Jordan Rose | 14fe9f3 | 2012-11-01 00:18:27 +0000 | [diff] [blame] | 2446 | |
Anna Zaks | 75cfbb6 | 2012-09-12 22:57:34 +0000 | [diff] [blame] | 2447 | SymbolRef ReallocSym = I.getData().ReallocatedSym; |
| 2448 | if (const RefState *RS = state->get<RegionState>(ReallocSym)) { |
| 2449 | if (RS->isReleased()) { |
| 2450 | if (I.getData().Kind == RPToBeFreedAfterFailure) |
Anna Zaks | ac06814 | 2012-02-15 00:11:25 +0000 | [diff] [blame] | 2451 | state = state->set<RegionState>(ReallocSym, |
Anton Yartsev | 0578959 | 2013-03-28 17:05:19 +0000 | [diff] [blame] | 2452 | RefState::getAllocated(RS->getAllocationFamily(), RS->getStmt())); |
Anna Zaks | 75cfbb6 | 2012-09-12 22:57:34 +0000 | [diff] [blame] | 2453 | else if (I.getData().Kind == RPDoNotTrackAfterFailure) |
| 2454 | state = state->remove<RegionState>(ReallocSym); |
| 2455 | else |
| 2456 | assert(I.getData().Kind == RPIsFreeOnFailure); |
Anna Zaks | d56c879 | 2012-02-13 18:05:39 +0000 | [diff] [blame] | 2457 | } |
Anna Zaks | d56c879 | 2012-02-13 18:05:39 +0000 | [diff] [blame] | 2458 | } |
Anna Zaks | 75cfbb6 | 2012-09-12 22:57:34 +0000 | [diff] [blame] | 2459 | state = state->remove<ReallocPairs>(I.getKey()); |
Anna Zaks | d56c879 | 2012-02-13 18:05:39 +0000 | [diff] [blame] | 2460 | } |
| 2461 | |
Anna Zaks | bb1ef90 | 2012-02-11 21:02:35 +0000 | [diff] [blame] | 2462 | return state; |
| 2463 | } |
| 2464 | |
Anna Zaks | 8ebeb64 | 2013-06-08 00:29:29 +0000 | [diff] [blame] | 2465 | bool MallocChecker::mayFreeAnyEscapedMemoryOrIsModeledExplicitly( |
Anna Zaks | a4bc5e1 | 2013-05-31 23:47:32 +0000 | [diff] [blame] | 2466 | const CallEvent *Call, |
| 2467 | ProgramStateRef State, |
| 2468 | SymbolRef &EscapingSymbol) const { |
Jordan Rose | 7ab0182 | 2012-07-02 19:27:51 +0000 | [diff] [blame] | 2469 | assert(Call); |
Craig Topper | 0dbb783 | 2014-05-27 02:45:47 +0000 | [diff] [blame] | 2470 | EscapingSymbol = nullptr; |
| 2471 | |
Jordan Rose | 2a833ca | 2014-01-15 17:25:15 +0000 | [diff] [blame] | 2472 | // For now, assume that any C++ or block call can free memory. |
Anna Zaks | 7ac344a | 2012-02-24 23:56:53 +0000 | [diff] [blame] | 2473 | // TODO: If we want to be more optimistic here, we'll need to make sure that |
| 2474 | // regions escape to C++ containers. They seem to do that even now, but for |
| 2475 | // mysterious reasons. |
Jordan Rose | 2a833ca | 2014-01-15 17:25:15 +0000 | [diff] [blame] | 2476 | if (!(isa<SimpleFunctionCall>(Call) || isa<ObjCMethodCall>(Call))) |
Anna Zaks | a4bc5e1 | 2013-05-31 23:47:32 +0000 | [diff] [blame] | 2477 | return true; |
Anna Zaks | 7ac344a | 2012-02-24 23:56:53 +0000 | [diff] [blame] | 2478 | |
Jordan Rose | 742920c | 2012-07-02 19:27:35 +0000 | [diff] [blame] | 2479 | // Check Objective-C messages by selector name. |
Jordan Rose | 6bad490 | 2012-07-02 19:27:56 +0000 | [diff] [blame] | 2480 | if (const ObjCMethodCall *Msg = dyn_cast<ObjCMethodCall>(Call)) { |
Jordan Rose | 7ab0182 | 2012-07-02 19:27:51 +0000 | [diff] [blame] | 2481 | // If it's not a framework call, or if it takes a callback, assume it |
| 2482 | // can free memory. |
Anna Zaks | fe1eca5 | 2015-10-27 20:19:45 +0000 | [diff] [blame] | 2483 | if (!Call->isInSystemHeader() || Call->argumentsMayEscape()) |
Anna Zaks | a4bc5e1 | 2013-05-31 23:47:32 +0000 | [diff] [blame] | 2484 | return true; |
Anna Zaks | 06a77fc | 2012-02-28 01:54:22 +0000 | [diff] [blame] | 2485 | |
Jordan Rose | 613f3c0 | 2013-03-09 00:59:10 +0000 | [diff] [blame] | 2486 | // If it's a method we know about, handle it explicitly post-call. |
| 2487 | // This should happen before the "freeWhenDone" check below. |
| 2488 | if (isKnownDeallocObjCMethodName(*Msg)) |
Anna Zaks | a4bc5e1 | 2013-05-31 23:47:32 +0000 | [diff] [blame] | 2489 | return false; |
Anna Zaks | 886dfb8 | 2012-06-20 23:35:57 +0000 | [diff] [blame] | 2490 | |
Jordan Rose | 613f3c0 | 2013-03-09 00:59:10 +0000 | [diff] [blame] | 2491 | // If there's a "freeWhenDone" parameter, but the method isn't one we know |
| 2492 | // about, we can't be sure that the object will use free() to deallocate the |
| 2493 | // memory, so we can't model it explicitly. The best we can do is use it to |
| 2494 | // decide whether the pointer escapes. |
| 2495 | if (Optional<bool> FreeWhenDone = getFreeWhenDoneArg(*Msg)) |
Anna Zaks | a4bc5e1 | 2013-05-31 23:47:32 +0000 | [diff] [blame] | 2496 | return *FreeWhenDone; |
Anna Zaks | 7ac344a | 2012-02-24 23:56:53 +0000 | [diff] [blame] | 2497 | |
Jordan Rose | 613f3c0 | 2013-03-09 00:59:10 +0000 | [diff] [blame] | 2498 | // If the first selector piece ends with "NoCopy", and there is no |
| 2499 | // "freeWhenDone" parameter set to zero, we know ownership is being |
| 2500 | // transferred. Again, though, we can't be sure that the object will use |
| 2501 | // free() to deallocate the memory, so we can't model it explicitly. |
| 2502 | StringRef FirstSlot = Msg->getSelector().getNameForSlot(0); |
Jordan Rose | 742920c | 2012-07-02 19:27:35 +0000 | [diff] [blame] | 2503 | if (FirstSlot.endswith("NoCopy")) |
Anna Zaks | a4bc5e1 | 2013-05-31 23:47:32 +0000 | [diff] [blame] | 2504 | return true; |
Anna Zaks | 12a8b90 | 2012-03-05 17:42:10 +0000 | [diff] [blame] | 2505 | |
Anna Zaks | 42908c7 | 2012-06-19 05:10:32 +0000 | [diff] [blame] | 2506 | // If the first selector starts with addPointer, insertPointer, |
| 2507 | // or replacePointer, assume we are dealing with NSPointerArray or similar. |
| 2508 | // This is similar to C++ containers (vector); we still might want to check |
Jordan Rose | 742920c | 2012-07-02 19:27:35 +0000 | [diff] [blame] | 2509 | // that the pointers get freed by following the container itself. |
| 2510 | if (FirstSlot.startswith("addPointer") || |
| 2511 | FirstSlot.startswith("insertPointer") || |
Jordan Rose | 514f935 | 2014-01-07 21:39:48 +0000 | [diff] [blame] | 2512 | FirstSlot.startswith("replacePointer") || |
| 2513 | FirstSlot.equals("valueWithPointer")) { |
Anna Zaks | a4bc5e1 | 2013-05-31 23:47:32 +0000 | [diff] [blame] | 2514 | return true; |
Anna Zaks | 42908c7 | 2012-06-19 05:10:32 +0000 | [diff] [blame] | 2515 | } |
| 2516 | |
Anna Zaks | a4bc5e1 | 2013-05-31 23:47:32 +0000 | [diff] [blame] | 2517 | // We should escape receiver on call to 'init'. This is especially relevant |
| 2518 | // to the receiver, as the corresponding symbol is usually not referenced |
| 2519 | // after the call. |
| 2520 | if (Msg->getMethodFamily() == OMF_init) { |
| 2521 | EscapingSymbol = Msg->getReceiverSVal().getAsSymbol(); |
| 2522 | return true; |
| 2523 | } |
Anna Zaks | 737926b | 2013-05-31 22:39:13 +0000 | [diff] [blame] | 2524 | |
Jordan Rose | 742920c | 2012-07-02 19:27:35 +0000 | [diff] [blame] | 2525 | // Otherwise, assume that the method does not free memory. |
| 2526 | // Most framework methods do not free memory. |
Anna Zaks | a4bc5e1 | 2013-05-31 23:47:32 +0000 | [diff] [blame] | 2527 | return false; |
Anna Zaks | 3d34834 | 2012-02-14 21:55:24 +0000 | [diff] [blame] | 2528 | } |
| 2529 | |
Jordan Rose | 742920c | 2012-07-02 19:27:35 +0000 | [diff] [blame] | 2530 | // At this point the only thing left to handle is straight function calls. |
Jordan Rose | 2a833ca | 2014-01-15 17:25:15 +0000 | [diff] [blame] | 2531 | const FunctionDecl *FD = cast<SimpleFunctionCall>(Call)->getDecl(); |
Jordan Rose | 742920c | 2012-07-02 19:27:35 +0000 | [diff] [blame] | 2532 | if (!FD) |
Anna Zaks | a4bc5e1 | 2013-05-31 23:47:32 +0000 | [diff] [blame] | 2533 | return true; |
Anna Zaks | 7ac344a | 2012-02-24 23:56:53 +0000 | [diff] [blame] | 2534 | |
Jordan Rose | 742920c | 2012-07-02 19:27:35 +0000 | [diff] [blame] | 2535 | ASTContext &ASTC = State->getStateManager().getContext(); |
| 2536 | |
| 2537 | // If it's one of the allocation functions we can reason about, we model |
| 2538 | // its behavior explicitly. |
| 2539 | if (isMemFunction(FD, ASTC)) |
Anna Zaks | a4bc5e1 | 2013-05-31 23:47:32 +0000 | [diff] [blame] | 2540 | return false; |
Jordan Rose | 742920c | 2012-07-02 19:27:35 +0000 | [diff] [blame] | 2541 | |
| 2542 | // If it's not a system call, assume it frees memory. |
| 2543 | if (!Call->isInSystemHeader()) |
Anna Zaks | a4bc5e1 | 2013-05-31 23:47:32 +0000 | [diff] [blame] | 2544 | return true; |
Jordan Rose | 742920c | 2012-07-02 19:27:35 +0000 | [diff] [blame] | 2545 | |
| 2546 | // White list the system functions whose arguments escape. |
| 2547 | const IdentifierInfo *II = FD->getIdentifier(); |
| 2548 | if (!II) |
Anna Zaks | a4bc5e1 | 2013-05-31 23:47:32 +0000 | [diff] [blame] | 2549 | return true; |
Jordan Rose | 742920c | 2012-07-02 19:27:35 +0000 | [diff] [blame] | 2550 | StringRef FName = II->getName(); |
| 2551 | |
Jordan Rose | 742920c | 2012-07-02 19:27:35 +0000 | [diff] [blame] | 2552 | // White list the 'XXXNoCopy' CoreFoundation functions. |
Ted Kremenek | 3a0678e | 2015-09-08 03:50:52 +0000 | [diff] [blame] | 2553 | // We specifically check these before |
Jordan Rose | 742920c | 2012-07-02 19:27:35 +0000 | [diff] [blame] | 2554 | if (FName.endswith("NoCopy")) { |
| 2555 | // Look for the deallocator argument. We know that the memory ownership |
| 2556 | // is not transferred only if the deallocator argument is |
| 2557 | // 'kCFAllocatorNull'. |
| 2558 | for (unsigned i = 1; i < Call->getNumArgs(); ++i) { |
| 2559 | const Expr *ArgE = Call->getArgExpr(i)->IgnoreParenCasts(); |
| 2560 | if (const DeclRefExpr *DE = dyn_cast<DeclRefExpr>(ArgE)) { |
| 2561 | StringRef DeallocatorName = DE->getFoundDecl()->getName(); |
| 2562 | if (DeallocatorName == "kCFAllocatorNull") |
Anna Zaks | a4bc5e1 | 2013-05-31 23:47:32 +0000 | [diff] [blame] | 2563 | return false; |
Jordan Rose | 742920c | 2012-07-02 19:27:35 +0000 | [diff] [blame] | 2564 | } |
| 2565 | } |
Anna Zaks | a4bc5e1 | 2013-05-31 23:47:32 +0000 | [diff] [blame] | 2566 | return true; |
Jordan Rose | 742920c | 2012-07-02 19:27:35 +0000 | [diff] [blame] | 2567 | } |
| 2568 | |
Jordan Rose | 742920c | 2012-07-02 19:27:35 +0000 | [diff] [blame] | 2569 | // Associating streams with malloced buffers. The pointer can escape if |
Jordan Rose | 7ab0182 | 2012-07-02 19:27:51 +0000 | [diff] [blame] | 2570 | // 'closefn' is specified (and if that function does free memory), |
| 2571 | // but it will not if closefn is not specified. |
Jordan Rose | 742920c | 2012-07-02 19:27:35 +0000 | [diff] [blame] | 2572 | // Currently, we do not inspect the 'closefn' function (PR12101). |
| 2573 | if (FName == "funopen") |
Jordan Rose | 7ab0182 | 2012-07-02 19:27:51 +0000 | [diff] [blame] | 2574 | if (Call->getNumArgs() >= 4 && Call->getArgSVal(4).isConstant(0)) |
Anna Zaks | a4bc5e1 | 2013-05-31 23:47:32 +0000 | [diff] [blame] | 2575 | return false; |
Jordan Rose | 742920c | 2012-07-02 19:27:35 +0000 | [diff] [blame] | 2576 | |
| 2577 | // Do not warn on pointers passed to 'setbuf' when used with std streams, |
| 2578 | // these leaks might be intentional when setting the buffer for stdio. |
| 2579 | // http://stackoverflow.com/questions/2671151/who-frees-setvbuf-buffer |
| 2580 | if (FName == "setbuf" || FName =="setbuffer" || |
| 2581 | FName == "setlinebuf" || FName == "setvbuf") { |
| 2582 | if (Call->getNumArgs() >= 1) { |
| 2583 | const Expr *ArgE = Call->getArgExpr(0)->IgnoreParenCasts(); |
| 2584 | if (const DeclRefExpr *ArgDRE = dyn_cast<DeclRefExpr>(ArgE)) |
| 2585 | if (const VarDecl *D = dyn_cast<VarDecl>(ArgDRE->getDecl())) |
| 2586 | if (D->getCanonicalDecl()->getName().find("std") != StringRef::npos) |
Anna Zaks | a4bc5e1 | 2013-05-31 23:47:32 +0000 | [diff] [blame] | 2587 | return true; |
Jordan Rose | 742920c | 2012-07-02 19:27:35 +0000 | [diff] [blame] | 2588 | } |
| 2589 | } |
| 2590 | |
| 2591 | // A bunch of other functions which either take ownership of a pointer or |
| 2592 | // wrap the result up in a struct or object, meaning it can be freed later. |
| 2593 | // (See RetainCountChecker.) Not all the parameters here are invalidated, |
| 2594 | // but the Malloc checker cannot differentiate between them. The right way |
| 2595 | // of doing this would be to implement a pointer escapes callback. |
| 2596 | if (FName == "CGBitmapContextCreate" || |
| 2597 | FName == "CGBitmapContextCreateWithData" || |
| 2598 | FName == "CVPixelBufferCreateWithBytes" || |
| 2599 | FName == "CVPixelBufferCreateWithPlanarBytes" || |
| 2600 | FName == "OSAtomicEnqueue") { |
Anna Zaks | a4bc5e1 | 2013-05-31 23:47:32 +0000 | [diff] [blame] | 2601 | return true; |
Jordan Rose | 742920c | 2012-07-02 19:27:35 +0000 | [diff] [blame] | 2602 | } |
| 2603 | |
Anna Zaks | 03f4833 | 2016-01-06 00:32:56 +0000 | [diff] [blame] | 2604 | if (FName == "postEvent" && |
| 2605 | FD->getQualifiedNameAsString() == "QCoreApplication::postEvent") { |
| 2606 | return true; |
| 2607 | } |
| 2608 | |
| 2609 | if (FName == "postEvent" && |
| 2610 | FD->getQualifiedNameAsString() == "QCoreApplication::postEvent") { |
| 2611 | return true; |
| 2612 | } |
| 2613 | |
Artem Dergachev | 85c9211 | 2016-12-16 12:21:55 +0000 | [diff] [blame] | 2614 | if (FName == "connectImpl" && |
| 2615 | FD->getQualifiedNameAsString() == "QObject::connectImpl") { |
| 2616 | return true; |
| 2617 | } |
| 2618 | |
Jordan Rose | 7ab0182 | 2012-07-02 19:27:51 +0000 | [diff] [blame] | 2619 | // Handle cases where we know a buffer's /address/ can escape. |
| 2620 | // Note that the above checks handle some special cases where we know that |
| 2621 | // even though the address escapes, it's still our responsibility to free the |
| 2622 | // buffer. |
| 2623 | if (Call->argumentsMayEscape()) |
Anna Zaks | a4bc5e1 | 2013-05-31 23:47:32 +0000 | [diff] [blame] | 2624 | return true; |
Jordan Rose | 742920c | 2012-07-02 19:27:35 +0000 | [diff] [blame] | 2625 | |
| 2626 | // Otherwise, assume that the function does not free memory. |
| 2627 | // Most system calls do not free the memory. |
Anna Zaks | a4bc5e1 | 2013-05-31 23:47:32 +0000 | [diff] [blame] | 2628 | return false; |
Anna Zaks | 3d34834 | 2012-02-14 21:55:24 +0000 | [diff] [blame] | 2629 | } |
| 2630 | |
Anna Zaks | 333481b | 2013-03-28 23:15:29 +0000 | [diff] [blame] | 2631 | static bool retTrue(const RefState *RS) { |
| 2632 | return true; |
| 2633 | } |
| 2634 | |
| 2635 | static bool checkIfNewOrNewArrayFamily(const RefState *RS) { |
| 2636 | return (RS->getAllocationFamily() == AF_CXXNewArray || |
| 2637 | RS->getAllocationFamily() == AF_CXXNew); |
| 2638 | } |
| 2639 | |
Anna Zaks | dc15415 | 2012-12-20 00:38:25 +0000 | [diff] [blame] | 2640 | ProgramStateRef MallocChecker::checkPointerEscape(ProgramStateRef State, |
| 2641 | const InvalidatedSymbols &Escaped, |
Anna Zaks | acdc13c | 2013-02-07 23:05:43 +0000 | [diff] [blame] | 2642 | const CallEvent *Call, |
| 2643 | PointerEscapeKind Kind) const { |
Anna Zaks | 333481b | 2013-03-28 23:15:29 +0000 | [diff] [blame] | 2644 | return checkPointerEscapeAux(State, Escaped, Call, Kind, &retTrue); |
| 2645 | } |
| 2646 | |
| 2647 | ProgramStateRef MallocChecker::checkConstPointerEscape(ProgramStateRef State, |
| 2648 | const InvalidatedSymbols &Escaped, |
| 2649 | const CallEvent *Call, |
| 2650 | PointerEscapeKind Kind) const { |
| 2651 | return checkPointerEscapeAux(State, Escaped, Call, Kind, |
| 2652 | &checkIfNewOrNewArrayFamily); |
| 2653 | } |
| 2654 | |
| 2655 | ProgramStateRef MallocChecker::checkPointerEscapeAux(ProgramStateRef State, |
| 2656 | const InvalidatedSymbols &Escaped, |
| 2657 | const CallEvent *Call, |
| 2658 | PointerEscapeKind Kind, |
| 2659 | bool(*CheckRefState)(const RefState*)) const { |
Jordan Rose | 613f3c0 | 2013-03-09 00:59:10 +0000 | [diff] [blame] | 2660 | // If we know that the call does not free memory, or we want to process the |
| 2661 | // call later, keep tracking the top level arguments. |
Craig Topper | 0dbb783 | 2014-05-27 02:45:47 +0000 | [diff] [blame] | 2662 | SymbolRef EscapingSymbol = nullptr; |
Jordan Rose | 757fbb0 | 2013-05-10 17:07:16 +0000 | [diff] [blame] | 2663 | if (Kind == PSK_DirectEscapeOnCall && |
Anna Zaks | 8ebeb64 | 2013-06-08 00:29:29 +0000 | [diff] [blame] | 2664 | !mayFreeAnyEscapedMemoryOrIsModeledExplicitly(Call, State, |
| 2665 | EscapingSymbol) && |
Anna Zaks | a4bc5e1 | 2013-05-31 23:47:32 +0000 | [diff] [blame] | 2666 | !EscapingSymbol) { |
Anna Zaks | 3d34834 | 2012-02-14 21:55:24 +0000 | [diff] [blame] | 2667 | return State; |
Anna Zaks | acdc13c | 2013-02-07 23:05:43 +0000 | [diff] [blame] | 2668 | } |
Anna Zaks | 3d34834 | 2012-02-14 21:55:24 +0000 | [diff] [blame] | 2669 | |
Anna Zaks | dc15415 | 2012-12-20 00:38:25 +0000 | [diff] [blame] | 2670 | for (InvalidatedSymbols::const_iterator I = Escaped.begin(), |
Anna Zaks | 333481b | 2013-03-28 23:15:29 +0000 | [diff] [blame] | 2671 | E = Escaped.end(); |
| 2672 | I != E; ++I) { |
Anna Zaks | bb1ef90 | 2012-02-11 21:02:35 +0000 | [diff] [blame] | 2673 | SymbolRef sym = *I; |
Anna Zaks | dc15415 | 2012-12-20 00:38:25 +0000 | [diff] [blame] | 2674 | |
Anna Zaks | a4bc5e1 | 2013-05-31 23:47:32 +0000 | [diff] [blame] | 2675 | if (EscapingSymbol && EscapingSymbol != sym) |
| 2676 | continue; |
Ted Kremenek | 3a0678e | 2015-09-08 03:50:52 +0000 | [diff] [blame] | 2677 | |
Anna Zaks | 0d6989b | 2012-06-22 02:04:31 +0000 | [diff] [blame] | 2678 | if (const RefState *RS = State->get<RegionState>(sym)) { |
Anton Yartsev | b50f4ba | 2015-04-14 14:18:04 +0000 | [diff] [blame] | 2679 | if ((RS->isAllocated() || RS->isAllocatedOfSizeZero()) && |
| 2680 | CheckRefState(RS)) { |
Anna Zaks | 23a6201 | 2012-08-09 00:42:24 +0000 | [diff] [blame] | 2681 | State = State->remove<RegionState>(sym); |
Anna Zaks | 93a21a8 | 2013-04-09 00:30:28 +0000 | [diff] [blame] | 2682 | State = State->set<RegionState>(sym, RefState::getEscaped(RS)); |
| 2683 | } |
Anna Zaks | 0d6989b | 2012-06-22 02:04:31 +0000 | [diff] [blame] | 2684 | } |
Anna Zaks | bb1ef90 | 2012-02-11 21:02:35 +0000 | [diff] [blame] | 2685 | } |
Anna Zaks | 3d34834 | 2012-02-14 21:55:24 +0000 | [diff] [blame] | 2686 | return State; |
Ted Kremenek | d21139a | 2010-07-31 01:52:11 +0000 | [diff] [blame] | 2687 | } |
Argyrios Kyrtzidis | 183f0fb | 2011-02-28 01:26:35 +0000 | [diff] [blame] | 2688 | |
Jordy Rose | bf38f20 | 2012-03-18 07:43:35 +0000 | [diff] [blame] | 2689 | static SymbolRef findFailedReallocSymbol(ProgramStateRef currState, |
| 2690 | ProgramStateRef prevState) { |
Jordan Rose | 0c153cb | 2012-11-02 01:54:06 +0000 | [diff] [blame] | 2691 | ReallocPairsTy currMap = currState->get<ReallocPairs>(); |
| 2692 | ReallocPairsTy prevMap = prevState->get<ReallocPairs>(); |
Jordy Rose | bf38f20 | 2012-03-18 07:43:35 +0000 | [diff] [blame] | 2693 | |
Jordan Rose | 0c153cb | 2012-11-02 01:54:06 +0000 | [diff] [blame] | 2694 | for (ReallocPairsTy::iterator I = prevMap.begin(), E = prevMap.end(); |
Jordy Rose | bf38f20 | 2012-03-18 07:43:35 +0000 | [diff] [blame] | 2695 | I != E; ++I) { |
| 2696 | SymbolRef sym = I.getKey(); |
| 2697 | if (!currMap.lookup(sym)) |
| 2698 | return sym; |
| 2699 | } |
| 2700 | |
Craig Topper | 0dbb783 | 2014-05-27 02:45:47 +0000 | [diff] [blame] | 2701 | return nullptr; |
Jordy Rose | bf38f20 | 2012-03-18 07:43:35 +0000 | [diff] [blame] | 2702 | } |
| 2703 | |
David Blaikie | 0a0c275 | 2017-01-05 17:26:53 +0000 | [diff] [blame] | 2704 | std::shared_ptr<PathDiagnosticPiece> MallocChecker::MallocBugVisitor::VisitNode( |
| 2705 | const ExplodedNode *N, const ExplodedNode *PrevN, BugReporterContext &BRC, |
| 2706 | BugReport &BR) { |
Jordy Rose | bf38f20 | 2012-03-18 07:43:35 +0000 | [diff] [blame] | 2707 | ProgramStateRef state = N->getState(); |
| 2708 | ProgramStateRef statePrev = PrevN->getState(); |
| 2709 | |
| 2710 | const RefState *RS = state->get<RegionState>(Sym); |
| 2711 | const RefState *RSPrev = statePrev->get<RegionState>(Sym); |
Anna Zaks | 52242a6 | 2012-08-03 18:30:18 +0000 | [diff] [blame] | 2712 | if (!RS) |
Craig Topper | 0dbb783 | 2014-05-27 02:45:47 +0000 | [diff] [blame] | 2713 | return nullptr; |
Anna Zaks | 2b5bb97 | 2012-02-09 06:25:51 +0000 | [diff] [blame] | 2714 | |
Gabor Horvath | 6ee4f90 | 2016-08-18 07:54:50 +0000 | [diff] [blame] | 2715 | const Stmt *S = PathDiagnosticLocation::getStmt(N); |
Anna Zaks | 9eb7bc8 | 2012-02-16 22:26:07 +0000 | [diff] [blame] | 2716 | if (!S) |
Craig Topper | 0dbb783 | 2014-05-27 02:45:47 +0000 | [diff] [blame] | 2717 | return nullptr; |
Anna Zaks | 2b5bb97 | 2012-02-09 06:25:51 +0000 | [diff] [blame] | 2718 | |
Jordan Rose | 681cce9 | 2012-07-10 22:07:42 +0000 | [diff] [blame] | 2719 | // FIXME: We will eventually need to handle non-statement-based events |
| 2720 | // (__attribute__((cleanup))). |
| 2721 | |
Anna Zaks | 2b5bb97 | 2012-02-09 06:25:51 +0000 | [diff] [blame] | 2722 | // Find out if this is an interesting point and what is the kind. |
Gabor Horvath | 6ee4f90 | 2016-08-18 07:54:50 +0000 | [diff] [blame] | 2723 | const char *Msg = nullptr; |
| 2724 | StackHintGeneratorForSymbol *StackHint = nullptr; |
Anna Zaks | 9eb7bc8 | 2012-02-16 22:26:07 +0000 | [diff] [blame] | 2725 | if (Mode == Normal) { |
Anna Zaks | 1ff57d5 | 2012-03-15 21:13:02 +0000 | [diff] [blame] | 2726 | if (isAllocated(RS, RSPrev, S)) { |
Anna Zaks | 9eb7bc8 | 2012-02-16 22:26:07 +0000 | [diff] [blame] | 2727 | Msg = "Memory is allocated"; |
Anna Zaks | a7f457a | 2012-03-16 23:44:28 +0000 | [diff] [blame] | 2728 | StackHint = new StackHintGeneratorForSymbol(Sym, |
| 2729 | "Returned allocated memory"); |
Anna Zaks | 1ff57d5 | 2012-03-15 21:13:02 +0000 | [diff] [blame] | 2730 | } else if (isReleased(RS, RSPrev, S)) { |
Anna Zaks | 9eb7bc8 | 2012-02-16 22:26:07 +0000 | [diff] [blame] | 2731 | Msg = "Memory is released"; |
Anna Zaks | a7f457a | 2012-03-16 23:44:28 +0000 | [diff] [blame] | 2732 | StackHint = new StackHintGeneratorForSymbol(Sym, |
Anna Zaks | e4cfcd4 | 2013-04-16 00:22:55 +0000 | [diff] [blame] | 2733 | "Returning; memory was released"); |
Anna Zaks | 0d6989b | 2012-06-22 02:04:31 +0000 | [diff] [blame] | 2734 | } else if (isRelinquished(RS, RSPrev, S)) { |
Alp Toker | 5faf0c0 | 2013-12-02 03:50:25 +0000 | [diff] [blame] | 2735 | Msg = "Memory ownership is transferred"; |
Anna Zaks | 0d6989b | 2012-06-22 02:04:31 +0000 | [diff] [blame] | 2736 | StackHint = new StackHintGeneratorForSymbol(Sym, ""); |
Anna Zaks | 1ff57d5 | 2012-03-15 21:13:02 +0000 | [diff] [blame] | 2737 | } else if (isReallocFailedCheck(RS, RSPrev, S)) { |
Anna Zaks | 9eb7bc8 | 2012-02-16 22:26:07 +0000 | [diff] [blame] | 2738 | Mode = ReallocationFailed; |
| 2739 | Msg = "Reallocation failed"; |
Anna Zaks | cba4f29 | 2012-03-16 23:24:20 +0000 | [diff] [blame] | 2740 | StackHint = new StackHintGeneratorForReallocationFailed(Sym, |
Anna Zaks | a7f457a | 2012-03-16 23:44:28 +0000 | [diff] [blame] | 2741 | "Reallocation failed"); |
Jordy Rose | bf38f20 | 2012-03-18 07:43:35 +0000 | [diff] [blame] | 2742 | |
Jordy Rose | 21ff76e | 2012-03-24 03:15:09 +0000 | [diff] [blame] | 2743 | if (SymbolRef sym = findFailedReallocSymbol(state, statePrev)) { |
| 2744 | // Is it possible to fail two reallocs WITHOUT testing in between? |
| 2745 | assert((!FailedReallocSymbol || FailedReallocSymbol == sym) && |
| 2746 | "We only support one failed realloc at a time."); |
Jordy Rose | bf38f20 | 2012-03-18 07:43:35 +0000 | [diff] [blame] | 2747 | BR.markInteresting(sym); |
Jordy Rose | 21ff76e | 2012-03-24 03:15:09 +0000 | [diff] [blame] | 2748 | FailedReallocSymbol = sym; |
| 2749 | } |
Anna Zaks | 9eb7bc8 | 2012-02-16 22:26:07 +0000 | [diff] [blame] | 2750 | } |
| 2751 | |
| 2752 | // We are in a special mode if a reallocation failed later in the path. |
| 2753 | } else if (Mode == ReallocationFailed) { |
Jordy Rose | 21ff76e | 2012-03-24 03:15:09 +0000 | [diff] [blame] | 2754 | assert(FailedReallocSymbol && "No symbol to look for."); |
Anna Zaks | 9eb7bc8 | 2012-02-16 22:26:07 +0000 | [diff] [blame] | 2755 | |
Jordy Rose | 21ff76e | 2012-03-24 03:15:09 +0000 | [diff] [blame] | 2756 | // Is this is the first appearance of the reallocated symbol? |
| 2757 | if (!statePrev->get<RegionState>(FailedReallocSymbol)) { |
Jordy Rose | 21ff76e | 2012-03-24 03:15:09 +0000 | [diff] [blame] | 2758 | // We're at the reallocation point. |
| 2759 | Msg = "Attempt to reallocate memory"; |
| 2760 | StackHint = new StackHintGeneratorForSymbol(Sym, |
| 2761 | "Returned reallocated memory"); |
Craig Topper | 0dbb783 | 2014-05-27 02:45:47 +0000 | [diff] [blame] | 2762 | FailedReallocSymbol = nullptr; |
Jordy Rose | 21ff76e | 2012-03-24 03:15:09 +0000 | [diff] [blame] | 2763 | Mode = Normal; |
| 2764 | } |
Anna Zaks | 9eb7bc8 | 2012-02-16 22:26:07 +0000 | [diff] [blame] | 2765 | } |
| 2766 | |
Anna Zaks | 2b5bb97 | 2012-02-09 06:25:51 +0000 | [diff] [blame] | 2767 | if (!Msg) |
Craig Topper | 0dbb783 | 2014-05-27 02:45:47 +0000 | [diff] [blame] | 2768 | return nullptr; |
Anna Zaks | cba4f29 | 2012-03-16 23:24:20 +0000 | [diff] [blame] | 2769 | assert(StackHint); |
Anna Zaks | 2b5bb97 | 2012-02-09 06:25:51 +0000 | [diff] [blame] | 2770 | |
| 2771 | // Generate the extra diagnostic. |
Anna Zaks | 9eb7bc8 | 2012-02-16 22:26:07 +0000 | [diff] [blame] | 2772 | PathDiagnosticLocation Pos(S, BRC.getSourceManager(), |
Anna Zaks | 2b5bb97 | 2012-02-09 06:25:51 +0000 | [diff] [blame] | 2773 | N->getLocationContext()); |
David Blaikie | 0a0c275 | 2017-01-05 17:26:53 +0000 | [diff] [blame] | 2774 | return std::make_shared<PathDiagnosticEventPiece>(Pos, Msg, true, StackHint); |
Anna Zaks | 2b5bb97 | 2012-02-09 06:25:51 +0000 | [diff] [blame] | 2775 | } |
| 2776 | |
Anna Zaks | 263b7e0 | 2012-05-02 00:05:20 +0000 | [diff] [blame] | 2777 | void MallocChecker::printState(raw_ostream &Out, ProgramStateRef State, |
| 2778 | const char *NL, const char *Sep) const { |
| 2779 | |
| 2780 | RegionStateTy RS = State->get<RegionState>(); |
| 2781 | |
Ted Kremenek | 6fcefb5 | 2013-01-03 01:30:12 +0000 | [diff] [blame] | 2782 | if (!RS.isEmpty()) { |
Anton Yartsev | 6a61922 | 2014-02-17 18:25:34 +0000 | [diff] [blame] | 2783 | Out << Sep << "MallocChecker :" << NL; |
Ted Kremenek | 6fcefb5 | 2013-01-03 01:30:12 +0000 | [diff] [blame] | 2784 | for (RegionStateTy::iterator I = RS.begin(), E = RS.end(); I != E; ++I) { |
Anton Yartsev | 6a61922 | 2014-02-17 18:25:34 +0000 | [diff] [blame] | 2785 | const RefState *RefS = State->get<RegionState>(I.getKey()); |
| 2786 | AllocationFamily Family = RefS->getAllocationFamily(); |
Anton Yartsev | 4eb394d | 2015-03-07 00:31:53 +0000 | [diff] [blame] | 2787 | Optional<MallocChecker::CheckKind> CheckKind = getCheckIfTracked(Family); |
Anton Yartsev | 2487dd6 | 2015-03-10 22:24:21 +0000 | [diff] [blame] | 2788 | if (!CheckKind.hasValue()) |
| 2789 | CheckKind = getCheckIfTracked(Family, true); |
Anton Yartsev | 4eb394d | 2015-03-07 00:31:53 +0000 | [diff] [blame] | 2790 | |
Ted Kremenek | 6fcefb5 | 2013-01-03 01:30:12 +0000 | [diff] [blame] | 2791 | I.getKey()->dumpToStream(Out); |
| 2792 | Out << " : "; |
| 2793 | I.getData().dump(Out); |
Anton Yartsev | 6a61922 | 2014-02-17 18:25:34 +0000 | [diff] [blame] | 2794 | if (CheckKind.hasValue()) |
| 2795 | Out << " (" << CheckNames[*CheckKind].getName() << ")"; |
Ted Kremenek | 6fcefb5 | 2013-01-03 01:30:12 +0000 | [diff] [blame] | 2796 | Out << NL; |
| 2797 | } |
| 2798 | } |
Anna Zaks | 263b7e0 | 2012-05-02 00:05:20 +0000 | [diff] [blame] | 2799 | } |
Anna Zaks | 2b5bb97 | 2012-02-09 06:25:51 +0000 | [diff] [blame] | 2800 | |
Anna Zaks | e4cfcd4 | 2013-04-16 00:22:55 +0000 | [diff] [blame] | 2801 | void ento::registerNewDeleteLeaksChecker(CheckerManager &mgr) { |
| 2802 | registerCStringCheckerBasic(mgr); |
Alexander Kornienko | 4aca9b1 | 2014-02-11 21:49:21 +0000 | [diff] [blame] | 2803 | MallocChecker *checker = mgr.registerChecker<MallocChecker>(); |
Gabor Horvath | e40c71c | 2015-03-04 17:59:34 +0000 | [diff] [blame] | 2804 | checker->IsOptimistic = mgr.getAnalyzerOptions().getBooleanOption( |
| 2805 | "Optimistic", false, checker); |
Alexander Kornienko | 4aca9b1 | 2014-02-11 21:49:21 +0000 | [diff] [blame] | 2806 | checker->ChecksEnabled[MallocChecker::CK_NewDeleteLeaksChecker] = true; |
| 2807 | checker->CheckNames[MallocChecker::CK_NewDeleteLeaksChecker] = |
| 2808 | mgr.getCurrentCheckName(); |
Ted Kremenek | 3a0678e | 2015-09-08 03:50:52 +0000 | [diff] [blame] | 2809 | // We currently treat NewDeleteLeaks checker as a subchecker of NewDelete |
Anna Zaks | e4cfcd4 | 2013-04-16 00:22:55 +0000 | [diff] [blame] | 2810 | // checker. |
Anton Yartsev | 6a61922 | 2014-02-17 18:25:34 +0000 | [diff] [blame] | 2811 | if (!checker->ChecksEnabled[MallocChecker::CK_NewDeleteChecker]) |
Alexander Kornienko | 4aca9b1 | 2014-02-11 21:49:21 +0000 | [diff] [blame] | 2812 | checker->ChecksEnabled[MallocChecker::CK_NewDeleteChecker] = true; |
Anna Zaks | e4cfcd4 | 2013-04-16 00:22:55 +0000 | [diff] [blame] | 2813 | } |
Anton Yartsev | 7af0aa8 | 2013-04-12 23:25:40 +0000 | [diff] [blame] | 2814 | |
Alexander Kornienko | 4aca9b1 | 2014-02-11 21:49:21 +0000 | [diff] [blame] | 2815 | #define REGISTER_CHECKER(name) \ |
| 2816 | void ento::register##name(CheckerManager &mgr) { \ |
| 2817 | registerCStringCheckerBasic(mgr); \ |
| 2818 | MallocChecker *checker = mgr.registerChecker<MallocChecker>(); \ |
Gabor Horvath | e40c71c | 2015-03-04 17:59:34 +0000 | [diff] [blame] | 2819 | checker->IsOptimistic = mgr.getAnalyzerOptions().getBooleanOption( \ |
| 2820 | "Optimistic", false, checker); \ |
Alexander Kornienko | 4aca9b1 | 2014-02-11 21:49:21 +0000 | [diff] [blame] | 2821 | checker->ChecksEnabled[MallocChecker::CK_##name] = true; \ |
| 2822 | checker->CheckNames[MallocChecker::CK_##name] = mgr.getCurrentCheckName(); \ |
| 2823 | } |
Anna Zaks | cd37bf4 | 2012-02-08 23:16:52 +0000 | [diff] [blame] | 2824 | |
Gabor Horvath | e40c71c | 2015-03-04 17:59:34 +0000 | [diff] [blame] | 2825 | REGISTER_CHECKER(MallocChecker) |
Anton Yartsev | 13df036 | 2013-03-25 01:35:45 +0000 | [diff] [blame] | 2826 | REGISTER_CHECKER(NewDeleteChecker) |
Anton Yartsev | 0578959 | 2013-03-28 17:05:19 +0000 | [diff] [blame] | 2827 | REGISTER_CHECKER(MismatchedDeallocatorChecker) |